[00:00:02] what is wikimedia-ops? [00:00:17] apparently not what we want :) [00:00:18] irc operators [00:00:22] jdlrobson: but i've also already bothered ops in IRC - i was asking if you could bug them in real life [00:00:26] in the office [00:00:42] i'll try Leslie [00:00:54] jdlrobson: she definitely responds well tow hiskey [00:01:13] for mobile varnish cache flushes, at least [00:01:20] ryan lane is doing it now [00:01:51] done [00:01:52] thanks :) [00:02:05] not sure tfinc about juliusz - you'll have to ask him - maybe he's in the zone [00:02:16] k [00:02:28] and look at that, now it works :) [00:02:53] ok jdlrobson, jcmish looks good now. feel free to tweet about it :) [00:02:59] awjr: done [00:03:05] now.. how do we solve this html problem.. [00:03:11] hehe woohooo [00:03:19] get RL enabled [00:03:21] i mean, fully [00:03:36] that will solve the problem of resource timestamps getting cached in the html [00:03:59] we will still need to occasionally flush mobile varnish cache when html structure changes, but that happens very rarely these days [00:04:37] brion: i spazzed on uploading the last ipa for iOS on http://www.mediawiki.org/wiki/Mobile/Release_history#Wikipedia .. but since no one care i'm thinking just shouldn't bother. does anyone use our official ipa ? [00:04:46] awjr: jdlrobson I need to go pick up my son and get him over to band [00:05:00] but I will continue tweeting and replying to folx when I'm done [00:05:02] awjr: but this was just a js change - we'll need to do this for every js change [00:05:03] tfinc: in theory jail breakers might use it, otherwise there's no real way to install the release .ipa by hand i think [00:05:06] cool jcmish thanks [00:05:12] no? [00:05:17] mainly i just like having backups of those files :) [00:05:18] brion: its missing the playbook releases [00:05:36] awjr: I'll also finish up the tickets, I'm flushing out AC [00:05:40] tfinc: yeah i'll see if i can turn up the previous release, but i'll add my next release there once i've got the keys cleared up [00:05:46] awesome jcmish :) [00:06:00] brion: thats such a tiny % that i don't think we should bother [00:06:14] no one has ever asked for them while we know people use the apk's [00:06:18] jdlrobson: i dont know, tbh. this doesn't happen all the time, or if it does, we don't always notice it [00:06:27] still, if we have to revert a version -- nice for us to have the .ipa around [00:06:35] theoretically it should happen all the time.. [00:06:49] we're serving old css and js to everyone until the page cache gets invalidated [00:06:53] as the timestamp is in the html [00:07:26] brion: you mean for us to test upgrades ? [00:07:28] but the pages get purged when they're edited; it's possible that we just not notice when we're testing [00:07:40] s/not notice/dont notice [00:07:57] tfinc: well if we fail to test an upgrade properly and have to revert to the previous release. ;) [00:08:06] though…. may not be able to just put up the old .ipa [00:08:09] maybe not worth uploading them [00:08:10] *shrug* [00:08:28] brion, jdlrobson why did we disable resource loader for mobile in production? [00:08:48] and can we enable it now? [00:08:50] awjr: it was loading modules that it shouldn't have, possibly because (some?) of the wikis hadn't actually been running the updated core code [00:08:56] it may or may not be safe to turn it back on, not sure [00:09:00] o_O [00:09:02] jeepers [00:09:15] indeed [00:09:16] brion: oh was it because of the different deployment branches being run simultaneously? [00:09:26] that was my thought at the time at least [00:09:28] and our changes were in the newer one but not the older one? [00:09:36] but if it did it on en.wikipedia.org then it might not be the same bug [00:09:41] hrm [00:09:45] i'm not 100% sure if it did or not [00:09:48] maybe we should try enabling it during the next deployment [00:09:57] awjr: brion we don't have a true resource loader environment [00:10:08] jdlrobson: we have part of one, we just don't use it for much yet :D [00:10:13] some things were expecting wgLanguageCode [00:10:26] also https://bugzilla.wikimedia.org/show_bug.cgi?id=41341 [00:10:27] well those were probably modules that shouldn't have loaded [00:10:37] so brion I guess https://bugzilla.wikimedia.org/show_bug.cgi?id=41341 is the core problem? [00:10:58] i think yeah [00:11:22] so awjr that needs to be fixed then we can probably turn it back on [00:11:41] i am confused about what the actual problem is [00:11:47] jdlrobson, brion ^ [00:12:32] awjr: so as far as we know, problem was that some wikis had old core code that didn't understand RL's new "target" parameter, so were loading up all sorts of gadgets and things that aren't mobile-ready [00:12:46] oh ok, yes that makes sense [00:12:49] which should no longer be a problem [00:12:53] "should" :) [00:12:55] we hope [00:12:57] right :) [00:13:03] so let's see what happens next week :) [00:13:16] :DD [00:13:39] afaik all wikis now are runing php-1.21wmf5 [00:14:00] although next week it will be 1.21wmf6 and 1.21wmf5; but both those branches should have the RL updates for target [00:14:07] yeah [00:25:48] New review: JGonera; "Personally, I'm against onevar. Can we talk about this? ;)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/37138 [00:36:17] i'm thinking of heading home early due to that 7-8 interview. does anyone need anything fro me ? [00:36:54] nope go ahead [00:37:27] i'm about to head out too since i need to grab stuff from my old computer at home to finish up the playbook build and test this css tweak on android tablets [01:35:37] New review: JGonera; "I guess I'll agree because that's our coding style. I still don't like it, mainly because of the ind..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/37138 [17:36:22] * awjr waves to MaxSem [17:36:32] MaxSem: did you wind up enabling geodata/ [17:36:38] hey awjr [17:37:08] I tried today, but my InitialiseSettings-fu wasn't good enough so I reverted [17:37:14] doh [17:37:27] MaxSem: yeah i saw the commits and was curious [17:37:41] by the way - turns out 20% is officially dead [17:37:49] https://www.mediawiki.org/wiki/Mentorship_programs/LevelUp [17:37:53] oh i thought that wasn't until january [17:37:57] https://www.mediawiki.org/wiki/20%25 [17:38:09] now you're supposed to do matchmaking [17:38:35] oh i see [17:40:18] i dont think i totally understnd what 'matchmaking' is [17:43:00] MaxSem: sumana confirmed 20% is over [17:49:58] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37166 [17:50:10] MaxSem re getting MobileFrontend on beta labs - im wondering whether or not we should try to schedule some dedicated time from someone from ops to help us out. what do you think? [17:50:30] someone from labs, you mean? [17:50:54] main problem here is that squid config isn't under version control [17:51:02] no, i mean ops specifically [17:51:15] so what do we need from ops? [17:51:21] i think technically it is, just not publicly accessible [17:51:45] MaxSem: im not sure, i guess that's part of what im asking. do we have enough knowhow to make everything run w/o support from ops [17:51:58] mmm [17:52:21] I don't know how beta cluste is set up [17:52:33] hashar can help us with that part [17:55:28] New patchset: Jdlrobson; "add an experimental mode to MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37288 [17:57:52] hey brion are we doing another iOS app push to correct the landscape issue? [17:57:56] or did that already happen? [17:58:14] jcmish: did we want to run some betas past humans first? [17:58:34] no sir I only did that for Android [17:58:40] but I can [17:59:09] awjr: were on the chrome box again today. worked perfectly this time [17:59:19] nice! [18:00:32] brion: standup! [18:00:37] joinoing now [18:18:16] jdlrobson, so what's your problem with https://gerrit.wikimedia.org/r/#/c/37323/ ? [18:29:39] New review: Jdlrobson; "Minor question about placement - I'm worried the menu will get very big without sparingly adding opt..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37163 [18:43:34] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/EHh9Sg [18:43:34] WikipediaMobile/master 2c3ebe0 Brion Vibber: Apply overflow-y: auto scrolling by default, only disable it on Android.... [18:43:34] WikipediaMobile/master 60b3f61 Brion Vibber: Merge pull request #318 from brion/scroll-change... [18:43:42] jdlrobson, I've replied at https://gerrit.wikimedia.org/r/#/c/37323/ [18:43:53] Project WikipediaMobile - Nightly builds build #471: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/471/ [18:43:53] Brion VIBBER: Apply overflow-y: auto scrolling by default, only disable it on Android. [18:46:28] tfinc: just realized i'm double-booked for 11:30 -- carry on w/diederik without me so i can do the interview, if you don't mind [18:46:54] i can check in with dr. dee another time [18:54:30] \o/ https://twitter.com/ZachHOfficial/status/277109600745029633 [19:29:13] hmm, is this a new bug? settings page options don't toggle for this user (not sure what kind of phone that is, but the OS is android 4.1.1): http://meta.wikimedia.org/wiki/Talk:Mobile_projects/Beta#TF700 [19:42:42] Maryana: i have your usb stick on my desk [19:43:19] thanks! i haven't used that thing in like 2 years, and all of a sudden i needed it twice yesterday [19:43:34] i hope it's not all glittery... [19:49:53] jdlrobson, how can I repro https://bugzilla.wikimedia.org/show_bug.cgi?id=42492 [19:50:31] Maryana: i'm sorry :( [19:50:43] MaxSem: so the best way is to opt out of beta [19:50:43] jdlrobson, https://en.wikipedia.org/w/api.php?action=mobileview&format=txtfm&page=Barack%20Obama§ions=all&prop=text&noimages= looks ok [19:50:49] whaaaa? [19:50:58] and disable images [19:51:28] hummm [19:51:29] 1s [19:53:10] MaxSem: it looks like another bug… http://en.m.wikipedia.org/wiki/Supernatural_(U.S._TV_series)#section_1 should have an image but no alt text is showing up... [19:53:21] "Creator Eric Kripke feels that America's urban legends are "every bit as fleshed out as any world mythologies" [19:54:36] jdlrobson: the alt text is "" on that image [19:54:39] MaxSem: it just gets completely scrubbed from the look of it [19:54:48] brion: it should still create a link to the image [19:54:52] hmm [19:55:00] So this is actually a problem in production [19:56:49] whee [19:56:58] brion MaxSem: to be exact go to http://en.m.wikipedia.org/wiki/Barack_Obama#section_1 see "Obama with his half-sister" - disable images - boom - that disappears completely [19:58:03] yeah the whole div disappears. weird... [19:58:12] MaxSem: i'll close that bug and create a new bug [19:58:25] why? [19:58:40] to avoid confusion [19:58:54] i can write on the same bug if you prefer [19:58:56] ^ MaxSem ? [19:59:16] btw jdlrobson - MobileFormatter doesn't understand sup[style*="help"] [20:01:40] $removals['CLASS'][] = "thumb tright"; [20:01:40] $removals['CLASS'][] = "thumb tleft"; [20:02:04] that strikes me as suspicious [20:02:18] it was there since forever [20:02:42] is the bug new or has it been there since forever too? [20:06:19] HtmlFormatter.php lines 183-193 [20:07:12] so if we have an image, we take its alt or "image has no description" if none and put it into a span [20:07:33] and replace with it [20:07:58] MaxSem: not sure why that is there - goes back to the svn days 14907303 [20:08:24] 14907303? [20:08:32] git log 14907303 [20:08:48] i'd be happy to remove all undocumented removals [20:09:46] ie. everything other than '#search','#wpDiff', '#wpPreview, '.noprint', '#ogg_player_1', '#ogg_player_2','.nomobile', [20:10:06] hahaha unit test: open https://m.mediawiki.org/wiki/Help:Images with images disabled:P [20:10:10] they raise too many questions [20:10:44] jdlrobson, we can always reverse engineer preilly [20:12:36] so yeah, looks like images with thumb or frame are removed [20:13:02] and this was there since dinosaurs walked the earth [20:13:05] huh [20:13:12] how strange [20:13:17] brb grabbing lunch and then interview [20:48:33] did the current android sdk drop support for emulating 2.2 and below? wtf… i can't find system images in the sdk manager [20:49:02] hmm, still lets me select 2.1 and 2.2 when creating an avd... [20:54:14] Maryana: https://bugzilla.wikimedia.org/show_bug.cgi?id=42744#c2 [20:54:54] also omg https://twitter.com/Cheesyhel/status/277033958192074753/photo/1 [20:55:07] yeah, we should talk about this on tuesday at the big mobile navigation meeting [20:55:39] wat [20:56:02] Also amazing http://en.m.wikipedia.org/wiki/File:Theodor_Kittelsen-En_uheldig_bj%C3%B8rnejakt.jpg [21:05:33] ok good news: i can reproduce the android 2.2 HTTPS failure in the emulator by making a release build [21:05:47] so i should be able to make a narrower test case and submit it either to cordova or android :P [21:14:58] New patchset: Jdlrobson; "quick fix for article history problem (bug 42835)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37497 [21:24:38] New patchset: Jdlrobson; "enable the history page in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37500 [21:44:31] New patchset: MaxSem; "Bug 42492 - don't be overzealous with image removal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37514 [21:44:36] jdlrobson, brion ^^^ [21:45:14] New review: Brion VIBBER; "Looks right but I haven't tested it yet. :D" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/37514 [21:47:25] New patchset: JGonera; "Remove dead code from SkinMobile, no need to pass $out" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37519 [22:05:15] brion: whats the time window for the microsoft in office interviews ? [22:06:18] they should arrive 9ish tuesday [22:06:26] not sure how long they'll be there, couple hoursish? [22:06:28] ouch .. 9am .. i see the invite now [22:06:32] yeah early [22:06:37] it'll be pretty empty ;) [22:06:42] i made no commitment that i'll be there [22:06:47] s/made/make [22:06:49] no worries either way :) [22:18:12] New review: Jdlrobson; "Tested and verified." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37514 [22:18:13] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37514 [22:25:42] can't repro the ssl bug in a minimal test case…. sigh [22:26:27] i'll try ripping things out of the app instead of building up from small [22:38:55] awjr: colloquy tells me you're offline and won't let me respond to your pm for some reason [22:39:14] but the tl;dr is i'm on it :) [22:39:23] sweet :) [22:39:35] thanks Maryana [22:39:45] anytime [22:43:29] jdlrobson: pm [22:49:15] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37040 [23:01:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37158 [23:03:34] jdlrobson: https://gerrit.wikimedia.org/r/#/c/37175/ and associated changes are for story 250, right? [23:03:47] (comments say 150) [23:04:51] awjr, jdlrobson: i went to find howie for the dragons disclaimer language, and he was still interviewing. can y'all wait for him to finish up (at 3:30)? [23:05:02] or do you need something now? [23:05:38] up to jdlrobson [23:05:52] dragons? O_O [23:06:04] awjr: yeh my fault i'll fix up [23:06:07] forgot about that [23:06:10] no worries jdlrobson [23:06:18] 1s i'll do that now [23:06:19] aye, Platonides, dragons :) [23:09:51] Platonides, we're hiring dragons, Howie was just interviewing one. of course, they tend to burn everything to the ground at times - so disclaimers are needed [23:10:58] hehe [23:14:58] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37318 [23:15:21] I hope he went with his antiinflammatory suit :) [23:16:03] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37135 [23:19:13] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37136 [23:21:11] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37137 [23:25:19] jdlrobson: im seeing a lot of failed tests for beta_opensearch.js in qunit - is this expected? [23:27:17] no… [23:27:18] * jdlrobson looks [23:27:26] New patchset: Jdlrobson; "add placeholder to login elements [story 250]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37176 [23:27:26] New patchset: Jdlrobson; "style login screen [story 250]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37177 [23:27:26] New patchset: Jdlrobson; "style error message [story 250]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37178 [23:27:27] New patchset: Jdlrobson; "remove info box from top of login [story 250]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37175 [23:27:58] argg awjr i'm not seeing them at all in chrome - must be an exception [23:28:11] or i have something configured wrong maybe [23:28:55] awjr: does it give you an error in your console? [23:29:24] also awjr what browser? [23:29:43] jdlrobson: yes, chrome desktop [23:29:47] (i see why) [23:31:38] actually all of the beta_opensearch tests fail for me [23:32:59] fixing now awjr [23:33:05] ty :) [23:33:12] it's because it's not recognized by http://localhost/w/index.php/Special:JavaScriptTest/qunit?filter=MobileFrontend#_ [23:33:15] *the filter) [23:34:54] jgonera did jdlrobson manage to convince you about single-line var statements? [23:35:22] awjr: i believe i convinced jgonera [23:35:33] but does jgonera believe you convinced jgonera? [23:35:58] personally im ambivalent; but if jgonera is OK with it i'll merge the changes [23:36:20] awjr, for the purpose of our code, lets say yes, but I still think that onevar gives me more problems than benefits, see http://benalman.com/news/2012/05/multiple-var-statements-javascript/ [23:36:28] (especially the second half of it) [23:36:34] * awjr looks [23:37:12] I mean, I would not use onevar in my projects, but I can get used to it [23:37:35] ok; im going to merge the code once i verify the tests are happy. if it causes problems we can always revisit :) [23:38:07] it's purely about coding style, shouldn't affect anything [23:38:19] yeah, by problems i mean pissing people off :p [23:40:50] New patchset: Jdlrobson; "fix the search tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37587 [23:41:02] ^ awjr [23:41:13] far out thanks jdlrobson [23:42:51] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37497 [23:44:24] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37587 [23:48:07] jgonera: i'm finding the comments more interesting as the argument of maintenance in http://benalman.com/news/2012/05/multiple-var-statements-javascript/ holds no weight for me - it's not about maintenance it's about readability and encouraging good coding habits .. but this is pretty interesting - http://jsperf.com/var-statement-between-comma/2 :) [23:48:19] interesting comments: http://benalman.com/news/2012/05/multiple-var-statements-javascript/#comment-519427938 http://benalman.com/news/2012/05/multiple-var-statements-javascript/#comment-518583177 [23:51:38] New review: awjrichards; "See inline comment." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37163 [23:52:09] New patchset: awjrichards; "enforce onevar" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37138 [23:52:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37138 [23:55:04] brion and preilly, why it was decided to create a new hook for https://bugzilla.wikimedia.org/show_bug.cgi?id=31012 instead of using BeforePageRedirect?