[14:56:23] awjr, o_0 [14:56:30] you;re already up? [14:56:40] MaxSem: fraid so [14:57:07] power's out at my house [14:58:22] had to hop online to get the # for the power company (yay tethering!) [15:01:19] MaxSem: im pretty sure the rest of the team are going to be zombies today [15:01:26] due to the holiday party in SF [15:01:30] ? [15:01:37] what party? [15:01:51] annual WMF holiday party [15:02:59] why in the middle of the week? [15:03:33] i dunno, good question. [15:04:30] MaxSem: i'm going to take off. see you in a bit [16:25:42] MaxSem: more question of 'why without us' [17:21:30] MaxSem: do you know if there is a way in MW to easily tell if an arbitrary extension is loaded/available? [17:22:00] all of them suck [17:22:16] 1) dig through $wgExtensionCredits [17:22:19] New review: awjrichards; "There is a chance this will prevent CentralAuth (and other hook invokers) from running its hook at a..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38676 [17:22:37] 2) check if an extension-specific class or function is present [17:22:37] blech [17:22:44] 3) or config variable [17:22:58] this one is register_globals unsafe [17:23:21] ideall,y and extension should define a "hey, I'm here" define [17:23:24] ok yeah, thanks MaxSem. i was hoping there was a global function or something that would make this not crappy :p [17:25:24] MaxSem: also do you know of any way to ensure extensions invoke a particular hook in a certain order? [17:25:38] eg extensionA will always invoke the hook before extensionB [17:25:47] lol [17:26:01] you desire far, far too much [17:26:07] i thought as much [17:26:14] * yuvipanda hands MaxSem a 'Grand ol' man' badge [17:26:19] lol [17:26:34] 'In my time we had to support PHP4!' [17:26:44] turns out ensuring there's no success page displayed thanks to CentralAuth after login is not easy. [17:27:34] right now im invoking the same hook as centralauth but returning false to prevent any more processing, but of course that might make it so centralauth never gets to log someone in everywhere [17:27:40] so amend these requirements [17:28:03] i took a stab at that yesterday at the end of the day but it didn't go over so well [17:28:05] what hook do you want to prevent? [17:28:31] what i'd really like to do is get devicedetection back into core and make MW context aware, then i coul dmake the changes in CentralAuth rather than hack around it in MF [17:28:37] UserLoginComplete [17:28:41] MaxSem ^ [17:29:01] don't prevent CA from doing anything, that beast might be too much to tame [17:29:52] well one possibility im thinking of now is still hijacking the hook invocation, and if CEntralAuth is installed, make sure it's invocation of the hook runs before returning false [17:29:55] which should do the trick [17:30:03] but it's a really nasty hack [17:34:56] awjr, JS might be the optimal solution indeed [17:35:30] MaxSem: i couldn't figure out a way to do it without first letting the success page load in the dom, which makes for a crap user experience. jon may have a better solution [17:35:51] you _need_ the success page [17:36:09] otherwise, CA will not log you in to sister projects [17:36:35] MaxSem: well the success page doesn't log you in, it just shows that you're logged in [17:37:16] awjr, small project logos is what logs oyu in everywhere butg the current wiki [17:37:47] MaxSem: wait, really? via js? [17:38:05] no, images set teh cookies;) [17:38:12] gah [17:38:40] i guess that makes sense since cookies need to be set across domains [17:39:29] so just redirect with JS once all images are loaded [17:40:32] alternatively load the images in a hidden div [17:41:04] that's bad cause users need to control the process visually [17:41:31] New review: awjrichards; "And by 'a chance' i mean this will definitely prevent centralauth from logging you in everywhere." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/38676 [17:41:42] MaxSem: why? [17:42:16] that's how it always worked [17:42:21] and without JS too [17:42:29] we can still do it without js [17:42:39] do you know that Opera, for example, doesn't load images in hidden divs? [17:43:02] damn it, i did not know that [17:43:07] it's an obvious optimization [17:43:21] except for when you want to make an ugly hack [17:43:55] sigh. [17:43:55] if it forces you to do the right thing, it's a cute little feature:) [17:44:32] well, the way centralauth logs you in everywhere is its own hack that we have to work around [17:47:05] hmm if $wgCentralAuthLoginIcon is not set for a proejct, centralauth will load a 1px transparent png [17:48:19] with minor modification we could make central auth variably display the transparent icon without having to mess with $wgCentralAuthLoginIcon and then implement my ugly hack [17:48:28] without having to load images in a hidden div [17:53:20] how i made it to the office at this time i have no diea [17:55:01] jdlrobson: still alive? [17:55:05] awjr: just about [17:55:11] :) [17:55:16] a guy called hector woke me up this morning telling me he was here to fix something [17:55:26] it was a confusing start to the day [17:55:27] hahaha [17:55:34] something about blinds [17:55:38] i think i had to call in sick after the last holidy party [17:55:41] he had a drill and I wasn't sure if I should let him in [17:58:18] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=43108 < this is making me grumpy [17:59:06] jdlrobson: that's easy to fix [17:59:15] awjr: in core? [17:59:21] or in hacked mobile frontend ? [17:59:22] no the form is not served from core [17:59:25] we're serving the form :) [17:59:35] or a hijacked version of the form [17:59:35] the table? [17:59:40] yup [17:59:46] the whole thing [17:59:52] but it shouldn't be a table in core either [17:59:53] we hijack the entire template [17:59:59] * flyingclimber yawns [18:00:12] jdlrobson: you in the office ? [18:00:17] jdlrobson: it doesnt make sense for us to care about how core does it for now since we need to totally alter the form anyway [18:00:36] flyingclimber: yup [18:00:58] awjr: i see now [18:01:02] jdlrobson: log into the chrome box and setup the video. i'm already on from home [18:01:07] jdlrobson: i think you're on your own for standup in the office unless jgonera and brion are there [18:01:07] i didn't realize we were creating it from scratch [18:01:09] brb [18:01:12] and/or just use your laptop [18:01:29] jdlrobson: not entirely, but for all intents and purposes we are [18:01:55] jdlrobson: you reviewed and merged the code that handles that :) [18:13:37] Maryana: you alive? [18:13:43] haha, yeah [18:13:48] :) [18:13:49] i had to be in the office at 9 for a call [18:13:54] so i didn't party too hard [18:13:55] ugh [18:13:58] yeahhhh [18:14:01] jdlrobson, were you trying to transmit your nausea to us?:P [18:14:01] good move :) [18:14:08] yes [18:14:12] sad i missed the nerf fight [18:14:21] i'm so hungover [18:14:23] hammock is not helping [18:14:29] Maryana: there are some serious barriers to getting rid of the success page after login. i *think* i've got a way to do it, but it's really ugly [18:14:29] well it is slightly [18:14:32] but not as much as I hoped [18:14:45] sigh [18:14:53] Maryana: i suggest we change the requirements for now to keep this cleaner until we can make the bigger changes necessary to do this right [18:15:12] Maryana: basically, CentralAuth needs to load all those icons in the success page in order to log users in to the other sites [18:15:27] so we could just do an automatic redirection from that page once all the icons have loaded [18:15:44] hey awjr [18:15:48] hi munaf [18:15:54] yeah, we had this problem on desktop when e3 worked on account creation [18:17:01] i think that'd be pretty awkward [18:17:04] one possible work around is to force CentralAuth to load 1x1px trapsnarent pngs instead of the wiki icons, hijack centralauth's output in order to suppress it, and then load the transparent pngs into the regular page [18:17:15] but, that's a REALLY ugly workaround that will be somewhat fragile [18:17:33] and will require code changes to CentralAuth [18:17:34] so i take it it's not easy to load those icons with display:none on the user's referring page [18:18:08] hmm i was thinking originally of doing it in a hidden div but MaxSem pointed out opera won't load images inside of a hidden div [18:18:15] MaxSem: will opera load images with display:none ? [18:18:22] and likely not only Opera [18:18:39] Opera will not load anything under display:none [18:18:55] so munaf that is not an option [18:19:02] no matter how it's bestoed upon images [18:19:08] that makes sense [18:20:26] highly unfortunate. i would like to meet the person who created this crazy centralauth hack and give him a piece of my mind [18:20:35] sigh. appending them to the end of body with opacity:0 or visibility:hidden then? [18:20:39] i think it might've been brion [18:20:40] Maryana, brion's not here [18:20:46] hehehe [18:20:49] hah, i thought so [18:21:13] hmmm, no logs [18:21:32] Maryana, munaf i guess the other option is to just leave things as-is [18:21:38] right [18:21:49] * yuvipanda grumbles about being left out of the party and the lack of teleporters. Revenge shall be had by working out of Goa when it is the coldest in SF :) [18:21:51] i'm just wondering what the options are and how hard they are to build [18:22:42] awjr, how soon do we need a (tentative) solution? would this benefit from an in-person brainstorm when you're in the office next week? [18:24:13] sooo\ [18:24:20] 1) leave as-is [very easy] 2) auto-redirect after login icons have loaded on success page [easy] 3) modify MediaWiki to know when a user is viewing via mobile vs desktop, modify centralauth to handle logins differently for mobile users [medium-hard, but will take a while] 4) do the ugly hack i described above (modify centralauth to let us force it to return 1px transparent images for the various wikis and embed those in article content after hi [18:24:21] well ok, let's just leave it as is. it sounds like the only possible solutions are either hacky or extremely difficult. all in favor? [18:24:26] those are the options i see Maryana, munaf ^^ [18:24:31] we have geolocation on enwiki - I can haz some means of testing it? [18:25:10] munaf what about an autoredirect after the images have loaded? [18:25:26] awjr, I don't see how 3) requires making MW mobile aware [18:25:30] yeah, i'm inclined not to layer hacks on hacks [18:25:38] you can simply make CA extendable [18:25:50] I'm personally firmly in favor of 1 or 2 [18:25:58] awjr i don't think it's a good idea from a ux perspective, it's gonna make users wonder what the icons were all about and why they were taken to that pgae [18:26:18] if we're gonna take them to that page i guess it's better to design it [18:26:33] MaxSem: it's true and we can still hook into MF to determine if we should be using the mobile view; but i think the better longterm solution is to build it into MW to make it easier for other extensions to have mobile-specific functionality [18:26:36] so maybe i'll include another mockup to make it at least have some useful links and intro text? [18:27:07] munaf that makes sense; if you want to change output/styling that's fine too [18:27:31] awjr, we laready had DeviceDetection in core -this resulted in nothing but confusion. we shouldn't even think about doing this if we don't have enough resources to finish this sanely [18:27:46] yeah i will get to work on that today. though honestly, i may end up hiding the icons in the page regardless (visibility:hidden or some such) [18:28:08] MaxSem: that's because we dropped the work I had been doing on making MW context aware - i had submitted changes but they never got merged and i stopped paying attention :( [18:28:14] flyingclimber, is https://bugzilla.wikimedia.org/show_bug.cgi?id=19920 a WONTFIX, or we're just waiting for infrastructure? [18:28:29] munaf: that wont work in opera apparently which is not an option for us [18:28:55] waiting for infrastructure but i'm fine with that bug being resolved for now [18:29:57] MaxSem: just having DeviceDetection in core is useless on its own [18:29:59] so I guess we can just reopen it to avoid pretending that it doesn't exist [18:31:49] awjr, so we must move a lot of stuff into MW to ensure it makes any sense [18:32:14] and this work is indeed much less important than new features [18:32:36] MaxSem: i think we'd need to move just enough to replicate MobileFrontend;:shouldDisplayMobileView() [18:33:03] but yeah, i agree. i might work on it at some point for experimentation time [18:33:06] meh, still too little a bite [18:35:51] New patchset: Jdlrobson; "show sign up heading for signup page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38738 [18:35:51] New patchset: Jdlrobson; "style account creation form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38674 [18:36:04] awjr: ^ [18:39:20] New review: awjrichards; "Mostly looks good! Please remove unused label msgs from i18n" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38674 [18:39:47] jdlrobson: also, even though we cant do the grey background for the captcha, perhaps it would still be good to have more visual separtion btwn the image the input? ^ [18:40:23] awjr: that would be going against the form [18:40:31] i'll sit down with munaf or vihba and tweak it with them [18:40:35] cool [18:40:38] that's worked well in the past [18:40:44] makes sense [18:40:49] (this can be done before merge or after merge depending when i see them) [18:41:02] i have a few questions around buttons anyway [18:41:47] jdlrobson: im fine to merge it (after removing unused i18n messages) so we at least have it in master for now [18:41:53] more tweaks can come later [18:41:55] k ill do that now [18:41:58] cool [18:42:54] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38676 [18:46:36] New patchset: Jdlrobson; "show sign up heading for signup page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38738 [18:46:36] New patchset: Jdlrobson; "style account creation form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38674 [18:46:37] awjr: amended ^ [18:47:29] missed one jdlrobson but i'll take care of it [18:47:34] awjr: no [18:47:38] that's used by login apparently [18:48:11] jdlrobson: mobile-frontend-accou [18:48:11] nt-create-captcha [18:48:13] er [18:48:16] pretend that's on one line [18:48:21] ohh ok [18:48:28] thanks for taking care of it [18:48:31] np [18:48:46] sorry awjr, jdlrobson, stepped away [18:49:05] munaf: nothing urgent - we just ran into a few issues with the account creation form [18:49:12] we can't style the captcha background as grey [18:49:19] the images have white backgrounds [18:49:55] New patchset: awjrichards; "style account creation form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38674 [18:51:01] yeah i thought that would be a stretch jdlrobson [18:51:10] i'll work out another way to visually separate it [18:53:26] New patchset: awjrichards; "style account creation form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38674 [18:54:04] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37857 [18:55:01] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38674 [18:55:26] New patchset: awjrichards; "show sign up heading for signup page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38738 [18:56:28] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38738 [19:13:14] flyingclimber i think i need this http://www.amazon.com/Nerf-N-Strike-Vulcan-EBF-25-Blaster/dp/B0013U95U2 [19:14:19] as demonstrated (slowly) by this small child http://www.youtube.com/watch?feature=player_embedded&v=yYIimlvIZsM [19:14:33] he makes it look lame though [19:14:47] it's definitely a nerf gun for under the arm [19:16:07] MaxSem: when do we get to share the vodka video with a wider audience? [19:16:27] jdlrobson: anything automatic is less fun to use [19:16:29] too predictable [19:17:55] jdlrobson, first time I hear about it [19:18:09] MaxSem: I have the vodka video on my hard drive [19:18:12] do you remember it? [19:18:20] (happily) no [19:18:33] hehehe [19:18:39] something about pickled cucumber [19:18:52] you started a meme [19:19:10] jdlrobson: I'm leaving videos to you - will be dead on my connection. [19:19:19] :D [19:20:16] MaxSem: you aren't on facebook, are you? [19:20:26] I'm not [19:22:55] jdlrobson awjr updated the signup mock https://mingle.corp.wikimedia.org/attachments/43e3400919100b734d6c255af5e15a26/195/Wikipedia_Signup_-_iOS.png [19:23:05] nothing drastic [19:24:48] yuvipanda: yo [19:24:52] tfinc: yo [19:24:56] yuvipanda: i need your feedback about the app jd [19:25:05] ah, right. [19:25:27] i read that in the morning, reading again [19:25:44] tfinc: 'You would not just take the reins of our iOS development but would also train our Android engineers to excel on iOS. They will in turn support you in becoming a rock star Android developer' [19:25:46] is confusing [19:26:05] and +1 to Maryana about 'rockstar' [19:26:15] we need to highlight that they are not just coming in to write code for iOS [19:26:35] they need to teach the rest of the team about object c [19:26:40] knowing that. how would you reword it? [19:27:14] tfinc: if that's the case, that's fine - but then knowing android dev should be a 'plus' [19:27:17] probably an 'extra points' [19:27:22] yuvipanda: so edit it [19:27:27] it was confusing because that sentence was there and then the rest of the jd said nothing about android [19:27:30] oh, i have edit rights? [19:27:32] * yuvipanda pokes [19:27:39] awjr jdlrobson, question on the captcha [19:27:59] i'm worried that it'll look awful on retina screens [19:28:15] can we change the size/resolution of the captcha image that's generated? [19:28:18] tfinc: i'm not too sure we need to put C/C++ there [19:30:35] yuvipanda: it shows a solid development foundation. having someone who understands c/c++ glues everything together [19:30:46] and allows us to write an intermediate low level layer [19:31:04] an 'intermediate lower layer' for iOS and Android mostly makes no sense. [19:31:14] my worry is that if you're spending a lot of time writing iOS / Android apps [19:31:19] you'll hardly need to touch C or C++ [19:31:34] like, only for the rarest of tasks. [19:31:49] and any code sharing that's going to happen is going to be CSS / JS, not C / C++ [19:32:51] tfinc: so -1 on the C / C++ there. [19:33:03] yuvipanda: put in a comment about that then and we'll see what brion says. he specifically requested it [19:34:18] jdlrobson: stop putting your comments into one stream on google docs. its makes it hard to resolve anything [19:34:29] and/or reply [19:35:39] tfinc: also, I want to add Javascript there. We'll definitely be using JS / CSS in our apps, even if they're all native (our API returns HTML) [19:35:51] * MaxSem cries [19:36:20] MaxSem: why? [19:36:33] OSM relies *heavily* on everything being on one bloody server [19:36:41] aaah, *that* [19:36:49] * yuvipanda hands MaxSem a *laaaarge* box of tissues. [19:37:04] can I have a chainsaw instead? [19:37:22] * tfinc hands MaxSem a fork [19:37:23] :D [19:37:36] * yuvipanda hands tfinc J2EE Spring Framework [19:37:47] * tfinc hands yuvipanda his textbook back [19:38:39] today's paper had phrases like 'the only thing management and managers understand is money' [19:39:35] clearly i suck as a manager then [19:40:44] tfinc: quite a lot of other horrors. It was using Motorolla and AT&T as successfull examples of managing quality & customer satisfaction. [19:44:15] tfinc: Hi! Siebrand have tried to push update of WIkisourceMobile app i18n but he hasn't direct push right in the GitHub repo https://github.com/wikimedia/WikisourceMobile/ [19:44:17] Can you give him this right, please? https://translatewiki.net/wiki/Thread:Support/WikisourceMobile [19:45:14] Tpt: sure. let me see which group he's in for our other retps [19:45:50] Tpt: done [19:46:11] tfinc:Thanks! :-) [19:48:00] tfinc: i'm happy with the JD, pending the C/C++ bit [19:48:10] yuvipanda: thanks [19:48:52] tfinc: status on planning stuff with language team? is there a starting list somewhere? Who is going to be involved? Everyone? Just the apps team? An ETA when we'll have some more details? [19:50:00] yuvipanda: i started building out http://www.mediawiki.org/wiki/Mobile_i18n yesterday from what i found on meta. brion has the first items to tackle and i'm working with alolita to find out how to manage the work [19:50:10] * yuvipanda looks [19:50:17] content there is just what i found on meta [19:50:34] i hope to have it built out before the day is over [19:50:48] i was unhappy that everything thus for has been in email and nothing was really on a central wiki [19:50:51] so i'm building this out [19:50:57] then i'll get brion to fill in the tech bits [19:51:01] and you can add as needed [19:51:03] sweet. [19:51:09] do you know when brion will be in? [19:51:36] he's had a lot of trouble with attendance lately [19:53:45] heh [19:54:31] tfinc: let me know if you want me to fill in on the IME details - we talked a fair bit about it [19:55:16] do it [19:55:44] alright [19:56:50] New review: awjrichards; "This enables history view everywhere (including non-beta). Not all resources that should be loading ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37500 [19:57:14] tfinc: doing it in an etherpad and then copying over. http://etherpad.wikimedia.org/mobile-ime-support [19:57:20] k [19:59:11] * yuvipanda waves at aharoni [19:59:54] jdlrobson, shouldn't we mark bugs as fixed after the fix is deployed? [20:03:13] preilly ping [20:06:13] awjr: i see a preilly talking with schoonover in r31 [20:06:19] guessing their doing a analytics arch review [20:06:24] thanks tfinc, it's not urgent [20:06:45] i'm waiting for preilly as well to find out how our pe candidate did with him [20:06:53] emilio [20:06:54] ? [20:07:21] * yuvipanda wonders what mischief rmoen was upto [20:08:22] yuvipanda: just feeling like a smarty pants.. btw awesome photos man :) [20:08:52] rmoen: i213 photos *selected*. not even 1/5th of it up yet :P [20:09:09] *213 [20:09:27] jgonera: i've always wanted a RESOLVED DEPLOYED state or similar [20:10:00] New patchset: awjrichards; "only style tables in overlays created by table module (bug 42710)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38340 [20:10:15] interrupt RESOLVED FIXED as meaning resolved in latest development version [20:10:22] jdlrobson: Resolved duplicate always gets me excited. [20:10:26] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38340 [20:10:47] interrupt = interpret? [20:11:36] New patchset: awjrichards; "ensure heading centered [267]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38470 [20:11:42] yes interpret [20:11:44] that's the hangover [20:12:06] mmm noodles [20:12:58] jdlrobson: soup freaks has a hangover soup that has worked well for me in the past [20:13:18] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38470 [20:13:54] New patchset: awjrichards; "move cleanup templates css into cleanup template module css [267]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38471 [20:14:11] tfinc which soup? [20:16:34] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38471 [20:16:37] awjr: its literally called the hangover soup. key ingredients : sriracha [20:16:43] hahaha [20:16:48] tfinc that's a good pro-tip [20:17:00] i can vouch for its effectiveness as i've had to use it [20:17:39] im writing that down in my mental notebook. i usually find myself in that state more often than i care to admit during trips back to sf... [20:18:14] * rmoen|away waves at rmoen [20:18:14] New patchset: awjrichards; "switch to border box mixin [267]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38472 [20:18:58] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38472 [20:20:18] Protection :) [20:20:37] Krinkle: yes, but I was trying a Unicode Homograph [20:20:45] don't think nicks can be unicode [20:21:16] indeed [20:21:27] damn monospace fonts [20:22:13] New patchset: awjrichards; "promote cleanup template module [267]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38473 [20:23:18] no unicode support in nicks :( [20:24:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38473 [20:25:19] New patchset: awjrichards; "switch to less aggressive min-height (bug 42702)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38474 [20:25:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38474 [20:26:46] New review: awjrichards; "I can't test this one :(" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/38550 [20:28:02] rmoen|away: yeah, the US emphasis is even in IRC. Also the reason that $ is 1 byte, while € is mb [20:28:21] Krinkle: well, UTF-8 [20:28:27] yeah [20:28:37] so it should be handled transparently (mostly) [20:28:44] plus it seems to support it for content just fine [20:35:07] awjr: have you got IE? [20:35:12] If so you can test https://gerrit.wikimedia.org/r/#/c/38550/ [20:35:13] no jdlrobson [20:35:19] or you can just set your user agent to IE [20:36:42] browser stack (or sauce labs!) [20:36:50] IE in < 10 seconds. [20:37:10] that too awjr ^ [20:37:17] i have access - just ask rachel [20:37:51] No more excuses, anyone can get their hands on IE. I find browserstack a little more reliable, but if you don't have a wmf account (yet), SauceLabs is now free registration for any open source projects. [20:37:56] munaf: Maryana awjr : watch list reader mode - siebrand points out that the items might not be articles - what do we think about this? - https://gerrit.wikimedia.org/r/#/c/38643/1/MobileFrontend.i18n.php [20:38:13] cool i'll look again in a bit jdlrobson [20:38:25] (re IE, that is) [20:39:27] New review: awjrichards; "As written this potentially has serious performance issues. See inline comments." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38642 [20:41:02] NickServ [NickServ@services.]: MaxSem!~yuvipanda@mediawiki/Yuvipandan failed to login to MaxSem. There has been 1 failed login attempt since your last successful login. [20:41:08] hahaha [20:41:24] :P [20:41:40] I also really need to get rid of that 'n' in my cloak. I've no idea why that's there [20:42:04] awjr: could do with your help on https://gerrit.wikimedia.org/r/#/c/38642/1/includes/specials/SpecialMobileWatchlist.php > we probably need to use memcached for recent changes view too? [20:42:42] jdlrobson: will look shortly [20:43:09] Krinkle: do we have organizational logins for browserstack/sauce labs? i have what i guess are old credentials for saucelabs that no longer work :( [20:43:44] awjr: saucelabs is free registration, so just create a personal account [20:43:51] cool Krinkle thanks [20:44:14] awjr: We got donated an organisational account at browserstack, however it is for management not actual usage. Rachel creates personal accounts from that management account. [20:44:20] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38678 [20:44:54] awjr: we have a shared wmf account at crossbrowsertesting.com too [20:45:15] though not sure if they support tunnelling localhost [20:45:24] I know browserstack supports it, maybe saucelabs too [20:49:38] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38550 [20:50:09] New patchset: Jdlrobson; "enable the history page in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37500 [20:51:29] jdlrobson: part of the problem with https://gerrit.wikimedia.org/r/#/c/38642/ is that you're doing the order by on a non-indexed field. it looks like that table has an index on namespace and title, but not title by itself [20:54:43] New patchset: Jdlrobson; "enable the history page in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37500 [20:56:30] oh actually i forgot that ordery by still will not use indexes if they have multiple columns (eg even though namespace, title is an index, doing order by namespace title still will not use indexes) - so you're stuck with a filesort [20:58:19] order by can be very evil [21:03:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37500 [21:05:11] jdlrobson: sorry, was having lunch w/e3 - siebrand is right about the watchlist copy. we should use "items" or "pages" with changes, not "articles" [21:20:20] Maryana, munaf: can we update the acceptance criteria for https://mingle.corp.wikimedia.org/projects/mobile/cards/265 to reflect that we'll leave the centralauth success page as-is? there was also a mention restyling the success page - should we include that in this story card? [21:27:53] will do [21:28:23] think munaf's working on updated styling. i'll make sure that's reflected in the assets attached to the card [21:28:54] tfinc: updated https://www.mediawiki.org/wiki/Mobile_i18n [21:30:12] * YuviPanda goes to bed [21:30:15] gnite folks [21:30:53] awjr: does this apply to logout behavior, as well? [21:31:08] does centralauth have to load those icons to log the user out of all projects? [21:31:23] Maryana: there is a success page for logout though it's different than that for login and i do not know if it has the same problems [21:31:38] so im not sure but i can check [21:31:40] * Maryana shakes fist at centralauth [21:33:01] Maryana: it appears so [21:33:06] sigh [21:33:08]