[00:01:49] small one if anyone can review - https://gerrit.wikimedia.org/r/#/c/38809/ [00:02:08] awjr: http://adafruit.com/products/1037 [00:02:24] tfinc looks awesome [00:03:15] tfinc im thinking about something like this: http://www.zdnet.com/raspberry-pi-meets-lego-in-supercomputer-like-cluster-photos-7000004209/ [00:06:53] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38809 [00:10:32] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/38827 [00:10:42] New patchset: Jdlrobson; "i18n change for hamburger menu (bug 42804)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39160 [00:10:56] MaxSem: also can you take a look at https://gerrit.wikimedia.org/r/#/c/36809/? [00:11:14] looks right [00:11:52] MaxSem: i'm merging https://gerrit.wikimedia.org/r/#/c/36809/ unless you have any objections [00:12:05] go ahead [00:12:07] ohh just saw aw message :) [00:12:18] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36809 [00:12:56] MaxSem: you wanted to talk about https://bugzilla.wikimedia.org/show_bug.cgi?id=41569 ? [00:13:19] we already did;) [00:14:19] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39160 [00:16:00] jcmish: card #257 is OK now, we've merged all the outstanding code [00:16:09] awjr: kayo [00:16:16] I'll give it a once over [00:16:28] Some holiday joy for everyone :) http://i.huffpost.com/gen/895386/original.jpg [00:17:08] hehehe [00:17:38] MaxSem if you say so :) [00:18:11] awjr: jcmish that sounds like a soundbite from a hollywood blockbuster. "jcmish it's over. We've merged all the outstanding code" [00:18:25] jcmish: :) [00:18:27] jdlrobson: oh you're right! [00:18:49] lol [00:18:56] awjr: https://gerrit.wikimedia.org/r/#/c/39151/ is pretty important - can you verify and let me merge? [00:19:32] np jdlrobson one sec [00:19:50] that is surprising actually, RL should only load the module once [00:20:04] oh i see, but it shouldnt be loading at all in beta [00:20:12] and https://gerrit.wikimedia.org/r/#/c/39155/1 should be fun in terms of getting us to our 1000 uploaders ;-) [00:20:22] awjr: correct [00:20:47] jdlrobson, CSS is still duplicated [00:22:29] MaxSem: what CSS? [00:22:39] jdlrobson: yeah, im also seeing photo-related css loading in beta still [00:22:48] ahh i'll fix that now [00:23:02] mf-photo [00:23:24] i smell a bad rebase [00:26:50] New patchset: Jdlrobson; "only load modules once [beta/alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39151 [00:26:51] awjr: MaxSem fixed with other catches ^ [00:29:23] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39151 [00:54:48] New patchset: Jdlrobson; "hardware back button behaviour" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39166 [00:57:37] New patchset: Jdlrobson; "hardware back button behaviour" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39166 [00:59:53] jdlrobson, ^^^ I thought history manipulation is buggy [00:59:53] in Android [00:59:54] we feature detect it [01:00:43] need to review all the history code though [01:00:46] feels very messy [01:06:01] New patchset: Jdlrobson; "make sure #mw-mf-overlay .header gets padding left [bug in beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39168 [01:25:16] jdlrobson, jgonera how have you guys gotten the language stuff to appear in articles on your local machines? [01:25:51] awjr, language stuff? you mean the variants? [01:27:48] jgonera yeah [01:28:23] awjr, you need to set the language of your mediawiki to something that has variants, e.g. sr or zh [01:28:57] ahha cool [01:29:04] thanks jgonera [01:32:12] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [01:32:37] MaxSem: how are you still awake? [01:32:38] go to bed [01:32:43] jdlrobson: go rest [01:40:57] tfinc: i am [01:40:59] multi tasking [01:41:02] drinking tea like a boss [01:41:28] drinking tea and thinking about owning an island ? [01:41:31] yes [01:41:38] both known ways to cure illness [01:41:44] need to take my mind off being ill [01:41:51] jdlrobson: i wonder how these islands hold up during tsunamis and hurricanes [01:42:01] tfinc: i was wondering this [01:42:25] jdlrobson: its time like this that i love knowing pilots who can take me to places like this [01:42:27] i was wondering if we can build underground as well [01:42:45] #humblebrag ;-) [01:42:51] :D [01:45:42] jdlrobson: that way we can know how badly it'll get destroyed [01:45:59] New patchset: JGonera; "Add Last modified" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39176 [01:49:14] New patchset: JGonera; "Add Last modified" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39176 [01:49:23] time to head home ... [01:50:27] New review: JGonera; "Depends on https://gerrit.wikimedia.org/r/#/c/39162/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/39176 [01:52:53] jgonera, it will take more than a month for the core change to propagate naturally, we'll have to cherrypick [01:53:11] :/ [01:53:43] I'll ask Maryana how urgent they think last modified is [01:58:54] New review: Jdlrobson; "I get Uncaught Error: Unknown dependency: mediawiki.jqueryMsg - how do I fix?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39176 [07:10:14] o [07:10:15] o/ [07:28:11] margle: hi! [07:28:13] \o [07:29:11] :) [18:02:24] tfinc: where's this 'benjamin franklin' space? [18:02:35] Maryana: ^ (for the nav discussion)? [18:02:56] we're in the 6th floor collab space [18:02:58] :) [18:03:01] o [18:03:10] calendar invite says 3rd flr 'benjamin franklin' [18:03:12] it's listed on https://office.wikimedia.org/wiki/Office_IT/Resources but …. doesn't say where on the 3rd floor it is. it's apparently *not* the standup space [18:03:13] on our way up [18:03:17] aha [18:03:18] i booked 3rd floor collab (benjamin franklin) just in case, cos there was a brownbag on 6 [18:03:27] but it's later at 11 or 12 [18:07:34] New patchset: awjrichards; "make sure #mw-mf-overlay .header gets padding left [bug in beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39168 [18:08:23] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39168 [18:08:46] It's a conspiracy!^^^ [18:12:06] for some reason it wasn't letting me submit the change, saying it needed verified even though i had +1 verified it... [18:14:27] awjr, you have a meeting? [18:14:42] MaxSem: yeah [18:15:54] you have to pay for being at office:P [18:17:15] hehehe indeed :p [18:17:32] most of my time this week is some meeting or another [18:48:10] http://www.sf-planning.org/index.aspx?page=3339#map :D [18:50:49] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [18:55:04] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [18:59:10] jgonera, I've left a bunch of comments at https://gerrit.wikimedia.org/r/#/c/39155/ [18:59:21] anyone want to do a usability test of bitbucket for a $40 amazon gift card? my friend is a designer there and is looking for people. remote is OK. [19:00:40] munaf: can it be done at any time of the day/night ? [19:00:57] specifically friday only, i think [19:01:05] how long ? [19:01:09] 1hr, over skype [19:01:36] MaxSem, I agree with them, I'll add my own comments soon [19:01:40] MaxSem: we need to talk about parse [19:02:18] wfMessage()->text(); transforms the message text (MessageCache::transform() which transforms all '{{}}') [19:02:33] i don't see what your big issue with ->text() is [19:02:40] it does exactly what i want it to [19:02:43] no wikitext, no html [19:03:22] I was under the understanding to only use escape for html attributes [19:03:39] text() neither processes wikitext (which can be fine on case by case basis) nor escapes HTML - which is bad [19:04:29] text() in this context allows full use of HTML in messages, which is bad and not recommended [19:05:47] MaxSem: no it doesn't [19:06:41] if i do

hello

i get exactly that [19:06:46] no html parsing [19:07:00] and i specifically don't want to process wikitext [19:07:09] because that can add html markup that i don't want [19:07:24] escaping is not necessary in a text node [19:07:36] max@vmubuntu:~/Projects/MediaWiki/maintenance$ php eval.php [19:07:36] > echo wfMessage('foo')->text(); [19:07:36] [19:08:11] doesn't do that for me MaxSem.. [19:08:37] if it's a text node, use escape() [19:08:47] i get Donate image<script>alert("xss")</script> [19:09:08] MaxSem: maybe we should have this discussion in #mediawiki-i18n [19:09:16] if it's a long text, consider using parse() anyway, because that's where Wikipedians love to use markup to give links to policies, add pretty images etc [19:09:23] BUT i don't want wikimarkup [19:09:36] it can mess up the rendering [19:09:43] how? [19:09:45] for instance the menu expects one link [19:09:54] if someone put an image in there it would render the menu incorrectly [19:10:03] I just want the label for the menu [19:10:13] yeah, don't use parse simple stuff like link text [19:10:16] if someone feels strongly about this they can argue and with good reason I will change it to parse [19:10:26] but you are telling me to do that - or to use escape [19:10:30] and I'm saying escape is unnecessary [19:10:58] but it HAS to be HTML-safe, either by using abstractions like Html::element() or escape [19:11:03] at least the output is as I expect - < and > are replaced with < and > [19:11:33] did you try the same in eval.php? [19:12:46] Translator doesn't need to know where they can simply write text and where they have to replace quotes with " [19:13:31] I'm asking in i18n [19:13:56] MaxSem: that's what qqq codes are for no? [19:15:22] you can't write in every qqq message "this message must be HTML-clean" and you will be misunderstood anyway [19:16:09] well that sounds like a bigger problem MaxSem [19:21:26] jdlrobson: jgonera brion http://www.sencha.com/blog/the-making-of-fastbook-an-html5-love-story/ [19:28:59] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [19:29:44] tfinc, looks really impressive, I wonder if Facebook will hire/buy them to redo their apps ;) [19:32:28] jdlrobson, is this commit reviewed and tested enough to merge it 1.5 hours before the deployment? [19:35:47] MaxSem: you tell me - from my side no one has reviewed it until today. I don't think it's a major change and it's for alpha but it's up to the team to decide! [19:36:56] jdlrobson, I say I'll deploy it only if jcmish will tell me it's been tested [19:37:11] where's jcmish, by the way? [19:37:28] MaxSem: still unclear to me how alpha works in terms of testing [19:38:21] yeah, we need more clarity on alpha deployments [19:38:39] jdlrobson, MaxSem - we should just smoke test alpha to make sure changes introduced there don't break anything else [19:39:00] All the code this touches is in alpha [19:39:12] awjr, speaking of which, can you help me with PageImages review? [19:39:48] MaxSem i think so, but i might not get it totally done by deployment time. i haven't looked at it yet, hoping preilly would get to it [19:40:05] michelle's making soup, by the way, she'll be back on shortly [19:40:12] awjr, preilly had approved its performance [19:40:17] oh sweet [19:41:02] MaxSem ok cool, i'm taking a look now [19:41:10] rather, in just a minute [19:44:11] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [19:44:51] sorry folx [19:44:55] MaxSem: hang on weirdness going on with this commit [19:44:59] ran down to see to my soup what's up [19:46:28] MaxSem just https://gerrit.wikimedia.org/r/#/c/39076/ ? [19:46:28] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [19:46:50] awjr, yes [19:46:54] jcmish i think MaxSem and jdlrobson had a question about a last minute merge [19:47:00] cool MaxSem, looking now [19:47:15] sure which one [19:47:15] ? [19:47:29] jcmish, how much testing is needed before deploying an alpha feature? [19:47:46] depends on how big what's the feature? [19:48:01] https://gerrit.wikimedia.org/r/#/c/39155/ [19:49:44] okay that one doesn't scare me [19:49:45] I'll go test it now [19:49:56] if it passes the sniff test I say we give it a shot [19:50:06] okay [19:51:46] MaxSem: i don't see anything scary jumping out at me from that changeset, but i still need to test. [19:51:56] MaxSem did you say you wanted the entire extension reviewed as well? [19:52:13] awjr, I think it was already reviewed before [19:52:21] k [19:52:22] anyway, the diff covers most of it [19:52:29] ok cool [20:01:55] MaxSem: i think this looks ok, but i feel rushed testing this. can we save deploying this for later this week? [20:02:06] of course [20:02:18] groovy [20:03:15] ok, gonna grab lunch before the deployment. MaxSem i'll wrap up testing PageImages in a bit [20:03:30] awjr, no hurry with PI then [20:03:51] cool MaxSem [20:22:24] okay, I say it's a code freeze [20:24:39] jdlrobson: [20:24:48] where is the donate mobile page? [20:24:53] how do I get to it? [20:25:25] I'm in alpha and logged in [20:26:55] i saw it in the left nav menu on jon's computer, jcmish [20:27:24] thanks Maryana let me update staging again [20:27:29] and see if I didn't pull the code [20:27:58] np :) [20:43:02] jdlrobson: MaxSem go ahead with https://gerrit.wikimedia.org/r/#/c/39155/ [20:45:12] jdlrobson, are you going to address Siebrand's comment? [20:49:03] ping ping [20:50:36] jdlrobson, you here? [20:54:30] * MaxSem tries to figure out who's around. no awjr, no jdlrobson, jcmish's here. brion, Maryana, jgonera? [20:54:39] wot [20:55:23] we're deploying in 5 minutes. or not - cuz a quorum is needed;) [20:55:30] whee [20:56:29] i say yes [20:56:30] New patchset: MaxSem; "Bug 42705 - editing sometimes sends user to desktop site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37600 [20:56:38] do I count as a quorum? :D [20:56:57] yeah, you're a blocking force in it [20:57:24] but still I'd like to have someone from j* gang around [20:58:19] jcmish, do you feel like testing https://gerrit.wikimedia.org/r/#/c/37600/ during today's deployment? [20:58:34] tfinc, where's everyone? [21:03:25] hey [21:03:29] sorry went for lunch with awjr [21:03:34] boo [21:03:42] erg https://gerrit.wikimedia.org/r/#/c/39155/7/MobileFrontend.i18n.php [21:03:54] can i fix this after / quickly amend? [21:04:44] you have a bit of time cause bsitu's still deploying [21:04:45] MaxSem: looking at it [21:05:54] New patchset: Jdlrobson; "add a donate image page [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [21:06:01] MaxSem: yeah [21:06:03] done ^ jcmish MaxSem [21:06:04] I can look at that [21:07:25] jdlrobson, we will also need to amend these messages to explain about CC otherwise we can get some spanking from legal [21:07:37] which messages MaxSem ? [21:07:51] we have "Note: All photos you publish will be published under a CC BY-SA 3.0 license" [21:07:54] "Help bring these pages to life by donating your images that you are willing to give away" [21:08:11] The information is given just before the upload which I think is more important [21:08:20] this sounds vague from a copyright POV [21:08:37] New review: MaxSem; "Ehm, alpha only." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39155 [21:08:37] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39155 [21:08:38] possibly - i don't argue we should get legal advice before pushing to stable [21:08:51] jdlrobson, even to beta [21:08:57] roger MaxSem [21:09:06] Maryana: something you could look into ^ ? [21:09:13] even to alpha - better fix it by tomorrow's localisation update [21:09:56] New patchset: MaxSem; "Bug 42705 - editing sometimes sends user to desktop site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37600 [21:10:23] okay, we have green light [21:11:30] what I'm going to do is pull https://gerrit.wikimedia.org/r/#/c/37600/ on fenari and try testing with it [21:11:41] awjr, sounds good?^^ [21:11:55] MaxSem: yessir [21:17:34] awjr, brion, jdlrobson, jcmish, jgonera, Maryana - we're live on testwiki, please test [21:17:39] \o/ [21:17:46] MaxSem is this just for the redirect change, or all changes? [21:17:48] will do [21:18:03] awjr, redirect is rebased on top of master [21:18:06] \o/ indeed [21:18:08] k [21:18:14] * jdlrobson boots up the windows phone [21:19:37] MaxSem: the redirection changes actually seem ok [21:20:04] wooo [21:20:06] changelog: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-12-18 [21:20:40] mmm, I'm having Guru Meditation trying to edit SF [21:21:04] wait, i thought editing was moved to alpha mode? [21:21:14] i am seeing it in beta still [21:21:17] jdlrobson: ^? [21:21:34] awjr: incorrect [21:21:36] editing stays in beta [21:21:40] k [21:21:42] MaxSem: wfm [21:22:17] Howie said "Photo uploads, random article, and table code should be in alpha. Mobile Editing stays in beta." [21:22:21] how do I get an image donation suggestion? [21:22:28] \o/ cleanup templates [21:22:33] jdlrobson: perfect, thanks [21:22:48] MaxSem: i'm not seeing device specific styling on windows phone [21:23:31] MaxSem: is device detection setup on test? [21:23:39] testing on firefox os phone… :) …. account creation giving me "ran out of captcha images" error :( [21:23:40] jdlrobson: should be [21:23:47] jdlrobson: uses the same as the rest of the cluster [21:23:50] mm [21:23:58] brion, that's something Aaron-related:) [21:24:14] weird clearing cache.. [21:24:34] nope.. don't seem to be being served ie.css [21:24:35] brion are captcha images unique to each project, or are they shared? [21:24:44] MaxSem did you sync-common on srv193? [21:24:50] arggg [21:24:50] yes [21:24:54] hmm [21:25:02] non beta testing looks good [21:25:16] opps now I have to sy non beta and non alpha :D [21:25:16] awjr: they're shared [21:25:19] hmm MaxSem just got a 503 from varnish on editing [21:25:23] brion then that's hella weird [21:25:26] probably the NFS mount died or something [21:25:38] ;_; [21:25:49] jerith: yo [21:26:03] New patchset: Jdlrobson; "remove random sentence" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39314 [21:26:05] ^ awjr MaxSem this is probably the reason [21:26:33] New review: MaxSem; "o_0" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39314 [21:26:33] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39314 [21:26:36] whoops [21:26:40] jdlrobson: is there a less file for that? [21:26:53] New patchset: MaxSem; "Bug 42705 - editing sometimes sends user to desktop site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37600 [21:26:54] nope not device stuff [21:27:55] updated, running sync-common on srv193... [21:30:18] jdlrobson, synched [21:30:22] thx max [21:30:33] \o/ works :D [21:31:07] hmm im seeing a double arrow with broken toggle in the footer on the 'saving…' page after edit [21:31:16] really?! that guys back? :( [21:31:22] so is the syling missing because of reurnning the sync? [21:31:58] jdlrobson: im only seeing it on that page [21:32:10] jdlrobson: oh, also on the 'edit' page [21:32:41] weird bug on IE where overlays sometimes come out with a dark background instead of light [21:33:02] seems to be special pages only [21:33:07] * jdlrobson cuts a bug [21:33:30] already on stable so not a new bug [21:35:34] I've reverted to master for now due to guru meditation. goddamn cultists [21:36:40] hahhaha [21:37:48] MaxSem: i wonder what was causing that, it didnt seem reliably reproducible [21:37:50] account creation page + captchas are a bit screwed [21:38:03] https://test.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page&type=signup <- same on desktop site, no captcha images [21:38:26] brion, that's Aaron doing something [21:38:55] testwiki ran out of captchas [21:39:06] MaxSem: doing something in the code? doing something on the server? [21:39:25] something with captchas:) [21:39:38] MaxSem did you already revert the redirect change? [21:39:46] or he's been fixing this... [21:39:50] awjr, yes [21:40:11] ok, there's a problem with the success page from CentralAuth then - it's not converting links to use the .m domain [21:40:15] awjr, and it seens that I shouldn't have cause I still see it [21:41:30] MaxSem you mean you're still getting the 503 error? [21:41:34] yup [21:41:51] MaxSem i only got the 503 when i tried to edit the SF article, but on the shorter articles i edited i never saw it [21:42:11] so it's prolly an overload [21:42:12] im a little nervous that we can't test the account creation form [21:42:37] MaxSem: labels look a bit screwed up on watch list page due to lack of messages :/ [21:42:38] and now im seeing styles missing ... [21:42:51] MaxSem: is editingz san francisco article yeyyy watchlists [21:42:55] i'm stalking the shit out of you! [21:43:12] jdlrobson just made an edit to unicorns [21:44:31] hey awjr [21:44:36] hi pubsez [21:44:42] I found the problem yesterday [21:44:52] what was it? [21:44:59] the issue was that, I created an alias for mobile urls [21:45:26] e.g. /mywiki/mobile/index.php/title => /mywiki/index.php?title=title&useformat=mobile [21:45:49] okay, since the 503 wasn't caused by my redirection changes, putting em back [21:45:49] this causes a problem in Wiki.php when it sets the squid max age to the configured one [21:46:06] because in_array returns false [21:46:41] this line specifically: in_array( $request->getFullRequestURL(), $requestTitle->getSquidURLs() ) [21:46:59] pubsez, sorry - we're in a middle of deployment [21:47:05] ops, sorry [21:47:31] pubsez, we'll poke at it as soon as we finish [21:47:34] pubsez ahha that makes sense [21:47:49] sure, I think I explained it all :) [21:48:14] MaxSem: did donate image get added ? [21:48:22] jdlrobson, it was [21:48:27] i can't see it - is it possibly because I can't upload images to test? [21:48:31] a permissioning problem? [21:50:03] http://test.m.wikipedia.org/wiki/Special:DonateImage [21:50:08] that works but not showing up in menu :( [21:50:09] maxsem@fenari:/home/wikipedia/common/php-1.21wmf6/extensions/MobileFrontend$ mwscript eval.php testwiki [21:50:09] > $u=User::newFromName('Jdlrobson');var_dump($u->isAllowed('upload')); [21:50:23] bool(true) [21:50:28] bath what's going on [21:50:47] "Notice: Undefined variable: data in /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMobile.php on line 630" eek [21:51:45] I don't see it in production [21:51:55] face palm [21:51:57] it's only alpha [21:51:59] sending fix [21:53:23] New patchset: Jdlrobson; "fix an epic fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39316 [21:53:23] MaxSem: ^ [21:53:44] there are no epic fails in alpha. only dragon eggs. [21:54:02] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39316 [21:54:25] jdlrobson, that's why I don't laike last-second commits [21:54:40] MaxSem: to be fair it was a last second change that you asked for ;-) [21:54:40] a bit of testing would have shown it up:) [21:54:42] but yeh i know [21:54:52] sorry bout that [21:55:13] New patchset: MaxSem; "Bug 42705 - editing sometimes sends user to desktop site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37600 [21:55:59] jcmish: what do we have left to prune on the testers list ? [21:56:03] jdlrobson, live [21:56:23] awjr, what do you think about redirects? [21:56:30] tfinc the folx that aren't in list [21:56:37] but are in the device list [21:56:53] you were gonna take a stab then I was gonna update the spreadsheet [21:57:07] jcmish we should file a bug about this - success page served by CentralAuth for logout provides a desktop link for logging back in [21:57:11] should I go ahead and add them? [21:57:27] awjr already on my list :D [21:57:31] thanks jcmish :) [21:57:37] saw that will file in a sec [21:57:39] no prob [21:58:01] MaxSem: things generally look OK without the redirect code, but i wonder if not having it is causing the bug i just mentioned [21:58:04] should I add CentralAuth to the ticket ... will that e meaningful? [21:58:28] awjr, then let's not risk it today [21:58:48] jcmish: did you add the ones we were uncertain about to the spreadsheet ? [21:59:05]