[10:52:34] Hi [10:53:04] I've just installed the Wikipedia beta mobile app, and I must say I'm thrilled to see the Solarized theme. [10:53:17] I can't seem to find where to log in, however. [11:55:16] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39777 [12:00:30] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39519 [12:41:44] omg self-merges [15:58:26] Hello, I'm having a problem in an article because images which are large and centered appear distorted in the mobile version. [15:59:17] Wehwalt, on which page? [15:59:29] Richard Nixon [16:02:44] mmm, indeed [16:02:49] I'll file a bug [16:04:07] OK. Thanks. Can you leave a note on its talk page saying you are doing it? The question of whether to feature it on the main page is being discussed at TFA/R and this is an issue, and I'd like to be able to point to something on wiki. [16:05:23] And do you think it would be fixed by January 9, which is the requested date? [16:05:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=43425 [16:05:56] no idea [16:06:17] OK, well, you've been a great help. Thanks. [16:06:18] we'll discuss it today [16:06:29] Oh, good. I appreciate this. [17:33:13] Hey I am new to wikimedia -mobile , I have referred the page http://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Mobile_tutorial#Second_Exercise , but I have one problem in second excercise , I am receiving only one article ,whenever I am clicking the "Show Random" menu [17:34:16] yuvipanda, ^^ [17:34:57] hello sakth [17:35:03] what do you mean by 'receiving only one article'? [17:35:20] yuvipanda: I mean the same article every time [17:35:22] New patchset: Brion VIBBER; "* (bug 43425) Fix aspect ratio on images reduced to fit width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40567 [17:35:57] sakth: did you put a debug statement inside the done function to see what was being returned? [17:36:23] yuvipanda: no [17:36:28] try that? [17:39:56] yuvipanda: I have logged the title , it displays "Ondina diaphana" [17:40:21] does it display that article? [17:40:47] yuvipanda: yeah [17:40:58] and when you do it again it shows you the same article? [17:41:02] and log also shows the same? [17:41:11] yuvipanda: yes [17:41:14] ... [17:41:22] that's weird [17:42:12] hmmm, caching maybe? [17:43:17] just checked ApiSandbox to be sure [17:43:35] sakth: try adding a cache bust to it? [17:43:55] just an extra parameter [17:43:56] to the request [17:44:44] yuvipanda: APISandbox showing different articles [17:46:00] yeah, i just checked [17:46:05] i am guessing this would be a cache issue [17:46:10] which phone are you testing on? [17:46:12] yuvipanda: I just uninstall and install the app , now it is showing different article [17:46:26] yuvipanda: android [17:46:35] which phone? [17:46:41] yuvipanda: but now it is showing the same different article [17:46:51] yeah definitely caching issue [17:47:04] add a cachebust? [17:47:21] yuvipanda: I am not aware of cachebust [17:48:20] sakth: you just add an extra random parameter to the request [17:48:24] so that it does not hit the HTTP cache [17:48:46] so in addition to the 3 params you're passing, you just pass one more [17:48:50] like the current time or something [17:48:52] doesn't matter what it is [17:49:00] since it is different, it'll break the cache [17:50:56] hey awjr [17:51:02] hey MaxSem how's it going? [17:51:46] awjr, can you review https://gerrit.wikimedia.org/r/#/c/40567/ cause the deadline is in 10 minutes:) [17:52:24] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40567 [17:52:26] sorry connection troubles [17:52:28] MaxSem done :) [17:52:37] cheers [17:52:45] yuvipanda: I just added name parameter , but it is showing the same [17:53:26] Wehwalt, looks like we're deploying a fix today [17:53:34] \o/ whee [17:53:42] MaxSem: are you available to manage the deployment today? [17:54:00] sakth: 'name parameter'? [17:54:04] i dont mind doing it but have my hands full [17:54:19] same for me:) [17:54:21] yuvipanda: you said any parameter ? [17:54:33] yeah, any paramter with a random value [17:54:40] also, what phone are you using? [17:54:55] MaxSem: ok - i'll take it today [17:55:00] yuvipanda: android 2.3.3 emulator [17:55:05] thanks [17:55:09] yuvipanda: I just gave name:"something" [17:55:37] hmm the calendar event for today's deployment disappeared [17:55:38] that's not very random :) [17:57:15] yuvipanda: ok I will add date [17:57:22] ok :) [17:57:25] yuvipanda: sorry time [18:01:01] yuvipanda: I just added seconds : new Date().getSeconds(); [18:01:08] yuvipanda: now it is working [18:01:11] :) [18:01:14] yuvipanda: thankyou [18:01:15] that's a cachebust :) [18:01:22] you should not be adding seconds though. [18:01:28] try adding just a random number [18:01:28] or [18:01:32] unix timestamp [18:01:35] if you just add seconds [18:01:40] then they'll recur [18:03:28] yuvipanda: even though it recur , it shows a random article [18:03:40] it will recur every minute [18:03:46] yuvipanda: I mean it is different from the last one or not [18:03:59] so at 04:30:01 (4 hours 30 minutes 1 second) the article you get [18:04:06] will be the same as you get on 04:31:01 [18:04:11] or 05:33:01 [18:04:17] only the last part of that is unique [18:05:27] yuvipanda: yeah got it , thankyou [18:05:56] sorry again [18:05:57] shitty connection [18:06:02] sakth: did you get my messages [18:06:02] ? [18:06:09] yuvipanda_: yes [18:06:22] :) [18:06:32] so you need to either use a random number [18:06:39] or a unix timestamp [18:06:43] so that it is mostly 'unique' [18:06:59] yuvipanda_: yes [18:07:08] :) [18:07:17] there are plenty of resources around the web for understanding how caching works [18:07:22] i suggest you read through a few of them [18:09:19] yuvipanda: sure [18:09:36] :) [18:10:22] grr i can't get on mozilla's irc from my 4g connection and my parents' wifi is too unreliably [18:10:26] first world problems man [18:11:12] aha it's verizon's fault. bastards [18:12:01] why is verizon blocking irc.mozilla.org? seriously wtf [18:14:27] brion: actually, I kinda wonder if Moz should know about that, sounds really iffy. [18:14:43] yeah there's a note on https://wiki.mozilla.org/IRC about it [18:15:33] dang [18:15:34] i should probably do my irc through my server anyway so i get back scroll when i'm not in, i'm just too lazy to set it up [18:15:41] MaxSem: Thank you, glad to hear that. [18:18:51] be back later, i'll help with testing after the deploy. wheee! [18:36:53] * jdlrobson looks around [18:37:38] New review: Jdlrobson; "Max please can you add a utility to the Makefile to do this... I never remember and this would be ve..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39343 [18:38:17] New review: Jdlrobson; "How would you suggest doing this Max?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39750 [18:40:46] New review: MaxSem; "Too late to merge for today's deployment anyway:) I just feel that you will keep forgetting this unl..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/39343 [18:41:02] MaxSem: a hook will stop me forgetting [18:44:14] jdlrobson, set MobileFormatter properties as always [18:46:35] brion & jcmish, do we have a test plan for Zero? [18:47:16] for today? or just in general? [18:47:41] MaxSem: we still have a week no? [18:47:51] in general [18:48:00] jcmish, a week till what? [18:48:22] I thought it was being pushed piecemeal or did I misunderstand? [18:49:16] I need to refactor a lot of MF/Zero interaction but I feel like I don't know if I'll break something [18:49:43] k gotcha. Let me ponder it and give you an answer tomorrow? [18:50:08] I've been looking at it but not really focusing on it as much as I would need to in order to come up with a plan [18:50:20] it looks like it touches a lot of things [18:51:29] ok [18:59:46] jcmish: how are you feeling? [18:59:55] blech [19:00:03] but I'm propped up on pillows :D [19:00:09] im sorry to hear that! [19:00:22] tis the way :D [19:00:54] good thing I don't dig ditches for a living :) [19:01:03] ha! [19:07:56] New patchset: Jdlrobson; "remove close this section [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39750 [19:07:56] jcmish: welcome to the club [19:08:11] coughing since I got back :( [19:08:17] very tired [19:08:20] :( sorry jdlrobson [19:08:33] I so hate being sick [19:09:07] jgonera: if you are there can you check https://gerrit.wikimedia.org/r/#/c/40318/ and +2 it ? it's annoying the hell out of me (no effect on todays deployment) [19:09:19] jcmish: me too :( [19:09:25] jdlrobson, one moment [19:09:25] especially when i need to see people! [19:09:44] hehe I'm using it to keep me from seeing people :D [19:10:17] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40318 [19:10:21] jdlrobson, done [19:10:37] thanks jgonera [19:11:50] Maryana, how urgent Last Modified is? it seems we have more problems with i18n (Max's comments on https://gerrit.wikimedia.org/r/#/c/39176/3/javascripts/common/mf-application.js) [19:12:31] hmmm [19:12:58] arg, that's unfortunate [19:13:51] jgonera: it's not urgent, but it's the kind of feature we'd hoped to reuse in a few places as a way of educating readers about the fact that wikimedia content is changing [19:14:49] New patchset: Jdlrobson; "fix background color of header (bug 43242)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40571 [19:15:11] jgonera: how about just supporting it on en wiki ? [19:15:15] e.g. if wfLanguageCode === 'en' [19:15:22] with a FIXME (in the name of progress) [19:15:39] sounds good to me, MaxSem ? [19:15:42] how is the desktop lastmodified currently being supported? [19:16:36] * MaxSem doesn't like temporary hacks because they tend to become permanent [19:16:56] Maryana, they can use the resource loader, we still can't... [19:17:02] ohh, right [19:17:28] well, we get rid of the hack as soon as two people review this: https://gerrit.wikimedia.org/r/#/c/39162/ [19:17:55] how's our progress on full resource loader integration? [19:18:31] jdlrobson & whoever else is working on it ^ ? [19:18:35] basically the changeset I just posted is blocking the i18n API [19:19:01] it's been waiting for review for 9 days [19:19:07] * jdlrobson doesn't like the need for hacks due to failure to be bold and make bold changes to code [19:19:44] if RL is blocking stuff, we should prioritize it ahead of any dependencies and just apply a lot of muscle to it [19:20:03] jgonera: i thought there was another patch you were waiting on? [19:20:17] well, I'd say we don't need a lot of muscle, just 5-10 minutes of people who work on the core to review this changeset ;) [19:20:32] brion, can you review https://gerrit.wikimedia.org/r/#/c/39162/ ? [19:20:59] jdlrobson, not really, I mean, there's Mark's new API which is also waiting for review but we don't have to use it right now, we can switch when it's reviewed [19:21:06] jgonera: if someone from the team doesn't merge that change, email wikitech about needing review for https://gerrit.wikimedia.org/r/#/c/39162/ and CC Roan and Trevor Parscal [19:21:20] awjr, ok [19:21:24] looking [19:21:27] jgonera: this patch is harmless [19:21:31] i'd hope brion could review it and ok it [19:21:37] since he worked a lot of the RL stuff [19:21:46] seems silly having to email wikitech [19:22:14] looks ok lemme double-check it real quick :) [19:22:51] jgonera: you can also try poking RoanKattouw and TrevorParscal on IRC (they both usually hang out in #wikimedia-dev), though im not sure what their schedules are like this week [19:23:17] trevor is idling as Trevor|afk [19:23:39] ok, let's see what brion says ;) [19:23:49] the change does seem trivial enough though, hopefully brion will be OK with it :) [19:24:08] jgonera: yeah - in the future though, those are good folks to poke for RL stuff. also, Krinkle [19:24:19] ok [19:27:16] MaxSem: any idea what https://bugzilla.wikimedia.org/show_bug.cgi?id=41546 is about? [19:27:18] oh i see why this isn't working. we load the mobile module funny still… lemme try on another module :D [19:27:46] \o/ [19:27:48] ok looks good [19:36:18] All going to run and grab some meds and make some tea [19:36:21] back in a little bit [19:41:21] brion, thanks for merging, so this will become available on Wikipedia after the next core deployment? [19:41:51] jgonera, can be deployed off-band [19:42:37] MaxSem, oh, ok, so when can I expect it? [19:43:14] assuming platform permits it, we can cherrypick it today [19:43:35] however, too late to adapt your MF change ant test it anyway [19:43:57] anyway, let [19:44:14] let's get this deployed before our next deployment [19:50:37] jdlrobson: can we use local storage for the CTA issue? [19:50:48] awjr: not reliably [19:50:57] for example: [19:51:12] i go to the San Francisco page click the watch list star. Click login but then get distracted [19:51:41] Now when I login /register next do I automatically watch the San Francisco article? [19:52:02] Cookie would be the most straight forward way to do that as it already has a concept of expiry [19:53:01] jdlrobson: yeah - that makes sense, but cookies will have an impact on caching (since we vary on cookie), so the same example you gave would be problematic for cookies [19:54:01] i think if someone gets distracted from logging in, the action just should not get completed [19:54:54] can we use returnto and returntoquery for it? [19:55:09] with query pointing to action=watch [19:55:12] jdlrobson: we might be able to do this totally in PHP without cookies/local storage etc with a query string and invoking a hook after login but before redirect [19:55:19] or that [19:57:01] MaxSem: this is what i wanted to avoid [19:57:14] hah [19:57:18] GET should always be safe [19:57:29] sometimes, we have to live with what we have;) [19:57:36] never [19:57:40] i'm a purist [19:57:46] it's already there, whether you want it or not [19:57:52] so why not use it? [19:57:52] not in mobile [19:57:56] and i want to keep it that way [19:58:15] jdlrobson: i do not understand the problem with that approach? [19:58:20] idempotence awjr [19:58:32] http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2 [19:58:52] * MaxSem pours some dirt on jdlrobson so that he becomes less pure [19:59:48] * yuvipanda pours some realism (or 'pessimism') on jdlrobson  [20:00:15] jdlrobson: well if we can think of a solution that will not further pollute the cache but still meets the goal, then im all for it. but otherwise, i do not think there's a good alternative and we need to operate with the constraints/existing functionality of MW [20:00:23] yuvipanda: code specific to mediawiki/wikipedia is not realism [20:00:45] what awjr said. [20:01:10] 'perfect the enemy of the good, etc' [20:01:57] mmm, can we embed a second returnto into action=watch? :D [20:02:09] @_@ [20:11:18] i think i have an idea that might work [20:12:41] if it's longer than 3 lines of code, use action=watch instead:P [20:14:13] MaxSem: that makes no sense - using action=watch would require more than 3 lines of code [20:14:27] you need to parse the url [20:29:07] jgonera, are you in the office today? [20:29:20] Maryana, yes [20:30:42] k, cool - vibha wants to check in on watchlist stuff sometime later today [20:31:49] awjr, I've prepared the PageImages changes: https://gerrit.wikimedia.org/r/#/c/40575/ https://gerrit.wikimedia.org/r/#/c/40572/ https://gerrit.wikimedia.org/r/#/c/40570/ [20:32:51] awjr MaxSem: awjr k think i found a nicer way to do this using localStorage [20:33:09] cool MaxSem., i'll get those merged in a sec [20:33:23] jdlrobson: sweet! [20:34:03] jdlrobson, http://youtu.be/GlecTBevmzc [20:34:44] Maryana, ok, I sent her an e-mail [20:35:59] MaxSem merged and looks OK [20:36:09] whee, thanks [20:50:46] jcmish: everything looking ok? can i begin merging code to the deployment branch? [20:51:02] let's do it! [20:51:06] w00t [20:51:27] after we wrap up with testing on prod I'll probably go lay down [20:51:36] but I'm good until we're done [20:51:46] did y'all just put something on test/test2wiki? [20:52:58] chrismcmahonbrb: shouldn't have [20:53:10] at least on mobile test [20:53:17] chrismcmahonbrb: not yet [20:53:25] jcmish: thanks, just got some unexpected failures, but might be just a flake [20:53:46] chrismcmahonbrb: ah okay let me know if they stick around after the deploy and I'll take a look [20:54:09] New patchset: Jdlrobson; "watch an article automatically after a successful login" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40580 [20:55:15] chrismcmahonbrb, but we're deploying a new extension today (not live yet) [20:55:25] wheeee! [20:55:59] MaxSem: PageImages is going live today? [20:56:10] wonderful! Wheee! [21:01:33] ok, we are up on testwiki (including PageImages) [21:01:44] MaxSem, jcmish, jgonera, brion, PythonPanda ^ [21:01:48] please test :) [21:02:00] i'll poke from my phone, lunchtime :) [21:02:02] jdlrobson: ^^ [21:02:55] Maryana: ^^^ [21:03:04] changelog here: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-12-26 [21:03:10] sweet [21:05:31] on it [21:05:51] awjr, I don't see PI at https://test.wikipedia.org/wiki/Special:Version [21:06:21] MaxSem oh, i still need to sync common/initialize settings [21:06:22] one sec [21:06:35] awjr, is this needed for testwiki? [21:06:43] MaxSem: i think so [21:07:33] awjr can we get that link added to the calendar invite? [21:08:29] wait a minute i'm confused… photo uploads got promoted to beta but the other changes didn't? [21:08:55] jdlrobson: the link is included in the regular calendar invite, but somehow today's had gotten deleted. i readded it this am but neglected to add the link. [21:09:58] is it a known issue that when I switch between stable/beta/dragons I have to refresh the page manually to see the changes? [21:10:13] Android 4.1 browser [21:10:28] awjr, configuration changes haven't been pulled, I'm doing it [21:10:39] MaxSem: im in the middle of it [21:11:03] hmm [21:11:04] MaxSem: done [21:11:08] something went boom [21:11:10] I see a weird breakage in commonsettings [21:11:18] cool, thanks [21:11:27] says our servers are currently experiencing a technical problem [21:11:39] yeah i see that - one sec [21:11:42] whee, my bad [21:11:43] k [21:12:02] haha, internal server error message asking for donation ;) [21:12:11] holy crap, do we need to run scap to get an extension enabled on testwiki? [21:12:30] MaxSem: ^? [21:12:53] sync the extension first before the cob fig? [21:12:56] awjr, no, I'm including a directory:0 fixing in a sec [21:15:04] awjr, https://gerrit.wikimedia.org/r/#/c/40682/ [21:15:05] fixed [21:15:15] holy crap MaxSem sorry, i should've caught then in review [21:15:19] * MaxSem slaps himself [21:15:32] * awjr slaps himself and MaxSem too [21:16:16] awjr, the moral is to never sync while testwiki is broken or you can break the cluster [21:16:45] this time it was protected by PI being enabled just on test [21:16:54] MaxSem, i didn't. testwiki broke because of the bad require in common settings, but since the ext was enabled only on test it was OK [21:17:14] I was referring to [01:10:35] <+logmsgbot> !log awjrichards synchronized wmf-config/CommonSettings.php 'Enabling PageImages on testwiki' [01:11:04] <+logmsgbot> !log awjrichards synchronized wmf-config/InitialiseSettings.php 'Enabling PageImages on testwiki' [21:17:36] MaxSem: dont you need to sync those files before config changes show up on test? [21:17:51] no [21:18:07] testwiki works off NFS [21:18:54] ok, my bad :( [21:18:58] * awjr slaps himself again [21:19:13] whee https://test.wikipedia.org/w/api.php?action=query&prop=pageimages&format=json&pilimit=10&titles=San%20Francisco [21:19:17] :D [21:21:29] not really much to test here so seems good to me [21:22:05] photo upload in beta seems not right to me [21:23:05] for instance, http://test.m.wikipedia.org/wiki/San_Francisco has a call to action for a photo upload (it shouldn't) and other pages do not, like http://test.m.wikipedia.org/wiki/Report/Page_list, (that sould) [21:23:06] *should [21:23:10] jdlrobson: ^ [21:23:25] jcmish, Maryana ^ [21:23:34] awjr: jdlrobson: wait a minute i'm confused… photo uploads got promoted to beta but the other changes didn't? [21:23:43] jdlrobson: what other changes? [21:24:06] is that why it's taking so long? [21:24:09] to upload? [21:24:09] all of these - https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:imageuploadthumb282,n,z and all of these https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:story282,n,z [21:24:19] chrismcmahonbrb, see any breakage on testwiki? [21:24:35] in tests i mean [21:24:48] MaxSem: my flaky tests were in fact just flaky and passed on re-run [21:25:11] jdlrobson: those are not merged, so no [21:25:15] awjr: i know [21:25:26] jdlrobson: now i am confused [21:25:39] https://gerrit.wikimedia.org/r/#/c/40305/ < i wasn't expecting this to merged without them though [21:25:53] the idea was to have all those changes merged, and *then* have uploads promoted to beta [21:26:05] Maryana: agreed [21:26:16] i see [21:26:22] but i did all the patches expecting they'd be merged by today but they weren't [21:26:45] there was no indication of that expectation in the commit message or comments for https://gerrit.wikimedia.org/r/#/c/40305/ [21:27:20] Maryana, jdlrobson is problematic as-is right now? [21:27:23] *is it [21:27:36] depends on how soon we can get those patches merged :) [21:27:41] to be honest there seems no point in doing a MFE deployment today... [21:27:47] deploying PageImages seems useful [21:27:52] but nothing has really changed in MFE looking at it [21:28:03] jdlrobson: there are bug fixes and at least one change another team is depending on that are scheduled for today [21:28:15] plus we do not have a deployment next week, so it would be nice to get what we can out otday [21:28:20] which change is that awjr ? [21:29:02] jdlrobson: https://gerrit.wikimedia.org/r/#/c/39617/ is the one another team is expecting [21:29:02] i see what happened - i thought my photo uploads stuff had been merged but actually it was on page 2 of the code review dashboard [21:30:02] Maryana: well those patches should get merged over the course of the rest of the week, but they wont get deployed until our next scheduled deployment (1/8) [21:32:06] okay other than the upload weirdness all is well [21:32:06] awjr, jdlrobson, can we revert 40305 for now? [21:32:11] so Maryana, options would be to proceed as-is, or we can try and back out those changes [21:32:22] right. that's unfortunate. i'd rather not have the feature hanging around beta in a weird buggy limbo state till then -- seems better to hold off graduating to beta for now [21:32:31] ok MaxSem, go ahead [21:32:35] and revert, i mean [21:32:40] Maryana: agreed with MaxSem [21:32:45] if we can just pull i it'll be easier [21:32:51] that's a long time to wait [21:32:52] New patchset: MaxSem; "Revert "move photo uploads to beta"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40742 [21:32:59] yep yep [21:33:00] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40742 [21:33:20] nobody uses the internet till after the new year anyway :D [21:33:28] hehe [21:33:38] in the future, if we have dependencies between patchsets, please make them obvious in commit messages or changeset comments [21:34:11] Ideally, in Gerrit deps [21:35:26] * jdlrobson hates gerrit deps [21:35:51] to be fair i could also make a comment about faster code review and about us checking stories/checking with product before promoting features to beta/production - it's a big deal [21:39:52] ok, change should be live on testwiki now [21:39:57] may need to clear your cache [21:40:00] k [21:43:58] jdlrobson: let's discuss further during the retrospective. we clearly need to resolve the code review backlog problem, but that needs to be weighed against realistic expectations during times like now, where folks are traveling/on vacation/etc. i feel like the current case is an exception to how we have been doing previously. if we need to create a convention about dbl checking all commits against their associated stories, etc, then we can figu [21:47:40] I added a pict to san francisco and it's throwing the table data off [21:47:47] when i look at it on my iphone [21:48:05] known issue? [21:48:21] jcmish: er sorry i just deleted that image :p [21:48:27] hehe [21:48:32] no worries [21:48:43] I was just testing was gonna delete after I showed it to someone [21:48:44] MaxSem is page images looking ok? [21:48:54] awjr, yes [21:49:03] scap? [21:49:14] MaxSem yeah im thinking scap first, then update config to enable everywhere? [21:49:30] https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-12-26 is confusing me - Uncategorized is from last deployment yes? [21:49:48] awjr, yes - first enable on test2, get Chris to run his tests and enable everywhere [21:50:08] I'll do that part, you just need to scap:) [21:50:23] MaxSem: ok, once i have go-ahead from jcmish and Maryana i'll scap [21:50:23] jdlrobson: some overlap yes but added them to be safe [21:50:38] figured I'd go and widdle them down after [21:50:45] awjr: I say go fo rit [21:50:48] *go for it [21:51:00] thumbs up from me [21:51:05] ok here goes [21:53:53] scap is running [21:54:17] \o/ [21:54:33] I'm running downstairs to find a stronger decongestant [21:55:15] back in a few [22:04:11] going afk for ~10mins [22:10:26] back [22:26:03] whee, scap is over [22:26:15] ok scap is done - jgonera, jcmish, MaxSem, biron, jdlrobson, Maryana [22:26:55] awjr: 282 is in "In Testing" when it should be in "Ready for testing" could you move that when you get a moment? [22:27:02] jcmish ^ [22:27:09] awjr: en.wiki and fr.wiki look fine to me [22:27:33] hmm, scap was fast today [22:27:41] it was, only 30 mins [22:27:52] gee, because we have only one wikiversion [22:28:06] so multiply by two next time;) [22:28:23] also 294 [22:28:35] i'd do it but i'm not allowed [22:29:20] try changing the status of the card instead of dragging [22:29:30] sometimes that works when dragging doesn't, for mysterious reasons [22:29:31] jdlrobson: jcmish has grabbed those [22:29:38] Maryana: that's a result of card transitions [22:29:41] New patchset: Jdlrobson; "promote photo uploads to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40752 [22:29:42] awjr: but they are not merged [22:29:48] so they cannot be tested [22:30:00] New review: Jdlrobson; "Please wait till other photo upload commits are merged" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40752 [22:31:04] jdlrobson: yeah i know - but jcmish is the one dealing with those right now, so i'll leave it to her to move them as needed [22:31:12] sorry guys [22:31:22] had to make the boy a sandwhich [22:31:27] things look fine to me in production [22:31:44] chrismcmahonbrb, can you run your tests on test2? [22:31:55] sure [22:31:59] jcmish: can you move 294 and 282 tback to "ready for testing" [22:32:00] (https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+Iteration%29%5D&group_by%5Blane%5D=status&lanes=Ready+for+Analysis%2CIn+Analysis%2 [22:32:01] dy+for+Development%2CIn+Development%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&tab=Story+Wall) [22:32:28] yup will do [22:32:39] hopefully adding the code review column will help that scenario in the future jcmish, jdlrobson [22:32:43] these are two still waiting for code review I believe? [22:32:45] :D [22:32:54] jcmish: yup [22:33:06] k moving them [22:35:12] all looks good to me [22:35:16] http://en.wikipedia.org/w/index.php?title=Der_neumodische_Liebhaber_Damon&action=history [22:35:17] :) [22:35:24] jdlrobson: all set [22:35:44] editing on mobile has become much easier now [22:36:57] Maryana: in what sense? [22:37:13] the expand-as-you-type boxes [22:37:28] i know that's been around for awhile. just pointing it out as a good change :) [22:42:13] fwiw, basic mobile tests are green in android/iphone/ipad, token desktop test is running but I don't expect an issue. [22:43:01] thanks chrismcmahonbrb [22:43:36] oi, forgot to change my nick 4 hours ago >.< [22:44:47] hehe [22:44:55] that's okay we knew you were back ;-) [22:46:24] chrismcmahon, thanks - so it's a go to deploy PageImages everywhere? [22:47:04] MaxSem: my automated tests are truly basic, I'm not the one to make the call on PageImages everywhere. [22:47:22] chrismcmahon, I just needed a no objections from you:) [22:47:35] no objections from me :) [22:47:42] per RobLa's email [22:48:46] I don't think I've seen robla's email, but I'm not sure what else I could do that you all haven't already done [22:49:46] chrismcmahon, "deploy to test2, let Chris run his tests, only then push everywhere lese" [22:49:53] s/lese/else/ [22:49:56] done, then [22:51:11] jdlrobson, what was that website/app that allows tunneling my local server? [22:51:38] localtunnel [22:51:40] ;-) [22:56:44] I'm fading fast so I'm going to go laydown for a while… I'll check my email later this evening. [22:59:35] whee "pageimage": "Barack_Obama_signature.svg" [22:59:56] more fail is always a win [23:00:26] New patchset: Jdlrobson; "remove overlay close button from special pages (bug 42744)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40755 [23:02:25] i'm feeling rough guys so i think i'm going to hit the hay. anything before i go? [23:04:20] hmm, at least "pageimage": "Flag_of_Russia.svg" [23:04:36] ...is what I've seen during my testing [23:10:59] brion, MaxSem, is there a way of fetching first x words/characters of the article in PHP? without any formatting [23:11:20] action=query&prop=extracts [23:11:43] from the php side…. i assume do whatever action=query&prop=extracts does :) [23:12:03] [[API:Calling internally]] [23:12:17] is that action implemented in core or mobile? [23:12:24] MF [23:12:24] ok, core I guess [23:12:27] oh [23:15:48] MaxSem, what's the proper way of using that inside another PHP file, should I just create an instance of ApiQueryExtracts and use it? [23:15:58] New patchset: Jdlrobson; "don't remove the sections on file page / remove special casing (bug 42741)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40757 [23:15:59] [03:12:04] [[API:Calling internally]] [23:16:10] oops, sorry [23:19:00] MaxSem, that seems like a lot of overhead for what I'm trying to do [23:19:44] I could whip up a PHP function [23:20:06] New patchset: awjrichards; "Fix possible php notice when 'query' not present in parsed url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40758 [23:20:48] hm, yeah, that could be a good idea, I just need that to show an intro for each article in the watchlist (https://mingle.corp.wikimedia.org/attachments/d163c65ffb1307f8f05cbe96814ab14f/201/Watchlist_Screen.png) [23:21:36] how many entries at once? [23:22:01] depends on how many items someone has on their watchlist [23:22:09] can be 1, can be 100 I guess [23:22:19] BANG! Server meltdown [23:22:23] ;) [23:22:28] can be 5000 [23:22:46] this function is expensive in worst case [23:22:55] yeah, probably, although we'll probably add some pagination or infinite scroll if people use it this way [23:23:50] we don't cache plain text of first sections of articles or anything like that? [23:24:17] we do aftyer we have it for the first tgime [23:24:36] if we don't... [23:25:18] I probably don't know all the complex layers of MediaWiki, but then what's the problem of fetching 100 rows from a database (assuming we will paginate after 100 items)? [23:28:58] the problem is that you need to have these 100 rows;) (we actually use memcached) [23:29:21] https://graphite.wikimedia.org/dashboard/temporary-19 [23:30:14] I think I don't have access to that [23:30:23] use labs creds [23:32:21] that's average response in ms? [23:32:46] New patchset: Ori.livneh; "Upgrade to full EventLogging & declare schema dep." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [23:33:28] average and 99th percentile [23:34:03] as you can see, caching works but when there's nothing in the cache fun ensues [23:34:47] so we're basically afraid that people won't have too many starred pages in common? [23:36:31] we're Wikipedia, we don't star we watchlist [23:36:41] [23:36:46] :D [23:37:28] I felt this was coming, but I'm not comfortable with using "watchlist" as a verb ;) [23:37:55] then use "add to watclist";) [23:37:58] MaxSem is whipping out his PHP again. [23:38:04] Better than his Python, I guess. [23:38:12] Susan: behave. [23:38:23] ori-l stalks "Python." [23:39:03] MaxSem, so it boils down to this: will getting first x words for at most 100 articles be possible? [23:39:20] jgonera, just wait till you get to the "unwatchlist" stage. and then you'll have to start conjugating it: watchlisted, will watchlist... [23:39:23] {{Infobox foo [23:39:31] possible, but it can take minutes in the worst case [23:39:34] Those are the first words of most articles. [23:39:56] Susan, I meant plain text, probably first section [23:39:57] we're not silly enough to count those as words [23:40:03] well, I'm leet enough to know this [23:40:29] Has anyone in here ever tried getting the first paragraph of an article? [23:40:32] It's no easy task. [23:40:53] I sure hoped it would be easier [23:41:05] susan: does knowing someone who did count? [23:41:24] Maryana: Not really. [23:41:27] http://en.wikipedia.org/wiki/Special:NewPagesFeed [23:41:38] oh susan. such a kidder. [23:42:23] > Matthew Le Tissier, three-time winner of the Player of the Year award in 1990, 1994 and 1995. Southampton Football Club is an English association f... [23:42:32] That's an image caption. [23:42:40] That's pretty much exactly what I'm talking about. [23:43:05] awjr, MaxSem: want to give this a shot? https://gerrit.wikimedia.org/r/#/c/40763/ [23:43:11] OTOH, if you're only looking at new pages, you have a distinct advantage. [23:43:25] Because most new articles start with paragraph text (prose). [23:44:27] ori-l, why start module names with schema? [23:44:49] MaxSem: they're not files; they're actually generated from schema on meta. [23:45:30] so that schema actually pulls meta.wikimedia.org/wiki/Schema:MobileBetaWatchlist and generates JS code that provides an API for logging events of that type. [23:46:15] Maryana: Speaking of... it seems nobody is patrolling new pages any longer? [23:46:32] there's a seasonal decline in all editing activity around this time of year [23:46:34] I looked at the backlog earlier today and there were month-old pages sitting unreviewed. I guess someone scared off DS. [23:46:34] does this introduce a PHP dependency on EventLogging? [23:46:47] Yes [23:47:07] see the last sentence of the commit msg [23:47:12] then it needs to be configurable as we have third-party users [23:48:01] RL may freak out when it sees an unknown module class [23:48:21] it does, yeah :/ EventLogging would have to be enabled. [23:48:46] but EventLogging is also open source and usable by third parties -- is that still a dealbreaker? [23:49:28] New review: MaxSem; "Please make it not break in absense of EventLogging to avoid breaking third parties," [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/40763 [23:49:44] absence [23:49:56] Ouch, -2. I may actually cry. [23:50:05] Pix. [23:50:08] yes - we don't want people to install whole WMF infrastructure [23:50:37] Heh, a healthy departure from past mobile development principles. :-) [23:50:38] OK, I'll update the change. [23:50:55] susan, p.s., you missed our disco night last friday in the e3 channel -- really a shame [23:51:08] Eep. [23:51:21] Maybe I'll make the next one. [23:51:52] absolutely :) [23:58:59] ugh, my favorite movie theater's website has just been "upgraded" - now it looks worse than ones of its competitors while before it was the opposite. yay to progress!