[00:02:50] New patchset: Ori.livneh; "Upgrade to full EventLogging & declare schema dep." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [00:03:02] MaxSem: speaking of "upgraded" --- [00:04:06] $wmgUseEventLogging is a WMF-specific variable. [00:04:53] MaxSem: how would you like me to check? Should I see if the class is defined? [00:05:19] I made the check for !empty( $wmgUseEventLogging ) rather than !== false for precisely this reason [00:05:28] probably. or go the C way with defines:) [00:05:38] probably the former [00:06:13] regarding empty() - what happens if a wiki does not have it set?;) [00:06:47] (hint: one evil PHP setting) [00:07:38] New patchset: Ori.livneh; "Upgrade to full EventLogging & declare schema dep." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [00:07:56] MaxSem: is there a setting that causes PHP to throw errors if a parameter to empty is unset? [00:08:00] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39344 [00:08:43] ori-l, there's a setting that imports request parameters into globals [00:09:03] https://www.mediawiki.org/wiki/Register_globals [00:10:30] $wgAutoloadClasses[ 'EventLoggingHooks' ] sounds promising [00:11:05] what does this have to do with $wmgUseEventLogging? 'register_globals' is both off by default for PHP 5.3 and deprecated, so it issues a warning [00:11:33] if you're barking mad and choose to use register_globals anyhow, EventLogging is the least of your problems [00:13:29] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39359 [00:13:30] I don't understand -- you'd like me to add it to wgAutoloadClasses in MobileFrontend? It's added in EventLogging.php, which (if EventLogging is configured) would always run before the hook. [00:14:42] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39573 [00:14:56] I proposed you to check for it [00:15:22] MaxSem: can you take a quick look at this? https://gerrit.wikimedia.org/r/#/c/40758/ [00:15:52] awjr, $prasedUrl [00:16:06] derp [00:16:44] New patchset: awjrichards; "Fix possible php notice when 'query' not present in parsed url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40758 [00:16:57] MaxSem ^ [00:18:18] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40758 [00:18:26] ty MaxSem [00:18:42] MaxSem: would you prefer: array_key_exists( 'ResourceLoaderSchemaModule', $GLOBALS['wgAutoloadLocalClasses'] ) [00:18:50] (a pattern I see elsewhere in our codebase) [00:19:00] or array_key_exists( 'ResourceLoaderSchemaModule', $wgAutoloadLocalClasses ) [00:19:14] with '$wgAutoloadLocalClasses' added to the global statement above? [00:20:10] I don't see much difference. generally, global $wgFoo; is seen more often in our code base. also why not isset()? [00:22:14] gah, should also be wgAutoloadClasses, not wgAutoloadLocalClasses. [00:22:19] isset is fine too. submitting a patch. [00:24:39] New patchset: Ori.livneh; "Upgrade to full EventLogging & declare schema dep." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [00:25:05] ^ MaxSem [00:27:00] ori-l, thanks! [00:28:10] awjr, what went wrong today? we didn't flush [00:28:34] MaxSem it did not seem we needed to [00:28:48] totally wrong [00:28:57] MaxSem: np -- thanks for quick feedback. [00:29:04] MaxSem what are you seeing? [00:29:16] nothing [00:29:23] AND THAT'S CREEPY [00:29:35] lulz [01:22:19] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39521 [01:22:19] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39520 [01:22:33] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39684 [01:24:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39755 [01:28:48] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39754 [01:32:46] New patchset: awjrichards; "respect address bar in random suggestions (bug 43241)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39778 [01:32:59] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39778 [01:33:22] New review: awjrichards; "ps i updated the commit message so it's clear this affects alpha only" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39778 [01:35:14] New review: Ori.livneh; "Maryana gathered enough data about section-toggling, so that stuff needs to get removed either way." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40763 [01:35:27] New patchset: Ori.livneh; "Upgrade to full EventLogging & declare schema dep." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [01:43:02] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39783 [01:47:42] New review: awjrichards; "LGTM, but please verify with product about the messaging if you haven't already." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/39782 [01:53:01] New review: awjrichards; "Minor messaging issue. Otherwise, this looks really cool :D" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37048 [02:29:44] New review: awjrichards; "See inline comment. This looks promising. Out of curiosity, is Apache Mobile Filter something that i..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40298 [02:31:47] New review: awjrichards; "Is this really related to story 282? I didn't see anything in the AC that seems to relate to this bu..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40313 [10:40:00] New patchset: Jdlrobson; "Improve ResourceLoader support for js/css [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40325 [10:54:15] New patchset: Jdlrobson; "check watch status for multiple articles in one request (bug 42587)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39758 [10:56:59] New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37048 [12:52:06] New patchset: Jdlrobson; "Improve ResourceLoader support for js/css [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40325 [12:59:42] New review: Jdlrobson; "Max I tried using pngcrush and it reduced from 2148 to 2062 - not much at all." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39343 [13:10:07] New patchset: Jdlrobson; "new approach to tables (alpha)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39343 [13:20:07] New patchset: Jdlrobson; "update pre-commit hook to crush pngs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40788 [15:02:34] New review: Jdlrobson; "Looks good to me - but will let Max ok before a merge" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40763 [16:23:24] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40763 [16:32:21] * yuvipanda looks around [16:38:33] yuvipanda, see me? [16:38:47] I do [16:52:25] pinging anything on wiki is timing out? [16:52:33] DNS looks fine [16:53:34] as in ping en.wikipedia.org [16:53:36] ? [16:53:38] WFM [16:54:04] yeah [16:54:13] ask in #-ops [16:54:17] yeah going there [17:02:36] MaxSem: wrong timing I guess :) [17:08:35] * awjr waves [17:09:10] hey awjr [17:09:17] hi yuvipanda how's it going? [17:09:31] awjr: pretty good, though I can't access wikipedia [17:09:36] packets don't go through [17:09:42] so trying to find someone in ops [17:09:43] ! [17:09:52] http://pastebin.com/fCSNAmJh [17:10:12] hmm leslie was on call yesterday, im not sure who is today - lemme see if i can figure it out [17:10:31] awjr: I asked in -ops and -tech [17:10:33] god nothing [17:10:35] any response [17:10:38] ok [17:10:56] yuvipanda: apergos is supposed to be on call right now [17:10:57] none yet [17:17:58] yuvipanda hop in #wikimedia-operations [17:36:00] MaxSem: you mentioned during the last retrospective that you felt a little out of the loop and unclear on your priorities because a lot of the work you've been doing hasn't been tracked in mingle story cards. should we try and come up with a few story cards for you for the next iteration (which starts 1/2)? [17:37:10] hmm [17:37:32] 1) OSM 2) GeoData 3) MF support [17:38:10] what are the actual things that need to be done for 1 and 2 in particular? is there anything around 3 that isn't already captured? [17:40:03] 1) have some time free of distraction [17:40:13] 2) replication and announcement [17:40:34] 3) no, but there are enough backend cards [17:41:16] MaxSem can we create some stories for 1 and 2? that way we can make sure they're prioritized against MF stuff. Getting replication going for GeoData could be one [17:43:23] even if it's just breaking this stuff down into tasks with an explanation of the goal [18:17:42] is there any way to automatically put my name on talk pages when I post something or I have to write it myself? [18:17:56] ~~~~ [18:19:14] is four tildas what I should put there or is it some new text/icon expression? [18:19:39] tyhe former [18:20:05] https://en.wikipedia.org/wiki/Wikipedia:Introduction ;) [18:21:19] thanks [18:24:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39748 [18:25:55] * jdlrobson waves [18:26:35] * Maryana waves back [18:26:50] pretty quiet around these parts [18:26:59] yeh i see [18:27:03] is tfinc around or on hols? [18:27:19] i think he's out [18:27:22] haven't seen him [18:27:54] :( - i want to get permission from him to book a flight before it goes super expensive [18:28:02] is story review still on for today? [18:28:58] New patchset: Ryan Lane; "Add support for Apache Mobile Filter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40298 [18:29:57] New review: Ryan Lane; "We're not using it in the cluster as far as I know. I'd just like to use the mobile view elsewhere a..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40298 [18:30:19] ^ Maryana [18:30:21] New review: awjrichards; "This looks fine to me and I'm happy to merge pending Max's satisfaction." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/39750 [18:30:43] i assume so, since awjr emailed me about it this morning :) [18:30:46] MaxSem: what do you think of jdlrobson's new approach on this? https://gerrit.wikimedia.org/r/#/c/39750/ [18:31:09] jdlrobson: i think tomasz is supposed to be back today [18:31:20] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40355 [18:31:32] awjr: \o/ i'll hold out a bit then - fingers crossed! [18:31:42] actually he said he'd be gone 12/24-12/27 [18:31:50] awjr: Maryana is the planning meeting 1pm-2pm PST? [18:31:53] so i dont know if that means through or to 12/27... [18:31:58] awjr: :( [18:32:01] jdlrobson: yes, but it should be short [18:32:05] i need to book this flight! :( [18:32:09] we dont have much to cover [18:32:25] jdlrobson: send him an email and maybe shoot him a text [18:32:53] i have [18:32:56] oh [18:32:57] :( [18:32:57] i can't txt :-( [18:33:01] my phone is blocked [18:33:06] doh! [18:33:09] well it can receive.. but not send [18:33:29] jdlrobson, what happened with your phone? [18:33:40] jdlrobson: mebe try facebook? [18:33:55] New review: MaxSem; "That's much better, thanks!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39750 [18:34:20] ergg rebasing [18:36:04] New patchset: awjrichards; "remove close this section [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39750 [18:36:08] jdlrobson: already took care of it [18:36:44] although i may have just screwed that up [18:37:21] git fetch ssh://awjrichards@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/50/39750/4 && git checkout FETCH_HEAD [18:37:23] gah [18:37:28] oh dearz [18:37:31] i have it ready.. [18:37:36] stop everything :P [18:37:42] New patchset: Jdlrobson; "remove close this section [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39750 [18:37:46] ^ merge that [18:38:27] ah one sec lemme test [18:38:37] can we finally get https://gerrit.wikimedia.org/r/#/c/39343/ merged as well? [18:38:42] tables have been broken for some time in alpha [18:38:44] yeah, i incorrectly interpreted that merge conflict [18:39:14] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39750 [18:42:35] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39343 [18:43:30] \o/ awjr [18:43:40] i like that approach, jdlrobson [18:43:49] me too I think it's definitely better [18:43:57] the last one was annoying the hell out of me [18:44:15] a stupid question: how do I view my cards? [18:51:11] MaxSem: not stupid.. Mingle is dumb. I guess you look under in development and see which one has you as owner [18:51:30] apparently you have none right now [18:52:20] Maryana: I need assets from https://mingle.corp.wikimedia.org/attachments/9643670438e6fe1416754c54b78d4407/192/Empty_watchlist_view.pdf [18:52:22] pdf is useless to me [18:53:45] jdlrobson, k, i'll ask vibha [18:54:16] also, it looks like we're not going to be able to implement the login call to action the way you were hoping - jorm sez no to ajax [18:54:37] Maryana: it's cool i took care of that [18:54:39] no need for ajax [18:54:46] it's not really the "ajax" posting; it's the loading of the login form on an insecure page. [18:54:49] experience could still be better by enforcing https [18:55:02] we'd have to enforce https on every page load for that to work. [18:55:40] just walked through the issues with awjr and jgonera; it's the same problem we have on the desktop site. [18:56:30] jorm, jdlrobson yeah - and we can't force https everywhere [18:56:49] since the redirector stuff can't support it right now (hopefully that's coming 2013q2) [18:56:55] but we CAN force https on login page [18:57:06] right. which is what we do, afaik. [18:58:43] are there any changes i need to make to the story card on this? https://mingle.corp.wikimedia.org/projects/mobile/cards/274 [18:59:31] maybe note that the spec isn't accurate, and that the flow is: tap star -> go to log in screen -> log in [18:59:51] as opposed to: tap star -> login form is revealed -> log in [19:00:03] flow should remain the same after that. [19:00:18] interesting. [19:00:35] desktop doesn't force https for the login screen but gives you the option to go to one. [19:00:40] we don't really have that option. [19:03:57] Maryana: i think just the designs need to be updated for 274; the acceptance criteria is still valid [19:04:34] jorm: we have a bug open about https on the login form, and i was planning on taking care of it this week [19:04:39] ok - but we're reusing the login/signup design, since we're basically just directing the user to that page, correct? [19:04:53] MobielFrontend used to force https on Special:UserLogin, i think, but ig uess that code got removed at some point [19:05:03] before we reimplemented the login form [19:05:06] yeah, i'd just write different' copy for the login screen. [19:05:32] i think there's already a way you can send a message to the login form [19:05:41] (personally, i think we should force https login on the desktop site) [19:05:42] if not, it would be trivial to do [19:05:52] jorm im surprised we dont [19:06:24] i'll bug ryan lane about that. [19:07:08] force it [19:07:25] I've been wanting that on the desktop site for quite a while now [19:07:43] I can't help that [19:07:51] it's in coredev's hands [19:08:04] jorm: ^^ [19:09:14] jdlrobson, jorm, Maryana so are we abandoning the login drawer? [19:09:30] i'm assuming we have to [19:10:03] it is certainly advisable [19:11:08] we'll need some new design work around this, as jorm points out -- at the very least some copy about why somebody should bother logging in/creating an account [19:11:42] yeah - and explaining why the action takes them to a whole new page [19:12:36] ok i'm a little confused [19:12:58] the drawer is in? [19:13:47] New review: awjrichards; "There are security concerns around the drawer approach for login, so -2'ing for now. We may need to ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/37048 [19:13:56] are we saying https://gerrit.wikimedia.org/r/#/c/37048/ is not suitable? [19:13:59] jdlrobson: drawer is out [19:14:07] i thought we were talking about actually doing the login via ajax [19:14:09] yeah. no drawer. [19:14:35] it's a misnomer, but the same problem as doing ajax login from an insecure page [19:15:14] "ajax login" is an overloaded term. [19:17:56] ok, munaf will work on a slightly modified version of the login page to take users to from the watchlist CTA [19:18:50] new copy? [19:20:10] yeah, just a note about how you need to be logged in to use the watchlist [19:20:27] space is kinda tight on that page, though - i'm not sure where it should go [19:21:15] iirc, the original design had the "W" on the left side, and space for a small block of text on the right. [19:22:03] i dont konw if this is better or worse from a UX perspective, but you could use the drawer or some kind of notification after clicking the start prompting the user to login [19:22:12] that way they don't have to navigate away from the page unless they really want to [19:22:22] btw does anyone know if RL allows you to load a single module with styles at top and scripts at bottom? Or do they have to be loaded both one place or the other? [19:22:41] s/start/star [19:22:45] awjr: the original way I did it was a login message [19:22:48] which was a link [19:23:03] 'Click here to login and watch this article' [19:23:19] jdlrobson: so you'd get a pop up message or whatever with the text + link? [19:23:42] awjr, that's how i originally thought of this feature, too - munaf is coming up with a few options for us [19:23:46] ok cool [19:23:48] yup and clicking on it sends you to login page with the return query parameter set [19:24:15] and a successf login redirects you to the page and watches the article [19:24:21] yeah, to me that seems like the best approach (generally speaking). being forcefully whisked away to a new page is really weird, especially for a user who might not ahve any idea what the star is for [19:25:14] jah, jah. [19:25:26] k, munaf will mock that up [19:25:37] jdlrobson: im not sure about RL, Krinkle likely does - or asking in #mediawiki or #wikimedia-dev will probably get you an answer [19:26:11] np - it's not going to block me - just wanted to know [19:29:39] MaxSem: to get PageImages working do I need to do anything additional to adding it to LocalSettings? [19:29:44] it's not doing anything for me :/ [19:29:52] no [19:30:03] but you need to reparse pages [19:30:11] reparse? [19:30:23] if the wiki isn't large, just run rebuildall.php [19:30:35] (in maintenance/) [19:32:02] ahh ok [19:32:39] * jdlrobson tries [19:33:18] running.. but slowly [19:34:37] MaxSem: is it suppose to take forever ? :) [19:34:49] yes [19:40:49] also MaxSem PageImages should be enabled on en.wiki right? [19:41:38] yes [19:41:50] but data isn't fully populated [19:42:13] ok that's in line with what i'm seeing (only a few images for articles) [19:43:22] and that's gonna take some time [19:46:13] and yes I know that some page images are weird - fix already committed [19:55:47] MaxSem so what are the tasks/goals for OSM/GeoData over the next few weeks? i'd like to get some story cards slotted for the upcoming iteration so we can prioritize/estimate them during the estimation meeting [19:56:06] I've created them [19:56:12] oh neat [19:56:14] * awjr looks [19:56:27] https://mingle.corp.wikimedia.org/projects/mobile/cards/302 https://mingle.corp.wikimedia.org/projects/mobile/cards/303 https://mingle.corp.wikimedia.org/projects/mobile/cards/304 [19:57:22] sweet thanks MaxSem [20:00:49] MaxSem cool - those look good. i moved them into the next iteration [20:18:33] awjr: Maryana I've split story 273 into 3 tasks [20:18:41] since i don't think i'll be able to do all of them alone [20:18:46] * Maryana looks [20:18:52] not sure if you want to change the priority [20:19:56] yeah, that looks about right. there are a few things rolled up in that story, and i wasn't sure how complicated each of them would be [20:21:09] i mentioned this to jgonera yesterday, but for the "add description to items in a-z list", we might want to ask kaldari & benny how they did it for http://en.wikipedia.org/wiki/Special:NewPagesFeed [20:21:24] though it could be another case of "works on english wikipedia only" [20:21:51] New patchset: Jdlrobson; "add thumbnails to watchlist list view (story 273 beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40818 [20:21:51] New patchset: Jdlrobson; "bold the watchlist title and change color (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40819 [20:22:15] * yuvipanda has 500 edits on commons, yay! [20:22:19] the add description seems complicated :( [20:22:31] brb moving location [20:23:18] jdlrobson, it is, more than I expected, I just left it without desc for now and will get back to it later [20:23:41] if you're stuck, we can axe it from the acceptance criteria [20:23:51] i just want to give it a good-faith go, cos it's a cool feature :) [20:25:12] jgonera: you started that story?! [20:25:30] I started 272 [20:25:34] it seems they overlap... [20:25:46] arghh https://mingle.corp.wikimedia.org/projects/mobile/cards/273 [20:25:50] i just did the thumbnails for that [20:25:56] did i do it for nothing? [20:26:20] uh, don't know, I guess we'll be able to merge that somehow [20:26:36] I should push my changeset later today [20:26:40] Maryana: awjr ^ care to disentangle 273 and 272 to avoid repeating work? [20:27:00] * Maryana checks [20:29:31] i don't see any mention of the snippet article preview in the acceptance criteria of #272 -- it it in one of the attached assets? [20:29:32] the acceptance criteria for those stories does not seem to overlap - am i missing something jgonera, jdlrobson? [20:29:55] the implementation kind of overlaps, I mean, we both change the structure of the list [20:30:21] ah, it's this asset: https://mingle.corp.wikimedia.org/attachments/d163c65ffb1307f8f05cbe96814ab14f/201/Watchlist_Screen.png [20:30:30] so 273 as i see it has 3 tasks - 1) thumbnail of the lead image next to each article (which i've done) 2) snippet preview of the lead text of the article (minus templates) 3) And I will see the time when each article was last edited 4) instructions 5) removal of items from watch list from this view [20:30:34] *5 tasks [20:30:47] is that correct? [20:31:12] however the styling of all these things seems to be tied in with 272 [20:32:02] 272 is mostly about the recently changed view, and 273 is about the a-z all items view [20:32:17] hm [20:32:36] but there was a stray asset in 272 that shows a-z list styling - the one we talked about yesterday w/vibha [20:33:06] my bad - i figured you'd started on it to help jdlrobson out, jgonera [20:34:14] well, I guess those two stories are still tightly coupled, they share the styling, we can't be changing the layout of one of the views without considering the other one [20:34:45] correct [20:34:48] should we turn this into a mega-story with a bunch of tasks? [20:34:49] jdlrobson, are you finished with 273? [20:34:58] yeh i'm not touching it with a barge pole now :) [20:35:00] Maryana, probably [20:35:21] hehe, is the changeset in gerrit? [20:35:29] k, i'll see what i can do... [20:35:54] mingle reflects the state of the world [20:36:04] jgonera: https://gerrit.wikimedia.org/r/40818 [20:36:05] [8:21pm] [20:36:19] those stories should probably have been broken out better and dependencies made clearer. [20:36:21] to be fair though [20:36:28] 273 was originally slated for the next iteration not this one [20:36:31] awjr: i don't think all of these can possibly get done either [20:36:47] is this what the "epic story" feature in mingle is for? [20:36:59] and i dont think we finished the review estimation on that card [20:37:00] we haven't had an epic story yet… can we get epic in the next iteration? :) [20:37:12] i moved it back over to the current sprint since jon was so certain he'd get through everything [20:37:17] awjr: i've run out of stories - i think Max would be best to work on 277 (i've had stabs at it in past and failed) and #279 is on brion i think? [20:37:24] i probably should have been more judicious [20:37:35] i was right awjr :P [20:37:40] jdlrobson, the images don't show up for me, is it my dev env? [20:37:49] jgonera: you need PageImages extension [20:37:49] jdlrobson: no one is working on 279 and it's the highest priority, so go for it [20:38:01] awjr: i haven't got a clue where to start [20:38:04] that's mostly php code [20:38:18] there's also no design assets [20:38:30] and i'm pretty sure brion had started something on that? [20:38:41] (in previous iterations) [20:38:52] i thought we had design assets for 279? [20:39:01] Maryana: ^ ? [20:39:08] the diff story has been in mingle for the past 3 iterations [20:39:17] or maybe 2 i forget [20:39:21] jdlrobson: yeah but no one's ever started working on it in earnest [20:39:29] biron had done some work on diffs before that story came into existence [20:39:59] well it's not clear at all from the story how to do it [20:40:08] it's all in brion's head [20:40:56] 272 has the assets for diff - i was assuming brion would continue his work on that, as well [20:40:56] I can attempt 277 but MaxSem will need to explain to me how to do it the right way to avoid wasting effort [20:41:24] also i thought Brion said "Spike: Investigate increase in DOMParse time over the last few months" was done? [20:41:33] i don't want to throw out whatever he's got for diff from previous iterations [20:42:28] jdlrobson, I poked at it myself - it's not that easy. and has nasty interdependencies with Zero - I asked jcmish and brion for a test plan [20:42:35] brb, grabbing food. are you gonna teleconference into the story review, jdlrobson? [20:42:59] MaxSem: I'll update Mingle card [20:43:00] so whoever picks up #279 should pick brion's brain, but i can almost guarantee you brion will not be doing it. he's been focussing on things other than mobile web (and will stop doing mobile web completely in january), and he's on vacation through new year's, i think [20:43:21] i suspect he'll likely respond to an email though [20:44:08] we really should be thinking about the stories as discrete units of work that anyone can pick up (of course there will be outliers) [20:44:22] sure. i'll send him an e-mail now - i'm unlikely to be able to work on anything else today as i'm planning to shoot off after the meeting for another early night (still ill) but hopefully he can respond by tomorrow as otherwise i will have nothing to work on.. [20:44:43] jdlrobson: that sounds reasonable [20:45:14] jdlrobson: if you get to a thumb-twiddling point tomorrow, bugs! jcmish can help pick out priority bugs [20:45:23] i'll pick up bugs and code review if not [20:45:34] most of the manageable ones are already fixed though [20:45:35] jdlrobson: also, you could pick up #297 if i dont get it done today [20:46:05] awjr: is that was ori started? [20:46:22] ? [20:46:27] jdlrobson: well if there are no bugs left to work on, there's always documentation, general code hygiene stuff, and experimentation [20:46:31] jdlrobson, I added PageImages, but still don't see any thumbnails [20:46:41] jdlrobson: he didn't start it per se, but he's been working on the plumbing for it afaik [20:46:51] i grabbed the card intending to start on it yesterday, but haven't yet [20:46:54] jgonera: run php maintenance/rebuildall.php [20:47:04] i'll put it back now in case you get to it befor em [20:47:08] *before me [20:47:47] how is it possible that it takes more than 1 second on a MediaWiki instance with 5 pages... [20:48:04] We (E3) have a deployment window starting in 15 minutes and lasting for two hours, and nothing to deploy except a small config change. If you guys are up for it, we could deploy the EventLogging update in MobileFrontend. You're also free to use the window for other purposes -- just let me know. [20:48:53] ori-l: thanks, but my inclination is to pass on MF deployment stuff for the moment [20:49:01] no problem at all [20:49:12] sorry to interrupt :) [20:49:18] no worries :) [20:49:27] jgonera: on your local instance? [20:49:38] yes [20:49:52] jgonera: it was very slow for me too [20:49:57] and it only gave me one image for one article [20:50:34] jgonera: oh just realized you're talking about pageimages, thought you were talking about loading articles in general [20:50:55] awjr, no, the php maintenance/rebuildall.php thing [20:51:07] yeah, you'll ahve to harass MaxSem about that :p [20:51:16] ok, got 1 thumbnail ;) [20:51:16] it's due to InstantCommons [20:52:07] jdlrobson, I'll try to review your changeset today and rebase my changes on top of it when it gets merged [20:52:41] jdlrobson: are all of the tasks for 273 blocked on design? [20:53:12] or just #307 and #309 [20:53:13] ? [20:56:21] * jdlrobson looks [20:56:34] 307 blocked on design [20:56:36] 309 also yes [20:56:44] see comments [20:57:03] story review/estimation time? [20:58:19] yes [21:01:07] jcmish just waiting on you for estimation :) [21:05:37] Maryana: added a little bit to https://www.mediawiki.org/wiki/Mobile/2013_strategy_planning [21:24:17] MaxSem: awjr https://gerrit.wikimedia.org/r/#/c/40325/ [21:24:20] jgonera: ^ [21:25:43] Maryana: wasn't sure if i should just edit that page or start stuff on the talk page [21:26:21] no, that's great - thanks yuvipanda :) [21:26:55] There's also a little uncertainity about what I'll be doing once I'll be back on staff [21:26:58] which is… 3 days [21:27:02] (w00t!) [21:27:08] should talk to tfinc when he's back, I guess [21:27:25] yes! you're coming to sf, right? [21:27:42] Maryana: I think so - but not for another 6 months, I think. [21:27:47] aww, boo [21:27:49]