[00:38:37] <gerrit-wm>	 New patchset: awjrichards; "Introduces wgMFForceSecureLogin config var" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41011
[00:38:37] <gerrit-wm>	 New patchset: awjrichards; "Make login links respect wgMFForceSecureLogin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41012
[00:45:26] <gerrit-wm>	 New review: awjrichards; "I'm open to adjusting how to handle this, perhaps to respect $wgSecureLogin, but I think we should s..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41011
[11:40:41] * yuvipanda  waves at jdlrobson 

[11:40:58] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[11:41:07] <jdlrobson>	 hey yuvipanda good holidays?
[11:41:13] <yuvipanda>	 very, I think
[11:41:34] <yuvipanda>	 Monks and Espresso Vodkas
[11:41:51] <yuvipanda>	 and am Infiltrating the Commons community :P Should reach 1000 edits soon
[11:43:02] <yuvipanda>	 jdlrobson: hope you're having a nice one too :)
[11:43:06] <yuvipanda>	 enjoying the snow?
[11:43:37] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[11:44:59] <gerrit-wm>	 New review: Jdlrobson; "Parent commit was rejected." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/40580
[11:49:07] <jdlrobson>	 yuvipanda: no snow here
[11:49:13] <jdlrobson>	 it's actually not bad for uk this time of year
[11:49:25] <yuvipanda>	 i'm sure i'll shiver to death
[11:49:31] <yuvipanda>	 under 8 layers of clothing there :P
[12:17:29] <gerrit-wm>	 New patchset: Zfilipin; "Setup for Selenium tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771
[12:20:10] <gerrit-wm>	 New review: Zfilipin; "Moved the files to tests/acceptance, as suggested. I will make the rest of the changes next." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771
[14:08:07] <gerrit-wm>	 New patchset: Zfilipin; "Setup for Selenium tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771
[14:16:01] <gerrit-wm>	 New patchset: Jdlrobson; "suggesting improvements to diff view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41034
[14:20:09] <gerrit-wm>	 New patchset: Jdlrobson; "suggesting improvements to diff view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41034
[14:23:53] <gerrit-wm>	 New review: Zfilipin; "Added more information about the tests to readme." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39771
[14:35:02] <gerrit-wm>	 New review: Zfilipin; "Parent commit has changed. How do I update this commit to point to the updated parent?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39773
[14:41:52] <Krenair>	 zeljkof, I would just rebase it onto master
[14:42:18] <zeljkof>	 Krenair: thanks, will try
[14:42:54] <Krenair>	 using git pull --rebase origin master
[14:43:35] <zeljkof>	 Krenair: does it matter that parent is not merged into master?
[14:44:19] <Krenair>	 Oh, yes... I'm not sure then, sorry zeljkof. Maybe ^demon can help you
[14:44:41] <gerrit-wm>	 New patchset: MaxSem; "The first two Selenium tests: mobile Search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39773
[14:45:00] <MaxSem>	 there's a button called "Rebase"
[14:46:02] <MaxSem>	 zeljkof, however the new revision also needs to move the files into tests/acceptance
[14:48:46] <zeljkof>	 MaxSem: I remember seeing rebase button, could not find it now
[15:13:18] <gerrit-wm>	 New patchset: Zfilipin; "The first two Selenium tests: mobile Search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39773
[15:14:07] <gerrit-wm>	 New review: Zfilipin; "Moved files to tests/acceptance folder." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39773
[15:40:31] <gerrit-wm>	 New review: Zfilipin; "Inline comment has more information about the change in base URL." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771
[15:47:46] <gerrit-wm>	 New patchset: Zfilipin; "The first two Selenium tests: mobile Search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39773
[15:49:05] <gerrit-wm>	 New review: Zfilipin; "If MEDIAWIKI_URL environment variable is set, the page will use it for it's base URL. If it is not s..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39773
[16:10:51] <Reedy>	 1 Warning:  htmlspecialchars() [<a href='function.htmlspecialchars'>function.htmlspecialchars</a>]: Invalid multibyte sequence in argument in /usr/local/apache/common-local/php-1.21wmf6/extensions/MobileFrontend/includes/specials/SpecialMobileFeedback.php on line 48
[17:32:34] * jdlrobson  looks around

[17:33:07] * jdlrobson  waves at awjr 

[17:33:13] * awjr  waves back

[17:33:21] <jdlrobson>	 awjr: what does wikidiff2 mean to you?
[17:33:48] <awjr>	 i think it's a diff engine
[17:34:12] <awjr>	 jdlrobson: http://www.mediawiki.org/wiki/Extension:Wikidiff2
[17:34:48] <jdlrobson>	 yeh i know but this is apparently the problem brion was trying to solve
[17:35:04] <jdlrobson>	 production uses wikidiff2 which does different things to the main diff engine that comes with mediawiki
[17:35:06] <awjr>	 oh
[17:35:08] <MaxSem>	 what problem?
[17:35:33] <jdlrobson>	 from brion: "The current diff code in Special:MobileDiff asks for a (possibly already cached) diff of the two revisions from the core DifferenceEngine class, then loads that HTML into a DOM document and extracts <ins> and <del> elements from it. In production this seems to often fail because the HTML output from the 'wikidiff2' plugin appears to differ from core and doesn't have <ins> and <del> around some pla
[17:36:14] <awjr>	 @_@
[17:36:15] <jdlrobson>	 so i wondered.. is it possible to disable wikidiff for mobile diffs?
[17:36:24] <awjr>	 what would we use instead?
[17:36:59] <jdlrobson>	 the default one
[17:37:09] <MaxSem>	 PHP diffs are slow
[17:37:22] <MaxSem>	 we just need to adapt his code to wikidiff2
[17:37:36] <awjr>	 jgonera: good morning! can you spend some time on code review today? the backlog is getting huge and there are quire a few JS-centric changes that are a little out of my league. in particular, can you take a look at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:imageuploadthumb282,n,z ?
[17:37:48] <jdlrobson>	 awjr: see my email
[17:37:57] <jdlrobson>	 i don't think those are as important considering next iteration
[17:38:05] <awjr>	 jdlrobson: still working through my backlog
[17:38:10] <jdlrobson>	 (obviously Maryana may disagree though)
[17:38:17] <awjr>	 jdlrobson: oh, you asked me to get those taken care of yesterday :p
[17:38:20] <jdlrobson>	 awjr: ideally i want them all merged but i'd like priority on watch list related ones :)
[17:38:32] <jgonera>	 awjr, I'll have a look at it after checking the thumbnails changeset from jdlrobson
[17:38:35] <jdlrobson>	 (i'm 8 hrs ahead of you remember ;-))
[17:38:58] <Maryana>	 hm? what's not as important?
[17:39:04] <awjr>	 thanks jgonera - note that jon is suggesting getting the watchlist related changes dealt with first
[17:39:18] <Maryana>	 ps, jdlrobson, you should take a look at the code for the navigation popups extension
[17:39:22] <jgonera>	 awjr, yeah, thumbnails are in watchlist
[17:39:28] <awjr>	 perfect jgonera, thanks
[17:39:29] <jdlrobson>	 Maryana: what for?
[17:39:34] <Maryana>	 it renders diffs… somehow. magically.
[17:39:35] <MaxSem>	 awjr, why https://gerrit.wikimedia.org/r/#/c/41011/ introduces a var but doesn't use it?
[17:39:45] <jdlrobson>	 ohh i see what you mean
[17:39:46] <Maryana>	 in unified format
[17:39:53] <jdlrobson>	 Maryana: it uses javascript
[17:39:58] <Maryana>	 js magic!
[17:40:00] <jdlrobson>	 ideally we want a non-js solution
[17:40:03] <awjr>	 MaxSem: look at the patchset that is dependent on it
[17:40:14] <Maryana>	 is that just because maxsem hates js? :-P
[17:40:16] <jdlrobson>	 js magic scares me :P
[17:40:27] <Maryana>	 haha, ok
[17:40:29] <jdlrobson>	 no Maryana it makes more sense for supporting older devices
[17:40:38] <Maryana>	 right. gotcha
[17:40:44] <jdlrobson>	 plus it's the right thing to do ™©
[17:40:50] <Maryana>	 hehehe
[17:40:52] <Maryana>	 ps: http://commons.wikimedia.org/wiki/File:Lead_Photo_For_Hic_sunt_dracones0-03331528860144317.jpg
[17:41:16] <Maryana>	 i don't know who this guy is, but he was nice enough to illustrate both the french and english "here be dragons" article for us
[17:41:18] <Maryana>	 via mobile
[17:41:20] <Maryana>	 :D
[17:41:34] <Maryana>	 (or she)
[17:42:03] <jdlrobson>	 sweeeettttt
[17:42:11] <jdlrobson>	 love it :D
[17:42:15] <jdlrobson>	 and mobile upload too :)
[17:42:26] <Maryana>	 but careful investigation of the history of those pages reveals that there was a few minutes lag btw upload to commons & adding to article
[17:42:33] <Maryana>	 not sure if that's a bug or slow load time or what
[17:42:50] <jdlrobson>	 possible
[17:43:23] <Maryana>	 it's also not tagging the add to article edit as mobile or leaving any edit summary
[17:43:37] <awjr>	 MaxSem do you know any of the history around $wgSecureLogin and why it's not used in prod?
[17:43:49] <jdlrobson>	 those are not in yet Maryana
[17:43:50] <Maryana>	 i'm replying to your email now with this to get it on ppls' radar
[17:43:53] <Maryana>	 ahhh, ok
[17:43:59] <MaxSem>	 I think Chris should be able to tell the whole story
[17:44:03] <Maryana>	 not in b/c somebody needs to review them still?
[17:44:07] <jdlrobson>	 patches exist though i think
[17:44:14] <jdlrobson>	 exactly Maryana ;-)
[17:44:21] <awjr>	 MaxSem: chris steipp?
[17:44:30] <MaxSem>	 yup
[17:44:33] <Maryana>	 ah, excellent - then i'll reply & make sure to get some eyeballs on em
[17:44:45] <awjr>	 MaxSem: thanks. just read an email that he's on vacation til next year :p
[17:44:54] <Maryana>	 do you happen to have gerrit links handy, jdlrobson?
[17:45:03] <MaxSem>	 luckily, that'll be very soon;)
[17:45:11] <jdlrobson>	 Maryana: https://gerrit.wikimedia.org/r/#/c/40340/
[17:45:17] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41011
[17:45:26] <jdlrobson>	 as for edit summary Maryana that sounds like a bug - what got uploaded without one?
[17:45:39] <jdlrobson>	 http://commons.wikimedia.org/wiki/File:Lead_Photo_For_Hic_sunt_dracones0-03331528860144317.jpg seems to have an edit summary?
[17:46:04] <Maryana>	 it has an edit summary on commons, but go to the articles it's been inserted in & take a look at the history
[17:46:13] <Maryana>	 adding to article doesn't leave any edit summary
[17:46:19] <jdlrobson>	 mm it should do..
[17:46:23] * jdlrobson  looks at code

[17:47:06] <jdlrobson>	 MaxSem: does action:edit prependtext ignore comment ?
[17:47:20] <jdlrobson>	 Maryana: according to code it should work.. sounds like a bug to me
[17:47:24] <MaxSem>	 no idea
[17:47:32] <MaxSem>	 check it?
[17:47:45] <jdlrobson>	 will do.. currently in the middle of install wikidiff2 though
[17:48:16] <Maryana>	 should i fire up a new bugzilla ticket for it, jdlrobson?
[17:48:35] <jdlrobson>	 Maryana: if you have sufficient evidence that none of the edits are including the edit summary
[17:48:49] <jdlrobson>	 it would help to point to a few where it is clear they used the mobile uploader
[17:48:54] <Maryana>	 will do
[17:48:57] <jdlrobson>	 (they might have used donate photo for example)
[17:49:04] <jdlrobson>	 and then added article separately
[17:49:17] <jdlrobson>	 Maryana: many more uploads since donate photo went into alpha?
[17:49:53] <Maryana>	 i see ten users who aren't wmf
[17:50:25] <Maryana>	 all mobile commons uploads since december 1, i should clarify
[17:50:52] <Maryana>	 hm, trouble is, i'm not sure which of these are "donate image" and which are lead image cta
[17:52:22] <Maryana>	 when we promote to beta, we should think about unique tags for both
[17:55:31] <jdlrobson>	 Maryana: probably a good idea
[17:56:12] <Maryana>	 good thing we have alpha to catch this stuff early :)
[17:57:30] <jdlrobson>	 mmm wikidiff2 is a pain
[18:08:56] <MaxSem>	 "moar code review" - and jdlrobsonlaughs happily
[18:13:18] <jdlrobson>	 mmm MaxSem have you ever setup wikidiff2?
[18:13:26] <jdlrobson>	 i've followed all instructions and it doesn't seem to be installed :(
[18:13:28] <jgonera>	 MaxSem, could you repeat the last thing you said about the descriptions? I couldn't hear you well back there
[18:15:11] <MaxSem>	 jdlrobson, apt-get install php-wikidiff2
[18:16:57] <MaxSem>	 jgonera, it's either regexes over wikitext which is fast but crappy or DOM manipulations over HTML which is slow but precise
[18:17:55] <jdlrobson>	 MaxSem: mac..
[18:19:13] <jgonera>	 I think we could risk using something fast and crappy, I mean, we will be showing like 200 characters at most from the beginning of the article, I guess the chances for any weird formatting there are pretty low
[18:20:02] <MaxSem>	 well MZ has shown you one outrageous error out of ~10 articles on the screen
[18:20:28] <jgonera>	 MZ?
[18:20:51] <MaxSem>	 goes by girlish nicks like Susan
[18:21:30] <jgonera>	 I'm not sure I saw the error
[18:25:38] * tfinc  still thinks its far too quiet in the office 

[18:25:45] * tfinc  ponders finding the nerf guns

[18:29:48] <jdlrobson>	 awjr: MaxSem so I installed a module (php -i | grep wikidiff2 seems to point correctly)
[18:29:48] <jdlrobson>	 b
[18:29:56] <jdlrobson>	 but when i run phpinfo it doesn't show up..
[18:34:09] <jgonera>	 MaxSem, what was the outrageous error?
[18:34:32] <awjr>	 jdlrobson: does it show up if you use php on the command line?
[18:34:35] <MaxSem>	 showing image caption instead of article text
[18:34:54] <awjr>	 jdlrobson: actually, is it a php extension? i dont really know mucha bout it
[18:36:13] <Maryana>	 maxsem: that's not outrageous :-P
[18:36:52] <Maryana>	 i'd be perfectly ok with that - it's relevant text about the article, at least
[18:37:01] <jgonera>	 MaxSem, yeah, seems better than nothing
[18:37:23] <awjr>	 jdlrobson: also did you bounce apache after installing it?
[18:37:39] <jdlrobson>	 i bounced it
[18:37:41] <jdlrobson>	 yup
[18:37:55] <jdlrobson>	 ooh maybe it's caching?
[18:38:10] <jdlrobson>	 i now get " DOMDocument::loadHTML(): Empty string supplied as input in /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php on line 89" if I look at a different diff
[18:38:21] <tfinc>	 awjr: did we finalize on the DOMParse time issue that brion was looking at with ops ?
[18:38:46] <jgonera>	 MaxSem, Maryana, I'm looking at http://en.wikipedia.org/wiki/Special:NewPagesFeed right now and can't spot anything outrageous
[18:39:53] <awjr>	 tfinc: asher responded to Brion's email on the ops list and he pushed for a little more investigation on rendering the slowest articles
[18:40:06] <tfinc>	 awjr: did this make it into a story card/bug/etc ?
[18:40:22] <jdlrobson>	 yeh i think that's what's happening
[18:40:26] <awjr>	 tfinc my thought is the spike is done and we can investigate further at a later time, though i haven't put this down in a card yet
[18:41:07] <tfinc>	 awjr: k. because if it doesn't make it into a bug/story/etc we won't get to it. so if its important get asher/brion/etc to put it somewhere more actionable
[18:41:17] <awjr>	 tfinc yup
[18:43:21] <MaxSem>	 awjr, tfinc, I actually have some plans of caching in this area as part of per-section views, but it requires a refactoring of MF-Zero interaction and I'm waiting for jcmish to come up with test plan for Zero otherwise it' is too dangerous
[18:43:57] <tfinc>	 MaxSem: k. put it in a bug/story/etc if were going to do it. otherwise we'll forget as it won't be actionable. or we'll get busy with something else
[18:44:15] <tfinc>	 but i want to make sure that ops is happy with were were at. it seems like they are
[18:44:22] <awjr>	 MaxSem did michelle give you a sense of when she expects to have that done?
[18:44:23] <tfinc>	 so i agree with awjr that we can consider the spike done
[18:44:58] <jgonera>	 awjr, MaxSem, is there any way I can profile the PHP code and know why mo dev instance sometimes takes 2 minutes to show a page (not any particular page, sometimes an article, sometimes a login page)
[18:45:05] <jgonera>	 mo=my
[18:45:09] <awjr>	 it's also possible stopping html parsing twice in beta will solve the problem :p
[18:45:32] <awjr>	 jgonera you can use xhprof to see where code bottlenecks are
[18:45:39] <MaxSem>	 apparently, she needs to coordinate with Patrick/Brion/whomever else knows about it
[18:45:45] <awjr>	 jgonera: also, are you using any kind of caching on your local instance
[18:46:12] <awjr>	 yeah ok, brion's on vacation til next week and i dont have any idea what preilly's schedule is.
[18:46:20] <jgonera>	 awjr, I'm not using any caching, do I need caching for MediaWiki with 5 pages?
[18:46:27] <awjr>	 jgonera: apparently :p
[18:46:38] <awjr>	 jgonera even just setting up memcache can help immenseley
[18:46:45] <awjr>	 im using memcache and varnish locally
[18:46:53] <jgonera>	 that's scary!
[18:46:55] <awjr>	 i can help you get something like that set up if you like
[18:46:58] <awjr>	 yeah, it's kinda ridiculous
[18:47:06] <jgonera>	 I mean, how bad can it be that it actually needs that on such a small scale!
[18:47:12] <MaxSem>	 jgonera, memcached. if you don't have it you should. if you have it enabled for MW but not running, it's fricking slow
[18:47:33] <tfinc>	 awjr: not as ridiculous as squid, htproxy, memache, mw, etc .. aka .. the hotrod payments cluster
[18:47:40] <tfinc>	 ahh the good ol days ...
[18:47:42] <awjr>	 jgonera: you should try rewriting mediawiki in c during your experimentation time
[18:47:46] <awjr>	 tfinc hahaha
[18:47:50] <jgonera>	 MaxSem, well, I'll try then but I think it's the first time I hear about using memcached in a dev environment
[18:48:30] <jgonera>	 awjr, I think rewriting it in anything would help, even rewriting it again in PHP (which would be insane)
[18:49:44] <awjr>	 lol
[18:50:00] <jgonera>	 MaxSem, still, why those 2-minute page loads happen only once every 15 minutes? why it's slow only sometimes?
[18:50:08] * tfinc  cancels all his meetings for the day and squeals with joy 

[18:50:12] <MaxSem>	 memcached?
[18:50:19] <MaxSem>	 oh
[18:50:32] <MaxSem>	 heehehehe
[18:50:45] <MaxSem>	 ResourceLoader cache expiration?
[18:50:56] <awjr>	 lol
[18:51:14] <awjr>	 jgonera: try turning off SETI@home
[18:51:36] <awjr>	 jgonera: this is some basic memcache config for mediawiki: http://pastie.org/5589994
[18:52:05] <jgonera>	 ok, will try that, thanks
[19:00:33] <tfinc>	 Maryana: whats the status on our photo upload blog post ?
[19:01:00] <Maryana>	 on hold till jan 8th
[19:01:21] <Maryana>	 that's our next deployment window for getting uploads back in beta
[19:01:22] <tfinc>	 k
[19:02:44] <tfinc>	 Maryana: Sumana was a about to draft up a blog post with Guilaume. i told them to stop as you had already done it
[19:03:21] <tfinc>	 Maryana: are we already scheduled on the communications calendar ?
[19:05:31] <Maryana>	 ayup
[19:06:09] <jdlrobson>	 ermm so it seems wikidiff2 is still not installed
[19:06:22] <tfinc>	 Maryana: where is meta hiding the calendar these days? i can't seem to find it
[19:06:34] <Maryana>	 will reply to sumana et al's email about it
[19:06:40] <MaxSem>	 169158 page images so far
[19:06:41] <jdlrobson>	 MaxSem: can you run var_dump( function_exists( 'wikidiff2_do_diff' ) ); on your instance running wikidiff2 and tell me what it says for you?
[19:06:44] <tfinc>	 MaxSem: did you already get ops in this channel ?
[19:06:55] <Maryana>	 tfinc: https://meta.wikimedia.org/wiki/Wikimedia_Blog/Calendar
[19:07:09] <awjr>	 jdlrobson: php > var_dump( function_exists( 'wikidiff2_do_diff' ) );
[19:07:09] <awjr>	 bool(true)
[19:07:12] <awjr>	 wfm
[19:07:21] <jdlrobson>	 awjr: could you tell me what's in your php.ini?
[19:07:42] <awjr>	 jdlrobson: i installed php-wikidiff2 in ubuntu and added a file called wikidiff2.ini in /etc/php5/conf.d
[19:07:56] <awjr>	 it has one line: extension = php_wikidiff2.so
[19:08:13] <jdlrobson>	 mm
[19:08:18] <awjr>	 jdlrobson: what does this do for you:
[19:08:19] <awjr>	 php -i | grep wikidiff
[19:09:04] <jdlrobson>	 nothing awjr
[19:09:09] <jdlrobson>	 it used to..
[19:11:30] <MaxSem>	 tfinc, I frankly believe that every team meber should have it
[19:12:08] <awjr>	 jdlrobson: are you using ubuntu?
[19:12:21] <jdlrobson>	 awjr: no mac
[19:12:25] <awjr>	 jdlrobson: o
[19:12:32] <jgonera>	 awjr, MaxSem, background jobs cause this, setting $wgJobRunRate = 0 fixed my problem, I will try running those jobs manually later and seeing which one takes that long. I'm stubborn, I just need to know what's going on.
[19:12:48] <awjr>	 jgonera  :)
[19:13:01] <MaxSem>	 oh yeah, jobs tend to accumulate
[19:13:05] <awjr>	 jdlrobson: i tried getting apache/php/mysql running in osx a few times and it's a total pita
[19:13:18] <awjr>	 jdlrobson: so i use a linux vm for that
[19:13:22] <MaxSem>	 switch to Ubuntu!
[19:13:38] <awjr>	 im loving os x with an ubuntu server vm
[19:13:46] <awjr>	 best of both worlds
[19:13:47] <jgonera>	 jdlrobson, maybe it's time to give vagrant a try, Ori will be happy ;)
[19:14:33] <awjr>	 some day i would like to make a vagrant instance that comes pimped out for MobileFrontend with a varnish cache and preconfigured for separate mobile/desktop domains
[19:14:52] <awjr>	 i am sure i'll get to it soon with my copious free time :p
[19:15:47] <awjr>	 jdlrobson: im not sure how php on os x handles configuration but did you try just adding extension = php_wikidiff2.so directly to your php.ini?
[19:15:55] <jdlrobson>	 i did yes
[19:16:11] <jdlrobson>	 does it need to be in a certain place?
[19:16:23] <awjr>	 at the end should be fine, i imagine
[19:16:47] <tfinc>	 MaxSem: that doesn't answer my question though. did you get ops in this channel?
[19:16:54] <jdlrobson>	 brb gonna grab some food then look at this again
[19:16:56] * yuvipanda  looks around groggily

[19:16:57] <MaxSem>	 no idea
[19:17:14] * tfinc  looks up the irc commands to figure that out

[19:17:26] <Maryana>	 try banning us all
[19:17:50] <Maryana>	 the only surefire way to know if you have op powers
[19:18:25] <MaxSem>	 mmm, no I don't have an op
[19:18:34] <MaxSem>	 the command appears to be /cs access #wikimedia-mobile list
[19:21:31] <awjr>	 hmm actually wikidiff2 does not appear to be working properly for me in MW
[19:21:36] <awjr>	 jdlrobson: ^
[19:21:57] <awjr>	 jdlrobson: do you see this error in your apache error log? /mnt/hgfs/testing/core/bin/ulimit4.sh: line 4: wikidiff2: command not found
[19:24:38] <jdlrobson>	 awjr: ill check in a bit :/
[19:24:55] <jdlrobson>	 i looked in the code and that function that existed for you didn't exist for me
[19:25:05] <jdlrobson>	 so i think you are probably a few steps ahead of me
[19:25:27] <tomaszf>	 MaxSem: there you go
[19:25:46] <MaxSem>	 whee
[19:25:50] <MaxSem>	 thanks
[19:26:31] <MaxSem>	 hmm, I'm still not on the list
[19:30:19] <tfinc>	 MaxSem: you'll have to figure out the irc incantation as i wasn't able to . with ops right now though you should be able to save
[19:31:34] <MaxSem>	 oops
[19:31:38] <tfinc>	 haha
[19:32:09] <tfinc>	 i feel that running irc commands is a little like witch craft. you never know what your truly going to get
[19:32:52] <yuvipanda>	 and you might just kickban yourself
[19:33:05] <MaxSem>	 I attempted to give myself op points while I was an op but it responded with You are not authorized to perform this operation.
[19:33:20] <yuvipanda>	 'yo dawg...'
[19:33:26] * yuvipanda  waves at Tanvir 

[19:33:28] <yuvipanda>	 err
[19:33:29] <yuvipanda>	 sorry
[19:33:30] <yuvipanda>	 tfinc:
[19:33:48] <tfinc>	 yuvipanda: you all set with Sue ?
[19:34:03] <yuvipanda>	 looks like. 4 more days.
[19:34:05] <yuvipanda>	 or 5.
[19:34:08] <tfinc>	 yuvipanda: excellent
[19:34:28] <tfinc>	 yuvipanda: what has brion said about the i18n work? i'm eager to hear the roadmap
[19:34:58] <yuvipanda>	 tfinc: all brion's told me is that we're doing the Android native keyboards, and stroke off the other options
[19:35:16] <yuvipanda>	 tfinc: mediawiki.org/wiki/Mobile_i18n
[19:35:18] <tfinc>	 yuvipanda: are the details up on a wiki ?
[19:36:14] <yuvipanda>	 tfinc: what support are we getting from i18n?
[19:36:33] <tfinc>	 yuvipanda: consulting from Santosh
[19:37:00] <tfinc>	 awjr: http://www.cnx-software.com/2012/12/26/mk802-ii-mini-pc-now-costs-as-much-as-raspberry-pi-model-b-lets-compare-them/
[19:37:56] <tfinc>	 awjr: i'm liking these micro designs
[19:38:53] <tfinc>	 the RPi so far is pretty slow for console emulation which is bugging me
[19:39:27] <MaxSem>	 mmm, apparently it has to be something like /cs access #wikimedia-mobile ADD *!*@wikimedia/MaxSem OP
[19:39:41] <tfinc>	 ok .. let me try that
[19:40:09] <awjr>	 tfinc: have you overclocked yet?
[19:41:31] <tomaszf>	 MaxSem: that didn't seem to do it. list still shows the same people
[19:41:50] <tomaszf>	 awjr: i've upped it to 800MHz but not past that.
[19:42:09] <MaxSem>	 no, it works!
[19:42:10] <awjr>	 tomaszf: that's +100MHz right?
[19:42:35] * awjr  bows to MaxSem+

[19:42:43] <tomaszf>	 MaxSem: why does't "/cs access #wikimedia-mobile list" show it ?
[19:42:53] <tomaszf>	 awjr: correct
[19:43:00] <MaxSem>	 it shows for me
[19:43:32] <yuvipanda>	 tomaszf: http://etherpad.wikimedia.org/android-ime
[19:43:35] <yuvipanda>	 (also in the wiki page now)
[19:43:43] <yuvipanda>	 that's the android bit.
[19:52:05] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39758
[19:52:11] <jdlrobson>	 jgonera: you need to get less scared of merging :)
[19:52:36] <jgonera>	 jdlrobson, yeah, I should've merged it
[19:52:46] <jdlrobson>	 Maryana: can you chat to Munaf about https://gerrit.wikimedia.org/r/#/c/41034/ ?
[19:53:30] <Maryana>	 yep, he just pinged me to ask what to work on for mobile :)
[19:55:47] <gerrit-wm>	 New review: Massaf; "Would you mind posting a screenshot of how it renders? I don't have an easy way to test this, sadly." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41034
[19:55:49] <awjr>	 also Maryana there are still cards blocked on design on the story wall: https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+Iteration%29%5D&group_by%5Blane%5D=status&lane
[19:55:57] <awjr>	 that is a beautiful url
[19:57:03] <Maryana>	 mangle!
[19:57:19] <Maryana>	 that just took me to the story wall. heh
[19:57:33] <Maryana>	 is it empty watchlist? vibha should have that done
[19:57:37] <Maryana>	 i'll check w/her
[19:59:11] <jdlrobson>	 so awjr i'm still screwing up with getting wikidiff working :(
[19:59:21] <awjr>	 Maryana: stories marked 'blocked' are in the in analysis column
[19:59:25] <awjr>	 jdlrobson: i am too now
[19:59:26] <jdlrobson>	 it now shows up when i do php -i | grep wikidiff
[19:59:29] <gerrit-wm>	 New review: JGonera; "Is there official design for this? That drawer that drops down just to show a message seems awkward ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41030
[19:59:34] <jdlrobson>	 it just doesn't seem to be registered on my localhost
[19:59:41] <awjr>	 jdlrobson: yeah, the instructions do not seem to be complete :|
[19:59:55] <awjr>	 jdlrobson: i've beena sking around in other channels but am not getting much guidance
[20:00:27] <Maryana>	 awjr, jdlrobson: vibha's on those two blocked designs. i'll check in w/her - you should have those by end of day
[20:00:43] <jdlrobson>	 awjr: :(
[20:00:54] <awjr>	 jdlrobson: yeah this is whacky
[20:01:03] <jdlrobson>	 Maryana: can you get munaf to log on?
[20:01:07] <jdlrobson>	 (irc)
[20:01:19] <gerrit-wm>	 New review: JGonera; "Plus, for some reason, the buttons in settings show as checkboxes instead of switches for me..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41030
[20:02:04] <jdlrobson>	 jgonera: please review in reverse chronological order to reduce merge conflicts :)
[20:02:11] <jgonera>	 jdlrobson, ok
[20:02:20] <Maryana>	 jdlrobson - he should be on in a few. he's reformatting his comp
[20:02:58] <Munaf>	 hi jdlrobson
[20:03:13] <jdlrobson>	 hey Munaf just grabbing you a screenshot
[20:03:21] <Munaf>	 sweet, appreciate it
[20:03:45] <Munaf>	 i should probably get a mediawiki instance running locally already. bleh.
[20:05:03] <jdlrobson>	 munaf http://jonrobson.me.uk/tmpdiff2.png and http://jonrobson.me.uk/tmpdiff1.png
[20:05:26] <Munaf>	 danke
[20:06:38] <tomaszf>	 ha! inbox(0) <--- take that lunch time
[20:06:51] <tomaszf>	 awjr: jdlrobson : and SF others lunch ?
[20:06:54] <yuvipanda>	 tomaszf: are you sure you didn't just select all and archive? :P
[20:07:14] <Munaf>	 jdlrobson, couple of notes on this
[20:07:37] <awjr>	 tomaszf i am obsessively trying to fix something, i might not be ready to head out for a bit
[20:07:39] <tomaszf>	 yuvipanda: i prefer select all and delete. anything important will be resent then :D
[20:08:15] <jdlrobson>	 my main worry Munaf was the inconsistency in colors in tmpdiff2.png between removal of content and also the lack of clarity with what green and red means (we can't assume everyone speaks diff and part of our job is to educate these people)
[20:08:17] <Munaf>	 i think we need icons or at minimum +/- signs in the headers. red/green colorblindness is the most common so it's good to dual-encode headings for scan-ability among the colorblind
[20:08:38] <tomaszf>	 awjr: would you be good by 12:30 ? i'm in no rush
[20:08:48] <jdlrobson>	 Munaf: we speak the same language - i was just worried that bytes removed was red but the diff itself was not
[20:08:55] <jdlrobson>	 these should be consistent
[20:09:00] <awjr>	 tomaszf: inshallah
[20:09:32] <tomaszf>	 wow .. going biblical on me awjr . nice.
[20:09:53] <awjr>	 jdlrobson: ok, i got it working locally
[20:09:57] <jdlrobson>	 how awjr
[20:10:01] <jdlrobson>	 share the secret of the holy grail!
[20:10:31] <awjr>	 jdlrobson: first, you'll need to sacrifice a small animal
[20:10:44] <jdlrobson>	 awjr: done the hamster is dead
[20:10:48] <awjr>	 k
[20:11:02] <awjr>	 jdlrobson: did you compile the extension from source?
[20:11:06] <tomaszf>	 Reedy: http://www.ouya.tv/its-open-season/ !
[20:11:24] <jdlrobson>	 the hamster tail extension?
[20:11:29] <jdlrobson>	 yup awjr followed instructions ./configure
[20:11:30] <jdlrobson>	 make
[20:11:32] <jdlrobson>	 make install
[20:11:53] <awjr>	 ok - the instructions were slightly wrong - i've updated them
[20:12:15] <jdlrobson>	 Libraries have been installed in:
[20:12:16] <jdlrobson>	    /Users/jrobson/Sites/w/extensions/wikidiff2/modules
[20:12:18] <awjr>	 jdlrobson: php.ini line should be: "extension = wikidiff2.so"
[20:12:26] <jdlrobson>	 yup did that
[20:12:33] <tfinc>	 now to take care of the 50+ starred messages that require real brain power
[20:12:34] <jdlrobson>	 i worked that bit out
[20:12:41] <awjr>	 jdlrobson: dbl check the line - the instructions had the extension name incorrect previously
[20:12:48] <jdlrobson>	 php -i | grep wikidiff2 wikidiff2 support => enabled
[20:12:53] <awjr>	 cool
[20:13:05] <awjr>	 jdlrobson: restart apache
[20:13:09] <jdlrobson>	 it doesn't seem to be active on my localhost though making me wonder if it is running a different php
[20:13:23] <awjr>	 how many phps do you have?!
[20:13:38] <jdlrobson>	 i don't know :(
[20:13:41] <jdlrobson>	 actually now i look closely
[20:13:48] <jdlrobson>	 php --version PHP 5.3.12
[20:13:48] <gerrit-wm>	 New review: JGonera; "This removes the back button from ALL special pages too. I think it was decided to replace it with t..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/40755
[20:13:57] <jdlrobson>	 but Apache/2.2.21 (Unix) DAV/2 PHP/5.3.10 with Suhosin-Patch :-S
[20:14:12] <jdlrobson>	 so i suspect that is what is going wrong
[20:14:34] <awjr>	 jdlrobson: phpinfo() should tell you where the config files that version of php is using
[20:14:47] <awjr>	 there's a row called 'Loaded Configuration File'
[20:15:24] <Munaf>	 jdlrobson i know this change is just styling, but do we currently shorten the diff output on mobile?
[20:15:25] <jdlrobson>	 awjr: /private/etc/php.ini
[20:15:32] <Munaf>	 ie to fit on the screen
[20:15:44] <awjr>	 jdlrobson: cool add the extension line there and restart apache
[20:15:47] <jdlrobson>	 Munaf: I think it just gets cut off at the moment if it is a long line
[20:15:54] <jgonera>	 jdlrobson, I think I reviewed everything from your message to mobile-tech
[20:15:55] <Munaf>	 gotcha
[20:15:58] <jdlrobson>	 awjr: nothing
[20:16:11] <awjr>	 jdlrobson: are you restarting the right apache?
[20:16:38] <jdlrobson>	 awjr: i think it's installed to a different php install
[20:16:47] <jdlrobson>	 how do i change the php install that apache uses? (dumb question i'm sure)
[20:17:02] <gerrit-wm>	 New review: Massaf; "This is definitely an improvement. The only improvements I'd make is to put a margin-top on the head..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41034
[20:17:27] <Munaf>	 oh, thank you gerrit bot.
[20:17:32] <awjr>	 jdlrobson: make sure the wikidiff.so library is linked to the right php version then
[20:17:33] <jdlrobson>	 Thanks Munaf - and i completely agree with you
[20:17:50] <Munaf>	 good stuff :-)
[20:18:27] <awjr>	 jdlrobson: look for 'extension dir' in the phpinfo()
[20:18:37] <awjr>	 that's where you should make sure wikidiff2.so is linked
[20:19:33] <awjr>	 tfinc: that last cup of coffee finally did the trick. i probably should've waited a few more minutes between cups though - i can't feel my face any more :|
[20:20:18] <tfinc>	 awjr: i'm surprised you can sit after all that coffee. i'd feel like i was on speed then
[20:20:23] <tfinc>	 and/or on a speeding train
[20:20:46] <awjr>	 jdlrobson: in the future, i recommend running apache/php/mysql/etc in a linux VM - much easier to cope with than os x whackness
[20:20:50] <jdlrobson>	 awjr: you sir are a genius
[20:20:56] <jdlrobson>	 awjr: agreed
[20:21:04] <jdlrobson>	 okkkk now i'm getting somewhere
[20:21:05] <awjr>	 jdlrobson: it's just the 5 cups of coffee at work
[20:21:19] <awjr>	 tfinc: if my heart leaps out of my chest any minute now, you know why
[20:22:18] <tfinc>	 awjr: as long as it doesn't look like this then i'll help you out http://quadrastreet.blogspot.com/2012/06/chest-bursting-animated-gif-not-for.html
[20:22:52] <awjr>	 lol
[20:23:11] <tfinc>	 and with that mental image .. its almost lunch time :D
[20:23:16] <awjr>	 \o/
[20:25:14] <awjr>	 ok tfinc ready
[20:25:33] <tfinc>	 excellent
[20:25:40] <jdlrobson>	 so jgonera i was trying to avoid messy php in https://gerrit.wikimedia.org/r/#/c/39782/1/includes/specials/SpecialMobileWatchlist.php
[20:25:50] <jdlrobson>	 would be 3 if statements otherwise
[20:26:01] <jdlrobson>	 (for <ul>, for empty message and for '</ul>')
[20:26:14] <jdlrobson>	 happy to change though as i do agree with you
[20:26:23] <jdlrobson>	 just the messy code looked horrible
[20:26:40] <jgonera>	 jdlrobson, I'll have a look at it again after lunch
[20:34:13] <gerrit-wm>	 New review: Jdlrobson; "Re-adding the hamburger icon is a separate discussion. This was a preliminary step (and yes it was i..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/40755
[20:35:18] <gerrit-wm>	 New patchset: Jdlrobson; "show message when watchlist view is empty (bug 42745)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39782
[20:46:09] <MaxSem>	 awjr, my testing indicates that API is slower for ESI chunks
[20:46:48] <MaxSem>	 dunno WTF but apparently API startup isn't as profiled as index.php
[20:47:45] <MaxSem>	 so an empty API module that returns an empty string in raw format is slower than Special:Esi/mf-bottom-scripts
[21:19:40] <awjr_lunch>	 MaxSem: that is quite surprising
[21:20:02] <awjr>	 MaxSem are you actually using ESI with varnish?
[21:20:44] <MaxSem>	 no, just ab'd the chunk URLs in both cases
[21:23:59] <awjr>	 MaxSem: how big was the difference?
[21:24:52] <MaxSem>	 empty API call is ~70ms slower than Special:Esi/mf-bottom-scripts
[21:25:52] <awjr>	 wow.
[21:26:02] <tfinc>	 jdlrobson: have you played with eBay's iOS tablet app? i've been really liking it for the last week. not a direct parallel but great execution
[21:26:13] <tfinc>	 and a thousand times better then their desktop site
[21:26:17] <jdlrobson>	 tfinc: nope - no access to an iOS tablet
[21:26:25] <tfinc>	 jdlrobson: i'll show you when you get back then
[21:26:27] <jdlrobson>	 will take a look when i do though now you recommend it :)
[21:26:36] <jdlrobson>	 \o/ i think i've worked out the diff problem
[21:27:04] <jdlrobson>	 i'm a bit worried though as it seems so easy and brion was working on it for a while so i worry i'm misunderestimating it though..;
[21:27:44] <jgonera>	 jdlrobson, have you already talked to Maryana or Munaf about https://gerrit.wikimedia.org/r/#/c/40755/ ?
[21:27:59] <jdlrobson>	 jgonera: nope
[21:28:00] <tfinc>	 i'm sure MaxSem will let us know if were doing something bad jdlrobson
[21:29:00] <jgonera>	 Maryana, Munaf, do you think it's a good idea to remove the back button from special pages without adding the hamburger in its place for now?
[21:30:12] <Maryana>	 the hamburger seems confusing there - i'd vote back button or nothing
[21:30:30] <Maryana>	 and if we're getting rid of back button in other places, i suppose nothing is better for consistency
[21:30:48] <Maryana>	 but i'd check with munaf
[21:30:54] <Maryana>	 jgonera ^
[21:31:46] <jdlrobson>	 Munaf: quick question about the approach i showed you earlier - you there?
[21:31:54] <tfinc>	 jorm: still free http://marketplace.xbox.com/en-US/Product/The-Walking-Dead/66acd000-77fe-1000-9115-d802584111de
[21:32:07] <jorm>	 on it.
[21:32:16] <jgonera>	 hm, I think we need to talk about that, from what Vibha told me I understood that a decision was made to use the hamburger everywhere (in particular all her watchlist layouts have the hamburger)
[21:32:21] <tfinc>	 i think each ep after is $5
[21:32:50] <jgonera>	 Maryana, Munaf, jdlrobson ^
[21:33:13] <tfinc>	 jorm: i love that xbox live works just like the android market. purchase on whatever you want and then tell the site to send it to your device
[21:33:18] <jdlrobson>	 jgonera: yes that was a discussion but the smaller part of the discussion was the back button was bad and should be rmeoved
[21:33:26] <jorm>	 apple market works the same.
[21:33:33] <jdlrobson>	 and that the browser back button should be enough
[21:33:35] <jorm>	 buy in itunes and it instantly downloads to your device.
[21:34:45] <jgonera>	 Maryana, why the hamburger would be confusing? if we just have it _everywhere_ it seems like the most consistent option to me
[21:35:41] <Maryana>	 overlays for me are a little different from a special page like a watchlist - it's something you just want to see for a second and then dismiss
[21:36:09] <Maryana>	 but i'd like to hear some interaction design thinking on this, because i'm no expert
[21:36:22] <Maryana>	 firing a quick email on this
[21:36:55] <jdlrobson>	 Maryana: jgonera this is not a quick 5 min discussion
[21:37:03] <jdlrobson>	 we'd need to revisit special pages altogether
[21:37:28] <jdlrobson>	 currently the only reason they are the way they are is because of the overlay concept we use for languages/tables
[21:37:30] <jgonera>	 jdlrobson, agreed
[21:37:36] <jdlrobson>	 i agree it's not perfect
[21:37:39] <jdlrobson>	 but the back is confusing
[21:37:52] <jdlrobson>	 i certainly press it rather than the browser back button at the moment
[21:37:55] <jdlrobson>	 and it's not as good
[21:38:06] <jdlrobson>	 for instance clicking hardware back button takes you back to position in page
[21:43:53] <Munaf>	 jdlrobson, back
[21:43:59] <Munaf>	 sorry was out to lunch
[21:45:15] <Munaf>	 jgonera jdlrobson yes, we were going to rely on hardware back for android and browser back for ios
[21:45:29] <Munaf>	 with hamburger everywhere otherwise
[21:45:49] <jdlrobson>	 Munaf: i'm not actually interested in this conversation right now… it's too big for irc
[21:45:58] <jdlrobson>	 i'm more interested in an extension of the diff conversation
[21:46:03] <jdlrobson>	 :)
[21:46:21] <Munaf>	 gotcha, thought we'd switched over.
[21:48:03] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40571
[21:48:27] <jdlrobson>	 so Munaf i realized that the diff view as brion did it actually jumbled up the diff
[21:48:43] <jdlrobson>	 so if I removed line 6 added line 7 and removed line 12
[21:48:44] <Maryana>	 i sent y'all an email about updating our mobile chrome situation
[21:48:45] <jgonera>	 jdlrobson, it's a bit confusing that this background rule affecting all the headers like that was in mf-login.less... was this some old unused code?
[21:48:53] <jdlrobson>	 what i'd see is these lines removed followed by 6 and 12
[21:48:58] <jdlrobson>	 these lines added followed by 7
[21:49:18] <jdlrobson>	 but the fact 7 follows 6 is important information
[21:49:22] <jdlrobson>	 so i've rejigged that
[21:49:58] <jdlrobson>	 Munaf: http://jonrobson.me.uk/tmpdiff3.png
[21:50:11] <jdlrobson>	 does this work (same problems being addressed as before)
[21:50:16] <jdlrobson>	 i've added the + and - though this time
[21:52:41] <Munaf>	 yup jdlrobson!
[21:53:59] <jdlrobson>	 sweet
[21:54:10] <jdlrobson>	 diffs done!
[21:54:18] <gerrit-wm>	 New patchset: Jdlrobson; "rewrite processDiff using xpath" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41182
[21:55:06] * jdlrobson  waits for MaxSem to moan

[21:55:55] <MaxSem>	 why? everything's MF style:P
[21:56:10] <MaxSem>	 oppa libxml2 style!
[21:56:33] <Maryana>	 jdlrobson - you seem to be drawing strange mystical productive powers from your homeland
[21:56:43] <jdlrobson>	 Maryana: it's called boredom ;-)
[21:56:55] <jdlrobson>	 and planes
[21:57:08] <jdlrobson>	 luckily you get one more plane out of me soon ;-)
[21:57:14] <jdlrobson>	 last flight was pretty damn busy
[21:57:24] <Maryana>	 when you come back, we're putting you in a box
[21:57:34] <MaxSem>	 how dare you be bored in the land of pubs on Friday evening?
[21:58:46] <Maryana>	 munaf, jdlrobson: mind updating this mingle card with any pertinent design info: https://mingle.corp.wikimedia.org/projects/mobile/cards/279
[21:59:03] * jdlrobson  looks

[21:59:10] <jdlrobson>	 will do
[21:59:11] <Maryana>	 just the mobile diff card
[21:59:13] <Maryana>	 thanks!
[21:59:19] <jdlrobson>	 in acceptance criteria or comments?
[21:59:39] <Maryana>	 both, and the spec that's attached is old
[21:59:45] * jdlrobson  feels naughty and powerful changing acceptance criteria

[21:59:49] <Maryana>	 hahaha
[22:01:06] <Maryana>	 i'm still watching. if you slip in anything about toucans, i will have to revert :-P
[22:02:17] <jdlrobson>	 So Maryana currently diffs look like http://jonrobson.me.uk/tmpdiff3.png
[22:02:33] <Maryana>	 wfm
[22:02:40] <jdlrobson>	 it's not quite https://mingle.corp.wikimedia.org/attachments/eb06b1db64417c279a7b481bb0edb7e5/215/Watchlist_UXSpec_Beta_Dec12th-06.png
[22:03:09] <jdlrobson>	 do you want me to style it more like that?
[22:03:26] <jdlrobson>	 or do we have bigger fish to fry?
[22:04:05] <Maryana>	 no, i think that's good. i would like to have article title in the body of the page, not the chrome, but that's a separate issue
[22:04:22] <gerrit-wm>	 Change abandoned: Jdlrobson; "abandoning in favour of https://gerrit.wikimedia.org/r/#/c/41182/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41034
[22:04:52] <Maryana>	 bytes changed icon - yea or nay, munaf?
[22:05:13] <jdlrobson>	 i mean none of that styling is too difficult - maybe pop it into next iteration Maryana ?
[22:05:22] <jdlrobson>	 maybe can use my experimentation time to polish it
[22:05:32] <Maryana>	 :D
[22:05:48] <Maryana>	 more beautiful words were never spoken
[22:09:16] <awjr>	 jgonera: check your pm when you have a chance
[22:10:53] <gerrit-wm>	 New review: Siebrand; "Added Amir for RTL review." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41182
[22:10:56] <tfinc>	 i can't believe our ledger system doesn't let me *search* for old transactions. everything has to be a report as far as i can tell
[22:10:58] <tfinc>	 this is dumb
[22:13:54] <gerrit-wm>	 New patchset: Jdlrobson; "show message when watchlist view is empty (bug 42745)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39782
[22:14:17] <jdlrobson>	 jgonera: did you see my comments https://gerrit.wikimedia.org/r/#/c/40818/ ?
[22:16:46] <jdlrobson>	 MaxSem: still around? if so could we talk about https://gerrit.wikimedia.org/r/#/c/40306/
[22:17:07] <MaxSem>	 sure
[22:17:19] <jdlrobson>	 also Munaf would you be ok with removing the back button arrow for the time being and leaving nothing in it's place ( https://gerrit.wikimedia.org/r/#/c/40755/)
[22:17:39] <jdlrobson>	 So MaxSem you mentioned using HistoryPager
[22:17:57] <jdlrobson>	 i'm not familiar with the term - would it be relatively easy to make use of
[22:18:37] <Munaf>	 i'm totally ok with it but i really do think that the hamburger should persist
[22:18:51] <Munaf>	 yes that was a great sentence in isolation
[22:19:04] <MaxSem>	 I mentioned HistoryPager regarding history views, but there are other pagers
[22:23:55] <tfinc>	 awjr: i see that your on http://www.mediawiki.org/wiki/Events/FOSDEM. given all the planning work that were doing. can i safely assume that your not going ?
[22:24:08] <awjr>	 tfinc: yup
[22:24:09] <tfinc>	 k
[22:24:27] <awjr>	 tfinc i just removed myself
[22:24:30] <tfinc>	 thanks
[22:25:21] <jdlrobson>	 MaxSem: should i just use the namespace/title suggestion to get this done and merged? would that be sufficient
[22:25:28] <jdlrobson>	 or is HistoryPager or similar the way to go?
[22:25:34] <jdlrobson>	 Munaf: thanks
[22:26:06] <gerrit-wm>	 New review: Jdlrobson; ""jdlrobson: also Munaf would you be ok with removing the back button arrow for the time being and le..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/40755
[22:26:24] <MaxSem>	 pagers are good in that they doo a lot of things for you. including paging, switching between different page size
[22:26:26] <Maryana>	 the hamburger must persist, or else it gets the hose again
[22:26:45] <MaxSem>	 my main concern is SQL performance though
[22:27:19] <MaxSem>	 if you specify LIMIT 100 OFFSET 1000 it means that MySQL will fetch 1100 rows
[22:27:30] <MaxSem>	 you should paginate by a key
[22:27:48] <jdlrobson>	 MaxSem: do you fancy tackling https://gerrit.wikimedia.org/r/#/c/40306/ ?
[22:27:56] <jdlrobson>	 my sql/php is very rusty as you know.. ;-)
[22:28:56] <MaxSem>	 I can, but we will need to discuss priorities during the kickoff meeting
[22:29:06] <jdlrobson>	 MaxSem: np  i need to look at https://gerrit.wikimedia.org/r/#/c/41030/
[22:29:25] <jdlrobson>	 i'm just trying to get watch lists in a good state for next kickoff meeting
[22:29:33] <jdlrobson>	 as they seem to be the big chunk of upcoming work
[22:29:48] <jdlrobson>	 (pre photo uploads)
[22:30:01] <MaxSem>	 mmm, 1 line of PHP? looks good:)
[22:30:16] <jgonera>	 jdlrobson, is forcing the size on the <img> not an option (instead of centering)?
[22:30:17] <jdlrobson>	 MaxSem: nope i need to look at that not you :)
[22:30:28] <jdlrobson>	 jgonera: no because it will lose its aspect ratio
[22:30:56] <jdlrobson>	 you could have a div with an image in it but that seems to defeat the point :)
[22:31:20] <tfinc>	 Maryana: "the hamburger must persist" is my new favorite quote from this channel
[22:31:36] <tfinc>	 especially out of context
[22:32:02] <Maryana>	 i amuse myself :)
[22:32:03] <jdlrobson>	 jgonera: good catch on the settings page
[22:32:13] <jdlrobson>	 (https://gerrit.wikimedia.org/r/#/c/41030/)
[22:32:57] <jgonera>	 jdlrobson, it was by accident, I cleared cookies and needed to reactivate beta ;)
[22:35:35] <jdlrobson>	 also Maryana Munaf need your thoughts on something
[22:35:44] <Munaf>	 yes'm?
[22:36:31] <jdlrobson>	 http://jonrobson.me.uk/login123.png
[22:36:41] <jdlrobson>	 as an interim solution for watch list cta
[22:37:05] <jdlrobson>	 clicking login or signup and doing them successfully will automatically redirect you to article and watch it
[22:37:29] <jdlrobson>	 jgonera was wondering if the drawer was bad and maybe we should use the toast notification instead?
[22:40:05] <Maryana>	 jdlrobson, that wfm, though the arrow up is a little funny. we use the x dismiss thingy on other drawers
[22:40:38] <jgonera>	 Maryana, isn't this drawer too big? I mean, what is all that space for?
[22:40:59] <jgonera>	 jdlrobson, when do we add mf- in .js and .less files and when not?
[22:41:01] <Maryana>	 assuming that's to leave room for someone with big thumbs to tap the arrow up
[22:41:10] <Maryana>	 but agreed
[22:41:46] <Maryana>	 we could use that space to put in a line of text about what watching a page means
[22:41:58] <Maryana>	 i don't think it's immediately obvious to most people
[22:42:05] <jdlrobson>	 it's only that big because of the login form originally being there - i can shrink it.
[22:42:11] <jdlrobson>	 i was more keen to understand whether the approach is right
[22:42:17] <jgonera>	 and generally, I thought jorm suggested that tapping the star should simply get us to the login page directly, but maybe I misunderstood
[22:42:31] <jgonera>	 if someone doesn't want to log in, they will just hit the back button
[22:42:45] <jgonera>	 there's just something wrong about this drawer for me ;)
[22:43:10] * jdlrobson  descends into a coughing fit

[22:43:18] <Munaf>	 if we can't embed the login form in the drawer due to ajax/security issues then yeah we should just go straight to the login page
[22:43:52] <Maryana>	 seems jarring to me
[22:44:11] <Maryana>	 to be taken to login/signup without any indication of why it happened after i tapped a star
[22:44:23] <Munaf>	 as long as there's a message when they land such as "You must log in to use the Watchlist" it's the best we can do given the circumstances
[22:44:24] <Maryana>	 and then won't people expect that to be the way you log in?
[22:44:43] <jdlrobson>	 I agree with Maryana
[22:44:44] <Munaf>	 i thought we could display messages on the login page based on the referrer, no?
[22:44:59] <jdlrobson>	 I click the star because i think it's available
[22:45:04] <jdlrobson>	 i might not want to leave the page
[22:45:12] <jdlrobson>	 and i would like to confirm if in the odd case i have to
[22:45:24] <jdlrobson>	 http://jonrobson.me.uk/login1234.png
[22:45:40] <Maryana>	 oooh toast
[22:45:43] <Munaf>	 that's fair enough actually. if that's the case then i'd just make it a wide agora button
[22:46:09] <jdlrobson>	 ooh hadn't thought of buttons..
[22:46:12] <jdlrobson>	 I could do that yes
[22:46:17] <Munaf>	 http://www.youtube.com/watch?v=Ru_FIwX1tb8
[22:46:22] <jdlrobson>	 Please login or sign up to watch this page
[22:46:26] <jdlrobson>	 followed by big login button
[22:46:30] <Munaf>	 yep
[22:46:31] <jdlrobson>	 followed by big sign up button
[22:46:32] <jdlrobson>	 ?
[22:46:37] <jdlrobson>	 sweet will do that now
[22:46:48] <Munaf>	 as i was saying to maryana, # of clicks doesn't matter as much as the ease of clicks
[22:46:56] <Munaf>	 so yeah that works
[22:47:05] <awjr>	 MaxSem: are you familiar at all with how https works on the cluster?
[22:47:22] <MaxSem>	 a bit
[22:47:29] <awjr>	 im pretty sure we do ssl termination with nginx and then squid/apache handles the rest
[22:47:35] <MaxSem>	 yes
[22:47:49] <awjr>	 MaxSem when making an ssl request on the cluster, do you know if WebRequest::detectProtocol() == 'https'?
[22:48:01] <awjr>	 because by the time the request hits the app servers, the protocol would be http
[22:48:05] <awjr>	 right?
[22:48:13] <Maryana>	 ok, so we're doing drawer with agora button, jdlrobson, munaf?
[22:48:19] <Maryana>	 can you live with that, jgonera?
[22:48:22] <Maryana>	 :)
[22:48:39] <jgonera>	 uh, let me read all of that ;)
[22:49:29] <awjr>	 unless there's some magic im unaware of...
[22:50:05] <awjr>	 i'll go ask laner
[22:50:23] <jgonera>	 what's an agora button?
[22:50:39] <jgonera>	 you mean the blue buttons?
[22:51:00] <Maryana>	 yes :)
[22:51:07] <MaxSem>	 awjr, from detection code in CommmonSettings I see that only $wgServer gets set with HTTPS
[22:52:50] <jgonera>	 I guess a smaller drawer plus blue button is OK
[22:52:54] <MaxSem>	 and WebRequest doesn't check for HTTP_X_FORWARDED_PROTO
[22:53:15] <awjr>	 MaxSem yeah which is lame
[22:53:21] <awjr>	 it probablys hould
[22:53:30] <awjr>	 but that's the magical header i needed :)
[22:53:45] <MaxSem>	 well, it detects server from request params not voce versa
[22:53:59] <jorm>	 i believe herr lane would love it if we could force https login everywhere.
[22:54:04] <MaxSem>	 awjr, on cluster, just use $wgServer
[22:54:17] <awjr>	 eeeenteresting
[22:54:39] <MaxSem>	 if ( isset( $_SERVER['HTTP_X_FORWARDED_PROTO'] ) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' ) {
[22:54:43] <MaxSem>	 ...
[22:54:47] <MaxSem>	 $wgServer = preg_replace( '/^http:/', 'https:', $wgServer );
[22:55:06] <jdlrobson>	 Munaf: http://jonrobson.me.uk/login123a.png
[22:55:17] <jdlrobson>	 ^ Maryana
[22:55:32] <awjr>	 MaxSem where is that config code, CommonSettings?
[22:55:33] <Maryana>	 i think just one button to the login/signup page is better
[22:55:40] <Maryana>	 they can do either from there
[22:55:50] <MaxSem>	 yes
[22:55:54] <awjr>	 cool thanks
[22:57:04] <Munaf>	 i'd actually make sign up a link so they're not 2 conflicting targets.. that sound good?
[22:57:07] <Munaf>	 jdlrobson ^
[22:57:23] <jdlrobson>	 not a problem
[22:57:48] <jorm>	 Ugh. I hate "sign up" as a call to action.
[22:58:30] <jdlrobson>	 BIKE SHEDDING BIKE SHEDDING
[22:58:33] <jdlrobson>	 :P
[22:58:43] <Maryana>	 i think the button should be purple
[22:58:47] <Maryana>	 the purple must persist
[22:58:56] <jdlrobson>	 Munaf: http://jonrobson.me.uk/login123a.png?e=3
[22:59:10] <jdlrobson>	 i want this done so i can go to bed soon - my throat is killing me today :(
[22:59:49] <Munaf>	 that works for me jdlrobson. would you might putting 5px of space between sign up and the arrow? go to bed otherwise!
[23:00:05] <jdlrobson>	 5px above and below?
[23:00:07] <jdlrobson>	 or just below
[23:00:13] <jdlrobson>	 as in below signup
[23:00:22] <Munaf>	 just below
[23:00:24] <Munaf>	 5px more rather
[23:00:41] <Munaf>	 just to hopefully avoid misclicks.
[23:01:54] <Maryana>	 +1 and then get some rest!
[23:12:33] <jdlrobson>	 who wants to take this one - https://twitter.com/aaronlammer/status/284780698097836032
[23:13:11] <tfinc>	 jdlrobson: i'm happy to go back and forth with him
[23:13:35] <jdlrobson>	 including evil plan?
[23:13:52] <jdlrobson>	 maybe we should reply with a question
[23:14:01] <jorm>	 "Why don't you come help us?"
[23:14:01] <tfinc>	 jdlrobson: my plan exactly
[23:14:08] <jdlrobson>	 what if the m.wikipedia.org… grew into wikipedia.org
[23:14:15] <jorm>	 The Evil Plan.
[23:14:28] <tfinc>	 i should make t-shirts for us that say that
[23:14:58] <jorm>	 "The Evil Plan?"
[23:15:00] <jdlrobson>	 http://www.youtube.com/watch?v=7edeOEuXdMU&t=11
[23:16:19] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[23:17:03] <gerrit-wm>	 Change abandoned: Jdlrobson; "Use https://gerrit.wikimedia.org/r/#/c/41030/ instead" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40580
[23:17:38] <gerrit-wm>	 New review: Jdlrobson; "ok by maryana and munaf..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41030
[23:19:37] <gerrit-wm>	 New review: Jdlrobson; "I got an update from jnf" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/36887
[23:20:06] <gerrit-wm>	 Change abandoned: Jdlrobson; "use https://gerrit.wikimedia.org/r/#/c/41030/ instead" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/37048
[23:21:15] <gerrit-wm>	 New review: Jdlrobson; "changed my mind. should have merged while you had the chance ;-)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1;  - https://gerrit.wikimedia.org/r/40354
[23:24:08] <jdlrobson>	 ok i'm slowly dying think i need to sign off
[23:24:12] <jdlrobson>	 anything needed from me before i go
[23:24:16] <tfinc>	 jdlrobson: take care
[23:24:26] <jdlrobson>	 tfinc: any decision on february?
[23:24:33] <tfinc>	 awjr: --^
[23:29:06] <jdlrobson>	 i've just sent an update on the watch list discussion
[23:29:28] <jdlrobson>	 don't need an answer now tfinc as long as i can get a yes or no or yes under these circumstances by monday that will be awesome. :)
[23:29:49] <jdlrobson>	 i'm going to dose myself up with cough improving drugs and hopefully sleep aiding ones
[23:30:03] <jdlrobson>	 night all :)
[23:30:16] <awjr>	 hey sorry was in a mtg - tfinc, jdlrobson, still reviewing dates, blahblahblah, but i'll ahve my opinions registered shortly
[23:30:18] <awjr>	 goodnight jdlrobson
[23:30:29] <awjr>	 get better!
[23:30:30] <jgonera>	 gnight jdlrobson, get better!
[23:30:33] <awjr>	 and see you next year :)
[23:30:40] <jdlrobson>	 ohh year
[23:30:44] <jdlrobson>	 2012 is ending :(
[23:30:51] <jdlrobson>	 nighttt
[23:35:58] <gerrit-wm>	 New review: Maryana; "This is also needed for the history view – medium to large sized articles will have hundreds if no..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/40306
[23:39:21] <tfinc>	 awjr: Ryan_Lane jgonera : interested in ice skating @ 5 embarcadero center?
[23:39:33] <awjr>	 tfinc sounds awesome but cant tonight
[23:39:40] <Ryan_Lane>	 hm. I think I need to get some work done...
[23:39:46] <Ryan_Lane>	 thanks for the invite, though
[23:48:15] <gerrit-wm>	 New patchset: awjrichards; "Always Special:Userlogin is handled by https, if enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41190
[23:49:26] <gerrit-wm>	 New patchset: awjrichards; "Always Special:Userlogin is handled by https, if enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41190
[23:50:14] <gerrit-wm>	 New patchset: awjrichards; "Always ensure Special:Userlogin is handled by https, if enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41190
[23:58:47] <jgonera>	 tfinc, just saw it, will ask my girlfriend
[23:58:54] <tfinc>	 k