[05:01:40] <YuviPanda>	 yay, ZNC setup
[08:51:05] <gerrit-wm>	 New review: Siebrand; "(marking -1, even though the weight of the comment doesn't warrant it, but as there already is one, ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41584
[11:54:37] <gerrit-wm>	 New patchset: Jdlrobson; "improve styling of diff page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41584
[11:56:22] <gerrit-wm>	 New review: Jdlrobson; "I don't think we can reply on ::first-line due to i18n reasons. I doubt we can guarantee which word ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41584
[11:59:28] <gerrit-wm>	 New patchset: Amire80; "rewrite processDiff using xpath" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41182
[12:02:45] <gerrit-wm>	 New patchset: Jdlrobson; "Improve ResourceLoader support for js/css [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40325
[12:03:54] <gerrit-wm>	 New review: Jdlrobson; "Rebased and merging after brion's +2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/40325
[12:03:56] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40325
[12:07:18] <gerrit-wm>	 New patchset: Jdlrobson; "show thumbnail instead of full size image" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39567
[13:16:06] <gerrit-wm>	 New review: Siebrand; "Given that some specific UI requirements are met, I'd be fine with the current L10n." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/41205
[15:17:56] <gerrit-wm>	 New review: Jdlrobson; "rebased and merged" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/39567
[15:17:57] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39567
[15:19:11] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41820
[15:19:32] <gerrit-wm>	 New patchset: Jdlrobson; "show temporary image as thumbnail size" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39568
[15:19:53] <gerrit-wm>	 New review: Jdlrobson; "rebased and merged" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/39568
[15:19:54] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39568
[15:26:50] <gerrit-wm>	 New patchset: Jdlrobson; "don't show edit link on protected pages (bug 41518)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39766
[15:27:00] <gerrit-wm>	 New review: Jdlrobson; "rebased and merged" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/39766
[15:27:00] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39766
[15:56:30] <MaxSem>	 jdlrobson, yup
[15:56:41] <jdlrobson>	 i'm struggling with getting the query right for https://gerrit.wikimedia.org/r/#/c/40306/2/includes/specials/SpecialMobileWatchlist.php
[15:56:51] <jdlrobson>	 i've got it working when the namespace is known
[15:57:05] <jdlrobson>	 but have no idea how to do it for all pages
[15:57:25] <jdlrobson>	 (although we currently don't surface this in the ui so not sure if that can be a fix me later thing)
[15:58:32] <MaxSem>	 there was no sprint kickoff in monday?
[15:58:48] <jdlrobson>	 not that i know of
[15:58:57] <jdlrobson>	 monday was new years eve so i was out :)
[15:59:12] <jdlrobson>	 but the new sprint has begun
[15:59:22] <jdlrobson>	 you and arthur were out
[16:01:12] <MaxSem>	 I'll take a look
[16:01:32] <MaxSem>	 btw, is the limit of 100 set somewhere in design?
[16:01:43] <MaxSem>	 cuz even desktop shows 50 by default
[16:03:23] <jdlrobson>	 nope just random number
[16:03:27] <jdlrobson>	 you can change it to 5 to test
[16:03:37] <jdlrobson>	 i'm just rebasing it
[16:06:21] <gerrit-wm>	 New patchset: Jdlrobson; "add pagination to watchlist a-z view (bug 43254)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40306
[16:06:53] <jdlrobson>	 MaxSem: ^
[16:07:10] <MaxSem>	 okie
[16:44:50] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962
[16:44:50] <gerrit-wm>	 New patchset: Jdlrobson; "change mf-settings.js into library rather than module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[16:45:35] <gerrit-wm>	 New review: Jdlrobson; "jgonera the settings refactor seemed to be confusing you so I have separated the watchlist specific ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41030
[16:46:59] <gerrit-wm>	 New patchset: Jdlrobson; "change mf-settings.js into library rather than module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[16:46:59] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962
[16:54:32] <gerrit-wm>	 New patchset: Jdlrobson; "update pre-commit hook to crush pngs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40788
[16:55:10] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40788
[16:56:20] <gerrit-wm>	 New review: Jdlrobson; "Please always look at dependencies to answer these questions. I know gerrit is annoying but the depe..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/40313
[17:09:11] <gerrit-wm>	 New review: Siebrand; "Missing i18n needs to be resolved." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41962
[17:53:24] * awjr  waves

[17:58:07] * brion  waves weakly from his cold-riddled state

[18:00:40] <MaxSem>	 standup, anyone?
[18:00:48] <brion>	 it's delayed 15 minutes
[18:08:59] <MaxSem>	 Maryana, I'm thinking of limiting watchlist to 50 items just  like on desktop - any objections?
[18:09:19] <Maryana>	 50 items and then a more button?
[18:09:47] <Maryana>	 or just 50 itmes and then you're done?
[18:10:53] <MaxSem>	 the former
[18:11:19] <Maryana>	 sounds good to me
[18:11:28] <MaxSem>	 ok
[18:15:21] <awjr>	 brion: joining us for standup?
[18:34:22] <tfinc>	 brion: do you have the iOS task ready to go?
[18:35:35] <tfinc>	 MaxSem: where are we with the next GeoData deployments ?
[18:36:59] <MaxSem>	 tfinc, still needs some replication work. I've created a story for it, we'll discuss its priority today
[18:38:07] <awjr>	 MaxSem: when you have a chance can you take a look at these changesets? https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/MobileFrontend+branch:master+topic:bug/35215+is:open,n,z
[18:38:30] <MaxSem>	 ok
[18:38:41] <MaxSem>	 will look shortly
[18:47:30] <jdlrobson>	 jgonera: have you been looking at templating languages at all?
[18:47:31] <tfinc>	 http://stats.wikimedia.org/EN/TablesPageViewsMonthlyMobile.htm <-- 44% increase. i don't trust it
[18:47:37] <tfinc>	 MaxSem: k
[18:47:42] <jgonera>	 jdlrobson, I have
[18:47:49] <jdlrobson>	 any preferred library?
[18:47:59] <jdlrobson>	 i have a reason to use one and am interested in playing around with oej
[18:48:32] <jgonera>	 jdlrobson, I see a different issue than a preferred library though, writing templates in JS code is super awkward due to no multiline strings and no syntax highlighting for HTML
[18:49:00] <jgonera>	 jdlrobson, oej?
[18:49:29] <jdlrobson>	 sorry.. not sure what happened there.. playing around with ideas
[18:49:44] <jgonera>	 jdlrobson, the usual way of putting templates within a <script> tag in HTML doesn't seem to be a good option in our case
[18:49:44] <jdlrobson>	 jgonera: so i want the html on the initial page load to contain the templates
[18:49:50] <jdlrobson>	 i was looking at languages
[18:50:05] <jgonera>	 jdlrobson, mhm, won't we load too much unneeded stuff?
[18:50:15] <jdlrobson>	 for instance in that case the div #mw-mf-language-section would become the template
[18:50:29] <jdlrobson>	 we would mark up the html so it knows where the value comes from
[18:50:37] <jdlrobson>	 it would load less than a script tag
[18:50:39] <jgonera>	 jdlrobson, my preference is to keep it simple, either underscore's templates (plus we get other goodies too) or hulk (which is compile-able mustache)
[18:50:58] <jdlrobson>	 for instance #mw-mf-language-section h2 might have data-value="title"
[18:51:19] <jdlrobson>	 meaning it's value comes from the value of the property title in the object that is passed to it
[18:51:23] <jgonera>	 jdlrobson, what templating lib uses data- attributes?
[18:51:31] <jgonera>	 yeah, I guessed
[18:51:47] <jgonera>	 anyway, we need the templates not to be interpreted as regular HTML
[18:51:56] <jdlrobson>	 jgonera: why do we need that?
[18:52:21] <jdlrobson>	 i think use of data attributes would be better than script template tags for instance
[18:52:24] <jgonera>	 that's why common practice is to put them in <script> tags but type=text/template or something (so they're also not interpreted as JS)
[18:52:52] <jdlrobson>	 jgonera: i hate that it sucks
[18:53:04] <jgonera>	 maybe, but we're still left with an HTML that is treated as normal HTML by the browser but has no content, right?
[18:53:06] <jdlrobson>	 it encourages repetition in a website where you want it to work without js
[18:53:14] <jdlrobson>	 not in our case jgonera
[18:53:18] <jdlrobson>	 as we initialize them with values
[18:53:29] <jdlrobson>	 the first page load shouldn't require any js to view content
[18:53:39] <jgonera>	 well, in most cases, probably yes, but not in all cases
[18:53:39] <jdlrobson>	 and it should also serve as the mechanism for serving templates
[18:53:53] <jdlrobson>	 jgonera: what cases would we not do that?
[18:54:38] <jgonera>	 I'd like to use the templates as much as possible. I imagine we can have a button "class" in JS (or a jQuery plugin) which automatically creates a button and attaches it to DOM
[18:54:57] <jgonera>	 and uses a template to generate button's HTML
[18:55:13] <jgonera>	 anyway, what was the templating lib you were looking at?
[18:57:34] <jgonera>	 jdlrobson, I don't see any dependencies in https://gerrit.wikimedia.org/r/#/c/40313/
[18:57:49] <jgonera>	 jdlrobson, forget it, I don't know why it was folded...
[18:57:57] <jdlrobson>	 jgonera: gerrit sucks
[19:06:10] <gerrit-wm>	 New patchset: Jdlrobson; "language search - correct inputs in overlay headers [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41975
[19:07:02] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/#/c/41030/6/javascripts/common/mf-settings.js new line creates cleaner diffs when you add libraries - i'm starting to like this js style - any issues with that?
[19:07:45] <jdlrobson>	 i don't care that much though - i'd rather get it merged
[19:08:56] <gerrit-wm>	 New patchset: Jdlrobson; "change mf-settings.js into library rather than module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[19:08:57] * jdlrobson  just fixes and merges it regardless

[19:09:11] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41030
[19:18:12] <gerrit-wm>	 New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962
[19:20:14] <jgonera>	 jdlrobson, haha, that's why I don't like onevar ;) a var not followed by anything does look weird to me
[19:23:03] <awjr>	 jdlrobson: im taking a look at https://gerrit.wikimedia.org/r/#/c/41584/2 - i'm seeing the new styling, but for some reason im still not seeing diff'd text in the diff view. is that expected?
[19:23:27] <jdlrobson>	 err
[19:23:31] <jdlrobson>	 what diff engine are you using?
[19:23:42] <awjr>	 i think wikidiff2 - lemme check
[19:23:46] <jdlrobson>	 remember https://gerrit.wikimedia.org/r/#/c/41182/ hasn't been merged
[19:23:48] <jdlrobson>	 so that's expected
[19:24:06] <jdlrobson>	 amir rebased it for some reason but didn't merge
[19:24:09] <jdlrobson>	 or comment
[19:24:15] <jdlrobson>	 i can only assume he was trying to submit it?
[19:24:15] <gerrit-wm>	 New review: JGonera; "Leaving as -1 since it seems we don't know if https://gerrit.wikimedia.org/r/#/c/40314/1 will actual..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/40313
[19:24:31] <awjr>	 ah i see
[19:24:37] <jdlrobson>	 jgonera: i could have saved you time reviewing that one...
[19:24:42] <jdlrobson>	 or rereviewing
[19:24:56] <jdlrobson>	 i just wanted to point out that usually the answers to your questions are hidden away in gerrit :)
[19:25:24] <jgonera>	 jdlrobson, yes, "hidden" is the right word ;)
[19:27:10] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41182
[19:32:58] <awjr>	 jdlrobson: can you rebase this and fix the conflicts? i tried fixing the conflicts but think i did it wrong: https://gerrit.wikimedia.org/r/#/c/41584/2
[19:33:05] <jdlrobson>	 sure
[19:33:32] <awjr>	 ty
[19:35:52] <gerrit-wm>	 New patchset: Jdlrobson; "improve styling of diff page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41584
[19:36:18] <jdlrobson>	 awjr: done
[19:37:19] <awjr>	 jdlrobson: thanks dude
[19:37:21] <awjr>	 ill merge shortly
[19:37:37] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41975
[19:39:05] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41584
[19:43:31] <jgonera>	 tfinc, if I want to write a draft about how our JS code could be refactored, where do I do it? one of he wikis? etherpad?
[19:43:53] <tfinc>	 hmm
[19:44:10] <tfinc>	 put up a proposal on wiki and then mail
[19:44:16] <tfinc>	 we can then edit it to be our guidelines
[19:44:21] <tfinc>	 nice and public that way
[19:44:45] <tfinc>	 brion: awesome interview in the signpost
[19:45:35] <jgonera>	 which wiki then?
[19:46:45] <tfinc>	 mw
[19:46:48] <tfinc>	 mediawiki.org
[19:49:39] <gerrit-wm>	 New review: awjrichards; "Clicking the watchlist star as a logged out user in beta gives me the following JS error in Chrome (..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41962
[19:52:50] <gerrit-wm>	 New patchset: Jdlrobson; "replace list of image names with a list of thumbnails [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39571
[19:56:00] <jgonera>	 jdlrobson, speaking of templates, let's say we'd like to replace the code in (master) - https://gerrit.wikimedia.org/r/41584
[19:56:01] <jgonera>	 * multichill (~multichil@zembla.brewery.verymad.net) has joined #wikimedia-mobile
[19:56:01] <jgonera>	 <jgonera> tfinc, if I want to write a draft about how our JS code could be refactored, where do I do it? one of he wikis? etherpad?
[19:56:01] <jgonera>	 <tfinc> hmm
[19:56:01] <jgonera>	 <tfinc> put up a proposal on wiki and then mail
[19:56:03] <jgonera>	 <tfinc> we can then edit it to be our guidelines
[19:56:05] <jgonera>	 <tfinc> nice and public that way
[19:56:07] <jgonera>	 <tfinc> brion: awesome interview in the signpost
[19:56:09] <jgonera>	 * chrismcmahon is now known as chrismcmahonafk
[19:56:11] <jgonera>	 <jgonera> which wiki then?
[19:56:15] <jgonera>	 <tfinc> mw
[19:56:17] <jgonera>	 <tfinc> mediawiki.org
[19:56:19] <jgonera>	 <gerrit-wm> New review: awjrichards; "Clicking the watchlist star as a logged out user in beta gives me the following JS error in Chrome (..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41962
[19:56:23] <jgonera>	 <gerrit-wm> New patchset: Jdlrobson; "replace list of image names with a list of thumbnails [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39571 (L118 and below) with a template. how would you go about it?
[19:56:25] <multichill>	 jgonera: Cut it out
[19:56:26] * tfinc  wonders if jgonera is out new log bot

[19:56:27] <jgonera>	 omg
[19:56:29] <jgonera>	 I'm not quite sure how that happened
[19:56:31] <tfinc>	 our*
[19:56:38] <jcmish>	 hahaha
[19:56:45] <jcmish>	 I was like what the heck just happened
[19:56:55] <jgonera>	 wow
[19:57:08] <jcmish>	 how'd you do that?
[19:57:29] <jgonera>	 that's funny, XChat interpreted what I wrote "L <number> and below" and took it from the chat log
[19:57:41] <jcmish>	 holy cow
[19:57:43] <jgonera>	 but I was referring to a file from gerrit :O
[19:58:06] <jcmish>	 wow that was kind of neat
[19:58:16] <jcmish>	 disturbing though :D
[19:59:58] <jgonera>	 jdlrobson, speaking of templates, let's say we'd like to replace the code in (master) - https://gerrit.wikimedia.org/r/41584 (l*i+n#e 118 and below) with a template. how would you go about it?
[20:00:01] <tfinc>	 MaxSem: i have yet to hear back from the open source days organizers. time to message them again
[20:01:16] <MaxSem>	 tfinc, what about the other options mentioned at https://www.mediawiki.org/wiki/Events/Wikimedia_Mapping_Event_2013 ?
[20:02:02] <tfinc>	 MaxSem: i'll fall back to them if open source days doesn't work out
[20:02:40] <tfinc>	 i don't want to wait until may though
[20:02:50] <jdlrobson>	 jgonera: i'm not convinced templates are necessary here.
[20:03:04] <tfinc>	 and i have no interest in organizing our own event
[20:03:16] <jdlrobson>	 awjr: you there?
[20:03:27] <awjr>	 jdlrobson: yup
[20:03:28] <jdlrobson>	 i can't recreate your problem with https://gerrit.wikimedia.org/r/#/c/41962/ but i have found a similar problem in master..
[20:03:38] <jdlrobson>	 i'm getting Uncaught TypeError: Cannot read property 'createOverlay' of undefined  in mf-languages.js
[20:03:48] <awjr>	 hmm
[20:04:11] <jdlrobson>	 must be RL related
[20:04:29] <awjr>	 jdlrobson: yeah im getting a TypeError too in master, though im not sure what it's relating to
[20:04:51] <awjr>	 yeah, createOverlay also
[20:05:19] <jdlrobson>	 can you replicate on master?
[20:05:27] <jdlrobson>	 beat me too it :)
[20:05:31] <jdlrobson>	 easy fix..
[20:05:42] <awjr>	 :)
[20:07:31] <gerrit-wm>	 New patchset: Jdlrobson; "RL fix: fix dependency [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41980
[20:07:33] <jdlrobson>	 ^ awjr_lunch
[20:26:47] <MaxSem>	 mmm, Reedy's deploying wmf7 to testwiki - how many MF changes will go live?
[20:27:13] <Reedy>	 https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf7#MobileFrontend
[20:29:06] <MaxSem>	 omg
[21:05:28] <awjr>	 MaxSem, Reedy those changes are going live today?
[21:05:39] <Reedy>	 Only on test, test2 and mediawikiwiki
[21:05:45] <MaxSem>	 awjr, so9 far on a small subset of wikis
[21:06:09] <multichill>	 Reedy: Any api changes going live? (as in, will all the bots break again)
[21:06:48] <Reedy>	 multichill: I think there is one, but I don't know what it breaks. Ask Anomie
[21:06:49] <awjr>	 Reedy so when there's a new wmf branch, extensions point to head of master rather than the point from which they were last deployed?
[21:07:02] <Reedy>	 by default, yes
[21:07:08] <multichill>	 Maybe the SHA1 regression in the api?
[21:07:33] <awjr>	 Reedy unless we have a separate deployment branch?
[21:08:00] <jdlrobson_dinner>	 awjr: https://gerrit.wikimedia.org/r/41980
[21:08:27] <Reedy>	 awjr: That or just pin it to a specific revision in make-wmf-branch
[21:08:27] <Reedy>	 https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/tools/release.git;a=blob;f=make-wmf-branch/default.conf;h=864803e54e48146861d53eae3378a521d660c7de;hb=HEAD
[21:08:35] <gerrit-wm>	 New review: Jdlrobson; "This issue is not with the current patchset" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41962
[21:08:41] <awjr>	 Reedy what is make-wmf-branch?
[21:08:53] <awjr>	 oh i see
[21:09:03] <Reedy>	 The script that pulls everything together
[21:10:15] * jdlrobson  can't wait to get back to PST time

[21:10:27] <gerrit-wm>	 New patchset: MaxSem; "add pagination to watchlist a-z view (bug 43254)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40306
[21:10:34] <MaxSem>	 jdlrobson, ^^^
[21:11:24] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41980
[21:11:33] <gerrit-wm>	 New patchset: awjrichards; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962
[21:18:26] <gerrit-wm>	 New review: awjrichards; "See inline comments. Also, if I click the watch star as a non-logged in user, then log in to an acco..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/41962
[21:25:16] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41012
[21:30:14] <tfinc>	 jdlrobson: our hangout would like to see you
[21:30:17] <awjr>	 jcmish, jgonera, jdlrobson, brion, Maryana retrospective!
[21:30:18] <tfinc>	 brion: --^
[21:30:34] <jcmish>	 I need about 5 mins
[21:30:37] <jcmish>	 but start without me
[21:31:27] <jdlrobson>	 oohh sorry
[21:33:26] <MaxSem>	 ep link plz
[21:34:04] <MaxSem>	 awjr, ^^
[21:34:15] <awjr>	 MaxSem: http://etherpad.wikimedia.org/mobile-retrospective-20120102
[21:58:02] <jcmish>	 in gerrit hell
[21:58:11] <jcmish>	 need to finish sorry folx I'll catch up later
[22:25:49] <jcmish>	 awjr:  did I miss the kickoff?
[22:26:58] <awjr>	 jcmish we're finishing up now
[22:27:08] <jcmish>	 :(
[22:27:10] <jcmish>	 I'm sorry
[22:37:33] <MaxSem>	 Reedy, "# Extensions extensions that we want to copy their status from the previous branch
[22:37:34] <MaxSem>	 # The key is the extension name and the value is either true (copy last branch) or
[22:37:34] <MaxSem>	 # a string (use that exact commit hash)"
[22:37:45] <MaxSem>	 'DataValues' => '2012-12-05',
[22:37:58] <MaxSem>	 so what does this array store?:P
[22:44:38] <Reedy>	 MaxSem: I think that's a branch
[22:44:47] <Reedy>	 Git will let you do weird shizz
[22:44:53] <MaxSem>	 hehe
[22:45:01] <MaxSem>	 okay, I'm trying this out...
[22:45:14] <MaxSem>	 maybe we'll see in a couple hours..
[22:49:16] <jgonera>	 jdlrobson, I'm getting TypeError: M.navigation is undefined in mf-languages on master
[22:49:25] <jdlrobson>	 rebase
[22:50:09] <jgonera>	 you mean pull?
[22:50:34] <jgonera>	 ok
[22:50:36] <jgonera>	 works
[22:51:08] <jgonera>	 jdlrobson, regarding the watchlist UI problems you're seeing - did you clear the browser cache?
[22:51:18] <jdlrobson>	 yup
[22:51:27] <jdlrobson>	 don't know what's going on there
[22:51:49] <jgonera>	 will check again soon
[22:52:09] <gerrit-wm>	 New patchset: Jdlrobson; "never try to run js on a bad phone" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42040
[22:52:52] <jgonera>	 and about the css issues, can we leave it as is and sort it out in a separate changeset or would you prefer me to think about including #content_wrapper selectively now? I kind of feel it's a bigger change that doesn't belong to the watchlist UI changeset
[22:54:28] <jgonera>	 jdlrobson, ^
[22:54:33] <jdlrobson>	 yeh thinking
[22:56:14] <jdlrobson>	 sorry i got really confused as https://gerrit.wikimedia.org/r/#/c/41962/ seems to have reverted to an older patchset
[22:56:58] <jdlrobson>	 so jgonera i was suggesting disabling the margin on special pages
[22:57:14] <jdlrobson>	 i'd be surprised if that was a big chunk of work
[22:57:21] <jgonera>	 jdlrobson, I know, but we shouldn't do it on all special pages
[22:57:29] <jgonera>	 e.g. we don't want to do it in settings
[22:57:31] <jdlrobson>	 why not?
[22:57:47] <jgonera>	 well, just disable it in Chrome and see ;)
[22:57:49] <jdlrobson>	 it's just the margin right?
[22:57:59] <jgonera>	 no, it's the top margin
[22:58:15] <jdlrobson>	 sorry that was bad choice of words
[22:58:37] <jdlrobson>	 i'll tell you what jgonera - i'll look into the margin top issue in a bit and fix it
[22:58:38] <jgonera>	 or too quick reading on my side
[22:59:29] <jgonera>	 ok, but I don't see how this can be fixed in any other way than not having #content_wrapper on some pages (and those are not all special pages)
[23:00:58] <jgonera>	 jdlrobson, I'm also trying to make https://gerrit.wikimedia.org/r/#/c/39176/2 use the RL again, but for some reason it doesn't work (JS is not loaded). have we changed something related to RL recently?
[23:02:05] <jdlrobson>	 jgonera: Change-Id: Idaa82d2efa675c463068375836e3579fa6644d68
[23:02:25] <jdlrobson>	 jgonera: focus on non margin related stuff for time being and i'll take a look
[23:02:46] <jgonera>	 jdlrobson, ok
[23:07:29] <jgonera>	 jdlrobson, why aren't we using $out->addModules() ?
[23:09:23] <MaxSem>	 jgonera, because of the no-jQuery mode
[23:09:46] <jgonera>	 so $out->addModules() needs jQuery?
[23:13:34] <tfinc>	 jcmish: brion and you need to talk about wikipedia zero planning. we still need to do it even though the feature that would have required it is going on the back burner
[23:14:15] <jcmish>	 tfinc:  yup understood
[23:14:22] <jcmish>	 either way I need to understand it
[23:14:33] <jcmish>	 so we'll keep working towards it regardless
[23:18:32] <gerrit-wm>	 New patchset: JGonera; "Add Last modified" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39176
[23:18:38] <gerrit-wm>	 New patchset: Zfilipin; "Setup for Selenium tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771
[23:19:16] <gerrit-wm>	 New review: Zfilipin; "Fixed .rvmrc and config files." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39771
[23:19:35] <gerrit-wm>	 New review: JGonera; "Patchset 4 uses mw.msg() again which solves plural forms in all languages." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/39176
[23:22:27] <gerrit-wm>	 New patchset: Jdlrobson; "don't enforce a margin top on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42047
[23:22:39] <jdlrobson>	 jgonera: ^ feel free to merge if your happy with it and use for your watch list styling
[23:22:41] <MaxSem>	 okay, I've reverted MF in 1.21wmf7 to the same version as wmf6
[23:23:03] <jdlrobson>	 jgonera: so $out->addModules() needs jQuery? < yes
[23:23:09] <jdlrobson>	 we're almost there :)
[23:25:18] <MaxSem>	 awjr, I'm unable to move a card from in testing to anythin other than ready for signoff
[23:25:34] <MaxSem>	 I want to kick it back to awaiting code review
[23:26:15] <jgonera>	 jdlrobson, jdlrobson, why not add a content class to the form instead of https://gerrit.wikimedia.org/r/#/c/42047/1/stylesheets/less/specials/mf-settings.less
[23:26:52] <jdlrobson>	 i did that...?
[23:27:03] * jdlrobson  confused jgonera 

[23:27:11] <jdlrobson>	 ohh sorry i understand
[23:27:15] <jgonera>	 I mean
[23:27:16] <jgonera>	 ;)
[23:27:26] <jdlrobson>	 um.. not quite as simple
[23:27:29] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/42047/1/stylesheets/less/common/mf-navigation.less
[23:27:53] <jdlrobson>	 could add a content id
[23:27:58] <jdlrobson>	 but was trying to avoid divitis
[23:27:59] <jgonera>	 oh, it's not a class now...
[23:28:07] <jdlrobson>	 it could probably be cleaned up
[23:28:18] <jdlrobson>	 but it feels better than resorting to - margins all over the place
[23:28:19] <jgonera>	 sure, but I would also avoid having various CSS rules that do the same thing
[23:28:49] <jcmish>	 Hey MaxSem is the deployment branch that you created going to be used going forward so same branch for every deployment or will you create special branches? And will there be a different branch for alpha, beta and trunk or will those all be in this one deployment branch?
[23:28:52] <jdlrobson>	 the preferred way to do it would be to give the form and id content
[23:28:59] <jdlrobson>	 but that would require some distangling
[23:29:00] <jgonera>	 what I was thinking about is having one kind of CSS class for wrappers on pages with margins and another (or no class) for pages without them
[23:29:24] <jdlrobson>	 (or stop using #content altogether in favor of .content)
[23:29:37] <jgonera>	 that's not a bad idea
[23:29:50] <jdlrobson>	 I could add a fix me note to all of these?
[23:29:51] <MaxSem>	 jcmish, there will be just one branch - for whatever is (going to be) live on cluster
[23:30:19] <jdlrobson>	 actually i could just fix now.. 1s
[23:30:26] <jcmish>	 k thanks MaxSem
[23:30:29] <jgonera>	 jdlrobson, hm, you could, but why would it be difficult to fix?
[23:30:32] <jgonera>	 ok ;)
[23:31:07] <MaxSem>	 jcmish, this changes nothing for you, you will need to keep testing master
[23:32:12] <jcmish>	 yessir understood that's why I asked those questions
[23:41:05] <gerrit-wm>	 New patchset: Jdlrobson; "don't enforce a margin top on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42047
[23:41:07] <jdlrobson>	 jgonera: attempt 2 ^
[23:41:17] <awjr>	 jdlrobson: i see https://mingle.corp.wikimedia.org/projects/mobile/cards/299 is still in 'ready for analysis' - what do we need to do to move forward with it?
[23:41:29] * jdlrobson  looks

[23:41:50] <jdlrobson>	 mingle gone down for me :(
[23:42:40] <awjr>	 jdlrobson: also curious about what we're waiting for on https://mingle.corp.wikimedia.org/projects/mobile/cards/307
[23:42:44] <jgonera>	 jdlrobson, seems ok, let me just quickly test
[23:42:46] <awjr>	 jdlrobson: mingle is working OK for me
[23:43:41] <jdlrobson>	 mm This webpage is not available
[23:43:58] <jdlrobson>	 how odd
[23:44:00] <jdlrobson>	 can't get in
[23:44:03] <jgonera>	 jdlrobson, the Contact us page totally changes, I don't know if that's intentional
[23:44:12] <jdlrobson>	 jgonera: ?
[23:44:37] <jgonera>	 jdlrobson, the changeset makes it look different, it now shows the form by default, I don't know why
[23:44:47] <jdlrobson>	 works for me jgonera ..
[23:45:16] <awjr>	 jdlrobson: card #299 is a task titled 'Prevent photo uploads showing on disambiguation pages', and there are no comments or any other info
[23:45:22] <jdlrobson>	 ahh ok
[23:45:24] <jgonera>	 jdlrobson, and the main page doesn't have a margin, probably because it doesn't have a heading
[23:45:28] <jdlrobson>	 so i was talking to kaldari about this
[23:46:01] <jdlrobson>	 basically https://gerrit.wikimedia.org/r/#/c/41043/ should work us but we are going to have to introduce the MakeGlobalVariablesScript hook to MobileFrontend < awjr
[23:46:14] <jdlrobson>	 jgonera: that's always been the case with the homepage
[23:46:33] <jgonera>	 jdlrobson, still the contact us looks different than on master
[23:46:40] <awjr>	 jdlrobson: ah ok, so the card is blocked on the other extension?
[23:46:46] <jgonera>	 and by the way, the Log in link no longer works for me on master
[23:47:05] <jdlrobson>	 jgonera: it doesn't for me though! contact looks fine… what's different about your setup?!
[23:47:17] <jgonera>	 jdlrobson, let me check again
[23:47:32] <jdlrobson>	 jgonera: i suspect the login link is trying to https on localhost
[23:47:46] <jdlrobson>	 you may need to disable the variable awjr brought in
[23:47:56] <jdlrobson>	 awjr: yup that's all i know :)
[23:48:07] <jgonera>	 yes, you're right about the login
[23:48:34] <awjr>	 jdlrobson: OK thanks
[23:48:51] <awjr>	 jdlrobson: also, #307 is about the empty message on watchlist - what is blocking that?
[23:49:08] <jdlrobson>	 awjr: just man hours - i'd argue it's not urgent though as there is a message now saying your watch list is empty
[23:49:32] <awjr>	 jdlrobson: then isn't that done?
[23:49:45] <jdlrobson>	 no
[23:49:58] <jdlrobson>	 see attachment
[23:50:05] <jdlrobson>	 that's different to what we currently have (just text)
[23:50:09] <awjr>	 jdlrobson: the attachment must be incorrect
[23:50:17] <awjr>	 it shows a picture of the watchlist star
[23:50:19] <tfinc>	 jdlrobson: awjr MaxSem jgonera brion jcmish : http://www.ubuntu.com/devices/phone
[23:50:20] <jdlrobson>	 ok mingle is working for me again now
[23:50:23] <MaxSem>	 awjr, I'm unable to move a card from in testing to anythin other than ready for signoff
[23:50:28] <tfinc>	 i'm pretty excited to try this guy out
[23:50:36] <awjr>	 MaxSem which card?
[23:50:42] <jdlrobson>	 awjr: attachment is correct
[23:50:50] <jdlrobson>	 the idea was to put that picture in the empty message
[23:50:50] <MaxSem>	 awjr, https://mingle.corp.wikimedia.org/projects/mobile/cards/318
[23:50:57] <jgonera>	 jdlrobson, master: http://i.imgur.com/WhmGX.png, your changeset: http://i.imgur.com/Sz0dP.png
[23:50:59] <jdlrobson>	 i think - check with vihba and Maryana
[23:51:02] <awjr>	 jdlrobson: ohhhh
[23:51:15] <awjr>	 jdlrobson: ok i get it now, thanks
[23:51:23] <jcmish>	 tfinc:  holy cow
[23:51:27] <awjr>	 MaxSem: where are you trying to move it?
[23:51:32] <jcmish>	 okay we need this right? :D
[23:51:42] <MaxSem>	 awjr, to awaiting CR
[23:51:54] <tfinc>	 fast forward to 5:34 to see the phone
[23:51:56] <tfinc>	 jcmish: --^
[23:52:02] <awjr>	 MaxSem: ok, i can fix it - i think i need to update transitions for tasks since we added that column
[23:52:26] <awjr>	 MaxSem: in the meantime, i've moved it to awaiating cr
[23:52:33] <MaxSem>	 thx
[23:52:36] <awjr>	 np
[23:53:12] <MaxSem>	 awjr, why https://gerrit.wikimedia.org/r/#/c/41190/3/includes/MobileFrontend.body.php is done via a hook, can't it be done in execute()?
[23:53:18] <jdlrobson>	 jgonera: let me try something
[23:53:45] <jcmish>	 tfinc:  I think we need the tv!
[23:53:50] <jcmish>	 I changed my mind…
[23:54:07] <jgonera>	 jdlrobson, it's like if the form jumped out of the Technical problem section
[23:54:43] <jcmish>	 tfinc: the phone is awesome but I dunno I've been burned before
[23:54:45] <awjr>	 MaxSem: yeah but then we'd check if it's a UserLogin page on every render. putting it in that hook limits the check to only when specialpages are requested
[23:54:59] <tfinc>	 i'm contacting the to get some test phones
[23:55:04] <jcmish>	 woohoo!
[23:55:05] <gerrit-wm>	 New patchset: Jdlrobson; "don't enforce a margin top on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42047
[23:55:13] <jdlrobson>	 jgonera: same issue with that one?
[23:55:55] <jgonera>	 jdlrobson, looks fine now, so it only worked like that for me?
[23:56:42] <jgonera>	 jdlrobson, Donate image also misses margins now
[23:56:42] <gerrit-wm>	 New review: Jdlrobson; "just fixing up and mergin now.." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/41962
[23:57:14] <jcmish>	 tfinc:  I wonder if this will marry well with firefoxOS
[23:57:28] <tfinc>	 jcmish: i'd say it competes directly with it
[23:57:48] <jcmish>	 yeah that's my guess but it's gonna be interesting to see what happens
[23:57:58] <jdlrobson>	 jgonera: can you add them i really need to get something else merged before i go to bed
[23:58:24] <jgonera>	 jdlrobson, sure, will do it and merge
[23:58:30] <jdlrobson>	 perfect