[00:02:50] tfinc, jgonera, awjr: Just noticed we are watching the same video. [00:05:57] rmoen: lolz. come by then! [00:06:57] New patchset: Jdlrobson; "show watchlist star when not logged in [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962 [00:13:42] jgonera: another one to look at if you haven't - http://sammyjs.org/ [00:14:13] jdlrobson, heard about it some time ago [00:14:30] same i've forgotten all about it - but i remember it looking quite nice when i looked at it before [00:15:13] jdlrobson, will have a look at it tomorrow [00:17:10] jgonera: this looks promising - http://leonidas.github.com/transparency/ [00:17:32] New review: JGonera; "I don't know what messed up dependencies in gerrit, but other than that it seems ok." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/39773 [00:19:04] right i'm off to bed - anyone need anything before i go? [00:19:09] will be doing more PST hours tomorrow [00:19:19] (today in the UK) [00:19:40] jdlrobson, doesn't look bad but I'm wondering how it handles ambiguous situations like a div with class content and another div with id content [00:19:59] jdlrobson, or two divs and { div: 'some text' } as data [00:23:50] jdlrobson, but definitely worth looking at, good find [00:33:26] New review: Cmcmahon; "Looks good, I want to see this run" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39773 [00:34:38] New patchset: JGonera; "don't enforce a margin top on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42047 [00:34:38] New review: Cmcmahon; "+2 to get mobile tests running" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39771 [00:34:39] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39771 [00:35:06] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42047 [00:35:17] New review: Cmcmahon; "dependency satisfied, trying to merge" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39773 [00:45:53] New patchset: awjrichards; "The first two Selenium tests: mobile Search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39773 [00:46:25] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39773 [01:17:59] New patchset: Ori.livneh; "Load EventLogging if it is enabled and present." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42064 [01:23:52] jcmish: https://play.google.com/store/apps/details?id=org.wikipedia no links directly to peoples google play profiles . even easier to message people [01:24:53] ohh [01:25:06] bookmarking it now [02:01:57] New review: awjrichards; "The essence of the patch set it great - there's no reason we should be linking to js scripts if the ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42040 [02:02:38] New review: awjrichards; "Wow. Forgot to -1, then +1'd instead, and now actually marking -1. See comments above." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42040 [09:50:37] New review: Siebrand; "L10n/i18n is fine." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/41962 [16:57:48] ohhh brion how goes it with info on Zero? [17:46:59] * awjr waves [17:47:20] * YuviPanda waves at awjr [17:48:26] * Maryana waves, too [17:48:55] I was supposed to be back on Staff from yesterday(?) [17:48:59] i'm not sure who I am now though [17:51:00] staffpanda? [17:51:33] YuviPanda: still yuvi :) [17:51:36] Maryana: potentially [17:51:58] i'm supposed to be working mondays through wednesdays, and I still have a Sue interview pending [17:52:01] YuviPanda: tomasz will probably be in shortly - i suspect he's got things figured out on how to move forward [17:52:04] I think tfinc can claer things up [17:52:04] yes [17:52:11] i'm figuring out the IME stuff anyway :) [17:52:11] potentiallystaffpanda is probably too long for nickerv to handle :) [17:52:26] *nickserv [17:53:02] :D [17:53:43] this fits intside the limits [17:54:25] Maryana: looking forward to being back on the staff channel :P [17:54:35] haha [17:54:48] i never hang out in the staff channel [17:55:08] me and oliver used to make noise [17:55:17] the grownups had to ssshhh us a few times [17:55:24] ha. sounds about right [17:55:25] lol [18:21:45] * Reedy glares at MaxSem [18:22:03] really? [18:22:08] Yup [18:22:21] If you add an extension to all wikis, you need to update WikimediaMaintenance/addWiki.php [18:22:32] It just died due to the missing geotags tables [18:22:48] Any other default install extensions? [18:22:54] mmm, the trick is that it isn't enabled on _all_ wikis [18:23:12] just wikipedias and special [18:23:28] It's on Wikivoyage [18:23:33] 'wmgEnableGeoData' => array( [18:23:34] 'default' => false, [18:23:34] 'testwiki' => true, [18:23:34] 'test2wiki' => true, [18:23:34] 'enwiki' => true, [18:23:34] 'wiki' => true, [18:23:37] 'wikivoyage' => true, [18:23:39] 'commonswiki' => false, [18:23:41] 'wikidatawiki' => false, [18:23:43] Reedy, PageImages - but it requires no schema changes [18:23:43] 'metawiki' => false, [18:23:45] ), [18:23:52] oh, right [18:23:56] lol [18:24:10] In these cases, it'd be safer just to add it by default, shouldn't do any harm :p [18:24:12] MaxSem: no geodata on commons? [18:24:20] PurgatoryPanda, not yet [18:24:24] * Reedy fixes [18:24:39] ah [18:25:34] should be enabled later, when we have more ideas about image geosearch workflows [18:25:59] MaxSem: I want externally-backed.sql right? [18:26:24] Do I need wmfFixTables.sql too? [18:26:57] Reedy, yes/no [18:29:08] is there a jgonera around? [18:30:18] hmm. or anyone who reviewed his code for last modified on mobile? :) [18:31:48] maxsem ^ ? [18:34:33] Maryana, I don't see that problem anymore, but can't merge [18:36:38] i have not seen jgonera today [18:37:15] Maryana: whyfor? [18:38:10] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41962 [18:38:35] nm, found it in gerrit. was just trying to remember what copy is used - is it "this page was last modified…" or "this page was last edited..." [18:41:08] reading changes in gerrit makes me feel ultra 1337 [18:42:11] lulz [18:42:35] Maryana: maybe we should poke chad and bring back the 'puke green' color scheme :P [18:42:59] oh dear lord no [18:43:28] New review: awjrichards; "Just noticed jdlrobson already +1'd - merging now." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39176 [19:01:10] New patchset: awjrichards; "Add support for Apache Mobile Filter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40298 [19:04:03] New review: awjrichards; "I took a stab at updating this. From what I can tell from the AMF docs on the wiki, a tablet will st..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40298 [19:04:11] walgreens run then i'll finish up the privacy policy tweaks for the apps. wheee sickness [19:06:19] awjr: bit confused by https://gerrit.wikimedia.org/r/#/c/42040/1/includes/skins/SkinMobile.php [19:06:34] * awjr looks [19:06:56] jdlrobson: you're still doing processing around bottomscripts related stuff that you don't need to do if you're not going to bother setting it [19:06:59] i just don't see how else i could do this without complicating code.. [19:07:07] i'm not though.. [19:07:17] one sec lemme pull up the code [19:07:27] as jQueryEnabled is a stronger version of jsEnabled.. [19:07:50] i suppose the isFilePage and action stuff could be wrapped [19:08:08] but the modules also are used for css [19:08:11] which is always added [19:09:18] jdlrobson: are you talking about line 274? [19:09:58] jdlrobson: it seems to me that you just need to put another conditional around line 274 [19:09:59] i suppose I could alter that line instead awjr [19:10:01] yeah [19:10:04] ok can do that [19:10:09] will do now [19:10:14] :) [19:10:57] also awjr are you experiencing weirdness with mobilefrontend? [19:11:02] modules seem to be loading more than once for me [19:11:23] jdlrobson: on master? [19:11:48] yup [19:11:54] it might be just something messed up with my instance [19:11:56] New patchset: Jdlrobson; "never try to run js on a bad phone" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42040 [19:12:00] but i'm seeing 4 toggle buttons at times [19:12:57] very inconsistent :/ [19:13:47] New patchset: JGonera; "Add Last modified" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39176 [19:14:23] awjr, I rebased https://gerrit.wikimedia.org/r/#/c/39176/, should I merge it myself? [19:15:08] jgonera: i can double check and merge it - one sec [19:15:17] ok [19:20:17] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39176 [19:21:03] jgonera ^ [19:21:11] anyone see a tfinc? [19:21:57] PurgatoryPanda: he's in the office but i think he's in a meeting right now [19:22:19] MaxSem: when you've got some time, can you take a look at https://gerrit.wikimedia.org/r/#/c/41190/ ? [19:23:25] jdlrobson: i haven't seen that problem locally, maybe time for a cache purge? [19:23:36] maybe.. [19:23:37] awjr, merge conflict [19:23:38] very odd though [19:23:45] doh [19:23:59] awjr: ah, ok [19:25:34] awjr, thanks! [19:34:03] New patchset: awjrichards; "Always ensure Special:Userlogin is handled by https, if enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41190 [19:34:07] MaxSem ^ [19:34:14] rebased [19:36:35] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41190 [19:36:56] w00t thanks MaxSem [19:38:34] why am i trying to set the 'src' on an ? i must be sick :P [19:39:45] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42040 [19:42:52] ergg awjr still having same issues with my local instance.. annoying me now :) [19:43:16] * PurgatoryPanda waves at brion [19:43:21] heyyyyy [19:43:46] "arning: Cannot modify header information - headers already sent by (output started at /Users/jrobson/Sites/w/includes/OutputPage.php:1997) in /Users/jrobson/Sites/w/includes/Exception.php on line 269 [19:43:47] " seems related [19:43:59] brion: I just got the default Google Android keyboard to build by itself :D [19:44:05] awesommmme [19:44:07] still crashes on run, but it's a start! [19:44:10] hehe [19:44:21] now once I get that to properly run, off to porting the jQuery.IME code [19:44:55] jdlrobson: do you have exceptions enabled? [19:45:12] probably awjr [19:45:21] jdlrobson: make sure you have $wgShowExceptionDetails = true; set in LocalSettings [19:45:21] how do i check [19:45:26] see above :) [19:45:46] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/lEKk2g [19:45:46] WikipediaMobile/master 52e0c42 Brion Vibber: * (bug 42967, 42968, 42970, 42971) Add terms of service and privacy policy links to page footer in app... [19:46:04] awjr: that suppresses the messages but i'm still getting 4 toggle buttons :/ [19:46:08] (i'm on beta) [19:46:10] Project WikipediaMobile - Nightly builds build #479: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/479/ [19:46:10] Brion VIBBER: * (bug 42967, 42968, 42970, 42971) Add terms of service and privacy policy links to page footer in app [19:46:18] shit did i leave the 'alert' in there? [19:46:19] jdlrobson: are you on a clean copy of master? [19:46:26] yup [19:46:31] sighhhhh [19:46:46] * jdlrobson updates core [19:47:12] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/9S-Yxw [19:47:12] WikipediaMobile/master 0085ee4 Brion Vibber: fix stupid debug left in line [19:47:15] Project WikipediaMobile - Nightly builds build #480: SUCCESS in 7.4 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/480/ [19:47:16] Brion VIBBER: fix stupid debug left in line [19:47:29] jdlrobson: i am not seeing the problem locally [19:47:43] mm core update seems to have fixed it [19:47:50] phew [19:47:52] very odd [19:48:05] [WikipediaMobile] brion pushed 2 new commits to v3.3-iOS: http://git.io/zYoqFg [19:48:05] WikipediaMobile/v3.3-iOS af0b10d Brion Vibber: * (bug 42967, 42968, 42970, 42971) Add terms of service and privacy policy links to page footer in app... [19:48:05] WikipediaMobile/v3.3-iOS d81e628 Brion Vibber: fix stupid debug left in line [19:48:10] Project WikipediaMobile - Nightly builds build #481: SUCCESS in 8.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/481/ [19:48:11] * Brion VIBBER: * (bug 42967, 42968, 42970, 42971) Add terms of service and privacy policy links to page footer in app [19:48:11] * Brion VIBBER: fix stupid debug left in line [19:51:51] PurgatoryPanda: howdy. i hear you were looking for me [19:58:26] tfinc: hello [19:58:47] tfinc: Sue interview scheduled for Tuesday :) [19:58:55] PurgatoryPanda: i saw. it'll be great [19:59:00] so I suppose I start Tuesday? [19:59:23] you can *return* whatever time you want up to Tuesday [19:59:38] ah :D [19:59:42] i like the terminology :) [20:00:36] tfinc: I've already been hacking away on the keyboard today. Have the build up and running. Will hack on it more tomorrow. [20:01:06] tfinc: Monday'll be out (conducting a MW hackathon on Sat, Sun, Mon nights). [20:01:26] tfinc: should I just keep putting status updates on mediawiki.org/wiki/Mobile_i18n [20:01:29] ? [20:04:04] PurgatoryPanda: do it. Brion is out sick and should be back Monday [20:04:28] PurgatoryPanda: keep iterating on https://www.mediawiki.org/wiki/Mobile/2013_strategy_planning [20:04:41] ah that too [20:06:09] whee [20:17:28] hey brion : i'm munching on some lunch now. after i'll mail you what we discussed at the partner meeting. i have a handful of followups for you [20:17:39] excellent [20:19:48] Change abandoned: Jdlrobson; "not going to work" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40314 [20:21:44] uhoh PurgatoryPanda why are you in Purgatory? [20:27:31] gonna grab lunch [20:35:39] brion: http://readwrite.com/2013/01/02/good-bye-netbooks-no-one-is-going-to-miss-you [20:35:48] hehe [20:36:04] i sorta liked my old dell mini 10 but damn i hated that keyboard [20:36:29] on the other hand, i could actually run a web stack on it -- which tablets don't do so well [20:36:58] tfinc, Maryana: are we limited to 1000 photo uploaders per month, or 1000 uploaders to commons/mo? (eg would video/audio count?) [20:36:59] Poor netbooks... getting the shaft. brion: true, they do make good little dev boxes [20:37:20] i don't think anyone's ever specified, awjr [20:37:52] i would think media files count too yeah [20:37:59] awjr_lunch: photos are simply easier to do [20:38:03] then audio, then video [20:39:59] tfinc yeah, i dont really know anything about how commons handles audio/video. but i suspect from the user perspective the workflows really wouldn't be that different. [20:39:59] tfinc what would make audio/video more complicated for us? [20:40:11] awjr_lunch: video h.264 codec support [20:40:14] for video [20:40:18] brion can tell you all about it [20:40:27] yeah, video playback [20:40:38] or we can get everyone to switch to firefox ;) [20:40:40] i've semi-followed the wikitech-l threads on that [20:40:50] but… do we need h.264 codec support to upload? [20:41:10] i guess it would be difficult to provide a way to review what you've uploaded [20:41:15] which would be alme [20:41:16] *lame [20:41:16] awjr_lunch: transcoding *from* h.264 and transcoding *to* h.264 are really separate issues [20:41:39] but most phones seem to want to record either h.264 or (*shudder*) 3gpp [20:41:44] nobody records webm [20:41:47] brion: roger that - do we not support transcoding from? [20:42:00] we can support it, but it's not switched on. [20:42:10] gotcha - are there licensing issues wrapped up in that too? [20:42:28] remember when GIFs were still patented? we forced people to upload PNG, but at least every browser supported them by then [20:42:28] brion what about audio? [20:42:41] ahhh the good ol days [20:42:51] that was back in the days of blink tags! [20:43:01] same issue with audio, we should have all the tech necessary to ingest aac or mp3 but it's probably not enabled yet and must be discussed [20:43:16] ok gotcha [20:43:36] awjr_lunch: I'll note that the commons android app already does audio [20:43:38] these will be good problems to solve at some point [20:43:48] convincing people to do ingest is probably easier -- since we convert once from the 'evil' format to the 'free' format [20:44:06] convincing people to do output transcoding is harder, as then we're actively supporting the 'evil' format [20:44:15] awjr_lunch: it converts from whatever format to ogg before uploading, so the 'evil' is handled by Android itself [20:44:31] PurgatoryPanda: that's a good one yeah. :) may not be beefy enough cpu to do that for video though [20:44:46] brion: indeed, though I'll probably experiment at some point [20:44:50] brion i would suspect that is generally the case [20:44:58] brion: Audio encoding speed completely surprised me (at how fast it is) [20:44:58] * brion imagines FireFogg for Android :) [20:45:23] i remember when ripping mp3s from my CDs took longer than playing the CDs [20:45:29] then again my cpu was 266 MHz [20:45:37] yesss! [20:45:38] brion: I think conversion got me around 5x realtime [20:45:42] nice [20:45:55] * PurgatoryPanda 's first machine was 333Mhz celeron, 16MB RAM! [20:46:09] brion: i'm updating status on https://www.mediawiki.org/wiki/Mobile_i18n#Solution [20:46:12] nice [20:46:17] will cook up something nicer tomorrow [20:46:24] i had the pentium II, it was rockin' [20:46:37] cpu ran on a daughterboard instead of just plugging straight into a socket [20:46:43] extra cool once i got double cpus installed [20:46:52] @_@ [20:47:04] http://en.wikipedia.org/wiki/File:Pentium_II.jpg [20:47:54] brion: I've a P1 down here somewhere [20:48:02] probably doesn't work though [20:48:15] heh [20:49:39] * MaxSem has a 1993 LaserJet 4p in a functional state [20:50:44] dude you should hang on to that, it'll become a collector's item some day [20:51:10] i wish my parents had kept our late-70s early-80s ataris [20:51:14] those were sweet [20:51:38] i learned to program in PILOT and LOGO and BASIC on those things [20:53:01] [WikipediaMobile] brion pushed 1 new commit to v3.3-iOS: http://git.io/px2_NA [20:53:01] WikipediaMobile/v3.3-iOS 033698f Brion Vibber: Force privacy/terms links to mobile view [20:53:04] Project WikipediaMobile - Nightly builds build #482: SUCCESS in 7.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/482/ [20:53:04] Brion VIBBER: Force privacy/terms links to mobile view [20:53:27] Project WikipediaMobile - Nightly builds build #483: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/483/ [20:53:27] Brion VIBBER: Force privacy/terms links to mobile view [20:56:40] brion: successfully running :) [20:56:42] brion: https://twitter.com/yuvipanda/status/286939012663500800/photo/1 [20:58:45] woohoo [20:59:00] brion: that was much faster than expected :) [20:59:09] though it's a little... hacky. [20:59:21] hehe [20:59:23] but I know exactly what the hack is, and exactly what the solution is [20:59:29] yay [21:05:44] awjr, what's the global var to disable https login? [21:06:05] jgonera: $wgMFForceSecureLogin = false; [21:06:27] thanks [21:08:19] awjr, hm, the links still lead to https [21:08:39] jgonera in the nav? [21:08:57] yes, and the message in the watchlist that tells me to log in [21:09:12] jgonera i'll take a look - that shouldn't happen [21:09:15] New patchset: Jdlrobson; "dynamically load languages (bug 42962)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42128 [21:10:04] $wgMFForceSecureLogin = false; in LocalSettings.php, right? [21:10:39] brion: whats our objective-c task status ? [21:10:40] jgonera yeah, and it works for me. is your code up to date? [21:10:53] tfinc: still behind on that, when you need it? [21:11:04] we have two candidates that are waiting on it [21:11:11] jgonera: you may need to clear your cache too if you hadn't had that var set to false previously [21:11:12] ok then i'll have that tomorrow [21:11:16] k [21:11:29] jdlrobson: where can i find an example of event logging in action in MF? [21:12:21] tfinc: that's fast + great :) [21:12:21] awjr: i don't think there is any at the moment [21:12:27] tfinc: do share when you have the task [21:12:28] jdlrobson: oh i thought we were logging toggles? [21:12:38] PurgatoryPanda: sure [21:12:39] i'm a bit out of the loop with event logging but i think we removed all traces of the toggle stuff [21:13:11] oh i see [21:13:21] brb [21:13:46] jdlrobson: yeah mobile.beta.jquery.eventlog does not seem to exist anymore [21:13:59] awjr: see latest ori patch [21:14:26] jdlrobson: ahha - is there a separate extension for it now? [21:14:31] yup [21:14:45] well.. it should be part of core but as i said i'm out of the loop :) [21:14:57] errg i can't edit my local wiki anymore :( [21:14:58] Detected bug in an extension! Hook ExtMobileFrontend::recentChange_save failed to return a value; should return true to continue hook processing or false to abort. [21:16:11] jdlrobson: that is a quick fix, just add return true to ExtMobileFrontend:recentChange_save [21:16:30] reading up - yep, we nixed the section toggling eventlogging stuff, but it should be reenabled to log watchlist star use in the next deployment window [21:16:47] ori-l can give you a more executive summary, if needed, awjr [21:17:42] awjr: is that just a bug for me though or everony?e [21:18:25] jdlrobson: for everyone. it was merged https://gerrit.wikimedia.org/r/#/c/40340/3/includes/MobileFrontend.body.php but somehow the return true; got overwritten, probably the result of a bad merge conflict resolution [21:18:46] erg [21:18:51] 1s just exploring a bug [21:19:24] jdlrobson: want me to fix it?' [21:19:49] thanks Maryana [21:20:33] awjr: if you wouldn't mind! [21:20:53] jdlrobson: k [21:21:43] New patchset: awjrichards; "Fixes broken invocation of hook recentChange_save" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42130 [21:21:59] jdlrobson: ^ [21:22:04] New patchset: Jdlrobson; "don't hijack image links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42131 [21:22:06] thanks awjr i'll check now [21:23:16] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42130 [21:26:06] brion: you have anything for me on Zero so I can get started on the tests? [21:27:21] jcmish: some prelim notes in the read me i threw together a couple weeks ago: https://gerrit.wikimedia.org/r/#/c/39701/1/README [21:27:33] danke [21:27:50] hope it helps :) it's still a little vague [21:28:20] awjr, my code is up to date and I have cache disabled in Chrome, what am I doing wrong? :( [21:29:36] brion: off to sleep :) [21:29:39] tfinc: ^ [21:29:39] gnite [21:31:01] sleep well [21:31:54] brion: I'm rebuilding it from the 4.2 sources [21:32:02] so we'll get a keyboard with gestural typing :) [21:32:14] tomorro! [21:32:42] tfinc: I already feel like i'm back :) [21:32:52] I keep saying 'good night' and going back to vim [21:32:59] ooooh [21:33:13] good night vim [21:34:51] New patchset: Jdlrobson; "don't hijack image links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42131 [21:35:12] jgonera: find me when you're back and i'll take a look [21:36:22] alright sleepytime for reals [21:36:24] gnite folks [21:48:51] Maryana: i see we have an event logging schema for the watchlist star - do we have one for account creation as well? [21:49:17] not yet - i wasn't sure which part of that would be logged by EL and which would be logged through some other magic [21:49:31] but i'm happy to work with you or whoever picks up that card to make a schema :) [21:50:56] Maryana: ok cool - im trying to get my environment set up to work with EventLogging so i can get a better sense of what this stuff is going to take. at the moment it seems to me we should use EventLogging for account creation as well - unless you had different intentions? [21:51:37] ah but we wanted to use the other tracking magic too - to track the funnels? [21:52:31] iirc there was some magic that e3 is using for that that we can steal? [21:52:38] yeah, there are a couple of different logging needs: 1) tag everybody coming in from mobile as a separate usergroup (dario has done work on this for other funnels like moodbar, fundraiser campaigns, etc.) [21:53:03] 2) track users going through various account creation funnels (e.g., watchlist star, left nav) [21:53:20] i think both can be accomplished by EL [21:53:28] actually i think so too - and that might be easier [21:53:45] my understanding is that EL has been localized on all wikis, now, too, so it wouldn't just be enwiki specific [21:54:03] once we ahve a unique id generated for a user, we can include that in logged events for things like watchlist start [21:54:05] *star [21:54:39] yep - and that should tie in nicely with watchlist star logging, anyway [21:55:04] we just slap a cookie on the user and follow him/her through the account creation funnel [21:56:32] i can check in w/dario about the tagging stuff [22:12:10] awjr: any idea about this https://bugzilla.wikimedia.org/show_bug.cgi?id=43267 ? [22:12:27] seems like it might be an important one in light of pushing this to production! [22:25:15] jdlrobson: i'll take a look shortly [22:31:00] back in about an hour I need to run the boy over to the school [22:49:18] awjr, facepalm. After a deeper investigation, $wgServer seems to be protocol-relative, so preg_replace( '/^http:/', 'https:', $wgServer ) doesn't work [22:50:06] MaxSem i think that's what they're doing on the cluster - one sec i'll take a closer look [22:51:19] MaxSem: look around line 1501 of CommonSettings.php [22:52:26] jdlrobson: i think i've seen that bug before with watchlist [22:52:35] really awjr ? [22:53:02] jdlrobson: yeah, but i think we took care of it [22:53:04] awjr, yeeeeeah, I ponted at that line to you myself. the problem is that it's set to a protocol-relative URL in InitialiseSettings [22:53:23] awjr: close fixed? [22:53:32] jdlrobson: not sure one sec, sorry juggling like 5 convos :p [22:54:00] awjr: http://www.thegeekstuff.com/2009/02/how-to-add-bookmarks-inside-vi-and-vim-editor/ [22:54:06] awjr: like a boss [22:54:12] MaxSem: ryan lane suggested that approach to me also [22:55:22] * MaxSem is tempted to try a couple of var_dumps [22:55:42] MaxSem: so you're saying strpos( $wgServer, 'https' ) === false will always be false? [22:55:44] New patchset: Jdlrobson; "remove enhanced search from no jquery beta (RL integration)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42150 [22:58:00] jdlrobson: yeah, we should keep that bug open and fix it. basically, that will happen if you hit Special:MobileDiff directly without a rev id [22:58:07] it should be trivial to guard against [22:58:44] awjr, https://test.wikipedia.org/wiki/Special:Version [22:58:50] jdlrobson: ha you'll note in the code for Special:MobileDiff a fixme that says 'validate', referring to the parameters passed in [22:59:03] damn it, MaxSem [22:59:08] that sucks [23:00:02] MaxSem we could do a check against wgServer and also check $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' [23:00:19] brb [23:05:57] on subject of login awjr how to i disable https login? [23:06:01] my localhost hates it [23:06:43] jdlrobson, $wgMFForceSecureLogin [23:06:54] thanks MaxSem [23:11:34] awjr, upon further investigation, WebRequest::detectProtocol() appears to work, so I'll fix MF [23:12:01] MaxSem iirc there was some reason that didn't work locally [23:12:18] I just tried in prod:P [23:12:26] i think because WebReuqest::detectProtocol() doesn't looks at HTTP_X_FORARDED_PROTO [23:12:31]