[03:00:33] New review: Ryan Lane; "I tested this at: http://testing-amf.wmflabs.org/wiki/Main_Page" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/40298 [07:46:11] New patchset: Mgrover; "add/remove articles to/from watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42218 [07:57:51] New patchset: Jdlrobson; "Prevent unnecessary ajax call on initial load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42219 [08:15:03] New review: Jdlrobson; "Not quite right" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/42219 [09:28:42] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42227 [13:04:59] why RantingPanda: ? [13:05:09] jdlrobson: India got to me. [13:05:10] New patchset: Jdlrobson; "move jQuery history specific code to mf-history-plus" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42243 [13:05:11] New patchset: Jdlrobson; "dynamically load languages (bug 42962)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42244 [13:05:11] New patchset: Jdlrobson; "rewrite renderPage using template engine" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42245 [13:05:16] aww poor RantingPanda [13:05:24] jdlrobson: on OFTC I'm MurderousPanda [13:05:29] YuviPanda: am i sane doing what i'm doing above? [13:05:42] i just hate script tags for serving templates [13:05:50] ah, templates in the mobile site? [13:05:51] i'd rather use as little as them as possible for better maintainability [13:05:52] * RantingPanda looks [13:06:55] if i hit 'diff all unified' [13:07:00] shouldn't it actually open up everything [13:07:04] rather than just the commit message? [13:09:22] it sucks [13:09:26] :( [13:09:33] i wish it did but it doesn't [13:09:52] okay, I don't think I can deal with gerrit right now [13:09:55] need to go let off some steam [13:10:00] pound walls, etc [13:10:04] jdlrobson: sorry. [13:10:08] i'll be back in an hour [13:10:11] or so [13:10:12] haha [13:10:15] good luck my friend [13:13:44] New review: Jdlrobson; "Juliusz - am I insane of does this seem workable?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42244 [13:14:41] jdlrobson: also, re handlebars [13:14:45] pick and choose, etc [13:14:53] and you *should* post to wikitech-l about it [13:15:01] jdlrobson: it can't iterate over dicts, which IMO sucks. [13:38:52] New patchset: Jdlrobson; "don't hijack image links (bug 43539)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42131 [14:01:19] New patchset: Jdlrobson; "update empty message (307)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42251 [14:22:00] New patchset: Jdlrobson; "update empty message (307)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42251 [14:36:17] New review: Siebrand; "Pointed out directionality issue." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42251 [14:45:04] New review: Zfilipin; "Let me know if you have 30 minutes today, we can pair to make all suggested changes." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42218 [14:49:05] New patchset: Zfilipin; "Cleanup: remove unused code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42256 [15:04:26] New patchset: Zfilipin; "Remove all unnecessary "mobile"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42259 [15:23:39] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42259 [15:25:58] New review: Cmcmahon; "better management of non-IE tests" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42256 [15:34:49] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42227 [15:34:49] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42227 [15:36:38] New patchset: Jdlrobson; "promote watchlist, login, logout from beta (task 315)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42264 [15:36:39] New patchset: Jdlrobson; "move account create into center just like login form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42265 [15:36:39] New patchset: Jdlrobson; "ensure diff/watchlist is styled regardless of whether js available" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42266 [15:36:39] New patchset: Jdlrobson; "promote watchlist to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42267 [15:37:06] New review: Jdlrobson; "Needs more vigorous cross browser testing (I may need help with this)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/42264 [15:57:31] New patchset: Jdlrobson; "when not logged in explain the watchlist feature" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [15:57:32] New patchset: Jdlrobson; "update empty message (307)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42251 [15:59:58] New review: Jdlrobson; "also waiting on:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/42264 [16:05:37] New patchset: MaxSem; "Bug 43123: force mobile URLs only for local redirects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [16:18:38] Change abandoned: Jdlrobson; "being stupid" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42219 [16:34:30] MaxSem: how can i test your latest patchset? [16:34:39] MaxSem: ie. https://gerrit.wikimedia.org/r/#/c/42272/1 [16:35:13] have some interwikis, e.g. by importing some from WikimediaMaintenance [16:35:37] set up mobile host template [16:35:59] try enter-searching for m:Foo in mobile mode [16:37:25] MaxSem: what would be a good mobileUrlTemplate that will work on my localhost? [16:38:08] "%h0.m.%h1.%h2" [16:38:22] but that requires adding hosts aliases [16:38:53] ok that's what i was missing ;-) [16:39:16] * jdlrobson edits /etc/hosts [16:47:54] MaxSem: can't seem to get it working seems to redirect fine without your patch.. [16:47:55] running off http://localhost.m./w/index.php/Duel_Masters?useformat=mobile#mw-mf-search [16:48:19] useformat is not enough [16:48:41] you need to set the mobile cookies or otherwise force mobile view unconditionally [16:48:48] k [16:49:43] oook now we're getting somewhere [16:53:44] New patchset: Jdlrobson; "update empty message (307)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42251 [16:55:55] jdlrobson, do you have some more or less urgent bugs for me? [16:56:11] https://gerrit.wikimedia.org/r/#/c/40306/ [16:56:17] that's my most important bug right now [17:00:03] bah, I didn't notice Arthur's comments [17:02:11] gerrit emails are too spammy to be useful [17:09:17] New review: Siebrand; "You can't merge this. It contains the biggest i18n type of error possible." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42251 [17:10:40] New review: Siebrand; "I added a few designers to this patch set because it's a great example of how not to design for 300 ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42251 [17:13:34] MaxSem: anything you need from me before i go? [17:13:41] nothing [17:13:45] sweet [17:13:55] if you could kill mysql for me [17:13:59] .... [17:16:02] Hallo. [17:16:29] Q: Do you know what is the most frequent complaint in the overspammed mobile-feedback list? [17:17:01] moar cowbell? [17:17:07] :) [17:17:10] Almost. [17:17:16] MaxSem: seen a few of these now on twitter - https://twitter.com/PeteLlewelyn/status/287205424724332545 - make me laugh [17:17:18] :) [17:17:26] iPad screen rotation. Dozens of people complain about it every day, in many languages. [17:18:04] I actually bother to read that crazy list. I don't know who else does. [17:18:56] aharoni: which feedback list? I think somehow I've been removed from this list :( [17:19:06] mobile-feedback. [17:19:27] yeh i got removed from "mobile-feedback-l" :( [17:19:42] it's the /dev/null to which all the "Technical problem" emails are redirected. [17:19:45] what do people say is wrong with iPad rotation? [17:19:53] "Please describe the problem you are experiencing with Wikipedia above this line. Please note that we cannot reply to every message we receive." [17:19:57] and why are they getting the mobile site at all? I thought they got desktop [17:20:08] That iPad rotation doesn't work. [17:20:11] yep aharoni i used to be on this but alas no more - only noticed today [17:20:41] for example: [17:20:49] I'm sure you have received mail about this issue, but if you haven't, here it is: [17:20:50] I use the Wikipedia app on my iPad 2, running on iOS 6.1. [17:20:52] The app does not rotate (landscape to portrait) so I have to use it in portrait position. That in itself is not a serious issue. However when I need to use the virtual (touch) keyboard it come up in landscape (vertical) position, ie, at 90 degrees to the screen. In such a position the keyboard totally obscures the search area. [17:21:03] dozens of emails like this every day. [17:21:24] ahh the app [17:21:30] yeh i hear about that all the time [17:21:42] think there's a bug [17:21:44] * jdlrobson looks [17:22:16] So well, I don't care about it myself much. Just wondered whether anybody of you is working on it. [17:23:03] aharoni: https://bugzilla.wikimedia.org/show_bug.cgi?id=42838 [17:23:15] apparently fixed [17:23:29] anything i have to go now [17:23:38] see you all laters [18:00:26] jcmish, mtg [18:07:05] New patchset: MaxSem; "add pagination to watchlist a-z view (bug 43254)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40306 [18:13:48] aharoni, just checked - that iPad fix will be pushed to the market soon [18:14:37] jcmish: what is the login issue you're experiencing on staging? [18:15:16] awjr: working on recreating right now [18:15:21] one sec [18:16:20] just clicking on login on http://staging.wmflabs.org/ [18:16:29] eventually times out [18:16:40] awjr: MaxSem : one thing that has been confusing me for the last months is the level of resource loader integration we have. even today were still saying things like " Did some work towards ResourceLoader integration" [18:16:47] jcmish: it is probably attempting to redirect you to https, which i imagine staging is not configured for. [18:16:54] jcmish: put this in your localsettings: [18:17:03] $wgMFForceSecureLogin = false; [18:17:13] k doing now [18:17:16] thanks [18:17:27] awjr, that's why I disabled secure login by default [18:17:38] tfinc: correct, ResourceLoader should now be fully in use in beta (as soon as all the code is reviewed/merged) [18:17:52] tfinc then the next step will be untangling things in production to get ResourceLoader fully in use there [18:17:52] tfinc, but there's still a limited-RL mode [18:18:09] aka get rid of non-jQuery mode [18:18:42] MaxSem yeah, that was a good move [18:18:56] so would it be fair to say that were 100% RL in alpha/beta and less so in production ? [18:19:41] something like that [18:19:42] tfinc as soon as all the related code is reviewed and merged, yes. in theory, the work is essentially done [18:19:51] awjr, no [18:19:54] ? [18:19:57] New review: JGonera; "Will submit a new rebased patchset soon." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/41205 [18:20:09] MaxSem ? [18:20:28] we still have dumbphones that don't fully spport RL and we serve them section-collapsing JS [18:20:32] this needs to go [18:20:52] MaxSem: is that still the case in beta? [18:21:02] this was the whole point of https://mingle.corp.wikimedia.org/projects/mobile/cards/293 [18:21:07] beta's broken for them ATM [18:21:39] because alpha/beta are using RL exclusively, right? [18:21:58] no, because they don't have falbacks for section views [18:22:17] aka https://bugzilla.wikimedia.org/show_bug.cgi?id=42746 [18:22:27] and its friend https://bugzilla.wikimedia.org/show_bug.cgi?id=41569 [18:24:27] MaxSem: right, but that's because RL is now being used in alpha/beta - we just don't provide fallbacks? [18:25:18] once we have fallbacks we still have to kill non-RL mode [18:27:09] yes [18:27:44] do we even have some kind of ORM in MediaWiki or we just send raw SQL queries everywhere? [18:28:32] we have an ORM and a PITA it creates [18:28:40] or another question: isn't there a reusable pagination component somewhere in the core? [18:28:46] in general, stick to SQL [18:29:02] yes there are: Pager.php [18:29:06] $dbr->select( $tables, $fields, $conds, __METHOD__, $options ); it doesn't look like ORM [18:29:16] hm... what's the problem with our ORM then? [18:29:22] yuvipanda_: yo [18:29:39] joslyn needs to know how to reach out. she has not contact info [18:29:49] yuvipanda_: sykpe, phone, etc ? [18:29:50] i thought i had hit send ont hat? [18:29:52] * yuvipanda_ goes to look [18:30:05] just let me know what you want to use and i'll forward it on [18:30:29] considering that i've been having spotty internet, I'd say phone [18:30:41] yuvipanda_: pm me your number [18:31:39] done [18:32:38] MaxSem: in https://gerrit.wikimedia.org/r/#/c/40306/5/includes/specials/SpecialMobileWatchlist.php - the switch sets wl_namespace = $foo in $conds, and then wl_namespace gets set as conds in line 225 - why? [18:33:32] it's for paging [18:35:29] New review: JGonera; "I feel like showResults() function is getting too long. Couldn't we use http://www.mediawiki.org/wik..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40306 [18:35:35] MaxSem: im confused… so you could potentially wind up with a query that looks like select * form watchlist where wl_namespace=0 AND wl_namespace > 0 OR ( wl_namespace=0 AND wl_title='$foo') order by wl_namspace, wl_title; [18:36:10] to be precise, [18:36:13] SELECT /* SpecialMobileWatchlist::doListQuery MaxSem */ `watchlist`.* FROM `watchlist` WHERE wl_user = '1' AND (wl_namespace = 0) AND (wl_namespace > 0 OR (wl_namespace = 0 AND wl_title >= 'How_does_MediaWiki_work?/it')) ORDER BY wl_namespace, wl_title LIMIT 100 [18:36:26] that's a bit different [18:36:47] MaxSem: AND (wl_namespace = 0) AND (wl_namespace > 0 [18:36:52] that makes no sense to me [18:37:14] well, MySQL can make sense out of it [18:37:19] lol [18:37:28] how can something be wl_namespace = 0 AND wl_namespace > 0? [18:37:46] it will always have to fall to the OR statement [18:38:11] imagine when we're using different namespaces: wl_namespace IN (0, 1, 2) and wl_namespace > 0 [18:38:31] sure, in that case it makes sense [18:41:55] that just feels so ugly in every other case [18:42:09] New review: Jorm; "Concur with Siebrand; this is Vibha Bamba's design, I believe. She'll need to be looped into gerrit." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42251 [18:42:12] but it works [18:43:11] New patchset: awjrichards; "when not logged in explain the watchlist feature" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [18:43:17] * yuvipanda_ wonders how to put the Keyboard repo on github. [18:43:22] it's about 300MB large :| [18:51:34] New review: JGonera; "I agree with Siebrand. Probably two versions of the image (LTR and RTL, depending on language) with ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42251 [18:54:20] New patchset: MaxSem; "add pagination to watchlist a-z view (bug 43254)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40306 [18:55:02] MaxSem: awjr heads up the git-deploy is coming down the pipeline soon. robla should be mailing out about a switch over the week of jan 16th [18:55:10] sweet! [18:55:11] thats all the detail i have now [18:57:56] anyone has other stuffs for me? [18:59:01] New review: JGonera; "That's a good idea. I'd only name the new file differently. -plus doesn't explain much. Maybe add -j..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42243 [19:14:03] jcmish: i think i found the commit associated with card #274: https://gerrit.wikimedia.org/r/#/c/41962/ [19:14:06] it's been merged [19:14:27] jcmish: so i moved the card to ready for testing [19:14:44] MaxSem: what is the status of https://mingle.corp.wikimedia.org/projects/mobile/cards/304? [19:15:09] notpeter's still poking [19:16:24] l [19:16:25] er [19:16:27] k thanks [19:17:17] MaxSem: https://www.mediawiki.org/wiki/GeoData_Storage_%26_API needs an update [19:17:25] sweet thanks awjr [19:17:31] btw I can log in now! [19:17:32] :D [19:17:46] tfinc, there's 2012-12-monthly [19:18:05] lolz. so it is. [19:18:14] * tfinc turns of auto-pilot [19:18:29] * tfinc and wonders why it didn't get picked up on https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/December#Mobile [19:18:36] there it is [19:18:42] old cached copy i guess [19:21:01] jcmish i set the mingle transitions for bug/task/story for in dev -> awaiting code review to require a comment - hopefully that will prompt folks to add appropriate gerrit links, etc [19:21:06] jcmish: do you know anything about https://mingle.corp.wikimedia.org/projects/mobile/cards/301? [19:22:24] sweet hmm nope nada [19:22:25] w [19:22:30] want me to chase it down [19:22:59] jcmish don't spend too much time on it, we can hit up jon on monday if we need to [19:23:26] my guess is it's part of #274, although there's no story associated with that task. [19:23:34] I was going to ask you [19:23:40] is it associated with that? [19:23:43] it sounds similar [19:24:00] yah, it looks like it probably is but im not 100% sure [19:24:46] k I'll hang on to it [19:24:49] and check with Jon [19:25:13] cool thanks [19:25:21] My son just said I'm the best mom… I made breakfast for lunch [19:25:26] ahhh to be 7 again! [19:25:45] jgonera, do you have any MF0related requests for me? [19:26:31] MaxSem, I guess not, I just wonder if PageImages will work fast enough in production, because it's rather sluggish on my dev env [19:27:22] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42150 [19:27:48] jgonera, yes it is: https://graphite.wikimedia.org/dashboard/temporary-20 [19:28:21] MaxSem, ok, this makes me happy then ;) [19:35:49] New review: awjrichards; "Looks good! I tested with couple of tablets and phones against the same URL. Ryan, can you please ad..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40298 [19:35:49] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40298 [19:38:19] tfinc, hi I was at #mediawiki & #wikimedia-dev - now here as well :) [19:38:40] qgil_: cool. i didn't see you on staff so i messaged [19:39:01] qgil_: lets chat with maxsem about osm hacking at an upcoming event [19:39:08] tfinc, staff requires me an extra step logging in and most mornings I'm just lazy [19:39:21] open source days sound interesting but i have yet to hear back from the Ole. i emailed conf organizers yesterday but have not heard back [19:40:42] New review: JGonera; "I still don't like the length of the showResults() function." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40306 [19:41:07] qgil_: in general i'm looking for a european based event that we could attach to and bring 10 or so people to hack on OSM [19:41:23] the latest date? [19:41:24] qgil_: MaxSem would be leading it on our end. We'd send one ops person and maybe one other person [19:41:34] qgil_: it'd be nice to do it in march [19:41:52] tfinc, MaxSem do you really need an event for 10 people? [19:42:34] qgil_: we don't want to have to organ location logistics [19:42:38] organize* [19:42:52] so attaching to a conf makes it easier [19:42:54] tfinc, but any hotel will have a room for 10 people [19:43:16] tfinc, the conf option is true if there is such conf :) [19:43:35] plus its nice to interact with other communities [19:43:49] i'm just trying to avoid having to plan logistics :) [19:45:22] well, then clearly OS Days in Denmark is the option to go http://www.mediawiki.org/wiki/Events/Wikimedia_Mapping_Event_2013 [19:47:33] tfinc, it's in the Copenhagen Business School so they should be able to get a room with the basics [19:49:57] MaxSem, tfinc can I help with anything? If you want you can add me in CC in your communication with the event organizers, and I can get the lego work agreement for you [19:50:40] qgil_: doing the leg work would be great. [19:50:56] tfinc, CC me then :) [19:51:02] ok [19:52:04] but MaxSem will need to bring back a delicious badly smelling cheese from there... [19:52:20] * qgil_ just remembered that US Customs won't probably allow that :( [19:52:40] and I dunno when I will be in the US next [19:53:05] MaxSem, ok that might lead to a excessively smelling cheese then :)) [19:53:27] as said, happy to help [19:53:37] omg bioterrorism [19:53:42] :) [19:53:50] * tfinc ponders lunch [19:54:01] now that you mention... [19:54:50] * YuviPanda finds something to snack on [19:58:47] \o/ thanks for merging my change [19:59:28] * YuviPanda gently pokes Ryan_Lane about HTTP/1.1 support [19:59:35] ah. right [20:00:16] :) [20:00:27] would be a very good nice-to-have for the mobile upload stuff [20:01:38] let's try this on ssl1001 [20:01:48] to make sure it's not going to break the world [20:02:04] sweeet! [20:02:43] I wouldn't be able to test it out, etc, until Tuesday/Wednesday though [20:06:32] wtf. is there *also* a mobile-design@ list? [20:09:05] wat [20:12:14] grabbing a bite [20:28:19] New patchset: Zfilipin; "Cleanup: remove unused code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42256 [20:29:24] New review: Zfilipin; "Fixed merge conflict." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42256 [20:42:04] New review: Cmcmahon; "merge attempt" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42256 [20:42:05] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42256 [20:43:18] New patchset: Zfilipin; "Renamed readme file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42296 [20:46:55] New review: Cmcmahon; "make README more readable" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42296 [20:46:55] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42296 [21:23:40] jcmish, I'm seeing a problem with watchlist which might be a regression, awjr suggested you could check it on staging [21:24:08] when I go from watchlist to a page or a diff, and press the back button, I get a blank page instead of getting watchlist again [21:24:34] will do [21:24:47] hmm that's a regression [21:25:20] jcmish, that's what happens on my local dev environment, but I wanted to know if it's just my dev env or not [21:25:28] yup checking now [21:25:45] jcmish, oh, and it doesn't happen in Chrome, only on a phone (checked on Iphone) [21:26:05] so just ff? or sarfari [21:26:48] mobile Safari I guess, I'll test Android in a moment [21:26:57] kayo [21:27:06] i have mobile firefox too so just checking [21:27:17] let me check on staging give me one sec [21:30:05] jcmish, seems to be happening only on iPhone, I'll check a different one, maybe it's the device [21:31:30] well, I'll do it as soon as it charges [21:34:36] haha i hear ya [21:34:42] no problem [21:37:19] actually awjr and jgonera I need a minute … staging is flaking out [21:37:29] ok [21:37:33] I need to see what's wrong with it [21:37:40] but articles aren't rendering correctly [21:41:15] New patchset: MaxSem; "DeviceDetection improvements" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42348 [21:59:10] jgonera, jcmish staging is fixed now [21:59:52] jgonera: it happens on staging [21:59:58] it's not just your environment [22:01:02] jgonera: I'll write up the bug and add the test case to the automation tests [22:01:20] awjr: can we fix this now? [22:01:28] or is the cardwall too crowded? [22:04:00] cardwall is crowded, but we need this fixed before we push watchlist to prod [22:04:08] so we should file a bug and prioritize it fairly high [22:08:38] h [22:09:24] k I'll get it on the board and prioritized [22:09:24] thanks [22:09:29] thank you! [22:11:30] awjr, can you take a look at https://gerrit.wikimedia.org/r/42348 ? [22:11:57] MaxSem: sure - but probably not until ~4 pst [23:24:10] New patchset: JGonera; "Overhaul watchlist UI [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41205 [23:44:41] coffee run [23:52:28] YuviPanda [23:52:29] ; [23:52:31] you about ?