[10:18:15] [WLMMobile] siebrand pushed 1 new commit to master: http://git.io/V88IhA [10:18:15] WLMMobile/master a1e0d81 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [10:18:33] Project WLMMobile - Nightly builds build #251: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/251/ [10:18:33] s.mazeland: Localisation updates from http://translatewiki.net. [10:20:04] Project WiktionaryMobile - Nightly builds build #112: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/112/ [10:20:04] s.mazeland: Localisation updates from http://translatewiki.net. [10:21:10] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/6ZYhSA [10:21:10] WikipediaMobile/master 8773fd1 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [10:21:28] Project WikipediaMobile - Nightly builds build #484: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/484/ [10:21:29] s.mazeland: Localisation updates from http://translatewiki.net. [15:00:18] New patchset: Jdlrobson; "move jQuery history specific code to mf-history-jquery" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42243 [15:00:55] New review: Jdlrobson; "done." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42243 [15:02:39] New review: Jdlrobson; "according to Max this is not the "mediawiki way" and I wasn't sure how best to do this. Rather than ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42196 [15:04:43] New patchset: Jdlrobson; "ensure diff/watchlist is styled regardless of whether js available" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42266 [15:05:22] New review: Jdlrobson; "Rebased and merged" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42266 [15:05:23] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42266 [15:07:37] New patchset: Jdlrobson; "move account create into center just like login form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42265 [15:07:58] New review: Jdlrobson; "Cherry-picked and merged after Arthur's review" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42265 [15:07:59] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42265 [15:12:06] New review: Jdlrobson; "Juliusz seemed fine with it other than name. Changed name and merged to avoid merge conflicts down t..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42243 [15:12:06] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42243 [15:23:22] New review: Jdlrobson; "This breaks the list view - I'm seeing the same article more than once. There is something wrong wit..." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/41205 [16:06:19] New patchset: MaxSem; "don't throw exception when bad revision id given (bug 43267)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42196 [16:06:47] New review: MaxSem; "Simplified a bit, fixed some PhpStorm warnings." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42196 [16:21:11] you jdlrobson [16:21:17] s/you/yo/ [16:21:19] you or yo? :) [16:21:26] oh good that's less damning ;-) [16:22:31] New review: Jdlrobson; "Maryana, are you happy for this to be promoted despite the fact it may show on disambiguation pages..?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40752 [16:23:18] jdlrobson, got commits for me to review? [16:23:34] still need pagination :) [16:23:45] also you misunderstood my review on https://gerrit.wikimedia.org/r/#/c/42391/1 [16:23:53] i was basically saying we should add comments to why we keep things [16:24:04] I was asking why do we still remove 'div.infobox', [16:24:14] if you fix that up ill happily merge [16:27:52] how the hell am I supposed to know why Patrick added these? [16:31:56] delete them then :) [16:32:01] or we can git blame [16:32:16] just seems if we are doing this we should do it properly [16:32:40] i'm happy to explore these [16:32:53] btw i assume script tag's are already removed that's why you took them out? [16:33:15] ^ MaxSem [16:33:59] parser output which we parse these days never contains