[00:00:51] brion: anything else to add for the whats new? [00:00:58] brion: i have [00:00:59] * fixed landscape mode on iOS 6 [00:00:59] * fixed splash screen flash on iPhone 5 [00:01:00] * native Facebook sharing on iOS 6 [00:01:11] should be about it [00:01:19] k [00:03:33] The Nearby fix [00:04:05] brion: didn't you do something to fix the images now showing up? [00:04:25] oh yeah, but i think that wasn't broken in the previous release [00:04:29] just in the betas [00:04:36] ah cool [00:04:53] brion: jcmish : done. v3.3 has been sent for review [00:04:56] http://www.mediawiki.org/wiki/Mobile/Release_history#Wikipedia has been updated [00:04:58] :) [00:05:07] \o/ yay [00:05:10] woohoo! [00:06:16] i'll update the firefox OS and bb playbook apps later, and we'll get to an android release later this month [00:06:26] still have to make the legal tweak for win8, that shouldn't be hard [00:10:31] is there any way I can see what $dbr->select() is actually sending to the database? [00:10:56] jgonera i believe there is [00:11:00] however, i forget what it is :| [00:11:22] lemme see if i can dig it up, unless brion knows? [00:11:29] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/41205 [00:11:34] $wgDebugDumpSql [00:11:43] set to true and it should dump full SQL to $wgDebugLog [00:11:47] or $wgDebugLogFile rather [00:12:25] :) [00:12:32] brion, thanks [00:12:37] enjoy [00:12:42] that will dump all the queries though, right? [00:12:48] no way of showing just one? [00:13:09] no convenient way ;) [00:13:39] in theory you may be able to enable/disable the debug flag on the appropriate database object [00:13:40] :/ [00:13:46] but i'm lazy and just dump everything and grep ;) [00:13:46] hm [00:14:11] awjr: hey, are you still in SF & in the office today? [00:14:21] ori-l: yup, although im gonna take off soon [00:14:27] ori-l: i'll also be around for most of tomorrow [00:14:37] ori-l: look to your left [00:14:45] heh [00:14:48] :) [00:16:13] anything needed before i sign off [00:16:22] jgonera: merged your code [00:16:40] brion, it doesn't seem to work... I also tried $wgDebugComments = true; but nothing shows up... [00:17:03] jdlrobson, wow, thanks! you're sure nobody else will complain? ;) [00:17:47] meh it's been in code review for long enough [00:19:39] brion: did the resource loader target stuff ever get documented? [00:19:49] awjr: that's…. an excellent question [00:19:52] :p [00:20:15] looks like that's another todo :D [00:20:18] :D [00:20:25] i'll go over the RL docs later [00:20:31] see if i can find a sane way to describe it [00:20:52] jgonera: i seem to be getting a flash of unstyled content on watch list - not sure what brought that in but can you explore? [00:21:16] seems to be a-z list only [00:21:20] jdlrobson, ok, will try to fix it. any particular browser? [00:21:50] (because I don't see it in Chrome) [00:22:51] New patchset: Ori.livneh; "Load EventLogging if it is enabled and present." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42064 [00:26:00] Seeing it on chrome a-z view [00:26:04] headings seem to flash [00:26:09] might just be my browser though [00:26:33] anyway speak tomorrow :) [00:27:32] jdlrobson, will try to reproduce this, if I can I'll fix it [01:15:50] New patchset: Ori.livneh; "Load EventLogging if it is enabled and present." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42064 [01:31:23] Thehelpfulone: congrats! i just heard the news [01:32:04] thanks :) [01:57:04] New review: JGonera; "There's still no "More" button in the "Pages with changes" view and the items there _are_ also limit..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40306 [09:52:50] New review: MaxSem; "Desktop watchlist isn't paged either, I see no problem with it." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40306 [10:02:28] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42739 [11:13:17] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42064 [11:15:56] New review: Jdlrobson; "Guys feel free to merge pre deployment - Maryana says this is not a deal breaker." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/40752 [11:18:05] New patchset: Jdlrobson; "promote photo uploads to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40752 [11:18:40] New review: Jdlrobson; "I have rebased" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40752 [11:22:36] New review: Jdlrobson; "Max your -1 makes no sense - the desktop view doesn't have a list view which does need it - what goo..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/40306 [11:23:46] New review: Jdlrobson; "Sorry Max - that was meant to be aimed at jgonera!" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/40306 [11:31:52] New patchset: Jdlrobson; "add pagination to watchlist a-z view (bug 43254)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40306 [11:33:25] New review: Jdlrobson; "I see no reason why this cannot be merged now." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40306 [11:47:14] New patchset: Jdlrobson; "experimental: remove all inline styles from #content in ALPHA" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42747 [12:02:20] New patchset: Zfilipin; "Do not set MEDIAWIKI_URL env variable automatically" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42750 [12:49:10] New patchset: Zfilipin; "Revert "add/remove articles to/from watchlist"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42754 [12:49:48] Change abandoned: Zfilipin; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42754 [13:02:38] New patchset: Zfilipin; "Commited files that got lost in patch set 2 of Gerrit commit 42218" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42755 [14:41:24] New patchset: MaxSem; "Make search load canonical URLs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42766 [15:17:22] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42739 [15:17:23] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42739 [15:18:46] New review: Cmcmahon; "cleanup" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42750 [15:18:46] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42750 [17:16:47] New review: awjrichards; "There are a number of places in the JS that use Javascript's encodeURIComponent() - should these be ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42766 [18:11:39] jgonera, seen the canonical links thread? [18:11:52] New review: JGonera; "OK, maybe I don't understand something or maybe it's my dev environment." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40306 [18:12:04] MaxSem, no, not yet [18:12:18] MaxSem, on gerrit you mean? [18:12:26] jgonera, in email [18:12:49] would be great if we resolved it today [18:13:19] awjr, are you still in SF [18:13:36] MaxSem, what's the subject? is it on mobile-tech? [18:13:45] `yes [18:13:57] [Analytics] Suspicious increase in mobile pv's [18:14:45] MaxSem, oh, ok, will read it now [18:17:39] MaxSem, I'd like to know the answer to awjr's question on gerrit, plus wikiEncode() sounds a bit ambiguous, maybe wikiEncodeURI()? [18:18:17] MaxSem: yup, still in SF until this afternoon [18:18:52] awjr, did the ops specify how we should book them for a Varnish purge? [18:19:17] MaxSem no, but last time i just contacted leslie a while before hand to let her know we were deploying and might need one [18:19:39] so, just ask in #-ops? [18:20:42] MaxSem yeah, and/or contact the op on duty [18:21:40] alright, I think I'm staff now, considering that I've finished an interview with Sue [18:22:16] New review: MaxSem; "Other uses are related to API or updateQueryStringParameter() which means that they're irrlevant as ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42766 [18:22:30] how was it? [18:24:14] Hey MaxSem ? the branch cut ticket do you want it to just hang around until later today? [18:24:59] jcmish, what branch cut ticket? [18:25:56] 318 I should have said branch deployment [18:26:24] ahhhhh [18:26:35] yes, let's close it after deployment:) [18:26:43] * MaxSem has a 3-item stack [18:26:50] MaxSem: pretty well, I think. The interview was mostly about how I didn't need one :) [18:33:34] yuvipanda_ This is awesome man. You deserve it. [18:33:42] New review: JGonera; "Good for me, I'd only change the name wikiEncode() to something more specific like getCanonicalURI()..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42766 [18:45:42] MaxSem: how would I test the Solr GeoData ticket? [19:02:08] jcmish, sorry - had a call. well, you can't really test it:) it's a matter of time - the Solr should just work reliably. I'll do some checks if replication works from time to time [19:02:16] New review: JGonera; "That's a great idea." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42244 [19:09:27] New review: awjrichards; "Max, what about updateUILinks() in mf-history.js?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42766 [19:13:16] New review: MaxSem; "They're for menu ( #mw-mf-menu-main a ) and footer ( #content_footer .notice a ), and don't deal wit..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42766 [19:14:18] i really wish the javascript functions were actually documented [19:14:24] i mean, in MobileFrontend [19:14:53] so you wouldn't have to read through all the JS to determine what something does :p [19:15:20] maybe, you even want that JS itself made some sense?:P [19:15:41] heh [19:18:25] New patchset: MaxSem; "Make search load canonical URLs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42766 [19:24:49] jgonera, ^^ [20:13:13] MaxSem, ping [20:13:19] pong [20:13:48] hi MaxSem , about that event. Did you check the emails in that thread? [20:15:03] MaxSem, I mean the email of aude and Cristian Consonni about [Wikitech-l] Fwd: Wikimedia/mapping event in Europe early next year? [20:15:55] MaxSem: https://gerrit.wikimedia.org/r/#/c/42803/ [20:16:22] qgil, we would like to organise it earlier [20:16:40] awjr, ok, will deploy [20:16:44] MaxSem, ok, then it's open source days in Denmark, rirght? [20:16:52] MaxSem, are we waiting for anything? [20:16:54] \o/ thanks MaxSem [20:17:04] can't be too short notice [20:17:15] qgil, for a reply from Danes [20:18:47] MaxSem, who exactly, and what was the question? Can you fwd me the email so I can ping them as well? [20:18:59] aude, Open Source Days, 9-10 March 2013, Copenhagen/Denmark [20:19:00] Who's helping: Potentially Wikimedia Denmark [20:19:00] See: http://www.opensourcedays.org/ [20:19:06] Tomasz does this part [20:19:15] and it was a second ping [20:19:37] MaxSem, but tomasz asked me to help on this... :) [20:19:46] * aude using up all my vacation time [20:19:48] already [20:19:59] so it'd have to be weekend or on work time [20:20:50] MaxSem, maybe they are simply busy. The event is in a school so I guess there is no lack of rooms. [20:21:06] MaxSem, anyway, I'll ask tfinc to put me in the loop so I can go and cal them directly [20:21:20] I'll fwd it to you shortly [20:21:30] currently trying to listen a tech talk [20:21:45] aude, March 9-10 is a weekend [20:21:57] MaxSem, oh sorry [20:22:01] thanks! [20:22:56] awjr, how about $wgMFForceSecureLogin = $wmgMFForceSecureLogin ?:) [20:23:00] qgil: maybe it's ok, but it's still slightly short notice IMHO [20:23:15] MaxSem sure, that works too :) [20:23:23] aude, some say April it [20:23:37] s to late, some say March s too soon. What can we do? :) [20:23:47] heh [20:24:40] aude, the only problem I'm trying to focus is not to let slip more weeks, since this discussion started, what, almost 2 months ago? [20:25:06] qgil: sure [20:25:22] somebody just pick a date and agree to organize it :) [20:44:04] MaxSem, how would you do the following SQL query in MediaWiki: [20:44:06] SELECT /* SpecialMobileWatchlist::doListQuery Jgonera */ `watchlist`.*,`lastchange`.last_timestamp FROM `watchlist` LEFT JOIN (SELECT rc_title, rc_namespace, MAX(rc_timestamp) as last_timestamp FROM recentchanges GROUP BY rc_title, rc_namespace) AS lastchange ON ((wl_namespace=rc_namespace) AND (wl_title=rc_title)) WHERE wl_user = '2' AND wl_namespace = '0' ORDER BY wl_namespace, wl_title; [20:44:23] hm, maybe let me reformat it [20:45:15] U NO UZ NESTID QWERIZ [20:45:47] uhm, so how can I do that differently? [20:46:44] https://gist.github.com/bdf02db09d438a750cc0 [20:53:02] jgonera: curious if you filter stuff like bot edits? [20:53:32] they are not hidden by default, though [20:53:52] aude, I'm not sure if I understand, is this a question related to the mobile frontend? [20:54:12] yeah, for the mobile watchlist [20:55:18] I don't think we do, but you better ask MaxSem or jdlrobson (who's not here atm) [20:55:28] jgonera: ok [20:56:16] with wikidata, there will be a new type of recent change, similar to a bot edit i suppose (at first) [20:56:31] but perhaps not more than people get now with the bots [20:59:19] jgonera have you seen http://www.mediawiki.org/wiki/Manual:Database_access ? [21:00:35] aude, I think it won't be a problem to filter those out if we need to [21:00:44] awjr, thanks, will check it [21:00:46] jgonera: ok [21:01:04] jgonera good luck, the abstraction layer in MW gives me a headache [21:01:23] we are doing custom formatting for wikidata changes, as seen on wikipedias [21:01:30] awjr, I already sensed this [21:01:33] :p [21:01:42] for changes that are relevant to a wikipedia page [21:02:02] jgonera got a sec to chat irl? [21:02:06] until time we can do better cross wiki stuff [21:02:30] aude, on which Wikipedias can it be seen? [21:02:39] awjr, sure, give me a few mins [21:02:40] test2 only now [21:02:51] hungarian will be first [21:03:18] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40752 [21:03:24] the changes are treated like anons [21:03:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42766 [21:03:57] heyyyyyyy [21:04:02] i realize it might be too late, but MaxSem ^^ [21:04:09] please don't merge during deployment [21:04:14] in the future we may be able to link edits cross wiki, if a user has a global acct [21:04:24] awjr, jgonera, jcmish, YuviPanda: we're live on testwiki, please test [21:04:30] MaxSem, sorry, didn't realize it was already 1pm [21:04:38] MaxSem: crap sorry, didn't realize it was 1 already and that you'd started :( [21:04:40] :o [21:04:51] ha! [21:04:54] me neither! [21:05:01] on it [21:07:50] anyone sync'd up with product about deployment? i don't see maryana around [21:08:36] nope awjr [21:08:44] the i18n seems not to be up to date on testwiki and the buttons in watchlist barely fit [21:08:49] k im gonna see if i can find her [21:09:15] also, some messages are missing (watchlist-feed-empty) [21:10:35] secure login has been deployed on testwiki too [21:11:32] the toast after adding something to the watchlist is not centered, can it be the infamous debug=true thing again? [21:12:29] I just tried clicking Log in in Chrome and got a 404 [21:13:20] It tries to go to http://test.m.wikipedia.org/https//test.m.wikipedia.org/w/index.php?title=Special:UserLogin&returntoquery=useformat%3Dmobile%26welcome%3Dyes [21:13:21] umm I can't log in? [21:13:32] ha same jgonera [21:13:50] I'll clear my cache to see [21:14:29] I have cache disabled [21:14:38] jgonera: i18n won't get updated on testwiki [21:14:41] yeah same I double checked [21:14:41] at least not until scap is run [21:14:49] awjr, ok [21:14:50] it is a limitation of our deployment system :( [21:14:53] andi can't find maryana [21:15:19] deployed the two latest merges [21:15:25] call her? [21:15:36] yeah looking up her # now [21:17:09] she's out to lunch [21:17:10] (literaly) [21:17:13] but is hoppingon line now [21:17:21] yo yo [21:17:24] also literally, apparently [21:17:35] :) [21:17:55] :D [21:18:11] awjr, so the log in and log out links are broken in the menu [21:18:22] ^ [21:18:24] +1 [21:18:34] wtf [21:18:49] yeah they look like this: http://test.m.wikipedia.org/wiki/https//test.m.wikipedia.org/w/https//test.m.wikipedia.org/w/index.php?title=Special:UserLogin&returntoquery=welcome%3Dyes [21:18:53] sends you to the redlink article page for some reason [21:18:58] * yuvipanda_ looks around [21:19:07] aude, any page where we could see the changes from wikidata in the history? [21:19:44] new watchlist styling looks *awesome*, jgonera! [21:19:55] Maryana, thanks! ;) [21:20:20] huh the links work fine for me locally in master, dunno why they're wonky on testwiki [21:21:12] awjr, but do you have the SSL enabled on your local dev env? [21:21:18] jgonera yes [21:22:08] awjr, they actually seem to be correct in HTML [21:22:14] ! [21:22:26] is it possible that we have some weird redirects in our test/production systems? [21:22:45] the link is not actually correct, it's missing a colon [21:23:01] hahahaha JS [21:23:06] probably mine [21:23:41] no [21:27:22] awjr, it's because of protocol-relative urls [21:27:27] argh [21:27:54] MaxSem how? [21:29:34] New patchset: MaxSem; "Fix switching to HTTPS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42854 [21:29:38] awjr, ^^^ [21:30:40] MaxSem, that looks weird, why isn't "://" a standard delimiter? [21:30:41] >_< [21:30:55] because it's '//' [21:31:33] MaxSem due to protocol relative URLs on the cluster? [21:31:38] yup [21:31:43] that is whacky [21:31:46] so why does it work with http (without s)? I'm probably asking questions without understanding how it works, any docs on that? [21:32:25] jgonera, try https://en.wikipedia.org/wiki/Insanity [21:32:40] :) [21:32:49] hmm, that's odd. i'm seeing the "add the first photo" notice in edit mode on a page, but not on the page itself [21:33:09] on http://test.m.wikipedia.org/wiki/Eudendrium_infundibuliforme [21:33:17] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42854 [21:33:25] MaxSem: ^ [21:33:56] im still not grokking what caused the problem though [21:34:26] nm it's due to wfParseUrl [21:34:28] wfParseUrl('//en.wikipedia.org/wiki/...') [21:34:42] yeah [21:34:57] i was looking at wfAssembleUrl rather than wfParseUrl [21:35:58] if ( $wasRelative ) { [21:35:58] $bits['scheme'] = ''; [21:35:58] $bits['delimiter'] = '//'; [21:35:58] } [21:36:01] * awjr shakes fist [21:36:15] :O [21:37:03] ;) [21:37:20] yo tfinc [21:37:47] whattup tfinc [21:37:53] howdy all [21:38:06] * tfinc debates wether he should come into the office now that his errands are done [21:38:15] MaxSem it's good we only enabled forcing https on testwiki rather than everywhere.. [21:38:18] awjr: i only have our 1:1 this afternoon [21:38:24] tfinc i have to leave before our 1:! [21:38:25] er [21:38:26] 1:1 [21:38:35] i declined it [21:38:43] that makes it easy [21:38:44] :) [21:38:58] unless you have something pressing, we can catch up next week then [21:39:17] jgonera: https://test2.wikipedia.org/wiki/Special:RecentChanges?hidewikidata=0 [21:39:46] tfinc the only thing is i should figure out about abu dhabi soon (though i still haven't been contacted about travel arrangements, so i think i still have some time), but we can talk about it later this week or next week [21:39:51] you have to choose to toggle the edits "on" or set your preference to show them [21:40:09] Maryana: thanks for jumping in for the monthly report [21:40:13] edits like [21:40:14] (diff | hist) . . May (Q119); 18:31 . . Grondin (Talk | contribs) (Language link added: ps:مې) [21:40:15] Maryana: what are we still missing / [21:40:41] awjr, have you been to Israel? [21:40:47] MaxSem: no [21:40:58] why would tht prevent me from getting a visa to UAE? [21:41:06] tfinc: i didn't know what to put for zero, J2ME app, SMS or QA [21:41:06] cuz otherwise they won't allow you into UAE [21:41:11] hello tfinc [21:41:12] that is good to know for the future [21:41:16] MaxSem: not true [21:41:17] MaxSem is the inverse true as well? [21:41:21] Maryana: all of those should already have updates [21:41:24] are they not showing up? [21:41:24] i'm quite sure it's not true now [21:41:43] am i looking at the right page? https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/December#Mobile ? [21:41:49] fuuuu [21:41:56] gerrit down [21:42:19] thats the right page but the updates are getting through [21:43:34] >_< [21:43:40] MaxSem: wfm [21:44:08] MaxSem: http://en.wikivoyage.org/wiki/United_Arab_Emirates#Get_in (if you believe wikivoyage :o) [21:44:19] aude, I'm not sure if I can see them, how do you format them? [21:44:50] jgonera: there's not that many on test2 [21:45:24] jgonera: it's a little bit hackish but we're reformatting each change line if the change comes from wikidata [21:46:00] * aude working to make the recent changes stuff more flexible and allow the user to be a user of a different wiki [21:46:23] or connect accounts, via central auth [21:47:09] jgonera: and in the database, they get rc_type = 5 (that being the RC_EXTERNAL type, vs BOT or other) [21:48:00] aude, but is there any page where I can see it easily? [21:48:30] let me make some edits :) [21:50:14] brb [21:50:16] jgonera: https://test2.wikipedia.org/w/index.php?title=Special:RecentChanges&hidewikidata=0 [21:50:37] MaxSem, is the https fix already deployed on test? [21:50:50] [01:41:50] fuuuu [21:50:51] [01:41:57] gerrit down [21:51:10] maybe we need a filter to show wikidata edits only, though i'm concerned about providing too many choices on the recent changes page [21:52:04] aude, I see it now, but it's not styled differently [21:52:18] not too much different [21:52:42] it has a link to the wikidata page (Q60) [21:53:03] maybe there could be an icon or something else to distiguish, though not sure what [21:53:15] wikipedians hate icons [21:53:28] aude, oh ok, I thought it would have something like an icon, like a new page edit or minor edit [21:53:36] back. we still experiencing login/logout issues? [21:53:37] MaxSem: gerrit's working for me ? [21:53:38] they do? ;) [21:53:42] maybe we can [21:54:02] oh sweet, i can logout now [21:54:05] good idea [21:54:16] anyway, we'll se if we should filter that on mobile or not [21:54:22] ahhh MaxSem login link looks good now on testwiki :) [21:54:28] ok [21:54:35] right now, it's pretty similar to bot edits [21:54:56] yet, without special formatting, stuff like the user link could be funky [21:55:04] yay https login! [21:55:16] the watchlist is still a very new feature on mobile, we'll probably get more feedback from users soon [21:55:33] yeah [21:55:37] us too :) [21:56:09] trying to strike the right balance between too much info and not enough for users [21:56:12] woohoo can login [21:56:15] oh wait someone said that [21:56:17] :) [21:57:57] aude, that's always difficult, even more so on mobile ;) [21:58:16] yeah [21:58:29] wheee, new wikivoyage logo :) [22:01:08] the toast notifications are not centered in Android browser, but it's not deployment related, I'll file a bug [22:02:35] i can't seem to toggle to my recently changed watchlist view [22:02:55] i tested it on chrome on my desktop machine earlier & it worked [22:03:00] but it doesn't work on my iphone [22:03:31] let me check [22:05:31] on my iphone on the watchlist page "Pages with changes" isn't sized correctly [22:05:59] awjr: did the copies of team geek come in? [22:06:09] i was hoping to give you one before you left [22:06:33] jcmish, can you navigate into that view? when i tap it, the button ducks away from me :) [22:06:51] Maryana: yup [22:06:55] that's what I was typing next [22:07:02] tfinc i have no idea [22:07:06] tfinc who would they have come to? [22:07:13] ok, I can see the problem [22:07:22] it will be gone when i18n gets updated [22:07:35] though I should accommodate for that just in case it happens in other languages [22:07:57] MaxSem, how much time do I have to fix this? ;) [22:08:17] pageimages on watchlist looks awesome, too, maxsem [22:08:27] jgonera, I should be scapping already [22:08:40] let's say no more than 10-15 mins [22:08:54] ok [22:10:20] awjr: rachel [22:10:28] awjr: and from amazon [22:10:51] wouldn't be a big package as their not big books [22:11:01] tfinc ok, i'll look on her desk when im back on 3 [22:11:26] * yuvipanda_ waves at brion [22:11:32] * brion waves [22:15:21] MaxSem, 3 more minutes and I'll post a patch [22:18:48] New patchset: JGonera; "Fix watchlist header buttons when text is too large" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42865 [22:18:55] MaxSem, ^ [22:20:00] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42865 [22:20:28] \o/ [22:23:13] jgonera, jcmish, Maryana - updated [22:23:32] great, thanks! [22:23:36]