[00:01:05] k [00:05:07] preilly: ok i have resubmitted the Firefox app and asked them to switch it from http to https (since I can't do that directly in the interface after the original submission) [00:06:29] brion: cool [00:16:21] are y'all still deploying? [00:16:24] e3 is chomping at the bit [00:17:21] Broken extension is broken [00:17:21] [10-Jan-2013 23:33:23] Fatal error: Call to undefined method languages::getCode() at /home/wikipedia/common/php-1.21wmf7/includes/cache/MessageCache.php on line 622 [00:17:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=38339 [00:18:31] (ZeroRatedMobileAccess) [00:18:46] Reedy: yeah i'm looking at that now [00:18:59] everytime you press refresh we get an error :D [00:19:01] looks like a weird breakage in core though somehow [00:20:40] in master that line is [00:20:41] $langcode = $lang->getCode(); [00:20:51] Maryana, still deploying [00:25:34] afaik there isn't a 'languages' class is there? [00:26:38] awjr, I merged the fix to mobile account creation into 1.21wmf7. [00:27:24] de5d9d6 Log displayMobile instead of host (for mobile). Now will do for 1.21wmf6. [00:29:30] spagewmf: are those changes on fenari? [00:29:36] im about to sync-dir MobileFrontend [00:30:08] awjr not yet. I'll check with you before I sync-dir EventLogging [00:30:10] oh, those are EventLogging changes, not MF changes [00:30:17] spagewmf: ok sounds good, we're just about done [00:34:17] jdlrobson, jcmish, MaxSem, Maryana changes are live (note i have not flushed cache yet [00:34:33] awjr: do we need to wait? [00:34:37] or can we start testing now? [00:34:41] start testing now [00:34:47] i only want to flush the cache if we discover we have to [00:35:02] awjr, doesn't seem much faster than scap [00:35:11] MaxSem i dont think it's really any faster [00:35:24] but i feel more in control of the process [00:35:43] like... the ability to make more mistakes?:P [00:35:46] oh, i need to make a config change to force https for login/account creation [00:35:48] MaxSem exactly :) [00:35:58] k [00:35:59] awjr is it OK if I pull my EventLogging change on fenari, or should I wait? (I follow http://wikitech.wikimedia.org/view/How_to_deploy_code#Step_2:_get_the_code_on_fenari ). [00:36:01] Maryana: can you try out the watch list pagination [00:36:06] since i know you have a long watch list :) [00:36:08] spagewmf: can you wait a few minutes? [00:36:28] * Maryana looks [00:36:29] awjr of course. [00:36:51] nice, jdlrobson! [00:36:57] i forgot i ever edited most of these [00:37:09] MaxSem: https://gerrit.wikimedia.org/r/#/c/43383/ [00:37:28] of course it would be more awesome with infinite scroll [00:38:42] of course Maryana ;-) soooonn [00:38:57] awjr, done [00:39:09] thanks MaxSem, deploying now [00:39:13] do we have a story on that, jdlrobson? [00:39:35] Maryana: no infinite scroll story no [00:39:41] (that I'm aware of) [00:39:51] presumably if we get people uploading via mobile and they have hundreds of mobile uploads (fingers crossed), we'll want to have infinite scroll on the "my uploads page", too [00:40:09] ruhroh [00:40:31] forcing https for mobile login shows me the desktop versin of the site when i try to log in [00:40:42] MaxSem can you test login on enwiki real quick? [00:41:34] awjr: works for me [00:41:38] awjr, WFM [00:41:42] me too [00:42:03] phew ok me three on my mobile device, i am only seeing the problem on desktop chrome [00:43:45] cool, im not seeing anything that suggests we need a cache flush [00:43:56] jdlrobson, MaxSem, jcmish, Maryana &? [00:43:58] er [00:44:00] ^ [00:44:04] awjr: works for me on desktop [00:44:07] typing fail [00:44:12] yup [00:44:14] are you doing this from en.m .wiki or en.wiki [00:44:20] jdlrobson: en.m [00:44:46] nope that was fine for me.. [00:44:52] blame sticky cookies? [00:44:54] ;-) [00:44:59] harhar [00:44:59] awjr: same here [00:45:14] i'm just going to blame sticky cookies for everything now [00:45:19] hahaha [00:45:21] lol [00:45:25] we do already anyway :p [00:45:30] jon the watch list is broken! well it's probably sticky cookie related.. [00:45:36] lol [00:45:40] but it's a javascript error… must be some sticky cookie related code leaking in [00:45:47] ok, are we done? do we need a cache flush? [00:46:07] but i've got cookies disabled… sticky cookies probably undisabled them [00:46:14] hahaha [00:46:50] Ninety-nine percent of the cookies are eaten by one percent of the monsters. [00:46:51] sticky cookie hamburger toast [00:47:01] you all are making me seriously hungry [00:47:08] we need a cookie flush [00:47:12] >_< [00:47:49] and cracker barrel is the featured article of the day, haha [00:48:12] also >_< [00:48:36] spagewmf: i think we're all done [00:49:29] what time do barbers close? [00:49:34] generally i mean ;-) [00:49:45] it fluctuates wildly in san franicsco [00:50:59] i wanted to go to Robson's barbers [00:51:07] but i think it will probably close at 5pm [00:51:12] * MaxSem imagines jdlrobson with a shaved head [00:51:16] wondering if it's worth a visit just in case [00:51:30] jdlrobson, you should get an spagewmf half mohawk [00:51:46] jdlrobson: http://www.yelp.com/biz/robson-barbers-vancouver ? [00:51:53] jdlrobson: you should just give em a call [00:51:56] yup [00:52:00] i have no phone :( [00:52:11] borrow one in the place that you currently are [00:52:32] that felt grammatically awkward [00:52:40] need to work out how to ring from my hotel room [00:52:55] i bet canadian phones are extra weird [00:53:38] awjr: are we all deployed now? [00:54:41] SKYPE [00:54:47] why the heck did i not think of that [00:54:49] idiot [00:54:53] anyway they close at 7pm [00:54:58] so i get my robson barbers haircut [00:55:01] this makes me very happy [00:55:37] why does canada have the same +1 as the usa [00:55:37] that is very confusing [00:55:44] jdlrobson: yup we're deployed [00:56:07] jdlrobson: you could just get your own hair and have the same experience for cheaper [00:56:18] s/get/cut [00:57:48] well awjr this haircut has a lot to live up to … http://www.facebook.com/photo.php?fbid=885983342344&set=pb.222302160.-2207520000.1357865841&type=3&theater [00:58:06] ! [00:58:08] you should invoke the copyright jdlrobson [00:58:19] that is awesome [00:59:35] right right right [00:59:40] anything needed from me before i bail [01:02:18] I'm gonna go get the kidlet dinner as well but I'll be online a bit later [01:04:44] coding from 7am tomorrow so let me know via email if anything i should concentrate on [01:04:46] catch you all tomo! [01:04:50] jdlrobson: you should get your haircut like this: http://imgur.com/gallery/FZf1J [01:04:54] jdlrobson: see you later! [01:10:47] awjr, what was your deploy window? I asked in #wikimedia-operations if it was OK to sync-file the EventLogging fix for events and got deafening silence :) [01:10:56] s/for events/for mobile events/ [01:11:06] spagewmf: we're done - sorry, i gave you the all clear about 30 mins ago [01:12:04] right, I needed lunch. Can this be the tail-end of your deploy or has the window closed [01:12:31] spagewmf: we're all done :) [01:13:14] spagewmf: technically our window is closed, but i dont think it would be a problem [01:13:33] nobody scheduled time after us [01:14:17] alright. It should be fine, just one file to 1.21wmf6 and 7. What's a mobile site with the beta create account that is still on 1.21wmf6? [01:15:24] one of the smaller language wikipedias i think [01:15:27] lemme pull up the list [01:15:56] spagewmf: eswiki, for example [01:16:00] or dewiki [01:16:07] and so on [01:16:59] hmm it's supposed to snow here on monday [01:18:05] spagewmf: you can double check what wiki is running which branch by looking on fenari in /home/wikipedia/common/wikiversions.dat [01:19:25] ok i'll double-check the axiata stuff later, it seems slightly off for now, might need more config tweaking [01:19:30] but i think all the ip stuff is done :) [01:22:21] reedy@fenari:/home/wikipedia/common$ ./multiversion/getMWVersion enwiki [01:22:22] php-1.21wmf7 [01:22:35] reedy@fenari:/home/wikipedia/common$ echo "print \$wgVersion;" | mwscript eval.php enwiki [01:22:36] 1.21wmf7 [01:22:38] oh fancy [01:24:54] im outta here. see you all tomorrow! [01:25:18] 42660 enwiki {"token":"","userId":18235977,"userName":"ACUX mobile test 2","isSelfMade":true,"userBuckets":"","displayMobile":true,"_meta":{"_site":"enwiki","_schema":"ServerSideAccountCreation","_revision":5014296,"_valid":true}} [01:25:26] merrry Festivus! [01:25:27] !!!! [01:25:32] spagewmf: AWESOME! [01:25:48] nice work :) [01:26:11] good night all [06:19:14] New review: Spage; "Also, when and if you rev your schema, we like isAnon for booleans." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43099 [11:13:09] New review: Siebrand; "Per Jon, with some additional comment." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43113 [11:53:02] New review: Siebrand; "i18n/L10n reviewed." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42251 [14:21:13] YuviPanda: :( [14:21:24] gonna go offline for 40 mins as soon as this bus leaves [14:21:30] stealing mcdonalds wifi at the moment [14:24:21] jdlrobson: :( [14:24:34] jdlrobson: no 3G? [14:24:41] jdlrobson: no living on the edge? [14:25:18] not yet [14:25:21] hopefully at border [14:25:52] argg how do i get at accidently archived emails in gmail [14:26:00] jdlrobson: search, or 'All Mail' [14:26:10] jdlrobson: 'All Mail' is hidden under 'More' usually [14:26:12] eek maybe i deleted accidently [14:27:22] jdlrobson: it'll be in trash [14:27:25] got it [14:27:39] arggg vibha hasn't understood me [16:57:38] New patchset: Jdlrobson; "add hamburger icon to special watchlist page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43469 [16:57:47] yay!!! [16:59:17] hamburgers detected [17:00:19] \o/ [17:22:17] MaxSem where's the wiki page you started recording tasks on? i have some to add [17:22:52] (for interviews, i mean) [17:23:06] awjr, so far in my userspace: https://office.wikimedia.org/wiki/User:Msemenik/Tech_task_1 https://office.wikimedia.org/wiki/User:Msemenik/Tech_task_2 [17:23:18] could move to something shared I guess [17:23:40] yeah, we should put it somewhere more general [17:23:48] there might already be a spot for that kind of stuff… but im not sure [17:25:18] mhm, mebbe on subpage of https://office.wikimedia.org/wiki/Engineering_Recruitment_Projects ? [17:31:16] i think that makes sense for now [17:41:12] awjr, can you share yours? [17:41:26] MaxSem yeah, sorry, i keep getting distracted - one minute [17:41:37] no worries [18:17:17] awjr: do you need me at the estimation @ 11 ? i'm eager to use my time elsewhere. [18:22:00] running to get coffee back in a bit [18:23:49] tfinc_: no you're optional [18:23:55] thanks [18:59:06] ehm, mtg? [19:00:39] where's everyone? [19:00:53] MaxSem maryana is setting up and i'll be joining as soon as i figure out why mingle is down [19:00:53] again [19:01:05] tfinc appears to be in engineering management mtf [19:01:09] *mtg [19:01:23] yeah he will not be joining us [19:01:31] does anybody have a macbook dongle for ethernet? [19:01:32] ok mingle's back up [19:01:45] Maryana: nope i never remember mine [19:02:26] dongle theft is rampant [19:03:05] where are we meeting? calendar says r37 but there's nobody there [19:03:49] brion r37 it is [19:03:59] we're here [19:04:04] and there's a dongle! [19:04:05] yay! [19:04:09] huzzah! [19:04:32] two! two ethernet dongles [19:04:35] ah ah ah [19:06:15] brion! [19:06:28] YuviPanda: what up [19:06:35] ready for APP TEAM MONDAY? [19:06:51] VERY MUCH SIR! :P [19:06:54] wooooo [19:07:05] brion: Almost done with the jQuery.IME Java port anywawy :P [19:07:10] excellent :D [19:07:11] and then realized that tehre's nothing for esperanto :P [19:07:18] so thought you might want to add one :P [19:08:33] there should be a ruleset in there :) [19:08:38] if not i'll have to add it! [19:09:14] brion: please do :) [19:20:50] bad mingle :( [19:31:30] jdlrobson: https://gist.github.com/4513299 [19:31:50] love how you did a gist brion :) [20:00:23] tfinc: for our call later i think it's best for me to ring you on my mobile [20:00:27] wifi is a bit flakey [20:05:44] Maryana: ack. such a busy day on the blog [20:06:36] tfinc: :( [20:06:41] i know - but according to e3, we're getting lots of account registrations! [20:06:48] it's pretty buried [20:06:57] from all over - hebrew, portuguese, vietnamese wikipedias.. [20:07:00] is it normal to do more than one blog post a day? seems kind of weird [20:07:14] only mine was scheduled for today as of earlier this week [20:07:22] i don't know where all these other ones came from [20:07:34] Maryana: are other people not using the calendar ? [20:07:35] * Maryana shakes fist [20:07:42] same on them! we did it right [20:07:53] so awjr how do I make a special page 404 [20:08:08] my mac died with the grey screen of death so not sure if that message came through [20:08:08] eh? [20:08:09] i can never find the communications anymore [20:08:16] jdlrobson_: / [20:08:17] er [20:08:17] ? [20:08:24] https://gerrit.wikimedia.org/r/#/c/42196/ is the context [20:08:41] specifically l23 https://gerrit.wikimedia.org/r/#/c/42196/2/includes/specials/SpecialMobileDiff.php [20:08:48] google found it right away [20:08:51] i'd like to get this patch wrapped up [20:08:56] there's a way to make MW display an http error - i forget off the top of my head, lemme see if i can find it [20:09:15] there were two others that are on the calendar http://meta.wikimedia.org/wiki/Wikimedia_Blog/Calendar [20:09:18] jdlrobson_: wfHttpError() is the function you want, i think [20:09:26] let me try [20:09:52] jdlrobson_: if we have multiple posts we at least try to stagger them a couple of hours apart [20:10:00] jdlrobson_: wfHttpError( $code, $label, $description ) [20:10:09] where $code is the error code (in this case, 404) [20:10:13] tfinc: a couple of hours isn't good enough in our world [20:10:19] with different time zones [20:10:32] i'd say posts should be 24 hours apart at least [20:10:47] it gives the sense they are less important [20:10:59] jdlrobson_: i don't disagree but sometime we simply can't have a blog post a day. i realize thats not ideal but given the level of activity on the blog its not always possible [20:11:14] :-/ [20:11:17] jdlrobson_: http://svn.wikimedia.org/doc/GlobalFunctions_8php.html#aeaf82e19627fefd908a8fb02699acf83 [20:11:24] thanks awjr gonna give that a go [20:11:31] mysqld & [20:11:34] ah damn it wrong box [20:16:21] awjr_lunch: you are a genius :) [20:22:23] New patchset: Jdlrobson; "don't throw exception when bad revision id given (bug 43267)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42196 [20:25:12] * jdlrobson_ grabbing lunch [20:36:39] jdlrobson: i'm failing trying to find the goals that i set with you at the beginning of the year. do you have them ready on hand ? [20:36:55] yes [20:36:58] had them earlier [20:37:19] let me dig them out.. [20:37:38] https://office.wikimedia.org/wiki/Goals/2012-2013/Engineering/Jon%20Robson [20:40:53] tfinc: ^ [20:41:13] office wiki FTW [20:41:14] thanks [21:28:28] tomasz around? [21:28:37] rmoen: ? [21:29:17] jdlrobson: here [21:35:05] jdlrobson: just lost you [21:37:02] jdlrobson: rather then wrestling with your connection lets do some of it on irc today and the rest on monday [21:37:18] who is cutting assets for the mobile watchlist stuff? [21:37:46] jorm: vibha [21:37:56] ShowDiff_Positive-20 and 21.png need recutting. [21:38:19] the shapes are not intersecting on solid pixel lines. [21:38:23] vibha: ping [21:41:25] i guess i should send an email. [21:50:28] brion: thanks for the merge of the javascript linting on SVGEdit :-D ( was https://gerrit.wikimedia.org/r/#/c/36754/ ) [21:52:31] \o/ [21:52:34] thanks for the update :D [22:03:22] MaxSem: i'm playing with GeoData again [22:03:23] Fatal error: Class 'ApiQueryGeoSearchDb' not found in /Users/jrobson/Sites/w/includes/api/ApiQuery.php on line 386 [22:03:59] you have bloody WMF cluster at your disposal now;) [22:04:16] i'm taking full advantage of being on a moving train.. [22:04:59] aha [22:05:32] cd extensions/GeoData && git checkout master && git pull [22:05:51] mm it tells me all is up to date [22:06:01] np though - i'll just use en.wiki [22:06:19] $wgAutoloadClasses['ApiQueryGeoSearchDB'] = "$dir/api/ApiQueryGeoSearchDB.php"; [22:11:16] gawd chrome geolocation is so lame [22:56:48] New patchset: Jdlrobson; "Add nearby page to mobile site [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [22:56:57] BOOM MaxSem [22:57:44] jdlrobson, we're not geonames, you can search for more [22:57:58] you mean more than 10? [22:58:09] yup [22:58:14] New patchset: Jdlrobson; "Add nearby page to mobile site [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [22:58:29] {{fixed}}?:P [22:58:36] not quite [22:58:37] what's the paremeter? [22:58:41] gslimit ? [22:58:48] how about 100? [22:58:50] aha [22:58:54] no prob [22:59:47] New patchset: Jdlrobson; "Add nearby page to mobile site [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [22:59:50] it needs to be balanced between map richness and download site [22:59:50] BOOM patchset 3 [22:59:54] s/site/size/ [23:00:12] It doesn't use a map at the moment [23:00:19] just a list view [23:00:35] actually I should probably add a map link (but I can do that in a later commit) [23:00:37] with distances? [23:00:46] Yup [23:00:51] i'll show you a screen [23:00:56] link to where? [23:01:41] MaxSem: http://jonrobson.me.uk/geodatayeh.png [23:01:50] Currently it just links to the article and says how close you are [23:01:58] I figured some kind of lookup was better than no lookup [23:02:20] in future we'll allow flicking to a map / summaries / last edited time / whether article needs a photo etc etc etc [23:03:22] right my train has almost arrived so I need to pack up [23:03:31] will be on email if you need me :) [23:03:40] jdlrobson, please create a configuration setting to disable this page [23:03:50] ahh shit I knew I forgot something [23:03:50] (should be disabled by default) [23:03:58] will do MaxSem [23:04:01] :) [23:04:08] good work [23:05:46] Is it enough just to disable javascript or do I need to prevent the Special page from initializing as well: [23:06:14] e.g. autoloadClasses [23:06:43] anyway gotta get off train [23:06:45] talk soon [23:27:23] New review: Siebrand; "L10n review." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43594 [23:38:24] disruption fini [23:46:57] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43237