[00:00:50] what movie MaxSem ? [00:01:22] you and other folks at the table;) [00:03:38] awjr: I think one solution to the code review problem is every morning I could send a picture of a Commons penis for every item in the code review backlog which hasn't had any activity to mobile-tech.. thoughts? [00:03:49] roflmao [00:04:09] it's extreme but i think extreme might be needed [00:04:11] i can imagine the algorithm for arbitrarily choosing a commons penis [00:13:26] Searching the length and bredth of the commons archive? [00:14:24] @_@ [00:52:35] New patchset: Jdlrobson; "Remove flash of unstyled content (bug 43739)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43979 [00:52:42] jgonera: awjr https://gerrit.wikimedia.org/r/43979 [00:55:16] jdlrobson, you've left some debugging code [00:55:22] aerggg [00:56:20] New patchset: Jdlrobson; "Remove flash of unstyled content (bug 43739)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43979 [00:57:20] New patchset: Jdlrobson; "replace list of image names with a list of thumbnails [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/39571 [00:59:05] so team.. just to point out we seem to have a very similar number of items in code review as we did at the start of the day and i don't see many more +1s or -1s….. [00:59:34] ^ awjr [01:18:52] sorry jdlrobson, i have been swamped today with no time to look at gerrit :( [01:19:02] jdlrobson: i will def spend some time on code review tomorrow, promise [02:56:51] New patchset: JGonera; "(card #308) Add modified date to All view in watchlist [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43113 [03:03:37] New patchset: JGonera; "(card #308) Add modified date to All view in watchlist [beta]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43113 [10:15:27] New review: Siebrand; "Suggested rewording to make it more generic, on not only the Encyclopedia use case." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43594 [10:47:55] New review: Siebrand; "L10n/i18n review." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/43113 [17:34:41] Hey MaxSem can you review https://gerrit.wikimedia.org/r/#/c/43469/ ? [17:34:58] sure but a bit later, I'm in interview [17:35:22] ahh ok sorry :) [17:49:21] why don't people have programming languages interpreters built-in into their brains? [17:49:40] MaxSem: I have one, it's just not very robust [17:49:43] brains are too squishy for interpreters [17:50:01] YuviPanda, you're hired [17:50:06] brion, you're not [17:50:17] awww [17:50:22] XD [17:50:36] brion: esperanto sir! [17:50:42] coming shortly [17:50:54] first, must blog post about wikipedia day :D [17:51:42] the first employee blogging about the first holiday? [17:52:46] just a short post [17:52:57] but figured i'd call it out since there's not a lot of "oh boy it's wikipedia day" :) [17:54:29] oh boy, it's wikipedia day!!!! [17:54:37] i totally forgot - happy wikipedia day everyone :D [17:54:42] that's what i'm talking about :D [17:56:02] :D [17:56:08] there, just a little post: http://leuksman.com/log/2013/01/15/wikipedia-is-12-years-old-today/ [17:56:11] I totally forgot. [17:57:20] now i could have sworn i did esperanto transliteration rules for narayam… maybe they got dropped in the conversion to jquery.ime [17:57:39] YuviPanda: no it's there: https://github.com/wikimedia/jquery.ime/blob/master/rules/eo/eo-transliteration.js [17:57:44] is it not selectable or something? [17:58:07] oh [17:58:11] i didn't see it! [17:58:14] :D [17:58:33] brion: actually i tihnk i did, just that 'eo' passed my attention [17:58:44] pssh [17:58:48] gotta learn your language codes dude [17:59:09] if only we had some sort of web site with lists of information that people could look up [17:59:36] brion: yeah, get to building that asap man :P [18:06:04] awjr: able to do some review? [18:06:57] jdlrobson: already doing some [18:07:11] awjr i'd suggest: https://gerrit.wikimedia.org/r/#/c/43469/ https://gerrit.wikimedia.org/r/#/c/42972/ https://gerrit.wikimedia.org/r/#/c/42348/ [18:07:14] im looking through 43979 [18:07:24] since you requested it at the end of the day yesterday [18:07:46] ok cool :) [18:08:01] i'm just glancing through at ones which seem very php heavy [18:08:21] anybody familiar with setting up nat rules on os x? i want to forward all requests originating somewhere on my LAN of my local machine on ports 80 and 443 to a VM running on a virtual network on said local machine (which is not accessible to my LAN) [18:08:23] MaxSem: let me know when you're free to do some code review so I can point you at some [18:08:31] aha [18:08:34] i know how to do this with iptables, but not with whatever voodoo runs on osx [18:09:46] brion, maybe? ^ [18:10:16] oh i ain't fiddled with nat rules on osx. it might be similar to freebsd but…. i ain't tried it :) [18:11:08] okidoke, looks like os x uses natd (same as freebsd?) [18:11:34] i imagine it's as easy as defining one simple stupid rule but i dont want to have to read all the documentaiton to figure out how to do it right now :p [18:16:40] awjr: call apple support :P [18:16:47] hahaha [18:17:06] rm -rf os x; apt-get ubuntu [18:17:08] oh wait... [18:17:51] any sign of jgonera? [18:18:21] (currently reviewing 43113 btw) [18:24:09] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43113 [18:28:22] New review: awjrichards; "In the big scheme of things, this looks good and appears to work. I have some minor quibbles - see i..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43979 [18:34:08] jdlrobson: jgonera just joined [18:38:52] jgonera: https://gerrit.wikimedia.org/r/#/c/42972/ https://gerrit.wikimedia.org/r/#/c/42990/ https://gerrit.wikimedia.org/r/#/c/42992/ [18:39:16] * YuviPanda throws a few obscenities at eclipse [18:50:54] New review: awjrichards; "in general, please please please keep php methods short, sweet, and single-purpose. things in SkinMo..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43469 [19:10:52] hmm gerrit seems to have eaten an inline comment of mine [19:11:09] * awjr performs heimlich maneuver on gerrit [19:11:49] New review: JGonera; "Nothing major, just some doubts." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42972 [19:12:14] awjr, maybe it's on an older patchset? [19:12:24] nope, only one patchset [19:12:41] im not sure what happened - i navigated away from the file i left the inline comment [19:12:47] and then maybe i refreshed gerrit or something [19:12:48] i dunno [19:17:56] New patchset: Jdlrobson; "Remove flash of unstyled content (bug 43739)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43979 [19:17:58] awjr: better? ^ [19:19:25] New patchset: Jdlrobson; "Add nearby page to mobile site [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [19:20:33] jgonera: https://gerrit.wikimedia.org/r/#/c/42972/1/javascripts/common/mf-application.js L27 that could happen on beta if a bad message key is passed - there for sanity checking more than anything [19:20:46] maxsem, jcmish, i'm taking a pass at clearing our "ready for signoff" column backlog in mingle - a few questions for you two: [19:20:59] did we create a deployment branch? [19:21:08] jdlrobson, that's my point, we want to know if we're passing a bad message key ;) [19:21:20] Maryana, yes [19:21:26] excellent. thanks! [19:21:28] yeh but i'm anticipating a future where modules from other extensions are passed [19:21:40] * are using the message function for whatever reason [19:21:45] want it to throw an exception instead? [19:21:54] i think event logging is unnecessary here [19:21:55] our message function? why would the do that? [19:22:00] they* [19:22:10] true i guess eventually it will cease to exist [19:22:30] anyway i either leave it or throw an exception or make it return undefined [19:22:31] up to you [19:22:43] I'd say throw an Error or return undefined [19:22:48] hm [19:23:15] choose :) [19:23:25] how about the RL - do we have it fully in mobilefrontend, maxsem? [19:23:35] throw an Error [19:23:48] depends on criteria - which card? [19:23:57] (I'd say no) [19:24:26] jdlrobson, I don't get why but sometimes I don't get the Read in another language button in my dev env [19:24:53] either you don't have any languages for that article [19:24:55] https://mingle.corp.wikimedia.org/projects/mobile/cards/293 [19:24:59] OR you are experiencing the dynamic sections bug [19:25:02] ^ maxsem [19:25:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=42962 [19:25:12] I have languages, because if I refresh the page it's there [19:25:24] and last modified is also missing if the button is missing [19:26:15] also https://mingle.corp.wikimedia.org/projects/mobile/cards/302, maxsem [19:26:43] 302 is done [19:27:18] sweet [19:27:36] how about resourceloader? [19:27:53] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42992 [19:30:49] Maryana, let's ask jdlrobson. Jon, do you think #293 can be considered done even though we still have a non-RL mode and build the RL links by hand? [19:32:41] MaxSem, Maryana, jdlrobson: not according to the acceptance criteria: 'All css/js for MobileFrontend loaded the standard way via ResourceLoader' [19:33:01] so it should go back to indevelopment... [19:33:13] iirc jdlrobson implemented that for beta but not production? [19:33:16] or even ready for dev if nobody's working on it ATM [19:33:34] i can't talk about this at moment sorry [19:33:35] although the original intention of that card was to do that everywhere [19:34:41] last time i talked to ori-l, it sounded like RL was a dependency for graduating eventlogging to stable, so i'd like to keep the work rolling on it if possible [19:34:44] jdlrobson: would you be offended if i made some small changes to https://gerrit.wikimedia.org/r/#/c/43979/3/MobileFrontend.php ? [19:34:52] grrrrrrr, got very tired by interviewing [19:35:09] no awjr_lunch i'd encourage it if it results in the code being merged quicker [19:35:19] jdlrobson: well, it will :) [19:35:29] because i am not going to merge it as is [19:35:54] so here goes [19:36:32] Maryana: so, we use RL for all the resources, we just do it in a weird way in most places [19:37:31] heh [19:37:43] well, as long as it's doing what needs to be done :) [19:37:58] loading all those resources [19:38:11] so we can log all those events [19:38:31] Maryana: was ori saying that the way we're currently doing things is preventing moving eventlogging to prod? [19:39:13] jdlrobson, I updated http://www.mediawiki.org/wiki/MobileFrontend/JS_code_organization [19:39:26] not necessarily. i should check in w/him about it, but i think he assumed that eventlogging wouldn't be able to work in prod without full RL in prod - and that we only have RL in beta atm [19:40:03] not sure he knew the extent of the RL coverage in prod currently [19:40:18] awjr_lunch, any opinion on the "It makes reviewing the code more tedious" bullet point in http://www.mediawiki.org/wiki/MobileFrontend/JS_code_organization ? [19:41:55] Maryana: it sounds like we should have a technical convo with ori - because he might be saying there are certain things that RL loads in desktop that aren't available in mobile, or the way we're loading stuff in prod is not compatible (which i think would be surprising), or xxxx [19:42:00] probably best go have him sync up with jon [19:42:15] jgonera probably :) [19:42:16] one sec [19:42:31] ok, i'll make it happen [19:44:32] New patchset: Jdlrobson; "use resource loader for message delivery where possible (bug 43409)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42972 [19:44:33] sorry got stuck in a huge rebase [19:44:46] ^ can we get that merged asap so i don't have to go through that again [19:46:36] So on subject of https://mingle.corp.wikimedia.org/projects/mobile/cards/293 - I think the problem lies from it being badly defined in the first place. I suspect we would never have been able to integrate resource loader fully (especially on non-beta) and I think we could have worded it differently to do the minimum possible to get us towards that. [19:47:02] the story should have been written more in terms of what we wanted to achieve whether that was supporting getting event logging into production or some other thing [19:48:16] i think you're right jdlrobson [19:48:38] I think we are extremely close to integrating a useful form of ResourceLoader to other teams and if we are prepared to make some tough decisions we can work on a story about moving it to production for the purpose of event logging [19:49:01] for instance if we are prepared to drop section toggling and search from a wide range of mobile devices we can do this now with some more testing [19:49:14] but in doing that we might piss off a lot of people [19:49:24] jdlrobson, things like that make me wonder again that maybe we should have two versions of the app, one with legacy non-JS mode that is just for reading and we won't have to touch ever again and one that we develop without considering those really old devices [19:49:26] we can complete the dynamic sections story to mitigate some of that annoyance [19:49:40] jgonera: this is what the RL world would look like [19:50:08] however arguably the non-JS mode is currently nasty when viewed without dynamic sections [19:50:08] RL is resource loader or real life here? ;) [19:50:19] both! [19:50:20] :) [19:50:22] or toggling [19:50:52] but assuming we get the section links at some point, do you see it as a possible alternative? [19:50:54] well, let's check with ori-l. maybe we don't actually need to do any more work on it yet to get a minimum viable eventlogger out in prod [19:51:27] Personally I'd like us to add the sections link fallback to reduce the impact on many of our users but if we want to get event logging quickly into production i don't think we have much choice but to just flick that switch [19:52:02] production = stable? [19:52:47] yup [19:52:51] sorry for the confusing term [19:53:47] awjr_lunch, so looks like you'll deploy with git-deploy this week >_> [19:54:13] @_@ [19:55:03] MaxSem i thought that was not until next week? [19:55:21] jgonera: http://www.mediawiki.org/w/index.php?title=MobileFrontend%2FJS_code_organization&diff=629079&oldid=628774 [19:56:04] awjr_lunch, see robla's latest email [19:56:05] jgonera: i have much less of an opinion about frameworks, particularly on the js side [19:57:01] awjr_lunch, what about OO programming? because currently the only objects we have in JS are DOM objects which do not represent anything from the application domain [19:58:16] jgonera if it were PHP i'd have a much stronger opinion to register about that but i am not confident enough in my JS to say one way or another which i think is better for our purpose. but in general, my preference is to use OOP as when done right, it keeps things more organized (and therefor readable), reusable, and resilient [19:58:34] awjr_lunch: we need to come up with a way of documenting our code [19:58:37] jdlrobson, why we're not injecting "empty-homepage" message in the addMessages() function? [19:58:39] it's not clear how i should document php [19:59:42] jdlrobson: http://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Comments_and_Documentation [20:00:08] yeh but we don't seem to be doing that so.. [20:00:12] awjr_lunch, ok, agreed, I'll try to rewrite one of the JS modules soon (first I'll finish experimenting with Knockout.js) and see what I come up with [20:01:27] MaxSem: im not sure if that's true. Robla still hasn't answered my questions [20:01:52] January 14-15 (Mon-Tue): deployments from fenari to Tampa cluster [20:01:53] using scap/sync-file/sync-dir as normal. [20:01:53] January 16 (Wed): 1.21wmf8 deployed to test, test2, and mediawiki.org [20:01:53] January 16-18 (Wed-Fri): 1.21wmf8 deployments using git-deploy from fenari [20:01:53] January 17 (Thu): Brown bag with Ryan Lane and Chris Steipp to talk [20:01:53] about git-deploy [20:02:18] MaxSem: yes, for 1.21wmf8 but whether or not we can still use sacp etc for 1.21wmf7 is up in the air [20:02:30] jgonera: that should be an easy one to review https://gerrit.wikimedia.org/r/#/c/40757/ [20:02:49] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42747 [20:04:18] i presume the old way should still work for 1.21wmf7... [20:07:18] * MaxSem is afraid that our deployment might get easily divided by zero in these pertrubations... [20:07:52] i am a bit nervous about it too, but we'll work it out one way or another [20:08:59] ...or no way:P [20:09:54] hehe MaxSem i remain optimistic :) [20:10:06] pfft [20:10:22] hahahahahaha does my optimism offend your sensibilities? [20:21:52] awjr_lunch: i'm not attending the WLM meet, since I wasn't involved for the meat of it [20:21:56] (i hit no on the invite, I Think) [20:22:07] ok YuviPanda no worries [20:22:30] awjr_lunch: I'll still be online, so poke me if I'm needed. [20:22:42] okidoke thanks [20:28:25] awjr_lunch: Not allowed to join [20:28:33] That's what i get [20:30:11] multichill, your email? [20:30:38] hmm [20:30:50] it refuses to let me open it to everyone [20:30:51] do you need a google account to use hangouts? [20:30:58] awjr, yes [20:31:00] No, the hangout, I don't use gmail. [20:31:09] I'm logged in [20:31:40] awjr: just trying to join now [20:32:01] multichill: can you try again? [20:32:20] multichill: i get the same thing usually. open in incognito, log in -> Works [20:33:58] hi [20:34:01] hey elya [20:34:16] YuviPanda, hi. [20:34:30] awjr: Just remove the security setting [20:34:36] multichill: if you have a google account you should be able to join; i've made it public [20:34:51] awjr, cannot join either [20:34:54] ! [20:35:07] i just tired it with my non-wmf gmail account (not on the invite) and it worked fine [20:35:08] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42990 [20:35:14] elya, multichill ^^ [20:35:18] no luck [20:35:27] awjr: I'll also note that people on the staff channel have been complaining about hangouts being down [20:35:43] well it's not down, everyone else is in it :p [20:36:00] multichill, elya, can you log out/log back in? [20:36:07] and try again? [20:36:16] failing that, maybe we should try something else - maybe just skype [20:36:18] Did that and different laptop [20:36:24] but we won't be able to use video [20:36:37] same problem. "missing credentials" [20:36:46] You're all ugly anyway :P [20:36:48] sigh. [20:37:17] 21st century communication [20:37:45] Different browser also fails. Let's go Skype [20:38:41] awjr: Can you assemble the group? [20:38:42] multichill, elya i just reinvited you one more time to the hangout and told the hangout to allow people outside the WMF to join [20:38:47] multichill, you should get an invitation now [20:38:48] plz try that then i'll try skype [20:38:58] awjr, did you use my gmail address? [20:39:39] elya: That worked for me [20:39:39] elya: yup [20:39:49] yay! [20:42:33] New patchset: awjrichards; "Remove flash of unstyled content (bug 43739)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43979 [20:51:20] awjr: are we doing that WLM retrospective? looks like i'm late [20:52:41] ok i'm in [20:55:35] yay http://www.youtube.com/watch?v=22zR1K2WG28 [20:55:38] err [20:55:54] let's not click that [20:56:04] random song link. I meant https://twitter.com/yuvipanda/status/291287049359749120/photo/1 [20:56:19] \o/ [20:56:25] is esperanto working? :D [20:57:14] brion: let me check [20:57:19] brion: so, i haven't put in code to turn this *off* [20:57:20] yet [20:57:20] :P [20:57:21] so [20:57:41] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42989 [20:58:41] \msg vbamba_ try msging Jon on IRC [20:58:50] ghh [20:59:10] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/40757 [21:01:53] brion: what's the current way to enter esperanto on Android? [21:02:07] is there a special keyboard? [21:02:14] or do you just piggy back on, say, Spanish or french? [21:02:15] YuviPanda: i think there's a 3rd-party keyboard in the play store somewhere for it [21:04:11] brion: ah, ok. [21:08:09] brion: can you fork a bunch of repos into wikimedia/ for me? [21:08:17] github.com/yuvipanda/java-morelangs [21:08:18] sure link me up bro [21:08:45] https://github.com/yuvipanda/aosp-morelang-ime [21:08:47] https://github.com/yuvipanda/aosp-morelang-ime-dictionaries [21:08:49] right [21:08:51] https://github.com/wikimedia/java-morelangs [21:08:51] so that's three [21:09:06] https://github.com/wikimedia/aosp-morelang-ime-dictionaries [21:09:15] well that's two [21:09:21] one more :P [21:09:21] your first appears to already be in wikimedia...? [21:09:24] *third [21:09:32] https://github.com/yuvipanda/aosp-morelang-ime one? [21:09:33] really? [21:09:40] where? [21:09:42] i don't see it [21:09:53] nope, still don't [21:09:55] woops [21:10:05] this is what i get for multitasking [21:10:07] https://github.com/wikimedia/aosp-morelang-ime [21:10:26] :P [21:10:48] brion: can you enable issues on all three? [21:10:56] hmmm [21:11:24] YuviPanda: done [21:11:32] yay awesome brion is awesome :P [21:11:36] :) [21:19:15] brion: can you *also* configure those three repos to post on #wikimedia-mobile whenever there's a commit [21:19:16] ? [21:19:18] last nag [21:19:20] I promsie! [21:19:21] *promise [21:22:37] YuviPanda: i'll do that after this meeting :) [21:22:44] have to double-check how to set it up [21:22:46] brion: thanks! [21:28:17] awjr: please review https://gerrit.wikimedia.org/r/#/c/42272/ ? [21:30:56] MaxSem jgonera: can you take a look at https://gerrit.wikimedia.org/r/#/c/42196/ [21:31:07] Ok. Thanks guys, that was nice! [21:31:24] thanks, bye! [21:31:33] jdlrobson, not a second has passed since I closed the hangout window. boo [21:31:40] muhaha [21:31:46] no rest whilst their is code review [21:31:50] or i'll make you a meme tomorrow [21:32:05] jdlrobson: MaxSem is *already* a meme [21:32:06] :P [21:32:10] jdlrobson: i forgot to add 'make a meme a day' to the tech lead responsibilities list [21:32:20] jdlrobson, this rev actually contains some my code so I abstain [21:33:09] jdlrobson: i made some changes to MobileFrontend.php: https://gerrit.wikimedia.org/r/#/c/43979/ [21:34:00] if you're ok with that, i think the changest can be merged [21:34:06] the meme for tomorrow is already made [21:34:16] MaxSem: you just need to ok the 404 [21:34:30] I feel like everything else has had sufficient code review [21:34:34] awjr: looking [21:34:41] brion: I sent you a tweet with esperanto on it ;) [21:34:59] yeah? really? and what if I want to bikeshed?:P [21:35:02] \o/ [21:35:19] * YuviPanda hands MaxSem a large kit with multiple colors of paint [21:35:31] i am nervous that mobile web's bike shedding is how mobile apps will crush us [21:35:36] brion: also https://dl.dropbox.com/u/8768784/morelangs-keyboard.apk [21:35:46] see? they are even encouraging us [21:35:51] awjr: looks good to me although L341 has trailing ws [21:35:55] gahhh [21:35:58] if you have it open can you quickly fix that otherwise i'll pull it out and do it [21:35:59] i'll fix the ws and merge [21:36:08] * MaxSem paints YuviPanda with pink stripes [21:36:08] sweet [21:36:08] thanks awjr [21:36:09] ok, +1 [21:36:13] my favorite color! how did you know?! [21:36:42] MaxSem: if you bike shed I will hit you with a bike [21:36:47] jdlrobson: would you mind commenting that my changes look OK so it looks less like im blindly merging my own code? [21:36:52] brion: are you on a nexus device? [21:37:03] galaxy nexus [21:37:09] running 4.1.1 iirc [21:37:17] New patchset: awjrichards; "Remove flash of unstyled content (bug 43739)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43979 [21:37:18] brion: can you install that and see if it installs? [21:37:21] i've a feeling it won't [21:37:49] moment [21:38:03] EPIC WIN: my fat ass have finally destroyed yet another chair! [21:38:18] btw for the record i loved the conversation about -1 for a typo in a commit message on wikitech today [21:38:27] brion: you're coming to az?! [21:38:30] at least we're not that bad.. [21:38:33] where's the knight foundation event/ [21:39:08] MaxSem: can I use the phrase "In mother Russia code review do you" on a meme of you at some point in the future? [21:39:16] or is that terribly stereotypical? [21:39:26] i'll do a british one of me "Keep calm and carry on code review" [21:40:17] awjr: i forget exactly where it is [21:40:23] i really should read those emails ;) [21:40:50] hahaha [21:41:02] jdlrobson: isn't that grammatically worng? [21:41:13] which one YuviPanda ? [21:41:15] either 'Keep calm and carry on reviewing code' or 'Keep calm and code review' [21:41:29] awjr: at ASU, so that's phoenix not tucson i believe [21:41:36] brion if it's in tucson we should hang out - but i'll bet it's in phoenix, which is only 1.5 hrs away. i might be able to drive up and say hi [21:41:39] tucson is U of A right? [21:41:41] http://en.wikipedia.org/wiki/Keep_Calm_and_Carry_On < YuviPanda [21:41:43] brion yah [21:41:49] * MaxSem proposes "Work wikislaves work" [21:41:52] jdlrobson: i know, just that... it's wrong [21:41:54] in thise case [21:41:57] So I suppose reviewing code would be best [21:42:03] yeah [21:42:11] literally too :P [21:42:12] but i think bad grammar maketh the meme ;-) [21:42:20] spiff. it'll be me, kul, and dfoy [21:42:21] bad grammer maketh the nazi [21:42:48] brion are you coming out by yourself? if so, i'm happy to make the effort to try and get up to phoenix to hang out [21:43:17] jdlrobson: 'then you code review, because it is not fuckin cognac'? :P [21:43:33] haha that's better than my current meme actually [21:43:38] :P [21:43:48] mine has no profanities though [21:43:55] profanity maketh the meme jdlrobson [21:44:14] you could make it 'smeggin cognac' [21:44:15] -1 on https://gerrit.wikimedia.org/r/#/c/43979/ [21:44:16] brion sweet! yeah, i'll see if i can get myself up there, it would be fun to hang out [21:44:19] if you prefer :) [21:44:26] awjr: awesome :) [21:44:35] brion: do poke me if you were able to install that apk :) [21:44:50] YuviPanda: ok lemme install that then i'll adjust your repo reporting [21:44:56] brion: whee [21:45:29] jdlrobson, your response needed at https://gerrit.wikimedia.org/r/#/c/43852/ [21:45:35] MaxSem: hook sounds like a good idea [21:45:59] and we already have a handler for it, just move the code there [21:46:07] MaxSem: And, do you think you can fix the http://nl.m.wikimedia.org issue? [21:46:26]