[02:56:29] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/44999 [02:57:39] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45000 [06:14:16] [WLMMobile] siebrand pushed 1 new commit to master: http://git.io/K34YAA [06:14:16] WLMMobile/master f26442c Siebrand Mazeland: Localisation updates from http://translatewiki.net. [06:14:29] Project WiktionaryMobile - Nightly builds build #114: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/114/ [06:14:30] s.mazeland: Localisation updates from http://translatewiki.net. [06:14:35] Project WLMMobile - Nightly builds build #253: SUCCESS in 8 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/253/ [06:14:35] s.mazeland: Localisation updates from http://translatewiki.net. [06:14:37] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/3WoDag [06:14:37] WikipediaMobile/master 25656cc Siebrand Mazeland: Localisation updates from http://translatewiki.net. [06:14:55] Project WikipediaMobile - Nightly builds build #488: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/488/ [06:14:55] s.mazeland: Localisation updates from http://translatewiki.net. [12:37:57] New review: Siebrand; "L10n/i18n reviewed." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/43594 [12:46:42] New review: Siebrand; "Marking -1, even though this is only an open question. That way it doesn't appear as "todo" on my re..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43001 [14:06:53] New patchset: Zfilipin; "Upgrade Firefox to version 18" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45132 [14:36:15] New patchset: Zfilipin; "Make Cucumber progress formatter the default one" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45135 [17:02:39] New review: Cmcmahon; "Cucumber reporting is nicer than native Jenkins reporting (both exist, but make Cuke visible by defa..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45135 [17:02:39] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45135 [17:03:53] New review: Cmcmahon; "support FF 18" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45132 [17:03:54] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45132 [17:38:45] awjr, you here? [17:38:51] MaxSem: hi, yup [17:38:54] how's it going? [17:39:00] hi [17:39:21] fucking hell, 600 Mbps of mobile miss traffic already [17:39:31] :( [17:39:44] i assume he's talking about mobile varnish cache? [17:39:45] the next appserver batch should come out of mobile's budget I think [17:40:02] time to move ahead with ESI:) [17:40:05] srsly [17:40:55] i think once RL is sorted out ESI will be easier to integrate [17:41:33] now that Zero test paln is coming, I've started my section work [17:41:39] i also think we should focus on one big thingamajig at a time [17:41:53] remind me what that is, MaxSem? [17:42:10] static per-section views [17:42:29] the only thing standing between us and RL-only mode [17:42:32] MaxSem i dont think you need to worry about that anymore [17:42:55] ? [17:43:00] product decided last week during the prioritization meeting that they don't care about toggleable sections for devices taht don't support jquery [17:43:08] at least not right now [17:43:36] I'm lost in this stuff [17:44:47] on the side news, Asher complains about our memcache usage, however sections caching will only increase this number [17:45:01] so ditching this stuff is good [17:45:44] yeah - i think you were in that meeting last week, but i can't really remember. but regardless, don't worry about it for now [17:46:00] that decision got written into some story card for the next iteration [17:46:25] i think it is good to have One Less Thing to worry about [17:46:25] I was, but I guess was too sleepy to understand every nuance [17:46:28] hehehehe [17:46:37] for sure [17:46:57] I remeber we discussed this but don't remeber the conclusion [17:48:18] maxsem, awjr: https://mingle.corp.wikimedia.org/projects/mobile/cards/382 [17:48:45] the relevant part is: "Given I’m a user of a phone listed in no jQuery section of http://www.mediawiki.org/wiki/Mobile/Testing_process who previously got collapsed sections I now see the entire page unfolded in stable." [17:49:06] thanks Maryana :) [17:49:16] np - it's slotted for next iteration [17:49:23] yup [17:49:31] cooll [17:49:43] "Update DeviceDetection.php to simplify devices"? [17:50:34] what does that mean? [17:53:04] that is a good quesiton [17:53:05] i don't know. that's a question for jdlrobson [17:53:36] MaxSem maybe leave a comment on the story [17:54:19] I don't think that we can e.g. merge some devices because we have per-device stylesheets [17:55:48] btw, there's a lot of fun in #-ops, watching is recommended [17:57:46] * awjr grabs popcorn and heads over to #wikimedia-operations [17:57:52] oooh [17:57:53] * SickPanda goes [18:06:01] notnarayan: hello [18:06:03] greetings SickPanda [18:06:10] greetings notnarayan [18:06:12] notnarayan: https://www.mediawiki.org/wiki/Extension:UploadWizard/Campaigns [18:07:15] * SickPanda waves at brion [18:08:08] SickPanda: we can do this for mobile ? [18:08:15] SickPanda: on mobile rather [18:08:18] notnarayan: the creation interface would be in the web for now [18:08:30] and that is fine [18:09:22] will go thought this SickPanda [18:09:39] i think we should just aim for consumption + contribution for that [18:09:47] * jdlrobson waves [18:09:51] stop getting sick panda! [18:09:58] notnarayan: and remember, we can always modify the data exposed by the server too [18:09:59] hello jdlrobson [18:10:06] * jdlrobson waves at notnarayan  [18:10:13] jdlrobson: apparently staying up for 36 hours and drinking ~30 cups of various types of tea makes you sick [18:10:16] who would've thought [18:10:21] hey all [18:10:21] who woulda thought [18:10:25] jdlrobson: who knew? [18:10:30] haha [18:10:30] eh [18:10:33] heh [18:10:37] eh? [18:10:43] I'm still craving Tea though [18:10:51] i have a bacon donut [18:10:56] or doughnut [18:11:01] depending on your preferred spelling [18:11:08] I still don't get what's so awesome about bacon [18:11:16] heresy, I know [18:11:22] hey jdlrobson, what does "Update DeviceDetection.php to simplify devices" mean? https://mingle.corp.wikimedia.org/projects/mobile/cards/382 [18:11:36] i'll clarify - thanks MaxSem [18:12:20] done [18:13:49] jdlrobson, don't we still need to know if the device support jQuery? [18:14:09] not that i'm aware of MaxSem if we do this [18:14:25] SickPanda: http://cdn.dropmark.com/16089/33fbab38ab2b1e63c15e8db3814245d7d0b0fd94/commons%20my%20upload%20rough.png [18:14:26] well let me put it this way - we don't use it anywhere [18:14:26] how so? [18:15:15] New review: Jdlrobson; "This breaks the left menu." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/44700 [18:16:04] if ( $jQueryEnabled ) { ... [18:16:48] that would be redundant MaxSem [18:16:58] notnarayan: http://etherpad.wikimedia.org/android-commons-app-1-0 [18:17:15] notnarayan: I think I'd want to issue an update every 10 days or so [18:17:23] jQueryEnabled can be assumed to be true if javascript is true [18:17:33] so : if ( $jQueryEnabled ) { > : if ( $javascriptEnabled ) { [18:17:58] jdlrobson, I think if should be more logical to do the other way around [18:18:03] ? [18:18:06] s/if/it/ [18:18:35] SickPanda: if this is a plan for 4th feb, can my uploads be done? [18:18:36] throw away JS support information in favor of jQuery support [18:18:54] notnarayan: i'm listing it there [18:19:07] MaxSem: we can discuss it during next iteration [18:19:13] I think the existence of both is confusing [18:20:04] MaxSem: i've tweaked the card to be more open [18:20:10] "Consider updating DeviceDetection.php to simplify devices by rethinking jQueryEnabled/javascriptEnabled device setting in the new environment." [18:20:14] notnarayan: let's just list them, and then organize them appropriately [18:20:20] awesome, thanks [18:20:24] SickPanda: yes. [18:20:26] jdlrobson: is tfinc in the office? [18:20:30] anyway the implementation notes are just there for guidance [18:20:32] SickPanda: yup [18:20:36] he's opposite me [18:20:39] want me to get him in irc? [18:21:03] \o/ i'm going to do some coding today [18:21:04] woooo [18:21:17] nah, just checking, we've a 1:1 in 10 [18:21:23] SickPanda: you rang ? [18:21:38] tfinc: no hangout link for 1:1 [18:21:44] so wondering if we're just gonna do that over chat? [18:21:57] fixed [18:22:00] tfinc: also, here have some germs :P [18:22:12] * tfinc puts on his hazmat suit  [18:22:30] * SickPanda goes to find his headset [18:22:59] Change abandoned: Jdlrobson; "since this doesn't work and there is a story in the next iteration (https://mingle.corp.wikimedia.or..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/44700 [18:24:17] * SickPanda restarts to get camera working [18:24:23] awjr: https://gerrit.wikimedia.org/r/#/c/42272/ can i merge this? [18:24:43] also jgonera can you check and merge this https://gerrit.wikimedia.org/r/#/c/44459/ [18:26:27] also MaxSem do you have any views on https://gerrit.wikimedia.org/r/#/c/43852/ [18:26:50] there was a message on the mailing list that spawned it [18:26:54] i'm trying to dig it out [18:27:05] tada! [18:27:23] MaxSem: [WikimediaMobile] Not displaying of page items < can you reply to that email on mobile-l ? [18:27:24] jdlrobson, we can move it for now, but what if we want to customize it a bit in future? [18:27:52] jdlrobson, as I already stated I'm opposed to it unless some analysis and communication are applied. this might be an ugly hack, but b/c tends to be ugly and not always breakable [18:28:30] ^ MaxSem can you reply to the mail ? [18:28:32] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/44459 [18:28:33] i think it's better there [18:28:48] gerrit has a habit of losing discussions [18:28:50] jdlrobson: no, im actually updating it now [18:28:57] awjr: cool [18:29:04] but im first trying to hunt down fresh batteries for my dead mouse :| [18:31:17] awjr: MaxSem jgonera thoughts on using https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer#installing in a git pre commit hook ? [18:32:14] I personally see no point in this now that we have Jenkins [18:32:31] jdlrobson: is that the same tool hashar was talking about last week? [18:32:36] awjr: yup [18:32:42] MaxSem: codesniffer does more than php -l afaik [18:32:54] jdlrobson: what is the problem you're hoping to solve? [18:33:20] awjr: I just want to make sure code we commit is of the best possible quality. Although jenkins does pick it up that seems to late in the work flow [18:33:39] then we should request this feature for Jenkins, otherwise there will always be a discrepancy between peoplewho have this hook and thise who don't [18:33:42] it would also encourage better code maintenance by flagging problems with files as we change them [18:33:45] I say we might try, if it's not too slow I think it's better to know that something's wrong before we commit [18:34:16] MaxSem: sure… but pre commit hook seems better than nothing. [18:34:19] my feeling is that it would be cool to try but is not worth spending a lot of time on right now; i don't think we've been having issues with PHP code quality for the most part [18:34:42] +1 awjr [18:34:52] awjr: i suspect it will take no more than 10 minutes to setup a pre commit hook so i wouldn't worry about spending a lot of time [18:35:13] multiply by the number of team members [18:35:26] well getting it running won't take time, but defining rules for code sniffer will, as will all of the discussion we'll have around it [18:35:29] well this is what experimental time is for :) [18:35:35] indeed! [18:35:44] also don't forget that installing CodeSniffer could be harder oth different platforms [18:37:07] MaxSem: you're such a negative nancy [18:37:11] you're reminding me of SickPanda :P [18:37:21] we're the gang [18:37:25] fear us [18:37:50] New review: Jdlrobson; "Open mobile-l discussion" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43852 [18:38:25] SickPanda: https://office.wikimedia.org/wiki/Goals [18:38:59] awjr: did we get a new date for our deployment? [18:39:18] jcmish: did you see the email i sent on friday eve? [18:39:22] yup [18:39:28] I wondered if there was another update :D [18:39:30] i haven't heard anything different from ops, so until we'll keep mon/tues of next week [18:39:36] jcmish: ^ [18:39:47] but if i hear something different from ops, i'll email out again [18:40:00] :) just doing heads down work on Zero test cases and didn't want to miss getting my git logs ready :D [18:40:18] for sure, thanks jcmish [18:40:33] No thank you! [18:40:33] :D [18:40:36] New patchset: awjrichards; "Bug 43123: force mobile URLs only for local redirects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [18:40:45] MaxSem can you look at ^? [18:40:51] i modified what you were originally doing to make it testable [18:41:30] sigh, now both backend devs are involved and can't merge:P [18:41:37] lol [18:41:47] unit tests, baby! [18:42:31] is MobileContext the best place for this function? [18:42:32] jdlrobson, https://github.com/necolas/normalize.css/ this one might be worth having a closer look at [18:42:42] MaxSem: i thought so [18:42:49] also, it should be called more genericly, e.g. isLocalURL() [18:42:52] MaxSem but i guess it is not strictly mobile-specific [18:42:54] especially " * 2. Prevent iOS text size adjust after orientation change, without disabling user zoom." [18:43:04] I saw it happening on our site [18:43:10] MaxSem that makes sense [18:43:33] MaxSem even though it's not strictly mobile specific, i am having a hard time thinking of when you'd want to use something like that out of the mobile context [18:44:19] meh [18:44:37] I'll merge if you change the function name [18:44:44] doing it now [18:45:22] oops [18:45:22] New patchset: awjrichards; "Bug 43123: force mobile URLs only for local redirects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [18:45:35] forgot to fix test case name [18:46:01] New patchset: awjrichards; "Bug 43123: force mobile URLs only for local redirects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [18:46:04] there we go, MaxSem ^ [18:48:32] New review: awjrichards; "i really don't want this happening every time i commit!" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43101 [18:50:20] New review: awjrichards; "you could make the pre-commit hook include some other pre-determined file that could be added to .gi..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43101 [18:58:23] New patchset: MaxSem; "Bug 43123: force mobile URLs only for local redirects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [18:59:10] tfinc: no hangout link for next meeting either [18:59:12] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42272 [18:59:30] fixed [18:59:43] alright [18:59:44] I just removed the mention of the bug in isLocalUrl() docs because it's not strictly related only to this bug [18:59:50] jdlrobson: can you give me an example of when i should see this in action? https://gerrit.wikimedia.org/r/#/c/42997/2 [18:59:57] MaxSem: reasonable [19:00:49] awjr: i can but not right now - you need to build up a language profile [19:00:58] >_< [19:01:04] details in https://gerrit.wikimedia.org/r/#/c/43002/2/javascripts/modules/mf-translator.js [19:01:27] localStorage.setItem( 'langMap', '{"en":400,"fr":400}') should do it [19:01:30] but i haven't' tested [19:01:41] (tested that line i just pasted - i did test the patch set :)) [19:01:52] then go to an article which doesn't have a french version [19:02:55] SickPanda: did you get the hangout link? brion: i'm set in r32 [19:03:15] be right there [19:03:56] SickPanda: just waiting on you? [19:04:09] tfinc: i don't see you [19:04:12] i'm in theh angout [19:04:26] New review: awjrichards; "Haven't been able to test, but looks sane." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42997 [19:04:34] SickPanda: this one https://plus.google.com/hangouts/_/99d441d84931f2044ce4ab32555d9d20091594ad ? [19:06:32] New review: JGonera; "Looks like a good start. Needs some UI fixes (probably should be styled like watchlist) and some way..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/43594 [19:11:29] tfinc: http://etherpad.wikimedia.org/android-commons-app-1-0 [19:20:16] hey brion [19:20:50] SickPanda: yo [19:21:12] hey brion [19:21:32] you've time to chat about iOS vs android work now? [19:21:34] on IRC [19:21:39] \o/ yes [19:21:53] sweet [19:22:03] brion: http://etherpad.wikimedia.org/android-commons-app-1-0 [19:22:16] SickPanda: brion: one item i forgot to mention was reviewing https://docs.google.com/document/d/1vTBGjRH1g95mZExkf7ZxNwO1uZxaFuNkn0a0uKlsoaE/edit [19:22:16] so that's what I want to do for Android [19:22:22] should i merge iOS stuff in with that or make a copy of the list [19:22:34] tfinc: thx [19:22:41] brion: let's copy that list down there, and do iOS? [19:22:48] let's keep it on the same pad and wiki it when done [19:22:48] it overlaps with a lot of what we've talked about and i'd like to get these volunteers invovled [19:23:49] SickPanda: now for android you presumably want 'send to' intents, that's not written down [19:24:07] brion: everything is Send To intents only [19:24:11] there will be no launcher [19:24:12] let me write that down [19:24:31] ah nice [19:24:57] we'll want a launcher for discovery in future though [19:25:10] but maybe not yet [19:25:20] brion: sure [19:26:34] for iOS we'll stick with foreground uploads for now; I may or may not be able to do background uploads but that's fancier stuff, have to do some more research on the background options for app lifecycle [19:26:54] iOS is much more aggressive about killing background apps, it's annoying [19:26:59] brion: indeed [19:27:01] no 'Services' [19:29:18] so if i'm showing a queue in the iOS app, a cancel capability seems sensible. i've put it on the list but could pull it if time requires [19:29:33] brion: i'll also note that i've a lot of code written for the android stuff :) [19:29:45] yeah, you're like almost done. ;) [19:29:46] 0, 1, 2 is mostly done, for example [19:29:53] my iOS app is….. much more primitive right now :D [19:30:03] 3, 4, 5, 6 are empty now ;P [19:30:22] brion: I'm considering putting up a 'my uploads' screen [19:30:31] but wondering if it should be for this iteration or next [19:30:39] that smells like something i want a launcher for [19:30:39] make it next [19:30:58] brion: or I could do that and add the launcher as well... [19:31:02] but yeah, that's a fair bit of work [19:31:14] hmmm [19:31:25] there's no way to actually do (4) nicely without doing that [19:31:32] no? [19:32:15] queuing multiple files? that shouldn't require a 'my uploads' screen, but it would help [19:33:01] brion: currently it sortof works [19:33:04] but you don't have any indication [19:33:06] that that is happening [19:34:00] brion: how about we release iOS today? lets say the afternoon [19:34:07] sounds good to me [19:34:27] lets say 1:30 .. right after lunch [19:34:50] brion: also, i'm debating about transferring the account to you so that i'm no longer a bottleneck. what do you think? [19:34:59] i wish i could just make you a co-admin [19:35:05] tfinc: works for me [19:35:09] yeah it's a pain [19:35:49] brion: http://slashdot.org/topic/cloud/firefox-os-smartphones-arriving-for-developers/ [19:36:09] \o/ [19:38:17] tfinc: another win https://twitter.com/w_faldo/status/293804721075019777 [19:38:47] jdlrobson: "Mobile Wikipedia. Its just better ... " [19:38:49] MaxSem: how do i get description url in http://localhost/w/api.php?action=query&generator=allimages&format=json&gaisort=timestamp&gaidir=descending&gaiuser=Jdlrobson&gailimit=10&prop=imageinfo&iiprop=url&iiurlwidth=200 [19:38:58] sorry description text [19:38:59] NOT url [19:39:56] brion: agent role transferred. no you'll be able to release the app today :D [19:40:05] \o/ [19:40:09] i'm trying to confirm it now :) [19:40:24] this doesn't remove the bottleneck but at least a dev on the team can do it [19:40:36] yay [19:41:25] brion: swap me to an admin please [19:41:55] it defaulted me to just a member [19:42:06] nm [19:42:08] i did it myself [19:42:08] heh [19:42:09] lolz [19:42:10] yay [19:42:18] you still got some power bits i guess :D [19:42:46] app release is here https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/wo/12.0.0.9.9.3.3.1.13.3.1.1.11.9.1.1.5.0 [19:43:46] tfinc: ok shall i push the button or wait a bit? [19:43:54] jdlrobson, description text? [19:44:11] if you can monitor then feel free to release. i only said 1:30 because i had/have meetings [19:44:32] ok i'll push zee button [19:44:37] brion: once you release send a tweet and monitor what people say like with all of our releases [19:45:00] MaxSem: e.g. http://commons.wikimedia.org/wiki/File:Lead_Photo_For_Pessimism0-8373815871309489.jpg I need the text "An pessimistic view of a glass of beer. Half of it is gone forever." from the summary [19:45:16] meh, it's not that easy [19:47:12] jdlrobson, first of all - expect a lot of descriptions like https://commons.wikimedia.org/wiki/File:Acueducto_de_Segovia_01.jpg [19:48:46] :/ [19:49:06] i'll have to talk to Maryana [19:49:21] so there's no sane way to do this ATM, even prop=extracts is not adequate for file description pages [19:49:29] you're not going to find descriptions that include a template like that via a mobile upload so much [19:49:55] Maryana, no guarantee that it will not be added later [19:50:21] +1 to {{Information}} being a complete clustersmeg [19:50:31] is that a big deal? [19:50:48] i just want to make sure mobile uploads don't get deleted because they have no description. [19:51:17] and it's *reaaaally* hard for new users to figure out how to edit a commons description on desktop after they've uploaded [19:51:25] hell, it's hard for experienced users :) [19:51:49] Maryana, ideally we should aim to use that template for our uploads [19:52:24] template is fine. as long as there's something there that tells the grumpy commons admin "don't delete me! i have a purpose!" [19:52:29] well it seems to be any description which contains wikitext you show a link saying "read description" [19:52:29] in principle, for a simple use cases https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&prop=extracts&format=txt&exlimit=10&explaintext=&titles=File%3ALead%20Photo%20For%20Pessimism0-8373815871309489.jpg [19:52:41] anything with plaintext you just print [19:52:57] just filter out the headings and whatever is not under a first heading [19:53:04] but MaxSem I'd have to do an ajax request for every single photo? [19:53:16] no, it's a prop module [19:54:31] ps, those in the office: user:isarra from english wikipedia is visiting & we're taking her out to lunch [19:54:42] train leaves the station in 5-10 minutes :) [19:54:55] * Isarra panics. [19:55:01] hehehe [19:55:03] Isarra, you should [19:55:24] MaxSem: Why? [19:55:40] it's Wikimedia!:P [19:56:52] Oh? [19:57:07] Isarra: are you panicking in the wrong channel? [19:57:18] tfinc: ok i pushed the release button, tweeted, and have tweet deck monitoring feedback and some searches for non-direct posts [19:57:25] woot [19:57:29] Is there a channel for panicking? [19:57:37] #wikimedia-panic [19:57:39] then we can close out the bug if we haven't already [19:58:02] * Isarra eyes Maryana suspiciously. [19:58:15] it's a trap!! [19:58:20] :) [20:07:31] New patchset: Zfilipin; "Removed line that does nothing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45179 [20:08:18] New patchset: Jdlrobson; "make mf-user-gallery.js only run on Special:DonateImage" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45180 [20:08:50] will monitor twitter during lunch :) [20:15:37] New patchset: Zfilipin; "PhantomJS needs some time for search resutls to appear" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45182 [20:17:16] MaxSem: are we done with http://etherpad.wikimedia.org/MFCommitGuidelines / [20:17:17] ? [20:17:56] awjr, no input from ppl, so I say it's done [20:18:07] any ideas where to move it to? [20:18:54] MaxSem: cool! how about to a subpage of http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web or on http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web/Team_norms [20:20:11] jgonera: is the JS organization/standards doc complete now? [20:20:47] awjr, I'd say the discussion is complete, I filed a few related bugs [20:21:05] but I will need to write a new one that actually contains guidelines [20:21:10] jgonera: excellent - can you move it or link to it from one of the pages i mentioned to max above? ^ [20:21:13] ok, makes sense [20:22:05] I'd wait until I write the next one I guess, I should see this week how things we agreed on with Jon work out in practice when working on photo upload [20:22:39] jgonera: ok cool - maybe link to it still and note it as a work-in-progress [20:22:42] tfinc: ping? [20:22:50] SickPanda: in a meeting [20:22:54] awjr, ok [20:22:56] oh, alright [20:26:29] brion-lunch: poke when available. Github administrative stuff! [20:26:36] New patchset: awjrichards; "when not logged in explain the watchlist feature" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [20:27:15] Change abandoned: Jdlrobson; "going to merge this into another commit instead" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45180 [20:27:43] mhm, am I the only one using HTTPS on WMF? [20:27:59] eh? [20:28:13] awjr, your links [20:28:26] oh :( [20:28:29] I should steal your cookies;) [20:28:33] SickPanda: whats up? [20:28:40] MaxSem: you can't, they're STICKY! [20:28:42] * tfinc ponders food [20:28:43] tfinc: rename https://github.com/wikimedia/aosp-morelang-ime to aosp-morelangs-ime [20:28:57] similar fix for https://github.com/wikimedia/aosp-morelang-ime-dictionaries [20:28:58] i wish we just did https everywhere all the time [20:29:01] i always forget [20:29:06] tfinc: also I need push access for wikimedia/java-mwapi [20:30:01] SickPanda: https://github.com/wikimedia/aosp-morelangs-ime [20:30:17] so: "aosp-morelangs-ime-dictionaries" ? [20:30:20] yes [20:30:33] SickPanda: https://github.com/wikimedia/aosp-morelangs-ime-dictionaries [20:30:57] which repot do you need push for ? [20:31:02] tfinc: wikimedia/java-mwapi [20:31:12] Moved to https://meta.wikimedia.org/wiki/Mobile_team/Mobile_web/Team_norms [20:31:15] tfinc: also, rename wikimedia/commons to wikimedia/android-commons [20:31:16] ? [20:31:29] tfinc: or you could just make me admin or something on github :P [20:31:42] yay thanks MaxSem [20:31:55] https://github.com/wikimedia/java-mwapi : done [20:32:23] https://github.com/wikimedia/android-commons : done [20:32:29] SickPanda: --^ [20:32:48] tfinc: also setup IRC notifications for java-mwapi and android-commons? [20:33:24] android-commons already has it [20:34:52] https://github.com/wikimedia/java-mwapi IRC : done [20:34:55] SickPanda: anything else ? [20:35:10] tfinc: nothing else for now :) [20:35:21] then i shall go get lunch [20:47:15] New patchset: awjrichards; "Fix fatal call to unknown function MobileContext::isLocalTarget()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45186 [20:47:23] MaxSem: ^ [20:48:39] ughhh [20:48:44] yeah :( [20:48:53] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45186 [20:49:35] New patchset: awjrichards; "when not logged in explain the watchlist feature" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [20:50:12] jdlrobson, jgonera i am seeing the following js error in master: Uncaught TypeError: Cannot read property 'length' of undefined [20:50:29] im seeing it in beta on regular pages [20:51:11] SickPanda: Hi! I'm beginning to work on a native Android app for Wikidata and I have two questions: [20:51:14] 1 Is there a clean way to import https://github.com/wikimedia/java-mwapi inside of my android project with something like git submodule instead of linking to a jar? [20:51:16] 2 Is it possible to share the Wikimedia account between apps in order to use the same account and login system as the commons app? [20:56:52] New patchset: awjrichards; "when not logged in explain the watchlist feature" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [20:57:02] jdlrobson: if the minor change i made in ^ looks good to you, im happy to merge [20:57:21] * jdlrobson looks [20:59:30] awjr: i'm seeing weirdness - "Please log in to view or edit items on your watchlist" [20:59:45] It should be alongside rest of text [21:00:09] jdlrobson: ok, that wasn't handled in that changeset [21:00:21] i think something probably broke in the redesign that happened since [21:00:24] i'll take a look at it later [21:00:42] is that a reason to not merge the changset? [21:01:05] New review: Jdlrobson; "The margin for "Please log in to view or edit items on your watchlist" seems to be disconnected from..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42271 [21:01:30] im fine either way, but what you're talking about seems diffrent than what i understood the objectives of that changset to be, but it's your change so whatever :p [21:01:48] i need to sit down with vibha anyway around watch list stuff for next iteration [21:02:02] jdlrobson: ok, but that story relates to *this* iteration [21:02:09] https://mingle.corp.wikimedia.org/projects/mobile/cards/307 [21:02:17] and it's been sitting in 'awaiting code review' for hella long [21:02:21] technically that's last iteration ;-) [21:02:25] i'd like to get it cleared out [21:02:26] exactly [21:02:32] it doesn't refer to when not logged in though [21:02:37] so this can be thought of as done [21:02:59] * awjr is confused [21:03:03] well "Given I am on either the read later or recent changes view of my watchlist" [21:03:09] my watch list implies you are logged in [21:03:19] When I have not watchlisted any pages Then I am show a message that instructs me how to do so. (Asset attached below.) - we have this [21:03:31] oh i see what you're saying [21:03:38] ok, that makes sense. can you update the comments then? [21:03:46] so moved it [21:03:50] because the latest comment points to the patchset you're wanting to punt on [21:04:43] Tpt_: hey [21:04:51] yes to both questions [21:04:58] git submodule works [21:05:05] but even better, I'm putting it on the maven repos right as we speak [21:05:08] so you can just use maven [21:07:14] SickPanda: Ok. Thanks. So I'll learn how to use maven. [21:07:25] yes! [21:10:58] Tpt_: also please do use ActionBarSherlock :D [21:11:48] SickPanda: Yes, of course. [21:12:02] Tpt_: and SlidingMenu :) [21:14:26] SickPanda: Ok. [21:19:17] [WikipediaMobile] brion created v1.3.4-Android (+5 new commits): http://git.io/iPf9wg [21:19:17] WikipediaMobile/v1.3.4-Android 8e7d8a9 Brion Vibber: bump version to 1.3.4 [21:19:17] WikipediaMobile/v1.3.4-Android 637d28a Brion Vibber: * (bug 42967, 42968, 42970, 42971) Add terms of service and privacy policy links to page footer in app... [21:19:17] WikipediaMobile/v1.3.4-Android 6fc81a5 Brion Vibber: fix stupid debug left in line [21:19:49] awjr, sorry, forgot to set afk, where do you see this error? [21:19:58] jcmish: want to do any testing of android release 1.3.4? it should be same as 1.3.3 but with the new terms/privacy links [21:20:01] Project WikipediaMobile - Nightly builds build #489: SUCCESS in 22 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/489/ [21:20:09] jgonera no worries; on regular articles [21:20:10] in beta [21:20:11] yep [21:20:14] can do [21:20:25] pont me to the apk and I'll get it going [21:20:30] ok lemme push the apk up [21:20:40] kayo [21:20:49] gotta sign it first [21:21:11] SickPanda: Thanks for these recommendations. I'll learn how to use maven and these libaries (I'm a newbie in Adnroid development). [21:21:17] Tpt_: :D [21:21:37] jgonera it seems fine in non-beta [21:21:51] awjr, trying to replicate that [21:23:39] awjr, is it fine in alpha? [21:23:55] also, what browser? [21:23:59] jgonera: no [21:24:02] jgonera: desktop chrome in os x [21:24:24] awjr, weird, I'm not getting it [21:24:32] (English Wikipedia) [21:24:37] jgonera: i am getting it in firefox too [21:24:44] jgonera: oh, sorry - the problem is in master [21:24:58] not in production [21:25:00] (afaik) [21:25:02] I also checked master, not getting it either [21:25:12] jgonera: did you clear cache/etc? [21:25:20] dynamically loaded articles or full page load? [21:25:26] I have cache disabled in Chrome [21:25:27] is anyone else seeing this problem against master? ^ [21:26:02] jgonera: i see it in both dynamically loaded pages and regular page loads [21:26:26] jgonera: your master is up to date? [21:26:28] which file/line? [21:26:33] yes, just pulled [21:26:53] TypeError: langlinks is undefined [21:26:53] http://virtualbot.com/testing/core/extensions/MobileFrontend/javascripts/common/mf-history-jquery.js [21:26:53] Line 59 [21:26:54] jcmish, SickPanda: https://www.dropbox.com/s/wbvnev3kqw4107n/Wikipedia-v1.3.4.apk [21:28:08] jgonera: is it possible that that's happening because i dont have languages configured or something? [21:28:15] kayo [21:28:23] give me one sec and I'll get started [21:28:39] thx [21:28:58] I'm not sure, jdlrobson worked on language links not long ago [21:30:42] awjr: it sounds like your branch got dirty [21:30:54] jdlrobson: im using master [21:30:58] 1s [21:31:09] and as far as i can tell it should be OK [21:31:11] awjr: have you got RL enabled ? [21:31:20] are you seeing this in beta/alpha/stable [21:31:26] see what console.log(resp) shows in L135 [21:31:27] and what article are you seeing this issue on? [21:31:40] also add debug=true to ensure you have a clear cache [21:31:54] jdlrobson: like i mentioned earlier, beta and alpha and im seeing it on /every/ article, and i am using debug=true. [21:32:09] it looks like the problem is around line 136 of mf-history-jquery.js [21:32:15] langlinks = pages[0] ? pages[0].langlinks : []; [21:32:24] langlinks is getting set to undefined for me [21:32:40] ok, I reproduced it [21:33:25] oh and i do have RL enabled [21:33:56] awjr: it looks like another beautiful example of how our api needs work [21:34:03] ok, it happens when an article has no alternative languages [21:34:20] good catch [21:34:31] heh, i didn't do much :) [21:40:29] New patchset: JGonera; "Fix JS error on pages with no alternative languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45240 [21:43:38] looks good, jgonera, thanks [21:43:48] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45240 [21:44:01] no problem [21:48:27] SickPanda: whats your graduation day? [21:49:20] tfinc: I'm not sure. My exams end in April / May (not scheduled yet) [21:49:31] there is no set date for when the results are out [21:49:36] usually Jul / Aug [21:49:53] its that loose ? [21:51:10] tfinc: yup [22:03:15] MaxSem: do you know anything about the 'mfsecure' cookie that gets set in MobileContext::checkUserLoggedIn()? [22:03:26] why does that exist? [22:03:58] it doesnt appear to be used anywhere else [22:07:08] awjr, I thhhhink it was used in the aborted attempt at mobile login [22:07:29] oh back in the day? [22:07:36] i wonder if it's safe to get rid of [22:07:44] brion dumb question [22:07:54] jcmish: ? [22:07:55] it the licensing change down in the footer? [22:08:04] yeah scroll down to bottom of article, should be there [22:08:12] cool and I'm poking around searching etc [22:08:29] but wanted to make sure I touch around there :D [22:08:31] awjr, it should be [22:08:41] :D [22:12:08] brion: SickPanda : i'm likely going to stick around late today. even if the feature list is interim put it up. otherwise ill do it tonight ;) [22:12:32] tfinc: http://etherpad.wikimedia.org/android-commons-app-1-0 [22:12:39] ok [22:12:51] tfinc: has for both iOS and Android [22:13:42] SickPanda: looks fine as a start. lets move it to the wiki and i'll rev on it tonight [22:13:55] tfinc: have a spot in mind? [22:13:58] wiki, that is [22:14:34] yeah that mfsecure code was introduced a loooonnnggg time ago [22:15:00] SickPanda: mw [22:15:20] mw where? [22:16:20] SickPanda: how about http://www.mediawiki.org/wiki/Apps/Commons ? [22:16:28] or ... [22:16:28] doing [22:16:38] we could just make a new project page fo rit [22:18:41] ala http://www.mediawiki.org/wiki/Wikimedia_Engineering/Project_documentation_howto [22:18:48] either way get it up on mw.org and we can move it later [22:20:48] New patchset: awjrichards; "Removes unneeded MobileContext::checkUserLoggedIn()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45245 [22:21:07] SickPanda: brilliant [22:22:12] New patchset: Jdlrobson; "Update upload page (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45247 [22:22:13] New patchset: Jdlrobson; "make alert styling available outside overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45248 [22:22:13] New patchset: Jdlrobson; "add MobileContext method to allow adding classes to #content_wrapper" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45249 [22:22:25] New patchset: Jdlrobson; "change upload position/logo in menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45250 [22:24:07] tfinc: alright [22:25:51] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42997 [22:27:38] awjr: jgonera if you could review https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:upload3,n,z that would be most helpful (maps to one of the stories in this iteration) - it's not complete but this removes much of the work needed to complete that story and hopefully you can see it heading in the right direction [22:29:33] hmm jenkins barfed on one of those patchsets [22:29:41] although the error doesnt look like it's related to anything in the code [22:29:46] https://integration.mediawiki.org/ci/job/mwext-MobileFrontend-lint/952/console [22:30:03] i wish there was an easy way to get jenkins to rerun [22:30:11] anyway, i can take a look later [22:30:12] ergg [22:30:26] i was just saying to juliusz it would be nice to be able to tag patch sets that are not vital for the iteration [22:30:32] i think -1 is the only way i'm going to be able to do this :/ [22:30:32] New patchset: Zfilipin; "Removed duplicate code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45252 [22:31:20] as long as you remember to take away the −1 later :p [22:31:27] that's a good way to get smoeone to not look at a patchset [22:32:49] jdlrobson: do you have a second to chat about https://bugzilla.wikimedia.org/show_bug.cgi?id=43909 [22:34:25] yes awjr [22:35:00] im scratching my head trying to think of an alternate way to handle remembering the page that was requested to be watched [22:35:28] and im not really thinking of anything good aside from a) trying to figure out why we can't pass query params and fix it or b) implementing the solution in the stackoverflow link you posted in the bug [22:36:21] we can try a cookie but i dont really want to do that as it's yet another thing to vary the cache, which is lame [22:36:56] do you have any other thoughts/ideas on the matter? [22:37:15] my inclination is to try and tackle (a) first [22:40:38] awjr, it was ea56338b243d9076f09474de37f7e93e4486f6fd [22:40:52] "set mfsecure cookie if user is logged in" [22:41:05] nice MaxSem, i got tired of looking :p [22:41:17] git bisect rules [22:41:22] :) [22:41:26] New patchset: Zfilipin; "Renamed "and" steps to appropriate given/when/then steps" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45253 [22:42:08] jdlrobson: if i can fix a), that means that the memory of watchlist tap won't go beyond the loading of the login screen, but i think that's ok - and it would be simpler/less ugly than implementing the local storage hack [22:43:46] awjr: over my dead body will we bastardize a get request :P - I keep meaning to read up on the subject - it must be a common problem in the js world [22:43:56] it's worth noting the cookie would be temporary if we went down that route [22:44:02] we can clear it as soon as the login has completed [22:44:15] we can give it a short lifetime as well [22:44:31] jdlrobson: but the cookie will still cause cache variance, reducing our abysmally low cache hit rate already [22:44:40] what do you mean 'bastardize a get request'? [22:44:41] surely not by much? [22:45:14] the only time it is going to be set is from clicking the star when logged out and clicking the login link to the completion of a login/create account [22:45:48] what if the user doesn't actually login? [22:46:10] how long would we keep the cookie for? [22:46:26] I say no longer than 24h [22:46:29] awjr: bastardizing = http://en.wikipedia.org/wiki/Idempotence [22:46:33] i'd say 1hr tops awjr [22:47:14] if we do a cookie…i think 1hr is even too long [22:47:27] how many people are tapping that star right now? [22:47:38] as non-logged in users? [22:48:11] also, how is indempotence 'bastardizing a get request'? [22:48:37] awjr: GET requests should have no side effects whatsoever [22:49:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45245 [22:49:08] To give a concrete example of why this is bad.. [22:49:09] jdlrobson: define 'side effects' [22:49:16] I own a company XYZ Ltd [22:49:24] I want to raise awareness of that company which happens to be on wikipedia [22:49:27] jdlrobson, https://en.wikipedia.org/wiki/Dogmatism :P [22:49:57] I add a link on a website which exploits this hole in our software and forces the XYZ Ltd article to be watched [22:50:39] A reader now wondering what this is doing on her watch list clicks it and is now aware of XYZ Ltd and feels somewhat confused to how it got there as to their knowledge they have not done anything to get it there [22:50:50] awjr, can't we set the cache to ignore some cookies? [22:51:12] jdlrobson, this functionality is here, whether you want it or not [22:51:58] i see your point jdlrobson, but that is already exactly how things work [22:52:13] awjr: but that's not how they should work and it's not future proof [22:52:25] it is [22:52:40] action=watch isn't going away any time soon [22:52:53] jgonera: i'll need to dig, but in theory i believe the answer is eys [22:52:55] *yes [22:53:18] that is actually worth looking into more closely [22:53:28] awjr, I guess this would be a good solution and could possibly be used for other things in future [22:53:53] jgonera: indeed [22:54:11] we're talking about varnish here, right? [22:54:18] right now i think we just blindly vary on all cookies [22:54:20] jgonera yes [22:54:31] i believe we can control that in the vcl [22:54:58] I imagine there should be a way of configuring varnish to ignore cookies with certain prefix/suffix or maybe even expiry date [22:56:02] varnish config is insanely flexible [22:57:04] New review: Cmcmahon; "I'd prefer to see the check remain, s/be_true/exist/. I think it is a reasonable test." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45179 [22:57:18] [Commons-iOS] none pushed 3 new commits to master: http://git.io/58BHkw [22:57:18] Commons-iOS/master f7f585a Brion Vibber: README [22:57:18] Commons-iOS/master 9913f60 Brion Vibber: Use Keychain to store username/password.... [22:57:18] Commons-iOS/master 0ec4f01 Brion Vibber: readme update [22:57:30] whee [22:58:36] awjr, yeah, I hoped it would be, http://serverfault.com/questions/195654/how-to-cache-websites-using-varnish-php-and-cookies, http://opensourcehacker.com/2011/11/16/varnish-caching-and-http-cookies/ [22:59:14] thanks jgonera, i will take a look [23:06:12] tfinc_: brion https://www.mediawiki.org/wiki/Apps/Commons [23:06:28] brion: so, android one is android-commons [23:06:33] but this is Commons-iOS? [23:06:34] tch tch [23:06:35] :P [23:07:14] i think if the cookie were only ever handled in JS (eg we never cared about the cookie server-side), we could unset it in the request when it's received by varnish, so it wouldn't affect caching, jgonera, jdlrobson [23:07:35] SickPanda: :P [23:07:43] naming conventions are for people who like consistency [23:07:52] haha [23:08:51] brion: I need to decide if we're going to have a concept of a 'wikimedia account' [23:08:57] and if we do, which app to put that in [23:09:18] awjr, I guess this would work [23:09:18] *nod* [23:09:20] brion: obvious solution is to have a 'wikimedia' app that does nothing but stores credentials... [23:09:27] and in the future does notifications [23:09:31] it'd be easier if there were some dependency system that would pull in the central service [23:09:35] rather than making people go install it [23:09:46] brion: there... isn't. [23:09:52] yeah [23:09:59] well on iOS i can't even share data between apps, so feel lucky ;) [23:10:00] you can lead the horse to the play store, but you can't install it for them [23:10:24] i hadn't realized this before but it appears that the mere act of opening the settings page causes a session cookie to get set [23:11:48] brion: I'm unaware of any other app that has this need [23:11:50] hmm, google perhaps [23:11:54] * SickPanda digs into his phone [23:12:28] oh it's because of the form token [23:13:01] yeah google just controls the platform so their signin bit is always installed ;) [23:14:30] brion: I'm very much leaning towards a 'Wikimedia' app [23:14:46] it can handle accounts for now [23:14:49] eventually a lot more? [23:14:58] like, settings + global watchlists [23:17:25] alrighty brion and SickPanda Testing on 1.3.4 looks great [23:17:58] ran through 2.2, 2.2.1, 2.3.3, 2.3.4, 2.3.6, 4.0, 4.1.1, 4.2 [23:18:00] all passed [23:18:23] I did searches, nearby, saved pages and click on the license and privacy changes [23:18:27] w00t [23:18:31] push it out brion [23:19:30] \o/ whee [23:19:38] thanks jcmish [23:20:11] you bet [23:20:59] brion: thoughts on the 'wikimedia' app? [23:21:40] SickPanda: i'd be inclined to put a central one into the wikipedia app, as it's the most likely people are to install in the first place [23:21:49] yeah, makes sense. [23:21:55] but I don't want to do that with the current wikipedia app [23:22:31] mmmmm true [23:23:55] awjr: sorry just had to have a walk. I have another solution thanks to ori-l for the watch list dilemma [23:24:04] ok pushed [23:24:06] jdlrobson: sweet tell me more [23:24:09] we can do the actual watch action on the server side [23:24:29] so concretely we add a hidden input field to the login form that triggers a post login hook that adds the article to the watchlist [23:25:04] that makes sense [23:25:20] brion: alright, I'm going ot leave it in this one now. When we do the Wiki app, we can switch to that pretty transparently [23:25:30] or use this one as a fallback [23:25:32] should be fine, I think [23:25:39] spiff [23:25:50] jdlrobson: that is actually probably pretty straightforward [23:25:58] exactly [23:26:32] and it keeps me happy - i know i'm fussy but I just don't like it when we go against standards because it's the easiest option [23:26:47] ok, i think that's the best approach for now and i can get started on it [23:27:02] sweet thanks awjr for putting up with me :) [23:27:02] jdlrobson: it's good :) [23:27:19] jdlrobson: but sometimes mediawiki standards != the rest of the world's standards :p [23:27:31] and by sometimes i mean usually [23:27:43] awjr: i know but i think we should push back against those and try to become more inline with the world's standards [23:27:54] it encourages bad development practices [23:28:13] i generally agree with you on that but i think we need to be careful about drawing to hard a line [23:28:16] brion: i've also setup 'my current uploads' for android, which is much simpler than 'my uploads' [23:28:17] *too [23:28:58] tfinc: I think the android parts of https://www.mediawiki.org/wiki/Apps/Commons#Features are fairly stable. [23:39:42] http://www.flickr.com/photos/psd/1805709102/sizes/o/ awjr - in case you haven't seen it [23:40:04] tfinc: would be cool to get one of those printed for the office :) [23:41:14] that is rad [23:42:54] New patchset: Zfilipin; "Fixed failing iOS tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45266 [23:43:27] [java-mwapi] yuvipanda pushed 5 new commits to master: http://git.io/W67RSg [23:43:27] java-mwapi/master e5b48a1 YuviPanda: Add IDEA specific files... [23:43:27] java-mwapi/master 29ab9fb YuviPanda: Mavenized everything... [23:43:27] java-mwapi/master 1665846 YuviPanda: Removed .idea files from the repo [23:45:20] i have an interesting candidate for generalist. who's up for talking with him about both js+php ? [23:45:41] New review: Jdlrobson; "I just realised that this won't work - localStorage is different on different sub domains. So if you..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43002 [23:45:47] just enough to know if we should fly him in [23:46:16] awjr: MaxSem jgonera jdlrobson --^ [23:46:26] I could ask the PHP part [23:46:41] when would that be? [23:46:44] New review: Jdlrobson; "The patchset this is dependent on will not work so although the code is fine in this patchset is fin..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43003 [23:46:45] it'd be good to do a light version of both [23:46:48] tfinc: any reason we can't have two people do it? [23:46:49] sometime this week over the phone [23:47:02] tfinc, google hangout mebbe [23:47:04] ? [23:47:43] jgonera: what about you and someone else? your the closest we have to a generalist now [23:47:56] I actually ran my last interview over voice only and I didn't like it. too little feedback [23:47:59] if you want to avid scheduling two different screens, maybe just have one session with two folks interviewing [23:48:15] jgonera, let's tag team him:) [23:48:24] tfinc, fine for me I guess, the only thing I'd like to know at least a day before is his GitHub/BitBucket/whatever account [23:48:39] s/his/their/ ;) [23:48:39] that makes sense [23:49:07] jgonera: have you done an interview with us before ? [23:49:17] *led* [23:49:22] no [23:49:30] I only know the other side [23:49:39] ok. then we'd need to pair you with someone [23:49:45] * MaxSem  [23:50:04] tfinc MaxSem offered to tag-team above [23:50:18] eastern european tag team [23:50:32] what's the candidate's timezone? [23:50:34] i can see the WWF special now [23:51:06] MaxSem: remember. this is to find out if his tech chops are worthy to fly thekm out. not to destroy them [23:51:12] their in the USA [23:52:18] ;) [23:54:56] mommy, they're not permitting me to be a maniac! [23:55:33] hahaha [23:55:59] New review: Cmcmahon; "this is the best bug/bugfix I've seen in I don't know how long" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45266 [23:59:43] jcmish etc ^^ check out Zeljko's fix for iOS automation bug :) [23:59:52] I know [23:59:55] I was working with hin [23:59:57] *him