[00:00:08] did you look at the video you can SEEE the shoe! [00:00:15] I told him I thought I was seeing things! [00:00:22] I have not. I can see it in my mind's eye :) [00:00:48] i think the QA folks have been drinking some kool-aid [00:00:50] New review: Jdlrobson; "Ignore jenkins. It's moaning about something being wrong that isn't!" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45248 [00:01:04] https://saucelabs.com/tests/9cfbf395848a47808cb14ee692bdeb82 [00:01:20] Maryana: is vibha free? if so i'm coming up\ [00:01:49] awjr: Željko:  I think the android test is passing because the verification is not good [00:01:49] it never goes to san francisco chronicle page [00:01:49] and "send_keys :enter" iOS interprets as a shoe [00:01:49]  me:  aha! [00:01:49]  Željko:  :return is a t-shirt [00:01:51] * chrismcmahon <3 SauceLabs. sometimes you can't believe it until you see the video [00:02:06] ha! I thoughly entertained [00:02:36] chrismcmahon: jcmish any idea why jenkins spat its dummy out on https://gerrit.wikimedia.org/r/45248 ? Also I can't seem to be able to re-trigger tests anymore for MFE like I used to - did the UI change? [00:02:48] brion: any word from the internet about v3.3 ? [00:03:06] tfinc, does Asher interview everyone nowadays? [00:03:29] tfinc: a couple rewtweets, one person glad to see landscape mode :) [00:03:35] no problems reported [00:03:53] MaxSem: yes. partner. [00:04:21] jdlrobson: not sure, but come on up [00:04:22] jdlrobson: not our jenkins but 22:22:45 stderr: error: refs/remotes/origin/master does not point to a valid object! 22:22:45 error: Trying to write ref refs/heads/master with nonexistent object 41573bef1eefa47f6dda1cde8d110f88caf52884 22:22:45 fatal: Cannot update the ref 'HEAD'. [00:04:23] * SickPanda navigates around javaland [00:05:01] tfinc, ok. I asked cause I need to know how much time to dedicate on scalability [00:05:22] now I can leave most of this to him [00:06:08] chrismcmahon: ok.. any idea how i can retrigger that test to see if it was a blip? [00:06:47] jdlrobson: not off the top of my head. Krinkle maybe? ^^ [00:07:01] jdlrobson: i think she's about to step out, actually, but she says she'll be back a bit later [00:09:23] Krinkle: let me know when I can bug you and take advantage of you being in the same room for once :) [00:09:29] Maryana: yup she just mailed me [00:10:38] jdlrobson: Just saw this yeah I don't think we access to kick it off [00:10:46] :( [00:10:51] I was gonna say one of the IT guys :( [00:13:17] SickPanda: brion: did you guys get your first feature pass on the wiki ? [00:13:31] jdlrobson, jcmish hashar or ^demon most likely [00:13:33] tfinc: I pinged you the link a while ago [00:13:34] tfinc: https://www.mediawiki.org/wiki/Apps/Commons [00:13:37] and yeah, maybe Krinkle [00:13:41] nice [00:13:44] tfinc: the stuff at https://www.mediawiki.org/wiki/Apps/Commons#Features or? [00:13:54] that work for now [00:13:59] i'll fold it into a project page [00:14:03] hashar is OOO for a while [00:14:09] tfinc: awesome [00:14:15] I'm running to pick up the kidlet back in a little [00:15:36] jdlrobson: also, i bet if you make a random change, git commit —amend and resubmit for review it will trigger jenkins again [00:15:46] you could even just slightly modify the commit message [00:15:49] awjr: sure.. i didn't want to get messy though [00:16:01] jdlrobson: jenkins already did that for you :p [00:16:07] (all dependent patch sets would need updating to) [00:16:28] oh right [00:16:31] blech [00:16:31] so awjr MaxSem I'm considering rewriting the donate page in php [00:16:44] the donate page? [00:16:49] are you working for fundraising now? [00:16:50] donate image page in alpha [00:16:55] ohh [00:17:01] that language is very confusing to me [00:17:04] this is gonna be so much fun :P [00:17:06] soon to be known as uploads dashboard [00:17:06] https://mingle.corp.wikimedia.org/projects/mobile/cards/328 [00:17:18] yeah that makes sense [00:17:18] hmmm, I should start calling it the Commons Donate app perhaps :P [00:20:10] 'donate' has such fiscal connotations… is it actually more effective at getitng people to upload photos than saying 'upload an image' or whatever? i would think it's more confusing to people, but i am not a good litmus test for what most people think/do [00:21:48] Maryana: ^ [00:22:20] donate has really strong fundraising connotations [00:22:44] we should explain to people in various ways that they're donating their images, but when it comes to what to put on the button, we should be more clear than that [00:23:06] my 2 pence [00:23:08] i concur [00:23:09] SickPanda: the only problem with the vim plugin for chrome is that when i think i'm in an editor/irc/messenger/whatever and i start typing a message/code/etc, but im actually still in chrome, weird things happen [00:23:25] ? [00:23:32] like you think you're in edit mode but you aren't? [00:23:44] hehe yeah [00:24:08] and it usually takes me a sentence's worth of keystrokes to realize wtf is going on [00:24:42] heh [00:24:48] it's a bit awkward about that, yeah [00:25:54] awjr: there's also vimperator, which is a much more full featured firefox plugin [00:26:31] cool, i generally don't use firefox much tho [00:26:44] i still like the vim plugin for chrome like crazy :) [00:27:00] awjr: :D [00:27:04] awjr: contribute to it! :D [00:27:13] :D [00:28:36] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/1uRQPw [00:28:36] Commons-iOS/master 296e024 Brion Vibber: XML -> JSON... [00:28:52] JSON turns out to be easy on iOS 5+ [00:28:55] brion: haha [00:28:57] nice [00:28:58] built-in library to deserialize into an array [00:29:04] it'll never be easy in Java :( [00:29:07] heh [00:29:12] also I just found out that default XPath is slooow [00:29:17] and i'll need to figure a fix out sometime [00:29:21] works for now though [00:29:22] heh [00:29:23] (in Java) [00:29:50] brion: for android, all the current java HTTP libs sucked (sortof), so I had to take an abandoned one and add more features to it [00:29:51] :( [00:29:57] fuuuuun [00:29:57] it's pretty neat now, of course [00:35:12] SickPanda: is JSONLib just too horrible for nested stuff? [00:35:18] looks like it would be a bit verbose [00:35:20] brion: the casts [00:35:22] zomg the casts [00:35:26] i first started out using it [00:35:31] and implemented java-mwapi [00:35:35] and then as I wrote the tests [00:35:39] json.getJSONObject('login').getString('token') [00:35:46] vs json.login.token (JS) [00:35:56] or json[@"login"][@"token"] (obj-c) [00:36:31] brion: hmm, I was using json-simple [00:36:39] and it was casts after casts after casts [00:36:46] ew [00:37:04] android seems to ship with the json.org JSONObject - http://developer.android.com/reference/org/json/JSONObject.html [00:37:06] jdlrobson: awjr: What's up? [00:37:14] if you just use .get() you'll have to cast everything [00:37:17] Krinkle: just a little issue we had with jenkins [00:37:22] but it has per-type methods which don't look too awful [00:37:31] jdlrobson: k, anything in particular? [00:37:40] https://gerrit.wikimedia.org/r/45248 < Krinkle not sure how to rerun it and what went wrong [00:37:42] wish you could just use an array operator [] in java :) [00:38:08] brion: I didn't notice that - I wrote java-mwapi to be generic java, so missed this [00:38:10] It says: 22:22:45 ERROR: Error cloning remote repo 'origin' : Could not clone /var/lib/zuul/git/mediawiki/extensions/MobileFrontend [00:38:23] jdlrobson: When was this jenkins job created? Did it work before? [00:38:32] brion: either way, I think XPath leads to easier code as far as java is concerned [00:38:41] your choice :) [00:38:47] brion: your opinion? [00:38:58] i'm not sure - it just failed on this one for some reason [00:38:58] getJSONObject('login').getString('token') [00:38:59] as long as it works, doesn't much matter either way [00:39:06] vs .xpath('/login/token') [00:39:15] okay, so `/var/lib/zuul/git/mediawiki/extensions/MobileFrontend` does exist on gallium [00:39:20] New review: Krinkle; "recheck" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45248 [00:39:26] lets see if it works noe [00:39:29] i wanted to re-trigger it to see if it was a blip but i seem to have lost the ability to re-trigger the test [00:39:34] the xpath will be more expensive because it has to parse the query, but it's unlikely to be criticial-path stuff [00:39:46] Krinkle: does replying recheck automatically re trigger now?! (that's cool) [00:39:51] yes [00:40:02] sweet - that was the missing piece of information :) thanks for helping! [00:40:07] yw [00:40:09] where are you btw [00:43:56] * SickPanda grrs at maven [00:55:09] [java-mwapi] yuvipanda pushed 1 new commit to master: http://git.io/Fg_EvA [00:55:09] java-mwapi/master b22c28f YuviPanda: Added maven dependency to http-fluent [01:00:28] Krinkle is that nugget of very useful information documented anywhere? (re forcing jenkins to rerun) [01:01:27] ok. http-fluent mavenized, request filed for org.wikimedia [01:01:30] for java-mwapi [01:01:31] all good [01:01:33] good night everyone :) [01:16:56] awjr: don't know, maybe hashar knows [01:17:01] (he implemented it) [01:18:18] New patchset: JGonera; "Add M.define() and M.require() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [01:35:37] SickPanda: how are you still awake ? [01:39:12] tfinc: I sent two email out to ask about wedding photographers I'll let you know when I hear something back [01:39:31] preilly: i really appreciate that. thank you. [01:39:36] tfinc: np [01:40:15] tfinc: this is one of them http://www.rileymacleanweddings.com/ [01:40:34] better link: http://rileymacleanweddings.com/filter/wedding [01:43:02] preilly: lots of nice ones there. im enjoying them [01:43:43] tfinc: you could try emailing riley@rileymaclean.com as well [01:43:46] ok [01:45:50] tfinc: here is a Facebook link as well https://www.facebook.com/pages/Riley-MacLean-Photography/340459630952 [02:15:33] awjr: talked with robla [02:15:45] awjr: he's feeling pretty good that we could deploy by thursday [02:24:46] New review: Jdlrobson; "looks good i'd like to see it in use though before merging! (I suspect that is coming..?)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45284 [05:15:51] SickPanda: why you not sleep? [05:17:47] notnarayan: let's do it here [05:17:58] SickPanda: yes. [05:18:02] notnarayan: yeah, no app launchers I think [05:18:08] don't see a need for them this time? [05:18:21] unless, we want to have a mini-tutorial of sorts? [05:18:35] SickPanda: with my uploads and other categories, well need an app [05:18:49] there's no my uploads for this [05:18:52] only my current uploads [05:18:57] will show up when you tap the notification [05:18:58] SickPanda: a mini tutorial, we can do it the first time the user decides to share on commons [05:19:19] SickPanda: 8. is my uploads [05:19:54] notnarayan: again, as I said, it is my current uploads [05:19:55] not my uploads [05:20:01] only the files that are currently uploading [05:20:09] SickPanda: i see [05:20:15] SickPanda: we can do a tutorial like http://www.archer-group.com/wp-content/uploads/2011/02/Pulse1-320x480.jpg [05:20:31] works [05:21:18] SickPanda so will the currently uploading stay in the generic gallery or an app? [05:21:27] notnarayan: gallery [05:21:36] workflow still starts from camera or gallery [05:21:37] no launcher [05:22:15] SickPanda: can an image in the gallery have a lil commons icon, to suggest that it has been uploaded to commons [05:22:50] SickPanda: also, i can do this icon in such a way that it also changes color so as to suggest progress [05:22:58] nope [05:23:17] no control over anything inside gallery itself [05:25:07] SickPanda: did you see the mockup i sent you yesterday [05:25:11] yes [05:25:26] seems out of scope for this release? [05:25:33] SickPanda: i was wondering if you could pull the image of the day [05:25:34] yes [05:25:47] yes, we could. FeaturedFeeds, etc [05:25:51] SickPanda: well i was looking at my uploads :) [05:25:53] but not for a while. [05:25:56] SickPanda: nice :) [05:26:08] SickPanda not for 4th feb [05:26:10] next up would be my uploads, and then I think the campaigns stuf [05:26:10] f [05:26:32] SickPanda: sounds good [05:26:33] and let's think about them when that turns up :) [05:26:38] hello tfinc [05:26:47] SickPanda: how are you awake already? [05:27:02] tfinc: I'm trying to switch to slightly more normal people hours. [05:27:04] futile, I know [05:27:06] but still [05:27:23] what can a panda do but try? [05:27:28] been scheming with notnarayan [05:27:36] tfinc: hello! [05:28:13] SickPanda: so, tell me about #4 [05:28:42] notnarayan: so, that ties into 8 [05:28:42] do tell [05:29:05] when upload fails, it shows up there with a failed indicator [05:29:07] and you can hit retry [05:30:06] SickPanda: can we do anything within the gallery? [05:31:49] nope [05:31:50] SickPanda the failed indicator would be a notification [05:32:08] so [05:32:21] currently there is one notification showing for each upload [05:32:39] but since there is no more than one upload happening at one time [05:32:46] I'd want to move to a dropboxy type model [05:32:52] where we have one notificiation [05:32:57] which goes 'uploading 1 / x' [05:33:11] SickPanda: and then says, 3 uploaded 4 failed [05:33:14] tapping that shows you current uploads [05:33:26] yes [05:33:37] so these are persistent ongoing notifications [05:33:52] when an upload fails, we'll also show a new notification (per failure) [05:35:09] ok, tapping that would open the generic gallery [05:35:47] SickPanda: can you send me the current upload app [05:37:55] notnarayan: no builds yet, let me set that up [05:38:15] notnarayan: no, the failure notification will also just open up the my uploads screen :P [05:38:53] SickPanda: I'm a lil confused where this my uploads is placed. :P [05:38:56] if an upload fails due to a network error, it cancels all uploads coming after it [05:39:14] notnarayan: it's just 'list of currently uploading files' [05:39:25] SickPanda: ah, i seee [05:39:27] when the notification says '1 / 10' [05:39:29] it lists the 10 [05:39:30] SickPanda: got it. [05:39:34] its a list. [05:39:36] yes [05:39:41] of currently uploading files. [05:39:50] SickPanda: so, thats 4+8 [05:40:02] yeah [05:40:15] 4, 5, 6, 7 depend on 8 [05:40:21] SickPanda: :) [05:41:36] SickPanda: ping me before you crash, I'm doing the mini tutorial page right now. will send you the image in a bit. [05:41:48] notnarayan: i slept and woke up sir :) [05:41:52] SickPanda: what are the other tasks i have at hand [05:41:56] SickPanda: lies. [05:41:59] honest [05:42:01] i slept for 4 hours [05:42:37] SickPanda: come to bhutan, i have some fresh Darjeeling tea [05:42:52] drinking tulsi ginger tea right now :D [05:43:05] notnarayan: will be there soon! [05:47:09] SickPanda: looking at the list, what else do i have on my plate [05:48:07] notnarayan: I think 'current uploads' only [05:48:29] SickPanda: current uploads and the mini tutorial. [05:49:14] notnarayan: hmmm, ok [05:49:37] eventually we're going to need a bigger tutorial on what is acceptable and what is not in commons [05:49:47] you'll probably have to work with Maryana, etc for tha [05:49:49] t [05:49:53] not for this iteration, of course [05:52:25] SickPanda: you 'are' coming tom. [05:52:29] notnarayan: yeah [05:52:30] i am [05:52:40] hopefully catch a morning bus [05:52:53] SickPanda catch tonights bus [05:53:09] SickPanda: so you 'sleep' on the bus [05:53:10] hmmm [05:53:28] possible if I work all day and then just send in status update [07:17:49] SickPanda: are you around? http://cdn.dropmark.com/16089/2a10873e4aa23f4897843f23ae86c66eb87e713c/mini-help.png [07:18:02] looking [07:18:04] SickPanda: just to get an idea. :) not final [07:18:25] other than the confusion over donate vs upload [07:18:32] and the fact that I can't properly read the font [07:18:34] looks great :) [07:18:40] :) [07:19:02] SickPanda: ill choose a better typeface for this. this one is a lil think [07:19:04] *think [07:19:08] *thin [07:19:20] make sure it is a free font, etc [07:19:28] SickPanda: of course :) [07:19:44] SickPanda: also, the user would see this the first time he hits upload. [07:20:13] yup [07:20:15] me likey [07:20:28] I'll have to write code for this [07:20:35] because text will have to match [07:21:02] SickPanda so, its something like this http://cdn.dropmark.com/16089/867da6f81cbd749357e44391220ba4d4cf34187b/upload.png [07:21:11] SickPanda: let this be an image [07:21:19] won't work [07:21:23] multiple screen sizes [07:21:26] multiple screen resolutions [07:21:32] SickPanda: ill give you multiple images [07:21:32] orientations [07:21:50] losing road sir. there are hundreds of different sizes :P [07:21:58] doing it in code will be easier [07:22:00] SickPanda what about transparency ? [07:22:09] easy to do with code [07:22:13] SickPanda: if its not too much work, we should do it [07:22:38] blur is hard (for background image) [07:22:41] transparency is easy [07:37:29] SickPanda: do you still eat? [07:40:21] notnarayan: should [07:40:22] yeah [07:40:23] soon [07:40:25] now that you remind me [10:17:50] [java-mwapi] yuvipanda pushed 2 new commits to master: http://git.io/MInQvw [10:17:50] java-mwapi/master 828e293 YuviPanda: Updated POM file [10:17:50] java-mwapi/master 6bd2885 YuviPanda: Added explicit LICENSE bits [10:49:55] YuviPanda, you're healed now?:) [10:50:10] the specific sickness I had, I no longer have :D [10:50:15] I'm just afflicted with Java and XML now [10:51:56] be thankful that your Java is not J2EE [14:10:07] New review: Zfilipin; "I disagree. We already have a test that checks if search box is displayed at home page." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45179 [14:32:08] New review: Cmcmahon; "I missed the other duplicate check, merging now" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/45179 [14:32:19] New review: Cmcmahon; "I missed the other duplicate check, merging now" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45179 [14:32:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45266 [14:32:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45253 [14:32:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45252 [14:32:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45182 [14:32:20] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45179 [14:44:13] New patchset: Zfilipin; "Make it easy to run tests using PhantomJS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45327 [14:59:46] New review: Cmcmahon; "easy support for PhantomJS" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45327 [14:59:48] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45327 [17:13:12] * MaxSem|android slaps his ISP [17:15:56] what happend? [17:18:07] my isp happened;) [17:19:16] heh did you forget to pay the bill again? [17:20:17] its not the first day of the month [17:21:05] apparently, their l2tp server or its db went down [17:21:26] doh [17:22:02] and the only internet cafe i can go uses them too [17:22:49] damn! [17:47:00] frak [17:47:08] it almost works [17:51:07] awjr: won't be making standup :( [17:51:08] sending in notes [17:51:17] ok YuviPanda, thanks for the head's up [17:53:08] awjr: seem to be having issues with the hangout link today :/ [17:53:18] jdlrobson: what is the problem? [17:53:28] it starts loading but then just shows the hangout logo [17:53:43] awjr: sent [17:53:55] seems to be doing same on my laptop [17:54:00] the loading bar just hangs [17:54:05] does it work for you? [17:54:07] yeah it's doing that for me too :( [17:54:11] boo [17:54:18] ergg might be down [17:54:19] let's try again in a few minutes [17:54:20] i'll keep at it [17:54:25] sometimes it just fixes itself [17:54:30] gonna go back to the chrome box now.. [17:54:31] ive seen this happen befoer [17:54:38] will try and install irc on there [17:54:38] also, sometimes a new hangout link will do the trick [17:54:59] jdlrobson: this works: https://plus.google.com/hangouts/_/1e67af01df929ef974602ad79231bcf40ece0bed?authuser=0&hl=en [17:55:06] MaxSem ^ [17:55:10] brion ^ [17:55:59] meh [17:56:08] my connection is down [17:56:41] thanks, MaxSem [17:57:31] awjr: still not working :( [17:58:04] awjr: what's the backup? [17:58:33] MaxSem|android: if you can't join the hangout, can you please send your standup notes via email? [17:58:38] officechromebox: https://plus.google.com/hangouts/_/1e67af01df929ef974602ad79231bcf40ece0bed?authuser=0&hl=en [17:58:45] awjr: we cant join the hangout either [17:58:57] me and jcmish are in… weird [17:59:07] officechromebox: lies! [17:59:11] \o/ [18:07:05] brion: can you give me push access to wikimedia/android-mwlogin? [18:07:16] yeah sec [18:07:31] brion: and setup IRC push if it isn't there [18:07:51] added staff team [18:08:02] sweet [18:08:06] brion: IRC? [18:08:10] setting it up..... [18:08:26] what's the point of pushing if you can't show off in channel... :P [18:08:31] hehe [18:08:33] [android-mwlogin] none pushed 0 new commits to master: http://git.io/kiSoFQ [18:08:39] works \o/ [18:09:07] [android-mwlogin] yuvipanda pushed 1 new commit to master: http://git.io/zWDk6Q [18:09:07] android-mwlogin/master d53f8c9 YuviPanda: Mavenize Everything! [18:09:15] ah [18:09:18] nice :) [18:11:23] * YuviPanda waves at notnarayan [18:11:32] greetings YuviPanda [18:12:07] YuviPanda: what were you telling about iOS? [18:12:10] awjr: did you see my message about a deployment on thursday yesterday ? [18:12:30] tfinc i did; i sent robla and Ct an email asking for certain confirmation [18:12:35] good [18:12:38] if we do thursday, it would have to be early [18:12:41] but that's fine [18:12:46] notnarayan: brion is working on it, I think [18:12:53] since max and i start early anwyay [18:13:05] and in theory, redeploying the changes should not be aproblem [18:15:25] hm? [18:15:30] meh [18:15:55] my connectivity problems persist [18:16:04] * YuviPanda points and laughs at MaxSem|android [18:16:06] bwahahaha [18:16:07] :P [18:16:17] so it would be easier if i posted my status here [18:16:33] so: [18:16:56] interviewed one guy on monday [18:17:46] tfinc: can i PM you = [18:17:48] yesterday was mostly osm. im discussing this stuff with kai krueger [18:18:11] his explanations changed some plans [18:18:55] can you give some more details about osm and the plan changes? [18:19:34] today i guess i could do some mf work which doesnt reqire internet access [18:19:37] notnarayan: sure [18:20:17] awjr, preferrably not with on screen keyboard :-! [18:20:28] fair enough [18:24:23] brion: timezone snafu. I thought app testing meeting was tomorrow :| [18:24:28] i emailed jcmish. [18:24:53] ok lemme know if we're doing it today or postponing it :) [18:25:09] brion: I mailed her asking to postpone (I'm in a bus) [18:25:27] heh [18:25:28] ok [18:25:42] i'll just poke at my iOS stuff [18:25:47] wonderful, org.wikimedia is now assigned to me on maven central! [18:25:49] bwahaha [18:25:52] \o/ [18:25:56] the power is yours [18:26:00] don't go mad with it [18:26:01] indeed :) [18:26:04] i'll try not to [18:26:09] :) [18:26:24] hey brion [18:26:26] I uttered the phrase 'maven is not so bad' today, at which point Chad gave me wise words of advice :P [18:26:27] hey [18:26:30] heh [18:29:22] brion: you working on the iOS commons uploads? [18:29:26] yeah [18:30:43] MaxSem|android: any idea on when your ISP will get its act together? [18:31:23] pretty sure they dont know it themselves [18:32:01] New review: JGonera; "I'm trying to figure out how to best do it in Gerrit. I didn't want to make a huge commit with all t..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45284 [18:33:01] brion: let me know if you need any help with design :) [18:33:31] will do :) for now i'm mostly making sure the internal pieces work so it's a bit ugly :D [18:37:26] [java-mwapi] yuvipanda pushed 1 new commit to master: http://git.io/YreBcw [18:37:26] java-mwapi/master a2af3fe YuviPanda: [maven-release-plugin] prepare release api-1.0 [18:37:34] [java-mwapi] yuvipanda tagged api-1.0 at 014f096: http://git.io/U559OQ [18:37:43] [java-mwapi] yuvipanda pushed 1 new commit to master: http://git.io/ipVDMA [18:37:43] java-mwapi/master d4b048e YuviPanda: [maven-release-plugin] prepare for next development iteration [18:38:39] brion: i saw the android update fly by. thanks! [18:43:12] \o/ [18:43:41] [java-mwapi] yuvipanda tagged rm at 014f096: http://git.io/MsoM_g [18:53:42] jdlrobson, are you there? [18:56:40] talking to vibha by the hammock will be free in about 30 mins max [18:56:51] [java-mwapi] yuvipanda pushed 3 new commits to master: http://git.io/w-tAiQ [18:56:52] java-mwapi/master 99697e8 YuviPanda: Move packagenames [18:56:52] java-mwapi/master 07ea9fb YuviPanda: Revert back to 1.0... [18:56:52] java-mwapi/master d2e40a6 YuviPanda: [maven-release-plugin] prepare release mwapi-1.0 [18:56:59] [java-mwapi] yuvipanda tagged mwapi-1.0 at fa22b35: http://git.io/cJHNYQ [18:57:07] [java-mwapi] yuvipanda pushed 1 new commit to master: http://git.io/Il07_g [18:57:07] java-mwapi/master 807ed3a YuviPanda: [maven-release-plugin] prepare for next development iteration [19:06:58] goddamn. [19:07:05] mediawiki / wikimedia confusion in namespaces [19:07:08] * PandaInABus facepalms [19:13:49] [java-mwapi] yuvipanda force-pushed master from 807ed3a to 6bd2885: http://git.io/bX0YBQ [19:14:07] aieeee [19:14:09] brion: pushed that to org.wikimedia.api instead of org.mediawiki.api [19:14:18] eeeeugh [19:14:25] what a moron [19:14:40] now i'll have to sheepily ask thhem for access to org.mediawiki [19:14:42] eugh eugh [19:15:30] i see [19:16:11] in whateveraster i had checked out [19:16:18] lol [19:16:31] *whatever master [19:21:51] [java-mwapi] yuvipanda pushed 2 new commits to master: http://git.io/zlCSJg [19:21:51] java-mwapi/master 2a2eb16 YuviPanda: Changed groupId to org.mediawiki... [19:21:51] java-mwapi/master 3d437d2 YuviPanda: [maven-release-plugin] prepare release api-1.0 [19:24:29] [java-mwapi] yuvipanda force-pushed api-1.0 from 014f096 to c0a27a6: http://git.io/U559OQ [19:25:56] [java-mwapi] yuvipanda deleted api-1.0 at c0a27a6: http://git.io/V-w9bA [19:26:04] fuck you fryazino.net [19:26:10] [java-mwapi] yuvipanda tagged api-1.0 at da73ad7: http://git.io/U559OQ [19:26:19] [java-mwapi] yuvipanda pushed 1 new commit to master: http://git.io/R25O8Q [19:26:20] java-mwapi/master b6cd003 YuviPanda: [maven-release-plugin] prepare for next development iteration [19:28:49] YuviPanda: http://www.bbc.co.uk/news/technology-21159531 FFOS phones [19:29:36] chrismcmahon: indeed [19:29:40] i'm still skeptical though [19:29:45] of gecko being fast enough [19:31:00] New patchset: MaxSem; "Reduce memcached usage by not caching small pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45355 [19:33:05] New patchset: MaxSem; "Minor improvements" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45356 [19:40:29] standup notres sent [19:42:26] MaxSem: whats left for the GeoData roll out ? [19:42:44] tfinc, make a public announcement;) [19:43:05] blog post! [19:43:10] we can't do it this week though because if problems surface we can't deploy a fix [19:43:19] thats fine [19:43:25] spin up a blog post about it and then share it with us [19:46:00] tfinc, so far I've seen simple and zh using it in addition to enwiki where I've added it myself [19:46:14] how are people using it? [19:46:30] by adding it to their coordinate templates [19:46:42] thus populating the data [19:52:09] jgonera: can you read through https://mingle.corp.wikimedia.org/projects/mobile/cards/376 and see if that's clear enough for you? [19:52:30] MaxSem: then we need to raise awareness [19:52:32] Maryana: we currently have 384 as more important than 376 but that's not true can you swap those around? [19:52:38] MaxSem: draft a blog post about it [19:52:45] on it already [19:54:04] jdlrobson, I find those descriptions tedious to read, give me a few minutes [19:54:09] * tfinc ponders lunch [19:54:20] jgonera: sure [19:56:57] jdlrobson - switched. [19:57:20] jdlrobson, so basically, styling changes, right? [19:57:56] mostly jgonera yup [19:58:15] I know it's verbose but I guess verbose is better than vague? [19:58:37] well, then, for me the description saying "make it look like on attached screenshots" + screenshots would suffice [19:58:58] I'm not sure, I guess it depends on personal preference [19:59:02] awjr_lunch: jgonera would be great if you can review these today - https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:upload3,n,z - since they are needed by this iteration [19:59:26] jdlrobson: have you ever headed to http://www.yelp.com/biz/johns-snack-and-deli-san-francisco ? [19:59:38] nope want to give it a go now? [19:59:42] yes [19:59:46] brion: jcmish moved the testing bits for me to tomorrow :) [19:59:50] this korean burrito intrigues me [19:59:53] whee [19:59:54] hehe [20:00:04] i just need to grab cash on the way [20:00:07] brion: check the times [20:00:09] brion: YuviPanda leads and I just follow! [20:00:10] :D [20:00:12] thanksa lot jcmish [20:00:18] I'm just saying that I'm not sure if investing time in writing those descriptions is worth it, but to sum up, yes it looks clear enough [20:00:20] YuviPanda: anytime D [20:00:23] i'm still in a bus :) [20:00:26] and on edge [20:00:37] YuviPanda jcmish: it's a little early for me but i'll live :D [20:00:45] YuviPanda: hahahah yeah I figured we'd prefer to not have AngryPanda join [20:00:48] oh sorry brion [20:00:52] is it a pain? [20:00:53] nah i'll be awake ;) [20:00:54] jcmish: more like packetloss panda [20:01:01] i'll just call in from home before i head into the office [20:01:01] brion: you can move it if you want [20:01:04] no it's fine [20:01:16] brion: jcmish can we move it a couple of hours? [20:01:24] i don't want sleepy brion :P [20:01:33] no it's fine, really :D [20:01:35] unless you've other meetings scheduled... [20:01:48] brion: 10pm is pretty early for me too :P [20:01:54] hehe [20:02:06] hahaha [20:02:32] i mean, it is the last 30 mins or so of shops being open [20:02:41] * brion fights with objective-c blocks syntax [20:02:47] (I hated it when you guys had DST, since standup was at 10:30 rather than 11:30) [20:03:20] there we go, + (void)retrieveResponseAsync:(NSURLRequest *)requestUrl withBlock:(void(^)(MWApiResult *))block; [20:03:27] it's like line noise… i mean perl :P [20:03:54] :P [20:03:57] jdlrobson, Maryana, I'd prefer to have a full screenshot for the diff view in https://mingle.corp.wikimedia.org/projects/mobile/cards/376 instead of the bullet points [20:04:18] Sohan: brion is currently working on it (commons-ios) [20:04:30] hi brion [20:04:32] howdy [20:05:39] i'm new to this. but YuviPanda says the commons-iOS project just started few days ago. there's a TODO list there to. i can start work on some of it [20:05:55] brion: ^ [20:06:24] cool! [20:06:46] jcmish: I know I'm being a pain but can you move that meeting a couple of hours? It *would* be too early for both me and brion... [20:07:09] brion: thought i should have him ping you so that you don't end up re-implementing each other [20:07:13] sure you said before 11 PST [20:07:18] you ant it a bit later? [20:07:34] *want it a bit later [20:07:38] it's currently at 8:30 PST? [20:07:56] sorry [20:07:57] duh my timezone :D [20:07:58] hold please [20:07:58] imma looking at the current implementation now [20:08:02] Sohan: a little info & link to github at https://www.mediawiki.org/wiki/Apps/Commons#iOS [20:08:11] i'm still doing things like making i/o async :) [20:08:18] jcmish: :D [20:08:33] jcmish: sorry, I can't think in CST yet [20:08:41] CET? [20:08:42] I don't even know :| [20:08:47] ha I'm in MT even worse [20:08:57] k take a look Brion and YuviPanda [20:09:48] can we have it at 10AM PST? [20:10:06] I guess I'm new to rescheduling meetings. Won't be this indecisive next time. Sorry! [20:10:11] brion: does the api return xml or json now? [20:10:40] Sohan: i switched it to use json yesterday [20:12:55] brion: cool. tried running it. its running fine in the simulator but its crashing on the device (ipod 4th gen) [20:13:07] hm, where's it crashing? [20:13:09] brion: ah auto layout i think [20:13:25] iOS 5? [20:13:55] yes. still using ios5 on this device :) [20:15:59] ok will have to fix that layout then :D [20:16:08] you want to do that while you're poking at it? [20:16:22] sure thing! [20:16:40] Sohan: good luck :) [20:17:11] YuviPanda: thanks man. will work on it now. [20:17:30] yay [20:19:07] brion: I'm almost done fixing up all the build stuff :) [20:19:13] whee [20:19:30] brion: it was getting messy - nested submodules are ewwwwww [20:19:35] eek [20:21:11] brion: anything else that needs fixing ? [20:21:35] right now i'm getting a handle on doing async i/o correctly, so i'm concentrating on that [20:22:00] if you can get it running on iOS 5 that'd be a great help for now :) [20:22:12] brion: the QA meeting updated to 10AM PST. [20:22:25] ok [20:22:39] so to get it running, i just disabled autolayout in the .storyboard file. [20:22:40] it works [20:22:50] cause it isn't aviaiable on ios5 [20:23:26] hah [20:23:33] well that's nice and easy :D [20:23:40] yeah :) [20:25:11] Sohan: wanna add localized strings support? [20:25:34] sure. what do i need to do exactly ? [20:26:54] Sohan: probably use NSLocalizedString function - https://developer.apple.com/library/mac/#documentation/cocoa/reference/foundation/miscellaneous/foundation_functions/reference/reference.html [20:27:21] to integrate best with our TranslateWiki tools, we probably want to use strings directly rather than localizing the .xib files [20:27:37] so pull strings and set the labels on controls at view startup, should do the trick [20:28:49] brion: you need the xib files anyway for things like app label, no? [20:29:00] app label? [20:29:00] so can't we just generate xib files from whatever format we use in twn? [20:29:12] well the xib file has view layout [20:29:36] you can localize xibs in some way with some string tools and put the strings back in, but it sounds like a pain in the butt [20:30:07] ah [20:30:22] but wait - are you telling me that iOS natively has no in built localization support? [20:30:28] like java's values- thing? [20:31:56] YuviPanda: it has strings table support [20:32:15] and you can localize any resources like .pngs or .xibs by sticking them in a .lproj directory [20:32:23] it's just kinda funky [20:32:27] ah [20:32:30] alright [20:35:31] wow compiling stuff kills the battery so fast [20:36:01] [android-mwlogin] yuvipanda pushed 1 new commit to master: http://git.io/tFuB1g [20:36:01] android-mwlogin/master bd45e44 YuviPanda: Directly reference java-mwapi from maven central [20:38:08] brion: i didn't understand what you meant by "so pull strings and set the labels on controls at view startup, should do the trick". [20:40:03] moment [20:41:18] sure [20:42:01] Sohan: something like this in a viewDidLoad: [20:42:02] [self.TakePhotoButton setTitle: NSLocalizedString(@"Take photo", @"Label for button for taking a photo") forState:UIControlStateNormal]; [20:42:05] should do it [20:42:13] that sort of thing [20:43:15] ah okay. basically setting all the user interface strings to localized. got it :) [20:45:27] yep :D [20:48:46] alright [20:48:49] good night brion :) [20:48:56] see ya later [20:49:20] brion: also, can you use {{doing}} and {{done}} templates instead o fmarking them with text? [20:49:25] easier to follow :D [20:49:26] sure [21:01:09] YuviPanda|afk: brion are you guys going to finish the whole todo list before we officially kick off on monday? [21:01:38] we might :) [21:02:32] brion: i like this challenge then. shankar should be starting on monday so the more non design bits you finish the better [21:02:39] then we can focus the next two weeks on polish with him [21:02:47] you guys can get the plumbing out of the way [21:02:50] yep [21:02:56] sounds like a plan :D [21:03:33] MaxSem: do you have any opinions about refactoring hook invocations out of mobileFrontend.body.php into a separate file? [21:03:51] you mean hook handlers? [21:03:57] er yeah [21:04:13] I support [21:04:40] since this class has no state now and context is available via MobileCOntext - why not [21:04:41] cool. it would be nice to trim that file down some [21:05:01] can do it if you merge https://gerrit.wikimedia.org/r/45356 :) [21:05:34] hehe ok, im in the middle of something now that's actually adding yet another hook handler. once i finish we can talk [21:12:10] YuviPanda|afk: can limechat auto identify with Nickserv ? [21:12:11] New patchset: JGonera; "Add M.define() and M.require() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [21:15:47] New patchset: JGonera; "Add M.api() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45368 [21:19:51] New patchset: Jdlrobson; "Add nearby page to mobile site [alpha]" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [21:20:13] New review: Jdlrobson; "rebased and submitted" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/43594 [21:20:13] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [21:20:55] New patchset: Jdlrobson; "on new pages add a textarea" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43000 [21:23:34] New patchset: Jdlrobson; "on new pages add a textarea" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43000 [21:23:57] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43000 [21:25:28] jgonera: any issues with doing this https://gerrit.wikimedia.org/r/#/c/45248/ ? [21:26:10] jdlrobson, will do it after lunch (in ~1hr) [21:26:39] sweet [21:27:43] jdlrobson: while im in the middle of implementing this… it occurred to me - how is this "jdlrobson: so concretely we add a hidden input field to the login form that triggers a post login hook that adds the article to the watchlist" any different (in effect) then just making sure the user gets redirect to ?title=article_name&article_action=watch? [21:28:19] it doesn't provide any protection form the arguments you were making yesterday around indempotence [21:28:27] as the article is watched via a POST which is triggered by a user [21:28:41] the important thing is watching the article is a change in state [21:28:42] but the same pitfalls apply to this approach, even if the HTTP verb is different [21:28:58] POST's are not indempotent methods [21:29:19] I cannot force you to do a post by sending you a link [21:29:35] and if you're not logged in, i can't force you to watch an article [21:29:58] the scenario you gave yesterday is just applicable with either approach [21:30:08] i'm not sure how login state is relevant.. [21:30:13] the attack assumes you are logged in [21:30:44] ok, then that attack is irrelevant to the task at hand [21:30:58] you have me confused now [21:31:02] :p [21:31:42] so let me clearly state how i imagine this working [21:31:43] in your argument yesterday against just relying on action=watch was to prevent the attack scenario: [21:31:44] jdlrobson: I want to raise awareness of that company which happens to be on wikipedia [21:31:44] 3:49:26 PM MaxSem: jdlrobson, https://en.wikipedia.org/wiki/Dogmatism :P [21:31:44] 3:49:57 PM jdlrobson: I add a link on a website which exploits this hole in our software and forces the XYZ Ltd article to be watched [21:31:44] 3:50:40 PM jdlrobson: A reader now wondering what this is doing on her watch list clicks it and is now aware of XYZ Ltd and feels somewhat confused to how it got there as to their knowledge they have not done anything to get it there [21:32:29] that is irrelevant to making the fact a non-logged in user clicked the 'watch' icon be remembered until after the user actually logs in [21:32:49] So I click the watch list star. I click login which POSTs some data to the login form which tells it to watch the article. The login form renders a hidden input field. When I click submit and login successfully the article is watched via a server side hook. I am redirected back to the page. Some javascript reads the query string and the state of the watch list star and if it is starred it shows a toast message saying the article has been watc [21:33:13] How can I be attacked in this method? [21:33:38] brion: YuviPanda|afk i'm breaking down howies tasks alongside your feature ideas and rolling up what matches, what i think needs design, etc. will rev on the same page after i'm done [21:33:39] ah, the fact that the login button posts to the login form was not mentioned yesterday [21:33:57] tfinc: excellent [21:33:57] and complicates this. [21:34:11] and does not generally remove the attack vector [21:34:17] how so awjr ? [21:34:35] once you're logged in you can still click a link someone has posted somewhere that includes action=watch in the query string [21:34:41] key parts that i'm seeing a need for a design (which i'll prioritize) account creation, discovery, single/multi upload (non gallery or intent based), my contribs, and set meta data [21:34:42] it's built in to MW [21:34:50] yeh but you click the link [21:35:13] and I guess that does a GET? [21:35:22] correct [21:35:23] Also an alternative acceptable approach would be to use a GET for the login, but for the interface to reveal the effect of logging in will watch the article [21:35:48] at least way the user is informed and knows that if they login something will happen [21:36:12] (but we can always add this later) [21:36:14] New review: MaxSem; "There's mediawiki.api already - can we wait a bit for the pure RL to come upon us and then start usi..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45368 [21:36:14] jdlrobson: eg expose the drawer if article_action=watch is in the URL [21:36:33] and they're not logged in [21:36:33] awjr: well a hash would be ideal [21:36:42] a hash? what do you mean? [21:36:46] but I think the login process doesn't honor the hash [21:36:49] brion: YuviPanda|afk. i'm also going to create a generic. this is what any commons app should have section [21:36:55] a hash of what where? [21:36:57] so that we stay coordinated [21:37:06] whee [21:37:10] for example /w/index.html#foo [21:37:13] in this example #foo is the hash [21:37:33] anyway showing the draw is only a ui change [21:37:37] it doesn't actually perform any operations [21:37:52] i see what you mean… but how does that solve the problem of someone sending a non-logged in user a link that says article_action=watch? [21:38:34] i don't understand the problem [21:38:39] currently if a non-logged in use were to click a link like that, they would jsut be taken to the article, no action would happen [21:38:43] jdlrobson: maybe i dont either [21:38:47] brion: i;ve added localized strings for the controls in main view and flip view controller. [21:38:50] awjr: i'm happy to take this bug if necessary as i'm quite clear in my head of what needs to happen [21:38:59] Sohan: awesome. send a pull req? [21:39:11] jdlrobson: i mean, im clear on a number of different ways we can do this but i dont htink it's worth overly complicating it [21:39:25] well know if you do it wrong I will spend my 10% time fixing it :) [21:39:28] in flipside though, the labels being used aren't described in the view controller but only in the nib. [21:39:34] (as it will bug me :) ) [21:40:23] maybe i'm missing something but i just don't see this as very complicated… [21:40:55] well, the uncomplicated way to do this is just remove the local storage component and allow the redirect to happen after login to article_aciton=watch [21:42:23] or rather, action=watch [21:44:08] ah i see what happens though if you do that; the user gets prompted again if they really want to add the article to their watchlist [21:45:17] New patchset: Jdlrobson; "allow special pages to register messages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45370 [21:46:41] Sohan: yeah you might have to add outlets for the labels [21:46:46] brion: sending a pull request now. do you follow any conventions in title during a pull req. ? [21:46:56] al let me add the labels and then send pull req. [21:46:57] nah we're flexible :) [21:46:59] ok [21:47:05] cool :) [21:54:52] New review: Jdlrobson; "several comments otherwise looking good" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45368 [21:56:12] Change abandoned: Jdlrobson; "makes sense i'll revisit in my free time. Will abandon to unspam the review backlog" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43101 [21:57:11] brion: YuviPanda|afk: how are you guys using 'Focus Areas' from https://www.mediawiki.org/wiki/Apps/Commons ? [21:58:05] [Commons-iOS] sohanmaheshwar opened pull request #1: First pull request (master...master) http://git.io/INUYGg [21:58:35] brion: i've sent a pull request. [21:58:48] let me know if there're more things i can work on [21:59:10] i can get to it tomorrow..err..later today. [22:03:00] tfinc: i'm seeing a lot of these things - https://twitter.com/colindickey/status/294107986912223232 [22:03:27] i like how 'this page has issues' seems to be becoming a tiny twitter meme :) [22:03:47] what else are people saying [22:04:24] Sohan: thanks i'll take a look [22:18:36] awjr, do you think it makes sense to deploy precisely what was attempted last time and leave it for a few days? there were important fixes after that - for example, restoring proper modules on non-English wikis' special pages [22:20:01] are the fixes things that are safe to wait on (eg non-critical)? [22:21:28] the one I mentioned is pretty serious [22:21:57] is that a changeset we can easily cherry-pick? [22:22:15] I think it should be [22:22:49] what if we deployed exactly what we tried to deploy last week and let it sit for a bit, and then deployed that specific changeset? [22:23:01] and then waited til next week for everything else? [22:23:18] if we did that, would we need a cache flush if we deployed that specific fix separately? [22:23:39] no, special pages are not cached [22:26:15] if we would not need a varnish cache flush for deploying just the fix you're talking about, i think we should first deploy the sha1 that we tried to deploy last week and let it sit for a bit, and if all is OK, deploy the fix [22:26:22] what do you think MaxSem? [22:26:35] ok [22:27:13] if we do this tomorrow, i am happy to manage it - but will you be around 9-10am pst? [22:29:32] brion: whats the repot name for android ? [22:29:37] i can't seem to find it anymore [22:30:17] tfinc: i think https://github.com/Wikimedia/android-commons for the app part [22:30:22] there's a couple more pieces though :) [22:30:35] https://github.com/Wikimedia/java-mwapi [22:30:52] and i think https://github.com/wikimedia/android-mwlogin is the last piece [22:33:31] brion: take a look at my changes http://www.mediawiki.org/wiki/Apps/Commons and let me know what you think. i'm just getting started [22:34:17] so far so good [22:35:26] i broke something doing my async changes, tracking it down… i think i'm handling events in the wrong order or something :D [22:35:29] awjr, I'll be [22:35:45] brion: is this for async upload ? [22:35:59] yeah [22:36:14] brion: mail michelle and let her know that iOS and Android have been updated [22:36:20] it works, it just doesn't return data; i'm switching the login to go async and it needs the data return so that's the fun part [22:36:21] you can respond on the old thread [22:36:40] tfinc: hm, which thread is this? [22:36:48] let me dig it up [22:37:45] tfinc: ah the legal thread [22:37:47] brion: "Fwd: [Legalteam] FYI: California Attorney Genera files suit against Delta for lack of privacy policy " [22:37:52] excellent will do [22:38:06] brion: close out https://bugzilla.wikimedia.org/show_bug.cgi?id=42967 [22:46:44] there, solved my async issue [22:48:00] now to kill all the sync i/o methods :D [23:04:00] New review: Siebrand; "Story in commit summary is a bit hard to understand..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45250 [23:06:18] New review: JGonera; "Thanks, I didn't know about it." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45368 [23:10:37] New patchset: Jdlrobson; "disable footer on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45485 [23:12:14] New review: Siebrand; "L10n/i18n review done." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45247 [23:13:47] New patchset: Jdlrobson; "make alert styling available outside overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45248 [23:15:16] New patchset: JGonera; "Add M.define() and M.require() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [23:16:59] New patchset: Jdlrobson; "add MobileContext method to allow adding classes to #content_wrapper" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45249 [23:17:40] New review: Jdlrobson; "low priority for time being" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42999 [23:18:32] New review: Jdlrobson; "Code review was neglected and this patchset has now gone stale. low priority for now. Review other m..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42998 [23:21:02] New patchset: JGonera; "Add M.define() and M.require() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [23:21:39] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45356 [23:22:31] Change abandoned: Jdlrobson; "abandoning for time being" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42271 [23:26:51] New patchset: Jdlrobson; "add getMobileHtmlHeader and setMobileHtmlHeader methods" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45489 [23:31:57] MaxSem, https://gerrit.wikimedia.org/r/#/c/45368/1 see my last comment [23:34:15] jdlrobson: http://www.drdobbs.com/architecture-and-design/mobile-as-the-driver-of-desktop-software/240146757 [23:36:59] Change abandoned: Jdlrobson; "trying to shrink this commit into smaller patchsets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45247 [23:46:20] [Commons-iOS] brion pushed 7 new commits to master: http://git.io/dr-ryw [23:46:20] Commons-iOS/master 1a10453 Brion Vibber: switch interfaces around for async -- kept compat sync interface [23:46:20] Commons-iOS/master 7724e0d Brion Vibber: async upload! [23:46:20] Commons-iOS/master 5002660 Brion Vibber: cleanup a bit from chained methods to using dictionary literals [23:46:51] New patchset: awjrichards; "(bug 43909) (mingle 377) Remove local storage component of non-logged in watchlist star tap" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45491 [23:46:51] New patchset: awjrichards; "(bug 43909) (mingle 377) Include article to watch information in login form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45492 [23:46:51] New patchset: awjrichards; "(bug 43909) (mingle 377) Invoke UserLoginComplete hook to watch an article after login" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45493 [23:46:52] New patchset: awjrichards; "(bug 43909) (mingle 377) Move watchlist data prep for login form to private method" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45494 [23:46:52] New patchset: awjrichards; "(bug 43909) (mingle 377) Add watch article hidden field in account creation form" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45495 [23:53:53] hmm we should make it so that (mingle <#>) links to the mingle cards in gerrit