[00:13:12] awjr_interview, MaxSem: when I said I would add that into the deployment system I was told it wasn't necessary and that we should push people to beta [00:27:22] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/xAs-kA [00:27:22] Commons-iOS/master 531cf07 Brion Vibber: remove stray files [00:45:13] MaxSem: you still around? [00:45:14] api headaches [01:28:57] New patchset: Jdlrobson; "make generic .loading class" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45504 [01:44:50] New patchset: Jdlrobson; "Add PHP CodeSniffer to pre commit hook" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45505 [01:45:35] Is the current iphone app phonegap based? [01:45:47] Mobile is confusing [01:47:34] Reedy: it is at the moment but Brion and YuviPanda|afk are changing that...! [01:47:40] anyway i gotta run now [01:47:47] I'm not so bothered about later ;) [01:47:48] YuviPanda|afk: will be awake soon i expect :) [01:58:22] oh, are they going native? is there a repo up somewhere? [02:23:51] Reedy: thats why we had a thread on wikitech about changing it [02:23:55] Reedy: before it got derailed! [02:25:23] lol [02:25:30] I wasn't sure if it was using the phonegap one [02:25:33] Don't have an iphone [02:25:41] And I don't really read wikitech often ;) [02:29:26] Rolken: yes, native [02:29:27] :) [02:29:56] it's about time, sign me up [02:30:00] Rolken: http://github.com/wikimedia/Commons-iOS [02:30:18] brion's on it full time now, and we're hiring an iOS dev [02:30:33] awesome [02:30:46] Rolken: :) [02:31:13] Rolken: 5.0+ only [02:31:59] yeah, that's a good balance point right now [02:35:37] you might want to consider staying away from storyboards though - if you have multiple contributors, managing merges becomes an unnecessarily annoying chore [02:35:56] but if you only intend to have a small number of contributors, it might not matter [02:36:47] apple's interface xml management could use some refinement [02:37:59] anyway, glad there's been a change of heart [02:38:18] :) [02:38:28] Rolken: but we're not touching wikipedia app currently [02:41:22] too many apps, too little time [02:41:57] c'est la vie [02:43:04] heh [07:36:39] New patchset: Raimond Spekking; "Fix typo from Iabe54543" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45520 [07:37:43] Change merged: Raimond Spekking; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45520 [08:10:18] New review: Raimond Spekking; "i18n review" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43594 [08:55:23] New patchset: MaxSem; "Reduce memcached usage by not caching small pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45355 [11:35:23] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45535 [16:52:12] YuviPanda: when you get some time can I pick your brain today or tomorrow [16:52:22] about community events you've hosted? [16:55:01] monrnin MaxSem [17:06:43] hey awjr [17:08:08] hi MaxSem [17:08:28] no deployment… yet; still waiting to know that we'll have some ops support [17:10:10] whee [17:10:17] ok, mark begrudgingly agree [17:10:18] d [17:10:23] so let's do this thing [17:10:33] who'll deploy? [17:10:40] i can do it [17:10:44] jcmish, are you around? [17:10:52] if you can pick up the deployment next tuesday! [17:11:05] hey jcmish [17:11:07] today would be awesome [17:11:17] MaxSem what was the commit for the fix you were talking bout yesterday? [17:11:17] awjr, sure [17:11:52] cool [17:13:38] still looking [17:13:52] awjr, you can deploy w/o it [17:14:34] howdy cool what time works for ya I don't want ya up until 1am :D [17:15:36] jcmish: we got someone from ops to commit to be around in caes of emergency, so i'm preparing to redeploy our changes from last week [17:15:56] awjr: WOOHOO [17:16:23] so i am going to be redploying sha1 6231a1c0e8c285876658464f5c43bb9393803d18 [17:16:42] and then once we see things are relatively ok, i'm going to deploy a minor fix on top of that, which will put us in a good place for next week [17:16:45] awjr: k cool [17:16:53] I'm gonna run git logs just to make sure [17:17:04] that I have everything up to that commit [17:17:04] thanks jcmish [17:17:07] yup [17:17:21] we should do a quick sanity check on test, but i dont think we need to go too crazy wiht testing since we've already tested this changeset [17:19:05] jcmish: right after our QA meeting? [17:19:10] jcmish: we could just do it on IRC :D [17:19:13] i love text chat stuff :) [17:19:33] sweet [17:19:44] yup I'm all about texting [17:19:51] +1 [17:19:57] video is so ol' school :P [17:20:03] ha! [17:20:31] * YuviPanda has a morbid feeling that his laptop is going to die in the coming few weeks [17:20:54] I don't know who is in charge but the Mobile enginnering section at https://www.mediawiki.org/wiki/Wikimedia_Engineering does look weird [17:20:55] hahahah [17:20:56] ummmm [17:20:57] why? [17:21:23] jcmish: os x says 'battery: replace soon' [17:21:28] and my fan's been working overtime lately [17:21:30] uhoh! [17:21:31] it's based on templates so I didn't dare to edit [17:21:32] awjr, https://gerrit.wikimedia.org/r/#/c/44699/ [17:21:38] yup you're right [17:22:05] MaxSem that looks to me like it will require a cache flush [17:22:13] maybe we should just cherry pick that change [17:22:23] awjr, no - it's for special pages only [17:22:25] oh wait no, it's special pages [17:22:26] right [17:22:30] thanks, forgot :p [17:23:22] are we live yet? [17:24:47] up on testwiki in one sec [17:25:01] waiting for sync-common to finish on srv193 [17:25:22] awjr: MaxSem the git logs and what I posted look good [17:25:28] standing by to test :D [17:25:32] cool rady in a sec [17:25:35] *rady [17:25:36] jebus [17:25:38] *ready [17:25:48] hahah [17:25:49] k [17:26:50] sync-common is taking an unusually long time [17:26:57] it's probably safe to start testing though [17:27:02] jcmish, MaxSem ^ [17:27:15] ok it's done [17:28:02] kayo [17:29:48] hmm the read in another language feature doesn't link to the .m version of the sites [17:29:56] has it always been like that? [17:30:11] yes [17:30:14] :( [17:30:16] * brion reads ".m" as "Objective-C source file" now :P [17:30:21] ha [17:30:27] awjr: yeah i think it relies on the redirects. kinda awkward [17:30:48] makes sense but a bummer [17:31:00] jcmish, MaxSem things look fine to me [17:31:06] go for it [17:31:13] jcmish: concur? [17:31:27] 1 sec [17:31:30] k [17:31:34] on my last perusal :D [17:31:36] hello brion [17:31:49] alrighty yup worked [17:31:58] great im just updating the other branch now, then i'll scap [17:32:00] hey hey [17:32:06] kayo [17:32:34] * brion upgrades his iPhone 3GS to iOS 6.0.1, killing off iOS 4.3 in his collection FOREVAH [17:32:54] \o/ [17:34:00] hey brion [17:34:16] who is matthew falschen? [17:34:50] he has an undeployed change in php-1.21wmf7 [17:36:14] grr [17:36:15] change looks benign... [17:36:20] at least for us :p [17:36:25] hehe [17:36:34] YuviPanda: how's android coming along? [17:36:44] brion: still getting the build right. [17:36:50] last part of it, the ndk is having problems [17:37:13] ndk? you're doing C components? [17:37:21] awjr, the policy has been revert on sight if you don't feel confident [17:37:24] brion: there's an unlisted audio transcoding component :P [17:37:30] ah right :D [17:37:34] it'll be a secret feature for a while. it's there already, so... [17:37:52] i'll have to work on that for iOS later :D already got libvorbis to compile for iOS [17:37:58] MaxSem: yeah, i'll give them one minute [17:38:07] brion: howie's mail seems to assume we're reusing components from WLM. Should have tfinc set expectations better [17:38:21] he's from e3, i think - i pinged ori and spage [17:38:24] i'm writing a followup [17:39:37] meh, reverted [17:39:45] brion: sweet [17:39:56] +1 the fact that doing 'save for later' is easier than building an interface in android :) [17:41:23] :) [17:41:49] scapping [17:42:50] brion: hmm, plus I think web and app will be disjoint [17:42:58] because one is integrated into wikipedia [17:43:00] while the other is not [17:43:12] * YuviPanda ponders writing a response [17:43:25] YuviPanda: as far as design or features? [17:43:30] well, both [17:43:35] :) [17:43:40] design we'd want to go be native to the platform [17:44:57] yup [17:45:11] some general stuff in common but they need to not be afraid of platform differences :) [17:45:21] yeah [17:45:51] awjr: deploying like a boss? [17:45:57] natch [17:46:02] hello jdlrobson [17:46:27] hey YuviPanda ! [17:46:49] brion is on a roll. I'm getting there. App team is coming for you :P [17:47:26] whatever [17:47:33] we'll always have the market share ;-) [17:48:12] tch tch. [17:48:30] jdlrobson: i'll be spending two weeks with language team in Pune next month [17:49:14] i hate scap :( [17:49:44] * YuviPanda gives awjr a moustache [17:49:48] :D [17:49:57] New patchset: Jdlrobson; "add getMobileHtmlHeader and setMobileHtmlHeader methods" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45489 [17:49:59] :{D [17:50:03] is scap not done yet? [17:50:08] omg [17:50:16] push, iPhone wants to be reactivated, demands a sim card. hope this t-mobile sim works :P [17:50:18] jcmish: video chat in ten minutes? [17:50:36] almost done with localisation cache update [17:50:49] i heard tim made sacp like a bagillion times faster (at least compared to last time) so hopefully it wont be so bad [17:51:32] poop, i need an at&t sim. oh well i'll finish activating later when i find one [17:52:18] yessir [17:52:21] you at a good spot? [17:52:26] computer not smoking? YuviPanda [17:52:58] New patchset: MaxSem; "(bug 44089) Fix js/css for non-English special pages" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/45562 [17:53:25] awjr ^^^ [17:53:38] jdlrobson: i'm on it [17:53:40] i mean [17:53:42] in the hangout [17:53:56] my mac has decided to kill my webcam, but that's ok [17:53:59] this place is dark anyway [17:54:10] YuviPanda: what are you on? [17:54:32] YuviPanda: ha k I'm on my way to rescue you from your dark place [17:54:38] jdlrobson: wifi [17:54:40] MaxSem is that effectively a cherrypick? [17:54:42] stealing from the hasgeek people :P [17:54:48] awjr, yes [17:54:58] great thanks for doing that [17:55:08] hi brion [17:55:12] howdy [17:55:24] YuviPanda: ? we have a meeting? [17:55:27] let me find my glasses, i'm too far from the screen at my home desktop :) [17:55:28] brb [17:55:31] i'm confused.. [17:55:34] ouch [17:55:36] jdlrobson: i meant jcmish [17:55:37] sorry [17:55:43] ahh k :) [17:55:44] sorry [17:56:21] ok l10n cache update complete... [17:56:22] brion this is what YuviPanda and I are looking at as v1 for android http://www.mediawiki.org/wiki/File:Commons_upload_flow_v1.pdf [17:56:32] grr maven [17:56:33] here comes the copy to apaches! [17:56:35] wow it's going fast [17:57:13] notnarayan: looks nice [17:57:23] brion: :) [17:57:47] main difference for iOS is that we do the photo selection from within the app [17:57:50] brion: is this the same planned for iOS from a features list? [17:58:17] pretty much same feature set yeah [17:58:29] so we might have login/tutorial before the photo selection [18:00:34] brion: an iOS app would look and work a lil different, ill send you a wireframe with the same features as v1 [18:00:40] great [18:00:56] notnarayan: brion is in the meeting with me and jcmish for a while now [18:01:02] now it's not going so fast [18:01:03] :( [18:10:08] scups done awjr ? [18:10:19] *scap [18:10:25] i'm seeing updated code \o/ [18:10:38] i'll report when it's done [18:17:21] jcmish: you wanted to talk about community events? [18:17:30] yep [18:17:41] gonna grab coffee then I'll IM you [18:17:43] scap is done, mark is purging mobile varnish caches [18:19:09] jcmish: sure [18:20:41] awjr: I really think we need to figure out the purge issue [18:21:09] awjr: we no longer have the spare capacity to afford them [18:21:33] preilly: we are working on it [18:22:05] awjr: I'd like to understand better what changed [18:22:17] awjr: because we had gotten to a place that we didn't need them [18:23:27] preilly: you can see the immediate chagnes that were just deployed here: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-01-17 [18:24:09] awjr: okay thanks [18:36:53] https://developer.android.com/tools/building/building-cmdline.html and https://developer.android.com/tools/devices/managing-avds-cmdline.html [18:36:58] for emulator from commandline [18:38:02] jcmish: ^ [18:38:27] awjr, do you still want to learn C?:) [18:39:02] awesome thanks YuviPanda [18:39:13] MaxSem: in general, yes - but i sense some sadism in that question [18:39:18] New patchset: Jdlrobson; "change upload position/logo in menu (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45250 [18:39:57] MaxSem: why do you ask? [18:39:58] awjr, since Sumana asks for LevelUp commitments, I thought I could mentor you [18:40:04] ooo [18:40:09] that actually sounds cool [18:40:27] i like that idea, MaxSem [18:43:44] awjr, alright - the goal could be that you sould be able to pass my C interview task from my previous work - it's actually reasonably simple [18:47:46] MaxSem: that sounds intriguing. i can't really give much thought or focus to this though for a few hours [18:48:14] awjr, I can add us to the table if you agree [18:48:32] then we'll find some time for this [18:48:33] MaxSem let me give it some more thought first, but i will likely go for it :) [18:49:33] mark is slowly purging the mobiel vanrish caches one-by-one. he's done 2 of the 4 so far, but wants to wait a bit to do the next ones due to current app server capacity [18:51:01] MaxSem: i have to run to a meeting in a few minutes and still haven't pushed out that additional fix. i can either do it after the mtg, or you can negotiate with preilly who's doing partner testing stuff right now if you want to push it out yourself [18:51:36] awjr, I'll take it [18:51:41] thanks MaxSem [18:53:34] MaxSem: I'm done [18:55:26] New review: JGonera; "My only problem with this is that it doesn't seem to belong to MobileContext. It probably belongs to..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45489 [18:56:54] awjr, could you also check https://gerrit.wikimedia.org/r/45489, it's pretty small, but I have some doubts (especially after reading your comments on setOverlay()) [18:57:18] jgonera: sure but i wont be able to til later this afternoon [18:57:31] awjr, ok [18:58:49] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/45562 [18:59:29] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45248 [19:03:56] New review: JGonera; "I feel pretty strongly about this one not belonging to MobileContext, but correct me if I'm wrong." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45249 [19:05:32] jdlrobson, do we want to disable footer on all special pages? [19:05:33] New review: MaxSem; "I concur with Juliusz - at most, we could create a couple of generic methods to set named properties." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45249 [19:07:46] New review: JGonera; "Changing to -1 because it seems very similar to https://gerrit.wikimedia.org/r/#/c/45249/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45489 [19:12:29] brion: hey. what are we working on today? i'm not sure why the navigation bar is showing that way on a 4-inch display [19:12:55] Sohan: yeah not sure what's up with that [19:13:09] switching screen sizes in the storyboard bumps it to the bottom as well [19:14:01] hmm. i don't have a 4-inch device with me right now so can't test. will have access to one tomorrow so can check where its failing [19:14:33] generally if a NIB is written for the 3.something device, it still shows up fine in the 4-inch device [19:15:17] Sohan: you can test in the simulator, you can choose from the 'hardware' menu [19:18:52] New review: Siebrand; "i18n/L10n reviewed." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45250 [19:20:52] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/F1undw [19:20:52] Commons-iOS/master c2a1285 Brion Vibber: Upload progress callback, progress bar [19:23:22] brion: any other bug fixes/ features that i can possibly work on ? [19:26:20] awjr_mtg, fix deployed [19:26:32] core pieces are still pretty in flux, not sure what's best to work on just yet :) [19:27:58] awesome MaxSem :D [19:33:22] Sohan: another small piece I can use -- right now all images get decompressed. when pulling from the image gallery, we should be able to pull the original JPEG or PNG file from the Asset Library [19:33:44] if we can pull that into an NSData instead of using the UIImage and recompressing it, that would be awesome [19:34:29] i'll be working today on getting the app to save data to a queue so you can upload at your will or upload multiples :) [19:37:57] yeah getting the original png file will be great. i can maybe look into tht [19:39:18] awesome thanks! [19:45:11] jdlrobson, we could possibly adapt something like that: https://github.com/airbnb/javascript [19:45:50] brion: looking at the api code now. good chance i'll have few doubts. so will ping then :) [19:46:22] New review: Brion VIBBER; "Two issues:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45485 [19:46:33] Sohan: super. :) [19:51:52] New review: Brion VIBBER; "Seems to work. :)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/45370 [19:52:00] New review: Brion VIBBER; "Seems to work. :)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45370 [19:52:01] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45370 [19:53:39] jcmish: https://github.com/calabash/calabash-android/blob/master/ruby-gem/lib/calabash-android/canned_steps.md looks wonderful [19:53:43] (I've not used Cucumber before) [19:53:52] if it works as advertised, would be amazingly useful :) [19:54:08] yupper [19:55:48] that's what I got to see that at the mobile summit [19:55:57] and I poked around because I never believe the videos :D [19:56:20] YuviPanda: ^ [19:56:30] jcmish: indeed [19:56:36] hopefully it isn't 'too good to be true' :) [19:56:52] YuviPanda: It works but I noticed there needs to be a good deal of config [19:57:04] so that it works "consistently" [19:57:57] ah [19:58:45] but still... [19:58:45] if it is a one shot effort [19:58:54] jcmish: I'm using maven to setup building for the android stuff. [19:59:04] using git submodules was tooo painful. [19:59:20] so if this works fine, you should be able to integrate that into the build process easily enough [20:00:36] jcmish: might try https://github.com/xian/great-expectations also at some point, to replace the junit tests I have [20:01:27] oh cool [20:01:27] thanks [20:06:03] awjr_mtg: MaxSem i'm seeing missing messages on production [20:06:18] mw.msg('mobile-frontend-photo-upload') not sure what [20:06:18] ' [20:06:27] that returns undefined - not sure why [20:06:48] might just be a problem with photo uploads though [20:06:51] so not massively important [20:07:04] sigh [20:07:15] To test - log in and visit https://en.m.wikipedia.org/wiki/List_of_fictional_ducks [20:07:28] the photo upload appears but there is no text to the right of the photo [20:07:42] jdlrobson: does ?debug=true fix it? [20:07:48] i dont think mark finished flushing the mobile varnish caches [20:08:01] ahh i see [20:08:03] it's a code problem [20:08:08] k [20:08:10] i guess a bad merge occurred [20:08:15] messages are only being added in alpha [20:08:21] oops [20:08:26] i'll send a patch [20:08:30] but it's not urgent [20:08:33] we can live with this [20:08:51] we can pick it up on tuesday's deployment [20:09:25] jgonera, are you ready for tomorrow's interview? [20:09:53] YuviPanda: that's pretty cool [20:09:53] MaxSem, almost, have to write down some questions and check candidate's github again [20:09:56] nice work [20:10:12] the great-expectations stuff [20:10:16] jgonera, have you ever interviewed someone? [20:10:26] MaxSem, no ;) [20:10:32] :) [20:10:37] about the time [20:11:48] New patchset: Jdlrobson; "package mf-photo.js messages with mf-photo.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45595 [20:11:52] awjr_sandwich: ^ [20:15:42] jcmish: yeah, much better than junit [20:16:01] i'll also need to find a mock framework sometime [20:16:07] but the current unit tests are sortof good enough [20:16:14] I've used Mockito and easy mock [20:16:19] but I come from the Java world [20:16:30] I don't know about other mocking frameworks for other languages [20:17:20] well, i'm all Java for ow [20:17:21] *now [20:17:27] for a while at least [20:18:21] jcmish: YuviPanda was asking me about mocking yesterday, I forgot you had all that Java. I think specifically the issue was mocking an HTTP server to test client code, which is a funny grey area. [20:18:36] yeah, mocking a mediawiki API 'server' [20:18:38] to test an API client [20:18:57] because I do not want to be debugging issues that crop up because the mock is not an exact enough replica [20:19:10] brion: can we use ALAsset to get the original image? its available only ios 4.0 and upwards though. [20:19:10] yeah I understand that [20:19:19] we can also convert ALAssert to NSData [20:19:39] Sohan: we are only iOS 5.0+ [20:19:41] Sohan: yeah, we're targeting 5.0+ [20:19:53] awesome [20:20:04] jcmish: so currently, for these 'unit' tests to run, there needs to be a local mw instance [20:20:04] let me try ALAsset class [20:20:05] not ideal, but I'm unsure what an ideal solution would be [20:20:14] hmm [20:20:14] if you can think of a better solution, i'd love to hear [20:20:20] you can't mock it? [20:20:21] this is for github.com/wikimedia/java-mwapi [20:20:39] mock which parts of the API, exactly? [20:20:53] should I just have a stored response for each request? then I won't be testing network code... [20:21:03] yup [20:21:06] that's what I'm thinking [20:21:14] hold canned responeses [20:21:30] hmm, build a small server that holds canned responses for common queries? [20:21:44] Do you really have to have a server? [20:22:02] jcmish: how else am I to test my network code? [20:22:06] that is the biggest component here [20:22:11] can the object mimic the responses then release? [20:22:25] Sorry YuviPanda I don't know alot about mw [20:22:35] forget mw [20:22:40] think of it as just another REST server [20:22:45] mw is just mediawiki :P [20:23:45] ah true [20:23:48]