[00:00:24] New patchset: Jdlrobson; "add method to allow adding classes to #content_wrapper" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45249 [00:00:28] ok both amended now so i should be able to get +1s from you now MaxSem :) [00:12:01] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/v_cf6g [00:12:01] android-commons/master 0766643 YuviPanda: Upgrade version of Maven plugin. [00:12:15] brion: so builds still working for me. I'm very confused now [00:12:22] I'll try to set it up on shankar's machine tomorrow [00:12:25] and see what happens [00:13:43] jdlrobson, you don't want to review https://gerrit.wikimedia.org/r/#/c/45491/1 ? [00:17:19] lemme try it again real quick [00:18:22] can't find android:android:jar:4.1_r2 [00:18:25] * brion headdesk [00:18:28] dunno dude [00:18:39] * YuviPanda wonders if this is a path issue [00:18:51] brion: i'll try it out on shankar's when he wakes up. [00:18:53] this is why i just use ant ;) [00:18:55] ok [00:19:05] heh :P [00:19:14] brion: this *was* just using ant. but... dependencies [00:19:22] yeah :( [00:19:26] when I started to try getting nested git submodules to work... [00:19:28] I figured I have to go [00:32:19] MaxSem: ? i reviewed it.. [00:32:38] jdlrobson, I mean +2 [00:33:08] i tend to wait 2 days to give someone else a chance to complain and then +2 [00:33:32] i'll make an exception though [00:33:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45492 [00:33:42] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45491 [00:35:15] thanks, it's in a chain of commits [00:35:52] MaxSem: awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=44330 [00:36:19] jdlrobson: it might be worth making that a mediawiki bug [00:36:24] MaxSem: can https://gerrit.wikimedia.org/r/#/c/45249/ and https://gerrit.wikimedia.org/r/#/c/45489/ be merged now? [00:36:33] awjr: does it work the same on MediaWiki ? [00:36:45] yeah, we're using the same exact login mechanism as core [00:37:01] ah [00:37:06] well that sucks [00:37:16] i suspect there's already a bug open about it, but i could not find it when i looked briefly the other day [00:37:18] that's going to be a big blocker in pushing watch lists to stable.. [00:37:25] how do you figure? [00:37:35] that shouldn't block pushing watch lists to stable at all [00:39:18] jdlrobson, if someone approves the CSS/I asked a question on it [00:40:12] well awjr if I click the watch list star and login [00:40:25] then click back it's confusing that i'm not logged in [00:40:33] also it's a pain [00:40:46] if i go to google do a search and end up on a wikipedia article i'm interested in [00:40:53] i will have to login every single time to watch an article [00:41:19] as i will never be logged in on http [00:42:08] i guess im not convinced that that's a common enough pain-enducing scenario to warrant blocking watchlist promotion [00:42:17] ok but it is a pain [00:42:20] :) [00:42:22] i agree :) [00:42:30] it might put people off the feature [00:42:32] i can think of some ways we can hack around that for the time being [00:42:44] ie. butt i just logged in 5 minutes ago! why are you asking me to login again? [00:42:54] is there anyway to force https for users who have logged in before? [00:43:03] in the redirector [00:43:03] but i'd leave it up to Maryana/howie whether or not we should block promotion on it [00:43:03] jdlrobson: no [00:43:06] well actually [00:43:08] i take that back [00:43:28] we could also potentially /always/ redirect the user to https... [00:44:03] i mean, as things are now, we wouldn't be able to know from http whether or not a user had logged in before (since the https login cookie is secure) [00:44:15] but if we always redirect the user to https when they'er coming to http... [00:44:18] so MaxSem if i fix this https://gerrit.wikimedia.org/r/#/c/45489/4 do you promise to +1 ? [00:44:26] then problem solved, or at least worked around [00:44:56] i dont know how good or bad of an idea that is though, probably worth checking with someone from ops [00:45:01] jdlrobson, tomorrow [00:45:14] New patchset: JGonera; "Add M.define() and M.require() + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [00:45:39] the alternative would be to set an http login cookie as well, although im not sure how tricky that would be particularly with centralauth [00:45:52] k k [00:45:52] New review: JGonera; "This is just a rebase, see changeset that depends on it for examples." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45284 [00:45:55] and more cookies?! blech [00:48:50] New patchset: JGonera; "Add api module + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45368 [00:49:10] awjr: as long as they aren't sticky cookies [00:49:38] hehehe sigh [00:49:56] jdlrobson: you're taking a boxing class? [00:50:51] is it like this? http://static.tvtropes.org/pmwiki/pub/images/folies-bergere-boxing-kangaroo.jpg [00:51:33] LimeChat's image preview helps sortof in times like this [00:51:36] New patchset: JGonera; "Add api module + tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45368 [00:51:42] only sortof, since i dunno if that is a kangaroo or a t. rex [00:51:53] * YuviPanda twiddles thumbs as maven does it's thing [00:52:14] awjr: yup it [00:52:14] s [00:52:22] it's surprisingly good fun and a good workout [00:52:42] i went with my housemate Amy [00:54:59] New patchset: Jdlrobson; "add getHtmlHeader and setHtmlHeader methods" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45489 [00:55:07] awjr: pleeeassee merge https://gerrit.wikimedia.org/r/#/c/45489/5 [00:55:11] end this saga [00:55:15] ! [00:56:13] jdlrobson: that is probably going to have to wait til tomorrow; i am warpping up other stuff before i head out for the evening [00:56:42] oookk :( [00:56:47] sorry dude [00:57:18] code review is first thing on my list for tomorrow am though, likely before you all get in anyway [01:00:20] brion: ping? [01:00:26] brion: rm ~/.m2 again [01:00:28] git pull [01:00:28] YuviPanda: yo [01:00:30] and do mvn install [01:00:34] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/eEwzdw [01:00:34] android-commons/master dc81ed6 YuviPanda: Add reference to Yuvi's Temperoary Repo... [01:00:54] brion: don't have to do anything with deployer [01:01:04] just go inside commons-android [01:01:05] do an mvn clean [01:01:06] then mvn install [01:01:11] yeah, do a clean first [01:01:46] trying... [01:01:58] * brion holds breath, crosses fingers, and sacrifices a chicken [01:02:23] it should download lots of small files [01:02:25] and a few big ones [01:02:54] it's downloading lots of things :D [01:03:07] indeed [01:03:11] and you'll find references to yuvi.in [01:03:23] [INFO] BUILD SUCCESS [01:03:31] \o/ [01:03:36] brion: connect a device, do mvn android:dpeloy [01:03:37] err [01:03:38] deploy [01:03:42] that should put that on your phone [01:04:06] New patchset: Jdlrobson; "fix jshint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45700 [01:04:29] brion: if that works I can peacefully go to sleep :D [01:04:30] New patchset: Jdlrobson; "fix jshint error (minor)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45700 [01:04:37] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45700 [01:04:43] brion: and new build instructions will simply be 'clone the repo, do mvn install' [01:04:44] :D [01:05:47] ok it installs, let's see if it works :D [01:05:57] \o/ [01:06:31] brion: it uploads to testwiki only [01:06:34] so feel free to upload [01:07:38] behold http://test.wikipedia.org/wiki/File:Test_photo_blah.jpeg \o/ [01:07:45] YuviPanda: ok so that'll do for now i guess :D [01:07:50] \o/ [01:07:52] brion: :) [01:07:58] maybe best to have instructions on how to reproduce that repo though [01:08:03] just in case it breaks some day :D [01:08:09] go to sleep now YuviPanda ! [01:08:19] brion: I expect the yuvi.in repo to be temperoary [01:08:37] brion: all I did was take the jars that the maven-android-deploy tool produced, and put them up [01:08:39] *nod* [01:08:41] heh [01:08:46] so in effect, it should've worked for you too [01:08:50] surprising why it didn't [01:08:51] weird that it won't work here [01:08:52] either way [01:08:53] yeah [01:09:06] brion: I should poke hashar so he can set this up on CI [01:11:13] jdlrobson: i took pity and am looking at the code now after all - is ' // assumes mobile skin' enough to satisfy max? [01:11:30] * jdlrobson shrugs - but he can fix it right if he does care? [01:11:42] lol [01:11:57] you could always check and make sure that it's a mobile skin first [01:12:19] his concern is valid, although it's ahrd to imagine a use case with our current code base where it would be a problem [01:12:35] i did that before awjr [01:12:38] he said it didn't matter [01:12:38] oh [01:12:41] i got very confused [01:12:44] that is confusing. [01:12:46] see the patch set preceding and his comment [01:12:56] MaxSem can be confusing XD [01:13:50] heh [01:14:09] i like that approach, actually, it is defensive. at least more so than a comment :p [01:15:28] but i dont think it's a huge deal right now [01:15:33] im just going to test this then i'll merge [01:16:48] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/FaTC_g [01:16:48] android-commons/master 1ca7913 YuviPanda: Added README with Build instructions [01:17:25] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45489 [01:17:35] there you go jdlrobson ^ [01:17:40] now im off, see you all tomorrow [01:18:04] bye awjr [01:18:53] bye! [01:18:55] awjr: \o/ [01:20:14] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45368 [01:20:15] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45284 [01:21:43] brion: we could also setup a repo storage server on wmf servers [01:21:44] it's just ftp [08:23:33] New review: Siebrand; "i18n/L10n reviewed." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45685 [10:28:06] New review: Siebrand; "Code feels familiar, as if I've seen it in another patch set, too... See inline comments." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45684 [15:27:49] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45535 [15:27:50] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45535 [16:58:57] grr [17:13:21] eh? [17:13:30] MyIspSux: same problems as before? [17:13:39] not anymore [17:14:11] but I'm starting to worry [17:14:25] what's going on? [17:14:31] as if there were alternatives to them in my little town [17:14:47] "technical problems" [17:15:39] >_< [17:16:11] awjr, what is your current level of C knowledge? [17:16:45] GrrrGrrr i can read some and have it make some sense but that's abou tit [17:17:21] like, i wouldn't really be able to write anything useful if you asked me to, at least not without serious trial/error/manuals [17:17:57] i could probably write a hello world program [17:18:16] you can read it? then you should be able to answer this question: http://etherpad.wikimedia.org/C-Lessons :) [17:18:35] ahaha i said 'i can read SOME' [17:19:55] that's my favorite first interview question [17:20:51] i guess im not hired :( [17:20:56] as experience shows, if the candidate can't answer them, they will ultimately fail [17:22:55] hi GrrrGrrrr [17:22:55] awjr: No standup for me today, am not working (30 hours a week) [17:23:40] ok GrrrGrr, if you have anything to share, can you shoot an email to the team? [17:23:41] GrrrGrr, good for you [17:23:54] i am so confused [17:24:02] but... sending emails is also a work? [17:24:46] ok, if you've only worked 29 hours and 58 minutes so far this week, can you send an email if there's anything important to share? [17:25:03] otherwise, im sure it can wait til monday [17:25:08] but you'll probably forget what you did by monday [17:27:25] GrrrGrrrr: so by the time we're done with my C training, will i be able to control the russian railroad? [17:28:18] mmm, I think that neither embedded programming not C++ will be the part of our programme [17:28:22] maybe next quarter [17:29:22] doncha be askin' for this boy - I might get creative when choosing a goal for ya;) [17:29:23] GrrrGrrrr: ping [17:29:29] notnarayan, pong [17:29:40] lol GrrrGrrrr [17:29:50] notnarayan: http://docs.oracle.com/javase/7/docs/webnotes/install/mac/mac-jdk.html [17:30:01] a long long time ago in the 90s when dinosaurs roamed the earth, I used to read C in a debugger. COBOL was easier. [17:30:03] GrrrGrrrr: :P [17:30:58] @_@ [17:31:20] I wrote C stuff for GNOME for a year [17:31:24] 'twas fun [17:31:30] though I'm not sure how much you can call Glib C [17:32:08] PuviYanda: it's a pity that I can't seem to use Unicode in IRC nicks [17:32:22] yup [17:32:52] PuviYanda: know anything about logging in varnish? [17:33:16] * SaxMem sounds like a musical memtest implementation [17:33:22] only that we need to change the delimiters [17:33:25] hahaha [17:33:31] PuviYanda: k [17:33:58] diederik was asking me about possibly logging the existence of beta/alpha cookies from varnish; but i will look into it later today [17:37:17] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45595 [17:41:57] MaxSem: can you take a look at these outstanding changes? https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:bug/43909,n,z [17:42:49] awjr, no doxygen at https://gerrit.wikimedia.org/r/#/c/45493/1/includes/MobileFrontend.body.php [17:43:03] * awjr fixing [17:45:39] New patchset: awjrichards; "(bug 43909) (mingle 377) Invoke UserLoginComplete hook to watch an article after login" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45493 [17:45:45] MaxSem fixed ^ [17:53:08] New patchset: awjrichards; "change upload position/logo in menu (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45250 [17:53:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45250 [17:55:56] New review: awjrichards; "This appears to already be the behavior on special pages, unless I am missing something... why is th..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45485 [17:56:48] New review: awjrichards; "Oh, i take it back - i am seeing the footer on watchlist page." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45485 [17:57:04] awjr, https://gerrit.wikimedia.org/r/#/c/45493/ sorry I didn't notice this immediately [17:57:17] (the problem) [17:57:35] oh! good point [17:57:53] i'll fix it after standup [17:58:38] awjr: not sure if my previous message got through - not joining standup today (not working today) [17:58:52] yup, i saw that YuviPanda, thanks [17:59:47] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45485 [18:00:34] jdlrobson: standup? [18:00:47] chrome box issues [18:00:49] sorry [18:00:51] boo [18:01:03] trying something else quickly [18:01:13] k [18:01:18] google is down! [18:01:27] well their authentication [18:01:35] tfinc is trying some magic [18:01:46] oh noes [18:02:06] notnarayan: ping [18:02:43] YuviPanda: http://www.oracle.com/technetwork/java/javase/downloads/index.html [18:22:22] MaxSem, will you use etherpad for the interview? [18:22:28] New review: Brion VIBBER; "Looks good as a quick hack, but consider a more general way of passing through actions." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45495 [18:23:18] we could try https://www.stypi.com/ since it has syntax highlighting and maintains indentation (writing code in etherpad is a pain) [18:23:27] New review: Brion VIBBER; "Depends on an "outdated" changeset. Does this need fixing/rebasing?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45494 [18:23:59] YuviPanda: brion: have either of you taken a look at the various WikiVoyage apps popping up? [18:24:13] tfinc_: i'm currently taking a look at the one in the email [18:24:15] not yet, i saw the mails and plan to check it out in a bit [18:24:19] regex'd wikitext parsing [18:24:28] yuck [18:24:33] thats prone to massive breakage [18:24:52] tfinc_: yup [18:25:01] New review: Brion VIBBER; "Is this ready to commit or not? If not, recommend abandoning the change to keep things uncluttered." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43852 [18:25:03] k, if you guys are on it then let me know what you find after [18:25:13] tfinc_: I'll look around over the weekend [18:25:28] jgonera, I'm ready [18:26:10] tfinc_: prelimiary incomplete draft at https://office.wikimedia.org/wiki/User:Ypandian/Goals [18:26:16] will work over the weekend to complete i [18:26:17] t [18:27:01] tfinc_: i did have a look at the wikivoyage app [18:27:32] its a simple offline dump [18:28:05] YuviPanda: have it done by monday [18:28:25] jgonera !!!!!! [18:28:26] tfinc_: yeah, i will [18:28:40] can someone pke him IRL? [18:28:55] notnarayan: we've bene iterating on http://www.mediawiki.org/wiki/Apps/Commons and now it has a needs design section http://www.mediawiki.org/wiki/Apps/Commons#Needs_Design [18:28:59] i'm hoping to prioritize it today [18:29:05] so that its ready to go for monday [18:29:36] tfinc_: i've had a bit more discussion with notnarayan over dinner today. Making a little bit of edits to that page now. [18:30:28] New review: Brion VIBBER; "Does this need to be activated somehow? The scripts, they do nothing on my machine." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45505 [18:30:34] tfinc_: done. [18:31:08] * YuviPanda will head to bed in a short while [18:31:22] tfinc_, can you poke Juliusz? we're looking bad [18:32:03] MaxSem: i did. hes joining [18:32:13] MaxSem, what's the hangout link? [18:32:24] https://plus.google.com/hangouts/_/e6de325b8f1ee1b00eec1cd162fc5790d5c1a7cd [18:35:02] New patchset: awjrichards; "(bug 43909) (mingle 377) Invoke UserLoginComplete hook to watch an article after login" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45493 [18:35:38] New patchset: awjrichards; "(bug 43909) (mingle 377) Move watchlist data prep for login form to private method" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45494 [18:37:47] jdlrobson: q for you: https://bugzilla.wikimedia.org/show_bug.cgi?id=43878 [18:39:39] New review: Brion VIBBER; "Looks good, seems to work." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45684 [18:39:40] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45684 [18:40:00] tfinc: I'm also leaving comments on the talk page of https://www.mediawiki.org/wiki/Apps/Commons#Tasks [18:40:27] YuviPanda: hit save so that we can see them [18:40:33] yeah, doing it now [18:40:56] YuviPanda: why do we need focus areas and tasks ? [18:41:28] YuviPanda: are focus areas design guidelines ? because otherwise i dont get it [18:41:42] tfinc: I started writing focus areas and then broke them down to tasks. I can add 'ensure compatibility with 2.3' to tasks and get rid of focus [18:41:52] kill it [18:42:11] doing [18:42:14] tfinc: hit talk page [18:42:18] 'upload later' makes no sense [18:42:37] New review: Brion VIBBER; "When passing multiple titles to API methods that accept them, generally it wants pipe-separated values." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45685 [18:43:28] YuviPanda: you could queue stuff up while on edge and then upload them on wifi [18:43:45] brion: sure. But you are just going to be using the camera app itself [18:43:57] brion: and just hit share when you're on wifi [18:44:00] maybe you want to add descriptions while you know what it was :) [18:44:27] hmmm [18:44:36] that's an use case, yes [18:44:49] brion: so, in that case, in the 'My Uploads' thing - a 'pause uploading' toggle would do? [18:44:54] YuviPanda: is your point in the talk page that save for it later is superfluous as the image will already be saved in the gallery ? [18:45:05] might do [18:45:11] New patchset: awjrichards; "add method to allow adding classes to #content_wrapper" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45249 [18:45:24] tfinc: yes, and you are free to take pictures whenever, and hit 'share' only when you have wifi, etc [18:45:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45249 [18:45:38] but brion's point being you might want to type the title, etc right then. [18:45:43] wo that makes sense. [18:46:03] but I think that's still an edge case, one 'toggle'. [18:46:13] It shouldn't be considered a major feature [18:46:54] responded [18:46:59] and god do i hate our discussion pages [18:47:10] tfinc: in https://www.mediawiki.org/wiki/Apps/Commons#Features I see both Queues and 'Save for Later'. I think on those two Save for Later is both confusing and redundant. Should be just queues IMO [18:47:32] kill it [18:49:03] tfinc: important private message [18:49:15] tfinc: we should have an image capture pipeline from inside the app itself, agreed [18:50:18] sorry awjr juliusz ran into some technical issues for the interview so had to jump in to help him :) [18:50:25] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45667 [18:50:26] jdlrobson: no problem [18:50:34] jdlrobson: i think all your code is merged for https://mingle.corp.wikimedia.org/projects/mobile/cards/328 ? [18:50:36] are you still blocked there? [18:51:48] awjr: will check in a minute just switching floors! [18:52:03] tfinc: responded [18:52:10] I've gotten used to talk pages :) [18:56:49] YuviPanda: can limechat be set to auto identify ? [18:56:54] tfinc: yes [18:56:56] or [18:56:57] well [18:56:59] I don't actually know [18:57:03] ZNC auto identifies for me [18:57:09] without an external tool [18:57:13] tfinc: ah yes [18:57:15] it can [18:57:20] cmd + U [18:57:23] nickserv password [19:05:50] YuviPanda: did you get a chance to upgrade Xcode and make sure the iOS app builds for you? [19:06:08] brion: on 3G today. Can mooch off thoughtworks' wifi tomorrow and upgrade [19:06:14] ok :D [19:06:23] :D [19:17:20] eek brion you merged https://gerrit.wikimedia.org/r/#/c/45684/1 [19:17:33] i was making changes siebrand suggested :-S [19:17:47] heh [19:18:05] gonna do some rebasing now ;-) [19:18:39] New patchset: Jdlrobson; "Surface image summaries on DonateImage page (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45685 [19:18:40] * YuviPanda heads off to sleep [19:18:48] tfinc: do leave comments on the talk page. [19:18:48] :) [19:18:50] gnite! [19:23:58] New patchset: Jdlrobson; "DonateImage code cleanup (minor)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45791 [19:27:49] brion: I responded to https://bugzilla.wikimedia.org/show_bug.cgi?id=44330 [19:28:07] maybe I should open as a new bug [19:28:37] personally i think if we are forcing https login on mobile we should force https on all mobile page views.. [19:29:10] i agree strongly :) [19:29:22] an interim would be force https on anyone who has ever logged in [19:29:28] *interim solution [19:30:25] jdlrobson, brion i am inclined to make it so we always force https on mobile, regardless [19:30:42] oooh [19:30:44] that would be easier that forcing https for anyone who has ever logged in (we don't really have any way of knowing that if a user is on http) [19:31:21] we'd have to do this at the extension level (for various reasons we can't do this in the squid redirector or at the varnish level apparently) [19:31:37] it's something i think we should clear with ops before we implement, but it should be trivial [19:31:47] what do you think brion, jdlrobson? ^ [19:31:53] i would like that very much [19:32:04] the login experience is currently very broken as it stands [19:32:08] i'd love https-only [19:32:19] If I go back on my browser and go back to an http mode [19:32:21] it might break ryan_lane's heart though :) [19:32:27] It's going to be very confusing why i've lost my login state [19:33:00] well, the login experience isn't broken, it works as it's designed :) [19:33:14] the ux is broken [19:33:21] :) [19:33:22] no, we just don't provide http login [19:33:28] i demoed it to a friend and they were hitting back [19:33:33] bah [19:33:34] i saw them login 3 times before realizing what was happening [19:33:46] that central auth page is horrible [19:33:46] that is sad :( [19:33:50] well that's true [19:33:59] he used back rather than find the link [19:34:04] as he didn't know what he was looking at [19:35:07] doh [19:35:35] we should figure out how to override that mess [19:35:40] it needs a spinner and an auto-redirect or something [19:36:08] brion do you know if there's anyway to force the order in which hook handlers execute? [19:36:19] hmmm [19:36:29] you could manipulate the order of contents in $wgHooks :P [19:36:45] heh [19:36:48] sheesh [19:37:14] it would be trivial to override how centralauth does it's thing if we could ensure that our handling of that same hook happens /after/ [19:37:30] or put a hook *in* centralauth [19:37:31] and use that [19:37:42] oh yeah [19:37:43] interesting [19:38:01] a hook within a hook! [19:38:10] programming inception [19:41:16] hehe [19:44:40] jgonera, https://en.wiktionary.org/wiki/variable#Pronunciation :P [20:00:47] Maryana: it sounded like you accepted cards 307, 279, and 273 - if so, can you move those over to the 'accepted' column? [20:01:27] yes indeed [20:01:33]