[00:15:19] <gerrit-wm>	 New patchset: Jdlrobson; "Add on and trigger methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912
[00:22:29] <gerrit-wm>	 New patchset: Jdlrobson; "add parameter to force mobile view always" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45914
[00:28:06] <gerrit-wm>	 New patchset: Jdlrobson; "Login form error message has no margin  (bug 44355)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45915
[00:28:27] <dfoy>	 brion: The scheduled Monday morning test was postponed
[00:28:38] <awjr>	 aw crap i think a bad merge ate the anon watchlist magic
[00:29:03] <brion>	 dfoy: ok
[00:36:33] <gerrit-wm>	 New patchset: awjrichards; "Readd onUserLoginComplete hook handler" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45917
[00:37:03] <awjr>	 jdlrobson_, jgonera can one of you take a look at ^ it's kinda important to get in as it fixes a regression introduced likely by a bad merge
[00:37:27] <jdlrobson_>	 sure
[00:37:31] <jdlrobson_>	 gimme 1s
[00:37:43] <awjr>	 ty
[00:40:40] <jdlrobson_>	 jorm: whiskey today?
[00:40:54] <gerrit-wm>	 New patchset: Jdlrobson; "save the hash (bug 44139)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45918
[00:41:46] <jdlrobson_>	 awjr: looking at your patch set now - i thought i reviewed this?
[00:42:07] <awjr>	 jdlrobson_: like the comment says, it appears to have been eaten by something in current master
[00:42:18] <jdlrobson_>	 ok so i'm testing auto watching yes?
[00:42:23] <awjr>	 aye
[00:42:32] <jdlrobson_>	 awjr: if you can merge https://gerrit.wikimedia.org/r/#/c/45914/
[00:42:35] <jdlrobson_>	 this makes my life a lot easier
[00:42:38] <awjr>	 jdlrobson_: lookin
[00:42:39] <jdlrobson_>	 my desktop view keeps forcing desktop
[00:42:46] <jdlrobson_>	 ahh you -1ed
[00:42:49] <jdlrobson_>	 sorry missed that
[00:42:51] <awjr>	 oh yeah :p
[00:42:59] <awjr>	 quick fixes though
[00:43:08] <jdlrobson_>	 ok i'll cherry-pick this for time being
[00:43:53] <jdlrobson_>	 works for me awjr
[00:43:58] <jdlrobson_>	 feel free to merge
[00:44:17] <awjr>	 k thanks jdlrobson_
[00:44:43] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45917
[00:45:25] <jdlrobson_>	 awjr: i disagree with you on https://gerrit.wikimedia.org/r/#/c/45914/1/includes/MobileContext.php
[00:45:47] <awjr>	 why? it breaks the model
[00:45:57] <jdlrobson_>	 well i want to make it impossible to ever get on desktop :)
[00:46:20] <jdlrobson_>	 actually wait
[00:46:22] <awjr>	 so put it at the top of shouldDisplayMobileViewInternal() or whatever it is
[00:46:23] <jdlrobson_>	 no i misunderstood sorry
[00:46:30] <jdlrobson_>	 i thought the history/isDiff stuff worked elsewhere
[00:46:42] <awjr>	 eh?
[00:48:19] <gerrit-wm>	 New patchset: Jdlrobson; "add parameter to force mobile view always (dev)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45914
[00:48:25] <jdlrobson_>	 sorry me communicating becomes impossible at 5pm on a friday :)
[00:48:37] <jdlrobson_>	 k that seems to work ^
[00:49:17] <gerrit-wm>	 New review: JGonera; "The only thing that worries me is that this hook is in a file where all the general hooks are, but u..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45917
[00:49:20] <awjr>	 you should probably put it below where it's checking the action
[00:49:26] <awjr>	 jdlrobson_: ^
[00:49:35] <awjr>	 otherwise you're not going to get an accurate experience
[00:49:44] <jdlrobson_>	 ?
[00:49:46] <awjr>	 by accurate i mean like how things work in prod
[00:49:59] <jdlrobson_>	 i want to force everything
[00:50:10] <jdlrobson_>	 it's AlwaysMobile not MostlyMobile :)
[00:50:48] <awjr>	 you gotta put it after the action == 'edit' check
[00:50:54] <jdlrobson_>	 why?
[00:51:11] <jdlrobson_>	 I want edit and history to be shown in mobile view even if they break
[00:51:22] <jdlrobson_>	 i want to escape desktop altogether and be wgMFAlwaysMobile
[00:51:29] <awjr>	 because i think it would be dangerous for one of us to be developing against $wgMFAlwaysMobile = true;
[00:51:42] <jdlrobson_>	 i don't see why..
[00:52:07] <jdlrobson_>	 please explain
[00:52:13] <awjr>	 because you are short circuiting behavior that happens in stable
[00:52:46] <awjr>	 so you will not be able to accurately locally test stable
[00:53:38] <jdlrobson_>	 that's fine
[00:53:40] <jdlrobson_>	 it's a power user feature
[00:53:55] <awjr>	 if you don't want to change it, i'll −1 it and you can see if others agree with you - if max and juliusz are ok with it then i'll give in, but you are not convincing me this is a good idea
[00:53:55] <jdlrobson_>	 for when i know i want to only be in mobile mode
[00:54:44] <jdlrobson_>	 i just really don't understand where you are coming from
[00:55:26] <jdlrobson_>	 I know edit and history show in stable as desktop, some pages force mobile view and if use format is desktop it forces desktop
[00:56:13] <jdlrobson_>	 it just seems like a badly named variable if it doesn't always force mobile
[00:57:01] <awjr>	 you know, you could just set forceMobileView to true with some trickery in your LocalSettings
[00:57:15] <tfinc>	 jdlrobson_: did you see http://blog.quora.com/Introducing-the-Best-Writing-Experience-on-Mobile?__snids__=90041538&__nsrc__=2
[00:57:23] <awjr>	 but then you'd get the functionality im talking about, not what i guess you're trying to acheive
[00:57:55] <awjr>	 i guess i can't understand why you'd want to force mobile view in edit/diff in stable
[00:58:18] <jdlrobson_>	 tfinc: yup it's on my to read list :)
[00:58:37] <jdlrobson_>	 awjr: because one day edit/diff will work in stable :)
[00:58:46] <tfinc>	 i'm charing our 4s to install it
[00:59:11] <awjr>	 right… but it doesn't now, by design, so why would you want to short circuit that locally?
[00:59:20] <jdlrobson_>	 i want to force myself to always use mobile mode as I want to see what's broken
[00:59:35] <jdlrobson_>	 as a motivator to fix it
[00:59:41] <awjr>	 but doing that might make it impossible to see what IS broken if you're short circuiting functionality in stable
[00:59:44] <jdlrobson_>	 i mean diff view should redirect to MobileDiff soon
[01:00:03] <awjr>	 right… i dont see how that's a good argument for this...
[01:00:53] <jdlrobson_>	 Well currently action=diff always forces desktop. If I'm viewing it with wgMFAlwaysMobile and I see a broken mobile experience then it motivates me to make sure i don't
[01:01:39] <awjr>	 i just don't get it… shouldnt you be looking at the diff functionality in beta anyway and fixing it there?
[01:01:49] <jdlrobson_>	 well i have a weird setup
[01:01:52] <jdlrobson_>	 i develop mostly in chrome
[01:01:58] <jdlrobson_>	 and i'm forever toggled back to desktop view for some reason
[01:02:12] <awjr>	 i mean, the only thing that your variable does that you can't already do with what exists is make it so that you get the mobile view for action=edit and action=history and diff view
[01:02:13] <jdlrobson_>	 i want confidence no code is going to interfere with me being in mobile mode
[01:02:35] <awjr>	 then maybe you should fix your set up instead of adding more code :p
[01:03:15] <jdlrobson_>	 trust me i've tried but wiping cookies seems to be the only way
[01:03:21] <jdlrobson_>	 and i'm fed up of continuously wiping cookies
[01:03:25] <awjr>	 i develop primarily against desktop chrome and i do not have that problem
[01:03:41] <awjr>	 and i dont need to constantly wipe cookies either
[01:04:01] <jdlrobson_>	 well i'm not sure why that is - but i obviously do something different in my dev process to you :)
[01:04:27] <awjr>	 to be fair, my dev instance is set up to emulate production a fair amount
[01:04:46] <awjr>	 i have varnish and memcache running with a separate .m domain and ssl support
[01:04:53] <jdlrobson_>	 see i don't have varnish..
[01:05:02] <jdlrobson_>	 and i don't have .m domain :)
[01:05:08] <jdlrobson_>	 anyway we can pick this conversation on monday again
[01:05:09] <awjr>	 but you could!
[01:05:16] <awjr>	 what we should really do
[01:05:17] <jdlrobson_>	 i don't want to though awjr this is the point :)
[01:05:43] <awjr>	 is get a vagrant thingamajig set up that we can all use to develop against so we develop against a consistent environment that is like prod
[01:06:04] <jdlrobson_>	 sure, but i still like to work off my local instance.. i use it a fair bit to collect notes
[01:06:43] <awjr>	 that's the idea of vagrant, it basically sets up a local virtual machine with preconfigured magic
[01:07:26] <jdlrobson_>	 anyway.. let's pick this conversation up again monday regardless i still thing such an option is useful
[01:07:38] <awjr>	 so jdlrobson_what im going to do is −1 your commit and register my concerns. but if you can get max and juliusz to agree, then i won't object
[01:07:48] <jdlrobson_>	 Max never agrees with me
[01:07:49] <jdlrobson_>	 :)
[01:07:55] <awjr>	 max never agress with anyone
[01:08:00] <awjr>	 jdlrobson_: you should try reverse psychology
[01:08:17] <jdlrobson_>	 anyway nothing wrong with getting in a world where desktop no longer exists
[01:08:38] <awjr>	 i think cheating stable is like cheating death
[01:08:38] <awjr>	 or something
[01:08:41] <tfinc>	 aww .. the new editor isn't out in the market yet. sadness
[01:09:02] <jdlrobson_>	 well i'm not afraid of death :)
[01:09:05] <awjr>	 hehehe
[01:09:37] <jdlrobson_>	 i mean i'm happy to put it at the bottom if this just ends the conversation
[01:09:52] <jdlrobson_>	 maybe the special casing won't annoy me but it probably will at some point ;-)
[01:10:07] <jdlrobson_>	 fuck found another bug
[01:10:27] <gerrit-wm>	 New patchset: Jdlrobson; "add parameter to force mobile view always (dev)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45914
[01:10:51] <jdlrobson_>	 ^ awjr there you go at the bottom :)
[01:12:43] <awjr>	 ok, now i'm going to −2 this because you can achieve the same functionality with existing code :p
[01:12:57] * awjr  waits for a punch in the face

[01:15:05] <awjr>	 jdlrobson_: just add this to your LocalSettings.php: $context = MobileContext::singleton();
[01:15:06] <awjr>	 $context->setForceMobileView( true );
[01:15:06] <jdlrobson_>	 argg
[01:15:09] * jdlrobson_  punches awjr 

[01:15:11] <jdlrobson_>	 i'm calling it a day
[01:15:15] <jdlrobson_>	 :P
[01:15:19] <awjr>	 fortunately i was anticipating that and ducked.
[01:15:34] <awjr>	 jdlrobson_: but seriously, just add the above to your LocalSettings, problem solved :)
[01:16:04] <gerrit-wm>	 New review: awjrichards; "You can achieve the same thing with the following in your LocalSettings.php:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/45914
[01:16:07] <jdlrobson_>	 grr i asked whether this was possible for and someone told me no and told me to set something in my .htaccess
[01:16:20] <awjr>	 jdlrobson_: they must not've known better
[01:16:32] <awjr>	 you can also set some stuff in your .htaccess but that's more complicated
[01:16:33] <jdlrobson_>	 well mobile is god mode should be in one day
[01:16:43] <awjr>	 lol
[01:16:49] <jdlrobson_>	 anyway i need to drink whiskey been a long week
[01:16:54] <awjr>	 :)
[01:17:01] <awjr>	 have a good weekend
[01:17:11] <jdlrobson_>	 u too man
[01:17:17] * jdlrobson_  salutes team mobile and then teleports

[01:25:06] <gerrit-wm>	 New patchset: awjrichards; "Refactor login hook into MobileFrontend.hooks.php" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45921
[01:48:37] <gerrit-wm>	 New patchset: awjrichards; "(bug 44330) When a user logs in on HTTPS, set a cookie to force them to stay on HTTPS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45922
[01:50:14] <gerrit-wm>	 New patchset: awjrichards; "(bug 44330) When a user logs in on HTTPS, set a cookie to force them to stay on HTTPS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45922
[01:50:41] <awjr>	 im outta here, have a great weekend everyone
[03:44:02] <NicolasRaoul>	 Hello all!
[21:57:10] <gerrit-wm>	 New review: Siebrand; "Repeat of ps1" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/45685