[00:03:14] Project Android-Commons (mobile) - Nightly builds build #10: FAILURE in 25 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/10/ [00:03:14] * yuvipanda: Do not undeploy before deploying to device by default [00:03:14] * yuvipanda: Fixed bug causing delayed notification of uploading being in progress [00:03:14] * yuvipanda: Have the Media class be parcelable [00:03:14] * yuvipanda: Show count of uploads being queued up [00:03:15] * yuvipanda: Refactor to send out Broadcasts events when uploading [00:03:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45921 [00:07:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45922 [00:17:00] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/OUEy4g [00:17:00] Commons-iOS/master f3d6197 Brion Vibber: Adjust transparency on description, label size... [00:20:35] New patchset: Jdlrobson; "make use of $wgMobileFrontendResourceTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46652 [00:20:36] MaxSem: awjr you'll like this one ^ [00:21:41] omg slower initialization [00:21:53] VisualEditor are doing it.. [00:22:13] Most extensions do it [00:22:30] it can't be that much slower.. [00:22:40] and cleaner code \o/ [00:22:42] meh, think of the ~~children~~ nanoseconds:P [00:28:39] awjr: https://github.com/wikimedia/mediawiki-vagrant/pull/1 merged [00:29:14] thanks preilly [00:29:20] awjr: np [00:29:29] soo... [00:29:31] you can do this in php? $wgMobileFrontendResourceTemplate + array() [00:29:34] i did not know that [00:29:46] no breakage after deployment --> /me goes to bed [00:29:58] g'night MaxSem [00:30:06] thanks for the deployment today :) [00:30:19] :) [00:30:30] awjr: Using the plus operator to merge an array really works best with an associative array, otherwise it merges on the numbered indexes, which can lead to some unexpected or odd results. [00:30:39] awjr: It should never be used! [00:31:00] preilly: why never? [00:31:01] awjr: The order of precedence with using the + operator to merge arrays is from left to right. [00:31:25] awjr: unexpected or odd results with indexes mostly [00:31:44] preilly: but that shouldn't be a problem with associative arrays i take it? [00:31:52] it sounds like equivalent of array_merge() [00:32:10] awjr: it is a special case for compatibility [00:32:26] except for non-associative arrays, that is [00:32:26] awjr: you should use the array_merge function [00:32:47] preilly: yeah that would be my inclination, i'd never seen the + operator used for array merges before [00:33:59] awjr: plus the + operator returns the right-hand array appended to the left-hand array; for keys that exist in both arrays, the elements from the left-hand array will be used, and the matching elements from the right-hand array will be ignored. [00:34:16] awjr: see for more information [00:34:33] thanks preilly [00:34:59] awjr: np [00:36:20] awjr: this is a good example of suckage: [00:36:21] $a = array('red', 'orange'); [00:36:22] $b = array('yellow', 'green', 'blue'); [00:36:23] $both = $a + $b; [00:36:23] var_dump($both); [00:36:37] Produces the output: [00:36:38] array(3) { [0]=> string(3) "red" [1]=> string(6) "orange" [2]=> string(4) "blue" } [00:36:39] To get a 5-element array, use array_merge. [00:37:07] * preilly goes away from #wikimedia-mobile now [00:44:42] New review: awjrichards; "Use array_merge() instead of '+' operator. '+' works, but it is uncommon and has potentially unexpec..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46652 [00:44:58] New review: awjrichards; "Also, I realize you might not be into the whole brevity thing, el duderino, but it would be nice if ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46652 [00:45:03] preilly: as a Ruby guy, that is just bizarre. [00:47:51] chrismcmahon: ha ha ha [01:24:06] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/9bO08w [01:24:06] Commons-iOS/master 3345b64 Brion Vibber: Fix settings dialog in portrait... [01:24:06] Commons-iOS/master bdf9de1 Brion Vibber: fix detail view in portrait mode... [01:24:06] Commons-iOS/master 5cd896d Brion Vibber: Add "Delete" button and adjust image preview size... [01:50:37] New patchset: Jdlrobson; "Create MobileFrontend resource loader module abstraction (code health)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46669 [01:55:42] jdlrobson, foundry square has an image now! [01:55:50] does that mean you fixed the bug? [01:58:23] Maryana: no I did it manually [01:58:23] :) [01:58:28] aww [01:58:33] well, i guess that works, too [01:58:51] very nice pic [01:59:02] New review: Jdlrobson; "I copied VisualEditors naming conventions. Happy to change to MF though." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46652 [02:01:55] New review: Krinkle; "* Minor whitespace error" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46669 [02:08:01] New patchset: JGonera; "Add View, an abstraction over jQuery elements." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46290 [02:09:42] New patchset: JGonera; "Overhaul photo upload code (#332)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46646 [02:10:47] New review: JGonera; "Toast messages still missing, some other minor polishing needed." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/46646 [02:18:58] [Commons-iOS] felixmo opened pull request #4: Fixes to credential input and implemented the ability to stop the upload operation (master...master) http://git.io/Ocuyuw [08:06:31] Yippie, build fixed! [08:06:32] Project Android-Commons (mobile) - Nightly builds build #11: FIXED in 1 min 34 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/11/ [08:06:32] yuvipanda: Add basic layout file for my contributions [08:39:58] New review: Ori.livneh; "Neat! I'd love to see this functionality in core." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46669 [11:02:27] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/Vh0sXA [11:02:27] android-commons/master 31f8aa4 YuviPanda: Pass correct length to the upload function [11:02:27] android-commons/master 420ec80 YuviPanda: Show queued upload count only when it is > 1 [11:03:18] Project Android-Commons (mobile) - Nightly builds build #12: SUCCESS in 24 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/12/ [11:03:18] * yuvipanda: Pass correct length to the upload function [11:03:19] * yuvipanda: Show queued upload count only when it is > 1 [16:59:33] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/rl-Jeg [16:59:33] android-commons/master 9540284 YuviPanda: Added a Contributions Content Provider!... [16:59:33] android-commons/master de49db5 YuviPanda: Updated IntelliJ project file [17:00:08] Project Android-Commons (mobile) - Nightly builds build #13: FAILURE in 15 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/13/ [17:00:08] * yuvipanda: Added a Contributions Content Provider! [17:00:09] * yuvipanda: Updated IntelliJ project file [17:01:13] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/tdtVkw [17:01:13] android-commons/master 64e16ad YuviPanda: Add missing DbOpenHelper class (required by prev. commit) [17:02:15] Yippie, build fixed! [17:02:15] Project Android-Commons (mobile) - Nightly builds build #14: FIXED in 30 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/14/ [17:02:15] yuvipanda: Add missing DbOpenHelper class (required by prev. commit) [17:10:43] YuviPanda: hello [17:11:14] YuviPanda: are we looking to allow selecting multiple images from gallery and upload to commons? [17:28:52] sigh [17:30:23] isp problems again? [17:30:40] sigh [17:43:04] hello notnarayan [17:43:31] ah, greeting YuviPanda [17:43:38] food has been had! [17:43:46] and the underlying data persistence framework has been built! [17:43:59] YuviPanda: give me a min, uploading wireframes to commons :) [17:44:02] nice [17:44:53] YuviPanda: http://commons.wikimedia.org/wiki/File:Commons_upload_and_my_uploads_android_workflows.pdf [17:45:44] notnarayan: can you also number the screens? makes it much easier to talk about [17:45:56] YuviPanda: noted. [17:46:11] MaxSem|android: when you have the chance, can you reply to Ryoichi from Google about the change you made yesterday? [17:46:23] notnarayan: I'll note that I'm not too much of a fan of (5) [17:46:32] sure [17:46:39] provided a solution involving lesser clicks could be found [17:46:55] * brion waves [17:46:55] notnarayan: but what I really want for now is a more detailed version of the last screen on the first row [17:47:00] (numbering :P) [17:47:14] brion: hello brion :) [17:47:28] notnarayan: and everything after 5th screen has no notes, is confusing :( [17:47:37] YuviPanda: the other option is to launch the camera and have gallery as one of the options [17:48:08] YuviPanda: I'm numbering it. hold on. [17:48:12] ok [17:48:36] YuviPanda: last screen first row is the currently uploading screen [17:48:46] YuviPanda: is that the one you want details for [17:48:57] there is no currently uploading screen [17:49:09] there is 'my uploads', which includes 'currently uploading, queued, and previously uploaded' [17:49:21] rather, there *should* be no currently uploading [17:49:27] because only one thing can upload at a time [17:49:44] yes [17:49:50] YuviPanda: thats what i have done [17:50:00] I still see a screen saying 'Currently Uploading' [17:50:06] YuviPanda: let me number them and well discuss them in ten mins [17:50:11] ok [17:51:55] brion: ping [17:52:14] YuviPanda: yo [17:52:45] brion: github settings fiddling :) [17:53:05] brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=44503 [17:53:10] whee [17:53:27] brion: could you do that? [17:53:35] think so [17:53:43] wheee [17:53:46] do it! [17:53:48] for android-commons? [17:53:51] yes [17:54:23] ok let me push the test button [17:55:04] * brion wonders if it did anything :D [17:55:20] hmm, maybe i should push to find out [17:56:36] * YuviPanda pushes [17:56:52] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/KjVCdw [17:56:52] android-commons/master d1b0885 YuviPanda: Use Filename as key for content URI, not id [17:56:56] ok. [17:57:12] Project Android-Commons (mobile) - Nightly builds build #15: SUCCESS in 25 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/15/ [17:57:13] yuvipanda: Use Filename as key for content URI, not id [17:57:16] wheee! :) [17:57:17] brion: ^ [17:57:27] yayyy [18:06:50] jcmish: after a long time someone at the standup with worse internet than me :P [18:06:53] yay Comcast! [18:07:00] ARRRRGGGHH [18:07:26] I finally just told me that my hardware is muted [18:07:56] jcmish: we still can't hear you. awjr asked you to just mail in notes [18:08:04] k [18:08:10] jcmish: yeah, we just finished up, dunno what happened :( [18:08:14] can I email arrghhh? [18:08:18] lol [18:08:39] that sounds like the name of a GELF from Red Dwarf :D [18:08:41] oh well [18:08:43] it might actually be my machine I'll reboot [18:08:53] and then email the notes [18:08:56] back in a sec [18:09:44] awjr: I think from next week notnarayan will also be joining standup :) [18:09:51] (or this friday even, though I won't be there) [18:10:06] great YuviPanda and notnarayan :) [18:10:09] awjr: id like that :) [18:10:38] notnarayan: if you send me your contact info i can add you to the calendar invite (the hangout link we use is found there) [18:11:52] awjr: its notnarayan@gmail.com. will i be getting a @wikimedia.com email id? haven't heard anything yet [18:13:11] i dunno notnarayan, good question for tomasz i think [18:13:26] awjr: ill ping him :) [18:13:59] YuviPanda: my friend http://upload.wikimedia.org/wikipedia/commons/b/b2/Commons_upload_and_my_uploads_android_workflows.pdf [18:14:14] * YuviPanda clicks [18:14:36] notnarayan: I insist that you call jdlrobson, tfinc and rmoen|afk 'my friend' every time :P [18:15:24] YuviPanda: screen 2, i was wondering if we could add a few set of images to the app repo which randomly get selected and show up on the start screen [18:15:41] * YuviPanda thinks [18:15:45] [Commons-iOS] brion pushed 4 new commits to master: http://git.io/al6XKg [18:15:45] Commons-iOS/master bd5b5bf Felix Mo: Settings view will now only validate credentials if they have been changed, and uploads cannot begin without first logging in [18:15:45] Commons-iOS/master 4d4e36c Felix Mo: Merge remote-tracking branch 'upstream/master' [18:15:45] Commons-iOS/master 17bfde6 Felix Mo: Implemented ability to cancel the current upload operation, modified the 'Upload' button to toggle between it and a 'Cancel' button that cancels the upload operation [18:15:54] we need a way to track those, actuall [18:15:55] y [18:16:03] notnarayan: can you file a bug, so I won't forge? [18:16:12] (wiki for larger level tasks, bugzilla for specifics) [18:16:22] YuviPanda: ill do that. [18:16:29] there is a 'Commons App' product [18:16:38] YuviPanda: link? [18:16:46] notnarayan: bugzilla.wikimedia.org ;P [18:16:59] grr grr [18:16:59] notnarayan: screen 7 looks very different from what we have... [18:17:08] now it pretends to work [18:17:10] MaxSem: :P [18:17:30] GrrrGrr: ignore 7 for now [18:17:35] ok [18:17:42] its a case where multiple images have been selected in gallery [18:18:20] GrrrGrr: we can debate if we need a next and a thumbnail so the user can enter the title and description while the images get uploaded [18:18:28] notnarayan: we aren't doing that for this iteration [18:18:31] YuviPanda: as we are not doing multiple now, ignore it [18:19:10] hmmm, can we remove things that we aren't doing this iteration and make it cleaner? [18:19:13] right now that's a *lot* of screens [18:19:51] YuviPanda: yes, i can do that. [18:19:54] and split it up into multiple pdfs for multiple iterations? [18:20:00] YuviPanda: noted. [18:20:02] hmmm, or I wonder if it should be in one large one... [18:20:09] i'm wondering what's the best way to go about this [18:20:28] brion: any luck on the signup api? [18:20:58] YuviPanda: not yet. i'll ping a reminder later if i don't hear anything [18:20:58] YuviPanda: ill have v1 v2 as separate docs, no issues there. [18:21:05] notnarayan: sweet :) [18:21:27] YuviPanda: how do you want to handle the case where the user is in the app and hits upload and selects gallery [18:21:30] Maryana, can you mmake me a screenshot of Special:Nearby in Android? [18:21:42] YuviPanda: are we saying that we allow him to only pick one image from gallery right now? [18:21:44] oh, i took one yesterday but forgot to send it to you! [18:21:51] so sorry, maxsem - sending now [18:21:56] notnarayan: yes [18:21:56] YuviPanda: i do see an ApiAccountCreation class in E3Experiments extension... [18:22:48] actually, maxsem - does it make sense for me to upload it to commons? [18:23:18] that'll make it very easy for you to stick into your blog post :) [18:24:07] brion: poke around? [18:24:40] YuviPanda: looks like… it just validates some parameters, doesn't actually create. :P no captcha support in it either [18:24:49] i'll probably have to write it myself then bah [18:24:56] brion: there's one from someone on #mediawiki [18:25:04] hmm [18:25:06] link? [18:25:22] tyler romeo [18:25:25] maxsem: http://commons.wikimedia.org/wiki/File:Mobile_nearby_prototype.PNG [18:25:30] looking [18:25:31] https://gerrit.wikimedia.org/r/#/c/18127/ [18:26:02] brion: fair amount of activity on it [18:26:10] but seems to have died down bout 2 weeks ago [18:26:12] whee [18:26:21] i'll poke at that then [18:26:35] :D [18:29:21] Maryana, awesome, thanks! [18:29:56] np - sorry i didn't do it earlier [18:29:56] was too excited about the feature :) [18:31:29] YuviPanda: any more updates on the wireframes? [18:31:48] notnarayan: 'my uploads' is thumbnails with no extra info? [18:31:53] me no likey [18:32:02] YuviPanda: :) [18:32:09] I liked the previous design better [18:32:11] YuviPanda: pick 8.1 [18:32:16] YuviPanda: :) [18:32:51] ah didn't see that :) [18:32:59] notnarayan: this is why too many screens are confusing :P [18:33:02] would be nice if you split :P [18:33:05] YuviPanda: i like that one too. just that if there are a *lot* of uploads, it becomes a lil difficult to show all of them [18:33:13] YuviPanda: ill split them [18:33:17] notnarayan: doesn't matter, since there is going to be only one active one [18:33:27] notnarayan: so i think a bit of distinctionb etween those three would be nice? [18:33:31] 'current', 'queued', 'previous' [18:34:17] YuviPanda: when the user opens the app, he would be taken to the my uploads screen [18:34:22] YuviPanda: thats 8.1 [18:34:32] yeah, but a bit more 'visual' distinction [18:34:36] YuviPanda: there is nothing getting uploaded [18:34:37] if you see th eplay store, for example [18:34:45] it has 'updating', 'update avilable' and 'rest' [18:37:23] hmm https://gerrit.wikimedia.org/r/#/c/18127/ appears to have been merged, that explains why no work on it in last two weeks :) [18:38:03] brion: ... oh? [18:38:36] still needs captcha support tho [18:42:22] last chance: any concerns about https://www.mediawiki.org/wiki/Extension:GeoData/blogpost before I submit it to Guillaume? [18:43:04] brion: did it get deployed anywhere? [18:43:25] seems to be live on https://en.wikipedia.org/w/api.php [18:43:28] and how did that pass through, without captcha? Spambots? No spam ptorection at all? [18:43:31] it just won't work :) [18:43:31] ... [18:43:43] captcha plugin will kick back an abort [18:43:56] OuKB: lgtm [18:43:56] or should, anyway [18:44:06] let me double-check ;) [18:44:48] brion: using it in apisandbox gives me weird results? [18:44:53] "info": "The user account was not created, as we could not confirm its source.\nEnsure you have cookies enabled, reload this page and try again." [18:47:45] brion: I leave it to you to go read through that and fish out how it works / doesn't :P [18:48:20] :) [18:49:38] YuviPanda: 8.1 http://upload.wikimedia.org/wikipedia/commons/b/b2/Commons_upload_and_my_uploads_android_workflows.pdf [18:51:11] * YuviPanda clicks [18:51:27] New review: awjrichards; "Looks/works fine, minor quibble with doxygen format" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/46649 [18:51:56] notnarayan: hmm, nice :) [18:52:05] YuviPanda: :) [18:52:15] can you get rid of the alternate screens so we could settle? [18:52:22] jgonera, there's a JS error on Special:Nearby in Firefox - can you take a look? [18:52:27] also we're not doing multiple selections on iteration 1 [18:52:59] notnarayan: but I've enough to go on :) [18:52:59] YuviPanda: yes. ill do that tom morning. [18:53:02] for now [18:53:15] YuviPanda: great! [18:53:17] notnarayan: :) [18:53:32] YuviPanda: ill do that tom morning. good night [18:53:40] :D [18:53:49] awjr, replied at https://gerrit.wikimedia.org/r/#/c/46649/ [18:55:37] awjr: can we do our 1:1 earlier [18:55:47] ? [18:56:33] * tfinc is amused at "Arthur dealing with a plumber 12:30 - 1" ... is pretty sure awjr is not amused [18:56:34] tfinc: sure i think im going to be free all afternoon (in spite of what my calendar currently says) [18:56:43] tfinc: no, im not - and he's coming early :p [18:56:46] like, in a few minutes [18:57:07] * YuviPanda cracks plumber joke. [18:57:21] im open any time after 12:30. your my only afternoon meeting so id like to get it done sooner [18:57:21] MaxSem, will have a look at it in ~30 min ok? [18:57:29] does anyone know what's going on with Jon? [18:57:35] but story prioritization is going to be rescheduled til tomorrow, and i think the central notice meeting isn't happening today since jon is sick [18:57:37] jgonera: jon is sick [18:57:44] jgonera, he's ill [19:02:39] jgonera: are you able to meet with matt walker re card #348 in jon's place? [19:03:07] if not, i'll let matt know since i dont think jon's emailed him [19:05:45] New review: awjrichards; "This does not resolve the fatal for me. Also, is this really how we should be handling the the mobil..." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/46648 [19:06:40] Maryana: we have mobile and beta-specific special pages that are currently accessible from outside of mobile and outside of beta, which is currently causing errors (sometimes fatal errors) and/or very weird behavior (like trying to login via Special:UserLogin from mobile when not in beta) [19:07:06] Maryana: we need to figure out what the actual behavior should be in the instances when those pages are accessed from places they shouldn't be [19:07:27] Maryana: Just a check - it's okay if I create a test schema for eventlogging, right? [19:07:42] awjr: oh dear [19:08:21] yuvipanda: yeah, of course! [19:08:24] sweet :) [19:08:27] awjr: spike? [19:08:27] Maryana: yeah :( [19:08:36] Maryana: i dunno actually [19:08:42] we can probably just figure out what we want to do without a spike [19:08:44] for next iteration? or is this something we need to hunker down and fix asap [19:08:50] ok [19:09:09] Maryana: in the case of the fatal errors, we can put stuff in place to stop them from being fatals for the time being [19:09:15] but, we should figure out what the actual UX should be [19:09:38] make sense? emergency-ish fix for explosions now, longer term UX-decision fix maybe next iteration [19:09:46] well, some of these problems are going to go away when we promote login & watchlist to stable [19:09:51] that is a good point [19:10:09] are there other pages causing problems? i'm sure it'll all happen again when we create new beta features [19:10:23] so we should still come up with a UX solution, you're right [19:10:33] Maryana: we will need to fix it for things like Special:DonateImage [19:11:00] right [19:11:10] so basically all the special pages in beta/alpha? [19:11:14] Maryana: yah [19:11:21] barg! [19:11:44] the two scenarios that we need to deal with are 1) what happens when those pages get accessed from desktop site 2) what happens when they're accessed from someone not in beta [19:12:14] i'll try to do a quick audit of this with munaf [19:12:20] Maryana: thanks :) [19:12:55] np [19:21:30] OuKB: re-responded [19:22:28] awjr: munaf and i just chatted a bit about the beta/alpha features weirdness [19:22:54] i'm less concerned about the scenario where a user types in a mobile URL on desktop - that seems like an edge case that won't happen so much [19:23:44] for the scenario where a user opts out of beta and still sees the message to log in and view beta features, i think the easiest solution is just to make the messaging a bit clearer on the error screen [19:24:09] Maryana: ok, can we at least decide in that instance whether or not we force the mobile view and show the feature anyway OR show the user some kind of error? the current problem with desktop views is throwing fatal errors, which we need to fix regardless [19:24:32] oh, hmmm [19:24:53] i suppose we should force mobile view [19:25:02] New patchset: MaxSem; "Reduce dependency on $wgExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46649 [19:25:24] Maryana: ok cool, i think that is the easiest thing to do for now :) [19:25:29] sweet [19:25:45] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46649 [19:27:28] [Commons-iOS] brion pushed 1 new commit to master: https://github.com/wikimedia/Commons-iOS/commit/281e650697c0a8bc005b52b585fc4c94149a796a [19:27:28] Commons-iOS/master 281e650 Brion Vibber: Make 'debug mode' switch work... [19:29:15] Can someone review this pull request to Wikisource mobile, please? https://github.com/wikimedia/WikisourceMobile/pull/1 [19:31:54] Tpt_: lemme just confirm it compiles for me :) [19:34:03] New review: awjrichards; "It's because $this->mobileView in MobileContext is already set before $this->forceMobileView is set...." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/46648 [19:35:08] tfinc: i can meet even earlier now if you prefer, my afternoon is wide open and the plumber has now been dealt with [19:35:20] brion: Thanks :-) . The translation is now pretty good, I believe that the app is now ready for publication. [19:35:32] awjr: how about 12:30 ? [19:35:47] Maryana, one thing in https://mingle.corp.wikimedia.org/projects/mobile/cards/332, it says that the thumbnail should show up on the page even before the upload is finished [19:36:07] can we show it after the upload? [19:36:35] this is a) easier, b) might make it possible to support more phones than we do for photo uploads in future (older phones) [19:36:50] yeah, i supposed it's rather confusing to show a user their photo before it's actually in the article [19:37:06] in that case we should think about the loading behavior we want [19:37:11] scroller? [19:37:17] well, it's optimistic, it assumes that everything will go ok ;) [19:37:26] ha, yeah… not always the case [19:37:46] tfinc great [19:37:58] Tpt_: ok it compiles and runs for me, that's good :D [19:38:22] merged. [19:39:32] brion: Thanks. :-) I've tested all features with my Nexus S. [19:41:39] brion: re: action=preparecreateaccount [19:41:46] brion: that vs how action=login does it [19:41:57] which is, first request gives you a token, and then you do it agian [19:42:02] any reason not to prefer the latter? [19:42:05] that works too i suppose [19:42:07] since it is mroe self contained [19:49:44] brion: Now that the Wikisource app is in Wikimedia repository and works, I believe, pretty fine, what is the next action to do in order to see it published in the Play Store by Wikimedia? [19:51:20] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/sqa7mw [19:51:20] Commons-iOS/master ed2ed31 Brion Vibber: Fuller description format, include some categories. [19:52:11] Tpt_: that's probably up to tfinc -- we're still thinking about the best way to balance unsupported or community-supported apps [19:53:55] brion: Ok. I'll ask it to him. Because the Wikisource app is only the Wikipedia app with an other name and logo, I think that maintaining it isn't very hard. Thanks :-) [19:54:03] :) [20:19:03] New patchset: Jdlrobson; "make use of $wgMobileFrontendResourceTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46652 [20:19:55] New patchset: Jdlrobson; "make use of $wgMFResourceBoilerplate (refactor)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46652 [20:32:48] Reedy, have you received my announcement about Copenhagen? [20:33:28] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/PGwKHw [20:33:28] Commons-iOS/master f8d1748 Brion Vibber: Switch to native iPad interface instead of iPhone compat mode... [20:33:28] Commons-iOS/master 552d2b0 Brion Vibber: Fix photo chooser for iPad (must be in a popover) [21:05:13] [Commons-iOS] felixmo opened pull request #5: 'mwapi' now utilizes the network activity indicator in the status bar (master...master) http://git.io/NgS4jg [21:26:46] MaxSem: got a sec to chat about https://gerrit.wikimedia.org/r/#/c/46648/ ? [21:27:00] i swear i wasn't eating lunch for the last two hours... [21:27:09] sure [21:27:36] the problem seems to be that once MobileContext::mobileView is set, it can't be indirectly undone [21:27:40] so it gets called from MobileFrontendHooks::onSpecialPage_initList() for the first time [21:28:28] MaxSem: maybe we can define a list of special pages that should always get mobile view/ [21:28:34] I think that this caching makes sense, otherwise some parts of the software will assume that we're in mobile mode, some otherwise [21:28:52] i agree [21:29:47] MaxSem: sow hat about building some functionality into ShouldDisplayMobileViewInternal() to check specific special pages? [21:31:03] mmm, maybe create a common class for mobile special pages? list have a bad habit of bitrotting:) [21:31:23] interesting [21:31:31] i like that [21:35:06] MaxSem: actually that wont make solving the problem an easier [21:35:07] *any [21:35:21] because of the call in onSpecialpage_initList() [21:36:01] MaxSem what about defining our special pages in a separte config var and only add them to the special page list in onSpecialpage_initList() [21:36:07] but this way we can disable the special pages on non-mobile uniformly [21:36:23] how do you envision doing that? [21:36:52]