[00:00:12] oh [00:00:46] nevermind [00:00:57] it is working [00:01:41] Special:Nearby though is simultaneously giving me a 'no such special page' as well as asking me to use my computer's location [00:01:44] is that expected? [00:02:27] $wgMFNearby = true; [00:03:08] ahha [00:04:43] New review: awjrichards; "this is painful. please please please let's not forget to remove this." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/46882 [00:04:44] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46882 [00:05:07] hmm, why doesn't nearby work for desktop browsers even on alpha? [00:05:45] i assumed for me it was because i dont have any pages with coordinates [00:05:57] oh do you mean in prod? [00:06:15] everywhere [00:06:24] it simply spins forever [00:06:40] WFM [00:07:06] only after i accepted that it use my browser's location (im using desktop chrome) [00:08:06] hmm, in Safari I see "Unable to find you. Trying again.." [00:08:08] it seems to spin forever locally though rather than timing out or saying it can't find any articles [00:08:17] but not in FF or Opera.... [00:08:45] jgonera, can you take a look? ^^ [00:09:19] awjr, any objections if I deploy this fix tomorrow? [00:09:34] you mean it doesn't work in production in desktop browsers for you? [00:10:13] well, im now wondering if it actually makes sense for us to be linking to nearby in the article. the feature's got issues, we're having to put in a nasty hack in order for this to work… [00:10:49] jgonera, I mean lack of notification that location can't be determined [00:11:10] oh, when you don't allow the browser to send it? [00:11:16] yeah, it just keeps spinning [00:11:29] when I do but my browser doesn't know the location [00:11:37] hm [00:11:45] Maryana, MaxSem what if instead of linking to it, we said it was an upcoming feature, and we can announce the feature when it's a little more ready? [00:11:58] I don't know how to test it, how do I tell my browser not to know my location? ;) [00:12:08] i am not feeling awesome about a) the hack b) rushing this when things are wonky [00:12:16] jgonera, does your laptop have a GPS? [00:12:25] hmm, agreed, awjr [00:12:30] awjr, concur [00:12:34] I don't know? do Macbook Air have GPS? [00:12:35] consensus! [00:12:41] \o/ [00:12:46] MaxSem: can i revert that hack, then? [00:13:02] for some reason on Macs I always was able to get location in my browser but not on the Dell I have at home [00:13:06] so maybe they do [00:13:10] New patchset: MaxSem; "Revert "A stopgap measure to make Nearby to work for everyone with a link"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46891 [00:13:19] heh you beat me to it [00:13:22] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46891 [00:14:40] awjr, Maryana - any ideas about the precise blogpost wording? [00:15:42] https://www.mediawiki.org/w/index.php?title=Extension:GeoData/blogpost&diff=638224&oldid=637856 <-- looks ok? [00:16:12] almost [00:16:16] i've got another edit -one sec [00:17:41] https://www.mediawiki.org/w/index.php?title=Extension%3AGeoData%2Fblogpost&diff=638232&oldid=638224 [00:17:45] MaxSem, Maryana ^ [00:18:08] thumbs up! [00:18:19] hooray for future tense :) [00:18:27] \o/ [00:18:43] alright, I'll send guillom the diff [00:22:08] New review: awjrichards; "\o/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46891 [00:30:33] Maryana, again https://dl.dropbox.com/sh/nlxigq10fp2wu78/Tgi5oz5HM4/Mobile/Photo%20Uploads/Story%20332/332.png the "Error, try again" message, I don't think try again should be a link/button [00:30:37] what would it do anyway? [00:30:56] resubmit the file, i assume? [00:30:56] I can just show the Add photo button instead [00:31:00] hm [00:31:06] the same file? [00:31:19] ok, I see now [00:31:46] if that's too tricky, we can just leave it as a flat message and show the add photo button instead, yeah [00:32:14] actually, i'm worried that resubmit might create a lot of double and triple submitted files anyway [00:32:30] if the user keeps clicking out of frustration [00:32:39] it's your call [00:32:58] possibly, and I can't see many situations where actually doing the same thing wouldn't cause the same error again [00:33:50] I mean, apart from temporary problems with Internet connection, if there's an error it probably means I messed up something in the code and retrying won't help ;) [00:39:34] hehe [01:20:06] New patchset: Jdlrobson; "overhaul of special pages (bug 44355)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46894 [01:21:51] New patchset: Jdlrobson; "overhaul of special pages (bug 44042)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46894 [08:26:30] [Commons-iOS] dz1111 opened pull request #6: Adjusted "return" keys functionality in Settings view (master...master) http://git.io/gf_mzA [15:56:58] https://blog.wikimedia.org/2013/01/31/geodata-a-new-age-of-geotagging-on-wikipedia/ is out and I'm posting to the social media channels now [15:57:08] guillom: \o/ [16:01:11] done [16:15:15] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/FZjsOg [16:15:15] Commons-iOS/master 45afdc7 Daniel Zhang: advance text field with 'next' and dismiss keyboard with 'done' [16:15:15] Commons-iOS/master 4eb7c00 Brion Vibber: Merge pull request #6 from dz1111/master... [17:28:17] awjr: hey ho [17:28:28] * awjr waves to hashar [17:29:14] I am most probably not going to attend the beta labs standup scheduled in 3 hours [17:29:27] awjr: I got vertigo, probably cursed by flu :/ [17:29:35] oh no hashar! [17:29:38] that sucks :( [17:30:08] and I noticed you were out tomorrow [17:30:16] hashar: if you've done any beta labs work since we last talked, would you mind emailing folks about it what you've been up to? [17:30:20] hashar correct [17:30:28] although i dont think jcmish or MaxSem will be :) [17:31:06] going to email everyone, that is a good idea [17:38:11] I am here! [17:38:12] :D [17:38:17] * YuviPanda|food looks around [17:39:00] hashar: the flu has really made it way through the company :D [17:39:21] * YuviPanda hasn't caught it yet [17:39:24] jcmish: and I thought I was well protected [17:39:34] though I *did* get my finger hurt by what appears to be a very rusty piece of metal [17:39:43] YuviPanda: your place is probably too hot for the flu to properly spread out [17:40:11] YuviPanda: cross you fingers! [17:40:14] hashar: it is 21C and I can't go out without a jacket (cold!) [17:42:48] YuviPanda, it's -5 and I ventilate my room by opening the balcony door regularly [17:42:59] MaxSem: you are hard core, of course :) [17:43:18] must be like 15°C this afternoon [17:43:31] hashar: this is at 11:15, I'm sure it was a bit warmer during the afternoon [17:43:46] MaxSem: at -5C, I'll probably be in a state of cryogenic shock. [17:43:55] I remember my hands were trembling too much to hold a drink in Berlin [17:44:12] dude [17:44:19] I didn't melt in India [17:44:22] YuviPanda: yeah Berlin was a bit cold [17:44:29] you will not freeze in Russia [17:45:03] it was actually colder in Berlin than in Moscow [17:45:25] MaxSem: oh? [17:46:04] and definitely rainier [17:47:46] ah rainier, yes [17:50:47] awjr: are we having sprint planning today? [17:52:28] jcmish: yep! [17:52:38] going to sleep a bit with the alarm clock [17:52:48] Take care hashar [17:52:49] will attempt to attend the meeting :) [17:52:51] thx! [17:53:08] awjr: hmm I don't have it on my calendar same bat time same bat place? [17:55:12] jcmish: that is no good if you don't see it on your calendar - it should be at 2-3mst [17:55:16] same place [17:55:32] jcmish: can you confirm it's not there? your name is on the invite [17:56:42] looking ow [17:57:40] argh i see that it might have only moved for me but for no one else, since i wasnt the original creator of the event [17:57:46] nope not there and I'm on the original invite [17:57:49] AHA! [17:57:55] gah [17:57:56] suck [17:57:57] ok [17:58:02] i'll re-invite everyone [17:58:33] kayo [18:01:23] jcmish: ok, i set up a new invite - are you seeing it? [18:02:05] yessir just accepted it [18:02:07] thanks! [18:17:43] YuviPanda: yo. i can do a quick 15min check in now. or wait till 11. your call [18:18:02] tfinc: I can do 11, it's fine. [18:18:29] ok 11 it is [18:18:33] :) [18:18:56] hey YuviPanda [18:19:01] hey brion :) [18:19:06] how goes android? [18:19:18] brion: pretty swell! I've notifications from the background service comign through :) [18:19:34] niiice [18:19:44] i'm working on the contributions list for iOS [18:19:56] brion: are you picking from their pre-existing contributions too? [18:19:57] it can fetch your last 10 or so uploads and show little thumbs [18:20:01] yeah [18:20:31] brion: nice. I'm not doing that yet. [18:20:40] brion: i'm only going to show the uploads from their phones. [18:21:18] score one for iOS ;) [18:24:16] tfinc: mornin. pm [18:24:21] k [18:24:28] awjr: I just had my sync up with Maryana [18:24:39] she can't make the meeting today and Howie's out [18:24:49] lol [18:24:52] do you want me to run it tomorrow for you while you're out :D [18:25:08] it's ok, i rescheduled the quarterly review [18:25:12] aww [18:25:13] assuming tfinc is ok w/5-6 [18:25:17] Yay [18:25:21] quarterly review review [18:25:23] Maryana: its too late for me. lets do it earlier [18:25:42] oh, that probably got goofed up for you guys because the calendar invite only moved from yesterday to today on MY calendar :( [18:25:57] how's 3-4, tfinc? [18:26:05] better [18:26:18] the earlier the better [18:26:35] 3-4 works and we might even have a room with av then [18:26:49] awjr, want to join us 3-4? [18:29:10] Maryana: sure if possible, i dont mind catching up later though if it's a huge hassle for you guys [18:30:12] booked r31 so no hassle at all [18:30:18] baller [18:30:24] :) [18:30:36] ok so we're still on for prioritization today then? [18:30:42] yep [18:30:45] col [18:30:46] er [18:30:48] cool too [18:31:45] sorry about that scheduling confusion [18:32:32] no worries [18:44:35] * awjr waves to jdlrobson [18:44:48] jdlrobson: feeling better? [18:45:58] a little [18:46:05] i'm back in the office just don't make me talk too much [18:47:18] jdlrobson: ok :) although i do have a quick question for you - i was trying to explain the nature of the pagview counting problem around API requests in MobileFrontend and then realized i'm not sure i actually totally understand the problem. can you clear it up for me? [18:48:08] it's pretty simple really. Every page gets only the lead section and pulls the other sections via javascript. However we also hijack links to load entire pages (which counts as a page count) [18:48:17] brion: ping [18:48:20] We need to distinguish between these 2 events [18:48:24] YuviPanda: pong [18:48:36] brion: do we send custom useragents for the blackberry / windows apps? [18:48:41] drdee asked me about them earlier today [18:49:23] YuviPanda: not currently. [18:49:26] jdlrobson: when you say 'pulls the other sections via javascript' you mean an api request gets made for section content from JS, right? that's what i thought but when i watch network activity in chrome dev tools i dont see additional api requests get made when toggling sections [18:49:43] brion: oh, at all? [18:50:10] awjr: they don't run on toggling sections [18:50:10] t [18:50:12] hey run on page load [18:50:30] oh i see [18:51:02] YuviPanda: no, not sure if we can override it actually [18:51:07] oh :( [18:51:07] we could send extra headers though i think [18:51:23] really? we can add headers but can't modify current ones? [18:51:36] might be able to, i haven't tried [18:52:19] hmm, ok [18:53:18] may be able to just override User-Agent in XHR, dunno [18:54:18] https://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-setrequestheader says you can't though [18:55:30] hmmm [18:55:36] brion: on android / iOS we override it with a plugin [18:55:41] jdlrobson: so if i were explaining how this works to someone who doesn't know, is this accurate? When MobileFrontend loads a page, it will load the lead section only and the rest of the sections get loaded via an API request made by JS. In some cases, a page is initially loaded in MobileFrontend via API request as well. We need to be able to diferentiate between an API request used to just get content for sections and an API request made to load [18:56:03] yes [18:56:11] thanks jdlrobson [18:56:14] and it's the same api request [18:56:17] (crucially) [18:56:28] what is the 'it' to which you are referring? [18:57:16] and when you say 'same api request' do you meant he request URLs for two different requests look the same? [18:58:55] put another way, do you mean the API request made for just fetching sections looks the same as the API request made for loading the whole article (when an article is loaded dynamically)? [19:03:06] brion: were in r32 [19:03:08] come by [19:03:36] k [19:15:18] jdlrobson: nice meme today :p [19:15:41] threat by moustache [19:15:47] jdlrobson: did you take a look at the changes i made here? https://gerrit.wikimedia.org/r/#/c/46549/ [19:16:11] yup i was fine with them - you just changed visibility right? [19:16:20] no, i changed a few other things [19:16:23] (i sometimes forget that since I'm a js guy :P) [19:16:32] erg wish it was easy to diff patchsets [19:16:33] see SpecialDonateImage [19:16:36] man i know [19:16:37] 1 sec [19:16:51] i also changed how getLoginUrl() works a bit [19:17:40] ah so http://pastebin.com/36XPDMmL [19:17:51] correct [19:18:03] http://pastebin.com/vrty0Jsm with syntax highlighting [19:18:28] yeah, although dif'd the other way :) [19:18:41] ( - => + [19:18:43] er [19:18:56] i mean, the additions are subtractions and vice versa [19:18:58] ahh ok [19:19:05] yeh looks fine to me [19:19:21] cool - the one thing i was curious about though is what i did in the special page [19:19:38] since you took out the upload permission check [19:20:23] that looks fine [19:20:33] actually wait [19:20:37] no scrap that.. [19:20:43] as that test is run on the current wiki [19:20:58] * take away can upload check. Firstly this applies to the current wiki so is [19:20:59] wrong when uploads go elsewhere e.g. commons, secondly the page should be visible [19:21:00] to these users (in future we may want to tell them how they can upload) [19:21:01] ^ commit message [19:21:28] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46888 [19:22:04] ^ awjr [19:22:14] i see - i was thinking permissions would be the same thanks to SUL, but that actually might not be true [19:22:24] in fact, im pretty sure it isn't [19:22:36] well commons allows any registered user to upload [19:22:37] i [19:22:38] t [19:22:43] hunk wikipedia requires 10 edits or something like that? [19:23:11] that sounds right [19:23:21] awjr shall i update the patch set to remove the upload check in DonateImage ? [19:23:27] yeah go for it jdlrobson [19:23:29] you're right [19:25:28] New patchset: Jdlrobson; "clicking uploads when anon redirects to login (story 359)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46549 [19:25:29] awjr: ^ [19:26:06] i'm quite excited about having a MFResourceLoaderModule (https://gerrit.wikimedia.org/r/#/c/46885/) [19:26:20] gives us a lot of flexibility and should help cleanup SkinMobile.php a hell of a lot [19:27:08] jdlrobson: would that solve https://bugzilla.wikimedia.org/show_bug.cgi?id=44072? [19:27:31] not quite - i need to look at that today [19:27:35] was hoping to grab ori [19:27:58] i was starting to poke it last night but realized it was going to take some RL digging [19:28:13] and then also realized it might actually get fixed by other work we have planned [19:29:25] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46622 [19:30:48] hello tfinc [19:30:59] i'm already in the hangout. [19:31:00] [Commons-iOS] brion pushed 9 new commits to master: http://git.io/SqMCMQ [19:31:00] Commons-iOS/master 1171662 Brion Vibber: start on loading my contributions into the list... [19:31:00] Commons-iOS/master c50c199 Brion Vibber: separate localFile & thumbnailFile deletions [19:31:00] Commons-iOS/master 8b7b1fd Brion Vibber: fetch thumbnails in background after refresh... [19:31:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46549 [19:34:07] tfinc: https://office.wikimedia.org/wiki/User:Ypandian/Goals [19:42:01] New patchset: JGonera; "Overhaul photo upload code (#332)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46646 [19:44:47] New patchset: Jdlrobson; "scrub inline styles on dynamically loaded pages (alpha)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46970 [19:45:46] New review: JGonera; "This is ready to go I guess, the only remaining thing is the Cancel button (see commit message)." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46646 [19:48:25] tfinc: https://integration.mediawiki.org/nightly/mobile/android-commons/ [20:07:32] tfinc: moved https://office.wikimedia.org/wiki/Goals/2012-2013/Engineering/Yuvi_Panda and lists in the appropriate place [20:07:38] YuviPanda: thanks [20:08:36] brion: whom should i bug here re content api? [20:10:02] I just hit Cmd+Q instead of Ctrl+Q [20:10:03] * YuviPanda facepalms [20:10:23] yurik: the guys who just went to lunch [20:10:46] YuviPanda: switch to windows ;) [20:11:12] brion: sigh, will ping again in an hr [20:11:23] :) [20:12:09] heh, in the end the key to show quick docs turned out to be... F1 [20:12:12] who would've thought [20:12:27] old skool [20:13:00] hmm i want to refactor the login/account create code [20:13:38] brion: are you going to be writing the createaccount api code? or is that going to pass on to someone else? [20:14:35] YuviPanda: dunno we'll have to hash that out :) [20:21:30] brion: from what I read in that mail thread, actually creating it will fall into us, with inputs / help from E3 folks. [20:21:47] probably yeah [20:22:30] brion: you think you have enough bandwidth to handle this within, say, the month? [20:22:39] yeah [20:22:44] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/WA4C8g [20:22:44] Commons-iOS/master 418b628 Brion Vibber: Show spinner while loading remote images on detail view [20:22:59] brion: alright, sweet then :) [20:23:03] wheeeee [20:23:24] brion: functionality wise, I guess the iOS app is ahead of android now :) [20:23:29] except for background uploading [20:23:40] nice :) [20:24:29] https://upload.wikimedia.org/wikipedia/test/9/9d/Screen_Shot_2013-01-31_at_12.23.18_PM.png \o/ [20:24:43] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46894 [20:24:57] whee! :) [20:25:25] workflow needs some work and the detail view sucks for already-uploaded photos, but it's coming along nicely [20:25:58] nice :) [20:26:17] so i've got so many phones and iPods and tablets now that i ordered a 28-port USB hub so i can charge them all easily [20:26:23] waaah [20:26:32] yepii! =) [20:26:40] hmm, I should've asked people to ship some USB cables with Alolita :P [20:27:00] heh [20:27:22] New review: awjrichards; "you're still using '+' to merge arrays. no bueno! use array_merge() instead." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46652 [20:28:46] bleh, http://www.mediawiki.org/wiki/Special:Nearby still doesn't ask the browser to allow anything [20:29:31] yurik: IIRC it is broken on desktops, awjr is working on a fix. [20:29:50] YuviPanda: just checked on an older android [20:29:58] (or that is the impression I got) [20:29:58] same thing [20:30:09] did you opt into the alpha? [20:30:30] awjr, mtg [20:36:31] New review: Jdlrobson; "Note this also breaks the Special:DonateImage page." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46646 [20:40:39] awjr: I'm going to run and grab food before our next meeting I may be about 5 mins late [20:42:05] awjr: VisualEditor team do https://gerrit.wikimedia.org/r/#/c/46652/ that [20:42:09] (use +) [20:42:30] yuck [20:43:13] awjr: wjr: [20:43:14] there are significant drawbacks to using + for this, particularly around the way in which in it used in the changeset (and how VisualEditor is using it) [20:43:16] awjr: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/VisualEditor.git;a=blob;f=VisualEditor.php;h=445cdec240ea4fbd2ce3cd2961093dacf7510bf3;hb=HEAD#l60 [20:43:46] i'd be interested in why rmoen|afk Krinkle|detached trevor and Roan do that.. i'm sure there is a reason? [20:44:50] + is generally safe if you're using associative arrays (which we are in this case). but when the two arrays share the same key, '+' will give primacy to the key/value of the leftmost array [20:45:18] why is that a problem? [20:45:27] what that means the way they are using it and the way that you've written it is that it is essentially impossible to override anything in $wgMFResourceBoilerplate [20:45:36] which is right [20:45:39] maybe that's what you intended? [20:45:41] we don't want those to be overriden [20:45:48] otherwise they shouldn't be in the boilerplate [20:45:53] i could see wanting 'raw' and/or 'targets' to be potentially overwritten [20:46:11] targets in particular [20:46:25] awjr: why targets? [20:46:37] for resources we want to load on desktop site, or both mobile and desktop [20:46:43] we already load one module specifically for desktop [20:47:05] if we made $wgMFResourceBoilerplate overridable, we could dynamically prepare all of our modules [20:47:14] (this is why mobile.desktop doesn't use the boilerplate [20:47:19] the boilerplate is only for mobile modules [20:47:40] we'd create a desktop boilerplate for that one if we wanted [20:47:56] i'm not convinced we'll ever need that awjr [20:48:17] jdlrobson: ok, then at the very least please rename the variable and a comment explaining the var [20:48:17] and if we do no big deal - we just need to rethink boilerplate and either create a new abstraction of it or make modules specify it themselves [20:48:38] awjr: what's wrong with the name $wgMFResourceBoilerplate ? [20:48:43] i already renamed it like you suggested.. [20:49:04] jdlrobson: well i thought it was a boilerplate for all MF modules, but you just said it was for mobile-only modules [20:49:35] awjr: suggest a name then - i hate naming things :) [20:49:51] $wgMFMobileResourceBoilerplate? [20:50:06] k [20:50:22] although saying that... [20:50:32] if something just targets desktop it's not MF right? [20:50:47] no, we have a module in MF targeted to desktop [20:50:50] it's being provided by MF [20:50:52] mobile.desktop has nothing to do with MF [20:50:57] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/xcw4HQ [20:50:57] Commons-iOS/master 8f5d43e Brion Vibber: Adjust size of titles in my uploads view... [20:51:04] it is provided by MF [20:51:05] so it's not a MF module as such.. [20:51:20] it is, in that it is provided by MF [20:51:22] and MFMobile just sounds like repeating the word Mobile [20:51:39] the first bit (MF) signifies the extension [20:51:54] it's convention for global var names and modules names [20:52:20] ok i don't care regardless just seems strange to me [20:53:50] New patchset: Jdlrobson; "make use of $wgMFResourceBoilerplate (refactor)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46652 [20:53:57] awjr: ^ [20:55:01] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/Mnmm0g [20:55:01] android-commons/master 2260078 YuviPanda: Added working (sortof) My Contributions screen... [20:55:38] brion: ^ I've my contributions, though they're fairly less sexy than yours :) And do not show contributions from desktop. But they are asynchronous! [20:55:44] Project Android-Commons (mobile) - Nightly builds build #16: SUCCESS in 45 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/16/ [20:55:44] yuvipanda: Added working (sortof) My Contributions screen [20:55:47] brion: I won't be in tomorrow, but do look through the code :) [20:56:06] it's still evolving, as I grok more of the best practices that came with new Android 4.x [20:56:18] spiff [20:56:24] whoa interesting, the array + operator is apparently hella faster than array_merge() [20:56:24] YuviPanda: oh are things fixed to work on 2.3 yet? [20:56:25] http://www.shesek.info/php/php-benchmark-the-array-plus-operator-vs-array_merge [20:57:03] brion: I'm unsure, actually :P I haven't done work on that yet - I've scheduled that for later next week. My test device will reach me over the weekend [20:57:04] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/IJh3_g [20:57:05] Commons-iOS/master 5693c8e Brion Vibber: add Daniel Zhang to credits (submitted a patch for keyboard nav fix) [20:57:05] Commons-iOS/master e4b9005 Brion Vibber: update README [20:57:29] brion: you seem to have some sort of magnetism, lots more patches for iOS app than for android [20:57:45] :) [20:57:57] awjr: if it's good enough for VisualEditor there is probably a reason ;-) [20:58:37] it's rare to see it in php and with good reason - it doesn't behave the way one would typically expect [20:58:45] brion: are you parsing data out of {{Information}}? [20:59:45] not yet but i will be [21:00:10] nice [21:00:30] jdlrobson: prioritization! [21:01:51] brion: also are you caching the images from the web? [21:02:29] i'm saving small square thumbnails to local disk; larger images coming from the web are HTTP-cached by the framework [21:02:42] which is nice cause i don't have to manually cache them :D [21:03:02] ah, nice [21:03:38] ok, still crashes on 2.3 :) [21:03:46] let's run it on 4.1 [21:03:52]