[18:00:30] MaxSem: you left before I remembered to discuss this with you yesterday, but I can manage today's deployment [18:00:45] that's not a problem [18:07:40] Reedy, you there? [18:28:54] New patchset: awjrichards; "(bug 44658) Ensures all query values (other than 'title') get passed on https login redirect" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47606 [18:44:24] YuviPanda: brion: actively add/edit/delete the backlog today : http://www.mediawiki.org/wiki/Apps/Commons#Backlog . I'll be looking at it in the afternoon and prioritizing [18:44:29] notnarayan: --^ [18:44:34] tfinc: ok! [18:44:41] whee [18:44:49] ok [18:44:58] tfinc: YuviPanda http://upload.wikimedia.org/wikipedia/commons/e/ea/Commons_single_image_screen.pdf [18:45:06] brion: ^ [18:45:37] nice [18:46:02] notnarayan: remember that usage will play nicely when we work on browse/discovery [18:46:03] notnarayan: we probably also want controls to 'share' a link to the image out to social networking [18:46:09] and to show license :) [18:46:15] and authorship [18:46:27] lets show the CC icons whenever we can [18:46:45] yeah i'm throwing in hardcoded CC-BY-SA 3.0 labels for now [18:46:52] which we'll make more real later :) [18:46:57] i know that we don't have them for all licenses but they fit so much more nicely on mobile [18:47:16] notnarayan: i like the 'upload similar' button [18:47:29] that would keep the existing categories etc? [18:47:35] brion: yes :) [18:47:39] sweet [18:47:43] i'll add that to the backlog :D [18:47:58] also a notification every time an image i contributed gets used somewhere [18:48:25] sharing my contribution on social networks would be great. [18:49:13] more for the backlog :D [18:50:50] tfinc: I'm working on the visual designs for android, will have a cut ready by today. icons and assets for android have been updated on http://commons.wikimedia.org/wiki/Category:Commons-mobile-app [18:50:55] brion: notnarayan also a 'post upload' screen of sorts, somewhere? [18:51:10] one like the one instagram has, which lets you pick which socnets to share on [18:51:31] notnarayan: are they linked from http://www.mediawiki.org/wiki/Commons_App ? [18:51:52] brion: removing 'My Contributions' from the backlog [18:52:06] \o/ [18:52:28] and I am making 'account tracking' into more generic terms [18:52:47] tfinc: there is a link to it on the section design assets needed [18:53:15] k [18:53:43] tfinc: will make a similar set for iOS tom [18:54:31] brion: I'm thinking we'll need some sort of Echo to be on before we can do the Notifications in the backlog (just checking) [18:54:48] YuviPanda: chat with kaldari to see where its at [18:54:55] he's been the main dev on it [18:54:56] YuviPanda: yeah we'll probably wait on that a bit [18:55:02] and will need infrastructure for the notifications [18:55:02] yeah, +1 on that. [18:55:14] brion: indeed, and will probably want to use device specific push [18:55:23] at least on Android I can 'fake' it by polling every hour or so [18:55:32] New review: awjrichards; "I think the team needs to consense on whether or not it's a good idea to add this as a precommit hoo..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/45505 [18:55:37] yeah, no background stuff on iOS :) [18:56:20] tfinc: will do. [18:57:22] brion: also, for sync - I'm just going to use logevents with upload/upload for now [18:57:29] ok [18:57:36] and see what to do about upload/overwrite later on [18:57:54] if we're looking at 'original media' contributions, then upload/upload should cover most of it [19:09:29] brion: hey! so while checking for internet connectivity, the only place where we technically need an active connection is during the upload right? there's no other instance where we'd need a net conn ? [19:10:00] Sohan: refreshing the contributions list and going into detail view on already-uploaded images needs a connection too [19:10:07] easy enough to error out tho [19:10:12] and login [19:10:34] oh right. so we're going to have a persistent login mechanism then [19:11:18] yeah [19:11:25] tfinc: question - is the granularity in the backlog enough for now (can be expanded tomorrow) or do you want to put more into it? [19:12:44] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/pgaI_w [19:12:44] Commons-iOS/master 05f91a8 Brion Vibber: Show license selector/viewer, currently hardcoded to CC-BY-SA 3.0... [19:13:26] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47388 [19:14:39] YuviPanda: i'll take a loook [19:14:45] ok [19:15:04] YuviPanda: worry more about the high level and then i'll start breaking them down [19:15:17] ok [19:15:17] New patchset: Jdlrobson; "module reorganisation (code health)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47608 [19:15:17] New patchset: Jdlrobson; "allow ResourceLoader modules to allow parsed messages (bug 43409)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46885 [19:15:18] New patchset: Jdlrobson; "Add template support to ResourceLoader" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47194 [19:15:18] New patchset: Jdlrobson; "deprecate registerModule and getModule (code health)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47513 [19:15:18] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [19:15:55] Change abandoned: Jdlrobson; "Merged into https://gerrit.wikimedia.org/r/#/c/47546/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47193 [19:16:40] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/R9RpTw [19:16:40] Commons-iOS/master 3951fa6 Brion Vibber: Add .gitignore with various files that should be excluded [19:21:23] awjr: MaxSem jgonera i'd really appreciate some review of https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:rlornication,n,z - it's giving me lots of rebasing headaches and RL headaches and i'd rather get it off my plate asap [19:21:38] sure, on it [19:21:56] jdlrobson, as soon as I make the changes to the events changeset [19:22:21] thanks MaxSem jgonera [19:22:45] jdlrobson: what makes you go with the smaller citation needed stickers? we'll have to do a run of 500 as social imprint doesn't do anything smaller . so we need to make sure were set on the size [19:28:33] jdlrobson, has the whole concept been passed by the RL team? [19:37:37] MaxSem: i've been getting advice i've asked them for feedback [19:37:51] we still need to make some changes in core [19:38:02] so still not quite using it properly! [19:38:29] so it's OK for me to merge if I don't see anything bad or some more work is required? [19:40:33] I'll poke trevor now [19:41:42] thanks [19:42:16] by the way, the deployment is nigh so nobody merge anything please [19:42:29] even though we have a cutoff rev [19:43:30] MaxSem: confused.. how so? I thought that was the point of the deployment cut off branch? [19:43:51] so MaxSem just chatted to trevor i'll have a chat with him about it later today (after 3pm) [19:44:05] because if we need to fix something during the deployment, we'd better not be confused by chqanges already merged [19:44:18] we can cherry pick no? [19:44:36] we can, but what if a manual merge will be required [19:44:46] so MaxSem just +1 about RL code if it is fine by you - no need to merge just yet [19:44:51] don't worry, just one hour is left [19:48:13] jdlrobson, I don't like that the module name MFResourceLoaderModule is very generic while in fact it's for parsed messages only [19:48:37] MaxSem: it's going to be more generic [19:48:49] (in later commit it adds templates for example) [19:55:27] New review: MaxSem; "See inline comments" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [19:57:17] New review: Jdlrobson; "This is a silly reason to -2 it." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45505 [20:02:13] whee, using log for contribs. win [20:06:39] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [20:06:39] New patchset: Jdlrobson; "module reorganisation (code health)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47608 [20:30:55] MaxSem: i just noticed https://gerrit.wikimedia.org/r/#/c/47619/ - are you planning on doing the deployment? [20:31:02] yes [20:31:19] oh - i thought i mentioned this morning that i would do it - but carry on :) [20:31:22] I replied that it's np that you can't deploy:) [20:31:30] hi jcmish, I just saw SauceLabs is releasing a new iOS test tool today, thought I'd let you know http://appium.io/ [20:31:57] MaxSem: now your reply makes more sense to me - but here's what i said: [20:32:00] 11:00 [20:32:01] awjr [20:32:01] 11:00 [20:32:01] awjr, duh - I actualy read "I can" as "I can't" [20:32:02] MaxSem: you left before I remembered to discuss this with you yesterday, but I can manage today's deployment [20:32:04] :p [20:32:09] jcmish: I think we're already getting most of the benefit of it already though [20:32:11] it's ok MaxSem, carry on - i'll get next week's [20:32:18] yeah:P [20:33:16] hey folks, check this out: http://en.m.wikipedia.beta.wmflabs.org/ [20:37:06] hmm seems broken chrismcmahon [20:37:13] awjr: how is the ops logging conversation going ? [20:37:22] tfinc: which one in particular? [20:37:38] tfinc: the one around mobile analytics? [20:37:58] having just spoken with Diederik he tells me their still blocked on us setting how we'll log (cookie, url's) page views [20:38:03] with ops [20:38:33] awjr: not got the bits yet, but the URL is up (he said, oversimplifying I'm sure) [20:38:37] chrismcmahon: funny I was just reading about it [20:38:42] chrismcmahon: :) [20:38:47] to see if it gives us anything new [20:38:57] jcmish: is all your travel settled ? [20:39:00] tfinc: yeah - we're still figuring out implementation details that will work for us as well as ops [20:39:13] tfinc: yes with the exception of the dinner we will have to go out with [20:39:21] tfinc: the conversation is happening on a wikitech-l thread [20:39:22] you and the wife too :D [20:39:46] jcmish: are you bringing the fam ? [20:40:04] awjr: what do you need to settle it so that we can unblock diederik ? [20:41:00] The hubby [20:41:10] he'll come Thursday night [20:41:18] and stay til Saturday with me [20:41:25] so we should grab a bite [20:42:04] tfinc: 1) settle implementation details ( i haven't looked at the thread yet today because i've been working on other things) 2) implement changes (we're already planning on slotting work for the next iteration) [20:42:21] tfinc diederik is aware of our timeline (not starting actual implementation til next iteration) [20:43:44] jcmish: nice. we can chat about how much he loves his iPad mini [20:44:03] awjr: k, short version ... next week [20:44:31] tfinc for mobile's implementation, yes. analytics will likely need to make changes based on the outcome of the discussion as well [20:44:38] k [20:44:44] tfinc: I couldn't wait… now I have one too :D [20:44:54] jcmish: you and brion-lunch [20:45:15] awjr: what's the guidance for the app team ? [20:45:16] ha! brion-lunch too! [20:45:31] wot [20:45:34] tfinc: ? [20:45:42] sorry, i dont understand [20:46:07] awjr: the app team is looking to accurately measure page views and need to know if any of the changes your making with analytics will impact them [20:46:27] at a high level. lets not make our data collection vastly different [20:47:21] tfinc: brion has been commenting on the thread. i haven't discussed any of this directly with the app team, but the conversation is happening transparently. should i more explicitly rope in YuviPanda/brion into this? [20:47:27] speaking of apps, do we have any stats of the J2ME app? [20:47:37] awjr: thats sounds good enough for now then [20:47:58] awjr: the header stuff? I think me / jdlrobson / brion responded about it on the internal thread? [20:50:08] YuviPanda: basically yeah - and yes you guys did, but the conversation has evolved considerably on wikitech-l based on feedback from ops; i pinged mobile-tech the other day to make sure everyone was aware and solicited review/comments from the rest of the team [20:50:15] MaxSem: not yet as Kul and Dan are still trying to find the right carrier for it [20:50:30] awjr: oh, I didn't realize. Will poke [20:50:31] :) [20:50:50] YuviPanda: this would be for the Wikipedia apps [20:51:05] tfinc: yeah, I realized [20:51:10] …and this is why nobody likes j2me apps, you can't just distribute them easily [20:52:41] brion: preaching to the choir [20:52:43] jdlrobson: do I owe you a workaround for $.toJSON for this deployment window? [20:52:55] ori-l: shouldn't no. [20:53:00] are you in office today? [20:53:04] would be good to catch up [20:53:09] and the cheapest phones can't run J2ME anyway, so it's stuck in a very narrow med-low-end segment [20:53:40] jdlrobson: I'm not but thinking of heading in [20:55:26] ori-l: :( [20:55:36] are you coming to beer js later today? [20:55:40] at benders bar [20:57:59] jdlrobson: hows beerjs these days? i remember the first one that i took you to [20:58:09] still beer involved [21:02:54] deploying things is go? [21:03:15] yes - updating testwiki ATM [21:03:54] haven't seen any response from ops to my heads up about a possible flush [21:04:24] :-/ [21:04:34] isn't ops all at FOSDEM right now? [21:04:47] i see a lot of empty desks on 3... [21:06:25] Maryana, since the eqiad migration flushes are a tricky thing, we might as well revert/deploy a fix if we see a need to flush [21:06:43] WHAT I'VE BEEN INSISTING ON FOR A LOT OF TIME.... [21:06:57] hrm [21:07:06] ok [21:07:41] i just *really* want the new lead image uploads in beta, so i can rally some editors to help us test it finally… [21:07:50] alright awjr, jcmish, jdlrobson, jgonera, Maryana - we're live on https://test.m.wikipedia.org/ [21:07:58] please test [21:09:30] woohoo [21:10:49] hmm, a save for wifi feature would be useless for me, since the wifi is slower than the 3G! [21:10:51] * YuviPanda shakes fist [21:11:19] i have a very strange bug report - i tapped on upload as a logged out user and got taken to the login screen. when i tapped browser back, i got taken back to the main page… but it was very small [21:11:30] not desktop view. just tiny mobile view [21:11:39] that is weird [21:13:40] yay the sticky https thing works [21:13:43] ahhh, and now it's doing the same thing, but the page is really big instead! [21:13:50] !!!! [21:13:51] this is very alice in wonderland [21:13:54] awjr: hurray for the https stuff :) [21:14:00] i'm so happy right now [21:14:49] New patchset: JGonera; "Move require()/define() to modules.js file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [21:14:50] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [21:14:51] Maryana: what device/browser are you using where you're seeing that? [21:17:14] bug found [21:19:43] oops me too [21:19:47] jdlrobson: what are you seeing [21:20:29] is test slow for you guys? [21:20:58] hmm nevermind my search is moving again :D [21:22:13] something's wrong with photo uploads [21:22:24] the button is shown everywhere [21:22:32] investigating... [21:23:06] so what's the branch we're deploying? deployment or master? [21:23:15] i am seeing a JS error on this article: https://test.m.wikipedia.org/wiki/Gerdos_uzduotis# [21:23:24] awjr - it looks fine now. must've been some ephemeral testwiki bug [21:23:25] jgonera: the branch is 'production' [21:23:45] New patchset: Jdlrobson; "Do not hijack returnto value in upload link (.noHijack)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47625 [21:23:46] ^ awjr [21:23:47] hmm i've tried to create an account twice now and both times received a varnish 503 error [21:23:58] can someone else try account creation please? [21:24:38] awjr: I can [21:24:45] I'm moving on to that test case anyway [21:25:21] thanks jcmish [21:25:25] jdlrobson, jgonera: i am seeing a JS error on this article: https://test.m.wikipedia.org/wiki/Gerdos_uzduotis# [21:25:30] awjr: yes i see [21:25:40] i'm wondering if it is because there are two h1s [21:25:48] ruhroh [21:26:38] awjr: yup varnish erro [21:26:42] r [21:26:44] same one [21:26:44] crappo [21:26:56] i wonder if that's testwiki being broken or something on our end :| [21:27:04] you know what's funny thouhg [21:27:06] *though [21:27:10] it created my user [21:27:27] I got the email asking for confirmation [21:27:34] so i think it's probably testwiki [21:27:51] * MaxSem shudders [21:28:18] awjr: yup the new user works too [21:28:27] just logged in after confirming the user [21:28:41] ok, let me finish reviewing jon's patch and i'll take a closer look [21:28:45] ok, I know what the bug with the button is, preparing a fix [21:29:27] should I branch from production or from master? [21:29:40] (for the fix) [21:29:46] awjr, MaxSem ^ [21:30:02] jgonera, commit to master then cherrypick to production [21:30:11] awjr: i think i know what that bug is [21:30:13] ok [21:30:14] *cherrypick when merged to master [21:30:47] awjr: i'm fixing the bug you've reported but it's nothing introduced by this weeks work [21:30:52] so not major [21:31:28] jdlrobson: https://gerrit.wikimedia.org/r/#/c/47625/1 does not seem to be working for me [21:31:34] awjr: ? [21:31:36] i've verrified that im seeing class='noHijack' in the button html [21:31:44] yes [21:31:53] and what does the href say? [21:32:13] but it still wants to send me back to the article i had been looking at (Rather than Special:DonateImage) and the login page title hasn't changed [21:32:51] jdlrobson: the href includes returnto=San_Francisco (the article im looking at) [21:34:13] so the http CTA bug was fixed and when i tap the star on an article, log in, & return to the article, i get the article watched for me - but i don't get any toast :-/ [21:34:49] testwiki bug or real bug? [21:35:20] * YuviPanda pokes brion [21:35:20] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/xT4rHQ [21:35:20] android-commons/master eac6807 YuviPanda: Added Sync Provider for syncing previous contributions [21:35:30] YuviPanda: what upppp [21:35:32] brion: ^ biggish commit, uses eventlog for sync :) [21:35:44] look at it / test when you have the time! (Remember to uninstall previous app!) [21:35:56] sweet [21:36:04] has one bug which adds dupe entries on your list when you upload stuff, gotta fix that [21:36:19] brion: plus needs a fair bit of refactor too - got too ad-hoc-y for my tastes now [21:36:23] My phone happily installs it over the top [21:36:27] Project Android-Commons (mobile) - Nightly builds build #37: SUCCESS in 1 min 8 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/37/ [21:36:28] yuvipanda: Added Sync Provider for syncing previous contributions [21:36:35] Reedy: it will, it might or might not work [21:36:53] Reedy: because I'm changing the internal sqlite database structure nilly willy, without adding upgrade scripts [21:37:09] so it'll crash at some weird place with an error about not finding column number -1... [21:37:32] well that's just mean [21:37:54] :) [21:37:54] Maryana: sorry was testing and just saw this [21:38:04] Maryana: what is "toast" [21:38:13] the little black bar notice at the bottom [21:38:31] i see it whenever i tap the star as a logged in user normally [21:38:51] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=44691 no quick fix i'm afraid [21:39:21] awjr: not quite sure why my fix would keep returnto=San_Francisco - are you sure your not caching? [21:39:25] ok jdlrobson, thakns for filing a but [21:39:37] jdlrobson: i thought i was sure but i will dbl check in a sec [21:39:54] New patchset: JGonera; "Don't show photo upload button on pages without #content_0" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47666 [21:40:09] MaxSem, fix for photo uploads ^ [21:40:13] wow my captcha word was just 'uddersmash' [21:40:39] jdlrobson, can you review^? [21:40:40] MaxSem, no, wait [21:41:23] MaxSem, sorry, it's ok, we're good ;) [21:41:29] HAHHA [21:41:34] awjr: you made that up [21:41:51] hehehe jcmish, nope :p [21:41:55] Maryana: aha! [21:42:24] arggg awjr typo [21:42:55] New patchset: Jdlrobson; "Do not hijack returnto value in upload link (.noHijack)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47625 [21:42:56] ^ awjr [21:42:58] MaxSem: yes [21:43:10] http://tropsavoirienconnaitre.blogspot.com/2013/01/wikipedia-et-letrange-interet-pour-son.html [21:43:18] awjr, at least it wasn't that ^ [21:43:22] YuviPanda: got a binary or should i install from src? [21:43:28] lol [21:43:55] rofl // Update: OH DEAR GOD WHAT A HORRIBLE HACK I AM SO SORRY [21:44:53] i am concerned about the 503 on account creation on test but i cant tell what might be causing it, the errors are vague. [21:45:04] jcmish: can you do me a favor and try account creation on desktop on test? [21:45:20] awjr: yup will do right now [21:46:38] jdlrobson: the updateUILinks() thing seems really hacky, why does that exist? [21:46:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47625 [21:47:14] jdlrobson: i merged the changeset [21:47:27] awjr: jcmish: the first experimental mobile support in 'beta' : http://en.m.wikipedia.beta.wmflabs.org/ ;-D [21:47:40] hashar: \o/ [21:47:41] wow hashar!!! [21:47:45] awjr: jcmish: still need some polishing, but we at least now have some kind of a page showing up \O/ [21:47:56] awjr: no error on desktop account creation [21:48:15] jcmish: ok thakns; that only kind of narrows things down :p [21:48:17] hashar and MaxSem thanks for that [21:48:22] that's so awesome! [21:48:28] + andrew boggot :-] [21:49:25] heading bed for now *wave* [21:50:53] ok i pinged in #wikimedia-operations about the 503 error on test. it's possible we'll get no response at the moment - i dont think we should block deployment on this since login works and the features are in beta anyway [21:51:17] hashar: I know but Andrew wasn't here for me to thanks [21:51:24] so I'll thank him on our call [21:51:28] sleep well! [21:51:31] jcmish: thx! [21:51:45] do we need anything other than https://gerrit.wikimedia.org/r/47666 ? [21:51:48] account creation works fine for me locally (with https, centralauth, and varnish) [21:51:58] MaxSem yeah [21:52:10] MaxSem: https://gerrit.wikimedia.org/r/#/c/47625/ [21:52:22] grrr [21:52:42] I can't cherrypick 47625 into prod [21:52:54] well, it cherrypicks [21:53:07] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/bAK8rw [21:53:07] android-commons/master 859065f YuviPanda: Enable contributions sync provider by default! [21:53:15] but `git review production` says nothing to push [21:53:39] my bad [21:53:56] Project Android-Commons (mobile) - Nightly builds build #38: SUCCESS in 30 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/38/ [21:53:57] yuvipanda: Enable contributions sync provider by default! [21:54:22] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/1dLNYg [21:54:22] Commons-iOS/master bc886b3 Brion Vibber: reorg table view to be larger [21:54:22] Commons-iOS/master 2409e20 Brion Vibber: Switch from TableView to CollectionView... [21:55:01] jdlrobson, can you cherrypick https://gerrit.wikimedia.org/r/#/c/47625/ into prod? [21:56:30] awjr: k [21:56:33] mmm, done. good night everyone! Happy deploying! [21:56:35] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/GPnG0A [21:56:35] android-commons/master eb3f0a4 YuviPanda: Name the sync adapter for contributions [21:56:39] awjr: noooo [21:56:51] oh sorry misunderstood [21:56:53] eh, jdlrobson? [21:56:54] Project Android-Commons (mobile) - Nightly builds build #39: SUCCESS in 24 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/39/ [21:56:55] ol [21:56:55] yuvipanda: Name the sync adapter for contributions [21:56:58] er [21:57:00] ok [21:57:11] MaxSem: patch https://gerrit.wikimedia.org/r/#/c/47625/ in is fine for production [21:58:20] hahahha [21:58:28] jdlrobson: I was like uhoh noo what :D [21:58:43] New patchset: MaxSem; "Do not hijack returnto value in upload link (.noHijack)" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/47667 [21:58:51] fuck [21:58:58] had to do that from Linux [21:59:06] YuviPanda: syncing seems to be working… but it's showing my oldest stuff at top [21:59:13] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/47667 [21:59:17] New review: Jdlrobson; "As discussed with Julisuz let's fix bug https://bugzilla.wikimedia.org/show_bug.cgi?id=43271 rather ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/47666 [21:59:19] i probably don't immediately care about Breakfast.jpg uploaded in 2006 :) [21:59:21] brion: hmmm? I thought I had fixed it [21:59:40] the images also seem to load verrrrrrrry slowly/intermittently [21:59:46] a lot of them aren't showing [21:59:50] brion: did you uninstall and reinstall? [21:59:55] sooo [22:00:08] if https://gerrit.wikimedia.org/r/47666 is a -2, are we good to go? [22:00:14] ok, MaxSem, we're not merging this fix, it's not a big deal [22:00:19] we are good to go [22:00:19] YuviPanda: yep [22:00:24] hmmm that's wierd [22:00:40] jcmish, fine for you too? [22:01:24] yup [22:02:20] do we need extra testing for https://gerrit.wikimedia.org/r/#/c/47625/ ? [22:02:52] YuviPanda: new picture taken with camera shows at top though... [22:03:17] I'd like to run through it on test MaxSem [22:03:19] just to be sure [22:03:42] Change abandoned: JGonera; "Will fix properly in the next iteration." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47666 [22:04:08] brion: data's all there, I just need to figure out appropriate sorting order. I think I've figured what's up. [22:04:17] yay [22:04:49] jcmish, it's now live on test [22:04:54] i'm redoing the uploads list on iOS to be a grid view like what you've got on android. it's looking awesome… will have to use a compat library for iOS 5 though :P [22:05:22] New review: Jdlrobson; "Merge post deployment" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/47183 [22:06:18] thanks MaxSem [22:07:25] brion: brion fixed :) [22:07:35] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/_WtmyA [22:07:35] android-commons/master 9f51fdf YuviPanda: Re-jiggle sort order of contributions [22:07:40] are we scapping? can i pop out for 10 min to get foodz? [22:07:57] Project Android-Commons (mobile) - Nightly builds build #40: SUCCESS in 27 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/40/ [22:07:58] yuvipanda: Re-jiggle sort order of contributions [22:09:01] brion: sweet :) pagination too? [22:09:17] not yet, i'm lazy ;) [22:09:23] just grabbing the last 100 or so items for now [22:09:52] heh :) [22:10:05] about to switch it to fetching thumbs dynamically [22:10:05] brion: so I'm not really doing pagination. [22:10:16] the first time it syncs, it syncs all the last 500 uploads [22:10:21]