[00:04:42] New review: JGonera; "I just realized it doesn't work. You don't load mobile.beta.dependencies anywhere and so the license..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46885 [00:11:59] why does the "Sign up" link in beta take me to a login page instead ? [00:15:31] New review: JGonera; "Just minor comments. I'd still be glad if we had tests for this sooner than later. It's going to be ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47194 [00:17:04] New review: awjrichards; "The way the pre-commit hooks are currently done in MobileFrontend makes them all-or-nothing. Maybe t..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/45505 [00:18:15] awjr, any opinion on adding mobileTargets property in https://gerrit.wikimedia.org/r/#/c/47546 ? [00:18:30] I was wondering if this couldn't be simply solved with dependencies [00:18:49] jgonera: will take a look when i can [00:18:52] ok [00:22:54] New review: Jdlrobson; "Not true at all. You have to enable it via" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45505 [00:27:59] New review: JGonera; "I'd also split the pre-commit script into several scripts." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45505 [00:28:45] New review: awjrichards; "I think you proved my 'all-or-nothing' point - at least without having to make modifications to what..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/45505 [00:31:58] tfinc sorry, computer weirdness one sec [00:32:06] l [00:32:07] k [00:32:18] New patchset: Jdlrobson; "allow ResourceLoader modules to allow parsed messages (bug 43409)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46885 [00:33:36] New review: Jdlrobson; "Fixed missing message due to the bad implementation of RL we currently have (good catch Juliusz)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46885 [00:33:41] awjr: now your frozen [00:35:04] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47183 [00:39:16] New review: Jdlrobson; "Agree in principle but merging https://gerrit.wikimedia.org/r/#/c/47546/ will actually reduce the co..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47623 [00:39:32] New review: Jdlrobson; "(lets merge https://gerrit.wikimedia.org/r/#/c/47546/ first)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47623 [00:42:54] tfinc lost you again :( [00:43:01] awjr: i'm switching to wired [00:43:04] k [00:48:00] New review: JGonera; "I can't wait for this to get merged. I really want to get rid of the JS-but-no-jQuery mode." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [00:49:58] New review: Jdlrobson; "The problem with this technique is that modules such as EventLogging which want to run on desktop an..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47546 [00:53:27] ^ jgonera replied to your comments [00:54:35] jdlrobson, I don't understand the non-inline reply [00:54:41] I can't see the problem [00:54:52] ? [00:54:55] with EventLogging ? [00:55:27] well EventLogging sets targets=>array('mobile', 'desktop') [00:55:35] if it adds a dependency to mobile.stable [00:55:48] mobile.stable is not loaded on desktop as it only targets => array('mobile') [00:56:03] if a dependency is missing RL throws an exception so on desktop EventLogging would no longer work [00:56:10] does that make sense? [00:56:21] ^ jgonera [00:56:34] but why would eventlogging add a dependency to mobile.stable? mobile.stable should have a dependency on eventlogging [00:57:05] just look at everything the other way round ;) [00:58:48] jdlrobson, ^ [00:59:26] jgonera: but that's bad too [00:59:33] why? [00:59:42] that means every extension has to add a patch to MobileFrontend to get their code to run [01:00:02] huh? [01:00:04] that's not how MediaWiki works [01:00:18] well in the current method EventLogging just needs to add mobileTargets to it's module definition [01:00:26] in this way EventLogging needs to edit MobileFrontend extension [01:00:35] and we add a dependency to EventLogging [01:00:56] (so no one would be able to install MobileFrontend without EventLogging) [01:01:13] I'm just looking at it from the other side, it's not EventLogging that wants to use us, it's us that want to use EventLogging and therefore we depend on it [01:01:26] which I think is the wrong way round [01:01:44] we should be empowering teams to add stuff to mobile as scary as that sounds :) [01:02:20] ok, then let's make eventlogging an exception and just load it conditionally ;) we already have flags in config for geo, why not treat event logging the same way? [01:03:30] ok, so you basically want to let people decide if they want to add their mobile extension to stable, beta or alpha? [01:03:37] yes [01:03:43] i want to encourage the e3 team for instance to add things to alpha [01:03:52] without us being a blocker [01:04:18] why don't we just give them a config option that tells them in what mode mobile frontend is running? [01:04:18] if this becomes a problem we can always raise the flood gates slightly and add extra security / change the security [01:04:29] (they already have that in JS, just add PHP counterpart) [01:04:36] ? [01:05:09] w8, let me just check one thing [01:05:14] anyway i see what your saying about dependencies - it's just the other way of looking at it. I guess as team we need to decide which way we prefer [01:07:40] how are modules loaded on desktop? does desktop also iterate over all $wgResourceModules and just loads everything? [01:07:47] jgonera: also it would be great if we could drive a beta/stable mode for desktop :) [01:08:02] jgonera: i need to check with Trevor but currently he's ignoring me :( rmoen|afk < [01:08:16] then we need to change the name mobileTargets to something different ;) [01:10:18] where is the IRC archive for this channel available? [01:10:30] I'd add a link to what we just wrote to gerrit [01:10:44] and would wait to hear what others say [01:13:42] jgonera: good question :) [01:14:49] jgonera, jdlrobson: https://mingle.corp.wikimedia.org/projects/mobile/cards/405 [01:15:11] for next iteration :) [01:15:26] sweet [01:15:46] login standardization! [01:16:08] Maryana, will Munaf get some wireframe for that or we just decide ourselves? [01:16:14] New patchset: Jdlrobson; "only add images to watchlist view in alpha (alpha, 376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47681 [01:19:49] awjr: do we have graphs of near by usage ? [01:20:13] tfinc not that i know of, although it's possible max did something fancy [01:20:57] i'm adding a card for it then. you guys can resolve it if its already in place [01:20:59] New review: JGonera; "More discussion: https://gist.github.com/jgonera/00e48593191e48377aef" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [01:21:05] cool tfinc [01:21:29] oh man, gerrit is even too stupid to parse URLs properly [01:22:52] jgonera, yes, i'll ask him to update this so it doesn't look like it's in the chrome: https://www.dropbox.com/sh/5eu72n5m5665kso/BIhItpLPdO/Story%20359#f:359.png [01:23:01] done : https://mingle.corp.wikimedia.org/projects/mobile/cards/409 [01:23:39] groovy [01:24:38] Maryana, ok [01:24:49] i'm enjoying nearby already [01:28:44] New patchset: Jdlrobson; "Ensure Special:JavaScriptTest always runs in desktop mode (codehealth)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47683 [01:29:42] Maryana: hahaha (Rated the one below R) https://twitter.com/darrentbc/status/298945239568220162 [01:29:45] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/CjWTiA [01:29:45] Commons-iOS/master 4d078d3 Brion Vibber: Convert to fetch larger thumbs on demand... [01:32:43] New patchset: Jdlrobson; "only add images to watchlist view in alpha (alpha, 376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47681 [01:41:32] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/DVKDvw [01:41:32] Commons-iOS/master af8115c Brion Vibber: Only refresh thumbnail when changed [01:44:06] New patchset: Jdlrobson; "Fix MobileDiff when position fixed not available (beta, 376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47684 [01:44:57] New patchset: Jdlrobson; "add border to chevron of user info box on diff page (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47685 [01:55:45] New patchset: Jdlrobson; "Center header of diff page (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47686 [01:56:43] New patchset: Jdlrobson; "increase edit count text on diff view (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47687 [02:00:15] New patchset: Jdlrobson; "move bytes added closed to page title on diff view (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47689 [02:10:45] New patchset: Jdlrobson; "Add icon to left of bytes added/removed on diff page (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47692 [02:21:33] New patchset: Jdlrobson; "Make the title clickable on diff page (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47693 [02:23:47] New patchset: Mgrover; "now that bugzilla bug 44658" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47694 [02:26:09] New patchset: Jdlrobson; "make sure buttons in watchlist header are aligned correctly (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47695 [11:11:24] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/48nE5g [11:11:24] android-commons/master b4bdff5 YuviPanda: Added GPLv2 COPYING file... [11:11:57] Project Android-Commons (mobile) - Nightly builds build #41: SUCCESS in 36 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/41/ [11:11:57] yuvipanda: Added GPLv2 COPYING file [11:38:47] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/dfbgQQ [11:38:47] android-commons/master b4c1c2a YuviPanda: Change DOWNLOAD to UPLOAD appropriately in constants... [11:39:06] Project Android-Commons (mobile) - Nightly builds build #42: SUCCESS in 23 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/42/ [11:39:06] yuvipanda: Change DOWNLOAD to UPLOAD appropriately in constants [13:47:34] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/Mgs-xw [13:47:34] android-commons/master b8dd312 YuviPanda: Save canonical filename of uploaded files... [13:48:04] Project Android-Commons (mobile) - Nightly builds build #43: SUCCESS in 34 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/43/ [13:48:05] yuvipanda: Save canonical filename of uploaded files [16:30:47] notnarayan: around? [16:30:57] yes RagePanda [16:31:07] back in BLR? [16:31:32] yes back in bhutan. [16:32:04] ah, nice. [16:32:39] RagePanda: be here, i have something to show you. [16:32:45] sure. [16:34:13] RagePanda: a teaser, http://upload.wikimedia.org/wikipedia/commons/9/9d/Commons-teaser.png [16:34:35] nicee! ) [16:34:41] * RagePanda likey [16:34:48] notnarayan: use the split actionbar thouh [16:34:50] *though [16:34:53] with actions at bottom [16:35:01] (of course, search still on top) [16:35:39] RagePanda: well launch gallery/camera no. [16:35:57] well, any actions in general, I think. It'll change according to which activity you are in [16:36:21] RagePanda: thats there [16:36:31] anyway, must get back to it :) [16:36:47] also I think examples for the campaigns should be more specific to make it easier to understand people. Someone will definitely come up and say that the campaigns are too generic ;) [16:37:04] RagePanda: yes [16:37:26] notnarayan: also, there might soon be 100s, 1000s of campaigns [16:37:32] so keep that in mind :) [16:37:50] RagePanda: i hope so. :) theser are top campaigns. the most active ones. [16:38:07] or the ones you're participating in [16:38:09] but yes, quite nice :) [16:39:14] notnarayan: also needed - icon for 'beta' version of commons :) [16:39:19] should go up on play store next week! [16:39:36] RagePanda: it would be interesting to show top campaigns cause if that changes everyday, just as the featured pic of today changes, it gives one a reason to check the app often [16:39:44] why so ragey? [16:39:57] MaxSem: had to interact with government mandated telecom stupidity. [16:39:57] MaxSem: hi. see http://upload.wikimedia.org/wikipedia/commons/9/9d/Commons-teaser.png [16:40:44] notnarayan, looks nice however no WMF wiki uses anything hashtagish [16:41:02] RagePanda: ^ [16:41:08] notnarayan: yeah, let's get rid of the '#' [16:41:15] we'll steal the concept, not the terminology :) [16:41:50] RagePanda, they still want you to participate in standups as a black rectangle? [16:42:30] MaxSem: that is unrelated. I was trying to get a few new sims for my nexus 7 and the other test device [16:43:42] RagePanda: should be RAGEPANDA. [16:44:00] well, people on #wikipedia-en do not like allcaps nicks :P [16:44:09] plus I'm not *that* ragey [16:44:12] didn't have to deal with college [16:44:13] so they want your ID, retina scan, finger- and buttprints? [16:44:14] for example [16:44:52] MaxSem: multiple IDs, can be activated only within normal-people-business hours, and I'll have to be in the same state as where I bought it until it activates (upto 2 days?) [16:45:22] MaxSem: I think I'm more ragey simply because people accept all this in the name of 'anti-terrorism' [16:45:26] than the actuall stuff itself [16:45:31] 'they must have a reason!' [16:45:33] reason my ass. [16:45:40] 'oh, let us go bomb this country!' [16:45:44] 'but... we can not get a sim!' [16:45:48] 'darn, our plan is spoilt!' [16:46:13] People with the IQ of a php array_ function [16:46:29] "OMG if you charge a phone with 220 volts, it will explode" [16:46:39] "let's ban all cellphones" [16:46:42] same idiots who essentially stopped all SMS service in the country because a few people were sending threats via SMS [16:47:38] MaxSem: 'rape happened in a bus with tinted glasses' 'ban all tinted glasses' [16:47:40] MaxSem: in south of india there is a concept that is more ragey than an ID retina scan and a finger print. Its called a "Jadagam" RagePanda [16:47:41] ^ true story. [16:47:45] RagePanda, I'm sure the bureaucratic fucks of our countries have a lot of things to reach each other:) [16:47:51] notnarayan: LALALALALA I CAN NOT HEAR YOU [16:48:08] s/reach/teach/ [16:48:18] indeed. [16:50:21] MaxSem: thank god there is no medium where people of different nationalities could come together to share their 'expertise'! [16:50:56] RagePanda, is the ID check enforced? I mean in Russia if you want to buy a sim but don't have an ID it will be registered for the poor guy who bought a sim before you [16:51:30] MaxSem: that used to happen too, but now 'enforcement' is worse. [16:51:34] (or better?) [16:54:16] wow, your government can actually enforce something? [16:54:41] why do you guys give a fuck what they're telling you? [16:56:53] as we Russians say, "the strictness of our laws is compensated by the lacking enforcement" [17:00:39] RagePanda: two meetings tonight [17:09:02] * MaxSem pokes awjr [17:09:05] * awjr waves [17:09:11] hi MaxSem [17:09:26] hey Arthur - want to chat about LevelUp? [17:09:54] sure MaxSem [17:10:50] so, do you have any ideas how you want us to proceed/what specifically do you want to learn? [17:10:57] heh no not really [17:11:01] otherwise, I have a plan... [17:11:03] i honestly haven't given it much thought yet [17:11:06] let's hear your plan :) [17:13:54] first stage, you read a book or an online tutorial - as you go you report what you're read and I help you if you have any questions and give you training tasks [17:14:09] I can't advice you a book, unfortunately [17:14:32] MaxSem: do you know any good tutorials/sites? [17:14:35] half of my C basics are from Turbo C built-in help anyway:) [17:14:41] heh [17:16:48] MaxSem: i am happy to get started with a book - i learn this kind of stuff best with a good reference book and tasks [17:17:11] MaxSem: maybe you can give me a training task that i try to complete by say, the end of next week? [17:17:26] mmmm [17:17:43] MaxSem: it doesn't have to be right now either - i probably wont focus on any of this til Friday [17:17:53] do you know what **p+++x does? [17:18:04] @_@ [17:18:05] no. [17:18:27] that's why you probably want to read a bit before starting with coding [17:18:32] it's aint no python [17:18:36] heh ok [17:22:36] somebody gets to write some C for varnish? [17:22:55] maybe after MaxSem gets me to levelup [17:23:10] achievement unlocked: double pointer dereference! [17:23:17] hehehe [17:23:55] MaxSem: this appears to be highly recommended: http://www.amazon.com/Programming-Language-2nd-Brian-Kernighan/dp/0131103628 [17:24:14] argh [17:24:28] there should be plenty of free online sources [17:25:00] i trust there are - but i have found i do better with this stuff when i have a physical book [17:27:41] "Publication Date: April 1, 1988" [17:27:43] this looks surprisingly thorough: http://www.iu.hio.no/~mark/CTutorial/CTutorial.html [17:27:53] yes, I've seen it [17:28:02] heh MaxSem yeah, this is another highly recommended one: http://www.amazon.com/exec/obidos/ASIN/0393969452/lynnallain [17:30:37] http://www.iu.hio.no/~mark/CTutorial/CTutorial.html appears pretty ancient [17:30:57] is ancient a bad thing? [17:31:01] i.e. assumed int type and so on [17:33:51] maybe I'm an old fart who have seen too many weird and crappy C compilers, but I'd like to have something that would allow to write a more portable code [17:34:02] MaxSem: **p++ + x or **p + ++x? [17:34:11] * RagePanda forgot how it associates [17:34:20] I suppose LTR, so that should be (1) [17:34:26] for example, modern GCC would output warnings from that tutorial's code [17:34:42] oh i ese [17:35:37] RagePanda, not exactly LTR (longer first, rather) but in principle you're right [17:36:29] longer in terms of? token size? [17:36:50] yes [17:37:08] aah [17:38:18] and stuff like http://lurkmore.so/images/c/c1/KYB-001.jpg [17:39:30] * RagePanda clikcs [17:40:52] MaxSem: is ++i++ + i even valid? [17:41:05] even i+++++i is valid [17:41:22] well that I can see [17:41:34] okay my question should've been ++i++ [17:41:37] without the +1 [17:41:38] err [17:41:39] + i [17:41:46] that is postfix and prefix on the same identifier [17:41:48] at the same time [17:41:55] a True C Programmer(tm) should be able to wrtie a short essay on why this code is UB [17:42:11] UB -> Utter Bonkers? [17:42:21] undefined behaviour [17:42:24] ah [17:51:59] MaxSem: there isn't really much C stuff around here, is there? [17:52:02] (in WMF, that is) [17:52:05] (except for Varnish) [17:52:44] also, there's the dreaded redirector.c [17:52:58] and some analytics pieces [17:53:05] and udp2log [17:53:14] sigh, nothing to just liesurely hack around [17:53:19] and PoolCounter [17:54:44] awjr, in principle http://www.cprogramming.com/tutorial.html looks sane [17:55:11] cool MaxSem [17:55:36] (just don't touch the C++ bits) [17:55:49] MaxSem: but with https://www.gnu.org/software/libc/manual/html_node/index.html C gets a lot... different no? [17:55:53] heh one thing at a time [17:55:58] * RagePanda hasn't actually done any C programming outside of glibc [17:57:01] RagePanda, glibc != ANSI C library [17:57:18] I meant glib, rather [17:57:29] glib is a lot better/worse depending on how you look at it, I guess [17:57:59] awjr: technical difficulties for standup [17:58:07] :( [17:58:12] chrome box won't connect to network [17:58:17] being troubleshooting for last 10 mins [17:58:20] noooooo [17:58:21] >_< [17:58:30] laptop? [17:58:33] network seems to be down [17:58:37] i can do wifi.. [17:59:18] wifi is usually a bust [17:59:31] i gotta log out and back in, webcam is acting up again [17:59:33] wifi works fine for me :P [17:59:50] awjr: that's a nice chair! [17:59:58] thanks, RagePanda :p [18:00:27] Hey, mobile team; quick question, is Shankar Narayan a new employee/contractor? Or a volunteer? Or an intern? [18:00:57] guillom: contractor i believe [18:01:24] hey guillom, Hi! I'm a contractor. :) [18:01:25] notnarayan, who are you?:P [18:01:31] brion: ok, thanks. They don't seem to have been announced on the list; do you think it's an oversight? [18:01:39] Oh, hello notnarayan :) [18:01:46] guillom: yeah, I think tfinc/howief would do that today. [18:01:47] i dunno nothing about announcements i just code ;) [18:01:49] notnarayan, standup!:) [18:01:59] Thanks RagePanda [18:02:02] MaxSem: now? [18:02:05] notnarayan: standup? [18:02:12] 2 mins ago [18:02:23] notnarayan: plz2join. [18:02:24] Alright, then I'll include you in the next monthly report :) Thanks [18:02:39] RagePanda: link [18:02:46] should be in your calendar? [18:02:48] notnarayan: https://plus.google.com/hangouts/_/8bc98160cdf0396821e2ba381099b56fde42cb0c [18:05:00] RagePanda, he's not in calendar [18:05:26] MaxSem: yeah, let's do that to [18:15:59] jdlrobson, did you receive Trevor's blessings on https://gerrit.wikimedia.org/r/#/c/46885/ ? [18:16:06] grrr [18:16:20] liefi [18:16:42] MaxSem: kai just committed to the OSM event :) [18:17:04] awjr, dude! you're awesome! [18:17:22] awjr: http://www.philly.com/philly/blogs/trending/VIDEO-hitchhiker-saves-woman-from-attack-gives-best-NSFW-interview-ever.html is kai? :P (/via jorm) [18:17:31] MaxSem :D [18:17:40] lol [18:17:46] RagePanda: different kai, i think :p [18:19:57] ragepanda, i'm pretty sure i already know the answer to this question, but do we have any way of tossing up banners on the android wikipedia app that specifically target one language project or geographic area? [18:20:28] Maryana: technically very possible. But the code for it does not exist yet :) [18:20:38] gotcha [18:21:01] there was an ask from fundraising - they're traveling the world and trying to reach out & talk to more mobile users [18:21:15] apparently, everybody in indonesia accesses wikipedia via android app :) [18:21:40] brion, do we have a phone which uses IE9? [18:21:59] jgonera: there should be an HTC Torch running Windows Phone 7.5, that has IE9 iirc [18:22:09] ok [18:22:27] Maryana: wah [18:22:33] we should probably pick up a WP8 device at some point too, test mobile IE10 [18:22:43] Maryana: I should really start giving them a better experience soon. [18:22:50] heheh, that was my thought, too [18:22:50] * RagePanda should pick up the full-native one sometime soon [18:23:03] somebody has to think of the indonesians [18:23:17] Maryana: did you see the PDF i mailed you? [18:23:17] :) [18:23:40] ragepanda: yes! [18:23:58] i'm pretty excited about this, post-uploads sprint [18:24:37] Maryana: indeed. me too! [18:24:50] New review: Jdlrobson; "There is a conversation on [WikimediaMobile] Showing .noprint elements on mobile. Let's make a call ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43852 [18:24:55] Maryana: I'd want to do this as a 'wikipedia app' proper from day 0, instead of trying to keep it general mediawiki compatible [18:25:18] so much code to write, so little time [18:25:21] yeah, especially since the sister projects all seem to be working on their own apps [18:26:39] can someone poke Jon to return to IRC?:) [18:28:13] MaxSem: poke successful :) [18:28:21] Maryana: well, those are just forks of the wikipedia app [18:28:21] RagePanda: https://test.wikipedia.org/wiki/File:Nexus_10_uploads_screen.png vs https://test.wikipedia.org/wiki/File:IPad_thingy.png :D [18:28:25] with minor modifications [18:28:27] jdlrobson, did you receive Trevor's blessings on https://gerrit.wikimedia.org/r/#/c/46885/ ? [18:28:38] * RagePanda clicks [18:28:41] MaxSem: Trevor was too busy :( [18:29:01] I'd suggest not getting blocked by Trevor provided it works [18:29:11] we can always refactor afterwards - i suspect i will need to do so anyway [18:29:13] brion: that is nice! [18:29:17] grr [18:29:19] okay [18:29:36] brion: needs more scary brion :) [18:29:39] MaxSem: he has helped me with that patch set so i'm sure it is fine [18:29:40] hehe [18:29:57] brion: I also have no padding, while you do. Dunno which is better [18:30:06] yeah i'm undecided on that [18:30:31] I think we've a meeting again now :P [18:30:35] yep [18:30:52] notnarayan: meeting! [18:31:07] RagePanda: I'm there [18:33:08] jgonera: can you rebase https://gerrit.wikimedia.org/r/#/c/47184/ [18:43:17] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47681 [18:50:37] jdlrobson, I'm having problems understanding getModifiedTime() in https://gerrit.wikimedia.org/r/#/c/46885/9/includes/modules/MFResourceLoaderModule.php [18:51:13] what does filemtime( __FILE__ ) achieve? [18:51:51] particular modules are not defined in this file [18:52:33] so getModifiedTIme is used to determine whether the cache needs to be broken [18:52:58] it's basically checking if the existing MFResourceLoaderModule.php file has been edited [18:53:03] ^ MaxSem [18:53:16] (note this is copied from VisualEditor) [18:54:06] MaxSem: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/VisualEditor.git;a=blob;f=VisualEditorMessagesModule.php;h=62612ae693562a5bd4f7bffe214a8925874a8041;hb=HEAD#l85 [18:54:09] but since that file doesn't gets changed when modules are changed, all this will not work [18:54:22] in VE, the situation is slightly different [18:55:09] VE's getMessageInfo() actually contains message definition [18:55:22] while your code simply uses a global defined elsewhere [18:55:48] thus, that global's changes will not invalidate cache [18:56:02] jgonera: http://jonrobson.me.uk/mobile/ [18:57:58] jdlrobson, ^^ [18:59:11] taking MobileFrontend.php's mtime would improve the situation, but not quite as messages can be changed on-wiki and these changes will not be picked up [18:59:28] (yeah, VE also has this problem, but still...) [19:00:33] brion: right on time, I guess? [19:00:38] yep :D [19:00:46] MaxSem: little confused.. surely if the message in i18n changes that's the only time it needs to get invalidated? [19:01:05] which is what $this->getMsgBlobMtime( $context->getLanguage() ) returns [19:01:13] jdlrobson, ever heard about the MediaWiki: namespace? ;) [19:01:33] brion: no tfinc yet [19:01:39] RagePanda: tfinc is in the hangout... [19:01:43] are we on the same link? [19:01:43] jgonera: http://nicolasgallagher.com/pure-css-speech-bubbles/demo/ [19:02:05] RagePanda: you clicking the hangout link in the invite? [19:02:19] RagePanda: https://plus.google.com/hangouts/_/b923618880a1a39dfed20721008d0395d709f898 [19:02:22] awjr, tfinc - do we need to chat about the OSM event? [19:02:34] do we? [19:02:39] you guys tell me [19:02:40] tfinc: we are in the wrong one i think [19:02:47] RagePanda: and also here's the ether pad: http://etherpad.wikimedia.org/MobileAppRetrospective [19:03:07] MaxSem: the what namespace ;-) [19:03:13] what's the issue there? [19:03:33] someone changes a message locally --> cache is not invalidated [19:03:40] MaxSem: i think we're fine at the moment unless there's something in particular you'd like to discuss [19:03:43] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47684 [19:04:03] the more messages a module has, the higher a chance of a screwup [19:04:19] MaxSem: can you quickly review https://gerrit.wikimedia.org/r/#/c/47606/ as well [19:05:45] done [19:05:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47606 [19:06:11] thanks MaxSem [19:06:27] MaxSem: so can we live with this screwup or could you make an adjustment that does the job? [19:06:41] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47685 [19:06:41] (also i'm not quite sure how to write phpunit tests which involve files) [19:06:52] can't think of a sane way... down with it for now [19:07:34] MaxSem: do you want to add a note to the code? [19:07:45] still no sign of trevor alas [19:09:20] New review: MaxSem; "See inline comments" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/46885 [19:09:29] tfinc: you're stuck in time! [19:09:30]