[00:00:39] ori-l: 1s [00:00:40] i managed to find a trevor [00:00:55] heh [00:05:03] awjr: so apparently according to Trevor the way to do this for the time being is to disable that global variable in a LocalSettings.php that is mobile specific... [00:06:46] jdlrobson, there's no such thing [00:07:15] we could create a post-initialize function in mobile.php that will unset it [00:07:36] gawd this feels wrong [00:07:40] New review: JGonera; "See inline comments." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47673 [00:07:56] awjr, this should be part of MF proper [00:08:13] well the problem itself should be fixed [00:08:35] but i think you're right MaxSem for now [00:09:16] we could use one of the RL hooks before it fully initialized [00:10:15] Krinkle says that any hook will be too late [00:10:22] :| [00:10:38] they are suggesting updating mobile.php as they changes to RL are not going to come any time soon.. [00:10:43] jdlrobson: any hook period or any RL hook? [00:12:37] ok a hook in MFE should work at the time where we 'enter mobile mode' e.g. detect mobile site should be launched [00:15:43] ^ awjr [00:16:10] so MaxSem 's approach seems a good un [00:16:12] we could add it to MobileContext::shouldDisplayMobileView() [00:16:43] $wgUseSiteJs = false; $wgAllowUserJs = false; should keep it pure [00:18:05] New review: JGonera; "Rebased. This blokcks https://gerrit.wikimedia.org/r/#/c/45912/ so it would be nice to get it merged." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47623 [00:19:11] awjr: just doing that now [00:20:02] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [00:20:19] ^ awjr MaxSem [00:22:18] jdlrobson, appears to be solved [00:22:28] \o/ [00:24:38] New review: JGonera; "Even if we keep mobileTargets, having stable and stableonly seems a bit clunky. I'd just explicitly ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [00:30:33] jdlrobson, I have more comments for the RL changeset, writing them now, sorry it's not nitpicking it's just big and I didn't notice some things at first [00:33:38] New review: JGonera; "Inline comments. Also see my previous non-inline comment." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [01:02:21] New review: awjrichards; "this changeset breaks unit tests:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [01:05:05] New patchset: awjrichards; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [01:05:48] New review: awjrichards; "php unit tests are still broken, but i amended the changeset to better encapsualate the JS diabling ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47546 [01:12:07] ok gonna take another look at https://gerrit.wikimedia.org/r/#/c/47546/ [01:25:54] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [01:27:40] Change abandoned: Jdlrobson; "Folding into other commit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47608 [01:27:59] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [01:40:53] New patchset: awjrichards; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [01:41:28] jdlrobson: thanks for fixing the broken tests; unfortunately your changesets overwrote some changes i had made, but i just added them back in [01:41:38] eek i was sure i picked the latest [01:41:43] * jdlrobson shakes fist at gerrit [01:41:50] heh no worries, not a big deal [01:42:07] gotta run - see ya! [01:42:14] k [02:03:52] New patchset: JGonera; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [02:06:38] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [09:58:58] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47846 [11:10:15] Hi! Are there any developers online? [15:22:25] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/47846 [15:22:26] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47846 [16:02:31] ping jcmish (in the correct channel this time) [16:17:38] YuviPanda: ping [16:17:44] pong [16:17:55] note that i'll be disappearing into whiskey and turkish alcohol soon :) [16:18:16] YuviPanda: ah! but before that, http://upload.wikimedia.org/wikipedia/commons/a/ad/Commons-ios-app.png [16:20:05] YuviPanda: what happened? [16:20:12] * YuviPanda clicks [16:20:17] oh nothing [16:20:26] loading [16:20:51] no agora colors? :P [16:21:03] notnarayan: also, there is something off about your sizing [16:21:12] YuviPanda: i used variants of the commons red dot. [16:21:14] 'cakes' would be *faaar* bigger [16:21:32] notnarayan: use agora colors or iOS colors no? Currently looks very gary [16:21:53] YuviPanda: whats gary? [16:21:57] the red [16:21:59] garish [16:22:06] and the font size is of [16:22:06] f [16:22:15] you're using a mnuch smaller font that what comes up in devices [16:22:31] YuviPanda: noted [16:22:32] 'famous paintings' will easily fill up more than half the screen on a normal readable font, for example [16:23:12] YuviPanda: tell me more/ [16:23:23] and no mosaics [16:23:41] they're not going to be implementable in the near future - will require a fair amount of time doing core algo work, and won't be good without a lot of testing even after. [16:23:45] stick to constant sized items [16:24:09] YuviPanda: i see. ok. [16:24:12] so [16:24:16] 1. use agora colors [16:24:22] 2. font sizes / general sizing is waaay off [16:24:26] 3. no mosaics [16:24:57] (2) is a big problem, because what looks great on a mockup can look pretty bad with normal sized readable text [16:25:16] at your current text sizes they'll be completely unreadable on devices [16:25:52] notnarayan: also, siebrand offered to have Pau help - he does have a PhD in mobile UX, I think. Perhaps he could help with the sizes [16:28:17] YuviPanda: ah yes [16:28:25] notnarayan: so email him? [16:28:34] YuviPanda: ill do that/ [16:28:37] :) [16:28:43] YuviPanda: did you show this to siebrand [16:28:56] no, he's on a video chat with his little kids [17:34:47] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [17:54:54] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/4Fpcrg [17:54:54] android-commons/master df950de YuviPanda: Added qq translation strings & removed unused strings... [17:55:33] Project Android-Commons (mobile) - Nightly builds build #47: SUCCESS in 37 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/47/ [17:55:34] yuvipanda: Added qq translation strings & removed unused strings [18:01:54] New review: JGonera; "I can fix those small things if you agree with them." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47546 [18:10:16] notnarayan: is https://commons.wikimedia.org/wiki/File:Commons-icon.svg rendering correctly? [18:10:22] the last arrow looks out of sorts to me [18:10:28] jdlrobson: Happy Wiki Anniversary! [18:10:44] :D jcmish [18:10:59] YuviPanda: thats strange [18:11:01] jdlrobson: happy getting introduced to my life anniversary :) [18:11:08] hahaha [18:11:11] :D [18:11:24] jdlrobson: we're going to ajanta on saturay [18:11:26] (probably) [18:11:31] oooohhh [18:11:33] jealous [18:11:38] won't be as good as ellora though ;-) [18:11:42] and it'll be my birthday :) [18:11:45] i saw! [18:11:47] jdlrobson: I think we might do both. [18:11:58] i noticed it in my calendar [18:12:01] who's "we" ? [18:12:03] :D [18:12:38] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [18:19:09] notnarayan: indeed, that's a bit off :| [18:19:29] YuviPanda: checking why and uploading a new [18:19:36] notnarayan: :) sweet [18:19:50] notnarayan: poke munaf / heatherw if you have trouble with that [18:21:10] YuviPanda: fixed https://commons.wikimedia.org/wiki/File:Commons-icon.svg [18:23:25] any brions around? [18:24:39] not yet [18:25:09] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [18:25:51] * YuviPanda waves at Maryana [18:26:02] Android App's now translations enabled! [18:26:05] howdy ho, yuvipanda [18:26:11] w00t! [18:26:38] hello Maryana! :) Drinking at pune with the language team folks, watching Nikerabbit add support for android to translatewiki :) [18:26:42] finally, the indonesians can have something in their own language [18:26:48] :D [18:26:49] indeed [18:26:55] well, they will once someone translates it :) [18:26:59] hehehe [18:27:13] yes, a vital step in the process [18:27:19] indeed. [18:28:19] you joining us for metrics in 30 minutes? [18:28:38] you have to see my masterpiece nearby + uploads demo [18:28:48] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [18:29:48] Maryana: ah yes, will do! [18:30:01] Maryana: will join the stream + IRC. You're there to do the wonderful demos :) [18:31:20] and brion's android demo, pre-recorded [18:31:43] Maryana: just to remember - we'll get an email with the link, etc a bit before it starts, right? [18:32:04] Maryana: sweet! I'll make a build for people to try out. https://bit.ly/android-commons will have it [18:32:31] praveena just sent out the email reminder [18:32:41] but it's in 30 min [18:32:53] no sure if she's doing another one immediately beforehand [18:32:58] ah ok [18:33:15] ah 2 minutes ago [18:33:15] *not [18:33:56] Maryana: can you include the URL in the presentation so that people who want to test can? [18:34:03] and mention it is only for Android 4.x right now? [18:34:11] i can indeed :) [18:34:23] wonderful :) [18:34:48] * YuviPanda sends Maryana some of the Ardberg Islay Single Malt he's having [18:35:17] hehe [18:35:24] i know it's heresy around here, but i'm more of a bourbon girl [18:38:13] awjr: MaxSem me and jgonera are just making some additional changes to the RL patch [18:38:22] awesome [18:38:31] ...the perennial RL patch:) [18:38:32] New patchset: Jdlrobson; "RL or nothing (story 393 - stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [18:38:35] Maryana: noted [18:38:54] YuviPanda: take pictures of whiskey and upload to commons [18:39:24] heheh [18:39:35] take a video of yourself explaining how to drink whiskey [18:39:38] and upload it to commons [18:39:49] :D [18:40:22] Maryana: :P I'll probably suck at it [18:40:25] vodka is still my favorite drink [18:41:13] YuviPanda: i frown at you. tsk tsk [18:41:44] YuviPanda: are you wearing a tie, cause this video http://www.youtube.com/watch?v=YVG1U-faqHY demands that you wear a tie [18:44:31] jgonera MaxSem awjr: review away let's get stuff unblocked :) https://gerrit.wikimedia.org/r/47546 [18:45:10] jdlrobson, you mean let's find another problem? >;] [18:45:23] :) [18:45:38] mmm, that was a Krogan smile [18:46:45] Maryana: consider yourself told - https://twitter.com/JDSuarez47/status/299363884547076096 - we need actionable cleanup templates :P [18:47:51] mmm YuviPanda http://tech2.in.com/features/web-services/with-3-billion-monthly-pageviews-wikipedia-mobile-drives-open-access/742872 "arthik Nadar, an avid Wikipedia editor from Mumbai, fires up the official Android app of the free, crowdsourced encyclopaedia on his slick, new smartphone whenever he needs to refer to it. Though the app doesn’t support editing, he finds it an efficient way to access Wikipedia on the move. Srikanth Ramakrishna [18:47:51] another prolific editor, from Coimbatore, uses the browser and 2G connection on his basic Java phone to look up Wikipedia" < is that official?! [18:48:21] jdlrobson: is what official? [18:48:30] the app he's using on his basic java phone [18:48:33] i've never seen it [18:48:42] jdlrobson: that's two different people [18:48:47] Karthik uses the app [18:48:52] Srikanth uses the web [18:48:56] ahh [18:48:58] 'uses the browser and 2G connection' [18:48:58] :P [18:49:04] so he's using your app [18:49:13] the picture threw me [18:49:16] Karthik? yes. [18:49:37] jdlrobson: i don't know what that screenshot it [18:49:46] that's probably an oooold old image from commons [18:49:52] from our ruby days [18:50:37] notnarayan: officially welcome :) [18:50:51] notnarayan: do you have an IRC cloak? [18:50:58] YuviPanda: yes! :) nice to see it. [18:51:08] notnarayan: if not, get one https://meta.wikimedia.org/wiki/IRC/Cloaks [18:51:11] YuviPanda: remind me what that is? [18:51:12] and then we can welcome you to the staff channel [18:54:19] notnarayan: ping [18:54:24] YuviPanda: yes [18:55:00] notnarayan: have the tablet handy? [18:55:20] i do, but no commons app in it yet [18:55:39] notnarayan: yeah, try the bit.ly url on it now? [18:55:46] bit.ly/android-commons [19:00:12] jgonera: did jon ever talk to you about why he's doing mobileTargets rather than just relying on dependency mapping in the modules? [19:01:17] notnarayan: works? [19:01:52] yes YuviPanda :) [19:01:58] notnarayan: sweet :) [19:02:12] YuviPanda: the take photo and from gallery is on the top bar though [19:02:31] MaxSem and jgonera: are you going to participate in demo'ing in the Mobile Showcase? [19:02:32] notnarayan: yup, that's how 'split' actionbars work [19:02:49] jcmish, the hangout has a limit [19:02:56] YuviPanda: weren't we going to have them stuck to the bottom? [19:03:05] so I'll be just watching [19:03:16] MaxSem: that's right I forgot [19:03:16] notnarayan: on phones, yes. [19:03:22] notnarayan: that's how the split actionbar works :) [19:03:39] ah, nice [19:04:00] notnarayan: even on phones - if your phone is big enough, when you go landscape, it'll show up on top [19:07:24] * jdlrobson welcomes YuviPanda and notnarayan virtually from the metrics meeting [19:07:58] jdlrobson: thank you :) you get my piece of the cake :) [19:08:36] thank you jdlrobson :) [19:10:58] jdlrobson: congratulations on turning 1 with the wmf :) [19:11:08] and it's today :D [19:15:01] YuviPanda: the app! :) [19:16:51] is it the video or erik's laptop that is performing so badly? [19:35:45] tfinc: eric's laptop is worst then our gremlin phone [19:36:06] i've already told maryana that i think the tech for todays metrics meeting is a disaster [19:37:13] wow this is amazing [19:37:23] (terry's speaking speed) [19:37:54] i'm worried he might collapse at the end of it through lack of breath tfinc [19:38:16] jdlrobson: i fee for any non native speakers listening to this [19:38:20] :) [19:38:39] i'm not sure i'm following and i'm native :P [19:38:50] white text on white background! arggh [19:39:07] jdlrobson: i've already contacted chip about how this tech setup made our jobs harder [19:40:39] http://www.troll.me/images/jackie-chan-whut/you-confused-bro.jpg [19:40:48] ROFL [19:40:55] hahaha [19:41:45] can't find a duracell bunny gif [19:41:51] but i would post one if i had one [19:42:30] this is not the same but… http://www.nosomosperfectos.com/wp-content/uploads/2009/09/duracell.gif [19:42:42] haha that works [19:42:55] i think i'm tripping at the metrics meeting again [19:43:04] lol but with no visuals this time? [19:43:49] wow i'm speechless [19:45:32] awjr: please buy http://www.etsy.com/listing/89670649/mustache-and-monocle-sticker-decal?ref=sr_gallery_11&ga_search_query=laptop+decal&ga_view_type=gallery&ga_ship_to=US&ga_search_type=all [19:45:41] or http://www.etsy.com/listing/62309668/mustache-set-1-laptop-decal-by-suzie?ref=sr_gallery_17&ga_search_query=laptop+decal&ga_view_type=gallery&ga_ship_to=US&ga_search_type=all [19:45:59] hahaha [19:46:24] jdlrobson: tempting http://www.etsy.com/listing/107731974/tardis-movie-for-macbook-laptop-notebook?ref=sr_gallery_15&ga_search_query=laptop+decal+tardis&ga_view_type=gallery&ga_ship_to=US&ga_search_type=all [19:46:42] oo tfinc [19:47:11] now i wonder if you can line up the tardis with the apple logo and make the glow work [19:47:23] ooohh http://www.etsy.com/listing/63773927/police-box-laptop-decal-vinyl-sticker?ref=sr_gallery_44&ga_search_query=doctor+who+laptop&ga_view_type=gallery&ga_ship_to=US&ga_page=2&ga_search_type=all [19:47:27] that's the dr who one [19:47:37] cute [20:09:42] hey brion [20:09:50] hey hey [20:12:20] brion, do you still remeber how language conversion works? why one section there: http://i50.tinypic.com/1k8jc.png gets converted while another doesn't? [20:12:48] trippy [20:14:06] i couldn't really say it's … mysterious [20:14:41] heh [20:15:03] anyway, I'm gonna commit my mobileview change, let's see if it behaves more properly than the ordinary view:] [20:15:15] awjr_lunch: and MaxSem any chance we can merge https://gerrit.wikimedia.org/r/#/c/47546/ now? [20:15:56] merge what? [20:16:04] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47546 [20:16:08] hey brion [20:16:11] * YuviPanda gears up for some late night hacking [20:16:16] hey YuviPanda [20:16:16] woooo [20:16:33] bah server troubles i can't read my watch lists ;_; [20:16:52] brion: we should put up the things that changed for next iteration (- account creation, + tutorials) on the page, I think? [20:17:03] yeah [20:17:03] brion: can you also explain to tfinc in person? Assuming you're in the office [20:17:19] yep just got in (had a dr.'s appointment earlier so missed the metrics meeting in person) [20:17:36] ah ok :) [20:18:16] so i ordered an HDMI video capture device [20:18:26] so next time we make screencasts i can do it with real devices at full frame rate :D [20:19:26] New patchset: MaxSem; "Bug 41995: variants fixage for action=mobileview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47915 [20:19:52] brion: :D [20:19:55] brion: wonderful! [20:20:22] gonna be able to capture from the nexus 10 and probably even my microsoft surface ;) [20:21:39] brion: wheeee! :) [20:21:49] brion: 2.3 is killing me :( [20:22:00] aww [20:22:23] it's taking more time than expected. Thinking of shuttling that to next iter and finishing up failed upload fixing now [20:22:42] *nod* [20:22:57] yeah i sacrificed iOS 5 temporarily to get the grid view, i'll need to add a compatibility shim [20:23:43] hmmm [20:24:04] brion: the only problem is that the issue is completely nonsensical. I'll have to root the phone, retreive the APK installed, and disassemble it to debug [20:24:06] grr [20:24:10] o_O [20:24:11] ugh [20:24:23] yeaah [20:24:28] it's telling me it can't find a view [20:24:33] while I can see that the view does exist [20:24:40] so... some bug somewhere in the process [20:24:41] * YuviPanda shakes fist [20:26:15] brion: also, unrelated, William Shatner seems to be active on Reddit now, and is way more funny than he was in TOS [20:26:16] :) [20:26:16] http://www.reddit.com/r/startrek/comments/1818um/someone_said_i_havent_said_hello_to_rstartrek_yet/c8ata0s?context=6 [20:26:40] heh [20:30:09] jcmish, awjr_lunch: are we going to have meeting? [20:30:28] yup [20:35:50] jcmish: hey [20:36:00] hey hashar [20:36:03] can't hear you [20:36:03] jcmish: there is apparently an internet connectivity issue between my iSP and google :( [20:36:07] no worries [20:36:12] just throw me a status here [20:36:17] I'll be your voice :D [20:36:22] I get a very high packet loss somewhere in Paris - New York [20:36:28] sorry bout that :( [20:36:52] hashar: can you hear us? [20:36:55] or still iffy>? [20:37:03] chrismcmahon: my connectivity is laggy as hell I can't hear any of you :( [20:37:20] aww [20:37:57] hashar: I'll you email a status [20:37:59] no worries [20:39:08] kind of from time to time :( [20:39:08] sorry [20:39:08] I will dump a status there. [20:39:08] the beta DNS entries m.beta.wmflabs.org have been removed [20:39:08] in favor of a scheme that respect production [20:39:08] which is .m..beta.wmflabs.org [20:39:09] that is following a talk with max sem [20:39:09] andrew has been kind enough to work around in bug in labsconsole and we have the DNS entries working [20:39:10] so we have nice entries now :-] [20:39:13] the puppet work has been applied on the deployment-t3-instance [20:39:34] that is serving request as we speak [20:39:34] since yesterday IIRC [20:39:34] the changes are still pending review by mark, but he was in vacations for the last few days [20:39:55] I will get him to do the final review / approval and merge all the puppet changes [20:40:14] long story short, Max did some tweak to varnish configurations [20:40:18] and now we have http://en.m.wikipedia.beta.wmflabs.org/ [20:40:28] we have some basic functionalities now for mobile [20:40:40] yuvi / brion are planning to use it for the commons IOS/Android apps [20:40:51] and we can later on tweak what ever is messy on the current install [20:41:07] * hashar hates when internet connectivity is bad [20:41:10] someone said app? [20:41:13] * YuviPanda reads backlog [20:41:33] YuviPanda: yeah we have a short meet up about setting up mobilefrontend + varnish on the beta cluster [20:41:53] ah, go on then. I'll be fine without :) [20:41:57] just referred to some email by you or brion that said you were willing to use the beta install to test your app [20:42:07] hey, what's the difference between #382 and #392?? [20:42:16] hashar: oh? I don't remember that... [20:42:28] hashar: ? [20:42:42] hashar: the android app requires a working http/1.1 implementation, which our squids don't provide *unless* they are in front of nginx. Unsure about how beta labs will do this [20:43:25] and can you point me to said email? don't remember... [20:43:56] I can't remember either :-] [20:43:59] maybe I have dreamed about it [20:44:27] brion: I was talking about having the commons IOS/Android to point on the beta cluster instead of test.wikipedia.org. But maybe I have just dreamed it up [20:45:19] jcmish: I'm using http://en.wikipedia.beta.wmflabs.org as an oracle for http://en.m.wikipedia.beta.wmflabs.org/ wrt to finding pages to check, links etc. [20:45:48] ok turns out my connection is capped at 256kbps !! [20:45:49] :( [20:46:04] obviously not enough for hangout :-/ [20:46:15] New review: MaxSem; "Meh, not much of a discussion on wikitech-l." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/43852 [20:46:19] http://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page looks incomplete :D [20:46:41] and no https version either :) [20:46:54] chrismcmahon: cool! [20:46:55] https is a pending feature request indeed [20:46:58] and no http/1.1 [20:47:00] :( [20:47:04] yup that's what I was gonna do [20:47:13] got to find out someone who know about our https infrastructure and have him replicate it on beta [20:47:24] hashar: gotcha [20:47:31] jcmish: so hmm I am really sorry for not being in the hangout :( [20:47:34] hashar: will that take a while? [20:47:42] jcmish: yeah I think my connection is dead [20:47:44] hashar: oh don't apologize it's fine [20:47:55] hashar: sweet. A neat side effect of using nginx for HTTPS is that it also supports a subset of HTTP/1.1 features - specifically Transfer-Encoding: Chunked (the app depends on this). Just something to keep in mind [20:47:56] jcmish: maybe I could give you a call tomorrow ? [20:48:07] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43852 [20:48:11] hashar: that would be great [20:48:20] just let me know what works for you [20:48:46] jcmish: tomorrow morning SF time ? [20:48:57] hashar: or earlier [20:49:01] if it's easier for you [20:49:12] I am working at a coworking place till 7pm (which is noon PST) [20:49:40] so anytime during SF morning is fine [20:49:42] we can do 8pst if that works [20:49:56] I'm up and about around then [20:50:03] so you pick and I'll accomodate [20:51:57] jcmish: I think I managed to send you an invite for 8am PST [20:52:34] again I am sooo sorry about that :( [20:52:37] I hate missing meetings [20:52:50] hashar: correct and I accepted :D [20:52:59] haha no problem hashar I'm pretty easy [20:53:03] great! [20:53:04] jcmish: image files are all redlinks right now it seems but http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard should work (for some value of "work") [20:53:11] so anyway the first step is in [20:53:31] I guess we want to list out what is left to be done. Max told me of some specific features we want to support [20:53:37] I can most probably catch up with him tomorrow [20:54:04] chrismcmahon: while you are around, beta is again running off master and should be more or less self updating [20:54:08] hashar: I think you're correct [20:54:20] thanks hashar [20:54:21] chrismcmahon: the missing message in http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard is due to the localization cache not updating properly. [20:54:49] chrismcmahon: some sudo rule is incorrect :/ The patch is at https://gerrit.wikimedia.org/r/#/c/47795/ [20:55:05] chrismcmahon: since that script spam the labs cron mailing list, I am confident Ryan will eventually have the change merged :-] [20:55:12] though I think he is traveling back to US hehe [20:57:25] well [20:57:33] will try to get the change merged tommorrow [20:57:51] leaving out for now :/ bad connection is not fun at all [20:57:56] jcmish: see you tomorrow :-] [20:58:04] see you [21:06:09] brion: I modified iteration 2 for android. can yo do so for iOS? [21:07:48] done [21:08:23] i'll grab tfinc later and check if we should drag in the graphics artists now or if we should just throw together a temporary version [21:08:33] brion: sweet. The clearer the better! [21:09:00] brion: I wouldn't mind making it English only to start with [21:09:19] yeah we can localize it later [21:09:32] +1 [21:10:36] reminds me i should eat lunch [21:28:13] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/k9jDqQ [21:28:13] android-commons/master 9ea843b YuviPanda: Make UploadService a Service rather than an IntentService [21:28:48] Project Android-Commons (mobile) - Nightly builds build #48: SUCCESS in 36 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/48/ [21:28:48] yuvipanda: Make UploadService a Service rather than an IntentService [21:34:21] tfinc: i just learned about vim-fugitive from looking through your dotfiles on github - it is BLOWING MY MIND [21:34:49] its a good addition to your tool kit [21:35:24] awjr: it is amazing. See the screencasts [21:35:33] awjr: also Command-T. And Vim Powerline. [21:35:53] awjr: and https://dl.dropbox.com/u/8768784/.vimrc :) [21:36:00] :) [21:39:02] jgonera, jdlrobson are either of you blocked anymore on outstanding code review/ [21:39:40] awjr: think we are good… for now [21:39:43] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/d6xgEQ [21:39:43] android-commons/master 91aa440 YuviPanda: Refactor a little bit to avoid too much Intent passing around [21:39:53] lots of rebasing to do [21:40:02] Project Android-Commons (mobile) - Nightly builds build #49: SUCCESS in 24 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/49/ [21:40:02] yuvipanda: Refactor a little bit to avoid too much Intent passing around [21:40:23] jdlrobson: have you ever done pair programing before? [21:40:26] awjr, https://gerrit.wikimedia.org/r/#/c/47623/ and https://gerrit.wikimedia.org/r/#/c/45912/ would be useful for me for the upload progress story, but I guess I need to rebase them after the RL stuff got merged [21:40:26] alright good nightey folks :) [21:40:36] I will do that soon and let you know [21:40:45] jgonera: cool, i can take a look when you're read [21:40:47] *ready [21:41:22] awjr, I suggested doing some pair programming to jdlrobson today ;) [21:41:26] ha! no kidding [21:41:27] I've never done this but I'm keen to try [21:41:42] if jgonera and jdlrobson are interested in trying, i think it will actually reduce the code review burden [21:42:01] especially since the two of you are most frequently blocked on code review. doing pair programming is like… code review in real time [21:42:25] yeah, especially with bigger things I guess it can be easier to get things right without 15 patchsets with two pair of eyes [21:42:37] yeah exactly [21:42:46] i haven't really done it before either, but i've heard others rave about it [21:42:52] i imagine it will take some getting used to [21:43:07] probably, but I hope we'll try [21:43:14] :) [21:43:35] although jdlrobson raises an interesting issue, if two people are authors of the code, there's less people who can review it ;) [21:43:45] *fewer [21:44:04] i guess that's true, but you're doing real-time review too [21:44:39] i guess if one of you isn't comfortable with merging, +1'ing and pinging someone else would be fine for merge [21:44:44] oh wow: http://remotepairprogramming.com/ [21:44:47] true, we could tag that somehow [21:45:33] I can't imagine having two cursors [21:45:35] totally, even mentioning it in a comment i think would b efine [21:45:36] haha [21:46:51] I was trying to make remote pair programming possible with my final project, but I never got it to the point where it would be fully functional and bug free [21:47:20] jgonera: like a screensharing app? [21:47:38] like google docs but for code [21:47:42] sweet [21:47:56] hmm a collaborative vim session would be sweet [21:48:16] I probably mentioned it during my interview (http://dev.coledit.com/) [21:48:40] I don't know if that exists, but I heard people using screen for this [21:48:42] somehow [21:49:02] awjr: you can share vim via screen() fwiw, I've seen that a lot. [21:49:06] yeah, with screen you can have multiple people using a session [21:49:08] :) [21:49:10] i've never tried that [21:49:16] i mean, not for pair programming [21:49:43] iirc though tfinc and i used a shared screen session for something when we were building out the payments cluster for fundraising a couple years ago [21:49:50] awjr: I used to use that for pairing a lot. as long as both parties can ssh to the host, and are using text-only editors, it rocks pretty hard. [21:49:58] that's awesome [21:50:02] lightweight :) [21:51:18] awjr: I've also done pairing with a UI using VNC to a shared host, it's not too shabby either, although the lag makes driver-navigator pairing usually the best approach. [21:51:41] that makes sense chrismcmahon - what has your experience been like with pairing? [21:52:15] awjr: I like it. I suck at vim though. [21:52:22] :p [21:52:41] New patchset: Jdlrobson; "Allow special pages to define dependencies (regression)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48026 [21:52:42] ^ awjr jgonera [21:52:49] chrismcmahon: when you've paired before, what were the mechanics like? i mean, did one person code while the other wrote tests or something, or did you both just hack simultaneously or .. ? [21:53:29] awjr: recently zeljkof and I paired writing some tests over hangout, where I wrote the test and he made suggestions. it worked well. [21:54:23] that's cool [21:54:57] ^ awjr that is blocking me now so if you can review :) [21:55:15] sure jdlrobson one sec [21:56:02] awjr: I was particularly pleased because the test we wrote caught a bug the next time we deployed, the timing was great. [21:56:21] ha! victory! \o/ [21:56:47] we break the Math extension by accident from time to time :) [21:58:35] New patchset: Jdlrobson; "Provide description url in photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48028 [21:58:35] New patchset: Jdlrobson; "special case the first upload through this page (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47673 [22:12:19] jdlrobson: can you explain the logic around the conditional dependencies here? https://gerrit.wikimedia.org/r/#/c/48026/1/includes/MobileFrontend.body.php [22:12:41] awjr: donateimage.js requires mf-photo.js [22:12:44] that's only in beta [22:12:48] part of what im asking is, why assign mobile.startup ONLY if there are no dependencies added? alternatively, why not add mobile.startup to the boilerplate? [22:13:19] actually the boilerplate one wouldn't really work - you wouldn't be able to easily override since you use '+' [22:13:33] because all mobile modules should depend on at least mw.mobileFrontend being there [22:13:38] which is provided by mobile.startup [22:13:42] unless they specify otherwise [22:13:52] this way just seemed cleaner than the boiler plate [22:14:07] yeah you can't use the boilerplate for this without changing how you smoosh the arrays together [22:14:56] so to make sure i undertsand if a special module has no dependency defined, it should definitely have mobile.startup added. if it does have a dependency defined, it should not have mobile.startup automatically added? [22:15:56] i promise im not trying to be petulant, i just want to make sure the logic is correct before i merge [22:18:16] jdlrobson: ^ [22:18:26] jdlrobson or jgonera, is "shim":"\/w\/extensions\/MobileFrontend\/stylesheets\/common\/images\/blank.gif" still needed? [22:19:13] awjr: correct [22:19:26] MaxSem, not sure, I'd be glad if it wasn't [22:19:30] MaxSem: possibly not [22:19:37] it should probably be phased out [22:19:39] i'll check in a bit [22:19:49] I thought shim is dead [22:20:19] long live the shim! [22:24:26] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48026 [22:32:19] New patchset: Jdlrobson; "make sure buttons in watchlist header are aligned correctly (376)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47695 [22:35:03] awjr: you got a pup? [22:35:10] jdlrobson: yep, last night :) [22:35:14] nice :d [22:35:15] :D [22:35:20] :D [22:35:22] New patchset: Jdlrobson; "Provide description url in photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48028 [22:35:55] MaxSem: https://gerrit.wikimedia.org/r/#/c/47683/ see my comment [22:35:56] admittedly she has me a little distracted today [22:36:16] but she is awesome :) [22:36:34] jdlrobson, I saw it [22:36:55] not sure how it happens [22:37:22] mm [22:37:24] New review: awjrichards; "looks good - this is funny, i thought the jutting was on purpose, to give the button a recessed, or ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/47695 [22:37:24] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47695 [22:37:25] does it happen for you to? [22:41:36] ahahahahahahahahahaha [22:42:39] infinite recursion [22:42:50] you don't have xDebug? [22:47:01] New patchset: MaxSem; "Ensure Special:JavaScriptTest always runs in desktop mode (codehealth)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47683 [22:47:35] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47683 [22:49:05] MaxSem: how would you query the api to find # of uploads? [22:49:36] liswt em all:P [22:51:53] eh MaxSem? [22:52:24] awjr, s/w// [22:52:40] there's no easy way [22:52:57] MaxSem: i see i can find contributions a user made to the File namespace [22:53:04] but is there a way i can get more specific than that? [22:53:12] awjr: chip just showed me a 60'' thats going to be installed into R31 over the next weeks :D [22:53:17] you can log uploads [22:53:17] jdlrobson: Maryana --^ [22:53:30] tfinc awesome :) [22:53:44] erm, list uploads from the log [22:54:01] which log do you mean MaxSem? [22:54:02] MaxSem: infinite recursion?! whyz?! [22:55:15] jdlrobson, http://www.urbandictionary.com/define.php?term=clusterfuck [22:56:13] awjr, the most precise way is to list by image table [22:56:35] \o/ MaxSem [22:56:44] MaxSem: is there a way i can do that via API? [22:57:25] but if you need a total number of uploads, it's stuck in RDBMS's inability to do a fast SELECT count(*) FROM ... WHERE ... [22:58:58] maxsem, that's why we're adding the template to all mobile uploads in this coming iteration :) [22:59:08] that's the easiest, friendliest way to log [23:10:22] New patchset: Jdlrobson; "Add template support to ResourceLoader" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47194 [23:11:24] New patchset: Jdlrobson; "Add template support to ResourceLoader" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47194 [23:12:49] MaxSem: would this be sufficient? /w/api.php?action=query&list=allimages&format=json&aisort=timestamp&aiuser=awjrichards&ailimit=500 [23:13:25] awjr, do you really want to load this much just to get a count? [23:13:50] MaxSem: it didn't sound like i have an alternative [23:14:39] sigh [23:14:49] what do you need this count for? [23:14:59] https://mingle.corp.wikimedia.org/projects/mobile/cards/330 [23:15:42] sigh [23:15:44] there should be a 'count' api [23:15:53] that just gets you counts of arbitrary information [23:16:15] awjr, seen my comment about count(*)? [23:16:37] yeah :( [23:17:24] can we change the design instead? [23:17:44] what do you have in mind, MaxSem? [23:18:01] not to show these numbers [23:18:06] hahaha [23:18:08] Maryana: ^ [23:18:55] oh, are you working on that card, maxsem? [23:19:12] if it's too hard to do, let's push it back to the backlog for now [23:19:17] i just grabbed it, Maryana [23:19:21] ah, ok :) [23:19:26] no, trying to prevent awjr from loading dozens of kilobytes just to get 1 number [23:19:32] it's not too hard to do per se but i think MaxSem has performance concerns [23:19:50] MaxSem: the good news is it will happen server side [23:19:57] aha [23:20:14] so it's wasteful, but should be relatively quick as far as i can tell and not have a negative impact on data usage for the user [23:20:17] then why you've been asking me about the API?:P [23:20:43] that… is a good question [23:21:23] oh, because i started going down that rabbit hole before i saw 'Do on server' [23:21:32] server-side it's pretty easy [23:21:42] although stupid [23:21:42] yeah i can just count from the db [23:22:04] just mind the limit;) [23:22:08] although… can enwiki talk to commons wiki db, MaxSem? [23:22:47] wfGetDB( DB_SLAVE, array(), 'commonswiki' ) [23:23:06] sweet. [23:23:36] ...can of worms [23:23:50] sorry, I'm too negativist today:P [23:25:12] * chrismcmahon considers asking MaxSem about https://gerrit.wikimedia.org/r/#/c/47683 but not sure I want to hear the answers [23:25:42] chrismcmahon, ?? [23:26:00] MaxSem: that's to support qunit tests? [23:26:14] jdlrobson, ^^ [23:27:21] I'm just confused about why you're making changes to prevent infinite recursion for a test that only right now hypothetical [23:27:41] that is right now only hypothetical [23:28:40] these changes are not to prevent recursion [23:28:57] the comment simply explains a particulat coding decision [23:29:17] this change is to ensure that this page is always run in deskop mode [23:29:44] desktop mode of what? [23:29:53] of site [23:30:39] chrismcmahon: desktop mode vs mobile mode [23:30:59] what runs this page? I think there is a hole in my knowledge, sorry. [23:32:52] engineers run it manually afaik, there may some automation around it but i dunno - jdlrobson might know better [23:33:06] oh, OK, thanks awjr [23:35:22] New patchset: Jdlrobson; "only load head modules once" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48046 [23:36:13] jdlrobson: poke poke poke [23:38:22] chrismcmahon: it's a special page which runs qunit tests for javascript [23:38:39] it doesn't run properly in mobile mode [23:39:08] we also run it with phantomjs using make qunit [23:39:19] thanks jdlrobson, I didn't know people were using qunit locally. [23:40:23] chrismcmahon: we are in MobileFrontend but also thanks to jgonera we have a command line script that runs it headless :D [23:40:38] hence why our qunit tests never fail ;-) [23:40:52] ori-l: i'm coming up if that's cool? [23:40:56] got it, thanks, clear now [23:41:18] New patchset: Jdlrobson; "load mobile.startup at bottom of page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48047 [23:41:47] jdlrobson: do [23:46:23] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48046 [23:46:34] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48047 [23:49:45] New patchset: JGonera; "Add progress event forwarding for Api calls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48049 [23:49:46] New patchset: JGonera; "Add progress bar to photo upload progress notification" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [23:50:58] New review: JGonera; "WIP" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/48049 [23:51:12] New review: JGonera; "WIP" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/48050 [23:52:35] munaf: that camera icon has some pathing issues. [23:52:40] jdlrobson, when we load startup at the bottom the go button blinks in the searchbar (because we hide it after everything is loaded) [23:52:58] that makes sense jgonera [23:53:04] we can tweak the css for that using page-loading class [23:53:26] hm jorm? can't spot 'em [23:53:31] jorm, the icon is old, I actually didn't get the new one (I mean it's in the new wireframes but I need a png with transparency) [23:53:48] i'm talking about the red one just uploaded to the drop box. [23:53:54] jdlrobson, good idea [23:54:01] jorm, oh, OK, then ignore me ;) [23:54:38] munaf: turn on a 1x grid, zoom in, tap the shape. the edges are off pixel boundries. when cut/exported, this results in a blurred image. [23:54:51] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [23:54:51] New patchset: JGonera; "Move require()/define() to modules.js file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [23:55:04] looks like this shape is stock from something but we can point-fix it. [23:55:06] jdlrobson: added isBeta field to server-side account creation logging: http://meta.wikimedia.org/wiki/Schema:ServerSideAccountCreation [23:55:33] awjr, if you have some time: https://gerrit.wikimedia.org/r/47623 and https://gerrit.wikimedia.org/r/45912 [23:55:52] ok jgonera, i'll try to look before i finish up today [23:56:01] thanks