[00:03:01] jorm not sure i follow completely but i did find issues with the shape and *think* i fixed 'em [00:03:16] hrm. no. sec. [00:03:25] i'll do my fixes in a new layer, so you can see what i mean. [00:08:25] k. reload it; check out my layer vs. the other one. [00:08:47] i just upgraded photerschops versions, and they changed how shape nudging works apparently. [00:08:54] so it's not as good as i'd like. [00:15:37] New patchset: JGonera; "Add progress bar to photo upload progress notification" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [00:15:37] New patchset: JGonera; "Add progress event forwarding for Api calls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48049 [00:16:38] ahh jorm. i see what you mean. works for me. [00:16:54] not sure it'd be a huge deal at a super small scale though. [00:17:36] saved the new version. thanks! [00:17:46] groovy. [00:26:38] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/DyqbSA [00:26:38] Commons-iOS/master 7f32ab3 Brion Vibber: Localization: first stab... [01:05:52] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [01:07:42] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [01:13:08] New patchset: Jdlrobson; "Remove definitions of Schemas (code health)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48061 [01:14:13] New patchset: Jdlrobson; "promote event logging to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48062 [01:27:06] awjr: where is the latest copy of our partner task sitting? [01:47:19] New review: Jdlrobson; "Not +1ing because of your TODO list in the commit" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/48059 [01:47:42] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48028 [01:47:56] New patchset: Jdlrobson; "special case the first upload through this page (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47673 [01:48:05] New patchset: JGonera; "Add progress bar to photo upload progress notification (#379)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [01:56:41] New patchset: Jdlrobson; "promote event logging to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48062 [01:57:06] Change abandoned: Jdlrobson; "see https://gerrit.wikimedia.org/r/48062 instead" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48061 [11:05:38] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/3gI5Tg [11:05:38] android-commons/master 297f327 YuviPanda: Tap to retry failed uploads implemented... [11:06:10] Project Android-Commons (mobile) - Nightly builds build #50: SUCCESS in 34 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/50/ [11:06:10] yuvipanda: Tap to retry failed uploads implemented [11:06:38] #win [11:36:57] notnarayan: hello shankar :) [11:37:02] final thing for this iteration about to be done [11:37:09] finishing touches on upload retrying :) [12:05:34] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/4gONGw [12:05:34] android-commons/master e6a8f4d YuviPanda: Cleanup contributions state when service starts.... [12:05:53] Project Android-Commons (mobile) - Nightly builds build #51: SUCCESS in 24 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/51/ [12:05:54] yuvipanda: Cleanup contributions state when service starts. [12:05:57] wheee [16:06:46] jcmish: https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimedia%20Labs [16:06:52] compoentn is "deployment-prep (beta)" [16:09:27] hang out rocks :-] [16:09:51] [Commons-iOS] felixmo opened pull request #24: Fixed upload buttons (master...master) http://git.io/0sJaLA [17:21:09] New patchset: MaxSem; "Bug 41995: variants fixage for action=mobileview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47915 [17:36:39] awjr: and MaxSem I can't upload photos on staging. http://staging.wmflabs.org/wiki/Main_Page [17:36:47] could it be a configuration issues? [17:36:50] looking [17:36:50] *issue? [17:36:50] maybe - one sec [17:36:54] ah max is on it [17:36:58] thanks guys [17:37:50] just uploaded http://staging.wmflabs.org/wiki/File:Rewgfewrger.png [17:38:14] it could be a permissions error for jcmish's user, MaxSem [17:38:28] I'm trying to upload a picture from my phone [17:38:34] using Mgrover(WMF) [17:38:36] in beta [17:38:48] and I get the error dialog [17:39:20] gave you admin rights [17:40:55] yeah, you should be able to edit now [17:41:15] ah cool thanks! [17:53:52] New review: Sumanah; "Michelle, a better commit summary would be great! https://www.mediawiki.org/wiki/Git/Commit_message..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/47694 [17:54:12] maxsem, can i have admin rights on staging, too? i have no articles with edits on my watchlist [17:54:14] user:maryana [17:54:44] done [17:58:52] hey jcmish [17:59:26] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [17:59:28] jcmish: you can amend a git commit to change things, including (I believe) the commit message https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change [17:59:37] thanks, maxsem! :D [17:59:38] sumanah: thanks [17:59:47] I'll fix it when I finish this meeting [18:00:24] cool [18:00:36] just wanted to jump in here so others can correct me if I'm wrong [18:00:39] * sumanah sneaks out again [18:08:24] haha okay [18:10:49] MaxSem: another blog picked it up http://popupcity.net/2013/02/wikify-your-city-with-wikipedias-nearby-app/ [18:11:04] :))) [18:12:24] ok, this really makes me think we need to focus on promoting nearby and adding upload CTAs in the iteration after next [18:12:53] and then organize an SF photo scavenger hunt [18:13:33] and can we make it work on non-mobile, even though it may look alien? [18:14:10] haha [18:15:27] sure, why not [18:15:34] awjr: MaxSem where is the latest copy of the partner task ? [18:16:15] tfinc, https://office.wikimedia.org/wiki/Engineering_Recruitment_Projects#Software_Engineer_-_Partners [18:16:25] thanks [18:16:51] jdlrobson, the watchlist style changes look great! [18:17:45] :D [18:18:04] make it work on non-mobile? [18:18:12] mobile is desktop ;-) [18:18:23] New review: MaxSem; "See comments" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/48059 [18:18:47] jdlrobson: responsive design from mobile -> desktop [18:20:09] jdlrobson, i'm actually starting to plan a redesign of the desktop watchlist that makes it look more like mobile :) [18:20:19] just the filtering/toggling UI, but it's a start [18:20:20] Maryana: don't waste your time ;-) [18:20:22] baby steps [18:20:33] just redirect it to mobile ;-) [18:20:47] heh. that will severely confuse newbies [18:24:52] just put a splash screen Maryana "We are redirecting you to a nicer user interface" [18:29:24] hmmm i thought i fixed that WS MaxSem… although i may have forgotten to re-add after i did MaxSem re 'Now you're allowing people to shoot themselves on foot, potentially loading HUGE result sets. Recommend a hard set limit of 500', would setting the object property to private make you feel better? the limit var is to make our lives easier if/when that value changes [18:30:10] awjr, you're already making an unbounded query [18:31:25] no, the query being made is limited to 500 [18:31:58] have you looked in the debug log?;) [18:32:12] * awjr looks [18:32:37] oh whoops [18:32:43] $uploadCount = $this->getUserUploadCount( $user->getName() ); [18:32:47] yeah saw it [18:33:04] congrats, you've shot yourself in the foot!:P [18:33:13] :p [18:34:11] awjr, also, to check if there are more than 500 rows, you need to set the limit to 501 [18:34:24] yeah already fixed that one too [18:35:43] New patchset: Mgrover; "now that bugzilla bug 44658 has been fixed add test case to verify that Sign up takes you to the Mobile Create Account screen" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47694 [18:36:25] jgonera, i just ran an online user test on account creation + uploads -- the user hit an upload error :-/ [18:36:51] Maryana, I guess there's little I can do now until we add error logging [18:37:08] unless the user knows how to debug it [18:37:40] heh. yeah, i'm hoping it's an isolated issue. we'll find out when we start logging [18:37:55] i'll upload the video to commons & send out the link [18:38:01] it's interesting, as they always are [18:38:24] he was coming from the left nav upload link, but thought the image would be added to the article he was on previously [18:42:39] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [18:44:24] awjr, why $limit=0? [18:44:52] Maryana, I can see how this might be confusing, I'm not sure when we decided to call this "Upload." I thought it was going to be called "My uploads" or even "My images" since we don't allow anything else as of now [18:45:26] let me know when you upload the video [18:45:32] MaxSem: why not? you are concerned about the potential for unbound queries? [18:45:36] converting to ogg theora now [18:45:39] ok [18:45:53] yeah [18:46:20] too much flexibility is looking for trouble [18:46:21] MaxSem: how about i take out the param and just use the object property? [18:46:23] fair enough [18:46:27] i think it will make more sense once we reorganize the items in the left nav to have all the "my" stuff (watchlist, login, upload) together under one submenu [18:47:08] awjr, it still needs to remove the WMF=specific hardcoding [18:47:17] MaxSem: yeah, i'll do it it another patchset [18:47:18] but doesn't "upload" sound like an action instead of sounding like a... place? [18:47:29] I'd make it plural [18:47:46] in a web browser you don [18:48:04] in a web browser you don't have a "download" window, you have "downloads" [18:48:11] agreed [18:48:47] this guy was on an iphone. i'm also going to run one on android now to compare [18:54:06] * BirthdayPanda looks around [18:54:14] brion: I fixed network retries in the Android app :) [18:54:22] woohoo [18:54:26] birthdaypanda - happy birthday? [18:54:27] re-uploading etc works perfectly fine [18:54:32] Maryana: yup :) [18:54:37] woo! [18:54:38] is it BirthdayPanda's birthday? \o/ [18:54:39] I'm old now :( [18:54:44] brion: yup :) [18:54:44] uhh [18:54:50] congrats, another year alive :D [18:54:51] don't say that. it makes me feel ancient [18:55:00] brion: indeed. I'm surprise [18:55:25] dfoy: i don't have IP addresses for orange central african republic … should i wait on that and just set up the translate entries? [18:56:30] Maryana: :) [18:58:49] brion:Yes, I'm still waiting for central african republic IPs, but it would be useful to set up translateWiki now [18:58:55] ok [18:59:04] brion: nothing else is needed for them now [18:59:33] jgonera: http://commons.wikimedia.org/wiki/File:Mobile_account_creation_upload_usertest.ogv [18:59:44] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [19:01:38] New patchset: JGonera; "Fix URL to description page for newly uplaoded images" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48148 [19:01:50] Maryana, thanks [19:02:18] sure thing. somebody just picked up the android test - i'll upload that one, too, when it's done [19:04:22] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [19:06:41] Whee limechat for iPad [19:09:26] Maryana: this guy annoys me he keeps doing things off screen :( [19:09:32] those are the most revealing [19:09:37] i know, that sucks [19:09:46] and is that a red wine sian? [19:09:48] *stain [19:09:52] haha [19:10:18] also hate CentralNotice [19:10:22] another ux fail [19:11:55] that one is really bad [19:12:06] i think that's going to trip up almost everyone [19:12:35] i did these usertests partly just to see how bad the problem is, but i can already see it's something we need to prioritize getting rid of [19:13:37] i wonder if we should add a quick js hack for the central notice for the time being [19:13:45] also would be nice to know what upload error he had [19:14:06] interesting he thinks that his photo would have gone to foundry square [19:17:47] jdlrobson: 5 hour ride to ellora tomorrow [19:18:03] train boss? [19:18:03] car [19:18:08] also not your birthday [19:18:11] birthday saturday [19:18:13] bad panda [19:18:21] ? [19:18:23] it is saturday :P [19:19:13] Omg birthday panda lives in the future [19:20:19] brion_: :D [19:20:22] I do [19:26:54] guys: http://www.ovirt.org/Home [19:27:13] and here is the code: https://github.com/OSAS/strapping-mediawiki [19:28:14] http://www.ovirt.org/Special:Version niiice [19:28:20] brion, jdlrobson and jgonera ^^ [19:33:48] jdlrobson: should i add a "quick & dirty centralauth hack" story to next iteration? would you be able to estimate it? [19:36:03] and more importantly, would you be able to do it in a day or two before you leave? :) [19:36:04] Maryana: gimme a few mins [19:36:08] kk [19:48:01] (Maryana basically i have code now that does that i just need to try it out) [19:48:31] heh, ok [19:54:50] New patchset: Jdlrobson; "promote watchlist and login functionality to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48156 [19:55:53] Change abandoned: Jdlrobson; "This seems to have fixed itself magically in https://gerrit.wikimedia.org/r/48156. \o/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/46485 [19:58:36] New review: Jdlrobson; "Also outstanding TODO notes in commit message" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/48059 [20:07:30] Maryana: actually on second thoughts lets just do the CentralAuth fix rather than hack it [20:07:32] the hack has problems [20:07:57] heh. as they usually do [20:08:19] ok. i'll think about how to prioritize that against the rest of our upcoming work [20:08:38] unfortunate that you won't be around next iteration :-/ [20:09:33] i've got another hack Maryana which makes it just show the return to link [20:09:56] that would be useful, though if the link is Special:DonateImage and people are coming from Upload... [20:10:06] still kinda confusing [20:10:35] but at least that's less confusing than sending them to that awful help page [20:11:01] just adding the hamburger to the post-login/signup page might help, actually [20:11:24] jdlrobson ^ [20:11:40] adding hamburger + hiding everything except returnto [20:11:54] it just says return to the article page [20:11:58] oh! [20:12:00] that's awesome [20:12:03] yeah, let's do that [20:12:10] next iteration [20:13:17] New patchset: Jdlrobson; "simplify login/logout confirmation message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48158 [20:13:37] ^ Maryana [20:13:48] wooooo [20:14:03] you're the best [20:14:09] i'll upload a screenshot [20:14:21] fabulous. thank you! [20:15:02] Maryana: http://imgur.com/xElWGWA [20:15:19] perfect! [20:15:46] i mean, not perfect but it will do sooo much better than what's there now [20:15:48] :) [20:15:53] New patchset: JGonera; "Increase line-height for inputs slightly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48159 [20:16:32] can we add some indication that the sign in was successful, jdlrobson? [20:16:45] even just the word "success!" [20:16:50] nope not easily :( [20:16:53] bah [20:16:58] oh well, still better, i think [20:17:04] at least it's clearer what to click [20:17:08] there's only one thing to click :D [20:17:09] yeah, definitely [20:17:14] hehe, yep [20:19:16] New patchset: Jdlrobson; "simplify login/logout confirmation message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48158 [20:28:55] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [20:28:56] New patchset: JGonera; "Move require()/define() to modules.js file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [20:29:49] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48158 [20:32:30] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [20:33:51] New review: Jdlrobson; "This has no effect on my Nexus Google Chrome" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/48159 [20:36:39] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [20:36:39] New patchset: JGonera; "Move require()/define() to modules.js file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [20:42:06] New patchset: awjrichards; "(mingle #330) Removes nasty db selection hack for photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48164 [20:43:58] New review: awjrichards; "Made fixes, also updated commit message to make clear TODO notes are for future changesets. Their la..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/48059 [20:49:55] New patchset: Jdlrobson; "cleanup jshintrc" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48166 [20:50:21] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48166 [20:55:19] jdlrobson, so we need to deploy https://gerrit.wikimedia.org/r/#/c/48058/ next time? [20:55:32] New patchset: Jdlrobson; "Move require()/define() to modules.js file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [20:55:37] ori-l there? ^ [20:55:50] hey [20:55:54] what's up? [20:55:55] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47623 [20:56:08] New patchset: Jdlrobson; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [20:56:46] ori-l: MaxSem is asking about deploying https://gerrit.wikimedia.org/r/#/c/48058/ [20:57:29] It should go out on Monday w/the wmf9 rollout, I think? [20:57:34] But in principle, yes. [20:58:59] ori-l, wmf9 is already branched [20:59:30] I'll prepare a couple of backports to merge them before scapping [21:05:18] thanks MaxSem [21:07:18] tfinc: I've the Nexus 7 now :) [21:07:20] tanke [21:08:19] interestingly, it also came with an AT&T Sim Card [21:08:23] which I guess is useless for me [21:16:14] Maryana: ping? [21:16:33] whiskeypanda: pong [21:16:34] Maryana: what do I have to to do get access to EventLogging data? [21:16:49] do you know SQL? [21:16:51] New patchset: JGonera; "Prevent scaling fonts in landscape on iPhone" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48170 [21:16:58] enough to get by :) [21:17:12] there's a shared researcher SQL account that we use to access the slave DBs via stat1 [21:17:44] i use a gui called sequel pro which is pretty nice for beginners [21:17:51] it's free :) [21:18:18] but I need access to it no? [21:18:20] but you need stat1 access. you can get that if you email ops [21:18:23] right [21:19:27] Maryana: whom do I email? [21:19:45] ori-l: said something about being able to hnad it out? :) [21:19:54] Change abandoned: JGonera; "Not a universal fix." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48159 [21:19:54] hmm, try CT? [21:19:59] hmm, ok [21:20:04] i'll put you on cc [21:20:08] tfinc around? [21:20:31] we should really just give the whole mobile team stat1 access, since that's where our data lives [21:21:12] but yeah, you should just send him your public key, and he should be able to get you all set up [21:21:24] and i can send you the researcher account login info [21:21:25] WhiskeyPanda: RT [21:22:37] Maryana: uh oh, then I shouldn't do that now. Will do on Monday [21:22:49] Reedy: I've access, will file a ticket on Monay [21:22:50] *Monday [21:23:47] kk. do you have any logging live currently? i can poke at it for you in the meantime :) [21:24:26] Maryana: nope! I'm going to first poke around, add logging for upload failures for non-network causes [21:24:33] been getting a fair bit of title blacklist stuff, for example [21:24:47] Maryana: but I suppose I'll need to understand what I can and can not log (privacy implications) [21:25:00] ah, yes [21:25:07] I suppose I could just poke you before I put some code in to make sure it is a'ok? :) [21:25:12] like, usernames are okay / not okay? [21:25:22] file names that failed while being uploaded? [21:25:30] yeah, just run it by me. usernames are fine [21:25:41] it's anon tracking that's less kosher, generally [21:25:45] can you give me an example of something that's not fine? [21:25:51] ah yes. we don't have anons so that's cool :) [21:26:03] yep, i think you should mostly be ok [21:26:15] hmm, okay. [21:26:20] things like device info? [21:26:34] geography info? [21:26:34] yeah, that's all captured in squid logs anyway [21:26:44] that i'm not sure about [21:26:51] well, this can get a lot more accurate than squid logs. [21:27:13] yeah, I suppose geography info beyond level of what IP can give us is not kosher? [21:27:56] right. my understanding is it's ok in aggregate, but associating usernames or user tokens to geography is a no-no [21:28:02] Maryana: aaa [21:28:03] h [21:28:08] so I can have two different schemas [21:28:11] one that does geography [21:28:20] but has no way to link to the other one which can contain user names [21:28:27] right [21:28:42] so being able to associate 'this user tried to upload a PNG file of this size at this time, and it failed with this XML response from the server' is completely okay [21:28:55] as long as I do not say 'while he was standing at this lat / lon' [21:28:57] got it [21:29:02] yeah, we're going to be doing that soon on mobile web [21:29:20] https://meta.wikimedia.org/wiki/Schema:MobileUploads [21:30:03] user token == username? [21:30:18] I can log usernames in the clear, right? [21:30:31] no, user token is a unique token associated with all users [21:30:59] userid is the user id that mediawiki assigns each new person [21:31:08] those are more or less sequential, whereas tokens are random hashes [21:31:30] i guess i should take out the user token for that schema, actually [21:31:31] well, in the app, all I have is the user name itself [21:31:43] unless I specifically ask for the sequential userid [21:31:54] but that's the commons username, correct? [21:32:02] (I've done some work with toolserver (and mw dev before that) so am a bit familiar with the MW Schema) [21:32:07] Maryana: yup. [21:32:11] so those users will also have a userid [21:32:28] it's just a matter of preference. it's somewhat easier to join userids than usernames [21:32:43] and usernames can be in weird characters that dirty up your data [21:32:55] oh, right. I forgot. [21:33:02] right. [21:33:08] heh. yeah, it took me awhile to figure that out [21:33:09] I think I should go at this the other way around [21:33:19] what reports do I want -> what data to collect [21:33:26] than the other way around [21:33:49] indeed [21:34:03] ah [21:34:18] hmm, so then the only thing I could think of now is the 'for what non-network reasons are uploads failing' [21:34:20] the nice thing about eventlogging is you can recalibrate [21:34:34] so that's going to be a bit different with apps. [21:34:49] since every time we push out, it's going to take at least a week for a good chunk of people to update [21:34:53] and some people never will update.... [21:35:00] ah, good point [21:35:19] that also creates verisoning problems, I suppose [21:35:20] so you'll need to know app versions [21:35:23] right [21:35:34] since old versions will need to be kept around for update laggards [21:38:19] Maryana: I'll make a page about what reports we would like, and then work from there. will mail out today or monday. [21:38:47] sounds great :) [21:39:32] sweet. [21:39:34] thanks Maryana [21:39:46] anytime! [21:39:53] * Maryana <3's eventlogging [21:39:54] :) [21:39:57] heh :) [21:40:02] we'll be the first non-web users of it [21:40:06] let's see what problems we dig up! [21:40:53] yep [21:41:04] Maryana: oh, and another thing me and brion talked about [21:41:12] is pushing off implementing Sign Up on the apps for a bit [21:41:23] since people who sign up will have no other view into the Wikimedia world [21:41:36] no idea of talk pages, user talk pages, about why stuff gets deleted, anything whatsoever [21:41:36] tfinc says we're aiming at existing commons users for the first couple iterations [21:41:43] so we don't really _need_ account creation at this point :) [21:41:45] yeah, so that'll work too. [21:41:53] though we want to get the plumbing in... [21:41:55] so let's do the API [21:41:59] yup [21:42:10] that makes sense to me [21:42:28] and perhaps even put in an account creation thing that appears when you hold the phone in landscape and point in the direction of Stallman's last known location.... [21:42:39] hehehe [21:42:40] ahahah [21:43:22] and then wikipetan pops up and says "it looks like you're one of us already. care to sign up?" [21:43:32] juuuuuust kidding [21:43:34] :P [21:43:38] hehe [21:43:45] I mean, if you know stallman's last known location... [21:43:50] then yeah, you can handle commons [21:44:09] we should also probably start betting pools or something on when the first NSFW pic will show up [21:44:17] and more importantly, when the first undeletd NSFW pic will show up [21:44:25] (considering that we're targetting experienced commons users - not long) [21:47:04] brion: I also have the Nexus 7 :) [21:47:12] huzzah [21:50:22] i hope for a future nexus 7 version with a 1920x1200 screen. 1280x800 is ok except that all the images in everything get scaled because it's at a freak 1.33 pixel scale ratio [21:50:27] brion: also did you look at calabash yet? [21:50:28] 1920 would bump it up to 2.0 [21:50:34] ah, nice [21:50:34] haven't tried it yet [21:50:45] considering my luck, since I just got one - I expect an updated nexus 7 in about 1 week [21:50:49] (that is what happened last time!0 [21:50:50] haha [21:51:05] bbiab [22:05:46] jdlrobson, why doesn't SkinMobile provide a target to resourceLoaderLink() in one case: [22:05:47] $this->resourceLoaderLink( $moduleNames['bottom'], 'styles' ); [22:06:17] ummmmm good question :) [22:06:20] it probably should [22:06:56] alright - I'm currently refactoring this stuff, will try to address this [22:07:16] sweet thanks Max [22:07:19] (I discovered a terrible client-side cache fragmentation) [22:07:23] i'd love to kill resourceLoaderLink if possible :( [22:07:33] MaxSem: yeh? what did you discover? [22:07:34] yeah [22:08:01] jdlrobson, we currently have only one main link for scripts and styles [22:08:33] one main link? [22:09:03] so when user goes to a special page, that page's module is added to the link, resulting in user downloading all the other modules once more [22:09:55] i can see that being a problem for stylesheets but i thought RL takes care of that for js? [22:10:03] actually no.. won't stylesheets be unique links? [22:10:14] this is solvable with module groups, however resourceLoaderLink() doesn't support groups [22:10:47] addBottomScripts outputs an inline script that triggers all the loads no? [22:13:36] mhm, scripts are handled properly indeed [22:13:48] well, there's till room for cleanup [22:13:54] *still [22:17:08] New patchset: Jdlrobson; "remove some cruft (code hygiene)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48202 [22:17:17] New patchset: MaxSem; "Remove $wgMFEnableResourceLoader, now it's unconditional" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48203 [22:17:54] jdlrobson, ^^ [22:18:01] MaxSem: ^ any situations we might want to turn it off? or are we just screwed if it doesn't work? :) [22:18:36] jdlrobson, we rely on it for message delivery - and we're going to kill JS for devices that don't support it:) [22:19:50] true [22:19:52] ok done [22:20:03] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48203 [22:20:39] New review: MaxSem; "You forgot argh [22:20:59] grep fail [22:21:14] doesn't your editor have search?:) [22:21:14] New review: awjrichards; "\o/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48203 [22:28:12] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=42708 [22:28:25] MaxSem: yeh but for some reason i either used it wrong or it came from cache [22:31:10] New patchset: JGonera; "(bug 42708) Show image upload preview when using Android gallery" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48204 [22:31:28] New patchset: MaxSem; "Rm unused variables, fix parameter types" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48205 [22:40:07] New patchset: JGonera; "Fix URL to description page for newly uploaded images" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48148 [22:45:54] New patchset: JGonera; "Change the namespaces where we show upload to main and user" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48207 [22:52:03] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [22:55:20] New patchset: JGonera; "Add progress bar to photo upload progress notification (#379)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [22:55:21] New patchset: JGonera; "Add progress event forwarding for Api calls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48049 [23:00:33] jdlrobson: we should sync up with ops about the performance implications of https://gerrit.wikimedia.org/r/#/c/48156/ and make sure that our infrastructure can really handle watchlist/login in production [23:01:21] awjr: you mean https://bugzilla.wikimedia.org/show_bug.cgi?id=44126 ? [23:01:26] that's the only real problem [23:02:13] jdlrobson: that's not the only potential problem at all, logging in bypasses caching, plus we're forcing https for logged in users [23:02:44] ok so we need to have that conversation before +2ing or before deploying? [23:02:53] it hadn't really occurred to me before i started reviewing that changeset, but we should really dbl check with ops before we deploy [23:03:23] jdlrobson: i think before we deploy [23:03:34] ok cool [23:03:40] i want to get this code review backlog cleared if possible [23:03:47] jdlrobson: can you coordinate with ops to make sure this is all good to go? [23:04:03] jdlrobson: fo sho [23:04:53] awjr: who would be best to talk to? [23:04:55] New patchset: Jdlrobson; "remove some cruft (code hygiene)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48202 [23:05:45] jdlrobson: probably asher but i think he's currently travelling, ryan lane is probably a good back up - probably an email to wikitech-l and/or ops list + a check in with someone in person in the office would get this going quickly [23:06:54] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48204 [23:07:07] ryan lane is traveling too i think? [23:07:12] wikitech seems like the best option [23:07:27] jdlrobson: agreed - if there's any opsen in the office, ask them too [23:09:50] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48205 [23:10:13] jgonera: https://gerrit.wikimedia.org/r/#/c/47673/ [23:10:27] brion: https://gerrit.wikimedia.org/r/#/c/47915/ [23:11:33] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48170 [23:12:22] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48207 [23:12:51] im seeing something funky in https://gerrit.wikimedia.org/r/#/c/45912/10 [23:13:23] in stable, when i tap in the nav to go to random, or settings, if i toggle the footer before the page finishes loading, the request for settings/random is cancelled. [23:13:33] jdlrobson, jgonera ^ [23:13:41] New review: Jdlrobson; "see comments on patch set 9" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45912 [23:14:00] New patchset: MaxSem; "WIP: Avoid SkinMobile-specific functions and properties" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48209 [23:14:10] awjr, jdlrobson, jgonera - what do you think of ^^^? [23:14:25] will look in a bit, MaxSem [23:14:25] MaxSem: will look in a bit [23:14:29] wpw [23:14:30] er [23:14:30] wow [23:14:33] jinx jdlrobson [23:14:52] awjr: https://gerrit.wikimedia.org/r/#/c/48062/ < can i talk about your comment here quickly? [23:14:58] sure jdlrobson [23:16:03] OK so the only really reason i picked that hook is because that's where we were using it before [23:16:17] the main thing is that all other extensions have to be loaded at the time of the hook running [23:16:52] all it is doing is changing the definition of the module so that it no longer runs on mobile [23:17:01] hmm actually the behavior i mentioned with toggling the footer canceling request for random/settings appears to be in master also [23:17:13] awjr: open a bug [23:17:17] jdlrobson: yeah will do [23:18:31] jdlrobson: im trying to remember why we originally put that in the resourceLoaderRegisterModule hook handler... [23:21:36] ori-l originally put it in there [23:21:59] New patchset: Jdlrobson; "promote watchlist and login functionality to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48156 [23:22:00] awjr: well i don't mind either way [23:22:12] awjr: feel free to amend - as long as it disables watch list all is good [23:26:27] New patchset: Jdlrobson; "Make watchlist stars appear on watchlist (regression)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48210 [23:26:28] New patchset: Jdlrobson; "promote watchlist and login functionality to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48156 [23:28:56] mhm, I expect a funny deployment next week XD [23:29:23] yeah, it's a big one [23:29:49] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48148 [23:30:55] awjr, I've got an impression that code moved around from module to module causes the most problems [23:31:17] MaxSem: you mean RL modules? [23:31:24] yes [23:31:27] New review: Jdlrobson; "waiting on dependencies.." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/48049 [23:31:50] awjr, jdlrobson: I'm context-switching across eight different things, so if I drop something or seem unresponsive please forgive me and ping me again. [23:32:00] no worrires ori-l [23:32:27] awjr: MaxSem i'm drafting an email about next weeks deployment :) [23:33:41] please no more code till all the current stuff is merged!! :D [23:34:11] jdlrobson, that would be a hack [23:39:01] * jdlrobson wishes he'd had more time to work on nearby this week :) [23:39:39] i count 8 patches related to this iteration [23:39:59] so awjr what's happening with https://gerrit.wikimedia.org/r/#/c/48062/ ? [23:40:52] jdlrobson: well, that patchset that you have does not seem to work [23:41:03] in what way? [23:41:10] WFM [23:41:20] im still seeing ext.eventLogging loaded even when i have $wgMFLogEvents = false [23:41:38] awjr: are you running latest event logging? [23:41:40] (with head of master of EventLogging ext) [23:41:42] yes [23:41:44] i just pulled [23:41:49] er [23:41:59] how do you know it's loading? [23:42:08] and how do you know it's running? [23:42:15] i see this in the page html: [23:42:17] also MaxSem where is $wgUseEventLogging defined? [23:42:26] (reference https://gerrit.wikimedia.org/r/#/c/48060/2/wmf-config/mobile.php) [23:43:01] InitialiseSettings.php [23:43:01] awjr: what happens when you run mw.eventLog in console? [23:43:09] jdlrobson: oh, undefined [23:43:15] so it's not present.. [23:43:16] why would the module show up in the page html tho? [23:43:37] New review: JGonera; "Some comments, nothing major." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/47673 [23:43:42] awjr: not sure… 1s [23:44:23] MaxSem: where's InitialiseSettings.php ? [23:44:39] same place as mobile.php [23:44:44] err [23:45:16] meh [23:45:20] MaxSem: do you have thoughts on this? https://gerrit.wikimedia.org/r/#/c/48062/2 [23:46:31] awjr, stuff in ExtensionFunctions gets always run, while this hook is run only when needed [23:46:44] MaxSem: https://gerrit.wikimedia.org/r/48060 [23:46:47] that settles that then. [23:48:14] jdlrobson, looks right - let's not forget that it needs to be deployed [23:48:21] roger [23:50:15] New patchset: JGonera; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [23:50:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48062 [23:51:18] New patchset: JGonera; "Add progress event forwarding for Api calls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48049 [23:51:35] New patchset: JGonera; "Add progress bar to photo upload progress notification (#379)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [23:51:40] New patchset: awjrichards; "Add progress bar to photo upload progress notification (#379)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48050 [23:54:44] jgonera im getting the following error in stable/beta: . Uncaught Error: Unknown dependency: jquery.json http://m.virtualbot.com/testing/core/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20121226T223735Z [23:54:44] . sortDependencieshttp://m.virtualbot.com/testing/core/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20121226T223735Z [23:54:44] . sortDependencieshttp://m.virtualbot.com/testing/core/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20121226T223735Z [23:54:45] . resolvehttp://m.virtualbot.com/testing/core/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20121226T223735Z [23:54:48] . mw.loader.loadhttp://m.virtualbot.com/testing/core/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20121226T223735Z [23:54:50] . (anonymous function)http://m.virtualbot.com/testing/core/index.php/Main_Page [23:54:54] er sorry, that's with: https://gerrit.wikimedia.org/r/#/c/48050/6 [23:55:29] huh [23:55:32] New review: awjrichards; "This changeset results in JS errors for me in desktop chrome:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/48050 [23:55:42] I just rebased it, can you check again? [23:55:47] jgonera: my comment on the patchset is probably clearer than that garbled output ^ [23:55:48] jgonera: sure [23:56:31] jgonera: still exists [23:56:48] awjr, thanks, will look into it in a moment [23:56:53] cool [23:58:15] New review: awjrichards; "perhaps a result of the dependency, but i am getting the same js error on this patchset as its parent." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/48049 [23:58:52] awjr, you need to update core [23:58:54] New patchset: awjrichards; "Add on and emit methods to mobileFrontend (bug 44128)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/45912 [23:59:00] OH [23:59:55] i forgot to do that after jon mentioned the change during standup this am