[00:00:13] SUL? [00:00:19] single user login [00:00:27] it's what central auth does [00:00:27] brion ^ [00:00:39] when you log in on one project, it's supposed to log you in on all [00:00:58] I see [00:01:18] hmm, lastmodified still doesn't work [00:01:45] jgonera: actually that might be the upload problem [00:02:13] in fact i will now put money on that [00:02:25] jgonera: http://pastebin.com/KEzDVD80 [00:02:34] ^ so photo uploading does work [00:02:35] jgonera: so, you log in to enwiki but you don't get logged into commons [00:02:49] jgonera: https://commons.wikimedia.org/wiki/File:Lead_Photo_For_Argavieso0-589199546026066.jpg [00:03:12] awjr: you're wrong :) [00:03:23] awjr, jdlrobson discovered something, I'll try to analyze that [00:03:24] jdlrobson: about which part? [00:03:30] uploads via the old method worked [00:03:39] since we've refactored the javascript api code it's broken [00:03:52] i'm logged in on commons and wikipedia [00:04:51] Krinkle, more than 5 minutes passed after awjr's fix - yet the messages are still absent [00:05:01] with *debug=true* [00:06:07] jdlrobson: you're logged in to commons and wikipedia as a result of logging in via mobile on enwiki? [00:07:04] MaxSem: awjr do you want to investigate the messages - me and jgonera will fix photo uploads [00:07:09] awjr: correct [00:07:21] that's what we're doing [00:07:23] jdlrobson: that is not working for me. can you please log out of both and try again? [00:07:49] and yeah, jdlrobson that's fine [00:08:21] MaxSem, Krinkle maybe we should try refreshing the i18n cache for wmf9 [00:08:34] ugh [00:09:07] MaxSem: Can you give me a url where I can see the messages being missing? [00:09:27] https://test.m.wikipedia.org/wiki/Self-refedirect?debug=true#_ [00:09:38] Not the UI where it is used per se, just where they should be loaded (I'll use the console) [00:09:41] ok [00:10:10] ugh, same crap on wmf8 [00:10:17] brion: YuviPanda: for notifications when will commons see echo ? [00:10:31] MaxSem: awjr: http://cl.ly/image/1Z2l2I1n213J [00:10:41] tfinc: when will it be available on Commons? or when will the app use it? :) [00:11:00] Krinkle, you need to enable beta [00:11:02] former [00:11:03] i'd think you'd need to be in mobile beta and on a page that loads the photo upload images [00:11:13] no idea, echo people don't tell me nothin' [00:11:18] MaxSem: ok [00:11:48] Krinkle: opt in to beta, then go to Special:DonateImage [00:12:01] awjr: MaxSem: http://cl.ly/image/3D3I0T2v2n2x [00:12:06] Indeed, get them now [00:12:22] brion: i'll mail kaldari. does echo add any new infrastructure or is it purely a visualization layer? [00:12:37] i don't know much about the actual implementation [00:12:52] Krinkle, MaxSem unless you have objections i'll try refreshing i18n cache [00:12:54] on wmf9 [00:13:07] no objections [00:13:54] awjr: MaxSem: This is the load.php request that is made on that page: https://test.m.wikipedia.org/w/load.php?debug=true&lang=en&modules=ext.eventLogging%7Cjquery.client%2Ccookie%2Chidpi%2Cjson%2CmwExtension%7Cmediawiki.cldr%2Chidpi%2CjqueryMsg%2Clanguage%2Cnotify%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmobile.beta%2Cstable%2Cstartup%7Cmobile.beta.dependencies%7Cm [00:13:54] obile.watchlist.schema&skin=vector&version=20130213T000206Z&* [00:14:03] Which contains: [00:14:04] "","mobile-frontend-image-uploading-cancel":"" [00:14:24] Krinkle: which suggests the messages are not in the l10n cache? [00:14:36] Exactly, the PHP code doesn't see them [00:14:49] When I create a url that is not in bits cache, it yields the same [00:14:49] https://test.m.wikipedia.org/w/load.php?debug=true&lang=en&modules=mobile.beta&version=blabla1 [00:15:02] That one has a fake timestamp, so it goes straight to the apaches. Same result [00:15:04] ok, im updating the l10n caches now [00:15:16] So eval.php giving you the right message probably only works on fenari [00:15:38] Krinkle, but in eval.php the messages work [00:15:42] If you try it on an apache, I suspect wfMsg('...') would in fact yield "" [00:15:51] ^ [00:16:28] aaaaa [00:16:38] no mwscript on apaches [00:21:55] ok we've solved the photo upload weirdness [00:22:04] what was it jdlrobson? [00:22:11] jgonera still debugging [00:22:22] but basically sending wrong data [00:22:31] oops [00:23:09] all good it makes logical sense [00:23:12] any luck on messages?' [00:23:14] :) [00:23:16] working on it, jdlrobson [00:23:19] sweet [00:23:23] im refreshing the message caches in prod [00:23:32] i hope this does it, otherwise im out of ideas [00:24:17] awjr, which instruction for refreshing are you using? [00:24:25] mw-update-l10n [00:24:33] from http://wikitech.wikimedia.org/view/How_to_deploy_code#Alternative_to_scap [00:25:39] awjr: ready to meet in 5 ? [00:25:51] tfinc should be [00:26:18] * awjr pokes l10n updater to go faster [00:29:34] Change abandoned: Jdlrobson; "too outdated - needs a rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42244 [00:29:43] Change abandoned: Jdlrobson; "too outdated - needs a rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/42245 [00:31:05] tfinc technical problems one sec [00:34:42] awjr, is your update complete? [00:39:13] MaxSem: yeah but sync didnt seem to work [00:39:21] geeeee [00:39:22] if you're still awake, can you run scap? [00:39:44] (im in a meeting) [00:39:47] awjr, not quite. I can run it in screen session and fall asleep [00:39:58] MaxSem: ok don't worry about it [00:54:54] this is magic, as soon as I don't bind any function to the upload progress event, uploads start to work again. I'm not sure how binding a callback to upload progress can cause CORS to fail... [00:56:08] Kringle, any idea? [00:56:18] Krinkle, any idea? [00:56:22] * Krinkle reads up [00:56:26] as soon as I comment this https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=javascripts/common/mf-api.js;h=8751728edcada70ff1a4c2f178edc78197d7b572;hb=HEAD#l59 [00:56:32] uploads start to work again [00:56:48] if this is present (doesn't matter what callbacks body is, can be empty) CORS fails [00:56:57] MaxSem: mwscript doesn't exist as a /usr/local/bin on apache's but the multiversion infrastructure is there (obviously) you can call /a/common/mutliversion/MWSCript.php (or something liek that) directly [00:57:02] mwscript on fenari is just a symlink to that [00:57:59] jgonera: Is this about the message breakage or about CORS? [00:58:04] CORS [00:58:07] I can't help you much with cors. [00:58:09] upload failing with 403 [00:58:10] Sorry :) [00:58:23] Try #wikimedia-dev or #wikimedia-operations instead [00:58:31] oh, ok, I though that maybe I was missing something in terms of how jQuery deals with XHR objects [00:58:47] it's client-side I guess, not server side [01:01:13] afaik the client-side code should be fine [01:01:17] Lets see [01:01:58] jgonera: Hm.. Not sure what's going on there, that seems rather hacky [01:02:17] why is it manipulating the internal xhr stuff and adding methods to the xhr? [01:02:22] " $.extend( request, EventEmitter.prototype );" [01:02:28] Krinkle, that's because jQuery doesn't support the XHR2 progress event yet [01:02:31] that seems potentially harmful [01:02:33] that's not relevant [01:02:42] method names might conflict etc. [01:02:56] that's true, but it's not causing this issue ;) [01:03:07] I think I know what might [01:03:26] data[key] instanceof Array -> Array.isArray(data[key]). Don't use instanceof for Array (or any other native constructor for that matter) [01:03:43] when I bind the progress event, the request is sent with OPTIONS verb instead of POST (I didn't even know OPTIONS existed) [01:03:48] Anyway, I don't see any alarm bells regarding CORS in this code. [01:04:10] OPTIONS is a sort of handshake before the actual request, to make sure it is all fine and stuff. [01:04:19] Because of variable headers, needs to be a separate request. [01:04:21] Array.isArray is present in all JS engines? [01:04:41] hm [01:04:43] jgonera: Well, if you don't even care about CORS not working, Array.isArray is the least of your concerns [01:05:01] But $.isArray if you will, it's a direct reference in modern browsers [01:05:01] huh? I care about both [01:05:11] ok, will change that [01:05:27] what is the reason of not using instanceof with native constructors? [01:05:33] for* [01:05:41] Basically: if ( Array.isArray ) { $.isArray = Array.isArray} else } $.isArray = function (a) { return $.type(a) === 'array'; }; [01:05:54] jgonera: Because they are unreliable and incorrect. [01:06:06] Arrays can be constructed in different ways and come from different contexts [01:06:11] Array === window.Array [01:06:42] which means if an array comes from another window, frame etc. it will be a native array by the language, but it will not be an instanceof the local reference you have to the Array constructor [01:07:10] Basically it comes down to JS being a prototypal language, trying to use it as a classical language will result in these kind of quirks [01:12:01] jgonera: is jon still in the office? [01:12:56] actually, either way jgonera - my message updating failed (weird permissions problems when i tried to sync) and at that point it was too late for me to comfortably sync (i gotta take off in a minute), so i'm going to continue following up with the messaging stuff tomorrow [01:13:17] awjr, he has just left [01:13:36] ok jgonera no worries, i'll email the team and update with what i just told you [01:13:44] did you guys make any headway with the upload stuff? [01:13:47] awjr, that's ok, we'll fix that tomorrow, maybe together with the upload itself [01:14:07] MaxSem: awjr: [01:14:15] i am glad these problems are not in stable - today wiped me out enough as it was :p [01:14:17] krinkle at srv193 in /apache/common (master*%) [01:14:17] $ php multiversion/MWScript.php eval.php testwiki [01:14:17] > wfMsg('mobile-frontend-image-uploading-long'); [01:14:18] > return wfMsg('mobile-frontend-image-uploading-long'); [01:14:20] <mobile-frontend-image-uploading-long> [01:15:05] ugh [01:15:07] > return wfMsg('mobile-frontend-image-uploading-cancel'); [01:15:08] <mobile-frontend-image-uploading-cancel> [01:15:13] So.. [01:15:13] why I'm not yet asleep? [01:15:22] good question MaxSem, you should change that :p [01:15:27] we can fix the message stuff tomorrow [01:15:32] or maybe it will just fix itself by then [01:19:20] im off - goodnight everyone [01:19:35] goodnight! [01:19:37] awjr, I know what's causing it [01:19:39] and good deployment :) [01:19:49] sadly it's the combination of CORS and progress bar [01:25:05] \o/ [01:25:08] mystery solved [01:25:13] now we just have to make it work :P [06:20:24] * YuviPanda looks around [06:22:29] and what does YuviPanda see? [06:22:43] no brion nor tfinc [06:22:48] since they had pinged me when I was away [06:23:08] also a large headache. I guess I'm old now, and my body can't handle 3 days of sleep deprivation like it used to [06:26:05] what does Danny_B see? [06:26:26] * Danny_B was not looking around... ;-) [06:35:34] New review: Krinkle; "Patch Set 2:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48663 [06:37:14] New review: Krinkle; "Patch Set 2:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48663 [07:43:39] New review: Siebrand; "Patch Set 5: Code-Review+1" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/43001 [08:25:53] New patchset: MaxSem; "Prevent fatals in dumps" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48797 [08:28:58] New review: Hashar; "Patch Set 1: Code-Review+2" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/48797 [08:32:34] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48797 [08:44:24] New patchset: MaxSem; "Prevent fatals in dumps" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/48800 [08:44:48] New review: MaxSem; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (production); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48800 [08:44:49] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/48800 [08:58:41] New patchset: MaxSem; "Now fix for realz" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48804 [09:00:25] New review: ArielGlenn; "Patch Set 1: Code-Review+2" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/48804 [09:00:44] New review: ArielGlenn; "Patch Set 1: Verified+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 - https://gerrit.wikimedia.org/r/48804 [09:00:45] Change merged: ArielGlenn; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48804 [09:03:50] New patchset: MaxSem; "Now fix for realz" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/48805 [09:04:02] New review: MaxSem; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (production); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48805 [09:04:04] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/48805 [09:57:59] * YuviPanda pokes MaxSem [09:58:07] * MaxSem poked [09:58:21] MaxSem: do you know where the EventLogging events go? [09:58:30] and do you have access to it? [09:58:39] low priority, I can always wait till night for ori-l [09:58:40] no/no [09:59:08] heh ok [11:13:40] [java-morelangs] yuvipanda pushed 1 new commit to master: http://git.io/0Q6H-w [11:13:40] java-morelangs/master 3d128fa YuviPanda: Updated to latest jQuery.IME [11:18:45] [aosp-morelangs-ime] yuvipanda pushed 2 new commits to master: http://git.io/wl_NeA [11:18:45] aosp-morelangs-ime/master 3ac7916 YuviPanda: Restrict installs to minimum JellyBean [11:18:45] aosp-morelangs-ime/master 697bfea YuviPanda: Updated to have more languages [11:28:18] [java-morelangs] yuvipanda pushed 1 new commit to master: http://git.io/bMJfYQ [11:28:18] java-morelangs/master 1b95bdd YuviPanda: Updated to latest jQuery [11:29:17] [aosp-morelangs-ime] yuvipanda pushed 2 new commits to master: http://git.io/50aSXw [11:29:17] aosp-morelangs-ime/master dc1d742 YuviPanda: Renamed it to MoreLangs keyboard [11:29:17] aosp-morelangs-ime/master 43e401e YuviPanda: Updated to latest morelang [16:39:14] New patchset: Zfilipin; "Updated multi_json Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48840 [17:36:20] MaxSem: seems like the messages in beta took care of themselves [17:36:27] meh [17:36:43] * awjr shrugs [17:36:53] while it's good to hear, WTF is it with our message cache? [17:37:56] yeah, i dunno - and the procedure for deploying the message cache after refreshing it did not work for me yesterday - i got permission denied errors when i tried to run sync-l10nupdate-1 1.21wmf9 [17:38:01] Reedy: ^ [17:38:32] worked fine for me earlier this week... [17:38:49] awjr, mebbe it had to be run as some weird user like l18nupdate [17:38:57] Reedy: i got mw1172: Permission denied (publickey,password) for what looks like every server [17:39:02] Oh [17:39:07] I think Tim changed something with sudo [17:39:17] I'm sure I saw it from gerrit [17:39:29] he mentioned he changed some mwscript related stuff in a wikitech email [17:39:35] but dunno if that would be related [17:41:03] if the timestamps on the caches look right on home on fenari, I'd just sync-dir it [17:41:33] Reedy: where do the caches live? [17:41:37] on fenari i mean [17:41:49] /home/wikipedia/common/php-1.21wmfX/cache/l10n [17:42:05] what is the practical difference between sync-dir'ing the message cache vs running sync-l10nupdate? [17:45:34] Almost nothing [17:45:35] cat `which sync-l10nupdate-1` [17:46:05] vs cat `which sync-common-file` [17:46:38] cool, thanks Reedy [17:49:02] hi brion [17:49:12] hey [17:49:21] brion an update https://www.mediawiki.org/wiki/File:Commons-ios-app.png [17:49:27] * brion looks [17:50:11] pretty :D [17:50:41] brion: :) [17:51:00] brion: the larger thumbnail does look better/ [17:51:11] yeah i kinda like this middle size [17:52:11] brion: i was looking at the current build on an emulator on my comp [17:52:34] for the picture & login screen -- do we want to try to do that as a splash on every launch, or just integrate it into the login prompt when needed? [17:53:02] jdlrobson: i had no luck finding the phrase book [17:53:15] brion: can we do that? pick up the featured picture of the day and use it as a splash screen? [17:53:33] brion: like download the picture every time an internet connection is available? [17:53:38] well the initial splash is fixed and we can't update it [17:53:49] we could display a splash screen _after_ that but that slows us down a bit maybe [17:53:53] notnarayan: we never want to block app launch on external resources [17:54:08] we could load an image async in the background of the login screen though [17:54:31] notnarayan: i'd say queue it up in the background while a user is using the app [17:54:32] brion: can it pick from a set of pictures that we bundle with the app? [17:54:40] but dont block app launch [17:54:51] again not at launch, but we could bundle some samples to avoid fetching them over the net [17:55:43] brion: i like that [17:56:28] brion: and we could update those async every couple of weeks [17:56:32] but never block on them [17:56:40] tfinc: ya, that sounds good. [17:57:27] whee [17:57:31] pictures \o/ [17:58:19] notnarayan: do we have assets for the camera & add media icons? i can start on making a pretty circle button [17:58:42] brion: yes :) will send them to you after the standup [17:58:46] thx [18:00:52] brion: standup! [18:00:55] dammit robh stole my home office keyboard again [18:01:00] i'll make do on the laptop keyboard :D [18:01:47] tfinc: did you read this: http://www.ghacks.net/2013/02/13/opera-software-announces-move-to-webkit/ [18:02:03] preilly: serious? [18:02:27] thats a huge position change for them [18:02:29] brion: --^ [18:02:30] tfinc: yeah read: http://www.opera.com/press/releases/2013/02/13/ [18:02:45] "The shift to WebKit means more of our resources can be dedicated to developing new features and the user-friendly solutions that can be expected from a company that invented so many of the features that are today being used by everyone in the browser industry." [18:03:01] tfinc, brion ^^ [18:03:51] craaaaaazy [18:04:17] if ms switches we'll be back to a duopoly :D [18:07:46] brion: saw the reports subsection + the schemas? [18:08:24] \o/ nice [18:08:49] brion: I think those two should cover it all for us, except device reporting. I've asked ori-l about it, let's see how that goes. [18:09:41] should do. [18:09:56] i'll count launch-with-file as equivalent of 'shareintent' for ios [18:10:07] brion: yup. Should we rename it to match? [18:10:13] nah [18:10:15] 'external' perhaps? [18:10:59] could do [18:11:11] brion: let me do that [18:11:14] ok [18:12:27] brion: done [18:12:44] +1 yay [18:13:02] Maryana: can you tell me when you have a little time to check up stuff on what EventLogging collects? Since I don't have access yet and ori-l isn't around yet? [18:13:07] ok so i'll have to record the source along with my pending-upload records. easy enough [18:13:27] yuvipanda - absolutely [18:13:46] i'll be poking into stat1 today to look at mobile web account creations & stuff anyway :) [18:14:04] Maryana: ah sweet :) [18:14:13] Maryana: can you check if any data at all got in into https://meta.wikimedia.org/wiki/Schema:MobileAppUploadErrors [18:14:13] ? [18:14:26] should be a few records in there, and if so can you just copy psate for me? [18:14:29] tfinc: preilly http://ejohn.org/blog/webkit-is-the-jquery-of-browser-engines/ [18:14:32] I should get my access today or tomorrow [18:14:41] yay webkit :) [18:14:52] jdlrobson: nice. will read later [18:14:56] sure, will do in a min. brb, relocating to coffee shop [18:17:25] tfinc: thanks for the quick response on the ticket :) [18:17:30] hopefully it won't get done today [18:18:02] YuviPanda: let me know how your accessing the data and how useful it is. if its useful then i'll get the same access [18:18:12] tfinc: I don't have it yet [18:18:20] but yes, it will be super useful [18:18:45] I'll talk to ori - ideally I'll want 'dashboards' of charts and stats that are publicly available, rather than only things that you can phyiscally run [18:20:35] New patchset: awjrichards; "(mingle #330) Removes nasty db selection hack for photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48164 [18:29:15] brion: how do you want the assets to be sent to you? [18:31:16] yuvipanda, i'm grepping through the logs and don't see any matches in client-side events. did you activate the schema in yesterday's deployment? [18:32:20] awjr: i figured it was cookie related [18:32:40] would be good to get that deployed as the experience is somewhat broken without it! [18:32:50] i'd hate people to notice they keep having to login and then giving up on the feature [18:34:18] brion: how do you want the assets to be sent to you? zip? [18:34:56] jdlrobson: yep [18:35:19] notnarayan: sure that'd be fine [18:35:28] brion: sending them right away. [18:36:20] jdlrobson: i notified ops in the channel - the usual suspects aren't around currently but i'll shepherd it out [18:37:08] maybe preilly could help? [18:39:47] New patchset: JGonera; "Make sure API wrapper doesn't process FormData objects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48857 [18:41:07] jdlrobson: he's helping poke [18:41:19] just to check awjr the cookie name is forceHTTPS not forceHttps ? [18:41:38] correct jdlrobson [18:44:12] jdlrobson, i'm trying to find the pw for our wikipedia mobile twitter account. do you have it? pm me? [18:45:30] oh wait, nm, i found it :) [18:50:05] awjr: your change should be live soon [18:50:13] w00t! [18:50:18] jcmish: can you pass me your travel dates. i want to make sure rachel has them [18:50:19] jdlrobson: ^^ [18:50:29] awjr: we are just waiting on a puppet run on those individual mobile caches [18:50:31] awjr: ? [18:50:42] jdlrobson: that change is on its way out as soon as puppet runs [18:50:47] ah ok sweet :) [18:51:14] yup 2/24- 3/2 [18:51:28] and tfinc I tried to add them to the engineering calendar [18:51:34] but it won't let me [18:51:51] thanks [18:52:13] awjr: wow —> http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&s=by+name&c=Mobile%2520caches%2520eqiad&tab=m&vn= [18:53:44] preilly: what are you wow'ing? the utilizaiton? [18:54:10] awjr: yes 82% on one box [18:54:14] New patchset: JGonera; "Disable forwarding of progress events" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48859 [18:54:37] ohhh twitter just went crazy Maryana [18:54:45] yaaaah! [18:54:56] * Maryana high fives [18:54:56] preilly: is that likely from puppet run? [18:55:09] awjr: the CPU portion of it is [18:55:18] now everybody in the world knows i secretly edit justin timberlake articles… [18:55:39] Maryana: ?!? [18:55:43] hahaha [18:56:09] i took a screenshot of my watchlist for the blog post on watchlists - one of the most recently edited pages was Cry Me a River [18:56:14] don't judge [18:56:18] lol [18:56:22] http://thenextweb.com/apps/2013/02/13/wikipedia-now-lets-mobile-visitors-login-and-track-pages-will-soon-support-article-editing/?utm_campaign=social%20media&utm_source=Twitter&utm_medium=Spreadus&awesm=tnw.to_f0be4 [18:56:43] Maryana: I'm judging but just 11% judgmental [18:56:44] Maryana: The... docs didn't say that they have to be individually activated. eugh. [18:56:47] Maryana: that is quite an eclectic list, actually [18:56:50] that or I didn't read them carefully enough [18:56:52] sigh [18:57:19] heh, that's why e3 just hired a technical writer, yuvipanda [18:57:22] to fix this problem [18:57:25] whee sweet! [18:57:28] the documentation is terrible [18:57:35] Indeed [18:57:35] not your fault [18:57:49] So how does one test? [18:58:05] Maryana: also how can I delete https://meta.wikimedia.org/wiki/Schema:MobileAppUploadErrors [18:58:09] (not going to be using that one) [18:58:14] are you an admin? [18:58:50] i have staff rights, so i can - but you can just edit over it [18:59:23] that kills the OCD. [18:59:26] so please do delete :) [18:59:31] you should check with jdlrobson on how to test it out [18:59:32] Maryana: so how does one test? [18:59:33] ah [18:59:34] haha, ok [18:59:34] okay [18:59:48] i'm not really sure. there's voodoo developer magic involved. [19:00:14] I don't think 'setup varnish and 0mq and mw and mysql and ... on your dev machine' is the answer [19:00:16] at least I hope not [19:00:51] oh dear. I just topped up the wrong phone number. [19:00:53] * YuviPanda facepalms [19:01:00] that 5 looked like a 6, I swear! [19:01:24] jdlrobson: ping? [19:02:00] YuviPanda: 1s [19:02:25] jdlrobson: ok [19:02:43] Maryana: also does mobile web have an 'opt out' at all? [19:02:56] not yet, but i'm thinking we should do one [19:03:07] i don't think it would be too hard to just add a setting [19:03:41] yup [19:03:51] I think UX for 'Opt in' is a lot more harder [19:04:20] New patchset: Jdlrobson; "bug 44919: correct padding of watchlist icon on watchlist page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48861 [19:04:21] well on an app you just prompt on first run, like firefox or chrome do [19:04:34] Maryana: we have no user preferences on mobile yet - only device preferences [19:04:40] brion: that too. [19:05:19] ah, you're right, jdlrobson [19:05:32] Maryana: twitter is still going crazy [19:05:37] :D [19:05:47] track wikipedia mobile is the search term for twitter if you want to enjoy [19:06:13] mostly RT of the same article [19:07:00] nice [19:07:07] Maryana: is watch star usage / account creation sky rocketing? [19:08:20] awjr: MaxSem could you review https://gerrit.wikimedia.org/r/#/c/47194/ today [19:08:23] ^ jgonera also [19:08:28] looking [19:08:32] i'm keen to get this done before i go [19:08:38] gonna be extremely useful [19:08:42] holy shit - 85K watchlist taps [19:08:46] writing the "why photo uploads don't work" email, will check in a moment [19:08:58] it was 4K a few hours ago [19:08:59] ahhh [19:09:01] Maryana \o/ [19:09:02] :) [19:09:03] wow! [19:09:12] brb [19:09:16] i hope eventlogging isn't melting [19:09:20] this is a good stress test for it [19:12:56] Maryana: that kicks butt! [19:13:07] Maryana: adds/new account/etc ? [19:13:19] and 487 new account created through the watchlist star CTA :) [19:14:02] most of the taps are anons who are probably just curious & poking it [19:16:13] 400 unique logged in users tapping it [19:16:46] i'll round up all these numbers after the 1st 24 hours (ending at around 1 or so) and publish onwiki [19:17:37] ori-l: is event logging melting yet? [19:17:43] 487? wow [19:19:08] that's just through the star [19:19:13] there's more through the login link [19:19:31] check out the second graph from the top: http://toolserver.org/~dartar/reg2/ [19:19:52] that big blue spike is us [19:20:07] there's been a year-over-year decline in new account registrations [19:20:25] we just pushed the numbers back up to pre 2012 levels :D [19:21:04] \o/ [19:27:05] ok, time to head into the office and bask in mobile teaminess glory :) [19:34:00] New patchset: Jdlrobson; "Display thumbnails in watchlist using PHP" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48475 [19:34:43] New review: Jdlrobson; "Patch Set 3: Code-Review+1" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/48475 [19:35:37] jdlrobson: should I poke you or jgonera about asking how you guys tested your EventLogging stuff? [19:35:41] custom install of EventLogging? [19:35:46] or awjr_lunch perhaps? [19:36:05] hey YuviPanda what do you mean by testing? [19:36:10] We install the EventLogging extension [19:36:12] we just use it [19:36:40] Maryana said that particular schemas need to be 'activated' before they'll start logging data? [19:36:58] oh wait. You installed EventLogging ony our local instance? [19:37:08] where did the data go to? MySQL tables in your local machine? [19:37:52] EventLogging extensions is kind of a black box, we just tell it to log stuff and we don't even care when the data goes (that is until we want to see it ;) [19:38:05] New review: Zfilipin; "Patch Set 1: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/47330 [19:38:49] but it's a JS extension to MW, so I guess you'd have to write some kind of a wrapper around the API itself to use it in an app [19:38:55] YuviPanda: so from our perspective we define a schema via mediaWiki.eventLog.setSchema takes title of schema and a json representing a given revision of a schema on meta. We then simply call .log which fires an ajax request [19:38:57] jdlrobson: jgonera ah, hmm. I suppose I best wait for Ori-l then. Since I've to write my own client (no mw.eventLog) [19:39:14] I guess ori-l could tell you more [19:39:25] jdlrobson: yeah that's what I thought too. I looked at setSchema and .log and re-implemented them in Java [19:39:42] but since I don't have access to stat1 yet, asked Maryana to check [19:39:50] and she said my test logs dont' seem to be going through [19:40:12] hm [19:40:39] I'd ask ori-l, he might be able to figure it out right away (when he's online that is) [19:40:44] yeah, will do [19:40:55] YuviPanda: just pmed you with more details [19:41:09] btw, YuviPanda, what are the schemas we're going to use for logging photo uploads? [19:41:27] jgonera: https://meta.wikimedia.org/wiki/Schema:MobileAppUploadAttempts [19:41:41] not complete, but that seems to cover whatever we wanted for now [19:41:59] jgonera: https://www.mediawiki.org/wiki/Apps/Commons#Reports are the reports we want, so we'll be using two schemas for covering max of them for now [19:43:56] I'd change a few things [19:44:05] should I just go ahead and edit it? [19:44:17] feel free to! [19:45:02] jgonera: poke me when done? [19:45:09] ok [19:45:31] I'm especially concerned about recording username itself. While it gives us incredible reaching out opportunities, also has downsides [19:46:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=44017< jgonera MaxSem awjr_lunch is this still an issue [19:48:45] I'm now thinking, are we supposed to use the same schema for the apps and web site? because the name is MobileAppUploadAttempts [19:49:19] jgonera: nope [19:49:38] don't think we should, tbh. A lot of things that make sense in the mobile web make no sense in the app [19:50:01] hm, the only thing I came up with is that the source should be optional [19:50:14] jgonera: so the app code will always know what the source is [19:50:25] MaxSem: http://en.m.wikipedia.org/w/api.php?action=query&prop=langlinks&format=json&llurl=true&titles=Battleship&lllimit=500 < any chance this could return what language codes translate to? [19:50:26] \ [19:50:28] why should it be optional? [19:50:44] and I would split result into two fields, one required enum (success/error...) and another optional, errormessage [19:51:05] I'm saying, if we were to use it both for app and web site [19:51:15] I mean, if we have two total different schemas [19:51:24] then analyzing the results will only get more complicated [19:51:37] and after all, our goal is 1000 uploaders in total [19:51:45] including both the apps and mobile web [19:51:45] jdlrobson, I'm not sure 44017 is 100% resolved - I'd rather close it when we switched to OutputPage linking, which supports module groups [19:52:01] jgonera: true but there are fundamental workflow differences in the app vs web. [19:52:05] ok MaxSem [19:52:06] primarily no CTA at all. [19:52:16] plus I think this gives us far more flexibility [19:52:27] and I think getting aggregate stats out shouldnt' be that much of a problem [19:52:51] In fact I think total uploads should be counted via Upload Categories than EventLogging [19:53:16] ok, lets just check with Maryana once again to be sure that this is what she wants as she's going to analyze those logs [19:53:43] it's not "total uploads", it's "total uploaders" we care about [19:53:51] right [19:53:53] total uploaders too [19:54:06] is that possible without EventLogging? [19:54:17] of course. Template:Uploaded via Mobile [19:54:22] I think Maryana made a card for it [19:54:27] hm [19:54:28] but it hasn't made it into any iteration yet [19:54:45] jdlrobson, looks like we'll have to modify core for that [19:54:48] (we used the same thing for WLM counting too) [19:55:08] ok, so you can revert the change I've just made to the app schema ;) [19:55:16] haha [19:55:16] ok [19:55:45] MaxSem: :( [19:57:36] jgonera: I guess https://meta.wikimedia.org/wiki/Schema:MobileUploads is what is for Mobile Web [19:57:54] far more complete I suppose [19:58:32] though we should perhaps rename it MobileWebUploads [19:58:33] to avoid confusion [19:59:42] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=43771 [19:59:49] yes, we probably should [20:01:14] hello Maryana [20:01:17] can you tail the logs again? [20:01:18] :P [20:01:30] sorry I'm pestery. [20:01:35] haha, no worries [20:01:52] sorry I'm pestery. [20:01:53] err [20:01:54] sorry [20:01:56] elsewhere :) [20:02:06] YuviPanda: I'm sorry I couldn't respond earlier -- did you start an RT ticket yet? If not, I can start one. [20:02:20] ori-l: oh started, key attached, manager approved. waiting on ops now :) [20:02:38] I realized my earlier requests were not sending the ';' and hence didn't register perhaps [20:02:43] excellent. [20:03:17] * ori-l shall returns. [20:03:24] return. [20:03:27] ori-l: :) [20:03:43] Maryana: do you see anything? [20:04:03] (I'll be off in about 30 minutes, so if this works out and confirms my code works I can finish it up tomorrow morning) [20:05:01] * jdlrobson in line for burning man tickets [20:05:27] * jdlrobson might need someone to get him lunch at this rate [20:06:33] jdlrobson: :D Enjoy :) [20:06:41] it's just an animated gif [20:06:50] i'm not convinced it's actually doing anything [20:07:10] :P [20:07:44] yuvipanda, just deleted that schema for you :) [20:07:58] ow. but did you see any data come through for it? [20:08:12] hmm, i'm still not seeing anything in client-side logs. is there a specific term that should be showing up? [20:09:01] curl "http://bits.wikimedia.org/event.gif?%7B%22event%22%3A%7B%22username%22%3A%22Yuvipanda%22%2C%22funnel%22%3A1%2C%22uploadError%22%3A%22minimalistic%22%7D%2C%22schema%22%3A%22MobileAppUploadErrors%22%7D%3B;" [20:09:03] is my simulation [20:09:11] so you could grep for MobileAppUploadErrors *and* Yuvipanda [20:09:15] hell or just Yuvipanda :P [20:09:18] hehe [20:09:20] ok [20:09:24] lesssee... [20:09:26] jdlrobson, don't you think that 150px is too much for mobile connections? [20:09:53] Maryana: and see if it is getting into the db table too? [20:11:52] MaxSem: i'd need to look at in beta for a while - depends what the size difference is, but 50px looks far too pixelated.. [20:12:34] jdlrobson, with retina? [20:17:28] yuvipanda, not seeing events in the raw logs or the db tables [20:17:33] hmmm [20:17:37] let me debug. [20:17:56] * YuviPanda switches to https://meta.wikimedia.org/wiki/Schema:MobileAppUploadAttempts [20:18:32] i'm pretty sure creating a new table in the db requires a deployment [20:18:39] not sure about raw logs, though [20:18:57] Maryana: jdlrobson just told me that it doesn't... [20:19:06] oh, heh [20:21:13] let me check with s page [20:22:13] okay should've logged one to https://meta.wikimedia.org/wiki/Schema:MobileAppUploadAttempts now [20:31:37] bah google talk plugin keeps getting stuck at 100% of one cpu core [20:37:37] MaxSem: how hard do you think it would be to implement ESI now? looking through recent changes, it seems to me implementing ESI specifically for removing x-device variance should be a helluva lot easier now [20:38:46] awjr, I think we need another pass at RL simplification - after that it should be reasonably stable to add ESI support [20:39:10] MaxSem: what do you have in mind around RL simplification? [20:42:20] there's currently some atavistic stuff we need to clean up - for example, we don't need to build RL links ourselves anymore in most cases [20:43:26] yeah i was wondering about that - in what cases do we need to build the RL links ourselves? [20:44:21] nice usage of atavistic, btw [20:45:16] I thought that was 'altavistic' [20:45:29] New review: Jdlrobson; "Patch Set 1: Code-Review+1" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/48366 [20:45:29] and referred to a technique invented at altavista [20:45:40] I clearly need to sleep, I think. Good night everyone :) [20:46:48] New patchset: Jdlrobson; "bug 44484: return more than 10 languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48884 [20:50:38] New review: MaxSem; "Patch Set 1: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/48884 [20:51:53] the fun will be when we will create so many languages that it will require paging [20:52:47] New review: Jdlrobson; "Patch Set 1: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/48584 [20:53:18] New review: Jdlrobson; "Patch Set 9: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/48059 [20:54:18] New review: awjrichards; "Patch Set 1:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48584 [20:55:33] New review: Jdlrobson; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48859 [20:55:35] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48859 [20:59:02] awjr, is there a prio meeting? [20:59:08] MaxSem: yep [21:12:16] Ooh, Android 4.2.2 [21:20:11] Reedy, where? [21:20:30] http://www.theregister.co.uk/2013/02/13/android_422_for_nexus_devices/ [21:28:20] http://www.engadget.com/2013/02/13/wikipedia-adds-watchlists-mobile-web/?utm_source=twitterfeed&utm_medium=twitter [21:39:40] oo [21:40:01] Maryana: your watchlist is now ultra-famous thanks to engadget :) [21:40:12] wooo! [21:41:38] ooooh [21:43:49] man, google stopped doing updates for CDMA devices, so my galaxy nexus still hasn't even gotten a 4.2 bump yet. i have to wait for my carrier to push out an ota update, which will probably be like… years from now [21:45:30] http://www.gottabemobile.com/2013/02/12/wait-for-verizon-galaxy-nexus-android-4-2-update/ [21:45:32] grumble [21:49:20] MaxSem: awjr https://gerrit.wikimedia.org/r/#/c/47194/ poke [21:49:35] awjr: i only just got to 4.1! [21:51:09] jdlrobson: really? what carrier? [21:52:55] I had 4.2 on my galaxy nexus for aaages [21:55:10] awjr: t mobile [21:55:15] frankly, I don't see much sense in these templates [21:55:47] MaxSem: trust me we need them [21:55:58] Maryana: hey there. what is watch list usage looking like ? [21:56:10] Krinkle was saying that other teams were also asking about client side templating support in RL [21:56:23] maintaining html strings in javascript is horrible [21:56:46] can this stuff at least be moved to some other extension as they're not real HTML files [21:59:11] jdlrobson: wikidata [21:59:22] (= the other team) [22:00:00] thanks Krinkle [22:00:05] MaxSem, why would you like to move that to another extension? the Visual editor team actually wants that in the core at some point [22:00:48] MaxSem: the idea was to trial it in mobile, perfect it then push an upstream change [22:03:22] sorry, tfinc - in an analytics mtg [22:05:28] (ironically unable to actually do analytics… :-P) [22:06:39] Maryana_mtg: ok [22:10:43] New patchset: Jdlrobson; "bug 44484: return more than 10 languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48884 [22:13:33] jdlrobson, the fixme is probably isn't needed [22:14:15] MaxSem: it is. We use them to document upstream problems with API [22:14:28] there is no API problem [22:14:38] you get as many as you request [22:14:57] if you don't specify how many do you want, a lowish limit will be used [22:15:20] which seems stupid [22:15:29] nah [22:15:34] well regardless this is hackish [22:15:38] what if limit is 100 [22:15:39] a [22:15:44] if there's no limit, you're probably just playing around [22:15:46] and there are 500 languages returned [22:16:01] (as in max limit is 100) [22:16:19] do we really have to make further ajax requests? [22:16:48] yes [22:17:06] this is called performance limitations [22:21:54] New patchset: Jdlrobson; "bug 44484: return more than 10 languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48884 [22:22:59] jgonera: https://gerrit.wikimedia.org/r/#/c/48861/ [22:23:19] New review: JGonera; "Patch Set 6: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/47194 [22:26:21] New patchset: Jdlrobson; "Add template support to ResourceLoader" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47194 [22:27:16] New review: JGonera; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48861 [22:27:18] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48861 [22:32:53] New review: MaxSem; "Patch Set 3: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48884 [22:33:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48884 [22:33:48] New review: MaxSem; "Patch Set 7: Code-Review+1" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/47194 [22:37:21] New review: Jdlrobson; "Patch Set 1: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/48857 [22:41:24] MaxSem: is there an easy way for a special page to set template variables for SkinMobile? [22:42:20] easy? not sure, but I'm thinking about https://gerrit.wikimedia.org/r/48209 [22:42:27] New review: JGonera; "Patch Set 7: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/47194 [22:42:28] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47194 [22:42:55] yeah MaxSem [22:48:53] New review: awjrichards; "Patch Set 1:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48584 [22:49:04] jdlrobson: can you take a look at my comment in ^ [22:52:37] MaxSem: what do you think about emailing wikitech about https://gerrit.wikimedia.org/r/#/c/48208/1 ? it would hopefully get a faster review as well as advertise the change which would likely be useful to many [22:53:48] mhm [22:53:51] makes sense [22:55:54] New patchset: awjrichards; "(mingle 330) Styles upload count on dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48584 [22:55:54] New patchset: awjrichards; "(mingle #330) Removes nasty db selection hack for photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48164 [22:55:54] New patchset: awjrichards; "(mingle 330) Displays number of user uploads on upload dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [22:56:26] New review: awjrichards; "Patch Set 2:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48584 [22:58:11] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/L6EEUw [22:58:11] Commons-iOS/master 8d021f5 Brion Vibber: Moving async stuff to use Promise pattern... [23:07:34] whoa using random in alpha from a special page is scary [23:19:52] New review: awjrichards; "Patch Set 5: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/43001 [23:20:07] :) http://www.engadget.com/2013/02/13/wikipedia-adds-watchlists-mobile-web/ [23:20:38] Maryana_mtg: --^ [23:21:43] Maryana_mtg, I'm wondering, maybe we should crop screenshots so that Verizon or iPhone specific stuff doesn't show up? [23:21:53] so that we're not "promoting" anything [23:23:06] New review: awjrichards; "Patch Set 5: Code-Review-1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/43003 [23:25:03] awjr, https://gerrit.wikimedia.org/r/#/c/48164/3/includes/specials/SpecialDonateImage.php [23:26:00] doh MaxSem - i fixed it in https://gerrit.wikimedia.org/r/#/c/48164/4/includes/specials/SpecialDonateImage.php but a rebase screwed it up in the 5th patchset >_< [23:26:07] whee [23:26:14] i'll fix again one sec. [23:26:54] New patchset: awjrichards; "(mingle #330) Removes nasty db selection hack for photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48164 [23:29:34] MaxSem: ^ [23:29:43] i gotta run an errand, biab [23:32:27] New review: MaxSem; "Patch Set 10:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48059 [23:36:36] New patchset: JGonera; "Make sure API wrapper doesn't process FormData objects" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48857 [23:37:43] jgonera: good point.. didn't think about that [23:38:07] the screenshot stuff [23:41:12] awjr_afk: just reading through your comment now [23:42:07] MaxSem: Maryana http://vladentinesday.tumblr.com/ [23:42:27] wat [23:46:22] brion: you there? [23:46:48] yo [23:47:48] https://gerrit.wikimedia.org/r/#/c/47915/ < brion could you take a look at - i think it's fine but i wanted to check it fixed the bug you reported [23:49:16] looks like it should work, not sure i've got a good way to test atm :) [23:54:01] MaxSem: re https://gerrit.wikimedia.org/r/#/c/48059/10/includes/specials/SpecialDonateImage.php - why should that be a const? it would be nice to be able to adjust it programatically [23:54:59] what for? [23:56:15] i was sure i had an answer to that [23:57:49] whatever, i'll make it a constant; we can change if we come upon the need