[07:48:07] <wikipedia-github>	 [Commons-iOS] dz1111 opened pull request #28: Starting to add some unit tests (master...UnitTests)  http://git.io/6q-lFA
[08:17:54] <YuviPanda>	 notnarayan: heya/
[08:18:07] <notnarayan>	 YuviPanda: hows it going ? where are you?
[08:18:12] <YuviPanda>	 in pune
[08:19:24] <notnarayan>	 YuviPanda: anything on commons app?
[08:20:34] <YuviPanda>	 notnarayan: i told you the other day no?
[08:20:45] <YuviPanda>	 notnarayan: I also think we should stick to actionbar pattern in android
[08:20:49] <YuviPanda>	 rather than the split circular one
[08:20:54] <notnarayan>	 YuviPanda: why so?
[08:21:03] <YuviPanda>	 platform conventions?
[08:21:19] <notnarayan>	 YuviPanda: i see.
[08:21:19] <YuviPanda>	 that's conventions from every app, so we should stick to it for familiarity.
[08:21:40] <notnarayan>	 YuviPanda: well, that doesn't really matter so much
[08:21:49] <YuviPanda>	 as in?
[08:21:51] <notnarayan>	 YuviPanda: there aren't too many controls.
[08:22:21] <notnarayan>	 YuviPanda we don't *have* to follow conventions.
[08:22:32] <YuviPanda>	 but we should be good citizens and follow it
[08:22:40] <YuviPanda>	 and break it only if there is a *very* good reason
[08:22:59] <YuviPanda>	 iOS afaik doesn't have standard action-bar type pattern. Android does
[08:23:14] <notnarayan>	 YuviPanda: iOS does.
[08:23:25] <notnarayan>	 YuviPanda: but one does not need to follow it
[08:23:35] <notnarayan>	 YuviPanda: i thought android was a lil more flexible
[08:23:41] <YuviPanda>	 we should, unless we have a very good reason to not
[08:23:50] <notnarayan>	 YuviPanda: also, there will be more controls.
[08:24:04] <YuviPanda>	 yes, and they'll fit on the action bar + slide out menu, no?
[08:25:03] <notnarayan>	 YuviPanda: nothing on the action bar. the slide bar on top. what is that called?
[08:25:13] <YuviPanda>	 'slide bar'?
[08:25:15] <YuviPanda>	 ?
[08:25:18] <notnarayan>	 YuviPanda: :)
[08:25:24] <notnarayan>	 YuviPanda: slide bar it is.
[08:25:27] * YuviPanda  is confused

[08:25:30] <YuviPanda>	 i'm still confused
[08:25:31] <YuviPanda>	 what?
[08:25:37] <YuviPanda>	 what is the slide bar?
[08:25:50] <YuviPanda>	 both the thing on top and the bottom row is action bar ('split action bar')
[08:25:51] <notnarayan>	 YuviPanda: one sec
[08:25:57] <YuviPanda>	 we definitely should stick to it
[08:26:11] <YuviPanda>	 that is one of the problems with phonegap, apps looking alien.
[08:26:18] <YuviPanda>	 just because we could doesn't mean we should
[08:26:41] <notnarayan>	 YuviPanda: https://upload.wikimedia.org/wikipedia/commons/archive/c/c6/20130206183024%21Commons_media_discovery_app.png
[08:27:27] <notnarayan>	 what do you call the bar that has campaigns my uploads and today
[08:27:36] <YuviPanda>	 (on a side note, media discovery isn't even in our top priority for a long while)
[08:27:44] <YuviPanda>	 tabbar
[08:28:21] <YuviPanda>	 I think?
[08:28:27] <YuviPanda>	 should be in the android design guidelines
[08:29:10] <notnarayan>	 YuviPanda: im looking
[08:31:14] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/AVFqwQ
[08:31:14] <wikipedia-github>	 android-commons/master 0c5996c YuviPanda: Remove useless Hello World string
[08:31:51] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #61: SUCCESS in 36 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/61/
[08:31:51] <mw-jenkinsbot>	 yuvipanda: Remove useless Hello World string
[08:32:30] <YuviPanda>	 notnarayan: http://www.androidpatterns.com/uap_pattern/slideable-top-navigation
[08:32:32] <YuviPanda>	 closest
[08:32:34] <YuviPanda>	 i got
[08:33:11] <notnarayan>	 YuviPanda: ya, this one
[08:34:23] <YuviPanda>	 notnarayan: but still, actionbar. Let's not do non-standard UI just because we can
[08:34:57] <notnarayan>	 YuviPanda: you know how the standard one would look right?
[08:35:14] <YuviPanda>	 the current one is the action bar, yes.
[08:35:59] <notnarayan>	 YuviPanda: can we alt east remove the text labels and have similar icons as we have on iOS
[08:36:10] <notnarayan>	 YuviPanda: did you see brions implementation of the same?
[08:36:24] <YuviPanda>	 the current actionbar doesn't have text labels
[08:36:41] <YuviPanda>	 but considering that we do have space I think perhaps we should add them?
[08:36:45] <YuviPanda>	 (for the actionbar)
[08:36:48] <notnarayan>	 YuviPanda: https://www.mediawiki.org/wiki/File:Commons-iOS-2013-02-14.webm
[08:36:49] <YuviPanda>	 no I have not. should do.
[08:37:30] <YuviPanda>	 nice :)
[08:37:48] <notnarayan>	 YuviPanda: the icons are a little off, but that can be fixed.
[08:38:01] <notnarayan>	 YuviPanda: anyway, i must install the current build and see how it looks.
[08:38:18] <YuviPanda>	 notnarayan: okay. Did you work on the details I asked you to?
[08:38:36] <YuviPanda>	 I'm also unsure of not having any extra info at all (not even titles), but I'm sure that can be easily user tested
[08:38:59] <notnarayan>	 YuviPanda: so, on the my uploads page, no text with image.
[08:39:04] <YuviPanda>	 why?
[08:39:37] <notnarayan>	 YuviPanda: its my uploads.
[08:39:52] <YuviPanda>	 you can't really remember the title of them all can you?
[08:40:03] <notnarayan>	 YuviPanda: so
[08:40:29] <notnarayan>	 YuviPanda: whats the need to have text on top of the image in a gallery view?
[08:41:01] <YuviPanda>	 because you don't really have enough context from an image?
[08:41:11] <notnarayan>	 YuviPanda: context for what?
[08:41:18] <YuviPanda>	 for the image.
[08:41:26] <YuviPanda>	 the point of commons is not just the images
[08:41:29] <YuviPanda>	 but the data about the image
[08:41:33] <YuviPanda>	 the image by itself tells me nothing
[08:41:48] <notnarayan>	 YuviPanda: so we will have a individual image page that allows us to look through all that info
[08:41:57] <notnarayan>	 why have anything on the thumbnail at all
[08:42:20] <notnarayan>	 YuviPanda: the image by itself tell you nothing?
[08:43:37] <notnarayan>	 YuviPanda: i agree, well need to have text on images, if we are showing a featured image of sorts. but having it on every image in a gallery view in my uploads not sure
[08:44:03] <notnarayan>	 YuviPanda: I'm not sure if there is any context the user is looking for, thats all. but lets discuss this.
[08:47:32] <YuviPanda>	 notnarayan: the title at the least is necessary info I think.
[08:47:42] <YuviPanda>	 if you have 50 uploads, you're not really going to remember them
[08:48:03] <YuviPanda>	 besides, that is what Commons is about - not just the images but the metadata too
[08:48:05] <notnarayan>	 YuviPanda: of course i wouldn't.
[08:48:42] <notnarayan>	 YuviPanda: see, if you see todays featured pic of the day, its a fish,
[08:49:33] <notnarayan>	 YuviPanda: what it really is a european flounder. thats what commons gives me
[08:50:42] <notnarayan>	 YuviPanda: for discovery, yes, a title would be required. but who would d be discovering their own images?
[08:50:45] <YuviPanda>	 you've 30 images from ellora cave 16
[08:50:52] <YuviPanda>	 do you know what they all are?
[08:51:24] <notnarayan>	 do i need to know, once I'm done uploading
[08:52:08] <YuviPanda>	 yes. If you don't, why even have a My Uploads?
[08:53:08] <notnarayan>	 YuviPanda: aint this the reason we began with the share feature :)
[08:53:29] <YuviPanda>	 I thought that was simply because that was simplest to implement.
[08:53:32] <notnarayan>	 YuviPanda: lets park if we need a title or not for later. whats the next on the list.
[08:53:54] <notnarayan>	 YuviPanda: I'm not clear on that yet, ill discuss this with munaf and maryana.
[08:54:13] <YuviPanda>	 right. No details page.
[08:54:18] <YuviPanda>	 and no sizing info.
[08:54:28] <notnarayan>	 YuviPanda: I'm doing the details page right now.
[08:54:34] <YuviPanda>	 also if we put titles on them they need to be bigger. I'll probably just leave the thing as is.
[08:54:47] <YuviPanda>	 notnarayan: just keep in mind that the metadata is as important as the image itself. Some cases more so.
[08:54:58] <notnarayan>	 YuviPanda: not sure if that is the case.
[08:55:02] <notnarayan>	 YuviPanda: lets see.
[08:55:06] <YuviPanda>	 this isn't flickr
[08:55:19] <YuviPanda>	 notnarayan: it is.
[08:55:31] <notnarayan>	 YuviPanda: who said this is flickr?
[08:55:38] <YuviPanda>	 nobody, I said it isn't :)
[08:55:52] <notnarayan>	 YuviPanda: have you seen 500px
[08:56:04] <YuviPanda>	 a while back.
[08:56:36] <notnarayan>	 YuviPanda: ill give you the details page mock up and the sizing info by today evening.
[08:57:28] <YuviPanda>	 ok
[08:57:56] <YuviPanda>	 notnarayan: I'm keeping the titles for now.
[08:58:08] <notnarayan>	 YuviPanda: and image size?
[08:58:35] <YuviPanda>	 256dp is what is currently at.
[08:58:39] <YuviPanda>	 so that is another problem
[08:58:47] <YuviPanda>	 if I reduce the size titles can't go on it anymore
[08:59:44] <notnarayan>	 YuviPanda: how many images are you showing in a single view
[08:59:50] <YuviPanda>	 depends on width.
[08:59:57] <YuviPanda>	 as many can fit.
[09:00:09] <notnarayan>	 are they square blocks?
[09:00:23] <YuviPanda>	 nope.
[09:00:27] <notnarayan>	 do they have a 2px padding inbetween
[09:00:32] <YuviPanda>	 nope.
[09:00:46] <notnarayan>	 cause thats all the sizing info i can give you
[09:01:02] <YuviPanda>	 if there is empty width left it is automatically redistributed across all columns
[09:01:36] <notnarayan>	 YuviPanda: i see
[09:01:46] <YuviPanda>	 hmm, true since we aren't doing the floating action items
[09:02:17] <notnarayan>	 YuviPanda: will you do them later?
[09:02:33] <YuviPanda>	 I don't want to. Let's stick to android conventions unless we have a very good reason to not.
[09:02:56] <notnarayan>	 YuviPanda: ok. :)
[09:04:50] <YuviPanda>	 notnarayan: and we need to resolve the Title thing. If we make the thumbs smaller we can't have titles on them.
[09:05:13] <notnarayan>	 YuviPanda: I'm for not having titles in the gallery view at all.
[09:05:23] <YuviPanda>	 but why?
[09:05:34] <notnarayan>	 YuviPanda: it comes int he way of looking at images
[09:06:19] <notnarayan>	 YuviPanda: its like the dirty watermark you find onto of good images.
[09:06:32] <notnarayan>	 YuviPanda: I'm not saying titles are not important or for that matter meta data
[09:07:06] <notnarayan>	 YuviPanda: just that it need not be on the image itself. when we are dealing only with images.
[09:07:08] <YuviPanda>	 dirty watermarks add nothing.
[09:07:14] <YuviPanda>	 titles do.
[09:07:18] <YuviPanda>	 we're bikeshedding. This is not productive.
[09:07:44] <notnarayan>	 YuviPanda: true.
[09:08:33] <notnarayan>	 YuviPanda: so let the image size be as it is with the title.
[09:08:42] <notnarayan>	 YuviPanda: ill send you the mock for the detail page.
[09:09:01] <notnarayan>	 YuviPanda: am i missing something>
[09:10:24] <YuviPanda>	 notnarayan: the 'let us keep it the android way / style' also applies to login screen, I think.
[09:10:30] <YuviPanda>	 anyway let me do it and see how it goes.
[09:11:13] <notnarayan>	 YuviPanda: what was that about the login screen again? i dint get you
[09:11:48] <YuviPanda>	 > what happens when the 'featured image' is all white?
[09:12:06] <YuviPanda>	 and the colors, etc of the login screen aren't Androidy.
[09:12:37] <YuviPanda>	 android design is clean cut, straight lines. Not shadowey, no?
[09:12:50] <notnarayan>	 YuviPanda: well that not a problem
[09:12:57] <notnarayan>	 YuviPanda: we can get rid of the shadows.
[09:13:02] <YuviPanda>	 one of the major issues with our PhoneGap app was that we did not fit in with the platform. I'm simply trying to avoid that
[09:13:03] <notnarayan>	 keep it flat white
[09:13:05] <YuviPanda>	 and white on white text
[09:13:06] <YuviPanda>	 ?
[09:13:24] <notnarayan>	 a all white featured image?
[09:13:30] <YuviPanda>	 a predominantly white one?
[09:13:30] <notnarayan>	 really?
[09:13:36] <YuviPanda>	 or one which has white in the places where we have login?
[09:13:44] <YuviPanda>	 as in
[09:13:45] <YuviPanda>	 the text
[09:13:48] <notnarayan>	 YuviPanda: i got it
[09:15:04] <notnarayan>	 YuviPanda: the login screen featured image is blurred. so it should not affect the text actually.
[09:15:13] <YuviPanda>	 hmm.
[09:15:17] <YuviPanda>	 let me implement it and see
[09:15:23] <YuviPanda>	 but I'm still a bit skeptical.
[09:15:34] <YuviPanda>	 we can't actually 'blur' the background image (battery drain)
[09:15:38] <YuviPanda>	 but we can put an overlay on it
[09:15:42] <YuviPanda>	 and alpha blend it
[09:15:56] <notnarayan>	 ya
[09:16:39] <notnarayan>	 YuviPanda: ill give you the detail page today evening.
[09:16:43] <YuviPanda>	 ok
[09:34:26] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/oF9o9g
[09:34:26] <wikipedia-github>	 android-commons/master ee35a5c YuviPanda: Minor size modifications to fit with 48 based android grid
[09:34:43] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #62: SUCCESS in 27 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/62/
[09:34:43] <mw-jenkinsbot>	 yuvipanda: Minor size modifications to fit with 48 based android grid
[09:48:31] <wikipedia-github>	 [android-commons] atdt opened pull request #3: Two tiny nits: don't send isValid; rename 'schema_rev' to 'scid'. (master...master)  http://git.io/Bj7xVw
[09:49:51] <wikipedia-github>	 [android-commons] yuvipanda pushed 3 new commits to master: http://git.io/sK_ALQ
[09:49:51] <wikipedia-github>	 android-commons/master d607324 Ori Livneh: Drop 'isValid' optional field from EventLog...
[09:49:51] <wikipedia-github>	 android-commons/master 0b0af4f Ori Livneh: Rename 'schema_rev' => 'scid'...
[09:49:51] <wikipedia-github>	 android-commons/master 5c8c584 Yuvi Panda: Merge pull request #3 from atdt/master...
[09:50:17] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #63: SUCCESS in 30 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/63/
[09:50:17] <mw-jenkinsbot>	 * ori: Drop 'isValid' optional field from EventLog
[09:50:18] <mw-jenkinsbot>	 * ori: Rename 'schema_rev' => 'scid'
[09:51:06] * ori-l  adds 'mobile developer' and 'java developer' to resume

[09:51:22] <ori-l>	 thanks!
[09:52:48] <YuviPanda>	 ori-l: :D
[09:53:22] <YuviPanda>	 ori-l: isn't it hard to keep up your natural sleep cycle (nocturnalish) and also go to office?
[09:54:02] <ori-l>	 1) yes. 2) oh, definitely, yes. 3) tomorrow is a holiday!
[09:54:20] <YuviPanda>	 heh :D
[09:54:40] <YuviPanda>	 probably going to be the biggest stick in me moving there, if I do.
[09:54:55] <ori-l>	 george washington's birthday, you mean?
[09:54:59] <YuviPanda>	 :P
[09:55:08] <YuviPanda>	 moving to normal people times.
[09:55:19] <YuviPanda>	 team standup is about 11:30 PM for me now, which is just perfect.
[09:55:40] * ori-l  drools.

[09:55:44] <ori-l>	 That _is_ perfect.
[09:55:54] <YuviPanda>	 I know!
[09:56:04] <YuviPanda>	 i can do an uninterrupted batch of work from about 4pm to 9pm
[09:56:11] <YuviPanda>	 then go eat and stuff
[09:56:15] <YuviPanda>	 then do meetings / IRC.
[09:56:17] <YuviPanda>	 and some more code.
[09:57:00] <YuviPanda>	 ori-l: plus the prospect of a 'commute' doesn't fit well with me either.
[09:57:09] <YuviPanda>	 if, however, erik is happy to have me sleep in the office... :P
[09:58:17] <ori-l>	 The office is pretty flexible with hours for people who are demonstrably damned productive, which you are
[09:59:40] <YuviPanda>	 ori-l: :) hopefully.
[10:12:51] <wikipedia-github>	 [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/l1Vnsg
[10:12:51] <wikipedia-github>	 android-commons/master 6b20dce YuviPanda: Make UploadService a purely bound service
[10:12:51] <wikipedia-github>	 android-commons/master 2df1b1b YuviPanda: Remove dead code for ActionBar overlay
[10:13:08] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #64: SUCCESS in 27 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/64/
[10:13:09] <mw-jenkinsbot>	 * yuvipanda: Make UploadService a purely bound service
[10:13:10] <mw-jenkinsbot>	 * yuvipanda: Remove dead code for ActionBar overlay
[10:58:09] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/GkW-BQ
[10:58:09] <wikipedia-github>	 android-commons/master 6e2c334 YuviPanda: Fix bug causing in-progress uploads to be marked as failed
[10:58:33] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #65: SUCCESS in 28 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/65/
[10:58:33] <mw-jenkinsbot>	 yuvipanda: Fix bug causing in-progress uploads to be marked as failed
[19:51:32] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: https://github.com/wikimedia/android-commons/commit/34eb356108a37f34d3081401a3e949f165a691ab
[19:51:32] <wikipedia-github>	 android-commons/master 34eb356 YuviPanda: Add EventLogging for Login success / failure
[19:52:03] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #66: SUCCESS in 32 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/66/
[19:52:03] <mw-jenkinsbot>	 yuvipanda: Add EventLogging for Login success / failure
[20:27:42] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: https://github.com/wikimedia/android-commons/commit/ffaac44f3a289b97dce2e8ba1fafcbb270f096b0
[20:27:42] <wikipedia-github>	 android-commons/master ffaac44 YuviPanda: Removed dead constants (killed by prior commit)
[20:28:10] <mw-jenkinsbot>	 Project Android-Commons (mobile) - Nightly builds build #67: SUCCESS in 30 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/67/
[20:28:11] <mw-jenkinsbot>	 yuvipanda: Removed dead constants (killed by prior commit)
[20:29:42] <Reedy>	 YuviPanda: brute.
[20:30:03] <YuviPanda>	 Reedy: vim made it quick.
[21:12:13] <wikipedia-github>	 [Commons-iOS] brion pushed 4 new commits to master: https://github.com/wikimedia/Commons-iOS/compare/8630f97ce536...9167fdec6889
[21:12:13] <wikipedia-github>	 Commons-iOS/master 4ccf92c Daniel Zhang: adding unit test for core data init; starting localization unit tests; cleaning up login test
[21:12:13] <wikipedia-github>	 Commons-iOS/master a782020 Daniel Zhang: adding method for UUID generation
[21:12:13] <wikipedia-github>	 Commons-iOS/master 029ba61 Daniel Zhang: removing unused imports
[21:18:20] <YuviPanda>	 brion: help! See if you can take a poke at 2.3 sometime. This bug causing app to crash with notifications is driving me crazy.
[21:18:33] <YuviPanda>	 been in one spot for the last 6 hours (and countless ones last week) trying to fix that to no avail.
[21:18:39] <YuviPanda>	 would be nice if you could give it a shot.
[21:18:51] <YuviPanda>	 (also EventLogging is fully implemented. Yay!)
[21:19:15] <brion>	 moment
[21:19:24] <wikipedia-github>	 [Commons-iOS] brion pushed 2 new commits to master: https://github.com/wikimedia/Commons-iOS/compare/9167fdec6889...aa743491c5e4
[21:19:24] <wikipedia-github>	 Commons-iOS/master 9986f04 Brion Vibber: drop old unit tests
[21:19:25] <wikipedia-github>	 Commons-iOS/master aa74349 Brion Vibber: shut up warning about border
[21:25:53] <brion>	 i can't seem to log in in 2.3 emulator
[21:29:57] <brion>	 nope, can't log in
[21:30:13] <brion>	 adb logcat just says:
[21:30:15] <brion>	 D/Commons (  440): Login to start!
[21:30:15] <brion>	 D/Commons (  440): Login done!
[21:30:27] <brion>	 YuviPanda: any idea why that might be failing?