[00:06:10] brion, uploads don't work on Firefox because for some reason the upload API is returning HTTP Forbidden error [00:06:25] probably Firefox is doing something with request [00:06:33] and this is on my local instance, so no CORS [00:06:45] istr that happening on local uploads because we set CORS on unconditionally… lemme check if that's still the case [00:08:09] you mean on the server side or client side? [02:20:54] brion: wikipedia android app is at almost 10,000,000 lifetime installs :D [9,681,963] [02:20:56] zz_YuviPanda: --^ [11:55:21] [Commons-iOS] dz1111 opened pull request #30: Adding more unit tests (master...UnitTests) http://git.io/LVVgCA [15:19:00] * MaxSem pokes YuviPanda [15:19:08] * YuviPanda pokes MaxSem back [15:19:10] hello MaxSem [15:19:15] hey [15:19:30] * preilly thinks that's a lot of poking [15:19:37] can you add more information on your requirements to https://www.mediawiki.org/wiki/Requests_for_comment/Image_information ? [15:20:08] MaxSem: yeah, I'm waiting for brion to turn up so we can talk a bit and do that. [15:20:18] sehr gut [15:20:23] :) [15:20:27] MaxSem: are page props queryable? [15:20:32] yes [15:20:34] as in, 'give me all pages with this prop = this value'? [15:20:35] ah [15:20:53] mmm, not sure about this use case [15:20:58] * MaxSem looks at indexes [15:21:29] no [15:22:00] MaxSem: hmm, that's what I thought. [15:22:15] MaxSem: so if we want anything to be queryable at all, they'll need their own tables [15:22:22] you can only safely request all properties for a particular page, or a particular property for a page [15:22:43] why do you want to know all pages with a particular prop? [15:23:01] I don't (right now) but just thinking. [15:23:08] 'explore by artist', for example [15:23:12] (is the only thing that came to mind) [15:23:29] I might never need to. Just asking to know the possibilities with the simplest solution :) [15:23:31] let's leave this to wikidata [15:23:46] MaxSem: is Extension:GeoData enabled on commons? [15:23:50] yes [15:24:01] ah, sweet. [15:24:07] though it probaly doesn't search for images sanely [15:24:22] or rather we need to check this [15:24:50] I didn't wanted originally to enable it there [15:25:02] enabled just to simplify the config:P [15:25:11] :P [15:26:16] MaxSem: https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&list=geosearch&format=json&gscoord=13.0838%7C80.27&gsradius=10000&gslimit=10&gsnamespace=6&gsprop=type%7Cname%7Cdim%7Ccountry [15:26:18] gives me 4 results [15:26:28] I doubt there are only 4 images geotagged to all of chennai [15:26:35] (or at least 10km of chennai) [15:27:10] not all of them were initialized [15:27:14] ah, Taj Mahal gives plenty more. [15:27:17] MaxSem: 'initialized'? [15:27:23] yes [15:27:37] as in? [15:27:40] put into the jobqueue? [15:27:54] gaeodata adds tags in 2 cases: there's {{#coordinates:}} and an images has exif coordinates [15:28:25] and neither of them works magically [15:28:44] the former needs template modifications [15:29:03] MaxSem: ah, right. [15:29:04] the latter needs image page to be reparsed [15:29:24] MaxSem: any blockers to doing either / both? [15:31:31] no [15:31:54] just looked, we have 64k coordinates on commons [15:41:18] MaxSem: I doubt that's all of it [15:41:26] yeah [15:41:31] MaxSem: think you can find some time to do both? [15:41:48] if you ask, sir:) [15:42:04] MaxSem: then, respected sir, please do :) [15:43:02] just bring me royal decree that says I should do it. three copies, all stamped with the grand seal of the realm:P [15:43:46] * LordPanda stamps the fuck outta everything [15:43:52] * LordPanda then hands it to MaxSem [15:43:53] here you go [15:44:06] :P [15:57:05] YuviPanda: I have Android installed and running! [15:57:41] I became possessed and stayed up until 3am so I'm all set [15:57:49] jcmish: wahaa [15:57:50] sweet [15:58:05] YuviPanda: I was rebuilding the new computer anyway [15:58:09] are you good to go on *everything* or are there things I could still help you with? [15:58:15] jcmish: did the sdk break your old computer? :P [15:58:18] so I was on a roll [15:58:33] YuviPanda: I'm good to go [15:58:37] ah sweet :D [15:58:39] and see I told you it broke my other computer! [15:58:55] :D [15:58:56] sure [15:59:16] ;) [16:20:40] duh, just cleaned an increadible amount of junk from my mose [16:20:44] *mouse [16:38:06] jcmish: hi, got a moment? [16:38:34] sure [16:43:26] jcmish: so, re the test plans for the mobile web photo upload testing -- do you think it's useful t think of more edge cases to test? [16:44:17] yup I"m adding those alreday [16:44:20] *already [16:44:25] the ones you provided in the email? [16:47:25] sumanah: ^ [16:47:39] sumanah: or were there other things you're referring to? [16:47:55] I mean even more, ones I hadn't thought of [16:48:19] I could spin out more speculations but I don't want to lard the list with unhelpful or extreme or very-hard-to-hit edge cases [16:51:41] jcmish: I have to go prep for a meeting but please feel free to advise via email :-) Mostly I was just grabbing ideas from www.thebraidytester.com/downloads/YouAreNotDoneYet.pdf [16:52:06] sumanah: yep I know the drill just wandered if I missed another email [16:52:26] I'm already working on that waiting to hear back from Maryana on whether to provide instructions for accessing beta [16:52:29] not that I know of. I was asking whether it would be useful to think of *even more* edge cases to test [16:52:30] ok [16:52:51] qgil_ should opine on that, but I would prefer to yes, include instructions for opting into beta. [16:53:17] how many different sets of instructions will that be (depending on handset)? and is it just commons.wikimedia.org or are there other sites they need to opt in on? [16:56:00] hi [16:56:36] sumanah: no it's just necessary when you're using the web version of the mobile app [16:56:43] but not the app versions [16:56:51] I'll make sure to make that clear [16:57:18] hi jcmish - yes, http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads should be as self-sufficient as possible [16:57:37] jcmish, then again there is no need to re-write or duplicate content [16:57:39] qgil_: howdy and will do [16:57:54] first I want to make sure it's not already out there for me to just reference [16:58:03] jcmish, if there is a page with proper instructions to enable beta just link it [16:58:13] qgil_: nodd [16:59:30] jcmish, http://www.mediawiki.org/wiki/Mobile_Beta exists but is not that :/ [17:00:00] qgil_: nope nothing so simple and clear as that :D [17:00:17] jcmish, ah: http://meta.wikimedia.org/wiki/Mobile_projects/Beta [17:01:13] qgil_: right but it feels a bit much to ask them to dig through that [17:01:18] or does that seem clear enough? [17:01:31] jcmish, given that the beta instructions are just 3 lines you can simply copy / ada[pt then and link to that page if people wants to know more [17:01:50] qgil_: agreed [17:02:27] thanks jcmish ! I will keep polishing that page as well. Hopefully by the end of today we will have something we are happy about [17:03:17] qgil_: awesome thanks [17:03:29] and qgil_ I will spend some time today getting the word out about this to a few potential volunteers .... and I assume you'll talk about it at the meetup tonight! :D [17:03:33] I'm getting some things setup on my laptop but I'll update the wiki soon [17:04:05] sumanah, yes indeed. I also have about 40 people to contact personally [17:04:31] great [18:25:57] hmm, no brion [18:28:39] argh, found a bug in GeoData [18:28:41] :P [18:29:14] MaxSem: :P [18:29:34] MaxSem: should I file a bug or something for GeoData on COmmons? [18:29:57] part of it is not SW-related, so not buggable [18:30:06] right [18:30:16] the second part should be done after the first part [18:30:27] who would've thought! :P [18:30:38] MaxSem: you've rights to edit the template no? [18:32:10] yes, with my staff acount [18:32:22] ah, right. [18:46:40] mhm, we have over 22k geotags in 10km radius around London centre [18:51:45] MaxSem: :D Is there a way to estimate how many we'll get when we run it on all of commons? [18:51:58] yes. do it [18:52:38] MaxSem: hehe [18:56:50] is EventLoggingExtensionFunctionsTest::testBeautifyJson also failing for you on master? [18:57:02] hm, wait [18:57:14] why does it even run when I run tests for our extension [18:57:23] (with make phpunit) [18:57:55] MaxSem, ori-l ^ [18:58:12] what, JS tests? [18:58:21] * MaxSem pours some blessed water on jgonera [18:58:36] those are PHP tests [18:58:48] but from EventLogging [18:59:08] and for some reason they run when I do make phpunit while in MobileFrontend dir [19:01:44] ok, it seems my phpunit is too old, but why this is run with our tests is still a mystery for me [19:03:39] jgonera: hey [19:03:50] i'm checking. [19:04:12] ok [19:04:43] the test passes fine with newer PHPUnit [19:05:32] but it runs the tests for EventLogging, too? and of no other extension? [19:10:22] brion: https://plus.google.com/hangouts/_/1db830cc335f6da969eb4d3539d618d13046e05a?authuser=0&hl=en [19:10:34] tfinc: yo [19:10:45] hey brion [19:10:48] brion: https://plus.google.com/hangouts/_/1db830cc335f6da969eb4d3539d618d13046e05a?authuser=0&hl=en [19:10:52] are you going to be on IRC today or that meetup thingy? [19:12:42] ori-l, let me check [19:14:10] Available test group(s): [19:14:10] - EventLogging [19:14:11] - GeoData [19:14:11] - MobileFrontend [19:14:13] strange [19:14:25] I have more extensions than that though [19:14:29] MaxSem, is this intentional? [19:16:45] well, I prefer to mark my extensions'tests with appropriate groups, but not everyone does that [19:17:07] yeah, i do that too [19:21:03] ok, how do I actually see what tests are being run? is there any verbose switch for phpunit or some spec-like reporter? [19:21:46] YuviPanda, https://commons.wikimedia.org/wiki/Commons:Village_pump#GeoData_on_Commons [19:21:51] * YuviPanda clicks [19:22:17] wheee alarm clock fail this morning :P [19:22:26] i'll be in the office after lunch [19:22:54] brion: are you doing swipeable detail views/ [19:23:05] MaxSem: sweet! [19:23:11] like swipe to go to the next/previous photo? [19:23:14] was considering it [19:23:35] brion: Took me a day of writing code but I has it. :) [19:23:41] \o/ awesome [19:23:42] brion: also we need to fill in details on MaxSem's RFC [19:23:46] MaxSem, ori-l, so it seems that GeoData tests also are being run when I run make phpunit in MobileFronted [19:23:47] yep [19:24:05] brion: so I think it doesn't need to be queryable at all [19:24:21] ? [19:24:34] brion: as in, we don't have to ask 'list of all pages with author = X' [19:24:36] or some such [19:24:51] New patchset: JGonera; "(bug 45217) Fix dependencies support in MFResourceLoaderModule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50198 [19:24:54] I guess if we can say 'give us all the meta data you got on page X in JSON/XML' is good enough [19:24:55] no? [19:25:26] ah yeah [19:25:41] yeah all we need is 'gimme info on file X' [19:27:02] this can be helluva lot of metadata [19:27:22] MaxSem: in terms of size? [19:27:27] yes [19:27:27] or variance? [19:28:07] whichone? [19:28:15] yes:P [19:28:31] :P [19:28:43] MaxSem: in terms of size per property? [19:28:52] yes [19:29:10] MaxSem: pageprops has limits? [19:29:15] also, there are a lot of properties, so the total download would be unfunny [19:29:37] using prop=pageprops for it is really stupid [19:29:51] because you'll get descriptions in all languages [19:30:07] right, right, and right. [19:30:22] MaxSem: the multilingual bit will be bad on pageprop [19:30:53] MaxSem: but I suppose most of them on average have 4-5 language descriptions? [19:31:11] (random number I pulled out of thin air) [19:33:12] MaxSem: Is description the only multilingual field? [19:33:22] looks like so [19:34:07] in pathological cases, you'll get dozen or more languages, however most pics appear to have only one [19:34:15] true [19:34:38] but that's something that we could help fix, so we shouldn't always assume that is the case :P [19:35:20] MaxSem: so two tables, one for desc + one for everything else? [19:35:21] ugh [19:35:35] eww [19:35:50] ewww indeed. [19:36:01] MaxSem: solution is clearly to use MongoDB [19:37:12] yeah, let's troll Domas [19:37:54] MaxSem: we already are running MongoDB in 'production' (of sorts) btw [19:38:01] E3 has logging data available on MongoDB :P [19:38:08] yeah, for some weird analytics stuff [19:38:13] :P [19:38:21] but I don't know if anyone is using it [19:38:25] same data is available in mysql too [19:41:42] hey awjr, you scared e3 into thinking we were taking their whole deployment window, and they also had some (smallish) stuff they wanted to roll out today [19:41:49] MaxSem: any solution comes to mind that doesn't require 2 tables [19:41:49] ? [19:41:59] lol Maryana [19:42:01] whoops [19:42:31] it's ok, i figured that's not what you meant & let 'em know :) [19:43:06] New patchset: MaxSem; "Specify test group explicitly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50200 [19:43:13] jgonera, ^^ [19:43:21] Maryana: just cleared it up with swalling [19:43:29] we'll deploy once e3 is done with what they need to do [19:43:31] cool, thx! [19:43:44] * awjr_lunch goes back to noms [19:44:00] hehe, enjoy :) [19:45:41] jgonera: i hacked together this script for extension tests: https://gist.github.com/atdt/5007357 [19:46:07] "runtests" with no params runs the default (for me, EventLogging) but "runtests MobileFrontend" runs MobileFrontend tests, etc. [19:46:55] the 'correct' way of doing this is probably to use phpunit / mediawiki's own test discovery protocol to identify and select a test suite to run rather than rely on paths, but this works well enough for me. [19:51:50] MaxSem: want us to edit the RFC or do you have enough info? [19:52:03] please edit [19:52:16] it's less than 1kb now, not serious;) [19:59:52] MaxSem: heh, ok [20:00:01] ori-l, why not just use phpunit --group ExtensionName ? [20:00:32] my main concern was if we actually want to run any other tests in MobileFrontend by default [20:03:17] New patchset: JGonera; "Run only MobileFrontend's PHPUnit tests on make phpunit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50204 [20:06:43] jgonera: are all the patches merged that need to go out today? [20:07:01] jgonera: I ran into various snags (multiple versions of phpunit on the path, etc.) that I didn't feel like sorting out. But if that works for you, sure, that's probably better. [20:07:01] jgonera, you're duplicating my patchset!:P [20:08:33] awjr, the minimum I wanted to get in is merged, however it would be nice if we could get those two small commits too: https://gerrit.wikimedia.org/r/#/c/50198/ and https://gerrit.wikimedia.org/r/#/c/50125/ [20:08:50] especially the first one which is a nasty bug that might lead to some race conditions [20:09:58] MaxSem, oops, didn't see it ;) [20:10:23] New review: JGonera; "Patch Set 1: Code-Review+1" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/50200 [20:11:17] Change abandoned: JGonera; "Duplicate patchset, MaxSem already pushed this." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50204 [20:16:28] jgonera: https://gerrit.wikimedia.org/r/#/c/50198/1 looks OK to me - what is a good way for me to test? [20:17:17] awjr, open the mobile site in desktop firefox without this commit and you'll see errors in JS console, open it with it and everything is fine [20:17:45] jgonera: and we definitely /always/ want mobile.startup loaded? [20:18:03] yes, there is no way that templates would work without it [20:18:27] jgobut doesnt that get added as a dependency though in the defined modules? [20:19:00] (in MobileFrontend.php) plus on line 236 of MobileFrontend.body.php? [20:19:07] (for special page modules, that is) [20:19:10] it wasn't added there, the fact that it worked in most browsers was a pure coincidence [20:19:18] let me double check [20:20:12] so it was, but it didn't work because 'dependencies' key was ignored by MFResourceLoaderModule [20:20:33] but anyway MFResourceLoaderModule can't work without mobile.startup so it makes sense to add it in MFResourceLoaderModule itself [20:20:39] so if you remove $this->dependencies[] = 'mobile.startup'; it should just work, right? [20:20:45] interesting [20:21:02] what happens if you multiple deps of the same name in $this->dependencies? [20:21:05] it should, unless some other non-MFResourceLoaderModule modules also depend on it [20:21:28] hm, good question [20:22:03] let me just add a check that adds mobile.startup only if it's not present already [20:24:12] New patchset: JGonera; "(bug 45217) Fix dependencies support in MFResourceLoaderModule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50198 [20:24:18] done [20:28:11] in_array() can be really slow if there are a lot of values - you can do an array_flip() and then check isset $arr[$needle] [20:30:14] awjr: doesn't array_flip have to iterate through the entire array and build a new hash table? [20:30:22] jgonera: i gotta run to a mtg but we'll try to get that merged before we deploy. it would be good to get MaxSem to take a look too (although he's in th emtg as well) [20:31:01] ori-l: dunno the internals [20:31:09] awjr, ok, if you don't have time, don't worry, things worked without it for a few weeks so I guess we can live without it a few days more [20:31:24] unless mobile webkits start loading JS in the same order as desktop firefox ;) [20:31:30] but actualy in the case of dependencies, it's ahrd to imagine that there would be so many that in_array() would cause performance problems [20:31:39] sorry I am late [20:32:16] awjr_mtg, I know about in_array, but I assumed it's not important with arrays of that size [20:32:24] jgonera: i think you're right [20:41:04] quick and easy :-D [20:44:34] i am tempted to bikeshed but it looks fine to me jgonera - MaxSem what do you think? https://gerrit.wikimedia.org/r/#/c/50198/2 [20:45:28] we can change it later, there are some things I still don't like in the way we use modules, but this bug just makes me a bit scary [20:45:39] yeah, word [20:45:50] scared * [20:47:35] New patchset: MaxSem; "(bug 45217) Fix dependencies support in MFResourceLoaderModule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50198 [20:47:37] awjr, easier to fix than to bikeshed;) [20:50:54] MaxSem: you are checking if the key is set but then setting the value if it's not, i think what jgonera originally had is fine [20:51:17] MaxSem, yes, I'm afraid you broke it unless I don't know about some PHP magic ;) [20:51:45] argh [20:52:11] :p [20:53:22] New patchset: MaxSem; "(bug 45217) Fix dependencies support in MFResourceLoaderModule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50198 [20:53:34] awjr, ^^ [20:53:57] thanks MaxSem - if you're fine with it let's merge [20:54:14] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50264 [20:54:16] New review: MaxSem; "Patch Set 4: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50198 [20:54:44] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50198 [20:55:54] New review: Cmcmahon; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50264 [20:55:56] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50264 [21:01:26] ok im going to update the production branch to current head of master (ab1564a5c26897fd13f85f5fb621b7fd89225c8e) and wait for e3 to finish their deployment [21:01:45] MaxSem, jgonera ^ [21:01:59] ok [21:02:24] are there any changes other than dependencies/upload logging that will go live today? [21:03:32] you changed the radius in geosearch [21:03:42] and some updates to Ruby gems, but that's not relevant [21:04:11] that is all [21:05:01] awjr, remember about https://gerrit.wikimedia.org/r/#/c/50109 [21:05:07] yup thanks jgonera [21:05:24] oh, there's also commit bfdb13de592c4899c34a458ff78189c14624a4c8 [21:05:31] 'Fix photo upload bug when the same image selected twice' [21:05:35] jgonera, geosearch has already been deployed [21:05:56] awjr, true [21:06:24] michelle is preparing git log notes but this should be pretty quick and painless (famous last words) [21:06:32] but if anything it's a good thing that this will get deployed while uploads are still in beta [21:06:48] yah [21:31:14] New patchset: JGonera; "Send all upload request parameters inside FormData" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50274 [21:31:15] New patchset: JGonera; "Add photo upload support for Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50275 [21:38:07] awjr, do you know when approximately we'll deploy? I'd go to grab some food now [21:38:26] jgonera: no, im waiting for the goahead from e3. ori-l do you have a rough idea? ^ [21:40:12] New patchset: awjrichards; "(mingle 397) Append configurable string to photo upload description" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49354 [21:40:25] awjr: probably another 10-15, is that ok? [21:40:34] that should leave you with another hour+ [21:40:46] ori-l: yeah, that's totally fine, just wanted to dbl check. thanks :) [21:40:48] jgonera: ^^ [21:40:58] New patchset: JGonera; "Don't show or log an error when user cancels photo upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50281 [21:41:11] New review: awjrichards; "Patch Set 1:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49354 [21:41:14] ok, thanks! [21:50:17] New patchset: JGonera; "Show upload button again if user cancels upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50287 [21:51:19] awjr: are you going to run scap? [21:53:11] ori-l: doesn't look like we need to, i am planning to just sync-dir [21:57:59] blah, one of the mediawiki hosts is stalling on superm401's sync.. [21:58:08] doh [22:04:12] awjr: hey. we have a few syncs left to do -- sorry things took longer than expected. we decided to just let you go ahead and then squeeze ours at the end. i'll update the deployment calendar in case we run a bit over. but you can go ahead. [22:04:29] I'll be back in about 15-20 minutes, is that ok? in case of emergency just ping me at 434 218 9748 [22:06:10] ori-l: sounds good - jgonera stick around for a bit [22:06:14] jgonera: we're going to start deploying now [22:07:19] jcmish, MaxSem, jgonera, Maryana im prepping to get things up on testwiki [22:07:26] coolness [22:07:29] whee [22:08:36] New review: Brion VIBBER; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50275 [22:09:52] ori-l im seeing: [22:09:52] commit 44c24b3ca9b1a6737178159fdc608b8e981905be [22:09:52] Author: Matthew Flaschen [22:09:52] Date: Thu Feb 21 17:05:50 2013 -0500 [22:09:53] Bump GettingStarted to master. [22:09:53] [22:09:54] Change-Id: Ie0c9dba8d7b8637b251d9ab09bf91457314aded4 [22:10:00] on fenari - is it ok to git pull that? [22:10:18] yes. [22:10:44] you can simply not update this submodule if you're not sure [22:11:04] yah i figured i may as well check tho [22:14:56] hmm, ori-l, i seem to be having trouble connecting to stat1. is this residual from the mysql restart? [22:15:35] jcmish, MaxSem, jgonera, Maryana ok, changes live on testwiki [22:15:42] k testing [22:15:50] Maryana: noooo idea. ping ops? (specifically notpeter) [22:17:02] \why I don't see the upload button on Special:DonateImage? [22:17:15] im seeing eventlog requests sent on upload error [22:17:21] MaxSem: huh - wfm [22:18:00] Maryana: can you see if upload errors are getting logged from testwiki? [22:18:25] 1 sec - my sql GUI appears to have stopped working :-/ [22:18:32] doh [22:18:47] aaand we're back :) [22:19:29] jgonera, which version of the schema are we going off of? [22:20:37] awjr: seeing events, yay! [22:20:41] Maryana: revision 5246000 [22:20:52] did jgonera wander off? [22:20:53] got it :) yes, we're generating stuff [22:20:58] huzzah! [22:21:04] yeah, i don't see him at his desk.. [22:21:10] harumph [22:21:35] I'll be back in about 15-20 minutes, is that ok? in case of emergency just ping me at 434 218 9748 [22:21:57] ah, thank you, ori-l [22:22:23] oh, i told him to stick around after that but i guess he already left :p [22:22:40] well, all looks good with the data [22:23:25] so far my quick testing looks ok; as soon as jcmish confirms things are ok i'll go ahead and push [22:23:27] non beta is f fine [22:23:33] *fine [22:23:35] as is beta [22:23:52] I'm looking at alpha right now [22:26:36] k allgood [22:27:05] ok - i wanna give juliusz a chance to confirm, i'll give him til 230PST to return, otherwise i'll go ahead and sync. [22:27:55] ah [22:28:00] k works for me [22:32:06] jgonera: back yet? [22:32:21] still no juliusz - do you want me to shoot him a quick text? [22:32:31] nah it's ok, i'm going to go ahead and sync [22:32:39] ok. [22:33:26] whoa im getting hella rsync errors [22:33:47] ruh roh [22:33:58] awjr: some machines were taken out of circulation for maintenance; i got the same. [22:34:12] ok, yeah, it seems like just a handful of boxes [22:35:53] okidoke, changes should be live now [22:36:05] hi, who handles the mobile twitter account, and can we get a RT of https://twitter.com/mediawiki/status/304677483389808640 [22:36:05] \0/ [22:36:15] somebody test some uploads! :) [22:36:40] qgil_ - i can do that [22:37:03] hi Maryana , long time no see ;) the wave of spamming is basically complete. Let's see how it goes. [22:37:21] fantastic - thank you! [22:37:23] retweeted. [22:37:52] oops i just accidentally uploaded the varnish book pdf to commons [22:37:53] hehehe [22:38:03] lol [22:38:22] ok i think i just caused an error event [22:38:36] we apparently do not do any file type checking before uploading [22:39:08] woah, uploads page does not like being tilted to landscape [22:40:47] awjr: we're going to test that during the mobile QA event next week [22:40:55] uploading weird file types, i mean [22:41:03] coolcool [22:41:07] awjr is precocious [22:41:12] :) [22:41:18] inadvertently :p [22:41:26] awjr: are we good to sync our remaining syncs? [22:41:34] ori-l: one sec but i think so [22:41:44] Maryana: are you seeing log events from enwiki for photo upload errors? [22:41:46] "This file did not pass file verification" [22:41:51] \o/ [22:41:53] yes indeed [22:41:55] cool [22:42:00] ori-l: yeah go for it - thanks :D [22:42:01] "This file is not a good file" [22:42:05] is what it should really say [22:43:51] heh [22:44:07] jgonera: your changes are live and events are being logged [22:45:27] awjr, thanks! [22:45:30] that's great [22:45:40] sorry for not being here during the process [22:46:33] is everything ok? [22:46:46] jgonera: looks like it to me :) [22:46:48] ori-l, could you remind me how to connect to event logging db? [22:47:04] jgonera: Maryana reported that she's seeing error events from photo upload [22:47:30] you mean expected ones? [22:47:36] lol yes [22:47:46] ok, that's good ;) [22:48:21] New review: awjrichards; "Patch Set 4: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48475 [22:48:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48475 [22:48:27] Maryana, are those messages from events? those are just for us anyway, we're not displaying them [23:00:59] jgonera: Maryana has the details, i'm not in the office and wld rather not send over irc [23:01:17] ori-l, ok, I've just got them from Maryana [23:01:31] top seekrit [23:09:09] MaxSem what would cause an api query for allimaages to return an image without a pageid? eg look at first image returned here: https://gist.github.com/awjrichards/9f89a3c3e63f311ce9c2 [23:09:14] New review: Brion VIBBER; "Patch Set 1:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50274 [23:12:51] awjr, is this image from a shared repo? [23:13:02] no, local instance [23:13:15] oh actually i think i know what it is [23:13:37] i generated a bunch of records in the image table [23:14:04] hmm [23:14:13] and one of them has id=-1? [23:14:35] well that's page id −1, which i presume means there's no actual page associated with the iamge [23:14:43] question about mobile uploads: users with beta enabled can do this from Wikipedia pages without any image, as seen at http://www.mediawiki.org/wiki/File:Mobile_upload_testing_2.PNG [23:14:56] but... can they do it from articles with images already? [23:15:00] which would make sense since i just generated records in the image table but didnt associate them with any pages [23:15:27] and... can they do it with a convenient mobile UI at http://commons.wikimedia.org ? [23:15:52] i wonder if that's a scenario that would ever be encountered in production [23:16:32] I'm trying to define thinmgs clearly at http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads [23:16:41] qgil_: currently the 'add an image to this article' button should only appear on articles that do not have a lead image [23:17:27] ok awjr, and (just to confirm) if I'm in a page with an image there is no way to upload an image from there [23:17:31] what about commons? [23:18:54] does commons get mobilefrontend by default right now? [23:19:34] brion, I just enabled mobile frontend and mobile beta as registered user in Commons but I see no upload button anywhere [23:19:58] so I guess next week's testing is all about uploading from Wikipedia pages without images + iOS & Android mobile apps [23:20:08] hmm no 'donate image' in the sidebar? [23:20:29] UploadWizard should work if you go to it in desktop mode, but it ain't pretty ;) [23:20:55] brion, ah wait, there is an "Upload" when clicking to that menu icon, yes [23:21:27] New review: JGonera; "Patch Set 1:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50274 [23:27:18] commons is currently kinduva weird case for MobileFrontend [23:27:31] we do not automatically redirect mobile devices to commons.m [23:28:21] there was talk back in the spring about doing that, but only after spending some time to make sure commons actually looked right/worked well within MobileFrontend, which wound up getting tabled around the time we started doing WLM stuff [23:29:03] qgil_, brion ^ [23:29:11] yeah, more uploads & file page stuff and we can probably do that a few months down the road [23:29:19] yah [23:32:23] Maryana, what do you mean by "uploads page does not like being tilted to landscape"? [23:37:14] awjr, are you still planning to work on card #405 (messaging in login/sign up)? [23:37:37] jgonera: yeah but i still haven't gotten to it yet - so feel free to take it if you need something to work on [23:38:09] ok, I'll take that or the hamburger as my next card [23:38:11] im working on code review right now and have some non-hacking related stuff to take care of afterwards which will probably take up the rest of my day [23:38:11] does the upload button appear in non-English Wikipedias? and in user pages? [23:38:19] jgonera: actually, why dont you grab hamburger then [23:38:26] awjr, ok [23:38:29] Nick /jcmish_late_lunch [23:38:29] groovy [23:38:51] qgil_, it should [23:38:54] New patchset: awjrichards; "Ensure images fetched from API for dashboard are associated with a page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50313 [23:39:39] jgonera, button doesn't show up in my Catalan user page, but I don't know where is the problem, since I don't have an "officially supported" phone [23:40:14] but well, if it should I will explain this at http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads - thanks! [23:40:35] qgil_, what phone are you using? there's a bug which might prevent the button from being shown on short pages (https://bugzilla.wikimedia.org/show_bug.cgi?id=43271) [23:40:57] qgil_, can you give me a link to your Catalan user page? [23:41:23] jgonera, it's a short page http://ca.wikipedia.org/wiki/Usuari:QuimGil [23:42:10] New review: awjrichards; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49271 [23:42:11] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49271 [23:42:15] jgonera, and I'm using still a Nokia N9, waiting to see if Firefox OS shows something I can buy in a few days at Mobile World Congress :P [23:44:47] New review: awjrichards; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50274 [23:44:48] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50275 [23:44:49] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50274 [23:48:08] qgil_, this text is long enough for the button to show up: https://gist.github.com/jgonera/bdc34d635b035cefc03b [23:49:35] ok, thank you jgonera . I assume that URL is permanent, rght? [23:49:51] qgil_, yes, should be