[00:05:43] qgil_: I added a quick note & a link to TestFlight signup URL to http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads#How_to_test_-_Commons_App [00:05:50] should we have more details about how to install? [00:06:34] brion, all the details, step by step. for dummies. If you feel lazy or lacking the time gimme an Android / iPhone device and I will do it [00:06:40] excellent [00:06:47] brion, I'm doing it right now for mobile web [00:07:23] * MaxSem goes to bed reminding brion about https://www.mediawiki.org/wiki/Requests_for_comment/Image_information [00:07:36] MaxSem: thanks i'll add some details [00:09:15] jgonera: im looking over https://gerrit.wikimedia.org/r/#/c/49184/3 again and im still curious about the installation location for npm modules [00:09:35] ok [00:09:37] New review: JGonera; "Patch Set 3:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49184 [00:09:50] so any objections? [00:10:08] I added a lengthy comment in patchset 2 [00:10:17] oh i missed it - silly gerrit [00:10:29] * awjr goes to read [00:10:48] ok makes sense [00:12:29] so jgonera the problem is that the shell script assumes that you have installed the node modules locally to the proejct [00:12:49] for intsance, i get: Arthurs-MacBook-Pro:MobileFrontend awjrichards$ make less [00:12:49] scripts/less.sh: line 7: node_modules/.bin/autoless: No such file or directory [00:12:49] make: *** [less] Error 127 [00:12:56] (i've got less installed elsewhere) [00:13:04] hm, it shouldn't be related [00:13:14] it should simply install another version of less locally [00:13:19] wait, I'll look at it [00:13:47] nono, because you're doing: if npm list autoless | grep "(empty)" > /dev/null ; then [00:14:07] but it's autoless, not less [00:14:10] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ npm list autoless [00:14:11] /Users/awjrichards [00:14:11] └── autoless@0.1.2 [00:14:14] what npm list autoless shows? [00:14:25] sorry, i meant autoless [00:14:36] qgil_: added a little more install info on http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads#How_to_test_-_Commons_App [00:14:41] wait, what is pwd? [00:14:49] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ pwd [00:14:49] /Users/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend [00:15:21] this is really confusing... [00:15:28] did you install autoless manually? [00:15:43] i do not remember :-/ [00:15:47] or did you run less.sh directly, not using make less/make watchless? [00:16:06] lesswatch* [00:16:19] i have not run make less nor have i run less.sh [00:16:28] :O [00:16:30] so i msut've installed it manually or part of something totally unrelated [00:16:47] hm, I will add a double check for that [00:17:06] cant you detect the appropriate node_modules dir location from npm list autoless? [00:17:13] that we're actually looking at node_modules in the current directory and not in one of the parent dirs [00:17:19] yes [00:17:27] I should be able to do that [00:17:31] let me check [00:18:04] I'll let you know when I push a new changeset [00:18:06] jgonera: vagrant. just sayin'. :P [00:18:53] ori-l, well, I can't assume everyone would use vagrant or that someone won't install some node modules somewhere in their vagrant instance [00:20:51] i know; didn't mean to harass you. [00:22:52] well, maybe I'll try to use vagrant again when I have more free space on my disk or when the instance doesn't use several gigabytes of disk space ;) [00:31:54] New patchset: JGonera; "Use autoless to compile LESS files" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49184 [00:32:01] awjr, ^ [00:32:10] adding a short package.json file solves the problem [00:34:13] ruhroh jgonera: [00:34:14] HEAD is now at b0f0808... Use autoless to compile LESS files [00:34:14] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ make less [00:34:14] Installing autoless... [00:34:14] npm http GET https://registry.npmjs.org/autoless [00:34:14] npm http 304 https://registry.npmjs.org/autoless [00:34:15] npm http GET https://registry.npmjs.org/watch/0.5.1 [00:34:16] npm http GET https://registry.npmjs.org/growl/1.6.1 [00:34:17] npm http GET https://registry.npmjs.org/commander/1.1.1 [00:34:18] npm http GET https://registry.npmjs.org/less/1.3.3 [00:34:19] npm http 304 https://registry.npmjs.org/less/1.3.3 [00:34:20] npm http 304 https://registry.npmjs.org/watch/0.5.1 [00:34:22] npm http 304 https://registry.npmjs.org/growl/1.6.1 [00:34:23] npm http 200 https://registry.npmjs.org/commander/1.1.1 [00:34:24] npm http GET https://registry.npmjs.org/commander/-/commander-1.1.1.tgz [00:34:25] npm http 200 https://registry.npmjs.org/commander/-/commander-1.1.1.tgz [00:34:26] npm http GET https://registry.npmjs.org/keypress [00:34:27] npm http GET https://registry.npmjs.org/ycssmin [00:34:28] npm http 304 https://registry.npmjs.org/keypress [00:34:29] npm http 304 https://registry.npmjs.org/ycssmin [00:34:30] autoless@0.1.2 node_modules/autoless [00:34:31] ├── growl@1.6.1 [00:34:32] ├── watch@0.5.1 [00:34:33] ├── commander@1.1.1 (keypress@0.1.0) [00:34:34] └── less@1.3.3 (ycssmin@1.0.1) [00:34:35] env: nodejs: No such file or directory [00:34:36] make: *** [less] Error 127 [00:34:37] derp sorry shoulda put that in a pastebin [00:35:02] aw, now that must be come Mac specific crap... [00:35:21] what does /usr/bin/env nodejs return? [00:35:47] jgonera: it's just 'node' on mac (and canonically, I think -- 'nodejs' was a debian decision IIRC to avoid a conflict.) [00:36:01] ori-l, thanks, that explains it [00:36:36] awjr, this is not the patchset itself, it's autoless I wrote, I'll update it and let you know [00:36:49] meanwhile delete the node_modules directory in MobileFrontend [00:37:24] doh jgonera Arthurs-MacBook-Pro:MobileFrontend awjrichards$ /usr/bin/env nodejs [00:37:24] env: nodejs: No such file or directory [00:37:35] yeah, what ori-l said [00:37:37] yeah that explains it, ori-l [00:37:39] yah [00:37:40] try /usr/bin/env node [00:37:41] awjr: also 'npm config set loglevel warn' for saner output :) [00:37:49] heheh thanks ori-l [00:37:55] well npm didn't fail here [00:38:00] I failed ;) [00:38:39] i know, npm's default mode of reporting every HTTP response status is a bit nuts [00:38:55] ah, that, I got so used to it that I don't notice anymore [00:41:46] ok, awjr, give it one more try ;) [00:41:53] Is there not a component in bugzilla for mobile-in-core issues? [00:42:11] marktraceur: what do you mean by 'mobile-in-core'? [00:42:56] awjr: As far as I can tell, https://bugzilla.wikimedia.org/show_bug.cgi?id=45260 is a core bug, but it's not unknown, it's about the mobile bits. Unless I'm misreading it and it's actually a mobilefrontend bug. [00:43:57] actually i think that /is/ a mobilefrontend bug, and im glad soemone reported it because i noticed it the other day and forgot to report it myself :p [00:44:18] marktraceur: ^ [00:44:46] Sweet. [00:44:47] marktraceur: i just moved it to MF [00:45:07] Thanks much! [00:45:15] * marktraceur sinks slowly beneath the water, and lurks [00:45:29] lol [00:48:23] New review: awjrichards; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50200 [00:48:24] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50200 [00:49:29] New review: awjrichards; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50281 [00:49:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50281 [00:50:03] jgonera: did you mean to add a new patch set for 49184? [00:50:24] no, it will work because I update autoless in npm repository [00:50:31] but first delete node_modules [00:50:42] oh :) [00:51:26] \o/ [00:51:29] works jgonera [00:51:39] yay! [00:51:49] New review: awjrichards; "Patch Set 4: Verified+2 Code-Review+2" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49184 [00:51:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49184 [00:53:26] jgonera: when you have a sec can you update the story wall? [00:53:44] ok, will have a look at it in a few mins [00:53:57] cool no rush, would just be nice to have it up to date for standup tomorrow [00:57:59] awjr, you mean the current story wall? [00:58:03] yep [00:58:16] i just "resolved: wontfix"ed my first bug. i feel like a bad person :-/ [00:58:20] I'm not sure what should be updated [00:58:39] Maryana, what bug was it? ;) [00:58:47] Maryana: that goes away. soon you'll feel yourself a mighty hunter, thinning down the herd [00:58:55] jgonera: oh dude, my bad - i hadn't actually refreshed >_ [00:59:05] somebody reported that the "close section/jump back" behavior was inconsistent btw ios & android [00:59:06] sorry :p [00:59:13] brion: ehehehehe [00:59:20] np ;) [00:59:29] Maryana: i noticed the other day that close section wasn't working properly for me on android [00:59:37] (i know you guys think no one uses that feature, but i do!) [00:59:39] yeah, we just need to kill that thing [00:59:42] haha [00:59:43] nooo [00:59:45] i love it [00:59:47] i'm sure like 5 power users use it [00:59:57] and they'll be mad that we're getting rid of it [01:00:06] hell yeah we will [01:00:07] :) [01:00:19] dont take our power! [01:00:27] https://www.xkcd.com/1172/ [01:00:27] soon you will adjust to the magic of scrolling [01:00:36] but my thumbs get soooo tired [01:00:38] brion: yep, i was just going to pull that link up [01:00:44] hehe [01:01:24] i'm sure 2 years from now we'll all be looking at the mobile site on google glass and scrolling with our MINDS anyway [01:01:29] lol [01:01:34] fingers crossed [01:02:03] Google Thought was great until they introduced Google Thoughtcrime [01:02:12] i appreciate how there's an xkcd comic for pretty much any scenario [01:02:19] lol [01:02:24] rofl brion [01:03:03] haha [01:04:13] don't laugh. when the MPAA figures out they can charge you every time you remember a movie quote, this'll all go off the deep end [01:04:33] it's their fault for making them so damn catchy! [01:04:43] oh wait.. [01:04:47] that's part of their plan, isn't it? [01:04:54] first time's free, kid [01:05:01] :) [01:07:45] hey guys do we have a file upload limit? [01:07:52] size limit [01:07:55] I mean [01:08:38] jcmish: 100mb default limit, i think [01:08:53] might be hard to get photos that big :) [01:08:57] sweet thanks brion [01:09:14] I was saying things like upload a "really large file" :D [01:09:16] but we'll have to use alternate interface for video someday, those easilly get bigger [01:09:25] and thought it might be nice to "share" the limit [01:11:34] yeah good to use real numbers :D [01:21:36] Hi, http://www.meetup.com/Wikipedia-Engineering-Meetup/events/100444752/ will start in about 45 minutes and we will experiment with Hangout streaming and IRC in #wikimedia-office . Let's see how it goes. [01:24:53] wheeeee [01:30:46] hmm, yuvi didn't commit that detail view did he :) [01:31:28] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/oltl9w [01:31:28] Commons-iOS/master 0fb0643 Brion Vibber: Update event logging schema versions, add to login [02:13:00] http://www.youtube.com/watch?v=8ccTm_IdZBw starting now [05:42:33] [android-commons] yuvipanda pushed 7 new commits to master: http://git.io/PIH08A [05:42:33] android-commons/master b37f1f3 YuviPanda: Add appropriate User Agent [05:42:33] android-commons/master 540b760 YuviPanda: Cleanup of ContributionsActivity to stop using Cursor directly [05:42:33] android-commons/master 9476ec6 YuviPanda: Start using Fragments appropriately [05:43:13] Project Android-Commons (mobile) - Nightly builds build #74: SUCCESS in 38 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/74/ [05:43:14] * yuvipanda: Add appropriate User Agent [05:43:14] * yuvipanda: Cleanup of ContributionsActivity to stop using Cursor directly [05:43:15] * yuvipanda: Start using Fragments appropriately [05:43:15] * yuvipanda: Moved Media and Contributions to be Parcelable [05:43:16] * yuvipanda: Add minimal detail view as a fragment [05:43:16] * yuvipanda: Minor stylistic fixes [05:43:17] * yuvipanda: Retain position of Contributions grid across Activity destroys [05:58:14] YuviPanda: CodeEditor is enabled for schemas now :P [05:58:20] ori-l: sweet! :D [05:58:25] but I still prefer my script :P [05:58:27] vim, etc [05:58:51] Early morning IST is the worst time ever, I guess. Nobody up from *any* timezone. [05:58:52] sigh [05:58:55] i know, but it's too l33t for mere mortals [05:59:08] ori-l: you really prefer ace over vim / emacs? [05:59:11] (whatever your editor is) [05:59:28] ori-l: what is your editor anyway? [06:00:52] ori-l: also with LC_ALL set to utf-8 I can't seem to log in to stat1 for some reason [06:01:02] (ssh -v points that as the part where it hangs) [06:01:02] and resetting it lets me log in [06:01:02] ... weird [06:05:40] i use vim, obviously [06:06:15] but check 'SendEnv' in your .ssh/config [06:07:40] ori-l: hehe at 'obviously' :) [06:07:43] will do [11:29:50] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/zIUCuQ [11:29:50] android-commons/master f5279d6 YuviPanda: Retreive all contributions ever, not just first 500 [11:30:22] Project Android-Commons (mobile) - Nightly builds build #75: SUCCESS in 42 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/75/ [11:30:23] yuvipanda: Retreive all contributions ever, not just first 500 [12:13:16] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/BItSNw [12:13:16] android-commons/master 700bfee YuviPanda: Add proper 'up' affordance behavior [12:13:42] Project Android-Commons (mobile) - Nightly builds build #76: SUCCESS in 30 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/76/ [12:13:43] yuvipanda: Add proper 'up' affordance behavior [13:02:20] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/XLluMQ [13:02:20] android-commons/master 0be55fa YuviPanda: Show number of contributions in activity subtitle [13:02:44] Project Android-Commons (mobile) - Nightly builds build #77: SUCCESS in 28 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/77/ [13:02:45] yuvipanda: Show number of contributions in activity subtitle [13:51:59] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/LykKVA [13:51:59] android-commons/master 6e3ee46 YuviPanda: Minor style changes to the 'Share' screen [13:52:23] Project Android-Commons (mobile) - Nightly builds build #78: SUCCESS in 28 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/78/ [13:52:23] yuvipanda: Minor style changes to the 'Share' screen [17:51:47] whee backing up my nexus10 [17:51:55] gonna try the ubuntu touch build on it [17:53:30] dude awesome [17:53:34] let us know how it goes, [17:57:33] we'll see how long this backup takes :) [18:00:26] brion: around? [18:00:31] yo YuviPanda [18:00:42] eh mtg? [18:00:47] MaxSem: delayed [18:00:59] brion: so push failed yesterday. ~10 commits pushed today :) [18:01:04] yay [18:01:13] brion: so do CR :) [18:01:17] will do :D [18:01:22] brion: also from iteration 3 section on the mw.org page [18:01:31] brion: I'm going to get rid of all the notifications type stuff. We should wait on Echo [18:01:35] have to, even. [18:01:37] yeah ok [18:01:43] sensible [18:01:49] can't do much until there's a system ready to plug in to :D [18:01:51] because checking for changes to all the files from the user with 2 reqs per image is not very good [18:01:54] yeah, exactly [18:04:04] so let me just go ahead and remove those [18:04:23] did I just say 'let me just go ahead and X' [18:04:25] sorry [18:04:30] brion: anyway, notifications stuff is gone [18:04:34] whee [18:06:44] hey notnarayan [18:06:54] hi brion [18:10:47] brion: are you in the office? [18:10:52] brion: cany ou test out out thenew build? [18:10:57] and show it to Maryana / tfinc too? [18:11:08] i'm at home office this morning, will head in when done with this tablet backup [18:11:40] was it the one you demo'ed last night at the eng meetup? [18:11:58] (I missed that) [18:12:07] Maryana: this one has had some fundamental code changes. [18:12:14] plus some UX fixes + a 'details' view [18:12:17] i didn't show the android version cause my hdmi adaptor's a bit flaky, juts showed the iOS version [18:12:21] will show ya the android one next time :D [18:12:32] ah :D [18:13:02] * brion checks if nexus 4 has a non-usb hdmi out [18:13:34] nope, it's via the usb too. bah [18:13:45] i'll just have to get a second adaptor that doesn't have a loose wire or whatever i guess [18:16:11] brion: :P [18:16:40] brion: standup! [18:16:58] darn camera's out again :P [18:24:28] MaxSem: so is card 304 done now? [18:24:53] YuviPanda: brion: please update http://www.mediawiki.org/wiki/Apps/Commons#Iteration_2 so that i can accurately set iteration 3 [18:25:04] awjr, let'awjr, s wait for https://gerrit.wikimedia.org/r/#/c/50376/ to be deployed [18:25:57] updated a bit [18:26:19] ok MaxSem thanks [18:26:31] YuviPanda: ok i found a second micro-usb cable, i think i can test on my galaxy nexus without disturbing the tablet backup i'm running [18:26:55] * brion is out of usb ports and goes looking for the hub, which is *somewhere* on this desk [18:27:36] tfinc: done for Android. Also iteration 3, we shouldn't be doing notifications without Echo, so I've BEBOLD and removed those [18:28:56] YuviPanda: removed or moved them to the backlog ? [18:29:33] tfinc: to backlog [18:29:38] YuviPanda: perfect [18:29:43] YuviPanda: i like the sideways scrolling to switch between files! [18:29:54] i'll take a look and prioritize them over the weekend [18:30:01] are you going to add description, license etc by scrolling down, or via menus? [18:30:04] tfinc: sweet. [18:30:13] brion: well, currently you see title [18:30:18] everything should be right around that [18:30:27] author + license right below [18:30:30] (in smaller text) [18:30:34] and description right below that [18:30:34] with descriptions and usage that could get pretty long [18:30:37] awjr: do you need me at the mobile/ops sync up? [18:30:39] brion: no usage. [18:30:45] brion: no usage until Echo [18:30:48] hmm [18:30:54] well we can do usage, we just can't notify you :) [18:31:00] brion: description - let's clip those at 3 lines, and have overflow that you've to tap to exapnd [18:31:07] brion: yeah, so that's confusing and useless, I think [18:31:08] tfinc i dont think so, i'd consider you optional [18:31:13] heh [18:31:14] awjr: k [18:31:20] we should either do it in a way that provides an end usable goal, or not do it at all [18:31:37] well going to see usage of your photo is kinda neat. seems like a usable goal in and of itself [18:31:53] brion: well, it'd be neater when you can get notified when someone uses it, no? [18:32:03] sure, that's neater. [18:32:05] I mean, for old commons hands it is... old? [18:32:13] and for new people, well, we don't have to want them go back and look [18:32:36] brion: and either way, I think we should prioritize Campaigns support over that. I think when we're done with Campaigns there should be some form of Echo for us [18:33:15] i'm still open to doing the usage list on the detail view, but that's up to tfinc to prioritize ultimately. :) campaigns might drive uploads more so… [18:33:39] brion: get it on the backlog and i'll take a look [18:33:50] spiff [18:34:04] tfinc: it's on the backlog (Notifications (Usage & Edits)) [18:34:09] I could separate it out if you want [18:35:35] tfinc: currently 'Show globalusage entries on detail page' is sitting in iteration 3, and notifications for live updates to usage are in backlog [18:35:54] yuvi's suggesting holding off on 'show global usage entries on detail page' until the notifications are available [18:40:25] YuviPanda: can you jump into "subject:Photo upload android app" ? [18:40:58] brion: it no longer is, I removed it. Feel free to add it back if you want to, but I think we should try to get a release out rather than add more stuff :P [18:41:04] tfinc: email? yes. trying it out now [18:41:07] fair nuff [18:41:22] YuviPanda: lets motivate them to join our efforts [18:41:30] exactly what I was thinking :) [18:41:33] and get them to test out beta [18:41:36] our* [18:41:42] and get them to make sure marathi looks awesome [18:43:11] tfinc: true! [18:43:14] (twn works) [18:43:36] YuviPanda: brion: how many rounds of translate wiki will we get into both betas ? [18:44:34] i'm not sure we've fully got the iOS one into twn yet… YuviPanda do I still have to poke those guys? [18:44:37] though it's ready to go :) [18:44:40] MaxSem jgonera can you guys take a look at these today? https://gerrit.wikimedia.org/r/#/q/owner:awjrichards+status:open+MobileFrontend,n,z [18:44:44] brion: I think so [18:44:55] * brion wanders over to #mediawiki-i18n [18:44:57] Maryana: any scary changes going out next week that we need the other teams to know about ? [18:44:58] tfinc: there's been one round in. I'll poke siebrand to get one more. It is one push button for them [18:45:05] k [18:45:09] awjr, will do before lunch [18:45:15] awesome thanks! [18:45:33] tfinc: depends on your definition of scary :) lead image uploads go to stable, which is pretty huge [18:45:46] \o/ [18:45:52] brion: the underlying framework (JSON) is what was okay with them. They still needed to set it up i think [18:45:54] that's a very popular feature in demos [18:46:00] ok [18:46:06] awjr: give james a cut off date for swag as i can see this dragging on [18:46:18] james/rachel [18:46:37] * MaxSem kicks gerrit-wm [18:47:01] brion: even Commons app is not on the frontpage yet [18:47:04] (but it is in TWN) [18:47:08] (and you can translate for it) [18:47:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/49354 [18:47:20] I tried translating a few things to Tamil, and then realized I absolutely completely suck at my native tongue [18:47:39] tfinc yeah - i mentioned already i need stuff no later than march 5. if i dont hear from james about it soon i'll give him a call [18:48:19] awjr: good. keep reminding them of the dates so that they know our expectations [18:48:23] word [18:48:59] brion: when would you be heading in to office? [18:49:18] I wanted to get a device to Maryana so that she could look over and figure out if we're doing 'copy' right [18:49:20] (the text) [18:49:22] waiting on a file copy… somewhere in the next hourish [18:49:48] kk - just give me shinies to play with when you're here, brion :) [18:49:55] will do :D [18:50:01] Maryana: :) [18:50:14] the app is very non-heavy on text (intentionally) [18:50:20] but would still be nice for you to look at it [18:50:25] munaf too, perhaps [18:50:32] yeah, i'll poke him, too [18:50:32] when does vibha come back, btw? [18:50:49] that's a very good question… she said next tuesday, but i haven't heard from her [18:50:54] starting to get a little worried [18:51:34] Maryana: is this expected for beta? https://mingle.corp.wikimedia.org/projects/mobile/cards/405 [18:51:40] Maryana: next tuesday is... 26? [18:52:56] awjr, yep, beta [18:53:00] yuvipanda: yeah [18:53:03] Maryana: tnx [18:53:11] np! [18:53:43] yuvipanda: can you just hop on down the street to mumbai and check on her? :) [18:53:55] oh, she is in Mumbai? [18:53:59] i think so [18:54:44] Maryana: there were a couple of bomb blasts in a different city. Mumbai is still peaceful. So she should be okay. [18:54:53] :-/ [18:54:57] that is not reassurring... [18:59:02] waaaah pretty touchscreen retina display but so expensive for just 32gb of local storage… https://play.google.com/store/devices/details?id=chromebook_pixel_wifi [18:59:12] if that had more i'd set one up to dual-boot ubuntu [19:00:57] brion: indeed. 32 / 64 seems to be the 'weird' part of that spec [19:01:08] well it's for THE CLOUD [19:01:17] which makes even 32g seem roomy i guess [19:05:15] Maryana: just wanted to dbl check the template to use for https://mingle.corp.wikimedia.org/projects/mobile/cards/397 [19:05:23] {{Upload from mobile site}} does not appear to currently exist [19:05:58] hmm, it looks like yuvi made this: https://commons.wikimedia.org/wiki/Template:Uploaded_from_Mobile [19:06:01] which is app-specific [19:06:02] yeah [19:06:08] Maryana: it isn't meant to be app specific [19:06:14] i named it so that web can use it too [19:07:01] but does it require a different parameter to indicate mobile webness? [19:07:08] or do we need to fork it..? [19:07:16] templates, how do they work? :) [19:07:18] ah but that template adds the 'uploaded with commons app' category [19:07:55] Maryana: idea is to have 'platform=web' [19:08:09] ah, ok [19:08:21] awjr: it adds Uploaded with Commons App/{platform} [19:08:22] category [19:08:28] should be easy to change it to [19:08:35] Uploaded with Mobile/{platform [19:08:35] } [19:08:48] so we will have Uploaded with Mobile/Android, /iOS, /Web [19:09:01] but does it involve mucking with (shudder) parser functions inside the template? [19:09:16] Maryana: not really. Wait, let me do that [19:09:40] YuviPanda: like this? https://commons.wikimedia.org/w/index.php?title=Template%3AUploaded_from_Mobile&diff=91247592&oldid=89989389 [19:09:46] i did waaaay too much of this when steven walling and i were a/b testing warning templates [19:09:57] templates make my brain hurt [19:10:03] awjr: exactly like that [19:10:08] i'm editing docs now [19:10:17] thanks, d00ds! [19:10:24] Maryana: what do you want 'platform' to be? [19:10:33] 'web' [19:10:33] ? [19:10:36] sure [19:10:42] Maryana: and 'version'? [19:10:44] will web have one? [19:10:55] well, that could be either "for use on article" or "donated to commons" [19:11:09] or some less wordy way of saying that :) [19:11:52] as things are right now in the code for that card, it's going to need to be static [19:12:18] i mean, we can't currently diferentiate 'for use on article' vs 'donated to commons' [19:13:27] ok, that's not a big deal [19:13:38] there are other ways to tell which workflow the upload is coming from [19:14:22] Maryana ok so platform=Web version=? [19:14:41] i can't think of any other use for a version field, then, unless we create uploads 2.0 -- uploads of the future! :) [19:14:54] maybe beta/stable, if that's possible? [19:15:18] not with how things are currently written based off of the card [19:15:30] ok, then let's just not worry about it for now [19:15:34] okidoke :) [19:15:49] all that really matters is making sure we tag these as category: mobile web they're coming in [19:15:55] *as they're coming in [19:21:40] Maryana: do you have an icon for 'mobile web' on Commons somewhere? [19:21:45] I remember a rounded w [19:21:53] currently it is using 'haloween wiki globe' icon ;P [19:21:58] haha, yeah, i saw that [19:22:04] * Maryana looks [19:23:55] man, how do we not have a linux libertine W on commons? [19:24:03] that's our brand! [19:24:40] oh wait, here we go: https://commons.wikimedia.org/wiki/File:Wikipedia%27s_W_(Linux_Libertine).svg [19:25:34] Maryana: :D [19:25:37] O [19:25:41] I'll update that [19:26:01] if that makes sense to use [19:26:31] Maryana: still better than the haloween one [19:27:04] Maryana: There was a 'button' type image with 'W' and 'Mobile' on it [19:27:14] hmm [19:27:34] do you mean the one on the signup screen? [19:58:22] Maryana, I am here now. [19:58:31] yo dawg [19:58:54] let's talk in #wikimedia-design [19:59:19] actually. no. [20:04:38] brion: ragesoss just perf tested the scrolling. works smooth on his 2308 uploads to commons :D [20:04:45] (I am getting them all now. Yay!) [20:04:48] yay! [20:04:58] ok i got ubuntu touch installed on my nexus 10. heading into the office :) [20:05:44] (my test was on a HTC One XL, fyi) [20:05:55] (okay, really leaving now) [20:33:22] awjr_lunch, MaxSem, I can't find a way to change our modules' targets for the JS test page other than: [20:33:23] if ( $wgEnableJavaScriptTest ) { [20:33:24] $wgMFMobileResourceBoilerplate['targets'][] = 'desktop'; [20:33:24] } [20:34:01] I can't do it anywhere outside MobileFrontend.php because the ResourceLoader is already initialized and changing $wgResourceModules has no effect [20:34:12] any ideas? [20:34:45] there has to be some protection from mobile modules leaking to the desktop site [20:36:09] in fact I also discovered that this has probably no effect: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=includes/MobileFrontend.hooks.php;h=07cbca09368426d40a16dfa060ddf04d533db22c;hb=HEAD#l188 [20:36:33] MaxSem, so I can't assume that $wgEnableJavaScriptTest is false in production, right? [20:36:41] ragesoss: I just stole the numbered loading background stuff :) [20:37:29] jgonera: it's true on test2wiki [20:37:35] jgonera, think of third-party installations [20:37:44] it also might be tru e.g. on translatewiki [20:37:53] yeah, that's what I thought... [20:38:19] so do you see any way of dealing with this? changing the targets of modules only for the test page? [20:39:36] ideally, Special:JavaScriptTest should make sure that every module has desktop target [20:39:38] ... [20:39:39] ... [20:39:45] yes, but how? ;) [20:39:48] * MaxSem runs away from resulting blast [20:40:18] as I said, changing the targets in the onResourceLoaderTestModules hook is too late [20:40:27] $resourceLoader->dontFrigginCheckTargets()? [20:41:11] two things came to my mind: reinitializing the resource loader, but I can't do it in the hook because it causes infinite recursion (RL runs the hook when it initializes) [20:41:28] * MaxSem facepalms [20:41:48] dependency hell [20:41:58] or rebuilding the whole $wgResourceModules with different module names (like adding some suffix or prefix) and registering those alternative modules for test purposes [20:42:16] is there a way to do it in the post setup hook? [20:42:29] post RL-init? [20:42:40] im thinking in efMobileFrontend_Setup() in MobileFrontend.php [20:42:54] hm [20:42:56] jgonera, maybe have it run tests for each target when this target is active? [20:43:26] MaxSem, I'm not sure I understand, JS test page doesn't work in mobile [20:43:30] in principle, this should ensure that all tests are run exactly in environment they're written for [20:43:37] yeah [20:43:38] so make it work [20:43:46] muhaha [20:43:46] I thought about that [20:45:24] awjr, putting the check in efMobileFrontend_Setup() seems to work [20:45:47] or not, wait [20:45:49] doh [20:46:14] no, it doesn't :/ [20:46:38] target separation is the way to go [20:47:01] you mean running tests on mobile version of the page? [20:47:54] yes [20:48:11] I agree, maybe I'll try that later [20:48:28] resistance is futile, you will be circularily depended [20:51:25] hehe [20:55:36] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/-B8quA [20:55:36] android-commons/master 48b292e YuviPanda: Show sequence numbers in the background as images load in list... [20:55:37] ragesoss: ^ implemented the background numbers :) [20:55:42] great, this will mean adding mobile target to all the qunit dependencies in the core... [20:56:03] really, we should be able to control targets somehow without submitting patches to the core... [20:56:12] Project Android-Commons (mobile) - Nightly builds build #79: SUCCESS in 36 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/79/ [20:56:13] yuvipanda: Show sequence numbers in the background as images load in list [20:56:50] jgonera: you might check with Krinkle, he may have some good ideas [20:56:59] and/or trevor [20:57:22] thanks, I will [20:57:29] qunit has no dependencies, standalone. [20:57:34] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/1FHYEg [20:57:34] android-commons/master 2e421b5 YuviPanda: Don't dispose of services if they don't need disposing... [20:57:35] YuviPanda: sweet [20:57:59] Project Android-Commons (mobile) - Nightly builds build #80: SUCCESS in 28 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/80/ [20:57:59] yuvipanda: Don't dispose of services if they don't need disposing [20:58:17] Krinkle, I mean the dependencies of all the RL modules [20:58:31] nothing from qunit has mobile as a target [20:58:34] awjr, how's your LevelUp doing? [20:58:44] hey basile [20:58:46] err [20:58:47] sorry basile [20:58:48] I meant brion [20:58:52] heyyy [20:59:13] jgonera: what is "all from qunit"? [20:59:15] Krinkle, I'm not sure why the JS test page on mobile simply doesn't work without showing any RL errors [20:59:18] MaxSem: slowly but surely. im currently working on MF stuff but should be done soon. i've read the first few chapters of a C book and am going to do some exercises later this afternoon [20:59:22] there is 1 mobile, jquery.qunit [20:59:26] brion: ragesoss just alerted me to this nice app called 'JustPictures' that he uses for browsing pics. [20:59:31] brion: I just stole a feature from them :D [20:59:38] \o/ [20:59:39] if you want that to be loadable on mobile, by all means. add target mobile to it. [20:59:43] 'mediawiki.tests.qunit.testrunner', 'jquery.qunit', 'jquery.qunit.completenessTest', etc. [20:59:45] awjr, excersizes from that book? [20:59:48] MaxSem: yeah [20:59:52] jgonera: Right [21:00:00] brion: can you make a build and show Maryana_lunch when she's back from lunch? [21:00:06] brion: I'm thinking of stealin ganother feature [21:00:12] brion: try out the app [21:00:13] it's pretty neat [21:00:16] jgonera: Well, it not showing errors is exactly what you (plural) asked for. I originally opposed the 'target' system, but it is how it is. [21:00:17] in terms of image browsing [21:00:17] Krinkle, I will, but it's painful ;) and it would be easier if I actually got some errors about missing dependencies in JS console [21:00:24] Maryana_lunch: re https://mingle.corp.wikimedia.org/projects/mobile/cards/405 it says 'when i tap the lead image CTA and go to the login or signup page'… the lead image CTA only shows up for logged in users at the momen [21:00:26] t [21:00:28] YuviPanda: will do [21:00:29] Completely isolated, everything it hasn't approved is as if it doens't exist [21:00:33] awjr, okay - poke me when you need some testing of knowledge acquisition [21:00:35] Krinkle, I'm not a big fan of it either [21:00:35] if it doesn't exist, it can't emit errors [21:00:35] should we remove that requirement from the card? [21:00:38] that's by design [21:00:40] will do MaxSem, thanks :) [21:00:55] Krinkle, but test modules by default depend on 'mediawiki.tests.qunit.testrunner' [21:00:55] jgonera: right, there's a few related modules. I forgot those [21:00:57] so i played a little with ubuntu touch on the nexus 10 on the train ride over [21:00:59] MaxSem: once i have some actual work to show i'll share it with you [21:01:05] they should throw an error if that module is missing [21:01:12] it's pretty but it crashes a lot, it's slow, and the apps are few and mostly demo-ish at this stage :) [21:01:14] jgonera: they mostly contain logic though, should be fine in mobile. Nothing UI related or a risk other wise. [21:01:20] awjr: you're right. wasn't sure how much we'd have built out by the time we got to this card [21:01:25] brion: :D [21:01:29] brion: maybe it'll get better. [21:01:34] oh i'm sure it will [21:01:39] we'll see how long it takes tho [21:01:41] brion: yeah. [21:01:52] I'm not holding my breath until they get their devices out [21:01:58] i suspect it's not fully graphics-accelerated; scrolling in the browser is hella slow [21:02:00] Maryana: yah fair enough. should we just remove that requirement for now? [21:02:11] yeah, editing now [21:02:19] cool thanks :) [21:02:39] brion: possible. And battery? [21:02:54] can't say yet, the machine's not fully charged yet [21:03:01] right [21:04:19] brion, any easy way of temporarily disabling DOMParse? [21:04:28] jgonera: uhhh? [21:05:09] jgonera, in which cases? [21:05:40] MaxSem, just to see if it's stripping something that QUnit needs [21:05:55] YuviPanda: what's the thing with sequence numbers? [21:06:24] brion: just a way to see how far down you are? [21:06:28] Looked better than scrolling blanks to me [21:06:37] i don't see it though... [21:06:43] brion: they disappear when you load [21:06:46] err [21:06:46] ah i see [21:06:47] when the images load [21:06:53] in the list view, not the detail [21:06:53] the images are in front of them [21:06:55] no [21:07:02] wouldn't make sense in the detail [21:07:05] jgonera, MobileCOntext::setContentTransformations() [21:07:10] (false) [21:07:20] thx [21:07:26] might want to shove the numbers up a bit, above the semi-transparent bar [21:07:26] bottom of the numbers gets partially cut off [21:07:41] New patchset: awjrichards; "(mingle #405) Make login/acct create header different from watchlist cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50430 [21:08:26] brion: true. Will have to poke around. But what do you think? [21:08:29] of it as a concept? [21:08:53] kinda neat [21:09:06] only 'kinda'? [21:09:16] it's kind of redundant to the scrollbar for determining position in the list [21:09:37] scrollbar doesn't give you a number. [21:09:51] what good's the number? it'll change as soon as you upload another thing [21:10:25] well, I've found it very useful in the other context (browsing my Flickr photos) [21:10:27] brion: you don't see it for more than a second anyway. [21:10:42] i'm not against it, just not convinced it's helpful :) [21:11:06] it also gives sense of scale for the scroll bar. [21:11:27] which can scroll through 2308 photos in about a minute of swiping. [21:11:49] ragesoss: also thoughts on the small alert-type-floating-thingy that shows up when you scroll, showing dates? [21:11:54] but you have no idea how fast the photos are going by. [21:12:07] YuviPanda: I like those. [21:12:12] yeah, me too [21:12:28] especially if they remain the same without re-rendering/flashing for a whole set of the same date. [21:12:29] brion: check the app out. [21:12:32] which I assume is what you mean. [21:12:48] ragesoss: yes. they'll change only when you are 'fling'ing [21:13:12] YuviPanda / ragesoss what was the app again? [21:13:38] ok, I've made it [21:13:42] awjr, can you review https://gerrit.wikimedia.org/r/#/c/50388/ please? [21:13:45] tests run on mobile! [21:13:49] brion: JustPictures [21:13:53] ok [21:14:01] now I can review awjr's commits ;) [21:14:25] i like how the app name includes an exclamation point and the store description is in ALL CAPS [21:14:35] brion: :D [21:14:36] MaxSem: looking [21:14:42] THEY ARE VERY EXCITED ABOUT SHOWING YOU YOUR PICTURES [21:14:57] YES! [21:16:30] MaxSem: merged [21:16:36] thanks [21:18:31] Maryana: i can show you the current iOS and android apps whenever you're ready :D [21:19:01] ok - uno secundo [21:19:02] bueno [21:19:13] brion: I've a build with it set to commons instead of testwiki [21:19:22] brion: bit.ly/android-commons [21:19:27] ooh [21:19:40] it'd be nice if that could be a runtime switch [21:19:48] brion: not the way the app is written, no [21:19:51] ah [21:19:53] well, I could. But would be a mess. [21:19:55] since I save tokens [21:19:56] which version are we going to be giving to beta testers? [21:20:11] brion: good question [21:20:18] I should ask qgil or Maryana I think [21:20:34] hm? [21:20:34] brion: bit.ly/android-commons should work and uploads / gets from commons [21:20:46] Maryana: for the testing sprint on Monday - should we have people upload to testwiki or commons? [21:20:49] * YuviPanda is thinking Commons [21:20:54] ah, good question [21:21:00] yeah, i think commons would be fine [21:21:06] we're primarily reaching out to wikipedians [21:21:09] yeah [21:21:12] YuviPanda: something i do like on JustPictures! is the overlay showing the approximate date of past pictures as you scroll [21:21:13] sweet [21:21:22] brion: I'm implementing that as wes peak :P [21:21:25] if we get any real crap, we can always delete :) [21:21:26] we [21:21:27] awesome :) [21:21:40] brion: STEAL ALL THE IDEAS! [21:21:45] :D [21:23:59] Maryana: brion has the commons link. Do look over :) [21:24:13] * YuviPanda still has to properly implement actions [21:24:30] brion: I also think we should have a way for people to look at talk pages for images. [21:24:41] mm [21:24:51] i'm leery of adding talk features before there's a sane discussion system in place :) [21:25:08] brion: I'm unsure of when flow's going to be available. [21:25:13] yep [21:25:16] and enabled, even [21:25:35] should we provide a shitty talk page experience? or just link them to the browser :( [21:25:54] brion: I'll talk with shankar about it tomorrow (he is snoring peacefully in the next bed) [21:26:00] brion: I think we can do a half-decent job [21:26:16] ok [21:26:23] more useful on tablets [21:26:26] than phones [21:26:52] brion: also is it just me or do thumbnails from Commons load much faster than thumbnails from testwiki? :) [21:27:18] YuviPanda: that's quite likely [21:29:03] YuviPanda: we're thinking of going with "My uploads" instead of "My contributions" [21:31:13] awjr, does https://gerrit.wikimedia.org/r/#/c/50313/ mean that the dashboard won't show photos uploaded using the dashboard button? [21:31:19] brion: yeah, that's what I've heard [21:31:22] and wanted to confirm [21:31:28] brion: also nice would be language for the subtitle [21:31:49] I think it'll also be nice to show how many queued uploads & how many failed ones are there [21:32:12] i dont think jgonera, lemme dbl check [21:32:36] or are they just assigned to the dashboard page? [21:33:52] yuvipanda: brion just showed my the shiny shiny apps [21:33:57] *me [21:34:24] YuviPanda: the "297 files contributed"? [21:34:26] (subtitle) [21:34:29] yeah [21:34:38] current text feels a tiny bit odd to me [21:34:40] that's a mouthful [21:34:49] how about just 297 uploads? [21:35:11] right [21:35:19] and My Uploads instead of My Contributions [21:35:20] ? [21:35:29] and consistent to 'Upload' than 'Contribution' everywhere? [21:35:45] (all my internal classes are named 'Contribution' so that's gonna be fun!) [21:36:20] well you only have to change the localization :) [21:36:37] yeah, but that is why it will be fun [21:36:53] 'for code about the Uploads feature, look at all these Classes named Contribution*!' [21:37:02] Maryana: also 'Uploads' or 'My Uploads'? [21:37:06] (I like the latter) [21:37:17] yeah, i think the latter makes sense for the app [21:37:50] yeah that way we can distinguish between a future general uploads feed view [21:38:02] jgonera: im not sure im actually having some weirdness with photo uploads on my local machine [21:38:16] awjr, ok, I will check that [21:38:20] thanks jgonera [21:39:28] hmm [21:39:30] My Uploads [21:39:33] or My uploads? [21:39:46] 'My uploads' [21:39:48] sentence case [21:40:28] right. done [21:40:32] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/oWTneA [21:40:32] Commons-iOS/master 8316755 Brion Vibber: Language tweaks... [21:40:44] Maryana: anything else you wanted to point out? [21:40:54] awjr, ok, it seems to work, I'm just wondering what causes some images not to have pageid [21:41:33] jgonera: it's possible that it was a result of something weird that i did while testing - i populated a bunch of records in the image table with a script [21:41:37] yuvipanda: i think we decided that "photo details" should just be "details" to save space/leave room for different file types [21:41:56] there's a string 'photo details'? [21:41:59] iOS? [21:41:59] awjr, so have you actually seen anything like that in production? [21:42:05] jgonera: nope [21:42:17] YuviPanda: yeah [21:42:25] yuvipanda, yeah, i believe so, when tapping on any given file [21:42:27] you don't have a title for the detail screen so that's fine, no change needed yet [21:42:31] right. [21:42:32] awjr, hm, then I'm not sure if we should try to fix it [21:42:35] brion: do you have ubuntu OS running on a device ? [21:42:40] brion: yeah, it still says 'My uploads' [21:42:42] should be fine, I think [21:42:45] tfinc: i do! it's running on my nexus 10 tablet [21:42:45] i spent a short amount of time seeing if it was possible for a similar case to exist in production, but it was inconclusive [21:42:50] it's….. early still :) [21:42:59] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/tyBIoA [21:42:59] android-commons/master 599be3c YuviPanda: Minor modifications to interface text [21:43:10] jgonera: i thought about that, but it seemed a defensive approach would be good [21:43:45] I mean, after a few months, when reading "// make sure image record is associated with a page " I can imagine myself thinking "why do we want images in the dashboard to be associated with a page?" [21:44:17] when you upload an image, it gets associated with a file page [21:44:26] so, always :) [21:44:55] hm [21:45:18] what was exactly the error you were getting without this change? I can't see pageid being used anywhere else [21:46:26] let me see if i can dig it up [21:47:33] jgonera: i've since deleted the image record that was causing it, but this was what the API was returning: https://gist.github.com/awjrichards/9f89a3c3e63f311ce9c2 [21:47:42] you'll notice the first image has no pageid [21:48:22] looks like some bad old record [21:48:31] for one thing the title begins with a lowercase letter [21:48:32] I see, but I grepped all the source for pageid and I can't find anything using it [21:49:27] brion yeah, i generated a bunch of records in the image table at one point for some other testing [21:49:39] ah suspicious [21:49:45] jgonera: yeah, we dont care about it anywhere else afaik [21:50:59] i don't really care that much about it - it seems like a benign and defensive approach to me, but if you'd rather not include it until we see a problem in production, im ok with that [21:51:25] we can merge it because it doesn't do anything wrong, but if it's also not fixing anything in typical deployments, I'm not sure there's a need for it [21:51:34] let's leave it for now if it's ok with you [21:51:41] yup :) [21:55:22] New review: JGonera; "I think the intent of the story #405 was not to put this message in the header but in a separate box..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/50430 [21:58:53] oh [21:59:08] Maryana: another question about https://mingle.corp.wikimedia.org/projects/mobile/cards/405 [21:59:25] was that text supposed to be in a separate box below the header, or was that text supposed to replace the header? [21:59:37] no no, do not replace the header [21:59:42] abort abort [21:59:52] scheisse [22:00:02] i mean, unless it's readable [22:00:13] when jon did that, the text was huge and it looked really weird [22:00:23] yeah i piggybacked off of what jon did [22:01:00] ok sorry, that was unclear from the design/card [22:01:00] looking at the jsfiddle, i can see why [22:01:05] yeah, i'm sorry about that [22:01:42] i thought munaf had made a mockup that made this more clear [22:02:18] but he's off today :-/ [22:03:19] hrm, although it was in the a.c.: I see a message at the top of the page, below the chrome, that tells me “You must be logged in to watch pages.” [22:03:40] doh [22:03:46] * awjr needs to read more carefully [22:08:37] thanks for catching that jgonera [22:09:21] brion: going to abandon the 'show date as you scroll' one for now. Want to get the beta out first [22:09:27] must stop chasing shiny things :) [22:09:46] have a state bug to fix (rotating view resets to first image) but other than that everything sortof looks okay [22:09:48] for a beta [22:09:53] brion: can you do a round of CR now? [22:10:13] awjr, no problem, I was there when Maryana talked about it [22:10:41] yeah, thank you, jgonera! [22:10:55] i'll try to make sure designs don't leave open this kind of ambiguity next time [22:13:16] thanks Maryana, i shoulda caught that in the AC [22:13:43] once i finish up what im working on now i'll take another stab at that [22:14:06] cool, thanks [22:19:48] brion: still busy? [22:19:51] * YuviPanda goes off to sleep [22:19:56] good night :) [22:20:03] * YuviPanda pokes brion about CR one final time [22:20:05] bye! [22:21:26] yo [22:21:29] sleep well :) [23:01:56] Krinkle, I have a feeling we're still not using RL the way it should be used in mobile... I made the JS test page work in mobile, but for some reasons all the qunit modules that should get loaded at the top, are not loaded at the top... which makes the PhantomJS runner sad [23:02:45] your comment at https://gerrit.wikimedia.org/r/#/c/49075/ seems to confirm this [23:03:40] do you think you could find some time to have a look at what we're doing with RL? it would take you much less time to figure out what weird things we're doing than me I guess [23:04:31] I stopped working on RL support rewrite, wanted to discuss it with Jon [23:05:57] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:06:20] New review: JGonera; "This is still work in progress." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/50442 [23:08:26] MaxSem, ok, I see [23:10:46] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:17:07] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:22:01] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:39:50] New patchset: JGonera; "Fix left and right margin in uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50453 [23:42:05] tfinc, have you checked what was wrong with the wifi in those old iPhones?