[00:00:11] SleepyPanda: have you talked image detail pages with shankar yet? [00:00:27] detail/use on wiki/etc [00:00:36] tfinc: yes. we're not doing 'use on wiki' for now. [00:01:13] SleepyPanda: does shankar have any sketches for it? [00:01:20] not that I know of. [00:02:21] we talked about it and decided to hold off on doing it for now since 1. it is very expensive to notify when new usage occurs 2. Without (1) it is a lot less useless 3. There is a lot of low hanging fruit elsewhere [00:02:47] brion: Does this summary make sense? https://bugzilla.wikimedia.org/show_bug.cgi?id=45401 [00:02:57] valeriej: perfect [00:03:28] brion: Good. I'll update the QA page. [00:04:05] thanks :D [00:08:36] brion: SleepyPanda: i'd call this responsive http://imgur.com/w2wW13j [00:08:46] nice :D [00:08:59] tfinc: thank you :) [00:09:02] tfinc: put that on commons :) [00:09:26] tfinc: if there was an Android TV, and you put that on a 42" screen, it would still be responsive :) [00:09:39] oh man we gotta get one of those [00:12:40] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50821 [00:13:39] SleepyPanda: here you go : http://commons.wikimedia.org/wiki/File:Responsive_design_-_Commons_Android_app.jpg taken with the Commons App no less ... how much more meta can i get ? [00:13:47] :D [00:14:14] brion: the iOS app is not setting date in {{Information}} [00:14:19] bad iOS, bad! :P [00:14:25] :/ Out of the last 3 images I uploaded, 1 of them doesn't display on my 'My uploads' page (it's just black with the number '3'), and all 3 of them display an 'x' when I try to look at them individually. [00:14:40] SleepyPanda: yeah i've got a bug for it :) [00:14:43] valeriej: are they small images? [00:15:10] tfinc: take the picture again, with the meta picture in your grid view [00:15:14] that'll be meta-meta [00:15:22] * tfinc head explodes [00:15:52] 3okay bus in less than an hour [00:15:55] i'll be off now [00:15:58] bye [00:16:02] SleepyPanda: Yeah, I would say so. One is a screen shot of my phone, though. 480x800 [00:16:19] valeriej: yeah, 640px minwidth. I've a bug filed, will fix it :) [00:16:22] (I promise!) [00:16:37] SleepyPanda: Ah, I see! Good to know! Bye! [00:16:41] Bye! [00:16:46] thanks a lot for testing valeriej! [00:17:00] SleepyPanda: You're welcome! [00:17:28] SleepyPanda: are you using a fixed height for the images in the grid or does it vary with device size? [00:17:37] MaxSem, is the SQL query thing in modified watchlist view fixed? [00:18:05] jgonera, working on it - was distracted by operations issues [00:18:08] SleepyPanda: do note the one image that doesn't load in http://commons.wikimedia.org/wiki/File:Responsive_design_-_Commons_Android_app.jpg [00:18:16] ok [00:18:16] is larger then 640 but i have no clue why it doesn't load [00:18:56] MaxSem, can this affect us in production? [00:19:34] probably. but since it's a bugfix, we can merge it even after the deadline (runs from jcmish) [00:19:58] tfinc: "This page has been deleted. The deletion and move log for the page are provided below for reference. " [00:20:18] brion: ahh. we should prune it from the feed then [00:20:36] yeah currently the android one will pick that up (from the log) but the iOS one won't (from all images) [00:20:43] we need to standardize how those behave a bit better [00:20:45] MaxSem, oh ok [00:21:11] if i can't see a preview then its useless to me [00:29:22] New patchset: JGonera; "Fix margin for thumbnails in watchlist (alpha)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50850 [00:30:23] New patchset: Zfilipin; "Updated Ruby version to 2.0" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50852 [00:31:15] [android-commons] mattflaschen opened pull request #4: Add newlines to Information tag so it is easier to edit. (master...informationNewlines) http://git.io/2Q1Giw [00:32:16] Maryana, one question about https://mingle.corp.wikimedia.org/projects/mobile/cards/375 - what do we want to see in the header of diffs? probably not the searchbar, right? [00:32:56] hmm [00:33:01] on the other hand, the watchlist doesn't have a title [00:34:05] i think the changes heading + hamburger works fine [00:34:11] ok [00:34:29] i know jon was classifying those kinds of pages differently, for some reason, though [00:34:41] but, meh, i like having the hamburger everywhere :) [00:40:29] does nearby work for you on master? [00:41:02] Maryana, he was treating it as an "overlay" but I'm not sure why, it's a separate page [00:41:48] jgonera: woah, yes. [00:41:58] just going to special:nearby? [00:42:35] Maryana, nevermind, for some reason it doesn't work on chrome but does on my phone [00:42:45] New review: Cmcmahon; "happy 20th anniversary" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50852 [00:42:47] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50852 [00:43:48] oh wow, Ruby 2.0 [00:46:29] :) [01:01:00] so, jgonera, i already told ori about this, but there's a slight problem with userids in eventlogging: they only work on english wikipedia right now [01:01:09] because of a dependency on the e3 experiments extension [01:02:05] userids? [01:02:12] is client ip a user id? [01:02:21] no, though it kind of works like one :) [01:02:32] uh [01:02:35] i mean the ID that mediawiki assigns to every user [01:02:50] we're not using that field for web uploads, but i did have it in the watchlist schema [01:03:30] … and then realized that the ID for every non-english wikipedian was missing [01:09:00] ROFL: i think this hard drive needs to update its highlight photo http://www.amazon.com/dp/B005OK9TBC [01:11:09] Maryana, but, what I meant was the same for me and Jon was client_ip column, is this the same thing [01:11:28] hi mobile people! :) [01:11:36] I think I have found a bug in commons app [01:11:40] * jgonera wants to print SkinMobile.php only to be able to burn it... [01:11:41] jgonera: no, it's the userId field here: http://meta.wikimedia.org/wiki/Schema:MobileBetaWatchlist [01:11:42] how do I report it? [01:11:49] zeljkof: bugzilla! [01:11:49] bugzilla? [01:12:00] tfinc: thanks :) [01:12:01] zeljkof: right here: https://bugzilla.wikimedia.org/enter_bug.cgi?product=Commons%20App :D [01:12:09] jgonera: i detect a hint of maxsem in your desire to burn things... [01:12:26] Maryana, so I wasn't talking about the same things [01:12:27] brion: will do, thanks [01:12:35] om nom nom [01:13:49] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/tqMDuQ [01:13:49] Commons-iOS/master 3491bc8 Brion Vibber: Size uploads-view items and show titles to roughly match Android [01:13:49] Commons-iOS/master fe04dc4 Brion Vibber: Go back to non-translucent navigation bars in most views... [01:15:49] jgonera ? [01:16:16] clientIp and userId are two different things, yes :) is that what you meant? [01:16:25] Maryana, I just read Michelle's message, she found an issue in the commit moving uploads to stable but unfortunately didn't write what the issue was... [01:16:38] uh oh [01:16:42] Maryana, yes, and I can't understand why Jon and I would have the same clientIp [01:17:24] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/kXEHbg [01:17:24] Commons-iOS/master 1a2a5b2 Brion Vibber: drop the empty blank toolbar on uploads view [01:17:54] so does that mean no uploads in stable tomorrow? :( [01:17:58] it seems so [01:19:26] that sucks [01:20:11] I'm looking at git log, actually I see MaxSem reverted this commit [01:20:20] MaxSem, what was the problem with it? [01:20:25] I can not figure out how to take a screenshot on nexus 4 [01:20:35] well, on the plus side, that means we might release both upload workflows (lead image and left nav) in the same day [01:22:13] this page says power+volume down should do it [01:22:14] http://support.google.com/nexus/bin/answer.py?hl=en&answer=2809823 [01:22:55] ok, you have to hold the buttons for a second or two :) [01:23:27] jgonera: i'm not sure if same MaxSem saw but i was seeing something missing mw.util [01:23:27] saw on both firefox and chrome [01:24:32] ""Exception thrown by mobile.stable: mw.util is undefined"" [01:25:16] is your mw core up to date? [01:25:29] where exactly does it happen? [01:25:31] was this morning [01:26:02] I can't reproduce that [01:26:23] moment [01:27:01] jgonera: if ( !validNamespace || mw.util.getParamValue( 'action' ) || !needsPhoto( $( '#content' ) ) ) { [01:27:08] in mf-photo.js [01:27:28] but what page do you access to get an error? [01:27:42] http://hawkeye.local/core/index.php/Main_Page?debug=true [01:27:43] just a page without a photo? [01:28:01] that's weird, I'm not getting any errors [01:28:02] or http://hawkeye.local/core/index.php/US_states [01:42:58] New patchset: JGonera; "Move lead photo upload to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50867 [01:43:56] Maryana, you can lobby for including https://gerrit.wikimedia.org/r/#/c/50867/ in tomorrow's deployment if it works for MaxSem now [01:44:06] yes!! [01:44:21] does it work for maxsem? [01:45:04] haha [01:45:08] heh [01:45:25] maxsem leaves dramatically [01:45:40] i'll send an email [01:45:46] ok [01:48:50] i'm not sure how deployment is going to work tomorrow with michelle traveling… hopefully arthur feels better, at least! [01:49:03] this feels like 10 little indians. soon it'll only be you and me, jgonera [01:49:05] and yuvi :) [01:49:20] eh... [01:49:43] I'm going home now too [01:52:49] and then there was 1 [01:52:58] submitted a couple of bugs, https://bugzilla.wikimedia.org/show_bug.cgi?id=45408 and https://bugzilla.wikimedia.org/show_bug.cgi?id=45407 [01:53:02] ok, have a good night, jgonera [01:53:06] (for android commons app) [01:53:17] thanks, zeljkof! [01:53:40] Maryana: I am glad I could help :) [01:53:49] andre__: are you in the office? [01:54:04] andre__: we will probably get some food/beer soon [01:54:30] andre__: never mind, I just saw you :) [01:54:33] zeljkof, yes, but on the leave. Plus got a last meeting (hangout) at 19:30h so I probably won't join :-/ [01:55:59] good night, Maryana (well, evening) [01:56:13] you too. see you tomorrow! [02:43:41] New review: Brion VIBBER; "Confirmed works on my test setup!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50867 [02:43:43] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50867 [16:36:02] Interesting discussion about Commons upload at https://commons.wikimedia.org/wiki/Commons:Village_pump#Help_test_out_new_mobile_upload_features [16:36:16] I will create a bug report to discuss further if nobody has done this before [16:39:14] qgil: looking [16:39:59] qgil: ther was a work item for porting UploadWizard tutorial to mobile [16:40:02] will create a bug and respond there [16:40:22] qgil: thanks for pointing me to it :) [17:17:40] jdlrobson: wow. you are back. [17:17:43] :D [17:18:04] jdlrobson: welcome back :) [17:18:11] thanx :d [17:18:21] it's cold here.. [17:18:30] jdlrobson: I know that feeling! :P [17:18:51] New review: Jdlrobson; "This makes me very happy." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/49076 [17:19:34] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50850 [17:21:10] hey jdlrobson [17:22:44] hey MaxSem :D [17:23:02] i saw you've got holiday planned yourself soon - are you going to go anywhere or stay at home? [17:23:15] Europe [17:23:24] Denmark --> Germany [17:23:30] MaxSem: ping? [17:23:34] nice [17:23:37] New patchset: Jdlrobson; "fix typo breaking languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50919 [17:23:40] where in Denmark where in Germany? [17:23:53] Copenhagen, Hmburg Bremen [17:24:06] and where were you? [17:24:27] GrumpyPanda, ? [17:24:42] MaxSem: I'm just curious. What do you think of the suggestion to deploy wikibase on commons? :P [17:24:52] (for our File Meta data RFC) [17:24:57] that's a question for aude [17:25:16] New patchset: Jdlrobson; "Fix watchlist query for users without rollback when PageImages extension enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50810 [17:25:36] ^ MaxSem changed commit message [17:25:37] jdlrobson, I was working on the same fix [17:25:48] MaxSem: I love Copenhagen - remind me do you drink coffee? [17:25:58] I do [17:26:01] Coffee Collective in Copenhagen does the best coffee in the world [17:26:09] http://www.coffeecollective.dk/ [17:26:34] (imo) [17:27:11] awjr_away, are you away today? [17:27:18] https://en.m.wikipedia.org/wiki/Unusually_shaped_vegetable < I wish this had a PageImage :( [17:31:06] * aude hides :) [17:31:43] it's a question for the commons community (and maybe denny) [17:32:13] and to make sure the repo and client work nicely on a single instance, might require a little more work to support [17:32:46] hmm [17:32:57] New patchset: Jdlrobson; "locally track languages the reader can speak (alpha)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/43002 [17:32:58] MaxSem: are you coming to berlin? [17:33:00] but there would still need to be a way to 'import' data from current things into the instance [17:33:07] aude, Y U NO WANT TSHIRT BTW? [17:33:22] huh? [17:33:22] Berlin? you mean Amsterdam? [17:33:32] It's all the same [17:33:43] aude, seen my email about tshirt sizes? [17:33:46] MaxSem: amsterdam too, but i'd think you'd be welcome at our office [17:33:50] MaxSem: no [17:34:00] * aude been on vacation and probably missed some emails [17:34:27] dated Feb 21 [17:34:58] "Also, please let me know your T-shirt size:)" [17:36:12] ah, ok [17:36:24] * aude still has time to reply :) [17:48:54] New patchset: Jdlrobson; "Revert damage of a bad merge/rebase" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [17:53:32] question: mobile uploads available to regular users in Wikipedia (not only to Beta mode) - is this happening this week? Today? [17:55:24] qgil_: possibly. there were complications in getting everything merged, but I think they were fixed. [17:55:33] MaxSem: do you know if photo uploads are going to stable today? [17:55:53] lemme see if my revert was reverted:P [17:56:43] Maryana, are there any plans to have a blog post or some significant announcement mixing these mobile web uploads, commons/iOS beta apps etc? [17:58:27] qgil_: I see a draft for a 'photo uploads on mobile web' blog post [17:58:56] GrumpyPanda, yes, we started that and I wanted to make sure whether you were planning something or not [17:59:22] i've got a draft ready for when we push out lead image uploads to the full mobile web (hopefully today) [17:59:40] qgil_: we are supposed to. brion wanted to work on it [17:59:40] Maryana, ok! good to know [18:00:14] New patchset: Jdlrobson; "alpha: slight tweak to tables" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50921 [18:17:10] anyone seen awjr_away today? [18:18:15] hmm... Android does not like very large images. [18:18:23] ragesoss: how large? [18:18:44] 40mb, 16000x10000px [18:18:51] :) [18:18:55] ragesoss: ... [18:18:59] ragesoss: did you try sharing that? :P [18:19:10] to Commons? [18:19:16] yes. [18:19:25] ragesoss: where did it blow up? [18:19:28] technically it should not. [18:19:33] but I have a feeling it did [18:19:35] It crashes Gallery, and anything else I use to try to upload it. [18:19:39] the code is meant to support that scenario. [18:19:44] but it's not Commons fault, I don't think. [18:19:57] Gallery crashes on its own until I delete the file. [18:20:05] ragesoss: heh. [18:20:14] but trying it through file manager and dropbox also failed. [18:20:19] If you find a way to share it it should work fine :) [18:20:25] once I fix a bug [18:20:26] not sure whether it's the image size or file size. [18:22:29] ragesoss: possibly both. [18:22:39] why is everyone so slow coming into today? no brion, juliusz, or awr yet [18:23:05] that's what happens when you get too much of tech together in one town. [18:23:10] hahaha [18:23:23] tfinc: is awjr_away in SF? [18:24:46] tfinc: also thoughts on changing mobile app team weekly sync up to Monday by default? [18:24:48] instead of tuesday? [18:25:23] YuviPanda: lets do it. the only reason it stayed on a tuesday was that the week of the very first meeting monday was a holiday [18:25:30] lol [18:25:31] right [18:25:50] I like consolidating meetings together to give myself large blocks of uninterrupted time on IRC with other tech folks around. [18:25:56] done [18:26:15] tfinc: thanks! [18:26:25] I think we have a 1:1 in a few mins. so see you there [18:26:49] YuviPanda: yup [18:35:07] YuviPanda: I've got a 80mb png uploading now. [18:35:27] I think trying to thumbnail the huge jpg is what chokes Android. [18:35:40] whereas it knows better than to try with the png. [18:37:46] strike that... it actually rendered a successful thumbnail in the upload list during upload. [18:38:05] even though it chokes Commons for thumbnail generation. [18:38:08] :D [18:39:30] http://commons.wikimedia.org/wiki/File:Big_test_file.png [18:40:17] which brings up the point... if my phone can make a thumbnail for that, why can't Commons? [18:44:12] ragesoss: :D [18:45:23] Can someone please answer to iOS willing-to-be testers a https://www.mediawiki.org/wiki/Talk:Mobile_QA/Commons_uploads ? Thank you! [18:51:43] eek ... we have an awjr in the ER [18:52:04] tfinc: ouch! [18:52:05] send him some well wishes when yout get a chance [18:52:15] tfinc: is he okayish? [18:52:36] sadly more migraines [18:53:20] YuviPanda: I managed to get a slightly smaller jpg to start uploading, and now it crashes the app every time I open it. It's still valiantly trying to upload it, though. [18:53:38] ragesoss: sent crash report? [18:53:45] ragesoss: so it uploaded an 80mb png? [18:53:48] it didn't give the dialog. [18:53:55] yes, 80mb png [18:54:08] hmm [18:54:10] so png succeeds [18:54:12] and jpeg crashes? [18:54:19] yes. [18:54:38] I managed to shut off the screen before it crashed, and it looks like this is allowing it to survive and keep uploading. [18:54:53] ragesoss: let me fix that [18:55:18] maybe... [18:55:33] actually, looks like it's hanging on "Starting" [18:56:04] ragesoss: it might just be counting it still... [18:56:12] ragesoss: if it crashes you'll definitely get a dialog [18:56:16] wait, no... [18:56:21] it Failed. [18:56:32] ragesoss: and did not crash? [18:56:38] but then stopped closing to home screen. [18:56:43] and now is uploading. [18:56:49] and now complete. [18:57:00] YuviPanda: brion figured out why one of my non 640 images wasn't showing in the my uploads feed [18:57:06] tfinc: deleted [18:57:06] deleted photo [18:57:14] I saw backscroll (YAY ZNC!) :P [18:57:27] why do we show deleted photos when i can't see the actual photo? [18:57:28] YuviPanda: http://commons.wikimedia.org/wiki/File:Test_big_file.jpeg [18:57:32] ragesoss: win! [18:57:39] tfinc: because we do not know that they are deleted :) [18:57:41] I never got a crash dialog. [18:57:46] ragesoss: so it never crashed [18:57:57] but something went pretty wrong. [18:58:00] ragesoss: or to be accurate, the app never crashed, but the screen did. [18:58:10] yeah. [18:58:10] ragesoss: also, eugh is 'User:null' [18:58:11] :| [18:58:18] YuviPanda: then how does brion filter it out. i don't see it on iOS [18:58:46] * ragesoss is proud for breaking the app. [18:59:00] tfinc: because he uses a different way of retrieving files. I remember I was using it as well, and then something was wrong with that method so I switched. [18:59:03] I'll investigate again. [18:59:18] ragesoss: you only almost broke it - it was still resilient enough to actually upload your file :P [18:59:24] YuviPanda: do we have bug about this/ [18:59:41] nope. I'll file one [18:59:51] I make it do user:null. [18:59:55] that counts as breaking, at the least. [19:00:00] ragesoss: ah that is true yes [19:00:01] ragesoss: file bug? [19:00:23] will do. [19:00:51] I wonder of User:null is related to redoing a failed upload, or something else. [19:00:53] tfinc: talking to victor over email about the App. He is incredibly excited about this one's potential for storytelling. [19:01:02] ragesoss: possible. [19:01:11] YuviPanda: perfect. i want him to talk the app up whenever he can [19:01:26] I'll file one for null, and one for the large-jpg-choking issue. [19:01:39] YuviPanda: i have to hold myself back from wanting to do browse because i think commons will look stunning on a 10 inch tablet with it [19:01:55] tfinc: I have to too. [19:02:05] ragesoss: yup! [19:02:13] tfinc: but good thing is, that all the code is reusable. [19:02:16] but were not going to do it yet as our goal is photo contributions not pretty browsing. at least for now [19:02:19] YuviPanda: great [19:02:24] it doesn't care if it is a stream of conributions or random stuff. [19:02:31] tfinc: I think campaigns will be gorgeous :) [19:08:23] hey jcmish [19:08:25] in SF? [19:11:38] YuviPanda: the Play store version has the crash reports too, right? [19:11:44] because that's what I'm using. [19:11:48] ragesoss: yup [19:11:49] it should [19:18:49] YuviPanda: i'm finally getting round to clearing the data of the phone you used in india.. [19:20:25] jdlrobson: whee :) [19:21:05] YuviPanda: down side is i'm getting your gchat messages ;-) [19:21:19] jdlrobson: that... is an interesting down side :P [19:21:19] and you are still logged in on facebook... [19:21:23] good thing i am a nice person :D [19:21:52] jdlrobson: very. That is why it is with you :P [19:22:33] YuviPanda: ok gonna push the button [19:22:37] backup i sent you was fine yes? [19:22:46] okay, bugs filed YuviPanda. [19:22:50] jdlrobson: yeah. should be. [19:23:02] even if it isn't since I have not felt the need to see it so long I doubt I will [19:23:10] k done [19:23:15] whee jdlrobson [19:23:16] thanks :) [19:23:22] dunno why that took me so long.. [19:24:07] jdlrobson: :D [19:24:36] (also, YuviPanda, you saw that I reopened the long load times bug because of the upload count discrepency, right?) [19:24:49] ragesoss: right. I'm unsure how to accurately count as well [19:25:39] jdlrobson: is photo upload going to stable today? [19:26:36] YuviPanda: sounds like it .. but i'm a bit worried [19:26:36] i want to grab Maryana [19:26:43] jdlrobson: worried about? [19:26:53] well.. CORS is being a bitch [19:26:55] hey hey jdlrobson, you back? [19:27:04] Maryana: you upstairs? [19:27:11] i'm on 6 cos all the ops/platform people needed extra desks [19:27:23] yep :) [19:34:10] New patchset: JGonera; "Disable photo upload button on main and protected pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50939 [19:34:33] MaxSem, could you merge ^^^ [19:34:52] It's a small fix, but I think it's important if we don't want the community to get mad [19:35:25] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50939 [19:35:49] jgonera, the check for .thumb is very crude but that's better than nothing [19:36:15] MaxSem, I removed the check for .thumb here, I just check for any img [19:36:28] in #content_0 and if it doesn't exist then in #content [19:54:47] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/UbEr9g [19:54:47] android-commons/master a2f63f1 Matthew Flaschen: Add newlines to Information tag so it is easier to edit. [19:54:47] android-commons/master 542aadd Yuvi Panda: Merge pull request #4 from mattflaschen/informationNewlines... [19:55:15] anyone know when i might be approved to use the beta? [19:55:20] Project Android-Commons (mobile) - Nightly builds build #96: SUCCESS in 37 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/96/ [19:55:20] matthew.flaschen: Add newlines to Information tag so it is easier to edit. [19:56:08] Ktr101: hello! [19:56:10] Ktr101: iOS? [19:56:16] si [19:56:21] Ktr101: brion isn't around yet, I'll make sure you will when he gets in [19:56:25] tfinc: any idea where brion is? [19:56:34] np, thanks! [19:56:38] YuviPanda: let me txt him [19:56:52] tfinc: sweet. [19:57:12] i'm waiting for the day athena comes out [19:57:23] jgonera: did you file a bug about the client ip thing? [19:57:30] it may come out in 2014, at the rate we go, but it would be nice to have [19:57:45] then again, does anyone know when editing capabilities will be added back into the app? [19:57:59] Ktr101: it is already available on the mobile web site [19:58:14] Ktr101: on the app... unsure. [19:58:15] yeah, but it was removed from the iOS app months ago [19:58:18] oh, nvm :D [19:58:25] ori-l, no, I didn't [19:58:39] jgonera: what was the issue, again? [19:58:56] MaxSem: jgonera any chance we can get https://gerrit.wikimedia.org/r/#/c/50919/ into todays deployment.. it's so annoying [19:59:14] jgonera: ohh, you're deploying. we can talk about it later if you want. [19:59:26] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50919 [19:59:26] yo [19:59:40] ori-l, so Jon uploading a photo from Costa Rica had the same IP as me uploading the photo from the office [19:59:48] which I find suspicious ;) [20:00:00] I mean, the clientIp hash [20:00:42] tfinc ping [20:00:46] YuviPanda: brion is in a cab en route to the office. he had muni commute problems [20:00:53] brion: hey brion [20:00:58] Maryana and I ruled out the possibility of Jon hiding for the past three weeks somewhere in the office [20:01:06] did you conquer muni ? [20:01:11] jgonera: hrm; android app or? [20:01:12] brion: Ktr101 was looking for you :) [20:01:18] ori-l, the web site [20:01:20] should be at the office in 10-15 [20:01:29] ori-l: android app doesn't really depend on or use clientIP [20:01:29] brion: thanks [20:01:29] (yet) [20:01:31] (or might ever) [20:01:34] jgonera, ori-l, i still have my suspicions [20:01:50] all those photos he took in costa rica look like they came from the set of "apocalypse now" [20:01:55] oh, ok ;) [20:02:15] ori-l, select * from MobileWebUploads_5246000 where event_pageId = 38639572; [20:02:15] ktr101 what's up [20:02:30] would you be able to approve me for iOS? [20:02:50] jgonera: were either / both of you using the office vpn? [20:03:00] yes did you sign up on test flight from your phone? [20:03:23] I need it to report your devic I'd so I can add you [20:03:34] ori-l, Jon was using a wifi hotspot in Costa Rica, without any VPN, I'm just connected to office wifi [20:04:08] jgonera: OK, i'll file a bug and CC you; will investigate sometime this week. [20:04:27] ok, thanks [20:05:12] New patchset: MaxSem; "Watchlist with PageImages fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50810 [20:05:20] jdlrobson, jgonera ^^^ [20:05:29] we need to deploy it today [20:05:35] ok, checking [20:06:30] brion: about two hours ago [20:06:42] jdlrobson, jgonera, so it's 14 out of 37 users who hit that login bug [20:06:58] 24 is the total number of login errors, presumably from people retrying [20:06:58] :( [20:06:59] great I'll update the build as soon as I get to the office [20:07:16] that's bad, but not 20 out of 30 bad, at least [20:07:26] it's about 38% [20:10:14] OK irc is running down my phone battery I'll be back online in a few :) [20:12:28] New review: JGonera; "I didn't analyse the code very closely, but it works for me." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/50810 [20:18:04] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50810 [20:20:17] Change abandoned: Jdlrobson; "Abandoning based on above comments." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50313 [20:20:24] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50313 [20:26:06] howdy [20:26:11] yo [20:30:03] hey brion [20:30:08] yo YuviPanda [20:30:14] brion: code review? :P [20:30:23] moment, pushing an update to iOS beta [20:30:27] okay [20:30:28] :) [20:31:20] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/7zhGWQ [20:31:20] Commons-iOS/master 3623640 Brion Vibber: bump version to 0.12 [20:42:34] MaxSem: I need admin again on staging.wmflabs so I can upload photos … is this something I can do myself? [20:42:54] you already have it... [20:43:00] what's the problem? [20:43:19] hmmm just tried to upload from my phone and received "Error try again" [20:45:08] try uploading from the desktop UI to verify [20:45:14] k [20:45:31] but permissions don't tend to rot off by themselves [20:45:52] yeah I wondered if it reset for some reason [20:46:03] was worth asking let me try it from the desktop [20:50:57] MaxSem: update on Commons GeoData? [20:51:06] see yourself [20:51:14] shoulkd be mostly ok [20:51:15] ... [20:51:23] I can see the tables myself? [20:54:43] no;) [20:54:54] all right, DEPLOYMENT TIME [20:55:23] * MaxSem summons his minions [20:57:07] note to myself: previous production branch was at ab1564a5c26897fd13f85f5fb621b7fd89225c8e [20:58:45] * Maryana_brb + her sandwich relocates to 3 [20:59:04] Maryana_brb, war room? [20:59:09] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/7dqypg [20:59:09] android-commons/master 7ee89db YuviPanda: Minor update to iml file [20:59:09] android-commons/master df95f47 YuviPanda: (Bug 45404) Add {{subst:unc}} to all uploads [20:59:22] yep :) [21:01:31] Project Android-Commons (mobile) - Nightly builds build #97: SUCCESS in 1 min 12 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/97/ [21:01:32] * yuvipanda: Minor update to iml file [21:01:32] * yuvipanda: (Bug 45404) Add {{subst:unc}} to all uploads [21:03:21] anyone know why it's conking out at 6/7th's download? [21:03:44] Ktr101: ? [21:03:55] i can't download it fully [21:04:02] the app? [21:04:04] oops, sorry for not specifying the commons app [21:04:05] yeah [21:04:31] hmmm it installs ok on my devices... [21:04:42] it's offering you the "install" button and you're pushing it and it's getting partway through installation? [21:04:47] or some other err? [21:05:35] yeo [21:05:38] yep [21:05:41] "unable to install" [21:06:09] :( hmmm [21:06:13] jcmish_grabbing, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [21:06:25] k k [21:06:38] on it [21:06:55] Ktr101: is it failing to install the mobileprovision keys or the actual app? [21:07:04] MaxSem: Maryana what are we deploying today? [21:07:17] actual app [21:07:25] lead image to stable, image categories [21:07:27] MobileFrontend, jdlrobson:P [21:07:36] is there a deploy note? [21:07:56] and login/signup messaging ("log in to watch articles," etc.) [21:08:03] it says i can't download the application [21:08:06] not sure - i'm just looking at mingle [21:08:10] jdlrobson, read your email [21:08:22] it installs right up until "Commons" appears as the name, tshen quit [21:08:53] MaxSem: i've got 235 unread email :( [21:09:50] Ktr101: ok lemme double-check the build settings [21:09:58] i can't seem to find a testwiki article that lacks images [21:10:08] according to our criteria, anyway [21:13:31] Ktr101: ok try again, it should offer you an 0.13 version build [21:13:40] see if that works, i think i signed it correctly this time :) [21:15:08] ori-l, how do I check if EventLogging is still live on test.m? [21:15:44] got it! [21:15:46] thanks [21:15:50] \o/ yay [21:15:54] thanks for testing Ktr101 :D [21:19:02] so, i just uploaded an image, and nothing has appeared on commons [21:19:19] is it waiting somewhere in a queue? [21:20:49] Ktr101: check on test.wikipedia.org [21:21:05] there's a switch in settings to pick between test.wikipedia and real commons [21:21:12] you can flip that at any time [21:21:43] ah [21:21:51] of course :) [21:21:59] in future i'll change the default to commons :) [21:22:23] is where an easy way to move it to commons? [21:22:32] easy way… upload it again :) [21:22:43] anything you take with the camera is saved to your photo library, so you can reselect it [21:23:24] non beta on test wiki looks good on to beta then alpha [21:24:15] true [21:25:04] yuvipanda when do we get a switch like that? [21:25:18] ragesoss: tht's gonna be a bit hard... [21:25:29] i'm off, but i will definitely be back to debug later [21:25:32] thanks for the help! [21:25:40] :) [21:25:42] ragesoss: how high priority would that be, really? [21:26:39] I just don't like iPeople having features I don't. matter of principle. [21:26:57] :p [21:26:58] ragesoss: I know exactly what you mean [21:26:58] hehe [21:26:59] :P [21:27:13] brion: has anyone tried uploading an 80mb PNG over the iOS app yet? [21:27:26] YuviPanda: not yet! we'll see.... [21:27:39] in theory it should work but it's gonna load a lot of stuff into ram [21:27:45] for large videos i'll have to do some refactoring [21:28:06] brion: oh yeh [21:28:07] and video [21:28:16] are we gonna be doing h264 ingestion anytime soon? [21:28:23] from what I know it is no longer a tech decision [21:28:33] brion: can you start that thread somewplace? :) [21:28:36] please say yes. [21:28:57] YuviPanda: baby steps. i've briefly chatted with luis about it :) [21:29:00] yay legal [21:29:08] and?d [21:29:09] and? [21:29:15] and we'll see where it goes... [21:29:42] mainly we have to socialize the idea and i guess get the board to amend our formats policy [21:29:45] :PP [21:29:47] brion: how possible is it? [21:29:56] i hope it's possible [21:29:57] brion: if it isn't, I should start figuring out software encoding on the client [21:30:06] i don't want to have to do software encoding, it's gonna be slow and eat battery [21:30:21] ok, got ubuntu touch running on a nexus4 phone :D [21:31:22] this screen is huge… they need a nexus 3.5 :P [21:32:40] brion: timeline for iOS app store releasee? [21:32:52] ok, so it looks like centralauth is just broken on testwiki [21:33:01] in general [21:33:10] no timeline at this point. we have to get it out of 'beta' first [21:33:11] so we can't test uploads until we push to enwiki [21:33:17] jcmish, maxsem ^ [21:33:18] :( [21:33:27] * Maryana shakes fist at testwiki [21:33:31] hahaha [21:33:37] it'll RUE the day Maryana [21:34:02] Maryana, CentralAuth or CentralAuth in MF? [21:34:53] centralauth in general [21:35:02] we can test upload, we just have to manually log into commons ;) [21:35:14] Brion: whatevs. next time I get a phone I'm going 5+. [21:35:15] what we can't test is if we have a bug in CentraulAuth or not [21:35:39] ragesoss: http://www.theregister.co.uk/2012/02/27/samsung_introduces_10_inch_galaxy_note_smartphone_cum_tablet/ [21:35:41] i tried logging in on desktop testwiki, went to commons, and it didn't remember me [21:38:13] heh. not quite that big. but with a nicer screen, I'd be happy with a Note-sized phone. [21:38:52] apart from the central auth issues [21:38:57] it seems to work [21:40:21] agreed [21:40:31] I just finished my other testing in beta and alpha [21:40:55] but I stayed away from upload since you guys had it covered [21:42:13] yeah, I think we can deploy [21:42:14] we'll do it live: http://www.youtube.com/watch?v=V1M6EYA14eU [21:49:35] MaxSem: ^ are we scapping? [21:51:01] okay [21:53:42] howdy brion. It's even more fun talking to you on IRC when you're only a few aisles over :) [21:55:05] :D [21:55:09] gonna grab some eats, brb [21:55:25] jcmish, block him on his way out! xD [21:55:38] Platonides: he's quick when he's hungry! [22:01:24] Jon, just to let you know, I started working on hamburger standardization + removal of noMargins (Max asked me to), just saying since I can't move it on Mingle yet [22:04:16] hamburger standardization \o/ [22:07:49] jdlrobson, ^^ (I got used to you being offline and typing Jon instead ;) [22:08:12] :D [22:08:16] k [22:10:14] so, there are bugd [22:10:19] bugs [22:11:09] if you cancel an upload, and try to upload, it crashs [22:12:08] brion-lunch: ^ [22:13:38] brion-lunch: can you also respond at https://www.mediawiki.org/wiki/Talk:Mobile_QA/Commons_uploads [22:13:39] ? [22:16:48] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/k95E3A [22:16:48] android-commons/master 12488c0 YuviPanda: Throw if no accounts are found... [22:17:27] Project Android-Commons (mobile) - Nightly builds build #98: SUCCESS in 37 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/98/ [22:17:27] yuvipanda: Throw if no accounts are found [22:20:01] test [22:29:40] can images on commons not be renamed ? [22:30:03] oh wait. i'm just not logged in [22:31:17] MaxSem: what do you mean by 'live'? [22:31:34] ori-l, I mean whether it works [22:31:49] (I did some conf refactoring around that) [22:31:59] YuviPanda: android app is not picking up file moves [22:32:04] iOS works just fine [22:32:17] hey jcmish, what happens to mingle cards after they've been accepted? do they get deleted? [22:32:18] what's the bug on standardizing the list for my uploads [22:32:20] MaxSem: well, EventLogging is inert by itself; you need to specify a schema as a dependency and add it to the page output to actually see something. [22:32:23] i want us to use the same method [22:32:25] brion-lunch: we had a discussion about using ListFiles vs upload log [22:32:28] do you remember why? [22:32:30] … do they go to mingle heaven? [22:32:31] nope Maryana [22:32:37] they just stay in accepted [22:32:50] hrm.. trying to figure out how to change this iteration to current [22:32:55] ahh [22:33:11] tfinc__: there's not one. Feel free to open. [22:33:16] MaxSem: is mobilefrontend enabled on test? [22:33:21] yes [22:33:34] https://test.m.wikipedia.org [22:33:55] YuviPanda: can i just say how much i love the picasa -> gallery -> commons workflow :D [22:34:00] http://commons.wikimedia.org/wiki/File:Paklenica_National_Park_Mountains.jpeg [22:34:04] MaxSem: seems to work; in a JS console, run 'mw.eventLog.schemas' [22:34:08] YuviPanda: yeah pulling from the log will probably get lost on things that have been renamed :( [22:34:19] tfinc__: :D yes, you may :) [22:34:47] YuviPanda: brion is going to add a bug to standardize the pull algorithm. we should use the exact same across platforms. [22:35:47] jcmish, jdlrobson, jgonera, Maryana - we're live, please test once again:) [22:37:01] MaxSem: you can also use generic ResourceLoader functionality to check on the state of any module: mw.loader.getState('ext.eventLogging'), mw.loader.getState('mobile.uploads.schema'), etc. [22:37:06] does that help? [22:37:20] ori-l, thanks [22:41:35] testing now MaxSem [22:41:47] lead image upload works for me! https://en.wikipedia.org/wiki/Lotus_Ware [22:42:43] brion: pass me the bug number and i'll add this use case [22:42:49] moment [22:42:51] for the my upload list [22:42:53] k [22:44:14] YuviPanda: sadness that i can't seem my newest upload on the tab10.1 due to file move [22:44:39] too much happiness is bad for health [22:44:40] :P [22:45:01] tfinc__: https://bugzilla.wikimedia.org/show_bug.cgi?id=45454 [22:45:37] brion: nice. you captured what i saw well [22:48:03] brion: tfinc__ I just grepped through the logs and found out why I used upload/upload than whatever method brion is using [22:48:22] tfinc__: if I make an edit to your file, it will disappear from your contributions on iOS now [22:48:29] (as in, someone not you) [22:48:41] that is because page image table IIRC records only the last user who updates the file [22:48:42] http://commons.wikimedia.org/wiki/File:Acireale,_Piazza_Duomo.jpeg nice [22:48:57] brion: ^ [22:49:03] so dumb [22:49:10] when i simply just want to see the photos i've added [22:49:23] Mediawiki is, yes. [22:52:31] tfinc__: can you refresh on iOS? [22:52:35] tfinc__: you should not be able to see https://commons.wikimedia.org/wiki/File:Citation_needed_stickers.jpeg [22:53:37] YuviPanda: my stickers!?! you took my precious. i must have the precious back. [22:53:45] tfinc__: did you try? [22:53:56] confirmed as gone from my feed [22:53:59] I only re-uploaded the exact same file. [22:54:06] so dumb [22:54:10] tfinc__: this is much harder to track than moved / deleted files [22:54:26] so that's things that I'll be fixing on Android soonish. [22:54:28] back [22:54:32] in cases like this id just want to see the latest upload given that file name [22:54:34] even if its not mine [22:54:40] tfinc__: yes exactly [22:54:43] that is what android does [22:55:11] maxsem, still there? [22:55:14] MaxSem: we've found an issue with edit tags [22:56:02] tfinc__: if I could have used the method brion uses, then the '640px images missing' bug would also be gone. [22:56:07] alas, Mediawiki is... [22:56:25] MW needs to evolve to service its users [22:56:29] it's a silly place ;) [22:56:35] just like camelot [22:56:48] we use up lots of ram-a-lot [22:56:50] * YuviPanda contemplates emptying out tfinc__'s iOS 'My contributions' by writing a script to 'touch' all his contribs [22:56:50] :P [22:57:04] heh [22:57:16] jdlrobson, http://www.mediawiki.org/wiki/API:Edit [22:57:21] I think deleted images have to 'go' [22:57:32] and moved images have to be replaced [22:57:32] * tfinc looks at HR and mentions Yuvi 'touching' his things  [22:57:41] yes [22:57:52] jdlrobson, yes? [22:58:05] ok 'oldimage' table appears to have an index on (oi_user_text,oi_timestamp) that could be used to pull old items in order [22:58:14] MaxSem: did the api change recently? We are using "comment" rather than "summary" to send the edit summary [22:58:16] we could in theory do a query on image and a query on oldimage and merge them together [22:58:32] tfinc: https://en.wikipedia.org/wiki/Touch_(Unix)#History not my fault [22:58:37] might have to add to the api though, not sure if we expose oldimage for the right queries [22:59:02] brion: there is an easier way [22:59:03] I think [22:59:18] track delete/delete and delete/move? [22:59:19] oh [22:59:20] no [22:59:21] that won't work [22:59:26] you are not going to be the mover [22:59:27] right [22:59:30] YuviPanda: and soon your going to tell me that time started in 1970 ... dont make up lies yuvi [22:59:40] tfinc: time didn't start in 1970. [22:59:46] non-negative time started in 1970 [22:59:46] :P [22:59:47] ugh [22:59:52] what "comment"? [22:59:53] hehe [23:00:03] there was always summary... [23:00:06] everything before 1970 is just sample data that came with our history books [23:00:37] but more questions! [23:00:42] if i modified a file [23:00:46] but didn't originally upload it [23:00:50] should it turn up in my stream *at all*? [23:01:10] i would get annoyed at that [23:01:16] +1 on that [23:01:21] query=allimages fails that too [23:01:22] New patchset: JGonera; "Fix no edit comment after adding image to article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51053 [23:01:26] because suddenly all my rotate bot changes would show up [23:01:30] MaxSem, ^ [23:01:31] and i hate that [23:01:34] tfinc: yeah, me too. [23:01:43] MaxSem: comment seems to have worked previously but not any more.. [23:01:43] I have a few hundred 'cropping' edits [23:01:47] i don't want them showing up [23:01:59] tfinc: wait, don't they currently show up in the iOS app? [23:02:10] they should, unless someone overrotated your rotate changs [23:02:23] now, as long as images get renamed _with redirects_ renaming shouldn't cause us too much trouble if we fetch the image via api imageinfo [23:02:23] we *will* not have those show up [23:02:33] if the redirects are deleted, not much to do :( [23:02:48] tfinc: yes. [23:03:08] brion: oveerwrites are the problem. [23:03:22] brion: if we can figure out how to deal with them right this gets solved, I think [23:03:26] hmm [23:03:26] hmmm [23:03:27] or not [23:03:35] well if we just show the latest version, assuming it's a new version…. is that ok? [23:03:45] I think that is expected [23:03:49] jdlrobson, ah. edit != upload [23:03:50] as long as we do show [23:03:58] that's why I didn't understand [23:04:39] yeah it's upload/reupload in the log i think, instead of upload/upload [23:06:06] hi YuviPanda I'm getting many "Failed" images with the Android app [23:06:32] YuviPanda, I wish I know how to report this properly, as I can't find a pattern [23:07:05] it seems that the pics at the queue eventually make it to Commons: http://commons.wikimedia.org/wiki/File:Testing.jpeg [23:07:16] damn can't use logevents as a generator [23:07:28] brion: yup, already tried [23:07:36] YuviPanda, these pics were "Failed" until somehow they alone made it to Commons, as I was trying to upload new picds [23:07:41] qgil: that is weird. [23:07:49] jdlrobson, do we need to deploy https://gerrit.wikimedia.org/r/#/c/51053/ ? [23:08:05] YuviPanda: qgil showed me and it seems like some "eventually" make it [23:08:14] so can't tell if it's 'really' slow uploading [23:08:15] YuviPanda, what is also weird is that at http://commons.wikimedia.org/wiki/File:Testing.jpeg two different pics decided to be just one [23:08:21] qgil: I see 3 attempts at an empty file. [23:08:24] filename [23:08:28] one with just a '.' [23:08:29] MaxSem: yes + 1 more patch - give me a few minutes [23:08:36] ok [23:08:38] then the Testing.jpeg file [23:08:41] then two '.' [23:08:46] YuviPanda, yes, I was testing what happens when you post an image without filling anything in title and desc [23:08:55] qgil: yeah, those should fail [23:09:02] MaxSem: could you change $wgMFPhotoUploadEndpoint to include useformat=mobile ? [23:09:03] qgil: I should put a warning. Do file that bug [23:09:05] YuviPanda, then I sarted filling a bit the fields to see what was happening [23:09:18] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=45459 [23:09:18] currently uploads are going via the desktop site and not being mobile tagged.. [23:09:35] New patchset: Jdlrobson; "Bug 45459: Fix no edit comment after adding image to article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51053 [23:09:49] YuviPanda, well, I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=45453 already, if this is what you mean [23:10:01] ah, sorry. haven't been keeping up to date with bugmail [23:10:02] jdlrobson, the endpoint is api.php location [23:10:12] can it be api.php?useformat=mobile please ? [23:10:16] ^ MaxSem [23:10:33] will it work this way? [23:10:45] qgil: re: Description being compulsory... I'm unsure. [23:10:48] if title/desc are required then the user shouldn't even be able to have the upload button enabled [23:10:50] I sortof mostly agree with you. [23:11:06] first step would be to have title have proper validation. [23:11:15] YuviPanda, anyway, if title is required then upload button should be by default disabled [23:11:23] qgil: yeah, filing another bug for that [23:11:23] agreed [23:11:27] jdlrobson, and there's no guarantee that there will always be only POSTs to that URL [23:11:29] for title validation we should also probably check for existing files, and avoid overwriting them [23:11:35] MaxSem: you are right.. don't do that [23:11:39] brion: that is true as well. But that should be another bug [23:11:42] cuz with GET it will break [23:11:43] ok [23:11:49] MaxSem: jgonera is about to submit one more patch [23:12:00] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51053 [23:12:14] ori-l: did I tell you how awesom eventlogging is? [23:12:14] ^ MaxSem this and one more patch should be deployed - waiting on jgonera now [23:12:17] it is very :) [23:12:36] YuviPanda ori-l i can't wait till you 2 are in the same office together - i imagine lots of hugging [23:13:02] New patchset: JGonera; "Fix photo uploads not being marked as mobile edits" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51057 [23:13:06] jdlrobson: :P [23:13:09] heheh [23:13:12] MaxSem, ^ [23:13:24] New patchset: Jdlrobson; "Bug 45459: Fix photo uploads not being marked as mobile edits" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51057 [23:13:30] New patchset: Jdlrobson; "Bug 45459: Fix photo uploads not being marked as mobile edits" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51057 [23:13:33] brion: why does refresh take so long even before any images load? does the feed list take that long to pull ? [23:13:54] tfinc: it's removing all the items _really inefficiently_, i gotta clean it up [23:14:01] tfinc, I saw your comments yesterday about speed. Works fine in my nexus s (when I don't get a Failed) :) [23:14:02] qgil: https://bugzilla.wikimedia.org/show_bug.cgi?id=45460 [23:14:05] lets open a bug for it [23:14:20] qgil: i'm going to blame this specific phone then [23:14:38] tfinc: yeah, it is quite snappy on the underpowered Galaxy Ace (2.3) I test on too [23:15:05] New patchset: Jdlrobson; "Bug 45459: Fix photo uploads not being marked as mobile edits" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51057 [23:15:08] ^ jgonera feel free to +2 [23:15:44] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51057 [23:15:47] MaxSem: can you deploy those 2 changes? [23:15:57] sure [23:16:16] thanks MaxSem you're a star (literally since you seem to be around in the night time a lot..) [23:17:16] jgonera: i'm going to pull you into an app candidate interview on friday [23:17:35] jeez Java doesn't do string switch cases [23:17:46] tfinc, just as a disclaimer, I don't know much about mobile native apps [23:17:48] what a piece of used floss. [23:18:40] just make a HashMap from strings to anonymous inner classes [23:18:47] * brion  [23:18:49] :P [23:18:59] brion: not enough XML [23:19:06] hah [23:19:36] blahorg.wikimedia.commons.item1 [23:20:06] See Also: XSLT [23:20:11] :P [23:21:11] New review: MaxSem; "Breaks thumbs on watchlist - they accidentally worked while they were done with JS but now that they..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/50920 [23:22:25] New review: Jdlrobson; "ahh.. was this removed intentionally then?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [23:22:32] MaxSem: let us know when deployed [23:23:06] brion: how easy is it to get a transition animation from tapping the take photo icon to seeing the two options fly out? [23:23:24] New review: MaxSem; "Yup, I was kinda in a hurry, better break alpha than beta:P" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [23:24:57] tfinc: add it to the backlog, should be doable [23:26:43] done [23:28:02] jcmish: lets do a walking 1:1 its nice outside [23:28:14] plus we can wander to coffee then [23:28:16] so, more bugs [23:28:20] very hilarious bugs [23:28:23] Ktr101: keep them coming [23:28:29] we love our bleeding edge testers [23:28:42] sure tfinc [23:28:53] so, i tried uploading a few, and "cancelled" before "uploading" them [23:28:57] turns out, they uploaded [23:29:28] jdlrobson, deployed [23:30:00] i also tried uploading, and it logged me out, and i can't get back in [23:30:21] http://commons.wikimedia.org/wiki/Special:ListFiles/Ktr101 [23:30:26] bugs \o/ [23:30:50] if you cancel too late in the process it might not fully take [23:31:00] but it seemed to work for me when canceling partway through.... [23:31:05] is it consistent or intermittent? [23:31:11] thanks MaxSem [23:31:13] testing now [23:31:42] brion: I worked around the cancel bug in Android by not having cancel as a feature :P [23:31:43] should add [23:31:47] heh [23:32:05] i uploaded it, pressed "upload", then it prompted me to upload again in the upper right-hand corner [23:32:08] or at least it seems [23:32:13] so, i cancelled, just to test it out [23:32:28] i would then try to upload directly from my files, and it would crash [23:32:31] it did this three times [23:33:00] the three there that aren't numbered [23:33:23] hmm [23:33:27] i then uploaded the wall one under the correct name, and did the station one [23:33:35] it said i wasn't logged in, but apparently i was [23:33:40] when i tried to log back in, i couldn't [23:33:55] so, i closed the app and tried again, to no avail...twice [23:33:57] so, yeah [23:34:06] what sort of error did you get logging back in? [23:35:08] i would "log in" but the button to upload was grey [23:35:32] ok i'll have to fix up the upload button, it might not be updating correctly [23:35:35] maybe that last part was a fluke [23:35:40] but it definitely crashed [23:35:43] if you go into the detail view for an image, does the upload button on that screen work? [23:35:43] i think it was a fluke [23:36:52] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/Ca6l2w [23:36:52] Commons-iOS/master 747d6b3 Brion Vibber: bump profile & ver [23:37:14] MaxSem: mobile edit tagging seems to be broken on en.wiki :( [23:37:20] and commons.. [23:37:28] and everywhere... [23:37:59] yeh i guess ;-) [23:38:00] any idea why? [23:38:16] specifically edits via the api [23:38:29] is there any reason that it isn't uploading a geotag? [23:38:38] i.e., coordinates [23:39:00] Ktr101: we haven't added geotagging yet [23:39:08] could we? [23:39:18] i'm going to do some serious uploading, so it would be nice to have it done soon [23:39:21] if the phone is set to save coords in the camera then you should see it in the exif data (we don't scrub it if it's there) [23:39:34] should be in in a week or two [23:39:40] i can do it faster if you're going to exercise it soon :) [23:39:53] yeah, i didn't realize i'm the only one doing serious uploads [23:40:05] hey, that's how we get Serious Testing :) [23:40:07] Ktr101, if there are GPS coordinates in EXIF, a bot on Commons will slap appropriate templates on it [23:40:12] k [23:41:53] Ktr101: oh -- and if things get too borked, try deleting the app and reinstalling it. it should save your username/password but should reset everything else [23:42:08] MaxSem: any idea about the mobile tagging problem? specifically https://en.wikipedia.org/w/index.php?title=Christ_of_the_Mercy&oldid=540777714 an [23:42:19] MaxSem, any idea why mobile uploads are not tagged as mobile edits in production? [23:42:23] yeah, the coordinates don't save in photostream [23:42:24] bleh [23:42:56] can you guys decide between yourselves who's to ask me?:P [23:46:13] doing copy is so goddamn hard. [23:46:53] MaxSem: so a POST was done to https://commons.wikimedia.org/w/api.php?useformat=mobile&r=0.4395327209495008 and it didn't register as a mobile edit :( [23:46:58] is there any reason that it isn't adding the date of the photo? [23:47:20] ugh [23:47:48] Ktr101: there is a bug for it. I think brion is on it. [23:47:59] yep that's on my list to fix [23:48:29] jdlrobson, action=edit or action=upload? [23:48:29] MaxSem: I'm stumped to why [23:48:40] action=upload [23:49:08] sent in FormData [23:50:00] is there any way that when the file name and description are clicked on, the text vanishes? [23:50:10] it's tough deleting it all [23:51:33] Ktr101: ah yes, i should remove the auto-generated text and just let you type your own [23:51:35] *adds to list* [23:54:59] jcmish: this is the main location http://www.yelp.com/biz/blue-bottle-coffee-san-francisco-8 [23:55:34] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=45459 [23:56:39] jcmish: this is one of my favorites - http://www.yelp.com/biz/sightglass-coffee-san-francisco [23:57:47] jcmish: http://www.yelp.com/biz/bittersweet-the-chocolate-caf%C3%A9-oakland [23:58:59] ah, i asked that :D