[00:01:01] jcmish: https://foursquare.com/v/the-station-sf/5022d17ee4b048003ea684b6 [00:02:16] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/wNJH4Q [00:02:16] android-commons/master f2a3666 YuviPanda: Revert "Throw if no accounts are found"... [00:02:16] android-commons/master b84d003 YuviPanda: (Bug 45370) Improve Error messages on Login Screen [00:02:48] MaxSem: Unrecognized parameters: 'useformat', 'r'" [00:02:54] Project Android-Commons (mobile) - Nightly builds build #99: FAILURE in 24 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/99/ [00:02:54] * yuvipanda: Revert "Throw if no accounts are found" [00:02:55] * yuvipanda: (Bug 45370) Improve Error messages on Login Screen [00:03:07] Can I trick the mobile team somehow into setting the "Priority" field for some of the recent Commons App bug reports, or shall I try my luck? [00:03:13] jdlrobson, nevertheless MobileContext should see it [00:03:17] mm [00:03:22] so what the heck is going on ? :( [00:03:23] andre__: I can go through them and do it for android stuff [00:03:35] andre__: but... is it useful for people? [00:03:42] jdlrobson, I'll investigate tomorrow [00:04:22] thanks MaxSem [00:04:24] sucks though :( [00:07:10] brion: can we also set it up so that if you decide that you don't want an image and go back, it doesn't kick you out of the album? [00:07:26] qgil: https://bugzilla.wikimedia.org/show_bug.cgi?id=45370 [00:07:29] fixed [00:07:32] Ktr101: hmm not sure what you mean? [00:07:37] qgil: though if you could help reword, will be glad :) [00:09:01] must've scared him off [00:11:33] brion: when you click to upload an image, and decide you don't want it, you can go back to "my uploads" [00:11:41] can it be set to go back to that album instead? [00:11:56] MaxSem, do we also want to get rid of $mobileSkin->setHtmlHeader() ? [00:12:01] Ktr101: ah back to the photo library picker? [00:12:03] since it would make more sense to allow for someone to choose another image, than have to have them go find that image if there is a huge file [00:12:04] yeah [00:12:07] sorry, i'm bouncing :D [00:12:09] can't currently but could in future [00:12:20] i'll add a bug with a note to self :D [00:12:29] jgonera, working on it in https://gerrit.wikimedia.org/r/48209 [00:13:38] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/rwdTdA [00:13:38] android-commons/master d0f2c87 YuviPanda: Slightly less awful network failure message [00:13:38] android-commons/master 78ba373 YuviPanda: Do not enable 'Login' button if either password or username is empty [00:13:45] could the image title automatically be capitalized? [00:13:47] Project Android-Commons (mobile) - Nightly builds build #100: STILL FAILING in 12 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/100/ [00:13:48] * yuvipanda: Slightly less awful network failure message [00:13:48] * yuvipanda: Do not enable 'Login' button if either password or username is empty [00:14:03] MaxSem, I feel that we'll be stepping on each other's toes if I'm working on the noMargins and hamburger standardization now, when do you think you might finish this commit, or how much do you think will change from what it is now? [00:14:30] jgonera, probably a lot [00:14:55] I can leave it be for now and resume my work after you're done [00:15:27] MaxSem, ok, lets do it like that then [00:19:07] brion: if you have a shaky finger, it uploads WAY too quickly [00:19:15] i.e. forgetting to title the damn thing [00:19:40] Ktr101: are you hitting 'upload' by accident or is something else triggering it? [00:19:47] accident [00:19:47] easy enough to disable the button until you've typed [00:19:50] *nod* [00:20:05] we might create false names where the image is then on there a few times [00:20:35] yep, i'll clean that up [00:21:08] uh, major issue time [00:21:23] http://commons.wikimedia.org/wiki/File:Deer_Island.jpg you can overwrite anything [00:21:31] heh yeah [00:21:34] that probably should be fixed [00:21:34] let me make a note of that [00:21:59] I wonder how to fix that for now [00:22:10] 'if we run into a conflict, then rename by adding timestamp'? [00:22:27] could add a timestamp, or just prompt to change it [00:22:29] brion: file bugs? [00:22:33] Ktr101: nice work on http://commons.wikimedia.org/wiki/File:World_Bank_waterfall.jpg [00:22:33] checking for conflicts while you type maybe [00:22:38] warn the user first, and then tell them that it should be changed [00:22:42] added https://bugzilla.wikimedia.org/show_bug.cgi?id=45468 [00:22:49] at the same time, it could be overwritten if they are the author [00:23:09] tfinc: thanks, the building is incredibly beautiful and I wish i could have been in more places there since the angles would be gorgeous [00:23:11] brion: that kills battery + network [00:23:24] brion: also how are we going to handle bugs that are common to iOS / Android? [00:23:36] the food there is incredibly cheap as well, and is way better than what you would pay if you payed it at mcdonalds (7 dollars for a burger, drink, cheesecake) [00:23:43] Ktr101: later when campaigns are implemented by YuviPanda you can rally your friends to join in and photograph them all [00:23:50] mmmm campaigns! [00:23:56] so many things to do, so little time [00:24:09] i'm really eager to see what YuviPanda and shankar come up for those designs [00:24:11] YuviPanda: i guess we should file twice, so we can close each separately [00:24:18] brion: +1 [00:24:27] YuviPanda: thats why you have me ruthlessly organizing what should and should not happen now [00:24:37] tfinc: indeed! [00:24:51] tfinc: I'm surprised to count back and note that officially, I've worked only 120 hours on the app :P [00:24:58] (30 * 4) [00:25:02] there's a crapton of security there, so it would require a lot of asking [00:25:21] Ktr101: i'm sure your crafty enough to make it happen [00:25:24] tfinc: campaigns will also most probably require some server side work. [00:25:40] I'll poke at it once I've done a pass over the bugs being reported. [00:25:46] YuviPanda: thats fine. the candidate for apps who were interviewing on Friday has PHP experience [00:25:59] YuviPanda: right now focus on the experience with shankar [00:26:00] niice! [00:26:07] yeah that's what I'm doing [00:26:15] i want people to be able to create AND take part in campagins [00:26:22] we can't just have the latter [00:26:34] currently you need a special right on commons to create campaigns [00:26:51] YuviPanda: i think that's lame and that anyone should be able to create a campaign [00:27:00] campaigns should be time boxed [00:27:03] we'll have to put some time into updating UploadWizard then :) [00:27:10] and should all have owners [00:27:24] brion: thats why flushing out the designs is so important now [00:27:28] brion: isn't UploadCampaigns a different extension? [00:27:37] it'll show us what the underlying necessary tech it [00:28:22] YuviPanda: nope, it's in UW as i recall [00:28:29] ah sweet [00:28:40] Yippie, build fixed! [00:28:40] Project MobileFrontend-linux-android build #254: FIXED in 6 min 13 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/254/ [00:28:50] brion: last time you touched it, IIRC it was... pretty crappy? [00:29:02] i was highly amused talking to howie about all this today. mid way though explaining where the app team was he asked me if i wanted to be a product manager due to how data/user driven i was presenting everything [00:29:04] i was touched :D [00:30:02] :) [00:30:02] brion: when we have no image clicked, maybe the upload thing could open up the file, instead of being a dead button until one is in the queue [00:30:27] hmm. if nothing's clicked, what's to open? [00:30:31] goatse [00:30:34] :P [00:30:38] just saying. [00:31:14] turn it into something that can be used [00:31:21] dunno, it just feels weird [00:31:30] i also instinctively click on the settings when i want to upload [00:32:27] yeah i may switch the settings back to the other corner [00:32:32] or something [00:32:38] it's an iphone habit, actually [00:32:53] it's because of the way it's set up, and the interface coloring is the same, so it's instinct [00:33:07] yup :) [00:33:09] okay dinner, bbl [00:33:14] jgonera, you looking at error messages on stat1? [00:33:19] thanks for the feedback Ktr101 ! enjoy dinner :) [00:33:29] Maryana, from time to time [00:33:41] what on earth is "sucky token"? [00:33:43] np, i'll be back soon [00:33:54] token that sucks. [00:34:18] Maryana, it's Jon trying to break things [00:34:25] oh, haha [00:35:00] I wonder, maybe we should add a field to schema distinguishing staff members [00:35:15] not a bad idea [00:35:20] isWMF [00:35:23] :) [00:35:56] yuvipanda, how are you logging usernames in the apps? [00:36:06] Maryana: I... am logging the username itself. [00:36:24] in plaintext. [00:36:26] but eventlogging can't grab userids that are not enwiki [00:36:31] username [00:36:32] not userid [00:36:39] jcmish: its times like this that i remember that i never have caffeine and how potent a single cup is for me [00:36:54] Maryana: and I have acecss to it because I'm storing username and password locally :) [00:36:57] yuvipanda: i just figured it would be the same problem for username.. hmmm [00:37:00] (in secure Android ways) [00:37:00] oh [00:37:02] YuviPanda: are you simply choosing not to sleep tonight ? [00:37:04] ahh, right right [00:37:06] blah [00:37:09] tfinc: what is this 'night' you speak of? [00:37:21] night is the time where productivity is high and distractions are low [00:37:30] tfinc: I'm switching sleep cycles. SO that I could sleep properly during the day in college on Thursday and Friday [00:37:37] most productive use of time I could think of there. [00:37:41] night is the warm glow of a crt [00:37:45] oh tfinc that's SOO sad [00:38:05] jcmish: this one cup will likely keep me up till the late AM [00:38:09] Maryana: I guess you guys don't have access to usernames? [00:38:16] only enwiki, i think [00:38:45] tfinc: I'm ready for another! [00:38:49] and I'll still sleep tonight [00:38:57] Maryana: heads up that our current app sprint is tackling the analytics dashboard. YuviPanda is point on it [00:39:31] Maryana: when is the blog post going out? [00:39:32] Maryana: really? [00:39:40] mw.config.get("wgUserName") [00:39:40] "Yuvipanda" [00:39:49] Maryana: I just got that on en.m. after logging in [00:39:55] and executing on the console [00:40:08] tfinc: uploads blog post is next week [00:40:26] Maryana: mw.config.get("wgUserId") [00:40:27] works too [00:40:40] it works on enwiki [00:40:43] but not anywhere else [00:40:46] try it on non-enwiki [00:41:17] Maryana: tried on tawiki [00:41:18] works [00:41:52] oh wow! [00:41:55] jgonera ^ [00:41:55] brion: when can we have the app blog post? [00:41:56] that is part of RL's default modules [00:41:59] I don't see why it shouldn't... [00:42:16] when ya want it tfinc ? [00:42:26] brion: http://readwrite.com/2013/02/25/mozillas-firefox-os-smartphones-unveiled-at-mobile-world-congress#feed=/mobile <-- look who's in the highlight shot [00:42:27] YuviPanda: wgUserId is not, I don't think. [00:42:30] well, for userids, there's some dependency on e3 experiments extension, which isn't deployed globally, yuvipanda [00:42:41] ori-l: right. I don't have ID. [00:42:43] but I do have name [00:42:47] Maryana, I'm not sure where I should start reading ;) [00:43:13] oh, sorry :) jgonera: yuvipanda just pointed out that we can log usernames globally. so we can filter out staff usernames.. [00:43:24] userids don't work globally, but usernames do [00:43:36] tfinc: woo that's our icon :D [00:43:40] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/U4c1WQ [00:43:40] Commons-iOS/master 8849240 Brion Vibber: Include date with upload description, using EXIF if possible [00:43:56] Maryana, just looking for (WMF) ? [00:44:06] yep [00:44:18] but do we want to log the user names? what legal would say about that? [00:44:18] or we can all agree to make socks with a certain string in the name or something [00:44:28] heh [00:44:47] Maryana: jgonera is logging user names a problem with legal? (Apps are logging user names). [00:44:48] well, username isn't technically private info... [00:44:58] (and an userid is equivalent, no?) [00:45:18] i have a patch to add userid globally, actually [00:45:18] yuvipanda, no, it's not. we just generally commit to logging as little as possible within reason [00:45:38] right :) [00:45:44] brion: hmm. i want a couple days between apps and mobile web posts. Maryana: what day are you publishing yours ? i'd put it +- 2days from it [00:45:55] got mine scheduled for next wednesday [00:46:08] tfinc: next friday? or hold until monday [00:46:12] brion: so i'd say Monday or Friday [00:46:24] brion: so that depends on how we theme it. YuviPanda was telling me that were short on testers [00:46:37] moar testers plz [00:46:39] brion: which changes the theme to a larger rally of come help us test .. i'd want that on monday [00:46:44] yeah, not as much as I'd want :) [00:46:45] ok [00:46:47] New patchset: Jdlrobson; "bug 45452: Ensure error message appears when a bad token is visible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51079 [00:46:47] New patchset: Jdlrobson; "bug 45452: only show donate image button when token available" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51080 [00:47:03] there should be no reason why we can't get a lot more android testers [00:47:10] tfinc: I'm going to be pushing updates to Google Play every weekend. [00:47:25] until we hit 1.0 [00:47:30] (rather than perpetual beta) [00:47:44] brion: put a place holder on the communications calendar for Monday then [00:47:54] ok [00:47:56] YuviPanda: sure [00:48:19] our goal here is to get feedback and numbers to let us select the next bits from the backlog [00:48:33] tfinc: hmm i see 'communications interns' in calendars but not a 'communications' overall one [00:48:34] in gal [00:48:36] *gcal [00:48:36] The MacBook Air is... just not powerful enough for jaava [00:48:37] grr [00:48:47] Maryana: can you pass brion the calendar? [00:48:50] nothing's powerful enough for java ;) [00:48:56] blog cal? [00:48:59] YuviPanda: nothing is powerful enough for java [00:49:05] heh [00:49:05] Maryana: the one for scheduling [00:49:06] jinx :) [00:49:18] * tfinc sneers at brion [00:49:19] http://meta.wikimedia.org/wiki/Wikimedia_Blog/Calendar [00:49:21] brion: tfinc my legs are literally being burnt. [00:49:25] and things are setill slow. [00:49:27] grrr [00:49:30] brion, just pencil yourself in somewhere on there ^ [00:49:42] for the first time, this was a problem PhoneGap did not have - I could always edit in Vim [00:49:43] YuviPanda: wear pants so that doesn't happen [00:49:52] ah goodie [00:49:55] tfinc: it burns through pants, a laptop cover, and even some little cardboard [00:50:04] then all hope is lost [00:50:07] yes. [00:51:33] ok added in https://meta.wikimedia.org/wiki/Wikimedia_Blog/Calendar#March_2013 [00:52:07] New patchset: Zfilipin; "adding watchlist behavoir when logged out" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47330 [00:53:40] Change merged: Zfilipin; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47330 [00:57:40] The MacBook Air is... just not powerful enough for jaava [00:57:48] are you sure it's not just the ask toolbar that is being a resource hog? [00:57:56] * ori-l ducks. [00:58:21] ori-l: would you rather fight a horse sized duck or a hundred duck sized horses? [00:58:42] the former, I think [00:59:07] Really? wouldn't the bill be powerful enough to crush you? [01:03:13] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/NBU5Mg [01:03:13] Commons-iOS/master 4d40be0 Brion Vibber: Partial disable of deleting during upload bug... [01:03:27] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/CYvKhw [01:03:27] android-commons/master 61ed62c YuviPanda: (Bug 45453) Make Title required in Share dialog [01:03:33] Project MobileFrontend-mac-iphone build #261: FAILURE in 9 min 6 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/261/ [01:03:34] zeljko.filipin: adding watchlist behavoir when logged out [01:03:36] Project Android-Commons (mobile) - Nightly builds build #101: STILL FAILING in 16 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/101/ [01:03:36] yuvipanda: (Bug 45453) Make Title required in Share dialog [01:03:57] Project MobileFrontend-linux-android build #255: SUCCESS in 8 min 50 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/255/ [01:03:58] zeljko.filipin: adding watchlist behavoir when logged out [01:05:33] yuvipanda I don't know the answer to your campaign question. [01:06:39] New patchset: Jdlrobson; "regression: make nearby work again (dependency fix)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51082 [01:07:31] qgil_: I received UUIDs for 2 of the users on the discussion page and brion added them so the next iOS build will be available to them [01:07:42] I'm waiting to hear back from only 1 person [01:08:32] New patchset: Jdlrobson; "bug 45449 regression: fix diff dependencies" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51083 [01:08:58] New patchset: Jdlrobson; "bug 45462: correct nearby dependencies (regression)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51082 [01:12:41] Project MobileFrontend-mac-ipad build #254: FAILURE in 9 min 7 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/254/ [01:12:41] zeljko.filipin: adding watchlist behavoir when logged out [01:13:52] [ERROR] Failed to execute goal on project commons: Could not resolve dependencies for project org.wikimedia:commons:apk:1.0-SNAPSHOT: Could not find artifact com.google.android:support-v4:jar:r11 in yuvi.in (http://yuvi.in/blog/maven) -> [Help 1] [01:13:55] hmm [01:13:56] New patchset: Zfilipin; "Feature: Manage Watchlist, Scenario: Login link leads to login page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51084 [01:13:56] New patchset: Zfilipin; "Feature: Manage Watchlist, Scenario: Sign up link leads to Sign up page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51085 [01:14:54] brion: hmm [01:15:02] brion: let me publish that [01:15:05] in a bit [01:15:07] ok [01:15:55] Change abandoned: Zfilipin; "Implemented at https://gerrit.wikimedia.org/r/#/c/51085/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47694 [01:16:19] YuviPanda, Re "Is Prio useful to people": Don't know... if Mobile team doesn't use the Priority field at all it's probably not. But so far I didn't have the impression that it's not used :) [01:16:27] maybe I should set up a meeting with mobile here. [01:16:55] andre__: possibly. Mobile Apps team is just me and brion (and tfinc to an extent) at the moment. [01:17:09] and the pri field is usaully set by other people - we don't really use it. [01:17:24] andre__: I'll also note that this team is only 4 weeks old, so not a lot of things are in place fully :) [01:17:27] YuviPanda: that's very helpful to know. [01:17:38] YuviPanda, wondering how you track priorities then [01:17:53] andre__: https://mediawiki.org/wiki/Apps/Commons [01:18:15] New patchset: Zfilipin; "Fixed HomePage URL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51086 [01:18:27] bugs from me: Highest. [01:18:40] bugs from others: Low [01:18:49] YuviPanda: I don't see specific bug reports mentioned on that page :) [01:19:06] andre__: that is because we started using bugzilla actively only starting... yesterday. [01:19:07] ragesoss: hehe, alright! [01:19:20] YuviPanda, uh ah. Ok, suddenly all makes sense :) [01:19:21] (yesterday was also our first release) [01:19:38] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51086 [01:19:51] (for some definition of release) [01:20:03] andre__: :D [01:20:26] YuviPanda: then we should probably talk, to make sure you get the best out of Bugzilla [01:20:29] * andre__ considers slapping himself for marketing speech [01:20:37] :D sure! [01:20:50] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51084 [01:20:58] andre__: a fair amount of people are reporting bugs now - either directly on BZ, or on IRC, or through the 'crash report email' feature. [01:21:13] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51085 [01:21:18] andre__: I file them all in bugzilla, de-dupe them and then work on them (along with brion) [01:21:27] andre__: I am on default CC for all bugs there, so get to them relatively fast. [01:21:57] andre__: the only problem we've discovered is that a lot of bugs are common to iOS and Android, but require completely different implementations and hence different people closing them at different times [01:22:01] and are not sure how exactly to handle that [01:22:40] New patchset: Jdlrobson; "bug 44806: style all pre and code tags" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51088 [01:23:03] YuviPanda, I see. I'm really interested to hear about such problems and trying to find an acceptable solution or workaround for you, so let me think about that one [01:23:30] andre__: :) The 'solution' we came to was to file every bug twice. And of course, everyone forgets to do this :P [01:23:32] not good [01:24:41] YuviPanda, there's several ways to approach this, this is one of them [01:25:44] but let me come back to you tomorrow or so [01:26:02] andre__: sure! :) [01:26:28] New patchset: Jdlrobson; "bug 44965: no longer lowercase save settings button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51089 [01:28:49] Yippie, build fixed! [01:28:49] Project MobileFrontend-mac-ipad build #255: FIXED in 8 min 20 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/255/ [01:28:50] zeljko.filipin: Fixed HomePage URL [01:29:31] testing: see if i can overwrite protected images [01:29:55] thank god i can't [01:30:13] probably should have a note about that, brion [01:30:56] Ktr101: once we fix the overwrite problem that shouldn't turn up as a case :) [01:31:14] naw, i can't overwrite protected images [01:31:23] featured images on the other hand, those can be vandalized :D [01:31:55] New patchset: Zfilipin; "Cleanup: deleted unused file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51091 [01:31:56] New patchset: Zfilipin; "Fixed page URL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51092 [01:32:31] Yippie, build fixed! [01:32:32] Project MobileFrontend-mac-iphone build #262: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/262/ [01:32:32] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Login link leads to login page [01:32:33] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Sign up link leads to Sign up page [01:32:33] * zeljko.filipin: Fixed HomePage URL [01:32:50] brion: how do you like the nexus4 ? [01:32:52] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51091 [01:33:33] tfinc: hardware seems nice; if i get bored of ubuntu i might switch it back to android and make it my main phone :) [01:33:35] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51092 [01:36:05] brion: any way to set it so that it will let you know if you'll upload a duplicate image? [01:36:38] Project MobileFrontend-mac-ipad build #256: FAILURE in 4 min 7 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/256/ [01:36:39] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Login link leads to login page [01:36:39] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Sign up link leads to Sign up page [01:37:49] New patchset: Jdlrobson; "bug 45137: Kill close this section in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51094 [01:38:15] Project MobileFrontend-linux-android build #256: SUCCESS in 9 min 26 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/256/ [01:38:16] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Login link leads to login page [01:38:16] * zeljko.filipin: Feature: Manage Watchlist, Scenario: Sign up link leads to Sign up page [01:38:17] * zeljko.filipin: Fixed HomePage URL [01:38:57] Ktr101: hmm, i'll add it to our backlog and consider ways [01:39:08] if it's the exact same image we should be able to detect dupes easily [01:39:12] from sha1 hash of the file [01:39:34] i just uploaded File:Barnstable Town Hall [01:39:40] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/dkgYCw [01:39:40] android-commons/master 0582895 YuviPanda: (Bug 45472) Consider network failure during a sync request a 'soft'... [01:39:41] Project Android-Commons (mobile) - Nightly builds build #102: STILL FAILING in 14 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/102/ [01:39:41] yuvipanda: (Bug 45472) Consider network failure during a sync request a 'soft' [01:39:42] brion: the crash you had has just been fixed. ^ [01:39:46] i had the name and description there, but neither uploaded [01:39:47] \o/ [01:40:46] Project MobileFrontend-mac-iphone build #263: FAILURE in 4 min 7 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/263/ [01:40:47] * zeljko.filipin: Cleanup: deleted unused file [01:40:47] * zeljko.filipin: Fixed page URL [01:42:03] Project MobileFrontend-mac-ipad build #257: STILL FAILING in 3 min 47 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/257/ [01:42:03] * zeljko.filipin: Cleanup: deleted unused file [01:42:04] * zeljko.filipin: Fixed page URL [01:43:26] brion: when you try to go back, the upload bar goes but nothing uploads [01:43:30] from the image upload, that is [01:44:00] Project MobileFrontend-linux-android build #257: FAILURE in 3 min 13 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/257/ [01:44:00] hm [01:44:01] * zeljko.filipin: Cleanup: deleted unused file [01:44:01] * zeljko.filipin: Fixed page URL [01:45:00] i had two in the queue [01:45:14] weird [01:45:20] yeah, going back uploaded that image [01:50:56] brion: https://play.google.com/store/devices/details/Nexus_4_Wireless_Charger?id=nexus_4_wireless_charger&feature=accessories#?t=W251bGwsMSwyLDExMSwiZGV2aWNlLW5leHVzXzRfd2lyZWxlc3NfY2hhcmdlciJd [01:52:30] tfinc: all you people with online stores that ship most things to you make mea ll jealous [01:53:23] YuviPanda: graduate and you too can benefit from this [01:53:29] who would've thought [01:56:03] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/NDrTpQ [01:56:03] Commons-iOS/master b1c3447 Brion Vibber: Adjust settings/login screen to better match Android... [01:59:35] Project Android-Commons (mobile) - Nightly builds build #103: STILL FAILING in 11 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/103/ [01:59:36] yuvipanda: (Bug 45393) Replace login subtitle with just the app name [01:59:38] brion: would it be crazy to wish for a way to auto-link to -en on these descriptions? [01:59:40] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/NvT5og [01:59:40] android-commons/master 0ecbe5c YuviPanda: (Bug 45393) Replace login subtitle with just the app name [02:00:40] New patchset: JGonera; "Remove noMargins and the need for addArticleClass()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51095 [02:00:41] New patchset: JGonera; "Standardize the hamburger and remove isOverlay (#375)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51096 [02:01:43] Ktr101: you can already use [[en:fafda]] manually :P [02:01:59] but I thinkh aving it work like how '@' autocomplete on twitter works would be nice [02:05:14] yeah, because that would make sense :D [02:05:22] Ktr101: yup! [02:05:27] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/QhXb7Q [02:05:27] android-commons/master 9aebac8 YuviPanda: (Bug 45360) Restrict file names to 2 lines at most [02:05:29] i've already recruited my sister as a beta tester in two and a half weeks [02:05:34] Ktr101: whee! [02:05:35] Project Android-Commons (mobile) - Nightly builds build #104: STILL FAILING in 12 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/104/ [02:05:35] yuvipanda: (Bug 45360) Restrict file names to 2 lines at most [02:05:37] Ktr101: but all iOS? [02:05:42] yeah [02:05:49] but i mean, she's the average person [02:06:01] it would be more to see if an average person can navigate us [02:06:13] Ktr101: true [02:06:27] Ktr101: I think primary problem of Commons and Average people is the concept of copyright [02:11:56] yeah [02:12:06] i hate how we only have one copyright tag available here though [02:12:09] for commons app [02:12:18] Ktr101: ? [02:12:22] one copyright tag? [02:14:00] all cc-by-sa 3.0 [02:14:18] which means that screenshots of GPL apps are going to be uploaded with the wrong license. [02:15:24] ...oh dear [02:16:06] a relatively minor issue. [02:16:07] ragesoss: don't really want to inundate people with 20 different licenses [02:16:14] agreed. [02:16:51] I did have to go and change the license on my upload in that situation, though. [02:16:54] :) [02:17:12] ragesoss: true. And I guess that's fine? [02:17:32] better than the alternative. [02:18:13] later on, it *might* be worth adding a per-image option for alternative licenses. Like, an Advanced field after Description that you have to enable in Settings. [02:18:55] since the trend will continue to be more people using mobile OSes in hybrid situations as their main computer. [02:18:56] ragesoss: description will possibly go away soon. [02:19:00] ragesoss: or rather, 'move' [02:19:13] ragesoss: you can type title, hit enter. [02:19:20] then there will be a screen where you can add all your other info [02:19:24] and then add description and other info after upload? [02:19:25] (Desc, Cat, Geo) [02:19:40] or before upload? [02:19:45] after [02:19:48] but in the same 'workflow' [02:19:59] you hit the upload button, and then can do this [02:20:04] (optional) [02:20:11] and can you go back and also add info for previous uploads? [02:20:19] ragesoss: hmm, no. that's going to be hard. [02:20:25] since that means I'll have to parse {{Information}} [02:20:36] I'll have to 'round trip' (aka not lose any info while editing) [02:20:40] that's gonna be hard [02:20:46] ragesoss: how useful would it be? [02:20:48] so, after upload, but before it gets out of the wizard-style holding zone. [02:20:53] ragesoss: I'll probably add categorization [02:21:21] ragesoss: sortof, yes. [02:21:34] ragesoss: mobile as acquisition now. [02:21:36] curation later [02:21:50] * ragesoss nods. [02:22:25] * ragesoss wants an endless stream of random images to rate from one to five stars on his phone. [02:22:42] hotornot, Commons version. [02:23:05] ragesoss: :P [02:23:14] ragesoss: AFT on commons? :P [02:23:14] anyone else do complaints? [02:23:41] Ktr101: about the iOS app? [02:23:48] a fair number are on bugzilla :) [02:24:56] YuviPanda: what's AFT? [02:25:02] oh, article feedback. [02:25:04] ragesoss: Article Feedback Tool? [02:25:05] yeah [02:25:19] yeah. it's actually way more useful there. [02:25:33] because anyone can tell at a glance whether X is a decent picture or not. [02:25:40] yup [02:26:10] and not having that sort of aggregate info really hampers Commons as a stock image database. [02:26:22] not that stock images is central to its mission [02:26:24] YuviPanda: yeah [02:26:36] i usually just give them to brion [02:26:41] ragesoss: you should email the usual peopl e:) [02:26:45] but aside from a holder for Wikipedia images, that's its main use. [02:26:48] Ktr101: since he is not around, you can file them :) [02:28:05] anything to do with Commons besides campaigns and your app is so far off the Tech agenda it's not even worth an email. [02:28:28] ragesoss: heh. [02:28:44] ragesoss: possibly true, yes. a lot of projects are wikipedia focused except mobile I guess [02:28:53] (and I'm sure Erik and others have it on their wish list, for when tech finally can give some attention to other projects) [02:29:54] but if you figured out a way to hack it into an app... [02:30:00] ;D [02:30:20] ragesoss: :P [02:31:13] ragesoss: I *could* implement a fake-ish commenting / rating system using templates on talk page [02:31:16] but not a clean idae [02:31:48] ragesoss: besides, I'm trying to be laser focused on one goal, which is to get 1k uploaders uploadin through mobile in about 4 months [02:31:51] of which I'll be off for one [02:31:52] yeah, no. It'd need to be something in the database, not stored in wikitext. [02:32:07] ragesoss: yeah. [02:32:53] but if it didn't actually have a desktop-user-facing component, it'd be probably relatively simple, compared to a project like AFT. [02:33:07] ragesoss: oh definitely [02:33:30] if we had the time, I'm sure Max can hook up a pure backend in a few days. [02:33:32] you keep focused on your goal, though. [02:34:32] hmm... 4 months. 1k uploaders. That's doable. What if you hit that in 3 months. Then you have a month to spare! [02:34:47] ragesoss: true :) [02:34:49] ragesoss: there's already going to be an extension that lets you query {{Information}} [02:34:50] ragesoss: so I actually have only 3 months (1 off for exams) [02:34:59] ragesoss: and that is 1k uploaders on all mobile (web + android + iOS) [02:35:19] though I think Android / iOS will have to take the brunt of the load there. [02:35:34] * ragesoss fires up some socks. [02:35:38] haha :P [02:36:42] what's the schedule for Play updates? [02:36:50] ragesoss: every Friday [02:36:51] :P [02:37:01] ragesoss: though I think I *should* be doing 'Every Monday' [02:37:05] not set. I'm still making up my mind [02:37:49] ragesoss: is a 'reliable' cycle really necessary? [02:38:03] hmmm [02:38:10] I don't want it to go to 'Wikipedia App' mode [02:38:12] is the weekly interval because of the publishing effort, or the 'don't want to frustrate users' attitude? [02:38:15] where we released every month or two [02:38:36] ragesoss: it is me trying to balance between 'not enough updates' to 'crashy' [02:38:40] stability vs new features, really [02:39:05] ragesoss: publishing effort is minimal. 15 minutes max. [02:39:10] 5 minutes more like [02:39:18] biggest part of it is going to be writing CHANGELOGs [02:39:23] (Android release process is awesome) [02:39:29] okay. so, probably you'll do multiple updates during this beta week, and then spread it out once the easy bugs are squashed and it's more about features? [02:39:41] ragesoss: yeah, probably. [02:40:09] ragesoss: and once we bless some version as 'stable' [02:40:18] then i'll release another 'beta' app into the play store [02:40:22] so you'll have stable and beta [02:40:36] so beta gets pushed every week (or every other week) [02:40:52] and last beta + fixes for reported bugs -> next iteration's stable [02:41:10] so that gets you a new release every other week (in sync with our iterations) [02:41:19] I think there's something to be said for the psychological benefit of reminding users that your app exists by pushing an update every week or two. [02:41:29] ragesoss: agreed. [02:41:36] ragesoss: and worst is what happened to the Wikipedia app. [02:41:40] months between updates [02:41:45] and even then insubstantial [02:41:55] every moment I've been off PhoneGap has been a happy one [02:42:06] yeah, but that's an app that people will use or not as they need it. [02:42:22] yeah. this needs to be 'pushed' [02:42:37] it's different from Commons, where we get more than just 1+ traffic each time it gets used. [02:42:41] ragesoss: how many active contributors does commons have? [02:42:51] umm... [02:43:08] order of magnitude? [02:43:52] searching the report card. [02:45:54] 7k with 5+ edits. [02:46:17] ever? [02:46:20] or this month? [02:46:28] January 2013 [02:46:34] not bad [02:46:43] but 1k uploaders still gonna be hard [02:46:53] I think it is 1k uploaders per month [02:46:57] which is much harder [02:47:33] I seem to be panicking a bit about that and overworking myself. [02:47:34] it is 8:20 AM and I have not slept yet [02:48:07] 20k+ with 1 edit per month. [02:48:19] 36k during WLM [02:48:36] ah [02:48:39] go to sleep. [02:48:40] not bad. [02:48:49] ragesoss: one last bug! [02:48:55] (the transparent background one) [02:49:03] with that all the 'low hanging fruit' would be taken care of [04:59:43] New patchset: Ori.livneh; "(Bug 45392) add user ID as JS variable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51110 [11:46:15] New patchset: Siebrand; "(bug 45461) Use email instead of e-mail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51146 [11:52:29] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/yRGa9g [11:52:29] android-commons/master 629f222 YuviPanda: Switch to using UIL for Share activity as well... [11:52:29] android-commons/master d2ab678 YuviPanda: (Bug 45401) Make transparent images have a white background... [11:53:06] Project Android-Commons (mobile) - Nightly builds build #105: STILL FAILING in 28 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/105/ [11:53:06] * yuvipanda: Switch to using UIL for Share activity as well [11:53:07] * yuvipanda: (Bug 45401) Make transparent images have a white background [12:13:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51146 [12:17:44] Project MobileFrontend-linux-android build #258: STILL FAILING in 3 min 21 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/258/ [12:17:45] s.mazeland: (bug 45461) Use email instead of e-mail [12:19:45] Project MobileFrontend-mac-iphone build #264: STILL FAILING in 4 min 45 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/264/ [12:19:46] s.mazeland: (bug 45461) Use email instead of e-mail [12:21:55] Project MobileFrontend-mac-ipad build #258: STILL FAILING in 4 min 10 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/258/ [12:21:55] s.mazeland: (bug 45461) Use email instead of e-mail [13:25:45] YuviPanda: ping [13:25:49] notnarayan: pong [13:25:54] YuviPanda: http://commons.wikimedia.org/wiki/File:Post_upload,_multiple_upload_flow.pdf [13:27:35] notnarayan: few things. title will be compulsory (we can't upload to mw without title yet) [13:27:44] and IIRC these two are supposed to be separate? [13:27:55] I am confused as to how the workflow will be when I'm uploading a single file... [13:28:06] and even multiple file. [13:28:19] it says '5 selected', but where do I see which 5? [13:28:25] same, you can scroll between multiple files [13:28:36] hitting later, would switch to the next file [13:28:53] the idea is that you give your Title [13:28:55] and then you hit upload [13:28:58] YuviPanda: i guess if we can't to without title [13:29:07] and then comes a screen where you can add desc, categories, etc. [13:29:21] not having optional fields in the first screen was the point, no? [13:29:45] categories going to be optional [13:30:33] ? [13:41:16] YuviPanda: http://commons.wikimedia.org/wiki/File:Post_upload,_multiple_upload_flow.pdf [13:44:37] notnarayan: shouldn't there be some indication of the images you have pending? [13:44:42] like a scrollable list at the bottom? [13:47:24] YuviPanda: i dint get you [13:47:40] notnarayan: like how the gallery has a list of thumbnails at the bottom? [13:48:12] YuviPanda: if there are 5 images, the action bar shows that number [13:48:56] notnarayan: have you seen how the gallery does it? [13:49:15] notnarayan: and have you tried using UploadWizard? It lets you title all of them in one go. [13:49:24] yes [13:49:43] plus it should be eaiser to title them than having to swipe or tap between every entry, no? [13:50:16] well a confirmation from the user once he has entered the title would be required [13:50:34] on conformation you switch to the next image [13:50:43] still 2 taps per image [13:52:21] upload wizard results in a scroll. [13:52:44] here the focus is on one image at a time. [13:52:45] upload wizard lets you specify one title and have derivatives copied over for the rest of them [13:52:49] it should not be is my point [13:53:08] focus should be on letting you upload them as soon as possible. [13:55:23] YuviPanda: what are you suggesting, have them all show at onc [13:55:26] once? [13:55:45] possibly. [13:56:12] one would still have to tap an image if he wishes to enter a title for it. [13:56:33] if we give a gallery view id [13:58:57] we could just have a list? [13:59:36] why have two different flows, one for a single upload and another for multiple upload [14:00:16] my thumbs would hurt if I had two taps for every title. [14:01:04] its not two taps [14:01:13] one for title then one for 'later' no? [14:01:16] lets say you select 5 [14:01:22] there is no later [14:01:27] please see the new wireframes [14:01:45] http://commons.wikimedia.org/wiki/File:Post_upload,_multiple_upload_flow.pdf [14:01:56] notnarayan: I see '5 selected' [14:01:58] a title [14:02:01] and an upload button [14:02:02] and nothingm ore [14:02:04] *more [14:02:11] http://upload.wikimedia.org/wikipedia/commons/5/5e/Post_upload%2C_multiple_upload_flow.pdf [14:02:18] swipe is worse than tap, no? [14:02:26] remember Title is *required* [14:03:50] its not two taps [14:04:06] you select 5 images, enter title, hit upload, it goes to the next image [14:04:12] its one tap per title [14:04:14] not two [14:04:24] should be able to enter titles then hit upload *once* [14:04:27] no? [14:05:47] YuviPanda: that would be quite forceful [14:05:56] hmm [14:05:58] let me think about this [14:06:05] notnarayan: and how would this integrate with post upload actions? [14:06:18] notnarayan: see, the point I'm trying to avoid [14:06:20] is having to type [14:06:26] 'Statues at Ellora Caves #1' [14:06:31] 'Statues at Ellora Caves #2' [14:06:35] 'Statues at Ellroa Caves #3' [14:06:36] over [14:06:37] and over again [14:06:42] and then adding categories to them over and over again [14:07:22] YuviPanda: well, if would be superb if you can detect the first images title and auto populate the other by adding a number or even the timestamp [14:07:38] and do the same for categories, [14:08:37] hmmm [14:08:41] let me think about this. [14:08:53] notnarayan: and adding how 'post upload actions' would integrate into this would be nice [14:09:11] YuviPanda: 4 and 5 are that [14:09:33] notnarayan: I don't think that is what we meant by 'post upload action' [14:09:35] YuviPanda: when a user opens an image from my uploads post upload [14:09:39] post upload is immediately after you hit the upload button [14:09:41] not when you tap a tile [14:11:37] at upload don't even ask for desc and categories only title. when the user taps on an image that does not have a desc or a category, show the widget for desc and categories, allow user to edit title too. the idea is to get the image asap, and allow him to enter the other metadata post upload of image itself [14:11:57] notnarayan: the idea is to suggest to people to add descriptions and categories [14:12:08] that once you upload you *should* add them [14:12:12] not *can* [14:12:47] YuviPanda: well, anyone can so. not sure if it needs to be forced. [14:12:58] it should be suggested. [14:13:24] tapping to edit is a part of the detail page, which IMO we shouldn't be doing for now. [14:13:29] (a couple of iterations later maybe) [14:13:48] we could suggest while he enters the title that he could enter desc and categories [14:13:55] what say YuviPanda ? [14:14:16] notnarayan: have you seen how Instagram's upload process works? [14:14:24] YuviPanda: yes [14:14:28] they ask for filter the start uploading then comes a screen where you can add description / share to others [14:14:33] *that* is the post upload screen [14:14:36] it is not too forceful [14:14:38] but very helpful [14:14:48] you can ignore it if you want. but it suggests that you do those. [14:16:12] so, 1. i don't think we need a post upload screen, the detail screen could be used to house these post upload actions. add desc, categories, share etc [14:17:02] why not? [14:17:20] cause we can do it in the detail screen [14:18:02] not unless the user explicitly taps it [14:18:10] Description is important. Categories are important. [14:18:16] http://commons.wikimedia.org/wiki/WP:VP#New_Commons_beta_app_for_Android_available_at_Google_Play [14:18:25] This file has no description. I hope that's not a new trend. --Dschwen (talk) 21:22, 25 February 2013 (UTC) [14:18:31] and I agree with him, in that I hope it is not a trend too [14:19:12] YuviPanda: send that again [14:19:14] Images *and* metadata are important. not just images. [14:19:25] http://commons.wikimedia.org/wiki/WP:VP#New_Commons_beta_app_for_Android_available_at_Google_Play [14:22:32] also see http://commons.wikimedia.org/wiki/WP:VP#Help_test_out_new_mobile_upload_features for a slightly unrelated ocmment [14:25:22] YuviPanda: brb [14:25:27] ok [14:25:59] YuviPanda: well discuss the workflow give me ten mins [14:26:07] ok [14:26:12] I'm off to get something to drink as well [14:26:13] brb [14:37:58] YuviPanda: bug updated. It seems like something in the title/description/start upload activity is still trying to load the file and running out of memory. or something. [14:40:16] ragesoss: yup, looks like [14:40:19] will investigate [15:14:50] ori-l: I'm thinking of using MongoDB for the analytics. Think it would be something that is going to be supported? [15:14:54] or just a hack that might rot on later? [15:41:36] New patchset: MaxSem; "Profiling" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51167 [16:37:05] GrumpyPanda: I uploaded an image from my mobile over wi-fi, then I cut the wi-fi off in the middle of the upload. The upload failed, but quickly restarted the upload over my mobile network. However, some info was lost: https://commons.wikimedia.org/wiki/File:Clown_Fish_at_Audubon_Aquarium_of_the_Americas.jpeg [16:37:15] valeriej: looking [16:37:19] Look at 'Description' and 'Author'. Both are null. [16:37:21] valeriej: also I fixed the transparent image bug [16:37:48] valeriej: ah, that is not a bug with network. Is a reported bug where everytime an upload is restarted it loses metadata [16:38:09] I was trying to file a bug report, but I couldn't think of a short summary. Oh, already reported, good. [16:38:39] valeriej: https://bugzilla.wikimedia.org/show_bug.cgi?id=45437 [16:38:44] valeriej: can you verify that? [16:38:52] that is, restarting uploads always results in user:Null? [16:39:53] As for the transparent image fix, I tried to update the app, but there wasn't one available. I think I recall you saying updates are pushed Friday? [16:41:18] I'll comment on bug 4537 with my scenario. My upload did fail as well, so I would say I got the same bug. [16:41:38] valeriej: bit.ly/android-commons is updated app. [16:41:51] valeriej: yeah, current thought process is to push out an update every Friday. [16:41:58] but that was an arbitrary decision [16:42:26] Ok, I'll check out the transparent image fix in a bit. [16:42:26] * brion tells GrumpyPanda to turn that frown upside-down [16:42:42] valeriej: thanks :) [16:42:56] GrumpyPanda: No problem! [16:43:03] brion: I'm grumpy because I will have to wake up at 5frickingAM tomorrow and go to college :| [16:43:10] suuuuuuuucks [16:43:19] brion: + a 2 hour commute [16:43:21] EITHER WAY [16:43:23] yuck [16:43:24] to go and sleep there [16:43:25] ok be grumpy :) [16:43:40] while sitting up [16:43:52] (there is a rule against sleeping with your head on the desk, but none about actually sleeping) [16:43:56] haha [16:44:00] GrumpyPanda: so, does the app silently overwrite existing files with same name? [16:44:07] http://test.wikipedia.org/wiki/File:Test.jpeg [16:44:13] lots of files with that name! [16:44:26] ragesoss: yup :P [16:44:33] ragesoss: need to fix. file a bug? [16:44:48] I'm thinking 'auto add a timestamp' or 'prompt user' [16:48:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=45498 [17:43:01] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51167 [17:46:04] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/tqpt_Q [17:46:04] android-commons/master e05f55d YuviPanda: (Bug 45401) Fix crash in older versions of Android [17:46:19] Project Android-Commons (mobile) - Nightly builds build #106: STILL FAILING in 14 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/106/ [17:46:19] yuvipanda: (Bug 45401) Fix crash in older versions of Android [17:54:37] Project MobileFrontend-mac-ipad build #259: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/259/ [17:54:37] maxsem.wiki: Profiling [17:55:33] Project MobileFrontend-mac-iphone build #265: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/265/ [17:55:33] maxsem.wiki: Profiling [17:55:47] wmf-selenium-bot, stfu [17:55:47] MaxSem you may not issue bot commands in this chat! [17:56:01] yes I can [17:56:59] * GrumpyPanda adds that to quips [17:57:24] GrumpyPanda, wanna follow wmf-selenium-bot's way? [17:57:36] :P [18:03:06] GrumpyPanda: standup? [18:03:48] Project MobileFrontend-linux-android build #259: STILL FAILING in 9 min 10 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/259/ [18:03:48] maxsem.wiki: Profiling [18:08:50] hrm, if wmf-selenium-bot doesn't shut up I'll silence it [18:08:53] sorry for the noise [18:12:23] brion: you should get Commons-iOS on twn soon :P [18:12:34] yep [18:19:41] everyone go check your watchlist in beta! [18:19:46] it's beaaaaauuuutiful :) [18:21:55] New patchset: Jdlrobson; "Alpha: Reactivate inline style scrubber" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [18:23:44] ok, so 71 non-testwiki users tried to upload, and 26 got an error message. looks like we're holding steady at 36/37% failure rate [18:23:52] not good but at least it's not gotten worse [18:24:45] * GrumpyPanda should really distinguish testwiki / commons uploaders in stats [18:25:30] GrumpyPanda: don't spend too much time on it. if we do it right commons should blow test wiki out of the water [18:25:49] tfinc: this is true [18:25:59] but we have 140 successfull uploads, and I do not know which are to testwiki [18:29:00] you have a wiki field in your schema, though, grumpypanda [18:29:08] Maryana: that comes by default [18:29:11] I... am just not setting it :P [18:29:13] should do [18:29:17] simple few line fix [18:29:21] ah. heh. gotcha [18:29:43] Maryana: is the goal 1000 uploaders per month by June? [18:29:47] or just 1000 uploaders in general? [18:29:53] (accumulative) [18:30:59] yeah, i think 1k uploaders per month by the end of the fiscal year, and an intermediate target by the end of this quarter that i'm blanking on [18:31:09] 300 per month? [18:31:22] That's what I remember. [18:31:35] sounds right :) [18:31:46] okay :) [18:31:52] so if we can get 300 people uploading via apps and web in march [18:31:55] then we'll be golden [18:32:07] yup! [18:32:50] Maryana, do we count non-successful attempts too? [18:32:54] I guess not, right? [18:32:57] err, no [18:33:39] Maryana: can you take a pass through https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 and update mobile web ? [18:34:00] sure thing [18:35:12] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/VUDZ2w [18:35:12] android-commons/master e324206 YuviPanda: Update EventLog with appropriate wiki name... [18:35:27] Project Android-Commons (mobile) - Nightly builds build #107: STILL FAILING in 19 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/107/ [18:35:28] yuvipanda: Update EventLog with appropriate wiki name [18:36:07] Maryana: Erik wants us to the some broader marketing for image uploads across all projects. i think mobile apps could jump on that bandwagon middle of march and that mobile web could do it sooner [18:36:41] (+1) [18:36:49] niiice [18:36:50] does that mean something like running banners on desktop? [18:37:02] i'd love to run a banner on commons telling people about mobile uploads :) [18:37:46] brion: I'm guessing 'wav' ingestion shouldn't run into legal issue, right? [18:38:16] GrumpyPanda: wav ingest should be fine…. not sure if we have that enabled on the server side or not [18:38:25] brion: IIRC we don't. [18:38:39] of course technically wav is a container format and can contain any encoding ;) [18:38:44] but they're typically uncompressed pcm [18:38:46] brion: wav / pcm [18:38:46] yeah [18:38:53] Maryana: yup [18:38:54] it would be a start. [18:39:18] Maryana: Erik will be talking to Comm today to see options [18:39:28] Maryana: what we need to figure out is how soon mobile web can do it [18:39:46] hmm.. i'd say probably in a week or 2 [18:39:55] want to make sure to kill this pesky login bug [18:40:00] (^ same for Android) [18:40:09] brion: GrumpyPanda : please mark what your currently doing on http://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_3 [18:40:30] done [18:41:20] brion: when do you think iOS can start being sent to Apple? [18:41:23] 2 weeks? [18:41:43] probably [18:41:57] tfinc: that sound like a good target? mid-march for iTunes distribution? [18:41:57] brion: you should make a tracking bug :) [18:42:14] brion: yes id say the marketing should line up with a stable store launch [18:42:40] i'm thinking third week of march to release to the store [18:42:51] 3/18/13 [18:43:00] 2013-03-18 :) [18:43:03] brion: GrumpyPanda : any reason why we couldn't make that? [18:43:15] tfinc: I'm doing weekly releases. [18:43:27] should be fine. i should try to submit it by march 11 to make sure it's ready to release [18:43:28] so no issues at all. [18:43:34] excellent [18:44:15] tfinc: thoughts on a Friday release vs a Monday release? [18:44:53] GrumpyPanda: Friday releases are horrible and screw your weekend [18:45:06] monday sounds better :) [18:45:14] that.. does sound right. [18:45:14] monday is the way to go [18:45:38] we should never release on Fridays [18:45:44] mondays/tuesdays are best [18:46:18] Maryana: if there is anything big missing project wise then do add it [18:46:33] MaxSem: can i consider GeoData done from our standpoint ? [18:47:01] tfinc, I would like to see it in heavy use first [18:47:04] tfinc: mobile edits? [18:47:27] only then we can be sure that it works for real [18:47:27] Maryana: get it on there if your planning it in the next quarter [18:47:31] MaxSem: k [18:47:43] MaxSem: how is populating the other languages going? [18:48:10] brion: do you know how to get hold of mdale? [18:48:43] uh, poke him on irc if he's around [18:49:10] tfinc, I see a lot of largest projects have already adopted it, but for smaller ones the solution would be only via Wikidata [18:49:17] k [18:57:13] MaxSem, where can we see data from wfProfile* functions? [18:58:45] GrumpyPanda: I think it depends entirely on whether or not it is used. I'd be happy to support it if it's useful for you. [18:59:10] jgonera, http://noc.wikimedia.org/cgi-bin/report.py https://graphite.wikimedia.org/ [18:59:26] thanks [19:03:21] GrumpyPanda: I think there's definitely room for a document store that handles JSON (or JSON-like) records without having to bend and squish them. But I couldn't find one that I loved. The current crop seems to optimize for scaleability rather than human-friendliness. Of the ones I looked at, I liked RethinkDB (see http://www.rethinkdb.com/api/) the best, but Mongo was already packaged and puppetized. [19:03:56] ori-l: heh, okay. my SQL skills suck (ORM-spoilt), so might as well check out mongo [19:04:40] Ok, I'll promote it to official status then [19:04:46] ceremony at 11 [19:05:04] ori-l: will there be alcohol? [19:07:10] no, but probably headaches and regrets the morning the after [19:07:16] * the morning after [19:07:39] ori-l: just every other day [19:08:46] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/b31B1Q [19:08:46] android-commons/master 5f63fcb YuviPanda: Make minimum version Android 2.3, not 2.2 [19:09:01] Project Android-Commons (mobile) - Nightly builds build #108: STILL FAILING in 27 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/108/ [19:09:02] yuvipanda: Make minimum version Android 2.3, not 2.2 [19:09:14] hehe still failing :P [19:18:53] Project Android-Commons (mobile) - Nightly builds build #109: STILL FAILING in 11 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/109/ [19:21:29] Project Android-Commons (mobile) - Nightly builds build #110: STILL FAILING in 11 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/110/ [19:25:49] oh hey, edit summary is working now! did you fix it, jgonera? https://en.wikipedia.org/w/index.php?title=Langness_Peninsula&action=history [19:26:00] ^ top edit [19:26:52] Maryana_, in general, edit tagging works: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit [19:27:07] Maryana_, yes, this was fixed after the deployment yesterday [19:27:16] sweet [19:27:33] maxsem: it's still not showing up on edits via the lead image thingy, though :( [19:27:43] MaxSem: it's not working for photo uploads [19:27:47] ie. edits via api [19:27:51] works fine for non-api edits [19:29:16] that is, it works for uploads, but not API edits;) [19:29:23] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/eZhDcQ [19:29:23] android-commons/master c0210c9 YuviPanda: Fix pom.xml to work properly [19:29:51] Yippie, build fixed! [19:29:52] Project Android-Commons (mobile) - Nightly builds build #111: FIXED in 32 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/111/ [19:29:52] yuvipanda: Fix pom.xml to work properly [19:30:02] brion: I fixed the bug with the dependency not working. CR? [19:31:07] moment [19:33:20] pulled… building... [19:33:36] builds! [19:35:05] MaxSem: so to be clear action=edit api calls are not working? [19:35:09] Maryana_: https://commons.wikimedia.org/w/index.php?namespace=&tagfilter=mobile+edit&title=Special%3ARecentChanges [19:35:33] yeah, been looking at those this morning [19:35:40] still no gross pics! [19:36:10] i know it's commons and there's bound to be at least one crotch shot [19:36:50] mm… bit confused about the Michael Happoldt [19:36:55] no edit to the page but the image was uploaded.. [19:37:35] seems to be mostly people testing and reverting? [19:42:07] maxsem: spooky! https://commons.wikimedia.org/wiki/File:Lead_Photo_For_DonateImage0-5981760113500059.jpg [19:42:25] New patchset: Jdlrobson; "bug 45392: add user ID as JS variable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51110 [19:42:28] psychedelia [19:42:46] New review: Jdlrobson; "Waiting for feedback (sent email to Ori and a few others) on why we are doing this before merging." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/51110 [20:00:51] New patchset: Jdlrobson; "bug 45465: Increment upload count on successful upload page upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [20:06:35] New patchset: Jdlrobson; "Regression: Do not enable random module on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51206 [20:07:46] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51082 [20:08:00] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51083 [20:08:38] Maryana, jdlrobson: https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit https://en.wikipedia.org/w/index.php?title=1986%E2%80%9387_Ekstraklasa&curid=18416954&action=history [20:08:52] nice! [20:08:56] maybe, the bogus results yesterday were due to caching? [20:09:12] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51205 [20:09:12] or maybe the wikis just fear you and do what you say [20:10:17] MaxSem: are there plans of letting users type in title from 'DonateImage'? [20:10:21] err [20:10:23] Maryana: ^ [20:10:49] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51205 [20:11:46] anyway, unless there's evidence that tagging is still broken, I'd call it resolved [20:12:48] yuvipanda, not anytime soon [20:12:53] we do need to change the default title, though [20:13:58] Maryana: ough. okay. [20:14:06] I've no idea what any of those images are [20:14:08] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51089 [20:16:25] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51206 [20:17:29] hey tfinc, i'm in r31 if you wanna join [20:17:40] Maryana: i was wondering where you were [20:17:54] oh, hehe - sorry :) [20:18:00] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/50920 [20:20:25] MaxSem, http://noc.wikimedia.org/cgi-bin/report.py gives me Gateway Time-out [20:20:39] ok, nevermind, it worked now [20:20:46] yeah, must've been broken by datacenter migration [20:24:13] New review: JGonera; "mf-languages.less is 0 bytes, should not be added." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51088 [20:27:13] brion: yt? [20:27:25] GrumpyPanda: ? [20:27:32] brion: talked to mdale [20:27:32] https://gerrit.wikimedia.org/r/#/c/25473/ [20:27:36] brion: we have all the tech in place [20:27:41] sweet [20:27:45] just needs a flip of a switch for us to support audio and video [20:27:49] right [20:27:50] brion: we should really push on that [20:27:51] that's the hard part :P [20:27:52] true [20:27:56] yep [20:28:39] i'll drop a note to legal and see if they feel they need to weigh in i guess [20:29:20] brion: I think mdale already asked them and has gotten back silence mostly (so far)? [20:29:28] brion: you can cc jan, robla and me if you want.. Robla may already have a thread [20:29:46] yeah, last i talked to robla he was kinda waiting until luis villa was set up in legal [20:29:49] brion: and include me too. [20:29:53] k [20:30:09] brion: on mobile we for the most part have no alternatives, and hence should push harder :) [20:30:25] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51094 [20:30:39] New review: Jdlrobson; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/51096 [20:30:53] hello edsanders [20:31:00] welcome to the mobile channel ;) [20:31:00] hi [20:32:44] I think just the argument about uploads is a good enough reason on its own ... 50 years from now when the robot overloads are visually analyzing all of the media content, I bet they will say, "sure would have been nice to have the originals". [20:32:48] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51089 [20:32:49] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51089 [20:33:33] +1 [20:33:40] or when we stream stuff directly into our retinas [20:33:46] sure [20:40:50] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51079 [20:43:21] New patchset: Jdlrobson; "Tweak: Position fixed elements and open navigation panel" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51210 [20:45:31] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51211 [20:46:38] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/so0AMA [20:46:38] android-commons/master 203aa67 YuviPanda: (Bug 45437) Retain creator & desc information across restarts... [20:47:06] Project Android-Commons (mobile) - Nightly builds build #112: SUCCESS in 31 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/112/ [20:47:07] yuvipanda: (Bug 45437) Retain creator & desc information across restarts [20:48:05] valeriej: ragesoss the User:null bug has been fixed :) [20:48:36] wah, fundraising banner in India! [20:48:36] YuviPanda: Awesome! [20:49:08] I saw the bugzilla email. [20:49:32] jdlrobson: just came across this while testing https://bugzilla.wikimedia.org/show_bug.cgi?id=45517 [20:49:38] very bizarre [20:49:51] MaxSem: i love the images we can now see in the image view [21:00:18] jdlrobson, mtg? [21:00:45] MaxSem: Now look what you've done [21:01:29] tfinc: btw, just like your Picasa -> Gallery -> Commons workflow, I think there is an Instagram -> Gallery -> Commons one too :) [21:02:02] jesus, why do people keep leaving when I ping them [21:02:04] dammit [21:06:40] brion: was talking to victor, he is also super interested about getting video done. [21:06:47] very much looking forward to your email thread :P [21:07:01] CC'ing victor too :) [21:09:18] brion: sweet :) [21:09:22] exciting stuff. [21:11:24] brion: also see https://meta.wikimedia.org/wiki/Grants:IEG/Wiki_Makes_Video [21:11:42] YuviPanda: YES! [21:12:07] YuviPanda: i'm going to want stats eventually of which ones people use. but we can worry about that later [21:12:35] tfinc: I'm unsure if we can have that, sadly. (We do have stats on how many people use the camera vs gallery) [21:13:20] New patchset: MaxSem; "Honor the no images setting on watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51218 [21:15:30] YuviPanda: not importnat right. just a thought going forward [21:15:40] sure. will keep in mind [21:17:17] brion: thank you :) [21:17:21] \o/ [21:17:39] tfinc: brion has an email thread going about video formats. Pushing on that from your part would be *incredibly* helpful :) [21:18:08] i'd love to have it resolved within the next month or two so we can prep for video uploads in the commons apps :) [21:18:16] YuviPanda: i do not want us distracted by video now [21:18:23] its it not our priority [21:18:33] the wheels move slowly [21:18:36] tfinc: we should start pushing now if we want it done within the next 6 months [21:18:42] i've been trying to start pushing it for a couple years [21:19:04] so you thiking of getting community acceptance over the next 3months and breaking ground on it next fiscal ? [21:19:14] that would be fine by me [21:19:21] tfinc: something like that. [21:19:29] tfinc: but it needs a lot of internal wheels to grind before that can happen. [21:19:30] even if we don't touch the upload side, we can get playback going very quickly if we can decide. [21:19:32] Legal needs to be involved [21:19:36] etc [21:19:44] tfinc: and there is minimal tech work on our side at all [21:19:51] mdale has done most of the heavy lifting with TMH [21:20:01] noted [21:20:06] tfinc: so this is at this point merely a process block [21:20:13] process block ? [21:20:23] tfinc: as in, 'go through legal, community, board' etc [21:20:26] rather than a technical one [21:21:10] a tfinc problem, not a yuvipanda problem. [21:21:20] indeed. [21:21:24] but it does affect yuvipanda [21:21:59] as managers' problems are wont to do. [21:22:00] mdale: is there a testwiki somewhere with h264 ingestion enabled? [21:22:31] I have this vague feeling that I don't actually need to do anything to support it. [21:23:07] it only affects me if i choose that we should work on that and i'm not convinced yet [21:23:33] tfinc: why not? [21:23:44] there is plenty of low hanging fruit for video on wiki/commons [21:23:44] videooooooo! [21:23:48] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/51211 [21:23:49] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51211 [21:23:59] because this is just one of the many things we could work on [21:24:31] and i haven't given it enough thought to know if its worth it. we should do a lunch about it so that we can banter about pros/cons [21:24:47] just imagine. [21:25:10] 10000 Harlem Shake videos on Commons. [21:25:12] tfinc: sure. I'm pretty sure me + brion can convince you. [21:25:23] bring it on [21:25:24] it'll be so awesome. [21:26:39] tfinc: there's an app team syncup on monday. let's talk about it then. [21:27:18] we can talk about it once we finish anything related to the sprint. there should be plenty of time [21:27:43] tfinc: yup. [21:28:11] tfinc: I don't think any of our previous ones went over 15 mins, and we have the room for 30. [21:28:29] its mid sprint. should be fine [21:28:40] yup. [21:50:05] brion: did you manage to find some time to do CR? [21:50:07] it's been a week [21:50:15] since I last poked you into it :) [21:50:25] it looks ok enough, i can do deeper dive later [21:50:30] brion: sweet [21:54:30] when will i get near by back? [21:55:20] tfinc: whenever we deploy again [21:55:27] k [21:55:37] is the next scheduled deployment next tuesday ? [21:57:22] okay, commute in 3 hours [21:57:25] off to sleep folks :) [21:57:26] gnite [21:57:40] tfinc: i guess :( unless you can convince MaxSem to do one today/tomorrow :) [21:58:02] why not? [21:58:28] we just need to determine what we _need_ to deploy [22:03:16] i wait for the days that we can just continuously deploy. i echo what juliusz said about deployment being too much of a big thing [22:03:24] we should just be able to push whenever [22:03:43] but practically .. it'd be nice to fix this broken behaviour before tuesday if we can isolate the bug fix [22:05:00] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51095 [22:30:05] New patchset: Brion VIBBER; "(bug 45500) Support photo uploads on Firefox OS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51287 [22:39:30] New patchset: Jdlrobson; "Regression: Do not enable random module on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51206 [22:40:53] New patchset: Brion VIBBER; "(bug 45500) Support photo uploads on Firefox OS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51287 [22:41:22] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51206 [22:43:00] New patchset: Jdlrobson; "bug 45452: Ensure error message appears when a bad token is visible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51079 [22:43:03] New review: Jdlrobson; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51079 [22:52:24] New patchset: Jdlrobson; "Alpha: Reactivate inline style scrubber" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [22:52:34] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50920 [22:53:06] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51095 [22:54:21] New patchset: Jdlrobson; "bug 44806: style all pre and code tags" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51088 [22:56:55] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [23:02:00] tfinc: so that bug is fixed… i'm more than up for a deployment.. we could deploy current master… nothing massive has come out so far :) [23:02:25] ^ MaxSem thoughts? [23:03:21] I see a lot of minor stuff [23:03:32] jdlrobson: http://meta.wikimedia.org/wiki/Schema:MobileWebUploads [23:03:56] though a lot of what was merged were tests [23:05:19] New review: Jdlrobson; "Maryana says she would prefer usernames to user ids as it is less work for her so abandoning this." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/51110 [23:05:29] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51110 [23:07:22] jdlrobson: nice. if max can stick around post deployment if we see issues then lets fix that one issue [23:08:03] jdlrobson, on gadget leakage: looks like it's because the module loader is not aware of targets and thus requests all that MW pours into it [23:08:36] :-( [23:08:40] so the proper fix would be to tweak the JS to append &target=mobile to resource links [23:09:00] we need to update ResourceLoader in core? [23:09:49] yes [23:09:53] wheeeeeeeeeeeeeeeee [23:09:59] that'd put a link in the code for an empty http request [23:10:03] seems waste [23:10:18] Krinkle, ? [23:10:48]