[00:09:26] Project MobileFrontend-linux-android build #305: NOW UNSTABLE in 9 min 22 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-linux-android/305/ [00:09:26] jrobson: Bug 44017: Cleanup ResourceLoader mess [00:23:21] New review: Krinkle; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [01:11:45] noooooooooooooooooooooo [01:11:53] commons app crashed trying to upload an image [01:12:10] * Reedy sends yuvi an email [01:19:45] Now it's force closing [01:19:45] GG [01:37:07] New review: JGonera; "(7 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52627 [01:46:08] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51205 [04:09:10] 14 Exception from line 159 of /usr/local/apache/common-local/php-1.21wmf10/extensions/MobileFrontend/includes/api/ApiMobileView.php: ApiMobileView::getData: Pool [04:09:10] Counter didn't return parser output [05:22:14] Reedy: I flagged those before; I think these are thought to be generic 'page took too long to parse' errors [10:09:44] New review: awjrichards; "I double checked with Diederik about the key name for zero and updated it accordingly. Both this cha..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52605 [10:16:31] New patchset: awjrichards; "Regression: fix margin/padding on input in header for language overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52190 [10:17:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52190 [10:19:43] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52567 [10:22:19] New patchset: awjrichards; "Fix comment to reference CentralAuth, rather than CentralNotice" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52782 [10:30:16] New review: awjrichards; "It looks like you may have forgotten to add the UnlistedSpecialMobilePage class in this commit." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52553 [10:33:15] New review: awjrichards; "i just tested this on a diff that only removes content. i see a flash of the diff as the page is loa..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52663 [10:37:41] New review: awjrichards; "Am I correct in assuming that the siteNotice will get loaded entirely via JS? If so, this should be ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52055 [10:40:32] New patchset: awjrichards; "alpha: show preferred languages at top of language selector" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48984 [10:41:38] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48984 [12:26:01] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52404 [12:26:02] New patchset: Zfilipin; "Updated Cucumber Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52791 [12:34:54] New patchset: Shirayuki; "American spelling - unrecognized (debug message)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52795 [14:57:41] New review: Jdlrobson; "Can you give me the html of the diff in beta? It would be a useful test case." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52663 [15:08:13] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [15:21:03] New patchset: Jdlrobson; "Maintenance: Load minimum possible css / reorg css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [15:23:53] New review: Jdlrobson; "Yeh I figured something like this was possible but couldn't work it out. I'm still not sure if this ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52553 [15:36:01] New patchset: Jdlrobson; "bug 45465: Increment upload count on successful upload page upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [15:36:47] New review: Jdlrobson; "+1ing on behalf of juliusz - waiting for that final merge" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/51205 [15:39:26] New review: Jdlrobson; "(5 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [15:41:25] New review: Siebrand; "@jon: Re: Your question on PS1: You can use 2 parameters: 1 for the plural, another to do your wrapp..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [15:44:53] New review: Siebrand; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [16:17:36] New review: Jdlrobson; "Well an empty #siteNotice div needs to exist in the html for banners to be surfaced. If central noti..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52055 [17:03:09] fale: hey! [17:03:12] sorry was away yesterday [17:03:27] fale: so a few things (adding to what qgil_ responded to on the email) [17:03:55] fale: 1. use maven! https://code.google.com/p/maven-android-plugin/ is wonderful, and will make it easy for you to integrate the libraries we use [17:04:38] fale: 2. use github.com/wikimedia/java-mwapi, which is a client library for mediawiki api in Java. The Commons app uses this, and it'll keep getting updates [17:04:50] (and is also on maven central, so easy to include!) [17:04:57] fale: 3. Use ActionBarSherlock :) [17:08:18] Reedy: what were you doing that made it crash? [17:08:23] and is it still crashing? [17:09:07] YuviPanda: tried to upload a photo taken via it [17:09:09] then it crashed [17:09:21] and now every time I open it, it stays open for a couple of seconds then disappears [17:09:22] still crashing? [17:09:36] yup [17:09:37] i'm on it [17:09:55] great [17:11:14] hmm [17:11:18] it says line 143 [17:11:28] that's just a return true [17:11:28] hmmm [17:12:18] Reedy: can you uninstall + reinstall? [17:12:24] for some reason it 'lost' the cookies. [17:12:53] I'm going to trace execution and see what could've caused that [17:13:52] lol [17:13:58] I'll try when I get into the office [17:14:03] Reedy: okay [17:15:31] YuviPanda: thanks for the heads up :) [17:15:46] fale: have you done native android stuff before? [17:16:05] YuviPanda: I've seen in the store a Wikipedia Mobile app in beta... is it native? [17:16:16] no, that is also the phonegap version [17:16:24] YuviPanda: only some test app, but nothing serious [17:19:50] fale: okay! [17:19:57] fale: do you have an android phone? [17:20:16] YuviPanda: yes :) an HTC One X rooted [17:20:18] oooh, sweet [17:20:44] fale: can you test the commons mobile app as well? If you're only getting started, I think patches to that will also help you get familiar with the system :) [17:21:08] YuviPanda: I've installed it yesterday :) [17:21:14] fale: from git? [17:21:15] :D [17:21:21] nope, from store :D [17:21:36] fale: get it from git! It uses mavne, java-mwapi, etc [17:25:26] YuviPanda: today I'm going to reinstall it from git :) [17:25:32] fale: woohoo :) [17:38:06] wow https://commons.wikimedia.org/wiki/File:%E5%8F%B0%E5%B7%9E%E5%B8%82%E6%B0%91%E5%B9%BF%E5%9C%BA%E5%85%A5%E5%8F%A3.jpeg [17:41:42] Project MobileFrontend-mac-ipad build #312: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/312/ [17:41:42] l10n-bot: Localisation updates from http://translatewiki.net. [17:50:09] Yippie, build fixed! [17:50:10] Project MobileFrontend-mac-ipad build #313: FIXED in 8 min 1 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/313/ [17:50:46] YuviPanda: :) [17:51:07] it's amazing that we have people who have not really contributed to commons before uploading, and panoramas at that :) [17:51:57] YuviPanda: a panaroma ? [17:52:07] https://commons.wikimedia.org/wiki/File:%E5%8F%B0%E5%B7%9E%E5%B8%82%E6%B0%91%E5%B9%BF%E5%9C%BA%E5%85%A5%E5%8F%A3.jpeg [17:52:22] I'm in Calcuta, learning Scala :) [17:53:31] YuviPanda: calcuta is supposed to be amazing [17:53:37] YuviPanda: for chats [17:53:43] I'm told so [17:53:56] I've a nice guide who has promised to take me to the chaat places :) [17:54:24] YuviPanda: super! [17:54:35] btw, http://upload.wikimedia.org/wikipedia/commons/5/5e/Post_upload%2C_multiple_upload_flow.pdf [17:54:57] YuviPanda: I've given mvn install :) [17:55:08] fale: works? [17:55:16] YuviPanda: it's downloading the world [17:55:23] fale: yeah, maven does that :) [17:55:31] fale: but it is *definitely* better than our previous process [17:55:45] which is 'oh, clone this to this location, then import that in eclipse here, and then add this reference there' [17:55:50] some 20-30 steps that are alle rror prone [17:56:14] yeah, I can immagine [17:56:28] dependency management without maven in android is a pain [17:56:34] YuviPanda: error :( [17:56:50] notnarayan: hmm, okay. I've a slighlty different idea in mind for how multiple uploads should look like, but I guess I'll just implement it next week [17:57:34] missing android_home... I've to set is with android-common folder or android tool folder? [17:57:34] fale: pastebin the error? [17:58:14] fale: you need to set it to your Android SDK folder [17:58:21] fale: where did you download the sdk to? [17:58:45] YuviPanda: ~/adt-bundle-linux-x86_64-20130219/sdk [17:58:56] fale: is ANDROID_HOME env variable set to that? [17:59:09] nope, was not setted at all :D [17:59:20] :) [18:01:41] YuviPanda: I need version 15? [18:01:55] fale: yeah. [18:02:01] fale: what version do you have? [18:02:09] YuviPanda: 17 :P [18:02:17] heh :P [18:02:27] hmm, I could just as well change it to 17 [18:02:31] but then I dont' have 17 :P [18:02:44] YuviPanda: standup? [18:02:45] oh, you'll have to change it to 17 in a *lot* of places [18:02:48] fale: get 15 instead :) [18:02:50] notnarayan: nope. [18:02:54] notnarayan: not working today :) [18:02:59] YuviPanda: :) [18:03:05] awjr_away: are you standing up [18:03:12] YuviPanda: you don't work on fridays [18:03:18] YuviPanda: I'm doing it [18:03:25] jdlrobson: yeah, and technically not on thursdays either [18:03:29] well, most of thursday at least [18:03:33] or something like that [18:03:41] jdlrobson: 30 hours a week. [18:04:09] jdlrobson: plus on 3G anyway. [18:06:04] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/gSW2Xw [18:06:04] android-commons/master 8d7b31d YuviPanda: Minor fix to README [18:07:40] fale: sweet :) [18:10:51] YuviPanda: started on my phone :) [18:11:03] YuviPanda: but it thinks I have 0 files uploaded :( [18:11:06] fale: see? It has a ton of dependencies but easy enough to build with maven :) [18:11:07] Maryana: did vibha get the banner designs done? [18:11:11] fale: wait for a bit... [18:11:14] fale: it is syncing [18:11:34] also am i right in thinking as of sunday i will be 3 hours ahead of you instead of 2!?! [18:11:35] YuviPanda: yesterday was faster... [18:11:53] jdlrobson, looks like she's working on it right now - she just emailed in her standup notes [18:11:57] jdlrobson: where are you off to? [18:12:06] wait, didn't I already ask you this? [18:12:07] i'm in austin texas YuviPanda [18:12:10] SXSW [18:12:11] right [18:12:12] austin also has daylight savings time [18:12:14] yup yup [18:12:20] Maryana: so it doesn't go forward? [18:12:24] (this is super confusing) [18:12:26] haha [18:12:31] it's only confusing because of arizona [18:12:40] they did the right thing :P [18:12:44] so 2 hours ahead or 3? [18:12:54] fale: still syncing? [18:12:57] 2 [18:13:05] YuviPanda: still 0 ;) [18:13:15] fale: oooh, right. [18:13:19] fale: this syncs to testwiki :) [18:13:21] fale: not commons :) [18:13:29] test.wikipedia.org [18:13:31] YuviPanda: ahah, that explains :) [18:13:34] you don't have any uploads there I guess [18:13:48] YuviPanda: can I upload freely on testwiki? [18:13:52] Maryana: bat bridge looks awesome. I'm watching the article now [18:13:54] yup [18:14:21] bat bridge! i know the bats migrate south for winter, but i'm hoping they're back by now so you can see them :) [18:16:08] YuviPanda: first image uploaded... and everything is perfect :) [18:16:39] New patchset: Jdlrobson; "Cleanup: Move SkinMobileTemplate into its own file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52879 [18:16:53] fale: :) [18:18:50] fale: fancy fixing a bug or two? [18:21:07] YuviPanda: where is the bug tracker? [18:21:23] fale: bugzilla.wikimedia.org [18:23:42] fale: https://bugzilla.wikimedia.org/show_bug.cgi?id=45575 is a super simple one [18:25:13] YuviPanda: I'm looking into it :) [18:25:55] YuviPanda: are you thinking about a work around? [18:26:21] fale: a workaround would be a simple check that says 'if percent > 100, then just display 100' :P [18:26:25] and would work for now [18:26:35] a larger fix would involve fixing the underlying http library [18:26:36] YuviPanda: I was thinking exactly to it [18:26:48] but the workaround (+ a note) would be good enough, methinks [18:30:19] jdlrobson, can you respond to comments in https://gerrit.wikimedia.org/r/#/c/52326/ ? [18:30:26] brion: did you see that android 4.2 got multi users on tablets ? [18:31:14] jgonera: confused - what's to comment on? [18:31:35] you still have class="search-box" - i'm not sure why that still needs to be in the html even with your comment [18:31:39] i'm fine about mfe-prefix [18:31:52] jdlrobson, well, you saw some problems in the patchset and they've all been responded to, which in turn might make them not-a-problems [18:32:11] well, it's in CSS, so it's in HTML too [18:32:18] i'm confused what munaf is saying [18:32:33] jgonera: so why not remove it from the css as well :) [18:32:47] jdlrobson, so I just remove the styling for the search box? [18:32:49] tfinc: can you poke someone about the RT? [18:32:50] I don't understand [18:33:01] YuviPanda: message the rt on duty staff memebr [18:33:05] YuviPanda: the problem is in the app, not in the http library, true? [18:33:15] fale: the problem is actually in the http library. [18:33:24] YuviPanda: please take a look at notnarayan's designs for post upload actions [18:33:38] jdlrobson, as far as I understand, Munaf prefers the icons to be symmetrical rather than aligned with the content [18:33:38] YuviPanda: where I can find the library code? [18:33:44] fale: it is reporting the 'transferred' correctly, but the 'total' is the 'total' of the file size alone [18:33:45] tfinc: where are those designs? [18:33:53] notnarayan: --^ [18:34:08] Maryana: any major changes going out next week ? [18:34:11] fale: total *should* be total of the HTTP request, which includes other data as well (filename, username, etc) [18:34:14] fale: hence the issue :) [18:34:18] ok jgonera i'm fine with that it's just the opposite of what heather told me [18:34:43] tfinc: http://upload.wikimedia.org/wikipedia/commons/5/5e/Post_upload%2C_multiple_upload_flow.pdf [18:34:45] jdlrobson, and as for search-box - it's used to style both page search and languages search uniformly [18:34:50] I see no reason for removing it [18:34:51] tfinc: fingers crossed, we'll be fixing the commons login bug and will finally be able to publicize uploads [18:35:00] fale: the library is at https://github.com/yuvipanda/java-http-fluent [18:35:02] uploads -> stable ? [18:35:03] heather? [18:35:14] or just blog post [18:35:30] jgonera: you can kill mw-mf-searchForm id though.. [18:35:31] we already have the lead image upload workflow in stable. we'll be adding the "donate image" workflow to stable & blogging about the whole shebang [18:35:36] YuviPanda: Yeah, clearing data wasn't enough. Uninstall/reinstall helps.... [18:35:39] jdlrobson, I'm confused now as to whom we should ask about design decisions [18:35:41] Let me try uploading again [18:35:46] tfinc: can i pm you ? [18:35:51] notnarayan: always [18:35:57] jgonera: the point person for the current iteration - so that's cool [18:35:59] Reedy: okay. clearing data usually doesn't clear cookies stored in the auth area. [18:36:19] i'm confused about what 'post upload' means here [18:36:22] * Reedy uploads [18:36:30] my original comment was because of what i'd been told by heather and you've checked that with munaf - that was all i wanted to check [18:36:39] https://commons.wikimedia.org/wiki/File:US_power_socket_faces.jpeg [18:36:41] Worked this time :/ [18:36:48] (although it still looks broken to me ;-) - i wonder if we should alter the right margin as well.. [18:37:07] tfinc: I think you'd appreciate this: https://commons.wikimedia.org/wiki/File:%E5%8F%B0%E5%B7%9E%E5%B8%82%E6%B0%91%E5%B9%BF%E5%9C%BA%E5%85%A5%E5%8F%A3.jpeg :) Totally new to commons user uploading panoramas in their local language :) [18:37:16] Reedy: yeah, I'm still trying to trace execution to where that could matter [18:37:23] Reedy: did you change your passwords recently? [18:37:27] jgonera: is munaf around? [18:37:30] jdlrobson, I didn't kill #mw-mf-searchForm because there are some slight styling differences and JS uses it to find the right form [18:37:36] YuviPanda: thats awesome. we need more of those [18:37:48] tfinc: yup! That is! [18:37:52] jdlrobson, please do grep -nr "mw-mf-searchForm" if you have doubts about where something is used [18:37:57] tfinc: I'll try to find a way to contact him (no userpage on commons) [18:38:07] jdlrobson, I'm not sure, I haven't seen him today [18:39:02] jgonera: i'll merge this but i still think deprecating use of mw-mf-searchForm would be a good thing [18:39:10] these slight styling differences are probably incorrect [18:39:15] jdlrobson, we can change the name [18:39:18] or we could use better selectors for them [18:39:32] personally i hate using id's unless they are a top level container [18:39:32] YuviPanda: Upon uploading, it should have the date parameter in the Information template [18:39:38] jdlrobson, still, JS wants the specific form, not both forms [18:39:41] It's a default field that shows up rendered even if it's not set [18:39:54] jgonera: which js are you talking about [18:39:57] jdlrobson, I can't see any other way than using ids here [18:40:16] jgonera: i'll do a follow up patch [18:40:21] in my opinion, ids should be used for crucial UI parts that JS needs easy access to [18:40:25] ok [18:40:35] jgonera: you need to rebase though [18:40:52] ok, just a sec [18:41:13] jgonera: sure.. but we have #mw-mf-sq, #mw-mf-header and #mw-mf-searchForm… that seems overkill [18:41:18] Reedy: hmm, so it sets them if it can read EXIF [18:41:19] brion: Awesome [18:41:28] Reedy: oooooh, right. did you tkae this with the camera from inside the app? [18:41:31] jdlrobson, that's true, we have too many of them [18:41:34] :) [18:41:35] GPS date 8 March 2013 [18:41:36] Yeah [18:41:43] Reedy: right. let me add a bug for that [18:42:12] Date and time of data generation 10:35, 8 March 2013 [18:42:17] Date and time of digitising 12:00, 8 December 2002 [18:42:19] say wut? [18:42:35] you must've jumped between timelines [18:43:02] brion: in this context, 'post upload' comes up right after you tap 'upload' [18:43:15] that lets you add optional info [18:44:32] YuviPanda: ok that makes sense [18:44:40] i was thinking it means after…. the upload process :) [18:44:54] it definitely needs a better name :) [18:45:18] YuviPanda: it does :| [18:45:24] suggestions? [18:45:45] tfinc: poked ops, they have the 3 day waiting period between when someone files to when it is granted access, so I've to wait till Monday. [18:46:00] its really part of the upload process and not post upload, why have post upload. [18:46:04] jdlrobson: hi, commented on your patch [18:46:22] would that approach work? [18:46:55] jgonera, munaf thanks you for fixing the chrome asymmetry :) [18:47:08] have you been looking at the mobile design trello board? [18:47:15] yurik: much appreciated! thanks (looks) [18:47:40] munaf and vibha made a wishlist column of little style improvements, and that was one of them [18:48:00] Maryana, I don't even know where the design trello is ;) [18:48:05] https://trello.com/board/mobile-design/5112b893d0cd43cb370062bd [18:48:12] yes thanks :-) [18:48:13] Reedy: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=45909 :) [18:48:23] yurik: so that approach would work.. but 2 things [18:48:29] there's a "story ideas" column on the right [18:48:31] jgonera i asked maryana to organize design work on trello because mingle only assigns things to devs [18:48:48] so please don't worry about maintaining anything on trello, it's strictly task management for vibha/myself [18:48:56] board not found :( [18:49:00] potentially none of those languages might ever be needed - so not sure if it's worth the download (might be better to filter to just the codes i have - not sure if that's possible) [18:49:06] This board may be private. You may be able to view it by logging in. hm [18:49:16] secondly it causes another ajax request rather than 1 - and lots of ajax requests are bad.. [18:49:19] weird [18:49:33] I guess you need to invite me [18:49:42] I just registered as jgonera@wikimedia.org [18:49:55] oh you didn't have a trello account? the board is visible within the org [18:50:00] try visiting again jgonera [18:50:02] although now I think about it - i could just run this query once.. [18:50:19] jdlrobson: two, opposite solutions [18:50:24] weird, should be public [18:50:26] one - they can be made together [18:50:27] ok, works! [18:50:30] :) [18:50:37] jdlrobson: and two - i think if you make the call to get all the languages once, the browser will cache it [18:50:47] yurik: correct on two [18:50:56] can i use a generator to combine the two queries? [18:51:07] YuviPanda: done, how can I test it [18:51:07] haha, most of the things in Story Ideas annoy me too [18:51:08] jgonera the "story ideas" board is where i've been putting random design bugs/etc to create stories from [18:51:09] *? [18:51:09] jdlrobson: what do you mean? [18:51:17] fale: upload a small file [18:51:20] jdlrobson: what data do you need? [18:51:24] actually no worries yurik i know what i'm going to do :) [18:51:32] fale: if it is small enough it should go over 100% without the patch [18:51:34] your change was ironic because i created this a few days ago: https://trello.com/card/make-target-areas-on-left-right-of-the-chrome-search-bar-equal-in-size/5112b893d0cd43cb370062bd/26 [18:51:35] and should clip at 100 with :) [18:51:42] ok, thanks for the link to the board, I'll try to fix those small things from time to time [18:52:05] jdlrobson: yeah - just get the list of languages with a separate call (could be in parallel with get langlinks), and use it as a lookup :) [18:52:16] browser and server will optimize it [18:52:17] jgonera: awesome :) [18:52:37] yeh i think that makes sense [18:54:21] jdlrobson: i guess that patch goes into the abandoned pile :) [18:54:33] yup thanks yurik [18:54:42] np [18:55:15] New patchset: JGonera; "Various fixes to overlay header code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52326 [18:55:30] jdlrobson, ^ [18:55:37] YuviPanda: my question was, How can I make maven use my version instead of yours? [18:55:43] fale: aaah [18:55:45] fale: right. [18:56:00] fale: you updated the library, right? [18:56:15] fale: it's a tiny bit complicated, but not too much :) [18:56:16] YuviPanda: yes, in local [18:56:24] fale: 1. also check out java-mwapi [18:56:55] 1. done [18:57:06] fale: 2. in pom.xml of java-mwapi, change version to 1.4-SNAPSHOT [18:57:29] version of the http-fluent library [18:57:29] that is [18:57:41] that would be line 64 [18:58:08] New review: Massaf; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/52326 [18:58:21] 3. in commons/pom.xml, change version of org.mediawiki.api dependency to 1.4-SNAPSHOT [18:58:30] 4. cd to http library, mvn install. [18:58:36] 5. cd to mwapi library, mvn install [18:58:39] 6. test app by normal install :) [18:58:51] fale: it looks complicated, but is not really. we're just incrementing a version number everywhere [18:59:01] YuviPanda: I see [18:59:04] and this is needed only because the app depends on the http library transitively [18:59:10] via the mediawiki api layer [18:59:15] I'm going out for dinner and afetrt I'm going to do it :) [18:59:23] fale: okay :) [18:59:29] it isn't too complicated, I promise :) [19:01:52] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [19:07:20] New patchset: Jdlrobson; "Bug 44484: Use template to render language section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52173 [19:09:12] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [19:09:44] jgonera: slight regression in your change… [19:09:55] the close button in the search results field in full screen search doesn't line up with watch star icons [19:09:55] jdlrobson, which one? [19:10:05] ok, let me see [19:10:31] you can do as a follow up [19:10:49] i'm not entirely sure what changed there [19:10:54] well would look superweird if it did [19:11:09] the right margin of the input [19:11:48] seems to have gone from padding-right: 23px; to padding-right: 8px; [19:12:02] (#mw-mf-searchForm) [19:12:13] yes, that's because if we already hide the star then we want to expand the input [19:12:35] and if we don't expand the input, there would still be no way of aligning that with stars as they are now [19:12:42] because the input would be too short [19:13:31] no i mean the stars in search results [19:13:43] I'm not sure if elements in the header should be aligned with elements in the content space [19:13:45] change li a.watch-this-article right to 8px [19:13:47] yes, I know [19:13:52] hm [19:14:00] let me check [19:14:59] (clear search text button not close search button) [19:15:04] it just looks odd in current form.. [19:15:12] yes, I know which one [19:15:13] other than that i'm ready to merge [19:19:51] New patchset: JGonera; "Various fixes to overlay header code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52326 [19:19:54] jdlrobson, check it now [19:19:58] thanks! [19:20:18] brion: reminder to take a look at the high priority projects document that erik shared [19:20:24] k [19:20:54] err.. no difference jgonera [19:20:57] ? [19:20:59] huh [19:21:04] let me double check [19:21:07] let me upload a screenshot [19:21:33] http://imgur.com/2m37Wwt [19:21:34] they're aligned for me now :O [19:21:45] (http://i.imgur.com/2m37Wwt.png) [19:21:46] it's not how it looks in my browser [19:22:06] hang on [19:22:43] ahh browser caching my bad - sorry [19:23:48] it's taking time to merge.. [19:24:01]