[00:02:32] New patchset: JGonera; "Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [00:03:49] New patchset: JGonera; "Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [00:08:02] New patchset: JGonera; "Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [00:59:36] tfinc still there? [10:33:08] hi :) [16:43:24] New review: Jdlrobson; "I was wondering what form of English is widely used and a grep of mediawiki suggests American spelli..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/52795 [16:48:11] New review: Jdlrobson; "I'm not to keen on this - the existence in the module ($wgResourceModules['mobile.stable']) is alrea..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/52917 [17:00:39] Hi . . . . any mobile guys here! [17:00:54] for discussion on wiki mobile [17:11:52] Ade: some are lurking and will probably read what you have to say at some point. [17:20:29] I would like to know how is testing carried in mobile based wiki projects [17:20:41] please fill me on the information [17:20:50] you can also mail me - adethyasjce@gmail.com [17:36:26] fale: hey [17:36:32] fale: saw your pull req :) [17:36:35] lookin [17:58:06] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52605 [18:03:18] YuviPanda: I've been able to compile http-fluent but not yet mwapi due to a problem with jmx that I'm not able to fix [18:03:30] fale: jmx? [18:03:49] YuviPanda: and I think that com.sun.jmx will have to be removed as a dependency since is not open [18:03:57] jmx? [18:04:25] I'm including jmx [18:04:26] ? [18:04:28] where, how what. [18:04:30] i'm confused [18:04:49] YuviPanda: [ERROR] /home/fale/java-mwapi/src/test/org/mediawiki/api/tests/MWApiTest.java:[32,23] error: package com.sun.jmx.snmp does not exist [18:05:01] that's weird [18:05:07] fale: also what version of maven are you using? [18:05:19] http-fluent also compiles for me without having to use your patch [18:05:38] YuviPanda: I've made the same change that I made for http-fluent to make it compilable [18:05:51] yeah, something weird is going on [18:05:55] since my maven doesn't need them [18:05:58] fale: what version of maven? [18:06:06] fale: 3.x? [18:06:08] YuviPanda: 3.0.4 http://pastebin.com/vxeSPt22 [18:06:13] hmmm [18:06:46] fale: checking [18:06:55] (I have 3.0.3) [18:09:35] YuviPanda: http://pastebin.com/1zNeJgjP [18:12:12] YuviPanda: the first one was for the patch and this one for the jmx error [18:12:36] fale: hmm, very weird. Let me try my build to see how the dependency tree differs [18:13:48] YuviPanda: oki :) [18:15:01] fale: did you put jmx on /home/fale/jmx-1_2_1-bin/lib [18:15:01] ? [18:15:05] i dunno why it is being included [18:15:09] fale: does that path exist? [18:15:11] if so can you remove it? [18:16:58] YuviPanda: the path exists and inside there is a test file you created [18:17:04] let me try delete it [18:17:40] YuviPanda: it works :D [18:19:08] fale: :D [18:19:08] fale: I don't think I created that [18:19:08] fale: can you try the http lib without your patch now as well? [18:20:52] YuviPanda: https://github.com/wikimedia/java-mwapi/blob/master/src/test/org/mediawiki/api/tests/MWApiTest.java [18:21:02] YuviPanda: https://github.com/wikimedia/java-mwapi/blame/master/src/test/org/mediawiki/api/tests/MWApiTest.java [18:21:21] wat [18:21:22] fuck [18:21:33] :| [18:21:43] YuviPanda: and there is a password to... [18:22:02] fale: that is a password for my localwiki on my dev machine [18:22:02] so is fine :) [18:22:10] fale: remove that import? [18:22:19] YuviPanda: ok, at least your passes are safe :) [18:23:00] fale: a pull req removing that import :) [18:23:08] YuviPanda: oki ;) [18:24:52] fale: thanks for finding that bug :) [18:26:48] YuviPanda: happy to help :) [18:27:20] YuviPanda: my patch is still needed and simply removing that lines brakes the file... I'm going to try to remove all the code that depends on that lib [18:28:10] fale: :D also feel free to kill unused imports and organize those [18:28:10] there should be no code that depends on that [18:28:54] YuviPanda: oh, right... the test are failing because I don't have a local wiki [18:29:06] fale: ah, right :) [18:29:16] install one? :) And change password? [18:29:30] YuviPanda: maybe it would be better to use the testwiki [18:29:48] YuviPanda: so is available to anyone equally [18:30:04] fale: problem with testwiki is that I can't put a password there :) [18:30:17] fale: and it might not be up all the time. [18:30:20] YuviPanda: I was thinking about a dummy user [18:30:28] if you put a password there [18:30:31] anyone can change it :) [18:30:36] YuviPanda: true [18:32:29] YuviPanda: I'm installing a localwiki and I'll create the user as the file requires so we can freely exchange that file :) [18:32:37] :D [18:35:01] YuviPanda: the user have to have special powers? [18:35:10] should be able to upload files [18:35:13] but that is default i think [18:38:53] YuviPanda: admins only ;) [18:42:14] fale: oh. but that's okay, localwiki :) [18:42:36] YuviPanda: over 8 tests, I've made 6 working. As soon as I'll be able to fix 'em all you'll receive a pull request :D [18:43:07] sweeet :D [18:43:15] YuviPanda: I'll pull-request wikimedia/java-mwapi o yuvipanda/java-mwapi? [18:43:21] fale: wikimedia/ [18:43:29] YuviPanda: thanks :) [18:45:31] fale: as for https://github.com/yuvipanda/java-http-fluent/pull/1/files [18:45:36] fale: can you try again without the patch? [18:45:42] since the jmx directory is deleteD? [18:45:49] fale: also, can you rm -rf ~/.m2 before trying? [18:45:58] because it works for me without it [18:46:04] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [19:03:32] fale: tests still failing? [19:03:39] good morning tfinc :) [19:07:34] mornign [19:07:40] * tfinc yawns [19:46:37] YuviPanda: what happened to all the data on http://mobile-reportcard.wmflabs.org/ ? [19:46:51] * YuviPanda checks [19:47:20] clearly is not. let me check [19:47:34] hmm [19:48:41] tfinc: checking [19:48:45] k [19:50:52] well the data is there [19:50:57] i'm unsure why it doesn't show up [19:50:59] investigating [19:56:02] YuviPanda, all those uploaders were banned :) [19:56:25] :D [19:56:31] commons is too hipster [20:17:52] YuviPanda: I've cooked and now I'm back to working on tests :) [20:17:59] wheee :) [20:21:07] tfinc: it seems to be broken independent of me pushing [20:21:12] (I checked it yesterday, it worked) [20:21:16] i'll drop a mail to milimetric [20:21:47] milimetric ? [20:22:58] I forgot his real name [20:23:02] Dan [20:23:08] Analytics team [20:23:43] ahh him ok [20:23:44] brb [20:28:40] YuviPanda: found the problem -.- I'm dummy [20:28:56] fale: oh? [20:29:17] YuviPanda: the images/ folder was not writeable by the webserver... [20:29:27] ouch [20:30:03] YuviPanda: so the code works :) [20:30:08] sweeet! [20:30:11] pull request time! :) [20:30:23] YuviPanda: ya :) [20:30:44] YuviPanda: and the patch in pot.xml is still needed even removing the .m2 folder [20:30:52] ugh. [20:30:56] weird. [20:34:55] fale: were you able to test your 100% patch? [20:40:52] YuviPanda: not yet.... now I'm going to, since I've been busy make the actual code to compile :D [20:40:58] wheee [20:48:16] [java-mwapi] Fale opened pull request #1: Compile fix (master...compile-fix) http://git.io/X2eoLw [20:50:34] fale: merged! [20:50:43] YuviPanda: :) thanks [20:50:48] merging the other one now [20:50:48] [java-mwapi] yuvipanda pushed 3 new commits to master: http://git.io/xBBzlg [20:50:48] java-mwapi/master 706df0a Fabio Alessandro Locati: Fix compile error updating maven version to 1.5 [20:50:48] java-mwapi/master 81ba1f6 Fabio Alessandro Locati: Remove useless and problematic dependency [20:50:48] java-mwapi/master 514970d Yuvi Panda: Merge pull request #1 from Fale/compile-fix... [20:51:03] merged! [20:51:08] YuviPanda: you are faster than the bot :D [20:51:13] hah :) [21:47:42] tfinc: responded with some concerns over erik's mail. do read when you can. [21:53:09] YuviPanda: thanks. i'm going to let those come in over the next hours and then respond afternoon/tomorrow [21:53:13] now its time for lunch [21:53:19] i've worked enough this morning [21:53:22] tfinc: hehe :) [21:53:25] tfinc: happy lunching :)