[00:05:11] where do I report bugs for mobile web uploads? MobileFrontend Beta? [00:06:55] Maryana: when do we get that nifty auto-add-lead-image jazz on the regular site? [00:07:34] tfinc: is MobleFrontend Beta the place on bugzilla to report mobile web upload bugs? [00:07:59] ragesoss - it's there already [00:08:12] Maryana: that bug is? [00:08:33] the lead-image upload workflow [00:09:03] as for bugs, you can report them on bugzilla. we're under mediawiki extensions -> mobilefrontend [00:09:06] :) [00:09:32] beta component or not? [01:25:40] New patchset: JGonera; "Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [01:56:14] New patchset: JGonera; "Close main menu after tapping the content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53305 [03:06:38] New review: Diederik; "This is a more stylistic comment, but maybe we should rename 'X-CS' and not use it in the code. CS s..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52605 [14:48:35] New review: Siebrand; "Jon: these 4 lines of comments damage your code so much that it shouldn't be merged?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52917 [15:28:40] New review: Jdlrobson; "No but it can definitely be improved to solve the same goal." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52917 [15:33:57] New patchset: Jdlrobson; "Bug 43845: Close main menu after tapping the content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53305 [15:35:14] New review: Jdlrobson; "Note we still haven't agreed on a commit message convention so I edited message to support both use ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53305 [15:35:19] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53305 [15:38:48] New review: Siebrand; "Jon: Gerrit completely messed up that URL. Can you use a shortener to make a URL that is not going t..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52917 [15:40:02] New patchset: Jdlrobson; "Story 343: Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [15:42:12] New patchset: Jdlrobson; "Add a generic Drawer view and CtaDrawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [15:42:27] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52943 [15:44:06] New review: Jdlrobson; "Correct it only gets filled via js. :)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/52055 [15:55:54] Yippie, build fixed! [15:55:54] Project MobileFrontend-mac-ipad build #326: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/326/ [15:55:55] * jrobson: Bug 43845: Close main menu after tapping the content [15:55:55] * jrobson: Add a generic Drawer view and CtaDrawer [17:20:09] New patchset: Jdlrobson; "Provide access to the device from javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52054 [17:21:03] New review: Jdlrobson; "I rebased. +1 left (jgonera's +1)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/52054 [17:21:52] New patchset: Jdlrobson; "Story 141: Add siteNotice div to skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52055 [17:22:56] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52055 [17:25:01] New patchset: Jdlrobson; "bug 45465: Increment upload count on successful upload page upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51205 [17:30:18] jcmish: i found the power adaptor for my windows machine yay :) want me to grab some screenshots of that certificate error if i can reproduce it in phone emulator? [17:30:28] OHH [17:30:33] kick butt! [17:30:35] yes please! [17:30:50] ok. it's installing software updates right now, i'll check in on it shortly :) [17:31:05] thanks! [17:31:13] sure thing [17:31:33] what's the point of having a billion devices otherwise eh :D [17:33:47] hehehe [17:33:54] I was totally bummed [17:34:07] because I was hoping there was a simple way to emulate it [17:34:18] but I'm going upgrade my windows machine [17:34:28] and put the emulator on it [17:34:56] * YuviPanda upgrades everyone [17:38:56] \o/ [17:39:12] :P [17:42:21] installing sdk…. whee [17:42:34] :-) do you feel dirty? :D [17:42:43] I just bought windows 8 I do :D [17:42:50] hahaha :) [17:44:30] hehe [17:45:29] jcmish: that reminds me, qgil saw similar cert errors on his meego phone [17:45:48] ohh what's a meego? [17:46:18] nokia's old linux phone thing before they dropped it and went with windows phone :P [17:46:27] ha! k [17:46:27] jcmish, when it comes to browser, WebKit based but not updated for a while [17:46:59] yeah my suspicion is that some of the new certs require a newer root cert than some browsers have [17:47:11] ah thanks qgil [17:47:19] it'll just be easier to get ops to fix it with some screenshots :) [17:47:31] brion: hehe yup [17:47:35] avoids confusion [17:50:01] qgil: hey! Stats about usage of mobile apps at http://mobile-reportcard.wmflabs.org/ [17:50:13] qgil: you can get the raw CSVs from there too if you want [17:53:54] YuviPanda, that helps. Thank you! [17:54:22] qgil: hmm, actually - that coutns only uploads to commons. I'm sure a lot more people uploaded to testwiki as well [17:54:30] qgil: I can run raw numbers for you that are testwiki + commons [17:54:38] qgil: can you tell me what exactly numbers you want [17:55:16] qgil: you probably want commons + testwiki, since people testing would probably upload to testwiki [17:55:41] YuviPanda, but our testing activity was all about Commons, so not really [17:56:24] YuviPanda, stats we are looking for are marked as FIXME at http://www.mediawiki.org/wiki/Mobile_QA/Commons_uploads#Results [17:56:27] qgil: well, it *is* the commons app. The iOS one had a switch that lets you upload to commons, or to testwiki. [17:56:42] qgil: okay, I can get you the first two [17:56:44] in about 15 mins [17:56:53] thanks! [17:57:19] YuviPanda, since we didn't make any mention to testwiki, "our"testers probably just used the default. [17:57:26] default is 'testwiki' :) [17:57:34] ok, then yes :) [17:57:37] yeah :) [17:57:41] will do in about 15 mins [18:03:06] son of a b [18:03:13] uhoh [18:03:19] jcmish: windows phone sdk 8 emulator only works on win8 pro [18:03:21] what happened brion [18:03:25] HAHAHHAHA [18:03:34] i can reinstall it, it'll just take forever [18:03:38] *sigh* [18:03:46] sigh [18:03:51] yup not surprised [18:04:57] hey dfoy [18:05:02] hey [18:05:27] jcmish: well i'll start it installing and will test it again when it's done. wheeeeee [18:05:40] brion: thanks [18:05:53] I'm also updating mine and backing it up but it'll take a while I bleieve [18:06:02] ok [18:12:52] brion: what's your interest in going to google i/o ? [18:13:16] tfinc: i'll pass, should be interesting stuff but i can get it all online after :) [18:14:51] tfinc: hopefully I could go next year :) [18:16:00] brion: YuviPanda: ok. i'll just get one pass for myself then [18:16:25] tfinc: if you get a google glass, dibs on it when we pry it out of your cold, dead hands :) [18:16:46] :) [18:16:48] YuviPanda: you'll have to catch me first [18:17:10] tfinc: :P [18:40:18] ooh i can upgrade that machine to win8 pro without a full reinstall, it looks like. that should save some time [18:52:36] tfinc: brion my eye has been swelling all day, and now my vision is blurry :| going to hit a doc tomorrow, and crash tonight. [18:52:43] :( [18:52:50] YuviPanda: got take care of it [18:52:52] get better dude [18:52:52] go* [18:52:59] yes, will have to do [18:53:03] i can't blink, it hurts :| [18:53:13] it happened some 4 years ago to the same eye [18:53:20] and I needed to get surgery on it to get that fixed [18:53:23] so a little scared. [18:53:39] yikes [18:53:39] plus I'm in the middle of rural-ish Kolkata, without any knowledge of the local language [18:53:46] and without much local support [18:53:59] so, if it bursts out or my eye completely shuts out, I'm so fucked [18:54:01] :| [18:54:13] go to the doctor yes [18:54:20] yes [18:54:44] marktraceur's intern is in the city, so I should poke her and see if she can help come along as translator. [18:54:52] I'm hoping it gets better tomorrow though [18:57:43] fale: how is the patch for the 100% bug coming along? found time yet? :) [18:58:16] "The Windows Phone OS is starting…" \o/ [18:58:33] sslloowwllyy [19:01:58] * Platonides hugs YuviPanda [19:02:07] thanks Platonides [19:02:11] heal soon [19:02:18] will try :) [19:02:23] :) [19:02:35] I just had this short little monologue in my head of what would happen if I... actually lost an eye. [19:02:39] ouch. [19:02:46] still better than losing hands, but.. [19:02:47] okay [19:02:51] good night everyone [19:04:09] New patchset: Jdlrobson; "Disable photo upload menu item when unusuable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51590 [19:04:11] hmm, I should try starting some process off wih analytics before leaving [19:07:15] jcmish: http://bug-attachment.wikimedia.org/attachment.cgi?id=11915 [19:07:37] sweet brion [19:07:46] and for fun… firefox hates that cert too [19:07:49] lemme get more info out of there [19:07:58] ha! [19:09:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=46037 [19:09:28] ahhhh [19:09:36] looking at the ticket yeah that makes sense [19:10:22] oh hey it's this https://bugzilla.wikimedia.org/show_bug.cgi?id=34788 [19:12:06] ha look at all the reated dupes! [19:17:52] *related [19:18:08] so brion this is truly a backend core thing right? [19:18:13] not really something we can do anything about? [19:18:58] jcmish: yeah i'm bugging the ops list about it :) [19:19:16] oh well let me come on over! :D [19:19:19] YUNOFIXSSL etc [19:37:43] i suspect everybody just forgot about it [19:47:36] brion - thanks for the emails to ops! [19:59:56] * BlurryPanda couldn't really sleep [20:00:06] tfinc: Android now has 2x as many images uploaded as iOS :D [20:00:17] nice [20:00:29] BlurryPanda: is http://mobile-reportcard.wmflabs.org/ up to date ? [20:03:26] tfinc: just updated it, up to date as of a few hours ago. [20:03:30] use incognito [20:03:39] BlurryPanda: you got your access to install the cron right ? [20:03:41] qgil: sorry, a bit sick. Can get you the numbers tomorrow. [20:03:43] tfinc: nope [20:03:47] tfinc: so, I got access [20:03:55] but I don't have permissions to do what needs to be done [20:04:07] talking with ottomata on -analytics now [20:05:01] tfinc: apparently ops have a problem with giving 'anyone' free access to host data publicly, so analytics is unsure what to do. Ottomata is writing an email to the ops list, I asked to be on CC. [20:05:15] will keep you updated [20:05:18] BlurryPanda, no worries. take care :) [20:05:20] until then manual updating. [20:09:32] * BlurryPanda goes off to try to sleep again [20:18:22] New patchset: Jdlrobson; "Maintenance: Load minimum possible css / reorg css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [20:18:38] jgonera: any chance you could look at https://gerrit.wikimedia.org/r/#/c/52627/ ? scared of future merge commits... [20:19:40] jdlrobson, sure, will do [20:19:46] thanks juliusz :) [20:19:54] you've made vibha very happy btw :) [20:23:24] chrismcmahon, see an experiment at https://www.mediawiki.org/wiki/QA/Browser_testing/Search_features#Focus [20:23:56] chrismcmahon, would it be good to ave one section for bugs/festures assigned and another one for those looking for a writer? [20:24:11] festures :) [20:24:54] ooops, wrong channel [20:25:00] qgil: not sure. I'd like to encourage pairing on any/all of this automation work [20:25:15] qgil, the link of "Accents should be disregarded" is wrong [20:25:27] links to the upper bug [20:26:07] whoops thanks Platonides my mistake [20:26:13] * chrismcmahon fixes [20:27:40] that looked a too-free reinterpretation of the bug contents ;) [20:28:23] Platonides: fixed, thanks again. (stale copy/paste on my part) [20:28:52] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/Aunifg [20:28:52] android-commons/master bee70b5 YuviPanda: Never show file extension in display title of images [20:28:52] android-commons/master 0978a2c YuviPanda: Make sure that notifications do not display the file extension [20:30:57] [android-commons] yuvipanda force-pushed beta from 6e195c4 to 29abc87: http://git.io/tUPHIg [20:30:57] android-commons/beta 29abc87 YuviPanda: Single squashed commit for converting master into beta [20:31:27] ragesoss: added guards to make sure that upload failure for non-network errors doesn't happen anymore [20:31:40] ragesoss: care to throw stuff at it some time? beta build should be coming online any moment now [20:31:47] (hopefully) [20:32:10] what kind of stuff? [20:32:13] SuperHappyDevHouse speaker in the room BlurryPanda :D [20:32:25] http://schedule.sxsw.com/2013/events/event_IAP3785 Project Android-Commons (mobile) - Nightly builds build #130: SUCCESS in 1 min 48 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/130/ [20:32:36] * yuvipanda: Never show file extension in display title of images [20:32:37] * yuvipanda: Make sure that notifications do not display the file extension [20:32:37] * yuvipanda: Single squashed commit for converting master into beta [20:32:40] ragesoss: any fullstop in the filename was failing, IIRC [20:32:49] jdlrobson: nice :) [20:32:56] oh, that stuff. k [20:33:02] just saw matthew inmans talk as well :) [20:33:27] jdlrobson: I'm going to go do attempt 3 at getting to sleep. My right eye is swollen, and last time that happened I needed surgery :| also in middle of rural-ish kolkata with no language support and limited local support. hurts to close it :| [20:33:39] awwww :( [20:33:42] will listen to your tales soon :D I'm sure you'll write those all up [20:33:43] * jdlrobson hugs BlurryPanda [20:33:49] thanks jdlrobson :) [20:33:54] * BlurryPanda goes off now, at least tries to [20:34:23] ragesoss: also It *should* be putting out .jpg now, rather than .jpeg. Not sure if that is a good idea - a lot of times we avoided overwriting well used files because of extension differences :) [20:34:44] oh, nevermind. It is still putting out jpeg [20:34:45] :) [20:34:53] :/ [20:34:59] should change that at some point [20:35:09] ragesoss: i'm asking the android OS for 'what is appropriate extension for image/jpeg' [20:35:13] it is giving me back '.jpeg' :P [20:35:19] and I'm unsure if i want to specialcase it [20:35:26] jdlrobson: who is the SuperHappyDevHouse person? [20:35:42] a coorganiser - Joel Franusic [20:35:42] ragesoss: do file a bug if you think that should change, otherwise i'm going to leave it as is [20:35:50] ^ chrismcmahon [20:35:59] * BlurryPanda goes to do sleep attempt #4 [20:36:11] oh btw BlurryPanda I and several others had the greatest idea ever for a hackathon.. [20:36:21] won't let me sleep :P [20:36:22] jdlrobson: tell me [20:36:26] i can't go without listening :P [20:36:38] jdlrobson: oh, and that other idea you were telling me yesterday... FF Android implemented it. I sent you a link :) [20:36:45] my uploads are failing [20:37:08] ragesoss: latest beta? [20:37:11] like, 2 minutes old beta? :) [20:37:16] ragesoss: and what uploads? [20:37:29] latest. [20:37:37] hmm [20:37:38] all failed. [20:37:39] ragesoss: what filename? [20:37:41] oh :| [20:37:43] wat [20:37:54] and wat. [20:37:54] oh [20:37:55] that's the filename ;) [20:37:57] one moment [20:40:22] ragesoss: in what I call 'incredibly unhelpful', they have been returning 'unknownerror' from the API :| [20:40:24] ragesoss: try a longer title? [20:40:33] nice [20:40:48] ragesoss: i ended up watching all the videos from the heroes series [20:41:00] ragesoss: i'm debating about picking up the chibi series [20:41:11] brion: do you have an android set top box / TV? [20:41:17] nope [20:41:20] brion: if so, would be interesting to run commons on it and see how it looks [20:41:22] * tfinc is reaching his critical limit of budget planning for one day [20:41:25] what, a device that brion does *not* have? [20:41:28] wow [20:41:32] ha [20:41:43] brion is missing a true android ... android [20:41:48] :P [20:41:56] I hear Katie(?) has a telepresence robot :P [20:42:05] :) [20:42:40] tfinc: glad to find a kindred spirit, in that realm :) [20:42:55] Yuvi, it crashed [20:42:59] ragesoss: found the bug that caused the crash. But what file is it? [20:43:06] ragesoss: do you have any of the chibi series ? [20:43:10] is it a jpeg, a png, or something else? [20:43:12] no [20:43:22] and where did it come from? [20:43:22] jog [20:43:22] jpg [20:43:27] camera? gallery? dropbox? [20:43:34] from gallery [20:43:39] hmmmm [20:43:40] weeeird [20:44:08] tfinc, that no was to you. [20:44:11] ragesoss: wat wat wat without the end '.' uploads? [20:44:31] ragesoss: their actual prints and break the pocket book less [20:44:40] plus i can arrange them in lots of different ways [20:44:44] ragesoss: you've seen the series right ? [20:44:54] * tfinc switches to staff channel for this [20:45:08] nope, crashed again Yuvi [20:45:20] ragesoss: very weird :| [20:45:32] ragesoss: can you file a bug? Might be a HTC vs whatever thing [20:49:38] tfinc: you'll like this - https://twitter.com/BarryTownSC/status/311233905393020929 [20:49:39] okokay, going to try sleeping again [21:14:04] New patchset: Jdlrobson; "Bug 45516: Rewrite getToken function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52317 [21:17:21] New patchset: Jdlrobson; "Disable photo upload menu item when unusuable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51590 [21:18:12] jdlrobson_, I can still see the flash in the footer in your CSS reorg changeset... [21:18:26] how!?! [21:18:27] :) [21:18:58] I don't know ;) [21:19:13] I also had some second thoughts about https://gerrit.wikimedia.org/r/51590 [21:19:44] instead of removing the menu item, maybe we should not have it by default and add it with JS when photo uploads are available? [21:20:33] in css reorg, the flash happens every time I hit F5 on a page short enough (so that I see the footer right away) [21:20:46] this is on Chrome with cache disabled [21:21:41] jgonera: do you mean the collapsing of the footer? [21:22:17] jgonera: possibly - but let's rethink that - we may want to surface the upload feature in future to users who can't upload to see their photos - i'd rather not spend too much time on it [21:22:19] yes and no, I just see a blue agora-like button with a missing message for a split second [21:22:26] jgonera: ? [21:22:26] and when I unflod the footer it's not there [21:22:34] agora button..?! [21:22:40] yeah, the blue one [21:22:49] i'm not seeing this [21:22:55] let me check i've submitted latest version.. [21:23:01] do you have cache disabled in Chrome? [21:23:11] jgonera: in safari i do.. [21:23:24] * jdlrobson_ tries in chrome [21:23:39] jgonera: .. see nothing [21:23:49] ok, I'll try to make a screenshort [21:23:50] jgonera: try https://gerrit.wikimedia.org/r/#/c/53282/ [21:23:54] see if that fixes it.. [21:24:31] also when you disable js jgonera do you see the agora button? [21:25:11] jdlrobson_, this works just fine, I mean the footer collapses after a plit second, but I don't see any agora buttons flashing there [21:25:21] jgonera: i'm totally confused [21:25:28] i see nothing wrong with the footer on my machine :( [21:25:37] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53282 [21:26:54] the button's caption is "" if that helps [21:27:19] it doesn't show up without JS [21:28:22] that's the toggle button.. [21:28:54] the button shouldn't even be there without js [21:29:01] somethings funky with your machine.. [21:29:10] New review: Dsc; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52605 [21:29:21] it's NOT there without JS [21:29:25] but it flashes _with_ JS [21:29:34] tfinc, yt? [21:29:40] that suggests js for toggle code is running before css [21:29:54] and it flashes with a message name instead of a message and it flashes as a big blue agora button [21:29:56] so js is running before css is loaded [21:30:04] are you sure https://gerrit.wikimedia.org/r/53282 doesn't fix it? [21:30:09] ok, wait [21:31:19] merge conflict, ugh... [21:31:43] jgonera: [21:31:47] don't worry i'm rebasing as we speak [21:31:47] New patchset: Jdlrobson; "Cleanup: Introduce mobilediff.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52934 [21:31:47] New patchset: Jdlrobson; "Maintenance: Load minimum possible css / reorg css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [21:31:50] try now [21:32:25] still flashes... [21:32:45] gotta move rooms.. [21:33:18] just checked on Firefox, also flashes, but with a different message [21:33:23] (caption) [21:37:44] jgonera: i don't know what to say.. it works absolutely fine on mine [21:37:49] do you have any extensions installed? [21:37:52] anything that might be causing it? [21:38:04] I don't know, eventlogging? [21:38:06] geo? [21:38:21] alpha beta or stable? [21:38:30] but you know, it doesn't happen without your patchset [21:38:50] stable and alpha, can check on beta too [21:39:13] but it also makes no sense.. [21:39:25] what chrome version? [21:39:44] (it makes no sense as css for toggle buttons loads before the javascript inserts the button in the footer) [21:39:51] jgonera: do you get same problem in other browsers? [21:40:11] Firefox and Chrome [21:40:25] does debug=true have any effect on the situation? [21:40:43] Firefox 19 Chrome 25 [21:40:59] nope, no change after debug=true [21:41:03] ok debug=true does have an effect on me [21:41:05] i can see it now [21:41:25] oh, right, I think I have it on by default on the dev instance [21:41:34] uff ;) [21:42:56] so it seems to be adding the js before the css [21:42:59] think there's an easy way to fix this [21:45:10] ok jgonera unrelated bug - but above fixes it [21:45:16] New patchset: Jdlrobson; "Maintenance: Load minimum possible css / reorg css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [21:45:18] ^ above [21:45:22] can you verify? [21:45:29] i need to disappear very soon [21:46:18] yes, it fixes it, the footer flashes twice but it's not so noticeable [21:46:38] New review: Jdlrobson; "I'm not sure how to test this on a local instance. Code looks fine and I'd love to get this merged a..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47915 [21:46:44] ^ brion any ideas? [21:48:17] jgonera: so are you good to merge? (based on fact this is a small edge case - only effects small articles) [21:48:38] jdlrobson, ok, let's merge [21:48:44] sweet [21:48:51] i also added your tests for getToken :) [21:48:55] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52627 [21:49:06] ok, will have a look at it later [21:49:06] took me a while as hadn't used sinon before - hope i did it right :) [21:50:59] jgonera: should be back on a normalish schedule tomorrow - no more interactive :-( [21:51:26] jdlrobson, hehe, ok, that's good in case something goes wrong during the deployment ;) [21:52:11] yup yup. 2 hrs ahead though :) [21:52:23] so there was a really interesting panel here about how to deal with trolls [21:52:31] degrade site performance for known trolls :) [21:52:53] for super trolls instead of banning them hide their contributions from other users [21:53:02] the result is trolls troll themselves :) [21:53:17] hide their contributions /to/ other users [21:53:30] ^ Maryana something we should adopt?! [21:53:40] it's genius [21:57:29] * brion checks backscroll [21:58:24] brion: was just keen to get https://gerrit.wikimedia.org/r/47915 tested - i have no idea how to test :( [21:58:36] aha [21:59:10] lemme see if i can test that manually [22:00:51] New patchset: Jdlrobson; "Bug 44042: Add #content div to special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52553 [22:00:57] thanks brion - if it's too difficult if you could just let me know how to do it i'll sort that out :) [22:01:17] nah should only take a couple mins [22:01:39] also brion if you get a chance it would be good to get https://gerrit.wikimedia.org/r/#/c/52054/ merged - i have a bad feeling without it we will be allowing banners from desktop on the mobile site. [22:02:15] the CentralNotice team have been a bit speedier with their code review then us :) [22:03:14] action=mobileview is taking forever on this test page, wtf [22:03:35] mm strange [22:05:33] i'm off - battery almost dead so that's a sign ;-) [22:05:36] * jdlrobson salutes team mobile [22:05:58] i swear i'm gonna have to rewrite foreign file repo to make requests in parallel [22:07:46] ok that's working better. lemme install the patch and test :D [22:08:31] ok looks good [22:10:34] New review: Brion VIBBER; "Ok, looks good in a quick test. For future reference, here's what I did:" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/47915 [22:10:37] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/47915 [22:10:44] thanks brion [22:11:00] i've got to go now but make sure https://gerrit.wikimedia.org/r/52054 get's merged or fixed and merged team :) [22:11:18] i'll take a peek :D [22:13:09] New review: Brion VIBBER; "I'm not sure I'd recommend exposing the internal device detection targets; they're frequently mislea..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52054 [22:18:35] Maryana, isn't it redundant that we show the CTA drawer/popup for the watch star and then again we show the message "You must be logged in to watch pages." on the login/sign up screen? [22:19:36] i think it's ok to show again [22:19:43]