[00:00:02] Maryana, I think the statistics for app uploads were slightly too high due to an error in SQL queries but I'll confirm that tomorrow with Yuvi (not much though, nothing to worry about) [00:00:24] ah, interesting [00:00:53] please let me know what you find. i'm doing the fuzzy math for the Q3 review and how close we are to meeting targets now, and i want it to be at least somewhat accurate :) [00:01:01] ok [00:01:11] tfinc there in one sec [00:01:22] wait, is that error in the dashboard or in the SQL tables? [00:01:37] jgonera ^ [00:01:49] dashboard [00:01:55] oh, that's fine. i never trust dashboards [00:01:57] :D [00:02:00] ;) [00:03:03] http://vimeo.com/61275290 [00:03:22] awjr: tfinc Maryana jgonera :) [00:03:28] ^ [00:06:50] awjr: http://lists.wikimedia.org/pipermail/maps-l/2013-March/001239.html [00:07:30] haha [00:09:39] jcmish: i don't like how that was a man trying to convince a lady to use technology, though. i had to teach my husband how to write html markup for blogging, how to edit wikipedia, how to use google reader… [00:10:10] HAHHAHAHA [00:10:24] Maryana: technology does have it's limits :D [00:11:37] heh, i'm sure there's some team at google committed to solving this problem with an app [00:11:44] HAH [00:14:31] according to my queries, we now have 81 unique uploaders via web and 55 via apps [00:14:57] however, I count people who use both web and apps double... [00:15:04] I don't know how important that is [00:21:13] oh, that's interesting [00:21:19] did you filter out staff? [00:21:44] all my queries involve and elaborate string of event_username != "Jdlrobson" ... [00:21:48] *an elaborate [00:22:37] no, I'm not filtering out staff [00:25:09] just subtract about 6 people from web and 4 from apps [00:36:20] well, I'm not going to hard-code this, I'll subtract them in my mind [00:36:41] also, 1 less uploader, I didn't filter out testwiki [00:43:00] New patchset: awjrichards; "(mingle #410) Add X-Analytics request/response header handling support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52605 [00:45:36] dont filter out staff. if staff are effecting our numbers that badly then we've put out a product that is not right for our broader audience [00:45:45] and needs to be redone [00:45:47] Maryana: jgonera --^ [00:47:14] awjr: i forget if i've told you but i'm really happy with the Nexus4 [00:47:29] Maryana: http://commons.wikimedia.org/wiki/Category:Uploaded_with_Mobile/Android now needs pagination for we have more then 200 photos :D [00:48:08] i worry for the commons contributor who was in front of this http://commons.wikimedia.org/wiki/File:S%C3%ADdli%C5%A1t%C4%9B_%C5%98epy,_9030.jpeg [00:49:06] omg, so cool! [00:49:28] Maryana: and we've gone meta http://commons.wikimedia.org/wiki/File:HTC_Hero_with_CyanogenMod_7.jpeg .. phones taking pictures of phones [00:49:57] haha, so many pictures of sage's baby [00:49:58] Maybe the driver is a lie, and it's actually going away from him [00:50:21] were also being used to take photos at conferences http://commons.wikimedia.org/wiki/File:Claire_Macken_at_Openltu.jpeg [00:51:14] Maryana: what did Erik say about unique uploads per month ? [00:51:26] mwhahah http://commons.wikimedia.org/wiki/File:Boston_University_terrier.jpg [00:53:18] and we've hit the big time now that were being used to take photos of Lil Wayne [00:53:47] well .. add photos in this case [00:54:55] tfinc, but I still filter out testwiki, right? [00:55:02] jgonera: yeah [00:57:59] tfinc awesome :) [00:58:06] ok folks im outta here - see you all tomorrow [00:59:02] awjr: seeya [01:37:56] tfinc: just got the response from erik. it's what we thought (e.g., the same 1,000 users can be uploading month-to-month, and that's fine) [01:38:06] good [17:02:20] New patchset: Jdlrobson; "Story 347: Provide nicer filenames" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [17:02:20] New patchset: Jdlrobson; "Make description an input element" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53770 [17:11:51] fatal: reference is not a tree: 2fc49f1f368c324688ef3ff2b6ac75c7784de562 [17:11:51] Unable to checkout '2fc49f1f368c324688ef3ff2b6ac75c7784de562' in submodule path 'MobileFrontend' [17:11:53] sigh [17:12:41] to tree or not to tree [17:13:03] manually updating it from master works [17:13:12] i'll hope it was just a fluke [17:18:29] YuviPanda: would you agree that for account creation if there's a captcha, we should show it *before* asking for username and password? [17:18:43] or at the same time rather [17:18:46] same time [17:18:47] yes [17:18:49] yeah [17:18:49] not after [17:18:56] ok i'm going to need a preflight request :) [17:19:08] brion-apiwork: use the same action [17:19:11] ala action=login [17:19:14] rather than something else :) [17:19:16] yeah [17:19:20] sweet [17:20:18] empty name -> preflight? [17:20:35] gives you back the token and the captcha info [17:20:49] brion-apiwork: hmm [17:21:10] brion-apiwork: do we have any password checks? [17:21:32] like "is this a good enough password"? [17:21:34] 'must be x chars' [17:21:40] yeah there's a minimum at least [17:21:42] 'must not be same as username' [17:21:48] heh [17:21:49] hmmm [17:22:20] brion-apiwork: preflight=true/ [17:22:22] ? [17:22:25] brion-apiwork: or prepare=true? [17:22:34] could do that [17:22:46] or 1 rather [17:29:32] ok good the account creation token doesn't appear to depend on the username etc [17:32:41] brion-apiwork: ah, nice [17:54:02] hehe i can send 'username=preflight' and no password and it gives me a token [17:54:17] noooooo [17:54:20] :P [17:54:25] what if someone wants to register preflight? :P [17:54:40] no problem, then just submit it with the real request [17:54:52] but… it'll feel safer with an extra param [17:55:15] yes, [17:55:23] empty username, password (missing too) [17:56:19] right now it gives an error if username is empty. should i just consider empty username a preflight, or use the extra param? [17:56:30] brion-apiwork: *both* :P [17:56:33] :D [17:57:15] New review: Dsc; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52605 [17:58:42] brion-apiwork: require it be empty (or missing) and also have extra param [17:58:52] YuviPanda: is http://mobile-reportcard.wmflabs.org/ up to date ? [17:59:04] tfinc: not since yesterday, no [17:59:24] tfinc: also jgonera found a bug in my SQL, which was over-reporting the app unique uploaders by about 15. he's fixed it. [17:59:28] tfinc: let me update now [17:59:51] YuviPanda: can i get a total files 30 day upload graph ? [17:59:54] Maryana: is there a hangout we are meeting on? [18:00:20] yes, just gimme a couple minutes to set up :) [18:01:58] tfinc: ? [18:02:17] tfinc: aah, got it [18:02:23] tfinc: yes, you may. [18:05:51] notnarayan, ok, hangout link sent [18:06:01] still wrestling with the camera, sadly [18:07:04] tfinc: "This makes photo scavenger hunts so much easier. Also easier than the web-based Commons upload form. Which is an incentive to get an Android emulator for my laptop... " on the commons app on play store, review :) [18:07:16] YuviPanda: were doing it right [18:07:21] good job team [18:07:26] happens to be from someone in the board of trustees - wonderful trolling, recognizable only to the people who know how completely shitty the android emulator is [18:07:30] now we need to get the iOS contribs moving [18:07:37] getting the app in store is critical [18:07:47] yup [18:07:56] brion and i were chatting yesterday and i'm pushing to get it out at the end of the *next* sprint [18:08:44] yeah, will have to stop working on features and do a lot of stabilization, I think [18:09:16] YuviPanda: where is that comment from ? [18:09:21] tfinc: play store [18:09:23] https://play.google.com/store/apps/details?id=org.wikimedia.commons [18:09:34] tfinc: we've one 1 star, which I believe is when we were crashing due to the SSL bug [18:10:01] 1 out of 12 [18:10:05] not bad [18:10:49] i am disappointed to not see much pickup after the blog post [18:11:01] growth is steady but not large increase due to it [18:11:02] our blog posts don't usually have that much reach, I think [18:11:07] plus we are not really measuring it [18:11:14] you want to see really good growth? CENTRAL NOTICE! [18:11:16] :) [18:11:17] we'll have to drive it harder with a CentralNotice campaign [18:11:24] indeed. [18:11:34] they have the range if we get picked up by the media [18:11:41] that ist rue [18:11:45] i think campaigns have the power to be picked up [18:12:39] yup! [18:12:46] should get there fast [18:15:21] with notnarayan's help [18:22:58] YuviPanda: I'm looking at the international reviews [18:23:07] oooh, I didn't. how're they? [18:23:13] "Ha? Wie kann ich mich registrieren? " <-- i can already guess what this means [18:23:23] (my internet is 0.05 mbps right now, so i dare not open any new pages) [18:23:26] YuviPanda: you can easily see them in the dashboard [18:23:29] yup, brion-apiwork is on it :) [18:23:45] i do like this one "Get it The app works really great already, even on a slow phone. It also looks really neat. You should download it." [18:23:52] \o/ [18:24:29] and i see that SJ wrote the comment you sent above YuviPanda [18:24:35] :D yes [18:24:47] I didn't know who he was [18:24:50] he's a good advocate to have and very active [18:25:00] tfinc: indeed. [18:25:15] YuviPanda: he's a current board member [18:25:21] http://wikimediafoundation.org/wiki/Board_of_Trustees#Samuel_Klein [18:25:23] yes, Ironholds told me [18:27:55] awjr: do you have a slide about alpha/beta/stable? [18:28:01] looks like i can make the captcha on user create compat with the stuff that's already in there for login and edit. making food progress, hope to be done by end of day if no surprises [18:28:04] tfinc: yes [18:28:08] # [18:28:11] *good progress [18:28:20] tfinc: well, i was going to talk about the introduction of alpha (and talk a bit around beta/stable there too) [18:28:30] k, then i'll delete my placeholder [18:28:30] brion-apiwork: food progress? :P [18:28:39] must be nearing lunchtime :P [18:28:52] awjr: i'm going to be working on my sections all day so expect questions/comments from me [18:29:00] Maryana: --^ (Quarterly Review) [18:29:08] tfinc: cool, i will be up until deploy time [18:29:09] heh [18:29:36] awjr: Maryana any concern if i share the deck with mobile tech this afternoon ? [18:29:41] tfinc: no [18:36:43] not at all - go right ahead, tfinc [18:45:47] ok i've got the captcha passthrough in theory,,, have to get that to play nice with the token [18:46:48] :D [18:48:08] brion-apiwork: your going to make that 1star german reviewer very happy [18:48:16] :) [18:49:13] YuviPanda: http://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_5 needs an update [18:49:15] err [18:49:19] http://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_4 [18:49:25] doing [18:49:57] brion-apiwork: i'm adding release to market for http://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_5 [18:50:24] tfinc: done [18:51:30] YuviPanda: how much control of the default sharing text do we have ? [18:52:38] tfinc: full. [18:53:10] tfinc: to rephrase, on some providers we have full control. on some, none. [18:53:14] twitter gives us full control, fo rexample [18:53:19] what about facebook ? [18:53:23] those are the big ones [18:53:43] i want to create messaging around this is what i uploaded and you should too [18:53:59] to grow our contributor base [18:54:04] huge potential there [18:54:40] "I just contributed this to the sum of all human knowledge. What did you do today?" [18:54:41] hehe [18:54:58] tfinc: yes, I am planning to do that on post upload [18:55:03] tfinc: but not on the detail view share, since that might from anywhere [18:55:19] tfinc: excellent [18:55:33] when you get it rigged up show me. i'd like to see the flow. that kind of messaging will give us a huge boost [18:58:09] tfinc: yup. post upload, should be on for next week. [18:58:14] i need to look at the design but. [18:58:22] k [19:03:32] Maryana: i added some app slides last night [19:05:05] Maryana: tfinc the Q4 strategy doc says nothing of campaigns, so I'll add some next week [19:05:14] YuviPanda: k [19:20:00] New patchset: Jdlrobson; "Story 440: Promote pageimages to stable on watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53790 [19:24:32] Maryana: what guidance are you prepared to give for projects like WikiVoyage, accountless uploads, and other really far reaching initiatives ? [19:29:04] awjr: can you have more of your slides in before this afternoon? i'd like to have more of your narrative before i share the slides with the teams [19:29:20] tfinc i'll have as much done as i can before deployment [19:29:25] k [19:29:41] tfinc i expect to have something in place for nearly every slide by then [19:29:59] perfect. that it'll be good to share by the afternoon [19:31:22] jcmish: is the betalabs standup still happening? [19:31:42] tfinc: as part of the quarterly review? [19:31:46] Maryana: yes [19:31:58] Erik brought up those specific questions with me [19:32:54] hm. i haven't really thought deeply about it. i think it's a little premature, given that we haven't really defined our primary objective with the mobile space [19:33:15] like, is it primarily an acquisition of new users tool? an empowering existing editors tool? [19:33:22] k, think about it long term but we can say that were not ready to make estimates yet [19:33:56] i can add a slide with some high-level bullet points around this [19:34:24] i should, actually. i was hoping to spend some time in the Q4 planning meetings getting a discussion going about the place of mobile in the wider wikimedia ecosystem [19:34:43] might be good to give erik & sue a heads up about this convo :) [19:35:34] yup [19:36:01] Maryana: what space do you have open to discuss communication for Q3/Q4 ... marketing specifically [19:36:37] maybe right after hitting on the short-term strategy of productizing nearby [19:36:43] there could be a long-term strategy slide [19:43:23] ragesoss: around? [19:43:31] vaguely [19:45:35] ragesoss: https://test.wikipedia.org/wiki/File:Screenshot_-2.png and https://test.wikipedia.org/wiki/File:Screenshot_of_multople_upload.png [19:45:40] YuviPanda, I thought that maybe we should remove generated data (json and csv) from the dahsboard's repo, what do you think? [19:45:53] jgonera: sure, once they are publicly available from stat1001 [19:46:02] jgonera: the data is in the git repo as an interim solution [19:46:08] jgonera: there's an RT ticket about this [19:46:14] YuviPanda, oh, ok [19:46:26] YuviPanda, btw, how often generate.py runs on kripke now? [19:46:43] YuviPanda: not bad. Will it have a description field as well? [19:46:43] because I deployed to mobile-dev and it still doesn't show today's data [19:46:47] jgonera: generate.py doesn't run on kripke ;) [19:46:56] jgonera: there is no cron. I do it manually [19:46:56] ooh... [19:47:02] I can do one run now [19:47:13] no, I can do it too [19:47:13] no problem [19:47:13] ragesoss: you can tap an image to add details [19:47:14] jgonera: ok! [19:47:23] but we'll have it in cron eventually? ;) [19:47:30] jgonera: yup. stat1001 [19:47:30] YuviPanda: what about adding the same thing to all at once? [19:47:33] ok [19:47:47] YuviPanda: I think that's a critical feature of multi-upload. [19:47:51] ragesoss: for desc? How common is that? [19:48:03] ragesoss: for title you add base title, and everything gets a derivative [19:48:17] ragesoss: and thubnail sizing is dynamic - so if you are uploading only 3, you get much larger thumbnails [19:48:22] than if you are uploading 60 [19:48:28] YuviPanda: for me, I do mass uploads with shared base descriptions all the time. [19:48:31] but their minimum values are clamped so that they don't get too small [19:48:55] YuviPanda: that sounds like a good display approach. [19:49:07] ragesoss: hmmm. I see [19:49:24] YuviPanda: if the titles are all in a set, then quite often the descriptions will also be the same or similar. [19:49:39] ragesoss: but how is this as a general design? the other alternative to this was to have one image per screen, and you would have to swipe between them [19:49:47] (titles will still be default auto generated, but no 'overview') [19:50:24] YuviPanda: I like this, I think. I'd have to actually try it out, but overview is nice. [19:50:28] ragesoss: hmm, right. I can add an expando box somewhere that lets you add descriptions and perhaps categories too. [19:50:32] ragesoss: it doesn't upload yet :P [19:50:42] ragesoss: I spent all day getting the display algorithm right [19:50:53] i'm fairly happy with how it works, but could use more tweaking :) [19:51:04] and it scrolls vertically for large sets? [19:51:10] ragesoss: yes [19:51:19] good [19:56:29] brion-apiwork: \o/ [19:56:45] YuviPanda: you saw the mail i just sent? [19:56:49] yes [19:56:53] that's the \o/ for [19:56:56] please give feedback and test if possible :D [19:57:01] will try to :D [19:57:07] brion-apiwork: https://test.wikipedia.org/wiki/File:Screenshot_-2.png and https://test.wikipedia.org/wiki/File:Screenshot_of_multople_upload.png [19:57:08] ? [19:57:23] jdlrobson: what were some of the good articles with the 'has issues' meme? [19:57:37] awjr: i started a blog for this purpose ;-) [19:57:40] ha [19:57:46] YuviPanda: so that's like an initial input of title, and it automatically appends a number on all of them? [19:57:56] any chance to dive in and rename them or just that's what you get? :D [19:57:57] brion-apiwork: multiple uploads implementation work, with adaptive thumbnail sizes. as you type the title is modified [19:58:02] brion-apiwork: yes, you can tap them to add details [19:58:04] http://wikipediahasissues.tumblr.com/ < awjr need to add a few of the best ones though :) [19:58:05] nice [19:58:11] brion-apiwork: and swipe between the tapped detail views [19:58:20] haven't worked out a way to get twitter posts on there in a nice way [19:58:30] brion-apiwork: i spent some time getting the thumbnails to 'auto-resize' - so if you are uploading only 3 files, the thumbs will be much larger, than if you are uploading 60 [19:58:37] brion-apiwork: but they are clamped at a minimum, so won't be tiny [19:58:44] nice touch [19:58:58] I guess that is needed for it to be usable [19:59:08] Specifically, I do not want large empty spaces :D [19:59:39] *nod* [19:59:40] I actually want it to 'expand to cover about 1.5x screen height' [20:00:35] expand screen to 3x its current size. [20:00:40] that'd be a nice feature. [20:00:46] heh [20:01:03] ragesoss: :P coming soon to a replicator near you... [20:01:11] brion-apiwork: I'm thinking if we should start using http://subtlepatterns.com/ [20:01:27] Licensing should be okay [20:01:40] and it isn't iOS-style heavy [20:01:50] mmmmmm light textures [20:02:08] ragesoss: does calling it 'base title' make sense/ [20:02:08] ? [20:02:42] YuviPanda: makes sense to me, although it's slightly inelegant. But I can't think of anything better off the top of my head. [20:02:44] ragesoss: I'm first going to get 'multiple uploads with no way to edit title', then 'multiple uploads with a detail view so you can edit title / description', and only finally 'multiple uploads where you can set base description / categories' [20:02:46] (in order of priority' [20:02:47] ) [20:02:49] ragesoss: yup. [20:02:54] 'Set Title'? [20:02:58] 'Title'? [20:03:24] where does the name of the field appear? [20:03:31] ragesoss: 'hint text' [20:03:31] in grey before you begin typing? [20:03:40] ragesoss: appears before you start typing [20:03:40] yes [20:03:42] I think that is enough? [20:03:49] yes. [20:04:01] it'll be self-explanatory when they begin and the dynamic stuff happens. [20:04:16] but you could actually be more verbose, maybe. [20:04:19] jdlrobson: what's the twitter hashtag? [20:04:38] jdlrobson: what's the twitter hashtg? [20:04:54] there isn't a hash tag (yet) [20:05:06] just search for wikipedia issues [20:05:08] YuviPand: 'title for this set'? [20:05:09] on twitter [20:05:14] or tumblr (little harder) [20:05:46] ragesoss: maybe, yes. [20:06:18] also, square thumbnails [20:11:07] yeah, definitily square thumbs [20:11:19] ragesoss: yup, just did that :) [20:12:27] ragesoss: I'll send you an early dratft to try out in a while :) [21:15:09] Yippie, build fixed! [21:15:09] Project MobileFrontend-mac-ipad build #336: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/336/ [21:15:10] l10n-bot: Localisation updates from http://translatewiki.net. [21:15:47] Yippie, build fixed! [21:15:48] Project MobileFrontend-mac-iphone build #339: FIXED in 9 min 4 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/339/ [21:15:48] l10n-bot: Localisation updates from http://translatewiki.net. [21:22:00] wow. temperature here just broke 100F [21:22:15] first time this year; and unusually early in the year [21:26:29] awjr: does that mean the swamp coolers are coming out? [21:26:56] tfinc surprisingly it was about 40 or 50F over night, so the inside of my house hasn't really warmed up all the way yet. [21:27:02] if this keeps up though, ask me again tomorrow! [21:27:55] wheeee multiple uploads wheee. [21:28:44] jgonera, i have a new app icon/favicon [21:28:49] ragesoss: https://test.wikipedia.org/wiki/File:Bleh_uploafs_-1.jpeg https://test.wikipedia.org/wiki/File:Bleh_uploafs_-2.jpeg https://test.wikipedia.org/wiki/File:Bleh_uploafs_-3.jpeg [21:28:56] i just need to know the various sizes we need to provide for it [21:28:58] http://i.imgur.com/ZjrOArO.png [21:29:02] pretty simple [21:29:24] munaf_, ok, but as I mentioned to vbamba it might need approval from the core people (that's what Jon said last time) [21:29:28] gotcha [21:29:45] well yeah, i know that ios uses naming standards for various sizes of icons [21:29:50] i think android recognizes them too [21:29:52] I'll have a look into that later, probably tomorrow [21:29:55] ok [21:29:56] cool [21:33:02] jgonera are there any configuration changes that you know of for today's deployment? [21:33:23] none that I'm aware of awjr [21:33:39] well, disabling SiteNotice [21:33:58] ragesoss: ping when around :) [21:35:03] jgonera: cool thanks; it will be disabled by deafult :) [21:35:05] er [21:35:06] defaut [21:35:10] >_< [21:35:11] default. [21:51:58] yuvipanda [21:52:19] hey ragesoss. Give me about 5 minutes, I've almost got a build ready for you :) [21:55:15] jcmish: do you have an updated code cutoff for today's deployment? [21:55:28] I do [21:55:35] it's already on the wiki [21:56:00] https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-03-13 ? [21:56:16] yessir [21:56:23] it appears to be missing https://gerrit.wikimedia.org/r/#/c/53601/ [21:56:32] ragesoss: uninstall commons app? [21:56:43] I got my MHL cable today, but it isn't working yet in cm10.1 [21:56:51] ah ran it again this morning [21:56:55] the Play version? [21:56:57] hold please awjr [21:57:06] ragesoss: yes. [21:57:13] ragesoss: and install https://bit.ly/android-commons [21:57:15] (not the nightly) [21:57:22] ragesoss: has multiple upload :) [21:57:23] np jcmish [21:57:25] (an early version of) [21:57:25] awjr: deployment o clock [21:57:27] ragesoss: goes to testwiki [21:57:32] yes indeed jdlrobson [21:57:38] ragesoss: you need to select multiple pics from gallery and send it in [21:58:42] ragesoss: this is exciting :) [21:58:45] jgonera: have you noticed jslint is failing in jenkins now.. any idea why it is ignoring our jshint rc? [21:59:23] it's pointed at Commons? [21:59:25] I noticed, but haven't investigated since it's non-voting and we run jshint locally anyway, maybe when I have more time [21:59:41] awjr: commit b100dfbccea94ed95de5b79794413d2d22f39c7f [21:59:47] nope. [21:59:57] answered own Q [22:00:05] ragesoss: no, to testwiki [22:00:07] awesome thanks jcmish [22:00:19] you bet gonna move it to 3-14 too [22:00:22] ragesoss: don't fill that stash of yours to commons yet - I'll add individual naming, details, etc to this soon [22:00:28] rad [22:00:38] ragesoss: just see how the 'flow' is [22:00:41] (so far) [22:00:47] and how the dynamic thumbnail sizing works [22:03:36] is it supposed to work? [22:03:41] ragesoss: yes [22:03:45] does it? [22:03:50] all failed [22:04:15] ragesoss: hmm? they went to contributions but failed there? [22:04:41] yes. [22:04:50] retry seems to work [22:04:57] one at a time [22:05:26] initially, no notification stuck around. [22:05:36] gerrit seems to be going sloooowwww right now [22:05:46] I opened the app, and saw they all failed. [22:05:55] ragesoss: interesting. [22:06:06] let me add EventLogging [22:06:20] # changed to - in file name [22:06:42] yup, commons doesn't like # in filename [22:06:48] I should put something else there [22:06:52] timestamp? [22:06:53] maybe just put - in to begin with in app? [22:07:06] is that what uploadwizard does/ [22:07:07] ? [22:07:55] IIRC we scrub some things out of titles, yes. [22:07:59] no timestamp. sets by definition are not uploaded at time of creation. [22:07:59] ragesoss: I see one successful upload from you [22:08:08] * marktraceur is hilighted on UploadWizard [22:08:14] yep. manual retry. [22:08:38] ragesoss: try again? That shouldn't really be happening. How many images? [22:08:49] 14 [22:09:04] marktraceur: ah, right. Is there any documentation on stash based uploads? :) [22:09:35] jdlrobson, Maryana, jgonera: E3 is still finishing upt heir deployment so im on hold [22:09:44] :( [22:09:51] ok doke [22:10:02] you want me to poke them to finish up? i'm on 6 in the e3 pen :) [22:10:44] ragesoss: tried again? [22:10:54] (uploading, that is) [22:11:47] Maryana: it's ok, i've already poked ori :) [22:11:54] aighty [22:12:00] they all look really focused [22:12:06] i won't interrupt [22:12:09] hehehe [22:12:48] YuviPanda: "documentation" is a subjective term, we prefer to think of the code as documentation. (in short not really, but what do you want to know?) [22:12:49] yep [22:12:56] failed. [22:13:07] eek. let me try to repro [22:13:18] awjr: i guess i won't be much use this deployment :/ [22:13:37] after I open the app, notification appears, stuck on 'starting' [22:13:40] marktraceur: well... Reading the API docs doesn't really tell me how it works, even what it is. Do I need to specifiy a title beforehand? Which params are required? How long is the 'stash' vaid? [22:13:46] hopefully we'll get to some testing while you're still around jdlrobson [22:13:50] for the first upload [22:13:56] but make sure you let folks know if there's anyting in particular you have concerns about [22:14:15] holy smokes, wunderground.com is saying it's 103.1F in tucson right now [22:14:23] ragesoss: can you try uploading one item? [22:14:29] ragesoss: noral single upload [22:14:34] (they take very different code paths) [22:14:41] i don't think so.. it's just the CentralNotice stuff - i'm still not 100% sure if a banner can be embedded without the #centralNotice div [22:14:50] i didn't get any answer to my earlier mail :) [22:14:59] YuviPanda: It's my understanding that you don't need a title, or if you do, it will be replaced when you finish the upload. [22:15:01] i mean theoretically a banner could be right? [22:15:02] i dont know how it would; i belive that's how it works on desktop jdlrobson [22:15:11] Yuvi via gallery selection? [22:15:18] YuviPanda: Actually, I think you may need a title, because I remember submitting a patch to fix name collisions. [22:15:21] ragesoss: via any way [22:15:30] jdlrobson: mwalker appears to be away right now [22:17:02] yuvipanda works. [22:17:21] ragesoss: eugh. okay [22:17:42] ragesoss: okay, so upload doesn't work. how's the dynamic thumbnail resizing? [22:17:46] ragesoss: is the logic okay? [22:18:59] seems a little off. selecting 8 -> 1 per row. [22:19:41] only fits 1.5 on screen, with keyboard [22:19:46] yeah [22:19:54] ragesoss: how many were there when you selected 14? [22:20:02] two? [22:20:04] ragesoss: this will go 'max' to same size as contribution photo [22:20:07] I think [22:20:07] hmm [22:22:14] selected a *lot*, still two per row. [22:22:28] and you have crash mail [22:22:38] ragesoss: hmm. I think I might have set the minimum to be too high [22:22:45] and the maximum to be too high too [22:24:45] 30 minutes awjr :) [22:26:30] ummm awjr 103 in Tuscan [22:26:34] it's not even summer yet! [22:27:44] performance issues in multi ui too. like thumbnails need to be regenerated after you scroll away and back. [22:27:49] awjr: superm401's scap is still running, but you can stage everything on fenari. i'm really sorry about taking up some of your time, didn't realize you swapped windows :( we can sacrifice our next window to you to recompense. [22:28:10] ori-l, it's ok, we've borrowed the e3 window a couple times now [22:28:17] it's all good in the hood [22:28:48] can I help in some other way? (code review, submodule commits, etc.) [22:29:10] ori-l: no problem :) code review is always appreciated though! [22:29:44] if i stage while scap is running though, won't any updates to code get pushed when things get sync'd? [22:30:51] ori-l: ^ [22:31:14] i didn't think so, but now i'm second-guessing [22:31:50] i'm not super familiar with how scap works but i think it syncs from what's staged on fenari [22:36:30] New patchset: Jdlrobson; "Add ownership statement to photo upload interface" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53876 [22:36:30] New patchset: Jdlrobson; "Add explanation overlay to photo upload view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [22:39:08] awjr: OK, turns out superm401 hasn't started scap yet [22:39:17] so we can wait for you to stage your changes and scap together [22:39:29] or just hold off entirely and let you sync if all you're doing is syncing [22:40:12] ori-l: ok one sec [22:42:15] ori-l: ok, so we have some minor messaging changes that will need to go out via scap, but what i'd like to do is sync our code changes first (after testing on test) and be sure our changes don't have a negative impact on anything before we scap [22:42:45] if changes were to arise after a scap, it might otherwise be difficult to figure out if it was mobile or e3 [22:44:19] sure [22:50:01] ok jdlrobson, jgonera, Maryana, jcmish - changes are up on testwiki [22:50:09] ok [22:50:11] kayo [22:50:18] ok awjr - i'm gonna have to test this on my phone on the move :) [22:50:18] roger [22:51:42] watch list broken for me -A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was: [22:51:49] from within function "DataModelBackendLBFactory::getList". Database returned error "1146: Table 'testwiki.aft_feedback' doesn't exist (10.0.6.46)". [22:51:56] derp. me too [22:52:56] huh [22:53:28] my test account still doesn't allow me to upload :( [22:54:01] looks AFT related [22:54:05] (db error) [22:54:15] ahh its the commons bug kicking in [22:54:48] jdlrobson: you mean the db error? [22:55:08] no for the uploads [22:55:30] not sure what's causing database error [22:55:30] maybe php maintenance/update.php [22:56:16] man searching is SUPER slow [22:56:50] my upload seems to be working but SUPER slow [22:57:32] ok i've got to continue testing on my mobile phone now… i will be offline but will mail in any bugs and an OK when i'm happy it works :) [22:57:43] ragesoss: download and try again? [22:57:48] hope that's cool awjr ? [22:58:04] sure jdlrobson, i htink we'll be fien [22:58:06] *fine [22:58:20] btw i've tracked down one of the aft developers and he's looking into the db error issue [22:59:33] we don't have any major user-facing changes going out today, right? [23:00:12] ok db errors are fixed [23:00:33] k non beta looks good [23:00:41] Maryana: no no major ones [23:00:47] a lot of minor tweaks [23:00:54] okey doke [23:02:42] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/y-ShQQ [23:02:42] android-commons/master f768ce4 YuviPanda: Moved "success toast" from generic UploadTask [23:03:22] jgonera, jcmish, Maryana we have some minor messaging changes going out today but wanted to let you know that they will be going out separately from the rest of the code changes (when ori runs scap after we push our code live) [23:03:41] not the banner stuff right? [23:03:44] ok [23:03:48] correct jcmish [23:03:53] okay cool [23:04:16] ok [23:05:06] yuvipanda: no crash. uploads still fail. [23:05:13] bleh. [23:05:16] ragesoss: jpeg files or png? [23:05:28] jog [23:05:34] jog [23:05:51] im seeing a broken image in the footer, where the logo usually is [23:05:58] jpg damn you autocorrect [23:06:22] my number of uploads is 1 too many [23:06:48] did the location of the copyright logo change? [23:06:53] jgonera: do you know ^? [23:07:07] ragesoss: :D [23:07:16] copyright logo? [23:07:19] the license? [23:07:26] where does it appear? [23:07:32] jgonera: not the license, but the logo that appears in the footer [23:07:37] ragesoss: looks like your UploadService is crashing, I'm unsure why. eugh. [23:07:47] sometimes we just display the sitename, but on enwiki (and testwiki) we show the wikipedia logo [23:07:55] path used to be stylesheets/common/images/logo-copyright-en.png [23:08:36] https://gerrit.wikimedia.org/r/#/c/53493/ [23:08:41] it was you, jgonera :) ^ [23:08:51] hmmm when I hit the watchlist star to login, the login shows up at the bottom of the page [23:09:12] awjr, damn, it was in stylesheets dir even though it's not used in css, my commit removed it [23:09:17] I will bring it back [23:09:21] thnx [23:09:55] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/gKRLSw [23:09:55] android-commons/master e50f50c YuviPanda: Added basic Multiple Upload support... [23:10:21] jcmish: im seeing that too… is that expected, Maryana, jgonera? [23:10:44] yes [23:10:48] you mean the cta? [23:10:49] yep [23:10:53] yeah the cta [23:10:58] yes, expected [23:10:58] k [23:11:07] it's the new standardized CTA for uploads and watchlist star [23:11:07] I didn't remember that :D [23:11:24] and it shows up at the bottom of the screen instead of the top? [23:11:38] awjr, what piece of code is inserting this image? grep finds nothing [23:11:46] jgonera: it happens in config [23:11:59] uh, can we change it? [23:12:09] jcmish, yeah, it would look really weird coming from the top when you hit the lead image upload button, and we wanted to standardize [23:12:10] jgonera: not this second [23:12:19] but before we deploy to production? [23:12:30] jgonera: oh, do you mean the path? [23:12:31] Maryana: okay [23:12:34] yes [23:12:37] on to the next tests [23:12:41] jgonera: lemme check [23:12:47] because else someone will run the image cleanup script someday and delete it again [23:12:54] i forget how this thing works, it's from a looong time ago [23:12:57] it should be in images/ not sytlesheets/.../images/ [23:14:06] jgonera: yeah, updating the path should be trivial [23:14:36] do we also need logo-en.png? [23:14:48] where's the file that specifies those images? [23:14:55] lemme see if i can find it in the config [23:15:04] [android-commons] yuvipanda force-pushed beta from b08db2f to e87d4a7: http://git.io/tUPHIg [23:15:04] android-commons/beta e87d4a7 YuviPanda: Single squashed commit for converting master into beta [23:15:34] jgonera: it's in InitialiseSettings.php - wmgMFCustomLogos [23:15:49] i dont see logo-en.png in there [23:15:52] bleh. Jenkins still down? [23:16:14] is it just the enwiki logo? we're currently grabbing that remotely [23:16:51] ok [23:17:06] Project Android-Commons (mobile) - Nightly builds build #135: SUCCESS in 1 min 5 sec: https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/135/ [23:17:07] * yuvipanda: Moved "success toast" from generic UploadTask [23:17:07] * yuvipanda: Added basic Multiple Upload support [23:17:08] * yuvipanda: Single squashed commit for converting master into beta [23:17:15] not bad. [23:17:28] ragesoss: nightly updated (link is bit.ly/commons-beta). Try that out [23:17:31] I'm going to crash now :) [23:17:32] gnite [23:17:37] ragesoss: thanks a lot for testing :) [23:17:37] see ya YuviPanda [23:17:42] see ya awjr [23:17:45] jgonera: i think logo-en.png is legacy and no longer used [23:17:47] night night [23:18:35] ragesoss: do test it out, and mail me (either success / failure) [23:18:42] if it fails i'll add more instrumentation so we can find out [23:18:46] ragesoss: it works fine for me [23:18:52] bye :) [23:19:45] awjr: is it ok for us to scap? (i lost scroll-back) [23:20:07] ori-l: not yet - soon [23:20:14] np [23:20:14] we're close to pushing [23:20:37] jgonera: you're updating the path to MobileFrontend/images/logo-copyright-en.png? i will update config while you get the image back [23:20:45] New patchset: JGonera; "Restore logo-copyright-en.png" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53887 [23:20:50] awjr, ^ [23:20:55] alrighty things look good [23:21:01] with the exception of the logo [23:21:19] guys, does expanding a section also move you to the top of the section? [23:22:23] I used Barack obama [23:22:32] and expanded one of legislator [23:22:36] and it didn't [23:22:50] I also see a UI problem on Android browser, when I focus search and press the back arrow, the watchstar is inside the search field, but I guess we can fix it later [23:23:03] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53887 [23:23:21] jcmish, I just checked in Android browser, there it moves me to the top when I fold the section [23:23:26] anyone experiencing that? [23:23:55] I'm checking on chrome and my ipad right now [23:23:59] one sec [23:24:43] jgonera: yes when i fold it does take me to the top [23:24:51] but when I expand it behaves correctly [23:24:58] the first thing (star in search bar) only happens when I type something in the search box and then tap back arrow [23:25:01] hm... [23:26:41] jgonera: that one I can't get to happen on the ipad [23:28:27] let me see [23:30:28] ok, logo is fixed on testwiki [23:30:47] woohoo [23:30:50] tis there [23:30:52] jcmish, Maryana are we good to go? [23:30:54] what do we do about other problems? how serious do you think this is? [23:30:58] thanks for getting that fixed jgonera :) [23:31:04] sure, I broke it [23:31:08] :p [23:31:18] Maryana: do you think the other two are big issues [23:31:27] I don't think so but I'll defer to Maryana [23:31:30] i don't have an android phone, so i can't see them [23:31:36] but we should get this fix with this sprint [23:31:41] jgonera, it's your call [23:31:49] doesn't sound too serious [23:32:26] and are those in stable or beta? [23:32:35] stable and beta but not alpha ;) [23:32:42] ha [23:32:52] @_@ [23:33:00] yeah, let's just file those as bugs for this sprint [23:33:00] yup [23:33:04] that's funny [23:33:14] and that's another thing that I broke! [23:33:18] give me 3 minutes [23:33:22] :) [23:33:34] ok jgonera [23:35:10] ok, fix coming [23:35:55] I need to run and get the kidlet [23:36:12] awjr: how long is scaping again? [23:36:51] jcmish: i won't scap, just sync the changes directly, which should only take a few minutes [23:36:57] oh nice [23:37:17] k I'll call the daycare lady [23:37:18] scap is only really needed with message changes [23:37:19] and hang out [23:37:29] thanks Reedy [23:37:40] it's all still fuzzy to me [23:37:42] reedy's doing daycare for you now? :D [23:37:49] omg [23:38:00] HAHAHHA [23:38:04] Maryana: Did you not see the child stashed under my desk? [23:38:04] New patchset: JGonera; "Don't call closeNavigation() on touchend if no menu closed" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53891 [23:38:10] awjr, ^ [23:38:15] A man of many talents! [23:38:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53891 [23:38:42] grr, wrong commit message [23:39:16] reedy: that's one off-color joke away from an HR pamphlet [23:39:17] oops already merged :( [23:39:27] hahahahah [23:39:30] nevermind, not a big thing [23:40:49] so are we all synced? [23:40:58] e3 is chomping at the bit to scap [23:41:13] Maryana: almost, im just getting juliusz's change on testwiki [23:41:19] kk [23:43:32] jgonera, Maryana, jcmish ok jgonera's change should be live on testwiki [23:43:44] k thx [23:43:57] looks good [23:44:03] w00t [23:44:21] jcmish, Maryana look good? shall i sync? [23:44:40] looks good [23:44:52] expanding and collapsing work :D [23:44:59] ok lemme just get this last config change in and i'll sync [23:45:04] awesome [23:45:07] thanks, team :) [23:46:41] ok syncing [23:47:21] ok changes should now be live. [23:47:29] k testing [23:47:30] jcmish, jgonera, Maryana ^ [23:47:52] wow, do fast? [23:47:54] so* [23:48:30] jgonera: yeah, just syncing changes is a helluva lot faster than scap (which also refreshes message cache) [23:49:06] lgtm [23:49:31] I really need to find time to change those translations for Polish mediawiki... [23:49:48] https://pl.m.wikipedia.org/w/index.php?title=Specjalna:MobileOptions seriously, this shouldn't be that long [23:50:06] hmm actually im getting some js problems, but they might fix themselves with the RL cache refreshes [23:50:23] where? [23:50:31] on stable on enwiki [23:50:40] sections are loading uncollapsed and are not toggle-able [23:50:49] oh, now it's fine [23:51:26] jgonera, it's pretty long in ukrainian, too... [23:51:29] blah [23:51:39] maybe the description is not good [23:51:49] actually, I think even in English it should be only Settings [23:51:52] not Mobile Settings [23:52:00] I mean, it's obvious [23:52:30] oh, it's "mobile site settings" [23:52:31] i like how people have translated "here be dragons" [23:52:33] alrighty beta and non beta look good [23:52:39] in ukrainian it's "you are entering a dangerous realm" [23:52:39] on to alpha [23:52:49] oh hahhahaa nice Maryana [23:52:52] now I need to go look [23:52:53] ok cool, cluster looks healthy (to me, although it's only been a few minutes) [23:53:07] well, that's better than Polish, where it's not translated at all ;) [23:53:14] aww [23:53:19] i guess they don't have dragons in poland ;) [23:53:27] nope, long gone [23:53:47] ok ori-l we're clear [23:54:20] awjr: thank you [23:54:24] thank YOU ori-l! [23:54:44] yes, for graciously giving you your own window :P [23:54:55] our rescheduled window [23:56:40] the "here be dragons" article is weak. nothing about contemporary usage. [23:57:05] even though that's why it exists at all. [23:59:00] In case Maryana didn't say, I'm doing a scap for you guys as well as our (very late) deployment