[00:42:20] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/O_N12Q [00:42:20] Commons-iOS/master a398c60 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [00:45:51] [android-commons] siebrand pushed 1 new commit to master: http://git.io/cyaD0g [00:45:51] android-commons/master 534ac65 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [00:48:37] Project WiktionaryMobile - Nightly builds build #120: SUCCESS in 13 sec: https://integration.wikimedia.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/120/ [00:48:38] s.mazeland: Localisation updates from http://translatewiki.net. [00:49:05] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/xQpZnA [00:49:05] WikipediaMobile/master 17db186 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [00:49:12] Project WikipediaMobile - Nightly builds build #499: SUCCESS in 10 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/499/ [00:49:13] s.mazeland: Localisation updates from http://translatewiki.net. [02:07:14] New review: Ori.livneh; "Yes, having a consistent implementation for desktop and mobile would be good." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54099 [13:47:41] howdy yuvipanda! [13:47:52] hello ragesoss [13:47:52] back in a different town [13:47:52] (Chennai) [13:47:53] hence [13:48:04] what a shitty city [13:48:38] :) [13:48:53] ragesoss: thinking of delaying release of beta by a day so that I could get multiple uploads 'in' [13:49:33] ori-l: does EL discard events if an enum does not validate? [13:49:49] ori-l: I want to add another item to the enum, but don't want to mess with the datatables [13:57:42] PissedPanda: delaying for multi-upload seems reasonable. although it's beta, so updates on consecutive days are not a big deal (imo) [13:57:56] sure but that fragments the user base. me no likey. [13:58:00] (says the person testing 5 versions per day) [13:58:04] yeah :P [13:58:15] it still crashes on yours, right? I'm worried about that :( [13:58:40] yeah, medium and large multiuploads still crash the uploader. [13:59:27] I actually had, I think, the Play beta crash randomly on my other phone. I don't know when, I discovered it this morning with the crash report dialog open. [13:59:46] I thought it was the nightly (and old) so I didn't send it. [14:00:17] I'm not sure what happened with that phone, but it's my quasselcore device and that crashed too last night. [14:03:24] ragesoss: sigh. [14:03:52] ragesoss: I'm doing a minor architectural change that should keep state related crashes to a lesser extent [15:24:23] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54470 [16:28:45] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53631 [16:35:10] morning all [16:35:24] special greetings to our new department member yurik [16:35:25] * YuviPanda waves at tfinc [16:35:32] yurik: hows it he morning treating you so far ? [16:35:41] yei! talking to HR on the phone, be back soon :) [16:35:51] goood to be here!!!!!!!!! [16:35:51] YuviPanda: can you update http://mobile-reportcard.wmflabs.org/ ? [16:35:54] ooo, yurik's joined us? [16:35:59] tfinc: I just did about 5 minutes back [16:36:18] yurik: take your time. today is crazy busy with the quarterly review [16:36:58] tfinc: the meeting goes on till 5AM for me. I'm unsure if I could make the entire thing, and if I do, how useful / awake I'd be. [16:38:01] YuviPanda: "Glad to have you. Mute yourself before you start snoring." [16:38:10] was my response to you just now [16:38:20] tfinc: http://www.threadless.com/product/4763/Nyeinstein/tab,guys/style,shirt :) [16:38:22] haha :P [16:38:39] nice [16:39:00] YuviPanda: screwed up caching is killing me on http://mobile-reportcard.wmflabs.org/ [16:39:07] YuviPanda: where is the bug tracking this issue ? [16:39:22] milimetric told me that they're aware of it, and working on it. I'll ask him for a bug [16:39:28] open one if there isn't [16:40:04] ok [16:44:19] tfinc: we've figured a workaround. [16:44:29] * YuviPanda tests that [16:46:36] yurik: i'll be in and out today due to the quarterly review 12:30 - 3:30 . brion will be acting as your buddy. he should be in shortly [16:46:52] sounds good :) [16:47:50] yurik: are you in the office? [16:47:53] yurik: but feel free to reach out to me at any point. email is best [16:50:01] awjr_away: you about ? [16:50:10] awjr: slide 38 [16:50:21] tfinc looking [16:50:34] tfinc: are the slides up somewhere for us to look at? Or do we just have to wait? :) [16:50:55] YuviPanda: i shared them with mobile-tech [16:51:08] ah, right [16:51:10] thanks [16:51:58] tfinc: love the limechat screenshot :) [16:52:05] YuviPanda: mwhaha [16:52:06] yes [17:13:00] is Adam on IRC already? [17:13:12] tfinc: awjr notnarayan sent me a text saying that there is a blackout at his place and hence he is not on [17:13:23] MaxSem: no. adam doesn't have his laptop yet [17:13:28] YuviPanda: k [17:13:33] awjr: no hangout on the invite [17:13:44] back [17:14:06] tfinc: i updated the invite [17:14:16] yurik: we just finished our morning standup for app and web [17:14:22] YuviPanda, will be in the office next week [17:14:33] brion was just walking adam over to HR. should be back soon [17:14:49] yeah, i just finished figuring out the wellness plan details :) [17:15:03] * yurik contemplates a personal spa at home... [17:15:11] * YuviPanda sips tea [17:15:35] do they make jacuzzi-proof laptops? [17:16:16] yurik: I believe sony has a few of those [17:16:23] on the plus size - jacuzzi proof laptops [17:16:26] on the minus side - sony [17:16:34] exactly my thoughts :) [17:16:57] including their weird buble-gum shaped memory stick [17:17:17] lol, I use Sony now. simply cuz it was the lightest 15" laptop on the market ATM [17:17:45] yeah, regrets are there [17:18:01] * YuviPanda should get a carbon x1 sometime [17:18:09] i heard lenovo is coming out with something nice [17:18:19] i kinda liked them when it was still ibm [17:18:22] a good workhorse [17:18:25] rock solid [17:18:26] yeah, still the case [17:18:33] ...but ugly [17:18:35] except ofcourse, they don't sell in India [17:18:58] MaxSem: X1 is a sweet looking machine. Nikerabbit has it [17:18:59] nah, i don't need a choice of colors in my laptop, functionality is always more important [17:19:17] Unable to checkout 'a540bf09f0117075d1437331d06307216a793cb0' in submodule path 'MobileFrontend' [17:19:22] yurik: functionality + build, I guess [17:19:23] that's getting annoying [17:19:28] i wonder if i messed up my repo somehow [17:19:43] brion, CTRL+A, Shift+Delete [17:19:48] :) [17:20:10] trying: rm -rf MobileFrontend; git reset --hard; git submodule update [17:20:16] brion, so are you the one walking me through how to check stuff into gerrit? :D [17:20:24] (same thing) [17:20:38] yurik: might be :) you already set up or do we need to go through the steps? :) [17:21:09] of course! all those +2 i gave out were simply me experimenting with the interface :D [17:21:43] :P [17:22:17] at first i thought +2 meant - yeah, I really dig that patch [17:23:49] we should go up to +11 [17:23:55] :D [17:24:17] yes, and an independent approval process for each level! [17:24:45] --how's your patch -- oh, its really good, made it to level 3 already! [17:25:10] instead of +2, just +11. that'd be pretty rock 'n roll. [17:25:29] make our gerrit standout. [17:25:37] but that's +3 for the decimal-oriented. I say +10 is better [17:26:03] tch tch. +42 [17:26:12] or rather, you need to get it to +42 to merge [17:26:18] http://www.youtube.com/watch?v=EbVKWCpNFhY [17:27:36] :) [17:32:19] YuviPanda: dropped! (well, logged to a flat file) [17:33:40] ? [17:33:51] what was that a response to? [17:33:53] i'm confused [17:35:37] nonvalid events don't make it to the database [17:36:03] ah [17:36:04] right [17:36:13] ori-l: so I'll need to edit the schema, and split the thing [17:36:27] split what thing? [17:36:54] ori-l: split the data [17:37:00] ori-l: since there will be a new table [17:37:09] ori-l: despite the fact that the only addition will be an extra value in the enum [17:45:13] New patchset: Jdlrobson; "Uploads page: Support descriptions that the Commons app uses" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54492 [17:50:57] tfinc: brion headsup, shankar texted me again. Still blackout, no power. He won't be there for the meeting in 10 [17:51:15] YuviPanda: k [17:51:23] brion: did you catch a yurik in here ? [17:51:41] yep, but turns out i already know how to use gerrit :) [17:52:02] \o/ [17:52:05] MaxSem: could you take a look at https://gerrit.wikimedia.org/r/#/c/53790/ - would be nice to get that into stable [17:52:07] YuviPanda: ok [17:52:16] yurik: who would've thought :P [17:52:30] YuviPanda: did he push out another multiple upload/post-upload mockup or do we need to shake him down later? [17:52:34] nah, i'm actually still strtugling... my tabs are still 8 spaces long :D [17:52:44] 4 spaces or die! :) [17:52:52] 2! [17:52:56] good enough for review [17:53:09] mm... 3 would make a fine round number [17:53:23] brion: he did send me a couple of them but they weren't super complete or clear [17:53:25] let me find links [17:53:43] brion: https://commons.wikimedia.org/wiki/File:Post-upload.png and https://commons.wikimedia.org/wiki/File:Post-upload-1.png\ [17:53:53] not very clear, as I said [17:54:50] awjr, I think I know what might be the problem, I didn't have a memcached php driver installed, but mediawiki didn't complain, probably failed silently... which one do you use, php5-memcache or php5-memcached? [17:56:14] YuviPanda: ok i think i can see some flows in https://upload.wikimedia.org/wikipedia/commons/3/38/Post-upload.png -- click pencil for 'edit mode', it pops up the overlay, you can modify it [17:56:19] needs a way to dismiss and stuff :) [17:56:25] we'll poke him later [17:56:36] brion: that's 'edit' rather than post upload [17:56:37] jgonera: ! [17:56:39] lemme see [17:56:42] hmmm [17:57:26] jgonera: php5-memcached [17:59:27] brion: are you in the hangout? [17:59:29] am I in a wrong one? [17:59:43] not yet [17:59:49] tfinc is talking with howie [17:59:50] ah [17:59:51] ok [18:00:04] where is that hangout? [18:00:33] New review: Yuvipanda; "I'll just note that this is used by all of commons ({{Information}}) rather than just the mobile app..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54492 [18:01:23] brion: I lost you [18:02:02] brion: you're still lost :) [18:02:54] brion: tfinc i've lost you [18:03:05] YuviPanda: we'll be back after this commerical break [18:03:09] :D [18:03:48] jgonera: does that help? [18:04:21] awjr, it might, but I found another problem, I'm trying to fix it now, I feel I'm getting closer ;) [18:05:05] it works! [18:05:10] YES! [18:05:27] let me now try if I can reproduce Safari's behavior on this [18:14:27] YuviPanda: can you +1 in MobileFrontend? [18:14:44] jdlrobson: that patch? or in genearl? [18:14:47] *general [18:14:49] both :) [18:14:53] could do with some help [18:15:10] would be nice to see some of this stuff deployed tomorrow.. [18:15:23] in particular photo uploads related code [18:15:27] e.g. https://gerrit.wikimedia.org/r/#/c/53769/ [18:15:43] * YuviPanda clicks [18:16:10] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53790 [18:24:03] New review: Yuvipanda; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [18:24:24] jdlrobson: I'll leave comments where I see them, but mostly refrain from -1 or +1 since I do not know the MF codebase well enough [18:24:30] that's cool YuviPanda [18:24:35] thanks - appreciated [18:24:39] I just left one. Have one more comment in another one [18:33:28] New review: Yuvipanda; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54492 [18:33:53] jdlrobson: done. do poke me if there's anything specific you'd want me to take a look at :) happy to help :) [18:34:03] thanks YuviPanda ! [18:37:45] New patchset: Jdlrobson; "Fix jshintrc for jenkins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54507 [18:50:45] New patchset: Jdlrobson; "Bug 45516: Rewrite getToken function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52317 [18:51:38] New patchset: Jdlrobson; "Add ownership statement to photo upload interface" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53876 [18:51:49] New patchset: Jdlrobson; "Add explanation overlay to photo upload view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [18:52:01] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:52:13] New review: Brion VIBBER; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [18:55:40] New review: Brion VIBBER; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54507 [18:59:31] New review: Yuvipanda; "In general, parsing WikiText is a Bad Idea(TM). See https://www.mediawiki.org/wiki/Requests_for_comm..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54492 [19:00:33] New review: Yuvipanda; "I meant 'parsing wikitext with a RegEx'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54492 [19:03:54] YuviPanda: http://commons.wikimedia.org/wiki/File:Post-upload.png [19:04:03] brion: ^ [19:04:05] hey notnarayan. [19:04:13] YuviPanda: i have power :) [19:04:15] awjr: chip and i are setting up early in R66 [19:04:31] cool tfinc [19:04:43] i just practiced my presentation sharing and got it figured out [19:04:48] sweet [19:04:48] you may find me lingering in the hangout [19:04:57] tfinc im gnona run and wolf down some food real quick [19:04:58] YuviPanda: and I'm hanging near the staircase getting bitten by mosquitoes so i can leach of CIS internet. [19:05:01] k [19:05:09] awjr: we'll want you back before 12:30 [19:05:11] :) [19:05:13] to test video and audio [19:05:21] YuviPanda: its surprisingly weak today :( [19:05:23] tfinc yup no problem [19:05:26] notnarayan: no hasgeek wifi? [19:05:27] awjr: be back by 12:15 [19:05:37] YuviPanda: flaky. [19:06:00] flaky indeed. sigh [19:06:02] brion: saw that link? [19:06:19] hey [19:06:23] notnarayan: this is much nicer :) [19:06:30] how will the 'share' things work? [19:06:35] YuviPanda: glad, glad, glad. [19:06:38] you tap them and they open out to the appropriate app? [19:06:47] New patchset: Jdlrobson; "Fix jshintrc for jenkins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54507 [19:06:58] YuviPanda: yes [19:07:00] does that take you away from the half-complete info you were about to update on the image? [19:07:26] YuviPanda: any idea if vibha and maryana would be here ? [19:07:42] notnarayan: Unsure about vibha, but I guess maryana is going to be out all day. 3 hour review meeting coming up [19:07:47] ragesoss: hmm, good point [19:07:48] YuviPanda: yo [19:07:56] hi ragesoss [19:07:57] ragesoss: you can come back and add it, I guess [19:08:47] YuviPanda: the image detail view will have an edit action that would launch the same flow, except of course, no title [19:08:51] how about the update button(s) at the bottom. [19:08:54] one for simple update [19:09:01] others for update & share. [19:09:41] an update button, and a checkbox or radio bubble for the things you want to share to. [19:09:58] (If it's in the other app, I guess only one share target at a time is possible?) [19:10:04] i'm unsure about having update & share on the same screen [19:10:14] as the primary action on the view is "upload" and then "update" i thought it would be much nicer to have them in one place [19:10:39] yeah, perhaps we could split those two? [19:10:44] can you update multiple times? [19:10:44] sharing feels more like a 'do something with this' action [19:10:51] especially if it's to include things like reposting to flickr [19:10:52] yes [19:11:00] do we want to commit to specific services like that? [19:11:28] share single view via intents, instead? [19:11:53] probably not as prominent as we want, though, to actually encourage sharing on social media [19:11:57] that'd be my inclination, especially at this stage of development it's easier to not have to add lots of target-specific support [19:12:57] but in theory somewhere alongside sharing would be a great place to add actions like 'add to Wikipedia article' [19:13:57] what did I miss? [19:14:23] we decided that Android isn't working out. it's iOS only from here on out. [19:14:37] and Windows Phone and Blackberry. [19:14:48] yeah, that goes without saying. [19:14:59] brion: so we don't have to commit to those. I think we can 'iterate' through the registered services and present them that way [19:15:05] no commitments, etc [19:15:19] notnarayan: also multipl euploads? [19:15:24] hmm, i'm not sure i can on iOS. will have to consider it :D [19:15:58] brion: :P [19:17:43] notnarayan: how is the flow going to be for multiple items? [19:18:34] YuviPanda: we are doing a single field entry for my uploads. so the flow itself won't be different. just that the view will show multiple images stacked one below the other [19:18:45] YuviPanda: ill work on that tom [19:18:50] \o/ first mobile commons genitalia ! [19:18:54] notnarayan: it's not *just* single field. [19:19:05] notnarayan: you could always tap on the image and add more details [19:19:15] so it's a combo of single field initial + deep dive editing [19:19:23] jdlrobson: link! [19:19:30] https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit [19:19:37] oh god [19:19:38] my eyes [19:20:50] YuviPanda: will work on that tom. got to go now. will ping you tom. [19:20:55] ok [19:20:56] bye [19:30:22] tfinc: brion I could harldy hear Sue. [19:30:35] yeah we're working on it :D [19:31:29] :) [19:31:36] brion: who is the person sitting right next to you? [19:33:37] hmm, how come i can't join the hangout? [19:33:44] YuviPanda: i'm terrible with names, i've forgotten :) [19:33:50] brion: hahaha :D [19:33:57] yurik: are you signed in on a personal google account? [19:33:58] yurik: try with your wmf account? [19:34:08] you might have to log out out the personal one, it's flaky otherwise [19:34:11] yurik: if that doesn't work, open incognito, paste in url, login with your wmf one [19:34:18] (I always have to use incognito) [19:34:23] i signed into both, but let me double check [19:34:24] yurik: also if you're using Ghostery... disable taht :) [19:34:28] i just use two browsers :P >_< [19:34:28] yurik: both causes problems [19:36:17] \o/ [19:37:49] \o/ [19:37:56] that table just looks so fun. [19:40:32] tfinc: I can hardly hear erik [19:40:44] awjr: ^ can you? [19:41:01] YuviPanda: im having a tough time hearing erik and sue [19:41:08] yeah, me too [19:41:10] brion: ^ [19:41:27] *nod* [19:41:41] maybe we can move the mic closer to them since i expect we'll be hearing feedback form them through the review [19:41:41] note to self - WiFi is just not good enough in NYC - even when sitting a few feet from the router [19:49:42] brion: can you ask tfinc to switch back to video, rather than screenshare? [19:50:07] YuviPanda: done [19:50:12] \o/ [19:50:21] was about to write it in a big font and turn my screen around ;) [19:50:42] haha :) [19:50:55] ALL CAPS MESSAGE PASSING! [19:51:17] New patchset: Zfilipin; "Makes it easy to create new Jenkins job to run Selenium tests from MobileFrontend repository" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54519 [19:52:06] Maryana: my laptop is queued to the q3 slide [19:53:04] sweet, thanks tfinc [19:53:49] Maryana: i have the speaker notes as well for you to use [19:54:47] die phonegap die! [19:54:52] :) [19:55:15] * YuviPanda puts 'write non-obscene post about what was bad with phonegap' in his queue [19:55:34] :) [19:56:21] YuviPanda, "this page was intentionally left blank"? [19:56:28] :D [19:56:41] MaxSem: I wrote one, but it was... too expletive filled. [19:56:49] link? [19:57:01] MaxSem: it never made it out [19:57:15] MaxSem: tfinc convinced me that the point I was trying to make would be overshadowed by the expletives [19:57:51] and people would stop paying attention [19:57:55] yeah [20:00:42] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53910 [20:00:43] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53910 [20:02:03] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54507 [20:05:23] Maryana: you should come by so that we can switch quickly [20:05:35] brion: nudge Maryana [20:07:18] YuviPanda: we should make http://mobile-reportcard-dev.wmflabs.org/ show mobile text edits as well.. [20:07:35] jdlrobson: is it being picked up by EventLogging? [20:07:39] New review: Brion VIBBER; "I do indeed get an upload failure if I select a GIF image... we can probably live with that but it'd..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53769 [20:07:47] no boss :-/ [20:07:57] :( that's going to be a little bit harder, sigh [20:08:13] jdlrobson: you should just add it to EL, no? easier that way for everything [20:08:46] jdlrobson: any reason to not? [20:08:54] I'm unsure if tags are indexed. [20:09:45] ori-l: if I make an edit to the schema, it creates a new table, right? [20:10:11] if the change is 'forward compatible', so that all data in the old table are directly compatible with the new one... [20:10:19] is it possible to route the old ones to the new one? [20:14:51] New review: Jdlrobson; "Since it's only alpha pushing.." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53609 [20:14:53] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53609 [20:18:01] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54078 [20:18:22] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54470 [20:22:45] New review: JGonera; "(4 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53876 [20:25:15] brilliant - https://commons.wikimedia.org/wiki/File:Lead_Photo_For_Siddharth_Randeria0-7594080063818546.JPG [20:33:13] New review: JGonera; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53877 [20:38:57] New patchset: Jdlrobson; "Story 347: Provide nicer filenames" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [20:42:20] New review: JGonera; "I think that createOverlay(), showOverlay() and other related functions should disappear altogether...." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54069 [20:43:44] next time we have a code review backlog, we should just get everyone in a room and force them to listen to a presentation… clearly it's the best way to blast through it! :) [20:46:34] New review: JGonera; "I don't see any CSS loaded with this commit." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54140 [20:48:49] Maryana: :P [20:49:37] New review: JGonera; "Why would we make this an input if it's higher than one line? Last time we talked with Vibha, she wa..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53770 [20:52:03] tfinc, wanna show us Sue?:P [20:52:14] New review: JGonera; "So this means if two people upload an image with description "cat" in the same minute, we have two f..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53769 [20:53:27] ori-l: if I make an edit to the schema, it creates a new table, right? [20:53:42] brion: ^^ switch to video [20:53:42] if you make an edit _and_ log an event, yes. tables are created on-demand as events for them are received. [20:53:44] tfinc can you stop sharing your screen so we can see the room? [20:53:50] ori-l: sure. [20:54:04] oh, you guys are all in the middle of something [20:54:05] i'll pm [20:54:20] jdlrobson: did you email out somewhere asking if we can move the app feedback to OTRS? [20:54:27] or am I imagining things? [20:54:31] jdlrobson: can you nudge tomasz to stop sharing his screen? [20:54:34] I sent a mail about turning it off [20:54:56] jdlrobson: whats up ? [20:55:09] just the above all good [20:55:12] k [20:55:46] jdlrobson: nothing about OTRS, righT? [20:56:36] nope but feel free to add to the mail [20:59:24] brion: >https://bugzilla.wikimedia.org/show_bug.cgi?id=46241 [20:59:43] +1 woohoo [21:00:10] jdlrobson: do you intend to redirect that to OTRS? [21:01:00] New review: JGonera; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52317 [21:01:07] New review: Jdlrobson; "Yes highly unlikely. I decided that more readable filenames were more important here. Ideally we sho..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [21:01:50] jgonera: you break my heart with all your -1s :( [21:02:05] tfinc: also phonegap. [21:02:31] jdlrobson, you break my hart with all the small problems I find in your changesets [21:02:40] I really wanted to merge the getToken already [21:02:46] but it's simply broken [21:03:08] (unless I misunderstood how it works) [21:03:14] well let's take a look and get this merged today together [21:04:18] YuviPanda: thats what i meant by framework and perf issues [21:04:30] yeah, I mentioned that before you started giving an answer that nailed it :) [21:04:31] so [21:04:44] :) [21:05:10] New review: JGonera; "Why would the site break due to a JS error? Why do we have JS errors? ;)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/54080 [21:06:14] New review: Brion VIBBER; "me like :D" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/54080 [21:06:17] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54080 [21:07:29] Maryana, jdlrobson, I always wondered, can we actually name a special page Special:Uploads? what if desktop also wants an Uploads page, will there be a conflict? Why our other special pages have the Mobile prefix? [21:08:03] i would recommend planning a desktop Special:Uploads as well [21:08:09] and a Special:Nearby for desktop :) [21:08:37]