[00:00:55] jgonera: i need to take off - email if you have more q's or need more clarification, i'll get back to you as soon as i can [00:01:04] MaxSem: yessir [00:01:13] MaxSem: why are you still awake [00:01:13] sorry ran to pick up the kid [00:01:26] MaxSem: go to bed [00:01:30] awjr, thanks, it doesn't store anything in particular [00:01:36] awjr, it's not dawn yet [00:01:42] can be '123', can be 'hi, I'm a cookie' [00:01:54] jgonera: cool, then make it smoething that doesn't fit that regex and it should be fine - varnish will just unset it so it shouldn't mess with caching [00:02:04] ok [00:02:26] ok im outta here - see you all tomorrow! [00:05:52] hahah MaxSem no sleeping until dawn? [00:09:06] MaxSem: wanna wait and talk beta labs tomorrow? [00:09:15] no, now [00:09:22] k [00:09:36] so I can't log in :) [00:09:51] that's pretty much the long and short of it and I don't know if it's a config issue [00:10:01] that's sending me to the wrong link or what [00:11:31] beta doesn't support HTTPS, as it seems [00:12:09] ahhhh [00:12:30] who do I bother about that? [00:13:32] jcmish: known issue, bother hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=36648 [00:13:47] ah so you guys have this same one then eh? [00:14:21] * chrismcmahon has to go, but yeah, Antoine for https on beta [00:14:28] k email being fired off now... I'll copy you chrismcmahon and MaxSem [00:17:39] jcmish, https://gerrit.wikimedia.org/r/#/c/54804/ [00:18:41] MaxSem: so we're just waiting for antoine to code review it? [00:18:53] just committed it [00:18:54] * jdlrobson wonders if MaxSem should have been read http://www.amazon.com/Go-F-Sleep-Adam-Mansbach/dp/145584165X as a child [00:19:10] jdlrobson: hahahaha I did! [00:20:06] k so MaxSem I'll send an extra nudge to Antoine to see if he could review it rather quickly I know he's working on the lucene changes right now [00:21:05] MaxSem: can Andrew review it too? [00:21:11] or is this a Antoine only thing? [00:21:16] hmmm [00:22:55] Maryana: jgonera seems to have mastered the hack [00:25:44] Actually MaxSem do you think it's okay if I +2 it? [00:26:12] Will someone freak out if I do? [00:26:18] feel free:) [00:27:25] damn I can't [00:27:30] wishful thinking :( [00:27:45] I'll just ask both Antoine and Andrew [00:27:51] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [00:29:02] the hack-force is strong with this team [00:29:27] :) [00:29:44] New patchset: Jdlrobson; "Add explanation overlay to photo upload view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [00:29:44] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [00:32:45] New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [00:32:50] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [00:36:28] New patchset: Jdlrobson; "Don't mess with the hash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [00:49:50] New patchset: JGonera; "Add Special:LoginHandshake workaround (#439)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54813 [00:57:23] New patchset: Jdlrobson; "Alpha: Nicer diffs (character granularity)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52663 [08:34:29] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/eTTArA [08:34:29] android-commons/master b2db85a YuviPanda: Don't re-request authKey on screen rotates for AuthenticatedActivity [08:59:09] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/kN2HUg [08:59:09] android-commons/master 6a2f0e2 YuviPanda: Properly check for action being sent [09:22:13] New review: JGonera; "(8 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54069 [09:24:11] New patchset: JGonera; "Add Special:LoginHandshake workaround (#439)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54813 [09:33:33] hey jgonera, still working?:) [09:33:36] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54835 [09:44:06] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/er_4DQ [09:44:06] android-commons/master 2976268 YuviPanda: Fix styling on 2.3... [12:08:59] ragesoss: around? [12:09:52] briefly [12:10:03] heh [12:10:24] ragesoss: fixed all the issues you reported. [12:10:59] k. will try 2.3 again later. [12:13:31] ragesoss: thanks :) [12:13:34] i did test on my 2.3, looks okay [12:42:41] yuvipanda is bitly updated? [12:43:48] oh, nightly. [12:43:57] ragesoss: bit.ly/android-commons [12:46:16] it's the black now? [12:48:47] ragesoss: no [12:48:49] still white [12:49:06] ragesoss: i've to make white -> black smoother. currently it takes me at least 10 mins per commit [12:49:51] 2.3 seems unchanged for multi [12:50:19] bitly is black. [12:50:31] correct bitly? [12:50:35] commons-nightly is black [12:50:38] android-commons is white [12:50:43] black shouldn't have anything changed [12:50:58] I just did android-commons [12:51:09] let me refresh it [12:51:13] try again? [12:52:01] white now [12:53:43] files are failing one at a time. notif is useful! [12:55:38] seems to be working on the app end. [12:55:55] each file uploads then fails on 2.3 [12:56:01] set of 52 [12:56:59] back in 30 mins [12:57:00] ragesoss: ah [12:57:07] ragesoss: all files fail [12:57:07] ok [13:23:11] ragesoss: ping when back. Uploads on 2.3 work on my device, I'll verify with you before pushing update [13:23:26] New patchset: Zfilipin; "Workarond for Sauce Labs Android driver bug" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54859 [13:25:02] Yuvi: back. couple things... [13:25:38] no crash on 4.2... same behavior as on 2.3 [13:26:08] ragesoss: are you able to upload? [13:26:24] ragesoss: and same behavior == multiple upload doesn't show up at all? [13:26:44] still failing, but ui works on both. [13:27:04] uploads going to server then fail [13:27:04] hmm [13:27:08] oh [13:27:11] let me check why that ahppens [13:27:19] yay eventlogging [13:27:23] font in notif too big on 4.2 [13:27:27] ragesoss: but they're going to the server and then failing [13:27:33] screenshot? [13:27:38] i'm just using system defaults [13:27:50] yep... working on it [13:29:03] ragesoss: File:Center for Sustainable Landscapes exterior, 2013-03-19.jpeg [13:29:03] ? [13:29:10] https://test.m.wikipedia.org/wiki/File:Notif.png [13:29:14] ragesoss: File:Random stuff - 17.jpeg [13:29:14] ? [13:29:34] ragesoss: this is also different behavior from before, where the app itself would crash [13:30:40] ragesoss: ah, you mean the icon? [13:30:45] the font is the same size as everything else [13:30:49] okay, on computer now. [13:31:12] YuviPanda: the point is just that the message is so long that I can't read the key detail: 5 failed. [13:31:15] ragesoss: I should also kill the commons icon there, replace it with thumbnail of currently uploading (or failed) file [13:31:18] yeah [13:31:22] agreed. [13:31:27] I'll need to find a solution for that [13:31:29] let me file a bug [13:31:50] maybe it was just a shorter set name on 2.3 that made that not happen. [13:32:00] but anyway, that's the key info, rather than set name. [13:32:03] maybe have that first? [13:32:04] yeah [13:32:23] probably shouldn't mess with default font size. [13:32:23] so I don't actually distinguish multiple and single uploads in the upload process. [13:32:26] yes, must not [13:32:32] they're just... titles [13:32:46] what were your questions about those other files? [13:33:17] ragesoss: I see 'Random stuff' 1- 17 uploads [13:33:18] ed [13:33:21] ragesoss: was that the entire set? [13:33:31] ragesoss: previously you had problems with the app crashing in the middle, is that still the case? [13:33:41] um... [13:34:10] oh wait [13:34:11] nevermind [13:34:12] what [13:34:13] okay [13:34:14] i'm confused [13:34:21] Random stuff was uploaded on march 15 [13:34:26] =that's almost a week ago [13:34:54] yeah. [13:35:13] that was one where it got through some then crashed in the middle of a large set, I think. [13:35:34] hmm [13:35:37] so, without changes, uploads work for you right now but not for me? [13:35:39] so the *UI* sortof works [13:35:41] yes [13:35:46] but uploads still don't work for you [13:35:47] YuviPanda: yes. [13:35:48] as in actual uploading [13:35:55] damn [13:35:57] uploading works. [13:36:02] it just fails after upload. [13:36:11] really? That's weird, because I don't see it on EL [13:36:40] I see only File:Notif.png beinguploaded [13:36:41] see that notif screenshot, that's about 5 fails into a set of 48. [13:36:42] at all [13:36:45] yeah [13:36:48] that's... weird :| [13:36:49] eugh [13:37:13] that's just super weird [13:37:15] eeek [13:37:30] (I used the black version to upload that screenshot while the others were still going) [13:38:15] hmmmm [13:38:29] I'm checking why EL isn't logging any of those [13:38:33] ragesoss: and they all failed. [13:38:48] yes. [13:39:24] okay, confirmed. I don't get it either [13:39:25] wat [13:40:04] it also still sometimes sends you to a url with no file extension, if you try to view it on the web before the server sends back the extension it assigned. [13:40:55] eeek logs aren't coming through [13:41:11] so, retry single upload works for me. [13:41:16] even for single upload. [13:41:17] wat [13:42:43] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54859 [13:43:49] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54835 [13:47:10] bleh [13:47:12] brb [14:09:17] ragesoss: back [14:09:20] still onc omputer? [14:18:54] YuviPanda: yes [14:19:04] ragesoss: can you do an adb logcat | grep -i 'Commons' [14:19:08] will tell me what errors you're getting [14:19:15] i'm stillt rying to nail down why EL data is not being collected [14:21:42] k [14:33:29] YuviPanda: I think it's working now. [14:33:46] ragesoss: uploads? [14:33:56] yes. [14:34:11] just uploaded 8 shots successfully, trying to catch that fail in logcat. [14:34:35] will try again with bigger set. [14:34:35] yeah, they didn't fail [14:34:37] okay [14:34:39] i'm fixing EL [14:39:56] grr... [14:40:25] ? [14:40:27] failed? [14:40:38] my desktop irc client is being silly. [14:41:11] 3 minutes of synclag, not sending messages. [14:41:36] anyhow, set of 52 uploading just fine. [14:41:53] the only thing I changed from before is I cleared app data. [14:42:24] this is the first time it's been working for a big set on my 4.2.2 phone [14:42:29] ragesoss: hmm [14:42:33] (although on my tablet, it always worked) [14:42:34] that is... weird [14:42:44] so it is possibly a data corruption issue somewhere? [14:42:47] well, it failed before on 2.3 too. [14:42:56] I think it was a network or server issue. [14:43:06] but only for you? [14:43:21] well, maybe data corruption... [14:43:28] I haven't cleared data for 2.3 yet. [14:43:33] lemme try to catch it there. [14:44:52] okay [14:45:06] Response is
filetype-mime-mismatch3_-_52image/jpeg
[14:45:33] apparently, I can get the recent logcat from my phone just by plugging it in. [14:45:48] that was the error that was on my 2.3 phone. [14:46:17] YuviPanda: ^ [14:46:32] yeah, logcat is stored in the phone for a while [14:46:38] mime mismatch [14:46:41] hmm [14:46:43] what was it named? [14:46:54] not sure. [14:46:56] nothing wierd. [14:47:02] and retry worked. [14:47:19] I have to go. [14:47:24] hmmm, okay. that was just the JPEG being corrected, I guess [14:47:25] thanks ragesoss [14:48:40] 2.3 phone not failing now, with the same big set. [14:48:58] absolutely nothing changed. [14:49:38] except what I named the set, but nothing exotic in either case. [14:50:08] ragesoss: network issue, I guess [14:50:18] yay! [14:50:23] :D [14:50:24] publish that sucker! [14:50:27] i'm going to fix EL [14:50:31] then publish that sucke [14:50:32] r [14:50:35] :D [14:50:50] k [14:50:53] really leaving now. [14:50:58] ragesoss: you're awesome [14:50:59] <3 [14:51:12] will log on as ragesock from the car repair center. [14:51:21] haha okay [15:09:32] Rawr [15:10:32] * YuviPanda puts presents in ragesock [15:10:40] this EL thing is driving me nuts [16:08:51] found the issue! [16:11:21] \o/ [16:25:19] New review: Brion VIBBER; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [16:40:16] New patchset: MaxSem; "Limit file description to 240 characters" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54587 [16:41:38] MaxSem: you gonna merge that or just rebasing? [16:41:45] rebasing [16:41:54] ok i'll review it [16:41:56] it has a dependency anyway [16:48:53] New review: Brion VIBBER; "This'll limit the input area to accept only 240 Unicode characters; the limit for filename length ho..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54587 [16:52:00] New review: Brion VIBBER; "Looks right; message is in fact HTML." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/54588 [16:54:33] grumble grumble path merge conflcit [16:55:14] and i do it manually and: Falling back to patching base and 3-way merge... [16:55:15] Auto-merging javascripts/specials/uploads.js [16:55:54] New patchset: Brion VIBBER; "Regression: Correct counter on photos dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54588 [16:56:06] let's see if i did it right [16:56:38] New review: Brion VIBBER; "Rebased... I think." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/54588 [16:56:43] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54588 [16:56:57] oh crap it's almost 10, i got distracted :) [16:57:16] * brion goes to comb hair for standup :P [17:00:37] oh it's delayed to 11 today [17:00:37] brion standup was rescheduled for 11 [17:00:41] well then perfect :) [17:00:44] :) [17:01:02] * brion today… mobile goes up to 11 [17:01:02] \o/ [17:02:15] :D [17:02:40] btw anybody with an iPhone -- iOS 6.1.3 update is out today. fixes a screen lock security issue, which nay be important :) [17:04:01] awjr, the standup is at 11 today? [17:04:06] hey do we have a [17:04:09] correct jgonera [17:04:14] hangout awjr [17:04:22] jcmish: for standup? [17:04:38] no no security? [17:04:49] nope, but join #wikimedia-office [17:04:55] awjr: there is also a hangout [17:05:01] (on wikitech-l) [17:05:09] (me isn't participating) [17:05:11] oh, i thought quim said tehre wasn't [17:05:17] uh... I'll just send the notes than, after 3 tries I managed to get the free tax consultation scheduled today at 11 and this is my last chance of asking some questions before filing tax return [17:05:19] jgonera, looks like you will not be needed for the Friday interview. have fun instead:) [17:05:39] ah yeah - jcmish [17:05:39] https://plus.google.com/hangouts/_/8ae93d9508dd26aeae43381dbf1d428f62a1f714?authuser=0&hl=en [17:05:39] awjr: chris replied to it about 6 months ago [17:05:39] err [17:05:40] 6 minutes [17:05:41] MaxSem, ok, thanks for the heads up, if something changes let me know [17:05:44] hehehe [17:34:47] New review: Brion VIBBER; "My original objections still stand. Removing the menu item that shows your list of uploads seems lik..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/51590 [17:35:09] New review: JGonera; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52173 [17:38:29] YuviPanda: will we finish multi file uploads for Android this sprint ? [17:38:36] i'm updating https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 our roadmap [17:38:41] Maryana: --^ updated as needed [17:38:45] tfinc: yeah, it's done. I'm preparing a build to roll out [17:38:52] k [17:39:48] will do [17:43:42] New review: Jdlrobson; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52173 [17:44:13] Maryana: the apps stuff is mostly up to date on the roadmap. we'll need mobile web to get to the same point [17:46:57] New review: Jdlrobson; "(6 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [17:48:28] awjr: heads up that erik needs to know by monday if you want to take any of the classes [17:48:39] tfinc ok, thanks [17:54:19] jgonera: why can't i do new Overlay( { template: newTemplate } ); ? [17:54:26] is that by design? [18:02:06] yes, by design [18:02:19] office peeps - standup! [18:02:20] brion: frizzy hair [18:02:24] :) [18:09:52] YuviPanda: did you make an update to the mobile attempts schema? [18:10:07] brion: yeah, but that shouldn't affect your older revision [18:10:16] ok [18:10:21] should i update to match though? [18:10:24] brion: it's going to be a complete pain when we log things, though [18:10:27] brion: yes, you should [18:10:28] heh [18:10:30] ok [18:10:35] brion: there is a 'multiple' field. Set that to false for now :) [18:10:43] ah ok [18:11:08] so just set multiple=true if the source was a batch of more than one? (which i don't support yet, gotta catch up soon!) [18:11:32] ok and that's a real boolean, not a string. good :D [18:11:50] brion: yes [18:11:54] brion: yes :P [18:12:03] i'll leave myself a bugzilla entry to remind me if i don't get to it today [18:12:13] brion: :D [18:12:37] brion: I'll be out for all of May, so you and monty will have plenty of time to catch up :P [18:13:15] :D [18:21:52] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:23:50] New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [18:24:53] New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [18:25:29] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [18:26:13] New patchset: Jdlrobson; "Don't mess with the hash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [18:29:47] going offline, any last requests? ;) [18:30:02] jgonera: pony? [18:31:24] New patchset: Jdlrobson; "Bug 44484: Use template to render language section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52173 [18:31:31] travel safe, jgonera! [18:31:42] have a great trip, jgonera [18:34:45] hehe, no ponies, sorry ;) [18:34:48] thanks guys [18:34:50] jdlrobson: i was just reviewing the next iteration story wall in prep for our review meeting this afternoon - cards 447 and 448 are still empty. will you be able to get those filled out with some more details before the mtg? [18:39:20] YuviPanda: when does the update drop? [18:39:29] ragesoss: multiple update EL causing problems [18:39:33] i'm tracking that *one thing* down [18:39:35] will go out right after [18:39:37] at worst an hour [18:39:45] but remember, no categories [18:39:49] so you'll have to do that manually later [18:39:56] oh, more EL probs. :/ [18:39:57] i'll be workign on post upload right after this, which does categories [18:40:16] yeah, categories I can do pretty efficiently from desktop post-hoc [18:40:24] thanks, cat-a-lot [18:42:24] jdlrobson: if you can't get some more info added to those cards before the meeting, perhaps we could just use the meeting time to do so with input from the rest of the team [18:44:32] gah, this is frustrating! [18:45:21] New patchset: Jdlrobson; "Story 347: Provide nicer filenames" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53769 [18:45:56] how do I see what was updated only in the last patchset in gerrit? [18:45:58] can I? [18:46:07] MaxSem: can you rebase https://gerrit.wikimedia.org/r/#/c/48209/ ? [19:22:24] ragesoss: all issues solved :) [19:22:31] making build now [19:22:55] [android-commons] yuvipanda pushed 5 new commits to master: http://git.io/4JtfsA [19:22:55] android-commons/master 694a22c YuviPanda: Fix source not being set, causing EL to fail [19:22:55] android-commons/master 90eb0d8 YuviPanda: Slightly more robust uploading [19:22:55] android-commons/master 2e4264c YuviPanda: Add constructor to StartUploadTask that takes a contribution [19:35:25] ragesoss: update pushed! [19:35:47] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/-MeShA [19:35:47] android-commons/master 5fc1803 YuviPanda: Bump version number and update CHANGELOG [19:38:30] tfinc_: do you have the link to the 'apps released' page? [19:38:47] * YuviPanda needs to update that [19:41:22] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/aIwa1A [19:41:22] android-commons/master 3fbcb30 YuviPanda: Add item missed in CHANGELOG [19:43:03] * ragesoss starts feverishly refreshing Play. [19:43:24] ragesoss: want the signed commons apk? [19:43:30] ls [19:43:31] err [19:43:32] dammit [19:44:31] ragesoss: https://dl.dropbox.com/u/8768784/commons-v1.0-beta4.apk [19:44:59] * jdlrobson looks around for brion [19:45:10] ragesoss is photo uploads from web still broken for you with latest deployment? [19:46:04] MaxSem: is there any cheap way to count the number of top level sections in a talk page e.g. count( $title->getTalkPage()-> ? ) [19:46:54] jdlrobson: I will check on test.m [19:47:03] thanks ragesoss [19:47:11] ragesoss: that's the same apk that went out [19:47:18] to play store [19:47:29] get parser output, it contains section information. get counts of each level sections, choose the first level with nonzero count [19:49:07] note: that will possibly decrease performance as you'll need two parses instead of one in the worst case [19:50:14] jdlrobson, so I say doing it properly would require hooking to talk page save procss and savin section information then to use it for subject page views [19:50:36] jdlrobson: upload ui comes up on first try, with beta off and beta on. [19:51:07] but both return error, try again, upon submit. [19:51:27] is brion around? [19:51:37] MaxSem: any reason why Section didn't become a thing ? e.g. a page has many Section (s) [19:52:21] ragesoss: I think you said there was a problem with the overlay closing when you selected an image on your phone.. is this still happening? [19:52:39] MaxSem: concretely why can't I do $title->getSections(); [19:52:45] jdlrobson, because it's wikitext. you can do too many funny things with it [19:53:01] MaxSem: like? [19:53:23] for example, a different number of section for different users [19:53:29] ... [19:53:35] MaxSem: o_O what? [19:53:53] jdlrobson, no, not happened so far. [19:53:54] parserfunctions can access {{REVISIONUSER}}? [19:53:55] yurik: no idea where brion went will poke him when he returns since i need him too [19:54:08] yuvipanda: https://test.m.wikipedia.org/wiki/File:Login_background.png [19:54:16] gradienty? [19:54:19] {{#if:{{int:somemessage}}|== Section1 ==\n\n==Section2==}} [19:54:37] ragesoss: well? it's black :P [19:54:43] is that how it ought to look, Yuvi? [19:54:44] (login screen was the only white thing) [19:55:02] for this and numerous other reasons, it doesn't sound like a good idea to display section count prominently [19:55:10] ragesoss: for now, yes. I'll do an overhaul when we add create account [19:55:23] okay, so it's a feature. just checking. [19:55:25] http://i.imgur.com/IHfR670.jpg [19:55:53] but MaxSem we are doing this in the api - why not formalize this? [19:55:55] ragesoss: yeah, I switched to holo dark everywhere. [19:56:31] jdlrobson, we aren't using it to determine the number of discussions [19:56:48] do you see banding, Yuvi? [19:57:25] ragesoss: i do [19:57:29] for example, imagine a talk page like this: = Warning =\nAll vandals will be shot.\n=Discussion=\n==Section1==\n==Section2==\n==Section3== [19:57:39] ragesoss: it's the default android background. [19:57:42] hoow many discussions are on that page? [19:57:44] ragesoss: i'll fix it when we do account creation [19:57:48] wat [19:58:01] YuviPanda: http://commons.wikimedia.org/wiki/Commons:Deletion_requests/Files_uploaded_by_Coentor [19:58:06] note the comments at the very end [19:58:21] per-section organisation of talk pages is a purely social construct and a matter of practice [19:58:37] and machines aren't very good at social things [19:59:09] tfinc_: i'm dropping him a note in his talk page to see what he means [20:00:27] MaxSem: sure.. but we can count sections [20:00:38] whether those mean discussions is a side discussion [20:00:56] YuviPanda: good. the photos are not going to be deleted since their in spain but it'd be good to reach out to our most prolific uploadere [20:01:16] tfinc_: yeah, doing. me and ragesoss were actually talking about it yesterday, I'm happy that they are going to be kept [20:01:24] i guarantee you we are going to need Sections to become a 'thing' for mobile to work - currently they are an expensive operation if I am not mistaken [20:01:24] (our reading of FOP was different, but we didn't have enough context) [20:01:41] brb story review [20:01:48] tfinc: also play store update pushed out. I'm currently writing email to mobile-l and wikitech-l [20:02:00] nice. when will we be out of beta for android ? [20:02:03] I wouldn't assume it's settled yet. *might* be kept. [20:02:18] ragesoss: the previous discussion was pretty similar, and was a keep [20:02:34] tfinc: good question. I want to be out of beta once our post upload actions support is done [20:02:43] oh, I didn't see that. [20:02:50] ragesoss: yeah, it's linked from the first KEEP (original uploader) comment [20:02:54] jdlrobson, I guarantee you that we (as in WMF devs) need to add a real discussion system. as of section counting, I warned you:) [20:03:06] YuviPanda: can i read the bump in uploads over the last days as multi uploads ? [20:03:11] ragesoss: apparently that's not just a carnival, but a special type of carnival which somehow makes them permanent, and hence covered under FOP [20:03:16] tfinc: nope, you may not :) [20:03:16] but if you still want to do it, I'll see what can be done to make it not suck [20:03:21] tfinc: multi uploads bump is yet to come [20:03:30] tfinc: that is one dedicated user doing single upload of all those things [20:03:34] interesting! [20:03:51] YuviPanda: i love our masochistic uploaders [20:03:53] thats dedication [20:04:06] YuviPanda: lets reach out to him for early multi upload testing [20:04:07] MaxSem: you around? we're gonna need a couple minor updates on zero varnish config [20:04:08] yeah, those are the ones proposed for deletion :P [20:04:09] yurik: ok let's get the hangout running [20:04:16] tfinc: also how did you come across that link? [20:04:25] multi upload bump coming shortly... [20:04:38] i've to fix the dashboard now [20:04:48] brion, we're about to start a 1-hour meeting [20:04:56] MaxSem: oh we'll push later :) [20:05:02] hmm, I wonder whom I should poke for some SQL help [20:05:02] we'll just prep it [20:05:11] brion, and I can't push Varnish changes:) [20:05:15] i was looking through the report card and trying to understand a bump in fils but not uploaders so i went to see the category and clicked through on one of his uploads [20:05:16] ok :D [20:05:21] that upload was tagged for deletion [20:06:11] ragesoss: are you doing uploads now/ [20:06:19] I'm not receiving any EL data, and a bit concerned [20:08:29] just started set of ten. [20:08:38] ragesoss: ah, got it [20:08:40] oats? [20:08:44] THE OATS ARE COMING [20:08:55] discovered feature I want. reverse numbering. [20:09:08] ? [20:09:22] oats progress from cooked to dry from 1 to 10. [20:09:36] is that how you selected them? [20:09:44] hmm, perhaps I should sort them by date before numbering? [20:09:49] yes. my fault. [20:09:52] or actually, I shoudl just use timestamps [20:09:56] rather than numbers? [20:10:17] either. [20:11:10] hmm [20:12:16] order was not the selected order actually. [20:12:50] ragesoss: yeah, it might be a bit random [20:12:56] possibly file creation order (but not original timestamp order) [20:13:25] since those are touched up on the phone. [20:14:33] ragesoss: exif has date, usually [20:14:37] but i'm not touching exif yet [20:14:44] I'm waiting for EXIF support to land in UIL [20:14:56] once that happens, all local file loading will get much faster [20:16:22] MaxSem: awjr http://etherpad.wikimedia.org/SVImxzLIyw [20:18:28] set of 41 uploading. [20:19:13] ragesoss: wheee [20:21:59] ragesoss: sorry, shitty internet [20:22:01] ragesoss: that's going to take it over 500 :) [20:22:03] did I miss anything? [20:22:27] nope [20:22:36] ah okay [20:22:41] yay! [20:22:49] #500 [20:23:11] * ragesoss wins the Nexus 10, right? [20:23:16] brion, are you still a root? [20:23:28] YuviPanda: whats the update frequency for http://mobile-reportcard.wmflabs.org/ ? [20:23:29] MaxSem: yes, i'll just have to figure out the proper buttons to push :) [20:24:39] "auto-updating every hour" [20:24:39] nm [20:24:39] tfinc: every hour [20:25:03] tfinc: we've a new schema, so the multiple uploads won't show up on it yet. I'm fixing that now [20:25:08] k [20:25:12] ragesoss: :D [20:25:14] i'm finding the dashboard very useful [20:25:16] howie was too [20:25:18] ragesoss: you win the Nexus 500! [20:25:20] i'm glad i prioritized it [20:26:09] tfinc: we should spend some time in a later sprint adding more metrics. 'Retained uploads' (aka how many were deleted by commons) is something I'm very interested in. [20:26:12] we should also make leaderboards! [20:26:23] YuviPanda: calm down [20:26:33] your running to pretty shiny things again [20:26:34] :) [20:26:39] heh. [20:26:52] but first let me fix this dashboard now [20:26:55] so that it counts everything [20:28:33] * ragesoss needs a leaderboard. NEEDS. [20:29:04] set of 24 going up now. [20:29:15] ragesoss: I know. I also need one! [20:29:57] https://gerrit.wikimedia.org/r/#/c/53627/ < awjr MaxSem [20:31:32] uploads are so much faster on Commons. [20:31:52] ragesoss: than testwiki? [20:32:37] I noticed in logcat a delay of several seconds between upload complete and server response. like 5 or 10 seconds. [20:32:54] on test wiki [20:33:08] ah, i see. non existent on commons? [20:33:15] ragesoss: i'm happy testwiki works at all :P [20:33:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=45572 [20:33:41] I don't know about Commons [20:36:49] https://gerrit.wikimedia.org/r/#/c/54705/ [20:39:31] ragesoss: should add ways to add / remove images from the selection [20:41:48] ori-l: any reason NavigationTiming doesn't distinguish between mobile site and desktop site in results? [20:42:07] +1 [20:42:18] errrrrrrrrrrr. [20:42:23] that's probably a good idea, jdlrobson. [20:42:26] and drag and drop reordering! [20:42:28] i'll add it. [20:42:48] ori-l: I guess webHost won't work [20:43:00] jdlrobson: actually, why not? [20:43:14] well you can access https://en.wikipedia.org/?useformat=mobile [20:43:22] ragesoss: why would re-ordering be a big deal? [20:43:39] jdlrobson: ...i'll add it then :) [20:43:43] sweet :) [20:43:52] so numbering is how you want it. [20:44:04] ragesoss: hmm, but should we still do numbering? [20:44:21] ragesoss: tfinc https://commons.wikimedia.org/wiki/User_talk:Coentor#Commons_Android_App [20:44:52] good [20:45:22] Yuvipanda: some sets will have a natural order aside from chronological. [20:45:35] hmm, that is true [20:45:46] ragesoss: okay, file seperate bugs for deletion, adding and re-ordering? [20:45:47] lets hope he reads his talk page [20:45:49] or are oyu on a phone? [20:46:04] tfinc: considering the amount of traffic there and the fact that he actually voted on the deletion request, I bet he does [20:46:09] will file later. [20:46:22] i hate talk pages more then most things on wiki [20:46:45] ragesoss: okay ragesoss, I'll file them now [20:46:58] tfinc: I've now become used to them :) [20:47:23] YuviPanda: i'm looking at http://upload.wikimedia.org/wikipedia/commons/3/38/Post-upload.png and it seems to imply a search for categories. does the api expose that ? [20:47:41] tfinc: yeah, we have prefix search [20:47:45] which is what we'll do for autocomplete [20:47:49] sweet [20:48:14] tfinc: we shot past 500 pics from Commons :D [20:48:17] 557 [20:48:17] now about the share section. can we actually show apps that respond to the share intent within app like that? [20:48:25] i thought it was post share tap that we get the list [20:48:27] tfinc: yup. I checked that [20:48:36] tfinc: we can display it however we want. [20:48:41] nice [20:48:44] New patchset: MaxSem; "Rm bogus CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54912 [20:49:08] tfinc: though brion and ragesoss had a concern with that design that I think should be addressed [20:49:14] hmm ? [20:49:24] does tapping, say 'twitter' also mean you tapped 'update'? [20:49:34] update adds categories and description [20:49:38] share takes you out of the screen [20:49:43] so... how does that work? [20:50:10] yeah, this is not fully flushed out [20:50:21] yeah [20:50:29] for this iteration, I'm just going to get the 'share' stuff out [20:50:35] and then add categories [20:51:35] YuviPanda: given the campaign designs in http://upload.wikimedia.org/wikipedia/commons/d/db/Campaign_workflows_and_post_upload.pdf what plumbing do we have to build ? [20:51:59] lots actually. [20:52:08] we need a way to get 'list of images contributed via campaign X' [20:52:12] that does not exist in the API yet [20:52:22] we also need ImageInfo API to be completed [20:52:40] it's a decent chunk of backend work [20:52:45] but not complex, however. [20:52:52] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54912 [20:53:06] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [20:53:38] Maryana_lunch: good time to talk with you and vibha? [20:53:49] i'm wondering how quickly we'll outgrow this very simplistic campaign list view [20:54:18] but i'm willing to tackle that when its time [20:54:32] vibha & i are were gonna go over app stuff in 30 min.. lemme see if she's free now to talk w/you about web stuff, jdlrobson [20:55:00] tfinc: yeah. [20:55:03] Maryana: if your talking apps should i be there ? [20:55:14] if you're talking about apps should *I* be there? [20:55:28] * tfinc waits for brion to say the same [20:55:36] she just wanted to go over shankar's wireframes/workflows - up to you, tfinc :) [20:55:47] yes [20:55:58] Maryana: you should show her the app on a phone. I'll note that the app is strikingly different from most of the wireframes :P [20:56:13] and we'd want yuvi there as well as he's been working closely with shankar [20:56:16] yeah, i'm downloading it now on a shiny new nexus 4 :D [20:56:36] tfinc: can you give me the URL for the 'list of app releases' wiki page? [20:56:53] Maryana: is the login screen black? [20:56:55] YuviPanda: http://www.mediawiki.org/wiki/Mobile/Release_history [20:56:57] if not that isn't the latest version [20:57:01] tfinc: thank you! [20:57:02] * YuviPanda updates [20:57:20] tfinc: moment, in meeting :) [20:57:31] brion: no need. i was just poking fun [20:57:35] yuvipanda: https://test.m.wikipedia.org/wiki/File:Upload_button_styling.png [20:57:41] * fun pokes tfinc back [20:58:02] jdlrobson, can we do it in 30 min? [20:58:03] ragesoss: yeah, that looks disabled, doesn't it [20:58:23] Maryana: sure [20:58:31] tfinc: Maryana if I have to be there, then hangout time. [20:58:33] yes. it goes from darker (before text) to that. [20:58:36] and hopefully it'll be better now than how it was earlier [20:58:51] ragesoss: yes, not good. that's because the background there is *white* while the app is on the holo dark theme [20:58:56] I should fix that [20:59:15] Maryana: let me know what color the login screen was - if it was white, I'll give you another URL to get the app from :) [21:00:22] yuvipanda - it's black. is that the right one? [21:00:26] looks like it's in Play noe [21:00:30] Maryana: it is [21:00:33] ragesoss: yup! it is! [21:01:09] hey, just a thought - does it let you log in if you have a local wiki account but have never visited commons before? [21:01:53] Maryana: I... haven't actually checked that [21:02:58] bah, i should have just checked with my sock account [21:03:34] * Maryana uninstalls & reinstalls :) [21:04:09] yeah, I should make 'remove account' work properly [21:04:25] you can currently do that from the settings screen, but it doesn't actually remove everything :) [21:05:01] the best thing about android is that it doesn't force you to enter your apple ID every time, even when you're installing free apps [21:05:10] :D [21:05:31] hmm, I should update the nightly that lets you upload to testwiki [21:05:36] awjr & jdlrobson, after some thinking, I don't like detection in JS [21:05:44] MaxSem: why so? [21:05:46] how come? [21:06:02] yuvipanda - it appears to work [21:06:08] for accounts that haven't visited commons [21:06:11] wheee [21:06:12] but the 0 uploads view is sad [21:06:17] MaxSem: people with shitty phones who have disabled javascript? [21:06:18] yeah, needs work [21:06:27] needs an inspiring image :) [21:06:28] first, it will result in flash of improperly styled content, like http://bug-attachment.wikimedia.org/attachment.cgi?id=10506 [21:06:41] Maryana: you'll notice the consistent lack of visuals / imagery everywhere :) [21:06:48] Maryana: I think the only 'image' we have there is the app icon [21:06:51] MaxSem: it won't if we run the javascript in the head [21:07:00] Maryana: as I said, needs a lot of design love too :) [21:07:17] Maryana: you'll also find some inconsistent colors instead, so be pre-warned :) [21:07:29] second, yes - some people disable JS [21:07:44] should pull a random naked picture from Commons if you have 0 uploads. [21:07:46] MaxSem: agreed (plus some phones cannot even run js [21:07:53] sooooooo [21:07:54] just to set the tone. [21:08:19] load.php?modules=mobile.device.autodetect [21:08:33] ughhhh [21:08:56] hi, I'm your can of worms, please choke on me [21:09:26] lulz [21:09:50] MaxSem: are you suggesting we focus on using ESI then? [21:09:54] ragesoss: :D Not one penis picture yet, i'm surprised [21:10:02] YuviPanda: we got one.. [21:10:02] ragesoss: there was one with the name on it, but was just some dude [21:10:07] jdlrobson: that wasn't a penis [21:10:19] awjr, I'm hoping to do it w/o ESI [21:10:21] that was just a dude in a gym! [21:10:38] MaxSem: how do you get around the JS issue then? [21:10:42] also check out https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit 18 March 2013 6:22 [21:10:50] if you dare [21:10:59] awjr, by varying RL by X-Device [21:11:04] jdlrobson: and it might also be deleted? I don't see it on https://commons.wikimedia.org/wiki/Category:Uploaded_with_Mobile/Web [21:11:27] hmmm [21:11:31] jdlrobson: Y U NO ADD TEMPLATE TO https://commons.wikimedia.org/wiki/File:Lead_Photo_For_Head_transplant0-12501397426240146.JPG [21:11:38] MaxSem: but if we dont do device detection in JS how would we do that? [21:11:40] https://commons.wikimedia.org/wiki/File:Lead_Photo_For_%D0%91%D0%B0%D1%80_(%D0%B5%D0%B4%D0%B8%D0%BD%D0%B8%D1%86%D0%B0_%D0%B8%D0%B7%D0%BC%D0%B5%D1%80%D0%B5%D0%BD%D0%B8%D1%8F)0-7233171246480197.jpg amaaazzzinng [21:11:58] jdlrobson: makes things so much harder for commons folks to track :( [21:12:03] Maryana: ^ [21:12:09] YuviPanda: which template? I thought we added the template [21:12:14] it's not there [21:12:24] check https://commons.wikimedia.org/wiki/File:Lead_Photo_For_Head_transplant0-12501397426240146.JPG [21:12:26] i don't see it [21:12:49] jdlrobson: it's there on https://commons.wikimedia.org/wiki/File:Lead_Photo_For_Adrian_Younge0-8287715325132012.jpg [21:12:50] jdlrobson, and the corresponding https://ru.wikipedia.org/w/index.php?title=%D0%91%D0%B0%D1%80_(%D0%B5%D0%B4%D0%B8%D0%BD%D0%B8%D1%86%D0%B0_%D0%B8%D0%B7%D0%BC%D0%B5%D1%80%D0%B5%D0%BD%D0%B8%D1%8F)&diff=prev&oldid=53143268 [21:13:26] hmm... [21:13:38] that's very odd. the mobile web uploads should all be automatically added to the category [21:13:46] unless someone is removing said category manually [21:13:56] no idea how he got round that.. [21:14:10] no, I don't think so https://commons.wikimedia.org/w/index.php?title=File:Lead_Photo_For_Head_transplant0-12501397426240146.JPG&action=history [21:14:20] the only other entry is a deletion request [21:14:38] yeah, checked the history of the file page, too [21:14:42] doesn't look like anybody removed the cat [21:14:44] weird [21:15:11] Maryana: what happened to mw.config.get( 'wgPhotoUploadAppendToDesc' ); ? [21:15:25] ? [21:15:26] maybe that explains why https://commons.wikimedia.org/wiki/Category:Uploaded_with_Mobile/Web is so underpopulated/ [21:15:28] only 67 [21:15:33] do testwiki web uploads go to Commons? [21:15:39] it seems to had egot wiped [21:15:42] ragesoss: yep [21:15:51] whoops! [21:15:52] jdlrobson, oh noe [21:15:54] s [21:16:25] need to update config to set wgPhotoUploadAppendToDesc back to what it was before... [21:16:27] ragesoss: it's ok, cos steven walling is behind on his commons admin duties, and he relishes deleting all of our test files :) [21:16:41] jdlrobson, yeah! good catch [21:16:48] how in the world did that happen? [21:16:53] * jdlrobson shrugs [21:17:01] these things are magic to me [21:17:04] MaxSem: how would we vary those specific resources on X-Device - set up device detection and set the header the bits varnish config? [21:17:24] that reminds me. I need to do my biannual Hail Jimbos on Commons too. [21:17:33] last upload was 10th March [21:17:42] direct those requests to m instead of bits as suggested by Asher [21:17:55] 11th rather [21:18:02] or is Erik considered the founding deity there? [21:18:42] ragesoss: is there a proper 'history of the wikimedia movement' somewhere? [21:19:05] mine is very limited [21:19:25] yuvipanda: there are exactly 0 rooms available when vibha has time to talk about apps :( do you mind if i take really good notes and send them out to mobile-tech? [21:19:36] Maryana: :( that's okay. [21:19:44] Maryana: i'll also be online, so feel free to ping me [21:19:52] ok [21:20:15] Maryana: also check out the multiple upload workflow - you have to start from the phone's gallery, select multiple images (long press!) then use the 'share' intent to share to commons [21:20:18] has a different UI [21:20:40] Maryana: will you be able to send them right after the meeting? I'll be up for a n hour at least [21:21:05] yeah, a lot of this will just be me and vibha catching up/playing with the app, but i'll def take notes as we go & send em out right away [21:21:43] Maryana: sweet! :) [21:22:05] i'll just pre-warn that the wireframes / mockups are not very representative. [21:26:12] yuvipanda: The Wikipedia Revolution is a decent overview of the early years. [21:26:44] yurik: did you catch the tail end of that? i ran out of battery :) [21:27:11] everyone left hangout pretty much within a minute after you left [21:27:26] ok then all should be done :) [21:27:27] brion: and apparently their speakers were off [21:27:33] heh woops [21:27:39] no worries [21:27:52] most of the important stuff seemed to be covered [21:28:01] ok so we're doing a test on vimpelcom this evening at 9pm PDT, if you want you can sit in while we poke, or you can sleep :) [21:28:25] 12 is not late... i'm slowly switich to SF schedule :) [21:29:05] awjr, jdlrobson, created https://mingle.corp.wikimedia.org/projects/mobile/cards/450 [21:29:29] yurik: welcome to the club :P [21:29:31] brion: congratulations on Vimpelcom [21:29:35] spiff. ok be on irc and we'll see if we Skype everybody in or just chat here [21:29:43] chrismcmahon: \o/ moar free users [21:29:50] chrismcmahon: Vimpelcom? [21:29:51] oh [21:29:51] wait [21:29:53] that's a telecom? [21:29:59] I thought that was a conference about Vim [21:30:04] rofl [21:30:23] LOL [21:30:27] YuviPanda, yes, in a way it was [21:30:37] :D [21:30:38] you should have heard brion swearing when he was trying to quit vim [21:30:43] vimpel is Russian for pennant [21:31:03] could be worse, could be emacs [21:31:04] i think he was just pushing random keys [21:31:07] i can never remember how to get out of emacs [21:31:31] getting out of emacs is easy - you just get ewindows [21:31:41] ESC+:q! [21:32:04] that's if the emacs had evil mode on [21:32:07] alt+f4 :-P [21:32:19] usually, a few headbangs on keyboard help [21:32:21] kick-cpu [21:32:45] sending a remote power-down command is also known to work [21:32:51] ok i'm gonna grab a quick lunch then i'll be back to follow up on that ops update and do some more code review [21:33:18] yurik: pedal-ctrl-meta-shift-esc-q [21:33:27] missing a headbang though [21:33:38] you forgot numlock! [21:33:48] :D [21:33:51] and the windows key [21:34:04] or is that now known as "pedal" ? [21:34:22] yurik: you haven't seen foot pedals used with emacs? [21:34:32] yurik: hmm, windows key would be hyper, I guess [21:34:42] pedal-ctrl-alt-meta-hyper-shift-esc-q [21:34:55] i only saw the pedal in OLPC [21:35:00] :D [21:35:08] http://emacswiki.org/emacs/FootSwitches [21:36:57] MaxSem: yup I saw that.. should be easy to fix just haven't got round to it [21:37:07] cool, thanks [21:37:07] MaxSem: can you raise a bug if there isn't already one? [21:37:14] sure [21:37:25] thanks :) [22:17:13] New patchset: Jdlrobson; "Do basic device detection in javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [22:17:41] Change abandoned: Jdlrobson; "How about https://gerrit.wikimedia.org/r/54987 instead." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52054 [22:27:39] New review: Brion VIBBER; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [22:28:12] * MaxSem ROFLs [22:28:14] if ( count( $contextModules['top'] > 0 ) ) [22:28:34] New review: Brion VIBBER; "Also it might not hurt to add a doc comment that reminds folks that this is detecting *OS*, not brow..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [22:29:27] did that just miss a paren somewhere? [22:29:35] or... what [22:30:23] I love languages that don't barf on such errors, they're so much fun! [22:30:46] LO [22:30:51] ah nice [22:32:06] oh php you're a silly language [22:32:28] array() == false, false == 0, but array() != 0 [22:35:09] New patchset: MaxSem; "Fix funny bracketing fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54990 [22:43:40] brion, are you saying wikipedia is a success despite php, not because of it? :) [22:44:02] could be worse, could be perl ;) [22:44:10] could be worse, could be Java [22:44:21] LOL on both counts [22:44:38] * yurik rewrites wiki in brainfuck [22:44:53] (no one notices the difference) [22:46:05] well, the character occurence distribution is slightly different... [22:47:26] i'm going to sleep [22:47:33] night night [22:47:45] tfinc: reportcard is going to under-report until tomorrow, I'll wake up and fix it [22:47:49] hmm, brion might know [22:48:01] brion: how can you treat two different mysql tables as one? [22:48:08] hmm [22:48:09] brion: assume they have same structure [22:48:10] etc [22:48:14] i was thinking a view [22:48:18] well you can do a UNION of two selects [22:48:23] i essentially want TABLE1 APPEND TABLE2 [22:48:25] not sure if you can make a view of a union but that might work [22:48:33] brion: but will it calculate DISTINCT correctly? [22:48:34] hmm [22:48:36] ok [22:48:40] i'll look into that tomorrow [22:48:42] off now [22:48:50] http://stackoverflow.com/questions/514817/creating-mysql-view-using-union [22:48:50] i should really lseep now [22:48:57] yes sleep :) [22:49:08] distinct? dunno, try it and find out :D [22:49:22] hehe [22:49:24] will do tomorrow [22:49:31] currently doing: cleaning up imports on top of Java [22:49:32] files [22:49:38] so that the rebase to beta code is easier [22:49:40] sigh [22:49:50] Maryana: i'm going to go crash, will read notes and respond tomorrow :) [22:49:51] thanks [22:54:32] dfoy, dr0ptp4kt, yurik: ok i asked in #wikimedia-operations and leslie merged the ACL changes for tonight's test. it should go live somewhere in the next couple hours :D [22:54:48] mwah [22:54:52] oh boy [22:54:53] then we'll just need to update the on-wiki configuration around 7-8pm to make sure it's out of cache by 9 [22:54:53] great [22:55:29] dfoy: are we going to try a group Skype chat or shall we just check in on IRC while you're on the call with the russians? [22:55:37] * yurik is really not happy about "timed" releases [22:56:02] welcome to working with partner companies :P :) [22:56:08] i could be on the call if you guys need translation :) [22:56:34] can't promise life translation though [22:56:45] only to get them ... comfortable ;) [22:57:13] *live [22:58:54] oops we lost dan again [22:59:00] MaxSem: awjr brion looks like there was an issue with deployment [22:59:06] jdlrobson: ? [22:59:09] :( [22:59:10] on Nokia N95 in my hand - i'm seeing css problems without debug=true [22:59:15] i wonder if this is what is causing the kindle 4 issue [22:59:22] curious [22:59:28] ruhroh [22:59:50] heh [22:59:54] jdlrobson: do styles get loaded via RL for the N95? [23:00:09] jdlrobson: also have you force refreshed/cleared local cache? [23:00:14] kindle is considered a dumb device, so it gets no LR [23:00:50] yurik: That may work [23:02:12] no RL = no fresh resources for you young padawan [23:02:26] ok the kindle problem is different -talking to brion i think i know what is going on there [23:02:30] yurik, brion: lets connect up on IRC and I will see how they would like to proceed. It's a new person testing on the Beeline side, so I'm not sure what they're willing to do [23:02:37] dfoy: ok [23:02:41] clearing cache to test nokia n95 issue [23:02:45] we'll stand by :) [23:02:46] (dfoy raised this btw) [23:02:48] dfoy, sounds good [23:03:01] issue still there awjr [23:03:09] so is the problem urgent enough to warrant a cache flush, or can we let it just refresh organically? [23:03:28] * yurik just realized a nice advertising opportunity - a company signs up for ZERO, and lists competitor's IPs as their own, plus does some crafty translations for the header... [23:03:35] awjr: i'm more worried about the cause.. [23:03:46] hehe [23:04:05] :) [23:04:36] jdlrobson: if there's no RL, isnt the resource's link embedded in the html? [23:04:45] it should be.. [23:04:46] awjr, it is [23:04:53] right… so isn't that the cause? [23:04:59] and it's not versioned [23:05:11] yes or even just putting the header out there on a carrier that isn't participating to cause people to run up biils and slam the company [23:05:36] oh… if it's not versioned then it should be fetching whatever's available from bits [23:06:15] what's the ttl on bits resources? [23:07:30] jdlrobson: do you have the link to the resource in question by chance? [23:07:50] awjr: the resource which contains the css that's not being applied? [23:07:59] yah [23:08:09] awjr: i'm not sure which one it will be [23:08:24] jdlrobson: can you view the page source? [23:08:29] no :( [23:08:48] jdlrobson: what's the UA for the N95? [23:09:13] "Some Nokia crap" [23:09:17] tehe [23:09:18] Mozilla/5.0 (SymbianOS/9.3; Series60/3.2 NokiaE52-2/091.003; Profile/MIDP-2.1 Configuration/CLDC-1.1 ) AppleWebKit/533.4 (KHTML, like Gecko) NokiaBrowser/7.3.1.34 Mobile Safari/533.4 [23:10:28] mm anything i can do to work out the bad css file? [23:10:53] jdlrobson: spoof the UA in a browser on your laptopt [23:10:55] and view source [23:11:27] but how do i know that's the same? [23:11:33] it looks fine on my spoofed browser [23:11:42] it's hard to work out which css file is the screwed up one [23:11:50] jdlrobson: can you describe what looks wrong? [23:12:22] theoretically it can only be https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=&only=styles&skin=mobile&* [23:12:32] I see a menu at the top left of the page [23:12:37] with Home, Random and settings [23:12:42] let me take a photo for you [23:12:49] okidoke [23:13:27] totally unrelated - but what is the 'apple-touch-icon' that is set in SkinMobileTemplate.php? [23:14:00] is that what mark was saying is one of the biggest requests from mobile to bits … and doesnt actually have a resource (just 404s)? [23:14:05] awjr: http://imgur.com/gy6jlxL [23:14:12] awjr: that's an apple thing [23:14:18] i'm pretty sure apple phones request it [23:14:58] oohh that one in particular is for the icon that we show when you add it to homescreen [23:15:04] is wgAppleTouchIcon set on server? [23:15:18] is it set to a url that 404s? [23:15:37] yeah it looks like it's a config variable [23:15:45] http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php has it set... [23:15:51] well what actually 404s apparently is /apple-touch-icon-precomposed.png [23:15:59] awjr: so that is an apple thing [23:16:09] /apple-touch-icon.png exists [23:16:14] the only solution to that is to stop it 404ing [23:16:15] hmmmmm yeah we don't specify the precomposed one [23:16:27] easy fix: copy the icon to the other one :P [23:16:37] reminds me, we need a non-shitty icon too [23:16:50] brion: talk to vibha she's desperate for that! :) [23:16:56] :D [23:17:04] brion: i think she has one too [23:17:23] precomposed if used won't add any apple effects [23:17:39] "if no icons are specified using a link element, the website root directory is searched for icons " [23:17:42] any referees on those 404s? or does it happen only on some domains? [23:17:53] brion yeah; there is nothing configured to use -precomposed, so i dunno where that's coming from [23:17:59] brion we'd have to ask mark or someone else from ops to check [23:18:05] anyway awjr any idea what is going on here - http://imgur.com/gy6jlxL [23:18:29] no jdlrobson :( it looks fine for me locally with spoofed UA [23:18:31] it looks like the *default* is to not output an apple-touch-icon link [23:18:32] can that be fixed by touching the css files? [23:18:39] so some projects may be defaulting to nothing and it's doing the searching [23:19:08] i guess we could try jdlrobson but im not sure, i believe that weird procedure is for weird behavior in RL [23:19:09] awjr, did you clear your cookies before spoofing the UA? [23:19:25] MaxSem: no but i am in private browsing [23:19:32] and have no cookies set [23:19:34] i'm pretty sure mf-navigation.css is the culprit [23:19:40] although [23:19:46] jdlrobson: can you clear your cookies on the n95 and try again? [23:20:18] awjr: i clearred everything [23:20:21] still same problem [23:20:29] :( [23:21:29] the main menu button appears to be showing, isn't that set in mf-navigation.css? [23:23:02] jdlrobson: did you give me the UA specifically for that device, or did you look up N95 UAs? [23:23:10] awjr: that's the specific ua [23:23:35] is it possible that there's something weird about that browser that's not rendering the css properly? [23:23:59] brion: true.. it might be using an old css file though [23:24:04] hrmmmm [23:24:17] or maybe something is going wrong in minification? [23:24:42] if it's working with debug=true, a minification-related problem is possible [23:24:52] perhaps the n95 browser is crappy and is misinterpreting something :P [23:25:18] i would lean towards that since it looks fine for me in chrome with the same UA [23:25:40] is there another dumb device that you can test on jdlrobson? [23:26:27] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=46392 [23:27:13] jdlrobson: that should make everyone happy. [23:29:57] there's something funky going on awjr in the magnification with embedded images [23:30:03] wondering if that's making it spit an error [23:30:15] is there a list of companies that have been officially declared as having ZERO? [23:30:17] thedj: roger [23:30:25] (just so I know which can be talked about) [23:30:49] awjr: need to talk to vibha will investigate more soon [23:30:57] ok jdlrobson [23:45:36] MaxSem do you know where this image lives and/or how to update it? http://en.wikipedia.org/apple-touch-icon.png [23:47:04] somewhere in mediawiki-config, looking [23:48:25] looks like docroot/$site [23:49:05] New review: Jdlrobson; "MaxSem This also got fixed in https://gerrit.wikimedia.org/r/#/c/53627/ over a week ago but alas no ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54990 [23:49:15] i dont really know how that stuff works… if we wanted to copy apple-touch-icon.png to apple-touch-icon-precomposed.png and deploy, what would we need to do? [23:49:23] New patchset: Jdlrobson; "Maintenance: Load minimum possible css / reorg css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53627 [23:50:47] New review: Jdlrobson; "mm.. my bad wrong link.. but I ***definitely*** fixed this in some other commit. I'm losing my mind ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/54990 [23:50:49] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54990 [23:52:23] New patchset: Jdlrobson; "Disable photo upload menu item when unusuable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51590 [23:53:48] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [23:54:07] brion: https://gerrit.wikimedia.org/r/#/c/51590/ added FIXME for you :) [23:54:14] \o/ [23:58:13] New review: Brion VIBBER; "Appears to work as described." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/51590 [23:58:15] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51590