[00:00:28] "brion made me do it" [00:00:59] LOL [00:01:13] the mobile-frontend file just has a few spaces you added [00:01:34] roger. tabs henceforth. [00:01:35] jebus - my 'quick errand' that should've taken about 30 minutes took a little over an hour thanks to rush hour, hella construction, and a motorcycle accident :( [00:02:02] you ok? [00:02:25] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [00:02:58] New patchset: Jdlrobson; "Bug 44484: Use template to render language section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52173 [00:03:46] New patchset: MaxSem; "WIP: [Card 446] Don't vary page HTML on X-Device" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226 [00:04:05] ^^^ [00:08:41] dr0ptp4kt: oh yeah, i wasn't in the accident :) just frustrated about how long it all took [00:09:24] New patchset: MaxSem; "Rm warning on place of old API" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55229 [00:09:33] New review: Jdlrobson; "Please put MobileFrontendDeviceDetectModule in a new file in includes/modules" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/55226 [00:10:08] * MaxSem gives jdlrobson a cure from Java [00:18:55] doh - did jon leave for the day? [00:19:54] seems so [00:44:07] New review: awjrichards; "LGTM - issues I noticed appear to be fixed by https://gerrit.wikimedia.org/r/#/c/54069/" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/53877 [00:52:42] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52173 [01:09:44] New patchset: awjrichards; "Add explanation overlay to photo upload view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [01:10:54] New review: awjrichards; "Fixed per Maryana's email comment:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [01:11:03] New review: awjrichards; "Fixed per Maryana's email comment:" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53877 [01:11:05] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53877 [09:13:27] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/6fRkfQ [09:13:27] android-commons/master 3bf1e3b YuviPanda: Fix UploadService to have appropriately instantiable constructors [09:13:27] android-commons/master d93827f YuviPanda: Remove unused androlog dependency [14:08:43] New patchset: JGonera; "Fix search input dimensions on non-Webkit browsers" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55073 [14:09:39] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55073 [14:14:05] New patchset: JGonera; "Fix ugly menu borders in Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55074 [14:15:14] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55074 [14:45:14] New patchset: JGonera; "Increase left padding in search input" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55265 [15:01:40] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55265 [15:05:23] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54069 [15:13:44] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54795 [15:17:53] New patchset: JGonera; "Fix wrong margin for menu items" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55268 [16:18:51] brion: ping [16:19:36] brion: when you have a few min, pls send some feedback on https://gerrit.wikimedia.org/r/#/c/55242/ [16:20:40] (hmm... everyone is probably still asleep in SF) [16:26:41] yo [16:27:00] yeah the office is pretty dead before 10 on the engineers side :) [16:27:20] i'm going to hang at home, try to get some api create account work finished up [16:27:25] but i can certainly look at that commit for ya [16:27:52] oh you've been busy yurik :) [16:29:28] oh that's nothing yet ;) [16:29:49] brion: i won't settle until i break the entire mobile site setup [16:29:54] :D [16:30:01] * yurik runs for the bushes [16:30:50] brion: i'm still learning the whole inclusion (kinda funky). I was thinking of adding another X-DfltLanguage=XX to the config to use in 666 errors [16:31:03] and unsetting that value right before returning [16:31:07] hmmm, that's not a bad idea [16:31:37] are there any reasons not to use header values as regular variables? [16:32:26] regular variables? [16:32:52] i'm asking in #wikimedia-operations for somebody who knows varnish better to double-check that this all works like we expect it should :D [16:33:02] but i bet ops are all asleep too ;) [16:33:29] also, is there a reason you don't check for the suffix ending? like [a-z]+\.org$ ? [16:34:03] i didn't write those regexes originally, it might be a mistake :) [16:36:45] must… resist… buying more phones [16:36:49] new blackberry is out [16:37:11] i think my dev phone is up to dye though, don't really need one [16:37:14] *up to date [16:38:15] brion: gotcha. Btw, there is a fix for the default lang - https://gerrit.wikimedia.org/r/#/c/55236/2 [16:38:21] is that how you set it up? [16:39:17] looks right [16:39:18] the idea from what i understand is to always redirect zero.* to en.zero.*/special [16:39:28] is "special" needed? [16:39:42] or can i redirect to en.zero.*/ [16:39:55] that's the landing page [16:40:07] so if you just go to zero.wikipedia.org you get sent to a language list instead of the default homepage [16:40:21] a, gotcha [16:40:42] brion: but the default case is to take the original params? [16:40:49] https://gerrit.wikimedia.org/r/#/c/55236/2/templates/varnish/mobile-frontend.inc.vcl.erb [16:40:51] line 557 [16:41:14] * brion hmms [16:42:04] i think something else might be forcing a redirect to the landing [16:42:15] in the ext maybe? i'll have to review it again [16:42:17] also, would it be ok to use canonical english Special:zero [16:42:26] for all other langs [16:42:45] this way i can use the X-DfltLang trick from above [16:43:10] i'm not 100% sure :) [16:43:17] but i think so [16:52:31] https://gerrit.wikimedia.org/r/#/c/55236/ merged \o/ [16:53:31] and https://gerrit.wikimedia.org/r/#/c/55242/ merged \o/ [16:56:10] \o/ [16:56:36] ohh boy [16:56:38] thanks brion [16:56:44] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54139 [16:56:52] now i should *really* hide! [16:57:31] :P [16:59:02] awjr: timecube.com [16:59:13] awjr: http://en.wikipedia.org/wiki/Time_Cube [17:01:51] jcmish: standup! [17:02:12] brion: so the big question now is - does it work? any testing suggestions? (other than setting x-* and seeing the banner [17:02:22] or should we just wait for the clients to complain :) [17:02:28] yurik: pretty much run down the banners yeah [17:02:48] and if they merged it, what's the usual eta? [17:03:10] for it to go live [17:03:20] you said an hour i think [17:03:30] once it's pulled down on the production puppet servers it "should" go out within 30-60 minutes [17:03:51] by pulled you mean merged to production branch? [17:03:56] or there is another step? [17:05:13] there is a second step, which is pulling from git onto the puppet master host [17:05:23] i may have the terminology slightly wrong but that's roughly it :) [17:05:41] since we're not in a hurry on this i'll just let the ops folks do it at their own pace [17:05:53] when we're in a rush we should specifically ask to make sure it gets pulled too [17:13:09] YuviPanda: timecube.com has just turned my brain into mush [17:14:13] jdlrobson, so I have a generalist interview in 45 minutes. wanna participate? [17:14:45] awjr: in that case you should *definitely* see http://neave.com/television/ [17:15:06] @_@ [17:15:06] Maryana: are we doing design walkthrough today? Or do you want to push it to monday? [17:15:30] we decided on wednesdays, since friday morning is friday night in india :) [17:15:45] oh [17:15:49] oko [17:16:09] though since we're doing planning mtgs next wednedsay, maybe monday would be better…. [17:16:27] i'll send out an email [17:16:28] :) setup a calendar invite and i'll be around :) [17:17:58] brion: understood about the steps, guess my question is more of "when should i start testing" - how do i know the new config has been deployed in prod [17:18:19] yurik: let's hop in #wikimedia-operations and ask :) [17:18:23] jdlrobson: re https://gerrit.wikimedia.org/r/#/c/54987/1/javascripts/startup/device-detection.js i think it would make more sense to keep the detection consistent with DeviceDetection.php [17:18:37] which *should* be consistent with the device detection done in Varnish [17:19:08] we already know (or at least believe) those rules are good [17:19:22] brion: hopped [17:25:19] New review: JGonera; "Where would we use that and why? As far as I know, we already have two different places with device ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:26:20] New review: awjrichards; "I think the device detection out to be consistent with what's in DeviceDetection.php (which is consi..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54987 [17:27:40] New review: Brion VIBBER; "ISTR there was some idea of pointing people at apps, for instance in CentralNotice banners, that we ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:27:51] awjr: so device detection.php - i thought we were killing that ? [17:28:04] and if so i think we should rewrite it.. it's not granular enough [17:29:08] jdlrobson: i dont recall any conversation about killing it - it's hard for me to imagine why we would as it's useful at least for third party setups [17:29:30] ok now i'm confused with what we talked about yesterday... ;) [17:29:31] jdlrobson: do you need it more granular for CN stuff? [17:29:34] New review: MaxSem; "Brion, shouldn't app banners be served by CentralNotice?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:29:38] i thought we were talking about doing device detection in js [17:29:58] if we drop WML and have a common stylesheet, we only need device detection to say "am i mobile?" [17:30:00] in theory [17:30:11] oh and "am i javascript-capable" i guess [17:30:47] awjr, what can you say about https://gerrit.wikimedia.org/r/55226 ? [17:30:51] jdlrobson: do you ened it more granular for any of the outstanding stories? [17:31:01] MaxSem: i'll take a look at it in a bit [17:31:04] aw apparently so... [17:31:29] awjr: well the origina story (from last iteration) was to serve banners to iPhones and android devices [17:31:40] the existing device detection detects opera mobile on iPhone as operamobile [17:31:48] so no banner would be shown [17:32:34] New review: Jdlrobson; "@jgonera arthur pointed out that we cannot set device with mw.config - as this would cause caching p..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:33:05] oh i see [17:33:24] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55268 [17:33:59] also awjr would appreciate your input or you taking on https://gerrit.wikimedia.org/r/#/c/52553/ - i did exactly what you said but MaxSem is unhappy :) [17:34:19] lol [17:36:27] ok, i think there are two different ways we can approach the device detection in JS. the quick way to get this out the door now to wrap up the outstanding dependent stories would be to replicate existing device detection rules. we can deal with updating them later and/or getting rid of the detection that happens in devicedetection.php. the other way is to update the rules now to be more granular [17:36:32] New patchset: JGonera; "Fix the page being wider than the screen on watched pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55283 [17:37:25] i think we should take the expedient approach now and update later. making sure that opera on iphone gets CN banners is nice, but not as important as making sure safari on ios does [17:37:36] New patchset: JGonera; "Prevent search focus when closing menu using hamburger" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55284 [17:38:19] we should walk into next iteration with all the stories currently in play closed out so we can focus on the performance stuff [17:39:13] awjr: this would be my dream and what i always want [17:39:38] jdlrobson: so let's do js device detection the quick way for now, we can make it better later [17:40:24] jgonera: will you be around to +2 https://gerrit.wikimedia.org/r/#/c/54069/ ? I'm fixing it up now [17:40:45] if you fix it soon then yes [17:41:07] guys, why do we need device detection in JS? [17:42:24] ok, reading jdlrobson reply to my comment [17:42:29] jgonera, for banners [17:42:55] yeah, but I was hoping we would pass the detected value from PHP's device detection [17:45:17] that's actually an interesting question [17:45:57] in 1-2 weeks HTML will not know about X-Device [17:45:59] New review: JGonera; "@jdlrobson, @awjr, will adding ESI help in putting this in mw.config instead? If yes, then let's mar..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:46:12] ^ awjr you want to field this one [17:46:31] jgonera: we're actually going to try to avoid using ESI for device-specific stuff per request from ops [17:46:49] i'll take a look at that sepcific patchset in a minute [17:46:56] my queue is getting long :) [17:47:15] but couldn't we mark the fragment of inline JS that sets mw.config values as not cacheable? [17:47:29] if we used esi sure [17:49:00] we would probably want to organize things in such a way that all device-specific whatever that needs to happen in PHP can be made to happen in one or two ESI chunks that would themselves be cached and varied on X-Device [17:49:41] but, we need to try to accomplish removing the need for X-Device variance without using ESI. from conversations earlier this week with jon and max in particular, it sounds like it should be doable [17:50:25] awjr: hi; when you have a moment, I'd like to briefly talk about the mobile team's plans to move the documentation on meta to mediawiki.org. I understand you chose meta a few years back, so I'd like to check with you that the move is ok and done well. [17:50:37] (it doesn't have to be now :) [17:50:59] ok guillom no problem - how much longer will you be around today? [17:51:40] awjr: at least an hour (for the Lua IRC office hour, but I'll probably be available during). After that, well, it's Friday evening so, not too long :) [17:52:15] ok guillom thanks [17:58:12] New review: awjrichards; "jdlrobson it's pretty common to call parent::__construct(). in fact, you also need to invoke Unliste..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/52553 [17:58:51] awjr: can you sort that patch out (not a PHP guy) - i feel like i'm just adding confusion to the whole matter [17:59:02] sure jdlrobson [17:59:09] thanks - i already have my plate full with this overlay stuff [17:59:13] sure thing [17:59:50] jdlrobson: one quick question - should all children of UnlistedSpecialMobilePage invoke clearPageMargins? [18:00:01] awjr: correct [18:00:04] k [18:00:08] so are we, possibly, considering removing complex device detection from PHP/Varnish and doing it only in JS? [18:00:08] then max was right :) [18:00:29] jgonera: basically yes [18:00:56] oh, ok, I was just afraid that it would get scattered all over the codebase ;) [18:02:08] yeah, if we don't need to vary anything on x-device, then there's no reason for us to do device detection in varnish. we may want to keep DeviceDetecion.php though for 3rd party users of MF [18:02:23] and by 'may want to' i mean 'should' [18:03:46] chrismcmahon: howdy [18:14:08] hello [18:16:35] New patchset: awjrichards; "Bug 44042: Add #content div to special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52553 [18:16:48] MaxSem: can you take a look at ^? [18:16:59] oh good, firefox os is definitely planning to add file upload support for v1.1 [18:17:00] awjr, I'm interviewwing [18:17:05] i just cleaned it up a bit, i think it's good to go [18:17:07] ok MaxSem [18:17:07] i still don't know how they let that slide from 1.0 :) [18:18:40] New review: awjrichards; "@jgonera it would, but per some planning conversations with ops, we are going to attempt to remove X..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [18:19:48] brion: no copy paste either, btw :P [18:19:57] copy paste? who uses that! [18:20:09] * brion fondly remembers the original iPhone [18:20:44] after the devices I used, I really hope that the biggest feature planned for 1.1 is... 'speed' [18:22:51] jdlrobson, how's that overlay patchset going? [18:23:01] jgonera: you don't realize the headaches you are giving me.. :) [18:23:28] ok, maybe let's merge it and I'll just put FIXMEs here and there...? [18:23:40] tfinc: I doubt it [18:23:42] ragesoss: http://commons.wikimedia.org/wiki/File:Center_for_Sustainable_Landscapes_at_Phipps_Conservatory,_Pittsburgh,_Pennsylvania_-_16.jpeg <-- will commons admins get pissy about the fishbowl ? [18:23:44] the OverlayManager is the problem.. i'm trying to work round it. [18:24:09] tfinc: admins? why? [18:24:18] using a fisheye lens isn't against policy. [18:24:22] tfinc: commons admins usually don't get prissy about things like that. [18:24:24] sweet [18:24:29] ive never seen it used on a commons image [18:24:48] tfinc: the *biggest* thing to think of, is FOP, I think. Catches most people off guard. [18:24:51] cell phone novelty lenses are teh awesu. [18:24:54] awesum [18:24:55] and the rules are not fully clear [18:24:56] FOP ? [18:25:08] i think i'e almost got it jgonera [18:25:19] tfinc: Freedom fo Panorama. Which things in public from other people that you photographed can and cannot be uploaded to commons [18:25:19] freedom of panorama ? [18:25:22] yup [18:25:28] tfinc: you can't upload Grafitti, for example [18:25:28] ok, I should be around for half an hour more [18:25:39] tfinc: because the author retains copyright over them :P [18:25:46] lame [18:25:51] (that was the response I got on -commons a while ago, might be totally wrong!) [18:25:56] ragesoss: ^ is that reading of FOP in the US correct? [18:25:58] * ragesoss is a commons admin, so ragesoss writes the rules. [18:26:09] tfinc: worst is the fact that it differs per country! [18:26:18] so something legal in country X might not be in country Y [18:26:34] YuviPanda: we need to get http://commons.wikimedia.org/wiki/User:Coentor to invite all of his friends to use the app as well [18:26:57] yeah, although it depends on how trivial it is. [18:27:11] ragesoss: so trivial graffitti falls under too-trivial-to-copyright? [18:27:17] while a banksy isn't? [18:27:28] like, if you're being really serious about FOP, just about any shot in a public place will have copyrighted content. [18:27:44] :P [18:27:51] but if that's not a significant focus of the picture, it's generally fine on Commons. [18:27:51] so the key is 'do not piss off someone' [18:28:14] YuviPanda: not so much that. [18:31:56] while mean-spirited copyright sticklerism happens occasionally, usually Commons is relatively consistent. [18:32:31] https://commons.wikimedia.org/wiki/Commons:De_minimis [18:32:42] that's the relevant policy. [18:34:44] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:34:46] jgonera: done. Sigh. Headache ^ [18:35:06] ok, looking now [18:35:31] ragesoss: ah, right. [18:37:13] jgonera: arg it's still not quite right.. i just remembered why i didn't use initialize before for LanguageOverlay! [18:37:24] because it needs to inherit from the parent [18:38:20] * jdlrobson makes slight adjustment [18:38:31] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:38:32] brion: ping [18:38:35] brion: could you check if you are getting a header pls? [18:39:01] yurik: for which carrier? [18:39:07] YuviPanda: yo [18:39:09] brion: tl;dr of our response to the nokia email should be 'go for it guys, but do not use wikimedia/WikipediaMobile code.' [18:39:13] concur? [18:39:13] i tried any [18:39:17] YuviPanda: yes :D [18:39:23] let me respond [18:39:24] brion: sorry, i tried beeline [18:39:34] if they want a good win phone app they should write it in C# [18:39:46] phone gap's just too ugly on WP [18:39:52] jdlrobson, quickly, self.isOpened = false; should be set in hide(), not in cancel buttons callback [18:40:00] yurik: ah that's probably disabled again, try Dialog Sri Lanka or one of the others [18:40:10] and I'd call it visible instead (that's the word jQuery uses often) [18:40:13] jgonera: trust me on this.. it's still not perfect but it needs to be set there [18:40:22] brion: the weird part is that the header dissappeared [18:40:23] hm... [18:40:26] ok [18:40:34] confused as to what it does then ;) [18:40:34] jgonera: the problem is the overlay manager needs to detach it without triggering an event [18:40:39] otherwise you will get an infinite loop [18:40:43] brion: responded. thanks [18:40:47] ok [18:40:47] brion: phonegap's too ugly anywhere. [18:40:52] let's leave it as it is then [18:40:59] i can write stuff in C# if you want - my fav [18:41:00] since it's not actually isVisible [18:41:06] jgonera: it's still not perfect and i know it can be improved but it works and it is better than the current situation [18:41:07] yurik: my fav too! [18:41:09] not that i want to play with windows phone :( [18:41:16] sure [18:41:16] yurik: Mono! [18:41:24] hehe [18:41:46] :) [18:42:21] fun fact: for a while a few years ago our search engine was in C# because the Mono runtime with Lucene.NET used less memory than the Java version on GCJ (Sun Java wasn't GPL'd yet) [18:43:50] brion, sorry, it works (assuming the new file is already online) [18:44:12] \o/ yay [18:44:17] and we should have stayed with mono! [18:44:49] yurik: yeah [18:44:53] java is eek [18:44:56] but, Scala is okay [18:44:58] I'lla llow that [18:47:25] jdlrobson: is https://gerrit.wikimedia.org/r/#/c/51591/ awaiting anything else now? it looks like the associated patchsets were merged and abandoned, respecitvely [18:49:50] awjr: see last comment [18:50:06] "We should iron out a few bugs beforehand notably https://bugzilla.wikimedia.org/show_bug.cgi?id=45452" [18:50:23] ah ok so it's dependent on special:loginhandshake - anyhting else? [18:51:34] dr0ptp4kt, yurik, brion: Beeline was happy with the test last night [18:51:45] good, thanks! [18:51:47] yei [18:51:59] dfoy: that's because they haven't seen my breaking changes just yet :-P [18:52:06] awesome [18:52:10] hah [18:52:30] yurik_: good thing we're pushing that config rearrangement while they're asleep then ;) [18:52:30] yurik :) [18:52:49] i'm reworking that file once more - adding default lang into that config [18:52:52] gerrit, why u so slow! [18:53:29] yurik: Great! The more we can get into the config, the less we'll have to keep changing that code [18:53:39] bugagaga [18:53:53] dfoy: so far it has just been refactoring of the existing code [18:54:07] hope brion can tell me about that req params line [18:54:08] yurik: ok [18:54:15] jdlrobson, is anyone else going to be reviewing this code or should I just merge it? [18:54:22] merge merge merge :) [18:54:22] New patchset: Jdlrobson; "Don't mess with the hash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [18:54:22] New patchset: Jdlrobson; "Rewrite createOverlay to use an Overlay View that is stackable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:54:29] uh... [18:54:35] wtf gerrit! [18:54:35] what's new in this one? ;) [18:54:51] should be nothing.. but i don't trust gerrit [18:54:52] ffs [18:54:53] dfoy: should make it much easier to add a new one though [18:54:59] and configure the languages [18:55:01] (defaults) [18:55:08] ok, check it quickly [18:55:31] New review: JGonera; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54069 [18:55:34] yurik: I agree. Another thing I noticed during the test was that we had a landing page with zero.wikipedia.org but not on m.wikipedia.org [18:55:49] jdlrobson, just some comments, but they're non-blocking [18:55:58] dfoy: i could REALLY use a qa :) [18:56:02] if you tested this code manually and it works, then it's good to merge [18:56:10] jgonera: i'm just going to resubmit patch set 11 [18:56:17] coding in notepad is just not that safe for billions of users without testing ;) [18:56:26] ok, but there's no further changes, right? [18:56:48] sigh i don't know wtf is going on jgonera [18:56:51] there should be none [18:56:52] yurik: I know - I'd like to see that as well [18:56:56] did something get merged maybe? [18:56:58] i had to rebase.. [18:57:02] jdlrobson: what happened? [18:57:08] I don't think so [18:57:10] gerrit made my life a misery [18:57:15] I merged a few very small things earlier today [18:57:21] yurik, brion: Brion, have you gone over using labs for some initial testing with Adam and Yuri? [18:57:28] nope [18:57:31] but literaly, single line changes in few files [18:57:35] brion said its not there yet [18:57:52] yurik: ok [18:57:55] no, i don't know whye current state of it. let's check in with jcmish when she gets back onlikne [18:58:22] jdlrobson: issue with a patchset with dependent patchsets? [18:58:26] guys, do you need something else today? I'll be out for today in a few minutes [18:58:41] awjr: i don't know.. i just updated a patch dependent on it and hit git review [18:58:46] and it resubmitted the patch it was based off [18:58:48] sigh [18:58:54] ah, it always does that, doesn't it? [18:58:56] i need to meet some people for lunch i'll be back in a bit [18:58:58] that makes sense, it would've rebased the other patchset [18:59:05] jgonera: i assume it's just a rebase [18:59:06] i hope [18:59:09] it should be [18:59:12] that's totally normal [18:59:17] gerrit makes me die inside [18:59:28] you can double check, you have my +1 so merge if you feel safe [18:59:46] we might want to carve out some time to get a better understanding of patchsets and dependencies as these seem to be giving folks a lot of grief [19:00:14] jgonera: what's the status of the loginhandshake? [19:00:23] maybe some workshop from people who actually think that gerrit is not a bad tool? maybe we just don't know how to use it? [19:00:44] roan has passed on quite a few tips to me around dealing with patchsets and dependencies [19:00:57] perhaps we could do a lunch with him sometime soon to share his tips and tricks [19:01:01] awjr, I tried changing the thing that brion mentioned (document.referrer) and it stopped working for me... [19:01:08] doh [19:01:11] I will try to see if I can debug it now quickly [19:01:21] and if not, then I'll check it tomorrow [19:01:33] hmm [19:01:36] fun [19:01:39] ok jgonera - we should get that merged asap as it seems to be a blocker for a bunch of other changes [19:02:00] btw anyone knows how to clear localStorage on Chrome for android? clearing the cache/data doesn't seem to clear it [19:02:04] I know [19:02:52] but jdlrobson would've killed me if I hadn't reviewed his changeset ;) [19:03:13] :p [19:09:13] back [19:09:25] jgonera: maybe settings > apps > All > Browser > Clear data + Clear cache? [19:09:45] dr0ptp4kt, I think I just needed to reopen a tab ;) [19:09:53] but thanks [19:09:59] cool [19:12:37] * brion has fallen into meta discussions oh no! https://meta.wikimedia.org/wiki/User_talk:Sue_Gardner/Wikimedia_Foundation_Guiding_Principles [19:12:59] brion, awjr, I think the fact that it stopped working is not related to document.referrer but to rebasing... sigh [19:13:07] dang [19:13:09] :( [19:14:43] yep, jdlrobson any changes that would make loginhandshake.js not load? [19:15:32] oh, he went for lunch didn't he? [19:15:47] ok, I'll have to figure this out tomorrow [19:15:59] ok jgonera thanks - get some rest :) [19:17:31] err, just got a varnish error when trying to log in to the mobile site [19:17:38] awjr, to be honest I already feel pretty OK after one night sleep, but it's the first Friday I'm here and I'm meeting some friends ;) [19:17:56] :) [19:18:14] then dont rest, party! [19:18:20] Maryana: wfm [19:18:22] :D [19:18:30] weird [19:18:35] i blame jgonera [19:18:45] Maryana: stable/beta/alpha? what was the varnish error? [19:18:59] Maryana, where's the smiley? or was it not a joke? [19:19:01] alpha - lemme try again [19:19:13] jgonera: :) [19:19:21] now I feel better [19:19:23] hahahaha i never realized how important emoticons are until i started working remotely :p [19:19:32] hehehe [19:20:00]