[12:56:29] New patchset: JGonera; "Load hi-res icons for JS-enabled devices (regression)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55572 [14:57:23] hey brion [14:57:24] update https://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_5 [14:57:25] ? [14:59:58] added bugfix/polish/prevent overwrites [15:00:07] that should be enough to reach initial market [15:06:13] brion: lgtm [15:06:19] brion: when is monty joining? [15:06:27] next monday [15:06:34] hmm, midsprint [15:06:41] brion: when is create-account landing? :D [15:06:46] soooooon [15:07:20] :D [15:22:09] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55464 [15:22:10] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55464 [17:17:38] * YuviPanda waves at jgonera [17:17:45] hey [17:17:48] jgonera: did you see the patch jdlrobson committed than abandoned? [17:17:55] re: descriptions for non-mobile-web images? [17:18:07] I'm not sure, can you give me a link? [17:18:09] I left comments on that patchset [17:18:11] sure one moment [17:19:30] geez gerrit is horrible [17:20:12] ;) [17:20:25] hehe welcome to the painnnn [17:20:35] YuviPanda, jgonera, the descriptions stuff is related to the image info [17:20:42] jgonera: https://gerrit.wikimedia.org/r/#/c/54492/ [17:20:51] basically, description is one piece of image info [17:20:58] yes, I've linked to https://www.mediawiki.org/wiki/Requests_for_comment/Image_information [17:21:13] though I'd be *really* happy if we could use wikibase rather than our own extension [17:21:23] since the app (and web too, eventually, I guess) will have to both edit and read [17:22:14] and that would mean something that can parse the template and also serialize it back to wikitext [17:22:29] editing is a bitch. bleh. [17:22:31] so what about the jdlrobson's patch? [17:22:58] jgonera: no, I've left some comments that I though would be useful, since you said during standup you'll start looking into implementing it [17:22:58] :) [17:22:59] that is all [17:25:47] I think this is the reason jdlrobson abandoned it, there's just too many cases to do quick and dirty manual regex parsing [17:25:59] jgonera: regex and wikitext do not mix [17:26:09] what do you mean? [17:26:16] as in, it's hard to parse wikitext with regex [17:26:25] well, hard to parse it properly, at least. [17:26:33] well, yes, definitely if we want to cover the whole syntax [17:26:58] but I think we'd be happy with covering 90% of what can appear in file description and some way of stripping the rest [17:27:04] but I just have to investigate more [17:27:05] brion: did you say that you've got centralauth set up locally for testing? [17:27:09] okay [17:27:26] jgonera: please add me as reviewer in the patchset when you submit it, since I would look into stealing parts of it for the app too :) [17:27:41] awjr, I thought we could test LoginHandshake on beta labs if we can modify the configuration for it (to set the global config var) [17:28:05] i think that might require merging it? [17:28:07] im not sure [17:28:10] MaxSem: do you know? ^ [17:28:12] YuviPanda, if there is a patchset I will, it's a spike and the result of a spike can be "can't be done in reasonable amount of time" ;) [17:28:35] jgonera: hehe, okay. in that case do let me know :) [17:28:38] awjr, yes [17:28:51] yes we'd have to merge it? [17:28:53] awjr, that's true, but that's still before deploying it ;) in the worst case we revert. that is unless there's another easy way of testing it [17:28:57] ypu [17:28:57] true that [17:29:01] MaxSem: what about config changes? [17:29:10] can be done separately [17:29:28] awjr: can you poke maryana? There's a meeting scheduled for us right now but no hangout link [17:29:41] sure YuviPanda [17:30:05] thanks awjr [17:30:10] awjr: on one of my test instances yeah, i can try to test… in theory :D [17:32:05] hey marktraceur [17:32:06] err [17:32:07] Maryana: [17:34:16] brion are you set up with two different domains? [17:35:01] ah they're on the same parent domain [17:35:09] so…. dunno if that'll help [17:35:10] darn [17:35:32] ok, then let's try it out on betalabs! [17:35:54] MaxSem: how do we make a config change for betalabs? [17:36:06] mobile-labs.php [17:36:07] whee [17:37:59] brion: YuviPanda : please update http://www.mediawiki.org/wiki/Wikimedia_Apps/Commons#Iteration_4 to be current [17:38:28] tfinc: it is for android [17:39:07] updated [17:41:48] Maryana: just checked, https://commons.wikimedia.org/wiki/Special:Contributions/notnarayan shows nothing after that email. [17:42:19] YuviPanda: i noticed a blinking cursor issues in the latest beta. the blinking cursor is off white on a white background [17:42:21] ok, let's give him some time to catch up, then [17:42:22] YuviPanda: you can barely see it [17:42:34] tfinc: oh, on the share screen? [17:42:38] upload [17:42:47] yeah, okay. filing bug, I think I know what's causing it [17:43:13] I noticed that the disabled / enabled looks of the button were sortof inverted too [17:43:33] tfinc: i'll file ab ug [17:43:36] *a bg [17:43:37] grr [17:43:38] *a bug [17:44:57] where's jdlrobson? [17:46:01] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=46543 [17:46:15] jgonera, MaxSem - sorry, just getting settled in and set up here, i'll try to get things sorted for loginhandshake on betalabs [17:48:44] awjr, sure [17:48:54] jgonera: what's the config change that's needed? [17:49:28] awjr, $wgMFLoginHandshakeUrl [17:49:42] jgonera: ah yeah, sorry what should the value be? [17:50:05] it should point to the Special:LoginHandshake url of Commons (or in this case beta Commons) [17:50:15] ok cool [17:51:55] YuviPanda: thanks [17:53:36] jgonera: entonces, http://commons.wikimedia.beta.wmflabs.org/wiki/Special:LoginHandshake ? [17:53:50] or https? [17:53:59] oh, we don't have SSL there right? [17:54:26] yes, that should be it [17:54:34] unfortunately not yet [17:54:41] of course we need to deploy the change both to beta wiki and beta commons [17:55:27] yah - i think if we just merge it, it will… just happen [17:55:50] on commons too? [17:56:58] good question - MaxSem do you know? ^ [17:57:02] i assume so [17:58:07] jgonera, use the same protocol as the calling UserLogin [17:58:16] (sorry, I've got an interview) [17:58:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54813 [17:58:51] MaxSem, that depends on how we set the $wgMFLoginHandshakeUrl, I guess we can just use // and it will work too [17:59:11] awjr, yeah, try //commons.wikimedia.beta.wmflabs.org/wiki/Special:LoginHandshake instead [17:59:19] will Location: //foo.bar.com work? /me doubts that [17:59:19] brion: heads up. i change the weekly app meeting to R33 [17:59:20] MaxSem: if i merge https://gerrit.wikimedia.org/r/#/c/55611/, will it get automatically deployed to betalabs too? [17:59:27] tfinc: ok [17:59:33] jgonera: im gonna leave it http for now [18:00:30] awjr, ok, in the worst case we can assume https in production, because we force it on login page anyway, right? [18:01:18] so basically, to test it, you want to grab the iphone 4 from the drawer, clear all Safari's cache and data and go to beta wiki [18:01:42] then log in, and only then open a separate tab for beta commons and check if you're logged in there too [18:02:43] meh, i'll merge it and we'll find out :) [18:09:30] New patchset: JGonera; "Add animation to popups and drawers (alpha)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55613 [18:09:50] correct jgonera [18:09:59] it works? [18:10:09] jgonera: not sure yet - sorry, lots of distractions in the office :p [18:10:17] ok ;) [18:10:38] awjr, one thing (sorry for distracting even further) [18:10:42] np [18:11:30] is it OK if I leave today before the sprint kickoff (in 1.5h)? it disappeared from my calendar on weekend and magically reappeared today [18:13:13] jgonera: i think that should be fine - you're already caught up with the performance-related work for the next sprint, right? [18:13:43] mobile down :( [18:14:07] yeah im seeing 503 [18:14:14] ops are on it [18:15:01] thanks jdlrobson [18:15:09] awjr, I think so, I guess my top priorities will be RL stuff and analyzing NavigationTiming data (I guess we'll have to split this somehow between Jon and me) [18:15:27] ok, i trust you guys can coordinate how to split that stuff up [18:15:57] wow there's been a huge drop in traffic to the mobile caches in the last 5-10mins, i guess because of the 503s [18:16:02] yeah, we'll figure this out tomorrow [18:16:07] hm [18:16:20] did we do something? is it our fault? ;) [18:18:33] doesn't appear to be [18:19:01] it sounds like possibly fundraising related, something that's killing apaches which is affecting us [18:19:35] you can follow along the fun in #wikimedia-operations [18:20:31] Maryana, do we have the QA meeting? [18:21:25] i haven't seen or heard anything from michelle [18:21:46] on the engineering calendar, she added that she's flying to MA, but i dont really know more than that [18:23:49] brion did you build any part of the UploadCampaigns stuff? :D [18:24:21] chrismcmahon: ping - got a few betalabs questions for ya [18:24:31] hi awjr [18:24:34] :D [18:24:43] YuviPanda: i think i did the api bit that lets us pull the campaign lists, needed it for WLM back in the day [18:24:51] the rest is…. weird UploadWizard stuff ;) [18:24:53] how often does code get updated from master on betalabs? also, if i make a config change, does that automatically get deployed to betalabs as well? [18:24:55] hehehe [18:24:57] chrismcmahon: ^^ [18:25:01] * YuviPanda waits for marktraceur to appear [18:25:19] jgonera, it doesn't look like we have much to demo still [18:25:19] he usually does when someone says UploadWizard [18:25:21] everything's awaiting code review [18:25:31] Maryana, ok, I see [18:25:49] jcmish, was there anything user facing to look at for QA review? it looks like we're still stuck in code review limbo on mingle [18:25:53] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55105 [18:26:29] awjr: code itself is updated automatically frequently, I think within minutes of each check-in. Config is a bit more complicated, but I believe that unless you're changing a production override in a local config file, that should also be automatic. I think. [18:27:07] I think jcmish is out today, eng schedule mentions flying to MA [18:27:45] awjr: any specific concern? [18:29:47] chrismcmahon: ok - yeah we're trying to test something on betalabs that we can't realistically test locally. i merged https://gerrit.wikimedia.org/r/#/c/54813/3 about 30 mins ago but does not appear to be live on beta labs [18:30:12] but im wondering if it appears to not be live because it depends on a config change [18:30:20] https://gerrit.wikimedia.org/r/#/c/55611/, which i merged also abaout 30 mins ago [18:30:55] jdlrobson, is there anything that needs to be merged in order for something not to be broken? [18:31:23] chrismcmahon: those changes should expose this special page: http://commons.wikimedia.beta.wmflabs.org/wiki/Special:LoginHandshake [18:32:11] YuviPanda: on the template parsing, try the 'rvgeneratexml' setting on prop=revisions - https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&prop=revisions&format=json&rvprop=content&rvlimit=10&rvgeneratexml=&titles=File%3APatriarch%20John%20X%20of%20Antioch.jpg [18:32:25] brion: parsing isn't a problem, but how do you serialize? [18:32:42] concat the plain text of the xml nodes [18:33:14] brion: and how do I go from xml -> wikitext? [18:33:18] also, no dirty diffs :P [18:33:26] as i said, concat the plain text of the xml nodes :) [18:33:36] oooh right [18:33:40] hmmm [18:33:56] brion: hmm, so instead of parsing wikitext, I'll be parsing xml [18:33:59] you can walk the xml tree until you find the template bits you want [18:34:00] and serializing xml [18:34:02] yeah [18:34:03] yeah, should be …. simpler at least [18:34:11] and should give just enough structure for what we need [18:34:12] chrismcmahon: any ideas about what might be going on? [18:34:17] brion: yes, it is [18:34:20] \o/ [18:34:25] brion: indeed! [18:35:16] awjr: not specifically. and hashar is not around. I suspect the issue has to do with redirecting to the commons wiki. [18:35:21] brion: yes, much better, actually [18:35:49] chrismcmahon: well, the changes look like they should expose taht special page everywhere [18:35:51] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/dKSxfA [18:35:51] Commons-iOS/master 0ca5d58 Brion Vibber: Update project file for newly-committed languages from TWN... [18:35:53] (on every project, i mean) [18:36:30] hey jgonera and Maryana, when were we going to change the mobile favicons? do we have a story for it? i should be uploading this asset somewhere :) [18:37:03] munaf, depending on how much time we spend on the performance issues, we might do this in the upcoming iteration [18:37:08] jgonera: talk page stuff would be nice.. [18:37:29] https://mingle.corp.wikimedia.org/projects/mobile/cards/443 [18:37:36] munaf ^ [18:37:45] dankeshön [18:37:51] as jgonera says, probably not until next iteration [18:38:14] New review: Jdlrobson; "The code allows long descriptions. This was a request from the story - I will revisit and potentiall..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54587 [18:38:18] cool thanks [18:38:39] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54795 [18:38:41] brion: the xml parse looks much better than writing my own parser :) [18:38:51] brion: with the sore point being... it is xml :P [18:38:56] brion: but I'll still have to write a serializer [18:39:18] jgonera: on https://gerrit.wikimedia.org/r/#/c/54795/5/javascripts/common/mf-history-jquery.js [18:39:29] yes? [18:39:38] a push state event is fired on document load [18:39:51] in every browser? [18:39:52] at least it does on Chrome [18:40:00] i'm pretty sure the spec says it should [18:40:06] because I just read on MDN "Browsers tend to handle the popstate event differently on page load. Chrome and Safari always emit a popstate event on page load, but Firefox doesn't." [18:40:16] ahh and i assume you are testing in Firefox? [18:40:21] nope [18:40:32] so now I'm confused.. [18:40:32] I'm testing on Android Browser [18:40:47] nevermind, I was just wondering what this code is supposed to do [18:41:10] (for the record i'm not actually changing the existing code - so if this is a problem we should address it as a separate bug :) ) [18:41:13] which android browser? [18:41:24] 4.2.1 [18:41:32] YuviPanda: ok we'll plan to work with that format then :D [18:41:38] awjr: looking, wish I were more help, sorry about that. [18:41:49] but why are you asking? knowing the browser will not help me understand the code ;) [18:41:52] brion: but we should still see if we can put in editing into that RFC [18:41:54] jgonera: i'm just confused what the issue is.. [18:41:57] brion: will make our lives much easier [18:42:00] brion: and avoid code duplication [18:42:05] it's ok chrismcmahon - thanks for looking. i'll keep an eye out for hashar too, i think he typically signs on around now [18:42:09] the code is there to handle back button with respect to hijacked links [18:42:09] we'll get to it :) [18:42:15] i'm gonna grab a bite to eat, bbiab [18:42:20] brion: ok [18:42:42] jdlrobson, the talk stuff simply doesn't work [18:42:56] the button overlaps the page title in a weird way and when I tap it nothing happens [18:43:25] actually, it sometimes overlaps the title and sometimes hides a bit under the chrome [18:43:34] anyway, doesn't look right... [18:47:24] New review: JGonera; "Doesn't work. Tested on Android Browser 4.2.1. The button overlaps the page title in a weird way or ..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54140 [18:49:43] awjr: there is an extra Nexus4 in the testing cabinet if you want to test drive [18:49:53] jgonera sigh.. looks like another rebase issue - should be easy to fix [18:49:53] oo cool tfinc, i'll take a look later today [18:50:40] awjr: apropos of that merge not propagating to beta, want to put in a BZ ticket for hashar about? or I can... [18:50:47] about it [18:51:14] i can do it chrismcmahon - actually, is this stuff documented anywhere? i haven't been able to find anything [18:51:25] Maryana: jdlrobson told me about 'edit' sneaking into stable logged in. what results are we seeing from it ? [18:51:36] i'm writing up a team email about it now :) [18:51:38] awjr: not documented well at all [18:52:04] tfinc: with charts! [18:52:04] ok, then it's not just my search-fu :p [18:52:57] awjr: https://meta.wikimedia.org/wiki/Talk:Metrics_and_activities_meetings/Quarterly_reviews/Mobile_contributions,_2013-03-18#Geographically_distribute_team [18:53:02] awjr: your blog post can directly answer this [18:53:36] Maryana: hopefully your charts go up and to the right as all charts should [18:55:03] tfinc oh yeah… [18:55:10] i've been 'working' on that blog post for a long time now [18:55:19] awjr: respond to them and let them know your writing it [18:55:23] ahem [18:55:24] ok [18:55:28] here is your kick in the pants to get it out [18:55:31] where's the blog post schedule again? [18:55:42] Maryana can tell you [18:55:42] heh [18:56:19] awjr: http://meta.wikimedia.org/wiki/Wikimedia_Blog/Calendar [18:56:57] ty :) [18:57:46] ok so im still a bit in the dark about why we're not seeing our changes on betalabs, but apparently there's also a possible glusterfs problem - jgonera, chrismcmahon [18:58:37] im gonna grab some lunch in a minute - i've emailed max, antoine and michelle about the issue - hopefully one of them will get back to us soon. if i dont hear back after i've grabbed food, i'll look into alternatives for testing [18:59:32] awjr: could be. to the best of my knowledge, prod configs are replicated automatically UNLESS there is a local override of that particular config option, in which case config changes are invisible until tweaked manually on beta [18:59:57] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [18:59:58] New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [19:00:07] jgonera: ^^^ pleeeasseee [19:00:07] chrismcmahon: i dont quite understand what you mean by a local override of a particular config optino? [19:00:15] before it breaks again with a rebase [19:00:26] awjr: say you have myC [19:01:32] awjr, jdlrobson what is the optimal time limit for the generalist task, in your opinion? [19:01:54] the current task, Max|interview? [19:01:55] awjr: say you have "$myConfig=foo" in CommonSettings.php. Beta has a CommonSettings-wmf.php that has "$myConfig=thisAintChanging" that will override whatever the prod settings are for $myConfig [19:02:04] Change abandoned: Jdlrobson; "Maryana says she forgets why this was a requirement so let's just chuck it and call this story done." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54587 [19:02:06] yes [19:02:38] chrismcmahon: ok, what if there is no config set in production (just whatever the default value is), but you set it just for labs? [19:02:49] jeez i dunno, a few hours [19:03:19] the PE task suggested 2 hours. too little for generalist one? [19:03:51] im not sure from the frontend perspective, but i would think 2 hours would be good for the backend portion of the task [19:04:03] awjr: set it just for labs is a manual operation on a deployment* host (if I understand the question correctly) [19:04:04] maybe no more than 4 hours total? (total shot in the dark) [19:04:29] chrismcmahon: we apparently have a labs-specific config file - wmf-config/mobile-labs.php [19:04:36] but you're saying that would need to be updated manually on labs? [19:04:43] (eg what's touched here: https://gerrit.wikimedia.org/r/#/c/55611/) [19:05:15] damn, yeah, glusterfs is apparently all kinds of messed up on labs right now [19:05:19] (surprise!) [19:05:31] bah [19:08:09] bah, today's meltdown was caused by FR "at mobile's request" [19:09:01] @_@ [19:09:35] hey fundraisers, can you please take down the site for us? kthx [19:10:14] paravoid: we originally had it in; but I removed it on request from mobile because they had concerns that setting this globally (which we were doing in the CN controller) would break their stuff [19:10:44] I don't understand it fully, but who requested what?:) [19:11:28] awjr, the changesets or something else? [19:11:39] jgonera: eh? [19:11:57] awjr, sorry, it was jdlrobson ;) [19:12:06] I read two messages too fast after one another ;) [19:12:26] :p [19:12:35] jgonera: change sets yes. They've been there for a week. Too long. [19:12:54] * YuviPanda adds quote to quips [19:13:00] we already have a bad reputation wrt performance, let's not aggravate it:) [19:13:06] lunch? [19:13:08] hehe, last one I saw was i am so in love with git stash. don't tell sarah. [19:13:19] jdlrobson, awjr, tfinc? [19:13:25] hahaha [19:13:27] Maryana: yah! [19:13:40] i think jdlrobson is in too but he's sorting something out [19:13:43] jdlrobson, I understand, but it's not like I've not reviewed the talk one [19:15:28] jdlrobson, anyway, any reason to make the button red? we don't use that color very often, only for error messages and diffs [19:15:31] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/1MQOOA [19:15:31] android-commons/master f7882e9 YuviPanda: Fix theming on Share Window to look appropriate... [19:15:43] New review: Jdlrobson; "jgonera.. what is wrong with your setup? This is working fine for me again - is the address bar chan..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [19:16:32] jdlrobson, are you testing on mobile Android Browser or on desktop? ^ [19:17:16] jdlrobson, ok, so I have a talk page that says "Hey there!" and the talk overlay shows "There are no conversations about this page." is it ok? [19:19:24] brion: remember to fix the EL related bugs before pushing to store :) [19:19:35] EL? [19:19:44] eventlogging [19:19:48] ah yeah [19:20:26] iOS doesn't log some things now, IIRC? [19:29:03] New review: JGonera; "(5 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54140 [19:29:11] brion: ping [19:29:14] brion: uploadcdampaign question [19:29:20] brion: can it contain arbitrary key-value pairs/ [19:29:21] ? [19:29:47] YuviPanda: my impression is… theoretically yes, but it's limited by what the front-end allows you to put in [19:29:58] sure, that's fine. we can modify the frontent [19:30:00] *frontend [19:30:01] awjr_lunch, Maryana_lunch, what are your thoughts on my last comment on https://gerrit.wikimedia.org/r/#/c/54140/ ? [19:30:03] but the database is freeform? [19:30:26] yeah iirc [19:30:37] so we can add fields relatively easily if we need to [19:30:58] brion: sweet [19:31:20] brion: in that case i think server side work is *very* minimal :) [19:31:23] \o/ [19:31:27] awesome [19:32:22] jdlrobson, please merge https://gerrit.wikimedia.org/r/#/c/55572/ unless you have something against it. Vibha will be pissed if you don't ;) [19:35:32] New review: JGonera; "Are you testing on mobile Android Browser or on desktop? It works on desktop Chrome, but not on Andr..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [19:39:34] jgonera: talk page - all known problems. No design input due to alpha [19:39:56] jgonera: known issue about talk pages with just text - not sure how to deal with it yet [19:40:11] that's why i want it in alpha to get people discussing it [19:40:25] jdlrobson, I thought that even things we develop in alpha should be briefly commented to someone instead of being developed in secret [19:40:26] hm, ok [19:40:43] anyway, as I said, it's good to merge after a few small fixes [19:44:08] jgonera - that's a good point (re: talk pages) [19:44:36] the biggest problem with giving a mobile-friendly view of talk pages is that they tend to come with huge, weird looking header templates [19:44:45] I mean, I don't want jdlrobson to feel like I'm against this, I just prefer to raise any issues sooner than later [19:44:54] yeah, totally [19:45:28] * jdlrobson had the understanding that alpha is a testing ground and as long as code is good it doesn't need to be a complete solution. The purpose of the alpha is to get a feature in front of a larger audience and see how people respond to it [19:45:40] otherwise we just have another beta [19:45:53] i've actually been really disappointed with the lack of attention to getting code into alpha [19:45:58] jdlrobson: yep :) go for it and see how it looks [19:46:59] i think the challenge with code review for alpha is that we typically have a lot of higher priority changes to push out for beta/porudction. personally if i only have a set amount of time for code review, i get through everything else before looking at alpha-specific changes [19:47:47] New review: JGonera; "Please see comments for patchset 10." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54139 [19:49:13] awjr, that's also true for me [19:50:29] jdlrobson, I understand that alpha should give us some freedom, but I still think that having a chat about a possible idea with someone before starting any work is a good thing [19:50:39] that's now how my brain works [19:50:56] i get excited about something, play around with ideas and end up with something [19:51:05] this particular thing was coded on a friday night [19:51:10] hm [19:51:11] tfinc_: I just talked to odder (commons community guy, deep into the community, I'd think) about Campaigns, and he's very enthusiastic :) [19:51:14] I'm writing up requirements [19:52:04] I understand, jdlrobson, this might mean however that not all of the code you write for alpha will ever make it out of alpha, but maybe that's the point of alpha [19:52:28] personally, I get a bit frustrated when I write code which later is not used ;) [19:54:26] jdlrobson, I have to go now, but I promise I'll re-review those two changesets first thing tomorrow so that we can possibly squeeze them in before deployment (they're alpha only anyway, so I'd hope others won't have anything against) [19:54:30] jgonera: we've never talked about alpha maintenance but some stuff e.g. nearby does get pushed into beta [19:54:43] jgonera: any issues with me merging talk page after fixing up your changes? [19:54:45] New review: Jdlrobson; "I'm looking at various devices including my Android (albeit a slightly different version) and don't ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [19:55:03] jdlrobson, absolutely, but Nearby is a feature that everyone knew about before you started working on it ;) [19:55:05] also might be worth reading that quickly if you can .. i'm really not sure what's going on with the address bar in your android :/^ [19:55:19] jdlrobson, no, but the changeset it depends on has some unanswered questions [19:56:02] jgonera: i don't see unanswered questions.. did you submit them? [19:56:06] (grr gerrit) [19:56:36] yes, for previous patchset, I didn't know a new one was coming [19:56:48] I don't see any difference between them anyway [19:57:09] jgonera: it's not published.. [19:57:30] also it just got rebased as gerrit loves to do that when you resubmit children [19:57:37] ps. i really hope people didn't see me as a grumpy muppet :) http://1.bp.blogspot.com/-9tL9I0BNyN8/T_bKZHDkO5I/AAAAAAAAAHo/pTWUwBYVOWU/s1600/grumpy-muppets.jpg [19:58:01] omg [19:58:02] wtf [19:58:22] New review: JGonera; "(5 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54139 [19:58:23] now? [19:58:29] yup thanks :) [19:58:56] jdlrobson: you're the gerrit loving muppet :) [19:58:56] * YuviPanda runs away [19:59:25] New review: JGonera; "It's not more broken, it's as broken as it was, but I thought the purpose of this change is to make ..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/54795 [19:59:53] jgonera: still around? [19:59:57] i think betalabs has latest code now [19:59:58] yes [20:00:29] jgonera: we should be able to test the handshake in betalabs now [20:00:47] New review: Jdlrobson; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [20:00:55] awjr, good [20:01:06] I can't do it because I don't have an iPhone though ;) [20:01:15] I mean, I can, but I won't know if it fixes anything [20:01:41] jgonera: what do i need to do to tesT? [20:02:14] New review: Jdlrobson; "The goal was to stop us messing with the hash. :-) Dynamic sections is a whole different kettle of f..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [20:02:30] jgonera> so basically, to test it, you want to grab the iphone 4 from the drawer, clear all Safari's cache and data and go to beta wiki [20:02:31]