[00:02:32] New review: JGonera; "Seems neater indeed ;)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/55797 [00:11:45] yurik: lgtm - i'll test it locally shortly [00:25:12] New patchset: JGonera; "Add lead photo upload CTA (#343)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [00:25:54] awjr, thanks! pls let me know [00:30:34] New patchset: JGonera; "Fix gazillions of JS errors on some pages (regression)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55832 [00:31:02] awjr, please merge this before the deployment ^ [00:31:47] jgonera, how are you still awake? [00:32:19] Maryana, I just came back from a pub and thought I'd check out if everything is OK ;) [00:32:38] yurik: just tested locally, looks good! [00:33:04] jgonera: what is a good way for me to test that change? [00:33:09] and I'm still not beating MaxSem with my working hours [00:33:14] heh. true. [00:33:26] awjr, go to login page without it and look at the JS console in Chrome [00:33:26] * MaxSem waves at jgonera [00:33:50] ah [00:34:22] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55832 [00:35:27] New review: JGonera; "Rebased." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [00:36:34] awjr, someone should also get https://gerrit.wikimedia.org/r/55572 merged or Vibha might get furious (and not that I wouldn't understand her after reviewing all the menu icons) [00:36:46] New patchset: awjrichards; "Regression: Remove OverlayManager, Fix photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55797 [00:37:28] ok, now I can go to bed ;) [00:37:32] see you tomorrow! [00:37:52] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55797 [00:40:16] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55572 [00:40:35] New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140 [00:40:35] New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [00:41:41] MaxSem: still around? [00:41:46] yup [00:42:54] is there a varnish change equivalent of https://gerrit.wikimedia.org/r/#/c/55393/1/includes/DeviceDetection.php [00:42:56] ^ MaxSem ? [00:43:32] will be, once the PHP change is merged [00:45:22] Maryana: still in the office/ [00:45:52] New patchset: Jdlrobson; "Bug 46435: Fix badly named global variable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55802 [00:48:33] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55832 [01:04:11] awjr, heya [01:04:15] are you still here? :) [01:07:03] Maryana: yes! you?! [01:15:08] New patchset: Jdlrobson; "Bug 46441: Move legacy css for menu into mobilemenu.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836 [01:20:07] New patchset: Jdlrobson; "Bug 46441: Move legacy css for menu into mobilemenu.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836 [01:21:48] Maryana: still around? [01:28:10] yes [01:28:13] what's up? [01:35:14] New review: Jdlrobson; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [01:35:33] New review: Jdlrobson; "A few minor nitpicks." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/53475 [01:35:50] New review: awjrichards; "This seems to fix the problem for photos uploaded from the dashboard, however when i upload photos f..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55802 [01:39:07] New review: awjrichards; "Looks good to me - Juliusz/Brion, can one of you dbl check the JS?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/55159 [01:44:01] New review: awjrichards; "See previous comments - just forgot to -1" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/55802 [01:46:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55818 [01:53:27] New patchset: Jdlrobson; "Fix fix me (js error on edit page)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55838 [01:55:08] New review: awjrichards; "I take it back - the problem appears to be that i was reuploading the same image over and over again..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55802 [01:55:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55802 [01:56:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55838 [02:02:22] New patchset: Jdlrobson; "Don't mess with the hash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [02:05:16] New review: awjrichards; "This looks fine to me, but let's double check with Maryana about which behavior is better." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54795 [11:02:15] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55832 [11:09:18] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [11:16:02] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/55836 [11:20:30] New patchset: JGonera; "Add lead photo upload CTA (#343)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [11:25:27] New patchset: JGonera; "Add lead photo upload CTA (#343)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/53475 [12:53:02] New patchset: Zfilipin; "Switch to new RVM setup files" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55880 [14:10:21] hi all [14:10:40] I'm trying to figure out how to add CSS to a mobile site [14:49:29] mark___, edit MediaWiki:Mobile.css [14:53:18] New review: JGonera; "Uh, jdlrobson, so the search code is currently related to dynamic sections? They both mess with the ..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/54795 [15:06:07] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/54139 [15:23:24] Thanks MaxSem, but this seems to have no effect, at least on wikivoyage [15:23:42] yeah, there's a bug about it [15:24:58] which reminds me that I need to reproduce it [15:25:20] is it something to do with the resource loader? [15:25:30] can I work around the problem there? [15:26:41] I'll try to fix it in time for today's deployment [15:27:03] That's great. Thanks! [15:27:57] mark___, more widely speaking, does WV have any requests or comments related to the mobile site? [15:28:19] more questions than anything [15:28:33] it's been a couple of years since I was involved in mediawiki code [15:28:45] we're happy to answer them! [15:28:49] so I'm unclear on some of these new developments [15:28:53] anyhow [15:29:17] If you look at the main page that they just re-implemented [15:29:25] it's got a lot of big images [15:29:41] and some nifty javascript to shrink and expand imagmaps [15:30:12] I don't think that's probably going to work with all of the devices we're targeting with a mobile site [15:30:22] but it will work with some of them [15:30:34] so I'm not sure how much to leave in, and how much to strip out [15:31:33] eww, it looks too heavy for mobile [15:31:38] New review: Jdlrobson; "We purposely avoid data uris. Older phones potentially might not be able to deal with them. The spec..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836 [15:31:41] yeah [15:31:48] That's what I thought. [15:32:32] So right now, as I understand I can use id attributes to turn things on and off [15:32:49] but how would I fall back to a lighter image [15:32:51] ? [15:32:55] not id but style [15:33:18] OK [15:33:28] i'm a desktop-only text [15:33:35] OK [15:33:37] cool [15:33:54] so the mobile site is some kind of reverse proxy, no? [15:34:03] which does this processing? [15:34:18] it's an advanced MediaWiki skin [15:34:47] which indeed transforms some HTML to a more mobile-friendly version [15:34:56] OK [15:35:45] So if I see references in the docs about something that seems to be a reverse proxy they're probably talking about the old ruby-based version? [15:36:46] yes [15:36:58] OK. Thanks. That clears that up. [15:38:26] is there a corresponding mobileonly class? [15:38:38] no [15:38:49] because we don't touch the non-mobile stuff [15:39:01] but you can always do it with site CSS [15:39:05] right. OK. that makes sense [15:39:35] I guess I'm still worried about falling back to older browsers [15:40:08] in any case, the current design of the main page doesn't degrade well at all [15:40:40] you could wait a bit for our frontend dev jdlrobson to appear [15:40:46] OK [15:41:07] I'll be commuting shortly, but I can be back on in a couple of hours [15:41:22] uh, from 10:00 PST we have a long meeting [15:41:44] so it'll woork out only much later than in 2 hours [15:42:05] OK [15:42:16] I'm in CET (Switzerland) [15:42:43] ah [15:43:25] I'll try after dinner [15:47:41] morning jcmish [16:28:33] Maryana: do you have some time to pull out the feature ideas from the planning wiki article, so we have just a simple list? [16:28:42] yeah, let's do it [16:28:49] saweet [16:29:21] * YuviPanda looks around [16:29:31] Maryana et al: I'm working on a 'Welcome to Commons' brochure, which should be in complete and printed by around late June. [16:29:45] anything in particular related to mobile that you want to highlight? [16:29:52] ragesoss: is this part of GettingStarted? [16:30:08] YuviPanda: no, it's part of the Bookshelf stuff. [16:30:09] Maryana: http://etherpad.wikimedia.org/mobile-q4-planning-2013 [16:30:17] print brochures. [16:30:32] ragesoss, yes! but i'm planning out some mobile sprint stuff at the mo [16:30:42] Maryana: no rush. [16:30:43] share it w/me for asynchronous collaboration? :) [16:31:01] Maryana: I'm drafting it here: http://commons.wikimedia.org/wiki/Commons:Welcome_to_Commons_brochure [16:31:15] will be seeking community feedback once a first basic draft is done. [16:31:32] then editing, design, review, etc. [16:32:05] obviously some kind of QR stuff will be there, to get people to the apps. [16:32:25] if there could be a single code that sorted users based on platform to the right app store, that'd be sweet. [16:35:08] oh wow, my home broadband network crapped out [16:35:12] but my phone's is pulling in http://www.speedtest.net/result/2601515118.png [16:35:18] which is way faster than my home's [16:35:19] whee [16:37:08] awjr: no standup today, right? [16:37:21] YuviPanda: correct [16:37:25] sweet [16:37:34] nor tomorrow [16:37:49] at least, not for mobile web - dunno if tomasz will want to do one for apps [16:37:50] goddamit [16:37:52] today's tuesday [16:38:17] I had a 6 hour sleep in the morning, and another 6 hours in the evening (woke up ~30 mins ago) [16:38:22] my date clock is messed up, I guess [16:39:32] * YuviPanda goes afk for a bit, be back by 30 [16:52:56] hi all, are we really having a 4 hour long meeting in a few minutes...? [16:53:49] awjr, ^ [16:54:19] jgonera, prepare a pillow [16:54:45] I could swear this wasn't on my Google Calendar yesterday, I don't know what's wrong with it... [16:58:34] jgonera: yeah, we've been talking about this for the last few weeks! [16:58:45] awjr, but 4 hours long? really? [16:58:51] fraid so [16:58:55] uh [16:59:17] any 15 minutes break or I should prepare food/drinks/whatever I might need? [16:59:27] awjr, I see it 2 times in my calendar, which of them I should use for hangout? [17:00:12] jgonera: http://etherpad.wikimedia.org/mobile-q4-planning-2013 says one 5 min break and one 30 min [17:00:58] oh, ok [17:01:03] awjr: coming soon... trying to find a place with the best signal [17:01:03] i've joined a hangout but i'm the only one there [17:01:05] hotel bites :( [17:01:05] wrong hangout? [17:01:14] ok, be there in 5 minutes [17:03:10] hey brion [17:03:20] hey [17:03:42] brion: saw awjr's email? [17:03:49] not yet, i'm way behind today [17:03:52] overslept :P [17:03:58] on the plus side i'm very well rested :D [17:04:35] brion: I had 6 hours of sleep this morning [17:04:39] brion: and 6 more hours in the evening [17:04:43] sorry for any confusion with multiple calendar invites - we have two rooms reserved since we'll be splitting up the group in a bit. for now, use: https://www.google.com/calendar/render?tab=cc&pli=1&gsessionid=qpFt0HJut3wYCz7sxRicbA? [17:04:49] nice [17:05:47] awjr: ok i've got everything i need to do an iOS walkthrough, i can share the simulator on the hangout [17:05:55] brion: awesome! thank you :) [17:06:04] brion: do you also have an android phone handy? As backup if my connection dies? [17:06:08] considering murphy, etc [17:06:15] YuviPanda: yeah i'll get my cable [17:06:28] New review: Jdlrobson; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139 [17:06:28] brion: you have asm, right? [17:06:33] yeah [17:06:41] hehe, meeting time so am expecting a large amount of code review happening:P [17:07:08] jgonera: can you join the hangout? [17:07:12] jcmish: you too! ^ [17:07:23] Change abandoned: Jdlrobson; "Max had an interesting alternative way to do this by creating a ResourceLoader module." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54987 [17:07:27] brion: which build do you have? [17:07:43] YuviPanda: i'll update to latest store build [17:07:48] brion: okay! [17:07:54] yeah, that's reasonably bug free :) [17:07:56] dfoy, ping [17:08:17] ok, looks up to date [17:08:27] Hey yuri [17:08:32] awjr: can you guys see my screen alright? [17:08:38] awjr, so which hangout is it? [17:08:40] which event [17:08:44] YuviPanda: yup [17:08:46] YuviPanda: looks good to me [17:08:53] oh ok I see [17:08:54] dfoy, i updated the list of ips for our new partner, could you email them with the new list just so they know? In theory it should be the same as what they gave us, only 3 times shorer :) [17:08:59] jcmish, jgonera: https://plus.google.com/hangouts/_/88fd444d08d9383887adb71c158e447d8185ad42 [17:09:00] sweet [17:09:02] awjr: still coming [17:09:09] but need to find somewhere to get on [17:09:18] I keep getting connection too slow [17:09:19] to connect [17:09:23] dfoy, and i heard comments from ops saying that we shouldn't accept anything less then /24 :) [17:09:29] worse comes to worse will use my ipad [17:09:32] yurik: you've been busy :) glad you guys are on this, we're able to get a lot more done with you guys [17:09:33] yurik: sure, I'll pass it along to them. [17:09:58] brion, my next goal is to rewrite syntax/code generation of varnish ;) [17:10:03] haha [17:10:03] we'll be using this etherpad: http://etherpad.wikimedia.org/mobile-q4-planning-2013 [17:10:26] yurik: I understand but may not be something we can stick to 100%. [17:10:32] dfoy, the new list is in the patch [17:10:56] dfoy, sure, but we should state it as our initial req, and possibly loosene it in special cases :) [17:11:01] pending ops approval :D [17:11:38] :) perhaps. [17:11:45] http://etherpad.wikimedia.org/mobile-q4-planning-2013 [17:26:11] awjr: still having an issue gonna try to go over to a starbucks darn boston be there soon [17:33:28] YuviPanda: highlight the stats http://mobile-reportcard.wmflabs.org/ [17:33:34] for android and why iOS is so low [17:47:17] MURPHY!!! [17:47:39] awjr: do we have a running graph of 503's ? [17:47:49] because we should [17:47:56] not that i know of tfinc [17:49:18] bug filed for the 503 error on watchlist: https://bugzilla.wikimedia.org/show_bug.cgi?id=46574 [17:49:44] awjr: i'm adding more failure items on the etherpad as a result of this [17:49:51] thanks tfinc, good idea [17:50:04] heh. android uploads are -1 total from yesterday. [17:50:10] deletion, I guess. [17:50:18] ragesoss: we don't count deletions :P [17:50:27] ragesoss: it's 30 day average [17:50:27] err [17:50:27] 30 day running count [17:50:39] then why is the total 771, versus 772 yesterday? For Android? [17:50:55] oh, 30 days. [17:51:05] yes [18:07:58] Maryana: https://plus.google.com/hangouts/_/88fd444d08d9383887adb71c158e447d8185ad42 [18:08:53] jdlrobson: it's been more than 5 minutes [18:08:54] come back! [18:09:29] jgonera: you back yet? [18:11:28] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/y_FFaQ [18:11:28] android-commons/master 03277af YuviPanda: Add EventLogging for Share attempts [18:11:30] tfinc: share eventlogging is done and commited ^ [18:13:24] \o/ [18:13:27] * brion adds it to his list [18:13:31] brion: :D [18:21:08] YuviPanda: you rock [18:21:14] i just sent you a todo for the report card [18:21:30] tfinc: okay [18:23:20] Maryana: https://commons.wikimedia.org/wiki/File:%D8%B3%D8%AF%D8%A7%D9%85_%D8%A8%D8%B1%D9%87%D8%A7%D9%86.jpg [18:24:15] jdlrobson: where is the category for this image ? [18:24:37] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=46435 [18:27:48] jdlrobson: will previous images get categorized ? [18:28:36] tfinc: no not as it stands [18:28:42] https://developer.apple.com/news/?id=10082012b < banners for iOS users to promote apps? [18:28:48] YuviPanda: what made you pick the rolling 30day vs monthly? consistent amount of days ? [18:29:51] tfinc: yes, easier to reason about, I think. [18:29:59] brion: YuviPanda : i'd love if we could get app users to love our app more then the commonist [18:30:03] tfinc: plus it is easier to code if I assume we are not using an insane calander system :) [18:30:13] :D [18:30:29] its the golden standard of large uploads on wiki right now [18:30:32] i think we can do it even better [18:30:36] yes [18:30:37] we can! [18:30:40] \o/ [18:30:45] tfinc: the biggest draw there is the fact that it runs on desktop :P [18:31:26] want us to work on desktop apps or try to get people to move to their tablets and phones :D [18:31:49] work queues ++ [18:31:50] brion: i want to do kiosks at wikimania [18:31:52] keep people busy :D [18:31:54] ooooh [18:32:05] brion: nexus 10 + SD Card reader [18:32:10] plus bluetooth keyboard [18:32:15] not a bad idea [18:32:23] course… we gotta tell people to sign out when done ;) [18:33:10] brion: we can do that easily :P [18:33:19] i can implement 'ephemeral' sessions [18:34:00] ooh [18:39:01] yurik: ping [18:42:48] brion: I hear ICS 5.0 might have support for netbook formfactors [18:42:56] ooh [18:43:02] i thought netbooks were dead :) [18:43:14] well, chromebooks rather :P [18:45:31] tfinc: added 'share attempts' to the dashboard, should show up in an hour or two [18:45:36] tfinc: will be empty now, since there are no released versions with this tracking [18:46:09] sandwich time [18:46:12] brb [18:46:19] New patchset: Reedy; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55930 [18:47:31] New patchset: Reedy; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55930 [18:47:49] yurik: we have extra food here, so please come help us eat it! let adam know too when you see him [18:48:01] * YuviPanda watches everyone eat from the dark [18:49:30] New patchset: Reedy; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55930 [18:49:37] yurik: found adam! come on into r31 and join us for noms [18:50:39] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55930 [18:58:09] tfinc: I quite like these types of lunches [18:58:18] except for the fact that I'm not eating anything [19:07:55] my cat is eyeing my sandwich [19:07:57] bad kitty [19:08:25] brion: eyeing > mouthing [19:08:32] true [19:08:47] that > can both be read as 'better than' and 'leads to' :) [19:08:58] :P [19:09:14] eternal vigilance is the price of lunch [19:09:44] https://gerrit.wikimedia.org/r/#/c/55930/ needs applying to the production branch [19:09:59] Git seems to think production is only a topic branch locally :/ [19:10:57] hmm well gerrit thinks that should be merged to master yeah [19:11:37] brb [19:11:56] yeah, that was the commit to master [19:12:12] I'm using the same "pattern" I do for core wmf branches, which works fine... [19:12:23] * YuviPanda re-enables disabled notifications [19:16:20] brion: just waiting on you [19:16:47] yo [19:16:50] brion: were in https://plus.google.com/hangouts/_/88fd444d08d9383887adb71c158e447d8185ad42 [19:17:01] Reedy, I'll deploy it in our window in 2 hours [19:17:26] MaxSem: Ta. It's currently a live hack on fenari [19:17:30] ok [19:53:09] http://en.wikipedia.org/wiki/Special:GettingStarted [20:13:11] yurik: https://www.mediawiki.org/wiki/Requests_for_comment/Image_information [20:33:30] yurik: hello [20:47:17] \o/ [20:48:17] I just got a notification saying Maryana 'thank'ed me for my edit [20:48:18] wah [20:48:23] tee hee [20:48:32] when did mw get all friendly? [20:48:35] echo just released their "thank" feature [20:48:35] also woowhoo [20:48:38] niceee! :) [20:48:43] conveniently [20:48:52] Maryana: did the web team decide on some timeline to talk to echo about getting notifications in? [20:49:29] we're going to do a bit of exploratory work around that in q4 [20:49:46] given that we're releasing editing and may potentially need to let new users know that their edits are being reverted [20:50:02] ooh [20:50:03] but it'll be pretty bare bones. don't wanna step on echo's toes too much [20:50:21] awjr: Maryana MaxSem I'm here for the deployment [20:50:26] can't stream for crap [20:50:27] the talk page view that jon put together is a good start :) [20:50:33] but I can test fine :-/ [20:50:43] that's the important part :) [20:50:49] brion, yurik and dr0ptp4kt - do we need to update Zero today? [20:51:15] yurik, dr0ptp4kt: there was that caching length update, anything else? [20:51:17] MaxSem, we really need to get the VCL patches out to production [20:51:38] yurik, that's not something I can do [20:51:46] awjr, MaxSem, do we have a proper patch for the mediawiki-config for Special:LoginHandshake? [20:52:06] brion, adam said if you approve, please merge, nothing more at this time for zerorated [20:52:32] Warning: preg_match() [function.preg-match]: Compilation failed: regular expression is too large at offset 58 in /usr/local/apache/common-local/php-1.21wmf12/extensions/MobileFrontend/includes/api/ApiQueryExtracts.php on line 261 [20:53:01] ok merged https://gerrit.wikimedia.org/r/#/c/55444/ [20:53:16] MaxSem: latest zero code update is optional, it just shortens the cache time [20:53:49] yurik: do we still need someone to merge https://gerrit.wikimedia.org/r/#/c/55302/ ? [20:54:36] brion, the range patch is the key, will have a big PR embarasement according to dfoy [20:54:42] if we don't get it in today [20:54:55] ok let's go into #wikimedia-operations and grab someone [20:54:59] the default lang is a nusance [20:55:11] Maryana: okay :) Will keep an eye out on what the web team does [20:55:23] can't go into ops - have mobile partners meeting until 2:30 [20:55:25] could you help? [20:55:27] thx [20:55:35] yurik: sure i'll poke em :) [20:55:37] Reedy, thanks - submitted to BZ so that I don't lose track of it during the deployment [20:55:54] thx [21:02:50] yurik: ops really wants a shorter list of IP ranges; can we crop it down more or at least commit to it later? [21:02:57] otherwise someone has to fight with mark :) [21:03:02] jdlrobson: nice hat boss. coffee/ [21:03:05] ? [21:03:14] yup let's go [21:07:20] so are we deploying now? and if yes, can someone answer my question about config changes? [21:07:57] jgonera: have you added the config change already, or do we still need to do it? [21:08:13] awjr, I haven't [21:08:13] im happy to prepare it if need be while max is prepping everything else for deployment [21:08:19] jgonera: can you send me the correct URL to use? [21:08:19] I can add it too [21:08:23] jgonera: ok, go for it :) [21:08:28] do you know where to do it? [21:08:31] did you check on beta if protocol-neutral URL also worked? [21:08:41] i did not, i just used http [21:08:53] but in theory it should work on the cluster [21:09:00] yeah, it should [21:09:10] did you use the mobile domain or useformat? [21:09:26] useformat [21:09:37] MaxSem: are you all set for deployment? [21:09:44] yes [21:09:47] in process [21:09:48] saweet [21:09:50] thanks [21:10:35] awjr, mobile.php? [21:10:51] I guess I'd try with an .m domain, won't that work too> [21:10:51] ? [21:11:00] jgonera: first you want to define the variable in InitialiseSettings.php, then in mobile.php [21:11:28] oh, so it's not like the change you made for labs? [21:11:33] not quite [21:11:46] config is typically handled a little diffrently for production [21:11:49] ok [21:12:21] by setting things up properly in InitialiseSettings.php, it make it trivial to change config values on a per-project basis [21:12:38] all right awjr jcmish jgonera jdlrobson Maryana - we're live on https://test.m.wikipedia.org/ - please test:) [21:12:56] awjr, so are any conf changes needed? [21:12:58] for instance, ew could prepare the config change to only effect testwiki and leave everything else untouched [21:13:03] MaxSem: yes, jgonera is preparing them [21:13:28] tfinc_: http://mobile-reportcard.wmflabs.org/ [21:13:29] :) [21:13:56] jdlrobson, is clicking on sections the only reason why we lock viewport? [21:14:52] Kayo [21:16:15] * Maryana clears cookies from iphone safari & takes a deep breath [21:16:19] c'mon special handshake! [21:16:39] Maryana, handshake isn't configured yet [21:16:53] oh - just not on test or not at all? [21:17:10] last time CentralAuth didn't work at all on test [21:17:16] has this changed? [21:17:29] awjr, MaxSem https://gerrit.wikimedia.org/r/56019 [21:17:37] probably not, jgonera [21:17:51] I used the normal domain since that what we use as the photo upload api endpoint too [21:18:04] that makes sense [21:18:06] (and useformat=mobile) [21:18:14] jgonera: you should enable that only for testwiki for now (default to false) [21:18:29] once we're happy with think on testwiki, we can default to the commons endpoint [21:18:34] s/think/that [21:18:41] the handshake config? [21:18:44] yeah [21:18:55] it won't work anyway until we deploy the whole thing to production [21:19:04] I mean, it doesn't mess the production [21:19:05] jgonera, https://gerrit.wikimedia.org/r/56019 [21:19:11] yeah test won't work right with CA sessions because it's still in tampa, iirc [21:19:11] -1'd [21:19:11] but I can make it test for now [21:19:13] oh right [21:19:16] or some weird config like that [21:19:36] sigh. [21:19:41] hm, good point MaxSem [21:21:55] MaxSem, pushed new patchset [21:23:12] hrrm. went to test wiki, hit random, got thrown on desktop [21:23:12] sigh [21:23:44] yeep [21:23:48] scary error on setting page [21:24:03] call to undefined method SkinVector::addArticleClass [21:24:41] anybody else seeing this weird stuff? [21:25:00] yeah [21:25:06] I know why it happens [21:25:26] one of the commit pages broke all the mobile special pages for desktop [21:25:44] i.e. when a mobile special page is rendered as a desktop page, this happens [21:25:48] what's weird is the link for random is pointing to .m, but it ultimately takes me to non-.m... [21:25:58] jdlrobson, do you know if we should fix this? is this urgent? [21:26:03] jgonera, you change is live on testwiki [21:26:23] MaxSem, thanks [21:27:01] heh, for me the testwiki won't open in mobile mode at all [21:27:05] i think this is urgent [21:27:09] even if I click the mobile link in the footer [21:27:35] jdlrobson, I think it's the UnlistedSpecialPage commit [21:28:09] why are we seeing this behavior on testwiki but not on betalabs? [21:28:14] jdlrobson, are you there? [21:28:18] er [21:28:18] YuviPanda: looks great. much easier to understand now [21:28:20] no he's not [21:28:28] tfinc_: :) [21:28:28] probably there's something messed up with mobile domain on testwiki [21:28:31] or something [21:28:33] no idea [21:28:42] tfinc_: as bonus, http://en.wikipedia.org/wiki/Puppy_pregnancy_syndrome [21:29:04] huh ? [21:29:12] i just txted jon [21:29:13] relevance ? [21:29:36] that is possible jgonera [21:29:37] none, that is why it is 'bonus'. :) [21:29:44] so it seems that it works for me on Chrome, but it just won't go into mobile mode at all in Android browser [21:31:04] wtf [21:31:16] clearing the cookies, cache, and tapping/untapping "request desktop site" didn't help :/ [21:31:55] and yes, when I go to settings in Chrome I get the same error as Maryana [21:32:00] Darn connection [21:32:12] I'm not sure if those two things are related [21:32:30] i dont seem to be getting the x-device header set from varnish [21:32:33] which i presume is the issue [21:33:04] that is happening only on testwiki right? [21:33:11] afaik jgonera [21:33:24] I mean, it's not possible that we broke it by deploying new code? [21:33:56] it appears to be working in production [21:37:34] I can't find that commit [21:37:48] im looking at the varnish conf and it actually looks potentialy incorrect for testwiki [21:37:59] device detection happens after is passes the request to testwiki [21:39:22] i think this might've busted things: https://gerrit.wikimedia.org/r/#/c/55555/ [21:39:24] but not sure [21:39:27] it's 32b21c0ef74765ad6c24ee0d49eece88a6601c90 [21:39:31] * jdlrobson looking into special pages problem [21:39:42] it readds the noMargins thing that MaxSem asked me to remove [21:40:01] in particular it calls addArticleClass which it shouldn't do [21:41:16] the more im looking at this i think testwiki is f'd because of https://gerrit.wikimedia.org/r/#/c/55555/ [21:41:40] yeah, that's one problem [21:42:02] the other one is that the settings page should not blow up on desktop (I guess) [21:43:03] jdlrobson, what was actually the reason behind https://gerrit.wikimedia.org/r/#/c/52553/ ? [21:43:15] jgonera: read the bug :) [21:43:37] I still saw special pages without the margin after that I think [21:43:38] somewhere [21:43:39] hm [21:44:02] i have a fix [21:45:30] im working with ops to get a fix out to make the mobile view work again on testwiki [21:45:48] ok, good [21:46:22] just got https://gerrit.wikimedia.org/r/#/c/56056/1 merged [21:46:57] Awjr start testing again? [21:46:57] mark is forcing a puppet run on the mobile varnish boxes now so that should be out shortly [21:47:00] how long until it gets deployed? [21:47:04] ok [21:47:04] probably a few minutes [21:47:44] K [21:50:01] New patchset: Jdlrobson; "Protect mobile special pages when viewed in desktop mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56059 [21:51:34] brion, back from the meeting, sitting with dfoy here [21:51:40] russia is a big country [21:51:43] 56mill [21:51:47] lots of ip ranges [21:51:53] yeah [21:52:01] ok, testwiki looks to be workoing right again :) [21:52:11] jcmish, jdlrobson, MaxSem, jgonera ^ [21:52:12] yurik: if you guys can convince mark that this is ok, fine…. [21:52:20] awjr: ^ new patchset [21:52:23] mark is asleep, isn't he? [21:52:31] yurik: no, i just talked to him [21:52:44] yurik: check in #wikimedia-operations [21:52:58] awjr, thx, switching [21:53:22] jdlrobson: shouldn't UnlistedSpecialMobilePage check shouldDisplayMobileView() in the constructor or something? [21:53:35] awjr: your the php expert :) [21:53:37] and possibly throw an exception if not? [21:53:40] *you're [21:53:43] well [21:53:47] it depends on what exactly you're trying to achieve [21:53:59] if you want to prevent mobile special pages from showing up on desktop, i would do it in the constructor [21:54:22] well currently i want to avoid an exception but if you note the FIXME ideally we should make these work in desktop or redirect to mobile [21:54:45] interesting [21:55:05] Maryana should help us figure out the specific behavior [21:55:24] is this a fix that needs to go out now? [21:55:29] jdlrobson: [21:55:30] ^ [21:55:57] i'd guess so… 500s are bad :) [21:56:08] I still can't force my android browser to show me the mobile version... [21:57:02] ok, works [21:57:09] I cleared the cache and cookies again [21:57:40] New review: awjrichards; "This is a fine fix for now, but we should figure out how to handle mobile special pages in desktop v..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56059 [21:57:41] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56059 [21:57:51] MaxSem: can you pick up ^^ [21:57:58] jgonera: clear cookies [21:57:58] oh [21:57:59] you did [21:58:04] i typed before i read :p [21:59:22] jdlrobson, I see both the languages list and the languages button in alpha [22:00:28] aaand [22:00:31] I can't login [22:00:41] it says I requested an invalid special page [22:00:45] jdlrobson, awjr ? [22:01:22] that's when I clicked it from wtchstar CTA [22:01:37] when I clicked it from main menu it got me to the desktop login page [22:01:59] jgonera: Im seeing the same behavior [22:02:02] oh no, actually when I clicked it from main menu it took me to Commons login page, wtf [22:02:31] But right I went to the commons page [22:03:12] and https://commons.wikimedia.org/wiki/Special:LoginHandshake?useformat=mobile also gives me no such special page message [22:03:18] well… it's not deployed on commons [22:03:29] so of course this won't work :) [22:03:37] oh, it's not [22:03:38] I see [22:03:47] right, that explains [22:03:48] get some sleep jgonera ;-) [22:04:04] i'm assuming we can change the config value to point to itself? [22:04:17] ok, but why is it taking me to the commons login page now... [22:04:26] instead of showing a message about a missing special page [22:04:44] oh no [22:04:45] sorry [22:04:50] nevermind, ignore me [22:04:59] jdlrobson: get some sleep jgonera ;-) [22:05:00] I clicked it from the commons main menu [22:05:02] shouldn't that config value be false? [22:05:14] for testwiki? [22:07:13] jgonera: yeah, so we can keep testing :) [22:08:18] post-login page has a JS error and thus doesn't work, but I guess it's cache problem again? [22:08:22] but at least we know the redirect works :p [22:08:29] gah [22:08:49] shouldn't be - testwiki requests are not getting cached [22:08:52] afaik [22:08:54] or no... [22:08:59] crap [22:09:03] it's some RL problem again [22:09:39] :( [22:10:24] awjr, deployed [22:10:36] wait [22:10:37] what? [22:10:47] jgonera: i think he means to testwiki :p [22:10:51] oh ok [22:10:54] Hahahha [22:11:03] jgonera: the fix that jon made for mobile special pages on desktop view [22:11:14] so yeah im seeing the JS error on the post-login screen [22:11:15] damn, there's a bigger problem there... [22:11:20] i didnt see that yesterday on betalabs... [22:12:05] that is a non-deterministic problem [22:12:11] jgonera: do you see what the problem is? [22:12:11] depends on how fast one thing loads [22:12:17] >_< [22:12:19] but I can prepare a fix now [22:13:12] still seeing the issues dfoy highlighted on Nokia N95 - but the new display seems to be a slight improvement :) [22:13:26] Hmm so maybe betalabs wasn't up to date awjr? Because I used that for testing [22:13:45] And I didn't see this :( [22:13:58] ok, I can fix it quickly by disabling logging of commons centralAuth image loading errors [22:14:00] yeah, it was all up to date when i tested yesterday and everthing was looking fine [22:14:07] which we didn't use that much anyway [22:14:18] Maryana, jdlrobson, are you guys ok with that ^? [22:14:20] we can revisit that later [22:14:33] erm, now it can't find special:uploads [22:14:37] is that expected? [22:16:37] Hmm Maryana on my ipad in beta it words [22:16:48] nm, figured it out [22:16:49] :) [22:16:55] just catchup up [22:16:55] Oh whew [22:17:00] catching [22:17:01] :) [22:17:32] we're getting fairly deep into our deployment window - and we still have things blocking us from fully testing [22:17:40] MaxSem: how are you feeling? [22:18:09] jgonera: were we getting many errors from commons image not loading? [22:18:20] mmm yes - either deploy now or revert. so if we can't deploy... [22:18:46] ok - jgonera are you close with a fix for those js problems? [22:18:55] yes [22:19:21] ok - MaxSem let's try out jgonera's fix. if we find more problems after that, let's abort [22:19:35] New patchset: JGonera; "Remove event logging for Commons CentralAuth image errors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56067 [22:19:41] awjr, MaxSem ^ [22:19:49] jdlrobson: can you review that JS ^^? [22:20:33] jgonera: probably to be safe remove mw.mobileFrontend from closure [22:20:45] actually maybe that's fine [22:20:49] can we guarantee mw is available? [22:21:28] New patchset: JGonera; "Remove event logging for Commons CentralAuth image errors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56067 [22:21:31] well yes, I think, without it there's no RL [22:21:38] true [22:22:35] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56067 [22:22:36] boom [22:23:17] ok MaxSem - willing to try out ^^ ? [22:23:18] let's hope there's not going to be more booms ;) [22:23:21] srsly [22:23:27] is that good boom or bad boom? [22:23:31] or big bada boom? [22:23:35] or boom-boom [22:23:47] it's still an unknown boom [22:23:54] tbd boom [22:25:46] done [22:25:58] mmm, 2:25 [22:26:10] jcmish, jgonera, jdlrobson, Maryana ok quick test on test [22:26:12] oh, actually now that I think about it, we discovered this problem only because CentralAuth is broken on testwiki and the image loading always results in an error ;) [22:26:15] if you find any more issues, we should abort [22:26:18] Kayo [22:26:36] doh jgonera >_< [22:26:58] http://everygame.files.wordpress.com/2010/07/superbomberman-batman.png [22:30:35] oh come on, can you guys see cancel and submit buttons in upload overlay? [22:30:50] yes, jgonera [22:30:56] android browser? [22:31:04] desktop chrome [22:31:10] I can see it on desktop [22:31:17] someone else with android can check? [22:31:22] looking [22:33:02] nope, jgonera :( [22:33:08] jdlrobson: some days you just can't get rid of a bomb [22:33:14] you can't see them? [22:33:17] no [22:33:20] i cannot [22:33:25] dammit :/ [22:34:00] mmm, is sync-common needed? [22:34:09] wfm on iOS [22:34:20] I can see them in Chrome for Android too [22:34:25] i dunno MaxSem, possibly if they're new assets, but we're seeing them in other browsers [22:34:38] so it's a bug [22:34:45] yes [22:34:50] iOS works for Dimi [22:34:55] I think I can click them though... [22:35:27] Me :) autocorrect [22:35:27] okay, I'll revert in 10-15 minutes, you can diagnose this bug for now [22:35:42] hehe, making your son test stuff for you. child cruelty! [22:35:49] ;) [22:36:27] Hahahah Maryana [22:36:36] He's griping at me [22:36:42] To hurry up [22:36:46] yeah, im seeing the same problem on betalabs [22:36:59] (buttons not showing up in upload overlay) [22:37:02] on android native browser [22:37:05] sigh. [22:37:14] So Freudian slip [22:37:27] :( [22:38:19] If we abort awjr when is our next window? [22:38:36] im checking jcmish [22:38:39] I'll change my vacation plans to test if need be [22:38:44] K [22:38:50] I'm trying to localize the commit that broke it... [22:39:14] we could potentially do it tomorrow aftn [22:39:15] er [22:39:16] afternoon [22:39:22] but that's pretty much it [22:39:33] otherwise we'll need to wait til next week [22:39:33] K I'll be around [22:41:09] I need to get the boy to dinner it's 6:40 here do you need me to stick around [22:41:18] ? [22:41:19] jcmish: i think we're done for now [22:41:29] we'll need to reschedule [22:41:31] K I'll be online tonight [22:41:34] jgonera: position fixed [22:41:43] commit? [22:41:43] which android browser do you have? [22:41:52] And I'll make sure I can test whenever [22:42:11] cool jcmish, it would be great if we can do a thorough test on betalabs beforehand [22:42:25] 4.2.1 [22:42:36] i'll see about rescheduling the deployment, right now it looks like tomorrow afternoon should work [22:44:23] jgonera: what happens when you add debug=true [22:44:41] jdlrobson, I don't know, but it works on every other browser [22:46:34] jgonera: add debug=true to the address bar on android [22:46:35] f [22:46:39] for me it fixes the issue [22:46:48] i've seen similar problems on my nokia since last deployment [22:46:50] something funky going on [22:47:13] ok found it [22:47:26] also stable/beta or alpha? [22:48:05] document.createElement( 'p' ) in supports3dTransforms trips android browser up [22:48:06] all right, I'm reverting [22:48:36] im gonna wander off for a few and i'll reschedule deployment when im back [22:48:53] or more likely, inserting this p tag [22:49:14] jdlrobson, jgonera - i saw the problem on android 4.2.2 in stable and beta (didnt check alpha) [22:49:23] jgonera: :-O [22:49:29] awjr_afk, I already know the cause [22:49:47] arrg of course [22:50:05] of course? why does it mess it up only on Android browser? ;) [22:51:11] well it makes sense in that we are creating an element in the DOM which could be masking it [22:51:16] we should be removing that DOM element [22:51:25] oh we are.. huh now i'm wtf :) [22:51:49] it's probably some weirdness in this particular browser [22:52:04] let me see if I can rewrite that function so that it doesn't do that [22:52:04] jgonera: should have know it would be related to 3d transformations.. ;-) [22:52:17] we should move this code out of mf-application.js though [22:52:25] well, it's not 3d transformations actually ;) [22:52:31] separate module? [22:52:33] *transitions [22:52:39] *transforms [22:52:43] it should have been in a separate module only loaded on alpha - that's my bad [22:53:14] We should probably from now on ensure we sandbox our code better [22:55:34] New patchset: MaxSem; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56072 [22:55:53] Change abandoned: MaxSem; "fuk" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56072 [22:56:51] lol. [22:58:51] "Web is the future! p tags for everyone!' [23:06:14] Reedy, yeah - [23:06:29] I'm currently bashing the same wall as you [23:09:13] awjr, any ideas how to cherry-pick https://gerrit.wikimedia.org/r/#/c/55930/ into production? [23:09:53] can you just cherrypick the changeset onto what the production branch is currently pointed at? [23:11:57] MaxSem: ^? [23:12:06] first, it attempted to push to master. after I forced it with git review production, it said ! [remote rejected] HEAD -> refs/publish/production/production (no new changes) [23:12:18] ugh [23:12:22] Reedy might have an idea? [23:12:47] oh actually you might need to do 'git review production' [23:12:55] to make sure it pushes to the production branch [23:13:23] see my reply;)^^^ [23:13:32] oh sorry, missed that [23:16:14] jdlrobson, I think I found a fix, using span instead of p works, probably because it's not a block element... a weird browser quirk anyway [23:16:27] yey browser quirks [23:16:37] I'll move it into a separate file anyway [23:16:40] just in case [23:16:47] thanks jgonera [23:18:09] MaxSem what about git review gerrit/production? [23:18:58] invalid upstream remotes/gerrit/gerrit/production [23:19:06] alright, doing it manually [23:19:13] sigh [23:19:43] jdlrobson, haha, with span the whole detection stops working in Chrome [23:19:54] has anyone worked with dynamic page redirect? Like when people browse to a redirect, the target page is returned within the same HTTP response, not a 302 redirect [23:19:58] yurik, dr0ptp4kt when are your carrier updates going out today? [23:20:16] awjr, carrier ACLs are supposedly live already [23:20:25] we have no way of knowing what's on the servers :( [23:21:16] ok thanks yurik - i guess theoretically if the changes are merged puppet should pick them up, i think puppet runs every 30mins [23:21:34] awjr, that's what we were told a few hours ago :) [23:22:41] New patchset: MaxSem; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/56075 [23:25:15] to make sure it pushes to the production branch [23:25:21] fscking thing! [23:25:22] :D [23:25:46] eh? [23:25:57] New patchset: MaxSem; "Minimal fix for Wikibase related SpecialMobileWatchlist fatal" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/56075 [23:26:03] .gitreview isn't pointing to the right branch [23:26:16] so that's the reason it keeps pushing it to master [23:26:23] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/56075 [23:27:10] git review is a horse puke [23:27:36] ...he said and typed git review again [23:29:42] lol [23:29:47] make a change to change the .gitreview [23:29:52] just rebase that ontop of master when you update... [23:31:18] we recreate that branch heavily so no point [23:36:50] rolled back [23:36:57] dammit [23:38:09] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55393 [23:40:02] brion: https://test.wikipedia.org/w/index.php?title=TestPage&curid=67832&diff=163005&oldid=163004 \o/ [23:40:28] brion: first edit done by the sync provider. nice arch too - 'insert this thing now, and eventaully at some point something will come over and do the edit' [23:40:33] brion: would like a CR once I commit it (not yet) [23:56:50] ok folks, im fried and think im gonna head out - anyone need anything from me before i go? [23:57:01] tfinc_, Maryana, jgonera, jdlrobson ^? [23:57:07] nopes [23:57:11] nope [23:57:14] go take a load off, awjr [23:57:52] far out - see you all tomorrow!