[00:03:04] * YuviPanda  heads to sleep

[00:03:05] <YuviPanda>	 gnite folks
[00:24:29] <jgonera>	 jdlrobson, how about adding if ( mw.config.get( 'wgMFMode' ) === 'alpha' ) instead of moving this function into a separate file?
[00:25:54] <jdlrobson>	 jgonera: i think we should get into the practice of doing things the history-jquery.js way
[00:26:19] <jgonera>	 hm, ok, I guess they're concatenated anyway
[00:26:20] <jdlrobson>	 maybe application-alpha.js ?
[00:26:29] <jdlrobson>	 things like editing going stable won't happen then :)
[00:26:29] <jgonera>	 yeah
[00:33:24] <gerrit-wm>	 New patchset: JGonera; "Fix Android Browser quirks in transforms support check" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56087
[00:34:13] <yurik>	 dfoy, still around?
[12:44:53] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/BT6LHg
[12:44:53] <wikipedia-github>	 android-commons/master 780af9d YuviPanda: Initial cut of Modifications syncing...
[14:05:51] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/__8PhQ
[14:05:51] <wikipedia-github>	 android-commons/master 8462b4b YuviPanda: Design mofifications to single share view
[14:14:32] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/55869
[14:14:33] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55869
[14:17:06] <gerrit-wm>	 New review: Cmcmahon; "update rvm" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/55880
[14:17:07] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55880
[14:41:05] <gerrit-wm>	 New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/54139
[14:46:30] <gerrit-wm>	 New review: JGonera; "If it's not very tricky, let's add a dependency, just to be sure. I have a feeling that when we star..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/55836
[15:17:29] <gerrit-wm>	 New review: JGonera; "(8 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/55159
[15:21:41] <gerrit-wm>	 New review: JGonera; "You mean on desktop with a wide window? It still doesn't fix it for me, the menu disappears." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/55776
[15:23:38] <gerrit-wm>	 New review: JGonera; "Actually, it works for me on current master and this commit breaks it ;)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55776
[16:23:30] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56087
[16:26:05] <gerrit-wm>	 New review: Jdlrobson; "YAGNI" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836
[16:52:32] <MaxSem>	 ehm, so which hangout should I join, standup or q4 mtg?
[16:56:09] <MaxSem>	 awjr, ^^
[16:56:19] <awjr>	 MaxSem: Q4 mtg - but we need to delay the meeting about 10 mins
[16:56:28] <awjr>	 i just sent an email to mobile-tech with an explanationa
[17:00:23] <yurik>	 dfoy, ping
[17:00:33] <yurik>	 did we get beeline onboard last night?
[17:01:02] <awjr>	 tfinc yuvi sent standup notes
[17:01:04] <tfinc>	 YuviPanda: just waiting on your to start the stand up
[17:01:12] <YuviPanda>	 tfinc: I sent standup notes
[17:01:24] <YuviPanda>	 tfinc: shitty connection day.
[17:02:17] <dfoy>	 yurik: it will go online this evening
[17:02:32] <yurik>	 didn't make it :(
[17:03:44] <dfoy>	 yurik: we delayed a day to handle getting this online on our side.  They were okay with doing that
[17:07:50] <tfinc>	 YuviPanda: yup. i saw them
[17:08:28] <YuviPanda>	 tfinc: ok. IIRC no other meetings for me today according to calendar
[17:10:38] <tfinc>	 YuviPanda: not unless you have something before my vacation
[17:10:43] <tfinc>	 something/any requests
[17:10:56] <YuviPanda>	 nope!
[17:11:55] <awjr>	 http://etherpad.wikimedia.org/mobile-retrospective-q3-2013
[17:13:00] <jdlrobson>	 please repaste link jgonera ?
[17:13:11] <jgonera>	 http://etherpad.wikimedia.org/mobile-retrospective-q3-2013
[17:13:14] <jdlrobson>	 thx
[17:22:20] <yurik>	 dfoy, btw, re IPs in case of anything - all ips seems to be public -- http://myip.ms/view/ip_owners/2546/Jsc_Vimpelcom.html
[17:23:34] <yurik>	 YuviPanda, ask for a pony!
[17:24:05] <dfoy>	 dfoy: ok thx
[17:24:10] <dfoy>	 yurik: ok thx
[17:24:15] <dfoy>	 :)
[17:24:18] <yurik>	 dfoy, talking to yourself? :)
[17:24:57] <dfoy>	 yurik: haha - looks that way
[18:02:54] <gerrit-wm>	 New review: Siebrand; "L10n looks okay to me. Please check the RTL behavior of the added UI elements." [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/54140
[18:15:18] <YuviPanda>	 brion: do send out an update for iOS
[18:15:23] <YuviPanda>	 brion: also include l10n updates!
[18:15:31] <brion>	 yes :D
[18:39:43] <wikipedia-github>	 [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/IHNsXQ
[18:39:43] <wikipedia-github>	 WikipediaMobile/master 103fe08 Brion Vibber: Add back user-agent for iOS (bug 42484)
[18:39:43] <wikipedia-github>	 WikipediaMobile/master fbbfa31 Brion Vibber: Merge pull request #316 from brion/useragent...
[18:40:22] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #503: SUCCESS in 19 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/503/
[18:40:23] <mw-jenkinsbot>	 Brion VIBBER: Add back user-agent for iOS (bug 42484)
[18:49:59] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #504: SUCCESS in 8 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/504/
[18:50:00] <mw-jenkinsbot>	 Brion VIBBER: iOS: use bundle version in user-agent rather than hardcoding
[18:50:02] <wikipedia-github>	 [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/7GEG6w
[18:50:02] <wikipedia-github>	 WikipediaMobile/master 76cf7df Brion Vibber: iOS: use bundle version in user-agent rather than hardcoding
[18:51:38] <wikipedia-github>	 [WikipediaMobile] brion created v3.3.1-iOS (+3 new commits): http://git.io/npdj0A
[18:51:38] <wikipedia-github>	 WikipediaMobile/v3.3.1-iOS 06a256c Brion Vibber: Merge remote-tracking branch 'origin/master' into v3.3-iOS...
[18:51:38] <wikipedia-github>	 WikipediaMobile/v3.3.1-iOS ba38053 Brion Vibber: Merge branch 'master' into v3.3.1-iOS
[18:51:38] <wikipedia-github>	 WikipediaMobile/v3.3.1-iOS 94b7316 Brion Vibber: Bump iOS version to 3.3.1
[18:51:53] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #505: SUCCESS in 9.7 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/505/
[19:12:39] <gerrit-wm>	 New review: MaxSem; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226
[19:15:25] <YuviPanda>	 brion: also send out l10n updates?
[19:15:39] <brion>	 YuviPanda: they're in there
[19:15:58] <YuviPanda>	 brion: oh? There were a bunch of experimental untested features too, make sure those don't get in :)
[19:16:16] <brion>	 probably already out in 3.3
[19:16:24] <brion>	 i don't remember doing any more work on it since
[19:16:33] <YuviPanda>	 brion: iirc 3.3 was cut from a branch
[19:16:36] <YuviPanda>	 brion: rather than master
[19:16:45] <YuviPanda>	 brion: I did a bunch of work in master (dark theme, for example)
[19:16:57] <YuviPanda>	 brion: just tell me branch name before you cut release, and i'll verify :)
[19:17:26] <brion>	 v3.3-iOS branched to v3.3.1-iOS and merged with master
[19:17:45] <YuviPanda>	 hmm, merge bad, without reverts
[19:17:47] <brion>	 light and solarized dark themes are already out in v3.3
[19:17:48] * YuviPanda  looks

[19:17:58] <YuviPanda>	 brion: oh, really?
[19:18:01] <brion>	 yup
[19:18:01] <YuviPanda>	 i didn't know :|
[19:18:04] <brion>	 since december
[19:18:05] <YuviPanda>	 well, go ahead :D
[19:18:08] <brion>	 :D
[19:18:54] <YuviPanda>	 brion: shoot an email to mobile-tech once you've sent it to apple, i'll do an update on android too
[19:19:09] <brion>	 already uploaded, it'll be a few days to go through the system
[19:19:31] <YuviPanda>	 brion: ah, right
[19:19:33] <YuviPanda>	 brion: ttoo quick!
[19:19:36] <brion>	 :D
[19:19:45] <brion>	 i've got days to pull it if anything's wrong :)
[19:20:01] <YuviPanda>	 :P
[19:29:24] <brion>	 luuuuunch
[20:05:09] <YuviPanda>	 brion: how's the account creation stuff coming? :)
[20:05:24] <brion>	 still needs to be finalized dude
[20:05:35] * YuviPanda  pesters brion

[20:05:41] <YuviPanda>	 brion: s sent some remarks, I think?
[20:06:07] <brion>	 yeah there's some more comments
[20:22:15] <MaxSem>	 jdlrobson, is zoom on section clicks the only reason why we fix the viewport?
[20:52:31] <MaxSem>	 hey office folks, we're deploying in 10 minutes!
[20:52:50] * YuviPanda  notes eerie silence

[20:54:47] <MaxSem>	 I'm not deploying alone ;)
[20:56:10] <jdlrobson>	 i'm here
[20:56:32] <jdlrobson>	 MaxSem: I'm making some huge changes to skins as we speak - but yes that's the only reason
[20:56:47] <awjr_lunch>	 you are not alone, MaxSem!
[20:56:55] <awjr>	 and apparently i forgot to update my nick..
[20:57:10] <MaxSem>	 jdlrobson, can't we just wrap whole bloody headings into an <a>?
[20:57:14] * tfinc  looks around for brion

[20:57:40] <jdlrobson>	 MaxSem: that might be one solution - leave that with me i'll find a solution!
[20:57:50] <MaxSem>	 sehr gut
[20:59:19] <Maryana>	 i don't actually take 2 hour lunches, i promise
[20:59:25] <Maryana>	 i just always forget to change my nick :)
[21:02:38] <MaxSem>	 Maryana, that's why I never change mine:)
[21:03:08] <Maryana>	 just makes you look like you're superhuman and don't need to eat to survive
[21:08:03] <MaxSem>	 okay, we're live on testwiki - please test
[21:08:06] <awjr>	 w00t
[21:08:28] <awjr>	 i just pinged michelle, but she's currently marked as away
[21:10:37] <jcmish>	 testing now :D
[21:12:11] <awjr>	 yay i see cancel/submit buttons on android for photo upload
[21:12:53] <jcmish>	 Juliusz is testing too guys
[21:13:04] <jcmish>	 I'm keeping him in the loop
[21:13:07] <awjr>	 awesome :)
[21:13:20] <jerith>	 act
[21:13:25] <jerith>	 Oops.
[21:13:31] <awjr>	 hi jerith :)
[21:14:32] <jerith>	 Hey awjr.
[21:15:53] <awjr>	 things are looking good to me
[21:16:07] <jcmish>	 so far so good for me
[21:16:16] <jcmish>	 checking with Juliuz back in a sec
[21:18:39] <jcmish>	 Juliusz:  I realised were doing the special handshake on logout too. This is usually not a problem since we do it only once.  me:  ah okay  Juliusz:  But if someone was logged in before deployment and they log out after it they'll get redirected to commons and back to logout.
[21:19:41] <jcmish>	 jdlrobson: ^
[21:19:44] <jcmish>	 from Juliuz
[21:20:01] <jcmish>	 Juliusz:  But as I said that shouldn't be a big deal. Tell Jon and ask what he thinks I'll install Irc on my phone meanwhile
[21:20:09] <jcmish>	 jdlrobson: ^ too
[21:20:20] <jdlrobson>	 jcmish: not a big deal - probably actually a good thing
[21:20:30] <jcmish>	 jdlrobson: alrighty
[21:20:37] <jdlrobson>	 forces users to visit commons :)
[21:20:48] <jdlrobson>	 jcmish: how are you talking to juliusz?! :)
[21:20:49] <jcmish>	 hahah
[21:20:54] <jcmish>	 IM
[21:21:12] <jcmish>	 gtalk
[21:21:37] <jcmish>	 awjr: Maryana looking good for me
[21:21:43] <awjr>	 sweet!
[21:21:44] <awjr>	 me too
[21:22:49] * Maryana  looks

[21:23:25] <jcmish>	 Juliusz concurs :D
[21:24:39] <Maryana>	 everything appears to be in order
[21:24:46] <awjr>	 MaxSem: engage!
[21:25:11] <Maryana>	 we had to disable eventlogging for something, IIRC. are we reenabling it when we push to production?
[21:25:15] <MaxSem>	 so fast? you're scaring me
[21:25:22] <Maryana>	 i want to watch the successful uploader numbers grow
[21:26:12] <awjr>	 is the eventlogging thing just a configuration change?
[21:26:20] <awjr>	 dunno if it's on MaxSem's radar, Maryana
[21:26:40] <MaxSem>	 nobody informed me
[21:27:14] <Maryana>	 juliusz said something about needing to disable EL to test special:handshake, but i could be totally wrong
[21:27:17] <awjr>	 Maryana: how do we reenable event logging?
[21:27:31] <awjr>	 ori-l: ^^
[21:27:32] <Maryana>	 ah, good, jgonera_ is here
[21:27:44] * awjr  waves to jgonera_

[21:27:47] <jgonera_>	 Well, on phone
[21:28:00] <jgonera_>	 Awkward keyboard :/
[21:28:03] <Maryana>	 jgonera_, did we power down eventlogging at some point to test something?
[21:28:10] <Maryana>	 and if so, can we power it back up?
[21:28:18] <Maryana>	 i seem to dimly recall you mentioning that you needed to disable it
[21:28:38] <awjr>	 wgUseEventLogging = true everywhre right now
[21:28:54] <Maryana>	 ok, maybe i just misunderstood :)
[21:28:57] <Maryana>	 nobody panic!
[21:29:09] * jdlrobson  waves at jgonera_ 

[21:29:27] <Maryana>	 ok, yeah, i'm seeing recent events being fired on stat1
[21:29:28] <awjr>	 wgMFLogEvents = true everywhere as well
[21:30:16] <awjr>	 phew
[21:30:30] <jcmish>	 :D
[21:31:16] <awjr>	 ok so we're good to go then jcmish, Maryana?
[21:31:23] <Maryana>	 yeah, let's do it!
[21:31:31] <awjr>	 MaxSem: ^^
[21:32:08] <jcmish>	 yup
[21:32:58] <MaxSem>	 me just typed scap 'git review':P
[21:33:17] <jdlrobson>	 jgonera_: looks like the qunit test runner now expects us to use 'expect' - getting over 60 failed tests right now :(
[21:33:53] <jgonera_>	 Since when? Locally or Jenkins?
[21:34:18] <jdlrobson>	 locally
[21:34:20] <jdlrobson>	 i just updated my core
[21:34:21] <jdlrobson>	 :(
[21:34:23] <Krinkle>	 jdlrobson: That's been in the ci from the start, but not in the local env. I recently fixed that to avoid situations where you test it locally and have it fail in jenkins.
[21:34:26] <jgonera_>	 Hm
[21:34:36] <jdlrobson>	 Krinkle: i see - can you point me to the commit that enabled it?
[21:34:39] <awjr>	 lol MaxSem
[21:34:58] <Krinkle>	 jdlrobson: tests/qunit/data/testrunner.js ; QUnit.config.requireExpects = true/false;
[21:35:30] <Krinkle>	 Feel free to override it in your test init if you don't want to fix it right away.
[21:35:42] <Krinkle>	 Though I'd recommend just brushing it over and be done with it.
[21:35:44] <jdlrobson>	 Krinkle might as well fix it was there a bug you can point me to so I can reference it in the commit?
[21:36:01] <Krinkle>	 No bug, sorry.
[21:36:09] <Krinkle>	 not reported anyway.
[21:36:21] <jdlrobson>	 change id ? :)
[21:36:35] <jcmish>	 brb
[21:36:45] <Krinkle>	 jdlrobson: found it
[21:36:46] <Krinkle>	 jdlrobson: c669c9a78c1d9362c4953164a205da1b870b201e
[21:36:50] <Krinkle>	 https://gerrit.wikimedia.org/r/#/c/53188/
[21:36:50] <jdlrobson>	 thx :)
[21:37:00] <Krinkle>	 It's been the default since the beginning, just wasn't in core code itselfyet.
[21:37:13] <Krinkle>	 I'll announce on wikitech-l later today just in case.
[21:41:21] <jcmish>	 back
[21:51:17] <gerrit-wm>	 New patchset: Jdlrobson; "Provide greater expect-ations (fix breaking tests)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56322
[21:51:19] <jdlrobson>	 ^ Krinkle jgonera_
[21:51:33] <awjr>	 jcmish: when you've been preparing git logs etc for deployments, have you done anything special aside from git log —no-merges?
[21:51:44] <jcmish>	 nope
[21:51:50] <awjr>	 cool
[21:51:53] <jcmish>	 same ole thing
[21:52:07] <Krinkle>	 jdlrobson: Eh.. Q.expect? That looks like a newly invented pattern that I'd like to avoid.
[21:52:12] <Krinkle>	 jdlrobson: Just use the same pattern as in core
[21:52:22] <jdlrobson>	 What does core do - just use expect ?
[21:52:54] <Krinkle>	 jdlrobson: Well, firstly, it doesn't use the deprecated global pattern of module(), test(), equal(). But that's another todo item.
[21:53:07] <Krinkle>	 jdlrobson: Use the second argument to test()
[21:53:18] <Krinkle>	 QUnit.test( name, expect, callback )
[21:53:24] <Krinkle>	 test( name, expect, callback ) in your case.
[21:53:31] <jdlrobson>	 arggg
[21:53:53] <Krinkle>	 Can probably do a regex replace (if your editor supports multi-line replacements)
[21:54:35] <Krinkle>	 jdlrobson: In case of testCases.length, use QUnit.expect( testCases.length ); That's okay if you need to.
[21:55:06] <jdlrobson>	 do you have issues with using the Q keyword?
[21:55:10] <Krinkle>	 (I'd alias it to QUnit instead of Q, it's nice to have it be short but QUnit doesn't have a common short name, Q is a bit unknown)
[21:55:18] <jdlrobson>	 I might as well turn test to Q.test in process
[21:55:28] <Krinkle>	 Why does it have to be different?
[21:55:28] <jdlrobson>	 It's the James Bond fan in me… ;-)
[21:55:55] <Krinkle>	 QUnit.module, QUnit.test and function ( assert ) and assert.method( .. )
[21:55:59] <gerrit-wm>	 New patchset: Jdlrobson; "Rename #mw-mf-search to #searchInput" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56324
[21:56:17] <Krinkle>	 jdlrobson: basically, remove the globals from .jshintrc and add only QUnit and then it should pass
[21:56:45] <jdlrobson>	 yeh it's just easier to type Q.test then QUnit.test but I don't really care too much
[21:58:34] <jcmish>	 MaxSem: are we scapping?
[21:58:40] <MaxSem>	 yes
[21:59:10] <Maryana>	 #scapisneverdone
[21:59:18] <awjr>	 tehe
[22:05:07] <MaxSem>	 scap done
[22:05:07] <jgonera_>	 Jdlrobson, I'm not going to review this on my phone in gerrit :) this has to wait until I set up the desktop
[22:05:24] <awjr>	 jcmish, jgonera_, jdlrobson, Maryana ^^
[22:05:30] <jdlrobson>	 jgonera_: not a problem
[22:05:53] <awjr>	 https://commons.wikimedia.org/wiki/Special:LoginHandshake?useformat=mobile is still 404'ing
[22:06:47] <jgonera_>	 I see search hint text on alpha without opening searh
[22:07:08] <awjr>	 might need to wait a few minutes for RL resources to refresh from bits cache
[22:07:15] <awjr>	 ttl is 5 mins
[22:07:30] <jgonera_>	 Oh ok
[22:07:48] <awjr>	 im more concerned about why we're not seeing Special:LoginHandshake on commons?
[22:07:59] <jgonera_>	 That's lame, we give people a broken website for 5 min
[22:08:02] <jgonera_>	 Yeah...
[22:09:34] <awjr>	 i see Special:LoginHandshake on enwiki
[22:09:36] <awjr>	 ...
[22:09:41] <awjr>	 but not commons
[22:09:59] <awjr>	 MaxSem: any ideas? ^
[22:11:34] * Maryana  watches stat1

[22:11:40] <Maryana>	 come on successful uploads!
[22:12:56] <awjr>	 Special:LoginHandshake isn't available on commons because wgMFLoginHandshakeUrl = false for commons
[22:13:18] * MaxSem  rofls

[22:14:25] <jdlrobson>	 :)
[22:14:47] <jdlrobson>	 Maryana: people can't login yet so that aint gonna happen :)
[22:15:00] <gerrit-wm>	 New patchset: awjrichards; "Make sure Special:LoginHandshake always loads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56325
[22:15:05] <awjr>	 MaxSem, jdlrobson, jgonera_ ^
[22:15:25] <awjr>	 alternatively
[22:15:44] <awjr>	 jon is suggesting just setting the config var for commons to the same as everywhere else
[22:16:10] <awjr>	 i was concerned about a redirect loop but apparently that's not a problem due to some magic
[22:19:43] <awjr>	 MaxSem: actually use https://gerrit.wikimedia.org/r/#/c/56327/ instead
[22:19:54] <awjr>	 otherwise, mobile login on commons is busted due to what looks like a logic error around the js redirect
[22:20:29] <jdlrobson>	 It seems if the login handshake url it redirects you to null - also a problem on local machine - you need to be in incognito mode to replicate
[22:21:20] <gerrit-wm>	 New review: Jdlrobson; "Experimenting with an alternative solution for time being..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/56325
[22:23:06] <jgonera_>	 Jdlrobson can you elaborate?
[22:23:32] <jdlrobson>	 jgonera_: soooo
[22:23:35] <jdlrobson>	 several things
[22:23:45] <jdlrobson>	 we only add the special page if wgMFLoginHandshakeUrl is set
[22:23:54] <jdlrobson>	 on commons wgMFLoginHandshakeUrl is set to false so doesn't exist
[22:24:02] <jgonera_>	 Yes I know this one
[22:24:05] <jdlrobson>	 on commons if you try to login
[22:24:05] <MaxSem>	 deployed
[22:24:13] <jgonera_>	 Silly I missed this...
[22:24:13] <jdlrobson>	 jgonera_: 1s let me check
[22:24:27] <jdlrobson>	 document.referrer !== loginHandshakeUrl as document.referrer !== false :)
[22:24:50] <awjr>	 cool looks good!
[22:25:05] <jdlrobson>	 works :D
[22:25:31] <jdlrobson>	 so jgonera_ we currently have a situation where if you go to the commons login page it handshakes with itself
[22:25:39] <jgonera_>	 Hm so it redirects anyway right?
[22:25:41] <jdlrobson>	 completely pointless but everyone likes a handshake
[22:25:49] <jcmish_>	 :)are you allowed to handshake yourself? :D
[22:26:04] <jgonera_>	 Yeah stupid but should do no harm for now
[22:26:09] <jdlrobson>	 \o/ team
[22:26:15] * jdlrobson  gets out the iphone

[22:26:28] <jgonera_>	 And I guess not that many people use mobile commons
[22:26:53] * jgonera_  keeps fingers crossed

[22:27:14] <awjr>	 login seems to be hanging for me in iOS simulator
[22:28:05] <awjr>	 i get stuck looking at the spinner, but i appear to be actually logged in
[22:28:12] <awjr>	 logging out also hangs and displays the spinner 4 eva
[22:29:15] <jgonera_>	 Wfm on android browser...
[22:29:18] <awjr>	 anybody else have an iphone they can test on?
[22:29:23] <Maryana>	 wfm on my iphone
[22:29:26] <Maryana>	 i'm trying again
[22:29:29] <Maryana>	 clearing cookies again
[22:29:33] <jcmish_>	 awjr: works on my phone
[22:29:38] <jcmish_>	 and my simulator
[22:29:41] <jgonera_>	 Cookies and everything
[22:29:42] <awjr>	 oh, it just worked for me on my simulator
[22:29:46] <awjr>	 dunno why it wasn't working before
[22:30:57] <Maryana>	 old js is old
[22:33:08] <awjr>	 possible i was getting bad JS before
[22:33:34] <jgonera_>	 Probably, doesn't happen anymore right?
[22:33:41] <awjr>	 no things are looking ok for me
[22:34:06] <jgonera_>	 Somebody tested uploads on fresh Safari?
[22:34:59] <jdlrobson>	 jgonera_: https://commons.wikimedia.org/wiki/File:Special_Handshake_2013-03-27_15-33.jpg
[22:35:08] <jdlrobson>	 that's from the office iPhone
[22:35:16] <jdlrobson>	 there's a little weirdness though - sometimes old js/css seems to be loaded
[22:35:40] <Maryana>	 jgonera_: and my phone with cleared cookies: http://commons.wikimedia.org/wiki/File:Mustache_on_sticky_note-_2013-03-27_15-34.jpg
[22:35:41] <Maryana>	 :D
[22:36:03] <awjr>	 i just did this from desktop safari: https://en.m.wikipedia.org/w/index.php?title=HMS_Naiad&welcome=yes
[22:36:51] <jgonera_>	 Haha, awesome! My favorite pictures on commons ;)
[22:37:14] <jdlrobson>	 the css and js is really worrying me though
[22:37:25] <jdlrobson>	 i just cleared browser cache and it's still busted
[22:37:38] <awjr>	 i am fairly certain it will just take some time for that to shake out - as i've seen js/css issues, a hard refresh seems to fix it
[22:37:39] <jgonera_>	 But is it related? Or just a different thing?
[22:37:40] <jdlrobson>	 meaning handshake code only occasionally runs on the login bpage
[22:37:50] <jgonera_>	 Uh
[22:38:05] <jcmish_>	 sorry wasn't looking but awjr and jgonera_ I did an upload on my phone and all was well
[22:38:13] <awjr>	 sweet
[22:38:21] <jgonera_>	 Good
[22:38:52] <Maryana>	 yay yay yay!
[22:38:55] <jgonera_>	 I'll keep pressing f5 on our new dashboard tonight
[22:39:09] <awjr>	 oops, tapping search in beta looks weird
[22:39:17] <awjr>	 it expands the nav and lays over it
[22:39:25] <awjr>	 (desktop chrome)
[22:39:30] <jdlrobson>	 told you awjr jgonera_ :) https://gerrit.wikimedia.org/r/#/c/55776/
[22:39:53] <awjr>	 it looks fine if the nav is already expanded
[22:40:10] <awjr>	 but looks busted when nav is collapsed
[22:41:06] <jgonera_>	 It looks fine on mobile browsers though and that commit really broke it for me on desktop.
[22:42:23] <awjr>	 huh i just got a hanging sign-in on android browser also
[22:42:30] <jgonera_>	 OK, I hope everything else is fine. I'll wander off to set up Linux on the old desktop computer.
[22:42:36] <jgonera_>	 :/
[22:42:46] <jgonera_>	 I hope its cache
[22:42:54] <jgonera_>	 And it'll disappear
[22:42:59] <awjr>	 MaxSem: can we touch and sync some resources to see if it helps clear up some of these weird js/css issues?
[22:43:08] <MaxSem>	 sure
[22:45:44] <wikipedia-github>	 [android-commons] yuvipanda pushed 3 new commits to master: http://git.io/Mhuvtw
[22:45:44] <wikipedia-github>	 android-commons/master f0e9d30 YuviPanda: Make title message for Share screen consistent
[22:45:44] <wikipedia-github>	 android-commons/master 1816f79 YuviPanda: Separate ShareView into an activity + a fragment
[22:45:44] <wikipedia-github>	 android-commons/master 8a79666 YuviPanda: Create a separate api object for modifications sync...
[22:46:55] <awjr>	 yeah, im still seeing weirdness with login where login is successful, but i get stuck on the page displaying the spinner
[22:47:05] <awjr>	 (desktop chrome now)
[22:47:23] <jgonera_>	 What does js console say?
[22:47:29] <awjr>	 nothing interesting
[22:48:51] <awjr>	 now seems to be working fine :-/
[22:49:01] <awjr>	 ah - max touched some files
[22:49:30] <YuviPanda>	 max == midas
[22:51:18] <awjr>	 :p
[22:52:24] <awjr>	 ok, issues i have been seeing seem to be cleared up now
[22:52:49] <awjr>	 im guessing the JS/css reorg was responsible
[22:54:52] <wikipedia-github>	 [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/Ns7dRA
[22:54:52] <wikipedia-github>	 android-commons/master 7f720d1 YuviPanda: Handle menu enabling / disabling appropriately
[22:55:00] * YuviPanda  heads to sleep

[23:01:11] <jdlrobson>	 jgonera_: i think we are ok
[23:01:17] <MaxSem>	 whee
[23:01:18] <jdlrobson>	 just suffering from cache weirdness
[23:01:23] <jdlrobson>	 seems intermitten
[23:04:36] <ori-l>	 hey, i'm back -- lots of scroll back. do you guys still need anything from me?
[23:05:40] <awjr>	 ori-l: nah, thanks though :)
[23:06:25] <ori-l>	 ok, sure. if EL complicates your deployment somehow, please file a bug or let me know and i'll see if there's something i can do about it.
[23:21:54] <gerrit-wm>	 New patchset: Jdlrobson; "Provide greater expect-ations (fix breaking tests)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56322
[23:24:08] <gerrit-wm>	 Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56325
[23:31:22] <gerrit-wm>	 New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226
[23:33:05] <gerrit-wm>	 New patchset: Jdlrobson; "Add Page and Section view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139
[23:34:31] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54139
[23:34:40] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Surface talk pages on article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/54140
[23:36:58] <gerrit-wm>	 New review: Jdlrobson; "Following Siebrand's comment RTL is fine - Juliusz merge at will." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/54140
[23:45:20] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 46441: Move legacy css for menu into mobilemenu.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836
[23:46:31] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55836
[23:47:54] <gerrit-wm>	 New review: awjrichards; "PS in regard to wapness, we could do something like:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226
[23:55:48] <jdlrobson>	 Maryana: https://gerrit.wikimedia.org/r/#/c/55159/4/MobileFrontend.i18n.php
[23:59:09] <gerrit-wm>	 New review: MaxSem; "I'm aware of that revision." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226
[23:59:37] <gerrit-wm>	 New patchset: awjrichards; "Ensure userlogin.js checks for wgMFLoginHandshakeUrl before handhsaking" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56346
[23:59:43] <awjr>	 jdlrobson: ^