[00:40:42] dfoy, ping [00:52:04] New review: Jdlrobson; "operamobile.css is unrelated to this patchset. It can die another day." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56548 [00:52:06] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56548 [00:54:20] New patchset: Jdlrobson; "Urgent fix: Provide greater expect-ations (fix breaking tests)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56322 [00:56:45] New patchset: Jdlrobson; "Rename #mw-mf-search to #searchInput" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56324 [00:56:45] New patchset: Jdlrobson; "Rename jsEnabled class to client-js to be consistent with desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56350 [00:56:46] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [00:56:46] New patchset: Jdlrobson; "Bring watchlist css/html markup closer to desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56515 [00:56:46] New patchset: Jdlrobson; "Skin rewrite: Rewrite footer in a desktop friendly way" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56559 [01:03:04] ragesoss: do you think we should let people create new categories from mobile? [01:13:50] ragesoss: https://test.wikipedia.org/w/index.php?title=File:A_panda_image.png&curid=68552&diff=163832&oldid=163831 [01:13:51] \o/ [02:56:56] zz_YuviPanda: Mobile is the future and all that! [10:08:33] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/-l56eA [10:08:33] android-commons/master 36f90b5 YuviPanda: Prevent ModificationsSyncAdapter from looping forever [11:02:51] Yuvipanda: I think assigning new cats is good. but there should be a warning. [11:03:16] ragesoss: good morning :) [11:03:38] ragesoss: i'm going to punt that for now. I'll want it to be a separate modal dialog box, asking for a description too, that'll create a category page [11:04:23] yes, was just going to suggest that as a later feature. [11:04:53] description and categories for the cat page . [11:05:04] ragesoss: oh yeah, cats for the cat page [11:05:15]

[11:05:18] ragesoss: http://mobile-reportcard.wmflabs.org/ is trending down ;( [11:05:58] ragesoss: also, I think, for initial view - i.e. when no search terms are entered, we should show list of all categories that the user has used previously [11:12:54] yes [11:13:11] ragesoss: bleh, shitty connection [11:13:14] did i miss something? [11:13:14] or at least, used recently. [11:13:25] yeah, all categories used previously sorted in reverse chronological [11:13:26] order [11:14:18] sweet [11:18:41] fucking piece of shit city. bleh [11:18:49] ragesoss: did I miss anything again? [11:20:57] nope. I'm making breakfast. [11:22:10] I said "sweet", re: what I heard about you liking cats. [11:29:07] New patchset: Zfilipin; "It is useful to sometimes debug problems in Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56591 [12:08:30] yuvipanda: how hard will it be to have a single QR code that will sort you by platform and send you to the right app store? [12:09:04] by, like, June. [12:54:05] zz_YuviPanda: are you lurking by chance? [13:33:08] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56322 [13:58:46] New review: JGonera; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/55159 [14:03:45] New review: JGonera; "Unfortunately, this makes Submit and Cancel buttons disappear in the photo preview on Android Browse..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55159 [14:05:19] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56358 [15:48:26] New patchset: MaxSem; "Remove disable_zoom now that it's unused" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56603 [16:16:31] New patchset: MaxSem; "WIP: [Card 446] Don't vary page HTML on X-Device" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226 [16:44:53] jgonera: i warned you about fixed positioning :) [16:45:23] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56603 [16:45:23] yeah... [16:45:30] I'm not sure what to do with it [16:45:44] it might be a mix of fixes and absolute that we have [16:45:50] supportPositionFixed [16:45:54] the weird thing is [16:46:01] that the buttons are actually there [16:46:04] you can click them [16:46:08] but you can't see them [16:46:21] yup welcome to the magical fun world of position fixed on mobile :) [16:47:23] i know android 2 can't handle it at all [16:48:01] hm [16:48:16] jgonera: it's worth noting on android 2 the drawer doesn't disappear until you touchend [16:48:19] I kind of hoped Android 4.2.1 wouldn't exhibit such problems [16:48:34] which drawer? [16:48:38] the cta? [16:48:39] The watch star [16:48:43] when not logged n [16:48:53] until touchend? isn't this correct? [16:48:56] the drawer is position absolute [16:49:12] so it looks odd as i scroll - it stays in place - when i stop it disappears [16:49:25] position fixed on mobile it's just a mess. They really need a reliable mobile version [16:49:31] oh ok [16:49:31] e.g. position: viewport-fixed [16:50:07] I was thinking a bit about us allowing zooming (I'm not sure how related this is) [16:50:28] I mean, when the UI is good, zooming should not be necessary [16:51:07] oh btw now we are not disabling viewport position fixed is broken on android 2 [16:51:08] http://bradfrostweb.com/blog/mobile/fixed-position/ [16:51:19] zooming is always necessary [16:51:25] i hate websites which don't [16:51:37] I know you do, but I don't know why [16:51:41] what do you use it for? [16:51:50] i zoom into photos all the time [16:52:00] and it's super annoying that Chrome zooms for no reason [16:52:11] it's just fundamentally wrong though - that you are stopping the user from exploring [16:52:32] I would allow it on file pages then ;) or develop some nice UI for zooming [16:52:42] zooming is awkward for me [16:52:53] you can always increase the text size in the browser [16:53:39] awjr, are the updated comments at https://gerrit.wikimedia.org/r/#/c/55226/4/MobileFrontend.php sufficient for you? [16:53:53] MaxSem: i'll take a look after standup [16:54:18] and personally, I think you have to stop users from exploring some things, at least by default. if they're pro users then most browsers allow them to diregard the blocked zooming [16:59:08] I know there are bugs in browsers but I don’t think we should take away the user’s right to pinch and zoom to make content larger. [16:59:13] https://twitter.com/adactio/status/52420790137794560 < I know I'm not alone in this [17:01:12] jgoneraare you joining us for standup? [17:02:07] it just told me that I'm not allowed to join this hangout... [17:02:16] wait, I'll try to log out and log in again [17:11:04] I might try rebooting to Windows for the standup next time, I'm on open source drivers on Linux because ATI decided to drop support for older graphics cards... [17:12:20] New patchset: Jdlrobson; "Bug 41519: Only request token when clicking the star" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56411 [17:12:31] New review: Jdlrobson; "Rebase. Submit." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56411 [17:12:32] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56411 [17:12:55] MaxSem: i just realized a big problem with https://gerrit.wikimedia.org/r/#/c/55226 [17:13:06] hey awjr, remember passing those two girls wearing weird sexy yeti costumes on the way to lunch yesterday? [17:13:08] http://kotaku.com/two-game-developers-quit-non-profit-objecting-to-femal-461717726 [17:13:09] sigh [17:13:36] in MobileContext::getXDevice(), you're now just setting xDevice to 'wap' or 'capable', which won't help for x-device variance of resources [17:14:09] jeez Maryana [17:14:16] so many conference scandals this year! [17:14:22] stay classy, all of technology! [17:15:05] MaxSem: also you're still not setting X-Device in the response header for resources [17:16:03] aha, thanks! [17:16:22] back to drawing board (as if I was away from it) [17:16:39] New review: awjrichards; "X-Device still needs to be set in the response header for resources (when varying by X-Device for th..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55226 [17:18:58] awjr, you mentioned not allowing client-side caching, why is this still a problem? I thought jdlrobson fixed our asset fragmentation making every page load one common JS/CSS file and one page-specific [17:19:18] jgonera: varnish is setting cache-control headers that prevent client-side caching [17:19:39] oh, ok, so it's something different [17:19:41] yeah [17:27:34] gerrit's down? [17:28:05] ok, it's up again [17:32:26] yeah, i had a gerrit blip too, had to log back in [17:34:55] New patchset: JGonera; "Use file name for images with descriptions with templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [17:37:26] motherfucking new reply interface in gmail is killing me [17:38:09] "Welcome to the new compose" uh-oh [17:38:21] is this the new compose that i turned off the preview of a few months ago? shit [17:40:31] yes... [17:40:37] I hate it too [17:41:15] really? i like it. i used to have to keep two tabs of gmail open, one to see new email and one to compose [17:41:26] but maybe that's because i take too long to write emails :) [17:42:12] It bothers me that I can't resize it [17:42:24] you can break it out to a new window and resize that [17:42:24] now they require 2 clicks to switch from reply to reply to all [17:42:28] or move it [17:42:45] brion, I know, but I don't want a new window ;) [17:42:57] welcome…. to software as a service :) [17:43:32] that's why I usually still use Thunderbird [17:44:00] I just thought I'd use gmail to avoid using up precious 1GB of RAM now [17:44:14] hehe [17:44:15] although I'm not sure if gmail tab eats less RAM than Thunderbird [17:44:28] HTML: it's like native code but slower and uses more RAM [17:44:35] but it's flexible :) [17:44:38] hehe [17:45:59] so jgonera i can't replicate the hidden carousel upload buttons on my android 4 ... [17:46:25] last time I tried out T-bird it barely moved under the load of my email archives [17:46:27] ask awjr, I guess he could replicate that when I had this problem after introducing animations [17:46:43] biron: looks like the engineering report hasn't been updated yet for mobile - can you coordinate updates for apps and zero? (https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2013/March#Mobile) [17:46:57] apparently needs to be done by march 31 [17:46:59] MaxSem, really? I usually have several thousands per folder and it's still fine [17:47:18] jdlrobson: are you using native android browser? [17:47:54] yes [17:48:32] MaxSem: can you update project status for https://www.mediawiki.org/wiki/OpenStreetMap ? [17:48:48] apparently status updates need to be done by march 31 for the engineering report [17:48:52] New review: Jdlrobson; "This seems like a step back - what if the description/filename changes?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [17:49:10] awjr: will do [17:49:23] thanks dude! [17:50:25] jgonera: works on arthur's as well.. [17:50:45] New patchset: Jdlrobson; "Story 400: Deal with first time user upload" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55159 [17:50:55] well, then I don't know, I guess we can ignore it for now? let me check again [17:51:03] jgonera: i suspect i know how to fix it but i can't replicate it. Try adding position relative to all div's in the overlay [17:52:13] hmm [17:52:21] awjr: i'm not seeing the update i did for commons app in https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2013/March#Mobile [17:52:33] hrm [17:52:38] i hate these complicated template things [17:52:47] can't we just edit a wiki page like normal people? :) [17:52:51] it's been a long time since i've done this and they've made it a lot fancier since then... [17:53:00] hey brion :) [17:53:28] brion: seen https://test.wikipedia.org/wiki/File:Category_oicker.png [17:53:40] awjr: ok i fixed it [17:53:42] jdlrobson, but the buttons are where they should be, they're just not rendered (but clickable), I can check anyway [17:53:45] it was pointing at the wrong template page [17:53:52] nicely done sir! [17:54:07] i was about to suggest you ask guillaume cuz… ?!?!!? [17:54:07] jdlrobson, #mw-mf-overlay div { position: relative; } ? [17:54:08] i know but these browser glitches are usually due to position of parent [17:54:18] jgonera: yeh try that [17:55:29] brion: that's the categorization interface :) [17:55:42] brion: putting final touches, should commit in an hour or so [17:55:45] oicker? :) [17:55:52] awsome :D [17:56:00] brion: it was supposed to be 'picker' but phonetypo [17:56:08] you're a machine yuvi, i've got lots to catch up on :D [17:56:27] brion: :) I'll be gone all of may! [17:56:40] true, that'll be my catchup time :D [17:56:49] brion: :) [17:57:10] brion: i'm also going to implement LRU there, so that by default it'll show you all your recently used categories [17:57:17] nice [17:57:32] yeah, that'll require more work though [17:57:35] but more work ftw :P [17:57:40] New review: JGonera; "If the description changes and no longer contains templates, the it gets displayed. I'm not sure how..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [17:57:51] brion: you should CR sometime :) [17:57:55] code base is a lot bigger now [17:58:01] i shall [17:58:14] once we get monte working on obj-c i'll explore the java codebase in more detail [17:58:29] brion: yeah [17:58:44] brion: there is going to be one full extra person working on iOS! [17:59:25] \o/ [17:59:44] brion: are you planning on submitting to APple today? [17:59:52] that's the plan [18:00:07] brion: nice :) looking forward to the bump from that :) [18:00:09] if i'm not happy with it today i'll do a little more on the weekend [18:00:15] brion: okay! [18:00:17] yeah it's gonna get it in a lot more peoples' hands [18:00:18] brion: 6.0+? [18:00:36] test flight is waaay better than manual beta, but still seems hard to get people to sign up with their device ids correctly [18:00:38] yeah, 6.0+ [18:02:30] jdlrobson, it might have been browser cache related problem on my side, sorry, it seems to be ok now [18:03:29] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55159 [18:04:10] brion: :D [18:04:19] brion: plus we're doing very little marketing, I think [18:04:38] yeah hardly any yet [18:08:36] New review: JGonera; "How does it make the skin desktop friendly? What do we need it for?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56324 [18:10:48] jgonera: check out https://gerrit.wikimedia.org/r/#/c/56559/ [18:10:53] it will answer all your questions [18:12:26] jdlrobson, actually it just doubles the amount of questions, now the same questions apply to the footer ;) [18:13:20] New review: Jdlrobson; "there is a parse api we can probably use." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [18:13:33] jgonera: ok look at the commit before [18:13:35] go to the desktop site [18:13:55] append useskin=minerva [18:14:05] \o/ gerrit and dependencies [18:14:23] basically i'm trying to throw away our custom skin code [18:14:32] are we renaming MF's skin parts into minerva? [18:15:58] YuviPanda: some common bits yes. I'm not convinced we can do mobile without extending the SkinMinerva and making a few tweaks to it [18:16:07] but we can certainly throw a lot of code away with a few core changes [18:16:09] jdlrobson, so this minerva skin would be something hidden until it's ready? is it the same thing as the one you worked on with Kaldari (is it the same code as on github)? [18:16:18] jgonera: yep same thing - but its not hidden [18:16:29] this change will make it available as a desktop skin from user preferences [18:16:33] I'll note that a lot of skins were just thrown away a few days ago [18:16:37] I mean hidden as in not shown to normal users [18:16:42] oh [18:16:42] to limit the number of them available in the user preferences [18:16:46] jgonera: it's shown to logged in users [18:16:53] in preferences, ok [18:16:56] i want to create more visibility and development interest in our skins [18:16:56] so if we're going to add one to that list, we should at least email wikitech-l [18:16:59] few people anyway ;) [18:17:19] YuviPanda: well theoretically we could disable it from that list / make it configurabl;e [18:17:23] one thing that makes me wonder, won't some changes make mobile RL modules load in desktop Vector skin? [18:17:25] mobile.startup [18:17:35] sure! [18:17:43] I'm just saying that we should do a 'headsup!' email on wikitech-l [18:17:46] jgonera: no they have to be manually added [18:17:51] than submarine it [18:18:10] YuviPanda: the mobile skin has been around for some time - just only in MobileFrontend [18:18:13] oh, ok, the skin adds them I suppose [18:18:50] I understand jdlrobson. I'm simply saying that since there's a clearing house of skins in the preferences list (about 4-5 were killed a day or two ago from the preferences list), and if we are going to add one more, we should let people know [18:19:08] i think it is awesome and a good way to improve our skins - a lot of people will even prefer it, I think [18:19:14] YuviPanda: I'd rather not add it to preferences then [18:19:18] i don't want a large amount of eyes on it [18:19:33] if there's a way to hide it in preferences even better [18:19:45] jdlrobson: I"m unsure if there's a way to do that (have a skin that's unselectable) [18:19:53] but what's wrong with just sending wikitech-l an email? [18:19:53] i think people are used to skins being complete [18:19:54] this would be a more iterative skin [18:20:03] I am pretty sure nobody's going to stop you from adding it [18:20:28] YuviPanda: I'm not worried about that [18:20:40] wikitech-l is not high distribution :) [18:20:44] we're not annoucing on village pumps [18:20:49] that's true [18:21:02] it still needs to get through the MaxSem though ;-) [18:21:07] ah, yes. that is there :) [18:21:39] MaxSem: brion SkinMobileBase has a function createDismissableBanner - does anything actually use that? I can't see it in zero.. [18:21:49] hmm [18:21:51] searching [18:22:01] jdlrobson, we used it for WLM banner [18:22:07] ok so it can burn! :D [18:22:15] no, we can use it for zero [18:22:23] ah [18:22:30] so those may merge [18:23:27] MaxSem: we do? [18:23:37] we can [18:23:45] but we don't [18:23:52] but we can [18:23:55] YAGNI [18:24:04] CAN [18:24:09] http://en.wikipedia.org/wiki/You_aren't_gonna_need_it :) [18:24:22] tumbleweed code scares me [18:25:41] New patchset: Jdlrobson; "Remove tumbleweed code for WLM banner" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56618 [18:29:28] jdlrobson, so why it changes SkinMobile.php? [18:29:35] jgonera: why what? [18:29:47] the minerva commit [18:30:03] so we are depending on this unfinished minerva skin in production? [18:30:58] SkinMobile extends SkinMobileBase which extends SkinMinerva [18:31:04] SkinMinerva is written in a desktop friendly way [18:31:06] yeah, I see [18:31:10] and moves stuff from mobile to desktop [18:31:20] SkinMinerva doesn't have to be a registered skin [18:31:21] but it's not finished, or is it? [18:31:30] jgonera: well it depends how you define finished [18:31:31] t [18:31:32] h [18:31:42] the existing mobile skin is not finished in that some pages look weird in it [18:32:09] if you view minerva in desktop the watch star and search box and menu all work [18:32:18] but some pages will not render well - Special:Preferences for example [18:32:23] but these are mobile problems too [18:33:04] I wish we had an internal staging version of Wikipedia that only some people used where the code would be 1 week ahead of production for the rest of the world [18:33:12] because else changes like that scare me [18:33:24] hm [18:33:49] it makes the blue Go button appear for me for starters [18:34:21] and doesn't use hires menu icon [18:34:33] wait, maybe cache again [18:36:32] else changes? [18:37:12] ? [18:38:32] "jgonera: because else changes like that scare me" [18:38:44] *otherwise [18:40:50] so there's no footer until I fetch the next changeset too? [18:42:33] no, actually I don't see the footer with either of them... [18:44:19] now i'm confused.. [18:44:35] the footer is always there, the 2nd change set just renames some html and class name [18:48:26] jgonera: daniel zahn says can you call him/organise a google hangout if you want ssh access for the weekend [18:49:17] jdlrobson, you saw what happened during standup, I can reboot to Windows, but then I'm... on Windows [18:49:27] which means no shell, no ssh keys, no anything [18:49:37] why is a hangout needed for that? [18:49:40] jgonera: just passing on a message :) [18:49:46] it went so smooth last time... [18:49:48] woo got irc working on my phone [18:49:49] i think it's a security concern [18:49:53] jdlrobson: https://meta.wikimedia.org/wiki/Turning_off_outdated_skins [18:50:09] what's his nick on IRC? [18:50:18] free node blacklisted T-Mobile so I have to use sasl auth [18:51:48] not sure and he's stepped out - just mail him [18:54:59] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56351 [18:58:38] jdlrobson, I'll be going soon, do you need anything before I leave? [18:59:06] nope i'm good [18:59:09] have a good weekend [18:59:37] New review: Brion VIBBER; "You can also use rvparse=1 on a prop=revisions to get parsed content; should be possible to extract ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [18:59:39] ooh i just noticed the carousel unit tests need to have the expects parameter [19:01:30] New patchset: Jdlrobson; "Minor QUnit test fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56625 [19:01:59] New review: JGonera; "Before:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56350 [19:02:31] stupid gerrit, removing my newlines [19:04:39] jgonera: re https://gerrit.wikimedia.org/r/#/c/56613/, if you just want to get description out, why can't you just request the HTML and parse the description out of it? [19:04:50] jgonera: {{Information}} has pretty stable HTML 'interface', documented at https://commons.wikimedia.org/wiki/Commons:Machine-readable_data [19:04:53] New patchset: Jdlrobson; "Rename jsEnabled class to client-js to be consistent with desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56350 [19:05:52] YuviPanda, is it always Information template? [19:06:05] and, why would I parse HTML instead of wikitext? [19:06:21] because you can parse the data from HTML by putting it into the DOM, but you can't parse Wikitext? [19:06:23] and, what if description itself contains more templates? [19:06:37] it's html, all templates are 'resolved' [19:06:55] yes, but some descriptions contain versions in 10 languages, etc. [19:07:01] how do I get the relevant one? [19:07:04] yeah, those are documented too, I think [19:07:10] they are stable, though [19:07:17] well, depends on how you define 'stable' [19:07:21] err [19:07:23] i mean [19:07:24] 'relevant' [19:07:36] it's easy enough to get all the languages one, and then oyu just decide which language to show [19:07:58] it's not an easy problem, but I think this is *definitely* more complete / easier than parsing wikitext [19:08:03] I'm just not sure how important it is for the mobile users to get the text from the description field, I still see parsing this as potentially unstable and hacky, I'm not sure it's worth the effort [19:08:38] hm [19:08:55] what do I show if there's no description for the current language? [19:09:14] there just seems to be many corner cases and I'm not sure it's worth the time investment [19:11:29] New patchset: Jdlrobson; "Change diff colors after design input" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56626 [19:11:29] New patchset: Jdlrobson; "Add new diff test case for simple insertion" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56627 [19:11:44] jgonera: commons is full of corner cases :) [19:11:54] I know [19:15:08] hey valeriej :) [19:15:30] jgonera: right now the way mobile web does descriptions is actually the corner case onc ommons, since the majority of pages just add an {{Information}} template [19:15:30] YuviPanda: Hello! [19:15:56] jgonera: so most of the tools that do commons stuff just parse {{Information}}, and hnece will break on the web uploads [19:15:58] YuviPanda, that's true [19:16:07] I noticed that [19:16:22] it's still a piece of code from the first uploads prototype [19:16:52] valeriej: what kind of dev experience do you have? [19:17:25] valeriej: and to pick a thing to start with, what would excite you more - writing automated tests to catch bugs or writing new code to create bugs? [19:17:26] :D [19:18:03] jgonera: yeah, so the 'right' thing to do would be to use {{Information}} on that too. And parsing out the HTML seems to be the 'least' hacky way to work with commons as it stands, at least to me [19:18:58] I'll analyse the HTML that comes out of this template later, thanks for suggesting that [19:19:51] ok, going now, hope nobody else needs anything, I should've asked before SF lunch hours... [19:20:04] see you! [19:21:01] YuviPanda: Java is the first coding language I learned and I used it in school. Most of our classes, like algorithms and data structures, used Java. I haven't had much mobile development experience, but lots of Java dev experience. [19:21:03] valeriej: http://calaba.sh/ is something we're looking at to do automated testing on android [19:21:11] valeriej: that's sweet! :) [19:21:24] valeriej: do you have time to get setup now? [19:21:40] YuviPanda: Sure! [19:21:44] valeriej: android is just java with a different framework [19:21:50] valeriej: wonderful. What OS are you on? [19:22:02] valeriej: and what IDE do you usually use for Java dev? [19:22:36] YuviPanda: I'm on Vista and I have Eclipse set up with the Android SDK plug-ins. [19:22:56] ah, okay. [19:23:00] I use IntelliJ but that should be fine [19:23:21] valeriej: fork / clone http://github.com/wikimedia/android-commons? [19:23:21] valeriej: all our development happens on GitHub [19:25:14] valeriej: have you used maven before? [19:25:15] YuviPanda: Let me see if I remember how to do this... [19:25:27] valeriej: I can guide you through it if you want :) Have you used GitHub before? [19:25:58] YuviPanda: I have an account, but I didn't really have anything to work on, so i just stopped there. [19:26:30] valeriej: ah, right. [19:26:40] valeriej: they do have a nice tutorial on getting set up [19:26:42] with keys, etc [19:32:03] valeriej: if you want to get started without having to set all that up, that is easy too [19:32:30] jgonera: trouble with hangouts on Linux? [19:33:24] YuviPanda: Sorry for the delay. I've cloned the repository. [19:33:30] use Chromium rather than Firefox, if you weren't. [19:33:46] (oh, jgonera is gone.) [19:34:05] ragesoss: he's in europe but in sane working hours that end at nightfall :P [19:34:24] valeriej: sweet. Have you used 'maven' before? [19:34:47] YuviPanda: No. [19:35:21] valeriej: okay. It is a way to package 'dependencies' in an automated way. It automatically sets up dependencies for you, so that you don't have to download and install 20 different libraries :) [19:35:52] valeriej: https://maven.apache.org/download.cgi has download and installation instructions [19:36:02] tell him that next time... lately for me, in chromium it works great, in Firefox I get constant problems. [19:36:11] YuviPanda: Thanks! I'll set that up now. [19:36:23] valeriej: pick up the 3.x version [19:36:26] ragesoss: will do! [19:36:34] YuviPanda: Got it. [19:49:34] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/55226 [19:58:10]