[00:18:51] [Commons-iOS] montehurd opened pull request #32: Made tapping add media button cause animation of take and choose picture buttons (master...bug45463) http://git.io/agc7lA [00:38:57] MaxSem: still awake? [00:39:03] yup [00:39:09] though not for long [00:39:13] k [00:39:15] quick q [00:39:26] so with https://gerrit.wikimedia.org/r/#/c/56774/2/templates/varnish/bits.inc.vcl.erb we'll need to update the bits URL on mobile requests, yes? [00:40:47] yeah [00:41:08] would we update the config var in efmobileFrontend_Setup() after detecting mobile view or … ? [00:41:47] in wmf-config/mobile.php [00:42:01] with that hook I've introduced [00:42:13] ! [00:42:13] which hook? [00:42:28] oh, the 'are we in mobile mode' hook [00:42:42] ok that makes more sense [00:51:33] New review: awjrichards; "Once this is documented, this is good to merge!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/57060 [00:51:55] bleh [00:52:08] core hooks get merged first;) [00:52:20] ha [00:52:23] really? [00:52:43] actually that makes sense. [00:52:48] im just nervous we'll forget. [00:53:47] New review: awjrichards; "Actually, max pointed out that core hooks get merged before documented on mw.o. So, I'm merging this..." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/57060 [00:54:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57060 [06:40:56] ragesoss: depends on how long it takes mediawiki, though [06:40:58] ragesoss: i'm unsure [11:33:01] Pffft how is zz_YuviPanda still sleeping [11:37:02] Reedy: :P [11:37:11] I'm up early and everything! [11:37:39] On the android commons app.. How is your upload list pulled? [11:40:25] YuviPanda: I've got a few seemingly dead images that are still on commons [11:40:30] And a couple of entries I've nfi what they are [11:40:48] Reedy: hmm, it's pulling from eventlog [11:41:03] Reedy: allimages doesn't do 'original uploader', so we are using eventlog for now [11:41:14] Yeah.. [11:41:19] Reedy: can you give me the nfi entries links? I've heard that before [11:41:20] I've got a JFKN-JFKN-1-1 and JFKN-JFKN-1-2 [11:41:48] Hmm. Seemingly deleted ogg files [11:41:55] yeah, deletions show up [11:41:59] and i'm not filtering by file format [11:42:06] Reedy: there's no easy way to handle deletions [11:42:08] or redirects [11:42:33] Oh [11:42:37] The others ones I failed at naming [11:42:40] And moved [11:42:52] bleufhgjfhfh [11:42:55] Reedy: there's no way for the API to get me 'files i originally uploaded that are undeleted and after renames' [11:43:19] yeah, i see https://commons.wikimedia.org/wiki/File:JFKN-JFKN-1-1.ogg deleted [11:43:24] Beat MaxSem into making one [11:43:49] Reedy: MaxSem is too busy :( [11:44:45] Reedy: there's also a user account creation patch from brion awaiting review [11:44:59] Reedy: there's a bug for this too, let me find it [11:45:15] * YuviPanda wonders if his internet is alright [11:46:19] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=46318 [11:56:46] morning Yuvi, Reedy [12:01:53] hello ragesoss [12:04:22] is post-upload categorization coming soon? [12:04:40] ragesoss: It's called hotcat [12:04:40] ragesoss: this is what i called 'post upload categorization; [12:04:47] ragesoss: as in it happens right after you upload :) [12:05:43] ragesoss: i'm listing out stuff I should get done before I take the break, and I'm unsure if I'll have post upload categorization there [12:06:00] ragesoss: assorted bugfixes, create account, automated testing would be top of the list [12:06:13] yeah. [12:06:49] ragesoss: also notifying users of errors in a more detailed way [12:07:31] +1 [12:09:13] ragesoss: really need automated testing, I don't want to have this 'omg i hope i didn't break anything' feeling as i push update [12:11:44] totes [12:12:54] automated 'not pointed at testwiki' testing. :p [14:19:52] ragesoss: heh, yes [14:19:58] ragesoss: should point at beta cluster or localwiki [16:33:15] New review: Cmcmahon; "point mobile browser tests to beta labs" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56505 [16:33:16] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56505 [16:34:22] New review: Cmcmahon; "allow Mobile tests to run on Firefox for debug purposes" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56591 [16:34:22] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56591 [16:36:53] aude_, around? [16:39:45] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/57054 [16:39:45] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57054 [17:09:59] brion: around? [17:10:05] yo [17:10:26] brion: :) [17:10:36] brion: we've a meeting scheduled for 11:30, want to just do it over IRC instead? [17:10:51] though I guess we might want to do video on and get mhurd involved too [17:11:01] but we could wait till tfinc gets back [17:11:02] your call [17:11:12] New review: MaxSem; "I don't like the renaming of the class, the MF prefix is non-standard for our classes. Otherwise, lo..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [17:11:37] YuviPanda: yeah let's wait until tfinc is back [17:12:52] bleh, what did I miss? [17:14:41] hey mhurd [17:15:07] hey yuvi! [17:15:51] had my first bug - my last patch doesn't work in landscape [17:16:06] gonna fix now [17:18:00] mhurd: :) [17:18:06] mhurd: what irc client are you using? [17:18:18] colloquy [17:18:30] people are starting to tag the mobile web uploads as 'no source' [17:18:40] ragesoss: hmm? link? [17:18:43] they are likely to end up deleted. [17:18:56] http://commons.wikimedia.org/wiki/File:Small_toddler_sitting_on_toilet.jpg [17:19:32] ragesoss: oh, web uploads lacking {{Information}} [17:19:32] (another that I uploaded got tagged earlier today) [17:19:36] yes. [17:19:48] yeah, I think {{Information}} is important [17:19:58] yep! [17:20:12] ragesoss: you could hand-add it this time [17:20:38] ragesoss: and poke Maryana / jdlrobson when they come back about this :) [17:20:38] I know. I was just pointing out that a whole lot of other web uploads are going to be at risk. [17:20:49] yeah... didn't see them, or would have. [17:20:50] ragesoss: yeah. I don't know what we could do, howver. [17:21:04] smooth talk the community? [17:21:07] ragesoss: there was a spike about adding {{Information}} support for web, but it was scrapped for now for being too technically complex [17:21:17] add the info by bot? [17:21:25] :/ [17:21:42] so, someone needs to do some communication with the Commons community. [17:21:50] yeah [17:22:31] ragesoss: i've a meeting with maryana in about 8 minutes, I'll poke her about it [17:22:38] good good [17:23:10] ragesoss: is someone putting out deletion notices en masse? [17:23:16] yes. [17:23:25] User:XenonX3 [17:23:52] hmm, yes, I think she mentioned something about that just as standup was ending [17:24:06] http://commons.wikimedia.org/wiki/User_talk:XenonX3#Inappropriate_deletion_tagging [17:24:29] oh, she's their talk page already. [17:24:45] *on [17:24:48] ragesoss: yeah [17:28:53] hey yuvipanda, vibha is stuck in another meeting - can you hold tight for another 20 min or so? [17:29:00] Maryana: sure :) [17:29:02] also, see my latest email to mobile tech [17:29:05] the pitchforks are out [17:29:11] Maryana: i'll get off hangout, can you ping me when you are ready? [17:29:12] (on IRC) [17:29:17] will do [17:29:20] Maryana: thanks [17:29:32] * brion better get some coffee :) [17:31:05] Maryana: should we get brion and mhurd into the syncup too? Or just me? [17:31:41] oh yeah, we have a big apps team now! :) [17:32:07] Maryana: http://commons.wikimedia.org/wiki/Commons:Deletion_requestsFile:Special_Handshake_2013-03-27_15-33.jpg#File:Special_Handshake_2013-03-27_15-33.jpg another example :) [17:32:10] sure thing, if they want to attend [17:32:29] jdlrobson, i think the easiest thing to do is to add "created by uploader" to the mobile upload templates [17:32:34] that goes for apps, too [17:32:44] Yes agreed Maryana makes it less obvious [17:32:44] could we just change the template? [17:32:47] yep :) [17:33:02] yuvipanda, can you help us out with your template-fu? [17:33:10] Maryana: apps have been adding templates for a while [17:33:20] ah, but you're not specifying author or source [17:33:24] we do! [17:33:30] where? [17:33:46] we always assume that the user is the author and source is self created work :) [17:33:52] which is true 99% of the time [17:34:01] check how the apps' {{Information}} is populated [17:34:13] let me fish it out [17:34:25] it's not that hard to put one together by string concat yeah :) [17:34:29] oh yeah, i see: https://commons.wikimedia.org/wiki/File:A_nous_enfin_le_droit_d_avoir_le_choix.jpeg [17:34:32] in the summary field [17:34:47] |source={{own}} [17:34:47] |author=[[User:Oliver H]] [17:34:48] we need that for mobile web uploads STAT! :D [17:34:50] Maryana: ^ [17:34:56] gotcha [17:35:13] but this will require redeploying, correct? [17:35:19] YuviPanda: save the day! [17:35:43] YuviPanda: can [17:35:44] 't [17:35:49] jdlrobson: you need to implement {{Information}}. There was a spike for this a while back from jgonera, I think it ended with 'let us not do this now' [17:35:53] YuviPanda: can't we just make this the default? [17:36:12] jdlrobson: ah, nope. [17:36:17] in the This photo was uploaded via Mobile Web template? [17:36:28] jdlrobson: ah, don't think so. [17:36:32] why nos? [17:37:08] that seems like a good temporary fix - can't we add |author={{{{$USER}} or something to the mobile upload/web template? [17:37:19] Maryana: no, those should be in the {{Information}} template [17:37:29] agreed [17:37:30] YuviPanda: yes but we need protection for existing photos.. [17:37:32] i'm just saying for now [17:37:36] as a stopgap [17:37:38] jdlrobson: commons policy, afaiu, is that the original author should explicitly do it [17:37:42] they have! [17:37:43] ughh [17:37:48] "I, the copyright holder of this work, hereby publish it under the following license:" [17:38:05] Maryana: stopgap would be to get a bot to do {{Information}} tagging [17:38:14] yeh nobody believes for uploads that even though it's apparently good enough for text edits [17:38:16] it irks me [17:38:21] +1 [17:38:29] * jdlrobson sighs and puts his head in his hands [17:38:40] hoooooooo boy [17:38:48] there, there [17:38:53] ok, everything's gonna be ok :) [17:38:54] jdlrobson: wait until they see the photo of you in the ellora cave, and then go 'oooh, but you are in the photo, and hence you can not be the copyright holder! Who is the original author? Can you ask them to send in an OTRS permission form?' [17:39:03] jdlrobson: it'll be alright :) [17:39:09] dfoy, no IP filtering for telcos :) but you got your ranges [17:39:15] YuviPanda: they've already done that [17:39:19] Maryana: i think a bot's the best 'stop gap' solution [17:39:20] it's already survived deletion [17:39:20] jdlrobson: aww [17:39:31] yuvipanda: know of a bot-herder that will do this for us? [17:39:44] haven't they heard of timed photos? [17:40:12] Maryana: legotkm is the one I know. Also, Coren. [17:40:16] but I don't know Coren :) [17:40:17] AWB could handle it. [17:40:22] ragesoss: for all of theM? [17:40:29] odder might be willing. [17:40:34] i know coren [17:40:40] YuviPanda: they are all in the category. [17:40:46] ragesoss: ah, right. [17:40:53] so just load the list of files in the cat, and get the right regex. [17:41:03] hmm, that could work [17:41:09] yeah, that shouldn't be *too* hard, though you'll need to find a way to populate author [17:41:16] which needs uploader name, i'm unsure if awb does that [17:41:18] (haven't used it) [17:41:23] Maryana: awb is windows only, IIRC :) [17:41:30] erghh [17:41:30] yeah, not sure if it does. [17:41:36] I run AWB on linux. [17:41:38] Maryana: and yeah, it might not support this [17:41:40] ragesoss: WINE? [17:41:40] wine FTW. [17:41:49] Maryana is on OS X:P [17:41:51] ok… so bot is our best bet? [17:41:59] Maryana: bot is our easiest bet. [17:42:07] it'll take a short-ish amount of time too [17:42:14] ragesoss: oh, also not all of them have the category [17:42:22] ragesoss: we had this 2 week period in the middle when a category was not being added [17:42:25] orly? [17:42:28] ragesoss: yarly [17:42:35] Maryana: jdlrobson you have to account for that too [17:42:39] you can get a list somehow, though. [17:42:50] I presume. [17:42:56] ragesoss: yeah, there's a mobile edit tag [17:43:02] which is a more 'canonical' list [17:43:07] yuvipanda, true. i'm ok with sacrificing the few to save the many, tho [17:43:25] Maryana: no need to sacrifice, just keep it in mind while telling the bot-runner :) [17:43:48] The problem with using Information templates though is we haven't solved the friendly photo uploads descriptions [17:43:49] jdlrobson: also do resist the temptation to write up the bot yourself in a bit of python and let it run. Bot accounts need community permission, and doing otherwise might get you banned :) [17:44:13] jdlrobson: i suggested a workable solution to jgonera, he said he'll investigate it [17:44:19] * jdlrobson has no interest in writing a bot which seems like a waste of time considering the information is IN the page [17:44:42] I think this deserves an RFC Maryana personally this seems fundamentally broken [17:44:45] jdlrobson: jsut general infiormation :) [17:45:04] i totally agree, jdlrobson [17:45:11] How is added a line "Source: jdlrobson" programmatically useful [17:45:18] * jdlrobson feels like he's in the India school system [17:45:32] jdlrobson: IIRC it is a legal requirement, not a technical one [17:45:37] yuvipanda, what's the bot herder channel? is it #wikipedia-bag? [17:45:43] jdlrobson: because using that template makes it part of the policing system, which is important. [17:45:55] YuviPanda: but if we are doing that programmatically it's not typed by the user [17:45:58] Maryana: I am unaware if there is one. legotkm hangs out in -en and in -commons, which is where i usually find him [17:46:12] jdlrobson: well, you do have a 'i accept this is mine' thing [17:46:23] ok, time to rustle me up some bot herders :) [17:46:28] people rely on the structured form of the information to identify bad images. Obviously it gets done crappily sometimes, with collateral damage like we see here. [17:46:35] The template should be able to pull this data from the page though [17:46:59] jdlrobson: the fundamental problem is that commons is using mediawiki, which is fitting a nuclear bomb into a square hole. [17:47:03] jdlrobson: will be very painful. [17:47:03] this is like the 4 tildes thing - these kind of things really irk me [17:47:09] haha [17:47:14] *tildas [17:47:27] Who's Tilda? [17:47:38] :) [17:48:08] ~ [17:48:18] * jdlrobson can't locate the why mediawiki why meme image :( [17:48:29] o_~ [17:49:00] :D [17:49:15] jdlrobson: the app solves this problem by not surfacing description anywhere ;) [17:49:26] jdlrobson: and this was also why I kept title and description separate. [17:49:37] whoa, big Android spike today! [17:49:45] new version FTW! [17:49:48] really? I saw only 777 [17:49:57] and my connection is so fucked up [17:50:01] nevermind [17:50:01] that reportcard takes ages to load [17:50:02] bleh [17:50:03] web spike [17:50:10] what's that from? [17:50:10] yeah [17:50:11] web spike :) [17:50:19] ragesoss: they pushed out a more visible CTA yesterday [17:50:30] ah. visible when logged out? [17:50:33] was that it? [17:50:47] ragesoss: unsure, Maryana might be better able to fill you in :) [17:51:01] I did notice the "add an image" button even while logged out. [17:51:06] ah yes [17:51:08] while making screenshots for my brochure. [17:51:15] :D [17:51:18] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/57197 [17:51:22] Maryana: are you finding bot herders somewhere? [17:51:39] jdlrobson: you can get rendered HTML of the commons page and pick the data you want out of it via commons.wikimedia.org/wiki/Commons:Machine-readable_data [17:51:42] https://commons.wikimedia.org/wiki/File:Uploading_a_shaggy_dog_photo_on_mobile_-_3.png [17:52:04] ragesoss: there's a small spike in android too [17:52:14] but yeah, web has major spike [17:52:15] yuvipanda, yeah, chatting w/legoktm [17:52:20] Maryana: okay [17:52:26] Maryana: where, btw? [17:52:28] yeah, from yesterday. and now 30 day total is over 800. [17:52:54] ragesoss: yup [17:53:22] ragesoss: screenshot of mobile web upload uploaded via app :) [17:53:25] just pm [17:53:38] nice [17:53:46] ah, oay [17:53:48] *okay [17:54:15] hello legoktm [17:54:16] welcome :) [17:54:20] o/ [17:54:28] \o [17:54:38] legoktm: no exam today? [17:54:38] nope :D [17:54:40] not till next week [17:54:46] nice :) [17:54:48] greetings :) [17:54:51] * YuviPanda has a project report to submit tomorrow, bah. [17:55:09] ragesoss: i overlooked the fact that i'm adding {{subst:unc}} even if they have categories. bah [17:55:11] sooo, yeah, i just laid out the sad situation we find ourselves in to legoktm [17:55:43] YuviPanda: isn't that necessary? [17:55:47] they upload before cats are in. [17:55:57] ragesoss: yeah, but what i should do is to remove that when I add cats [17:56:04] yes. [17:56:12] filed a bug though. will fix for next week [17:56:12] 's [17:56:17] [[Category:Uncategorized cat photos]] [17:56:29] best category ever. [17:56:33] Maryana: are you planning on doing an RFC? [17:56:52] cats, plus self-contradiction. [17:56:56] welcome to the internet. [17:56:59] http://en.wikipedia.org/wiki/Category:Lists_of_fictional_felines wtf [17:57:07] awjr, so how can I help you with 462? [17:57:15] MaxSem: talk in a bit, in a mtg [17:57:20] sure [17:57:21] brion: I started posting weird-but-sourced wiki articles on my blog, also coming through to planet. [17:57:27] nice [17:57:30] brion: today's was 'toilet related deaths' [17:57:35] hey, no fair. that cat doesn't exist, brion. [17:57:43] brion: tomorrow's is 'puppy pregnancy syndrome' [17:57:47] wiki is a wild place [17:57:51] list of dictionary categories.... [17:57:53] *fictional [17:57:56] wtf autocorrect [17:58:03] yer spoling my jokes [17:58:09] list of fictional dictionaries [17:58:09] haha, list of dictionary categories [17:58:10] yuvipanda, possibly. i just want to make sure we save the mobile uploaders from certain death in the short term first [17:58:19] Maryana: hmm, okay :) [17:59:09] good luck folks -- i'm going to rustle up something in the kitchen, find my glasses, and bang on api account creation until it bends to my will [17:59:19] a short-short term fix might be a little more explicit pressure on XenonX3: we're going to fix this, but for now, please stop tagging the mobile uploads for deletion unless you specifically suspect one. [17:59:23] Maryana: some of these images dont even have {{information}}? https://commons.wikimedia.org/w/index.php?title=File:Eksempel_p%C3%A5_s%C3%B8kemotor_2013-04-03_16-12.jpg&action=edit [17:59:34] from a (WMF) account [17:59:42] legoktm: *none* of them have {{Information}} [17:59:49] o.O [17:59:52] ragesoss, more explicit as nuking him from the orbit?:P [17:59:52] well. [18:00:07] his makes it a bit harder... [18:00:07] MaxSem: well, no. [18:00:07] this* [18:00:12] that might have... repercussions. [18:00:41] legoktm: some of them do not have the tracking category either [18:00:42] DELETE FROM user WHERE user_name='XenonX3'; [18:00:58] YuviPanda: well i cant do much about that... [18:01:08] no repercussions, this operation is p-erfectly indexed and will be executed fast [18:01:12] ah, I guess I didn't appreciate how high up orbit is. [18:01:24] you shouldn't have said anything in a public channel, though. [18:01:37] now if you delete them from the database, someone will probably trace it back to you. [18:01:39] yeah, my sense of humor is failing me [18:02:01] otherwise it could be like 'oh, we don't know why your account disappeared, we'll look into it right away' [18:02:45] legoktm: they were tagged with a revtag, though [18:02:52] revtag? [18:02:55] oh [18:03:01] yeah, don't worry about the ones not in the category, yuvipanda, legoktm - i can find them from the revtags and manually add {{information}} [18:03:08] there aren't that many [18:03:36] all hail Maryana, defender of the uncategorized! [18:04:49] Maryana: do you want to cancel the design syncup to fight this fire? [18:04:50] or? [18:05:05] yuvipanda, yeah just checked w/vibha - can we do it later today? [18:05:15] Maryana: how later? [18:05:40] I just found a file called "You Only Live Once" >.< [18:05:43] oh, boo, that's right. it's like 0 o'clock for you [18:06:06] Maryana: well, I do sleep at 4am :P [18:06:06] so [18:06:14] it's okay, as long as you can give me a time estimate beforehand [18:06:16] Maryana: most have {{Uploaded from Mobile|platform=Web|version=}}, will any of them have a version set? [18:06:20] so I can figure out sleep patterns appropriately [18:06:25] legoktm: they won't [18:06:29] would 12 our time work? [18:06:34] Maryana: splendid [18:06:40] thank you!! [18:06:51] legoktm - we thought about including the author/source stuff in there [18:07:00] in that extra param [18:07:08] not sure if that meets commons stringent guidelines, tho [18:07:11] legoktm: also, that template is used for platform=Android / platform=iOS as well. Those have proper {{Information}}, however. [18:07:24] Maryana: we can't actually do that, hough. [18:07:40] Maryana: since author needs to be the author's username, IIRC, and we can't programatically obtain that in templates [18:07:47] hmm, might be possible via Lua, though - I haven't looked [18:07:58] blah, right [18:09:05] well, worst-case scenario - i drink a lot of coffee and stay up all night tagging mobile uploads by hand [18:09:23] … and then spend 5 minutes every hour tagging new uploads :) [18:09:26] for the next week [18:09:30] just call me maryanabot [18:10:14] :P [18:10:39] hehe, not too loudly, Maryanabot, or someone on Commons will try to ban you for being an unauthorized bot [18:10:39] can i assume that they're all going to be tagged as {{self|cc-by-sa-3.0}} ? [18:10:45] legoktm: yup [18:10:51] oh great [18:11:05] jdlrobson: can you confirm ^ [18:13:36] * YuviPanda wonders if his IRC connection is still active [18:24:07] MaxSem: I just read Mark's response on the ops-l thread about cache control headers for mobile varnish, which clears things up for me. I don't think I need any help at the moment, but I'll letcha know if i do [18:25:39] ok [18:42:45] * StabbyPanda stabs self [18:42:50] * StabbyPanda stabs internet [18:44:28] :( [18:47:23] brion: are you in the office? [18:47:31] home today [18:47:39] brion: ok [18:47:54] brion: are you going to join us for the design retrospective? [18:47:54] need someone poked? [18:47:58] with vibha and maryana? [18:48:03] there's one in about 10 mins [18:48:13] i don't have it on my calendar, but i could [18:48:24] i'll need a hangout link i guess :) [18:49:25] brion: adding you [18:49:30] whee [18:49:39] New review: Jdlrobson; "I can't work out what's going on but there seems to be something funky about the dependencies." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [18:50:59] does anybody remeber what was the cause of last week's mobile site outage? [18:51:32] MaxSem: fundraising turning off cache [18:51:34] I think? [18:51:39] or was that a different outage? [18:51:49] the different one [18:52:13] hmm i dont remember a different one [18:52:45] brion: i've invited oyu [18:52:48] brion: but it doesn't start yet [18:53:02] it 500'd or something as opposed to a simple overloading [18:53:11] oh, the thing witht he watchlist? [18:53:18] StabbyPanda: got it thanks. will log in in … 7 minutes [18:53:28] the watchlist 500s were caused by a PHP fatal [18:54:05] brion: :) [18:54:19] damn [18:54:29] one week has passed and we all forgot it [18:54:39] too much work?:P [18:54:54] hmm, maybe. [18:55:02] * StabbyPanda needs to calm down a little bit more, and actually work only 30h [18:55:12] lol last week felt like… weeks [18:55:22] * legoktm hugs StabbyPanda  [18:55:31] thanks legoktm [18:55:32] <3 [18:58:42] Maryana_intervie: are you still in an Interview? [19:01:16] Maryana_intervie: poke poke [19:02:47] jdlrobson: any sign of Maryana_intervie ? [19:03:48] * brion watches video about NSAttributedString while he waits [19:06:15] awjr, answered RFC, and also, fundraiser team wants to use that lookup for everything - much better than geoIP :) [19:06:35] so it is possible we might even be doing the lookup on the whole wiki :) [19:06:55] geolocate ALL the IPs! [19:06:56] (assuming https://rt.wikimedia.org/Ticket/Display.html?id=4881 is done in a very fast way) [19:07:01] exactly [19:07:14] wikipedia knows where you live [19:07:32] nah, its the collection of ALL knowledge - it knows what you had for breakfast! [19:07:36] and is out to extract consensus! [19:07:38] so beware! [19:07:42] yurik: instagram already knows that [19:07:48] hehe [19:07:54] yurik: intriguing! does this varnish extension already exist? [19:08:05] awjr, yes, its called geoIP :D [19:08:11] oh lol [19:08:21] the RFC says 'similar to geoip' so i thought it would be… different :p [19:08:29] and debian has a generator to create their database [19:08:44] so in reality we could just reuse their code [19:08:45] yeah i think that's already in use for CentralNotice/fundraising [19:08:51] exactly [19:09:04] brb [19:09:04] StabbyPanda: what format should |date= be in? [19:09:50] yo yo brion yuvipanda others who were pinging me [19:09:52] what's up? [19:10:23] Maryana: hey, what format do you want |date= to be in? human readable? iso? [19:10:39] Maryana: you moved the design syncup to this time :P [19:10:46] oh lordy [19:10:49] legoktm: i think so. [19:10:49] sorry :( [19:10:51] crazy day [19:11:07] StabbyPanda: err, so which one? [19:11:19] looking legoktm [19:11:26] it's definitely not human readable. [19:11:35] no i mean [19:11:39] legoktm: iso [19:11:39] yes [19:11:46] what format should it be [19:11:46] when my bot fills it in [19:11:57] legoktm: yyyy-MM-dd [19:11:59] is good enough [19:12:05] ok [19:12:32] yes, that sounds good [19:12:40] thank you, legoktm! [19:12:59] Maryana: you want to reschedule to another day? we don't want to drain all your manna :) [19:13:15] * Maryana checks w/vibha [19:13:26] i'd like to still do it if she can [19:13:36] okay [19:13:40] Maryana: me and brion are on the hangout :) [19:14:53] d'oh. not hearing from vibha. i think she moved on to bigger & better things [19:15:06] i'm so sorry, brion & yuvipanda [19:15:10] :( [19:15:11] nothing's bigger and better than mobile :( [19:15:19] let's move this to another day [19:15:21] we'll review later no worries :) [19:15:28] ok - sorry to keep you hanging! [19:15:43] literally :) [19:16:01] Maryana: i don't think I can do it this week, have college next few days, so for once I might actually not be able to work friday / thur night [19:16:19] :( [19:16:22] no worries. monday? [19:17:07] works [19:18:29] ok, great :) [19:20:36] New review: Jdlrobson; "Should we rename all the others as well then..?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [19:21:22] Maryana: https://commons.wikimedia.org/w/index.php?title=File:%22Messier_objects%22-_2013-04-02_19-39.jpg&diff=prev&oldid=93919985 [19:21:24] New patchset: Jdlrobson; "Bug 46480: Enable mobile site module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [19:23:09] meh, I clicked legoktm's link a while ago, and it still hasn't loaded yet [19:23:11] * StabbyPanda stabs self some more [19:23:39] :/ [19:24:03] legoktm: looks nice :) [19:24:11] :D [19:24:13] legoktm: but you should probably strip trailing whitespace from the descriptions if you can [19:24:16] oh [19:24:18] thats easy [19:24:31] {{done}} [19:24:46] :) [19:25:17] legoktm: from that diff, it lgtm [19:25:32] hmm, if i get rid of all vowels from legoktm, and then get rid of the k [19:25:34] it becomes lgtm [19:25:35] :D [19:25:36] that category only has ~270 photos, i can do that in like 15 minutes [19:25:37] o.O [19:25:38] haha [19:26:34] legoktm, you're the best [19:26:38] except when yuvipanda is the best [19:26:43] haha [19:26:44] then you get to share "the best" title [19:26:55] half best [19:26:56] :) [19:27:01] :D [19:27:45] ok, here goes [19:28:58] New review: MaxSem; "Ehm, are you proposing to prefix everything with MF?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [19:42:16] Maryana: done! [19:42:20] lemme get the list of ones it missed [19:42:25] you're a life saver! [19:42:40] legoktm: :) [19:42:44] actually looks like ts is down [19:42:55] sigh. as usual. [19:42:57] i was gonna use catscan to find articles in the category but w/o the template [19:43:18] aha [19:43:19] http://bots.wmflabs.org/~richs/catscan_rewrite.php [19:43:22] give me a minute [19:44:32] heh [19:44:35] that one doesnt work [19:54:04] New review: Jdlrobson; "I'm saying we should make a decision to be more consistent." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [19:55:00] Maryana: ohh dear https://en.wikipedia.org/wiki/Ben_Hoffman [19:55:32] erm... [19:55:51] but on a more positive note https://en.wikipedia.org/wiki/Cup_Noodles [19:55:53] jdlrobson: was that for the bears or for the 'undefined'? [19:55:58] StabbyPanda: both :) [19:57:14] jdlrobson: more 'Undefined'? [19:57:15] is that a bug? [19:57:44] StabbyPanda: does appear to be.. will need to look at logs [19:59:07] ihehhee https://en.wikipedia.org/wiki/Shaggy_dog_story [19:59:48] * StabbyPanda tagged bears for deletion [20:00:33] huh http://en.wikipedia.org/wiki/History_of_mobile_phones what happened there with that photo? [20:01:10] btw happy anniversary guys - On 3 April 1973 Martin Cooper, a Motorola engineer and executive, made the first mobile telephone call from handheld subscriber equipment in front of reporters [20:01:21] \o/ [20:01:59] jdlrobson: looks like that's been deleted, and commons delinker hasn't gotten to it yet [20:13:30] https://commons.wikimedia.org/w/index.php?title=File:%22Messier_objects%22-_2013-04-02_19-39.jpg&diff=prev&oldid=93919985 [20:13:35] jdlrobson, awjr [20:41:45] jdlrobson: i just got roped in to covering tomasz for a budget meeting - so i can't be at the gerrit talk [20:41:50] can you wrangle and make sure notes are taken? [20:48:28] Maryana: can you make sure jon sees that ^? [20:49:17] roger - conveyed to jon [20:54:03] thanks! [21:03:22] brion: are you joining us for the hangout? [21:03:29] yurik, are you with us? [21:03:38] yurik: ? [21:03:40] hi [21:03:42] joining [21:05:04] nope enjoy it though guys :D [21:05:06] gerrit is the bomb [21:05:18] for various definitions of 'bomb' [21:13:53] yurik: MaxSem http://etherpad.wikimedia.org/kAKhhwCsJ7 [21:17:53] New patchset: Catrope; "Set defaultrebase=0" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57421 [21:45:27] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57421 [22:20:48] tfinc, around? [22:21:14] yurik: he should be on a flight right now [22:21:27] oh, i guess someone else logged in as him ;) [22:21:30] yurik: interesting, I wonder how it is onlyine when his laptop is stolen :| [22:21:43] exactly ;) [22:21:45] yurik: he doesn't use a bouncer [22:21:58] my home desktop is always logged in [22:21:59] yurik: i remember him telling me that he setup LimeChat with autoauth [22:22:10] that's how i'm online [22:22:16] then i can always remote in [22:22:16] yurik: should we report this to someone? [22:22:49] well, do we know its not him? [22:22:55] you want to do an ip trace? :) [22:23:00] yurik: from facebook I know that he's lost his laptop [22:23:08] and that he's on a flight about now [22:23:21] Maryana_brb: awjr ^ [22:23:22] yeah, i heard about it, but he could have logged in remotelly into his home somehow [22:23:36] yurik: well, he hasn't responded today [22:23:38] or used a browser [22:23:38] nor did he yesterday [22:24:07] is he even alive? maybe someone captured him and wrestled his IRC password...? [22:24:22] [22:24:34] or maybe he is just too busy planning for his honeymoon :) [22:25:17] not according to facebook :) [22:25:21] he was too busy getting duplicate passports [22:25:28] New patchset: Dr0ptp4kt; "Currently, the dismiss button "X" in zero-rated displays overlays the text of carrier verbiage. Changing from absolute positioning to float appears to result in the same visual rendering as today, but without the unintended overlay." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57432 [22:27:45] ^ jdlrobson, you mind taking a look? i'll forward you some screenshots showing the current bug. [22:28:50] yurik: meh, I guess nobody cares. [22:29:25] YuviPanda, who manages IRC host? can we decloack him? [22:30:11] unsure [22:30:13] let me poke Leslie [22:32:01] yurik: connected since before he left [22:32:06] so hopefully home machine :) [22:33:02] darn it, and we could have found out the IP of his secret evil hideout [22:34:33] just get him on Skype :) [22:35:16] mhurd: are you opening a new pull req for the updated version of the animation? [22:36:52] (just asking in case you wanted to push updates to the same pull req, there's some tricks for it) [22:37:51] was about to, but found that if the button animation happens during the device rotation animation period things get weird [22:38:07] heh [22:38:08] yurik: it's been on for 6 days [22:38:12] yurik: and only on -mobile channel [22:38:24] tfinc: so I guess it's on his home box [22:38:26] yurik: ^ [22:38:34] mhurd: maybe detect when rotation starts and cancel the animations... [22:38:48] * YuviPanda goes to sleep [22:38:56] YuviPanda, gnight [22:39:29] nini [22:40:58] i tried that, but canceling at that point would return the buttons to the correct pre-rotation locations, but those locations are not correct for post-rotation, so still wonky… [22:41:03] i have idea though... [22:41:48] maybe we should just position them manually [22:42:02] they get kind of 'widely' spaces on landscape or iPad now anyway [22:42:47] could do that, or i could cancel the autorotate in the rare case that it occurs while the button animation is in progress... [22:43:14] then we wouldn't have to worry about manual positioning [22:43:45] oh i have another idea... [22:45:05] ooh [22:45:42] hey brion, how would you feel about being the voice of the apps team in a video walkthrough of the android app? :) [22:45:58] communications want to put together a video for the play store [22:45:59] i'll break out my Announcer Voice [22:46:03] hehe [22:48:13] New patchset: Jdlrobson; "Rewrite commons description as template, use Information template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57434 [22:48:16] ^ Maryana - fixes templates [22:48:23] w00t! [22:48:46] who do i bribe to get us a deployment window this week? [22:48:55] * jdlrobson shrugs [22:49:01] zz_YuviPanda: wake up! [22:49:04] you cannot sleep! [22:49:05] hehe [22:49:06] :D [22:49:24] awjr, maxsem - around? [22:49:38] Maryana: https://bugzilla.wikimedia.org/show_bug.cgi?id=46652 [22:49:42] it's not a bug :( [22:50:02] what's the best way to deal with disagreements with how we are doing something? Ask to start a wikitech discussion? [22:50:42] actually I think his bug is about the keyboard not staying open [22:50:45] wait, so it's closing the keyboard on ff for android? [22:50:50] that's weird [22:51:48] i think what he's complaining about is not the full-screen search, but the fact that his keyboard disappears, jdlrobson [22:51:57] yeh i think so Maryana but he also mentions desktop [22:52:18] I *think* what that means is mobile view on desktop [22:52:20] but i could be wrong [22:53:19] mhurd: should work though (can't pm you for some reason it says you're offline) [22:53:21] yeah, from his screenshot it just looks like keyboard disappears and there's no cursor to search, so he can't use search at all [22:53:31] jdlrobson ^ [22:53:39] just sounds like a firefox bug to me [22:54:08] mhurd: if we cancel the auto-rotation does it happen again after a bit? or does the user go "oh it didn't take, let's try again" (probably an acceptable failure mode) [22:55:45] Maryana: yep, just got out of a mtg [22:55:47] wassup? [22:56:04] * awjr reads backscroll [22:56:52] just wondering if we can grab a deployment window this week [22:57:01] for https://gerrit.wikimedia.org/r/#/c/57434/? [22:57:03] to deploy the fix to mobile upload templates [22:57:04] yep [22:57:18] i think it's too late today since that still needs review/testing/etc [22:57:23] lemme look for tmrw [22:57:28] is Max arround? [22:57:48] awjr: I had a thought which might help with his startup module woes [22:57:51] he dropped off about 10 mins ago jdlrobson [22:57:54] prolly past his bedtime [22:58:02] yeh i don't blame him [22:58:05] totally, though that rarely stops him :p [22:58:31] so awjr i had a good idea.. [22:58:32] so tomorrow afternoon is 'lightning deploy time' [22:58:36] unfortunately, greg is not around today [22:58:39] oh actually [22:58:40] … we make our own startup module [22:58:42] greg-g yt? [22:58:54] don't see him at his desk [22:59:03] he sent a mail saying he had jury duty [22:59:08] but wasn't sure what came of it [22:59:11] ah [22:59:15] * Maryana checks the kitchen [22:59:47] meh, i'll email him, i imagine we can slot this for lightning deploy or some other itme tmrw afternoon [22:59:58] yeah, don't see him [23:00:00] sounds good [23:00:02] thanks, awjr! [23:00:09] jdlrobson: and use that instead of regular startup, or in conjunction? [23:00:14] np marktraceur [23:00:15] er [23:00:18] Maryana [23:00:21] haha [23:00:23] poor mark [23:00:27] :p [23:00:34] i think he's done it to me, so we 're even [23:00:38] so awjr $scripts = $this->makeResourceLoaderLink( 'startup', ResourceLoaderModule::TYPE_SCRIPTS, true ); [23:00:49] this line basically sets the startup module to the module called startup [23:01:00] I suggest changing that to $scripts = $this->makeResourceLoaderLink($this->startupModuleName, ResourceLoaderModule::TYPE_SCRIPTS, true ); [23:01:18] jdlrobson: so you could variably have different startup modules [23:01:26] we can then do class MFResourceLoaderStartUpModule extends ResourceLoaderStartUpModule { [23:01:31] $this = a ResourceLoader obj? [23:01:47] a class [23:01:56] so we could create a module mobile.startup that has class MFResourceLoaderStartUpModule [23:02:44] Maryana: I'm used to it by now [23:02:56] hehe [23:03:41] awjr: Some clients will have a choice between "last to speak" and "alphabetical" in the tab-completion settings [23:03:43] jdlrobson: i think that makes sense though you may have to convince Krinkle [23:03:46] jdlrobson, good response on the bug :) [23:03:55] interesting marktraceur [23:03:56] * awjr looks [23:04:16] What would mobile.startup do different than startup? [23:04:41] awjr and brion, do you happen to know if historically the mDot experience for Zero partners has allowed content upload? yurik, if you remember discussion on this, feel free to chime in. i think it's supposed to be "read only", but i can't remember. [23:04:49] So Krinkle for instance we have config variables that should not be surfaced on desktop https://bugzilla.wikimedia.org/show_bug.cgi?id=44133 [23:04:58] dr0ptp4kt: no [23:05:09] we don't use certain config variables surfaced on desktop [23:05:12] dr0ptp4kt: i mean, i don't know, but we haven't supported uploads in the mobile experience until very recently [23:05:21] i don't know fi there's any notion that it *should* be read-only, it just happened to be//// [23:05:31] ya [23:05:47] jdlrobson: What you don't use is irrelevant because there is no 'we'. Assuming mobile won't stay in isolation for ever the envirnoment needs to be reliable and consistent. mw.config is shared. [23:05:53] the rules we are introducing for mobile isCompatible seem unfair to force as a penalty on desktop users [23:06:05] i don't think dfoy said anything about this restriction. I think the intention was even to support zero editing at some point [23:06:17] jdlrobson: An extra one for mobile makes sense indeed, though you may want to put that in OutputPage / MobileSkin instead. [23:06:18] seems easier [23:06:23] marktraceur: my client appears to support no such thing :( [23:06:24] i can just see zero editting over USSD... [23:06:39] yurik: lol [23:06:47] awjr and brion, thanks. i'll through that to dan as a research question. for the moment i'm going to try to upload a file while spoofing. [23:06:51] ^ (which will work) [23:06:52] Aw. [23:07:02] awjr: I think it's default in irssi, and XChat definitely has it. [23:07:14] Krinkle: 'an extra one for mobile' - extra startup module or extra isCompatible function ? [23:07:25] im using adium, marktraceur - im googling for more details [23:07:42] jdlrobson: neither, extra mw.config. That's what you were talking about. [23:07:49] I figured it was something like that, though I wasn't sure what "Purple IRC" is [23:07:51] yurik, when i was a boy, we did all base64 and uuencoding by hand on a non-t9 keyboard. and we liked it! [23:07:56] jdlrobson: What about isCompatibe? [23:08:12] Krinkle: https://gerrit.wikimedia.org/r/#/c/55446/5/resources/startup.js [23:08:25] it seems an unfair amount of count to add to the desktop experience [23:08:34] when i was a boy, I used punch cards, thank you very much [23:08:41] and i still remember the paper tape [23:08:45] with holes [23:08:59] it was either 4 or 8 bit encoding [23:08:59] considering these phones will either never visit desktop due to redirects or can't handle desktop [23:09:31] jdlrobson: It is unfair indeed, but that code is not ever getting merged like that. [23:09:35] don't matter where. [23:10:10] Once it is in better condition, I do think we should have it on desktop [23:10:23] because desktop site can be opened on mobile devices too [23:10:36] and not every mediawiki site wants or does have mf installed. [23:10:46] sorry brion! i screwed something up on colloquy [23:10:54] heh [23:11:53] to answer your question yes it would cancel the auto-rotate [23:12:04] Krinkle so the main issues are around polluting the global scope and reducing the amount of code? To be fair Max is a backend guy so I should help the poor guy out [23:12:10] that should be acceptable yeah [23:12:32] jdlrobson: The global scope and amount of code is just implementation detail, that is certainly a blocker but easy to fix [23:12:43] Krinkle: ok i misunderstood - i thought the issue was with the code existing full stop :) [23:12:47] jdlrobson: The main problem is that it is way too generic. [23:12:48] cool. it's pretty hard to reproduce the bug in the first place, so it may never even happen in the wild [23:12:56] Krinkle: sure i'll take a closer look [23:13:16] rare bugs that have little effect are the best bugs :D [23:13:20] jdlrobson: e.g. blacklisting single words is just not an option, [23:15:12] Krinkle: agreed [23:15:19] Remember that this is very low level. It should only blacklist specific browsers and up to a fixed version that are known to not support modern javascript. [23:15:30] the IE < 6.0 is a good example. [23:15:44] Minimal regex, but not simple word match. [23:15:47] jdlrobson: i need to take a break after the endless string of mtgs. i'll be back soon and take a look at that patchset and see about scheduilng a deployment tmrw [23:15:54] thanks awjr [23:16:00] Krinkle: *nod* [23:16:10] i've not had much to do with this patch set but i'll have a go at cleaning it up [23:16:52] brb [23:17:00] jdlrobson: the test cases are nice, but making it not pollute the global scope will make it pretty much impossible to test from qunit. Will need an alternative approach. Probably just stick to a few sample user agents in a comment. [23:17:10] New review: Jdlrobson; "I think we should standardise on whether to call this MobileFrontendDeviceDetectModule or MFDeviceDe..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/56703 [23:22:40] jdlrobson: As for mw.config, I see TimStarling made the same suggestion I just made in https://bugzilla.wikimedia.org/show_bug.cgi?id=44133 . Put it in OutputPage (with addJsConfigVars) from SkinMobile. [23:29:06] New review: Krinkle; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/51604 [23:31:48] New review: Krinkle; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/52270 [23:34:38] jdlrobson: https://gerrit.wikimedia.org/r/#/c/57434/1 looks OK to me. im going to test it shortly [23:34:47] awesome [23:34:50] i agree that should be configurable, but we can deal with it later. [23:34:54] awjr_afk: you use chrome right? [23:35:00] yep [23:35:09] awjr: so i have a few tricks for you to make gerrit nicer [23:35:14] oohoo [23:35:18] tell me more [23:35:28] also, how did the thing with roan go? i was bummed i couldn't be there [23:35:40] so 1) do you still have the etherpad? [23:35:44] yah [23:35:47] i saw you lurking [23:35:56] still am, though i haven'ta ctually looked at it yet :p [23:35:59] my laptop crashed so i lost it - could you ping me it? [23:36:04] also install https://github.com/jdlrobson/gerrit-be-nice-to-me [23:36:08] jdlrobson: http://etherpad.wikimedia.org/kAKhhwCsJ7 [23:36:15] thanks gonna mail that to team [23:36:33] jdlrobson: i've been saving our etherpads on wiki [23:36:40] http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web [23:36:45] see the last section at the bottom [23:37:06] just copy/paste content into a wiki page so it's there FOREVER [23:37:29] although the contents of that pad may be better served on mediawiki.org somewhere in the git/gerrit stuff [23:38:23] awjr: just mailed the team [23:38:30] that should have the useful snippets from it [23:38:41] groovy [23:38:42] yurik: you should update the chrome extension. Just added extra awesomeness [23:39:45] ohhh fancy jdlrobson [23:39:48] i like that [23:40:03] the opacity on jenkins-bot stuff is a bit high though for my taste [23:40:22] but this makes comments *a lot* easier [23:40:23] thanks dude [23:40:35] np [23:40:47] dunno if you saw but it also gives you a comment count without having to open [23:43:50] was syncing up with roan useful? [23:48:27] jdlrobson: ^ [23:48:45] awjr: yup the highlights made it worthwhile to me. I still hate gerrits ui though ;-) [23:48:55] hehehe you are not alone. glad to hear it tho [23:49:26] hate leads to the dark side [23:50:07] do not underestimate the power of the dark side [23:51:45] awjr: we need to standardize on names for modules [23:52:08] sounds reasonable [23:52:11] make a proposal! [23:52:24] see discussion on https://gerrit.wikimedia.org/r/#/c/57216/ [23:52:27] currently me vs Max ;-) [23:53:04] * jdlrobson has to go soon to grab his Dad and show him around the office [23:53:32] jdlrobson: draft something up, stick it on http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web/Engineering_conventions and let's vote or consense or something [23:54:13] jdlrobson: say hi to your dad for me! [23:58:56] ok will do! [23:58:59] gotta fly :)