[00:11:38] hey brion i got the not-rotate stuff finished - had to delegate the "shouldAutorotate" method's decision from the root nav controller to the top-most view controller. nice as now any presently visible view controller can easily make a rotation decision in the future if needed [00:17:19] New review: awjrichards; "LGTM and tested locally with imported templates from Commons. Code looks OK but would like at least ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/57434 [00:36:32] [Commons-iOS] montehurd opened pull request #33: Animate the take and choose picture buttons to and from their locations. (master...bug45463) http://git.io/OOf_5g [03:30:32] New patchset: Yuvipanda; "Rewrite commons description as template, use Information template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57434 [03:31:43] New review: Yuvipanda; "lgtm, made minor fixes to the template for consistency with how it is generally used." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/57434 [07:02:59] New review: MaxSem; "After further thinking, the class name should match the module name: MobileDeviceDetectResourceLoade..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [08:12:11] yurik, do you ever sleep? [08:17:44] MaxSem, yeah, on ocasion [08:18:01] what's wrong with PHP namespaces? [08:18:08] Syntax! [08:18:09] (i haven't used them much yet, just know they are there) [08:18:11] lol [08:18:14] is that all? [08:18:17] IT HURTS MY EYES [08:18:37] you should be explicit in your emails when you critisize them, i thought it was something much more substantial [08:18:44] spacing in PHP hurt my eyes even more [08:18:50] (in our MW php) [08:19:12] spacingg is something you can live with [08:19:34] but when you see Winwows paths in your code you rick shits [08:19:44] *brick shits [08:20:10] i think you mean shit bricks [08:21:00] no, shitting bricks is too mild [08:21:49] i'm soooo not getting into the semantics of this [08:35:49] mumble mumble PHP is a crime against humanity [08:38:40] StabbyPanda, nah, we already covered that topic [08:39:21] and i still think you should be named pandamonium [08:41:51] suggestions as to what use instead of PHP? [08:42:06] node.js? [08:42:16] bingo! [08:42:18] (i haven't used it, just heard semi-positive) [08:42:21] it's even worse [08:42:26] Well, at that point I guess it was PHP or Perl [08:42:38] but I guess if we were starting right now, we'd be either Python or Ruby [08:42:46] meh [08:42:57] Python's OOP is a joke [08:42:59] not really, even c# was already there, albeit a bit crooked :) [08:43:22] PHP is a joke [08:43:31] RUST is the way! [08:43:38] and Ruby's gem dependency system is FUBAR [08:43:48] (according to mozilla) [08:44:12] StabbyPanda, but PHP's OOP is borrowed from Java and is relatively nice [08:44:21] Java and Nice in the same word? [08:44:39] * yurik pukes bricked shits [08:44:41] (at least for my irreversibly damaged by C++/C# brains) [08:44:41] MaxSem: Python's OOP is more than good enough to do what you would want [08:45:12] C# is awesome! [08:45:16] post 3.x at least [08:45:22] StabbyPanda, selfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfselfself [08:45:35] welcome to Python! [08:45:36] didn't we have this talk a few days back? [08:45:47] did we? [08:45:57] we didn't if i wasn't present [08:46:37] MaxSem: better than Javascript's implicit self [08:47:12] var that = this; [08:47:16] welcome to Javascript! [08:47:40] ok, I think we all agree that the best language ATM is C#, with occasional Managed C++ DLLs [08:47:47] * yurik hides [08:48:13] C# is awesome indeed but .NET has turned into J2ME hell of its own [08:49:08] every complex system tends to overbloat with versions. See DOS -- 3.3 was awesome, and it all went downhill from there, ending in Windows ME [08:49:17] horrible! [08:49:43] they had to rewrite from scratch -- NT [08:49:57] ...and ended up with Vista [08:50:08] Nah, that was a detour [08:50:12] Win7 rulez [08:50:21] ...unlike 8 [08:50:33] (as I heard:P) [08:50:47] MS is on one off cycle - one good, one bad [08:51:36] 3.5 - bleh, 4 - okish (they had 6+ service packs, so hard to count), 2000 meh, XP ok, Vista - bleh, 7 - good, 8 - bleh [08:52:42] was there a NT 3.1? [09:03:00] MaxSem, yeah, actually there was 3.1, which was crap, and 3.5, which was actually more or less usable [09:03:36] or i shouldn't say that - i started using 4 [09:04:04] is there a good IRC client for macs? [09:04:13] need to use it on my loner [09:08:23] what, did you betray Windows? [09:09:02] need to buy a laptop [09:09:05] not sure which yet [09:09:25] need to go to s affrica for a trip, and my old lenovo has 40min bat life :) [09:09:46] XPS13 Dev Edition [09:10:11] not a big fan of dells tell you the truth [09:10:16] have tehy improved much? [09:14:15] it's a 100% open source ultrabook [09:19:10] MaxSem, philosophy is fun, but i need to be productive too ;) [14:55:11] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57434 [16:03:55] legoktm: I don't know how many images it affect (probably very very few), but your bot didn't handle uploads that had been manually updated with {{information}} already. [16:04:13] didn't handle *well* [16:04:31] It nested {{information}} inside {{information}} [16:04:43] (just in case you're going to run in again in the future) [16:41:58] New review: Brion VIBBER; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57434 [16:46:15] New review: Brion VIBBER; "Works as expected on my local test instance. Let's +2 this!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/57434 [16:46:15] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57434 [16:49:40] New review: Jdlrobson; "probably want to use padding right as nothing is clearing this float. Also you'll need to edit the l..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/57432 [16:58:21] * brion gonna watch the Facebook mobile announcement, see if there's anything cool [17:02:03] New patchset: MaxSem; "Rewrite commons description as template, use Information template" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/57525 [17:02:51] MaxSem: ??? ^ [17:03:04] preparation to deploymet;) [17:03:14] OH [17:03:17] branch: productin [17:03:27] * awjr goes for more coffee [17:03:42] \o/ [17:04:02] MaxSem: i was just doing the same thing - should i just start assuming you'll handle the deployments unless you tell me otherwise? [17:04:10] sure [17:04:15] cool :) [17:07:12] hey awjr [17:07:17] whattup YuviPanda [17:07:34] can you point me to where the config variables are for MF? [17:08:13] operations/mediawiki-config.git [17:08:26] YuviPanda: actually - did you mean in production, or in general? [17:09:08] if production, checkout that mediawiki-config repo, and look in wmf-config/mobile.php [17:09:20] most of the config vars are controlled by settings in wmf-config/InitialiseSettings.php [17:09:24] by ultimately set in mobile.php [17:09:39] s/by/but [17:12:03] awjr: okay, at my current speeds a checkout is going to take forever :( [17:12:19] YuviPanda: what are you looking for specifically? you could also use gitweb [17:12:25] awjr: can you add {{subst:unc}} to wgMFPhotoUploadAppendToDesc [17:12:25] or i could just find it for you :) [17:12:44] what does that do, YuviPanda? [17:12:46] * brion stabs mark zuckerberg with a wtf-bat [17:12:56] ruhroh [17:13:01] awjr: it adds it to the backlog for images needing categorization [17:13:01] what did he do this time brion? [17:13:15] YuviPanda: ok gimme a few minutes [17:13:22] if i'm understanding correctly, the new 'Facebook home' for android is just the least space-efficient Facebook news reader possible [17:13:59] >_< [17:14:07] but it runs on your lock screen! [17:14:28] lol [17:14:29] yay? [17:14:56] YuviPanda: were you hoping for that config change to happen during today's deployment? [17:15:03] awjr: yes, I am :) [17:15:06] k [17:20:05] YuviPanda: like this - https://gerrit.wikimedia.org/r/#/c/57528/ ? [17:20:48] awjr: \n between those? :) [17:20:50] lgtm otherwise [17:20:53] awjr: and thanks :) [17:20:57] np YuviPanda [17:21:06] awjr: I just figured I should get a little bit more involved with some of the commons stuff [17:21:34] YuviPanda: totally :) does Maryana know about that change? [17:21:45] awjr: I'll mail out now [17:22:03] the app has been doing this for a while, and it's been appreciated by the commons folks [17:22:41] ok cool - i just want to make sure she knows before that goes out [17:28:53] so…. Facebook home has a lock screen/home screen, and an overlay for chat that sits on top of your other apps. eh, i'm not that impressed. might play with it though [17:29:40] what should i know about, yuvipanda? [17:29:53] Maryana: hello! [17:30:00] just typing out an email [17:30:11] ah, k - no worries, don't let me stop you [17:30:19] Maryana: but, https://gerrit.wikimedia.org/r/#/c/57528/ adds all mobile uploads to the 'images needing categories' backlog in commons [17:30:31] oh, nice! [17:30:33] tiny change, but it's been in the apps and the communtiy appreciates it [17:30:42] yeah, definitely [17:30:59] and it prevents new users from getting their first talk page message from a bot that yells at them to add categories to their upload :) [17:31:13] thanks, yuvipanda [17:31:14] Maryana: yes, that too :) [17:34:20] YuviPanda: it looks like a new line will get added a literal \n [17:34:48] awjr: ? [17:34:49] oh [17:34:49] damn [17:35:14] im not sure why, perhaps because of how the template works [17:35:21] (internal template, not wiki template) [17:35:26] awjr: is that because of single quotes vs double quotes? [17:35:37] no YuviPanda, i've tried with both in my local config [17:35:42] bleh. [17:35:50] im glad i dbl checked :p [17:35:53] i think that's okay awjr, but let me confirm [17:35:56] :D [17:35:58] woah - check out the second graph from the top: http://toolserver.org/~dartar/reg2/ [17:36:19] that looks like a legitimate hockey stick. [17:36:41] that is wild. [17:37:15] :) [17:37:53] awjr: I just verified, it's okay to not have a newline [17:37:59] cool YuviPanda [17:38:06] doesn't mess up the layout, etc [17:38:12] good [17:38:15] so https://gerrit.wikimedia.org/r/#/c/57528/1 is ok as-is? [17:38:43] we should file a bug that \n is being handled to literally [17:38:45] *too [17:38:57] awjr: yup, i'll add a +1 [17:39:03] gr00vy [17:39:15] MaxSem: can we get https://gerrit.wikimedia.org/r/#/c/57528/1 deployed today as well? [17:39:52] yeah, I already added it to my list [17:39:57] also, miracle of miracles, the commons patroller who tagged all those files is actually being nice(ish) to me [17:40:13] awesome MaxSem [17:40:17] yay Maryana! [17:41:02] goal for Q4: at least 10 smiley faces from commons patrollers [17:41:09] 1 down, 9 to go [17:41:13] :D [17:45:37] hehehe [17:51:07] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=46897 [17:51:19] * YuviPanda clicks [17:51:32] sweet, thanks awjr [17:51:40] np YuviPanda [18:12:34] gawd i just saw "Departure Arthur Richards" - I keep thinking everyones leaving because of ryan's choice of email subject :) [18:12:49] Noooooo [18:13:05] jdlrobson, heh me too:))))))) [18:14:56] dr0ptp4kt: yurik - i can't seem to get zero working on a local instance right now [18:15:20] jdlrobson, its ok, noone can [18:15:29] what's the issue? :) [18:15:29] jdlrobson, did you set X-Carrier? [18:15:36] I got it to work once. Mostly [18:15:53] brion_, then it collapsed after 5 minutes? [18:16:12] yeh MaxSem in htaccess - RequestHeader set X-CARRIER "Orange Ivory Coast" [18:16:14] you guys are gonna make me make it work, aren't you? [18:16:31] yurik: i've enabled it and just want to see a banner [18:16:52] &renderZeroRatedBanner=true has no effect [18:16:53] does it show the red banner? [18:17:15] jdlrobson, there is a very weird local settings on the labs instance, that somehow makes it all work [18:17:23] i will have to figure out all the settings there :) [18:17:32] yurik: no banner at all [18:17:46] did we break something? [18:17:52] hope not [18:18:20] jdlrobson, i need to set up my own instance to get a better handle on all localsettings [18:18:36] hopefully i will have it in a few hours, will tell you what i get [18:19:02] ok cool [18:19:07] very confused.. used to work fine for me [18:21:43] New review: Brion VIBBER; "Also double-check how this looks in Arabic... :)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57432 [18:22:39] yurik: mm it's not showing as an installed extension.. [18:22:45] Maryana: your last edit to commons vp was as 'mobiletesttest' :) [18:22:46] that's probably why.. [18:22:48] (assuming it is you) [18:22:50] i know [18:22:51] haha [18:22:53] just realized [18:23:02] whoops :) [18:23:11] yurik: me stupid ;-) [18:23:15] * YuviPanda has VP on watchlist and email notifications enabled, not always a good idea :) [18:23:32] jdlrobson, that's what I WAS HERE FOR :) [18:23:40] ;-) [18:36:13] nice preso Maryana :) [18:36:18] thx d00d [18:44:35] jdlrobson, awjr, jgonera: can we come to a quick conclusion re class names? [18:44:59] MaxSem, I just started reading the thread on mobile-tech [18:45:11] MaxSem: is this a blocker for something? [18:45:30] for common sense:P [18:46:00] lol [18:46:27] MaxSem: i would love to and awjr yes it is a somewhat blocker as i said in the email :) [18:46:46] let's not let this be a blocker; we can change class names later. [18:47:04] so I'm not quite sure where is the problem in terms of PHP, we don't seem to be using any prefixes in class names, and we use CamelCase which seems to be standard in PHP [18:47:42] oh, we do use the prefix in RL [18:48:08] jgonera, not exactly: it's 1:1:) [18:48:53] well, I wouldn't prefix everything, but ResourceLoaderModule doesn't exactly describe what the class purpose is [18:49:19] \MediaWiki\Extensions\MobileFrontend\TemplateResourceLoaderModule [18:49:42] * MaxSem throws a bucket of holy water at brion_ [18:49:50] It burrrrnnssssss [18:50:06] +1 on TemplateResourceLoaderModule though:) [18:50:23] :) [18:50:35] I actually don't think it's that bad as long as we can alias this long name locally (and yes, I also don't like the backslash) [18:51:39] What's the convention for namespaces in wiki base? Iirc they're the main ext using them so far [18:59:02] brion_, appears to be just one Wikibase NS, shared by 3 their extensions [18:59:30] kinda helps to isolate stuff, but not very "per books" [18:59:49] hungry :( [19:00:00] awjr, I couldn't help myself not to tweak https://gerrit.wikimedia.org/r/57528 :) [19:00:13] and you guys have icecream [19:00:27] * yurik heads out to cry and get icecream [19:01:18] MaxSem: that won't work [19:01:34] do not include the \n character, because it will get added as a literal [19:01:38] even with "" [19:01:47] ? [19:01:51] awjr: \n should be fine in ""… ? [19:02:09] brion i know, i tested this locally though and \n was added as a literal to the description [19:02:16] weird [19:02:23] we'll see:) [19:02:28] MaxSem: Property. Query. 2 [19:03:28] What. Do. You. Mean. [19:04:14] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/57525 [19:04:35] oh i am an idiot, brion, MaxSem - i just dbl checked locally and it does indeed work as expected with "" [19:04:45] :D [19:04:46] i must've checked a previous upload when i had '' [19:04:47] \o/ [19:04:58] happens:) [19:05:26] back in a sec [19:08:05] i dont think i should be allowed to do anything until i've had my required coffee intake [19:08:23] thanks for the props, Maryana! and nice presentation. [19:08:34] thank you :) [19:08:50] the commons pushback has begun [19:08:55] not sure how hard it would be, but {{commonscat}} represents a lot of good data for auto-categories. [19:09:10] all right, the config change went live! [19:09:14] woohoo [19:09:15] yeah, i should take a look [19:09:36] Maryana: I was trying to not work today, so missed the meeting for the most part :( [19:09:44] you were just finishing up when I tuned in. [19:09:47] will watch the recording though [19:09:57] yep, it's on the interwebz :) [19:10:33] already? [19:10:35] a whole boatload of recent web upload selfies have been nommed for deletion. [19:10:39] you probably saw that, Maryana. [19:10:51] sigh [19:11:09] is tfinc back? [19:11:18] doesn't seem so [19:11:19] i don't think so, yurik - i haven't seen him [19:11:26] ok, so i guess no 1:12 [19:11:29] oops :) [19:11:30] 1:1 [19:11:35] yurik: should be back in the US now but won't be back in the office til tomorrow (though he may be on later this afternoon) [19:11:48] tfinc, what did you do to the real tfinc? [19:11:50] brb, grabbing food [19:12:01] Maryana_food, grab some for me! [19:12:02] yurik: last i heard was that he was hoping to take care of a few things from home this afternoon assuming travel went OK, etc [19:12:13] heh, will see [19:13:36] ragesoss: jdlrobson ooh, I was looking through web uploads, looks like we have our first actual nsfw image [19:13:53] YuviPanda: already had 2 boss [19:13:57] heh [19:15:08] i have to admit, i don't really notice the CTA when it's at the bottom of the screen; i prefer the CTA at the top [19:15:41] the login cta? [19:15:44] yeah [19:15:50] the MF change is live on testwiki, please test a bit:) [19:16:06] yes sir! [19:17:02] can we upload on testwiki? [19:17:10] or do we have to wait for production? [19:17:13] YuviPanda, jdlrobson: links? [19:17:13] man, we should not display the lead images when the images are broken [19:17:22] we can [19:17:25] Maryana: wait for production i think [19:17:31] ragesoss: pm'd [19:17:51] gah. http://commons.wikimedia.org/wiki/File:Hermaphrodite_2013-04-04_14-28.jpg [19:18:27] oh, there it is. the penis we've been waiting for. [19:18:45] yeah, somebody linked to it on the vp discussion [19:18:52] https://commons.wikimedia.org/wiki/Commons:Village_pump#Missing_author.2Fsource_parameters_on_mobile_uploads:_fix_coming [19:18:57] oh actually, i was able to upload from testwiki [19:18:59] that is new [19:19:04] Maryana: ^ [19:19:13] orly? [19:19:15] right after I write [[Selfie]], I'm writing [[Crotch shot]] [19:20:04] actually im not sure anymore [19:20:34] no [19:20:34] strange [19:20:37] i uploaded a photo from uploads dashboard [19:20:43] but it didn't get uploaded to commons [19:20:45] * YuviPanda does some patrolling on the android app uploads [19:20:55] and the file i uploaded links to Special:Uploads, not to the file page [19:21:21] i don't see it in your contribs, but i did just delete one of your test images from the other day, awjr :) [19:21:29] heh thanks Maryana [19:21:36] yeah, it didnt actually get uplaoded to commons [19:21:40] see ^^^ [19:22:22] oh, there's another mobile web penis, too. [19:22:23] Maryana: have you seen https://commons.wikimedia.org/wiki/File:Child_running_through_gravity_illusion_room_at_Children%27s_Museum_of_Pittsburgh.gif? [19:22:24] :) [19:22:43] woahhh [19:22:58] Maryana: ragesoss's kid :) There's an android app that records animated gifs [19:23:14] there are like 100, actually. [19:23:17] none any good. [19:23:18] heh [19:23:27] welcome to Google Play. [19:23:29] Maryana: i just uploaded this from testwiki: https://commons.wikimedia.org/wiki/File:A_test!_2013-04-04_12-22.png [19:23:30] ragesoss: should https://commons.wikimedia.org/wiki/File:Darkness.jpeg be kept? [19:23:32] so it DID work [19:23:45] ragesoss, by the time your kids get to college, they're going to be notable as the most photographed people on commons :) [19:23:53] awjr: that's been working for a while. [19:24:07] ragesoss: it didn't really work a minute ago [19:24:10] Maryana: alongside LiAnna's dog. [19:24:29] awjr: that test image now appears in https://commons.wikimedia.org/wiki/Category:Media_needing_categories_as_of_4_April_2013 and a bunch of other places, so yay for integrating into commons workflows :) [19:24:34] awjr: I uploaded files via test.m a week or two ago. [19:24:41] didn't realize they were going up on Commons. [19:24:59] if you did it via mobile ragesoss it would've gone to commons [19:25:54] mobile uploads from testwiki has been really flaky for me [19:26:02] yeah. I was trying to test the alpha or beta or something. so I went to test, thinking that wouldn't go to commons. then I got deletions in my watchlist, and I was like waaaaah? [19:26:24] the good news is, the changes ew're trying to deploy seem to work [19:26:28] heh ragesoss [19:26:34] Maryana, so should I push the update? [19:26:45] yeah, we can't really test until we go live [19:26:50] YuviPanda: Darkness should probably get deleted at some point, but it's a big fat meh. [19:27:20] i actually really like the Darkness image. [19:28:15] it really is impressively dark, for an actual photograph. [19:28:28] for all we know, it could be a selfie. [19:28:33] awjr: also, if you want to tag a test image properly, add the template {{Test upload}} [19:28:45] YuviPanda: better to do that, or just delete it? [19:28:57] awjr: if you add the test upload one it'll get deleted at some point [19:29:10] awjr: it also adds in a speedy deletion category for you [19:29:11] ok good to know - because sometimes i get distracted and forget to delete it myself [19:29:19] oh, you've deletion rights? [19:29:23] if so then carry on :) [19:29:23] yes YuviPanda [19:29:31] but like i said, sometimes i forget :p [19:29:31] abyoose! [19:29:40] :) [19:30:56] ragesoss: went through all the app android pics, only needed to tag a few. [19:31:05] ragesoss: that's sad, since that means not many new people are trying it out :( [19:31:24] well, it's not very discoverable yet. [19:31:32] we need to do actual publicity. [19:31:49] done, MaxSem? [19:32:25] ragesoss: yeah, and I don't think we've much plans on that yet [19:33:34] How do you edit a pull request on github? [19:33:44] Or rather, amend a change that's in your PR.. [19:33:53] deployed [19:33:58] Maryana: http://www.huffingtonpost.com/2013/02/27/sloth-selfie-photo_n_2776228.html [19:34:21] hahaha [19:34:27] YuviPanda: how many installs per day usually? [19:34:37] Reedy: you just add a new commit to the branch [19:34:42] Reedy: and push to the branch [19:34:43] Taa [19:34:48] Reedy: no amending business. [19:34:54] Reedy: GitHub doesn't like force pushes [19:35:11] Reedy: when i checked yesterday we have around 400 active installs [19:35:15] that is people who haven't uninstalled [19:35:32] looks good, MaxSem, jdlrobson, jgonera, YuviPanda: https://commons.wikimedia.org/wiki/File:A_test_upload-_--Test_upload--_2013-04-04_12-35.png [19:35:58] awjr: \o/ [19:36:35] awjr, why is date empty? [19:36:39] epic win? [19:36:59] jgonera: it's part of the template but we're not supplying a value for it [19:37:02] ok [19:37:21] we could though [19:37:46] should we now assume that this template will be used in all uploads and try to parse it when showing descriptions in the dashboard? [19:38:08] may have been an oversight, but it wasn't in the story - i presume it's because we wanted to make sure we were hitting the bare minimum requirements for commons [19:38:20] yes [19:38:38] ok [19:38:49] awjr: it's also sortof hard - date is supposed to be date where the image was taken, *not* date image is uploaded [19:39:00] isnt that in the exif? [19:39:20] office wifi, grr [19:39:38] awjr: for most, yes. [19:39:54] mobile uploads looking good! [19:40:13] awjr: there's another template {{According to EXIF data}} to denote that a date is extracted from EXIF [19:40:13] the only bummer is raw templat text in the descriptions on the dashboard [19:40:25] so many templates! [19:40:32] awjr: :D [19:40:52] im gonna grab some lunch, bbiab [19:41:28] awjr_lunch: https://commons.wikimedia.org/wiki/Template:Information has plenty of information [19:41:38] New patchset: Jdlrobson; "Moving zero specific code over to Zero" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57554 [19:42:18] New patchset: Jdlrobson; "Moving zero specific code over to Zero" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57554 [19:44:17] ok, so we're calling deploy done, right? [19:46:02] Maryana, yup [19:46:11] sweet [19:46:21] thanks for taking care of this so fast, team :) [19:46:23] \join wikimedia-staff [19:46:28] oops haha [19:46:33] too much Windows :P [19:46:49] you have to say "siri" first, mhurd [19:46:55] :D [19:46:55] "siri, join wikimedia-staff!" [19:46:57] :D [19:46:59] New review: MaxSem; "Wheeeeeeeeeeeeeeeeeeeeeeeeee" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/57554 [19:47:08] :) [19:47:37] the siri command appears to be broken on this IRC client. criminal. [19:47:48] Maryana: I'll be happy to talk to Commons:VP, etc about the apps :) [19:47:57] Maryana: I guess it's time I create YuviPanda_(WMF) [19:47:59] i'm on it haha [19:48:02] sweet, thanks yuvipanda! [19:48:19] I love everything about this: http://m.flickr.com/#/photos/smohundro/2427502693/ [19:48:37] just remember that (WMF) = extra hate from some community members... [19:48:55] ragesoss: ahahaha [19:49:05] I need to ask for a relicense, and that can be the lead for [[selfie]] [19:49:09] Maryana: :D [19:49:16] Maryana: just saw https://commons.wikimedia.org/wiki/User:Heatherawalls/sandbox [19:49:28] Maryana: I must post a warning somewhere about *not* using the app mockups for any promos [19:49:36] Maryana: the apps look nothing like the mockups, for the most part [19:49:44] yeah, those are just placeholders [19:49:48] they're going to use real screenshots [19:49:55] sweet :) [19:50:01] but feel free to leave feedback for heather on the talk page [19:50:05] if you have any more suggestions [19:50:14] we weren't sure about the copyright status of the itunes and play buttons, actually [19:50:15] Maryana: it looks awesome :) [19:50:32] Maryana: yeah, I'm pretty sure that might not fly on commons [19:50:37] Maryana: will be totally fine on enwiki, however [19:50:38] (fair use) [19:50:50] we used the play button on the WLM app banners/landing page [19:51:18] Maryana: hmm, I think content rules might not apply since it is technically part of the interface? [19:51:32] bleh, I don't think we should worry about it and self copyright nazi ourselves [19:51:55] heh, yeah [19:52:19] just something to be prepared for.. [19:52:43] heh, yes [20:04:12] Maryana: stole from your user template for http://en.wikipedia.org/wiki/User:YuviPanda_(WMF) [20:04:13] :) [20:04:47] nice :) [20:07:01] OMG COPYVIO UPLOADED BY A WMF EMPLOYEE [20:07:16] where? [20:07:27] oh [20:07:28] haha [20:07:34] where? [20:07:38] my template [20:07:41] you stole it! [20:07:44] except it's not really mine [20:07:50] ah, :D [20:09:00] Maryana: do you use the two browser strategy or 'goddamit now I need to log out aargh' strategy/ [20:09:02] ? [20:09:28] mostly the latter [20:09:35] I prefer the goddamit now I need to log out strategy myself [20:09:36] it's pretty messy [20:09:55] but it works. except when you post to the VP with your sock account. ahem [20:10:00] hehe :P [20:10:07] * YuviPanda should acquire some socks [20:10:24] yes, they're useful for keeping your toes warm :) [20:11:02] any objections against moving Zero gerrit notifications to this channel? [20:15:27] nope [20:18:28] New patchset: Jdlrobson; "Tests: prevent exception" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57646 [20:20:40] awjr_lunch: can you reply to https://gerrit.wikimedia.org/r/#/c/56887/6/includes/skins/SkinMobile.php when you have a chance < likewise MaxSem [20:23:04] ragesoss: early day bugs bunny cartoons are under PD? [20:23:05] or no? [20:23:10] ~1940 [20:23:18] jdlrobson, the new caching scheme will likely be deployed next week. no point in adding a temprary hack as it will be *too* temporary [20:23:25] ragesoss: not 70 years? [20:23:37] * jdlrobson nods - ok so let's get that patch unblocked so this can move forward [20:24:57] * brion looks over https://github.com/montehurd/Commons-iOS/commit/d67c64cb021a95b45f53d080172bdfdf13df88cf wheeee [20:25:29] yuvi: no. [20:26:08] for the US, 1923 and later may be copyrighted. [20:26:31] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [20:26:40] ragesoss: bleh. [20:26:49] ragesoss: but will be before our lifetimes :) [20:26:54] brion: hey! create account! [20:27:48] MaxSem: care to review https://gerrit.wikimedia.org/r/#/c/56886/3 ? [20:28:43] i'm not sure i understand your comment.. [20:29:16] i mean we can add them manually but it's kind of annoying when you are writing a special page [20:30:36] jdlrobson, re 56886: why is there a .styles vs .scripts distinction? [20:30:55] because its best practice to split up styles and scripts [20:30:58] so that styles work without js [20:31:13] MaxSem: addModules adds styles as well [20:31:15] {{citation needed}} [20:31:20] * jdlrobson finds a citation [20:31:41] I see relevant CSS packed with JS everywhere [20:31:51] why is mobile different? [20:32:03] New review: JGonera; "Moves the star too close to the search input making the chrome look asymmetric." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56515 [20:32:15] brion: can you get that merged this week? [20:32:20] pleeassssseeeeee [20:32:36] i will try :) [20:32:53] brion: :( [20:34:04] brion: panda sad [20:34:12] brion: anything I can do to help? [20:34:35] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57187 [20:34:51] SadPanda: if you have any more suggestions for tweaks stick em on the gerrit entry [20:34:57] i'll try and finish it up tonight [20:35:13] jdlrobson, do you agree with MobileDeviceDetectResourceLoaderModule? [20:35:39] eh MobileSiteResourceLoaderModule [20:35:43] http://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#Loading_module "OutputPage::addModules adds the given the module name(s) to the load queue of the page. The client side loader will request all of the components for this module (scripts, styles, messages, dependencies, etc.) and load them correctly." "OutputPage::addModuleStyles should be avoided, unless you need the CSS to be loaded when JavaScript is disabled." [20:37:04] ^ MaxSem [20:37:19] so basically if we want css to load without javascript it should be in its own dedicated module [20:37:31] you can't do addModuleStyles and addModuleScripts on the same module as the latter ignores dependencies [20:37:52] brion: whee, thanks [20:37:52] :) [20:38:39] New patchset: JGonera; "Don't add more than one photo upload button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57197 [20:39:17] meh, nice kludge:) [20:39:21] SadPanda: if the 'Defiance' game servers weren't so glitchy i'd probably be playing that tonight, so thank SyFy and Trion and their bad server planning :) [20:39:33] scary RL is scary [20:39:40] Maryana: is the 'tutorial' for mobile web coming up this iteration? [20:39:50] brion: hehe :D May the game servers be ddos'd! [20:39:51] :) [20:40:03] MaxSem: have you seen my latest comments on https://gerrit.wikimedia.org/r/#/c/48209/ [20:40:30] * brion suspects SadPanda is behind the ddos to increase brion's productivity [20:40:43] legoktm: see last part of https://commons.wikimedia.org/wiki/Commons:Village_pump#Missing_author.2Fsource_parameters_on_mobile_uploads:_fix_coming? [20:40:49] legoktm: can you run the bot once again? :D [20:41:03] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56886 [20:41:04] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57197 [20:43:32] awjr, thanks! [20:43:43] np Max, but looks like it needs another erbase :( [20:43:44] er [20:43:45] rebaes [20:43:46] damn it [20:43:47] rebase [20:43:50] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56886 [20:45:11] ruhroh [20:45:21] im getting a fatal on master [20:45:25] Detected bug in an extension! Hook updateLoadScript failed to return a value; should return true to continue hook processing or false to abort. [20:45:25] Backtrace: [20:45:25] #0 /mnt/hgfs/testing/core/includes/GlobalFunctions.php(3841): Hooks::run('EnterMobileMode', Array) [20:45:25] #1 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileContext.php(230): wfRunHooks('EnterMobileMode', Array) [20:45:25] #2 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(168): MobileContext->shouldDisplayMobileView() [20:45:26] #3 [internal function]: MobileFrontendHooks::onBeforePageRedirect(Object(OutputPage), 'https://www.vir...', '302') [20:45:27] #4 /mnt/hgfs/testing/core/includes/Hooks.php(255): call_user_func_array('MobileFrontendH...', Array) [20:45:28] #5 /mnt/hgfs/testing/core/includes/GlobalFunctions.php(3841): Hooks::run('BeforePageRedir...', Array) [20:45:29] #6 /mnt/hgfs/testing/core/includes/OutputPage.php(1999): wfRunHooks('BeforePageRedir...', Array) [20:45:30] #7 /mnt/hgfs/testing/core/includes/Wiki.php(517): OutputPage->output() [20:45:31] #8 /mnt/hgfs/testing/core/includes/Wiki.php(458): MediaWiki->main() [20:45:32] #9 /mnt/hgfs/testing/core/index.php(59): MediaWiki->run() [20:45:33] #10 {main} [20:45:34] mastah is dead! [20:46:17] :( [20:46:27] please test before merging :) [20:47:52] awjr, is updateLoadScript a MF thingie? [20:48:00] doesn't look like it MaxSem [20:48:24] dude [20:48:27] my bad [20:48:32] ;) [20:48:39] it's something i had set in my localsettings to test your EnterMobileMode hook >_< [20:48:44] today, i wear the dunce cap. [20:49:08] * MaxSem gives awjr some irish coffee [20:49:20] ahhhhh much better :) [20:49:23] now i am brilliant! [20:51:18] New patchset: Jdlrobson; "Make special pages declare their modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56886 [20:52:21] New review: awjrichards; "I've replicated the problem locally, and this does indeed fix it." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55776 [20:52:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/55776 [20:52:53] ok, Wikipedia app 3.3.1 for iOS has been approved [20:53:01] lemme go ahead and release that to the store [20:53:28] brion: sweeeet [20:53:34] brion: tell the analytics folks too :) [20:55:00] yep [20:55:35] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57093 [20:56:22] Maryana: have you seen this/this change ok? https://gerrit.wikimedia.org/r/#/c/57094/1/MobileFrontend.i18n.php [20:57:44] New review: Jdlrobson; "Sounds good to me." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [20:58:03] man, it's 91F today :( [20:58:12] a harbinger of summer [20:58:12] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56324 [20:58:30] awjr: welcome to the club :) Was 92 when I was out earlier [20:58:41] with ~55% humidity :( [20:59:17] * brion hands awjr and SadPanda a copy of https://www.google.com/search?q=san+francisco+weather [20:59:43] 60F, Rain, and Good Internet, without power blackouts? [20:59:50] yyyyyup [20:59:53] sounds no fun [21:00:35] lol [21:00:45] i dont even remember what rain is [21:01:39] rain is that thing that you wait for it to pass before going in to the office if you don't have any meetings [21:01:41] brion: mhurd https://bugzilla.wikimedia.org/show_bug.cgi?id=46898 :) [21:01:42] it's a pain in the ass :) [21:01:51] brion: meetings or rain? :P [21:01:52] hehehe [21:01:58] lose-lose scenario [21:02:08] i do recall rain making commutes to the office fairly miserable - particularly when i biked to the office everyday [21:02:12] meh, jdlrobson - is not splitting the module a real problem? [21:02:17] brion: I now have http://en.wikipedia.org/wiki/User:YuviPanda_(WMF) :) [21:02:20] *the detect module [21:02:21] \o/ [21:02:29] gah gerrit's 503ing for me [21:02:40] SadPanda: so shall we append that template in for now until we get categories going? [21:02:49] brion: yup, you should [21:02:57] it's substed, so adds the date [21:02:58] too [21:03:01] spiffy [21:03:13] brion: but create account first :D [21:03:16] MaxSem: yeh :/ [21:03:21] :P [21:03:22] okay, time to sleep [21:03:22] i think [21:03:25] as we want the styles to run without js [21:03:35] if we use addModuleScripts it will also reload the styles in javascript [21:03:44] ^ ignore last line [21:03:48] f we use /addModules/ it will also reload the styles in javascript [21:03:55] f we use addModuleScripts it will not load the dependencies [21:04:02] SadPanda: should it go at the bottom, top, or in a section? [21:04:15] * brion looks up the template [21:04:17] brion: unc? Bottom [21:04:25] usually [21:04:28] ok [21:04:30] or at least that's where I put 'em [21:04:40] that's a one-line fix i may as well stick it in :D [21:05:37] New patchset: MaxSem; "WIP: Avoid SkinMobile-specific functions and properties" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48209 [21:05:39] awjr, ^^^ [21:07:04] New review: awjrichards; "I really don't think we should block on naming convention since we don't have one yet. Let's fix the..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/57216 [21:07:44] brion: good night :) [21:07:56] nini [21:07:58] ok example: https://commons.wikimedia.org/wiki/File:IPod_running_Commons.jpeg [21:08:00] looks good [21:08:01] yo brion: can I close https://bugzilla.wikimedia.org/show_bug.cgi?id=42484 ? [21:08:50] drdee: go ahead yes :D [21:09:04] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/yYV3fA [21:09:04] Commons-iOS/master 1364ce7 Brion Vibber: (Bug 46898) Add 'unc' template to uploads.... [21:11:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/48209 [21:11:25] brion: done [21:15:28] New patchset: Jdlrobson; "Bring watch star css/html markup closer to desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56515 [21:15:59] New review: Jdlrobson; "Looks like the css from the special pages was interfering.. fixed." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56515 [21:16:42] New patchset: Jdlrobson; "Bring watch star css/html markup closer to desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56515 [21:27:10] New patchset: awjrichards; "Un-skip MobileContextTest::testUpdateDesktopUrlHost" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57653 [21:29:30] jdlrobson, should mobile.device come strictly after mobile.styles? [21:33:07] i am getting a couple of exceptions running qunit in master - is that expected? [21:33:11] jdlrobson, jgonera ^ [21:33:35] oh https://gerrit.wikimedia.org/r/#/c/57646/1 [21:34:44] can anyone repro https://bugzilla.wikimedia.org/show_bug.cgi?id=36601 ? it looks fixed to me [21:35:48] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57646 [21:38:47] MaxSem, I can reproduce it easily [21:38:53] wget -U "Safari iOS 4.3.3/iPhone" http://www.wikipedia.org/wiki/.is [21:39:04] i can repro it max [21:39:19] ugh, somehow it redirects properly for me, wtf [21:39:31] MaxSem: don't copy/paste the UA they provided, it's wrong [21:39:40] it has a typo [21:39:42] iPhone, not iPhonr [21:39:46] I didn't [21:39:49] hrmph [21:40:04] I used a ff plugin to fake iphone 3 [21:40:08] MaxSem, eqiad or pmtpa ? [21:40:49] Platonides, all this stuff goes to eqiad these days [21:41:52] i can repro it with other mobile devices too [21:41:53] sorry, I meant esams [21:42:07] there's something whack in the redirect rules [21:42:59] yeah ,we need to tweak the varnish rules [21:43:17] however, how the hell did it WFM from ff? [21:43:19] MaxSem: that's coming from varnish or from squid/redirector? [21:43:26] i dunno, that's weird [21:43:28] eh squid [21:43:32] unless your UA wasn't being properly spoofed [21:43:45] Mozilla/5.0 (iPhone; U; CPU iPhone OS 3_0 like Mac OS X; en-us) AppleWebKit/528.18 (KHTML, like Gecko) Version/4.0 Mobile/7A341 Safari/528.16 [21:44:45] * awjr shrugs [21:44:53] MaxSem: yes it should come afterwards [21:45:15] (device styles) [21:45:48] MaxSem: i fixed up https://gerrit.wikimedia.org/r/#/c/56886/ should be ready to merge awjr ? [21:46:23] MaxSem, that UA also fails for me [21:46:36] grr, FF magic [21:47:12] fun! [21:48:39] I feel we shouldn;t waste our time on Squid [21:49:26] i would guess that that is an edgecase [21:49:36] and isn't worth prioritizing very high right now [21:49:54] MaxSem: on account of the eventual move to varnish? [21:49:59] should be trivial once we switch the main site to Varnish [21:50:31] yah [21:54:15] Krinkle|detached: you still detached? [21:55:19] I was wondering about https://gerrit.wikimedia.org/r/#/c/55446/6 and I wondered if instead of resorting to user agent testing whether we could feature detect something(s) that we consider minimal to support a javascript mode. [21:55:32] Maryana_brb: are those tutorial images actually in there? i've never seen them [21:56:34] ah they show only for people with no uploads ever [21:56:34] jdlrobson: in https://gerrit.wikimedia.org/r/#/c/56886/3..4/includes/specials/UnlistedSpecialMobilePage.php - you know it's possible for $name to be an empty string [21:56:37] well that explains that :) [21:56:41] jdlrobson, there's no feature detection for stuff like "if you load jQuery into earlyish Blackberries you will crash the browser" [21:57:14] jdlrobson: so either you should protect for that by forcing a name for UnlistedSpecialMobilePage objects, or otherwise protect for it in the addModules() method [21:57:22] MaxSem: that's why RL has a compatibility check before it loads any modules. Unfortunately it only checks for "IE before 6" iirc :P :) [21:57:39] brion, see the linked commit;) [21:57:41] aww, panda went to bed at a sane hour for once [21:57:56] https://gerrit.wikimedia.org/r/#/c/55446/6 [21:58:26] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56886 [21:59:34] our current device detection works fairly well, I see no point in changing it without a clear need [21:59:48] +1 [22:00:14] MaxSem: totally agree; and if we do decide to change it, we'll need to do some signifcant testing, blahblahblah [22:00:27] which is not necessarily a bad thing, but we would need to plan around it [22:00:46] +1s should go to gerrit:) [22:00:54] * awjr looks [22:05:19] yeah, brion, you need to create a sock with no uploads to see the tutorial [22:05:35] however, what you should not do is forget to log out of your sock and then edit the commons VP :-P [22:05:49] haha [22:06:10] i may steal that tutorial for the apps [22:06:12] New patchset: Jdlrobson; "Make special pages declare their modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56886 [22:06:14] want to run it by yuvi too [22:07:22] ^ awjr [22:07:36] o_0 [22:09:17] i like that "donate original photos that have educational value" has an icon of a dude with a unix beard [22:09:32] hahahaha [22:10:14] yeah, hehe [22:10:23] perhaps this is what's encouraging all the selfies [22:10:33] meh. this is stupid - indeed I'll have to split the module [22:10:36] get a firefox os phone to RMS [22:10:38] we looked at other "person" icons, but they were all kinda surly [22:10:40] wtfwtfwtfwtfwtfwtfwtfwtfwtfwtfwtf [22:10:41] have him take a selfie [22:10:43] the beard guy looked the happiest [22:17:11] I just made some mobile contribs to Category:Star Wars fandom. [22:21:21] oh dear [22:23:47] bleh, are there any custom settings required for a local mobilefrontend extension? [22:23:59] i just configured mobile & zero (master) [22:24:23] omg. https://commons.wikimedia.org/wiki/File:Slave_Leia_Shoot,_Celebration_V.jpg [22:24:42] faked X-Device = android, User-Agent = android, X-Carrier=..., and I get "Welcome, Admin!" instead of the main page [22:24:47] brion, ? [22:24:57] yurik: that sounds right, actually [22:25:11] yurik: main page needs customization in order to appear in mobile skin [22:25:22] yeah that should be same as without x-carrier :) [22:25:23] ragesoss: @_@ [22:25:56] brion, actually x-carrier gets ignored completelly [22:26:05] do i need extra settings for zero? [22:26:19] there is no banner [22:27:01] yurik: my LocalSettings has $wgEnableZeroRatedMobileAccessTesting = true; [22:27:09] i forget if you need it or what that does :) [22:27:54] oh yeah, now it works, thanks brion :) [22:28:10] * yurik is getting scarred of zero [22:28:21] hehe [22:28:45] i love the "have no clue what it does, try it and see if it works" approach [22:32:19] Maryana: you just made me laugh [22:32:27] (And this is why we should have mobile team demos more regularly.) [22:32:32] hehehe [22:32:47] MaxSem: i just had a chat with Trevor. I'm making some tweaks to your patchset [22:32:58] someone has to fill in for him! [22:33:00] cool [22:37:47] New patchset: MaxSem; "Story 141: Set wgMobileDeviceName in a device specific js module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [22:38:03] phewww [22:54:06] MaxSem: NokiaN73-2/3.0-630.0.2 Series60/3.0 Profile/MIDP-2.0 Configuration/CLDC-1.1 is a wap phone right? [22:54:13] will that ever get served the html site? [22:55:57] is there any place where all the possible parameters of a RL module are documented? [22:56:18] jdlrobson_, its x-device is wap2 actually [22:56:24] which is... HTML:P [22:56:30] eek [22:56:35] so MaxSem I [22:56:36] 'v [22:56:50] I've rewritten your isCompatible in a way Trevor will like but i'm not sure about this one [22:56:57] jgonera, includes/resourceloader [22:57:24] jdlrobson_, that device needs detection and it's not jQuery-compatible [22:57:35] ok np [22:58:24] 'wap2' should really be killed in favour of 'html' though [22:58:30] next time... [23:02:45] * jdlrobson_ takes a deep breath [23:03:05] * MaxSem prepares his -1...:P [23:03:21] MaxSem: https://gerrit.wikimedia.org/r/#/c/55446/7 [23:03:32] so MaxSem I think this is a good middle ground [23:04:16] if jQuery mobile support phones then we should too. After all I have tweaked the device detection rules for blackberry based on them [23:04:53] jdlrobson_, [ false, 'I\'m an unknown mobile browser' ], was there for a reason [23:05:27] MaxSem: why. You don't know anything about it [23:05:44] When is that a user agent? [23:06:07] when it matches /mobi/i [23:06:13] that's stupid [23:06:24] that's not a real user agent [23:06:36] and since we know about all modern mobile web platforms, all the rest is assumed to be incompatible [23:06:50] i think that's wrong. I think we should blacklist based on facts. [23:06:59] dr0ptp4kt: did you ever get an answer to your mobile/zero experience domain names q? [23:09:02] jdlrobson_, you're going against the current detection scheme [23:09:09] which is proven to be working [23:09:18] jdlrobson_: imho we should stick with current detection and make updates later [23:09:35] MaxSem: and awjr i completely disagree and will reply to the thread with my comments [23:09:42] since we're migrating this to JS, it would be prudent to work from status quo to make sure things work correctly BEFORE making changes [23:09:57] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:10:04] let's break less things more often [23:10:08] or whatever [23:10:26] jdlrobson_: you're such a maverick [23:10:48] i hpe you're wearing your cowboy hat [23:11:28] if anyone wants a quick and easy CR: https://gerrit.wikimedia.org/r/#/c/57653/ [23:13:58] jdlrobson_, when you have a moment, I think I figured out why tests didn't work for you in https://gerrit.wikimedia.org/r/50442 [23:17:22] MaxSem: how do you want to proceed with x-device variance for resources? i was thinking it would be good to try and enable it on a smaller project on tuesday if we can get ops to merge the varnish changes [23:17:30] and hten potentially enable it everywhere the week following [23:18:02] awjr, enabling it on a small wiki will not give an idea if it works [23:18:17] unless there will be totally bizzarre failures, of course [23:18:29] well that's kinda the idea [23:18:41] to make sure there aren't bizzare failures [23:18:59] since we cant really test this stuff out very well anywhere other than prod [23:20:00] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56515 [23:20:02] awjr, sorry for the delay, must have missed the notification. i haven't received further information from the list. i'm guessing no one knows of additional domains n use. [23:20:08] it's such a significant change with such architectural significance, i think it's worth being careful with it, MaxSem [23:20:38] let's chat with mark about this tomorrow [23:21:01] MaxSem: i will be out tomorrow, but go ahead without me, im sure you guys will come up with a reasonable plan [23:21:09] sure [23:21:18] poke him again to get those changes merged too :p [23:21:26] zz_SadPanda: sure, taking a look [23:21:39] dr0ptp4kt: *most* domains have a .m [23:21:40] but there are a handful that don't [23:21:50] in terms of what is expected for zero… i have no idea [23:23:15] dr0ptp4kt: i can tell you the domains that have automatic redirection to a .m if that's helpful, but that's only a subset of .m domains [23:26:56] dr0ptp4kt: to see the things that match for automatic redirection of mobile devices to .m, take a look in operations/puppet/templates/squid/redirector.conf.erb - basically anything that matches that regex [23:27:27] jdlrobson_, https://gerrit.wikimedia.org/r/55446 [23:28:00] awjr, will look at that. i guess maybe i need to spend a few hours parodying the connections through an intercepting proxy while on mDot. [23:28:15] sounds fun, dr0ptp4kt :p [23:28:55] why do we want to set wgMobileDeviceName in a device-specific JS module? does it help in caching? it seems that the HTML will be different for different devices anyway (https://gerrit.wikimedia.org/r/#/c/56703/) [23:29:05] jdlrobson_, randomly breaking phones is not "widening our support" [23:29:31] jgonera, no it will not - that's the whole point [23:29:52] how? I mean, you load the JS in HTML, so if you change the JS you load, the HTML changes [23:30:37] you don't change the URL depending on device [23:32:43] oh, right, sorry. still, why do we have a separate MobileDeviceDetectScriptsModule instead of using onMakeGlobalVariablesScript hook? [23:33:46] because global vars go into HTML [23:35:26] all right, and this probably goes to some RL core JS file? [23:36:37] jgonera: correct [23:37:00] and that JS file varies on the X-Device header [23:39:28] jgonera: your latest patch set is still funky with me - doesn't run any of the test o_O [23:39:39] :O [23:39:42] although there is a mysterious "Failed to load resource: the server responded with a status of 403 (Forbidden) " message [23:39:49] for http://localhost/w/extensions/MobileFrontend/tests/externals/sinon.js [23:40:07] and if you try to load this file in browser yourself? [23:40:18] maybe something with directory permissions? [23:40:18] it's forbidden also [23:40:25] i seem to remember MaxSem introducing an htaccess file? [23:40:34] well, looks like permissions or Apache config [23:41:04] jgonera: why it is loading the file anyhow and not using RL ? [23:41:21] it is using RL, that's how RL works in debug mode [23:41:36] so that you get line numbers on errors in browser [23:41:50] that actually correspond to original code [23:42:03] you are forcing debug mode? [23:42:38] yes because a) it's good to know line numbers when tests fail, b) sinon.js assumes global scope and there's no global scope without debug mode [23:43:06] and it worked before only because we stuffed all the tests into a single RL module [23:43:11] within a single closure [23:44:07] haaa [23:44:09] haaaa [23:44:22] it's not loading because of .htaccess [23:44:36] why don't I have this problem? [23:44:54] because htaccess is disabled by default [23:45:02] oh, right... [23:45:12] jgonera: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=tests/.htaccess;h=3a42882788717c9ed1d5c2fcc3277d21ec13152b;hb=HEAD [23:45:29] so yeh it works now... [23:45:37] and .htaccess shouldn't be removed unless qunit.sh is protected from CGI invocations [23:45:43] although PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/0481F83E-AE6E-468C-A4B5-DA962C276F1E.dmp [23:46:04] MaxSem, and if I move qunit.sh? [23:46:08] jdlrobson_: I'm checking the blacklist commit now [23:46:18] I've got a few ammendments coming up for it [23:46:26] I actually think that scripts directory is a better place for it [23:46:28] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57094 [23:47:08] yeah [23:47:24] jdlrobson_, it crashes for me too occasionally, even on master, I suspect the new version has a bug [23:48:03] New review: Jdlrobson; "Perfect. I'll leave arthur to do the +2 hono(u)rs so we can get a PHP perspective." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/56703 [23:48:04] I mean it does right, segfaults should never happen, no matter what crazy stuff we run on the web site ;) [23:48:32] jgonera: so yeh happy to merge this once you've fixed the htaccess problem :) [23:48:57] ok, will change my Apache config to reproduce and push a new patch [23:49:22] New review: Jdlrobson; "As discussed on irc there seems to be an htaccess problem due to " [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [23:49:46] jgonera: in case you didn't see it > https://github.com/jdlrobson/gerrit-be-nice-to-me [23:49:53] although you'll have to use chrome ;-) [23:51:23] jdlrobson_, will check it out! [23:58:28] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442