[02:07:40] hey legoktm [02:09:50] legoktm: looks like the bot ran :) [02:09:51] thanks! :) [08:49:44] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58062 [12:51:53] all hail legoktm [12:52:08] o.O [12:52:15] :) [12:52:16] good morning YuviPanda [12:52:22] I went to college today [12:52:24] so, evening :( [12:52:30]

[12:52:36] anyway, did the bot run complete legoktm? [12:52:42] yup [12:53:10] whee [14:41:58] New patchset: Jdlrobson; "Disable upload CTA when $wgMFEnablePhotoUploadCTA is false" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [14:43:54] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57653 [14:50:31] New review: Jdlrobson; "I am now getting a couple of qunit errors - this might be a test that needs fixing?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [14:51:42] New review: Jdlrobson; "PS. Max potentially won't like you deleting the .htaccess in the tests folder ;)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [15:02:44] New review: Cmcmahon; "bundle for parallel, mobile" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/57839 [15:02:44] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57839 [15:19:10] New review: MaxSem; "Max had already explained what needs to be done to remove the .htaccess: nothing in this directory s..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [17:11:29] New review: Cmcmahon; "hygiene" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/57838 [17:11:29] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57838 [17:12:34] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58062 [17:12:35] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58062 [17:14:34] hey brion [17:14:44] brion: saw my trello email? [17:16:10] YuviPanda: yeah will follow the link shortly :D [17:16:14] :) [17:16:23] jgonera: I heard you talk about adding one more graph to the dashboard. [17:16:32] yes [17:16:36] in a separate tab I think [17:16:39] jgonera: i've done a few changes to the generator code, so just a headsup [17:16:54] jgonera: if all you are going to do is just add another sql file, there are no changes. [17:17:00] except that adding a title in the config file is now a 'must' [17:17:16] just a headsup :) [17:17:18] yeah, I saw it, I'll tell you if I have any problems [17:17:21] sure, thanks ;) [17:17:24] hey Maryana [17:17:26] Maryana: https://gerrit.wikimedia.org/r/gitweb?p=analytics/limn-mobile-data.git;a=tree;f=mobile;h=71335626cb43e658c1198d2cf4165c3e4dd5dfeb;hb=HEAD [17:17:28] has the scripts [17:17:32] hmm [17:17:37] merci beaucoup! [17:17:38] Maryana: the deletion ratio is from 'alltime-numbers.py' [17:17:56] gotcha [17:17:56] YuviPanda: i'm not sure i have the right permissions or something, i see no UI to create new entries in the channels at https://trello.com/board/sprint-6/5162461b43476994540002ba [17:17:56] Maryana: it's using data from both our eventlogging and commonwiki [17:18:03] brion: what are you logged in as? [17:18:10] brion: bvibber@wikimedia.org? [17:18:25] i'm not sure [17:18:33] brion: log out and log back in? [17:18:33] it just came up [17:18:40] are you loggedin? [17:18:58] Maryana: we've a design syncup in 10? [17:19:11] nope, jcmish is still out [17:19:21] she rescheduled it for tomorrow [17:19:22] YuviPanda: ok logged back in via bvibber@wikimedia.org 'google account' [17:19:26] Maryana: jcmish? [17:19:28] i still see no 'add card' on sprint 6 [17:19:32] but i see it on the sprint template [17:19:40] Maryana: design syncup was with vibha, no? [17:20:04] oh, sorry, yes :) [17:20:13] brion: you are added as a member [17:20:13] weird [17:20:23] Maryana: so, that is postponed too? [17:20:24] or? [17:20:26] i'm confused [17:20:41] yuvipanda, no, that one's happening [17:20:48] sorry, i thought you were talking about QA/design sync up [17:20:51] Maryana: can you grab brion and mhurd too? [17:20:55] too many syncups [17:20:59] heh [17:20:59] yeah [17:21:01] too many paradigm shifts [17:21:04] too much synergy :P [17:21:07] i was thinking about the pitchforks. Have we considered proposing some image pre-classification system - to ask the user to justify why that image should be in wiki? [17:21:34] brion: try now [17:21:58] this way we, from the start, put the user in the state of "not everything is good, i have to proove that its worthy [17:22:23] brion: i removed and re-added you [17:22:26] and does two things: 1) users won't be upset that the submission wasn't accepted [17:22:38] yurik - yes, though imho that tends to a) scare away good users and b) not deter people who don't care/don't read instructions [17:22:42] and 2 - helps commons community categorize it [17:23:01] checjing [17:23:01] but there are more scary and less scary implementations, yes :) [17:23:13] 'add a card' \o/ thanks YuviPanda [17:23:25] ok the sync-up is in a half hour-ish? [17:23:25] well, we could make it less scarry :) something like - in order to justify this image for wiki, please select category ... [17:23:35] and the categorization could be controlled by the community [17:23:51] so let the community decide how an image should be classified [17:23:57] brion: :D [17:24:05] brion: doubt it'll be that much :) [17:24:19] and deal with the problem of not scarring ppl away [17:24:46] in other words, the app will download some magic settings from wiki that admins have configured [17:25:05] yurik: app != mobile web [17:25:08] and offer them as upload steps [17:25:12] i understand that :) [17:25:12] I should keep a counter of number of times I say that :) [17:25:26] YuviPanda, i don't mean to implement wiki rendering on the app [17:25:36] just to have some predetermined workflow with customizable categories [17:25:52] i know! we'll force all uploads to first have a video chat with an angry commons admin [17:25:54] yurik: yeah, 'campaigns'. they're the next major feature. [17:25:56] simplistic workflow defining language might be the next step [17:26:07] yurik: but just pointing out that *this* pitchforking is for the mobile web [17:26:14] the apps pitcforking should be coming up shortly :P [17:26:17] oh, i thought it was for the app? [17:26:22] hmm, sorry, misread [17:26:37] all those uploads happened on mobile web? [17:26:39] wow [17:26:55] yurik: yeah [17:27:39] where's jdlrobson? [17:27:40] * yurik is looking for a pitchfork of his own [17:35:17] brion, mhurd, we're up on the 6th floor in R66 talking about apps design stuff, if you're interested in joining :) [17:35:29] jdlrobson, so i talked last week with jgonera and Krinkle|detached about https://gerrit.wikimedia.org/r/55446 and my proposal was to merge it if nobody has any seriousl problems with it, enable on testwiki and use all our office's phones to test the hell about it, then corect if needed and deploy next week to the rest of projects [17:35:32] thoughts? [17:35:36] ya [17:37:12] MaxSem: that seems like a very good approach [17:37:32] who's gonna merge?:P [17:37:39] MaxSem: it still needs a few fixes [17:37:46] like? [17:37:53] crinkle enabled it on opera mini and nokias [17:38:07] See my Patch Set 9: Code-Review-1 comment [17:38:21] i'll do that now MaxSem [17:38:27] New patchset: Jdlrobson; "Remove the need for a button in sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [17:38:27] New patchset: Jdlrobson; "jqueryify toggle.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58110 [17:39:01] mhurd: YuviPanda brion : i wont have the full back log prepped for todays meeting as i'm still catching up. be prepared to jump in and suggest what you want in the sprint. [17:39:21] tfinc: saw the trello board? I've been putting in Android stuff and brion has started putting in iOS stuff [17:39:28] YuviPanda: linke me [17:39:34] brion, i have been bugging i18n ppl, but maybe you know... or someone else here -- how do i inject my own messages into the wfMessage translation cache? [17:39:39] tfinc: https://trello.com/board/sprint-6/5162461b43476994540002ba [17:39:52] tfinc: we're in a design meeting with vibha and Maryana though [17:39:52] YuviPanda: nice [17:39:58] tfinc: i'm looking at how e2 and e3 do it [17:40:00] to see [17:40:02] YuviPanda: but it ends in time for our 11 team meeting ? [17:40:05] yes [17:40:33] tfinc: me, monte, brion are all on it [17:40:51] tfinc, am i needed for that meeting? need to step outside for an hour [17:40:59] yurik: nope [17:41:04] this is an app team meeting [17:41:09] oki [17:41:14] wasn't sure [17:42:29] Maryana, I was going through the village pump discussion and thought that maybe we should remove the Uploads menu item instead of the uploads CTA for logged out users [17:42:57] my reasoning is that if someone logs in because of the CTA it's because they think they can add a valuable image to an article [17:43:23] and when they click on Uploads in menu, they just want to play and then upload lots of trash because they don't want what to upload [17:43:59] dr0ptp4kt, ping [17:44:11] yurik, pong [17:44:19] hi [17:44:25] did you have a chance to look at my code? [17:44:26] hi [17:44:31] actually, we should somehow track if the photos that are deleted come from the dashboard or lead image button [17:44:52] yurik, i read it once this morning. planning to take another look later today. [17:45:21] cool, see if it runs for you. Btw, we need to start bugging ops about getting us a proper namespace set up [17:46:23] dr0ptp4kt, and feel free to +2 it -- its a separate branch, the code won't go into the master just yet [17:46:31] New review: MaxSem; "Do we need to change the HTML output for it?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [17:46:32] but try to read through it first ;) [17:48:25] yurik, yes :) [17:48:29] tfinc: it got started a little late. Entire app team is there though (excepting you) [17:48:54] done by 11:30 ? [17:49:07] New review: MaxSem; "There are more CTAs around, so can we generalize that setting and make it control all the other call..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [17:49:09] unsure. Maryana ^? [17:49:17] Maryana, are you there? [17:49:26] yeah, sorry, in the apps design mt [17:49:28] mtg [17:49:31] tfinc: can we push it? [17:49:32] oh, ok [17:49:42] what was the question? [17:49:52] YuviPanda: i'm feeling very out of the loop on what's being discussed at this design meeting. as the person managing the backlog it puts me a big disadvantage [17:50:06] just scroll up a bit, I had some thoughts about disabling image CTA [17:50:24] tfinc, come on up to R66 [17:50:32] jdlrobson, am I needed for the ops meeting? [17:50:38] this is the sync up w/vibha and the apps team that we've been rescheduling forever [17:50:55] Maryana: i can not. i'm in the regular manager meeting till 11 [17:51:44] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [17:51:53] Maryana: please catch me up when you finish and invite me to the future ones. that way i can prioritize more effectively [17:52:02] no need to slow this one down since its in progress [17:52:08] k [17:53:12] * tfinc thinks he may be able to duck out of this manager meeting now [17:54:12] jgonera: nope you're okay [17:56:27] Maryana: http://play.google.com/store/apps/details?id=org.wikimedia.commons [17:57:42] http://etherpad.wikimedia.org/App-20design-20tweaks [18:00:21] Maryana: http://dpaste.de/wuvjQ/ [18:00:23] the email [18:04:51] tfinc: I'm in the hangout. [18:06:10] YuviPanda: tfinc is hooking up the camera [18:06:14] ah okay [18:07:02] brion: am I in the right hangout? [18:07:07] i think so [18:07:22] okay [18:07:35] YuviPanda: you need an avatar dude [18:14:59] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58088 [18:16:59] brion: black rectangle best avatar :) [18:19:02] New review: JGonera; "Was there anything else apart from qunit.sh? I'm not sure how dangerous it is to run a PHP test file..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [18:19:11] MaxSem, ^ [18:20:54] Maryana, do we have the QA review now? jdlrobson would you cover that one? Else I'll have to switch to Windows again... [18:21:06] * jdlrobson is in the ops meeting [18:21:10] btw, I should have my laptop back tomorrow, hopefully [18:21:24] jgonera, nope, jcmish is out - it's rescheduled for tomorrow [18:21:30] ok, thanks [18:24:30] New review: MaxSem; "The PHP tests are safe, so the only thing one needs to worry about are qunit.sh and tests/acceptance..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [18:24:39] jgonera, ^ [18:24:41] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [18:26:13] New review: JGonera; "tests/acceptance shouldn't be harmful. Those tests don't touch the database or anything, plus I don'..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [18:26:56] jgonera, you have an outrageous lack of paranoia:] [18:27:17] I usually don't [18:27:27] MaxSem: i'd say the opposite when it comes to jgonera ;-) [18:27:41] ok, it seems safer to either put another .htaccess in tests/javascripts [18:28:02] or to move sinon [18:28:03] jgonera: just chance the existing htaccess [18:28:19] jdlrobson, we all bikeshed here and there, but I was speaking about a particular thing:) [18:28:23] from Deny from all to be more explicit.. [18:28:37] hm [18:28:51] I think I want to deny from all, just not for all dirs [18:29:26] jgonera: MaxSem talking of bike sheds can we get https://gerrit.wikimedia.org/r/#/c/57216/ merged? [18:29:45] awjr is waiting for one of you to ok it [18:29:48] re htaccess, not worth the effort: some options can be disabled for .htaccess, resulting in everything being unavailable [18:30:35] jdlrobson, I was going to rename it to MobileSiteModule.php and then merge:] [18:31:01] MaxSem: if that makes you happy :) [18:31:47] basing class names on module names allows us to avoid the MF-specific prefix no matter what it is [18:32:03] also, shoerter:) [18:33:05] MaxSem, what do you mean? why do we even have .htaccess then? [18:35:05] hy Maryana [18:35:08] do you have a trello login? [18:35:11] yep [18:35:32] Maryana: email? [18:35:41] should just be my wikimedia email [18:35:44] jgonera, imagine some poor soul having to install MW into cgi-bin [18:36:00] Maryana: okay [18:36:33] jgonera: any idea what the jsduck issue is on https://gerrit.wikimedia.org/r/#/c/55446/ ? [18:36:42] MaxSem, yes, so that's why we have it, so I want this poor soul to be protected but us still being able to run JS tests ;) [18:36:57] yup [18:37:03] seems unrelated to my change? [18:37:19] so move the offending parts to some place where you can slap a simplest htaccess on them [18:37:34] also jgonera see my comment on https://gerrit.wikimedia.org/r/#/c/58088/ and feel free to rewrite as you please - essential we get this patch merged today! [18:38:50] jdlrobson, Warning: /var/lib/jenkins/jobs/mediawiki-core-jsduck/workspace/resources/mediawiki/mediawiki.js:471: Optional param followed by regular param callback ? [18:38:59] not sure if it's a problem with this patchset [18:39:16] jgonera: agreed [18:39:28] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [18:41:04] New patchset: Zfilipin; "Wait until login page opens" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58121 [18:41:12] so MaxSem Mark from ops was keen to be involved in any deployment relating to our changes [18:41:22] (specifically the varnish changes) [18:41:25] yup, I talked to him [18:41:32] only problem is he has an interview tomorrow [18:41:35] did he mention that? [18:41:36] Maryana: added you to https://trello.com/board/sprint-6/5162461b43476994540002ba [18:41:37] eh, the varnish changes are already merged [18:41:45] w00t, thx yuvipanda [18:41:46] Maryana: We've prioritized the tutorial for this sprint. [18:42:00] we can control whether we use them or not with a MF setting [18:42:00] Maryana: our trello is still messy, we're just getting started, etc. [18:42:41] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [18:43:08] New review: Cmcmahon; "explicit wait_until for login page" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58121 [18:43:09] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58121 [18:44:51] MaxSem, but what are the offending parts? the acceptance tests? I'm not sure why putting a second .htaccess in tests/javascripts saying "Accept from all" is not the right solution [18:46:03] so MaxSem you spoke to Mark today? If not please quickly check his availability for deployment tomorrow - i think it has changed! [18:48:11] New patchset: Zfilipin; "Wait until login page opens" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58125 [18:48:44] jdlrobson, will do, however we don't have to flip that switch tomorrow so if he can't we can do it any time [18:52:18] * MaxSem notices that today's showcase has disappeared from his calendar [18:52:20] yay. [18:55:58] thanks MaxSem :) [18:56:37] so jgonera should we do a rewrite or a quick short term fix? with regards to https://gerrit.wikimedia.org/r/#/c/58088/ [18:57:11] I'd just move it the way I mentioned in the comment for now, I can do it after I finish fighting with htaccess [19:00:08] New patchset: Zfilipin; "Removed unnecessary step" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58128 [19:00:08] New patchset: Zfilipin; "Fixed Rake task so it reports failures properly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58129 [19:04:05] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [19:04:16] jdlrobson, can you check if that works for you? ^ [19:10:08] jdlrobson, you able to do a google hangout so we can screenshare? [19:14:43] New patchset: JGonera; "Disable upload CTA when $wgMFEnablePhotoUploadCTA is false" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [19:19:20] YuviPanda, what was the repo where the instructions for setting up limn locally were written? [19:21:31] jgonera: wikimedia/limn? [19:21:33] on github/ [19:22:06] MaxSem: so can i just merge this https://gerrit.wikimedia.org/r/#/c/57216/ ? [19:22:19] one sec [19:22:30] YuviPanda, no, there was another one with data, where the command for linking to data locally was shown [19:22:45] jgonera: http://github.com/wikimedia/limn-data [19:22:47] i think [19:22:47] like our limn-mobile-data but for something else [19:22:48] oh [19:23:11] that's the one, thanks [19:23:27] :) [19:25:27] New patchset: Jdlrobson; "Disable upload CTA when $wgMFEnablePhotoUploadCTA is false" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [19:25:28] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [19:25:56] jdlrobson, I'm a bit worried about making the mobile.site CSS accessible only to RL-supporting browsers [19:26:10] MaxSem: it shouldn't be.. [19:26:16] it will be available to all [19:26:22] New review: Jdlrobson; "Works for time being. We should definitely think about refactoring this in the future though as the ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58088 [19:26:23] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58088 [19:26:35] mw.loader.load(["mediawiki.page.ready","mediawiki.hidpi","mobile.startup","mobile.stable.dependencies","mobile.beta.plumbing","mobile.beta","mobile.alpha.plumbing","mobile.alpha","mobile.stable","mobile.site"],null,true); [19:27:17] MaxSem: ahh sorry i thought you were talking about another module [19:27:24] so https://gerrit.wikimedia.org/r/#/c/56887/6/includes/skins/SkinMobile.php can take care of this [19:27:50] we can just call addModuleStyles for css [19:28:43] MaxSem: actually.. how does the site module get added to the page? [19:29:22] MaxSem: how does mediawiki desktop do it - does it add css with js? [19:31:08] jdlrobson, [19:31:19] so I think we should do the same [19:31:36] I'll do that as part of my tweak to that commit [19:31:56] MaxSem: be careful not to add css twice... [19:33:56] YuviPanda, there's no way to override the mysql host using an env var anymore? [19:34:07] jgonera: change it in your config [19:34:23] yeah, but then I have to be careful not to push it ;) [19:34:27] and git add -p or commit -p in the end [19:34:28] yeah :) [19:34:37] -p? [19:34:46] --patch? [19:35:01] oh ok [19:36:24] jdlrobson, ugh. OutputPage goes as far as constructing the site module link by hand. I think I\ll just add it to the top to avoid sudden style changes once the bottom CSS is loaded [19:40:04] YuviPanda, this is getting more difficult... am I also supposed to create a file called /a/.my.cnf.research to run this locally? [19:40:19] jgonera: change that too? [19:40:32] what's in that file anyway? [19:40:36] I mean [19:40:39] what's the syntax [19:40:43] jgonera: it's an ini file [19:40:45] mysql configuration [19:41:17] New patchset: MaxSem; "Bug 46480: Enable mobile site module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [19:41:21] jdlrobson, ^^^ [19:42:00] jgonera: it's standard mysql client config. let me find an example [19:42:24] YuviPanda, thanks, would appreciate that since I don't think I have access to kripke now [19:42:32] rawr, hashar keps adding more checks to jenkins faster than we can fix them [19:42:33] this is on stat1 [19:42:41] oh [19:42:42] but yeah, let me get that [19:42:44] then I can check it [19:42:48] jgonera: okay :) [19:43:04] no I cant :/ [19:43:05] cat: /a/.my.cnf.research: Permission denied [19:43:20] jdlrobson, so can we move forward with https://gerrit.wikimedia.org/r/#/c/55446/ ? [19:43:31] jgonera: yeah, I think it's permission restricted [19:43:35] jgonera: do you have the password? [19:43:39] to the research account? [19:43:48] YuviPanda, I think I do [19:44:07] jgonera: http://dpaste.de/UMiZQ/ [19:44:11] that should be the content [19:44:22] and replace password with password [19:50:41] YuviPanda, last one: can I somehow disable the commons db graphs? [19:50:56] jgonera: take them out of the config file, they won't run [19:51:17] they do, and I get an error that generate.py raises [19:51:27] ValueError: No such database: "commons" [19:51:50] It's commonswiki_p [19:52:32] I'll just edit generate.py for now... [19:55:50] [Commons-iOS] montehurd opened pull request #35: Cleanup of Login Screen and Created new Settings screen (master...loginLayout) http://git.io/rUEAJQ [19:59:08] oh god... again limn shows nothing [20:00:21] jgonera: yeah, I never managed to fix that one [20:18:44] New review: Dr0ptp4kt; "This is prep work for https://gerrit.wikimedia.org/r/#/c/57553/." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/57554 [20:40:10] jdlrobson, are you kicking off the sprint? [20:40:24] jgonera: yup [20:41:35] is there a lot to estimate? I'd just prefer to avoid closing everything and switching to Windows for the hangout. I think I'll try to participate with my video and sound disabled and I'll write when needed [20:42:10] food and be back [20:43:37] jgonera: that should be fine. you can give your estimates over irc ;-) [20:45:24] MaxSem: i mailed my Buenos Aires story to wikitech. Now you'll know what happened [20:46:20] :) [20:48:39] err [20:48:45] mobile-tech :) [20:48:46] fun times [20:48:58] jgonera, can you estimate this one real quick? https://mingle.corp.wikimedia.org/projects/mobile/cards/482 [20:53:48] tfinc: have you been following the generalist tech task conversation? [20:54:19] jdlrobson: i see it but have not read it [20:54:29] tfinc: roger. we can talk about it later. [21:02:39] jgonera: you around? [21:02:51] yes [21:02:57] looking at 482 [21:03:51] Maryana, I estimate that as a 2 or 1 [21:04:10] awesome, thx! [21:05:03] jgonera: are you joining the hangout or just staying on irc? [21:05:17] trying to join now [21:07:42] ragesoss: why is this being flagged for deletion http://commons.wikimedia.org/wiki/File:Lead_Photo_For_Zuni_Cafe0-8158609459642321.jpg ? i have it cited as own work [21:08:02] and the author is listed [21:08:40] jdlrobson, is the chat window open in hangout? I'll type sth occassionally [21:08:49] jgonera: yup got it [21:58:21] New patchset: Jdlrobson; "Fix search (bad merge): Rename to #searchInput" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58227 [22:00:51] jdlrobson https://mingle.corp.wikimedia.org/projects/mobile/cards/478 [22:02:21] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57216 [22:02:41] New patchset: Jdlrobson; "Make special pages declare their modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56886 [22:02:41] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [22:04:59] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58227 [22:06:21] New patchset: Jdlrobson; "Regression: Fix menu button on watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58229 [22:08:04] New review: Massaf; "Is this deployed anywhere? Can we see it?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [22:18:18] MaxSem: nooo don't add opera mini support! [22:19:07] if we don't stop bikeshedding, I will unleash a crowd of angry ops yelling "PERFORMANCE" at us;) [22:19:44] MaxSem: you bikeshedded ! we were good! :) [22:20:12] nah, I addressed a couple of CR concerns [22:22:17] I really haven't got the bandwidth to have to support Opera Mini right now. [22:23:04] have you read my coment? we don't need to care about supporting it, we just serve it JS and forget about it [22:23:40] jdlrobson, ^^^ [22:24:03] also, it's not just for mobile, it's now for all of MW [22:24:22] MaxSem: so this will break search for opera mini 4 [22:24:29] ? [22:24:35] MaxSem: yeh but opera mini should redirect to mobile anyway [22:24:42] so the experience won't be any different [22:25:00] and we should think of mobile and desktop as the same [22:25:07] so why care about it? [22:25:12] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=36381 [22:25:16] I don't see the logic [22:25:47] I think we should be more explicit in what we support [22:26:49] okay, how about allowing only 7+? [22:27:45] also, that bug isn't really relevant because we don't have a non-jQ mode anymore, JS will simply die on it [22:28:04] ...before it does any harm [22:28:16] New review: Jdlrobson; "MaxSem - no all HTML was previously injected so no HTML changes in this patchset." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [22:28:37] MaxSem: if you must enable it for 7+ only I just don't want to create more unnecessary work for us [22:28:48] MaxSem: and that's not true [22:28:52] JS can die mid execution [22:29:00] so it can be half done [22:29:27] for instance in the toggling code it might close sections then die on an error and those sections won't be expandable [22:29:56] but certainly we can't allow support for 4,5,6 [22:30:02] ok [22:30:08]