[00:00:06] jgonera: you running latest core? [00:00:19] I guess, at most from a few days ago [00:00:32] if i amend toggle.js to exit if content is undefined it works fine [00:02:39] jgonera: have you tried Chromium / Chrome for hangouts? A few months ago all the hangout problems in Linux cleared up for me with Chromium (but not Firefox) [00:03:14] ragesoss, I did, it's just the open source driver for gpu + cheap webcam with crappy Linux drivers [00:03:21] but I'm getting my laptop back tomorrow [00:03:29] ah. [00:04:18] jdlrobson, did you see all the LOST messages? [00:04:26] not sure what those are [00:04:27] yurik: ? [00:04:31] https://gerrit.wikimedia.org/r/#/c/57553/ [00:04:33] ohh jenkins bot? [00:04:38] yep [00:04:43] but sounds scarry [00:04:46] i'm sure you broke something [00:04:48] not sure what :) [00:04:51] yeh i've seen that a lot today [00:04:54] not just here.. [00:05:03] https://gerrit.wikimedia.org/r/#/c/55446/ [00:05:26] asking in mediawiki [00:05:45] jdlrobson, but in both cases you were the one merging... i'm sure you are to blame :-P [00:05:50] haha [00:05:56] wouldn't be the first time [00:10:50] yurik: apparently it's sick [00:11:01] jgonera: i have no idea why toggle.js is loading before anything else [00:11:08] (fixtures.js specifically) [00:11:10] it's very oddd [00:11:20] jdlrobson, "it" == gerrit? [00:11:26] yurik: yup [00:11:27] /jenkins [00:11:38] what error does it give you? something related to fixtures missing? [00:11:39] as long as it recovers and doesn't die [00:11:48] ok, let's see if i get any responses on my new captcha stuff… i'm actually beginning to like the idea of a big refactor ;) [00:12:53] jgonera: i think what is happening is mobile.toggling module is loading before mobile.tests.base [00:13:12] oh... [00:13:26] that might be happening [00:13:33] I'll prepare a fix for tomorrow [00:14:59] jgonera: a tacky way to get round it is to add a 0. prefix to mobile.tests.base :) [00:15:37] I'm not sure, I think the loading order is non-deterministic still, or otherwise why would it work on my dev env as it is? [00:18:24] so i have it working on my local instance now.. [00:18:42] well… cookie module is not working now :-S [00:19:32] jgonera: if i resubmit a version of your patch can you test something for me? [00:20:09] oh, the cookie module for some reason often stops working for me in tests after a bigger change and then works again when I refresh... [00:20:36] sure, resubmit, I'll try to test but if it gets longer I'll probably pass out ;) [00:22:27] New patchset: Jdlrobson; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [00:22:30] so jgonera this works for me ^ [00:22:45] what files change? [00:23:15] jgonera: http://pastebin.com/WVGNYt2r [00:23:36] hacky i know [00:23:47] but in the interest of getting this in... [00:23:55] can always add a fixme [00:25:38] other way to do it i guess is clone every module and make that the test dependency [00:25:52] e.g. mobile.toggling.tests is mobile.toggling but depends on mobile.tests.base [00:26:15] mobile.toggling.testmodule depends on mobile.toggling.tests [00:26:17] do we have to clone them? [00:26:39] i'm not sure if there's an easier way.. but it seems the load order varies on environment [00:26:40] I thought about adding tests.base as a dependency for all the modules [00:26:43] you're on linux right? [00:26:45] yes [00:26:59] i guess the default sort is different on mac? [00:27:33] I'm not sure if it sorts anything, I mean, why would it? [00:28:20] New review: Jdlrobson; "Currently broken for me. There seems to be a dependency load order." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/50442 [00:28:36] jgonera: *shrug* [00:28:48] there's something quirky going on [00:28:59] but it makes sense in that mobile.toggling should depend on mobile.tests.base (in its current state) [00:29:13] yeah [00:29:24] the other way to do it is to update mobile.toggling https://gerrit.wikimedia.org/r/#/c/58110/ [00:29:26] :) [00:29:30] then it should die silently [00:29:52] mw.config.set( 'wgInitOnDefine', false ); is the line that is causing the problem - stuff is initializing when it shouldn't [00:30:07] hm [00:31:43] the patchset you submitted works for me, so if it fixes it for you I'd leave it as it is for now, and think about it later... [00:32:06] ok sounds good [00:32:08] let's merge :) [00:32:16] I think it needs rebasing [00:32:39] ergg [00:33:16] CONFLICT (rename/delete): tests/javascripts/modules/test_mf-banner.js deleted in HEAD and renamed in Refactor the way we run mobile JavaScript tests [00:33:18] what changed :-S [00:33:20] so I delete this one? [00:33:28] yep [00:33:35] no need for the tests here now [00:34:57] ooh tfinc just learnt something new http://en.wikipedia.org/wiki/Moonbow [00:35:18] now wondering if this photo of mine is a moon bow - i'm guessing not though http://www.flickr.com/photos/jdlrobson/6178088837/ [00:35:47] New patchset: JGonera; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [00:36:24] nice photo [00:36:39] i've never heard for a moonbow [00:36:57] jdlrobson, rebase [00:36:58] d [00:37:18] fun fact: make qunit on master says Took 17ms to run 0 tests. 0 passed, 0 failed. [00:37:30] but the one from this patchset works (165 tests) [00:38:55] New patchset: Jdlrobson; "Refactor the way we run mobile JavaScript tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [00:39:01] jgonera: just adding a fix me [00:39:06] Took 281ms to run 165 tests. 165 passed, 0 failed. [00:39:26] to the rebased version? [00:39:28] both :) [00:39:48] jgonera: are you running it in desktop mode or mobile mode? [00:40:14] mobile [00:40:22] huh weird. [00:40:37] anyway. [00:41:09] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/50442 [00:41:34] jgonera: can you quickly review https://gerrit.wikimedia.org/r/#/c/58229/ [00:41:42] watch list page button to open menu is broken on master [00:41:53] then go to sleep :) [00:50:15] jdlrobson, just merged your patch [00:50:33] although now that i think of it, your change might need a minor fix too [00:52:00] [Commons-iOS] montehurd opened pull request #36: Make login page logo look better on iPad when keyboard visible. (master...iPadLandscapeLogo) http://git.io/QcObqQ [00:52:27] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [00:52:27] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [00:52:28] New patchset: Jdlrobson; "Use wgMFMode in template name for consistency purposes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58256 [00:52:28] New patchset: Jdlrobson; "Promote addToBodyAttributes to desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257 [00:53:33] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58229 [00:54:50] Change abandoned: Jdlrobson; "Now part of minerva-2 branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56559 [00:58:31] jdlrobson, fixed [00:59:27] let me know if you see any issues. Also, will ask about that test and how to run it [00:59:40] jdlrobson, can you cover the QA meeting tomorrow? [01:00:22] jgonera: sure. I'm pretty sure you are optional for that anyway :) [01:00:48] oh ok, I guess I got used to that when you were away ;) [01:00:51] yurik: jgonera i'm off now :) [01:00:54] i suggest you do same :D [01:00:56] ok [01:00:58] I will [01:01:05] I will work European hours tomorrow [01:01:13] k k [01:01:19] cu [01:01:21] you can dissect minerva- [01:01:36] it's a bit scary but i'd like to merge it after deployment so we can start reaping the benefits :) [02:22:08] so yeah, mobile web is returning a 503. i'm sure someone else has noticed? [02:22:24] Not just mobile [02:22:49] well then. [02:22:50] NORMAL SERVICE WILL BE RESUMED SHORTLY [02:22:58] :P [13:18:50] New patchset: Zfilipin; "Fixed Rake task so it reports failures properly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58129 [13:35:10] YuviPanda, I'm having some problems with adding this graph... I see that lots of things changed and adding only SQL is not enough [13:35:29] how do I generate those JSON files, or should I just copy one of them and change what's needed? [13:35:38] jgonera: copy and change one [13:35:59] jgonera: that was changed a while ago, because ops wants everything puppetized and we can't use limnpy that way [13:36:04] actually I already tried that but for some reason the graph was empty, I must be missing something [13:36:19] jgonera: yeah, limn has shitty diagnostics [13:36:27] jgonera: did you add it to the dashboard as well? [13:36:28] anyway, I noticed some things are wrong in those files, such as some label being always Aug 2012 ;) [13:36:36] yes, it's there, but nothing plotted [13:36:42] I'll tinker a bit more [13:36:46] jgonera: you created both a datasource file and a graph file? [13:36:49] yes [13:37:04] sigh [13:37:04] ;) [13:37:20] maybe we should consider using something non-limn [13:37:24] all the data is publicly available [13:37:24] haha [13:37:26] over http [13:37:41] let's not give up on limn just yet [13:37:46] :) [13:39:07] jgonera: btw, did you get your limn working? [13:39:10] what was the issue? [13:39:26] yes [13:39:30] don't run npm update [13:39:31] ever [13:39:38] heh [13:39:43] millimetric already removed it from readme [13:39:52] ah [13:39:53] nice [13:39:59] i should try setting it up later [13:40:03] I hope it fixes it for you too [13:40:14] jgonera: are you adding navigation timing dashboard? [13:40:30] yes, I'll add one more tab with just one graph for now [13:40:36] sweet [13:40:46] which is event_rendering daily average [13:41:24] I'll still use SQL though because the query is very simple and I don't want to experiment with mongo now [13:41:45] jgonera: we don't have anything with Mongo yet [13:41:57] jgonera: the .py files are there because some queries join data from commonswiki and eventlogging [13:42:04] we can't do cross database cross host joins, afaik [13:42:17] you mean our code doesn't support it, but the data is already in mongo as ori-l said some time ago [13:42:32] uuh [13:42:36] as in, we don't use mongo for any of the queries yet. [13:42:41] yes, I know [13:42:58] if we did maybe I'd use it, but I don't want to write support for it right now ;) [13:43:05] jgonera: :) [13:43:13] jgonera: I'll do that next time I need to add a script [13:43:28] ok, we'll see who's first ;) [13:43:33] :D [13:44:04] jgonera: I should replace all the complex date based SQL stuff with Mongo, I think [13:44:21] New patchset: Zfilipin; "Update to Cucumber 1.2.5 since 1.2.4 was yanked" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58300 [13:44:57] I'd say don't do it now unless you need to change something. I'm all for maintainability, but I sometimes think "don't touch it if it works" [13:45:28] I'm going to eat sth, be back later [13:46:14] yeah, that's why [13:46:19] I said I'll do it next time I touch something [14:45:08] New patchset: Zfilipin; "Upgrade to the latest stable version of Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58304 [15:14:32] New review: Cmcmahon; "wait for specific page" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58125 [15:14:33] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58125 [15:15:26] New review: Cmcmahon; "no longer need to specify beta mode" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58128 [15:15:26] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58128 [15:29:54] RantyPanda: I redid the create account api captcha stuff in response to earlier review notes. gonna bug people to re-review it today and see if they like it this way… [15:30:07] brion: yeah, saw yesterdays losg :) [15:30:11] brion: response being "WHEEEE!" [15:30:15] New review: Cmcmahon; "fix rakefile" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58129 [15:30:16] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58129 [15:30:16] :) [15:30:23] :) [15:31:08] brb foooood [15:31:38] New review: Cmcmahon; "cucumber 1.2.4 removed, go to 1.2.5" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58300 [15:31:39] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58300 [15:34:09] New review: Cmcmahon; "update FF version" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58304 [15:34:09] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58304 [16:08:24] Change abandoned: Jdlrobson; "This code is now in ZeroRated extension so this patch is no longer relevant to MobileFronten project." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/57432 [16:30:01] HandSanitizer, I initially read Ranty as Party:P [16:30:37] MaxSem: :D some friends of mine on another channel read it as a slight variation on the word Party [16:30:40] they found it hilarious [16:44:46] off to the office... [16:44:59] alliterative brion [16:45:15] alliteration? awful [16:45:42] off to the office is awful alliteration? [16:48:44] legoktm: ragesoss apple rejected the iOS build brion sent them :( [16:48:46] meh [16:48:50] :(((( [16:48:52] why? [16:49:40] legoktm: idk yet [16:49:48] haven't you read any of the dozen or so steve jobs hagiographies? being an inscrutable jerk fosters excellence, apparently [16:49:53] :) [16:50:08] ori-l: legoktm the last time they rejected the wiki app because we mentioned that we removed google maps [16:50:21] apparently using the word 'google' is grounds for automated removal [16:50:25] but *after* 2 weeks [16:50:29] lololol [16:50:50] legoktm: it's funny to talk about, but honestly, as a developer, it's fucking pissing off [16:50:54] to say the least [16:51:46] now would people who use Apple products raise their hands please?;) [16:51:56] * legoktm raises his hand 3 times [16:52:11] hey, I haven't paid a dollar to apple *after* i started developing for them [16:52:12] and won't [16:52:51] but as soon you had a bit money, you bought a MacBook [16:53:05] thus you funded the evil empire [16:53:23] they now use your own money to oppress you [16:53:30] MaxSem: well, the previous company I worked for got me the Macbook air as a 'bonus' [16:53:37] and then I quit at which point they asked me to pay for it [16:55:40] hey mhurd [16:55:48] apple rejected the build brion sent 'em :( [16:55:50] hey yuvi! [16:55:55] gah really? [16:56:07] whee http://www.lenovo.com/products/us/laptop/ [16:56:08] mhurd: yeah, just got hte email [16:56:12] they can be so picky [16:56:40] that's one of the words you can use, yeah :) [16:56:44] hehehe [16:57:13] glad to see yesterday they streamlined some of the provisioning nonsense - got an email announcing they'd done so [16:57:20] mhurd: wtf [16:57:25] mhurd: "We began the review of your app but are not able to continue because we need a demo account to fully access your app features. " [16:57:27] sigh [16:57:32] ooooh [16:57:47] heh [16:58:03] ya they want it all laid out - the real estate app i did had to include demo acct info w the submission [16:58:22] yeah, I can understand that [16:58:27] that's actually a pretty quick turn-around though [16:58:31] in my experience [16:58:35] for them haha [16:58:44] mhurd: the last time we got rejected because we mentioned that we added OSM support instead of Google Maps [16:58:46] registering is too thought-intensive for them? [16:58:49] they rejected for using the G word. [16:59:05] haha really??! [16:59:08] sigh [16:59:25] mhurd: be prepared for lots of jibes at Apple :) Lots of people are not fans around here, despite the extreme prevelance of macbooks [16:59:55] MaxSem: to be fair the app doesn't do registration yet [17:00:06] ohohoh [17:00:13] pwn3d [17:00:42] hehe [17:00:55] mhurd: the trello card, I'm going to do some re-org. [17:01:24] s/card/board/ [17:01:32] meh, nevermind. not no [17:01:32] i sympathize with where the non-fans are coming from so it's all good [17:01:33] w [17:01:52] mhurd: :) [17:02:07] i'm pretty happy with the trello interface [17:02:15] mhurd: yeah, so what I was going to try [17:02:22] mhurd: was to get rid of the Android /iOS / other lists [17:02:27] mhurd: and use labels for those instead [17:02:30] so we can use filters [17:02:32] when we want [17:02:45] filters are good! [17:03:40] yep [17:05:00] YuviPanda: whydid it get rejected? [17:05:09] ragesoss: oh, apparently they need a 'test username and password' [17:05:24] heylo Maryana [17:05:26] heh [17:05:48] heyhi yuvipanda :) [17:06:21] hey Maryana :) [17:07:17] Maryana: just to note, iOS first round rejected by apple, because they want test credentials. I guess we'll resubmit today. [17:07:57] ah, good to know [17:08:05] further reason to push back apps marketing [17:08:28] Maryana: sigh, yes. I really hope we get a good amount of it in before I leave, though [17:09:16] oh, that's right, you're not working in may [17:09:24] sadly, yes. [17:09:37] I need to sacrifice a month if I want to attempt to move there. [17:15:10] Maryana, regarding https://mingle.corp.wikimedia.org/projects/mobile/cards/478 - I've added it to http://staging.wmflabs.org/wiki/Main_Page can you check this out? [17:15:44] also, is this image supposed to be precomposed or something? [17:16:25] the angles look not round enough for precomposed, while non-precomposed images shouldn't have a background, in theory [17:18:08] MaxSem: will you be deployed Zero extension today with MFE? [17:18:28] I can if needed [17:18:40] MaxSem: it's needed since we moved the code/css from mobile to zero [17:18:52] np [17:18:56] thanks MaxSem [17:19:03] i assume you know which core changes are needed? [17:19:14] just startup.js one i think :) [17:19:19] besides the startup lulz? [17:26:16] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/0cpMbw [17:26:16] android-commons/master b62f14c YuviPanda: Add minimal About activity [17:28:08] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/V8g03w [17:28:08] android-commons/master 1d603cd YuviPanda: Add missing preferences xml file [17:28:20] Maryana: do we have the acceptance review today? Seems like there's little to accept.. [17:34:28] jcmish, it doesn't look like we have any design stuff to look at today [17:34:38] I know! [17:34:56] I am still testing on betalabs though [17:35:00] just to make sure I don't see any regressions [17:35:09] ok, sweet [17:35:24] I'll just keep doing that and give an all clear or raise issues [17:35:55] thanks :) [17:37:56] Maryana, regarding https://mingle.corp.wikimedia.org/projects/mobile/cards/478 - I've added it to http://staging.wmflabs.org/wiki/Main_Page can you check this out? [17:38:14] maxsem, excellent [17:39:19] hmm, but how do i check? [17:39:26] add staging to my home screen? [17:40:15] yup [17:41:41] beautiful! [17:41:47] thank you, maxsem [17:42:01] Maryana, but that image is too large [17:42:12] we need to downscale it [17:43:17] is it? looks the same size as my other icons [17:44:46] the underlying image is 512 x 512 [17:44:58] which is too much even for retina [17:47:12] i'll let munaf know [17:49:48] my ears are burning [17:51:59] hey MaxSem [17:52:06] just looking at the icon now in Maryana's screenshot [17:52:07] hey munaf [17:52:15] i think i want to do 3 changes [17:52:29] 1. make the W darker [17:52:36] 2. make the black inner border a bit thicker [17:52:40] 3. resize as needed [17:52:45] cool [17:52:57] what's the correct size? i thought i found 512x512 as the required retina size [17:56:29] actually (2) won't happen. it's a bad idea with apple's auto rounding of icons. [17:57:45] http://www.vickiwenderlich.com/2012/09/app-icon-size-reference-chart/ MaxSem [17:58:45] munaf, I don't see 512 here at all [17:58:59] munaf: isn't that for the apps? [17:59:02] yep, i was wrong about that. finding conflicting information [17:59:28] the apple docs are http://developer.apple.com/library/safari/#documentation/UserExperience/Conceptual/MobileHIG/IconsImages/IconsImages.html#//apple_ref/doc/uid/TP40006556-CH14 [17:59:51] in "Web clip icon (recommended for web apps and websites)" the maximim is 144 x 144 [18:00:37] yep. i assumed that they required the same size for touch icons as they did for apps. wrong :-) thanks max. [18:03:54] updated on mingle. [18:03:58] https://www.dropbox.com/s/geray0mc650zgwp/apple-touch-icon-114x114.png MaxSem [18:10:38] munaf & Maryana, updated on staging [18:12:00] oh yeah, that does look more crisp [18:12:32] ok, preparing a commit [18:13:22] munaf, just sent you another screenshot [18:17:45] jcmish: you about / [18:17:46] ? [18:17:48] munaf, there's the same touch icon for both mobile and desktop sites, is it ok to change them both? [18:18:02] I am! [18:18:08] (otherwise, some trickery is required) [18:18:12] how goes it 007 [18:18:26] jcmish: he's never going to live that down, is he? :) [18:18:39] no not if I can help it! [18:18:40] RT 4600 for michelle grover to get shell access to cluster + stat1 access specifically. We need her to put her public ssh key on her office user page [18:18:40] 11:17 RobH [18:18:40] so if you happen to chat with her later (since you approved her access) [18:18:44] jcmish: --^ [18:18:51] yup I'm doing that right now [18:18:56] maxsem, only if you can handle the wrath of core contributors... [18:19:22] eww, who let ops into our channel? :) [18:19:27] tfinc: do I have to add it to the ticket? [18:19:28] MaxSem I'm happy to change them both but yeah, Maryana has a point [18:19:40] or can I just "reply" to the email? [18:19:49] against whom do we need to check? [18:19:58] i'm not really sure.. [18:20:01] jcmish: put it up on your office wiki user page and then update the rt ticket with a link to it [18:20:02] but you can bet someone will freak out [18:20:05] jcmish: you can just reply to the email after adding it to your officewiki page [18:20:16] jcmish: do you need any help generating ssh keys ? [18:20:20] cool [18:20:31] they always freak out (that word exactly) [18:21:12] tfinc: I have it [18:21:23] so I'm good [18:21:27] had to do them to use gerrit [18:22:31] YuviPanda: you gonna stay up to hear Blaine? [18:22:47] Maryana, maybe Brandon is that person?:) [18:23:15] i don't think so.. it's probably some random developer-inclined folks in the community [18:23:19] huh? [18:23:30] MaxSem this particular freakout might have some validity. we'd be making the W wikipedia's symbol across all languages. [18:23:41] jdlrobson: unsure. i'll know in an hour [18:23:54] do you happen to know who "owns" the desktop favicon, jorm? [18:24:41] munaf, good point. let's not get into that hornet's nest until we have a better understanding of the feature. where does it even appear on desktop? [18:24:54] jorm, we're changing the apple touch icon for the mobile site and wondering if we shgould change it for desktop too - as it looks ugly: http://bug-attachment.wikimedia.org/attachment.cgi?id=11789 [18:25:11] squished puzzle globe is sad :( [18:25:34] I don't know if anyone "owns" it (I think I made a commit about it many moons ago) but the problem isn't goign to be from core. it's going to be language engineering. [18:25:49] for languages like Kannada and such. [18:26:47] yeah [18:26:54] is it? cause they use the same W favicon [18:27:27] do they? [18:27:39] https://kn.wikipedia.org/wiki/ಮುಖ್ಯ_ಪುಟ [18:27:58] anyway, if there is a chance of uprising, I'll just make it specific for mobile [18:28:12] http://bits.wikimedia.org/favicon/wikipedia.ico [18:28:20] yeah, that makes sense, maxsem [18:28:21] holy smokes. everyone links to that. [18:28:21] yeah everyone uses that favicon [18:28:23] chinese, etc [18:28:43] i mean, i guess it's the best branding we've got [18:28:48] however the touch icon is still the blue globe underwater. [18:28:58] short of sad eyes jimmy [18:29:34] that apple touch icon needs updating ANYWAY. [18:29:37] it's the wrong icon. [18:29:54] http://ka.wikipedia.org/apple-touch-icon.png <--- version 1.0 [18:30:07] lol [18:30:13] you can tell it's the wrong hero glyph because of the klingon character. [18:30:24] the best moment to sneak in a change:P [18:31:07] this is the icon that shows up when you do the "turn this web page into a launch app" song and dance? [18:31:48] http://bug-attachment.wikimedia.org/attachment.cgi?id=11789 [18:32:54] okay. [18:33:25] This should be the globe, then, if it's going to be a "global" app language. We have higher resolution to play with than a favicon. [18:34:06] * jorm hates the globe as a logo but only about half of the wikipedia's pronounce the word "Wikipedia" with a "W" or even know what a "W" is. [18:34:51] i talked about it with jay. tl;dr, *nobody* knows what the globe is, and we're not going to be using it as branding going forward [18:34:55] ok, I'll back it off for now [18:35:11] maxsem, the w is fine [18:35:18] it's not ideal, but it's the best we've got [18:35:25] and it's better than sad squished globe [18:35:31] if people complain, direct them to me and jay :) [18:36:06] per jorm, it's not that simple. we can wait a couple of days while a ML RFC is being run [18:36:59] there is also a single puzzle peice. [18:37:16] (we don't have to deploy this on our window, any 5 free minutes are ok) [18:37:27] our brand recognition goes: Wordmark > W > Puzzle piece > Puzzle Globe [18:37:27] again, though, you'd have to understand the globe bit before you got why a puzzle piece = wikipedia [18:37:48] yeah, and i'm not sure if this brand survey was done world wide or with english speakers only. [18:37:51] sec. lemme find it. [18:38:09] maxsem, which mailing list would you hold an RFC on? [18:38:16] mmm [18:38:26] you'd have to find one with enough non-english speakers to validate the hypothesis [18:38:29] wikimedia-l? [18:38:43] hmm [18:39:01] we all talked it over with jay and he seemed to be OK with the W. it's also been the favicon for all languages forever. [18:39:13] point ^ [18:39:31] also, the people who are likely to be unhappy with the change probably won't respond to an RFC [18:39:42] but they might file a bug if they're really unhappy [18:39:45] fully 3D pieces simply don't reduce well to icon sizes anyways. [18:39:51] i'd rather just do it and then change it if people complain [18:39:55] jdlrobson: do you have the ether pad link to our generalist job notes ? i can't find mine [18:39:57] than worry about potential hypothetical complainers [18:40:02] if that makes sense :) [18:40:46] this appears to be a WIP: http://wikimediafoundation.org/wiki/Visual_identity_guidelines [18:41:22] tfinc: all in the email thread - http://etherpad.wikimedia.org/kZaM0swM4c [18:41:23] the wiki is a WIP. [18:41:30] talk to jay [18:41:36] thanks [18:42:47] http://wikimediafoundation.org/wiki/Visual_identity_guidelines#toc-w appears to support W instead of puzzle globe [18:42:51] The ‘W’ is intended to evoke the Wikipedia brand in applications where limited space, aesthetics, or other constraints prevent the use of the Wikipedia puzzle globe and stylized text. Common usages might include mobile devices, web browser bookmark bars, and small branded merchandise. [18:42:54] yep [18:42:59] works for me [18:43:16] Thank you Maryana! [18:44:06] I just got into the conversation. We should also have a larger discussion with Jay and record any current conclusions to avoid confusion. [18:44:27] Yeah. So point to that doc if anyone complains. [18:44:33] thx d00d [18:46:49] vbamba, yeah, good call [18:47:30] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/4AlC7A [18:47:30] android-commons/master d76541c YuviPanda: Add way to send feedback via email [18:48:11] Project Android-Commons (mobile) - Nightly builds build #141: SUCCESS in 53 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/141/ [18:48:12] * yuvipanda: Add beta string to string resources [18:48:12] * yuvipanda: Removed unused file [18:48:12] * yuvipanda: Bumped to v1.0beta2 [18:48:13] * yuvipanda: Removed invalid reference to Login for Label [18:48:13] * s.mazeland: Localisation updates from http://translatewiki.net. [18:48:14] * yuvipanda: Remove 3+ letter code localizations [18:48:14] * yuvipanda: (hopefully) fix random crashes caused by reading parcelable wrong [18:48:15] * yuvipanda: Rename hebrew from he to iw (Android uses deprecated values) [18:48:15] * yuvipanda: Minor fix to README [18:48:16] * s.mazeland: Localisation updates from http://translatewiki.net. [18:48:16] * yuvipanda: Symlink -he to -iw [18:48:17] * yuvipanda: Bumped version number & added CHANGELOG [18:48:17] * yuvipanda: Append extension in code rather than leave it to the server [18:48:18] * yuvipanda: Never show file extension in display title of images [18:48:18] * yuvipanda: Make sure that notifications do not display the file extension [18:48:19] * yuvipanda: Do not crash if Android doesn't know the mimetype of the file [18:48:20] * yuvipanda: Refactored StartUploadActivity to it's own separate class [18:48:31] * yuvipanda: Don't re-request authKey on screen rotates for AuthenticatedActivity [18:48:31] * yuvipanda: Properly check for action being sent [18:48:32] * yuvipanda: Fix styling on 2.3 [18:48:32] * yuvipanda: Fix source not being set, causing EL to fail [18:48:33] * yuvipanda: Slightly more robust uploading [18:48:33] * yuvipanda: Add constructor to StartUploadTask that takes a contribution [18:48:34] * yuvipanda: Add isMultiple tracking parameter [18:48:34] * yuvipanda: Enure that db migrations are done properly [18:48:35] * yuvipanda: Bump version number and update CHANGELOG [18:48:35] * yuvipanda: Add item missed in CHANGELOG [18:48:36] * yuvipanda: Cleanup Imports [18:48:36] * yuvipanda: Set user name properly for multiple uploads! [18:48:37] * yuvipanda: Bumped version number & updated CHANGELOG [18:48:37] * yuvipanda: Do not hardcode service name in HandlerService [18:48:38] * yuvipanda: Pushed out v1.0beta5.1, updated changelog [18:48:38] * yuvipanda: Added RELEASE-CHECKLIST.md, to help prevent sadpandas [18:48:39] * yuvipanda: Fix UploadService to have appropriately instantiable constructors [18:48:39] * yuvipanda: Remove unused androlog dependency [18:48:41] holy shit. [18:48:44] ahh! [18:48:51] * yuvipanda: Add post-upload categorization to Multiple Upload [18:48:51] * yuvipanda: Make explanatory category text work for both singular and plural [18:48:52] * s.mazeland: Localisation updates from http://translatewiki.net. [18:48:52] * yuvipanda: Trim whitespace in one of the messages [18:48:53] * yuvipanda: Disable the multi upload photos view while adding categories [18:48:54] * yuvipanda: Add Categorization EventLogging [18:48:54] * yuvipanda: Fix crash on 2.3 during categorization [18:48:54] * yuvipanda: Remove RuntimExceptions on transient errors [18:48:55] * yuvipanda: Fix ghost keyboard issue with multiple uploads [18:48:55] * yuvipanda: Automatiaclly turn on the Modifications Content provider [18:48:56] * yuvipanda: Updated CHANGELOG and bumped version number [18:48:56] * s.mazeland: Localisation updates from http://translatewiki.net. [18:48:57] * yuvipanda: EventLogging network failure is silently ignored [18:48:57] * yuvipanda: Minor case fix to be consistent across template parameters [18:48:58] * yuvipanda: Add a boolean pref to disable EventLogging based tracking [18:48:58] * yuvipanda: Turn EventLogging *on* by default [18:48:59] * yuvipanda: Add a settings screen, with a preference to disable tracking [18:48:59] * yuvipanda: Track changes to the preference for tracking changes [18:49:12] sorry [18:49:13] i like to think yuvipanda is just an incredibly fast hacker. [18:49:14] about the spam people [18:49:16] MaxSem: can you quiet the thing? [18:49:18] well [18:49:20] only 3 more commits [18:49:22] hehe :P [18:49:41] yuvipanda - put. the coffee. down! [18:50:07] :D [18:50:19] MaxSem: did you +q it? [18:50:22] or something? [18:50:24] or did it just stop? [18:50:25] not yet [18:50:33] hmm [18:50:41] was that really enough commits ot crash jenkins? [18:50:48] * YuviPanda goes to look [18:51:01] heh [18:51:03] there was a bug in gerrit causing jenkins fail [18:51:05] poor jenkins [18:51:11] aparently, they fixed it:) [18:51:13] overworked and underappreciated [18:51:23] https://integration.mediawiki.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/141/ [18:51:24] it succeeded [18:51:36] but the IRC tihng crashed [18:51:36] i guess [18:52:12] legoktm: is there a channel where bot owners hang out? [18:52:22] just generally asking [18:52:34] well there's #pywikipediabot, and enwiki has #wikipedia-BAG [18:52:39] dewiki has their own channel too [18:53:16] hmmm [18:53:17] ok [18:54:01] hmm, pywikipediabot looks especially small [18:54:50] it's bigger than -bag :P [18:55:08] heh :P [19:48:03] 10 minutes alert, boys and girls!:) [19:49:45] * awjr waves [19:49:59] awjr! [19:50:03] \o/ [19:50:12] you feeling ok? [19:50:20] meh, hangin tough [19:50:34] heyyy awjr [19:50:34] i can't tell if it's really bad allergies or a cold [19:50:39] what's up MaxSem! [19:51:12] brion, so the apple folks couldn't figure out how to create an account on commons? [19:51:18] yeah [19:51:25] i put the login link in the review comments [19:51:30] from the people who brought you the one-button control interface... [19:51:31] but apparently they want an actual username/password [19:51:32] srsly [19:51:37] it was insanely windy in AZ yesterday and i got caught in a crazy dust storm yesterday on my way home from CA - im hoping it just really aggrevated my allergies and i'll be feeling better tmrw [19:51:51] Maryana: http://www.theonion.com/video/apple-introduces-revolutionary-new-laptop-with-no,14299/ [19:52:05] hehehehe [19:52:12] but figured i'd hang out, catch up on emails, and help test for the deployment [19:52:42] your body just wants you to go back to cali [19:52:52] awjr: bummer [19:52:52] it's nice and temperate and there's no dust! [19:53:48] hehehe Maryana - it was pretty damn dusty where i was out in the mojave desert, but was also absolutely gorgeous :) [19:54:04] jealous! [19:54:06] i've wanted to go camping there for ages [19:55:51] YuviPanda: poke [19:55:59] it is EPIC, Maryana - we go out there every year for friends/extended family reunion around easter [19:56:03] brion: ping [19:56:07] awjr: sympathies. I've been sick the past three days. [19:56:10] YuviPanda: is the black background on the android commons login screen just for the beta releases or is that meant as the standard? [19:56:14] boooooo jorm :( [19:56:16] awjr: yeah, apparently AZ dust decided to annex CO: http://durangoherald.com/article/20130408/NEWS01/130409632/-1/News01/It%E2%80%99s-raining-mud [19:56:20] jdlrobson: thanks so much for talking to mark and gang [19:56:26] i'd tell you about it but it's pretty friggin' gross. [19:56:30] that's awesome news [19:56:42] me and mhurd are updating dialog styles to match android better and also look awesome with animations ;) [19:56:50] brion: android has no animations yet ;) [19:56:53] where i say "me and mhurd" i mean "i'm reviewing mhurd's code" :) [19:57:03] oh wow chrismcmahonafk - yeah it was pretty wild yesterday. there were a few times where i had to totally pull off the freeway and wait due to whiteout conditions [19:57:06] brion: i think for now i'm trying to match android holo default as close as possible [19:57:16] brion: but eventually we'll want to have our own color scheme and use that [19:57:19] jorm: thanks for sparing me the details :p hope you're feeling better soon [19:57:22] brion: i don't like how the current background is [19:57:29] brion: so feel free to not mimick the colors :) [19:57:32] i liked the designs we saw that one time in that one meeting. the ones with the kind of "trays" for inputs. [19:57:33] :) [19:57:42] jorm: it's the same now [19:57:46] YuviPanda: should we aim for dark or light theme? we can do either, just as with holo light & holo dark [19:57:48] np jcmish [19:57:50] jorm: except it's black background instead of white [19:58:01] brion: i'd say dark [19:58:16] awjr MaxSem: did you get back to mark's mail? [19:58:17] mhurd: dark it is then :) [19:58:31] sounds good! [19:58:36] green text on black. [19:58:38] brion: because our primary content is images, and in general the default color combinations for the 'dark' theme seem to be able to handle those well [19:58:42] jdlrobson: i just saw it - what are the varnish changes he's talking about (MaxSem)? [19:58:43] fuckin' *old school* [19:58:48] haha [19:58:50] jdlrobson, yup - we agreed to do full-scale deployment next week, but I'm permitted to flip it on testwiki today [19:58:59] jorm: hehe :D It's blue + white on black (android default) now. [19:59:02] MaxSem: is this for RL stuff? [19:59:05] yup [19:59:09] awesome [19:59:14] that's exciting [19:59:24] jorm: I want to modify the color scheme, however. Don't like the current one. should poke vibha about it [19:59:26] brion: mhurd ^ [19:59:51] mhurd: brion if we start working on something that isn't in the trello card, i think we should just add 'em and move it :) [20:00:05] to make sure that eventually, done and doing are accurate [20:00:14] yeah [20:00:17] easy to add cards [20:00:19] ya [20:00:33] sweet :) [20:00:54] mhurd: brion okay, imma spend 5 mins rejigging them a bit [20:03:17] are we still planning to disable the photo upload CTA today? [20:04:24] yes [20:04:27] brion: mhurd check it now [20:04:29] jdlrobson, ^^ [20:04:30] oh wait [20:04:39] awjr: yes please [20:05:53] brion: mhurd try now [20:05:59] brion: mhurd filter cards :) [20:07:04] ooh [20:07:52] YuviPanda: the Android column now includes non-Android things. did you want to rename it? [20:07:56] awjr, can you review https://gerrit.wikimedia.org/r/#/c/58043/ ? [20:08:05] brion: done [20:08:11] brion: they're color coded [20:08:14] brion: see filter cards [20:08:49] ooooh nice [20:09:01] sure MaxSem [20:09:25] brion: we can remove the tag prefixes, if you find the color coding sufficient [20:09:26] meanwhile, the changes are live on testwiki, please test:) [20:09:36] brion: less clutter [20:09:37] nah i like visible tags [20:09:40] i never remember the colors [20:10:06] brion: yeah, let's keep 'em both for now [20:10:08] then [20:10:13] brion: we can use the labels for filtering [20:10:16] and the visible tags [20:10:21] for visibility [20:10:31] visible tags are visible [20:10:31] err [20:10:34] readabilitity :P [20:10:35] but yeah [20:10:38] they are : [20:10:41] nice!! [20:10:59] brion: mhurd do leave comments on the mobile-tech thread [20:13:51] brion: mhurd are you happy wtih the current logo? [20:14:00] brion: mhurd I wonder if we should make a new one [20:14:02] hey jgonera [20:14:08] hi [20:14:16] YuviPanda: the app launcher icon? [20:14:19] brion: yeah [20:14:24] hhhmmm... [20:14:24] looks ok to me [20:14:32] hmm, it feels a little... odd [20:14:33] well it's our freakish logo anyway :) [20:14:36] true :) [20:14:37] hehe [20:14:45] our non-square taller-than-wide logo [20:14:53] jgonera: I left a review on the generate.py patch [20:15:11] ok, will have a look now [20:15:43] mhurd: what do you think? [20:17:17] MaxSem: lgtm [20:17:24] thanks! [20:17:57] i was thinking maybe try the splash logo (the one with the "Wikimedia Commons" text below it) [20:18:10] for the launcher [20:18:11] ? [20:18:14] hey Maryana [20:18:26] for the logo above the login text boxes [20:18:28] Maryana: I'm wondering how to best organize with vibha. Should we just add her to the trello board? [20:18:33] mhurd: ah, right. [20:19:02] i've been using trello w/design - they have their own mobile design board, which you're welcome to add app stuff to [20:19:10] lemme invite you on it [20:19:24] Maryana: ah, sweet [20:19:49] Maryana: hmm, but wouldn't that fragment stuff? Being separate from the app board... [20:19:58] yeah it does a little [20:20:05] YuviPanda: Maryana and I chatted about the app designs yesterday [20:20:17] but we link to every mingle card in its corresponding trello card. for the most part trello is better for keeping track of a design. [20:20:21] and she showed me how the design team manages their backlog [20:20:26] ah! [20:20:36] munaf: we're using trello for the apps team too, no mingle [20:20:54] tfinc: and? [20:20:55] YuviPanda: i think its fine for us to experiment with putting our designs into the design teams trello board [20:21:13] okay [20:21:17] hmm [20:21:29] then someone will have to be responsible for reflecting the changes back in the app board [20:21:32] hmm, that's okay I guess [20:21:46] MaxSem: so it looks to me like the mobile bits changes have been merged and i assume they've gone out already - but we will wait for mark to flip the switch on $wgMFVaryResources? [20:22:02] Maryana: i think you might have to invite ypandian@wikimedia.org (ugh), rather than yuvipanda@ [20:22:05] YuviPanda: i'm happy to own that [20:22:07] awjr, we can flip it on test today [20:22:12] but no more than that [20:22:14] ah sweet. [20:22:16] ok cool MaxSem [20:22:35] we need to test the JS for compat with a lot of devices anyway [20:23:25] yup makes sense [20:23:56] New patchset: Jdlrobson; "Rewrite search as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [20:24:17] YuviPanda: i'll take a look at the trello boards and mail out after i finish this pass on the generalist jd [20:24:27] tfinc: okay [20:24:42] jcmish_, how are we looking? [20:25:56] pretty good [20:26:01] almost done [20:27:06] wait MaxSem we're supposed to be testing right? [20:27:13] yes [20:27:21] ha was just making sure [20:27:32] k back to it I'm on my last set of tests [20:28:02] tfinc that reminds me instead of the testing service [20:28:14] can I just get 2 android devices? [20:28:19] jcmish_: sure [20:28:26] I looked at the cost [20:28:27] jcmish_: what do you need ? [20:28:28] it's cheaper [20:28:43] New patchset: Jdlrobson; "Rewrite search as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [20:28:49] keep in mind that were talking about all of next year [20:28:55] than keeping the service I'm thinking a One note [20:29:11] and an older one that runs 2.2 or so ? [20:29:47] [Commons-iOS] brion pushed 12 new commits to master: http://git.io/-1-Rnw [20:29:47] Commons-iOS/master 8273deb Monte Hurd: Separate settings page. Smooth animations for login page keyboard reveal on iPad and iPhone... [20:29:47] Commons-iOS/master 55d09fe Monte Hurd: Added spinning loading indicator to login page... [20:29:47] Commons-iOS/master 0fc1563 Monte Hurd: Fixed device-laying-flat interface orientation issue... [20:29:59] woo! [20:30:00] sure, thats purely the hardware budget then. can you for certain say that you'll need no external contractor funding for testing ? [20:30:07] mhurd: nice [20:30:14] ah true tfinc [20:30:35] Can you tell me what we spent this year of our budget [20:30:37] ? [20:30:44] New patchset: Jdlrobson; "Rewrite search as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [20:30:57] jcmish_: you + our testing services were our contractor expenses [20:30:58] MaxSem: we look good just finished beta [20:31:04] and alpha [20:31:09] aha [20:31:10] wee [20:31:25] Maryana: ? anything look amiss? [20:31:33] ack, didn't realize we were testing already [20:31:38] oh hahahhaha [20:31:41] on staging, labs, or test.wiki? [20:32:27] tfinc: we should probably hold some back just to be safe [20:32:37] jcmish_: mail me a number and i'll add it [20:32:46] tfinc: will do [20:35:05] Maryana, testwiki [20:35:10] thx [20:35:22] jdlrobson: i took your top jd points into https://docs.google.com/a/wikimedia.org/document/d/14UpyHT4WJDvxtBnkytmGCH_ux0Q1nnq1HsG6-2Xnm6g/edit ... debating on how i feel about it being so short [20:35:26] sigh, I should've pinged everyone like I did before [20:35:34] heh, i do find that useful [20:36:12] New patchset: Jdlrobson; "Deprecate M.utils" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58400 [20:36:35] New review: Jdlrobson; "Needs https://gerrit.wikimedia.org/r/58110 to be merged" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/58400 [20:37:29] awjr: MaxSem can we consider this done or assigned at least - https://bugzilla.wikimedia.org/show_bug.cgi?id=35842? [20:37:31] tfinc: looking [20:38:38] opps sorry Maryana didn't see your question [20:39:37] https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/237 ca n be closed [20:39:38] tfinc: following on from what ori-l and jgonera said it doesn't seem unreasonable to say we expect a github account [20:39:42] it might help with the quality of candidates [20:39:54] everything looks fine to me [20:40:01] jdlrobson: yup. thats already in there [20:40:25] tfinc: before it said that they are useful - now it says it is expected :) [20:40:31] jdlrobson: i think we should close that bug - the initial problem reported was fixed but that bug seems to have grown into something way more [20:40:33] jdlrobson, shouldn't sound like a 100% must have though [20:40:38] awjr: feeling better ? [20:40:45] tfinc: not really :( [20:41:06] tfinc im hoping it's just really bad allergies [20:41:16] awjr: pass me some feedback on the jd i just posted and then go to bed [20:41:21] MaxSem: from what i'm hearing from a lot of people it seems like it is a 100% must have if we want to find the right guy... [20:41:38] tfinc will do after deployment and catching up on some email [20:41:40] some people might use sourceforge etc [20:41:50] jdlrobson: i dont care if its github, sourceforge, etc [20:42:00] some people might kick ass regardless [20:42:14] tfinc: agreed [20:42:22] * YuviPanda writes regex to parse wikitext [20:42:25] MaxSem: citation needed ;-) [20:42:40] * MaxSem kicks jdlrobson's ass [20:42:43] tfinc: MaxSem but if they can't provide any examples of their work that's a bad sign [20:42:47] YuviPanda: feeling masochistic today? [20:42:56] tfinc: there is literally no other way to do this [20:42:57] jdlrobson: yup [20:43:05] github/sourceforge/a website they've done/an app etc etc [20:43:10] so... [20:43:17] thats why we have a whole paragraph for it [20:45:17] Reedy: I can haz Special:Import previlages on testwiki? [20:45:38] Reedy: or, can I request you to import Template:unc along with dependencies from commons to testwiki? [20:45:42] jdlrobson, I still see a CTA - are we removing just some of it? [20:46:28] MaxSem: are you logged in? [20:46:36] yes [20:46:39] log out [20:46:45] heh [20:46:48] we only hide it when your not logged in [20:47:00] Maryana tfinc: what's the current wiki page we use to collect feedback for mobile? [20:47:05] i'm doing some bug triaging [20:47:33] we really don't have a single dedicated one… stuff comes in from all over the place [20:47:38] i'll let maryana answer that as apps aren't using one [20:47:58] i'm actually answering a similar question from a community member on enwiki [20:48:16] yeah, apps we just aks people to file bugs [20:48:17] leads me to suspect we should start a dedicated feedback page and redirect all old & busted feedback pages to it :) [20:48:19] *aks [20:48:36] hehe, Maryana http://xkcd.com/927/ :) [20:48:48] haha, yeah [20:49:04] jdlrobson: Talk:Mobile projects on meta works for now [20:49:40] Maryana: lots of those talk discussions are old - is it bad practice to clean out old inactive discussions? [20:49:53] you should archive them [20:49:56] jdlrobson: i think this jd has a problem. i can see people knowing ruby jumping on it. which isn't that relevant to us [20:49:59] its lax on php right now [20:50:07] awjr: thoughts toward that ? [20:50:11] tfinc: how so? [20:50:12] by which i mean i should archive them, because archiving things is insanely weird/hard [20:50:17] i like it for its js points as is [20:50:24] Maryana: i think we should just ask for an archive bot [20:50:29] tfinc i think it's worth mentioning php specifically in the jd [20:50:30] legoktm: know where we can ask for an archival bot? :) [20:50:31] i've been reading it and thinking about it alongside different devs that i know [20:50:34] is there one on meta, yuvipanda? [20:50:51] i could easily seem my ruby/js devs applying for this and then being confused [20:50:54] to archive what? [20:50:55] tfinc: do you have a link handy to the current jd? [20:50:56] Maryana: I'd think so - every wiki where pitchforks happen laways has one [20:51:00] legoktm: talk page conversations? [20:51:04] oh [20:51:07] pywikipediabot has one [20:51:10] archivebot.py [20:51:16] awjr: its on jobs http://hire.jobvite.com/Jobvite/Job.aspx?j=o4cKWfwG&c=qSa9VfwQ [20:51:20] its what the Miszabot's run [20:51:23] legoktm: is there someone already running one? So that we can ask them to add our page on it too? [20:51:23] ah [20:51:33] which wiki? [20:51:36] legoktm: meta [20:51:37] awjr: pervious notes http://etherpad.wikimedia.org/kZaM0swM4c [20:52:02] thnx [20:52:04] https://meta.wikimedia.org/wiki/User:MiszaBot [20:52:13] same way as you would on enwiki [20:52:23] Maryana: ^ [20:52:30] awjr: i'm really eager to see what the recruiters think of the new format [20:52:42] Maryana: has a big green box saying 'click here to set up auto archival' [20:52:43] legoktm: <3 [20:52:46] :D [20:52:50] sweeeet [20:52:59] archiving by hand is a PITA [20:53:07] and not the delicous kind of pita [20:53:14] *delicious [20:53:17] there's a delicious kind? [20:53:30] tfinc are we doing away with the responsibilities/requirements/preferred sections? [20:53:37] yuvipanda: https://en.wikipedia.org/wiki/Pita [20:54:01] oh [20:54:06] I think I mgiht've seen one at some point [20:54:07] awjr: i'm trying to avoid them all together if i can to keep it simple [20:54:14] awjr: most of them are already covered in the listed points [20:54:23] k tfinc [20:54:40] minus years of experience. HR likes that as it guarantees we can get someone an H1B [20:56:10] awjr: jdlrobson: i was going to write prose for all of the points but then i realized that would just make it harder to read [20:56:18] so i just went back to jons points [20:57:02] tfinc yeah, i think the current format is more digestible [20:58:12] Maryana: did you send me an invite to the design team's trello? [20:58:28] i did.. you have an XKCD avatar, right? [20:58:52] Maryana: that's the wrong email :) [20:58:59] Maryana: send to ypandian@wikimedia.org [20:59:02] bah [20:59:04] ok, trying again [20:59:06] Maryana: this one has no avatar [20:59:41] i can't seem to find you in the search bar [20:59:55] Maryana: try @yuvarajpandian? [21:00:15] ah, there [21:00:41] people with no avatars are suspicious >_> [21:00:56] i see [21:01:01] see! [21:01:21] Maryana: i'll find a black rectangle to fit that one at some point :) [21:02:05] Maryana: got it [21:02:18] YuviPanda: I saw Suspicious activity, so I called BART police. Hope you don't mind. [21:02:43] ERROR JOKE TOO GEOGRAPHICALLY LOCALIZED PLEASE ADD INTERNATIONALIZATION [21:02:49] They'll be knocking down your door tomorrow, the last train for Chennai leaves at 13:00 so they're stuck in Oakland for the night [21:02:51] ahahaha [21:03:04] :D [21:03:27] Maryana: still better than over here, where the last train leaves at around 10:20 [21:03:37] Whoa, that's terrible. [21:03:45] indeedy [21:03:45] How do people get home from work? [21:03:50] early [21:03:57] everything closes down by 10 anyway [21:04:06] i've been on the 10:20 trans a few times [21:04:07] What, they work 01:00 to 09:00? [21:04:10] incredibly empty [21:04:15] oh, i meant pm [21:04:15] Seems overly nocturnal to me [21:04:16] ;P [21:04:18] Oh. [21:04:28] See above re: i18n [21:04:34] :P [21:04:36] touche [21:04:53] Maryana: you cut deep [21:04:55] Maryana: so, do I add a card directly? Or how does it work? [21:04:58] I try not to have an avatar! [21:05:25] yuvipanda, be bold :) [21:05:30] ah :) [21:05:56] YuviPanda: Remember, [[WP:Be bold except when registering TLDs]] [21:05:59] jcmish_ but avatars are so useful for scanning/recognition [21:06:20] be bold, but remember that someone is watching and may revert you [21:06:22] Maryana: done [21:06:27] * Maryana reverts [21:06:28] jcmish_: creepy [21:06:32] that's what they are! [21:06:32] Maryana: another problem now. the iterations don't sync up between app and web [21:06:33] hahah [21:06:40] Maryana: hehe :P [21:06:43] yuvipanda, we could get rid of those labels [21:06:49] i think i'm the only one who follows them, anyway [21:06:53] Maryana: haha :P [21:06:55] we could just have 2 labels, web & apps [21:07:06] that'll be nice! [21:07:20] heyyyy [21:07:21] the apps dashboard used up all the labels though [21:07:22] ! [21:07:24] ! [21:07:25] ! [21:07:33] ? [21:07:34] ^ scary when MaxSem does that [21:07:43] is anyone testing?;) [21:07:58] i looked. everything appears to be ok.. [21:09:17] Maryana: you can put names on the labels, no? [21:09:23] Maryana: why have a card just for iteration keys/ [21:09:24] ? [21:09:40] i did that to keep track of stuff that was coming up & stuff that we were currently working on [21:09:45] but it's not super useful [21:09:47] ah [21:09:48] right [21:09:50] i just changed the labels [21:09:53] ok [21:09:55] what color do you want for apps? :) [21:10:02] red is good :) [21:10:12] in the apps trello red is design. [21:10:13] so [21:10:17] red it is [21:11:12] MaxSem: i believe jcmish_ gave a 'everything is ok' earlier [21:11:27] huh [21:12:28] I did indeed [21:12:36] and Maryana as well [21:12:48] sorry MaxSem [21:13:02] I don't think we used your name in the all's well [21:13:09] carry on MaxSem ! [21:15:42] Hello [21:15:53] hello pragunbhutani [21:16:18] hey ppl, pragunbhutani wanted to discuss the mobile UI for Wikiidata as a GSoC project [21:16:23] Yes [21:16:28] ah [21:16:30] I don't have a proposal [21:16:40] I'd like to discuss the problem first [21:16:54] and whether it makes for a suitable gsoc project [21:17:20] pragunbhutani: i read the email :) [21:17:31] so, MF is currently optimized for reading only. Editing exists but is a tiny bit. [21:17:52] and the majority of new features work has been towards wikis that are being used as, well, wikis (Photo Uploads, Nearby, etc) [21:18:06] pragunbhutani: so as it is, MobileFrontend (MF) will probably not be in great shape for Wikidata [21:18:50] True. The box structures of Wikidata will definitely require a separate layout [21:19:00] indeed [21:19:08] plus I suppose it'll need editing too [21:19:18] and i'm usure how wikidata does searching [21:19:25] For a complete solution, yes [21:20:29] brb [21:20:29] pragunbhutani: a working solution might be to have wikidata figure out when it is feeding things into MobileFrontend and hae it adjust accordingly. [21:20:31] New review: Massaf; "As long as the target size hasn't decreased (in fact, increasing it might be better) then I'm cool w..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [21:20:34] rather than put everyginth in MF [21:21:00] MaxSem: awjr are you coming to blaine's talk at 4 (in the remote sense) [21:21:02] Hmm [21:21:12] pragunbhutani: i'm the least qualified person to talk about this in this channel, though. I'll wait for MaxSem, jdlrobson, jgonera and awjr to chime in [21:21:15] also awjr are you able to fix mingle so it shows current iteration? [21:21:27] so we basically let MF be as it is and format the information passed by wikidata? [21:21:27] probably not jdlrobson, i think im going to lay down again once deployment is done [21:21:33] New review: Siebrand; "+1 for L10n/i18n" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/58109 [21:21:35] ah yeah, thanks for reminding me jdlrobson - i can fix mingle [21:21:54] pragunbhutani: something like that, yeah [21:21:54] awjr: :( there will be a youtube video so it should be recorded [21:22:01] what talk? [21:22:05] * jdlrobson a bit worried about lack of attendance :) [21:22:11] awesome jdlrobson, thanks - i will definitely check it out [21:22:30] MaxSem: check your mail "4pm today: Blaine Cook Poetica demo" [21:22:40] jdlrobson: i bet the visual editor folks will be particularly interested [21:22:50] plus, here's a thought I had [21:22:54] awjr: i hope so - they should be :) [21:23:09] I'm kind of attending but I'm not reading IRC all the time and didn't notice any call to testing [21:23:09] jdlrobson: make sure they attend! [21:23:19] if the entire project turns out to be more complex than is appropriate for gsoc [21:23:43] oh, the attendance was not IRC-related? [21:23:45] perhaps it could be broken down into segments and I could put in the first iteration [21:24:04] to get the ball rolling, so to speak [21:24:08] just a thought [21:24:11] sure [21:24:23] I'm unsure how exactly to break that up, however. [21:24:29] something like this hasn't been done before [21:24:47] and the actual MF experts seem to be busy right now :( [21:25:27] pragunbhutani, first of all: you should use MobileFrontend - reinventing the wheel will be no good [21:25:39] YuviPanda, pragunbhutani, I'm about to go to sleep but I'll gladly talk about it other day [21:25:55] MaxSem: do you really want to put wikibase specific code into MF? [21:26:08] YuviPanda, vice versa [21:26:12] yeah, right [21:26:16] that's what I was saying, I think [21:26:17] ok [21:26:26] re-use MF code? [21:26:41] there's nothing bad about extensions being aware of each other and interact [21:26:42] ... [21:26:47] if done sanely;) [21:26:51] have wikibase detect when it is running through MobileFrontend and modify it :) [21:27:01] so many extensions, only one MF... [21:27:01] ah [21:27:01] pragunbhutani, basically, MF is a skin [21:27:21] okay [21:28:09] it can also mangle your page HTML as it feels better for mobile screens, but this can be disabled [21:28:43] * YuviPanda goes to sleep [21:28:45] gnite folks :) [21:29:00] G'night :) [21:29:04] sweet dreams panda [21:29:09] tanke MaxSem [21:29:28] I think in that case I should take a closer look at MF [21:29:42] pragunbhutani, so you basically need to reformat wikidata tables for narrow screens and tweak editing UI a bit [21:29:58] if designed right, it shouldn't be too hard [21:30:25] that was my original impression, before I got the feedback on the mailing list [21:30:43] I'm not very familiar with WD to have more suggestions [21:31:33] I think people might have been mislead by your idea not to use MF - that is a huge scope creep [21:31:56] without it, it doesn't sound like an overkill for SoC [21:32:17] I didn't have any such intentions [21:32:27] maybe I didn't put it down correctly [21:33:23] ah yes, I can see what might've lead to that confusion [21:33:33] I'll shoot a clarification to the list [21:36:01] "While the MobileFrontend extension prints a mobile friendly version of Wikipedia, there needs to be a separate extension for Wikidata." [21:36:23] for me, it sounds like a clear-cut suggestion not to use MF on WD [21:36:34] 'separate extension', yes [21:37:24] I should clarify that I mean something along the lines of "new extension extends MF" [21:39:26] and why new extension? just twead wikibase itself [21:39:35] s/twead/tweak/ [21:45:13] oh okay [21:54:33] brion: mhurd: what turn around time can we expect after gets our testing credentials ? [21:54:56] back of the queue :( [21:55:08] with luck, and request for expedited, about a week [21:55:10] without luck, god knows [21:55:17] hehe [21:55:21] brion: mhurd: is the submitted build to apple the same one as on test flight ? [21:55:25] i'd like to give it a spin [21:55:33] brion: last one is i believe yeah [21:55:44] we've got some prettifications in master which i haven't released yet [21:55:48] need another quick tweak from mhurd [22:00:17] Maryana: Ping [22:01:11] jdlrobson: awjr MaxSem : do you guys have anything you'd like to share from your research time for tomorrow? I'm going to cancel it if we dont [22:01:24] nope [22:01:29] no tfinc [22:02:21] I had some reasearch time last Friday but it resulted in one scap-related commit, nothing special to report [22:04:36] ummm only really minerva tfinc [22:04:41] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [22:04:41] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:06:06] aaargh RED ALERT [22:06:10] Cannot redeclare class extmobilefrontend in /usr/local/apache/common-local/php-1.21wmf12/includes/AutoLoader.php on line 1160 [22:06:59] awjr ^^ [22:07:50] @_@ [22:08:09] mhurd: how's that login screen skip coming? [22:08:17] comes from different servers [22:09:04] is it posible that will clear up when scap is finished? [22:09:08] just noticed that the login button text wasn't doing i18n - just finished doing so. on skip now [22:09:17] awesome :D [22:09:24] i'd ask you in person but you have headphones on :) [22:09:29] MaxSem: also, any way to see a stacktrace? [22:09:36] nope [22:09:49] luckily, the number of these is small [22:10:03] yeah [22:10:26] just throw something at me haha [22:10:30] jdlrobson: can you add me as reviewer on that minerva commit? [22:10:58] sure - it's all preliminary work at moment - just refactoring mobile skin so it works on desktop [22:11:15] i'm struggling to find bold enough people to review it ;-) [22:12:02] jdlrobson: Maybe it'd be easier to find italic people? [22:12:24] nah, not even underlined [22:12:33] You could promise them pasta. [22:12:51] jerith: i think a subscript person would be better. best if they don't attract attention [22:13:24] :-) [22:14:33] meanwhile, suddenly https://gerrit.wikimedia.org/r/58427 :) [22:15:14] lgtm MaxSem [22:15:50] MaxSem: fatalmonitor seems to have quieted down about that fatal [22:16:10] because all the logs are full of GC spam [22:16:22] GC? [22:17:12] GC cache entry '/usr/local/apache/common-local/php-1.21wmf12/extensions/MobileFrontend/MobileFrontend.php' (dev=2049 ino=12110799) was on gc-list for 601 seconds in /usr/local/apache/common-local/php-1.22wmf1/includes/AutoLoader.php on line 1158 [22:17:34] APC being stupid [22:17:39] MaxSem: See the fatalmonitor [22:17:48] Yeah, its a know weirdness [22:18:05] how often does that apache log in /home/wikimedia/syslog roll over? [22:18:09] I believe latest version of APC no longer emits these errors. [22:18:48] awjr, fatalmonitor displays last 1000 lines, filtering out some of the useless messages [22:19:00] MaxSem: yeah i know, but what about the actual log file? [22:19:08] daily, probably [22:19:56] all right awjr, jdlrobson, Maryana_brb - we're live everywhere, please test:) [22:20:05] * jdlrobson tests [22:20:10] * Maryana tests [22:20:21] then, magic will happen [22:20:22] MaxSem the last fatal for that was 15 minutes ago [22:20:36] and they all happened inside a window of 6 minutes [22:20:46] my guess is it had something to do with the scap [22:20:56] but is hopefully fine now [22:21:51] MaxSem: test wiki or everywhere? [22:22:08] everywhere [22:22:11] jdlrobson ^ [22:22:51] confirmed that we're no longer seeing hte upload CTA, which is good [22:22:55] *the [22:24:47] if there's nothing glaring, I'm enabling new caching stuff on testwiki [22:25:00] MaxSem: i don't seem to be seeing device specific styles - is that [22:25:20] yes, it's intended at this stage [22:25:50] all looks good to me, maxsem [22:25:57] on both desktop chrome and chrome on android, im getting stuck on the special:loginhandshake page (i don't get redirected back to login form) [22:26:31] central notice seems to be running on stable as well for some weird reason… even though it should only be beta.. [22:26:33] after tapping 'uploads' from nav (on beta, loggedout ) [22:26:59] and it's recording itself as desktop which is kinda worrying [22:28:05] jdlrobson, though we still should be able to see the old mobile.device.iphone and alike [22:28:07] jdlrobson, jgonera, MaxSem, Maryana - is anyone else experincing issues with Special:LoginHandshake? im also getting the same problem when just tapping 'login' from the nav [22:28:13] which we don't :( [22:28:34] awjr, i just tried logging in and it worked fine for me [22:28:35] * jdlrobson is still puzzled why central notice is leaking to stable [22:29:19] Maryana: you cleared your cache/cookies/etc? [22:29:27] and experiecned the Special:LoginHandshake redirect? [22:29:40] i didn't clear my cookies, no. will try again [22:30:37] ahh.. efCentralNoticeLoader hook is the reason [22:30:37] ruh roh [22:30:47] the handshake redirect also appears broken in safari on ios [22:30:58] awjr, yeah, stuck on the "redirecting…" screen [22:31:02] yup [22:31:05] :( [22:31:09] mm ok gonna need to rethink how mobileTargets works [22:32:05] oh weird, i went back and tried again and it worked [22:32:10] maybe because it set the cookie [22:32:18] * Maryana clears cache & tries again [22:32:27] * jdlrobson thinks he knows what's happening [22:32:34] on login? [22:32:52] * jdlrobson knows whats happening - yes Maryana  [22:32:53] it appears broken on testwiki and betalabs - we should have caught this a lot sooner. [22:32:59] gah where is michelle? [22:34:02] quick fix jdlrobson? [22:34:04] New patchset: Jdlrobson; "Regression: Add handshake javascript module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58431 [22:34:05] ^ awjr [22:34:18] thanks, jdlrobson! [22:35:22] awjr: hang on [22:35:24] that's not right [22:36:37] New patchset: Jdlrobson; "Regression: Add handshake javascript module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58431 [22:36:59] that should work [22:37:41] that looks better [22:37:48] let me see if i can test locally [22:38:01] oh actually i know i cant, i've done this before. i'll merge it and we should test on betalabs [22:38:16] New review: awjrichards; "merging so we can test on betalabs..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58431 [22:40:36] sorry, I was afk for a moment, but I see the fix is on the way [22:41:13] hmm i've +2d but still doesnt seem to have merged [22:41:24] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58431 [22:41:46] thanks MaxSem - why didn't it automerge? [22:41:53] so we have another problem MaxSem awjr jgonera which is not such a big deal - but basically mobileTargets no longer works - anything which targets mobile will be going to stable [22:41:57] jenkins troubles [22:42:03] ah [22:42:10] fuuuuu [22:42:10] the implication of this is CentralNotice running on stable [22:42:13] brb my visitor is here [22:42:20] but the beta/alpha code will not leak to stable? [22:42:20] ... [22:43:05] i wonder if the jenkins troubles means betalabs will not be updated [22:44:07] MaxSem: can you pick up that changeset and put it on testwiki? betalabs still hasn't updated and im nervous it wont til jenkins troubles are fixed [22:44:25] and we should get this fix out asap since login is busted in prod [22:44:52] ah betalabs just updated [22:44:56] MaxSem ^ [22:45:17] ok, not deploying for now [22:46:27] looks like it works, MaxSem [22:46:45] on it [22:47:33] jgonera: correct [22:47:33] jdlrobson: by "centralnotice leaks to stable" do you mean we're showing banners in stable? [22:47:40] or just that the code is there [22:47:42] shall I deploy to both versions at once? [22:47:43] the only problem is where extensions explicitly add themselves to the output page [22:47:50] currently only event logging and central notice do that [22:47:58] ok, that doesn't sound that bad, for now [22:48:09] just as long as we aren't spamming stable users with banners [22:48:16] yeah [22:48:17] Maryana: i'm not sure the current state of CentralNotice [22:48:18] that would be bad [22:48:26] i think we don't show the div so should be fine [22:48:38] yeah, i'm not seeing anything, thankfully [22:49:25] sadly matt's not around to check :( [22:50:27] yeah it doesnt look like we're exposing the
that CN populates, so even if we're loading CN js, it shouldn't be a problem [22:50:45] might throw a js error though [22:51:29] insertBanner( '
foo
' ) seems to be benign.. [22:51:55] doesn't seem to, but i doubt there's a banner running on enwiki right now [22:53:18] yeah, there's not [22:55:31] awjr, jdlrobson - deployed [22:56:02] * Maryana checks [22:56:02] looks good, MaxSem, jdlrobson [22:56:03] thanks :) [22:56:16] yay, works! [22:56:20] thanks, everyone! [22:56:27] crisis averted [22:56:32] michelle is going to be adding an automated test for that [22:56:37] i'm still worried about the lack of device modules [22:56:58] MaxSem: what is the issue? [22:57:20] no mobile.device.* in HTML [22:59:38] MaxSem: that should only be happneing for devices that have specific styles, right? [23:00:40] I faked iphone [23:01:50] awjr: when I cleared the cache [23:01:57] I got it to happen on iphone on my emulator [23:02:10] but it's working now and I'm looking in chromes emulator [23:02:53] hmm im not seeing it when i fake an iphone UA [23:04:59] http://youtu.be/vnawxpCqiYo < awjr ` [23:06:45] MaxSem: it's not working for me on master locally either [23:06:52] ugh [23:06:59] jdlrobson, ^^^ [23:07:43] awjr: what are you guys seeing? [23:07:55] device specific styles are not being loaded [23:08:18] ah which device type? [23:08:25] so I can switch emulation [23:08:29] iphone, for example [23:08:47] iphone is probably the easiest, but there are a few others [23:10:46] blackberry, ie, kindle, nokia, operamini, opera mobile, psp, wii all get specific styles [23:10:50] or are supposed to [23:11:48] gotcha went back and started spinning up emulaters [23:12:01] emulators and see the the difference [23:17:12] uhoh awjr MaxSem no jdlrobson ? [23:17:24] he's on tech talk [23:17:24] he's hosting an event right now [23:17:34] ah just saw the email! [23:17:43] still, suspicious why he's not at the laptop:P [23:17:48] hahaha [23:18:17] so awjr the cache clearing is easy for automation but I need to get it to run only at the beginning of the tests [23:18:32] for special:loginhandshake jcmish_? [23:18:42] yup [23:18:44] the bigger concern is clearing cookies [23:19:09] *cache meant cookies [23:19:41] New patchset: MaxSem; "Make device modules mobile-targeted" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58436 [23:19:50] but I'm gonna tweak them tonight Zeljko will be around and can code review by the time I'm up and running tomorrow [23:19:52] turns out it was broken a week ago [23:20:11] ok cool jcmish_ [23:20:24] yeah I haven't been clearing the cookies MaxSem [23:20:27] if it wasn't noticeable, maybe we don't need iphone-specific fixes at least?:) [23:20:32] jcmish_: can you point me to a list of our automated tests? [23:20:35] hahaha [23:20:52] MaxSem: we also don't give folks any real way to give feedback from the mobile web... [23:21:00] so, no news doesn't necessarily mean good news :p [23:21:28] we used to give them that chance. guess what? they blew it! [23:21:50] hahaha [23:22:32] can we merge ^^^ so I could deploy it? [23:22:50] ok MaxSem that seems to work for me locally [23:23:00] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58436 [23:23:02] stupid chat dropped me again [23:23:08] sorry here you go awjr [23:23:37] thanks jcmish - it would also be good to have an automated test for device-specific things like styles [23:24:04] yeah I'm actually looking at saucelabs [23:24:14] to see how hard it is to do some style checks [23:24:30] that's actually trickier [23:24:49] jcmish: well, for this in particular, we don't necessarily need an actual device [23:24:56] jcmish: is there a way we can override the UA? [23:25:01] yup you can [23:25:09] if so, then we can just make sure that for certain UA's, certain styles get loaded [23:25:11] but I'm trying to automate it by passing it [23:25:19] and that I'm not sure about with sauce [23:26:44] awjr: MaxSem I need to run out and speak to the funeral people [23:26:49] it's about 7:30 here [23:27:03] but I'll have IRC on my ipad [23:27:04] jcmish: ok; i think once max gets that fix out we're done [23:27:19] yup so definitely let me know and I'll take another run at it [23:27:23] sure, I don't think we need you now [23:27:23] cool thanks [23:27:39] that change is pretty localised [23:27:58] ah well I wanna check it still :D [23:28:20] I'll be doing some automated tests tonight and wanna make sure they worked so I need to before and after :D got the before :D [23:35:42] harr harr https://en.wikipedia.org/wiki/Wikipedia:VPT#Scripts_etc_not_loading [23:36:07] FF 3.6 is IE 6 of our days [23:36:40] MaxSem: is that fix deployed yet? [23:36:41] heh [23:36:56] omg [23:39:11] awjr: can you take another pass on the jd? i made some more changes [23:41:50] sure tfinc [23:42:00] MaxSem: ^^^ [23:42:26] can I have the link? [23:43:00] oh, MaxSem i was wondering if that fix was deployed yet [23:43:16] nope, greg-g is not responding [23:44:04] MaxSem: maybe try announcing in #wikimedia-tech since it's lightning deploy time? [23:44:15] it's over [23:45:23] oh, so it is [23:45:48] well if no one ojbects in ops channel or tech, should be fine [23:49:30] MaxSem: for the jd ? [23:49:51] tfinc, I misunderstood awjr's question