[00:07:39] okay, fix pushed [00:08:02] [Commons-iOS] montehurd opened pull request #37: Straight to uploads if previous credentials found (master...straightToUploads) http://git.io/Iy-mSg [00:08:17] fix confirmed [00:08:17] Sorry MaxSem which fox [00:08:21] Fix [00:08:28] Oh ipad :) [00:08:30] whee [00:08:31] device-specific CSS [00:08:46] K checking as well [00:09:08] still not seeing it, but maybe need to wait for RL cache to expire [00:09:50] you need fresh *HTML* ;) [00:10:26] there it is [00:10:39] im seeing it now [00:11:05] lol Maryana - is http://bug-attachment.wikimedia.org/attachment.cgi?id=11789 your phone? [00:11:16] looks bloodthirsty:) [00:11:31] lol [00:11:40] yeah, haha, it's from a comic that my friend did [00:11:48] i figured it would ward off iphone thieves :) [00:12:03] i totally forgot about it when i took that screenshot [00:12:14] sorry for subjecting the bugzilla community to horror comics [00:12:24] so can we confirm https://mingle.corp.wikimedia.org/projects/mobile/cards/478 ? [00:12:41] K I checked ipad, UA for opera and I see [00:12:53] ooh, didn't realize we deployed it today [00:12:54] It :) [00:12:56] * Maryana checks [00:13:31] lovely! [00:16:01] jcmish_, Maryana: everything looking ok in prod now/ [00:16:42] awjr: Yessir [00:17:09] Much better Maryana ? [00:17:36] yep :) [00:17:50] ok sweet thanks everyone - im gonna take off. hopefully see you all tomorrow [00:18:05] Feel better awjr [00:18:14] thanks jcmish_ :) [00:18:21] I'm gonna drop too folks [00:18:44] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/lS8rcw [00:18:44] Commons-iOS/master c682df4 Monte Hurd: Added i18n for the login button text.... [00:18:44] Commons-iOS/master 6f85d23 Monte Hurd: Auto login if previous credentials found... [00:18:45] Commons-iOS/master f0218d7 Brion Vibber: Merge pull request #37 from montehurd/straightToUploads... [00:19:31] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/kqxoTw [00:19:31] Commons-iOS/master 8486e9e Brion Vibber: bump to 0.18 [01:03:37] mhurd: expect bugs coming your way now that i have the latest iOS version running [01:03:51] will do :) [01:03:52] mhurd: biggest one will be how badly the interface blocks when you trigger a refresh [01:04:14] agreed [01:04:39] mhurd: why do we block on all operations within the UI but the account tab ? [01:05:36] when the add media button is pushed? [01:06:09] New review: Jdlrobson; "am breaking this into smaller commits to make review easier. Please review it's dependencies though!" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/56351 [01:07:21] 1) from my uploads pull down from the top most images to trigger a feed refresh [01:07:35] 2) try to tap config, add image, anything but 'Account' [01:07:42] 3) wait... wait ... wait [01:07:48] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [01:07:48] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [01:07:49] New patchset: Jdlrobson; "Rename scriptUrl to wgScript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58443 [01:22:03] mhurd: --^ [01:22:23] its weird - mine still seems to respond [05:01:39] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [05:50:11] New patchset: Jdlrobson; "Rename scriptUrl to wgScript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58443 [05:50:11] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [05:50:11] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [05:50:12] New patchset: Jdlrobson; "Rewrite menu generation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [05:50:12] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [10:59:41] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58485 [13:42:43] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/BSBc9A [13:42:43] android-commons/master 1252755 YuviPanda: Remove results of {{subst:unc}} when adding categories... [13:43:25] Project Android-Commons (mobile) - Nightly builds build #142: SUCCESS in 46 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/142/ [13:43:25] yuvipanda: Remove results of {{subst:unc}} when adding categories [15:20:04] Email [15:20:32] hello Macfarl92 [15:22:03] Viber [15:23:59] Hello Yuvi panda [15:24:13] Hello Macfarl92 [15:24:16] how can we help you? [15:26:38] How can i contact you besides wikipedia [15:46:13] hey qgil [15:46:31] YuviPanda, "UX as close to official version as possible." [15:46:47] actually now that I read it I don't like "Topic / platform doesn't overlap with official projects." either. [15:46:49] sounds like cookie licking [15:47:13] qgil: yup, that neither. [15:47:33] qgil: 1. if you are building an app for android, what is the point of making it look exactly like the current app? [15:47:51] qgil: and if you are building for a platform that doesn't have a official version, then you would want to make it feel native to that platform, not copy from elsewhere [15:47:52] "UX as close to official version as possible. Adaptations to native look & feel specific to the OS platform are welcome." [15:48:19] "Stick to native conventions on the target platform as much as possible" [15:48:21] if the official one has a toolbar with 4 options you still want that [15:48:32] not at all, no? [15:48:38] UX = user experience, not just having same screenshots [15:48:52] YuviPanda, ok, the first point is feature parity [15:48:57] do you agree on feature party? [15:49:18] I just don't want to put artiicial restrictions on it [15:49:28] Open Source, Privacy Policy, Open Analytics, Community Support, Maintainer [15:49:31] should be good enough [15:49:34] why play Apple? [15:49:52] -1 to feature parity as well [15:50:12] The reasoning is [15:50:22] We don't hav resources to develop apps for all platforms [15:50:42] we don't even have resources to watch and support the development of multiple apps done by others [15:50:54] so the simplest pragmatic solutiuon is [15:51:22] If you want to have an official Wikipedia app in platform X it needs to be conceptually like a port of the official app [15:51:40] this way you don't mess with user expectations and the evaluation is simpler [15:51:43] so [15:51:45] first is [15:51:49] the 'official app' is a moving target [15:51:50] the API is public and anybody can buold apps using our data [15:51:59] currently it is 'stable' which is simply another word for 'dead'. [15:52:06] the apps team has decided to abandon PhoneGap and move to something else [15:52:16] would you expect people to scram and port all theirs once we port? [15:52:38] fundamentally, I don't think Official Apps should be treated any different from Volunteers' apps. [15:52:39] YuviPanda, I think this discussion would benefit from actual examples [15:52:47] qgil: what examples, exactly? [15:52:58] qgil: nobody has actually developed alternative apps that want to use the trademark [15:53:08] so anything we talk about is going to be hypothetical [15:53:10] one example: Nokia wants to contribute an official Wikipedia app for Windows Phone [15:53:17] and that is a real example [15:53:26] sure [15:53:37] so they would want to show off how apps are in their native environment (Windows Phone) [15:53:54] why should we ask them to feature match and UX match our android app? [15:53:57] yes, and this is what we have told them [15:53:58] our abandoned android app, even? [15:54:18] it's the easiest for everybody [15:54:32] qgil: there was a mailing list thread about it a few days ago, and me and brion responded to tfinc telling them to do it as long as they do *not* look at our official app for cues [15:54:41] qgil: I disagree qgil. Not policing at all is easiest for everybody [15:54:48] qgil: we should restrict based on license, ads, privacy. [15:54:52] not arbitrary features [15:54:53] take the Android app that is currently in Google Play, implement the corresponding features in Windows Phone and apply the Metro UI as Microsoft recommends [15:55:04] -1 again. [15:55:11] YuviPanda, well, you can ideed discuss this with Kul and Tomasz [15:55:26] btw, Nokia has no problems with this approach [15:55:26] I will do so when tfinc comes online today. [15:55:39] sure, but I don't want people looking at the Official app as a benchmark [15:55:47] it is *abandoned* by us. if we don't think it is good [15:55:51] we should *not* be pointing other people to it [15:56:03] qgil: and I strongly reccomended against them looking at the official app [15:56:08] qgil: and tfinc told me that is what he told them [15:56:10] I'll clarify. [15:56:10] from a user point of view that is the benchmark [15:56:26] if we think something better should exist, it should be first in the official Wikipedia app [15:56:43] qgil: there is nobody working on the official Wikipedia app [15:56:56] It is doenloaded every day from Google Play and App Store [15:57:08] "if we think something better should exist, it should be first in the official Wikipedia app " can not happen when nobody is working on it [15:57:11] no matter how many people download it [15:57:29] anyway, I'll talk to tfinc about it. I strongly reccomend removing those three points [15:57:39] YuviPanda, anyway, there was a problem and I helped solve it. If you can hep solving the problem better please by all means. :) [15:57:44] will do :) [15:57:48] Nokia was waiting for us, now the ball is in their court., [15:57:59] and they have a specific reference to work on. [15:58:25] qgil: that is scary. The email response from the app team (me *and* brion) was to completely disregard the native app [15:58:26] err [15:58:28] the official app [15:58:47] if you have a better reference that WMF Mobile Partners and Engineering teams are happy to approve as official one day, please pitch it to them. [15:59:12] I am against the idea of a reference at all [15:59:19] or an 'approval' that is engineering / features based [15:59:28] but I'll talk to tfinc and get it sorted :) [15:59:51] YuviPanda, an alternative is letting Nokia go wild, and then when they are done we might tell them. Mmm sorry but we don't have the resources to assess this app and decide whether it should be official. [16:00:37] "I talked to brion on IRC, and we concur. Our response should be something along 'Go for it guys, but do not use github.com/wikimedia/WikipediaMobile. We are not going to support that codebase or derivatives of it' " [16:00:46] YuviPanda, you are right that the current plan is not perfect, but is a plan nonetheless. You are welcome to impreove it. [16:01:15] YuviPanda, they are not using the PhoneGap codebase, they are doing 100% native WP & Metro [16:02:01] I really hope they don't implement saved pages [16:02:04] since we are goign to remove that [16:02:05] anyway [16:02:07] I'll talk to tfinc [16:02:08] about it [16:02:19] YuviPanda, is there a roadmap somewhere? [16:02:40] qgil: no, because there's nothing planned for the next 2 quarters. [16:02:58] nothing -> no features, no UX changes. [16:03:04] hence the major -2 for the 'UX requirement' [16:03:12] but if you know you will get rid of Saved pages of whatever feature it would be good to know [16:03:36] qgil: if you want I can make a list of 'essential features' that will be the minimum supported by the app team. [16:03:49] that would be useful [16:04:11] writing in the talk page now [16:04:15] and we could require "essential features" parity [16:04:41] qgil: +1 on that [16:06:27] edited: Parity of essential features with the official version. [16:06:27] UX integrated with the native OS, taking the official version as reference. [16:06:50] qgil: done [16:07:09] qgil: again, -1 on that :) [16:07:11] on the official version [16:07:15] on Android, for example [16:07:30] the official version uses completely outdated patterns at all parts of the UI. [16:07:42] taking it as a reference would be a bad idea and not something we want to encourage [16:07:49] I agree with the first part though [16:08:17] essential features: I need to take more than 2 minutes to come up with the list. [16:08:22] you need :) [16:08:43] qgil: the features that the official app has that are not there are: 1. Nearby 2. Saved Pages :) [16:09:34] 3. History [16:10:04] qgil: I'll get consensus for it from the rest of the app team before moving it to the main page from the talk page [16:10:22] removed , taking the official version as reference [16:10:53] wonderful :) [16:10:56] qgil: finally, "Topic / platform doesn't overlap with official projects. " [16:11:05] those essential features should be listed in the Wikipedia app pages, not in that list of Main criteria [16:11:17] qgil: really? why split it out that way? [16:11:24] qgil: those are essential features for 'approval' [16:11:31] i don't see how that makes sense in the app page [16:11:40] YuviPanda, because that is interesing information to anybody interested in the Wikipedia app, not only those porting it [16:11:48] we can link [16:12:03] also the official apps can be about Wiktionary etc, not only Wikipedia [16:12:19] hmm, right. makes sense. [16:12:37] I still don't like it, but I'll talk to tfinc about it [16:12:44] someone making a 'hebrew wikipedia' app, for example [16:12:49] need not implement 'language switching' [16:12:59] YuviPanda, every app page needs to have all the documentation ref that app. Ideally including a roadmap. [16:13:30] YuviPanda, if I'm working on a Wikiwhatever app it is normal that I take its documentation as a reference [16:14:15] at this point we're talking about personal preferences qgil :) [16:14:20] to start with, I think it is a bad idea to have a Wikipedia In My Language app [16:14:22] https://meta.wikimedia.org/wiki/Talk:Wikimedia_Apps/proposal#One_app_for_one_project [16:14:29] yeah, I -1'd that too [16:14:46] The fundamental thing is that I don't want to put blanket restrictions [16:15:08] it makes perfect sense to have a, say, "Hindi Wikipedia app" if your platform does not support Unicode rendering of hindi [16:15:14] and you have to build a image based rasterizer [16:15:15] YuviPanda, personal preferences? if the Wikipedia app has 5 essential features why do I need to know only by visiting https://meta.wikimedia.org/wiki/Wikimedia_Apps/proposal ? [16:15:16] for people to read it [16:15:29] qgil: no, i was talking about "YuviPanda, if I'm working on a Wikiwhatever app it is normal that I take its documentation as a reference " [16:15:53] and it would be a huge burden to expect those people to build a renderer for every language [16:15:58] beurocracy bad. [16:16:33] qgil: also, "Topic / platform doesn't overlap with official projects. " [16:16:39] if we require feature parity and then say you can't do what the official app does... [16:16:48] + is cookie licking [16:20:40] https://meta.wikimedia.org/w/index.php?title=Wikimedia_Apps%2Fproposal&diff=5382532&oldid=5382502 [16:21:42] YuviPanda, the principle is simple: if there is already an official WikiSpecies app for FirefoxOS we won't approve a second one. [16:22:15] in the same way that if there is already a Wiktionary project in Urdu we are not accepting a second one [16:22:50] that makes sense, but in that case "Topic / platform doesn't overlap with official projects. " should be reworded to represent that [16:23:19] YuviPanda, to me it reads the same... Can you find a a better sentence? [16:23:19] to me it sounds like "If there is a Wikispecies app for FireFox OS then we won't do anything related to Wikispecieis on ANdroid" [16:23:37] ok, leme see [16:23:45] *WikiSpecieis [16:23:47] gah [16:23:50] I can't spell [16:24:42] YuviPanda, "Your combination of Wikimedia project / mobile platform doesn't exist yet."? [16:25:00] well, that sounds the same too. [16:25:09] see my example about rendering, hindi and wikipedia before [16:25:23] I don't see what the problem is as long as we don't have two things with the same name [16:25:48] "There does not exist another official app for your platform with the same name"? [16:26:05] YuviPanda, so where is your patch? ;) I already had two attempts at writing a sentence that looks clear to me [16:26:17] my patch got reverted :P [16:26:18] if someone comes with an exception then they can explain it at mobile-l and we can agree on it [16:26:29] isn't that overhead? [16:26:31] YuviPanda, did your patch touch that sentence? [16:26:43] no because I didn't notice it. but I just said "There does not exist another official app for your platform with the same name"? [16:26:57] overhead would be to deal with the more probable attempts of building the third Wikivoyage app... [16:27:15] as long as they are all not called Wikivoyage [16:27:25] I think that is *good* [16:27:25] competition is nice! [16:27:31] If they are not called Wikivoyage then they are not official, and anybody can do whatever they want [16:27:39] 'Wikivoyage ' [16:27:59] I'm just applying the same principles Wikimedia pplies for "desktop" projects [16:28:10] an app is very different from a desktop project [16:28:16] since desktop projects run on our infrastructure [16:28:17] apps do not [16:28:39] official apps are published under the name of the Wikimedia Foundation anyway [16:29:06] YuviPanda, and I'd rather be dealing with this problem when someone wants to actually do one of such projects [16:29:22] me too [16:29:36] we have got 3 requests in 6 months for anything mobile app. I don't think this is overhead [16:30:19] we couldn't deal properly with previous requests because we didn't even have a list of main criteria. Now we have one. [16:30:22] so I think the problem is I wasn't involved in the discussion with tfinc. I'll talk to him and then get back to you. [16:30:32] yes, and it is not aligned with what we want to do, I think [16:30:39] patches welcoe :) [16:30:40] m [16:30:45] hopefully they won't be reverted :) [16:30:51] qgil: you should put a draft notice on it, I think. [16:30:59] I still ave to maintain a whole component [16:31:01] have [16:31:08] hmm? [16:31:58] hey mhurd :) [16:32:06] hey yuvi! [16:32:06] mhurd: do you know if brion re-submitted to apple? [16:32:16] mhurd: or are you guys doing bugfixes before re-submitting? [16:32:17] not sure - i think he was going to [16:32:36] hmm, okay [16:32:43] yes i believe quite a few commits were being appended [16:32:53] ah, nice [16:32:53] yay :) [16:34:02] mhurd: what IRC client are you on? [16:34:22] colloquy [16:34:36] mhurd: hmm, tab completion is nice :) you can hit y to complete to my name [16:34:41] it'll also notify me so that I'll look [16:34:51] YuviPanda: omg [16:34:58] YuviPanda: thanks :) [16:35:02] mhurd: also, try LimeChat. much better than Colloquy. I converted tfinc to LimeChat and he hasn't gone back :D [16:35:03] mhurd: :D [16:35:16] YuviPanda: will do! [16:35:21] mhurd: :D :D [16:37:47] hey brion [16:37:54] hello again :) [16:37:55] brion: are you submitting the iOS app to the app store as is? [16:37:58] brion: or making new commits? [16:38:21] tfinc had a complaint about the refresh speed, so i may try to fix that first :) [16:38:49] i hate that anything we submit to the store will be permanently 1-2 weeks behind development by the time it comes out [16:39:08] brion: i thought of a couple potential issues last night that the apple may be picky about... [16:39:29] shoot [16:40:04] brion: so, if we don't have it in the store by Monday, I'm going to push on with the watchlist notices for the Android app alone. [16:40:08] i've heard that they can bounce submissions if they have excessive output (ala NSLog) [16:40:18] brion: I'll be off in 2 weeks :( [16:40:23] ah yeah i've got a shitton of NSLog()s :) [16:40:33] YuviPanda: feel free to keep on trucking yes :D [16:40:38] also if submitted version number is < 1.0 [16:40:38] we'll catch up while you're away [16:40:39] brion: sweet :) [16:40:47] heh yeah [16:40:55] even though that's not yet exposed in the ui [16:41:01] brion: we should plan on what you gonna catch up while I'm away [16:41:04] wait does the app store show version number? [16:41:11] ya [16:41:22] yep. https://itunes.apple.com/us/app/wikipedia-mobile/id324715238 shows 3.3.1 [16:41:29] ok i'll have to bump it to 1.0 :) [16:42:48] mhurd: ok i'm adding some notes at http://etherpad.wikimedia.org/commons-ios-fixes [16:43:20] YuviPanda: so for watch list notices we'll need something server-side to push the notice, won't we? [16:43:26] brion: nah, not really [16:43:32] if you want i could replace all NSLog with WMLog, then create a "debug" scheme with a "don't log" setting which i'd check in WMLog. that way we could easily switch between a verbose output and release mode [16:43:38] brion: we just go through the community, and they edit a mediawiki namespace message [16:43:49] mhurd: that's exactly what i was thinking yeah [16:44:03] i've done it before, if you'd like i can take it on [16:44:29] YuviPanda: oh so like general broadcast notifications? [16:44:32] mhurd: go for it [16:44:34] brion: yeah, pretty much [16:44:41] but the patch would be pretty massive :) [16:44:49] spiff that's easy, do a periodic poll [16:44:49] but i can do it pretty quick [16:44:54] on android anyway :) [16:45:12] mhurd: yeah big patch easy fix :) [16:45:17] :) [16:46:39] brion: poll what? [16:46:51] brion: also seen https://meta.wikimedia.org/wiki/Wikimedia_Apps/proposal? [16:47:18] ah i'll have to look at that [16:48:30] brion: it first said that it should mimic the official app's UX, which I don't think is a good idea :) [16:48:35] brion: look at the talk page too [16:48:47] brion: we should really mark the official app as 'deprecated' someplace [16:48:59] brion: we don't want people looking at it for *any* kind of reference / guidance whatsoever [16:49:02] brion: thoughts? [16:49:06] reading [16:53:14] starting to comment on the discussion :) [16:53:19] brion: :) [17:00:32] brion: standup! [17:00:34] brion: standup! [17:00:54] woop it's that time [17:05:12] http://etherpad.wikimedia.org/commons-ios-fixes [17:15:09] http://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2013-04-08/Wikizine [17:15:17] awjr, jdlrobson, maxsem ^ [17:15:30] thanks Maryana! [17:16:03] "deployment of sidebar, a new facility in its mobile website" [17:16:09] yeah, hehe [17:16:12] time to re-enable my bz account [17:16:17] mhurd: were you saying you needed a 3.5" iOS test device? [17:16:22] i'm going to comment & let them know that's not quite right, maxsem [17:16:23] Chukcha not reader, Chukcha writer [17:16:44] brion: i can just pass mhurd the iPhone4S [17:16:47] ok [17:16:47] brion: ya i tried a 3g from the drawer but Xcode didn't support [17:16:58] tfinc: perfect [17:17:12] mhurd: yeah in my personal drawer i've also got a 3gs which can run iOS 6 but the 4s will do fine [17:17:14] mhurd: oh i didn't expect that to make signpost :) [17:17:18] and will be prettier :) [17:17:19] i just wont be able to do screenshots then but will describe as best as i can [17:17:22] maxsem: :D [17:23:27] awjr_away: MaxSem can we get https://gerrit.wikimedia.org/r/#/c/56887/ merged? [17:23:37] looking [17:25:23] ori-l: can i steal you for some code review today? [17:25:53] brion: mhurd YuviPanda the iOS app requires title and desc. is that a real req ? [17:26:07] tfinc: think so. [17:26:17] tfinc: it won't upload an image unless they're both set [17:26:25] or… it shouldn't :D [17:26:30] brion: you should make desc optional [17:26:36] hmmm [17:26:37] brion: but present [17:26:41] i do notice my descs are often the same as my titles [17:26:42] i know it wont upload. i'm asking if its required for commons [17:26:47] and title mandatory [17:26:49] ah [17:26:53] good question [17:26:53] tfinc: tiltle mandotory [17:27:09] tfinc: description highly reccomended to avoid deletion [17:27:14] what are our users actually filling in? i bet the same thing in both ? [17:27:50] tfinc: i havent checked. [17:28:14] tfinc: oh actually not [17:28:25] a good number are filling in actual wikitext [17:28:27] brion: mhurde: [17:28:27] * https://bugzilla.wikimedia.org/show_bug.cgi?id=47083 [17:28:27] * https://bugzilla.wikimedia.org/show_bug.cgi?id=47084 [17:28:28] * https://bugzilla.wikimedia.org/show_bug.cgi?id=47085 [17:28:30] with appropriate templates [17:28:30] * https://bugzilla.wikimedia.org/show_bug.cgi?id=47086 [17:28:39] staggering [17:28:45] i was surprised [17:28:57] all those french uploads had {{fr|actualdesc}} [17:29:01] he did those by hand [17:29:09] I wonder if we could put some better text to motivate people there then [17:29:11] tfinc: was https://bugzilla.wikimedia.org/show_bug.cgi?id=47083 on the 4s or another device? [17:29:20] tfinc: indeed. [17:29:23] all of these were on the 4S [17:29:29] that mhurd has now [17:29:38] ok so it's the 3.5" screen that's at issue, good [17:29:57] s/below/beneath [17:30:08] yeah [17:30:30] so not retina but 3.5'' [17:30:46] yep. [17:30:49] assigning that one to monte :) [17:31:16] bug title updated [17:31:39] tx [17:32:35] Maryana: is https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 up to date [Roadmap] ? [17:33:51] Maryana: are we really going to get to Mobile notifications ? [17:33:55] in april [17:34:06] New review: MaxSem; "This looks pretty botched up: $wgMFVaryResources is ignored." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56887 [17:34:28] tfinc mhurd: so this looks about right for things to fix? anything else to add? http://etherpad.wikimedia.org/commons-ios-fixes [17:34:36] checking [17:35:17] i'll add some more [17:35:34] spiff [17:35:46] yeah we should def make sure we test on the older devices more [17:35:49] just means more cables :P :) [17:36:14] ya [17:36:31] Maryana: editing to stable looks far too ambitious to me [17:38:26] MaxSem: where are we for the OSM build out for April? [17:38:37] it's not really accurate, tfinc, but we need to have a more detailed conversation with howie & erik before we update it [17:38:59] i'm sitting right between howie and erik right now [17:39:06] hehe, well well [17:39:49] tfinc, I worked at it @ labs it last Monday - need more time for this. probably, this iteration once all perfomance stuff is done? [17:39:56] k [17:40:18] Maryana: so whats the thought on editing right now ? moving it to stable is a huge jump [17:40:46] it's a jump in terms of focus, but i don't think it's technically unfeasible [17:41:34] but April or May ? [17:42:19] i know that its not in the current sprint [17:42:31] brion: any ideas why EXIF data doesn't show on certain uploads via mobile web [17:42:36] will we see it in two weeks ? [17:42:45] see it picked up* [17:42:54] it's been bugging me [17:43:23] jdlrobson: on Firefox OS i've seen an issue where selecting a photo forces you to crop it, which removes the exif data. might be something like that going on... [17:43:54] but it's just a file no? - we don't alter it in anyway.. where might the cropping appear? [17:44:16] in the gallery or camera maybe [17:44:22] i can't recall what you all said about the lunch hangout. does anyone have something to demo ? [17:44:32] tfinc, updated [17:44:35] New review: MaxSem; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58426 [17:48:50] YuviPanda: why doesn't the app board show up here https://trello.com/wikimediafoundation ? [17:49:31] tfinc: i wasn't aware of that org. will move our board there in a bit [17:49:49] tfinc: https://trello.com/wmfmobile [17:50:00] YuviPanda: can you easily move it over ? [17:50:07] looking [17:50:32] tfinc: yes. will do in a minute [17:51:22] tfinc: hmm, I don't have perms to move it. do you know who is admin on [17:51:23] https://trello.com/wikimediafoundation [17:51:24] ? [17:52:24] New review: Jdlrobson; "MaxSem - it needs a rebase. will do that now" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [17:53:55] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [17:54:59] ^ MaxSem [17:56:31] Maryana: do you know who is admin on https://trello.com/wikimediafoundation [17:56:57] not sure [17:57:00] YuviPanda: i'm guessing someone on e3 [17:57:08] ori ? [17:57:12] pure guess [17:57:15] yuvipanda, what's the email you're pointing your contact link to? [17:57:22] probably stevenw if i had to guess [17:57:28] Maryana: mobile-feedback-l [17:57:34] awesome, thanks [17:59:43] awjr: jdlrobson: MaxSem YuviPanda brion mhurd : anyone have items to present at the lunch hangout. http://etherpad.wikimedia.org/MobileTeamHangout looks very general [17:59:53] i'm inclined to cancel if we don't [17:59:59] i do not, tfinc [18:00:17] just prettifications on the app [18:00:40] what brion said ^ [18:00:58] tfinc: +1 to cancelling it for now. [18:01:53] [Commons-iOS] montehurd opened pull request #38: Only NSLog for debug configs (master...logSpam) http://git.io/b0mZPQ [18:03:35] MaxSem: awjr either of you want to review my my python script? [18:03:40] brion: found simplified way to turn off NSLog for release config [18:03:44] sure jcmish [18:03:51] \o/ [18:03:53] my python is ... [18:05:01] thanks awjr :D [18:05:12] and hahaa MaxSem sorry [18:05:22] I tried to write it in other things and it was annoying so I went back to what I know :) [18:06:11] --max-count=1 can be simply -1 [18:06:42] why "%s.." % last_updated ? [18:07:05] jcmish, ^^ [18:07:37] tfinc: ping? [18:07:42] YuviPanda: yes ? [18:07:50] tfinc: do you have time to talk about https://meta.wikimedia.org/wiki/Wikimedia_Apps/proposal [18:07:50] ? [18:08:01] tfinc: I was told it went through you but I don't recall hearign about it [18:08:03] deleted [18:08:03] *hearing [18:08:17] hmm? [18:08:19] YuviPanda: is this quims write up ? [18:08:23] tfinc: yup [18:08:50] I just stuck the git log commands I use on the command line [18:08:53] YuviPanda: sure, what are your thoughts? and yes he did talk to me. i said that we couldn't manage it [18:09:03] my git is minimum [18:09:03] and that he would have to shepherd it [18:09:19] tfinc: yeah, I agree. It's better now, but it had mentions of how the new app should mimic the UX and features of the existing official app [18:09:22] so let me know if there are other things I can do with git [18:09:33] which felt counter intuitive to me, since we made it clear that the current app is 'abandoned' [18:10:12] tfinc: so just want to confirm that we should consider our current apps deprecated / abandoned and should *not* be pointing people to it to use as a reference for anything [18:10:19] git log --no-merges b6264477c0a4946c68259d67d8e462c03a2548d1..> ChangeLogs_03_14.txt [18:10:36] but feel free to tell me a better way [18:10:36] MaxSem: ^^ that's all I translated [18:10:55] https://hacks.mozilla.org/2013/04/persona-beta-2-launch/ [18:11:00] YuviPanda: id consider the codebase abandoned but i dont see why they couldn't follow the ux flow of the current apps ... tailoring them the os in question [18:11:00] brion have you seen this ^? [18:12:00] tfinc: sure, they *can*. I just don't want us to *require* that from them [18:13:03] awjr: i'll have to look at it later…. Persona hasn't really grabbed me, as far as i can tell it's just OpenID with optional browser UI integration. [18:13:08] YuviPanda: letting them go all out would produce apps that look nothing like each other [18:13:21] so we need some guidelines to brand them similarly [18:13:58] tfinc: They should feel native to their operating system, and be consistent in their operating systems [18:14:01] tfinc: not across operating systems [18:14:15] tfinc: that is why we have a super negative review on iOS app store, for example. [18:14:41] YuviPanda: you can have a native app that's still consistent across platforms but keeps a similar look and feel [18:14:58] brion: i haven't dug into the details yet, but i chatted briefly with a mozilla dev working on persona when i was in copenhagen who was explaining to me it's quite different from openid, particularly in regards to user experience. it sounds a helluva lot easier/less confusing [18:15:08] similar ... *not* ... same [18:15:29] so what i'm trying to keep is some cohesion between all wikipedia reader apps [18:15:44] color scheme, icons, etc [18:15:47] tfinc: but *why*? we can keep cohesion between our own stuff, why require it of other people's? [18:15:48] brion: thoughts ? [18:15:57] awjr: yeah but i think it trades it for a centralized email authenticator. anyway i'll research it some time :D [18:15:59] tfinc: we shouldn't be consistent for the sake of consistency [18:16:02] because as soon as it has an official title its us [18:16:20] tfinc: common style and branding are nice, but we haven't even settled on that between our own apps/sites :) [18:16:20] tfinc: really? I don't think we are going to be maintaining these... [18:16:21] press, community, etc will come to us [18:16:29] we = wikimedia [18:16:42] brion: and even then, I wouldn't reccomend mimicking the current app's style. [18:16:42] quim will have to manage all of these [18:17:00] and he wants to publish them under the wmf accound [18:17:01] account* [18:17:47] really? that makes us a bottleneck for those 3rd party devs... [18:18:05] * qgil reads [18:18:29] lets see what qgil thinks. qgil: will we publish these under wmf accounts or a third party account ? [18:18:36] the way it was explained to me was under the wmf accounts [18:19:02] hmm, what I heard was that this was primarily for permission to use our trademarks [18:19:08] clarification on that would help :) [18:19:16] tfinc, I also understand that official means under wmf ccount, yes [18:19:49] http://meta.wikimedia.org/wiki/Wikimedia_Apps/proposal says [18:20:01] "TBD: who publishes to the store." [18:20:15] because we can discuss that when someone is actually heading in that direction [18:20:41] it also depends: official Wikipedia app, for sure it's WMF published [18:21:16] Wikisource in Hebrew app for Firefox OS, maybe we can be more flexible [18:21:24] MaxSem: awjr https://gerrit.wikimedia.org/r/#/c/56887/11 [18:21:29] please please please [18:21:35] I wouldn't spend much time discussing detals before someone needs them [18:21:50] qgil: makes sense [18:22:09] Maryana: do we have a schema for what does this mean? [18:22:33] i think we can just add it to the mobile web uploads schema [18:22:36] lemme find it for you [18:22:46] Hey MaxSem the tools/release I should checkin is that under mediawiki/tools? [18:23:37] jdlrobson: http://meta.wikimedia.org/wiki/Schema:MobileWebUploads <- you can probably add it to "action" as another enum [18:23:54] great stuff [18:24:46] jcmish, right, sorry [18:25:41] tfinc: either way, I don't want us to point to the *current* wiki app for guidelines, and think that the page looks good as is now. We should add a notice saying "If you do not want to use the Wikimedia foundation trademarks, these do not apply to you. Go wild" though :) [18:25:45] gahh jobvite seems to have changed and i cant figure out how to find details on existing candidates [18:26:00] tfinc: and I'd want to be involved in any future discussions of this kind of app related stuff that happens [18:26:59] YuviPanda: if they don't want to use our trademarks and you don't want it official .. then sure... they can do what they want [18:27:08] tfinc: yup. [18:27:16] s/you/they [18:27:19] just want to note that there to avoid confusion [18:27:26] add it [18:27:36] MaxSem: no problem thanks [18:27:37] qgil: may I? [18:28:34] YuviPanda, sure, but this is a basic principle of projcts with a public API... [18:28:51] doesn't hurt to mention it. [18:28:54] sure [18:30:04] done [18:30:53] done again [18:33:56] tfinc: qgil thanks. [18:34:12] New patchset: Jdlrobson; "Log 'what does this mean' clicks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58550 [18:36:01] jdlrobson, we already deployed this, right? https://mingle.corp.wikimedia.org/projects/mobile/cards/476 [18:36:10] New patchset: Jdlrobson; "Log 'what does this mean' clicks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58550 [18:36:17] Maryana: correct [18:36:24] ok, i'll move it to accepted :) [18:36:35] not sure why it's in ready for testing [18:37:10] mmm, do we need to do anything else for https://mingle.corp.wikimedia.org/projects/mobile/cards/447 ? [18:38:32] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [18:39:11] MaxSem: we need v [18:39:12] https://gerrit.wikimedia.org/r/#/c/56887/ [18:39:38] heh, what I'm currently reviewing [18:39:53] also MaxSem we still need to vary HTML on X-Device until https://gerrit.wikimedia.org/r/#/c/58458/ [18:40:02] 446 is not reading for testing :) [18:40:06] awjr: can we move that back? [18:40:11] brion: issue with Xcode and scheme changes - closed the pull req while it tease it out [18:40:30] jdlrobson, ugh, I thought we're ready to pull the lever [18:40:30] core data scheme changes? or something else [18:40:39] MaxSem: nope.. menus currently vary on it [18:40:53] ie. we show certain items only for certain devices [18:40:56] jdlrobson: of course, go for it [18:41:01] awjr: i can't [18:41:03] it doesn't allow me [18:41:16] if i ask you it's because mingle is misbehaving :) [18:41:22] jdlrobson: it needs to go back to awaiting code review right? [18:41:35] yup [18:43:00] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/Da57qQ [18:43:00] Commons-iOS/master c4ed0f5 Brion Vibber: bug 47084: Update refresh to be much faster, not block UI... [18:43:03] jdlrobson: try moving it now? [18:44:22] brion: the scheme data was stored in the project dir (http://stackoverflow.com/q/5304031/135557) checking the "shared" box per the accepted answer to that link (http://stackoverflow.com/a/5304206/135557) made the settings be saved but there were then duplicate entries. going to see if deleting the pre-shared schemes messes anything up [18:44:35] awjr: done [18:44:45] gah! "was NOT stored in the project dir" [18:44:46] jdlrobson, I don't see how left menu currently requires a device information [18:44:51] awaiting final code review column is now bigger than in development [18:44:55] well it's the same [18:44:59] cool jdlrobson, there hadn't been a card transition set up yet [18:45:01] which sends off my alarm [18:45:04] mhurd: weeeird [18:45:14] yeah, that needs to get emptied out [18:45:51] brion: yeah. goofy stuff. on the plus side the fix i found won't require any replacement of NSLog [18:45:59] \o/ [18:46:21] MaxSem: well we weren't showing the login link/watchlist link to older devices [18:46:29] or were we? [18:46:38] I thought I removed that [18:46:54] I don't see how https://gerrit.wikimedia.org/r/#/c/56887/ removes anything like that [18:47:11] huh your right.. but that's wrong.. i think? [18:47:36] {{nobody cares}} [18:47:37] well i guess logging in to see watchlist should be fine but i'm sure we didn't use to show that... [18:47:48] it's more significant with uploads though [18:47:52] as uploads just don't work in mobile [18:48:30] * jdlrobson boots up an old phone [18:48:36] we could just hide this stuff with display=none and then remove that style with jQuery [18:48:43] MaxSem: that's what this patch does :) [18:48:57] I see no JS;) [18:49:26] confirmed… we are showing the uploads link to non-js users [18:49:31] and it shows a blank page [18:49:32] doh [18:49:35] (in production awjr ) [18:49:55] blank as in php error?:) [18:50:05] yeh.. [18:50:06] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/Wu4SFg [18:50:06] android-commons/master 91e0f8c YuviPanda: Make template remover more robust... [18:50:06] w [18:50:12] well it shows Uploads and number of uploads [18:50:14] but looks broken [18:50:32] is your friend [18:50:43] that's no bueno. [18:50:45] ergg [18:51:19] Project Android-Commons (mobile) - Nightly builds build #143: SUCCESS in 1 min 10 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/143/ [18:51:20] yuvipanda: Make template remover more robust [18:51:31] watch list page is not very useful to new users either :) [18:51:50] jdlrobson: hey, what's up? [18:51:52] anyway.. please merge https://gerrit.wikimedia.org/r/#/c/58458/1/includes/skins/SkinMobileTemplate.php - although no css/js it does add jsonly class to menu items meaning they will not show on dodgy phones [18:52:22] ori-l: would you mind reviewing https://gerrit.wikimedia.org/r/#/c/58110/ and parent [18:52:34] it's basically taking some old code and rewriting it in a jquery way [18:52:38] jdlrobson: OK [18:52:47] i'm also throwing away an unnecessary button creation [18:52:51] juliusz is away so i'm needing a js expert :) [18:52:59] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/6ciFCg [18:52:59] android-commons/master f996138 YuviPanda: Trigger Modifications Sync right after all uploads are done... [18:53:20] Project Android-Commons (mobile) - Nightly builds build #144: SUCCESS in 35 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/144/ [18:53:20] yuvipanda: Trigger Modifications Sync right after all uploads are done [18:53:59] awjr: can you cover me in the manager meeting on friday? [18:54:51] sure thing tfinc [18:54:54] New review: Jdlrobson; "It seems we've had a regression and we are now showing the full menu to users with older phones. For..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [18:55:26] brion: would you mind pulling "logSpam" from https://github.com/montehurd/Commons-iOS.git and letting me know if you see 4 or 7 schemes in the drop down? [18:55:31] awjr: added you to the invite [18:55:39] sec [18:55:58] brion: (Xcode's schemes drop down that is) [18:57:15] tfinc: also, can you respond to luis' email before you leave on vacation? [18:57:24] YuviPanda: sure [18:57:27] tfinc: thanks :) [18:57:36] * tfinc is giving kiwix on android a run through [18:57:53] tfinc: oh, it is in working state? never realzied! [18:57:54] nice [18:58:04] YuviPanda: https://play.google.com/store/apps/details?id=org.kiwix.kiwixmobile [18:58:10] tfinc: wonderful [18:58:14] mhurd: ok i see… 6 schemes [18:58:14] will give it a go [18:58:28] mhurd: brion also, is the trello board somewhat accurate? :P [18:58:37] YuviPanda: i'll update it :) [18:58:41] brion: thanks :) [18:58:55] brion: there's now a sortof-nice half-wikitext-parser-kinda-thing in the android app :) [18:59:05] brion: if you go to manage schemes how many are checked/unchecked? [18:59:07] it only removes templates, though. but does so in solid competent fashion! [18:59:53] mhurd: all 6 are checked [19:00:15] ah [19:00:19] all 6 are checked under 'show' [19:00:24] 4 are checked under 'shared' [19:00:27] brion: ahh! [19:00:34] brion: that's good! [19:00:37] \o/ [19:00:45] victory is ours [19:00:45] * YuviPanda looks for ragesoss [19:00:50] brion: the 4 that are shared are from the commit [19:00:59] ok [19:01:02] brion: the other 4 may be deleted [19:01:27] brion: also uncheck "auto create schemes" before you close xcode [19:01:33] spiff [19:01:48] brion: then if you re-open you should just see the 4 [19:02:14] yay! [19:02:26] brion: and those 4 should now be part of the repo (once that branch is merged) [19:02:30] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [19:02:57] looks good [19:03:02] brion: the new "Commons-iOS-Debug" scheme should print NSLog msgs [19:03:17] brion: the "Commons-iOS" scheme should not [19:03:46] woohoo take that logspam [19:03:47] confirmed [19:03:48] brb [19:03:48] YuviPanda: huh? [19:03:49] merging... [19:04:00] brion: you will still see some log output with Commons-iOS-Debug, but it won't be from NSLog [19:04:07] ragesoss: around? About to release an app :) [19:04:30] I'm around. [19:04:37] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/T-tDWg [19:04:37] Commons-iOS/master aba62dc Monte Hurd: Made NSLog not output to log if non-release config in use... [19:04:37] Commons-iOS/master 9b6da0f Monte Hurd: Checked "shared" box on schemes... [19:04:37] Commons-iOS/master 641d2e7 Brion Vibber: Merge branch 'logSpam' [19:04:45] I have a moment now, and more free time in half an hour, YuviPanda. [19:04:56] ragesoss: okay, I'll still be around in half an hour :) [19:05:00] ragesoss: I'll do some testing till then :) [19:05:25] mhurd: ok i'm gonna break and grab some lunch. if you take the field positioning issues i'll poke at the image fetching after [19:05:37] brion: ya! [19:05:41] New patchset: MaxSem; "Don't set $wgResourceLoaderDebug" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58554 [19:05:49] excellent [19:06:06] quick review please^^ cuz I can't review anything RL-related without it [19:07:30] i'm blocked on code review so going to lunch [19:07:54] MaxSem: will take a look when i get back [19:11:02] heh we are all deadlocked [19:11:12] New review: awjrichards; "LGTM - may want to let Juliusz/Jon know this change is happening so they can accommodate for it." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58554 [19:11:20] nodejs is the answer! [19:11:21] :P [19:11:43] awjr, thanks! [19:11:53] np MaxSem - do let jon/juliusz know about that change tho [19:12:36] oops merge failed [19:13:04] 1) MFResourceLoaderModuleTest::testGetTemplateScript with data set #1 (array(array('template', 'template2'), '/mnt/hgfs/wikimedia_git/extensions/MobileFrontend/tests/modules/../templates'), 'mw.mobileFrontend.template.add("template","hello\\n");mw.mobileFrontend.template.add("template2","goodbye\\n");') [19:13:04] MWException: MFResourceLoaderModule::getTemplateScript: template file not found: "/mnt/hgfs/wikimedia_git/extensions/MobileFrontend/tests/modules/../templates/template.html" [19:13:04] /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/modules/MFResourceLoaderModule.php:85 [19:13:04] /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/tests/modules/MFResourceLoaderModuleTest.php:142 [19:13:05] /mnt/hgfs/testing/core/tests/phpunit/MediaWikiTestCase.php:116 [19:13:06] /mnt/hgfs/testing/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64 [19:13:07] /mnt/hgfs/testing/core/tests/phpunit/MediaWikiPHPUnitCommand.php:48 [19:13:31] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58554 [19:13:54] we should fix that test, MaxSem [19:13:57] puny jenkins is mo match to my kung fu! [19:14:01] lol [19:14:09] i'll fix it, i see what the problem is [19:14:34] New patchset: MaxSem; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [19:16:30] New review: Ori.livneh; "(3 comments)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/58110 [19:16:41] ^ jon [19:16:46] ^ jdlrobson, rather. [19:17:09] oh, i forgot about the dependency, sec [19:22:38] New patchset: awjrichards; "Fixes broken test, MFResourceLoaderModuleTest::testGetTemplateScript()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58555 [19:23:12] MaxSem: ^ [19:23:20] already on it [19:24:14] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58555 [19:24:30] ty [19:38:23] New patchset: MaxSem; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [19:38:44] New review: awjrichards; "Tests need to be updated:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56887 [19:39:36] gah, I thought it fails due to the above issue [19:40:00] code changed, tests didn't get updated to reflect changes [19:43:16] YuviPanda: reporting for duty. [19:43:27] greeetings hummann! [19:43:28] :) [19:43:45] ragesoss: https://bit.ly/commons-nightly [19:43:53] ragesoss: it's white icon though [19:44:10] hmm, bleh [19:44:36] ragesoss: https://integration.wikimedia.org/nightly/mobile/android-commons/android-commons_latest.apk [19:45:34] ragesoss: no major new features, actually. Just a bunch of under-the-hood-fixes [19:45:38] ragesoss: and an 'opt out' feature [19:45:42] ragesoss: and an About Page [19:46:48] ragesoss: and a 'send feedback' thing [19:46:51] New patchset: awjrichards; "Story 141: Set wgMobileDeviceName in a device specific js module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [19:46:55] YuviPanda: how do I access these features? [19:46:57] ragesoss: and fixes in how consistent categorization works [19:47:02] ragesoss: hit the menu [19:47:23] lemme try again... I seem to have an app that didn't update yet. [19:48:13] ragesoss: yeah, i haven't pushed it out yet [19:48:16] ragesoss: doing final checks. [19:49:13] my bad. user error [19:49:29] ah? [19:50:45] somehow my dropbox daemon died. [19:50:54] oh [19:50:58] ah, linux [19:51:13] that's actually never happened before [19:51:23] dropbox on linux is usually super reliable. [19:51:45] New patchset: awjrichards; "Story 141: Set wgMobileDeviceName in a device specific js module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [19:54:57] New review: awjrichards; "LGTM but I had to rebase this manually. I botched it the first time I tried, and think I got it fixe..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/56703 [19:55:11] doh i think i screwed up fixing a merge conflict [19:59:09] ragesoss: anyluck? [19:59:15] yeah. [19:59:28] no new complaints [19:59:37] ragesoss: on 2.3 too? [19:59:57] keyboard is not active at outset of cats ui. [20:00:18] ? it doesn't auto pop up? [20:00:24] so contra instructions, I can't type until I tap input [20:00:32] nope [20:00:32] ah [20:00:33] hmm [20:01:14] Maryana_lunch, jdlrobson: prioritization [20:02:28] setting up :) [20:02:37] w00t [20:05:09] jdlrobson: ?? [20:07:56] ragesoss: hmm, strong enough to stall a release? [20:08:03] YuviPanda: direct downloads from integration.wikimedia.org never work on my phones. [20:08:10] not sure if it's a CM bug or a general android bug. [20:08:11] ragesoss: really? why? [20:08:18] ragesoss: what do you mean by 'does not work'? [20:08:23] but some links for downloads just stall and never start. [20:08:33] ah [20:08:36] sounds like a CM bug? [20:08:40] the download notif says [20:08:42] but it's a downloads issue [20:08:49] but it does this on 2.3 and 4.2 [20:08:58] hmm let me see [20:09:00] but dropbox links always work. [20:09:10] well, we do send ocntent-length [20:09:12] it might be security related. [20:09:14] but we don't send file name [20:09:20] so that might be the reason [20:09:21] though I dobut it [20:11:11] okay, installing on 2.3 now [20:12:50] ragesoss: sweet [20:12:55] YuviPanda: 2.3 flashes at each new 10 uploads it loads after sign-in. [20:13:04] ragesoss: yeah, it'll flash a lot more [20:13:17] ragesoss: it's an unfixed bug. [20:13:25] ragesoss: i'm at a loss on how to fix that, actually [20:13:37] ragesoss: but it is scheduled for next week [20:14:15] YuviPanda: I notice that the input box for cats ui is actually a lot easier to see on 2.3 [20:14:23] it's got a white, not transparent, background. [20:14:26] this is a good thing. [20:14:26] ragesoss: yeah, it's a 'block' [20:14:37] hmm, yeah. [20:14:43] it's hard to see as an input box on 4.2 [20:14:44] I'm unsure how to 'fix' it in 4.x though [20:14:58] ragesoss: we have plenty of 'input boxes' on translucent areas [20:15:01] that will be hard to see [20:15:18] hah [20:15:23] found a crash bug [20:15:37] ragesoss: ah! [20:15:39] where what how [20:15:53] getting it to you shortly. [20:16:06] crashed on email feedback [20:16:39] ragesoss: oh [20:16:46] ragesoss: Did it ask for crash report? [20:16:51] yeah [20:16:55] getting it to you [20:16:57] hold on [20:16:57] okay [20:16:58] :) [20:18:20] ygm [20:18:57] ragesoss: <3 [20:19:26] ragesoss: do... you have any app installed that can send email? [20:20:26] no [20:20:29] :) [20:20:47] ragesoss: mm, that explains it :) [20:20:51] ragesoss: let me try it on my device [20:21:03] ragesoss: so, I suppose I should, uh, I dunno. [20:21:12] put up a dialog box saying no appropriate things found? [20:21:36] ragesoss: do the links in the ABOUT page work? [20:21:40] share entry says "Upload medi...” [20:22:14] rather than Wikimedia Commons like before [20:22:31] ragesoss: ah [20:23:48] ragesoss: let me fix that [20:28:31] links work [20:28:45] everything else seems great. [20:30:58] ragesoss: sweet [20:31:09] ragesoss: so, 1. share entry, 2. fix for email feedback [20:31:12] ragesoss: that's it? [20:33:44] and keyboard on cats ui [20:34:02] ragesoss: right [20:34:18] ragesoss: I'm actually going to test the email thing on my phone [20:34:19] keyboard absent for both phones. [20:34:25] and if it works, i'm going to leave it for now [20:34:28] and just file a bug [20:35:04] YuviPanda: still no word back from vibha. do you already have some thoughts on the tutorial for the app written up ? [20:35:51] tfinc: I don't but I can do so on the card. [20:36:24] https://trello.com/card/educational-ui-for-new-mobile-app-uploaders-android/5112b893d0cd43cb370062bd/40 ? [20:36:28] yeah [20:36:33] tfinc: writing now [20:36:35] k [20:36:37] one minut [20:42:29] brion mhurd : do you guys need me to add the defects i put into bugzilla into trello or is that overkill ? [20:42:41] tfinc: I think we should [20:42:44] tfinc: I do it for Android [20:43:23] tfinc: would be nice :) [20:44:02] ragesoss: email works for me [20:44:05] so going to let that one slide :) [20:46:52] ok. their all on trello now [20:48:06] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/6jrLSg [20:48:06] android-commons/master 11b1b27 YuviPanda: Remove settings icon from menu... [20:48:43] tfinc: sweet [20:48:47] Project Android-Commons (mobile) - Nightly builds build #145: SUCCESS in 48 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/145/ [20:48:48] yuvipanda: Remove settings icon from menu [20:48:52] tfinc: also we started using labels for iOS / Android. Check that out too [20:49:12] YuviPanda: if i put a retrospective for next friday would you be able to make it ? [20:49:21] MaxSem: would you mind fixing up https://gerrit.wikimedia.org/r/58426 so I can rebase and fix all the other patches I need to? :) [20:49:32] also is gerrit down - mega slow [20:49:43] tfinc: if it is not too early, yes :) [20:49:50] 11AM PDT [20:50:10] jdlrobson: gerrit has seemed megaslow to me all day :-/ [20:50:10] hmm, wfm tfinc [20:50:48] tfinc: I'll be available for the whole of next iteration [20:50:50] also awjr phpunit tests are broken :( [20:51:01] where jdlrobson? [20:51:07] ok colors added [20:51:07] not sure what happened [20:51:30] tfinc: sweet [20:51:33] jdlrobson: what revision are you on? [20:51:45] latest and greatest of everything [20:52:09] jdlrobson: head of master has no unit test failures for me. [20:52:19] are you up to date on core as well? [20:52:26] maybe not [20:52:27] mhurd: i see brion and yuvi in the doing column on trello. which story are you working on ? [20:52:52] they're subsumed under 'fix up pre-release issues' [20:52:55] YuviPanda: any luck moving the board to the wmf account ? [20:52:56] we ca nmake separate cards tho [20:53:01] ahh ok [20:53:02] gerr gerrit [20:53:16] * awjr slaps gerrit [20:53:21] i dare you to go slower [20:53:27] tfinc: haven't located the owner yet. When I last saw StevenW he was in a very intense debate going on in #e3, so left him be. will poke when he's back [20:53:54] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [20:53:59] Maryana: does anyone else besides swalling have admin ? [20:54:11] New patchset: Jdlrobson; "Remove the need for a button in sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [20:54:14] ragesoss: link to your commons brochure? [20:54:15] on trello? dunno [20:54:18] ragesoss: and how far is it from being complete? [20:54:20] yeah [20:55:08] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58109 [20:55:46] tfinc: the card has some details on it [20:55:59] tfinc: there's a link there that i think we'll want to lean on and pick material from [20:56:03] awjr: jdlrobson i'm going to the silence on the task email that there hasn't been any other discussion past whats there [20:56:06] awjr: strange phpunit passing for me now [20:56:30] tfinc: the 3.5 inch screen positioning - presently i'm in provisioning hell (all the certificate non-sense you have to deal with just to push dev builds to a testing device - pretty much my least fav thing ever) [20:56:34] tfinc: no not really - i still think the tech task i suggested was a good one but others obviously don't agree :) [20:57:17] yeah, tfinc i haven't thought about since my last post on that thread [20:57:58] jdlrobson: yeah finally got some updates to core, and phpunit tests all work now - maybe you had been running tests from an older checkout of master (max merged some unit test fixes i made ealier today) [20:58:05] tfinc: apple makes this waaay convoluted :( [20:58:41] brion: i'm going to delete https://trello.com/card/ios-fix-up-pre-release-issues/5162461b43476994540002ba/28 as i added the individual story cards that are within it [20:58:59] yuvi: https://commons.wikimedia.org/wiki/Commons:Welcome_to_Commons_brochure [20:59:26] copy is essentially complete. visual designer just starting. [20:59:54] I need a URL/qrcode for apps [21:00:47] ok [21:00:48] ragesoss: right. [21:01:31] dude [21:01:35] gerrit has become unusable. [21:02:15] yeah, that happened a few months ago when we turned it on and has only slowly gotten better now :P [21:02:24] ragesoss: who is the visual designer? [21:02:26] :p [21:02:43] YuviPanda: at least i could click things in gerrit and stuff would happen back then… [21:02:58] that's not a high bar :P [21:03:37] good git and gerrit are so slow that they are practically unusable [21:03:54] hmm, I'm told puppet is also incredibly lsow [21:03:55] *slow [21:03:59] is it just my wifi? [21:04:06] all other sites seem fine [21:04:09] jdlrobson: it's slow for awjr too [21:04:16] i can't actually do ANY work right now [21:04:17] t [21:04:20] this is ridiculous [21:04:22] yeah im stuck now too jdlrobson [21:04:39] im poking around various channels to see if someone can do something… looks like MaxSem is having problems too [21:05:40] jdlrobson: thoughts on experimenting with using GitHub for discussions + PRs, and then finally merging into Gerrit, if we have the tools to do so painlessly? I posted something to wikitech-l a while back, lots of people are interested, and I'm polishing it up this weekend [21:06:12] (eventually, not now) [21:06:15] sweet. I think any kind of github integration is a good thing [21:06:44] jdlrobson: did you see https://gerrit.wikimedia.org/r/#/c/56703/ ? [21:06:52] jdlrobson: okay :) I'll polish it and then see if I can lobby you guys to use it :) [21:06:56] awjr: i'm trying to check it out but so far it is taking 10 minutes to do so.. [21:08:06] jdlrobson: things are now responsive for me again [21:10:01] awjr: same [21:10:58] tfinc: i updated that card [21:11:03] no one seems to have any idea what's going on, current theory seems to be super backed-up jobs and massive i/o… 'wait it out' they say. [21:11:19] awjr: let me ask robla [21:11:19] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/xZd-ug [21:11:19] android-commons/master 6a82b3e YuviPanda: Make share target title to be app name [21:11:36] thanks tfinc [21:12:07] jdlrobson: were you getting any gerrit errors at all, or was it just unresponsive for you? [21:12:23] awjr: just unresponsive [21:12:25] MaxSem: ^ [21:12:37] awjr: device detection thing seems broken - looking into it [21:12:55] ahh it only works when X-Device set now... [21:14:36] Project Android-Commons (mobile) - Nightly builds build #146: SUCCESS in 1 min 15 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/146/ [21:14:36] yuvipanda: Make share target title to be app name [21:16:29] slow [21:17:46] ragesoss: the categories thing seems to be a long and winding bug to me :( [21:17:51] ragesoss: i'm just going to file it and release this one [21:17:55] ragesoss: is that fine? [21:18:09] MaxSem brion think there's a shot at making the icons the same? for both the app and mobile web [21:18:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56703 [21:19:12] munaf_, you mean https://gerrit.wikimedia.org/r/#/c/58463/ ? [21:20:36] i mean the wikipedia app and mobile web should have the same touch icon, not favicon. [21:21:49] munaf_: on both iOS and Android? [21:21:58] yeah. consistent branding and all. [21:22:14] the iOS icon will fail Android's icon guidelines :P [21:22:34] munaf_: but we can definitely use them in the iOS app [21:22:35] brion: ^ [21:22:53] i can make new versions [21:22:53] munaf_: https://developer.android.com/guide/practices/ui_guidelines/icon_design_launcher.html [21:23:03] munaf_: I'll be happy to push out a new version :) [21:23:15] munaf_: for Android, provided we stick to the Android guideliens [21:23:21] which ask for a different style than iOS [21:23:22] will do YuviPanda. [21:23:26] munaf_: thanks :) [21:23:31] Yuvi go for it. [21:23:39] ragesoss: :) Adding CREDITS file now. [21:23:40] release that is. [21:24:19] whee [21:24:21] icons :P [21:24:38] ragesoss: yeah, adding CREDITS, then bump, then release [21:24:41] ragesoss: then post on VP :P [21:28:21] tfinc: it's up on https://trello.com/wikimediafoundation [21:28:24] nice [21:28:59] tfinc: :) [21:29:05] tfinc: did you check out the design card? [21:29:05] brion: i think i may have figured out my provisioning problem - could you add me as a team member on developer.apple.com (my user email there is mlhurd@hotmail.com) [21:30:07] awjr: how can i disable hooks in tests? [21:30:19] brion: i was trying to provision via my dev acct, but the team id prefix being used was from my acct not the WMF acct [21:30:27] jdlrobson: eh? [21:30:41] awjr: so i'm rewriting the test in SkinMobileTest.php [21:30:54] and there is a hook in there which messes with my results... [21:31:03] i just wondered if it was possible to disable the hook temporarily [21:31:09] what's the best practice? [21:31:24] uh [21:31:36] i think i need more context - what is the test in quesiton? [21:31:55] jdlrobson: ^ [21:32:33] hang on i'll submit something and you can fix it up [21:38:56] awjr: so you got a few mins to help me on a couple of test related things? [21:39:11] jdlrobson: give me a few minutes [21:40:10] hey look, fae doesn't hate us so much anymore! http://commons.wikimedia.org/wiki/Commons:Village_pump#Mobile_Web_Uploads_turned_off_in_stable [21:40:23] he also appears to be quite interested in the EXIF data-reading thing [21:41:27] mhurd: moment [21:41:28] Maryana: indeed, at some point he seems to have flipped :) [21:41:51] brion: :) [21:41:56] Maryana: he hangs out on -commons and was not pitchforky when I talked to hi :) [21:42:07] yay! [21:42:22] *him [21:43:06] mhurd: ok….. you should have some sort of invite in your email [21:43:08] hopefully it helps to have a human presence on the various wikis/channels and show that we actually do care/respond to feedback [21:43:34] brion: woohoo thanks! [21:43:38] Maryana: yeah, hope so :) [21:44:04] Maryana: i think that might've been a trick we missed, spamming VP more incassently [21:44:18] Maryana: I'm going to spam VP with every version of the app release now, until they ask me to stop [21:44:22] haha [21:44:31] wake up every morning and tell them what you had for breakfast [21:44:47] Maryana: something like that ;) [21:44:56] ok jdlrobson [21:46:58] jdlrobson: ready when you are [21:47:05] k [21:47:09] i'll just submit it [21:47:30] ok take a look now [21:47:32] tests are broken [21:47:35] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [21:47:38] but hopefully you can see what i'm trying to do [21:47:49] mhurd: ok i approved your cert req [21:48:19] so 2 things going on awjr [21:48:28] 1) I don't know how best to do the messing with the hooks stuff [21:48:44] 2) OutputPage seems to keep modules from previous tests (i don't understand why) [21:49:08] hmm ok [21:51:05] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [21:51:06] awjr: tests pass with this version but it's hacky ^ [21:51:26] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [21:51:29] Maryana: i added one more item to the mobile design board [21:51:29] brion: i saw it magically go from red to green [21:51:33] juat a headsup [21:51:49] icon for android app? [21:51:53] Maryana: yup. [21:52:24] brion: i assume i have to create a new provisioning profile now as non of the existing ones reference my cert? [21:52:41] ah yes, see if it'll let you [21:52:46] i bet munaf could knock that out pretty easily, as he's just worked on the mobile web home icon [21:52:48] brion: k [21:52:59] you should add him to the card, yuvipanda [21:53:01] know how to do that? [21:53:06] brion: nope - the + icon is grayed out [21:53:14] :P [21:53:38] brion: what a circus haha [21:53:38] Maryana: yup [21:53:53] Maryana: do i just assign him to it? [21:55:00] Maryana: i just assigned munaf_, hopefully that's the right thing to do [21:55:11] mhurd: hmm it lists a development cert for you… what do you need a provisioning profile for, is the dev cert not enough to install on the local machine? [21:55:15] work?!?!?! [21:55:19] should be. did a little smiley coffee cup show up on the card? [21:55:21] EvilPanda! [21:55:35] munaf_: bwahahahaha [21:55:54] brion: it says the dev cert is invalid :( [21:56:09] bah wtf [21:56:19] and Xcode doesn't redownload it or anything? [21:56:28] so fyi, i'll be running all of these icon changes by jay before sending you guys anything [21:56:49] munaf_: sure. have you seen oru current Commons app icon? [21:56:49] brion: not that i can tell… [21:56:52] so, we shall have communications/branding signoff and that shouldn't be a huge issue [21:56:59] not yet [21:57:01] but i shall [21:57:09] munaf_: :) [21:57:21] brion: i may be doing it wrong [21:57:25] munaf_: we also have a 'black' variant, used for beta. having one would also be nice :) [21:57:28] * EvilPanda adds it to the card [21:57:36] eeexcellent [21:57:50] jdlrobson: sorry, still poking around trying to fully understand what's happening here [21:57:56] so i may make this pop a little more [21:58:04] done. [21:58:10] munaf_: go ahead :) [21:58:15] and by pop i mean a silhouette of michael jackson. [21:58:28] :D [21:58:41] I thought you meant a silhoutte of jorm [21:58:47] can do that too. [21:58:51] different pop, but. [21:59:04] munaf_: we can go wild on the beta icon, mostly. [21:59:08] yaaay [21:59:11] munaf_: and if you really want, you can do 3 - stable, beta, nightly. [21:59:24] mhurd: lemme try making a new development provisioning profile [21:59:24] nightly will have very limited distribution - only hard core testers, so we can go *really* wild [21:59:25] jdlrobson: pastchset 16 does not make tests work [21:59:48] ok. i'll inject a few espressos and get to photoshoppin' [21:59:58] hmm it doesn't list you... [22:00:22] munaf_: <3 [22:00:32] munaf_: just remember the Android style guidelines :) [22:00:47] awjr: it doesn't? huhhSasa [22:00:59] the facebook "no profile" icon is bill gates' mug shot. [22:01:00] jdlrobson: no it throws 5 errors [22:01:13] mhurd: anything more you have to poke on that dev cert? maybe it's incomplete in some weird way [22:01:15] errr… weird [22:01:17] jdlrobson: i am confused about WHY you want mess with the hook/ [22:01:27] awjr: as other extensions might be using it [22:01:27] munaf_: we clearly need to work jorm's silhoutte somewhere now. [22:01:36] i wanted to test the hook does what it should [22:01:39] seems done... [22:01:41] well, i guess i could make it a hidden layer in the psd. [22:01:47] tch tch. [22:01:52] CentralNotice uses the hook and thus its modules get added [22:02:20] are you sure you checked out patch set 16 and not 15 awjr ? [22:02:21] brion: i may be onto something… it's fetching a wildcard app id now… [22:02:23] tests work fine this end [22:03:33] jdlrobson: im not sure this really qualifies as a unit test per se [22:03:39] jdlrobson, I see no footer with https://gerrit.wikimedia.org/r/#/c/58426/ at all [22:03:41] awjr: well shall we throw it out? [22:03:57] sorry MaxSem i can't think about that patch set until this one is out of the way :) [22:04:12] then why you asked me to fix it? [22:04:28] i think i am inclined to, jdlrobson [22:04:38] ragesoss: update away :) [22:04:39] MaxSem: just give me a few minutes - i thought it was just a case of fixing the escaping [22:05:01] the existence of those modules might be better tested for in automated frontend tests [22:05:17] what you have here is kinda outside the paradigm of unit testing [22:05:34] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/yGNWLw [22:05:34] android-commons/master 719612a YuviPanda: Updated CHANGELOG, added CREDITS & bumped version number [22:05:36] awjr: so i'll just tear them out then [22:05:42] that's fine jdlrobson [22:06:15] Project Android-Commons (mobile) - Nightly builds build #147: SUCCESS in 46 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/147/ [22:06:15] yuvipanda: Updated CHANGELOG, added CREDITS & bumped version number [22:06:22] errgg gerrit went slow again siggh [22:06:42] if you have to futz around with globals to cope with hooks, you're doing smoething wrong - either in the test, or the code you're trying to test. [22:06:48] brion: aaaaand it's still fetching… apple gah! haha [22:06:48] gerr it is the albatross around my neck [22:06:54] lol [22:06:55] whee [22:07:32] New patchset: Jdlrobson; "jqueryify toggle.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58110 [22:07:48] ori-l: thanks for the review - made some fixes like you suggested [22:10:29] mhurd: ok i created a new development provisional profile for 'Commons Development' but… you weren't available on the list of developers [22:10:32] so god knows if it'll work [22:11:50] brion: i just got it to work! i'll email image describing how (for future reference - easier to snapshot than try to explain) [22:13:03] wheee [22:13:04] ARHSDHAHDADHDHA GERRIT ARg [22:14:56] awjr: i removed the tests - it's slowly on its way to gerrit for you to press the button [22:15:08] ragesoss: spammign everywhere [22:15:32] New patchset: Jdlrobson; "RL: Add modules and module styles to page as modules found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [22:19:34] MaxSem: ok looking at footer stuff now [22:19:37] $this->hookOptions['toggle_view_desktop'] wtf does this do? [22:20:06] Zero stuff [22:20:16] $url = $this->getRequest()->appendQuery( $hookQuery ) . urlencode( $url ); ? [22:20:26] brion: i emailed you a snapshot (now that i was added to the acct it pulled down all the provisioning profiles and one of them worked :)) [22:20:27] not clear why it concatenates with original url... [22:20:56] got it thx :D [22:23:16] MaxSem ^ also you said you couldn't see the footer? [22:23:25] yes [22:23:33] MaxSem: why does it concatenate the original url with the same url? [22:23:37] that line looks broken [22:24:03] http://.../wiki/Special:ZeroMadness?url=your_old_url [22:25:22] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:25:34] ^ ok MaxSem that should meet your escaping needs - i don't understand why you can't see the footer - what page are you on? [22:25:55] main page [22:25:57] (note on special pages you don't see the footer currently by design) [22:26:52] ah yes. main page is being treated as a special page - let me see why [22:27:03] that context helps * a lot * thanks max [22:27:23] jdlrobson, wrong again [22:27:31] MaxSem: ? [22:27:36] you're urlencoding for usage in HTML [22:28:27] also, before the url is modified [22:29:40] MaxSem: ? - in the interest of reducing the many patch sets i have open that are obviously effecting my mind would you mind fixing that for me? [22:29:51] sure [22:30:11] I wasfixing the previous version when I noticed the lack of footer [22:31:07] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:31:12] thanks MaxSem ^ this fixes the footer [22:31:15] (on main page) [22:32:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56887 [22:33:07] New review: Jdlrobson; "I killed some hash related code with the purpose of making it cleaner. I'd rather we turned the head..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58110 [22:36:44] New patchset: MaxSem; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:36:52] jdlrobson, ^^ [22:37:09] thanks MaxSem [22:37:38] ahh i see - do it after the hook [22:37:40] ragesoss: i'm actually not going to post to VP today [22:37:46] shows my lack of understanding of the hook.. [22:37:50] ragesoss: will do tomorrow. I need to fix [[Commons:Mobile app]] before that [22:38:22] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58550 [22:38:56] gnite everyone [22:39:03] ragesoss: thanks for testing :) [22:39:08] ragesoss: <3 [22:39:10] bye [22:40:04] New patchset: MaxSem; "Rm old b/c code. MF now requires MW master" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58621 [22:41:42] New patchset: awjrichards; "Rewrite menu generation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [22:41:42] New patchset: awjrichards; "Rename scriptUrl to wgScript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58443 [22:41:42] New patchset: awjrichards; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:42:33] huh [22:43:27] jdlrobson: https://gerrit.wikimedia.org/r/#/c/58458/1 seems to make the footer on the main page disappear for me, but other pages look fine [22:43:29] awjr: you're gonna need to merge https://gerrit.wikimedia.org/r/#/c/58551/ for https://gerrit.wikimedia.org/r/#/c/58550/ to work [22:43:38] awjr: you are looking at an old patchset [22:43:40] yeah realized that after i rebased [22:44:00] aw god [22:44:07] did it resubmit a bad version of footer? [22:44:16] gerrit is making me close to tears today [22:44:32] jdlrobson: the original patchset doesn't have the footer on the main page [22:44:41] New patchset: MaxSem; "Cleanup unused vars and doxygen" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58622 [22:44:42] that's why i rebased :) [22:44:49] in the hopes it would magically fix it [22:44:59] well that and to stop failing tests. [22:45:19] erg let me fix this *again* [22:46:52] awjr: so the rebase has replaced the nice patch set 6 with a nasty one [22:47:00] and it won't let me resubmit it [22:47:09] because of the dependencies? [22:48:13] and btw jdlrobson we can't merge config changes til we're read to deploy, so you'll need to remind max about https://gerrit.wikimedia.org/r/#/c/58551/ when we deploy next week [22:48:42] New patchset: Jdlrobson; "Rewrite footer how skins do it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [22:48:53] ok awjr don't rebase anything and get that patch tested and merged :) [22:50:00] jdlrobson: the main page footer is still missing for me in the latest patchset of https://gerrit.wikimedia.org/r/#/c/58426/ [22:50:11] oops [22:50:13] j/k [22:50:13] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/3hRVEA [22:50:13] Commons-iOS/master 2ac3674 Brion Vibber: (bug 47086) improve image caching... [22:50:19] awjr: not possible [22:50:35] jdlrobson: yeah, i forgot to flush my varnish cache [22:51:09] brion: one more thing - hopefully easy: it looks like it won't let me add a device to the prov portal (the iPad mini) - says only a team agent may do so. is it easy to escalate my privileges to team agent? even just temporarily to add the device? [22:51:35] mhurd: alas we can only have one agent, and changing it requires talking to apple support :P [22:51:42] i can add the device easily enough though [22:51:55] brion: cool! [22:51:58] register it on testflightapp.com in safari, it should send me the udid [22:52:07] brion: k [22:52:31] New patchset: Jdlrobson; "jqueryify toggle.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58110 [22:55:44] tfinc: try a master build or wait for tonight's beta and the images should be much more persistent during scrolling :) [22:56:50] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58110 [22:59:16] brion: registered it on testflght [23:00:27] oohhh god qunit tests are breaking now [23:00:59] i see it. adding... [23:01:15] umm so MaxSem Change-Id: I3c219ff300ba3267d06c22769b5e4a700126b337 broke qunit tests [23:01:35] mhurd: ok done [23:01:42] brion: woo! [23:01:49] New patchset: Jdlrobson; "Revert "Don't set $wgResourceLoaderDebug"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58627 [23:02:07] jdlrobson, that thing is completely broken [23:02:28] MaxSem: constructively what is broken [23:03:02] if your tests require debug mode, they're wrong - because production wikis don't run scripts in debug mode [23:03:21] MaxSem: as i understand it jgonera made it require debug mode to ensure load order for qunit [23:03:40] so it's a hack of a hack of a hack [23:03:46] mediawiki is a hack as you once said :) [23:03:54] brion: aaaaand it's good! [23:04:04] woohoo [23:04:16] regardless of his reasons we now have a problem :) [23:04:18] this results in dev wikis always using debug mode, which is horrible [23:04:18] all 3 aspect ratios represented :) [23:04:41] testing the positioning patch now [23:05:05] MaxSem: agreed [23:05:10] but is there a way we can set it for qunit [23:05:21] woot [23:05:27] just do it the proer way [23:05:32] eh, some proper way [23:05:37] tfinc: are the cell numbers a must for release? shouldn't be hard, just checking [23:05:40] you know what I mean [23:05:55] brion: how hard is it to do ? [23:06:07] * jdlrobson needs air desperately [23:06:10] jdlrobson, there are RL dependencies for ensuring load order [23:06:10] not very i think. add a label and set it to the index path key [23:06:10] i'd like to for consistency [23:06:15] ok i'll go ahead then [23:06:19] and visually they look great [23:06:21] good [23:06:43] woot [23:08:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58426 [23:09:08] New patchset: awjrichards; "Rename scriptUrl to wgScript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58443 [23:11:12] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58443 [23:11:24] New patchset: awjrichards; "Rewrite menu generation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [23:17:06] jdlrobson: quick q, probably just a mistake - why are you passing $tpl in line 123 of https://gerrit.wikimedia.org/r/#/c/58458/3/includes/skins/SkinMobile.php? that method takes no params. [23:19:30] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/QfwR4Q [23:19:30] Commons-iOS/master aa8516d Brion Vibber: bug 47085: Add cell index numbers to match Android... [23:20:13] mhurd: ping me when you're ready for review [23:20:33] New patchset: awjrichards; "Rewrite menu generation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [23:21:07] New review: awjrichards; "Just took out the errant $tpl you were passing as a param to getLogInOutLink(). Otherwise, lgtm!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58458 [23:21:41] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58458 [23:22:50] brion: preparing now [23:24:34] can we call this done now, jdlrobson, MaxSem? https://mingle.corp.wikimedia.org/projects/mobile/cards/446 [23:25:08] yes i think [23:25:56] [Commons-iOS] montehurd opened pull request #39: Improved layout on 3.5 inch screens (master...smallScreens) http://git.io/zKmrVg [23:27:08] mhurd: testing... [23:27:13] brion: yay [23:27:20] so MaxSem the change associated with https://mingle.corp.wikimedia.org/projects/mobile/cards/461 only modifies the http status check for the main page - i though we were going to start monitoring and alerting for 500 errors? [23:27:58] mhurd: oh don't be shy about using the simulator either; it doesn't tell you much about real performance but it lets you test some form factor combinations that you may not have handy. usually fine for layout issues [23:28:15] status check will trigger on 500s [23:28:22] brion: good point - especially with second screen [23:28:24] MaxSem: only on the main page of enwiki [23:28:45] what happens in one of the special pages is causing 500s? [23:29:34] what's your suggestion? [23:29:34] like when the watchlist exploded a coupla weeks ago [23:29:34] are 5xxs logged somewhere? [23:29:34] mhurd: omg if you get a retina macbook eventually, it's *great* for the simulator. can run at full resolution <3 [23:29:34] apache log, as always [23:29:34] brion: i never thought about that! [23:29:38] the one you access with fatalmonitor [23:29:44] brion: screen envy... [23:29:53] * brion kinda hopes that Ultra-HD monitors at 24" size will come in and support OS X's hidpi mode [23:30:00] so can we check the apache log for 500s and alert if we cross a certain threshold for mobile-related reqs? [23:30:08] then you could plug em into older machines too [23:30:14] or macbook airs [23:30:20] that would be amazing [23:31:47] i hope apple will eventually push out a ultra-hd iMac and that'll help push high-res monitors for desktop computers / docked laptops [23:32:01] awjr, you can't reliably distinguish mobile fatals in the log, the domain is the same as desktop at this point [23:32:05] otherwise we have to wait… slowly… for manufacturers to scale down their ultra-hd TVs that are huge and overpriced :( [23:32:25] MaxSem: then how about generic 500 monitoring? [23:32:31] im surprised that doesn't exist already [23:32:43] doable, prolly [23:33:13] looks good on 3.5 and 4" screen [23:33:19] double-checking on iPad for surprises [23:33:42] looks good! merging... [23:33:51] why can I get a 10” ultra HD screen with an attached computer for much cheaper than just a normal sized monitor at same res? [23:34:04] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/8kmUlA [23:34:04] Commons-iOS/master e59bfa3 Monte Hurd: Improved layout on 3.5 inch screens... [23:34:04] Commons-iOS/master 2bd958b Brion Vibber: Merge pull request #39 from montehurd/smallScreens... [23:34:41] ragesoss: srsly. :P i can only assume making the larger panels is more expensive (mo pixels, mo failure rate) [23:35:39] buy it's not mo pixels. it's the same! [23:36:36] I thought shrinking the electronics was the expensive thing. [23:37:10] in that case, a 60" hdtv should be cheaper than a 40" one ;) [23:37:29] brion: i'm getting weirdness when i log out of one acct and into a different one… not sure the images are right. hmmm… [23:37:39] oooh [23:37:48] we're probably not remove the old images now [23:38:02] because i changed the refresh to only fetch new items [23:38:08] instead of deleting them all and starting over [23:38:31] mhurd: want to add a 'delete all records' and call it when switching usernames or test mode switch? [23:39:20] unfortunately the best way to delete lots of core data items appears to be to either iterate over the list and delete one at a time (ssllooww) or tear down core data and delete the file, then start over ;) [23:39:36] brion: could do that, or save the images in folder by username [23:39:49] mmm [23:40:04] then we either have to use a separate core data store for each user, or change the schema [23:40:31] could do [23:41:10] brion: ya i'm not sure about the code implications just yet, but the nice thing about this approach is it would reduce network traffic and act as cache - could not fetch an image if you see you already have it [23:41:36] let's go small for now, just delete the items [23:41:45] brion: ends good [23:41:47] but i like the idea of multiple accounts and we should pursue it later [23:41:55] brion: *sounds* [23:41:56] power users do that sort of thing sometimes :) [23:42:09] all's well that ends good [23:42:17] hehe [23:50:55] brion: i like the numbers!!! [23:53:09] :) [23:53:34] they irk me because the sequence numbers mean nothing ;) but everybody loves em, they look nice [23:54:39] hehe [23:55:22] New review: awjrichards; "Can we update the qunit tests to not depend on setting $wgResourceLoaderDebug? That would be a much ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58627 [23:55:26] oh for delete all record method should i just delete "queued" and "thumbs" folders? [23:56:27] mhurd: [app deleteRecord] should delete the queued items…. thumbnails are currently stored in the thumbs folder but without tracking [23:56:34] so yeah could ditch/recrete the dir [23:56:49] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [23:56:53] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [23:57:44] brion: cool, so just folders ditch/recreate, no core-data goodness necessary? [23:57:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58622 [23:58:21] * brion hmms [23:58:39] mhurd: if you delete the uploads.sqlite file maybe [23:58:49] make sure it doesn't kill core data running on the other screen or something tho [23:59:00] brion: will do [23:59:01] i…. think it shouldn't be live when on the login screen though [23:59:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58621 [23:59:58] New review: Jdlrobson; "Has been merged" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58400