[00:00:53] New patchset: Jdlrobson; "Use file name for images with descriptions with templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [00:01:20] New review: awjrichards; "The MinervaTemplate thing seems orthogonal to the rest of this commit, perhaps it would be better to..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [00:01:48] awjr: although it might seem orthogonal it makes more sense… [00:02:03] i am prepared to hear your case :) [00:02:08] that's where i intend for that code to end up and this is a good place to start doing that [00:02:17] currently there is a lot of red code in https://gerrit.wikimedia.org/r/#/c/56351/ [00:02:27] and a lot of it is moving it to the new file - and i'd rather minimize that (hence why the -2 on that) [00:02:47] makes git blame easier as well.. [00:02:55] ok [00:03:09] jdlrobson: what about moving Minerva* out of MobileFrontend into its own extension? [00:03:17] awjr: i'd rather not [00:03:23] why? [00:03:36] convince me - because currently i really think it should not be part of MF [00:03:36] well it's currently a dependency on MobileFrontend [00:03:48] in future it might be worth doing but right now it's too closely coupled [00:04:27] i'd rather just get to a point where we say this needs its own extension and then just do a clean move of files from one extension to the other [00:04:34] i dont think the dependency is a reason to not have it be its own separate extension - zero is like that, for instance [00:04:53] awjr: from a development point of view it's going to be a major headache [00:05:01] i struggle managing commits in 1 let alone 2 extensions [00:05:13] for the sake of my health please let us fork it into a new extension later :( [00:05:20] i can see that - in the long run though it should really be moved out of MF; MF is already bloate [00:05:21] d [00:05:26] awjr: agreed [00:05:33] and that's where i want to get to but we're not at that point yet [00:08:59] awjr: have i convinced you O~O [00:09:06] yes jdlrobson :) [00:09:36] * jdlrobson not sure how to change sad about to burst into tears face into elated face so will just go with \o/ [00:09:55] \o/ [00:12:42] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58256 [00:17:50] New patchset: Jdlrobson; "Story 426: Use file name for images with descriptions with templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [00:18:06] ^ Maryana so it turns out juliusz pretty much did that story in the next iteration [00:18:22] oh, haha [00:18:34] nice work, juliusz! [00:18:45] i love it when devs are telepathic [00:18:47] lol [00:18:53] New review: Jdlrobson; "jdlrobson: awjr: although it might seem orthogonal it makes more sense…" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [00:19:24] isn't juliusz great - does work when he's not even here [00:19:41] and when it didn't even really exist ye! [00:19:42] *yet [00:20:21] ok im winding down - anyone need anything from me before i head out? [00:20:43] New review: Jdlrobson; "The situation has changed now we have agreed on the story referenced in the commit summary. :)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/56613 [00:20:57] awjr: want to review the orthogonal one? [00:21:18] not right now jdlrobson, cant focus anymore, feeling to crappo :( [00:21:25] i'll take a look tomorrow though [00:21:28] okz [00:22:14] i just noticed a sponsored add on my facebook page: 'How to open a dispensary' [00:25:51] i get the best sponsored ads on facebook, especially the dating ones [00:26:25] i got my first one entirely in Korean the other day, and one asking me if i'm interested in meeting single men in my area (Ankara) [00:26:33] i do not live in Turkey [00:27:35] also the ones tryig to convince me that 'hot girls are waiting for me' have now turned into 'ugly girls are waiting for me', no joke, like maybe my standards are too low for the hot girls [00:28:09] maybe targeted advertising would work better if any of my personal information were actually true [00:29:24] yeah, mine are really out there - i got one for a fainting goat auction service once [00:29:49] i mean, i guess owning a fainting goat would be cool... [00:33:23] whoa fainting goats are actually… a thing [00:33:27] http://en.wikipedia.org/wiki/Fainting_goat [00:33:29] i want one like buttermilk which also faints http://youtu.be/5IuRzJRrRpQ [00:33:56] yeah! i guess they're quite useful to have because instead of getting into trouble as most goats do, they just faint [00:34:38] moogsi: ! [00:34:41] want [00:35:41] Maryana: me too but i have a suspicion that she only shuts up when asleep... if she does sleep... [00:36:00] and then one day she'll grow up and eat _everything_ [00:36:20] (or so i'm told is the problem with goats) [00:36:26] actually, she reminds me of yuvipanda :) [00:36:55] his panda avatar is inaccurate. he's way more energetic than that [00:42:05] least hyperactive animal, excepting the noble sloth [00:42:16] or maybe the manatee [00:42:36] afaict they just sit around all day eating bamboo and farting and not having sex [00:44:45] i don't have enough room for a goat, not even a tiny one... a housegoat would also eat all my stuff [00:45:07] maybe i'm onto something there, micropigs seem to be a market... [00:45:13] pygmy housegoats [00:46:03] omg [00:46:13] i wonder what my dog would do with a pygmy housegoat [00:46:25] first GIS hit for "microgoat": http://img.yessy.com/688808607-32050b.jpg [00:46:45] ! [00:47:04] maybe it's not feasible because they would eat everything and poop everywhere [00:47:50] pigs are at least clever enough to train [00:47:52] New patchset: Jdlrobson; "Story 438: Log uploads from nearby and watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58641 [00:48:54] awjr_away: i think they would probably be best buddies forever? [00:56:38] brion: not getting expected behavior when deleting the folders and sqlite file… ok to pick it up again tomorrow? [00:56:57] mhurd: sure, we'll figure it out in the morning [00:57:04] brion: sounds good! [01:02:41] Maryana: https://en.m.wikipedia.org/w/index.php?title=Zuni_Cafe&curid=9652642&diff=549472489&oldid=543146911 [01:03:13] shrug [01:03:53] i guess some people are very sensitive about filenames..? we stopped using the generic "lead photo for blah" prefix awhile ago, just to make them happy :) [01:13:57] New patchset: Jdlrobson; "Dev Change: Allow nearby page to run on a different api" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58647 [01:13:57] New patchset: Jdlrobson; "Rewrite nearby as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58648 [01:15:09] tfinc: weird. [01:33:18] New patchset: Jdlrobson; "Rewrite nearby as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58648 [01:33:18] New patchset: Jdlrobson; "Surface page images on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58652 [08:02:26] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58485 [08:02:26] New patchset: Zfilipin; "Updated watir-webdriver Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58673 [14:21:49] everyone's asleep... [14:23:10] That's what you think... [14:25:08] wiki never sleeps :) [14:25:56] severely jet-lagged, should get some coffee quick [15:11:11] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58673 [15:12:09] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58673 [15:12:10] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58485 [15:51:48] * YuviPanda hands yurik_ coffee [16:13:59] * YuviPanda waves at valeriej [16:14:03] valeriej: hey [16:14:10] Hey YuviPanda! [16:14:17] good... afternoon? [16:14:40] valeriej: had any chance to work on the android stuff yet? :) [16:14:44] Almost! It's 11:00 over here. :) [16:15:05] :) [16:16:47] YuviPanda: I've been reading the android developer site and looking through the code. You said you use InelliJ? [16:16:55] valeriej: yup@ [16:16:57] yup! [16:17:05] at least on OS X it is *faaar* less buggy than OS X [16:18:14] YuviPanda: Ah. Can you help me set it up? I tried, but I'm not sure if I'm doing it right, hah. [16:18:24] valeriej: glad to help! what are you having trouble with? [16:21:23] YuviPanda: I'm not sure if I've got the dependencies set up correctly. There are probably other errors, too. [16:22:00] valeriej: hmm, okay. I can walk you through it now if you want! [16:22:18] YuviPanda: Sure! That'd be great! :) [16:22:23] valeriej: :D okay [16:22:37] valeriej: one moment, let me make a fresh clone so that I can do it the same way :) [16:22:41] valeriej: I suggest you do the same too :) [16:23:09] YuviPanda: Can do. [16:23:52] valeriej: done? [16:25:06] YuviPanda: Done. [16:25:13] valeriej: okay. Open IntelliJ, [16:25:17] File -> Import Project [16:25:34] Ok. [16:25:42] valeriej: and navigate to that folder that you cloned it from [16:25:45] s/from/to [16:25:59] Ok. [16:27:16] I've got the option to 'Create from existing sources' or 'Import from external model', and I initially selected 'Import from external model' and selected Maven. [16:27:19] valeriej: next screen, select 'import project frome xternal model' [16:27:21] yeah [16:27:23] that's correct [16:27:27] Ok. [16:27:29] so the bit is [16:27:31] * andre__ waves at valeriej [16:27:33] in the next screen [16:27:42] select 'import maven projects automatically' [16:27:48] * valeriej waves at andre__ "Hi!" :) [16:28:18] valeriej: also the 'search recursively' checkbox [16:28:21] then click next [16:28:23] YuviPanda: Do I need to uncheck anything? [16:28:29] nop [16:28:29] e [16:28:43] ignore the 'profiles' thing [16:28:44] Ok. [16:29:03] hit next [16:29:06] hit next again [16:29:18] you should see 'SDK select' [16:29:23] do you see Android in it? [16:30:21] valeriej: ^ [16:31:23] Yeah, I'm on select project SDK. It has Android 4.0.3 Platform information already populated. [16:31:43] valeriej: hmm, it should work. select it and hit nedxt? [16:31:56] project name is fine [16:31:57] hit next [16:32:10] I don't have anything in the Java SDK, is that ok? [16:32:19] * valeriej hasn't hit 'next' yet. [16:32:35] hmm, if it isn't good enough it'll complain [16:32:43] so hit next and we'll see? [16:32:46] Ok. Hitting next. [16:33:07] Hit next again and it says 'no frameworks selected.' [16:33:25] that's okay [16:33:53] s/selected/detected [16:34:03] yeah, oyu can keep hitting next till the end on that one [16:34:12] Ok, I hit finish. [16:34:17] awesome. now try to compile? [16:35:36] I hit the 'Make Project' button and got this error: Cannot start compiler: the SDK is not specified for module "~apklib-com.actionbarsherlock_actionbarsherlock_4.2.0". [16:36:06] yeah that's fine [16:36:15] open the project structure dialog? [16:36:48] This is where I stopped, ha ha. I didn't know what to change in the project structure dialog. [16:36:53] valeriej: :) [16:36:53] It's open. [16:37:08] valeriej: so do you see 'Module SDK' [16:37:08] ? [16:37:12] and a drop down right next? [16:37:33] select 'Android 4.0.3' from it :) [16:37:50] Yes. Ok. [16:37:53] valeriej: and hit okay [16:38:06] Got it. [16:38:14] valeriej: still not done, you'll have one more error ;) [16:38:22] try to compile again [16:38:41] Ok. [16:39:24] valeriej: did you get a load of errors? [16:39:46] Just one: "Cannot find JDK ''..." [16:40:04] valeriej: oh, that is.. weird [16:40:09] valeriej: open the project structure dialog again? [16:40:45] It's open. [16:40:55] There was more to that error message if you want me to type it. [16:41:25] can you copy past eit? [16:41:45] Ah, yes: java: Cannot find JDK '' for module '~apklib-com.actionbarsherlock_actionbarsherlock_4.2.0' [16:42:27] valeriej: hmm, open the ~apklib-com.actionbar* entry under Modules [16:42:50] next to 'Android 4.0.3 Platform' do you see a Java version in parens? [16:43:37] No. [16:43:52] valeriej: ah, hmm [16:44:17] valeriej: select 'SDKs' on the left pane? [16:44:31] Ok. [16:45:03] valeriej: and select 'Android 4.0.3' entry [16:45:11] what is specified under 'Java SDK'? [16:46:17] Nothing. [16:46:25] valeriej: select it? do you see any options? [16:46:51] Nope. [16:48:00] valeriej: ah, okay. [16:48:15] valeriej: hit the '+' button on the top of the second pane [16:48:29] and select 'JDK' from the list? [16:49:08] Oh, got it. [16:50:40] valeriej: :D [16:52:03] So I navigate to my jdk, just the jdk folder? Or to the bin folder? [16:52:03] valeriej: works? [16:52:10] valeriej: just the jdk folder [16:53:04] Ok, I have a selection available under Java SDK now. Just hit 'ok'? [16:53:20] Oh, wait. [16:53:28] hmm? [16:53:37] Under Modules do I still have Android 4.0.3 Platform selected? [16:53:39] you need to have jdk 1.6, btw. 1.7 doesn't work with android too well [16:53:55] valeriej: yeah, and you set the 'Java SDK' of 4.0.3 to 1.6 [16:54:09] Ok. [16:55:27] Wee, now I have a bunch of errors. [16:55:59] Specifically in ActionBar.java. [16:56:55] valeriej: yes, that's better :D [16:57:06] valeriej: scroll to the top [16:57:08] valeriej: do you see import android.support.v4.app.FragmentTransaction; [16:57:14] Yes. [16:57:15] with the red on FragmentTransaction? [16:57:20] *nodnod* [16:57:29] put the cursor on that [16:57:32] and hit, option enter [16:57:41] hmm, i'm not sure what the equivalent of option in windows is :| [16:57:58] ctrl? alt? [16:58:05] whatever that pops up the 'auto fix' dialog [16:58:45] Hrm, let me see... [16:59:03] 'alt' it seems. [16:59:32] YuviPanda: What do I select in the dialog [16:59:35] ? [17:00:00] valeriej: do you see 'add android compatibility library to classpath'? [17:01:13] I have two options to add a library to classpath. [17:02:07] valeriej: yes, one should be 'compatibility library' [17:02:10] other should be something else? [17:02:14] pick the compatibility library [17:02:17] Maven: android:android: 4.1_r2 [17:02:21] Ok. that's the other one. [17:02:33] Got it. [17:04:04] valeriej: yeah, the other one [17:04:22] valeriej: try compiling now [17:05:35] YuviPanda: It's compiling. [17:05:41] \o/, should work [17:07:32] \o/ Success! [17:07:41] Thanks YuviPanda! [17:07:45] :D [17:07:48] valeriej: try it out :) [17:07:56] valeriej: also if you can, turn this into a doc? :D [17:08:03] it's got a lot of non-obvious parts, now that I think about it [17:08:23] I need to make a configuration, right? And yeah, I can do that! :) [17:09:47] make a configuration as in? [17:11:48] Right now I don't have the option to 'Run' the project (It's grey). For me there's a down arrow next to the 'Make Project' button. When I click that arrow, it says 'Edit Configuration' [17:12:45] Reedy: ah, right. [17:12:47] err [17:12:48] not Reedy [17:12:49] i mean [17:12:50] valeriej: [17:12:52] When I click 'Edit Configurations' the 'Run/Debug Configurations' dialog opens. [17:12:56] * Reedy beats YuviPanda [17:13:18] valeriej: yeah, you can select 'Android Application', set 'Module' to commons [17:13:21] and that should be enough [17:13:41] valeriej: oh, and you probably want to set 'target device' to 'show chooser dialog' [17:13:43] than emulator [17:13:45] because emulator sucks [17:13:46] majorly [17:14:29] YuviPanda: Ok. [17:16:34] YuviPanda: It's not working :/ I select 'Run' and then I have to 'Edit Configurations' again. I have 'Launch default Activity' selected. [17:16:53] valeriej: hmm, try this [17:17:02] valeriej: in 'edit configuration', there should be a '+' in the left pane [17:17:13] Create a new one, select the same options, and hit save [17:17:21] Ah, ok. [17:18:45] valeriej: works? [17:19:26] Yeah. I need to create a new one instead of changing the default. [17:19:30] It's running! [17:19:59] valeriej: :D [17:20:00] niceee! [17:20:07] * YuviPanda loses ragesock in a washer [17:20:15] :) [17:23:57] morning all [17:24:08] hiya brion [17:24:17] yo [17:24:35] * brion waves at mdale  [17:25:08] Where should I put a page on how to set up IntelliJ for CommonsApp development? Mediawiki or Meta? [17:25:12] YuviPanda: the trello board for sprint 6 appears to have vanished [17:25:18] brion: ... oh? [17:25:25] valeriej: mediawiki.org probably [17:25:36] brion: https://trello.com/board/mobile-app-team-sprint-6/5162461b43476994540002ba [17:25:40] brion: Ok, thanks! [17:25:45] yeah if i follow the direct link it's there [17:25:47] valeriej: brion actually, put it in the repo itself? [17:25:50] but i don't see it on my dashboard :P [17:25:55] brion: ah, hmm, i see [17:25:56] YuviPanda: in README? probably good idea yeah [17:26:08] valeriej: brion yeah, we should keep it in line with the source, etc. [17:26:17] brion: let me see if I can fix that [17:26:17] YuviPanda: ok i see it in the 'boards' drop-down so… i can live with that [17:26:23] but nice if it shows up again :D [17:26:29] hmm, sounsd like a bug [17:26:33] since we moved 'organizations' [17:26:39] valeriej: submit a pull req :) [17:26:47] valeriej: and use markdown, not wikitext :) [17:26:58] YuviPanda: Ok, I'll start working on that. :) [17:27:50] valeriej: \o/ [17:32:15] oh finally, i figured out how to take screenshots on my windows tablet without attaching a keyboard with a 'print screen' button [17:32:19] windows+volume down [17:33:41] brion: :D [17:33:58] every damn os has a slightly different shortcut for it [17:35:46] i like trello so far… i've been meaning for years to make a mediawiki extension that does roughly that but never got round to it [17:35:53] i gotta do more late-night hacking :) [17:39:58] brion: :) [17:40:09] brion: best type of hacking [17:45:07] hey MaxSem yurik_ what am i doing wrong with the api this time? https://gerrit.wikimedia.org/r/#/c/58652/ [17:46:10] looking [17:47:42] jdlrobson, why so huge thumbs? [17:47:56] MaxSem: just copying watchlist [17:48:25] ugh. watchlist needs to be fixed then:) [17:49:08] grr [17:49:09] grr [17:49:17] http://www.nypost.com/p/news/international/hijacking_plane_there_an_app_for_li4kBgbCRALBHSdqPKZZeP [17:53:27] MaxSem: no there's a good reason for it [17:53:34] jdlrobson, why do you consider its result random? [17:53:41] MaxSem: we need to stretch the thumbnail [17:53:48] why? [17:54:00] design request - it looks crap when there is white above or to the sides [17:54:15] anyway… MaxSem: so there are 2 problems 1) the result of the search is NOT the same as just doing a straight geosearch [17:54:18] don't forget it's mobile-oriented service every byte is counted [17:54:26] 2) the result doesn't provide distance [17:54:43] so the results are NOT the closest things [17:54:50] 1) lgtm [17:54:55] MaxSem: check it out and try it yourself [17:55:10] tried in london [17:55:12] currently shows NaN distance from your current location… [17:55:14] same stuff [17:55:36] 2) it shouldn't as geosearch is used only as a generator [17:55:48] so you'll also need to request prop=coordinates [17:56:04] MaxSem: can you paste a url? ApiSandbox wasn't being helpful.. [17:56:22] you can't construct such URLs in apisb [17:56:57] compare https://en.wikipedia.org/w/api.php?action=query&prop=pageimages&format=jsonfm&pilimit=10&generator=geosearch&ggscoord=51.507222%7C-0.1275&ggsradius=10000&ggslimit=10 [17:56:58] vs. [17:57:15] https://en.wikipedia.org/w/api.php?action=query&prop=pageimages|coordinates&format=jsonfm&pilimit=10&generator=geosearch&ggscoord=51.507222%7C-0.1275&ggsradius=10000&ggslimit=10 [17:57:39] you'll have to calculate the distance yourself though [17:58:32] see extensions/GeoData/GeoDataMath.php, function distance() [17:59:47] awjr & jdlrobson, I fixed $wgMFVaryResources on testwiki, can you look if it works for you? [18:00:00] sure MaxSem, give me a few minutes [18:00:22] in a bit yah [18:00:36] New patchset: Zfilipin; "Refactored pages to use only one MediaWiki URL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58724 [18:05:43] New patchset: Jdlrobson; "Allow overlay heading title to span 2 lines" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58725 [18:06:00] New review: Jdlrobson; "Wait for https://gerrit.wikimedia.org/r/#/c/58332/ to be merged - otherwise breaks search" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/58725 [18:07:41] brion: it's called deleteAllRecords on https://github.com/montehurd/Commons-iOS.git [18:13:26] MaxSem: so what should the request URLs look like for device-specific CSS on testwiki? [18:13:57] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.device.detect%7Cmobile.styles%7Cmobile.styles.page&only=styles&skin=mobile&target=mobile&* [18:14:04] MaxSem actually i dont really care, it appears to be working [18:14:25] when i spoof myself as iphone, the CSS response headers show: Vary:Accept-Encoding,X-Device [18:14:44] and all reqs now have X-Device set in the resp headers [18:15:12] and when i just use X-Device: webkit, everyhting looks good too [18:17:54] MaxSem: allso lgtm with js disabled [18:18:14] awjr, I don't see Vary: X-WAP though [18:18:39] MaxSem: probably because Varnish is not setting that [18:18:47] yup [18:18:49] weird [18:19:05] the change to set X-Wap hasn't been merged yet has it? [18:19:20] it was [18:19:25] o [18:19:54] see device-detection.inc.vcl.erb [18:21:04] ugh [18:21:59] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/PQOdNw [18:21:59] Commons-iOS/master 0d443a2 Monte Hurd: Reset the uploads on login... [18:22:20] brion: yeahhh! [18:23:24] awjr, I have a suspicion that an include change didn't trigger a VCL reload [18:23:38] that would make sense MaxSem [18:23:52] im not seeing anything weird in code [18:23:56] or, weirder than usual [18:25:37] yeah, from reading through X-WAP related code in config and in MF, it should work [18:28:50] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/JLpVlA [18:28:50] Commons-iOS/master 2ba866b Brion Vibber: Fix positioning of sequence number... [18:36:01] So MaxSem - why do some pages from the geo api not have coordinates in the response ? e.g. 'Palace Hotel, San Francisco' [18:36:14] url? [18:36:35] http://en.m.wikipedia.org/w/api.php?format=json&action=query&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.78670760000001%7C-122.39959539999998&ggsradius=10000&ggsnamespace=0&ggslimit=50&_=1365705318404 [18:37:11] "4574532":{"pageid":4574532,"ns":0,"title":"Palace Hotel, San Francisco","thumbnail":{"source":"http://upload.wikimedia.org/wikipedia/commons/thumb/9/95/Palace_Hotel_and_Lotta%27s_Fountain.jpg/180px-Palace_Hotel_and_Lotta%27s_Fountain.jpg","width":180,"height":135},"pageimage":"Palace_Hotel_and_Lotta's_Fountain.jpg"} [18:38:29] grr [18:38:43] MaxSem: can we open a bug [18:38:51] yes please [18:39:09] I feel I need to make a GD bugfixing sprint [18:39:11] k will do [18:40:55] brion: fixed that toggle weirdness :) [18:41:02] \o/ [18:47:31] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/TTa-tg [18:47:31] Commons-iOS/master 5d4d468 Brion Vibber: Fix regression when no camera available... [18:52:11] New patchset: Jdlrobson; "Surface page images on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58652 [18:52:14] New patchset: Jdlrobson; "Bug 44959: Translate wiki related fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58735 [19:43:55] MaxSem: will we be flipping on $wgMFVaryResoruces everywhere next week? [19:44:59] awjr, there are several problems with it [19:45:28] first, looks like we can'tenable it on wikis w/o a dedicated mobile host [19:45:31] eg on Commons [19:45:50] how come? [19:46:13] it's served via Squid, no X-Device or anything [19:46:31] i thought squid still redirectedt hose requests to varnish [19:46:39] but that might have just been in my head and not based in any reality [19:46:41] how? [19:46:50] looking for useformat=mobile [19:46:56] i think [19:47:24] oh wait [19:47:29] also, commons does have a dedicated mobile host [19:47:33] we jsut don't automatically redirect [19:47:42] http://commons.m.wikimedia.org/ [19:48:14] lol [19:48:24] im surprised we don't have that set up in the conf actually - the 'mobile view' link on commons doesn't point to the .m [19:48:32] and for useformat=mobile it's Vary: Accept-Encoding,Cookie,X-Carrier,X-Subdomain,X-Images [19:48:38] no X-Device [19:48:46] sad panda [19:49:01] we need to do something about commons [19:49:26] well commons is easy - we should just make it use the .m [19:49:41] we dont necessarily need to set automatic redirection, but just configure it to use the .m [19:51:17] MaxSem: also, we could configure squid to look for mobileFormat cookie (which is used to keep people on the mobile site when no .m is set up) [19:51:22] and then forward requests to varnish [19:51:51] since squid is being deprecated, that's unlikely to happen [19:51:57] dude [19:52:04] squid has been being deprecated for the last 3 years [19:52:17] plus that should be an easy change [19:52:39] nah, I'm just using my psychic powers to predict the ops' response ;) [19:52:44] lol [19:52:56] so commons is an easy fix, we just fix MW config to use the .m [19:53:15] are the other non-.m projects enough of an edgecase to not worry about right now? [19:53:53] we can tell by using $wgMobileUrlTemplate [19:54:00] yah [19:55:26] fwiw we could add an acl in mobile /h/w/conf/squid/mobile_acls.conf to look for mobileFormat cookie [19:55:45] also, we need JS testing. jdlrobson, you appear to be the only person ATM near our deposit of phones:) [19:55:58] speaking ofo which… where is michelle? [19:56:06] jon is currently interviewing a product manager candidate [19:56:15] she's travelling back home [19:56:23] i thought that wasn't til next weds [19:57:01] she is supposed to be out tomorrow (4/12) [19:57:10] meh - she should be able to help coordinate testing too [19:57:28] so MaxSem the blockers for turning this on next week are dealing with non-.m domains and testing? [19:58:11] due to the X-WAP problem I'm not declaring a public testing yet [19:59:02] yah - did you check with ops about that? [19:59:41] was investigating how to make it update automatically next time [20:00:04] can't make it elegant so far [20:00:13] poke ops [20:01:45] ok i gotta go get lunch before next interview - bbiab [20:16:17] MaxSem: sorry was in interview [20:16:33] was it successful? [20:16:34] MaxSem: so I still think this would be better done by crowd sourcing some testing [20:16:34] New patchset: Zfilipin; "Refactored pages to use only one MediaWiki URL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58724 [20:16:43] MaxSem: i'm still collecting my thoughts :) [20:17:10] MaxSem: I have various phones but no where near enough to successfully say things are fine. [20:18:21] MaxSem: could we coordinate with jcmish or quim and maybe ask people to visit test.wikipedia.org on any phones they have, ask if login is available. If so create an account and login, attempt to watch the article, attempt to open a section report back the results ? [20:18:41] oh btw MaxSem page images on nearby looks awesome - super excited :) [20:19:28] jdlrobson, when? today or can we organize something properly? [20:20:17] qgil_: sooner the better i think - we are making a major change to how we decide phone support. The main thing to check is older mobile devices can view articles [20:20:18] I'll just write to wikitech-l [20:20:39] MaxSem: that would be good too but the more people we can rope in the better :) [20:20:58] oh btw MaxSem i spoke to patrick the other day and he says those user agent strings came from his head not WURFL :) [20:21:07] (the ones in DeviceDetection :)) [20:22:04] * jdlrobson needs to grab lunch before interview #2! yey! no coding for me today! :P [20:22:21] mmm, he was quite a machine then:) [20:28:38] MaxSem: i am a little concerned about crowd-testing on testwiki - what about enabling $wgMFVaryResources on one or a few wikis next week and using that for testing? [20:29:00] what's the difference? [20:29:23] quite a few, for instance testwiki doesn't get resources from bits [20:29:45] plus other quirks of testwiki that won't give us a full picture [20:29:50] where else would you crowd-test other than testwiki or test2wiki awjr_lunch? MediaWiki.org? [20:30:03] yeah, that's what iw as thinking Thehelpfulone [20:30:17] test2 doesn't have a mobile domain [20:30:17] mw.o [20:30:25] poor mw.org, it's Echo's testing ground too [20:30:38] it's the testing ground for everything :) [20:30:53] MW releases get tested there before being rolled out everywhere else [20:33:04] what do you think MaxSem? ^ [20:33:19] mwahaha [20:33:42] can we have a short in-house testing before doing it? [20:34:21] on testwiki? [20:34:35] * YuviPanda has been going through other people's code and merging stuff on random extensions [20:34:39] * YuviPanda hopes that nobody kills him [20:34:54] YuviPanda: i imagine many people will actually be quite happy :) [20:35:03] with the possible exception of maintainers... [20:35:06] awjr: :) [20:35:19] awjr: well, I'm only merging minor patches that have been just 'sitting' there for a while [20:35:30] oh YuviPanda, you will be regaled as a hero. [20:35:46] awjr: usually in extensions that are not actively maintained. One for ApiSandbox, one for Nuke, a couple in UW [20:35:47] now looking for similar patches... [20:36:05] awjr: I only realized I've +2 on mediawiki/* about a month ago :) So... doing what little good I can. [20:36:21] MaxSem: so in-house test against testwiki, small rollout to mw.o and crowd-source testing, then rollout to everywhere else? [20:36:25] hehehe YuviPanda :) [20:36:29] :) [20:36:31] yes [20:37:16] that sounds really good to me MaxSem [20:47:51] rawr http://stats.wikimedia.org/wikispecial/EN/SummaryMEDIAWIKI.htm <-- no page view stats [21:06:39] [WikipediaMobile] brion created r7-win8 from master (+0 new commits): http://git.io/aUVWHw [21:06:58] Project WikipediaMobile - Nightly builds build #510: SUCCESS in 16 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/510/ [21:06:59] Brion VIBBER: Bump Win8 version to 1.0.0.29 (r7) [21:07:07] Project WikipediaMobile - Nightly builds build #511: SUCCESS in 8.6 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/511/ [21:11:19] * brion toddles around waiting for windows 8 app validation to run [21:11:24] been meaning to get this bug fix release out for a while [21:11:33] New patchset: Jdlrobson; "Style nearby distance" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58824 [21:11:33] New patchset: Jdlrobson; "Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [21:14:06] jdlrobson: im gonna run 10 minutes late again since we started 12 mins late [21:14:19] awjr: :( but thanks for the headsup [21:22:41] [WikipediaMobile] brion pushed 2 new commits to r7-win8: http://git.io/g3yrZw [21:22:41] WikipediaMobile/r7-win8 2fb2556 Brion Vibber: Win8: set a setting to pass store validation [21:22:41] WikipediaMobile/r7-win8 52754ab Brion Vibber: win8: update store info [21:22:51] [WikipediaMobile] brion merged r7-win8 into master: http://git.io/g3yrZw [21:24:30] Project WikipediaMobile - Nightly builds build #512: SUCCESS in 25 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/512/ [21:24:31] * Brion VIBBER: Win8: set a setting to pass store validation [21:24:31] * Brion VIBBER: win8: update store info [21:37:19] New review: Cmcmahon; "manage various URLs" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58724 [21:37:19] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58724 [21:37:30] awjr: you done yet? [21:37:39] ping me when you are :) [21:37:42] almost jdlrobson - i just want to give him a minute to ask me qs [21:37:43] will do [21:41:29] jdlrobson: just lost my connection with kenan, but go on ahead - tell him i'll finish answering his question via email and to feel free to shoot me any other questions he might ahve [21:41:50] i think his laptop battery died [21:51:03] brion: quick question when u have a sec [21:56:09] question answered :) [21:56:16] :) [22:19:05] jdlrobson: thanks for sending that to mobile-l instead of mobile-tech :) [22:19:16] YuviPanda: ;-) [22:25:34] jdlrobson: I'm thinking that we should stick to wikitech-l [22:25:39] jdlrobson: mobile-l seems to be a ghost town [22:25:53] YuviPanda: i think we should keep mobile-l but use it more [22:26:04] i've been meaning to talk more with the team in next retrospective [22:26:23] jdlrobson: hmm, right. But the one email I forwarded, for example, should go to wikitech-l [22:26:27] but the wikimania one on mobile-l [22:26:30] I guess/ [22:26:31] ? [22:44:47] YuviPanda: both if necessary. If it's on a public mailing list you just forward it [22:44:58] heh, good enough :) [22:45:27] the wikimania one though i'll leave to others outside the team to forward [22:45:35] i'm kind of interested if it is forwarded [22:45:37] oh that reminds me i need to submit a talk for wikimania [22:45:58] should i do the mobile apps, or another crazy research project? [22:46:19] brion: you should just sit at the front of the stage with a huge complicated chemistry set [22:46:33] (and blow stuff up of course) [22:46:47] and somehow bring it back to be about mobile [22:47:12] brion: mobile app stuff together? :) [22:47:20] brion: or one of us could do the 'why off phonegap' and the other 'commons app' [22:47:32] brion: or we could have *3* talks, one for 'why off', one for iOS and one for Android [22:47:54] jdlrobson: i can drop mobile phones into various chemicals [22:48:24] YuviPanda: Maybe you could make it controversial by making a cardboard cereal box with "Phonegap" written on it and blow it up with brion's chemicals [22:48:37] i love it when a plan comes together [22:48:39] niiiice [22:48:41] jdlrobson: :D [22:48:50] or we could set fire to it [22:48:56] as a bonus, we'll test the fire alarm system [22:48:56] s [22:49:25] jdlrobson: my last year's talk had a slide of captain picard and riker doing a facepalm together, and I explained it by saying that it is a headache to maintain native versions for iOS and Android [22:49:39] YuviPanda: i was there man i was there [22:49:42] yeah [22:49:52] oh what fools we were [22:50:05] perhaps we should dress up a phonegap red shirt and send it on an away mission... [22:50:07] i still like html development, but DAMN it needs a debugger and actual device capabilities that work [22:50:31] brion: indeed. Nobody seems to be putting work into it, though [22:50:43] brion: there's lots of talk about webrtc, but nobody's fixed css flexbox [22:50:48] or