[00:06:22] jdlrobson: what was the patchset you wanted me to look at yesterday? [00:17:34] awjr: https://gerrit.wikimedia.org/r/#/c/58459/ [00:17:43] ah good, im in the middle of that already :) [00:21:30] New review: awjrichards; "(7 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58459 [00:26:32] jdlrobson: how come https://gerrit.wikimedia.org/r/#/c/58648/3 has a dependency on https://gerrit.wikimedia.org/r/#/c/58647/2? it would be nice if we didn't create unneeded dependencies as it makes code review/merging more complicated [00:27:17] awjr: dependencies are there for a reason :) [00:27:26] awjr: alway review the first one :) [00:27:37] you can't test nearby without it [00:27:41] jdlrobson: i get that, but i dont see why one is a dependency on the other in this case [00:28:05] well awjr if you can't test it how can you review it properly? [00:28:16] i couldn't develop it properly without it :) [00:28:38] well then that's reasonable :p [00:31:49] New review: awjrichards; "I dont think this is the best approach as what you're expecting to be set for $wgNearbyHost to be ju..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58647 [00:35:42] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58647 [00:36:25] New review: Jdlrobson; "We currently use this technique for $wgMFPhotoUploadEndpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58647 [00:36:49] jdlrobson: i cant use ^^ with my setup. [00:37:00] awjr: why not? [00:37:25] because you are assuming the URL patterns are the same between enwiki and the dev environment, which in my case is not true [00:37:49] * YuviPanda has not been able to sleep, has gone and reviewed several more patches since [00:37:51] this is addictive [00:37:57] what that does for me is make the request url look like: en.wikipedia.org/testing/core/api.php [00:38:02] which… obviously doesn't work :p [00:39:23] what are you setting as the host? [00:39:30] en.wikipedia.org [00:39:56] set it to http://en.wikipedia.org/ [00:40:16] I assume you set wgScriptPath ? [00:40:30] the problem is the script path, not the host [00:40:47] look at what you're doing on line 31 of jabascripts/specials/nearby.js [00:41:05] if $wgNearbyHost is not set, you just use the API url (which i believe is script path + api.php) [00:41:23] the API url in my case is /testing/core/api.php, which is not the same as that for en.wikipedia.org [00:41:40] im suggesting that you just use the whole URL for the api endpoint in wgNearbyHost instead of trying to set just the host [00:42:02] like you guys wound up doing with the photo endpoint (i think i had this same convo with juliusz) [00:42:31] lol s/jabascripts/javascripts [00:42:36] huh [00:43:22] awjr: what does mw.config.get( 'wgScriptPath', '' ) + '/api.php'; return for you? [00:43:27] just /api.php ? [00:43:53] mw.config.get('wgScriptPath') + '/api.php'; [00:43:54] "/testing/core/api.php" [00:44:08] so oh i see what your saying [00:44:15] my wgScriptPath is different than that of enwiki [00:44:19] ok yeh i'll make it an endpoint [00:44:21] :) [00:44:23] thanks [00:45:07] i think with that change it will be mergable [00:59:56] [Commons-iOS] montehurd opened pull request #40: More small screen updates (master...moreSmallScreenTweaks) http://git.io/pAZrmw [01:12:42] New patchset: Jdlrobson; "Story 419: Nearby distance enhancements" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58847 [06:06:35] New review: Siebrand; "i18n/L10n LGTM as discussed on IRC." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/58847 [08:39:41] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58863 [11:20:55] New patchset: Zfilipin; "wmf-selenium-bot should not report SCM changes in IRC notifications" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58870 [13:53:43] YuviPanda: yeah that's about what i expected really [13:54:00] maybe ~10% of that first flurry were actually useful [13:54:36] moogsi: yeah [13:54:46] that's why people were annoyed i think - the people who do the frontline maintenance stuff are pretty insular and there's not many of them [13:54:54] + they weren't expecting it = upsetness [13:55:12] moogsi: true. [13:55:36] moogsi: I also think that we were not expecting that many, uh, selfies [13:55:47] haha [13:55:49] and preachy proclamations of the return of the christ [13:56:03] moogsi: the running joke was a flood of penises, not selfies [13:56:26] surprised by the lack of genitals in general, really [13:56:52] dick shots are a special brand of selfie [13:58:19] one thing i know after seeing what comes into Commons is, people are now conditioned to spread pictures of themselves everywhere, indiscriminately and apparently to no end [13:58:23] THANKS FACEBOOK [13:58:37] moogsi: yeah [13:58:37] moogsi: :D [13:58:38] moogsi: that is true. [13:59:22] moogsi: I think we all got blindsided by facebook, tbh [13:59:33] moogsi: if we had done it right, people would be addicted to wikipedia, not facebook [13:59:52] haha wikipedia would have to be very different [14:00:12] true [14:00:45] it's quite difficult to be so superficial and get any meaningful work done at the same time [14:01:13] moogsi: true [14:01:19] moogsi: but that's also guided by the software itself [14:01:41] no it definitely could be easier to talk to people [14:02:04] moogsi: Flow is coming [14:02:07] moogsi: Echo is coming [14:02:09] moogsi: Mobile is coming [14:02:12] ooh [14:02:23] moogsi: 2013-2014 is going to be nice :) [14:02:30] you sound like an action move trailer [14:02:32] :P [14:02:38] moogsi: sooooon! [14:02:38] :P [14:02:42] uh huh [14:02:48] FALL 2018 [14:02:52] or.. whenever [14:02:58] moogsi: one of the other things we've in the background is support for h264 / aac support [14:03:01] FALL, WHEN IT'S DONE [14:03:17] moogsi: that should explode our audio / video stuff [14:03:21] ooh fancy [14:03:40] moogsi: but I think a good number of people on commons will come at us with Pitchforks [14:03:54] proprietary formats... [14:04:06] moogsi: well, they aren't proprietary [14:04:16] moogsi: they're patent encumbered in certain parts of the world [14:04:20] patent-encumbered formats? [14:04:22] ah [14:04:45] moogsi: and we won't be violating laws either [14:05:27] i was talking to some dude about uploading .wavs [14:05:37] moogsi: wav has no patents on it [14:06:07] i don't know what's wrong with it [14:06:09] moogsi: we'll be using free software to do our encoding and decoding too [14:06:12] moogsi: oh, it's just huge [14:06:18] i guess MS owns it kinda? [14:06:21] moogsi: think about why we don't accept BMP for example [14:06:22] moogsi: not really [14:06:31] no, people seems to think there would be some philosophical objection [14:06:42] moogsi: there was, on the bug [14:07:03] because Commons is pathologically dedicated to freedom [14:07:19] hehe [14:07:21] but, we have .GIF i guess [14:08:08] moogsi: those patents expired [14:10:20] moogsi: and we have limited GIFs too [14:10:57] moogsi: https://commons.wikimedia.org/wiki/File:Child_running_through_gravity_illusion_room_at_Children%27s_Museum_of_Pittsburgh.gif [14:10:58] :D [14:12:29] moogsi: there seems to be surprisingly little spam in the Android category :) [14:12:36] I just had to mark one image for deletion! [14:12:39] in one entire page! [14:13:36] moogsi: https://commons.wikimedia.org/wiki/File:Chicken.gif [14:15:44] haha [14:16:21] i saw that one with the kid [14:16:54] moogsi: yeah, that's the kid of ragesoss :) [14:17:03] anyway this is why he wanted .wav: https://www.mediawiki.org/wiki/User:Rahul21/Gsoc [14:17:45] now it seems like mayybbeee they will do the encoding into .oga on the server? [14:18:10] moogsi: also https://commons.wikimedia.org/wiki/File:Snake_can_be_completed.gif [14:18:20] moogsi: that code for wav to flacc already exists [14:18:24] moogsi: just needs to be turned on [14:19:09] more gifs!! [14:19:12] moogsi: the second gif is amazing [14:19:47] takes me back to the 90s where i knew someone who could finish nokia snake every time [14:20:21] :) [14:20:27] the screen was smaller of course [14:20:38] heh [14:21:23] moogsi: only 3 deletions in ~1000 images that I had to mark :) [14:21:29] actually 4 [14:21:31] hmm [14:21:31] 5 [14:21:35] but 3 were test uploads [14:21:41] well the android users already know Commons [14:21:49] true [14:21:50] so good [14:48:50] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58863 [14:48:50] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58863 [14:49:43] New review: Cmcmahon; "less IRC spam from wmf-selenium-bot" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58870 [14:49:44] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58870 [15:22:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=46086 oh Rillke :( [15:22:28] we need that one fixed and he decides to go off on a rant [15:22:47] * YuviPanda looks [15:22:56] it's very woolly [15:23:25] basically none of our delete tools work properly because of some unspecified API error [15:24:34] moogsi: 'none'? [15:25:21] well they all rely on the 2 he links in the thread somehow i think... [15:25:36] if Rillke gets hit by a bus or something then we're totally screwed [15:26:07] unfortunately he is busy doing actualy work at the moment :/ [15:26:08] moogsi: AjaxQuickDelete? [15:27:38] moogsi: people can always take up and fix bugs, I guess [15:27:42] it's just javascript [15:29:34] i am trying to figure out where the problem is.. it apparently started just before i even had admin so i don't know how things are supposed to work [15:29:46] heh [15:29:56] most of the scripts are integrated in a way that you just turn them on in preferences and voilà [15:30:40] right [15:32:13] but deletion seems very slow and fails with that error like 1 in 4 times if you send a lot of requests at once [15:32:49] i should talk to #mediawiki , but really Rillke should do it and he.. doesn't want to right now :l [15:32:59] moogsi: sigh [15:33:08] moogsi: is that the case always? [15:33:15] moogsi: maybe it's hitting a part of the API that's got some bad code [15:33:21] no i think he is really busy with actual work right now [15:33:29] oh i thought you meant rillke :P [15:34:55] i'm not sure, i'd have to find a whole mass of files to delete at once [15:36:30] moogsi: :P [15:36:41] moogsi: heh, maybe the mobile team could help with that :P [15:37:01] https://commons.wikimedia.org/wiki/User_talk:Rillke/Discuss/2013 bottom of the page there is what happened earlier, it's weird [16:36:01] YuviPanda: how have you been liking trello? [16:37:10] awjr: pretty good! [16:37:23] awjr: Labels are working well + filtering [16:37:38] awjr: though they are limited in number. But that might be a good thing. Unsure [16:37:44] we haven't hit that limit yet [16:37:59] YuviPanda: what's the URL for apps again? [16:38:06] moment [16:38:26] awjr: so, all the boards wmf uses are at https://trello.com/wikimediafoundation [16:38:48] awjr: and apps team at https://trello.com/board/mobile-app-team-sprint-6/5162461b43476994540002ba [16:38:58] thanks YuviPanda [16:39:02] :) [16:39:05] i appreciate how lightweight it is [16:39:10] so are you creating a new board for each sprint? [16:39:21] awjr: so, we don't know yet. [16:39:34] awjr: we can either create a new board, or just re-use this one. [16:40:00] awjr: if I re-use this one, I'll just rename current 'Done' to 'Sprint No. 6' and archive that list alone [16:40:03] thus we have a historical record too [16:40:11] but then we don't have a record of what was left in the backlog [16:40:16] ah coo, yeah i was giong to ask about history [16:40:19] and that can be fixed by using a new board [16:40:27] can you move stuff between boards? [16:40:27] we can 'copy' this board, create a new one, and archive the 'Done' [16:40:39] awjr: you can copy baords to create new ones [16:40:49] ah ok but you can't move individual things between boards? [16:40:49] awjr: and archive older boards [16:40:58] awjr: so that'll work for history [16:41:40] YuviPanda: are you guys keeping a general backlog somewhere? [16:41:50] awjr: there's one on the Wiki page [16:44:37] cool - thanks YuviPanda :) [16:44:44] np awjr [16:45:04] awjr: also reminder that I won't be in standup, being friday :) [16:45:09] Sigh. [16:45:11] yup, thanks YuviPanda [16:45:15] MaxSem|android: internet trouble? [16:45:34] awjr: but I'll still be around. Working on UploadWizard today [16:45:45] so poke me if you need anything [16:45:50] cool thanks [16:46:14] Yeah. And this time it looks scarier [16:46:25] what's the problem MaxSem|android? [16:46:44] MaxSem|android: no power either? [16:46:45] or? [16:48:02] Gateway not pingable [16:48:08] Not the overloaded billing server as it was before [16:49:59] MaxSem|android: :( [16:51:38] MaxSem|android: are you giong to be able to join us for standup? [16:53:35] So here's my report: worked on variable resources, worked with Kai on OSM in labs. Today will try to work on GeoData bugs [16:54:07] New patchset: Jdlrobson; "Dev Change: Allow nearby page to run on a different api" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58647 [16:54:56] New review: Jdlrobson; "Juliusz put this in place - not sure what other alternatives there are. In meantime I can enable it ..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/58627 [16:55:22] New patchset: Jdlrobson; "Rewrite search as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [16:55:26] New patchset: Jdlrobson; "Deprecate M.utils" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58400 [16:57:12] New patchset: Jdlrobson; "Story 430: Promote nearby to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58842 [16:57:13] New patchset: Jdlrobson; "Story 419: Nearby distance enhancements" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58847 [16:57:42] New review: Jdlrobson; "Needs more design input" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/58825 [16:59:27] wool it's standup time [16:59:30] * brion goes to find glasses [16:59:41] * brion adds woop to spell dictionary :P [17:01:37] * YuviPanda wraps brion in wool [17:01:46] mmmm comfy [17:07:26] thanks MaxSem|android [17:08:14] MaxSem|android: were you able to coordinate in-house testing of wgMFVaryResources on testwiki? [17:08:58] MaxSem|android: i ask in part because im about to cover for tomasz in the weekly deployments meeting and i want to report our deployment plan for that change [17:19:23] mhurd: did we finish this one? https://bugzilla.wikimedia.org/show_bug.cgi?id=47083 [17:19:27] * brion checks pull requests [17:19:39] yeah there it is https://github.com/wikimedia/Commons-iOS/pull/40 [17:19:43] * brion tests [17:20:18] brion: yes i believe so [17:23:53] mhurd: a couple quick notes on https://github.com/montehurd/Commons-iOS/commit/a9d47173690fe6cbeafcaf465ce3b56e9b358335 [17:24:20] ugh i have got to remember how to change tab-complete to be case-insensitive in my shell [17:24:31] that really should be default on mac since the FS is case-insensitive :P [17:24:49] brion: commenting now [17:24:56] whee [17:26:07] brion: added comments below your notes [17:26:16] brion: that missing chunk is weeeird! [17:26:27] yeah it's crazy [17:26:41] one of the reasons i always do a 'git diff' before committing [17:26:52] it seems to regen the section ok so i don't know if it's unnecessary data or what [17:26:54] brion: good practice! [17:27:00] but it's nicer to have clean diffs :) [17:27:05] ya [17:30:19] brion: mhurd I have been using git commit -p all the time now [17:30:23] brion: mhurd no missing chunks! [17:30:29] :) [17:30:38] good idea [17:30:56] mhurd: let's disable the 'hide keyboard' button on iPad, it's not needed in portrait mode and in either orientation there's a hide button already on the keyboard [17:30:59] pesky chunks :) [17:31:01] (which i wish iPhone had too :P :)_ [17:31:24] brion: agh! that's a good point! [17:31:37] will do now [17:31:53] tx :D [17:32:20] darn, i left my 3.5" iPod at the office. i'll have to use the simulator [17:33:46] we should see if we can figure out how to make the description cell expand on demand... [17:33:51] or else move it to the bottom :) [17:33:55] no rush on that though [17:35:06] yes i'll make note [17:35:35] mhurd: i'm thinking we should put a solid background behind the 'hide keyboard' button, it looks a little weird if you scroll down over the license chunk [17:35:43] other than that i'm happy, i'll go ahead and merge this so far :D [17:35:59] brion: just about to push that non-ipad commit [17:36:21] [Commons-iOS] brion pushed 6 new commits to master: http://git.io/jMgSGA [17:36:21] Commons-iOS/master 1bbdb16 Monte Hurd: Choose pic button iPad only worked the first time.... [17:36:21] Commons-iOS/master a9d4717 Monte Hurd: Make picture details screen scroll with keyboard... [17:36:21] Commons-iOS/master c811708 Monte Hurd: Image title and description keyboard dismissal... [17:37:23] brion: pushed it [17:37:50] same branch? [17:37:52] brion: ya [17:37:55] * brion looks [17:38:03] will add background [17:39:30] spiff [17:44:48] oh microsoft [17:44:51] " Congratulations! Wikipedia, release 7 is now in the Windows Store. Use this link to your app’s listing in the Windows Store to let others know about your app." [17:44:57] http://apps.microsoft.com/windows/en-US/app/wikipedia/6b80bf54-1a31-4651-acce-59a5b5c2b7c8 <- says release 6 :P [18:09:52] brion: remember when i played with the title box having that slight background color? *that's* why i added that extra space on the left of the title. now that there's no background color it makes little sense to have the padding space haha [18:10:01] ahhh that was it eh [18:10:11] ok easy to take that back out :D [18:10:49] brion: ya i just looked at it on the device and realized how useless it was now :) [18:14:42] * brion updates parallels, whee [18:17:40] grr microsoft still lies. i see r6 in the store still [18:18:11] * awjr slaps microsoft [18:18:12] add to this that EVERY TIME i log into the windows store developer portal it emails me a new confirmation code [18:18:23] >_< [18:18:33] i just want it to work and not take much of my work time :) [18:19:30] obligatory: did you use MSIE? [18:19:42] i *kid* [18:19:55] hehe [18:20:15] even in the win8 store app it's showing the previous revision. i guess i just have to wait… there's no more buttons to push in the dev console [18:20:31] brion: got the "hide keyboard" background color working. playing with colors/transparency now [18:21:07] sweet [18:21:25] brion: also made the focus shift happen if tap lands *anwhere* in cell rather than just on label. even better! [18:21:33] oooooh nicely done [18:24:12] New review: awjrichards; "you may want to rely on $wgCookiePrefix in the cookie name to make it easier to identify this cookie..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58641 [18:31:40] New review: awjrichards; "much better, thanks!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58647 [18:31:52] New patchset: awjrichards; "Rewrite nearby as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58648 [18:32:15] dr0ptp4kt, ping [18:32:22] yurik, pong [18:32:29] hi! [18:32:52] have you tried the new patch by any chance? [18:33:12] not yet. within the next hour, though. [18:33:20] awesome -- if i put the macbook in the right spot on the ChromeBook Pixel's box, the magnet latch in the box makes the macbook think its own lid is closed and it goes to sleep [18:34:23] yurik: no mountains? [18:34:40] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58647 [18:34:56] YuviPanda, nah, i just walked to the city (the entire hotel staff thought i was crazy to walk 5 km to the center of the city) [18:36:35] they might be right too [18:36:36] :D [18:38:21] dr0ptp4kt, how are you feeling? [18:38:27] still in the hospital? [18:38:53] YuviPanda, of course they are right! noone in their right mind works with wiki ;) [18:51:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58648 [18:51:57] yurik, i feel like usual except for the darn leg. that reminds me, i need to send a note to the team. will do that right now.yurik, you be safe now. [18:54:08] hehe [18:54:55] dr0ptp4kt, so do you want to jump in on this? One thing i could defiently use already is a littel scrlipt to upload settings: ) [18:56:06] yurik, you referring to an ongoing integration or to the refactor or something else? [18:56:30] the ongoing migration to the new settings (refactoring i guess) [18:58:51] gotta mail a computer, brb [19:01:49] dr0ptp4kt, but i don't want to stress you while you are recovering :) [19:01:58] yurik, sure thing. you want the auto-generation script, an upload script, or both? if both, which one is needed first? my thought on auto-generation is we can run the auto-generator then manually cross-check. [19:02:09] yurik, no stress here! this is work! [19:02:29] dr0ptp4kt, lol, for most ppl work == stress [19:03:32] dr0ptp4kt, not sure what you mean by autogeneration script - we need to get all the data together into one table for easy analysis [19:03:49] and later - to take that one big table and uplaod it as individual pages [19:04:44] okay, so one utility that grabs the current config from the 3 pages, turns it into a consolidated data structure, then provides the ability to export that to one JSON blob per carrier. correct? [19:04:46] New patchset: awjrichards; "Surface page images on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58652 [19:04:58] yep [19:05:11] oh, why 3? [19:05:17] dr0ptp4kt, its actually two i think [19:05:22] plus the VCL file [19:05:38] plus the i18n php file [19:06:06] it doesn't have to be a nice script - this is a one time change, can use search replace :) [19:06:18] but whichever is most convinient [19:06:45] i'm more worried about the upload - because it might need to be repeated several times until we iron out all kinks [19:09:27] yurik, agreed. [19:11:15] dr0ptp4kt, just keep in mind that this is a one time conversion process, so at a later time the most we will need to do is update all existing setting pages with some value [19:11:38] for example we might decide to add an extra value, or to delete some existing value [19:11:47] adding would actually be more rare [19:12:11] but in short - some minor modification scripted somehow [19:12:48] yurik, got it [19:12:57] :) [19:14:35] LOL [19:31:28] adam, re file - i just realized that it might be good to use CSV instead of tabs because this will allow us to have all IPs for one ID in one cell [19:31:32] just an adea [19:31:41] New review: awjrichards; "Yeah page images! w00t!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58652 [19:31:58] New patchset: awjrichards; "Bug 44959: Translate wiki related fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58735 [19:32:00] this way multi-line values are surrounded by the " [19:32:20] and excel (and probably libreoffice) will understand it [19:32:30] just replied to the email [19:33:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58652 [19:34:25] jdlrobson, you should torture max about that geo-math stuff :) [19:34:45] that's his baby i think [19:36:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58735 [19:37:15] New patchset: awjrichards; "Style nearby distance" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58824 [19:39:20] mhurd: how's the changes coming? [19:41:14] brion: oh the button change is done. just tracked down and fixed an odd bug: the keyboard hide notifications in the login view controller were being received even when the login view wasn't visible. noticed a layout weirdness which tipped me off. just finished the fix [19:42:00] brion: going to verify quickly then push these up to that same branch [19:42:03] spiff [19:43:42] grr [19:43:43] grr [19:44:13] MaxSem, 100% agree [19:44:48] * yurik contemplates adding animal sounds to the smilei dictionary [19:48:55] MaxSem: get your internet woes sorted? [19:49:02] yup [19:49:14] anything i missed? [19:49:29] New patchset: Jdlrobson; "Promote addToBodyAttributes to desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257 [19:49:29] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [19:49:29] New patchset: Jdlrobson; "Promote menu button generation to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [19:49:30] New patchset: Jdlrobson; "Define render function in MinervaTemplate to output page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58991 [19:49:30] New patchset: Jdlrobson; "Kill navigationStart" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58992 [19:49:30] New patchset: Jdlrobson; "Promote all the banners into MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58993 [19:49:30] New patchset: Jdlrobson; "Move header to generic MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [19:49:31] New patchset: Jdlrobson; "banner fixup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58995 [19:49:31] New patchset: Jdlrobson; "Code move: Lift and shift html rendering to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996 [19:49:32] MaxSem, i heard a new tech allows multiplexing internet connection over multiple lines... [19:49:32] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [19:49:48] nothing particularly exciting, MaxSem [19:50:03] MaxSem: were you able to coordinate some in-house testing of wgMFVaryResources on testwiki? [19:50:30] nope [19:51:29] Change abandoned: Jdlrobson; "See https://gerrit.wikimedia.org/r/#/c/58997/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56351 [19:53:13] brion: just sent pull request [19:53:13] [Commons-iOS] montehurd opened pull request #41: Hide keyboard button background color and further fixes. (master...moreSmallScreenTweaks) http://git.io/3xsAkA [19:53:32] [Commons-iOS] brion pushed 5 new commits to master: http://git.io/eDG89w [19:53:32] Commons-iOS/master 5ede431 Monte Hurd: Only show "hide keyboard" on non iPads [19:53:32] Commons-iOS/master d2ba61e Monte Hurd: Focus to title and desc if respective cell tapped... [19:53:32] Commons-iOS/master 2c91775 Monte Hurd: Added background to "hide keyboard" button... [19:53:33] brion: lol that was fast [19:53:41] heh i already merged it manually :D [19:54:03] brion: would have been almost scary fast otherwise haha [19:54:12] it's looking awesome so far dude! [19:54:22] anything else you think we should squeeze in before a beta? [19:54:24] brion: woohoo! [19:54:38] brion: lemme check real quick [19:54:41] k [19:56:15] brion: i think it's cool for now :) [19:56:22] eeeexcellent [19:56:29] i'll bump the version and beta it [19:56:37] and upload to apple and wait. :) [19:56:53] awesome! [19:59:08] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/asJBUw [19:59:08] Commons-iOS/master 75c1dce Brion Vibber: Bump version to 1.0.0 [20:01:25] wtf [20:01:26] "Could not launch “Commons-iOS”" [20:01:30] "failed to get the task for process 5065" [20:02:48] jdlrobson: im not seeing 'last modified' and page images look squished in https://gerrit.wikimedia.org/r/#/c/58824/3 - is that known/intentional? [20:02:49] ah i see the debugger doesn't work when i sign for ad-hoc distribution [20:02:54] * brion slaps ios [20:03:03]