[00:00:29] awjr: did brion leave? [00:00:39] https://gerrit.wikimedia.org/r/#/c/58332/ < i am desperate to see this merged for tomorrow [00:00:55] brion already verified it "Looks fine to me, except a double-escaping problem. :)" [00:01:17] ^ awjr so the js has been reviewed ... [00:02:10] oh, sorry, should've looked at previous comments [00:02:56] i just had to switch on the a/c for the first time this year - it's currently 83F in my house and im sweating like crazy, i think my brains are starting to boil [00:03:00] "fine except for problem" is not a mandate to merge [00:03:20] im taking a closer look at brion's comments now [00:03:46] MaxSem: is search currently being broken for everyone on a windows phone sufficient? :) [00:04:07] i dont think that's his point, jdlrobson :p [00:04:30] I can start cursing every WP owner in Twitter. not like they're not guilty [00:05:04] awjr: it also points out at how woeful we are at prioritizing code review. The original patch was posted on the 9th April so a fix has been sitting here for 6 days without attention till today but that's an orthogonal conversation... [00:05:11] i wish i knew the solution to this [00:05:14] jdlrobson: why was the search output double escaped to begin with? [00:05:21] awjr: it always has been in production [00:05:39] it's just previously we only did autocomplete on terms which were at least 2 characters long [00:05:44] now we do it for 1 character long strings [00:06:18] jdlrobson: re the prioriziation, today was the first i've heard of the issue, and there's nothing in mingle tracking it - so unless im told otherwise, i use the cards in mingle to determine code review priorty [00:06:49] awjr: the bug came up after last weeks deployment [00:06:55] we'd already done prioritization at that point [00:07:07] this is a problem of 2 week iterations :) [00:07:19] can we /should we add bugs mid iteration [00:07:20] ? [00:07:26] priority can change at any moment - it's not frozen in place at the start of an iteration [00:07:55] we can totally add bugs mid iteration, but that's up to Maryana (as is prioritization of said bug against the rest of the work for the iteration) [00:07:56] anyway tangent conversation - is there any reason we can't merge this code? [00:08:29] i can't find ori or brion or juliusz (for obvious reasons) who are my usual go to's in this situation [00:08:39] anything can change at any time, but prioritization is up to Maryana, and as long as she's (or whoever is the product owner) is aware of the potential cost of introducing new work mid-iteration, it's totally fine [00:08:43] and it's currently listed as a 'major' bug https://bugzilla.wikimedia.org/show_bug.cgi?id=40986 [00:09:33] I see no point in dragging bugs other than really complex ones into mingle [00:09:33] and you added the work to the iteration yourself by going ahead and doing it, even though it wasn't added to the story wall :p [00:09:47] for this, MaxSem [00:09:48] awjr: i ALWAYS give bugs priority [00:09:57] bugs are a penalty of bad development you [00:09:57] v [00:09:59] so we can have them prioritized against the other stuff we're doing [00:10:02] you've said this before yourself [00:10:15] yes, i don't disagree, that is not my point [00:10:40] awjr: i think there is obviously a discussion to be had right now - but right now the question is what's stopping us from merging this code? [00:10:45] my point is this was totally invisible to me as was its priority - we've otherwise been tracking bugs on the story wall [00:10:54] it's fully unit tested and everything [00:11:43] jdlrobson: i dont feel confident enough with the JS to merge this - the way the double escaping is being handled doesn't seem right to me, but i dont have enough context to feel confident in this [00:12:30] * Maryana reads up [00:12:33] if brion come's online either today or tomorrow am and is happy with this patch and michelle is ok with it can we merge this? if so i will send a mail [00:12:41] awjr: but i really think using mingle for bugs is broken [00:12:47] we have a tool for that - bugzilla [00:12:51] jdlrobson: of course [00:13:01] if something is marked of high importance i automatically prioritize that over new stories [00:13:04] (in regards to merging this post cut-off) [00:13:25] i review the bug queue every morning [00:13:37] jdlrobson: and that is totally invisible to the rest of the team unless you put it in mingle. also, a 'high priority' bug isn't necessarily higher priority than other work happening in the iteration, Maryana needs to make that call [00:13:46] awjr: it's not if you subscribe to the bug list :) [00:14:08] jdlrobson: how can i tell the relative priority of something in bugzilla against the rest of our work tracked in mingle? [00:14:34] if you just go off of what's in bugzilla, that also doesn't give Maryana a chance to rate the priority [00:14:45] awjr: if it it's a bug it should get priority automatically.. it's a no brainer to me. We should be striving not to make bugs [00:15:31] hmm, but not all bugs are created equal. i don't really care about enhancements or bugs introduced to devices that 2 people use [00:15:42] it's a tough problem [00:15:55] at one point, jcmish and i were going over the bug list each week to see if anything needed to be prioritized [00:16:01] well this shows to me we need to rethink/review how we treat our bugs [00:16:10] we stopped because bugs were coming in sporadically/unpredictably [00:16:10] Maryana: that doesn't work as bugs pop up all the time [00:16:10] jdlrobson: see the second bullet point: http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web/Roles_and_responsibilities#Product_owner [00:16:13] it's a daily thing [00:16:17] yep :) [00:16:21] and we've been using mingle for tracking bugs in our iterations all along… or at least i thought we were [00:16:41] i've been trying to, yes, awjr [00:16:59] i think the point jdlrobson is making is that it's hard to know what to do with bugs that come in mid-iteration [00:17:24] we can decide on some process to upwards prioritize them from now on [00:17:46] some kind of "dire bug" card that jdlrobson can hand to me :) [00:17:48] so traditionally this is something that might come up during a daily scrum, but we do every other day, so that's probably not the best venue [00:18:24] that might still work [00:18:25] I really think bugs in mingle is broken until we have some kind of mingle-bugzilla automated workflow [00:18:57] in an ideal world any bug that is marked as high priority in bugzilla should appear in the story wall of the current iteration imo [00:19:08] what about high priority but low severity? [00:19:09] it's non-ideal, but i wouldn't say it's 'broken', it takes 2s to create a card in mingle to track a bug (its current work status, its priority) [00:19:12] or whatever it's called in bugzilla... [00:19:25] when you have a really critical issue but it only affects two people [00:19:31] jdlrobson: don't forget that pretty much anyone can set priority of bugs in bugzilla [00:19:40] awjr: which is a good thing [00:19:49] not always :) [00:19:59] wikipedians are going to mark everything as high priority [00:20:14] i agree jdlrobson, but again, refer to bullet point #2 :) http://meta.wikimedia.org/wiki/Mobile_team/Mobile_web/Roles_and_responsibilities#Product_owner [00:20:17] they pretty much invented that XKCD "you must support my workflow" meme [00:20:28] jdlrobson, I'd say that the problem here is Juliusz's vacation [00:20:39] awjr: bullet points aside it's broken [00:20:57] what specifically is broken, jdlrobson? [00:21:01] the fact is it's so annoying having to 1) create a card for a bug when it's already on bugzilla 2) move a card to in development when there is an ASSIGNED property in bugzilla 3) move a card to ready for testing when there is a RESOLVED FIXED field in bugzilla. [00:21:20] jdlrobson: that is a pain in the ass, not something that's broken [00:21:54] we can figure out how to make it less of a pain in the ass [00:22:15] but this has been, i thought, our process for dealing with this stuff [00:22:36] so, short of changing the software, how would you make this better jdlrobson? [00:23:05] awjr: agree to give bugs with patches priority in code review. [00:23:19] and trust that your team are wisely spending their time [00:23:29] jdlrobson: but we, as a team, have already agreed that the prioritization buck stops with the product owner [00:24:13] and i think that having to look in two different places to determine priority is not a good solution, particularly when in one of those places /anyone/ can set the priority [00:25:48] awjr: you must understand what i'm hearing here - i am hearing "jon you are wasting your time writing code to fix bugs rather than working on stories Maryana(product) are writing" yet I don't think my fixing bugs is interfering with our iterations [00:26:23] if something is set as high priority I still reserve the right to question that priority and talk to maryana about it if a community member disagrees/thinks we should be focusing on - i choose not to as i believe that is a waste of mine and Maryana's time [00:26:23] jdlrobson: that is not at all what i am saying, and i apologize if it's coming off that way [00:27:04] my point was we're using different systems for determining priority, which is not a good thing, and is precisely why i had no idea the patchset in question was such a big deal until today [00:27:45] to me a bug on a windows phone that stops searching is a no brainer that needs to be fixed asap as this effects a significant number of our user base so i automatically look into fixing it [00:28:01] brion, you able to spare 10 minutes? wanted to get your opinion on deployment approach on ZeroRatedMobileAccess. [00:28:12] i see that we are using different systems and that is indeed bad and needs to be resolved [00:28:21] jdlrobson: and of course it's your prerogative to work on whatever, but unless we're all looking at our work queues with a shared understanding of priority, it's not fair to be upset that that patchset hasn't been reviewed yet! [00:28:46] but the problem i see is that we are as a team not paying attention/caring for the bug queue [00:28:47] jdlrobson: i understand that, but that needs to be conveyed to the rest of the team somehow - that's the critical step that was missing [00:28:58] jdlrobson: then let's fix that! [00:29:05] awjr: agreed but i'm not sure what that is other than review bugs first [00:29:32] i think relying on another tool (such as mingle) just complicates matters [00:30:18] regardless of the tools, can we agree that the product owner should be setting the priorities of bugs for the team relative to the rest of the work we have planned? [00:30:34] awjr: that's a huge task bug tracking should be a shared responsibility [00:30:57] it relies on understanding the bug, understanding its impact on a daily basis [00:31:05] this is why we have a bug wrangler.. [00:31:16] i agree but that is different than having one person be the final ersponsibility for priority, just like with the rest of our work [00:32:04] just like we all have a role in defining the work that we do, we should all have a role in coping with the bugs - but the final priority is set by one person [00:32:30] it seems to me the problem is upstreaming the bug information to Maryana and making sure there's enough context/information for her to make an informed decision [00:32:40] awjr: so every time i/member of community decides to fix a bug they have to OK it via maryana? or would this be more an after thing - when patches come in Maryana has to assess priority? [00:33:01] i dont think it needs to be cut and dry, jdlrobson [00:33:48] ideally the priority would be set /before/ the bug gets fixed (like, shortly after its been reported) [00:34:34] awjr: that's not always workable. This is where my concern about trusting each other comes in and is the thing that most worries us [00:34:40] *worries me [00:34:54] if Maryana is in a meeting do i just forget about it? [00:35:20] in that case, you should at least find a way to communicate the urgency with the rest of the team [00:35:31] why don't we make that a bigger part of standups? [00:35:34] to start [00:35:39] and see how far that gets us [00:35:52] awjr: sometimes it's just easier to fix it [00:36:17] jdlrobson: right, but then how am i supposed to it's an urgent fix that needs review unless its somehow communicated to me? [00:36:28] awjr: there is the word bug in the commit summary :) [00:36:44] it all goes back to the fact we have different ways of reviewing [00:36:56] i review bugs first regardless of whether they are in the story wall or not :) [00:37:11] even for bugs that are 'low' priority? [00:37:16] or enhancements/ [00:37:41] Maryana: i think that's a good idea [00:37:58] awjr: no as it should be clear from the bug report and by trusting that developers are working on the right and most important things [00:38:43] jdlrobson: i get that, but as humans, we all have different perspectives on what is 'important' - that is why we give the power of prioritization to one person; to unequivocally settle that question. [00:39:49] awjr: then what's stopping you from looking at a patch and before spending time on code reviewing asking the originator/maryana whether it is important (unless it's obvious) [00:40:24] imagine MobileFrontend had a thriving developer community with bug fixes coming in left right and center [00:41:29] jdlrobson: well, like i said before, i've been using priorities set in Mingle as my guide for what to code review. when i set aside time for code review, i do it in priority order from mingle. if i exhaust that and still have time, i move on to other patchsets. but usually i dont have more time and move on to other work [00:43:31] the nice thing about keeping priorities in one place is i don't have to stop and ask what the priority of something is; and i can know at any time of day or night, anywhere in the world, whenever i feel like working on something, what the priority is [00:48:52] awjr, you got 10 minutes? i think brion is occupied, and i believe you can answer my questions as well. [00:49:00] sure dr0ptp4kt, what's up? [00:49:19] looking for advice on deployment approach with some zero stuff. [00:49:37] able to get on skype? [00:50:20] dr0ptp4kt: can you give me a few minutes? [00:50:27] awjr, yep [00:50:33] awjr, lemme know once ready [00:51:51] awjr: it might work for you but it's not working for me…the only time i ever go to mingle is when i'm picking something to work on or moving it over to code review :) i stay away from it as much as i can [00:55:05] jdlrobson: honestly, that's all i use it for too… and since we define our work priorities there, that's where i look to know what to do next [00:55:54] it's nice to have a common tool where we can at-a-glance know what the priority is, what's actively being worked on (so we don't step on eachother's toes), and know what we need to be doing next [00:56:10] especially when we don't all work during the same hours in the same space [05:33:32] dr0ptp4kt, here? [07:06:02] MaxSem, ping [07:06:14] hey yurik [07:06:41] MaxSem, hi, i juts replied re deploymetn [07:06:59] Zero ext master branch cannot be deployed yet [07:07:40] can you pick up the revision of the decoupling, not later [07:08:05] since the related MF changes will be deployed today - will Zero continue functioning? [07:08:25] (if we don't deploy it) [07:08:50] note that 1.22wmf2 already has a latish Zero [07:10:09] MaxSem, https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fextensions%2FZeroRatedMobileAccess.git;a=summary [07:10:27] jrobson's checkin is fine [07:10:36] everything afterwards should not be deployed just yet [07:11:02] aha [07:11:13] (simply because settings - meta Zero:xxx pages have not been created yet) [07:29:35] grrr [07:29:59] master is supposed to be deploymnet-ready at all times [07:32:17] Всегда готов! [08:09:29] LOL ori-l, where did you dig that one up! [08:09:48] MaxSem, master is deployment ready, the settings are not :) [08:09:50] bug dr0ptp4kt [08:09:57] its on his plate now :) [10:11:57] MaxSem, so when do you want to deploy? [10:12:09] I don't mind next monday [10:17:17] MaxSem, i won't be around begining of the next week - i will have a few days off and then flying back [10:17:38] not like you really need me i guess [10:17:48] because it won't be any of my stuff just yet [14:07:58] MaxSem: can you send me the link for the UA info again? [14:08:21] http://staging.wmflabs.org/ua.php [14:10:24] thanks again [14:38:16] New review: Brion VIBBER; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/58332 [14:59:11] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/9d4yRA [14:59:11] Commons-iOS/master 41d0851 Brion Vibber: Language mapping for Portuguese/Brazilian Portuguese [15:02:30] [Commons-iOS] brion pushed 4 new commits to master: http://git.io/PwR5dQ [15:02:30] Commons-iOS/master 9b037c4 Monte Hurd: About page.... [15:02:30] Commons-iOS/master d596c4b Monte Hurd: Changed about page commons link. Simplified version replace. [15:02:30] Commons-iOS/master e6190a0 Monte Hurd: Improved about page... [16:48:37] oh sweet, Xcode updates in the app store are actually small [16:48:42] instead of a full 2gb download [16:57:02] dr0ptp4kt: do you have access to fenari yet? [16:57:12] no, just tried ssh'ing, in fact. [16:57:16] ok [16:57:19] should i just ask tomasz for that? [16:57:33] im actually not sure who the right person is for that these days - i can look into it [16:57:58] okay, thank you. i was going to look on the actual box to see what version of code is there. [16:58:09] dr0ptp4kt: i just saw your email wondering what the current status of production is for zero [16:58:21] you can figure that out on fenari [16:58:26] or, you can just look in the production branches [16:58:29] awjr: :) [16:59:41] so dr0ptp4kt the first thing you want to do is figure out what branches are currently being used in production [16:59:52] you can figure that out by looking at http://noc.wikimedia.org/conf/highlight.php?file=wikiversions.dat [17:00:01] (also on fenari in /home/wikipedia/common/wikiversions.dat) [17:00:44] the values on the left side of that text file are the specific projects, the values on the right are the branch that they're currently using [17:00:55] i.e., enwiki php-1.22wmf1 * [17:01:20] maxsem@fenari:/h/w/c/php-1.22wmf2/extensions/ZeroRatedMobileAccess$ git log -1 [17:01:20] commit 888c4225e65d768b0200cb9d12ee9cf311597f80 [17:01:20] Author: Yuri Astrakhan [17:01:36] MaxSem, ? [17:02:01] maxsem@fenari:/h/w/c/php-1.22wmf1/extensions/ZeroRatedMobileAccess$ git log -1 [17:02:01] commit 0a239dda9fd41b809d7e6e3cbda859a17c644034 [17:02:01] Author: Translation updater bot [17:02:02] yeah dr0ptp4kt, so enwiki = english wikipedia, branch = 1.22wmf1 (in the actual branch name, there is no 'php-' prefix) [17:02:19] yurik, discussing what's deployed ^^^ [17:03:28] dr0ptp4kt: to get the specific branches checked out on your local machine, you can follow the specific steps here: https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Case_1c:_extension_update or if you want to be a little more expedient, just checkout the remote branch locally [17:04:06] if you do a git branch -r from a clone of core, you'll see a bunch of remote branches like: [17:04:07] origin/wmf/1.21wmf5 [17:04:07] origin/wmf/1.21wmf6 [17:04:07] origin/wmf/1.21wmf7 [17:04:07] origin/wmf/1.21wmf8 [17:04:08] origin/wmf/1.21wmf9 [17:04:09] origin/wmf/1.22wmf1 [17:04:25] origin/wmf/* are what are used for production [17:13:29] dr0ptp4kt: pm [17:41:48] dr0ptp4kt & yurik, would it be safe to assume that wmf2 should be reverted to whatever is in wmf1? [17:42:15] New review: Jdlrobson; "Desktop uses jquery suggestions plugin. We could use this but I've always felt something like this i..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [17:43:12] New review: Jdlrobson; "ps. I've noticed that highlighting is completely broken on deployed wikipedia anyway since the stron..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [17:57:45] New patchset: Jdlrobson; "Rewrite search as an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [17:58:39] MaxSem: what's the latest auto detection mechanism out of the box for MF ? I have a user with a problem "Hi Jon, I upgraded to Mediawiki 1.20 on me dev machine, and things [17:58:39] seem to work fine. [17:58:41] However using MF for MW 1.20 has no auto-detect, so it's not very [17:58:41] useful to me :)" [17:59:19] Do we have a wiki page explaining the above? [17:59:33] if they want autodetection, they should use master MW+MF [18:00:15] MaxSem: also see http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20130416091705&lqt_mustshow=26314#Howto_switch_to_mobile_Version_26314 [18:00:18] there are a few different ways that can do it, but the easy ones have been introduced relatively recently, like within the last 3 or 4 mos [18:00:34] Can I suggest a page? I'm getting *lots* of queries around this? [18:00:50] there seems to be lots of interest in the current situaton [18:01:09] i dont think we have a page currently documenting any of the possible ways, with the excepiton of maybe how we do it with varnish [18:02:11] awjr: ok if I knock one up can we add some brief notes? [18:02:21] yeah totes [18:02:23] be bold! [18:02:49] jdlrobson: maybe a subpage of mediawiki.org/wiki/Extension:MobileFrontend [18:02:58] why subpage? [18:03:04] or section :) [18:03:06] people never notice them [18:03:07] whatever [18:03:21] also should we set MobileFrontend Release status to something other than stable - as that doesn't really seem true right now :) [18:03:22] just personal preference, i dont like long pages [18:03:37] if it's not in TOC, you can assume that it's only seqarchable, but not discoverable [18:03:57] jdlrobson, MF's status is rolling updates [18:04:09] each of them is kinda stable [18:04:20] MaxSem: i usually create a section on a main page for a subpage and either make the section header a link, or put a link to the subpage as the main content in the section (for something like this) [18:04:23] not according to http://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend MaxSem :) [18:04:26] it's table relative to Mediawiki core [18:04:26] as in stable enough to run on WMF [18:06:25] ie stable enough for us cowboys [18:06:39] and cowgals [18:07:51] not to mention cowaliens [18:08:29] awjr: MaxSem what's the link to varnish configuration ? [18:08:50] operations/puppet/templates/varnish [18:09:43] mhurd: apple rejected it *again* [18:09:50] MaxSem: is there a mediawiki page for that? [18:10:32] YuviPanda|Meds: :( [18:10:43] WHAT THE FUCK [18:10:44] "We found that your app includes the ability to collect charitable donations within the app, which is not in compliance with the App Store Review Guidelines " [18:10:50] YuviPanda|Meds: ? [18:10:58] mhurd: that's their reason for rejection [18:11:05] YuviPanda|Meds: that makes no sense! [18:11:10] indeed [18:11:12] the commons app? [18:11:13] YuviPanda|Meds: gah! [18:11:15] did we have a 'donate' link somewhere? [18:11:16] Maryana: yeah [18:11:19] wtf [18:11:21] that's crazy [18:11:52] did they see the words "donate image" and think that was a chariatable contribution?? [18:11:55] Maryana: no [18:11:58] Maryana: they sent us a screenshot [18:12:05] Maryana: somehow they've managed to navigate to donate.wikimedia.org [18:12:11] from the commons app? [18:12:13] yes [18:12:20] *in* the commons app itself. [18:12:39] I *think* they went to the license screen and went from there [18:12:47] mhurd: do you have access to iTunes connect? [18:12:48] that is insane [18:13:14] YuviPanda|Meds: yes [18:13:19] YuviPanda|Meds: i'll login [18:13:24] oh, and I think they might also want us to flag the app as 18+ [18:13:29] also [18:13:31] "- Developer must act on objectionable content reports within 24 hours by removing the content and ejecting the user who provided the offending content " [18:13:33] hahaha, sure [18:13:53] wat [18:13:56] @_@ [18:14:09] it's only the user's own content that will be shown, right? [18:14:09] let me paste the entire thing somewhere [18:14:13] ragesoss: yup [18:14:23] gotta protect you from yourself [18:14:26] i dont even [18:14:34] @_@ [18:14:39] http://dpaste.de/4cdj4/ [18:14:49] awjr: MaxSem can you help me flesh out http://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_Browser_Auto-Detection [18:14:56] 18.2 section is so fun [18:14:56] yeah jdlrobson, but later [18:15:31] ragesoss: Maryana http://dpaste.de/4cdj4/ [18:15:40] just read it. [18:15:55] it bottles the mind. [18:16:04] jdlrobson, have you actually tried http://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_Browser_Auto-Detection#Apache_Redirects ? [18:16:08] * YuviPanda|Meds bottles ragesoss [18:16:13] yuvipanda|meds: well, on the plus side, the fundraising team will be happy to hear that we can collect donations via mobile, despite no one having worked on this ever… [18:16:25] :D [18:16:25] Maryana: hehe :P [18:16:58] Maryana: so that can be construed as a bug. There might be a donate link buried somewhere in the CC license text, and apparently apple wants us to not allow users to click that [18:17:06] jdlrobson: varnish config can be found here: https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=tree;f=templates/varnish;h=ffd0b24bc45a8fa092fe4b3719d5002db79e8aca;hb=HEAD particularly in device-detection.inc.vcl.erb, mobile-frontend.inc.vcl.erb [18:17:35] awjr: can you update the mediawiki page instead? [18:17:41] it sounds like they're ok with sending users to an external link to donate, yuvipanda|meds [18:17:55] Maryana: yup. so that's a fixable 'bug' [18:18:02] YuviPanda|Meds: i can't see the screenshot - could you post it [18:18:05] we just need to pop users out to safari instead of in the app for anything [18:18:17] mhurd: can you go to https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/da/rejectionReasons?adamId=630901780 [18:18:30] mhurd: it's easy to miss, called 'Screneshot_0' [18:18:32] except spelt right [18:18:39] if you still can't find it i'll paste it [18:19:05] still no image :( [18:19:10] okay, paste comin up [18:19:25] mhurd: http://a93.phobos.apple.com/us/r30/Purple/v4/f0/f6/46/f0f646ef-0bbb-e6c8-d8ed-f04d0f2e4ccd/temp..bdjlgmdm.png [18:19:48] YuviPanda|Meds: thanks! [18:19:52] :) [18:20:08] YuviPanda|Meds: btw hope you're feeling better!! [18:20:28] mhurd: thanks :) The meds have kicked in and I no longer feel like my lower jaw is possessed by demons [18:20:51] YuviPanda|Meds: oh man! [18:22:14] soooo... no other users' pics for the iCrap app?:) [18:22:26] not yet :P [18:24:10] YuviPanda|Meds: they must have reached the donation page via the licensing link at the bottom of the details page, and by following links on that to the full site and from there to a donate button… i guess? [18:24:18] yup [18:24:21] that is very convoluted [18:24:25] but the only way I could think of [18:24:27] YuviPanda|Meds: could we link to a plain-text license page w / no links [18:24:55] we could do that but that'll be painful [18:24:59] action=raw is mostly eek [18:25:12] mhurd: can we make all links going out from that webview pop up in safari? [18:25:21] what links are you using for license? you should just link to the human-readable creative commons pages [18:25:36] lemme check [18:26:03] why not link to the license in Safari in the first place? [18:26:10] that'd work too [18:26:12] plus less code! [18:26:25] Maryana: I think that's what is being linked to currently. [18:26:54] so how did they get from a creative commons domain back to a wikimedia domain? [18:27:33] link: http://creativecommons.org/licenses/by-sa/3.0/ [18:27:36] Maryana: our nearby feature makes me feel bad about myself [18:27:36] :D [18:27:46] even when I travel I'm not near anyone [18:27:52] maybe we could change it to this one: http://creativecommons.org/licenses/by-sa/3.0/legalcode [18:28:11] which seems to have fewer links [18:28:26] mhurd, yep, that's what mobile web is using :) [18:28:40] mhurd: but can't we just make all link navigations pop to Safari? I'm sure Apple will find a way to 'break out' of there :) [18:28:52] mhurd: I mean, they went to donate.wikimedia.org from the original page... [18:29:27] Maryana: however, I'm not sure what we're going to do about the second part [18:29:28] re: flagging [18:29:35] we might get rejected again for that [18:29:51] and IIRC Commons doesn't really have a 'flag' thing [18:30:05] and even if it did, apple's definition of 'Objectionable' is not really going to be in line with Commons' [18:30:11] ragesoss: ^ [18:30:20] yeah, that i have no idea about. how did we deal with this on the wikipedia app for iOS? [18:30:29] they never asked. [18:30:50] it seems like they misunderstand what the app displays, in terms of user-generated content. [18:31:01] I think it didn't occur to them that Wikipedia is 'user generated'. [18:31:16] ragesoss: indeed. If it didn't turn up for Wiki where you see everyone else's, but this where you (currently) see only yours... [18:31:19] YuviPanda|Meds: generally i prefer to minimize jumping in and out of the app (to safari and back) if it can be avoided [18:31:49] hmm, mhurd but in this case we just want that webview to show people the license, right? having them wander to donate from that seems a bit awkward... [18:31:56] yeah. they probably actually *couldn't* justify passing the Wikipedia app, if they are taking their policy seriously. [18:32:03] mmm, does 18.2 cover displaying people's own pics to themselves? [18:32:05] but the Commons app, they just don't understand it. [18:32:09] yup [18:32:38] MaxSem: I don't see how it could, or every camera app and gallery would run afoul of it. [18:32:52] hehe, let's ban them [18:32:57] YuviPanda|Meds: i'll double-check links from http://creativecommons.org/licenses/by-sa/3.0/legalcode to confirm that it would even be an option [18:33:23] haha max [18:33:26] :) [18:33:27] so if our app doesn't yet have other users' pics, WTF are they objecting to? [18:33:27] mhurd: definitely is [18:33:38] mhurd: hit first link on top, scroll down a bit, bam! [18:33:40] yuvipanda|meds - is there an actual human we can talk to at apple? [18:33:43] :) [18:33:54] to explain this? or is it all faceless corporate drones? [18:34:10] apple is staffed by mandroids and fembots [18:34:12] so Maryana [18:34:16] Maryana, I'm afraid they're all either biomechanoids or jerks. Jobs style! [18:34:17] Use the field below to ask questions or provide additional information to the App Review team. [18:34:17] ' [18:34:20] can't you just have the second link deep open in safari instead of in-app browser? [18:34:20] and a textbox under it [18:34:22] YuviPanda|Meds: oh i meant "be an option to not-jump out if there's no way to get to donate page from the plain(er) text link" [18:34:24] Maryana: so we could respond on that [18:34:44] yes we definitely can [18:34:46] mhurd: yeah, I'm saying it is possible with just 2 steps :) [18:35:08] in fact I can't figure out *how* they got from our first link to the donate page [18:35:13] since it links to *creative* commons [18:35:17] and the screenshot is *our* donate page [18:36:39] YuviPanda|Meds: ah - i just did the same 2 steps - gah! [18:37:09] Maryana: the iTunes connect page has a reply form. Not sure how much of a human it goes to, though [18:37:14] it might be just automated responses [18:37:49] YuviPanda|Meds: that's actually possible - it goes through an automated system before anyone actually looks at it [18:37:53] yup [18:38:10] yuvipanda|meds, sounds like you should bring tfinc into this. he probably has ways of making apple do his bidding ;) [18:38:17] yup [18:38:22] is he in the office? [18:38:59] hrm, don't see him [18:39:18] mhurd: actually, come to think of it, are we sure it's the creative commons link? [18:39:26] mhurd: I don't see how we can get from CC to Wikimedia's Donate page [18:39:35] YuviPanda|Meds: lemme check [18:39:48] jdlrobson: i forgot to tell you earlier - i spent some time last night exploring the mingle api. i started slapping together a quick and dirty script to periodically poll an rss feed from bugzilla and automatically add bug cards to mingle. i've got a basic proof of concept but will hopefully get it ready to show off sometime this week [18:40:07] awjr: that's great! [18:40:10] ohai brion [18:40:12] that would be awesome [18:40:30] yo [18:40:38] :) [18:40:41] also, jdlrobson - I've a mostly working GitHub -> Gerrit thingy. Should be fully automated+working before end of week on labs. [18:40:52] jdlrobson: I'm asking maintainers of extensions to see if they want it enabled on theirs :) [18:40:55] should I put up MF? [18:41:11] YuviPanda|Meds: that would also be awesome! I'd be interested in seeing if people contribute more [18:41:16] jdlrobson: proposed workflow at https://www.mediawiki.org/wiki/User:Yuvipanda/G2G [18:41:23] * jdlrobson reads [18:41:32] New review: Brion VIBBER; "Handles my crazy ampersand cases. :) Let's +2 woo!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58332 [18:41:33] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58332 [18:41:38] jdlrobson: the version at end of week will automatically open a patchset for every PR, and update the patchset whenever people add a commit to the PR [18:41:45] jdlrobson: eventually I'll add two way comments syncing too [18:42:20] jdlrobson: code is at https://github.com/yuvipanda/SuchABot :) [18:42:21] YuviPanda|Meds: "If there are multiple commits in the GH PR, they are all squashed into one" < not sure about that!!! [18:42:29] jdlrobson: hmm? [18:42:34] i dislike squashing [18:42:40] jdlrobson: you dislike Gerrit :P [18:42:45] jdlrobson: you can't have multiple commits per patchset [18:42:46] so [18:42:53] brion, does ^^ need to be deployed today? [18:42:53] smaller commits are better for everyone - reviewers, code maintainers, code newbies [18:42:54] they're preserved on the GitHub side [18:43:08] jdlrobson: the idea is one PR is equivalent to one Patchset [18:43:12] MaxSem: that's up to how bad jdlrobson wants it :) [18:43:14] not one commit per patchset [18:43:47] MaxSem: I think we should deploy it but that's up to Maryana ultimately [18:44:17] jdlrobson: so in gerrit how we 'amend' a patchset you'll just push out a new commit for a GitHub PR [18:44:23] New patchset: Jdlrobson; "Bug 44959: Allow overlay heading title to span 2 lines" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58725 [18:44:54] YuviPanda|Meds: i'd have to see it in practice. [18:45:03] you shall in a few days, jdlrobson :) [18:45:14] jdlrobson: i'll make sure to poke you when it goes lie [18:45:21] jdlrobson: that's how I've always used GitHub PRs though. [18:46:51] jdlrobson: we don't have a workflow figured out that works for everyone, hence testing with minimal number of repos [18:46:59] jdlrobson: chrismcmahon has volunteered qa/browsertests too [18:47:08] and I'm going to ask ori-l-away if we can have something from E3 :) [18:47:08] YuviPanda|Meds: sure but we should have it configurable :) [18:47:19] I don't see at all how we can support one patchset per commit [18:47:26] that'll just land us up in Gerrit Dependency Hell [18:47:38] anyway, let's just see how it works in practice jdlrobson :) [18:47:48] one of the reasons I want to actually get it up and running before talking about it too much [18:49:30] YuviPanda|Meds: found it - from the license page the link is "fair use" then "learn more" - on the page that loads there's donate info [18:49:42] yuvipanda|meds, i hear a tfinc in office [18:49:52] mhurd: oh man that's so convoluted [18:50:17] indeed [18:50:19] YuviPanda|Meds: ya, their submit-bot *had* to have flagged it [18:50:21] mhurd: but that still leads us to http://wiki.creativecommons.org/Frequently_Asked_Questions#Do_Creative_Commons_licenses_affect_fair_use.2C_fair_dealing_or_other_exceptions_to_copyright.3F [18:50:35] mhurd: but the page in the screenshot is donate.wikimedia.org [18:50:47] not creativecommons.net/donate [18:50:54] i don't see links out of donate.wikimedia.org from that page [18:52:20] mhurd: oh wait, you mean from that link on to https://en.wikipedia.org/wiki/Fair_use and then the tiny 'donate to wikipedia' link on the sidebar? [18:52:24] that's what, 4 steps? [18:54:17] YuviPanda|Meds: not sure [18:54:53] mhurd: there is a 'view in browser' feature that brion added. Maybe it opened it in the app itself than shelling to browser? [18:54:58] because then it'll just be two hops... [18:55:54] YuviPanda|Meds: could be... [18:57:17] awjr_sandwich, https://gerrit.wikimedia.org/r/59449 :) [18:58:51] ahhh Apple. how dearly do you like to screw with everyone [18:59:00] YuviPanda|Meds: mhurd : i'm catching up on the thread now [18:59:16] tfinc: okay. It's just essentially been discussed on IRC [18:59:21] I can recap if you want :) [18:59:34] do it on mobile-tech so that we can have an archive [19:01:23] tfinc: ok [19:09:48] so in true apple fashion i can read why our app got rejected but i'm unauthorized from reading App Store Review Guidelines [19:09:58] apple for the fail [19:10:54] - Developer must act on objectionable content reports within 24 hours by removing the content and ejecting the user who provided the offending content [19:10:54] - Developer needs a method for ejecting users who violate the terms of the EULA [19:10:56] YuviPanda|Meds: mhurd : how are you guys feeling about the last two clauses ? [19:11:07] yeah, not so good [19:11:10] writing that up in the email now [19:14:38] tfinc: mhurd sent [19:19:12] YuviPanda|Meds: good write up [19:19:18] ty [19:19:21] i'll respond on list [19:19:32] YuviPanda|Meds: how you feeling? all doped up ? [19:19:41] tfinc: okay. I don't think we've figured out what convoluted set of actions they took to get to donate. [19:19:51] tfinc: just oral medicine, so nothing funny yet. [19:20:00] tfinc: but yes, a little like how I feel at 6AM, not at 1 AM [19:20:08] YuviPanda|Meds: their better at the wikipedia game then we are [19:20:22] tfinc: we sent them to creative commons :P [19:23:10] tfinc: can't pull up the rejection text [19:24:08] mhurd: tfinc attaching rejection text to email [19:24:23] mhurd YuviPanda|Meds: it only takes three taps to get to the donate page [19:24:24] YuviPanda|Meds: thanks! the http://dpaste.de/4cdj4/ link expired [19:24:25] beat that :D [19:24:37] haha [19:25:09] tfinc: how so? [19:25:14] link, what's the chain? [19:25:21] its in my email but i'll post here [19:25:30] #1 Tap "I" [19:25:30] #2 Tap "Privacy Policy" [19:25:30] #3 Tap Donate in the sidebar [19:25:50] i challenge you to get there sooner :D [19:26:00] heh :P [19:26:12] ah, we were looking for it from the creative commons link [19:26:26] ooooh! [19:26:33] YuviPanda|Meds: too much work. i do it the easy way [19:26:40] :P [19:26:45] anyway, that's fixable. [19:26:50] we can just safari out them all [19:27:02] yup [19:27:09] easy peasie [19:28:05] tfinc: but the second one [19:28:06] idk [19:28:28] hmm ? [19:29:36] tfinc: the moderator / objectionable content thing [19:29:39] i'm responding to that next [19:29:42] that one is harder :D [19:29:42] ah, okay [19:29:43] just saw it [19:30:00] New patchset: Jdlrobson; "Bug 47290: Fix search in non-js mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59459 [19:30:47] YuviPanda|Meds: so the big future feature that would cause us to infringe would be discovery [19:30:50] and anything that touched it [19:31:29] tfinc: Campaigns too. [19:32:21] tfinc: Campaigns shows you pics other people participating in the campaign have taken [19:32:35] tfinc: it's one of the prime features [19:32:41] YuviPanda|Meds: THINK OF THE CHILDREN!?! [19:32:51] haha [19:33:00] * tfinc loads up instagram to see what they do [19:33:01] Hey, metric fuck-ton of events with schema of '-1' coming in from MFE; expect some gaps in EL data. I'm going to be restarting things, etc. [19:33:14] tfinc: good idea... [19:33:26] I still don't know if it's MFE or EL but I'll keep you posted. [19:33:32] a good idea would be knowing what my instragram password is [19:33:35] tfinc: hmm, maybe they have some paid moderators? [19:35:15] so .. foursquare has a bottom left Report Photo button that pops up a select list with spam/nudity/blah/blah [19:36:32] twitter? facebook? [19:37:03] i just marked one of sarahs photos as unrelated to see how it works :D [19:38:47] :P [19:38:57] now lets flag one of jdlrobson photos on instagram as inappropriate and see what happens [19:39:13] Well, first he should take an inappropriate picture and then we should flag it [19:39:18] to test it properly, you see [19:39:30] and jdlrobson can always have the excuse of 'my boss told me so!' :P [19:41:01] i especially like instagrams report -> i don't like this photo -> unfollow the people you don't like [19:47:29] tfinc: http://commons.wikimedia.org/wiki/Commons:Deletion_policy#Speedy_deletion [19:50:11] Maryana: tfinc though Apple's definition of 'objectionable' is *very* loose. They once rejected an app that counted 'number of days till Bush leaves office' [19:50:13] http://www.juggleware.com/blog/2008/09/steve-jobs-writes-back/ [19:51:05] and I'm still unable to find clear guidelines on what they consider 'objectionable' [19:54:19] ori-l: when did this start? [19:56:16] mwhaha: Tap on “Build Number” repeatedly (7 times). On your third tap you should see message indicating that you only have 4 more taps to go to ‘become a developer’. [19:56:18] that is too funny [19:56:22] and retarded [19:56:40] tfinc: late to the party, I see :P [19:57:03] [Commons-iOS] montehurd opened pull request #43: Simplified about page scrolling code (master...aboutPage) http://git.io/2ckDhw [19:57:10] YuviPanda|Meds: yup. all my other phones already had it on since they were 2.3 -> 4.x [19:57:20] heh, yeah. [19:57:42] this 2.3 bug is irking me [19:57:43] grr [19:57:46] dr0ptp4kt: have you already updated the production branches to point to what you want to have deployed today? [19:58:21] awjr, hi, so what's the status? [19:58:31] of what yurik? [19:58:52] MaxSem and i are on a Google Hangout [19:59:07] awesome :) [19:59:09] are you doing deployment today? [19:59:25] i am in bed, but i guess i should join you guys :) [19:59:32] no yurik, MaxSem is and it sounds like he's already working with dr0ptp4kt [19:59:57] yurik, not sure if you have a good connection, but check email for the google hangout invitation. [20:00:37] dr0ptp4kt, connection is somewhat ok, but not sure if i have enough credit left [20:00:49] but dfntly not good enough for video [20:04:52] Maryana: whats your capacity to prod vibha about the designs for the tutorial while i unravel this apple issue ? [20:05:04] jcmish, Maryana, jdlrobson: deployment changes are live on testwiki :) [20:05:08] i can do prod :) [20:05:45] awjr, dr0ptp4kt, jcmish, jdlrobson, Maryana - we're live on testwiki, please test:) [20:07:58] slow testwiki is slow [20:08:33] nearby's not loading for me :( [20:09:00] is geodata properly set up on testwiki for nearby? [20:09:05] Maryana: MaxSem geodata is not installed on testwiki [20:09:14] O RLY? [20:09:18] heh [20:09:21] jdlrobson: were there any config changes that need to gout (like for any of the logging or …. )? [20:09:30] awjr: yes [20:09:39] MaxSem: ^ [20:09:39] awjr: https://gerrit.wikimedia.org/r/#/c/58551/ [20:09:57] i'm not aware of any others [20:10:01] or rather, MaxSem ^ [20:10:03] cool thanks jdlrobson [20:10:07] was there core changes? i forget [20:10:21] not that im aware of [20:10:32] but that doesn't mean no :p [20:10:57] https://test.m.wikipedia.org/w/api.php?format=json&action=query&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.786823999999996%7C-122.39935770000001&ggsradius=10000&ggsnamespace=0&ggslimit=50 < suggests geodata not there? [20:11:08] bleh, connection is bad [20:11:25] and it pouring outside :( [20:12:15] where are the git logs jcmish awjr ? [20:12:20] * jdlrobson can't find the link again [20:12:27] https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-04-16 [20:12:30] jdlrobson: ^ [20:12:34] jdlrobson, are we able to check if it works now on testwiki? [20:12:39] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments [20:12:44] oh [20:12:44] haha [20:12:48] sorry awjr [20:12:51] you beat me [20:12:58] quickest draw in the west! [20:12:59] awjr: can we get a link to https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments added to the calendar invite? [20:13:27] probably jdlrobson although we might need to ask greg to do it - i'll take a look in a bit [20:13:27] MaxSem: with a config change you can point it at wikipedia but that's not a true test of production :) [20:13:27] yup how dare I try to best you [20:13:29] :p [20:15:02] i forget - are photo uploads still not supposed to work correctly on testwiki? [20:15:39] i can confirm central notice is now running correctly although without wgVaryResources we are not communicating our device [20:15:53] wgVaryResources *is* enabled on testwiki jdlrobson [20:15:58] awjr: probably not (yey test wiki! :P) [20:16:00] it is? [20:16:01] huh.. [20:16:05] yah [20:16:06] * jdlrobson looks closer [20:16:21] notice 'X-Device' is missing from the Vary header on article requests [20:16:45] oooh.. not good [20:17:11] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.styles%7Cmobile.styles.page%7Cmobile.xdevice.detect.styles%7Cmobile.zero.styles&only=styles&skin=mobile&target=mobile&* < does not vary [20:17:42] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.eventLogging%2CnavigationTiming%7Cjquery.checkboxShiftClick%2Chidpi%2Cjson%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%7Cmediawiki.cldr%2Chidpi%2CjqueryMsg%2Clanguage%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmobile.alpha%2Cbeta%2Cstable%2Cstartup%7Cmobile.alpha.plumbing%7Cmobile.beta.plumbing%7Cmobile.stable.dependencies%2C [20:17:43] es%7Cmobile.uploads.schema%7Cmobile.watchlist.schema%7Cmobile.xdevice.detect.scripts%7Cmobile.zero.scripts%7Cschema.NavigationTiming&skin=vector&version=20130416T200400Z&* [20:17:44] < does not vary [20:18:23] i'm guessing we don't want to vary the entire url? so we should have separate script and style tags for those devices [20:19:20] so https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.styles%7Cmobile.styles.page%7Cmobile.xdevice.detect.styles%7Cmobile.zero.styles&only=styles&skin=mobile&target=mobile&* has appropriate headers for me, jdlrobson [20:19:29] Vary:Accept-Encoding,X-Device [20:19:35] X-Device:webkit [20:19:36] mm i'm not seeing that for some reason [20:19:49] you may need to hard refresh [20:19:50] also do we really want to vary the entire file? [20:20:18] I thought we were adding separate script/link tags just for the device [20:21:10] awjr: just seeing Vary:Accept-Encoding for some reason on chrome with overridden user agent [20:21:26] what staus code are you getting, jdlrobson? [20:21:34] 200 OK [20:21:56] hmm [20:22:09] im not sure jdlrobson, MaxSem might have more insight than me [20:22:13] im not really sure how this is configured on testwiki atm [20:22:20] ahh i was logged in [20:22:28] so it only varies when ologged in? is that correct [20:22:33] *when i'm not logged in [20:22:34] no [20:22:46] ... [20:22:49] it should work when you're logged in too [20:22:50] well it is for me for some reason [20:22:53] i think... [20:23:00] mostly because im logged in :) [20:23:09] jdlrobson, only URLs with mobile.xdevice.detect are supposed to vary [20:23:36] MaxSem: correct. and i'm saying they only vary when I'm not logged in.. :) [20:23:54] it varies for me when I'm logged in [20:24:25] sam [20:24:25] e [20:24:26] brion: hey! hope you're feeling better! [20:24:34] getting there [20:24:37] :( [20:24:44] annoyed at apple now :P [20:24:44] ok logged back in again and now they are varying again [20:24:49] me too [20:24:54] so it seems it only kicks in for existing users when you log out? [20:25:00] hey brion [20:25:34] hey YuviPanda|Meds how's the tooth? [20:25:45] there's another pull req from me which fixes all of the about page buttons to open their links in external browser to satisfy apple's latest silliness [20:25:54] brion: ^ [20:26:04] brion: better, though I'm a bit groggy. should crash in a bit [20:26:07] mhurd: spiff lemme look [20:26:11] this 2.3 bug doesn't seem to die :( [20:26:16] mhurd: i was thinking we could make the external browser selectable in prefs [20:26:25] but we can re-add that later [20:26:31] brion: i like it! [20:27:10] mhurd: both changes on https://github.com/wikimedia/Commons-iOS/pull/43 ? (scrolling change & urls) [20:27:22] brion: ya [20:27:42] brion: the scrolling was just a small tweak from last night [20:28:10] * jdlrobson still confused why the css and scripts are being combined [20:28:22] brion: or rather in addition to last night's branch which you already merged [20:28:30] jdlrobson: link? [20:28:34] i am not seeing that... [20:28:54] YuviPanda|Meds: responded [20:29:00] yeah, read :) [20:29:06] well awjr we're creating a link https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.styles%7Cmobile.styles.page%7Cmobile.xdevice.detect.styles%7Cmobile.zero.styles&only=styles&skin=mobile&target=mobile&* that varies [20:29:16] tfinc: there is one issue with that, which is that commons accepts Nudity and, uh, 'more' [20:29:20] yes [20:29:30] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.xdevice.detect.styles&only=styles&skin=mobile&target=mobile&* is all that needs to vary [20:29:41] why vary a big file when you can vary a small one? [20:29:57] likewise https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.xdevice.detect.scripts&only=scripts&skin=mobile&target=mobile&* [20:30:11] * jdlrobson wonders if setting a group on the module would help here [20:30:40] YuviPanda|Meds: i dont think that apple actually cares to set the guideline of whats objectionable. they let the apps do it themselves. and as long as their is a mechanism it keeps working [20:31:02] this leaves a very very bad taste in my mouth. [20:31:03] but items on commons that may be seen as pr0n may reach outside of that [20:31:23] YuviPanda|Meds: what does ? [20:31:43] * tfinc wonders if YuviPanda|Meds pain meds taste bad [20:31:45] see, according to apple if a user reports something as objectionable [20:31:51] and if it is objectionable by *apple* standards [20:31:54] it should be removed in 24 hours [20:32:04] link me to do doc [20:32:09] now, on commons, a lot of things that are objectionable by apple standards will never be removed [20:32:11] the doc on apple? [20:32:11] the* [20:32:13] yeah [20:32:15] it said so in the email [20:32:21] "- Developer must act on objectionable content reports within 24 hours by removing the content and ejecting the user who provided the offending content " [20:32:48] YuviPanda|Meds: we should check if that still applies if we say 'fuck it, label as 17+' [20:32:55] yeah that wont work for commons [20:32:59] and on what apple considers objectionable - political satire (http://blog.cloudfour.com/apples-policy-on-satire-16-rejected-apps/), bikinis (http://iphoneincubator.com/blog/general/app-store-rejections-can-you-define-%E2%80%9Cobjectionable%E2%80%9D-content-please) [20:33:15] awjr: Maryana MaxSem jdlrobson sanity tests run, searching, adding to watchlist in beta, alpha and non beta [20:33:20] yuvipanda|meds, but all this is predicated on the idea that some human will a) download the commons app, b) use it, and c) report things that are objectionable [20:33:28] brion: making the Details license open externally now... [20:33:31] and most users who use the app will be experienced commons users, for now anyway [20:33:33] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/-_o_XA [20:33:33] Commons-iOS/master c0069f5 Monte Hurd: Simplified about page scrolling code... [20:33:33] Commons-iOS/master 45672d2 Monte Hurd: Modified about page urls to open in external browser.... [20:33:33] Commons-iOS/master 097b1f7 Brion Vibber: Merge remote-tracking branch 'monte/aboutPage' [20:33:40] Maryana: well, it's predicated on what the app store reviewer does :P [20:33:52] Maryana: for example, commons folks aren't going to be pissed about the donate link either. [20:33:54] but someone will actually have to report something as objectionable [20:34:07] mhurd: ooh we also missed the web view link on the detail page for already-uploaded items [20:34:09] to active the 24-hour window for us to respond [20:34:24] brion: agh! i'll get that too [20:34:27] thx [20:34:34] Maryana: I think Apple will just want to verify that the mechanism is in place. [20:34:40] Maryana: or maybe they'll test it too? [20:34:45] go ahed and take out the WebViewController, but leave BrowserHelper -- well use it in the future [20:34:50] what i'm saying is that with the current userbase on the app and the current feature set, nobody is going to report anything objectionable. so we can promise them whatever they want [20:34:52] Maryana: tfinc I think, at this point, we do not actually have enough information about that :) [20:34:53] New patchset: Jdlrobson; "RL: vary as little as possible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512 [20:34:54] ^ MaxSem awjr [20:35:03] Maryana: tfinc yup, so I tihnk let's fix the donate thing and resubmit [20:35:05] and see how it goes [20:35:28] jdlrobson, you can't create your own groups [20:35:32] MaxSem: you can [20:35:49] this, of course, leaves a bad taste in my mouth (person X deciding how developer A and user B interact), but I suppose that's what all the people using iDevices want... [20:35:50] *shrug* [20:36:18] jdlrobson, I specifically investigated this issue, reading OutputPage [20:36:26] YuviPanda|Meds: most iDevice owners have no clue that apple has that kind of weird control, i suspect [20:36:29] $styles = array( 'other' => array(), 'user' => array(), 'site' => array(), 'private' => array(), 'noscript' => array() ); [20:36:45] they just play with their phones and never notice what they don't get [20:36:48] YuviPanda|Meds: i'm reading this per Sue and it lines up frighteningly well http://www.amazon.com/The-Master-Switch-Information-Empires/dp/0307390993 [20:37:02] foreach ( array( 'site', 'noscript', 'private', 'user' ) as $group ) { .... } [20:37:07] MaxSem: explain why 'group' => 'ext.visualEditor', is in VisualEditor code then? :) [20:37:18] tfinc: indeed. It sortof... scares me. [20:37:26] with how the telegraph, radio, tv, internet, etc shift as they evolve over time [20:37:28] tfinc: one of the many reasons I hope Apple dies, and dies soon. [20:37:37] from open and free to streamlined and limited [20:37:38] because it's for client-side loads. addScriptStyles() is more restrictive [20:38:18] New review: MaxSem; "As explained in IRC, will not work with addModuleStyles()" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/59512 [20:38:55] at least the telephone doesn't hang up on my conversation if i say something offensive [20:39:00] tfinc: in ways the iOS app store model is the exact opposite of the Wiki model, where everyone is welcome to play but only if it is okay with the dude who owns the ball [20:39:30] YuviPanda|Meds: Apple iBall can only be used to play Apple-approved games [20:39:31] so MaxSem I just spoke with Roan and he has confirmed that's what groups are designed for [20:39:40] Maryana: the flag for deletion conversation is one that i'd like to have in the open with commons admins. is that best on email, wiki, other ? [20:39:42] jdlrobson, read the code [20:39:44] brion: heh, but I'm sure they're not handing otu licenses to companies that won't let the govrnment tap things out. [20:39:50] tfinc: it's best on Commons:VP [20:39:55] MaxSem: I just spoke to the people that wrote the code - and they are telling me otherwise :) [20:40:00] tfinc: the commons-l list is very inactive [20:40:05] jdlrobson, read the code [20:40:09] MaxSem: have you tested my patch? [20:40:11] http://commons.wikimedia.org/wiki/Village_pump [20:40:16] tfinc - i'm not so sure that's a good idea, tbh [20:40:21] +1 to Maryana [20:40:21] I tried somethiing similar myself [20:40:26] commons users are gonna freak [20:40:28] MaxSem: have you tested my patch? [20:40:35] jcmish: i saw you mentioned you ran all your tests - things look ok to deploy? [20:40:37] and say we're imposing apple's conservative standards on their project [20:40:39] if you think the mobile web stuff was pitchforks... [20:40:40] YuviPanda|Meds: the government is welcome to tap my phone as long as they make all their phone calls and emails public… i don't think they'll take the deal though ;) [20:40:52] awjr: yup [20:40:52] not a apple is doing this to us. but a how do we handle flagging in the app for any store that requires it [20:40:53] brion: I'm pretty sure it's already happening :P [20:40:55] i'd almost be inclined to say that we allow users to "flag" stuff.. and then that just goes directly to us, tfinc [20:41:05] Maryana: are you done testing on testwiki? things look OK to deploy? [20:41:07] i doubt there would be much traffic on a flag feature [20:41:15] jdlrobson: the icons are funky on the blackberry [20:41:16] Maryana: where us = ? [20:41:18] New review: Jdlrobson; "As explained in IRC Roan has told me this is exactly what they are designed for and "it works"." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512 [20:41:21] tfinc, mobile team [20:41:32] Maryana: were not built to be a content team [20:41:33] they're huge and unpreportioned I'm trying to figure out how to take a picture [20:41:36] wouldn't scale [20:41:50] awjr, i need to test nearby in production, so if everything looks good to you guys, let's do it [20:42:01] MaxSem: ^ [20:42:32] tfinc, maybe.. if we really only target existing commons users for the app, i doubt you'd get any "flags", is what i'm saying [20:43:03] it's tricky. but telling commons users that we're going to give people the ability to flag content sounds suspiciously like image filter [20:43:07] and you know how well that went... [20:43:08] MaxSem: i've read the code now as you've asked me to "foreach ( $moduleStyles as $name ) {" confirms that this is the case [20:43:26] Maryana: true that. but flag for deletion is a common practice [20:43:34] were not saying mobile/desktop get different views [20:43:40] were saying what will stick around vs being deleted [20:44:35] yeah, i dunno, it's tough. i'd definitely check w/erik [20:45:14] MaxSem: it just defaults to other in the case of styles which is fine [20:45:30] "// Modules in groups named "other" or anything different than "user", "site" or "private" " [20:45:45] "// will be placed in the "other" group" [20:46:04] we definitely do not want to vary the entirety of the js and css files! [20:46:23] just the basics [20:46:26] ^ awjr i don't know if you have been following this conversation [20:46:34] not particularly jdlrobson [20:46:38] * awjr reads backscroll [20:46:41] tfinc: Maryana yeah, super tricky. I'd like Eloquence and ragesoss to respond too. Plus we should definitely not 'sneak' it in, even if it is just reporting it to us [20:47:26] already scapping [20:48:32] yuvipanda|meds, yeah.. blah. never would have imagined this would be so bureaucratic-y [20:48:38] hmm, not sure why it didn't work for me before [20:48:48] jdlrobson: i hear what you're saying; id need to dig into the code to see what's going on. for now, my feeling is that the way things are being handled is fine; the js/css resources that we're varying on X-Device are still relatively small and i dont think is going to be a big deal. we can optimize this later [20:49:12] prolly, related to subsequent changes [20:49:27] jdlrobson: unless you have a major reservation? [20:49:32] Maryana: Apple has always treated its developers badly :) Not just an iOS thing. [20:49:49] they treat users very nicely, however! [20:49:53] heh [20:49:58] i guess the burden has to go somewhere [20:50:35] that's one way of looking at it, yeah :) [20:50:48] awjr: i just see this as a trivial change that will maximize our cache hit - your call though [20:51:04] awjr, does https://gerrit.wikimedia.org/r/59449 look ok? [20:51:28] jdlrobson, if it's not an emergency, we shouldn't even think about merging during deployment [20:51:37] jdlrobson: let me get to a stopping point on what im doing and i'll take a look [20:52:10] MaxSem: scapping in progress? [20:52:18] yes [20:53:14] MaxSem: lgtm https://gerrit.wikimedia.org/r/#/c/59449/ [20:55:16] New review: Jdlrobson; "I've also grepped the code to confirm this to be the case. In the same of styles where the group is ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512 [20:56:01] Change abandoned: Jdlrobson; "There was another change that forced debug mode on qunit tests. This will work for our use case but ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58627 [20:56:29] MaxSem: do you know offhand where the code in question regarding groups is in OutputPage? [20:56:41] buildCssLinks() [20:56:48] ty [20:57:39] brion: seen https://developer.apple.com/appstore/resources/approval/guidelines.html? [20:57:53] brion: reminds me of the Imagefilter discussion :) [20:58:01] YuviPanda|Meds: you mean the page that says "we are dicks and may arbitrarily reject your app. fuck you!"? [20:58:14] ooo, angrybrion! [20:58:18] yes, one of the many pages that says that [20:58:36] sonuva http://commons.wikimedia.org/w/index.php?title=File%3AZuni_Cafe_in_San_Francisco.jpg&diff=94374687&oldid=94242540 [21:00:36] tfinc: same guy who said he is quitting commons because of mobile web uploads, btw [21:00:47] ragesoss: --^ [21:01:00] so what should i do ? [21:02:05] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=46764 [21:02:29] tfinc: you can either email OTRS (surefire way, less drama), or revert the edit with a summary about how yes, you did take it and the {{information}} tag was added later by a bot [21:03:01] by revert you mean undo ? [21:03:10] yeah [21:03:31] that *might* cause drama. [21:03:33] or might not [21:03:36] ragesoss will know better [21:03:53] i reverted it [21:03:55] lets see what happens [21:04:11] :) [21:04:16] * YuviPanda|Meds glares at 2.3 [21:04:29] tfinc: what was the outcome of the video codecs meeting? [21:04:35] can you respond to that email with notes? [21:04:36] mhurd: top rope @ MC tonight ? [21:04:44] YuviPanda|Meds: sure [21:04:52] thanks! [21:05:42] YuviPanda|Meds: short version. legal needs more time to review the contract. i need to create/update our multimedia infrastructure docs [21:05:43] New review: awjrichards; "Whether or not this gives us or our users a performance boost is unclear. Doing this would require c..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/59512 [21:05:52] alrgiht :) [21:05:56] jdlrobson: ^^ [21:06:04] tfinc: was there a vague timeline? [21:06:34] tfinc: yes!!! [21:06:36] if i tell you one will you really trust it ? [21:06:58] mhurd: then see my email on climbers@ [21:07:00] slow legal wheels are slow :) [21:08:00] tfinc: will do! [21:10:06] tfinc: better than nothing :D [21:10:19] tfinc: plus I expect it to be accurate to +/- 2 months :P [21:13:36] tfinc: sent you a quick mail about the firefox os app. i can make some quick fixes, but we might want to consider replacing the standalone app with a good clean link into the mobile web site [21:13:57] no rush [21:24:52] mhurd ping me when your changes are ready to review and I'll prep a new build. whee apple! [21:27:10] brion: k [21:29:04] brion: where in the submission process can we explain our content review guideliens ? [21:29:58] tfinc I guess in 'review notes' [21:30:19] course that's where I put the create account link ;) [21:30:27] tfinc: brion there's a box in https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/da/rejectionReasons?adamId=630901780 for you to respond to their current review [21:30:51] what's the best place for me to respond from ? [21:31:21] mhurd: brion ^ [21:31:31] should our response go as a response to the current review or with the new build? [21:32:31] [Commons-iOS] montehurd opened pull request #44: More external browser fixes (master...externalBrowser) http://git.io/pHgqvA [21:34:28] Yuvi probably we should add a response but submit new binary also with that info [21:34:32] brion: i think i got it all squared away [21:35:52] spiff lemme take a peek [21:41:47] mhurd: looks good, lemme merge [21:42:16] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/VGr0uQ [21:42:16] Commons-iOS/master 1d66f19 Monte Hurd: License and view image pages now load in external browser... [21:42:16] Commons-iOS/master 2c5b36e Monte Hurd: Removed un-needed references to WebViewController.h... [21:42:16] Commons-iOS/master 7b6ed29 Brion Vibber: Merge remote-tracking branch 'monte/externalBrowser' [21:42:22] \0/ [21:42:35] woohoo! [21:43:12] anything else we should tweak before resubmitting? [21:43:19] with an explanation that only your own photos are visible? :P [21:43:38] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/TVCLKg [21:43:38] Commons-iOS/master 9ce1e93 Brion Vibber: Bump ver to 1.0.1 [21:44:49] brion_: yeah, do you need me to write that up ? [21:45:04] brion_: then we need to decide about the age rating [21:45:13] *nod* [21:45:39] this kinda thing makes me fear for 'wikikidia' or whatever :) [21:46:22] awjr, dr0ptp4kt, jcmish, jdlrobson, Maryana - deployed everywhere, please test:) [21:46:40] roge [21:46:40] r [21:47:38] sweet! [21:47:58] ack. nearby view all squashed on iOS [21:48:21] sweet working on it now [21:49:20] yeah, same in desktop chrome Maryana - we noticed that yesterday but weren't able to get a fix in time [21:49:42] no bigs, it's beta [21:49:50] ya [21:49:52] uploading to testflight... [21:50:01] more worryingly, upload CTA doesn't seem to be showing up [21:50:09] i'm logged in on beta on the W San Francisco article [21:50:15] which nearby tells me needs images [21:50:20] is the nearby CTA just off? [21:51:18] EL back up; I'll write up a brief explanation later tonight and CC mobile tech. Since you guys only use client-side events, gaps in data should be confined to 19:08 - 20:54 (UTC). [21:51:21] ^ Maryana [21:51:37] thanks, ori-l [21:52:02] which reminds me - we should confirm that event logging is now working per stories 482 and 438 [21:52:08] Maryana: ^ [21:52:18] yep. i'm just trying to find an article that has an upload CTA from nearby [21:53:13] tfinc: i've sent the build to test flight and sent out the install emails [21:56:46] ok, confirmed that i'm seeing events firing from nearby [21:56:51] awesome [21:58:47] automation tests passed on production [21:59:09] beta, non beta and alpha [21:59:23] errrr looks like the funnel isn't working for some odd reason [22:00:39] yeah, it tracks the user as a nearby uploader through preview and submit, but not success [22:01:08] err, actually, only preview and cancel [22:02:07] the "what does this mean" logging doesn't appear to be working, either [22:04:31] New patchset: Jdlrobson; "Funnel fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59532 [22:04:38] ^ Maryana awjr [22:05:11] yeah… we need to get eventlogging working in betalabs so this doesn't happen [22:05:50] tfinc: mhurd ok ping me if anything new comes up to adjust on the iOS app, i'llbe online [22:07:18] Maryana: Uncaught TypeError: Object # has no method 'log' ergg [22:07:20] jdlrobson: confident this is right this time? https://gerrit.wikimedia.org/r/#/c/59532/1 [22:07:36] wat [22:08:56] brion: will do [22:09:57] just noticed a js error on what looks like pages with tables [22:10:02] Exception thrown by mediawiki.page.ready: Unknown dependency: jquery.tablesorter [22:10:02] https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:10:02] . Error {} https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:10:02] . loghttps://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:10:04] . executehttps://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:10:06] . mw.loader.implementhttps://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:10:07] ori-l: latest master of event logging - Parse error: parse error in /Users/jrobson/Sites/w/extensions/EventLogging/EventLogging.php on line 255 [22:10:08] . (anonymous function) [22:10:09] on https://en.m.wikipedia.org/wiki/Sergey_Pakura [22:10:23] jdlrobson: ^^ [22:10:33] 1 minute awjr looking at another problem [22:10:36] kk [22:11:45] brb guys [22:13:05] ugh, fuck. jdlrobson, check out 89f99095c4d1a2e82c4557322ea211f7034045ce [22:14:21] translation updates? [22:14:41] ori-l: https://gerrit.wikimedia.org/r/#/c/57866/ ? [22:14:56] i mean, git checkout :P [22:15:00] or wait two minutes for a fix [22:15:05] ahhh ok [22:18:09] New patchset: Jdlrobson; "Use the correct logging function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59535 [22:18:44] ok awjr looking at this particular issue [22:19:35] awjr: so that looks like mediawiki magic [22:20:00] mediawiki.page.ready is a default module [22:21:26] basically gonna need a core change.. [22:21:45] an easy one? [22:22:02] awjr: whoa what browser? https://bugzilla.wikimedia.org/show_bug.cgi?id=47065 https://bugzilla.wikimedia.org/show_bug.cgi?id=47277 [22:22:51] awjr: not sure yet.. but this default module pulls in a lot of js that i don't believe we need [22:22:54] 'jquery.checkboxShiftClick', [22:22:54] 'jquery.makeCollapsible', [22:22:55] 'jquery.placeholder', [22:22:56] 'jquery.mw-jump', [22:23:49] awjr: not quite sure why it only shows on certain pages.. [22:24:05] could it be something that's getting loaded by gadget or something like that? [22:24:28] also, does it seem to be limited to pages with tables? [22:24:39] jdlrobson: EventLogging's HEAD should be sane; sorry 'bout that. [22:24:45] awjr: we've been chasing something causing just that error for a couple days now, but a) not seen it outside test2wiki and b) not seen in browser other than IE and c) seen in debug mode only so far. [22:25:08] chrismcmahon: sorry - which error? [22:25:17] awjr: well i fear another bike shedding conversation will appear :) [22:25:21] mw.loader.implementhttps://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z awjr [22:25:40] chrismcmahon: I thought it was determined by PleaseStand to be IE's 31 stylesheet maximum? [22:25:55] if we're talking about the same thing. [22:26:29] ori-l: yes, but: [22:26:32] (03:09:57 PM) awjr: just noticed a js error on what looks like pages with tables [22:26:32] (03:10:02 PM) awjr: Exception thrown by mediawiki.page.ready: Unknown dependency: jquery.tablesorter [22:26:32] (03:10:02 PM) awjr: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130412T014541Z [22:26:53] MaxSem: https://en.m.wikipedia.org/wiki/Sergey_Pakura [22:27:00] ah i see chrismcmahon sorry, wasn't drawing the connection [22:27:55] awjr: ok i see the problem [22:27:59] we'll need a bug for this [22:28:00] awjr: np, I did a double-take myself "wow, now where have I seen that error string before..." [22:28:26] jdlrobson: is it the same thing that chrismcmahon was mentioning? [22:29:12] he's checking w/trevor, awjr [22:29:17] thanks Maryana [22:29:21] np :) [22:29:27] and jdlrobson do we still need to get those two patches merged/deployeD? [22:30:30] brb [22:30:38] jdlrobson, MaxSem: https://gerrit.wikimedia.org/r/59532 and https://gerrit.wikimedia.org/r/59535 - i've +2'd, waiting for merge [22:31:38] Maryana, jdlrobson are those urgent to get out now or can those wait? we're way outside of our window and will need to coordinate if we need to get them out now ^ [22:34:43] jon says they're not urgent [22:34:58] MaxSem: ^ [22:35:07] thanks Maryana [22:35:10] cool [22:35:21] sorry thought we were talking about other bug [22:35:30] those aren't urgent but it's up to Maryana if she wants event logging to work [22:35:40] or can wait a week :) [22:35:44] if it's a 3-second thing, we should do it now [22:35:56] so we can collect some data on nearby before pushing to production [22:36:09] the exception that awjr and chrismcmahon were discussing is not so urgent [22:36:10] awjr, maxsem ^ [22:36:37] sorry, that's what i thought awjr was asking about :-/ [22:36:57] both problems, really :) [22:37:54] awjr: we good for 4:30 ? [22:38:01] yep, tfinc [22:38:32] so Maryana there's another deployment happening right now, but there's lighting deploy at 4 [22:38:42] i can see if we can sneak it in during lightning deployment [22:38:46] jdlrobson awjr sound like you might know more about that error than is at https://bugzilla.wikimedia.org/show_bug.cgi?id=47277 if you'd care to comment [22:38:59] Maryana: otherwise it will have to wait [22:39:40] awjr, sneaking it in at 4 would be aweomse :) [22:39:48] i shall do my best! [22:39:49] *awesome, even [22:39:51] chrismcmahon: sure that's the right bug? [22:40:18] jdlrobson: this is my favorite version of it: https://bugzilla.wikimedia.org/show_bug.cgi?id=47065 [22:46:40] Maryana, jdlrobson looks like i'll be able to get those two patchsets out shortly [22:47:12] New patchset: Jdlrobson; "Documentation: Link FIXME to bug" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59538 [22:47:15] awjr: so i opened a bughttps://bugzilla.wikimedia.org/show_bug.cgi?id=47296 [22:48:17] sweet! [22:48:31] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [22:49:04] thanks jdlrobson - so that's a totally diffrent problem than what chrismcmahon was reporting [22:49:05] ? [22:49:48] different error msg at least [22:50:13] roger [22:51:28] awjr: looks like a different bug [22:52:21] * awjr slaps jenkins [22:53:11] I'm just intrigued by awjr getting that error msg. ...modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport... that's been so obscure since it turned up late last week. [22:54:43] brion: would this be the line that would make the app handle opening an image from another app? https://github.com/montehurd/Commons-iOS/blob/master/Commons-iOS/AppDelegate.m#L47 [22:54:58] totally chrismcmahon, though it sounds like they manifested somewhat differently [22:59:12] mhurd its actually the application:openurl:from application: a few bits down [22:59:23] brion: ahh [22:59:52] there was some special case that made it pop up the detail screen yhough [22:59:54] brion: hehe guess i missed the method name [23:00:09] and that's what's not triggering anymore [23:00:54] so what's happening is it sees the file, saves it into the queue, but never prompts you to enter a description [23:01:31] brion: huh… [23:01:49] brion: want me to jump on this? [23:02:25] mhurd: yeah see if you can track it down [23:02:55] brion_: k [23:03:07] so MaxSem awjr there is a slight problem with device detection mw.config.get('wgMobileDeviceName') is not set before the bannerController is loaded :( - so confusingly device specific styles need to load last and js first… [23:03:38] jdlrobson, this should be done with dependencies [23:03:52] MaxSem: RL has no concept of optional dependencies [23:04:21] although that said we can do it in this case as we use a mobile specific module... [23:05:23] so.. i have the greenlight to deploy those changes but am stuck waitnig for jenkins to finish [23:05:36] jdlrobson, $wgHooks['EnterMobileMode'][] = function() { global $wgResourceModules; $wgResourceModules['foo']['dependencies'][] = 'mobile.xdevice.detect.scripts'; } [23:05:50] MaxSem: jdlrobson: although that said we can do it in this case as we use a mobile specific module... :) [23:06:03] but MaxSem this won't be true if vary resources is not set [23:06:11] was busy typing:) [23:06:18] * jdlrobson wishes there was a soft dependency concept [23:07:10] mhurd: oh i think i know what it is [23:07:22] jdlrobson, yeah - this will need to wait for variance to be enabled everywhere - and it will not be enabled e.g. on Commons [23:07:41] brion_: ya? [23:07:45] because Commons has no automatic redirection [23:07:56] mhurd: MyUploadsViewController has a special-case in its core data update handler [23:08:11] when a new item is inserted that's marked as incomplete, it pushes over to the detail view [23:08:24] this works when we take a new photo or use the gallery because the my uploads view is active [23:08:47] and used to work i think for the open-in-application because the my uploads view was the first subview in the navigation stack [23:08:58] but now it's probably triggering on the login screen before we push past it [23:09:06] and the my uploads view never sees the insert [23:10:41] MaxSem: https://gerrit.wikimedia.org/r/59546 [23:11:17] brion_: makes sense [23:12:03] jdlrobson, +1d [23:12:32] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59535 [23:12:38] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59532 [23:12:41] could probably stuff it into… say it with me… "the singleton" :) [23:13:04] brion_: hahaha [23:13:28] feel free to come up with a more elegant solution :D [23:14:25] so are we doing deployment part 2, electric boogaloo? [23:14:27] :) [23:14:42] gotta charge this laptop, brb [23:15:40] how did they boogaloo pre-electric grid? [23:18:48] analog boogaloo [23:19:15] * YuviPanda|Meds shakes fist at android 2.3, goes to sleep [23:22:01] jdlrobson, Maryana, jcmish: just deployed those patchsets [23:22:15] sweet [23:22:18] * jdlrobson looks [23:22:24] fire some events! [23:22:42] actually may be a few minutes for bits cache to expire [23:22:56] appears to be working [23:23:14] ah well, sweet :) [23:23:20] jdlrobson, did you upload from nearby? all i see is a preview [23:23:36] Maryana: nope but if those are working then the latter will work :) [23:23:49] i'm gonna send a cancel event from nearby now.. [23:23:56] ok, looking.. [23:24:07] yep sent [23:24:07] got it! [23:24:15] now check the "what does this mean" link, plz [23:24:24] done [23:25:04] hrm [23:25:13] it just shows up as "preview" [23:25:35] jdlrobson ^ [23:26:12] Maryana: {"event":{},"clientValidated":false,"revision":-1,"schema":{"action":"whatDoesThisMean"},"webHost":"en.m.wikipedia.org","wiki":"enwiki"};: [23:26:32] schema is -1 for some reason - this is what ori-l was complaining about earlier.. [23:26:51] config problem? [23:26:53] how strange.. [23:26:58] are you grepping that from server side logs? [23:27:14] actually no.. revision is -1 schema is empty [23:28:33] MaxSem: since we don't provide feedback stuff from MF anymore, should we pull all that cruft out of the conf/ [23:28:48] prolly [23:29:01] why it's still live in MF btw? [23:29:10] oh, i thought we turned it off [23:29:30] or we just made it impossible to find [23:29:39] the latter [23:29:42] yeah [23:29:44] heh [23:30:15] Maryana: yeh so it's still funky - is anything showing up at all your side? [23:30:16] \ [23:30:24] it's triggering an event but i suspect it's validating badly [23:30:31] nope, i just see "preview" in the sql tables [23:30:43] brion: keynote app is huge! [23:30:43] my screw up [23:30:49] that's ok [23:31:01] should have verified they were coming in from my machine [23:31:02] just checking in the raw logs [23:31:31] it's the templates I bet. iapps whee [23:31:34] anyway, not a huge deal. it was more of a nice to have. the logging uploads via nearby was the crucial piece of logging :) [23:31:41] jdlrobson ^ [23:34:46] awjr, https://gerrit.wikimedia.org/r/59553 [23:39:28] New patchset: Jdlrobson; "Give PhotoUploaderPreview access to log function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59555 [23:54:25] so are we all set w/deployment? [23:54:50] ps, I just discovered colloquy on my phone and it had changed my life [23:54:53] New patchset: Jdlrobson; "Alpha: Talk page - allow access to lead section conversation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [23:54:54] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [23:55:51] awjr ? [23:55:58] New review: Jdlrobson; "wanting input from juliusz - just had a fiddle around to see if this could easily be done and found ..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/59560 [23:56:05] Maryana_, yes [23:56:26] Ok, sweet. Thanks, MaxSem :) [23:58:23] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [23:58:23] New patchset: Jdlrobson; "Promote menu button generation to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [23:58:37] New patchset: Jdlrobson; "Define render function in MinervaTemplate to output page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58991 [23:58:42] New patchset: Jdlrobson; "Kill navigationStart" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58992 [23:58:47] New patchset: Jdlrobson; "Promote all the banners into MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58993 [23:58:51] New patchset: Jdlrobson; "Move header to generic MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [23:58:55] New patchset: Jdlrobson; "banner fixup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58995 [23:59:00] anybody need anything? i'm going to wrap up for the day in MN.