[00:01:47] <dr0ptp4kt>	 alright, heading out. have a good evening/morning/day...
[00:02:35] <mhurd>	 gnight!
[00:06:02] <gerrit-wm>	 New patchset: Jdlrobson; "banner fixup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58995
[00:07:02] <gerrit-wm>	 New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997
[00:07:02] <gerrit-wm>	 New patchset: Jdlrobson; "Code move: Lift and shift html rendering to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996
[00:07:09] <gerrit-wm>	 New patchset: Jdlrobson; "Promote addToBodyAttributes to desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257
[00:08:38] <gerrit-wm>	 New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512
[00:16:53] <awjr>	 Maryana: hey sorry was in a mtg
[00:17:00] <awjr>	 deployment's all done!
[00:17:08] <awjr>	 doh
[00:20:55] <tfinc_>	 mhurd: leaving in 10min
[00:21:04] <mhurd>	 tfinc: ah!
[00:21:14] <mhurd>	 tfinc: sounds good!
[00:36:03] <qgil>	 hi, about http://www.mediawiki.org/wiki/Mobile_QA/DeviceType_Changes I will do the promotion tomorrow morning
[00:36:39] <qgil>	 now we have Asia and Europe basically sleeping, and this is where most of the non-iOS/Android devices you are looking for can be found
[00:39:25] <awjr>	 thanks qgil, that sounds great :) jcmish ^
[12:26:12] <gerrit-wm>	 New review: Siebrand; "L10n LGTM" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/59559
[14:15:01] <gerrit-wm>	 New review: MaxSem; "max@vmubuntu:~/Projects/MediaWiki/extensions/MobileFrontend$ make phpunit" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/59338
[14:18:13] <gerrit-wm>	 New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/56613
[14:24:58] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59538
[15:59:38] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Allow searching from special page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59636
[16:30:31] <brion>	  Status Waiting For Review
[16:30:35] <brion>	 dum dee dum
[16:31:01] <MaxSem>	 is it good or bad?:)
[16:53:08] <gerrit-wm>	 New patchset: Jdlrobson; "Add protection for bug" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59647
[16:56:45] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 47320: Make proximity right value consistent with watchlist page star" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59648
[16:58:23] <MaxSem>	 jdlrobson, so what's wrong with http://en.m.wikipedia.org/w/api.php?callback=jQuery183024442400317639112_1366214103812&format=jsonfm&action=query&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.7739738%7C-122.44422600000001&ggsradius=10000&ggsnamespace=0&ggslimit=50&_=1366214105344 ?
[17:03:59] <Maryana>	 awjr, standup?
[17:04:12] <awjr>	 oh jeez thanks
[17:04:26] <Maryana>	 :)
[17:04:26] <awjr>	 totally lost track of time :p
[17:13:05] * brion  rearranges cards on trello

[17:13:07] <brion>	 wheeeee!
[17:14:19] <jdlrobson>	 MaxSem: point me to the bug again?
[17:14:38] <gerrit-wm>	 New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59647
[17:14:56] <MaxSem>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=47133
[17:15:04] <jdlrobson>	 MaxSem: so grep for "title": "Sunset Tunnel",
[17:15:08] <jdlrobson>	 no coordinates in it
[17:15:27] <brion>	 mhurd: do you have more tweaks you're already working on? let's make sure they're on the trello board
[17:15:41] <brion>	 i've got a couple more things you can take from the 'to do' column if you like :)
[17:16:08] <Maryana>	 jdlrobson, so nearby does appear to be logging correctly - just tested on a nexus
[17:16:22] <jdlrobson>	 Maryana: sweet move over that card! :)
[17:16:27] <Maryana>	 will do!
[17:16:42] <jdlrobson>	 gawd.. bugzilla.. is there no easy way to find bugs i recently opened?
[17:17:05] <MaxSem>	 jdlrobson, "my bugs" in the sidebar
[17:17:15] <jdlrobson>	 ahh yeh
[17:17:42] <mhurd>	 brion: ah, good point - still on the open-from-extenal-app issue. got keynote for testing
[17:17:52] <brion>	 awesome
[17:18:02] <mhurd>	 brion: yes please on the to-do column
[17:18:19] <gerrit-wm>	 New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59647
[17:18:24] <brion>	 opt-out for logging and make external browser selectable as pref shouldn't be too hard
[17:18:51] <brion>	 if you're brave, try 'detect and log upload cancellations' :)
[17:19:03] <brion>	 something's dropping the ball and not sending through an error response iirc
[17:19:07] <jdlrobson>	 ergg MaxSem doesn't show what i want though..
[17:19:12] <jdlrobson>	 what crazy ordering system is this?! :)
[17:19:23] <MaxSem>	 jdlrobson, so it's possible to generate a list that has no coordinates for a lot of entries eg http://en.m.wikipedia.org/w/api.php?callback=jQuery183024442400317639112_1366214103812&format=jsonfm&action=query&coprimary=secondary&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.7739738%7C-122.44422600000001&ggsradius=10000&ggsnamespace=0&ggslimit=
[17:19:27] <mhurd>	 oh forgot to mention at stand up - i met w/vibha yesterday to start picking her brain about design goodness
[17:19:37] <brion>	 ah great
[17:20:03] <jdlrobson>	 MaxSem: if there are no coordinates then the api is doing the wrong thing - i only want things nearby not things that are nearby or might be nearby...
[17:20:11] <MaxSem>	 nah
[17:20:14] <mhurd>	 brion: sounds good on those to-do's
[17:20:48] <brion>	 mwahaha… i'll start planning the category additions and keep an eye out for review updates
[17:21:00] <MaxSem>	 e.g. it's possible to search for points with primary coordinates, but request secondary coordinates like in my example
[17:21:02] <MaxSem>	 that's billion percent legitimate
[17:23:02] <MaxSem>	 jdlrobson, ^^. that your particular instance with Sunset Tunnel is a manifestation of a known bug with updates but still the point that it's legitimate not to return coordinates in a lot of cases
[17:23:50] <jdlrobson>	 MaxSem: i can't see a legitimate case. I'm a developer who wants things nearby and you can imply for that I want to know where they are
[17:23:57] <MaxSem>	 example: coordinates removed from an article: they disappear from DB immediately but will vanish from Solr only after the next cron update
[17:23:58] <jdlrobson>	 if you can't give me both these things i'm not interested in the result :)
[17:24:15] <MaxSem>	 so yeah - I can't
[17:24:28] <jdlrobson>	 MaxSem: yes i can understand that but you should protect me against this
[17:24:38] <MaxSem>	 how?
[17:24:41] <jdlrobson>	 it's completely unreasonable to expect an api consumer to deal with this
[17:25:04] <jdlrobson>	 MaxSem: i don't know the code well enough to tell you how to deal with this - i'm just saying we need to deal with this
[17:25:32] <jdlrobson>	 if i've asked for a coordinates property and it's not there then it shouldn't be returned
[17:26:06] <jdlrobson>	 Maryana: can you reprioritise the code review column? i've added some bug fixes
[17:26:11] <MaxSem>	 it's not there and it's not returned
[17:26:19] <Maryana>	 jdlrobson, roger
[17:26:30] <jdlrobson>	 thanks Maryana :)
[17:26:34] <MaxSem>	 property modules don't work  the way you want them to
[17:26:52] <MaxSem>	 if you requested a title, it must be present in pageset
[17:27:01] * brion  coffees

[17:27:10] <MaxSem>	 if a property is available, it will be returned
[17:27:23] <MaxSem>	 but you haz no guarantee
[17:27:52] <Maryana>	 jdlrobson, btw, i did try logging out/logging back in to see the upload button. no luck :(
[17:28:41] <MaxSem>	 ALL prop modules work this way. they DON'T filter
[17:28:59] <MaxSem>	 yurik_ can confirm
[17:29:28] <tfinc>	 YuviPanda: how are you feeling today?
[17:29:57] <YuviPanda|Meds>	 mm
[17:29:59] <YuviPanda|Meds>	 tfinc: had a bout of intense pain a while back, so went and got more meds
[17:30:03] <YuviPanda|Meds>	 tfinc: so... worse than yesterday
[17:30:15] <mhurd>	 YuviPanda|Meds: :(
[17:30:16] <tfinc>	 are we sure your pain meds do anything ?
[17:30:18] <YuviPanda|Meds>	 tfinc: tomorrow evening is the procedure, so hopefully things get better from there
[17:30:25] <ori-l>	 YuviPanda|Meds: oh man :(
[17:30:27] <tfinc>	 perhaps its whiskey time
[17:30:38] <YuviPanda|Meds>	 Stuck in Chennai == No Alcohol
[17:30:43] <YuviPanda|Meds>	 well, no alcohol worth having, at least
[17:30:58] <YuviPanda|Meds>	 ori-l: sucks. THe last time I had to go to a dentist was almost 15 years ago :(
[17:31:26] <YuviPanda|Meds>	 tfinc: they're kicking in slowly, and I think it's back to where it was a couple of days back.
[17:32:35] <jdlrobson>	 MaxSem: yurik_ i'm not saying that's not how it's working i'm just saying this is another dumb thing the api does. If I wasn't a foundation member employee and just a normal frontend developer i would have given up with the api by now out of frustration. It shouldn't work that way from a frontend perspective.
[17:32:52] <jdlrobson>	 YuviPanda|Meds: :(
[17:33:05] <YuviPanda|Meds>	 jdlrobson: sucks.
[17:33:06] <jdlrobson>	 YuviPanda|Meds: have they got you on morphine at least
[17:33:18] <jdlrobson>	 or some other fun indian pharmacy approved drug?
[17:33:21] <YuviPanda|Meds>	 jdlrobson: so far I only have had oral painkillers.
[17:33:28] <YuviPanda|Meds>	 hopefully I'll get something else tomorrow
[17:33:34] <tfinc>	 Maryana: is https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 up to date ?
[17:33:35] <MaxSem>	 jdlrobson, so create a FR for filters in API 2.0;)
[17:33:48] <jdlrobson>	 MaxSem: i have too many battles to fight
[17:34:02] <jdlrobson>	 i need someone else to fight this battle for me right now
[17:36:57] <YuviPanda|Meds>	 oh man
[17:37:02] <YuviPanda|Meds>	 Commons has some crazy people https://commons.wikimedia.org/wiki/Commons:Deletion_requests/Template:Gods_Work
[17:37:07] <YuviPanda|Meds>	 sane ones too, yes.
[17:40:02] <Maryana>	 tfinc: now it should be :)
[17:47:49] <MaxSem>	 jdlrobson, another example: you have another module in that query, prop=pageimages. bang! all pages without images suddenly disappear
[17:53:10] <tfinc>	 thanks
[18:27:49] <jdlrobson>	 Maryana: you got mail
[18:28:30] * Maryana  reads

[18:28:47] <Maryana>	 i checked w/vibha yesterday; she said she'd have design assets by the story review today
[18:30:07] <tfinc>	 Maryana: what did vibha say about the tutorial ?
[18:30:20] <Maryana>	 she said she'd have that ready, too :)
[18:31:04] <tfinc>	 woot!
[18:32:47] <jdlrobson>	 oohh loving the wikivoyage homepage
[18:33:27] <jdlrobson>	 with a few tweaks it could be mobile friendly..
[18:38:49] <awjr>	 has anyone heard anything from juliusz today?
[18:40:31] <awjr>	 he's supposed to be back in SF today, but i dunno if that meant he was supposed to be back working today, or his flight was arriving sometime today
[18:42:53] <moogsi>	 YuviPanda|Meds: haha i didn't know it was a work in progress!
[18:42:54] <brion>	 mhurd: YuviPanda|Meds: how's something like this sound for add-category UI on iOS? https://brionv.com/misc/cats-ui.png
[18:42:59] <moogsi>	 that was only 7 months ago
[18:43:42] <YuviPanda|Meds>	 brion: neato :)
[18:43:46] <YuviPanda|Meds>	 moogsi: what was?
[18:44:05] <ragesoss>	 Creation
[18:44:22] <YuviPanda|Meds>	 hmm?
[18:44:34] <ragesoss>	 the template
[18:44:44] <YuviPanda|Meds>	 i'm entirely super confused
[18:44:46] <ragesoss>	 God's Work
[18:45:09] <moogsi>	 yes, that
[18:45:23] <YuviPanda|Meds>	 aah
[18:45:24] <YuviPanda|Meds>	 :D
[18:46:01] <moogsi>	 i saw it on VP/C and i thought, this person is crazy but it's kind of interesting so i'll be nice...
[18:46:04] <mhurd>	 brion: nice!
[18:46:16] <moogsi>	 maybe they think everyone has forgotten
[18:53:35] <YuviPanda|Meds>	 moogsi: God never forgets :)
[18:53:57] <YuviPanda|Meds>	 brion: pretty neat! I like it better than the Android version
[18:54:06] <brion>	 :D
[18:54:22] <brion>	 well so far it's just the UI layout, i haven't coded any of the behavior  up yet ;)
[18:54:54] <brion>	 but i'm glad it sounds right to you guys :D
[18:55:06] <YuviPanda|Meds>	 sure, but I've been super unproductive this week and that doesn't seem to be improving, so I bet when I come back in June I'll have a lot of catching up to do :)
[18:56:15] <YuviPanda|Meds>	 brion: I think we'll have to overhaul UploadCampaigns' data storage before we'd want to use it. Thoughts?
[18:56:22] <YuviPanda|Meds>	 not right now, of course. But still..
[18:56:29] <mhurd>	 brion: quick update: i found some complications with the "open-from-external-app" issue, such as the user being already authenticated vs not, app suspended vs not running and the myuploads position in nav stack. i think i've almost got a pretty simple solution though
[18:57:28] <brion>	 mhurd: ooh good point, i never actually tested the 'not yet authed' case
[18:57:40] <brion>	 there's always something else eh
[18:57:56] <brion>	 YuviPanda|Meds: yes… probably :)
[18:58:00] <mhurd>	 brion: keeps things interesting :)
[18:58:07] <YuviPanda|Meds>	 brion: and I want to work on that :D
[18:58:29] <YuviPanda|Meds>	 brion: I want to spend some time next week to bring you up on the Android app.
[18:58:48] <YuviPanda|Meds>	 brion: or rather at least document it more
[18:59:01] <brion>	 YuviPanda|Meds: yeah
[18:59:15] <brion>	 when's your dental work?
[18:59:19] <YuviPanda|Meds>	 brion: tomorrow
[18:59:26] <brion>	 funnn
[18:59:39] <brion>	 hopefully you'll be lucid by monday :D
[18:59:45] <YuviPanda|Meds>	 hopefully, yeah
[18:59:55] <YuviPanda|Meds>	 i'm trying to not think of it too much :)
[19:00:58] <brion>	 i won't tell you stories about my wisdom tooth extraction then :)
[19:02:54] <YuviPanda|Meds>	 brion: don't! I haven't gone to a dentist in 15 years, so I don't remember anything. ALso have not looked at the wiki article either
[19:03:09] <brion>	 hehe
[19:09:08] <awjr>	 MaxSem: re https://gerrit.wikimedia.org/r/#/c/59338/2 - it's hard for me to decipher the error you got since i don't know your directory structure. was it looking for tests/phpunit/bootstrap.php in one directory too high?
[19:10:02] <MaxSem>	 my dir structure is classic: extensions in $IP/extensions
[19:10:31] <MaxSem>	 and it tried to open /home/max/Projects/tests/phpunit/bootstrap.php
[19:10:43] <MaxSem>	 should be /home/max/Projects/MediaWiki/tests/phpunit/bootstrap.php
[19:11:27] <awjr>	 yeah ok one dir too far
[19:15:27] <gerrit-wm>	 New patchset: awjrichards; "Ensures phpunit run from the makefile respects MW_INSTALL_PATH" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59338
[19:15:34] <awjr>	 does that work, MaxSem? ^
[19:38:41] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59338
[19:39:05] <mhurd>	 brion: this is sooooo useful: http://stackoverflow.com/q/7954905/135557
[19:40:25] <brion>	 mhurd: oh that sounds like WONDERFUL for debugging
[19:40:31] <mhurd>	 brion: put it in application:didFinishLaunchingWithOptions: then set a break point on the NSLog line - super cool!
[19:40:40] <brion>	 nice
[19:41:14] <mhurd>	 brion: not only see 'em but see *when* they occur and step from one to next w/continue… :)
[19:42:43] <mhurd>	 brion: used to track down UINavigationControllerDidShowViewControllerNotification, which while being descriptively named was nonetheless not something i'd committed to memory
[19:43:06] <brion>	 \o/
[19:46:21] <awjr>	 damn it i've been trying to submit a patchset and when i 'git review' it's trying to submit 16 previous patchsets - even though i've made this local branch off of current head of master
[19:46:22] <awjr>	 wtf
[19:46:31] <ori-l>	 git fetch gerrit
[19:46:36] <ori-l>	 maybe you have two remotes, origin and gerrit
[19:46:47] <ori-l>	 and only one is up-to-date
[19:46:55] <awjr>	 o_O
[19:46:57] <brion>	 oh yeah that bug is back
[19:47:00] <brion>	 \o/
[19:47:19] <gerrit-wm>	 New patchset: awjrichards; "Renames MobileContext::getMobileHost() to getMobileHostToken()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59710
[19:47:25] <awjr>	 ori-l: you were right
[19:47:31] <awjr>	 wtf
[19:48:40] <awjr>	 ori-l: should i remove one of the dupe remotes? is one preferable over the other?
[19:49:41] <ori-l>	 i confess that i have been intending to sort this out for my own local clones for some months now, but haven't
[19:49:41] <ori-l>	 git review needs a 'gerrit' remote
[19:49:48] <ori-l>	 by default master tracks origin if you git-cloned it the usual way
[19:49:58] <ori-l>	 i think you should be able to drop origin and set master to track gerrit
[19:50:02] <ori-l>	 and live happily ever after
[19:50:04] <ori-l>	 but i haven't tried it
[19:50:12] <awjr>	 interesting - ok thanks
[19:51:09] <YuviPanda|Meds>	 awjr: I think Roan or Chad mailed to wikitech-l about this a while back
[19:51:43] <awjr>	 must've missed it :( i think this might be symptomatic of an update i did to git-review last night
[19:52:01] <YuviPanda|Meds>	 yup
[19:55:31] <brion>	 bbiab
[20:00:02] <Maryana_foodz>	 jdlrobson, story review!
[20:00:29] <awjr>	 grr
[20:14:17] <Reedy>	 Warning:  htmlspecialchars() [<a href='function.htmlspecialchars'>function.htmlspecialchars</a>]: Invalid multibyte sequence in argument in /usr/local/apache/common-local/php-1.22wmf1/extensions/MobileFrontend/includes/specials/SpecialMobileFeedback.php on line 49
[20:18:06] <MaxSem>	 I thought we disabled that crap
[20:49:51] <awjr>	 this sounds like a useful app: http://www.newsoficeland.com/home/technology/innovation/item/1124-new-app-prevents-icelanders-from-sleeping-with-their-relatives
[20:50:21] <gerrit-wm>	 New patchset: Jdlrobson; "Don't special case homepage in alpha" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722
[20:50:21] <gerrit-wm>	 New patchset: Jdlrobson; "Make homepage module run outside alpha" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59723
[20:50:23] <YuviPanda|Meds>	 awjr: yeah, I wonder if they track 'success'rates
[20:50:36] <awjr>	 hehe
[20:51:15] <awjr>	 MaxSem, Reedy we just made it impossible to find the feedback page, i think it's still otherwise active
[20:51:46] <awjr>	 http://en.m.wikipedia.org/wiki/Special:MobileFeedback
[20:52:20] <awjr>	 we could set $wgMFFeedbacLinks = array() which would essentially render that page useless
[20:53:14] <MaxSem>	 awjr, like in https://gerrit.wikimedia.org/r/#/c/59553/ ?;)
[20:55:44] <awjr>	 actually im not sure that would totally do it.
[20:56:16] <MaxSem>	 nukenukenukeit
[20:56:35] <awjr>	 maybe we should actually just get rid of the special page altogether
[21:12:43] <YuviPanda|Meds>	 tfinc: mhurd Maryana commons watchlist notice on https://commons.wikimedia.org/wiki/Special:Watchlist
[21:12:56] <YuviPanda|Meds>	 tfinc: mhurd Maryana requesting for enwiki now.
[21:13:27] <YuviPanda|Meds>	 Maryana: I think a direct link (what is there now) is okay for watchlist notice since it's going to experienced users. We can push to heather's page when we're targetting new users.
[21:18:07] <jdlrobson>	 MaxSem awjr care to review any more of minerva? Most of the changes are PHP and code review is going very slow on it - killing my momentum :(
[21:19:45] <awjr>	 yes but not right now jdlrobson
[21:25:35] <tfinc>	 YuviPanda|Meds: i'm going to share the raw meeting notes with you and then i'll mail out a summary. the notes will likely confuse you as they were pretty ad hoc
[21:25:47] <YuviPanda|Meds>	 tfinc: heh, okay!
[21:25:53] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560
[21:30:22] <YuviPanda|Meds>	 tfinc: yup, very ad hoc ;) I'll wait for the summary.
[21:38:07] <munaf>	 **super** early iteration of mobile editing UI. http://i.imgur.com/JQsHVvu.png
[21:38:22] <munaf>	 preview/save workflow forthcoming.
[21:38:25] <awjr>	 MaxSem: is there a MW way to fetch hostname? or should i just derive that from something like the URL fetched from title?
[21:38:51] <MaxSem>	 $wgServer
[21:38:58] <MaxSem>	 ah
[21:39:00] <MaxSem>	 grrr
[21:39:29] <YuviPanda|Meds>	 munaf: any news on the app icons? :)
[21:39:37] <MaxSem>	 awjr, php_uname( 'n' )
[21:40:12] <munaf>	 ios is done, android got held up by higher priority stuff but i haz not forgotten YuviPanda|Meds :-)
[21:40:16] <MaxSem>	 2 answers, depending on what you mean
[21:40:23] <YuviPanda|Meds>	 :) okay munaf :)
[21:40:52] <awjr>	 MaxSem: $wgServer could be more than just hostname right?
[21:41:01] <jdlrobson>	 this is kind of freaky: http://kgajos.eecs.harvard.edu/ag/
[21:41:03] <awjr>	 i think php_uname('n') is good
[21:41:14] <MaxSem>	 so what do you want?
[21:41:32] <awjr>	 the hostname!
[21:42:24] <awjr>	 i guess the equivalent of $_SERVER['SERVER_NAME']
[21:43:52] <munaf>	 it said i was 29 jdlrobson
[21:44:01] <jdlrobson>	 munaf: me 30.. :(
[21:44:02] <munaf>	 it lies
[21:44:04] <awjr>	 ultimately MaxSem i want to see if a user is currently using a mobile domain
[21:44:10] <YuviPanda|Meds>	 jdlrobson: it said i'm 31
[21:44:14] <jdlrobson>	 although it did say 'close to 30' :)
[21:44:17] <MaxSem>	 uname won't help
[21:44:21] <jdlrobson>	 haha YuviPanda|Meds but did you say you were on meds?
[21:44:27] <YuviPanda|Meds>	 haha :P
[21:44:31] <YuviPanda|Meds>	 that might've affected it, yeah
[21:44:38] <jdlrobson>	 haters gonna hate - https://twitter.com/Wudinstoun/status/324639488510918656
[21:44:39] <munaf>	 guess we don't play enough video games
[21:44:40] <YuviPanda|Meds>	 man i should sleep
[21:44:44] <YuviPanda|Meds>	 munaf: +1
[21:44:46] <jdlrobson>	 who wants to reply "get rid of your blackberry? :
[21:44:57] <awjr>	 oh i see php_uname() is basically just like running uname
[21:45:08] <MaxSem>	 awjr, mobile host header gets rewritten to desktop one
[21:45:15] <awjr>	 that is a good point
[21:45:24] <MaxSem>	 use MobileCOntext::shouldDisplayMobileView()
[21:45:26] <awjr>	 i should run wfParseUrl() on $title->getFullUrl(
[21:45:36] <awjr>	 no MaxSem, i need to do this inside of shouldDisplaymobileView() :p
[21:45:39] <jdlrobson>	 Maryana: btw - how would you feel about promoting dynamic sections but NOT link hijacking to beta ?
[21:45:45] <MaxSem>	 loooooooooooooooooooooooooooooooooooooooo
[21:45:46] <MaxSem>	 l
[21:45:54] <YuviPanda|Meds>	 that's a high lol
[21:45:59] <awjr>	 lulz
[21:56:53] <jdlrobson>	 YuviPanda|Meds: https://twitter.com/rakugojon/status/324640194114514945
[22:08:34] <MaxSem>	 jdlrobson, +1:)
[22:10:37] <Maryana>	 jdlrobson, is there a better technical term for "link hijacking"?
[22:11:03] <Maryana>	 https://mingle.corp.wikimedia.org/projects/mobile/cards/498
[22:13:57] <Maryana>	 ok, i'm going to work w/vibha on copy for the copyvio messaging module - might be sporadically offline for a bit
[22:14:24] <Maryana>	 email if you need anything - my mobile is always connected :)
[22:28:43] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Stopping Wikipedia Zero X close button from overlaying elements." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/59748
[22:33:54] <gerrit-wm>	 Change abandoned: Dr0ptp4kt; "Oops, submitted to wrong remote. Will fix that in a jiffy." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/59748
[22:36:34] <awjr>	 MaxSem: it seems that within the phpunit tests, MobileContext::singleton()->getTitle() will return null… im having a hard time figuring out how to make it return an actual title object. do you have any ideas
[22:36:35] <awjr>	 ?
[22:39:11] <MaxSem>	 create a DerivativeContext, it has setTitle(0
[22:40:59] <awjr>	 oh cool
[22:41:09] <awjr>	 actually it looks like that's already being done in MobileContextTest::setUp
[22:41:11] <awjr>	 hanks!
[22:41:12] <awjr>	 er
[22:41:13] <awjr>	 thanks!
[22:43:23] <awjr>	 oh but i can't use that since it's using FauxRequest
[22:43:40] <MaxSem>	 derive from it!
[22:45:27] <awjr>	 im actually surprised that you get setTitle() from FauxRequest...
[22:45:35] <awjr>	 s/get/can't
[22:47:18] <MaxSem>	 heyyyy. you can provide a title as a URL parameter!
[22:47:24] <MaxSem>	 oneoneone
[22:47:27] <awjr>	 that's a good idea
[22:47:38] <awjr>	 setVal( 'title', 'whatever' )
[22:47:47] <MaxSem>	 who said that context made things easier?
[22:47:53] <awjr>	 heh
[22:49:59] <MaxSem>	 mmm, no response to our request for testers
[22:50:26] <awjr>	 :(
[22:50:37] <awjr>	 it might take a coupla days
[22:50:39] <awjr>	 i guess
[22:51:31] <MaxSem>	 if people will not test the first evening after they heard about it, they will not test at all
[22:52:05] <awjr>	 you are assuming all potntial testers have heard about it :)
[22:52:59] <awjr>	 michelle mentioned to me it would likely take a few days
[22:53:07] <MaxSem>	 meh
[22:53:15] <awjr>	 but i dont really know
[22:53:34] <MaxSem>	 I wanted to flip it on a few more wikis
[22:53:53] <awjr>	 you will have your chance
[22:56:45] <awjr>	 but i agree, the wait is … hard to tolerate. im very eager to watch our cache hit ratio finally improve
[22:59:16] <awjr>	 phpunit is weird.
[23:00:33] <Ktr101>	 hey, is there any way that we could create a way so images aren't uploaded twice from the mobile app?
[23:01:03] <awjr>	 o_O
[23:01:18] <Ktr101>	 it happened last night :(
[23:01:26] <awjr>	 does it always happen?
[23:01:51] <MaxSem>	 we shouldn't ignore warnings then
[23:03:21] <Ktr101>	 no, i only remember pressing it once
[23:03:34] <Ktr101>	 i mean, uploading crashes periodically, so it could be that
[23:04:07] <awjr>	 jdlrobson: ^
[23:04:26] <jdlrobson>	 mobile app or mobile web app?
[23:05:07] <Ktr101>	 mobile commons app
[23:05:21] <awjr>	 ahha
[23:06:00] <awjr>	 mhurd: where are you guys tracking bugs/issues for the apps - particularly the commons app?
[23:07:09] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Stopping Wikipedia Zero X close button from overlaying elements." [mediawiki/extensions/ZeroRatedMobileAccess] (migrate-mfe-to-zrma) - https://gerrit.wikimedia.org/r/59757
[23:07:51] <awjr>	 Maryana: do you know where app issues are currently being reported - particularly mobile commons app?
[23:08:00] <awjr>	 Ktr101: iOS or android app?
[23:08:12] <mhurd>	 iOS: https://bugzilla.wikimedia.org/buglist.cgi?product=Commons%20App
[23:08:15] <Ktr101>	 iOS
[23:08:19] <Maryana>	 i believe yuvi added a link to mobile-feedback-l@lists.wikimedia.org
[23:08:28] <awjr>	 Ktr101: can you file a bug in bugzilla? ^^
[23:08:43] <awjr>	 additionally, mhurd might have some ideas :)
[23:09:01] <Ktr101>	 rawr
[23:10:23] <mhurd>	 ya occasionally seeing crashes as well… will try to nail down
[23:11:41] <Ktr101>	 i forgot my password
[23:11:45] <Ktr101>	 this is sad
[23:16:14] <Ktr101>	 dinner, be back later
[23:16:20] <Ktr101>	 i'll try to file a report then
[23:18:15] <awjr>	 gah
[23:18:17] <awjr>	 i hate php globals
[23:19:32] <awjr>	 we've overwritten globals all over the place in some of the unit tests :(
[23:21:49] <MaxSem>	 save in setUp(), restorein tearDown()
[23:23:03] <Maryana>	 mhurd: any word from the apple store?
[23:23:29] <mhurd>	 Maryana: not that i've heard
[23:24:12] <Maryana>	 ok. just checking :)
[23:26:22] <jdlrobson>	 MaxSem: i thought vary resources was set on mediawiki?
[23:26:28] <jdlrobson>	 (mediawiki.org)
[23:26:30] <MaxSem>	 it is
[23:26:36] <MaxSem>	 I WANT MoAR
[23:26:48] <jdlrobson>	 MaxSem: mm.. for some reason the script module doesn't seem to be running there
[23:26:52] <jdlrobson>	 works fine on test wiki
[23:27:00] <jdlrobson>	 mw.config.get( 'wgMobileDeviceName' ) > android (on test wiki)
[23:27:05] <jdlrobson>	 mw.config.get( 'wgMobileDeviceName' ) > '' (on mediawiki.org)
[23:27:14] <MaxSem>	 old cache?
[23:27:38] <jdlrobson>	 maybe.. *shrug*
[23:28:59] <awjr>	 did you try a force refresh
[23:29:14] <jdlrobson>	 awjr: of course
[23:30:35] <awjr>	 im seeing the same behavior as you jdlrobson, however i am also seeing the css resourves being varied by X-Device
[23:30:47] <MaxSem>	 maxsem@fenari:~$ mwscript eval.php mediawikiwiki
[23:30:47] <MaxSem>	 > var_dump($wgMFVaryResources);
[23:30:47] <MaxSem>	 bool(true)
[23:30:50] <awjr>	 so, $wgMFVaryResources is indeed set on mediawiki
[23:32:16] <jdlrobson>	 mm awjr doesn't get set in output here - https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.centralNotice.bannerController.mobile%7Cjquery.client%2Ccookie%2CmwExtension%7Cmediawiki.notify%2Cutil%7Cmediawiki.page.startup%7Cmobile.xdevice.detect.scripts&skin=vector&version=20130417T025000Z&*
[23:32:29] <jdlrobson>	 (grep for mw.config.set("wgMobileDeviceName",""))
[23:33:13] <MaxSem>	 jdlrobson, it's a wrong URL
[23:33:28] <jdlrobson>	 MaxSem: well that's the url that's being outputted on mediawiki.org :)
[23:33:32] <MaxSem>	 should be https://bits.wikimedia.org/m/www.mediawiki.org
[23:33:36] <MaxSem>	 grrr
[23:33:40] <awjr>	 jdlrobson: i see mw.config.set("wgMobileDeviceName","")
[23:33:45] <awjr>	 in https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.centralNotice.bannerController.mobile%7Cjquery.client,cookie,mwExtension%7Cmediawiki.notify,util%7Cmediawiki.page.startup%7Cmobile.xdevice.detect.scripts&skin=vector&version=20130417T025000Z&*
[23:33:57] <MaxSem>	 cuz it has no X-Device
[23:36:41] <gerrit-wm>	 New patchset: awjrichards; "Make sure globals are not overwritten in MobileContextTest" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59765
[23:39:14] <MaxSem>	 grr
[23:53:27] <MaxSem>	 awjr, jdlrobson: https://gerrit.wikimedia.org/r/59767
[23:53:53] <awjr>	 MaxSem: earlier you said 'mobile host header gets rewritten to desktop one' - does that mean $this->getTitle()->getFullUrl() on en.m.wikipedia.org/wiki/Main_Page would actually be en.wikipedia.org/wiki/Main_Page?
[23:54:20] <MaxSem>	 yes, that's why we have getMobileUrl() everywhere
[23:54:28] <awjr>	 shit
[23:54:58] <awjr>	 i just wasted a bunch of time then
[23:55:01] <awjr>	 gah
[23:55:16] <MaxSem>	 thoughts on ^^?
[23:55:32] <awjr>	 so, is there anyway to know that we're on a mobile-specific domain in production (aside from looking at headers set by varnish, since i want to keep this as generic as possible)?
[23:55:37] <awjr>	 looking MaxSem
[23:56:12] <MaxSem>	 well, we rely on varnish...
[23:56:42] <awjr>	 bah i dont want this to be a WMF-specific hack
[23:57:42] <awjr>	 MaxSem: why run wfAdjustLoadScript() twice?
[23:57:52] <MaxSem>	 not twice
[23:58:00] <MaxSem>	 once for HTML views
[23:58:06] <MaxSem>	 once for load.php
[23:58:53] <MaxSem>	 awjr, for non-WMF usage there's $wgMFAutodetectMobileView
[23:59:20] <awjr>	 no that doesn't help either
[23:59:48] <awjr>	 i want to make it so that if someone goes to a mobile-specific domain, then they *always* get the mobile view, no matter what
[23:59:56] <MaxSem>	 allowing different domains to reach Apache = you've polluted your parser cache